| johnsom | eandersson Wow, great catch... 20 seems a bit low (Octavia and neutron use 1,000 if I remember right). Either way, I can work on this now that you figured out what was going on. Totally makes sense why it is intermittent and got better with the recent cleanup patches. | 16:20 |
|---|---|---|
| eandersson | I pushed another simple clean up semi related https://review.opendev.org/c/openstack/designate-tempest-plugin/+/797172 | 17:24 |
| johnsom | eandersson Ok. If you aren't working on the story/pagination issue, I will today. | 17:25 |
| eandersson | No worries. I actually see an issue with the commit now that I need to fix. | 17:26 |
| eandersson | So ignore it for now :D | 17:26 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate-tempest-plugin master: Properly clean up transfer requests https://review.opendev.org/c/openstack/designate-tempest-plugin/+/797172 | 19:55 |
| opendevreview | Michael Johnson proposed openstack/designate-tempest-plugin master: Fix list-all-project tests for pagination limit https://review.opendev.org/c/openstack/designate-tempest-plugin/+/797366 | 23:43 |
| johnsom | eandersson I chose the obvious path to fix that issue, set the limit query parameter to 1000 (the default max). I'm going to check if we have functional coverage for pagination. Let me know if you think we should take this further and implement paging in the tempest client. | 23:47 |
| eandersson | I was just gonna say the exact same thing | 23:49 |
| eandersson | I think that either path is fine. As long as we test (or implement tests) for pagination somewhere. | 23:50 |
| johnsom | Sigh, looks like we don't really have a pagination test anywhere, just a check that it limits results, not that the markers work. | 23:50 |
| johnsom | At least a grep for pagination only found those two. | 23:50 |
| johnsom | Ah, I found some more. | 23:51 |
| johnsom | Yeah, ok, functional covers it with _assert_paging | 23:52 |
| johnsom | https://opendev.org/openstack/designate/src/branch/master/designate/tests/test_api/test_v2/test_recordsets.py#L296 | 23:53 |
| johnsom | My patch doesn't really address the bug you opened, so I didn't link it. It's still valid, just maybe not such a burning issue. | 23:56 |
| eandersson | Yea - I mean I think your fix is fine | 23:58 |
| eandersson | I like the idea of us having inbuilt pagination, but honestly don't really super care :D | 23:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!