| *** lxkong <lxkong!~uid83407@id-83407.stonehaven.irccloud.com> has quit IRC (Quit: Connection closed for inactivity) | 03:52 | |
| opendevreview | Arkady Shtempler proposed openstack/designate-tempest-plugin master: Fix for "PTR" tests suite and skipping "Recordset" test https://review.opendev.org/c/openstack/designate-tempest-plugin/+/794708 | 09:20 |
|---|---|---|
| *** lxkong <lxkong!uid83407@id-83407.stonehaven.irccloud.com> has joined #openstack-dns | 11:14 | |
| *** lxkong <lxkong!uid83407@id-83407.stonehaven.irccloud.com> has quit IRC (Quit: Connection closed for inactivity) | 14:02 | |
| *** lxkong <lxkong!uid83407@id-83407.stonehaven.irccloud.com> has joined #openstack-dns | 22:53 | |
| eandersson | johnsom I saw the bug comment, but not sure I understand the issue. Is it that it just never honors the header and only works depending on what zones exist at the time? | 23:10 |
| eandersson | I am just a little confused why it didn't show up when the test was first added. | 23:12 |
| johnsom | eandersson I'm tearing apart a washing machine at the moment, so can't chat, but yes, I think so. I think there was another issue with a another test not cleaning up correctly that in combination allowed it to pass sometimes | 23:13 |
| eandersson | Haha no hurry! | 23:13 |
| eandersson | Oh I see the bug | 23:14 |
| eandersson | > if request.headers.get('X-Auth-All-Projects'): | 23:14 |
| eandersson | This is case sensative | 23:14 |
| eandersson | But all tests are lower case | 23:15 |
| eandersson | > headers={'x-auth-all-projects': True}) | 23:15 |
| eandersson | unless headers.get is some sort of magical get :D | 23:16 |
| eandersson | *use lower case | 23:17 |
| johnsom | I think that call just is ignoring the all-projects header all together. I don't think it makes it down to the list methods. | 23:27 |
| johnsom | I planned to work on it on Monday | 23:27 |
| johnsom | Today, I need to figure out why the washer failed to drain. lol | 23:28 |
| eandersson | I mean even if it did it wouldn’t work since it is case sensitive | 23:29 |
| eandersson | Haha | 23:29 |
| eandersson | I'll throw up a quick PR | 23:30 |
| eandersson | Easy enough to very | 23:30 |
| eandersson | *verify | 23:31 |
| johnsom | Ok, cool, thanks | 23:35 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: [DNM] Testing https://review.opendev.org/c/openstack/designate/+/796167 | 23:38 |
| eandersson | I am full of typos today, couldn't even write matched apparently and wrote Marched. :D | 23:39 |
| eandersson | I guess I am marching into action? | 23:39 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate-tempest-plugin master: Headers are case-sensative https://review.opendev.org/c/openstack/designate-tempest-plugin/+/796168 | 23:51 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!