| eandersson | frickler will try to take a look tonight | 00:35 |
|---|---|---|
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Stop setting version specific basepython binaries https://review.opendev.org/706504 | 00:45 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Stop setting version specific basepython binaries https://review.opendev.org/706504 | 01:09 |
| eandersson | frickler the mock version was too old, bumped it to 3.0.0 min | 01:11 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Stop setting version specific basepython binaries https://review.opendev.org/706504 | 01:11 |
| eandersson | frickler, mugsie pretty sure there is a race condition in how serial are updated on dns changes | 01:14 |
| eandersson | When two records are created at the same time, sometimes the serial is only bumped for one of them | 01:15 |
| eandersson | which means that everything will look good, but possible that only one of the records get AXFR'd since designate thinks that everything is good | 01:16 |
| eandersson | but the second record only gets replicated the next time the serial gets bumped | 01:17 |
| eandersson | axfr against the target servers shows the same serial as designate | 01:17 |
| eandersson | but the actual content is different | 01:17 |
| eandersson | I don't have an idea on how to fix this, besides maybe adding a coordinator to this so that the worker can only update one zone at a time? | 01:17 |
| eandersson | I am thinking that maybe this call here can override another actions call | 05:04 |
| eandersson | https://github.com/openstack/designate/blob/master/designate/worker/tasks/zone.py#L513 | 05:04 |
| eandersson | Unless I am missing something I don't understand what could prevent a potential race condition here | 05:05 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: [WIP] Adding distributed locking to inc zone serial https://review.opendev.org/717955 | 05:40 |
| *** ircuser-1 has quit IRC | 06:07 | |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: [WIP] Adding distributed locking to inc zone serial https://review.opendev.org/717955 | 06:13 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: [WIP] Adding distributed locking to inc zone serial https://review.opendev.org/717955 | 06:16 |
| openstackgerrit | Merged openstack/designate master: Stop setting version specific basepython binaries https://review.opendev.org/706504 | 07:36 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: [WIP] Adding distributed locking to inc zone serial https://review.opendev.org/717955 | 08:09 |
| eandersson | Testing your idea frickler with replacing the top lock | 08:45 |
| eandersson | Test 1 good | 08:47 |
| eandersson | Test 2 good | 08:47 |
| eandersson | Never had two successful runs in a row :D | 08:48 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Adding distributed locking to central https://review.opendev.org/717955 | 08:52 |
| eandersson | Yea that worked. Thanks frickler | 08:52 |
| frickler | \o/ | 09:03 |
| eandersson | This for sure fixes the race condition. | 09:04 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Adding distributed locking to central https://review.opendev.org/717955 | 09:20 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Adding distributed locking to central https://review.opendev.org/717955 | 09:20 |
| *** njohnston has quit IRC | 11:18 | |
| *** njohnston has joined #openstack-dns | 12:59 | |
| *** njohnston has quit IRC | 14:24 | |
| *** njohnston has joined #openstack-dns | 14:34 | |
| *** ircuser-1 has joined #openstack-dns | 15:11 | |
| openstackgerrit | Jens Harbott (frickler) proposed openstack/designate master: DNM: test fix coordination lock use https://review.opendev.org/718146 | 15:13 |
| frickler | eandersson: ^^ waiting for test results before merging into your patch, feel free to adapt | 15:14 |
| openstackgerrit | Merged openstack/python-designateclient master: Cleanup py27 support https://review.opendev.org/717454 | 17:23 |
| frickler | eandersson: hmm, weird, checks on 718146 have all passed, but I'm seeing a couple of failures when running tox-py36 locally, possibly we need to add some more mocking | 18:49 |
| eandersson | frickler do you have a config set up? | 19:38 |
| eandersson | e.g. /etc/designate/designate.conf or even in <repo>/etc/designate/designate.conf | 19:38 |
| eandersson | because I had the same scare until I realized that I had designate configured locally and it was trying to use that config for some reason | 19:38 |
| frickler | ah, good point, yes that is a devstack host indeed. guess we still should get that fixed if we can | 19:42 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Adding distributed locking to central https://review.opendev.org/717955 | 20:28 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Adding distributed locking to central https://review.opendev.org/717955 | 20:28 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Adding distributed locking to central https://review.opendev.org/717955 | 22:29 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!