Thursday, 2016-03-31

« Wednesday, 2016-03-30 Index Friday, 2016-04-01 »
*** fawadkhaliq has quit IRC00:06
*** fawadkhaliq has joined #openstack-dns00:07
*** johnbelamaric has joined #openstack-dns00:08
*** fawadkhaliq has quit IRC00:13
*** fawadkhaliq has joined #openstack-dns00:16
*** fawadkhaliq has quit IRC00:21
*** fawadkhaliq has joined #openstack-dns00:23
*** _shaps_ has joined #openstack-dns00:38
*** ducttape_ has joined #openstack-dns00:39
*** johnbelamaric has left #openstack-dns00:39
*** _shaps_ has quit IRC00:42
*** ducttape_ has quit IRC00:50
*** kei_yama has quit IRC01:01
*** kei_yama has joined #openstack-dns01:01
*** ducttape_ has joined #openstack-dns01:04
*** ducttape_ has quit IRC01:09
*** bpokorny_ has joined #openstack-dns01:12
*** fawadkhaliq has quit IRC01:14
*** fawadkhaliq has joined #openstack-dns01:14
*** bpokorny has quit IRC01:15
*** EricGonc_ has joined #openstack-dns01:16
*** bpokorny_ has quit IRC01:16
*** EricGonczer_ has quit IRC01:19
*** fawadkhaliq has quit IRC01:20
*** fawadkhaliq has joined #openstack-dns01:23
*** fawadkhaliq has quit IRC01:24
*** fawadkhaliq has joined #openstack-dns01:25
*** fawadkhaliq has quit IRC01:27
*** rudrajit has joined #openstack-dns01:33
*** rudrajit has quit IRC01:33
*** rudrajit has joined #openstack-dns01:38
*** EricGonc_ has quit IRC01:41
*** ducttape_ has joined #openstack-dns01:49
*** stanzgy has joined #openstack-dns01:59
*** ducttape_ has quit IRC02:02
*** ducttape_ has joined #openstack-dns02:03
*** kei_yama has quit IRC02:06
*** kei_yama has joined #openstack-dns02:06
*** ducttape_ has quit IRC02:08
*** richm has quit IRC02:13
*** bpokorny has joined #openstack-dns02:32
*** _shaps_ has joined #openstack-dns02:53
*** _shaps_ has quit IRC02:58
*** bpokorny has quit IRC03:01
*** fawadkhaliq has joined #openstack-dns03:08
*** simonmcc_ has joined #openstack-dns03:26
*** fawadkhaliq has quit IRC03:26
*** fawadkhaliq has joined #openstack-dns03:26
*** rudrajit has quit IRC03:28
*** rudrajit has joined #openstack-dns03:29
*** pfreund_ has joined #openstack-dns03:29
*** krotscheck has joined #openstack-dns03:30
*** fawadkhaliq has quit IRC03:32
*** fawadkhaliq has joined #openstack-dns03:32
*** simonmcc has quit IRC03:32
*** dougwig has quit IRC03:32
*** krotscheck_dcm has quit IRC03:32
*** pfreund has quit IRC03:32
*** andrewbogott has quit IRC03:33
*** serverascode has quit IRC03:33
*** adreznec has quit IRC03:33
*** amitry has quit IRC03:33
*** simonmcc_ is now known as simonmcc03:33
*** adreznec has joined #openstack-dns03:34
*** pfreund_ is now known as pfreund03:35
*** andrewbogott has joined #openstack-dns03:38
*** dougwig has joined #openstack-dns03:38
*** amitry has joined #openstack-dns03:38
*** bpokorny has joined #openstack-dns03:40
*** serverascode has joined #openstack-dns03:41
*** fawadkhaliq has quit IRC03:58
*** fawadkhaliq has joined #openstack-dns03:59
*** fawadkhaliq has quit IRC04:00
*** fawadkhaliq has joined #openstack-dns04:01
*** fawadkhaliq has quit IRC04:02
*** fawadkhaliq has joined #openstack-dns04:02
*** bpokorny has quit IRC04:08
*** bpokorny has joined #openstack-dns04:24
*** fawadkhaliq has quit IRC04:29
*** fawadkhaliq has joined #openstack-dns04:30
*** bpokorny has quit IRC04:47
*** fawadkhaliq has quit IRC05:15
*** fawadkhaliq has joined #openstack-dns05:16
*** johnbelamaric has joined #openstack-dns05:31
*** johnbelamaric has left #openstack-dns05:31
*** fawadkhaliq has quit IRC05:37
*** fawadkhaliq has joined #openstack-dns05:39
*** rudrajit has quit IRC05:44
*** rudrajit has joined #openstack-dns05:44
*** nyechiel_ has joined #openstack-dns05:46
*** rudrajit has quit IRC05:49
*** pcaruana has quit IRC05:49
*** nyechiel_ has quit IRC05:54
*** fawadkhaliq has quit IRC05:59
*** fawadkhaliq has joined #openstack-dns06:00
*** fawadkhaliq has quit IRC06:04
*** fawadkhaliq has joined #openstack-dns06:08
*** Alex_Stef has joined #openstack-dns06:10
*** fawadkhaliq has quit IRC06:19
*** fawadkhaliq has joined #openstack-dns06:19
*** fawadkhaliq has quit IRC06:48
*** fawadkhaliq has joined #openstack-dns06:49
*** _shaps_ has joined #openstack-dns07:19
*** _shaps_ has quit IRC07:21
*** _shaps_ has joined #openstack-dns07:22
*** pcaruana has joined #openstack-dns07:41
*** fawadkhaliq has quit IRC07:59
*** jordanP has joined #openstack-dns08:01
*** fawadkhaliq has joined #openstack-dns08:01
*** fawadkhaliq has quit IRC08:03
*** fawadkhaliq has joined #openstack-dns08:04
*** nyechiel_ has joined #openstack-dns08:08
*** fawadkhaliq has quit IRC08:37
*** kei_yama has quit IRC08:38
*** fawadkhaliq has joined #openstack-dns08:40
*** fawadkhaliq has quit IRC09:05
*** fawadkhaliq has joined #openstack-dns09:09
*** fawadkhaliq has quit IRC09:25
*** fawadkhaliq has joined #openstack-dns09:26
*** fawadkhaliq has quit IRC09:41
*** fawadkhaliq has joined #openstack-dns09:42
*** fawadkhaliq has quit IRC09:44
*** fawadkhaliq has joined #openstack-dns09:50
*** fawadkhaliq has quit IRC10:09
*** fawadkhaliq has joined #openstack-dns10:10
*** fawadkhaliq has quit IRC10:18
*** fawadkhaliq has joined #openstack-dns10:19
*** fawadkhaliq has quit IRC10:25
*** fawadkhaliq has joined #openstack-dns10:39
*** fawadkhaliq has quit IRC10:49
*** km has quit IRC11:15
*** adreznec has quit IRC11:22
*** lkoranda has quit IRC11:22
*** dhellmann has quit IRC11:22
*** dhellmann_ has joined #openstack-dns11:22
*** adreznec has joined #openstack-dns11:23
*** lkoranda has joined #openstack-dns11:23
*** dhellmann_ is now known as dhellmann11:26
*** nyechiel has joined #openstack-dns12:04
*** nyechiel_ has quit IRC12:04
*** EricGonczer_ has joined #openstack-dns12:12
*** ducttape_ has joined #openstack-dns12:16
*** stanzgy has quit IRC12:19
*** ducttape_ has quit IRC12:33
*** rsyed_away is now known as rsyed12:43
*** penick has quit IRC12:57
*** penick has joined #openstack-dns13:13
*** richm has joined #openstack-dns13:14
openstackgerritKiall Mac Innes proposed openstack/designate: Run the cli functional tests in openstack ci  https://review.openstack.org/29844113:20
openstackgerritKiall Mac Innes proposed openstack/designate: Adding v2 namespaced event to zone manager  https://review.openstack.org/28016013:23
*** lkoranda has quit IRC13:25
openstackgerritGraham Hayes proposed openstack/designate: Docs update  https://review.openstack.org/29551113:43
openstackgerritGraham Hayes proposed openstack/designate: Move to OpenStack Docs theme  https://review.openstack.org/29994013:43
openstackgerritGraham Hayes proposed openstack/designate: Roll up migrations to start from liberty.  https://review.openstack.org/29994213:48
*** ducttape_ has joined #openstack-dns13:57
openstackgerritMerged openstack/python-designateclient: Fix an issue causing a blacklist test to fail  https://review.openstack.org/29946914:02
*** mlavalle has joined #openstack-dns14:06
*** penick has quit IRC14:07
openstackgerritMerged openstack/python-designateclient: Show responses on zone and recordset deletes  https://review.openstack.org/29953014:12
*** pglass has joined #openstack-dns14:23
*** lkoranda has joined #openstack-dns14:31
openstackgerritMerged openstack/designate: Run the cli functional tests in openstack ci  https://review.openstack.org/29844114:41
rsyedwould i need a core to "recheck no bug" or whatever to get the gates to run again for https://review.openstack.org/#/c/297477/ ?14:42
*** nyechiel has quit IRC14:42
*** nyechiel has joined #openstack-dns14:43
rsyed(given that https://review.openstack.org/298441 just merged)14:43
elarsonrsyed: nope!14:43
*** andrewbogott has quit IRC14:47
*** andrewbogott has joined #openstack-dns14:47
eandersson^Any solution to the broken multi domain token support is broken in Kilo/Liberty/Mitaka yet?15:08
*** Alex_Stef has quit IRC15:09
elarsonfederico3: I get an error on my ALIAS patches b/c this patch doesn't seem to happen https://github.com/openstack/designate/blob/master/designate/tests/test_zone_manager/test_tasks.py#L11315:10
elarsonI'm curious what the advantages are of fixtures MockPatch vs. just using patch?15:10
rsyedelarson nothing happened!  https://review.openstack.org/#/c/29747715:10
rsyedi feel like this: https://www.youtube.com/watch?v=HuGIgf-ICHM15:10
pglassrsyed: it takes a bit for it to pick it up, I think15:11
rsyedcool, thanks pglass!15:11
federico3elarson: undoing the patching where needed15:11
elarsonfederico3: using patch as a context manage does that as well thought, right?15:12
elarsonunless I'm missing something15:12
federico3yes15:12
pglassrsyed: you can check zuul too http://status.openstack.org/zuul/ it lets you filter on the review number15:12
pglassyours is in a queue15:12
federico3(but you can't always use it as a context manager)15:12
rsyedis that a ghostbusters reference15:12
rsyed(TIL, thanks)15:13
elarsonfederico3: really? do you have an example?15:13
federico3elarson: when you want to set up a mock during setUp and remove it inside tearDown15:13
elarsonfair enough15:13
federico3[unlike py.test mocking...]15:14
elarsonyou know the bummer about that and unittest is that if there is a failure in setUp teardown doesn't get called at all and you only have access the class no t the instance15:14
elarsonman seriously15:14
elarsonpy.test setup/teardown behavior is much nicer IMHO15:15
federico3and the side-effect might lead to false-positive tests, as it happened15:15
federico3yep15:15
Kiallwell, I believe self.useFixture(foo) will execute during the cleanup, now teardown...15:17
Kiallbut - if your using patch as a context manager or decorator, makes zero difference.15:18
Kialltimsim: if yer around - https://review.openstack.org/#/q/status:open+project:openstack/designate+branch:stable/mitaka+topic:designate-mitaka-backports15:21
eandersson^Kiall: Looking into your broken multi domain token support at the moment.15:21
eandersson^It's impossible to use designate if you have multi domain set up.15:22
KiallKeystone multi domain? Really? I've seen it work in that scenario?15:22
eandersson^Not sure how15:22
eandersson^The only way it would work would be if you sent this15:22
eandersson^designate --os-project-name=my_lab domain-list15:22
eandersson^but that will fail with15:22
eandersson^ERROR: Authentication cannot be scoped to multiple targets. Pick one of: project, domain, trust or unscoped15:22
eandersson^so you need to unset the domain15:23
KiallSo, you're using a domain scoped token?15:23
eandersson^Yes15:23
Kiallrather than a project scoped (which belongs to a domain) token15:23
eandersson^In this case yea, as I am trying to perform this as an admin.15:23
KiallAh.. Right, that's unsupported and a rather large change to make work (if that's even desired)15:23
eandersson^I'll test a project scoped token15:24
Kialle.g. nova list with that same token, I'm betting you get nothing back (but it's been a while)15:24
*** bpokorny has joined #openstack-dns15:24
eandersson^Nova list works fine15:24
KiallThe issue is, with a domain scoped token - we know the domain ID, but not the Nx projects within the domain. So we can't show you anything meaningful15:24
KiallDoes it show the instances for all projects within the domain?15:25
eandersson^The only cli not working is Designate15:25
eandersson^hmm although we might be using the openstack client for nova15:25
eandersson^so maybe you are right15:25
mugsieeandersson^: try "openstack zone list" if you have the v2 API + a newer version of designate client15:26
eandersson^enabling it now15:26
pglasselarson: the addCleanups() you do in the fixture setUp get called even if there's a subsequent exception in either the fixture setup or the test setup15:26
pglassbut the tearDown() will not get called.15:27
*** bpokorny has quit IRC15:28
eandersson^mugsie: That does indeed work15:28
eandersson^So I'll enable v2 and just use the openstack client then15:28
eandersson^:D15:28
mugsiewhat zones does it show?15:29
eandersson^It shows my domain15:29
elarsonpglass: yeah, I'm just confused as to what the extra lib is bringing to the table in my case. the code hasn't changed and the pool manager api hasn't been patched, so tracking it down has meant digging into fixtures which I hadn't really looked at before. it has brought up my dislike of unittest when compared to pytest and federico3 is a fellow pytest sympathizer :P15:29
elarsonignore my whining!15:29
eandersson^It does indeed not work with the domain scoped token, but it does with the project scoped token15:30
eandersson^which is fine15:30
eandersson^which makes sense15:30
*** bpokorny has joined #openstack-dns15:30
mugsieelarson: what I got from that was "I am just confused .... ignore my whining"15:30
federico3elarson: wait until I post my next CR, I had to fight testr quite a bit :-/15:30
pglassi'm not a big fan of those fixtures15:30
* mugsie makes a not too ignore the next review from elarson :P15:30
pglassat least the ones i made in the functionaltests15:30
mugsiea note*15:30
eandersson^btw only have one domain int his env15:31
mugsieok#15:31
eandersson^so it only shows that one zone15:31
elarsonmugsie: :)15:31
eandersson^at least with openstack client and v2 we can bypass the ugly hack we had in place15:32
* mugsie needs to add projects + domains + hiriarchical projects to his reading list for newton15:32
mugsiemake sure you have designateclient > 2.0.0 if you use openstack client15:32
mugsieit was there in 1.5.0 with ... issues15:32
eandersson^Yea, will need to figure out how to approach that.15:32
elarsonmugsie: I just read that really as you were adding things to your newtwon ;)15:32
mugsie(like never showing more than 20 records)15:33
eandersson^hmm only got 1.5.1 :(15:33
mugsie2.0.0 get released about 2 months ago15:35
elarsonfederico3: do you need this fixture https://github.com/openstack/designate/blob/master/designate/tests/fixtures.py#L158 when testing the deleted zone purge test? https://github.com/openstack/designate/blob/master/designate/tests/test_zone_manager/test_tasks.py#L4515:36
mugsie2.1.0 was released last night15:36
elarsondoes that partition bit that happens make a difference?15:36
elarsonfederico3: it looks like you could just instantiate it in setUp, set the my_partitions there and be done15:36
elarsonfederico3: btw, I'm just trying to unwind things to see why they are failing for me. looking for any implicit assumptions I might be missing15:37
*** bpokorny has quit IRC15:48
*** bpokorny has joined #openstack-dns15:48
federico3elarson: it could be moved to setUp, I guess, given that we don't seem to need any complex cleanup or anything stateful in the fixture15:49
elarsonfederico3: whoops! linked the wrong test https://github.com/openstack/designate/blob/master/designate/tests/test_zone_manager/test_tasks.py#L12115:52
elarsonthere the self.generate_delayed_notify_task_fixture is the one I was thinking of15:52
Kialltimsim / elarson / mugsie: https://review.openstack.org/#/c/280160/15:53
Kiall(I made changes to it, so can't really +2 myself)15:53
*** ccneill has joined #openstack-dns15:53
KiallI'd call it a mitaka candidate too15:53
elarsonKiall: it is good to know that if you could +2 yourself, you would :)15:53
KiallI can +A it myself, I won't ;)15:54
mugsieKiall: that is a mitaka candiate - can you push the backport15:55
Kialldone15:55
Kiallhttps://review.openstack.org/#/c/300048/115:56
Kiallhttps://review.openstack.org/#/c/300048/115:56
elarsonKiall: hope you don't mind my comment regarding adding a comment.16:06
*** james_li has joined #openstack-dns16:06
Kiallmeta16:06
Kialllol16:06
federico3elarson: same pattern - have you tried not using the fixtures?16:06
Kialllet me look16:06
elarsonfederico3: yeah, and I still get an error, which is good! it means they aren't broken and I'm misunderstanding them16:07
mugsietimsim: around?16:07
KiallNot sure i follow elarson, we want to ensure that at least 1 of the N calls to notifier.info contains each of the 2 sets of arguments.16:08
*** pcaruana has quit IRC16:08
elarsonKiall: the two things that would be good clarify are 1) why do we have a zone and domain and 2) that both should be called for each zone.16:09
timsimo/16:10
KiallAh, compatibility .. this is an "API" between us an e.g. ceilometer etc. We can't just change it, we have to move from 1 to the other over time. I'll add that comment.16:10
rsyedhey pglass i forgot: in your change to enable the CLI functionaltests, they were added to the post-test hook for the devstack gate.  meaning rechecking my CLI change wouldn't have triggered those tests (they don't apply to CLI gates)16:10
pglassrsyed: the devstack gate in python-designateclient should be identical to one in the designate gate16:11
pglassi think16:11
Kiallthey are identical16:11
rsyedcool, thanks for the clarification16:11
openstackgerritKiall Mac Innes proposed openstack/designate: Adding v2 namespaced event to zone manager  https://review.openstack.org/28016016:12
Kiallmugsie / elarson: updated with a comment explaing the 2 event16:12
Kialls16:12
elarsonbadoosh!16:12
mugsietimsim: https://review.openstack.org/#/q/status:open+project:openstack/designate+branch:stable/mitaka+topic:designate-mitaka-backports16:13
mugsie+ https://review.openstack.org/#/c/300048/216:13
mugsieelarson: if you could review these as well, so we can gte your stable review stats up so I can get you added to our list of stable reviewers16:14
elarsonwill do!16:14
elarsonmugsie: I was able to +2 https://review.openstack.org/c/299960 timsim had already workflowed that change, but just a fyi16:16
mugsieah, stable mitaka has different rules it seems16:18
KiallWhich review is that? (url invalid ;))16:18
*** rudrajit has joined #openstack-dns16:18
mugsiehttps://github.com/openstack-infra/project-config/blob/master/gerrit/acls/openstack/designate.config#L19-L3316:18
mugsieKiall: stick a #/ in front of the c/16:18
mugsiehttps://review.openstack.org/#/c/29996016:18
Kialleffort :P16:18
*** fawadkhaliq has joined #openstack-dns16:19
elarsonKiall: my web browser reloads does a redirect for me16:19
Kialllies :P16:19
elarsonand it is in emacs... so...16:19
elarsonok, that is not true ;)16:19
mugsieelarson: did you see you can now run emacs on Windows 10 :P16:20
Kiallmugsie: he's been running windows in emacs for years ;)16:20
mugsiemy favorite line from the demo is "and of course I have no idea how to close emacs, so I am just going to close the terminal window"16:21
Kiall^ loved that one too ;)16:21
elarsonmugsie: haha, I didn't see the demo. did that really happen?16:21
mugsieyeah16:22
*** lkoranda has quit IRC16:22
mugsieit was great :)16:23
mugsieI saw a comment somehwere that "its easy to close emacs - you just M+x reboot"16:23
mugsie(or whatever the shell macro is in emacs)16:24
elarsonlol, that is awesome :016:25
elarson:)16:26
*** lkoranda has joined #openstack-dns16:29
*** rudrajit has quit IRC16:32
*** penick has joined #openstack-dns16:34
*** fawadkhaliq has quit IRC16:36
*** fawadkhaliq has joined #openstack-dns16:37
*** _shaps_ has quit IRC16:38
*** fawadkhaliq has quit IRC16:41
*** fawadkhaliq has joined #openstack-dns16:41
*** nyechiel has quit IRC16:48
*** rsyed is now known as rsyed_away16:48
*** nyechiel has joined #openstack-dns16:56
mugsiehttps://hangouts.google.com/hangouts/_/managedit.ie/austinplanningmeetup Kiall timsim elarson mlavalle16:58
*** lkoranda has quit IRC16:58
* timsim untangles his headphones17:00
* elarson puts on his wizard hat17:01
mugsiehttps://docs.google.com/presentation/d/1xQ4cJ1rDZlVwnL1RwYE5Arvv9sbTKMRW3Tu6zQZEeHc/edit?usp=sharing17:04
*** james_li has quit IRC17:11
*** lkoranda has joined #openstack-dns17:14
*** rudrajit has joined #openstack-dns17:15
*** penick has quit IRC17:21
*** penick has joined #openstack-dns17:27
*** fawadkhaliq has quit IRC17:28
*** fawadkhaliq has joined #openstack-dns17:30
*** ccneill has quit IRC17:33
*** ccneill has joined #openstack-dns17:35
*** ducttape_ has quit IRC17:39
*** rsyed_away is now known as rsyed17:40
openstackgerritFederico Ceratto proposed openstack/designate: WIP Move unit and functional testing to MySQL  https://review.openstack.org/30011217:41
*** rudrajit_ has joined #openstack-dns17:44
*** nyechiel has quit IRC17:45
*** fawadkhaliq has quit IRC17:46
*** fawadkhaliq has joined #openstack-dns17:46
*** rudrajit has quit IRC17:47
*** fawadkhaliq has quit IRC17:47
*** fawadkhaliq has joined #openstack-dns17:47
-openstackstatus- NOTICE: Job failures for missing traceroute packages are in the process of being fixed now, ETA 30 minutes to effectiveness for new jobs17:47
*** fawadkhaliq has quit IRC17:47
*** fawadkhaliq has joined #openstack-dns17:48
*** fawadkhaliq has quit IRC17:48
*** fawadkhaliq has joined #openstack-dns17:49
*** fawadkhaliq has quit IRC17:50
*** ducttape_ has joined #openstack-dns17:50
*** fawadkhaliq has joined #openstack-dns17:50
*** fawadk has joined #openstack-dns18:06
*** fawadkhaliq has quit IRC18:07
*** fawadk has quit IRC18:09
*** jasonsb has joined #openstack-dns18:10
*** jasonsb has quit IRC18:13
*** nyechiel has joined #openstack-dns18:18
*** james_li has joined #openstack-dns18:19
*** bpokorny has quit IRC18:24
*** penick has quit IRC18:27
*** fawadkhaliq has joined #openstack-dns18:29
*** nyechiel has quit IRC18:34
*** bpokorny has joined #openstack-dns18:40
*** bpokorny has quit IRC18:40
*** bpokorny has joined #openstack-dns18:41
*** nyechiel has joined #openstack-dns18:47
*** rudrajit_ has quit IRC18:49
*** rudrajit has joined #openstack-dns18:49
*** nyechiel has quit IRC18:52
*** nkinder has joined #openstack-dns18:58
*** jordanP has quit IRC19:00
*** openstackgerrit has quit IRC19:03
*** openstackgerrit has joined #openstack-dns19:04
*** ChanServ sets mode: +v openstackgerrit19:04
*** penick has joined #openstack-dns19:06
*** penick has quit IRC19:07
*** penick has joined #openstack-dns19:14
*** nkinder has quit IRC19:15
*** penick has quit IRC19:16
-openstackstatus- NOTICE: Any jobs which erroneously failed on missing traceroute packages should be safe to recheck now19:54
*** penick has joined #openstack-dns20:25
*** fawadkhaliq has quit IRC20:27
*** fawadkhaliq has joined #openstack-dns20:27
*** bpokorny has quit IRC20:32
*** bpokorny has joined #openstack-dns20:34
elarsonpglass: do you know of a way to ignore the pythonlogging capture when running a test with tox?20:35
elarsonrunning a single test seems to be missing some setup bits that make it fail loading the config so I've been stuck with tox -e py27 mod.path.to.test and ther e is a massive log I have to try to hop around in20:35
pglassnope20:40
elarsonbummer :(20:40
pglassi haven't really run those unittests20:40
pglasselarson: you can try `export OS_LOG_CAPTURE=0`20:41
*** fawadkhaliq has quit IRC20:42
* elarson double checks if that is what he did20:42
* elarson tried -120:43
elarsontrying 0 now20:43
pglassalthough you might need to add a `passenv = OS_LOG_CAPTURE` in tox.ini20:43
pglassit looks like20:43
elarsonpglass: isn't that already there?20:43
* elarson checks20:43
pglassit's not for the `[testenv]` block20:44
pglassit is for the functional tests20:44
*** fawadkhaliq has joined #openstack-dns20:45
pglassalthough I don't actually know what picks up on that variable20:46
elarsonyeah, just noticed that20:46
Kiallif OS_LOG_CAPTURE is missing from the passenv, we should add it20:58
Kiall(and there are others like it too...)20:58
Kiallhttps://github.com/openstack/oslotest/blob/master/oslotest/base.py#L3520:58
pglassso `OS_LOG_CAPTURE=0` will get rid of the pythonlogging bit, but you'll still get stderr printing stuff21:00
elarsonpglass: really? that didn't work for me21:01
* elarson keeps trying21:01
pglasselarson: on the one test case I was checking (designate.tests.unit.test_central.test_basic.CentralServiceTestCase.test_create_zone_forbidden), it would no longer say "captured pythonlogging" or whatever, but all the same logs would get printed to stderr21:02
KiallRight, when you don't capture the logs, the end up on stderr, which can also silence with OS_STDERR_CAPTURE=0 - now, if that causes them to end up on the real stderr, you can redirect to /dev/null21:03
KiallThough, I think I've just learned to live with all the logs.21:04
*** rsyed is now known as rsyed_away21:04
elarsongeez21:05
Kiallwith a real shell, it's reasonable to deal with them.. with a poor text editor like emacs, it must be harder :D21:06
elarsonholy crapola... are you serious Kiall. OMG21:06
pglassyeah, that works.21:07
pglassexport OS_LOG_CAPTURE=021:07
pglassexport OS_STDERR_CAPTURE=021:07
pglasstox -e py27 -- designate.tests.unit.test_central.test_basic.CentralServiceTestCase.test_create_zone_forbidden 2>/dev/null21:07
pglasswith the appropriate passenvs added in tox.ini21:07
elarsonyeah, doing both does the jazz21:07
elarsonyup21:07
KiallAnyway, the real moral of the story is, we shouldn't execute every line of designate code in every test ;)21:08
elarsonindeed21:08
elarsonright now I'm trying to figure out why test_generate_delayed_notify_zones is not returning the 10 delayed zones even though it confirms it they are there before actually testing the task21:09
*** jschwarz has joined #openstack-dns21:09
elarsonmy only theory is my migration screwed up something...21:09
Kiallcould the service be running and the notifies sent?21:11
Kiall(also, are our tests actually sending notifies somewhere? lol)21:11
openstackgerritMerged openstack/designate: Adding v2 namespaced event to zone manager  https://review.openstack.org/28016021:11
elarsonhmm... I don't think so ?21:11
KiallI'd say they probably are ;) But that's unrelated I gues21:12
Kialls21:12
elarsonservices are definitely not running21:14
*** nyechiel has joined #openstack-dns21:15
Kiallelarson: https://bugs.launchpad.net/designate/+bug/141171721:18
openstackLaunchpad bug 1411717 in Designate "Service Fixture in Unit Tests Does not Stop Service" [Medium,Triaged]21:18
elarsonif that is the issue I'm going to lose it21:20
mugsieelarson: Kiall they certainly used to emit notifications.... no idea if they still do21:27
* mugsie got bitten testing something a while back21:27
elarsonok, here is another one. https://gist.github.com/e5bd780310266fbe2a8418f35a3c822c21:30
elarsonthat happens if I don't run the test via tox21:30
elarsonso with unittest and py.test that happens, which suggest something doesn't get loaded before running the test21:31
elarsonby something I'm thinking it is the config...21:31
Kiallyea, we have a BUNCH of issues with running via anything but tox ;)21:32
Kiallin that case, lets see..21:32
*** EricGonc_ has joined #openstack-dns21:32
Kiallactually, no clue why that's exploding.21:34
Kiallsetting a config override shouldn't need the config option to have already been defined.21:34
Kiall(or, didn't used to require that ordering)21:34
Kialltests/__init__.py could do cfg.CONF.import_opt(...) to make sure it gets defined right after the imports in the file..21:35
*** EricGonczer_ has quit IRC21:36
*** fawadkhaliq has quit IRC21:38
*** rsyed_away is now known as rsyed21:39
*** fawadkhaliq has joined #openstack-dns21:39
*** fawadkhaliq has quit IRC21:40
*** nyechiel has quit IRC21:40
*** fawadkhaliq has joined #openstack-dns21:41
*** rsyed is now known as rsyed_away21:43
*** fawadkhaliq has quit IRC21:44
*** fawadkhaliq has joined #openstack-dns21:44
*** gord0 has joined #openstack-dns21:48
*** ccneill_ has joined #openstack-dns22:25
*** ccneill has quit IRC22:25
*** ccneill_ is now known as ccneil22:25
*** ccneil is now known as ccneill22:25
*** bpokorny_ has joined #openstack-dns22:28
*** ducttape_ has quit IRC22:30
*** bpokorny_ has quit IRC22:30
*** bpokorny_ has joined #openstack-dns22:30
*** bpokorny has quit IRC22:32
*** james_li has quit IRC22:42
*** bpokorny_ has quit IRC22:44
*** bpokorny has joined #openstack-dns22:44
*** pglass has quit IRC22:45
*** doublek has joined #openstack-dns22:56
*** penick has quit IRC22:58
*** jschwarz has quit IRC23:08
*** kei_yama has joined #openstack-dns23:26
*** km has joined #openstack-dns23:29
*** ccneill has quit IRC23:35
*** doublek has quit IRC23:37
*** bpokorny_ has joined #openstack-dns23:41
*** bpokorny has quit IRC23:41
*** bpokorny_ has quit IRC23:41
*** bpokorny has joined #openstack-dns23:42
« Wednesday, 2016-03-30 Index Friday, 2016-04-01 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!