| *** rudrajit has joined #openstack-dns | 00:34 | |
| *** boris-42 has joined #openstack-dns | 00:39 | |
| *** stanzgy has joined #openstack-dns | 01:37 | |
| *** EricGonczer_ has joined #openstack-dns | 01:57 | |
| *** rudrajit has quit IRC | 01:58 | |
| *** stanzgy has quit IRC | 02:44 | |
| *** EricGonczer_ has quit IRC | 02:50 | |
| *** sonuk has joined #openstack-dns | 02:54 | |
| *** EricGonczer_ has joined #openstack-dns | 02:59 | |
| *** EricGonczer_ has quit IRC | 02:59 | |
| *** stanzgy has joined #openstack-dns | 03:03 | |
| *** RuiChen has joined #openstack-dns | 03:20 | |
| *** richm has joined #openstack-dns | 03:32 | |
| *** EricGonczer_ has joined #openstack-dns | 03:49 | |
| *** EricGonczer_ has quit IRC | 03:53 | |
| *** km has joined #openstack-dns | 04:11 | |
| *** richm has quit IRC | 04:13 | |
| *** chlong has joined #openstack-dns | 04:52 | |
| *** km__ has joined #openstack-dns | 05:31 | |
| *** km__ is now known as Guest93711 | 05:31 | |
| *** km has quit IRC | 05:32 | |
| *** rudrajit has joined #openstack-dns | 05:39 | |
| *** chlong has quit IRC | 06:28 | |
| *** _RuiChen has joined #openstack-dns | 07:02 | |
| *** RuiChen has quit IRC | 07:05 | |
| *** Guest93711 has quit IRC | 07:15 | |
| *** km has joined #openstack-dns | 07:16 | |
| *** rudrajit has quit IRC | 07:41 | |
| *** elarson has quit IRC | 07:59 | |
| *** elarson has joined #openstack-dns | 08:05 | |
| *** nyechiel_ has joined #openstack-dns | 08:45 | |
| *** _RuiChen has quit IRC | 09:38 | |
| *** _RuiChen has joined #openstack-dns | 09:39 | |
| *** jordanP has joined #openstack-dns | 09:51 | |
| *** km has quit IRC | 10:25 | |
| *** vipul has joined #openstack-dns | 10:29 | |
| *** vipuls has quit IRC | 10:30 | |
| *** vipul has quit IRC | 10:34 | |
| *** vipul has joined #openstack-dns | 10:35 | |
| *** vipuls has joined #openstack-dns | 10:37 | |
| *** vipul has quit IRC | 10:39 | |
| *** stanzgy has quit IRC | 10:48 | |
| *** vipuls has quit IRC | 10:51 | |
| *** vipul has joined #openstack-dns | 10:51 | |
| *** naggappan has joined #openstack-dns | 10:58 | |
| *** kei_yama has quit IRC | 11:33 | |
| *** GonZoPT has quit IRC | 11:46 | |
| *** nyechiel_ has quit IRC | 12:54 | |
| *** nyechiel has joined #openstack-dns | 12:54 | |
| openstackgerrit | Ram Sateesh Talari proposed openstack/designate-specs: Added a new specification for Tenant domainID for Designate Sink https://review.openstack.org/272081 | 12:57 |
|---|---|---|
| *** ducttape_ has joined #openstack-dns | 13:09 | |
| *** ducttape_ has quit IRC | 13:26 | |
| openstackgerrit | Ram Sateesh Talari proposed openstack/designate-specs: Added a new specification for Tenant domainID for Designate Sink https://review.openstack.org/272081 | 13:28 |
| *** EricGonczer_ has joined #openstack-dns | 13:33 | |
| *** EricGonc_ has joined #openstack-dns | 13:41 | |
| *** EricGonczer_ has quit IRC | 13:45 | |
| *** EricGonc_ has quit IRC | 14:00 | |
| *** richm has joined #openstack-dns | 14:16 | |
| *** mdavidson has joined #openstack-dns | 14:29 | |
| *** GonZo2K has joined #openstack-dns | 14:29 | |
| *** johnbelamaric has joined #openstack-dns | 14:34 | |
| openstackgerrit | Ram Sateesh Talari proposed openstack/designate-specs: Added a new specification for Tenant domainID for Designate Sink https://review.openstack.org/272081 | 14:37 |
| *** rsyed_away is now known as rsyed | 14:49 | |
| *** ducttape_ has joined #openstack-dns | 15:00 | |
| *** russStarr has joined #openstack-dns | 15:11 | |
| *** mlavalle has joined #openstack-dns | 15:17 | |
| *** EricGonczer_ has joined #openstack-dns | 15:27 | |
| *** chlong has joined #openstack-dns | 15:27 | |
| *** naggappan has quit IRC | 15:28 | |
| *** EricGonc_ has joined #openstack-dns | 15:28 | |
| *** EricGonczer_ has quit IRC | 15:32 | |
| *** GonZo2K has quit IRC | 15:32 | |
| *** chlong has quit IRC | 15:40 | |
| *** chlong has joined #openstack-dns | 15:41 | |
| *** pglass has joined #openstack-dns | 15:42 | |
| *** sonuk has quit IRC | 15:43 | |
| *** chlong has quit IRC | 15:43 | |
| *** sonuk has joined #openstack-dns | 15:44 | |
| *** chlong has joined #openstack-dns | 15:44 | |
| mlavalle | mugsie: FYI, https://review.openstack.org/#/c/271578 implements completely the Nova side: https://blueprints.launchpad.net/nova/+spec/neutron-hostname-dns | 15:48 |
| *** sonuk has quit IRC | 16:02 | |
| *** chlong has quit IRC | 16:15 | |
| *** rudrajit has joined #openstack-dns | 16:15 | |
| *** chlong has joined #openstack-dns | 16:16 | |
| *** rudrajit has quit IRC | 16:20 | |
| openstackgerrit | Merged openstack/designate: Fixes wording of exceptions for delete https://review.openstack.org/271577 | 16:31 |
| openstackgerrit | Merged openstack/designate: Rename zone > domain for errors in V1 https://review.openstack.org/266382 | 16:46 |
| *** rsyed is now known as rsyed_away | 16:46 | |
| *** nyechiel has quit IRC | 16:48 | |
| *** rsyed_away is now known as rsyed | 16:50 | |
| *** bpokorny has joined #openstack-dns | 16:50 | |
| *** ccneill has joined #openstack-dns | 16:52 | |
| *** chlong has quit IRC | 17:02 | |
| *** chlong has joined #openstack-dns | 17:03 | |
| *** james_li has joined #openstack-dns | 17:03 | |
| *** chlong has quit IRC | 17:04 | |
| *** chlong has joined #openstack-dns | 17:05 | |
| *** jordanP has quit IRC | 17:16 | |
| *** EricGonc_ has quit IRC | 17:20 | |
| *** EricGonczer_ has joined #openstack-dns | 17:22 | |
| *** jmcbride has joined #openstack-dns | 17:22 | |
| *** rudrajit has joined #openstack-dns | 17:25 | |
| *** rudrajit has quit IRC | 17:25 | |
| *** rudrajit has joined #openstack-dns | 17:26 | |
| *** EricGonczer_ has quit IRC | 17:38 | |
| *** EricGonc_ has joined #openstack-dns | 17:38 | |
| ryanpetrello | hey designate folks - has anybody encountered this error on the designate tests on HEAD? https://gist.github.com/ryanpetrello/15220947b0b03e412379 | 17:50 |
| ryanpetrello | (when running tox -epy27) | 17:51 |
| rsyed | hey ryanpetrello i did observe that very recently as well. haven't had a chance to dig into it yet | 17:51 |
| ryanpetrello | okay :/ | 17:52 |
| ryanpetrello | running tests again on my end to see if it happens every time | 17:52 |
| ryanpetrello | if so, I'll probably remove designate's tests from pecan's gating until it's resolved | 17:52 |
| rsyed | (i'm focused on a set of other tests that aren't impacted by that issue, i'm just running my subset now instead) | 17:52 |
| rsyed | oh got it, designate's failures are impactful to your work with pecan | 17:53 |
| ryanpetrello | running from a fresh checkout just to confirm I'm not doing something dumb | 17:54 |
| *** russStarr has quit IRC | 17:55 | |
| ryanpetrello | yep, `tox -epy27` seems to fail for me on a fresh clone of designate | 17:55 |
| ryanpetrello | https://bugs.launchpad.net/designate/+bug/1537853 | 18:00 |
| openstack | Launchpad bug 1537853 in Designate "py27 tox tests fail with a TypeError" [Undecided,New] | 18:00 |
| ryanpetrello | I'm going to stop gating pecan on this project for a bit | 18:00 |
| ryanpetrello | because I seem to have this problem quite regularly :/ | 18:00 |
| Kiall | ryanpetrello: I believe we've managed to introduce some non deterministic tests - somehow. We've been seeing "weird" failures which make little sense, and come + go based on $random. | 18:01 |
| ryanpetrello | yea, that's been my experience while working on pecan in the last week | 18:01 |
| ryanpetrello | I can count on designate tests to fail randomly :/ | 18:02 |
| Kiall | Sorry :'( | 18:02 |
| ryanpetrello | it's okay :), I may revisit in a few weeks | 18:02 |
| Kiall | I've not tracked a source yet, something somewhere is off in 1 test that's causing $rand in other tests as near as I can tell - but I've not dug in properly yet | 18:02 |
| ryanpetrello | for now, it's holding me up on making some pecan changes, though | 18:02 |
| Kiall | dooh, really? It's failing everytime for you? | 18:03 |
| ryanpetrello | right now it is | 18:03 |
| ryanpetrello | at least, I've run `tox -epy27` a few times in a row now and it's failed every time | 18:03 |
| ryanpetrello | (with the same error) | 18:03 |
| Kiall | from designate I guess, rather than from pecan's tox.ini? | 18:03 |
| ryanpetrello | yep | 18:03 |
| ryanpetrello | cloned a fresh designate | 18:03 |
| Kiall | Humm - thats odd, because it's passing in the gate etc most of the time | 18:05 |
| Kiall | let me see if it fails locally too.. just in case | 18:05 |
| dhellmann | Kiall : I'm seeing errors related to mocks. I | 18:08 |
| dhellmann | specifically around get_admin_context | 18:08 |
| Kiall | Yea, I'm reproducing now locally too | 18:08 |
| dhellmann | usually that means that a test mocks an object but doesn't revert that correctly | 18:08 |
| Kiall | I'm willing to bet a test is patching code without using a context manager | 18:08 |
| Kiall | Yea, digging in ;) | 18:08 |
| ryanpetrello | here's the exact error I'm seeing: https://gist.github.com/ryanpetrello/15220947b0b03e412379 | 18:08 |
| dhellmann | it can appear non-deterministic because testr splits the tests up in to different sets and runs them in different processes | 18:08 |
| dhellmann | yeah, DesignateBackendTest uses patch() and then calls .start() on the result | 18:09 |
| dhellmann | that looks like mox behavior | 18:09 |
| ryanpetrello | that'll do it :) | 18:09 |
| * Kiall glares towarads federico3 for writing the code and into a mirror for me approving it. lol | 18:10 | |
| Kiall | Yea, this looks like a total fluke it passed the check and gate queues :) | 18:12 |
| federico3 | this might explain a test that failed intermittently in the past, I'll send a patch | 18:15 |
| *** james_li has quit IRC | 18:16 | |
| Kiall | federico3: I've got a *real* quick fix I'm running though the tests a few times. Hopefully that's the only mock leaking, but will see soon. | 18:17 |
| Kiall | Assuming they pass a few goes in a row, we'll prob want to re-check all the mock usage in your new + cleaner tests to make sure there's no other leakage we're missing :) | 18:18 |
| Kiall | damn - it's not the only place ;) | 18:18 |
| federico3 | or, even better, find a way to ensure that the library checks for patching and patch removal | 18:19 |
| *** james_li has joined #openstack-dns | 18:20 | |
| *** rsyed is now known as rsyed_away | 18:21 | |
| dhellmann | Kiall, federico3 : oslotest has some fixtures for handling these sorts of cases | 18:24 |
| Kiall | Yea, I was sure we actually had that cleanup fixture enabled | 18:24 |
| dhellmann | http://docs.openstack.org/developer/oslotest/api/oslotest.mockpatch.html | 18:25 |
| Kiall | Oh, that was the old Mox one. | 18:25 |
| Kiall | And my grep-fu has ran out of things to addCleanup on, still with random fails. | 18:27 |
| *** GonZo2K has joined #openstack-dns | 18:28 | |
| *** GonZo2K has joined #openstack-dns | 18:28 | |
| *** chlong has quit IRC | 18:29 | |
| *** chlong has joined #openstack-dns | 18:30 | |
| *** james_li has quit IRC | 18:30 | |
| Kiall | federico3: you're more familar with the tests these days, can you dig in today/tomorrow? General rule of thumb: Use mock.patch as a context manager or class/method decorator where possible - failing that, fixtures.*Patch* (see https://pypi.python.org/pypi/fixtures ) | 18:31 |
| *** chlong has quit IRC | 18:32 | |
| Kiall | federico3: bug # for the commit - 1537851 | 18:32 |
| *** chlong has joined #openstack-dns | 18:33 | |
| federico3 | yup | 18:33 |
| federico3 | Kiall: are you sending out a CR for the changes you've done so far? | 18:33 |
| Kiall | yea, will do.. but it's just a quick fix, and may only be a fix if I find em all ;) | 18:35 |
| *** james_li has joined #openstack-dns | 18:36 | |
| openstackgerrit | Kiall Mac Innes proposed openstack/designate: Ensure mocks are stopped after use https://review.openstack.org/272219 | 18:37 |
| Kiall | federico3: ^ passed 3x in a row.. not a guarantee it's all of them, but should be most | 18:37 |
| Kiall | ryanpetrello: try pulling ^ patch down and seeing if it passes for you now | 18:38 |
| * ryanpetrello tries | 18:38 | |
| ryanpetrello | yep, that works for me | 18:41 |
| Kiall | awesome. mugsie / timsim: can you +2/+A https://review.openstack.org/272219 - tis a temporary fix, but worth merging until we do a cleanup | 18:45 |
| *** james_li has quit IRC | 18:45 | |
| *** jasonsb has quit IRC | 18:45 | |
| mugsie | Kiall: +2'd | 18:50 |
| *** pcaruana has joined #openstack-dns | 18:51 | |
| Kiall | testrs's --until-failure really needs to print a summary once stopped.. but after 15 mins of the tests running over+over, no fails. | 18:52 |
| federico3 | I had 8 failures out of 8 runs. Were you seeing random failures instead? | 18:53 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/designate: Updated from global requirements https://review.openstack.org/270938 | 18:57 |
| *** bpokorny has quit IRC | 18:59 | |
| *** openstackgerrit has quit IRC | 19:02 | |
| *** openstackgerrit has joined #openstack-dns | 19:02 | |
| *** ChanServ sets mode: +v openstackgerrit | 19:02 | |
| *** james_li has joined #openstack-dns | 19:09 | |
| *** james_li has quit IRC | 19:14 | |
| *** bpokorny has joined #openstack-dns | 19:18 | |
| *** james_li has joined #openstack-dns | 19:29 | |
| *** pcaruana has quit IRC | 19:32 | |
| *** james_li has quit IRC | 19:33 | |
| *** james_li has joined #openstack-dns | 19:33 | |
| *** pcaruana has joined #openstack-dns | 19:36 | |
| *** rsyed_away is now known as rsyed | 19:40 | |
| *** pcaruana has quit IRC | 19:40 | |
| *** pcaruana has joined #openstack-dns | 19:43 | |
| *** rudrajit has quit IRC | 19:48 | |
| *** rudrajit has joined #openstack-dns | 19:49 | |
| *** rudrajit has quit IRC | 19:53 | |
| *** pcaruana has quit IRC | 19:56 | |
| *** rudrajit has joined #openstack-dns | 20:19 | |
| *** rudrajit has quit IRC | 20:23 | |
| openstackgerrit | James Li proposed openstack/designate: Fix _assert_exception() https://review.openstack.org/272256 | 20:27 |
| ryanpetrello | Kiall you know anybody that you can get to +A https://review.openstack.org/#/c/272219/1 ? | 20:45 |
| ryanpetrello | looks like Jenkins gave +1 | 20:45 |
| Kiall | mugsie: still on? worth giving ^ a +A as it's a blocker | 20:45 |
| Kiall | or timsim - but he seems AFK today | 20:45 |
| ryanpetrello | kthx | 20:45 |
| Kiall | (if mugsie isn't on IRC, I'll ping him on hangouts - I know that causes his watch to vibrate ;)) | 20:46 |
| timsim | Sorry, got it Kiall | 20:50 |
| Kiall | cool, thanks :) | 20:50 |
| ryanpetrello | thx timsim | 20:51 |
| *** rudrajit has joined #openstack-dns | 20:57 | |
| *** chlong has quit IRC | 21:07 | |
| *** chlong has joined #openstack-dns | 21:09 | |
| openstackgerrit | Merged openstack/designate: Ensure mocks are stopped after use https://review.openstack.org/272219 | 21:20 |
| *** ccneill has quit IRC | 21:29 | |
| *** sonuk has joined #openstack-dns | 21:30 | |
| *** ccneill has joined #openstack-dns | 21:30 | |
| *** chlong has quit IRC | 21:39 | |
| *** chlong has joined #openstack-dns | 21:40 | |
| *** rudrajit_ has joined #openstack-dns | 21:44 | |
| *** rudrajit has quit IRC | 21:47 | |
| *** rudrajit_ has quit IRC | 21:50 | |
| ryanpetrello | thanks for your help Kiall, just released a new pecan | 22:09 |
| *** rudrajit has joined #openstack-dns | 22:18 | |
| *** rudrajit has quit IRC | 22:18 | |
| *** rudrajit has joined #openstack-dns | 22:19 | |
| *** EricGonc_ has quit IRC | 22:26 | |
| *** rsyed is now known as rsyed_away | 22:42 | |
| openstackgerrit | James Li proposed openstack/designate: Fix _assert_exception() https://review.openstack.org/272256 | 22:52 |
| *** chlong has quit IRC | 23:02 | |
| *** chlong has joined #openstack-dns | 23:04 | |
| *** chlong has quit IRC | 23:04 | |
| *** chlong has joined #openstack-dns | 23:05 | |
| *** gord0 has joined #openstack-dns | 23:07 | |
| openstackgerrit | Tim Simmons proposed openstack/designate: Improve performance and utility of Periodic Recovery https://review.openstack.org/272316 | 23:13 |
| *** rsyed_away is now known as rsyed | 23:24 | |
| *** sonuk has quit IRC | 23:25 | |
| *** chlong has quit IRC | 23:29 | |
| *** chlong has joined #openstack-dns | 23:30 | |
| *** km has joined #openstack-dns | 23:35 | |
| *** kei_yama has joined #openstack-dns | 23:36 | |
| *** james_li has quit IRC | 23:49 | |
| *** ducttape_ has quit IRC | 23:53 | |
| *** pglass has quit IRC | 23:56 | |
| *** chlong has quit IRC | 23:58 | |
| *** mlavalle has quit IRC | 23:59 | |
| *** chlong has joined #openstack-dns | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!