Friday, 2015-04-10

*** paul_glass has quit IRC00:06
*** MentalRay has joined #openstack-dns00:07
*** ericpeterson has quit IRC00:17
*** km has joined #openstack-dns00:43
*** EricGonczer_ has quit IRC01:02
*** ericpeterson has joined #openstack-dns01:19
*** ericpeterson has quit IRC01:20
*** ericpeterson has joined #openstack-dns01:20
*** stanzgy has joined #openstack-dns01:38
*** ericpeterson has quit IRC01:57
*** ericpeterson has joined #openstack-dns01:58
*** stanzgy has quit IRC02:01
*** ericpeterson has quit IRC02:23
*** stanzgy has joined #openstack-dns02:27
*** ericpeterson has joined #openstack-dns02:28
*** ericpeterson has quit IRC02:52
*** richm has quit IRC03:06
*** johnbelamaric has quit IRC03:10
*** kei_yama has quit IRC03:49
*** ericpeterson has joined #openstack-dns04:23
*** crc32 has joined #openstack-dns04:27
*** ericpeterson has quit IRC04:27
*** crc32 has quit IRC05:33
*** ericpeterson has joined #openstack-dns06:12
*** ericpeterson has quit IRC06:16
*** MentalRay has quit IRC06:24
*** jordanP has joined #openstack-dns07:24
*** kodoku has joined #openstack-dns07:58
kodokuHi, Requierment.txt for kilo forget pymysql07:59
*** ericpeterson has joined #openstack-dns08:01
kodokuAnd what is pool-target-id when I try powerdns sync ??08:02
kodokuKiall I see in irc log you talk about that08:04
*** ericpeterson has quit IRC08:06
kodokuping :)08:25
*** kodoku_ has joined #openstack-dns08:37
*** kodoku has quit IRC08:38
*** jordan_ has joined #openstack-dns08:43
*** jordanP has quit IRC08:43
kodoku_omg need docs for pool ^^09:00
*** kodoku has joined #openstack-dns09:38
*** kodoku_ has quit IRC09:40
*** kodoku has quit IRC09:46
*** ericpeterson has joined #openstack-dns09:49
*** kodoku has joined #openstack-dns09:50
*** ericpeterson has quit IRC09:55
*** untriaged-bot has joined #openstack-dns10:01
untriaged-botUntriaged bugs so far:10:01
untriaged-bothttps://bugs.launchpad.net/designate/+bug/144222110:01
openstackLaunchpad bug 1442221 in Designate "Pool manager does not update domain create errors correctly" [Undecided,In progress] - Assigned to Vinod Mangalpally (vinod-mang)10:01
untriaged-bothttps://bugs.launchpad.net/designate/+bug/144214110:01
openstackLaunchpad bug 1442141 in Designate "designate-api Throws Error on stop()" [Undecided,New]10:01
untriaged-bothttps://bugs.launchpad.net/designate/+bug/143769910:01
openstackLaunchpad bug 1437699 in Designate "mDNS should Handle Bad File Descriptor" [Medium,New] - Assigned to Ron Rickard (rjrjr)10:01
*** untriaged-bot has quit IRC10:01
*** eandersson has joined #openstack-dns10:37
eanderssonedit_managed_records is that for supporting managed records from the api?10:39
eandersson* Added policy check (edit_managed_records), defaulting to rule:admi10:39
mugsieeandersson: yup10:46
mugsiethere is a HTTP header you send in with the request10:46
mugsieits not in the client yet10:46
mugsiebut if you use curl you are golden10:47
eanderssonThis should really be re-factored :P https://github.com/openstack/designate/blob/master/designate/notification_handler/base.py10:48
eanderssonthe _create and _delete functions10:48
eanderssonshouldn't use anything directly fromt he configuration :P10:48
mugsiehuh10:49
mugsieno we definitly should not10:49
eanderssonIn the BaseAddressHandler10:49
mugsie-_-10:49
mugsiepatches accepted! :D10:49
eandersson=]10:49
eanderssonSoon!10:49
mugsie:)10:50
eanderssonin _delete10:51
eanderssonwhy would resource_id ever be None?10:51
eanderssonor could criterion contain the values needed?10:51
eanderssonif so wouldn't resource_id None override that?10:52
mugsieyup10:52
mugsiehonestly that area of the code does need a good going over10:52
eanderssonI might as well fix it there instead of fixing my code again :p10:53
mugsieI dont use it regularly (if at all)10:53
openstackgerritEndre Karlson proposed openstack/designate: Switch to API v2 as the new CURRENT  https://review.openstack.org/17237511:01
*** kodoku has quit IRC11:05
*** ericpeterson has joined #openstack-dns11:06
*** kodoku has joined #openstack-dns11:06
kodokueandersson do you know how sync powerdns database with kilo designate ?11:07
kodokuwith pool concept :/11:07
*** ericpeterson has quit IRC11:11
*** eandersson has quit IRC11:13
*** stanzgy has quit IRC11:14
*** eandersson has joined #openstack-dns11:20
kodokueandersson do you know how sync powerdns database with kilo designate ? with pool concept. Because if I make "designate-manage powerdns sync"  ==> usage: designate powerdns sync [-h] pool-target-id11:24
mugsiekodoku: it should be the pool-target-id in the config file11:26
kodokuAnd when I use designate-manage I have always => No handlers could be found for logger "oslo_config.cfg"  (Maybe eventlet bug ?)11:26
mugsiewhere you configured the db connection string11:26
mugsieyou should have a section like [pool_target:f26e0b32-736f-4f0a-831b-039a415c481e]11:27
openstackgerritErik Olof Gunnar Andersson proposed openstack/designate: Refactored BaseAddressHandler.  https://review.openstack.org/17238211:27
mugsiethats where to DB connection string is11:27
mugsieso take the UUID from the section title11:27
mugsieand use that in the command11:27
kodokuok in [pool_manager_cache:memcache]11:28
kodokuha ok i see11:28
kodokuI configure here powerdns ?11:28
mugsieyeah11:29
kodokuok but I need [backend:powerdns] too ?11:29
mugsienope11:29
mugsienot anymore11:30
kodokuok but in sample I don't see how I write database pdns11:30
mugsieit would be .... one sec11:30
kodokuI have just type =powerdns port=53 host=localhost11:30
kodokuI have option=.... but it's for bind11:31
mugsieoptions = connect: <connection string>11:31
*** EricGonczer_ has joined #openstack-dns11:32
mugsiesorry, options = connection  : string11:32
mugsieyou will also need to fill in the IP of your miniDNS server in the masters section11:32
mugsieIP:PORT actually11:32
kodokupdns is on designate host11:33
kodokuI don't have miniDNS O_o11:33
mugsieyou need to run a designate-mdns as well, to get data from Designate -> PDNS11:34
mugsie(actual records etc)11:34
*** EricGonczer_ has quit IRC11:35
kodokuok for recap11:35
*** kodoku_ has joined #openstack-dns11:37
kodoku_I conf [pool:79....]  + [pool_nameserver:0f.....] + [pool_target:f2222], I launch "manage powerdns sync f2222" + "manage database sync"  ==> then i launch central, mdns, api + sink11:37
mugsieyup11:38
kodoku_ok thx11:38
kodoku_I'll try that11:38
kodoku_and for "No handlers could be found for logger "oslo_config.cfg""  ?11:38
mugsienot sure - think that my just be a long outstanding bug11:40
*** kodoku has quit IRC11:40
mugsieshould not cause any issues11:40
kodoku_ok11:40
*** mwagner_lap has quit IRC11:42
kodoku_mugsie ok works for add records with api but pdns database always empty11:51
kodoku_so pdns send can't find :/11:51
kodoku_records and domains table empty :/11:51
kodoku_no error or trace with mdns11:51
mugsieah, crap11:54
kodoku_hum wait11:54
mugsieforgot one service - pool-manager11:54
kodoku_msdn has shutdown11:54
kodoku_arf11:54
mugsiedesignate-pool-manager as well11:54
kodoku_hum11:54
kodoku_trace11:54
kodoku_ValueError: Invalid target type: None11:55
kodoku_need to uncomment [service:pool_manager] ?11:56
mugsieeh, i think so11:58
*** EricGonczer_ has joined #openstack-dns12:01
*** EricGonczer_ has quit IRC12:01
kodoku_mugsie need cache driver and configure memcache ?12:02
mugsiekodoku_: no, it will do a simple in memory cache if there is no memcache12:03
kodoku_ok so  no need [pool_manager_cache:sqlalchemy] ?12:04
kodoku_mugsie this is my designate.conf http://pastebin.com/03eickp412:07
*** ericpeterson has joined #openstack-dns12:07
kodoku_maybe you can see if there is wrong conf12:07
mugsieyou are missing master in the pool target section12:12
mugsiethat should be ip / hostname of miniDNS + port (usually <ip>:5354 )12:13
kodoku_ok12:13
kodoku_always ValueError: Invalid target type: None  when I start pool-manager12:13
kodoku_maybe workers in [service:pool_manager]12:16
kodoku_mugsie like need workers = 1 ?12:17
*** EricGonczer_ has joined #openstack-dns12:21
kodoku_hum12:22
kodoku_ValueError("Invalid target type: %r" % target)12:22
kodoku_maybe in target def  type = powerdns is wrong12:22
kodoku_maybe type= pdns ?12:22
eanderssonAnyone seen this before when using the sink? Remote error: DBError badly formed hexadecimal UUID string (original cause: ValueError: badly formed hexadecimal UUID string)12:29
mugsiekodoku_: humm, let me look - do you have a full stack trace?12:30
mugsieeandersson: yeah - the UUID is not being coverted properly - where are you getting that?12:31
*** ericpeterson has quit IRC12:31
eanderssonmugsie: http://paste.openstack.org/show/bsorsUWRjG6kSxQV5pOV/12:33
eanderssonhmm return self.central_api.get_domain(context, domain_id) I think12:34
mugsielooks like the domain_id isnt getting there12:34
mugsieor, it might have the '-' stripped - I have seen it give out about that before12:35
*** bustersw_ has joined #openstack-dns12:35
eanderssonmaybe I messed up somewhere :P12:35
*** EricGonczer_ has quit IRC12:35
eanderssonwill add more logging =]12:35
kodoku_OK I succes to launch pool-manager12:35
kodoku_i add database for pool-manager12:36
kodoku_and configure [pool_manager_cache:sqlalchemy]12:36
kodoku_but when I add records12:36
kodoku_ TRACE : UnexpectedSource: got a response from ('10.121.141.43', 53) instead of (u'juno008.gate', 53)12:36
kodoku_so need IP and no HOSTNAME in designate.conf ??12:37
mugsieyeah, unless you have reverse DNS setup, ip is preferable12:38
kodoku_ok12:38
Kiallactually, dnspython, of all things, behaves TERRIBLY with hostnames. lol12:40
KiallIPs even with rdns setup should be used :(12:40
kodoku_ok12:41
kodoku_I drop and recreate all database12:41
kodoku_start all service central, api, mdns, pool-cache12:42
kodoku_all start witout error or trace12:42
kodoku_I go to add server, domains and records :)12:42
kodoku_Yes Baby !12:44
*** km has quit IRC12:45
kodoku_Kiall mugsie    arf, domain is add to domains tables of pdns but when I add record ==> no add to pdns table12:46
Kiallkodoku_: Oh, pdns config.. did you set master=yes ?12:47
Kiallif not, restart it, it should fill it out12:47
kodoku_hum in options ?12:48
kodoku_In pool_target I have masters = 10.121.141.43:535412:48
kodoku_arf in pdns config12:48
kodoku_daemon=yes master=yes12:48
KiallOkay, and pdns logs should have something about trying to AXFR the zone?12:49
kodoku_ pdns[31304]: AXFR done for 'test.domain', zone committed with serial number 142866981012:49
kodoku_I have 5 times => pdns[31304]: Received NOTIFY for test.domain from 10.121.141.43 but slave support is disabled in the configuration12:51
KiallDooh .. Another pdns config option is slave = yes12:51
kodoku_ok I add it12:51
KiallWe do this during DevStack runs:12:52
Kiallhttps://github.com/openstack/designate/blob/master/contrib/devstack/lib/designate_plugins/backend-powerdns#L6712:52
kodoku_ha so master=no ?12:52
KiallYea, I mixed up master vs slave :)12:52
Kiallmaster = yes won't break it, just means more stuff enabled in pdns than would be strictly necessary12:52
kodoku_but designate write directly in pdns database no ?12:53
kodoku_If I add records with designate, I can see this records in records tables of pdns database12:54
KiallIn Kilo, we write only to the domains table and allow pDNS to AXFR the rest of the contnet12:54
Kiallcontent*12:54
kodoku_ok works, I add a new record and I can see both in tables12:54
kodoku_ok12:55
kodoku_i understand now12:55
kodoku_Kiall and question for sink. In juno version, eandersson give me a fix write by you.12:57
kodoku_It's for Fix records add when user launch 10-20 instances from openstack12:58
kodoku_This fix is commit in kilo version ?12:58
KiallThat's fixed in Kilo, if you see similar issues, yell really really loud so we can fix them before re release Kilo final!12:58
Kiallbefore we release*12:58
kodoku_Ok I make in production soon so If i see similar issue, I tell you13:00
Kiall:)13:03
*** richm has joined #openstack-dns13:14
eanderssonAlmost got it working with Kilo now. :D13:16
eanderssonThe record is created by the sink, but it is not removed.13:16
eanderssonI see delete_record: Calling central's delete_record13:16
eanderssonbut the record is still there13:16
kodoku_with sink ?13:17
eanderssonyep13:17
kodoku_ho god13:17
kodoku_no good for me ^^13:17
eanderssonI use a customized plugin for the sink though :P13:17
eanderssonso probably wont affect you13:17
kodoku_and If new instance with same name is create ?13:17
kodoku_ok  :)13:17
kodoku_I'll try now13:17
eanderssonpretty sure it behaves the same way for you as it did in Juno13:18
kodoku_and I see in designate.conf.sample  => notification_topics = notifications for sink13:19
eanderssonYea, you'd probably want to change that to something like designate-notifications13:19
kodoku_so now, I doesn't need to add notification_topics = notifications-designate in nova.conf13:19
openstackgerritGraham Hayes proposed openstack/designate: Moved RecordSet lookup to a custom join query  https://review.openstack.org/17241513:19
eanderssonKiall: When deleting records when something is misconfigured shouldn't it fail? I am not getting any feedback on failures.13:23
kodoku_ok sink see anything :/13:24
KiallWith sink? It depends on the fail I guess13:24
kodoku_I have consumer in notification queue from designate host13:24
KiallSink can be turned on with 50k existing VMs, so throwing a stacktrace as those get deleted isn't really idea13:24
Kiallideal*13:24
eanderssonI see Queueing notification for dns.record.delete13:24
eanderssonI see the policy check etc succeed13:24
eanderssonbut the record is still there13:25
kodoku_ok so Sink start without error, I see it in queue like consumer, When I start instance I see in queue my instance but sink make anything ......13:28
Kialleandersson: okay, could be a bug then :(13:28
KiallThat said.. I added a review for sink support in devstack, including some exercicses for it, and it workd13:28
eanderssonI do see the following "Got Timeout while trying to send 'NOTIFY'" in designate-mdns13:28
Kiallworked13:28
*** johnbelamaric has joined #openstack-dns13:29
kodoku_and my queue is empty.... so designte ACK the msg no ?13:30
eanderssondo you see any incoming?13:30
kodoku_in quueue ?13:30
eanderssonyea13:30
kodoku_yes13:30
kodoku_ok works after change notification_topics = notification-designate13:32
kodoku_with notification_topics = notifications not works :/13:32
kodoku_but in nova.conf I have notification_topics = notifications,notification-designate13:32
eanderssonYou need that ont he nova compute nodes13:33
eanderssondid you restart the compute nodes after applying the configuration?13:33
eanderssonKiall: Setting record xxx, serial 1428672832: action DELETE, status ERROR _update_record_status13:36
eanderssonI do see that13:36
*** csoukup has joined #openstack-dns13:37
eanderssonI guess I have to dig into the new code13:37
*** kodoku_ has quit IRC13:41
Kialleandersson: that suggests that sink did delete it, but the nameserver acted on the deletion. The NOTIFY timeouts are likely the cause13:44
eanderssonok so if I fix the timeouts it should work?13:44
eanderssonI just find it odd that it can create, as the same timeouts should happen there as well.13:44
KiallYep, it failed to notify the nameserver of a change, so the nameserver never fetched the update zone, so the change (the delete) was marked as failed after a couple of attempts13:45
KiallYea - It is odd, since the code is identical for how those notifys etc get sent... Humm13:45
eanderssonIs the actual mysql db removal proxied now?13:49
eanderssonSince I would assume that the DB entry would be deleted here: self._delete_record_in_storage13:49
eanderssonOh Kiall13:51
eanderssonrecordset = self.storage.delete_recordset(context, recordset.id)13:51
KiallThat will mark it as action = DELETE, status = PENDING in our DB, then, once it's cleared from the nameserver, actually deleted13:51
eanderssonThis exists in the delete_recordset13:51
eanderssonbut there is no such function in delete_record13:51
eanderssononly record = self.storage.update_record(context, record)13:51
eanderssongonna check trunk13:51
eanderssonhttps://github.com/openstack/designate/blob/master/designate/central/service.py#L156513:52
eanderssonand this is delete_recordset13:52
eanderssonhttps://github.com/openstack/designate/blob/master/designate/central/service.py#L133213:52
eanderssonMaybe I am missing something? :D13:53
eanderssonas in missing something obvious (not missing code :P)13:53
KiallHumm, that certainly looks like an issue.. But, I'm sure our tests cover those .. Which has me wondering a little13:53
KiallAbout to hop onto a call, will check after.13:54
*** mwagner_lap has joined #openstack-dns13:57
*** ericpeterson has joined #openstack-dns13:58
*** vinod1 has joined #openstack-dns13:59
*** paul_glass has joined #openstack-dns14:14
*** andrewbogott_afk is now known as andrewbogott14:20
*** dvorak is now known as clayton14:21
eanderssonKiall: I Added self.storage.delete_record(context, record.id) and it works now. =]14:22
elarsonI wrote a little script to create random domain names in designate. http://paste.openstack.org/show/202038/14:29
elarsonone thing to note is it uses the randstr package. I wrote that the other day to create small random strings for this sort of thing14:30
elarsonjust a friendly FYI14:31
*** kodoku has joined #openstack-dns14:38
kodokuKiall eandersson mugsie Re, I try to automat deploy of designate with puppet and when puppet launch database sync, I have ==>  oslo.config.cfg.NoSuchGroupError: no such group: <oslo_config.cfg.OptGroup object at 0x2ec7650>14:39
kodokuAny Ideas ?14:39
elarsonkodoku: that sounds like a config option group is missing14:40
kodokuok I compare with the first deploy14:41
elarsonkodoku: can you tell where in the code the error is coming from? that might help narrow it down14:41
* elarson also wonders if best practice is to pass a group object or the name when referencing groups in the config as it looks like object pattern doesn't really help users debug the config.14:43
kodokuFile "/usr/lib/python2.7/site-packages/stevedore/driver.py", line 50, in _default_on_load_failure     raise err14:44
kodokuand designate.conf is same of original14:44
kodokuelarson full trace http://pastebin.com/AhxhdY7214:45
kodokuI have stevedore (1.3.0)14:47
*** EricGonczer_ has joined #openstack-dns14:49
*** andrewbogott is now known as andrewbogott_afk14:51
timsimkodoku: What does the config look like?14:52
kodokuI up designate.conf14:53
*** ericpeterson has quit IRC14:53
kodokutimsim http://pastebin.com/usWD5AbT14:54
timsimUsually when I see that error, it spells out a specific config section it's looking for. Not an Oslo config object.14:57
kodoku:/14:59
kodokuwhen I launch designate-manage I have this issue15:00
kodokuwithout option15:00
kodokueven designate-manage --help Traceback :/15:01
elarsonkodoku: if you're running the database sync, do you have a [storage:sqlalchemy] section?15:03
elarsoncould be a misspelling too15:03
kodokuyes15:03
*** andrewbogott_afk is now known as andrewbogott15:03
kodokuI have link my conf15:03
kodokuhttp://pastebin.com/usWD5AbT15:03
kodokuBut I think is not a conf issue15:04
kodokuBecause "designate-manage --help" make a trace15:04
kodokuMaybe a module not install or bug in setup.py install :/15:04
timsimYeah I guess try and run setup.py again? And make sure that the config is where it's expecting it15:05
kodokupython setup.py install works without errors15:06
kodokuand same issue15:06
timsimI think you can specify the config directory to designate-manage, try that15:06
timsimWell wait, if you're on Juno, a bunch of that config doesn't need to be there.15:06
kodokuI'am on kilo version15:07
timsimOh, well nvm then15:07
kodokuI reinstall on fresh system15:08
eanderssonKiall: https://review.openstack.org/#/c/172459/ Let me know if I am completely wrong about this. =]15:09
vinod1eandersson - that looks right - did you hit this issue with the v1 api?15:13
KiallI really think the gate jobs are going to fail with that... But just off that call and being pushed to get some more bits+pieces done today before I'm gone Monday :(15:13
KiallIf anything, I delete the delete_recordset was an extra call that should be removed!15:14
eanderssonYou have the same for create_record though15:15
eanderssonecord = self.storage.create_record(...)15:15
Kiallthe actual delete from the DB get's covered from here: https://github.com/openstack/designate/blob/master/designate/central/service.py#L213815:15
*** MentalRay has joined #openstack-dns15:15
Kiall(as does the delete_recordset call)15:15
eanderssonThat is how I thought that it worked at first.15:15
eanderssonThe delete_recordset code threw me off.15:16
eanderssonI really see it as an issue with managed records not being deleted though.15:16
eanderssonAs the way it is right now, we need to go into the database and delete those everytime.15:16
kodokuarf always same bug T_T15:17
eanderssonIt should at the very least report something to the sink even if it doesn't throw an exception.15:17
Kialleandersson: actually, are you using increment_serial = False in your sink handler?15:19
eanderssonnope15:19
KiallCan you throw the logs on paste.openstack.org? I can't look straight away, but I'll try look over the next few hours.15:20
eanderssonIn the actual DNS creation process my code is almost identical to trunk.15:20
KiallOh - custom handler? Okay, what about the stock ones? can you test that out?15:20
KiallOr is the only change the one you submitted as a refactor?15:20
eanderssonPretty much.15:20
kodokuIf you have time to look : http://paste.openstack.org/show/202081/15:21
eanderssonI just re-use BaseAddressHandler with the addition of the refactored code.15:21
elarsonkodoku: it looks like oslo.messaging is assuming a config group exists. can you confirm what version you're using?15:29
kodokuelarson oslo.messaging (1.8.0)15:32
*** jmcbride has joined #openstack-dns15:34
eanderssonKiall: I'll set up a local environment tonight or tomorrow and reproduce it. These logs are way too messy.15:41
-openstackstatus- NOTICE: gerrit has been restarted to address a hung event stream. change events between 15:00 and 15:43 utc which were lost will need to be rechecked or have approval workflow votes reapplied for zuul to act on them15:44
openstackgerritVinod Mangalpally proposed openstack/designate: Show admin endpoint in list of versions  https://review.openstack.org/17248815:46
elarsonkodoku: fwiw, I have oslo.messaging==1.8.115:47
mugsievinod1: I did have admin api in the list but got overrule by Kiall15:50
mugsienot sure why he didn't want it15:50
KiallBecauage / is a URL you can hit unauthenticated, and we shouldn't expose the /admin to non admins15:51
KiallBecause*15:51
vinod1but we document the admin endpoint here - http://docs.openstack.org/developer/designate/rest/admin/quotas.html15:52
mugsieKiall: thats tenous15:52
elarsonthis was actually confusing me just yesterday as I needed to up some quotas15:53
mugsiebecause admin apis are documented, and can even be in service catalogs15:53
Kiallvinod1: yea, but users who can't get it shouldn't see it returned as a possible API15:53
*** ericpeterson has joined #openstack-dns15:53
Kialle.g. every public openstack deployments hides the "adminURL" catalog property from end users.. If we expose it at / .. there all going to go fork it.15:54
Kiall(or just get annoyed and leave it ;))15:54
mugsiei really dont think they will15:56
mugsieI actually doubt anyone will care. That said it would be very easy to have a policy check there15:56
*** ericpeterson has quit IRC15:58
openstackgerritEric Larson proposed openstack/designate: Add the Hook Point API  https://review.openstack.org/16474815:59
*** jordan_ has quit IRC16:00
vinod1Is something like  this policy.check('admin', context, target) valid - if so kiall can we add that as an additional check before displaying the endpoint?16:00
elarson+116:00
*** untriaged-bot has joined #openstack-dns16:01
untriaged-botUntriaged bugs so far:16:01
untriaged-bothttps://bugs.launchpad.net/designate/+bug/144222116:01
openstackLaunchpad bug 1442221 in Designate "Pool manager does not update domain create errors correctly" [Undecided,In progress] - Assigned to Vinod Mangalpally (vinod-mang)16:01
Kiallvinod1: so, we don't have the KS middleware in front of that endpoint..16:01
untriaged-bothttps://bugs.launchpad.net/designate/+bug/144214116:01
openstackLaunchpad bug 1442141 in Designate "designate-api Throws Error on stop()" [Undecided,New] - Assigned to Graham Hayes (grahamhayes)16:01
untriaged-bothttps://bugs.launchpad.net/designate/+bug/144269916:01
openstackLaunchpad bug 1442699 in Designate "Add admin endpoint to the list of versions" [Undecided,In progress] - Assigned to Vinod Mangalpally (vinod-mang)16:01
untriaged-bothttps://bugs.launchpad.net/designate/+bug/143769916:01
openstackLaunchpad bug 1437699 in Designate "mDNS should Handle Bad File Descriptor" [Medium,New] - Assigned to Ron Rickard (rjrjr)16:01
*** untriaged-bot has quit IRC16:01
Kiallwe could add it, with "delay_auth_decision" set to False to unauthenticated users can still hit it16:02
Kialls/to/so/16:02
*** jmcbride has quit IRC16:04
mugsieif we are putting in policy there, we should be adding it to all endpoints16:04
*** kodoku has quit IRC16:04
mugsieso people can limit the v1 as well16:04
mugsieor even v2 if they feel like it16:04
vinod1first off is this issue - (displaying admin in versions) important for rc1?16:08
Kiallmugsie: humm, yea..16:08
Kiallvinod1: ehh.. I'm not sure. If we have a reasonable way to do it, then it's probably a good thing to do..16:08
KiallI think we can just drop the KS middleware in front on the "versions" app in api-paste.ini, the tricky bit is getting only that 1 "app" to use delay_auth_decision=False16:09
KiallActually, I think that can be done easily too ..  let me see16:10
openstackgerritKiall Mac Innes proposed openstack/designate: Throw KS middleware in front of versions app  https://review.openstack.org/17249616:15
Kiallvinod1 / mugsie: in theory .. ^ gives us a context we can work with.. Not sure how the context middleware will handle empty headers etc etc tho16:15
*** jmcbride has joined #openstack-dns16:15
Kiall(I have no intent of that merging, just writing it was easier than explaing it ;))16:16
Kialllol .. and delay_auth_decision = False should be set to True ;)16:16
*** ericpeterson has joined #openstack-dns16:17
vinod1with all these changes - the change will no longer be simple and will require more testing16:18
Kiall++16:19
*** jmcbride1 has joined #openstack-dns16:19
*** jmcbride has quit IRC16:20
Kiall"admin endpoint not exposed in versions list for admin users" is a bug, but probably not critical enough to force in now.. and one we can fix post release in the stable branch.16:20
Kiallmugsie: thoughts ^ ?16:22
mugsieyeah. I think we should do it, but this close is asking for trouble16:23
vinod1kiall you mentioned some other changes before rc1 - what changes would these be?16:24
KiallThe only blocker is making the decision in V2 being stable16:24
Kiall(that I know of)16:25
Kiallhttps://review.openstack.org/#/c/172375/ <-- review for that is here, I'd like to get "Votes" in the form of +/-2 by EOD Monday!16:25
Kiall(My -2 is just to block in going in for now ;))16:25
eanderssonKiall: So it is not a bug then?16:57
openstackgerritGraham Hayes proposed openstack/designate: Moved RecordSet lookup to a custom join query  https://review.openstack.org/17241516:57
*** andrewbogott is now known as andrewbogott_afk17:01
*** mwagner_lap has quit IRC17:02
eanderssonI still find it odd that it can create, but not delete. That could lead to a lof of unwated records in the db. =]17:02
Kialleandersson: re your patch, Gerrit was broke when you submitted it so the tests didn't get triggered.. The "recheck no bug" common is how you get Gerrit to re-trigger the tests :)17:10
Kiallcomment*17:10
eanderssonah17:11
eanderssonbut the tests did indeed fail like you said17:11
eanderssonAll failing with RecordNotFound17:12
Kiallre "that it can create, but not delete. That could lead to a lof of unwated records in the db.".. It does delete, the SQL DELETE query is just deferred until the record has been purged from the nameservers17:13
eanderssonah ok17:13
eanderssonthat makes a lot more sense17:13
*** jmcbride1 has quit IRC17:13
eanderssondef wai then17:13
eanderssonthanks Kiall17:13
KiallThe failing NOTIFY is preventing the nameserver from updating, so it never get's removed17:13
Kiall(or some other issue is preventing it.. That might be a red herring)17:14
eanderssonI guess I am just hung up on the lack of support for Managed records in the API.17:14
eanderssonAs I am afraid of something like this happening in production.17:14
Kialleandersson: someone.. mugsie maybe? added a review for that yesterday.. I have no clue if we merged it tho.. lol.17:14
eanderssonWould be a lot of work to manually go through the databases17:14
mugsieKiall: afaik we did17:14
*** MentalRay has quit IRC17:14
Kiall(It's been 2 days of ear glued to a phone)17:14
KiallWe did.. https://github.com/openstack/designate/commit/a4f3ad90b9f7d9a98b47c5adcf949d5f45c3ded417:14
Kiall^ let's you, client support is still needed tho17:15
eanderssonah yea saw that code17:15
eanderssonthat is awesome17:15
eanderssonI can use it for my sync script17:15
mugsieeandersson: so you can delete from the API, by adding X-Designate-Edit-Managed-Records:True as a header17:15
eanderssonperfect17:15
KiallMaybe? Depends exactly what you're tying to do! Ie.g. you can't create managed records using it, that would have been a much bigger API change (exposing the managed_* fields so you can set them)17:16
mugsievinod1 timsim elarson Kiall thoughts on putting https://review.openstack.org/172415 in RC1 ?17:16
eanderssonI might have to track deleted records though and periodically follow up to make sure that they have been deleted17:16
Kialleandersson: SELECT * FROM records WHERE action = 'DELETE' AND satus = 'ERROR';17:17
Kiall^ that'll get all the ones that failed to delete17:17
timsimmugsie: I'd like to. But that's a pretty big change. I don't know if that'll fly. Seems like we could probably get it tested properly.17:17
eanderssonawh that is nice17:17
Kialland pool manager will keep trying to delete them17:17
vinod1just looking at the timings - with the patch v1 is taking more time?17:17
eanderssonperfect17:17
Kiallonce the underlying issue is fixed, they should get deleted17:17
eanderssonsorry a little out of touch with the new changes17:17
eanderssonsetting up a new dev environment where I can test out the changes properly17:17
*** jmcbride has joined #openstack-dns17:18
mugsievinod1: nope, the number you are interested in is the last one17:18
Kiallvinod1 / mugsie the numbers in the comment are wrong ;)17:18
KiallThe V1 comment is comparing a limited V1 API call to a unlimited V2 API call ;)17:19
mugsiev1 isnt limted17:19
Kiallscratch that..17:19
KiallThe V1 comment is comparing an unlimited V1 API call to a limited V2 API call ;)17:19
Kialltime http http://127.0.0.1:9001/v1/domains/3b366791-35f8-42d3-8078-f9672669f04d/records > /dev/null17:19
Kiallvs17:19
Kialltime http http://127.0.0.1:9001/v2/zones/3b366791-35f8-42d3-8078-f9672669f04d/recordsets\?limit\=1700 > /dev/null17:19
Kiallv1 vs v217:19
mugsiethe limit is there to make sure we got all the records17:19
Kiallno limit, vs limit=170017:19
mugsiethe deafult limit is there now17:20
mugsie"On Zone with 1700 Records"17:20
mugsie(it was actually a little less)17:20
KiallAh.. Okay.. It's still comparing the V1 vs V2 API rather than V1 before, V1 after ;)17:20
mugsieah17:20
mugsieit is17:20
mugsiehuh17:20
mugsiewoops17:20
Kiall;)17:20
KiallAlso .. Is that on your desktop env? You changed that back from SQLite, right? Just in case ;)17:21
mugsieit is my desktop - running MySQL 5.617:21
mugsie(yes i did ;) )17:22
mugsiedesignate➜  designate git:(master) ✗ time http http://127.0.0.1:9001/v1/domains/3b366791-35f8-42d3-8078-f9672669f04d/records > /dev/null                                                                                                                                                                                                                                                           ae1-2:grahamhayes-hp-project117:22
mugsiehttp  > /dev/null  0.19s user 0.04s system 2% cpu 9.576 total17:22
mugsiethats without17:22
KiallK - So the Q is .. rc1 potential? It's certainly something we should fixup in Kilo.. But might be something for 2015.1.1 rather than 2015.1.0 .. Humm.. If we leave it for 2015.1.1, we can likely make it work for all the resources which have related stuff to load..17:29
vinod1+1 for 2015.1.117:32
mugsiei would err towards .1 - apart from the 55-60% time difference + the reduced load + reduced DB traffic.17:33
mugsieit is a huge amount of time17:33
mugsieand we go from N+1 (where N = number of recordsets) DB calls to 217:34
mugsieor 3 if we have a marker (but that would be N+2 right now)17:34
vinod1mugsie are you saying you want the change in 2015.1.0?17:36
mugsieI would like it. but it would require very in depth review17:37
mugsie(it fixes a bug that was opened against Icehouse)17:38
mugsiesorry, against Juno17:38
mugsiebut I can understand why we wouldnt want to merge it17:38
*** MentalRay has joined #openstack-dns17:41
*** photocyte has joined #openstack-dns17:49
*** boris-42 has joined #openstack-dns17:53
*** mwagner_lap has joined #openstack-dns18:02
eanderssonIf you have two sites, is it possible two have one designate per site and somehow still share a sub-domain?18:11
eanderssonor what is the most redundent setup you could do with two sinks?18:12
*** andrewbogott_afk is now known as andrewbogott18:12
*** vinod1 has quit IRC18:18
*** vinod1 has joined #openstack-dns18:20
*** vinod1 has quit IRC18:21
*** vinod1 has joined #openstack-dns18:21
*** vinod2 has joined #openstack-dns18:25
*** vinod1 has quit IRC18:25
*** crc32 has joined #openstack-dns18:33
*** photocyte has quit IRC18:38
*** MentalRay has quit IRC18:54
eanderssonhave a good weekend guys!18:58
*** eandersson has quit IRC18:58
*** johnbelamaric1 has joined #openstack-dns19:02
*** johnbelamaric has quit IRC19:02
*** EricGonc_ has joined #openstack-dns19:08
*** EricGonczer_ has quit IRC19:11
*** MentalRay has joined #openstack-dns19:12
*** johnbelamaric1 has quit IRC19:12
*** crc32 has quit IRC19:13
*** photocyte has joined #openstack-dns19:19
*** crc32 has joined #openstack-dns19:20
*** MentalRay has quit IRC19:25
*** johnbelamaric has joined #openstack-dns19:28
*** crc32 has quit IRC19:47
*** johnbelamaric has quit IRC19:48
*** vinod2 has quit IRC19:48
*** MentalRay has joined #openstack-dns19:49
*** EricGonc_ has quit IRC19:51
*** johnbelamaric has joined #openstack-dns19:52
*** EricGonczer_ has joined #openstack-dns19:53
*** csoukup has quit IRC19:56
*** EricGonc_ has joined #openstack-dns20:03
*** vinod1 has joined #openstack-dns20:06
*** EricGonczer_ has quit IRC20:06
*** johnbelamaric has quit IRC20:08
*** johnbelamaric has joined #openstack-dns20:08
*** boris-42 has quit IRC20:38
openstackgerritEric Larson proposed openstack/designate-specs: Add hook-point-api specification and liberty specs  https://review.openstack.org/17168920:39
*** vinod1 has quit IRC20:49
*** MentalRay has quit IRC20:51
*** bustersw_ has quit IRC20:53
openstackgerritEric Larson proposed openstack/designate: Add the Hook Point API  https://review.openstack.org/16474821:17
*** jmcbride has quit IRC21:17
*** photocyte has quit IRC21:30
*** johnbelamaric has quit IRC21:31
*** MentalRay has joined #openstack-dns21:39
*** EricGonczer_ has joined #openstack-dns21:55
*** EricGonc_ has quit IRC21:57
*** paul_glass has quit IRC22:07
openstackgerritEric Larson proposed openstack/designate: Add the Hook Point API  https://review.openstack.org/16474822:28
*** EricGonczer_ has quit IRC22:44
*** ericpeterson has quit IRC22:45
*** ericpeterson has joined #openstack-dns22:56
*** andrewbogott is now known as andrewbogott_afk23:11
*** ericpeterson has quit IRC23:15

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!