| openstackgerrit | OpenStack Proposal Bot proposed openstack/designate: Updated from global requirements https://review.openstack.org/147025 | 00:02 |
|---|---|---|
| *** chlong has joined #openstack-dns | 00:05 | |
| *** rmoe_ has joined #openstack-dns | 00:05 | |
| *** tryggvil has quit IRC | 00:07 | |
| *** rediskin has joined #openstack-dns | 00:09 | |
| *** pk has quit IRC | 00:09 | |
| *** rmoe has quit IRC | 00:09 | |
| *** redixin has quit IRC | 00:09 | |
| *** tryggvil has joined #openstack-dns | 00:10 | |
| *** pk has joined #openstack-dns | 00:13 | |
| *** simonmcc has joined #openstack-dns | 00:20 | |
| *** vinod1 has joined #openstack-dns | 00:23 | |
| *** vinod1 has quit IRC | 00:24 | |
| *** tryggvil has quit IRC | 00:34 | |
| *** serverascode has joined #openstack-dns | 00:36 | |
| *** tryggvil has joined #openstack-dns | 00:38 | |
| openstackgerrit | Kiall Mac Innes proposed openstack/designate: Update README.md doc build instructions https://review.openstack.org/147037 | 00:42 |
| *** tryggvil has quit IRC | 00:55 | |
| *** rmoe_ has quit IRC | 00:57 | |
| *** tryggvil has joined #openstack-dns | 00:57 | |
| *** tryggvil has quit IRC | 00:59 | |
| *** Stanley00 has joined #openstack-dns | 01:01 | |
| *** rmoe has joined #openstack-dns | 01:12 | |
| *** shakamunyi has quit IRC | 01:13 | |
| *** stanzgy has joined #openstack-dns | 01:18 | |
| *** nkinder has joined #openstack-dns | 01:22 | |
| *** penick has joined #openstack-dns | 01:32 | |
| *** penick has quit IRC | 01:51 | |
| *** richm has quit IRC | 02:07 | |
| *** mwagner_lap has quit IRC | 02:29 | |
| *** mwagner_lap has joined #openstack-dns | 02:41 | |
| *** shakamunyi has joined #openstack-dns | 02:41 | |
| *** shakamunyi has quit IRC | 02:47 | |
| *** puck has quit IRC | 02:48 | |
| *** harmw has quit IRC | 02:48 | |
| *** shakamunyi has joined #openstack-dns | 02:48 | |
| *** harmw has joined #openstack-dns | 02:50 | |
| *** jmcbride has joined #openstack-dns | 02:50 | |
| openstackgerrit | stanzgy proposed openstack/designate: Fix powerdns db table records missing column disabled https://review.openstack.org/146391 | 02:51 |
| *** puck has joined #openstack-dns | 02:54 | |
| *** shakamunyi has quit IRC | 03:05 | |
| *** Stanley|00 has joined #openstack-dns | 03:16 | |
| *** Stanley00 has quit IRC | 03:20 | |
| *** jmcbride has quit IRC | 03:40 | |
| *** harmw has quit IRC | 03:43 | |
| *** simonmcc has quit IRC | 03:46 | |
| *** simonmcc has joined #openstack-dns | 03:48 | |
| *** harmw has joined #openstack-dns | 03:56 | |
| *** Stanley|00 is now known as Stanley00 | 04:02 | |
| *** rjrjr_ has quit IRC | 04:14 | |
| openstackgerrit | stanzgy proposed openstack/designate: Fix powerdns db table records missing column disabled https://review.openstack.org/146391 | 04:26 |
| *** harmw has quit IRC | 04:36 | |
| *** harmw has joined #openstack-dns | 04:36 | |
| *** hichtakk has quit IRC | 04:38 | |
| *** hichtakk has joined #openstack-dns | 04:39 | |
| *** hichtakk has quit IRC | 04:39 | |
| *** hichtakk has joined #openstack-dns | 04:39 | |
| *** hichtakk has quit IRC | 04:40 | |
| *** hichtakk has joined #openstack-dns | 04:41 | |
| *** hichtakk has quit IRC | 04:41 | |
| *** GonZo2K has quit IRC | 04:41 | |
| *** hichtakk has joined #openstack-dns | 04:42 | |
| *** hichtakk has quit IRC | 04:42 | |
| *** hichtakk has joined #openstack-dns | 04:42 | |
| *** hichtakk has quit IRC | 04:42 | |
| *** hichtakk has joined #openstack-dns | 04:43 | |
| *** zigo has quit IRC | 05:20 | |
| *** zigo has joined #openstack-dns | 05:21 | |
| *** hichtakk has quit IRC | 05:23 | |
| *** hichtakk has joined #openstack-dns | 05:23 | |
| *** hichtakk has quit IRC | 05:23 | |
| *** hichtakk has joined #openstack-dns | 05:24 | |
| *** hichtakk has quit IRC | 05:24 | |
| *** hichtakk_ has joined #openstack-dns | 05:25 | |
| *** hichtak__ has joined #openstack-dns | 05:26 | |
| *** hichtakk_ has quit IRC | 05:26 | |
| *** hichtak__ has quit IRC | 05:41 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/designate: Imported Translations from Transifex https://review.openstack.org/147071 | 06:09 |
| *** harmw has quit IRC | 06:22 | |
| *** harmw has joined #openstack-dns | 06:22 | |
| ekarlso- | Kiall: u up ? | 06:43 |
| *** serverascode has quit IRC | 07:12 | |
| *** serverascode has joined #openstack-dns | 07:15 | |
| *** nihilifer has joined #openstack-dns | 07:35 | |
| *** chlong has quit IRC | 07:47 | |
| *** hichtakk has joined #openstack-dns | 08:25 | |
| *** hichtakk has quit IRC | 08:25 | |
| *** nkinder has quit IRC | 08:25 | |
| *** nkinder has joined #openstack-dns | 08:37 | |
| *** serverascode has quit IRC | 09:09 | |
| *** jordanP has joined #openstack-dns | 09:10 | |
| *** tryggvil has joined #openstack-dns | 09:10 | |
| *** serverascode has joined #openstack-dns | 09:12 | |
| *** tryggvil has quit IRC | 09:17 | |
| *** Stanley00 has quit IRC | 10:05 | |
| *** eandersson has joined #openstack-dns | 10:14 | |
| openstackgerrit | Endre Karlson proposed openstack/designate: Support secondary zones https://review.openstack.org/133682 | 10:16 |
| eandersson | Kiall: Did you ever figure out why DBLock wasn't enough for the DB issue? | 10:45 |
| *** stanzgy has quit IRC | 10:53 | |
| *** untriaged-bot has joined #openstack-dns | 11:02 | |
| untriaged-bot | Untriaged bugs so far: | 11:02 |
| untriaged-bot | https://bugs.launchpad.net/designate/+bug/1289444 | 11:02 |
| uvirtbot | Launchpad bug 1289444 in designate "Designate with postgres backend is having issues" [Medium,New] | 11:02 |
| untriaged-bot | https://bugs.launchpad.net/designate/+bug/1409629 | 11:02 |
| untriaged-bot | https://bugs.launchpad.net/designate/+bug/1409824 | 11:02 |
| uvirtbot | Launchpad bug 1409629 in designate "powerdns database records table missing 'disabled' column" [Undecided,In progress] | 11:02 |
| uvirtbot | Launchpad bug 1409824 in designate "The API does not return a status field for recordsets" [Undecided,New] | 11:02 |
| untriaged-bot | https://bugs.launchpad.net/designate/+bug/1408202 | 11:02 |
| uvirtbot | Launchpad bug 1408202 in designate "Statuses in Pool Manager Cache Are Persistent" [Low,New] | 11:02 |
| *** untriaged-bot has quit IRC | 11:02 | |
| *** jmcbride has joined #openstack-dns | 11:09 | |
| *** jmcbride has quit IRC | 11:47 | |
| *** mwagner_lap has quit IRC | 12:00 | |
| *** chlong has joined #openstack-dns | 12:06 | |
| *** tryggvil has joined #openstack-dns | 12:28 | |
| *** ryanpetrello has joined #openstack-dns | 12:53 | |
| *** EricGonczer_ has joined #openstack-dns | 12:55 | |
| *** boris-42 has joined #openstack-dns | 12:56 | |
| *** chlong has quit IRC | 13:02 | |
| *** EricGonc_ has joined #openstack-dns | 13:04 | |
| *** EricGonczer_ has quit IRC | 13:07 | |
| *** EricGonc_ has quit IRC | 13:31 | |
| *** mwagner_lap has joined #openstack-dns | 13:33 | |
| *** vinod1 has joined #openstack-dns | 14:14 | |
| *** nkinder has quit IRC | 14:20 | |
| *** richm has joined #openstack-dns | 14:34 | |
| *** jmcbride has joined #openstack-dns | 14:35 | |
| *** jmcbride has quit IRC | 14:38 | |
| *** jmcbride has joined #openstack-dns | 14:39 | |
| *** EricGonczer_ has joined #openstack-dns | 14:54 | |
| *** eandersson has quit IRC | 14:56 | |
| *** eandersson has joined #openstack-dns | 14:56 | |
| *** jmcbride has quit IRC | 15:01 | |
| *** jmcbride has joined #openstack-dns | 15:02 | |
| *** nkinder has joined #openstack-dns | 15:10 | |
| *** jmcbride has quit IRC | 15:31 | |
| *** nihilifer has quit IRC | 15:36 | |
| *** paul_glass has joined #openstack-dns | 15:37 | |
| *** csoukup has joined #openstack-dns | 15:37 | |
| *** richm has quit IRC | 15:38 | |
| *** vinod1 has quit IRC | 15:40 | |
| *** richm has joined #openstack-dns | 15:40 | |
| *** vinod1 has joined #openstack-dns | 15:41 | |
| *** jmcbride has joined #openstack-dns | 15:51 | |
| *** jmcbride has quit IRC | 15:52 | |
| *** jmcbride has joined #openstack-dns | 15:53 | |
| *** ryanpetrello_ has joined #openstack-dns | 16:04 | |
| *** ryanpetrello has quit IRC | 16:08 | |
| *** ryanpetrello_ is now known as ryanpetrello | 16:08 | |
| *** uvirtbot has quit IRC | 16:25 | |
| *** vinod1 has quit IRC | 16:30 | |
| *** timsim has joined #openstack-dns | 16:33 | |
| openstackgerrit | Ron Rickard proposed openstack/designate: Ensure Pool Manager Works for Multiple Backend Servers https://review.openstack.org/146246 | 16:43 |
| openstackgerrit | Ron Rickard proposed openstack/designate: WIP Add Unit Tests for Pool Manager https://review.openstack.org/147241 | 16:43 |
| *** rjrjr_ has joined #openstack-dns | 16:47 | |
| timsim | IRC meet? | 17:00 |
| Kiall | Yep | 17:00 |
| *** untriaged-bot has joined #openstack-dns | 17:02 | |
| untriaged-bot | Untriaged bugs so far: | 17:02 |
| untriaged-bot | https://bugs.launchpad.net/designate/+bug/1289444 | 17:02 |
| untriaged-bot | https://bugs.launchpad.net/designate/+bug/1409629 | 17:02 |
| untriaged-bot | https://bugs.launchpad.net/designate/+bug/1409824 | 17:02 |
| untriaged-bot | https://bugs.launchpad.net/designate/+bug/1408202 | 17:02 |
| *** untriaged-bot has quit IRC | 17:02 | |
| *** vinod1 has joined #openstack-dns | 17:04 | |
| *** penick has joined #openstack-dns | 17:05 | |
| *** vinod1 has quit IRC | 17:05 | |
| *** vinod1 has joined #openstack-dns | 17:07 | |
| *** tryggvil has quit IRC | 17:08 | |
| *** tryggvil has joined #openstack-dns | 17:10 | |
| openstackgerrit | Graham Hayes proposed openstack/designate: Moved to oslo_db namespace https://review.openstack.org/147251 | 17:11 |
| *** jmcbride has quit IRC | 17:14 | |
| *** rmoe has quit IRC | 17:17 | |
| *** jmcbride has joined #openstack-dns | 17:36 | |
| *** rmoe has joined #openstack-dns | 17:37 | |
| *** jmcbride1 has joined #openstack-dns | 17:39 | |
| *** jmcbride has quit IRC | 17:41 | |
| rjrjr_ | vinod1: are you on? | 17:44 |
| *** rmoe has quit IRC | 17:44 | |
| *** rmoe has joined #openstack-dns | 17:45 | |
| *** jordanP has quit IRC | 17:48 | |
| *** jmcbride1 has quit IRC | 17:48 | |
| *** jmcbride has joined #openstack-dns | 17:48 | |
| vinod1 | hi rjrjr_ | 17:56 |
| *** kbyrne has quit IRC | 17:56 | |
| Kiall | https://review.openstack.org/#/c/147012/ and https://review.openstack.org/#/c/147251/ are two trivial reviews for oslo.* -> oslo_* switchover's.. vinod1 / betsy culd you through a quick eye over them before they go out of date? :) | 17:58 |
| betsy | kiall: sure | 17:59 |
| vinod1 | kiall - i had question for https://review.openstack.org/#/c/147012/ | 17:59 |
| vinod1 | Should requirements.txt be updated too? | 17:59 |
| *** penick has quit IRC | 17:59 | |
| Kiall | That was already updated a while back, currently, both oslo.* and oslo_* will work for all the oslo packages | 18:00 |
| vinod1 | the requirements.txt currently has oslo.middleware - so is that fine? | 18:00 |
| Kiall | Yep - pypi package is still called that | 18:01 |
| vinod1 | ok | 18:01 |
| *** penick has joined #openstack-dns | 18:03 | |
| Kiall | I'm 99% sure the oslo pypi packages will always be called that, but the code under oslo_* | 18:03 |
| Kiall | renaming the pypi package has much more fallout than renaming the code inside and leaving a backwards compat shim under oslo.* ;) | 18:04 |
| vinod1 | Okay both the changes are approved - one by Betsy and another by me | 18:05 |
| betsy | Or in one case, by both of us. :D | 18:06 |
| *** chlong has joined #openstack-dns | 18:10 | |
| Kiall | ;) | 18:11 |
| rjrjr_ | vinod1: sorry, was working on fixes for your comments. what do you mean by the first comment here: | 18:12 |
| rjrjr_ | https://review.openstack.org/#/c/146246/1/designate/pool_manager/service.py | 18:12 |
| rjrjr_ | in the code (remember, this code relies on a persistent status) the update_status serial reflects the serial number of the domain from the server. | 18:14 |
| vinod1 | i was thinking of the case when we create a domain - the domain is still pending and and now some changes occur | 18:14 |
| openstackgerrit | Merged openstack/designate: Switch to oslo_middleware namespace https://review.openstack.org/147012 | 18:15 |
| rjrjr_ | domain is pending to be created? | 18:15 |
| vinod1 | but yesterday evening i was looking some more at the code - and i don't think it matters | 18:15 |
| rjrjr_ | if that is the case, no update_status will exist. | 18:15 |
| vinod1 | so you can ignore the comment | 18:15 |
| rjrjr_ | okay. | 18:15 |
| rjrjr_ | you'll be happy to know i unraveled some of the methods calling methods. | 18:16 |
| vinod1 | what are you referring to? | 18:16 |
| rjrjr_ | let me post the new code up in paste. just a sec. | 18:16 |
| vinod1 | ok - will wait for it | 18:16 |
| rjrjr_ | http://paste.openstack.org/show/157996/ | 18:17 |
| rjrjr_ | you had a comment last week about too many nested methods. for this particular code, i unraveled that so there are not multiple for-loops, one try-except, etc. | 18:18 |
| rjrjr_ | anyway, the code is in a state where it will be easy for me to remove the statuses from the cache. will work on that right after i get the unit tests done. | 18:19 |
| openstackgerrit | Kiall Mac Innes proposed openstack/designate: Update Vagrantfile with new Ubuntu box https://review.openstack.org/147266 | 18:22 |
| vinod1 | rjrjr_: I see that you uploaded patchset 2 for https://review.openstack.org/#/c/146246/2. But I do not see any difference between that and patchset 1 | 18:23 |
| Kiall | vinod1: it likely auto-rebased over master | 18:24 |
| Kiall | (I tend to `git review -R` to avoid that, and only rebase when I suspect a merge conflict is likely..) | 18:24 |
| *** tryggvil has quit IRC | 18:25 | |
| Kiall | vinod1: one way to notice that BTW is - Your -1 on PS1 "stuck" around for PS2 :) | 18:27 |
| *** tryggvil has joined #openstack-dns | 18:30 | |
| *** tryggvil has quit IRC | 18:31 | |
| openstackgerrit | Merged openstack/designate: Fix powerdns db table records missing column disabled https://review.openstack.org/146391 | 18:31 |
| rjrjr_ | vinod1: what kiall said. :) | 18:34 |
| *** mwagner_lap has quit IRC | 18:35 | |
| openstackgerrit | Merged openstack/designate: Imported Translations from Transifex https://review.openstack.org/147071 | 18:38 |
| openstackgerrit | Kiall Mac Innes proposed openstack/designate: Add .coveragerc configuration file https://review.openstack.org/147270 | 18:47 |
| Kiall | Would be good to get ^ merged before tomorrow, filters some unwanted stuff from the coverage reports | 18:47 |
| *** penick has quit IRC | 18:49 | |
| timsim | Apparently the deadline for Vancouver summit talk submissions is Feb 9. I guess we should talk about that at some point. | 18:49 |
| vinod1 | what does the ignore-errors do - what errors is that ignoring? | 18:49 |
| *** penick has joined #openstack-dns | 18:50 | |
| *** penick_ has joined #openstack-dns | 18:52 | |
| Kiall | vinod1: I'm honestly not 100% sure! I robbed nova's config file ;) | 18:52 |
| Kiall | FYI - I've also submitted a change to the CI system to run a coverage report as part of the initial check pipeline... | 18:52 |
| vinod1 | is that to openstack-infra? | 18:53 |
| Kiall | Yep - https://review.openstack.org/#/c/147272/ | 18:53 |
| *** penick has quit IRC | 18:55 | |
| *** penick_ is now known as penick | 18:55 | |
| Kiall | Coverage report: 64% after the config file addition.. 59% before.. Slightly better ;) | 18:56 |
| vinod1 | so the post section had coverage before? | 18:58 |
| vinod1 | kiall do you know how much time the coverage adds to the check pipeline? | 19:01 |
| Kiall | It shouldn't add any time, it will run in parallel to the other longer running jobs like devstack-pdns/bind and rally | 19:01 |
| Kiall | On occasion, when the CI system is backed up, it could in theory make us wait a little while to get another slave to run on.. But usually the contention is for the devstack slaves rather than bare slaves this + unit tests run on .. | 19:02 |
| *** penick has quit IRC | 19:04 | |
| *** penick has joined #openstack-dns | 19:06 | |
| openstackgerrit | Kiall Mac Innes proposed openstack/designate: Remove dead SQLAlchemy code https://review.openstack.org/147275 | 19:06 |
| openstackgerrit | Kiall Mac Innes proposed openstack/designate: Remove dead SQLAlchemy code https://review.openstack.org/147275 | 19:19 |
| openstackgerrit | Kiall Mac Innes proposed openstack/designate: Remove dead designate.wsgi https://review.openstack.org/147278 | 19:22 |
| *** jmcbride has quit IRC | 19:24 | |
| *** penick has quit IRC | 19:27 | |
| *** jmcbride has joined #openstack-dns | 19:36 | |
| *** nkinder has quit IRC | 19:38 | |
| *** GonZo2000 has joined #openstack-dns | 19:46 | |
| openstackgerrit | Ron Rickard proposed openstack/designate: Ensure Pool Manager Works for Multiple Backend Servers https://review.openstack.org/146246 | 19:46 |
| openstackgerrit | Ron Rickard proposed openstack/designate: WIP Add Unit Tests for Pool Manager https://review.openstack.org/147241 | 19:49 |
| *** mwagner_lap has joined #openstack-dns | 19:56 | |
| *** paul_glass has quit IRC | 20:03 | |
| *** jmcbride has quit IRC | 20:04 | |
| *** jmcbride has joined #openstack-dns | 20:14 | |
| openstackgerrit | Merged openstack/designate: Moved to oslo_db namespace https://review.openstack.org/147251 | 20:20 |
| *** jmcbride has quit IRC | 20:33 | |
| *** jmcbride has joined #openstack-dns | 20:37 | |
| *** paul_glass has joined #openstack-dns | 20:57 | |
| timsim | rjrjr_: around? | 20:58 |
| *** paul_glass has quit IRC | 21:02 | |
| rjrjr_ | i'm here tim. | 21:09 |
| rjrjr_ | timsim: i'm here. | 21:09 |
| timsim | Have you given much thought to that 'second' periodic sync job? I think the current one was going to be changed to just reading from the PM cache, and then there was going to be another one that was going to sync *everything* | 21:10 |
| *** paul_glass has joined #openstack-dns | 21:10 | |
| rjrjr_ | we have 2 periodic syncs right now. one that "fixes" things and another that runs a periodic sync. when i remove the cache entries, that second one will be the sync *everything* one. | 21:11 |
| rjrjr_ | periodic_recovery and periodic_sync. | 21:11 |
| rjrjr_ | i understand it doesn't exactly do that now. | 21:11 |
| rjrjr_ | i have a good idea on how to make all this happen. i wanted to get the unit tests done and work on that next. tell vinod to quit -1'ing my stuff and things will go faster. :) | 21:13 |
| timsim | I have no control over vinod1 ;) he's a man on a mission. | 21:13 |
| rjrjr_ | vinod's fine. i'm just kidding about that. he is very good at finding issues. | 21:13 |
| *** nkinder has joined #openstack-dns | 21:14 | |
| timsim | For the periodic sync (*everything*) is the plan to basically NOTIFY every zone? | 21:14 |
| rjrjr_ | every server for every domain that has the domain created, yes. | 21:15 |
| rjrjr_ | no point in notifying servers that do not have the domain created. | 21:15 |
| timsim | Right. | 21:15 |
| rjrjr_ | right now, it relies on the cache for which servers to notify. once the cache is cleaned out on successful updates, that won't be the case. | 21:16 |
| timsim | Does it make more sense to take the changes for a specified configurable time. Say (24 hours to 1 hour ago, or the beginning of time and now) and send SOA queries for those zones to make sure that they've been done, and if not, do the needful thing? | 21:17 |
| timsim | Because sometimes you'll have things that won't respond to a notify, that need to be created/deleted, etc. | 21:17 |
| rjrjr_ | if the domain is in the process of being deleted on a server, we can ignore those updates too. i don't think the upstream prevents that though, but it should. | 21:19 |
| rjrjr_ | for example, i submit a request to delete a domain, but one server fails and the domain is pending delete. we still allow updates to that domain (that is code outside pool manager though.) | 21:20 |
| rjrjr_ | here is my thought, there are going to be a few situations like this. let me document them and we can talk about those cases next week. | 21:20 |
| rjrjr_ | i'm sure you and vinod can come up with others too. | 21:21 |
| rjrjr_ | but, by friday, i want the cache to be a true cache, so we can work from that point. | 21:21 |
| timsim | Sure. I've just been thinking, and disucssing with some folks, and I think that sync process can be really valuable, and I want to make sure we think hard on it. | 21:21 |
| rjrjr_ | i'm not keen on having sync remove domains from unmanaged servers though. :) | 21:22 |
| timsim | Definitely not ones that Designate has never managed. | 21:22 |
| rjrjr_ | i know i heard that last week. remember, we went with unmanaged for our default. that means the server is not managed by pool manager, meaning the admin set up the server and we shouldn't be touching existing domains on those servers. | 21:23 |
| rjrjr_ | when we talk about managed servers (so far these are just concepts and not reality in the code) then i can see the pool manager completely controlling the domains on the server. | 21:23 |
| *** jmcbride has quit IRC | 21:24 | |
| rjrjr_ | i digress. | 21:24 |
| timsim | This process should still be able to be used with a "unmanaged" server though. | 21:25 |
| rjrjr_ | then i want a flag that will determine how those cases are handled. | 21:25 |
| rjrjr_ | we can talk about this next week though. peripheral to where i want to be by friday. | 21:26 |
| timsim | It'll definitely have to be thought out well. But if done right, that process has huge potential from our point of view. We can't have it deleting things Designate doesn't/hasn't managed either. | 21:26 |
| timsim | Yeah, for sure. | 21:26 |
| rjrjr_ | okay, let me finish the unit tests today, get vinod to +1 everything, and i'll have code to cleanup the cache by friday. | 21:27 |
| rjrjr_ | the biggest tests I have not run are when we have multiple pool manager instances. as far as multiple backend instances, i feel we have a good grasp on that right now and it works. | 21:28 |
| rjrjr_ | i hope that will be addressed tomorrow with our sprint. | 21:29 |
| timsim | Sounds like something to be functionally tested, rather than with a unit test. | 21:29 |
| rjrjr_ | exactly. | 21:30 |
| rjrjr_ | unit tests *will* cover multiple backends though. i'm making sure of that. | 21:30 |
| openstackgerrit | Merged openstack/designate: Add .coveragerc configuration file https://review.openstack.org/147270 | 21:31 |
| rjrjr_ | i'm not sure if we have tests for multiple instance of any of our components though. | 21:32 |
| rjrjr_ | 2 centrals, 2 mdns, 2 api, 2 sink, etc. | 21:32 |
| rjrjr_ | maybe we do and i just haven't stumbled across that code yet. | 21:32 |
| *** jmcbride has joined #openstack-dns | 21:42 | |
| *** jmcbride has quit IRC | 21:44 | |
| *** jmcbride has joined #openstack-dns | 21:44 | |
| *** jmcbride has quit IRC | 21:45 | |
| *** chlong has quit IRC | 21:47 | |
| *** jmcbride has joined #openstack-dns | 21:49 | |
| Kiall | grr @ merge conflicts -_- | 21:50 |
| openstackgerrit | Kiall Mac Innes proposed openstack/designate: Remove dead SQLAlchemy code https://review.openstack.org/147275 | 21:51 |
| openstackgerrit | Kiall Mac Innes proposed openstack/designate: Remove dead designate.wsgi https://review.openstack.org/147278 | 21:51 |
| Kiall | vinod1 / betsy - when you get a chance, can you re-review this one? https://review.openstack.org/#/c/147275/ merge failed and needed a rebase -_- | 22:33 |
| vinod1 | kiall - got a chance - rereviewed :-) | 22:37 |
| Kiall | Excellent :) Thanks.. | 22:37 |
| Kiall | Eyeballing the coverage reports identified some obvious dead code - may as well remove it before we go write tests for it ;) | 22:38 |
| *** paul_glass1 has joined #openstack-dns | 22:38 | |
| *** jmcbride has quit IRC | 22:39 | |
| *** paul_glass has quit IRC | 22:40 | |
| vinod1 | ah - so now all the dead code changes - make sense | 22:41 |
| Kiall | Yea, Just identifying areas - seeing code with 0% makes me think it's A) totally untested, and B) totally unsed ;) | 22:43 |
| openstackgerrit | Merged openstack/designate: Update Vagrantfile with new Ubuntu box https://review.openstack.org/147266 | 22:44 |
| Kiall | e.g. lots of dead methods in here: http://logs.openstack.org/75/147275/2/check/designate-coverage/59b584d/cover/designate_rpc.html | 22:44 |
| *** csoukup has quit IRC | 22:47 | |
| *** ryanpetrello has quit IRC | 23:02 | |
| *** EricGonczer_ has quit IRC | 23:02 | |
| *** ryanpetrello has joined #openstack-dns | 23:03 | |
| *** timsim has quit IRC | 23:05 | |
| openstackgerrit | Kiall Mac Innes proposed openstack/designate: Moved to oslo_utils namespace https://review.openstack.org/147331 | 23:26 |
| *** rjrjr_ has quit IRC | 23:29 | |
| *** paul_glass1 has quit IRC | 23:32 | |
| openstackgerrit | Merged openstack/designate: Remove dead SQLAlchemy code https://review.openstack.org/147275 | 23:38 |
| openstackgerrit | Merged openstack/designate: Remove dead designate.wsgi https://review.openstack.org/147278 | 23:39 |
| *** csoukup has joined #openstack-dns | 23:46 | |
| *** ryanpetrello has quit IRC | 23:46 | |
| *** vinod1 has quit IRC | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!