| *** betsy has joined #openstack-dns | 00:06 | |
| *** betsy has quit IRC | 00:30 | |
| *** shakayumi is now known as shakamunyi | 00:59 | |
| *** betsy has joined #openstack-dns | 01:09 | |
| *** betsy has quit IRC | 01:16 | |
| *** nosnos has joined #openstack-dns | 01:38 | |
| *** darshan104 has quit IRC | 01:43 | |
| *** shakayumi has joined #openstack-dns | 01:46 | |
| *** shakamunyi has quit IRC | 01:49 | |
| *** vinod1 has joined #openstack-dns | 02:25 | |
| *** vinod1 has quit IRC | 03:11 | |
| *** vinod1 has joined #openstack-dns | 03:54 | |
| *** vinod1 has quit IRC | 03:55 | |
| *** Krast has joined #openstack-dns | 03:56 | |
| *** nkinder has quit IRC | 04:34 | |
| *** nkinder has joined #openstack-dns | 04:35 | |
| *** nosnos has quit IRC | 05:59 | |
| *** nosnos has joined #openstack-dns | 06:01 | |
| *** darshan104 has joined #openstack-dns | 06:19 | |
| *** tryggvil has joined #openstack-dns | 09:29 | |
| *** mwagner_lap has joined #openstack-dns | 09:58 | |
| *** RaginBajin has joined #openstack-dns | 11:31 | |
| *** mwagner_lap has quit IRC | 12:28 | |
| *** darshan104 has quit IRC | 12:44 | |
| *** darshan104 has joined #openstack-dns | 12:53 | |
| *** darshan104 has quit IRC | 12:57 | |
| *** richm has joined #openstack-dns | 13:04 | |
| *** nkinder has quit IRC | 13:10 | |
| *** darshan104 has joined #openstack-dns | 13:13 | |
| *** darshan104 has quit IRC | 13:17 | |
| *** eankutse has joined #openstack-dns | 13:17 | |
| *** darshan104 has joined #openstack-dns | 13:17 | |
| *** darshan104 has quit IRC | 13:22 | |
| *** darshan104 has joined #openstack-dns | 13:22 | |
| *** darshan104 has quit IRC | 13:27 | |
| *** vinod1 has joined #openstack-dns | 13:36 | |
| *** vinod1 has quit IRC | 13:38 | |
| *** darshan104 has joined #openstack-dns | 13:38 | |
| *** darshan104 has quit IRC | 13:43 | |
| *** darshan104 has joined #openstack-dns | 13:45 | |
| *** betsy has joined #openstack-dns | 13:46 | |
| *** darshan104 has quit IRC | 13:50 | |
| *** mwagner_lap has joined #openstack-dns | 13:52 | |
| *** darshan104 has joined #openstack-dns | 13:52 | |
| *** nkinder has joined #openstack-dns | 13:56 | |
| *** darshan104 has quit IRC | 13:57 | |
| *** Krast_ has joined #openstack-dns | 14:04 | |
| *** Krast has quit IRC | 14:11 | |
| *** nosnos has quit IRC | 14:16 | |
| *** mwagner_lap has quit IRC | 14:23 | |
| *** mwagner_lap has joined #openstack-dns | 14:24 | |
| *** timsim has joined #openstack-dns | 14:29 | |
| *** timsim has joined #openstack-dns | 14:30 | |
| *** vinod1 has joined #openstack-dns | 14:33 | |
| *** mwagner_lap has quit IRC | 14:34 | |
| Kiall | betsy: back in the office? | 14:34 |
|---|---|---|
| betsy | Heya. | 14:35 |
| *** mwagner_lap has joined #openstack-dns | 14:35 | |
| betsy | Yep. I’m back | 14:35 |
| betsy | What’s up? | 14:37 |
| *** mwagner_lap has quit IRC | 14:41 | |
| *** mwagner_lap has joined #openstack-dns | 14:41 | |
| *** paul_glass has joined #openstack-dns | 14:46 | |
| *** paul_glass has quit IRC | 14:47 | |
| *** paul_glass has joined #openstack-dns | 14:47 | |
| *** mwagner_lap has quit IRC | 14:49 | |
| *** mwagner_lap has joined #openstack-dns | 14:50 | |
| *** rustlebee is now known as russellb | 14:52 | |
| *** darshan104 has joined #openstack-dns | 14:53 | |
| *** darshan104 has quit IRC | 14:57 | |
| *** paul_glass has quit IRC | 15:02 | |
| *** paul_glass has joined #openstack-dns | 15:19 | |
| *** vinod1 has quit IRC | 15:24 | |
| Kiall | betsy: sorry, had a call | 15:25 |
| betsy | np | 15:25 |
| Kiall | re the expose NS/SOA stuff, I took a stab and writing a DB migration to pre-generate them all, but didn't have time to update your patch to match ;) .. Wanted to make sure you didn't re-implement! | 15:26 |
| betsy | Oh, I started working on it over the weekend | 15:26 |
| Kiall | hah - I was told you were on holidays! I didn't expect you to be back until today | 15:26 |
| betsy | I got back on Friday | 15:26 |
| betsy | Doesn’t seem too hard, but if you’ve already done it, go ahead and check it in | 15:27 |
| Kiall | http://paste.openstack.org/show/u1xb5ChCVjmezdbLlfsx/ was where I got to (with lots of room for improvement ;)) | 15:27 |
| betsy | I was just getting ready to test mine | 15:27 |
| Kiall | feel free to ignore mine :) | 15:29 |
| betsy | hmm. Mine’s not too different. I just did everything in the one loop thru the domains - create the SOA recordset, the SOA record, the NS recordset and the NS record | 15:30 |
| betsy | Oh, you did the same thing | 15:30 |
| betsy | At first glance I thought you were doing the ns records separately | 15:30 |
| betsy | Why do you have managed set to True for the NS recordsets and records? | 15:31 |
| Kiall | Well, we need to ensure users can't edit the, for example, SOA record or inbuilt NS records | 15:32 |
| Kiall | in-theory - managed=True is meant to do that, but I went looking for where that's implemented, and I think that code got refactored away at some point :/ | 15:32 |
| betsy | I also didn’t check to see if there were existing NS recordsets. I thought about it, but was thinking there wouldn’t be any | 15:34 |
| betsy | Is that not correct? | 15:34 |
| Kiall | Yes, there can be an existing NS RRset | 15:34 |
| betsy | Oh, good to know. But not existing SOAs? | 15:35 |
| *** vinod1 has joined #openstack-dns | 15:35 | |
| Kiall | No, SOA will be rejected as an invalid rtype, NS is allowed though - e.g. for delegating a subdomain to another nameserver | 15:35 |
| Kiall | and we never blocked creating NS records for the domain itself, so it seems we have some customers doing that :) | 15:36 |
| betsy | Oh, true. Duh. I’m adding that now. | 15:36 |
| betsy | As far as the missing unique constraint - I didn’t run into that in testing, but had to add it to get it to pass tox | 15:37 |
| betsy | I guess that’s running sqlite | 15:37 |
| Kiall | Yea, SQLite drops indexes when you ALTER TABLE, so they have to be re-added (but only for SQLite..) | 15:37 |
| Kiall | It's *really* annoying.. I always forget ;) | 15:38 |
| betsy | Yeah. I saw your comment and added that. | 15:38 |
| betsy | I couldn’t figure out why it wouldn’t pass tox on that, because it was fine for me. | 15:38 |
| Kiall | Yea, it's silently dropped inside of SQLite, so there's not even any logs etc.. It just goes *poof* | 15:38 |
| betsy | Oh, I was also wondering about the created_ad and updated_at | 15:39 |
| betsy | Why do those need to be explicitly added? | 15:40 |
| betsy | Just to make them match the zone info because they should have been created with the zone? | 15:41 |
| betsy | And I guess you didn’t add the updated_date, but the example I was looking at — 035 — did | 15:41 |
| Kiall | well, everything needs a created_at - that should never be NULL.. and I figured the zone creation date was a reasonable choice | 15:42 |
| betsy | I assumed that was created by the db when it was inserted | 15:43 |
| Kiall | updated_at .. I didn't really think about it, but I suppose NOW() would be a reasonable choice? | 15:43 |
| betsy | ok. I’ll add that | 15:43 |
| Kiall | It's possible it is, I didn't think of that ;) | 15:43 |
| betsy | Ok. I’ll play with it and see | 15:43 |
| *** rmoe has quit IRC | 15:48 | |
| *** rmoe has joined #openstack-dns | 15:57 | |
| *** zain1 has joined #openstack-dns | 15:59 | |
| *** zain has quit IRC | 15:59 | |
| vinod1 | kiall: I had a question on your sqlalchemy core change - https://review.openstack.org/#/c/109833/ | 16:00 |
| vinod1 | What is the reasoning for creating this file - https://review.openstack.org/#/c/109833/3/designate/sqlalchemy/utils.py? | 16:00 |
| Kiall | heya | 16:05 |
| Kiall | So, oslo.db has a method that is 99% the same, but it's build for ORM - where the "SELECT .. WHERE" function is called filter_by rather than "where" | 16:06 |
| Kiall | so, I had to copy+edit.. At some point we should get oslo.db updated to support both, but even if we did today, it'll be a while before we can require that version of oslo.db as the minimun! | 16:07 |
| Kiall | minimum* | 16:07 |
| vinod1 | Thanks Kiall for the clarification | 16:08 |
| *** zain has joined #openstack-dns | 16:11 | |
| *** paul_glass has quit IRC | 16:12 | |
| *** zain1 has quit IRC | 16:12 | |
| *** paul_glass has joined #openstack-dns | 16:13 | |
| *** mwagner_lap has quit IRC | 16:23 | |
| *** paul_glass has quit IRC | 16:35 | |
| *** zain has quit IRC | 16:37 | |
| *** zain1 has joined #openstack-dns | 16:37 | |
| *** crc32 has joined #openstack-dns | 16:55 | |
| *** paul_glass has joined #openstack-dns | 17:21 | |
| *** zain2 has joined #openstack-dns | 17:21 | |
| *** zain1 has quit IRC | 17:25 | |
| *** vinod1 has quit IRC | 17:32 | |
| *** vinod1 has joined #openstack-dns | 17:49 | |
| *** darshan104 has joined #openstack-dns | 17:50 | |
| *** rossk has joined #openstack-dns | 17:52 | |
| *** darshan104 has quit IRC | 17:54 | |
| *** darshan104 has joined #openstack-dns | 18:15 | |
| vinod1 | kiall: With the requirements.txt file, I now see an error - No distributions matching the version for oslo.config>=1.4.0.0a3 | 18:30 |
| Kiall | vinod1: you could be on too old a version of pip? | 18:30 |
| Kiall | https://pypi.python.org/pypi/oslo.config <-- 1.4.0.0a3 exists, but it's an "wheel" rather than tarball, which is a new-ish format | 18:31 |
| vinod1 | Thanks Kiall - that worked | 18:32 |
| Kiall | Those wheels have caused untold amounts of pain for people ;) | 18:33 |
| *** vinod1 has quit IRC | 18:37 | |
| *** jaiswaro has joined #openstack-dns | 19:33 | |
| rjrjr | anyone get a chance to look at this: https://review.openstack.org/#/c/114397/ | 19:39 |
| *** jaiswaro has quit IRC | 19:49 | |
| *** shakayumi has quit IRC | 19:53 | |
| *** nkinder has quit IRC | 19:54 | |
| *** simonmcc__ has joined #openstack-dns | 19:57 | |
| *** zain2 has quit IRC | 19:58 | |
| *** betsy has quit IRC | 19:58 | |
| *** simonmcc_ has quit IRC | 19:58 | |
| *** simonmcc__ is now known as simonmcc_ | 19:59 | |
| *** tryggvil has quit IRC | 19:59 | |
| *** betsy has joined #openstack-dns | 20:01 | |
| *** zain has joined #openstack-dns | 20:02 | |
| *** vinod1 has joined #openstack-dns | 20:33 | |
| *** paul_glass has quit IRC | 20:46 | |
| *** RaginBajin has quit IRC | 20:48 | |
| *** nkinder has joined #openstack-dns | 21:10 | |
| *** EricGonczer_ has joined #openstack-dns | 21:11 | |
| *** EricGonczer_ has quit IRC | 21:23 | |
| *** eankutse has quit IRC | 21:30 | |
| *** timsim has quit IRC | 21:41 | |
| *** crc32 has quit IRC | 21:46 | |
| *** vinod1 has quit IRC | 22:17 | |
| openstackgerrit | A change was merged to openstack/designate: Migrate to SQLAlchemy Core https://review.openstack.org/109833 | 22:32 |
| *** EricGonczer_ has joined #openstack-dns | 22:56 | |
| *** eankutse has joined #openstack-dns | 23:10 | |
| *** eankutse has quit IRC | 23:14 | |
| *** darshan104 has quit IRC | 23:20 | |
| *** crc32 has joined #openstack-dns | 23:21 | |
| *** vinod1 has joined #openstack-dns | 23:23 | |
| *** vinod1 has quit IRC | 23:23 | |
| *** darshan104 has joined #openstack-dns | 23:24 | |
| *** vinod1 has joined #openstack-dns | 23:26 | |
| *** vinod1 has quit IRC | 23:26 | |
| *** EricGonczer_ has quit IRC | 23:41 | |
| *** darshan104 has quit IRC | 23:41 | |
| *** darshan104 has joined #openstack-dns | 23:43 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!