| *** m1crofarmer is now known as m1crofarmer_ | 02:09 | |
| *** Vickyiscorg has joined #openstack-dns | 04:47 | |
| *** openstackgerrit has quit IRC | 05:00 | |
| *** openstackgerrit has joined #openstack-dns | 05:01 | |
| *** ChanServ sets mode: +v openstackgerrit | 05:01 | |
| *** Vickyiscorg has quit IRC | 05:24 | |
| *** Vickyiscorg has joined #openstack-dns | 05:35 | |
| *** Vickyiscorg has quit IRC | 05:48 | |
| *** Vickyiscorg has joined #openstack-dns | 05:52 | |
| *** Vickyiscorg has quit IRC | 06:09 | |
| *** zane has joined #openstack-dns | 07:53 | |
| *** zane has quit IRC | 08:46 | |
| Kiall | spam time again, sorry ;) | 12:00 |
|---|---|---|
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Ensure RPC serializes all types to primitives https://review.openstack.org/104505 | 12:00 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: WIP: Update's should use objects https://review.openstack.org/103587 | 12:00 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Object fields should not be marked changed if the value has not changed https://review.openstack.org/104531 | 12:01 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Don't create new objects when doing a create_* https://review.openstack.org/103558 | 12:01 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Track the original/persisted values in Objects https://review.openstack.org/105013 | 12:01 |
| betsy | kiall: how do these changes affect the Recordset/Record api changes I’ve made? Have you had a chance to look at those yet? | 12:53 |
| Kiall | betsy: hopefully, very little will need to change in your patch | 12:53 |
| Kiall | If it does, then I've done it wrong :D | 12:53 |
| betsy | That’s what I thought, especially with the first one, but you said you hadn’t done Recordsets or Records on the WIP one, so I was just wondering | 12:54 |
| betsy | I was wondering if you’ve had a chance to review mine yet | 12:54 |
| Kiall | I've just about got RecordSets done.. everything but the API sides. let me push that up so you can see the changes to central's update_recordset method | 12:55 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: WIP: Update's should use objects https://review.openstack.org/103587 | 12:57 |
| Kiall | betsy: https://review.openstack.org/#/c/103587/13/designate/central/rpcapi.py | 12:57 |
| betsy | Ah, I see. Makes sense. | 12:59 |
| Kiall | re your change, I've given it a quick look, but not enough to have any real comments yet :( | 12:59 |
| Kiall | I've been trying to get ^ change done whenever I have a chance to code ;) | 12:59 |
| betsy | Lots of work in that, but it’ll be a good change | 12:59 |
| Kiall | Yea, The change itself is fairly small, all the dependant patchsets are bigger ;) | 13:00 |
| betsy | Yep. Those kind of changes cascade everywhere, which is what I ran into making my changes | 13:01 |
| betsy | Are the ones that aren’t WIP ready to go in? I can review them this morning | 13:01 |
| Kiall | Yea - I've been trying really hard to keep the patchsets to 1 concept each, hopefully making them easier to review ;) | 13:01 |
| Kiall | It's slow going though.. I've hit about 10 roadblocks as this point and had to circle back to fix those before moving forward :( | 13:02 |
| betsy | You’ve done a great job. I couldn’t figure out how to make mine any smaller. | 13:02 |
| betsy | Yep. Same problem I ran into. Going around in circles | 13:03 |
| betsy | I’d like to get mine merged in before there’s a lot of conflicts with other changes | 13:04 |
| betsy | Assuming, I don’t have a lot of changes to make, of course. :D | 13:04 |
| Kiall | Hah - I think we're going to have conflicts regardless ;) | 13:05 |
| Kiall | We've both touched wayy too many files :D | 13:05 |
| betsy | I know, right? | 13:06 |
| Kiall | Yea, once I'm done, hopefully today, I'll circle back to your patch and A) review it... B) try and identify any conflicts etc | 13:07 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: WIP: Update's should use objects https://review.openstack.org/103587 | 13:31 |
| openstackgerrit | A change was merged to openstack/designate: Ensure RPC serializes all types to primitives https://review.openstack.org/104505 | 13:44 |
| openstackgerrit | A change was merged to openstack/designate: Object fields should not be marked changed if the value has not changed https://review.openstack.org/104531 | 13:44 |
| betsy | kiall: thx | 13:46 |
| Kiall | Only Records and Blacklists TODO :D Whey :D | 13:48 |
| Kiall | This is so tedious -_- | 13:48 |
| betsy | refactoring always is :D | 14:22 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: WIP: Update's should use objects https://review.openstack.org/103587 | 14:29 |
| Kiall | Records done :) Blacklists are all that's left :D | 14:29 |
| Kiall | But.. 99.999% sure that bit is going to conflict like mad -_- | 14:30 |
| *** ekarlso has quit IRC | 14:41 | |
| *** ekarlso has joined #openstack-dns | 14:48 | |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Update's should use objects https://review.openstack.org/103587 | 15:21 |
| Kiall | Can't believe that patch is actually finished :D | 15:22 |
| Kiall | betsy: I'm rebasing your change over mine now, doesn't look to be too many conflicts :) | 15:36 |
| Kiall | spotting a few small issues as I do it, but not fixing them, just aiming for a clean rebase | 15:43 |
| betsy | kiall: cool | 15:43 |
| betsy | how do I then get the clean rebased copy? | 15:43 |
| *** sballe__ has joined #openstack-dns | 15:45 | |
| Kiall | betsy: you can fetch it back down from Gerrit with `git review -d <CHANGE NUMBER>` | 15:47 |
| *** sballe_ has quit IRC | 15:48 | |
| Kiall | Rebase done.. Just checking the tests still pass | 15:48 |
| Kiall | and... they explode ;) | 15:48 |
| betsy | :( | 15:49 |
| betsy | do I fetch it in my branch that I was working in? | 15:49 |
| betsy | I’m sure that’s a dumb question, but I suck at git | 15:50 |
| Kiall | it will create a new branch called review/betsy/<topic> | 15:52 |
| Kiall | But - it won't do much until I fix the tests the rebase broke and upload ;) | 15:52 |
| betsy | Yeah, I’ll definitely wait until you’re done | 15:53 |
| Kiall | Down to 11 fails ;) | 15:54 |
| betsy | :) | 15:54 |
| Kiall | I think the main issue is that you updated (Fixed is probably the right word) the storage get_recordset to return the records too.. It seems most of the tests are failing because there's extra data in there | 15:56 |
| betsy | I had those working in my submission | 15:57 |
| Kiall | Yep - all the tests passed before I started the rebase | 15:57 |
| Kiall | git is just bad a merging things "correctly".. | 15:57 |
| betsy | I think I broke over half the almost 500 tests when I made my changes :) | 15:57 |
| betsy | Took me days to fix them all | 15:58 |
| Kiall | ouch .. Yea, I think my changes have touched almost every test too ;) | 15:59 |
| Kiall | Something simple has broke - I've got two main errors - "BadRequest: Moving a recordset between tenants is not allowed" and | 16:01 |
| Kiall | MismatchError: !=: | 16:01 |
| Kiall | reference = [<designate.storage.impl_sqlalchemy.models.Record object at 0x7f1614bb9d50>, | 16:01 |
| Kiall | <designate.storage.impl_sqlalchemy.models.Record object at 0x7f1614bb6a90>] | 16:01 |
| Kiall | actual = ['192.3.3.15', '192.3.3.16'] | 16:01 |
| Kiall | where one list is the models, the other is the text representations | 16:01 |
| Kiall | and the move between tenants stuff is just confusing :) No clue why that's triggered yet | 16:01 |
| Kiall | All the storage tests are passing, that's a start :) | 16:07 |
| *** zane has joined #openstack-dns | 16:18 | |
| Kiall | betsy: re that missing tests bug, I'd recommend using my "updates should use objects" commit as a base, as it changes how lots of the storage tests work | 16:22 |
| betsy | Sorry. Not sure exactly what you mean | 16:23 |
| Kiall | `git review -d 103587 && git checkout -b bug/1338246` then work away and commit etc.. Your fix will end up on top of mine, so no rebases necessary | 16:23 |
| betsy | Oh, I see | 16:23 |
| Kiall | Yep - since we know it'll conflict - we may as well do it in the pattern that will merge correctly from the start :) | 16:24 |
| betsy | Yeah. I wasn’t going to do the missing tests bug today. I just stuck my name on it since I did the Blacklists in the first place. I won’t get to it until later this week | 16:25 |
| Kiall | betsy: Anyway - I'm seeing an issue with the combination of your RecordSet and my objects changes, where RecordSet's have a nested list of Records to manage.. | 16:25 |
| betsy | In the storage layer? | 16:26 |
| Kiall | The combination of changes don't play nice .. I'm going to take a step back, fix the Objects to properly handle lists of nested objects, then rebase yours again | 16:26 |
| Kiall | Nah - In isolation, both work nicely.. | 16:26 |
| Kiall | In combination, they don't :'( | 16:26 |
| betsy | ok | 16:26 |
| Kiall | The SQLA model objects find their way outside of the storage layer once our changes merge, which isn't right :'( It should be an easy fix to the objects stuff to handle it though | 16:28 |
| Kiall | (I hope :P) | 16:28 |
| betsy | Yeah. Good luck! | 16:29 |
| Kiall | It'll be easier that my last change, I know that for sure :D | 16:29 |
| betsy | One can only hope. :D | 16:29 |
| Kiall | lol .. not a good start -_- | 16:32 |
| Kiall | Ran 521 (+427) tests in 11.889s (+3.870s) | 16:32 |
| Kiall | FAILED (id=61, failures=316 (+312)) | 16:32 |
| betsy | Good grief! :( | 16:53 |
| Kiall | It's OK.. was my own fault ;) | 17:16 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Iterator methods should be on DictObjectMixin https://review.openstack.org/105020 | 17:45 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement a ListObjectMixin class https://review.openstack.org/105021 | 17:45 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement a ListObjectMixin class https://review.openstack.org/105021 | 18:03 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement a ListObjectMixin class https://review.openstack.org/105021 | 18:16 |
| *** zane has quit IRC | 18:30 | |
| *** zane has joined #openstack-dns | 18:52 | |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement a ListObjectMixin class https://review.openstack.org/105021 | 18:59 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement a ListObjectMixin class https://review.openstack.org/105021 | 19:00 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement a ListObjectMixin class https://review.openstack.org/105021 | 19:07 |
| *** zane has quit IRC | 19:12 | |
| openstackgerrit | Endre Karlson proposed a change to openstack/designate-specs: [designateclient] v1 support for keystone sessions https://review.openstack.org/105033 | 19:58 |
| openstackgerrit | Endre Karlson proposed a change to openstack/designate-specs: [designateclient] v1 support for keystone sessions https://review.openstack.org/105033 | 20:06 |
| ekarlso | betsy: u wanna read spec ? ; p | 20:08 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement a ListObjectMixin class https://review.openstack.org/105021 | 21:29 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement equality methods on DesignateObject https://review.openstack.org/105036 | 21:29 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement equality methods on DesignateObject https://review.openstack.org/105036 | 21:56 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: WIP: Attach records to RecordSet objects https://review.openstack.org/105038 | 21:56 |
| openstackgerrit | Endre Karlson proposed a change to openstack/designate-specs: [designateclient] Bindings for V2 API https://review.openstack.org/105040 | 21:59 |
| betsy | ekarlso: Sure. I’ll try to look at it later tonight | 23:30 |
| *** zane has joined #openstack-dns | 23:30 | |
| *** zane has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!