| *** openstack has joined #openstack-dns | 13:49 | |
| *** ChanServ sets mode: +v openstack | 13:49 | |
| Kiall | So, the to/from_primitive methods already set _obj_changes, and since we recurse, the "nested" objects get the same behaviours | 13:49 |
|---|---|---|
| Kiall | or maybe I'm not understanding the Q :) | 13:49 |
| vinod1 | my question was should it behave like from_sqla - not triggering object changes | 13:51 |
| Kiall | Oh - No, It don't think it should.. The use case for the change tracking was one of the next pieces I'm trying to get in :) | 13:51 |
| Kiall | Essentially, the storage layer should be the only thing to call obj_reset_changes(), right after loading/reloading data that is persisted | 13:52 |
| Kiall | That way, the API layer can change an object, send to central, and central can tell which fields need to be written to the DB | 13:52 |
| vinod1 | so if nothing is changed in the object and the object goes across rpc - to_primitive mark all fields as changed - correct? | 13:54 |
| vinod1 | actually i see 'designate_object.changes': list(self._obj_changes) - so that is not the case | 13:56 |
| vinod1 | i was mistaken - so the obj_changes is transmitted as is - i mistook that it would be changed when from/to_primitives are called | 13:58 |
| *** CaptTofu has joined #openstack-dns | 13:59 | |
| *** zane has joined #openstack-dns | 14:02 | |
| *** betsy has quit IRC | 14:03 | |
| Kiall | vinod1: No, if an object is loaded from storage, transferred over the the API, then back again (without the API changing any values), it should have an empty changes set... | 14:03 |
| Kiall | changes are basically "what fields on this object are not persisted to the DB" | 14:04 |
| *** eankutse has joined #openstack-dns | 14:05 | |
| vinod1 | so what is the reasoning behind having an _obj_changes in each object? | 14:08 |
| Kiall | As we move to "objects everywhere", we'll want to be using objects for the various "update" calls, so this: | 14:09 |
| Kiall | def update_tld(self, context, tld_id, values): | 14:09 |
| Kiall | will change to: | 14:09 |
| Kiall | def update_tld(self, context, tld): | 14:09 |
| Kiall | (the tld_id becomes unnecessary, and the changed values are determined from the tld.obj_get_changes()) | 14:10 |
| *** timsim has joined #openstack-dns | 14:16 | |
| Kiall | and .. `git reset --hard` ... new approach needed -_- | 14:17 |
| *** msisk has joined #openstack-dns | 14:29 | |
| *** betsy has joined #openstack-dns | 14:41 | |
| *** betsy has quit IRC | 14:41 | |
| *** betsy has joined #openstack-dns | 14:42 | |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Don't create new objects when doing a create_* https://review.openstack.org/103558 | 14:46 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Don't create new objects when doing a create_* https://review.openstack.org/103558 | 14:56 |
| *** sballe has joined #openstack-dns | 14:59 | |
| *** jaycaz has quit IRC | 15:59 | |
| *** vinod1 has quit IRC | 16:06 | |
| *** jmcbride has joined #openstack-dns | 16:11 | |
| *** shakamunyi has joined #openstack-dns | 16:15 | |
| *** shakamunyi has quit IRC | 16:15 | |
| *** shakamunyi has joined #openstack-dns | 16:16 | |
| *** shakamunyi has quit IRC | 16:17 | |
| *** shakamunyi has joined #openstack-dns | 16:17 | |
| *** shakamunyi has quit IRC | 16:18 | |
| *** shakamunyi has joined #openstack-dns | 16:18 | |
| *** jmcbride has quit IRC | 16:30 | |
| *** vinod1 has joined #openstack-dns | 16:31 | |
| *** jmcbride has joined #openstack-dns | 16:33 | |
| openstackgerrit | A change was merged to openstack/designate: Specify minimum and maximum correctly in schemas https://review.openstack.org/103184 | 16:37 |
| *** jmcbride has quit IRC | 16:38 | |
| *** jmcbride has joined #openstack-dns | 16:44 | |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: WIP: Update's should use objects https://review.openstack.org/103587 | 16:46 |
| Kiall | vinod1: ^ is a really early idea of what I was talking about | 16:46 |
| vinod1 | That looks good - takes us forward a lot | 16:52 |
| vinod1 | to using objects everywhere | 16:52 |
| Kiall | Yea, It's really really painful to do though -_- | 16:53 |
| vinod1 | Also I notice that you marked https://review.openstack.org/#/c/103558/ Don't create new objects when doing a create_* | 16:53 |
| vinod1 | as -1 | 16:53 |
| vinod1 | Is that a WIP or did you see any issues with it? | 16:53 |
| Kiall | Almost all my previous patches have been the result of attempting to to ^, but getting blocked ;) | 16:53 |
| Kiall | it's -1 right now because I removed the "def _get_record_object(self, context, record):" method without replacing it.. | 16:54 |
| *** CaptTofu has quit IRC | 16:54 | |
| Kiall | But.. I'm thinking that OK, and will be fixed once the "objects everywhere" is done, so this can be finished: https://review.openstack.org/#/c/102307/ | 16:54 |
| openstackgerrit | A change was merged to openstack/designate: Support recursive object serialization https://review.openstack.org/103507 | 16:55 |
| Kiall | And - One of the blockers to the rrdata objects patch just merged ;) | 16:55 |
| openstackgerrit | A change was merged to openstack/designate: Ensure DesignateObject.from_sqla does not trigger change tracking https://review.openstack.org/103544 | 16:58 |
| *** dtx00ff has joined #openstack-dns | 17:15 | |
| *** dtx00ff has quit IRC | 17:16 | |
| *** dtx00ff has joined #openstack-dns | 17:17 | |
| *** jaycaz has joined #openstack-dns | 17:43 | |
| *** yidclare has joined #openstack-dns | 17:46 | |
| *** jmcbride has quit IRC | 17:53 | |
| *** jmcbride has joined #openstack-dns | 17:57 | |
| *** ryanpetrello has quit IRC | 18:00 | |
| *** jmcbride has quit IRC | 18:02 | |
| *** jmcbride has joined #openstack-dns | 18:03 | |
| *** dtx00ff has quit IRC | 18:04 | |
| *** ryanpetrello has joined #openstack-dns | 18:06 | |
| zane | hi All | 18:12 |
| zane | I had a question regarding zones | 18:12 |
| zane | when you list zones the link to the self always to local host where would I be able to change the default host | 18:15 |
| zane | "links": {"self": "http://127.0.0.1:9001/v2/zones/e8f2de63-aa2f-42e2-9b62-a8cb61667655"} | 18:16 |
| *** jmcbride has quit IRC | 18:26 | |
| vinod1 | zane: set api_base_uri in [service:api] section in designate.conf | 18:27 |
| vinod1 | it should be set to http://ip:port/ | 18:27 |
| *** dtx00ff has joined #openstack-dns | 18:29 | |
| timsim | ^That should be in the config options page of the docs, if it isn't already | 18:30 |
| *** vinod1 has quit IRC | 18:30 | |
| *** dtx00ff has quit IRC | 18:31 | |
| timsim | Or I suppose it might be in the default config when the generation stuff drops. | 18:31 |
| zane | ok thanks @vinod1 | 18:32 |
| *** jmcbride has joined #openstack-dns | 18:39 | |
| *** jmcbride has quit IRC | 18:55 | |
| *** vinod1 has joined #openstack-dns | 18:58 | |
| *** yidclare has quit IRC | 18:58 | |
| *** yidclare has joined #openstack-dns | 19:01 | |
| *** jmcbride has joined #openstack-dns | 19:03 | |
| *** vinod1 has quit IRC | 19:11 | |
| *** vinod1 has joined #openstack-dns | 19:11 | |
| *** yidclare has quit IRC | 19:13 | |
| *** vinod1 has quit IRC | 19:21 | |
| *** vinod1 has joined #openstack-dns | 19:22 | |
| *** timsim has quit IRC | 19:36 | |
| *** jmcbride has quit IRC | 19:40 | |
| *** jmcbride has joined #openstack-dns | 19:42 | |
| *** timsim has joined #openstack-dns | 19:43 | |
| *** shakamunyi has quit IRC | 19:52 | |
| *** shakamunyi has joined #openstack-dns | 19:53 | |
| *** shakamunyi has quit IRC | 19:53 | |
| *** msisk has quit IRC | 19:59 | |
| *** jmcbride has quit IRC | 19:59 | |
| *** msisk has joined #openstack-dns | 20:00 | |
| *** yidclare has joined #openstack-dns | 20:12 | |
| *** nkinder_ has quit IRC | 20:13 | |
| *** crc32 has joined #openstack-dns | 20:16 | |
| *** jmcbride has joined #openstack-dns | 20:25 | |
| jaycaz | Hey guys, it looks like the documentation on designate.readthedocs.org may be out of date. It's quite different from the documentation I just generated in the designate repository. | 20:30 |
| *** nkinder_ has joined #openstack-dns | 20:30 | |
| jaycaz | How does the whole process of updating the documentation website work? | 20:30 |
| *** jmcbride has quit IRC | 20:31 | |
| *** crc32 has quit IRC | 20:35 | |
| betsy | kiall: you around? | 20:36 |
| vinod1 | betsy: the status for kiall shows away | 20:38 |
| vinod1 | jaycaz: Last time i checked with mugsie_, designate.readthedocs.org would be updated as and when the docs on the repo are updated | 20:39 |
| betsy | Ah, it does now. I didn’t at least for me) a few minutes ago | 20:39 |
| vinod1 | what differences do you see between the site and the docs that you generated | 20:39 |
| betsy | vinod1: I think it may have something to do with the stackforge -> openstack switch | 20:40 |
| jaycaz | vinod1: it's a pretty big difference | 20:40 |
| jaycaz | even the style is completely different | 20:40 |
| betsy | http://designate.readthedocs.org/en/latest/ still has links to stackforge, although the actual docs have been changed | 20:41 |
| vinod1 | the rendering i think is different - but the content should be the same - though as betsy pointed out the site still has links to stackforge | 20:42 |
| *** zane has left #openstack-dns | 20:42 | |
| jaycaz | I failed to mention, but the content is also different | 20:42 |
| *** crc32 has joined #openstack-dns | 20:43 | |
| *** zane has joined #openstack-dns | 20:43 | |
| jaycaz | at least, the links are. There are broken links that point to the stackforge repo | 20:43 |
| vinod1 | I think that needs to be updated | 20:46 |
| vinod1 | mugsie_: would you be able to get the links at designate.readthedocs.org updated from stackforge to openstack? | 20:46 |
| *** vinod2 has joined #openstack-dns | 20:48 | |
| *** vinod1 has quit IRC | 20:48 | |
| betsy | vinod1: looks like it’s a change in the .rst files that needs to be made | 20:49 |
| betsy | No, maybe not. Looks like that’s already been done | 20:53 |
| jaycaz | the last update to the docs was two days ago, from the looks of it | 20:53 |
| *** eankutse has quit IRC | 20:54 | |
| jaycaz | kiall's change to update stackforge references in the docs was merged 10 hours ago | 20:54 |
| Kiall | vinod2: ah - read the docs was removed as part of the stackforge -> openstack, because we thought we'd be on docs.openstack.org.. But .. that stalled.. https://review.openstack.org/#/c/103349/ | 20:58 |
| Kiall | Still waiting on Anne to reply | 20:58 |
| *** msisk has quit IRC | 20:59 | |
| jaycaz | Kiall: Ah, all right then! | 21:01 |
| Kiall | I've kicked off a build of read the docs based from their site for now, waiting on a reply from anne before making a permanent change | 21:01 |
| betsy | Kiall: I’ve got a question about your recent submissions | 21:01 |
| * Kiall hides | 21:01 | |
| vinod2 | thanks for the update kiall | 21:01 |
| betsy | :) | 21:02 |
| betsy | So, I’m using the models for all my updates with the changes to the recordset/record v2 api changes | 21:02 |
| jaycaz | Kiall: great, thanks Kiall! | 21:02 |
| betsy | Are you changing that? | 21:02 |
| betsy | Did I see something about using the objects to update? | 21:02 |
| Kiall | Using a model with the update doesn't work right now? | 21:03 |
| betsy | I’ve fixed that as part of my changes | 21:03 |
| Kiall | Ohh | 21:03 |
| Kiall | -_- | 21:03 |
| Kiall | If I knew.. I wouldn't have started it.. lol | 21:03 |
| betsy | I’ve got it working now | 21:03 |
| betsy | Sorry | 21:03 |
| betsy | I just need to get the update record for v1 fixed | 21:04 |
| betsy | I can check in what I’ve got so you can see it | 21:04 |
| Kiall | Cool :) | 21:05 |
| Kiall | My goals for all my submissions have basically been leading up to being able to finish this: https://review.openstack.org/#/c/102307/ | 21:06 |
| *** timsim has quit IRC | 21:06 | |
| betsy | Right, but I thought we’d still use them in storage. | 21:07 |
| betsy | — still use the model objects | 21:07 |
| betsy | … in storage | 21:08 |
| Kiall | Oh yes, the models will be used in storage (for as long as we still use SQLA ORM rather than SQLA Core) | 21:08 |
| Kiall | "everywhere" is probably the wrong word, now that you mention that.. It's everywhere outside storage ;) | 21:09 |
| betsy | Oh, okay. That’s where I’m using the models — in impl_sqlalchemy/__init.__.py | 21:09 |
| betsy | Ok. Just wanted to check and make sure | 21:09 |
| Kiall | e.g. the storage driver API should accept/return our objects - and do whatever it wants internally | 21:10 |
| betsy | ok | 21:10 |
| betsy | We’re on the same page. Just checking | 21:11 |
| *** timsim has joined #openstack-dns | 21:12 | |
| *** nkinder_ has quit IRC | 21:24 | |
| *** jaycaz1 has joined #openstack-dns | 21:26 | |
| *** zane1 has joined #openstack-dns | 21:30 | |
| *** jaycaz has quit IRC | 21:35 | |
| *** zane has quit IRC | 21:35 | |
| *** timsim has quit IRC | 21:39 | |
| *** shuffleb1t is now known as shufflebot | 21:49 | |
| *** shufflebot has quit IRC | 21:49 | |
| *** shufflebot has joined #openstack-dns | 21:49 | |
| *** msisk has joined #openstack-dns | 21:49 | |
| *** msisk has quit IRC | 21:53 | |
| *** msisk has joined #openstack-dns | 21:54 | |
| *** betsy has quit IRC | 22:08 | |
| *** vinod2 has quit IRC | 22:12 | |
| *** yidclare has quit IRC | 22:12 | |
| *** nkinder_ has joined #openstack-dns | 22:30 | |
| *** shakamunyi has joined #openstack-dns | 22:33 | |
| *** bandarji has joined #openstack-dns | 22:38 | |
| *** openstackgerrit has quit IRC | 23:19 | |
| *** openstackgerrit has joined #openstack-dns | 23:20 | |
| *** ChanServ sets mode: +v openstackgerrit | 23:20 | |
| *** jaycaz1 has quit IRC | 23:28 | |
| *** msisk has quit IRC | 23:34 | |
| *** bandarji has quit IRC | 23:39 | |
| *** shakamunyi has quit IRC | 23:52 | |
| *** shakamunyi has joined #openstack-dns | 23:53 | |
| *** shakamunyi has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!