Tuesday, 2014-06-24

*** eankutse has quit IRC00:06
*** eankutse has joined #openstack-dns00:09
*** eankutse has quit IRC00:09
*** rmoe has quit IRC00:09
*** matsuhashi has joined #openstack-dns00:21
*** rmoe has joined #openstack-dns00:24
*** vinod1 has quit IRC00:25
*** vinod1 has joined #openstack-dns00:49
*** vinod1 has quit IRC01:14
*** crc32 has quit IRC01:23
*** shakamunyi has joined #openstack-dns01:24
*** shakamunyi has quit IRC01:24
*** shakamunyi has joined #openstack-dns01:25
*** vinod1 has joined #openstack-dns01:26
*** nosnos has joined #openstack-dns01:44
*** vinod1 has quit IRC02:04
*** richm has left #openstack-dns02:07
*** vinod1 has joined #openstack-dns02:10
*** betsy has joined #openstack-dns02:38
*** vinod1 has quit IRC02:53
*** nosnos has quit IRC02:54
*** nosnos has joined #openstack-dns02:54
*** baffle has quit IRC02:55
*** baffle has joined #openstack-dns02:56
*** nosnos has quit IRC02:59
*** nosnos has joined #openstack-dns03:05
*** nkinder has joined #openstack-dns03:07
*** matsuhashi has quit IRC03:18
*** matsuhashi has joined #openstack-dns03:19
*** matsuhashi has quit IRC03:24
*** nosnos has quit IRC03:34
*** nosnos has joined #openstack-dns03:35
*** nosnos has quit IRC03:39
*** CaptTofu_ has quit IRC03:48
*** matsuhashi has joined #openstack-dns04:10
*** msisk has quit IRC04:17
*** nosnos has joined #openstack-dns04:19
*** shakamunyi has quit IRC04:45
*** CaptTofu_ has joined #openstack-dns05:01
*** CaptTofu_ has quit IRC05:06
*** ajc_ has joined #openstack-dns05:07
*** betsy has quit IRC05:11
*** betsy has joined #openstack-dns05:11
*** shakamunyi has joined #openstack-dns05:33
*** shakamunyi has quit IRC05:38
*** shakamunyi has joined #openstack-dns06:34
*** shakamunyi has quit IRC06:38
*** CaptTofu_ has joined #openstack-dns06:49
*** CaptTofu_ has quit IRC06:54
*** openstackgerrit has quit IRC07:10
*** shakamunyi has joined #openstack-dns07:34
*** shakamunyi has quit IRC07:39
*** shakamunyi has joined #openstack-dns08:35
*** tylerdurden has joined #openstack-dns08:37
*** shakamunyi has quit IRC08:37
*** CaptTofu_ has joined #openstack-dns08:38
*** tylerdurden has quit IRC08:42
*** CaptTofu_ has quit IRC08:42
*** shakamunyi has joined #openstack-dns09:38
*** shakamunyi has quit IRC09:42
*** openstackgerrit has joined #openstack-dns09:47
*** ChanServ sets mode: +v openstackgerrit09:47
*** amarao has joined #openstack-dns09:57
*** nosnos has quit IRC10:19
*** nosnos has joined #openstack-dns10:19
*** matsuhashi has quit IRC10:23
*** matsuhashi has joined #openstack-dns10:24
*** nosnos has quit IRC10:24
*** CaptTofu_ has joined #openstack-dns10:26
*** matsuhashi has quit IRC10:28
*** CaptTofu_ has quit IRC10:31
*** shakamunyi has joined #openstack-dns10:38
*** shakamunyi has quit IRC10:43
openstackgerritGraham Hayes proposed a change to stackforge/designate: Ensure that 404's are returned as JSON  https://review.openstack.org/10195411:05
*** shakamunyi has joined #openstack-dns11:39
*** shakamunyi has quit IRC11:44
*** CaptTofu_ has joined #openstack-dns11:59
*** shakamunyi has joined #openstack-dns12:20
*** tylerdurden has joined #openstack-dns12:22
*** shakamunyi has quit IRC12:25
*** tylerdurden has quit IRC12:26
*** mwagner_lap has quit IRC12:45
*** ajc_ has quit IRC12:50
*** vinod1 has joined #openstack-dns12:52
*** richm has joined #openstack-dns13:03
*** nkinder has quit IRC13:10
*** shakamunyi has joined #openstack-dns13:22
*** shakamunyi has quit IRC13:27
*** vinod1 has quit IRC13:33
*** vinod1 has joined #openstack-dns13:37
*** nkinder has joined #openstack-dns13:54
*** vinod1 has quit IRC13:56
*** shakamunyi has joined #openstack-dns13:59
*** shakamunyi has quit IRC13:59
*** eankutse has joined #openstack-dns14:02
*** eankutse has quit IRC14:02
*** eankutse has joined #openstack-dns14:02
*** tsimmons has joined #openstack-dns14:06
*** mwagner_lap has joined #openstack-dns14:12
*** shakamunyi has joined #openstack-dns14:13
openstackgerritJordan Cazamias proposed a change to stackforge/designate: Change log string format to '%' for consistency  https://review.openstack.org/10104714:18
*** betsy has quit IRC14:22
*** vinod1 has joined #openstack-dns14:24
*** vinod1 has quit IRC14:25
*** vinod1 has joined #openstack-dns14:25
*** msisk has joined #openstack-dns14:27
*** msisk has quit IRC14:27
*** msisk has joined #openstack-dns14:28
openstackgerritKiall Mac Innes proposed a change to stackforge/designate: Objects should have a concrete list of their fields  https://review.openstack.org/10163214:32
*** vinod2 has joined #openstack-dns14:58
*** vinod1 has quit IRC15:02
*** bandarji has joined #openstack-dns15:07
*** shakamunyi has quit IRC15:13
*** betsy has joined #openstack-dns15:19
*** zane1 has joined #openstack-dns15:20
tsimmonsFound something a little weird while unit testing the quotas stuff: http://paste.openstack.org/show/84796/ Maybe I'm doing the Management API stuff wrong. But it may warrant changing?15:29
Kialltsimmons: that sounds like the second API call should have been rejected with a permission denied to me15:32
Kiallif you add an X-Auth-Roles: admin header, does it get the right data?15:32
tsimmonsAh, sorry meant to add that. No you don't get the right data. I'm using it with noauth so it defaults to admin.15:33
KiallOh .. Humm15:34
KiallSounds like a bug15:34
tsimmonshttp://paste.openstack.org/show/84797/ <-- Added the header.15:35
tsimmonsYeah I think it has to do with the context being passed in all the way through to storage, maybe it doesn't get other people's quotas just because you're an admin15:36
tsimmonsYou could do a little override in the one of the find_quotas to impersonate the tenant id in question if you're an admin.15:37
Kialltsimmons: https://github.com/stackforge/designate/blob/master/designate/api/middleware.py#L14215:37
Kialltry adding a is_admin=True into that make_context call15:37
KiallI suspect we're still relying on that flag (somewhere..)15:37
*** jaycaz has joined #openstack-dns15:37
tsimmonsNo luck :/15:39
*** rmoe has quit IRC15:50
openstackgerritJordan Cazamias proposed a change to stackforge/designate: Change log string format to '%' for consistency  https://review.openstack.org/10104715:50
*** vinod2 has quit IRC15:54
tsimmonsKiall: Without any extensive testing, L10-11 seem to fix the issue here. It's a huge hack but I think it isolates the issue at least http://paste.openstack.org/show/84800/15:58
KiallOoo.. Humm15:59
KiallTry this instead, context.all_tenants = True15:59
KiallI think that's a valid fix - as long as central is correctly applying the admin_or_owner policy.16:00
tsimmonsYeah that works too.16:01
KiallIn this case, we're explicitly breaking out of the current tenant, with policy enforcing who is allowed do that. So - By setting all_tenants = True, we let the storage layer know our intent - which causes it not to add a WHERE tenant_id=context.tenant_id and allows your criteria to applied as is16:02
tsimmonsWell crap. Now the owner thing doesn't seem to be working16:03
KiallHeh.. Typical -_-16:04
*** rmoe has joined #openstack-dns16:06
tsimmonsOH. That's because I left "is_admin=True" in the NoAuth context.16:07
Kialltsimmons: do you still have the added is_admin16:07
Kiallsnap16:07
tsimmons:P16:07
tsimmonsOf course the unit test that uncovered the issue is still failing....16:11
* Kiall hides16:16
KiallIt's probably an existing bug or something -_-16:16
tsimmonsOh my god now it's not working.16:19
tsimmonsOk surely this is something I'm doing wrong.16:19
KiallI know exactly how you feel - starting at a stacktrace with no real clue what I'm looking at.16:22
KiallAnd to preempt mugsie ... Yes, this is representative http://weknowgifs.com/wp-content/uploads/2013/11/i-have-no-idea-what-im-doing-dog-gif.gif16:22
tsimmons^ Exactly how I feel16:22
tsimmonsI think it's just the way I'm testing it but it feels like it's toggling back and forth between working and failing.16:22
mugsietsimmons, I know the feeling16:27
* mugsie right now -> http://hba77098f93150e3dfce5dfe4e9c551fd.cdn.hpcloudsvc.com/WHATno.gif16:27
*** vinod1 has joined #openstack-dns16:30
tsimmonshttp://weknowgifs.com/wp-content/uploads/2014/03/michael-scott-no-gif.gif16:31
KiallWell.. I've discovered my cause.. Fixing it is going to be painful though -_-16:37
KiallWhich leads me to here... http://37.media.tumblr.com/tumblr_lmhg6eYEKd1qii6tmo1_250.gif16:37
tsimmonsI think I've got it figured out, just trying to make it clean. But really all I'm thinking about is http://media3.giphy.com/media/N9QbkLJWeL7wY/giphy.gif16:38
*** shakamunyi has joined #openstack-dns16:59
*** shakamunyi has quit IRC16:59
*** shakamunyi has joined #openstack-dns17:00
*** mugsie has quit IRC17:06
*** yidclare has joined #openstack-dns17:08
*** jaycaz has quit IRC17:13
*** amarao has quit IRC17:15
rjrjrrich: are you on?17:31
rjrjrso, it has been determined that we will be using BIND9 for our DNS server.  the good news, I'm not keenly interested in fixing the BIND9 driver so it works well.17:34
*** shakamunyi has quit IRC17:34
rjrjrcan you please send me any deficiencies you know about with the driver (performance, bugs, etc.)?  i'm going to go through the open bugs and blueprints and start working on fixes right away.17:35
*** openstackgerrit has quit IRC17:35
rjrjri believe there was some thinking that the driver had performance issues, but i don't know if that has been captured in a bug or blueprint.17:36
*** openstackgerrit has joined #openstack-dns17:36
*** ChanServ sets mode: +v openstackgerrit17:36
rjrjr^I'm not^I'm now17:36
openstackgerritA change was merged to stackforge/designate: Objects should have a concrete list of their fields  https://review.openstack.org/10163217:41
*** vinod1 has quit IRC17:58
*** jaycaz has joined #openstack-dns18:02
*** shakamunyi has joined #openstack-dns18:09
openstackgerritJordan Cazamias proposed a change to stackforge/designate: Change log string format to '%' for consistency  https://review.openstack.org/10104718:11
*** mugsie has joined #openstack-dns18:12
richmrjrjr: I'm on18:13
openstackgerritKiall Mac Innes proposed a change to stackforge/designate: WIP: Use RRData Objects everywhere  https://review.openstack.org/10230718:14
richmrjrjr: I'm not aware of any issues with the bind9 backend other than the issues that I have filed bugs about18:15
Kiallvinod: re the use of rdata objects.. I've already started it ^ :)18:15
KiallThe pile of cleanup patches were mostly all about getting things ready to do it18:15
Kiallrjrjr: I believe the biggest issue is that we re-render the entire file for every change, and re-render ALL files upon startup.18:17
*** mugsie has quit IRC18:17
KiallBoth could be made much cleaner + more performant by using dnspython to read the zonefile, make the necessary change, and save it again.18:17
rjrjrrichm: okay.18:18
rjrjrkiall: i'll work on the bugs and using dnspython to help with the performance.  i'll get a baseline on how it performs now and make sure these changes help.18:19
*** mugsie has joined #openstack-dns18:21
*** mugsie has joined #openstack-dns18:21
Kiallrjrjr: oh, they will.. especially with large zones (and from memory, you have a small number of large zones rather than lots of small zones)18:21
*** vinod1 has joined #openstack-dns18:31
Kiall19:15 <Kiall> vinod: re the use of rdata objects.. I've already started it https://review.openstack.org/102307 :)18:32
Kiall19:16 <Kiall> The pile of cleanup patches were mostly all about getting things ready to do it18:32
Kiallvinod1: since you weren't actually on the first time I said it ;)18:33
tsimmonsKiall: Should I submit a separate patchset/file a bug with the fix to that little quotas bug I found? Or should I just lump it in with the extension?18:33
Kialltsimmons: A bug would be nice, if it's a trivial fix, then I'd include it in the same review and reference the bug and the blueprint18:33
tsimmonsOk will do. It's like ten lines. It's mostly working around the issue of having the correct is_admin in the noauth middleware.18:35
vinod1mugsie: Regarding https://review.openstack.org/#/c/101954/4/designate/api/middleware.py, is there a reason not to log 404's?18:38
mugsiewe do log 404's18:39
mugsiethat line just dumps a stacktrace in18:39
mugsie(the API logs all requests)18:39
mugsieand responce codes18:39
mugsie(we never had this before, as pecan was doing the error handling, and it missed the middleware entirly)18:40
KiallSoo... I saw that too and thought .. "humm"18:40
mugsiehad this issue*18:40
mugsieshould we log a stack trace for 404s?18:40
mugsie(IMHO I say no)18:40
KiallNo - But I think we log stacktraces all all sorts of other stuff we shouldnt18:40
mugsietrue18:40
Kialland a generic mechanism would be nice :)18:41
mugsiemaybe if 500 -> 599 do a stack trace?18:41
mugsiewe should log things that cause a 5xx status code18:41
*** nkinder has quit IRC18:41
KiallWell - I was thinking of things like the exceptions logged between the API<-->Central, where the code is meaningless18:42
KiallBut.. I didn't give it any more thought than ^18:42
mugsiedoes the middleware log those?18:42
KiallThe middleware isn't involved there ;) But the same exceptions are..18:43
mugsieah18:43
KiallMaybe a "expected = True" attr on exceptions which shouldn't have a trace logger18:43
mugsieright18:43
KiallThen the middleware are rpc code can be updated to handle it18:43
KiallBut.. No clue if that's doable with oslo.rpc!18:43
Kialloslo.messaging*18:43
* mugsie has no idea18:43
KiallAs I said.. I saw it and though humm, but had to move on ;)18:43
mugsieThat would be a different patchset anyway ;)18:44
Kialloslo.rpc had a way to say "this is OK, don't log it"18:44
KiallI just can't remember what it was, or what the oslo.messaging gallivant is18:44
Kiallequivalent*18:44
mugsiek18:44
Kialldamn spell checker -_-18:44
mugsiebut for the patchset ^, I think we can stay with what we have for the time being18:45
mugsieor do you think differently Kiall ?18:46
KiallI thought "Humm" and moved on ;)18:46
KiallThe oslo.messaging way is something like set an attr on the exception, then it makes sense to use that .. If it's not or more complicated, then what you have is fine IMO18:47
KiallIf the*18:47
Kiallhttps://github.com/openstack/oslo.messaging/blob/master/oslo/messaging/rpc/dispatcher.py#L13518:48
Kiallfrom memory, oslo.rpc saw "expected" exceptions, and wrapped then in that over the wire18:49
Kiallthe Q is where that happens in oslo.messaging -_-18:49
Kiallaha18:50
Kiallhttps://github.com/openstack/oslo.messaging/blob/master/oslo/messaging/rpc/server.py#L12318:50
KiallIf that decorator is used, any Exception classes passed to it are considered OK for that endpoint method18:50
KiallWe can adapt that easily enough to support a "expected = True" property on the exception18:50
Kiallthat way we get the same mechanism available in the RPC / API / etc18:51
vinod1steering the discussion to a more mundane bug :-)18:54
vinod1(Unrelated to your change), mugsie, since you are dealing with pecan now - A trailing slash after a uuid causes a 404 to be returned. e.g. v2/zones/<zone_id>/18:54
KiallGrr - We should just fix that once and for all and strip any trailing /'s before the requests hit pecan/flask18:56
openstackgerritGraham Hayes proposed a change to stackforge/designate: Ensure that 404's are returned as JSON  https://review.openstack.org/10195418:58
vinod1mugsie:  That was fast18:59
KiallFast'n'buggy :P19:05
KiallIf anyone is intersted .. Infra team meeting in #openstack-meeting - I've put the designate repo rename onto the agenda19:06
openstackgerritTim Simmons proposed a change to stackforge/designate: Add Extensions to the v2 API  https://review.openstack.org/10036119:06
openstackgerritGraham Hayes proposed a change to stackforge/designate: Ensure that 404's are returned as JSON  https://review.openstack.org/10195419:08
mugsievinod1, fixed19:11
Kiallvinod1 / betsy / eankutse / rjrjr / richm "<jeblair> #agreed rename designate (and bash8) saturday 1500 UTC"19:19
openstackgerritA change was merged to stackforge/designate: Change log string format to '%' for consistency  https://review.openstack.org/10104719:19
tsimmonsKiall: Cool, openstack/designate has a nice ring to it.19:19
Kiall;)19:19
vinod1great - so after that are all the open reviews marked as abandoned?19:21
Kiallvinod1: no, things will be moved19:21
KiallThere will be 10-15 minute Gerrit downtime while they rename it all19:22
Kiall(for all of openstack  ;))19:22
Kiallmugsie: https://review.openstack.org/#/c/94997/19:29
betsykiall: good news. I’m surprised they’re able to do it so quickly19:30
mugsieKiall, https://review.openstack.org/#/c/102328/19:42
*** yidclare has quit IRC19:43
*** shakamunyi has quit IRC19:47
*** rektide has quit IRC19:50
*** shakamunyi has joined #openstack-dns19:53
*** yidclare has joined #openstack-dns20:16
openstackgerritKiall Mac Innes proposed a change to stackforge/designate: Implement change tracking in DesignateObjects  https://review.openstack.org/10233720:21
Kiallvinod1: next piece of "objects everywhere" - found while realizing how painful updates with a nested RData object were going to be20:22
*** mwagner_lap has quit IRC20:23
*** nkinder has joined #openstack-dns20:24
*** msisk has quit IRC20:35
*** tsimmons has quit IRC20:37
*** betsy has quit IRC20:39
openstackgerritA change was merged to stackforge/designate: Added all fields to limits endpoint, and corrected casing  https://review.openstack.org/10193520:48
*** rektide has joined #openstack-dns20:52
openstackgerritA change was merged to stackforge/designate: Fixes default content type on /v2/zones endpoint  https://review.openstack.org/10192920:53
*** eankutse has quit IRC21:13
*** msisk has joined #openstack-dns21:14
*** msisk has quit IRC21:15
*** msisk has joined #openstack-dns21:16
*** tsimmons has joined #openstack-dns21:24
*** msisk has quit IRC21:28
*** msisk has joined #openstack-dns21:31
*** msisk has quit IRC21:35
*** msisk has joined #openstack-dns21:35
*** shakamunyi has quit IRC21:38
*** shakamunyi has joined #openstack-dns21:39
*** shakamunyi has quit IRC21:39
*** shakamunyi has joined #openstack-dns21:40
*** shakamunyi has quit IRC21:40
*** shakamunyi has joined #openstack-dns21:43
*** msisk has quit IRC21:44
*** betsy has joined #openstack-dns21:46
*** shakamunyi has quit IRC21:59
*** shakamunyi has joined #openstack-dns22:00
*** vinod1 has quit IRC22:00
*** shakamunyi has quit IRC22:20
*** shakamunyi has joined #openstack-dns22:29
*** yidclare has quit IRC22:32
openstackgerritA change was merged to stackforge/designate: Implement change tracking in DesignateObjects  https://review.openstack.org/10233722:38
*** yidclare has joined #openstack-dns22:59
*** seventy3 has quit IRC23:03
*** vinod1 has joined #openstack-dns23:04
*** yidclare has quit IRC23:05
*** seventy3 has joined #openstack-dns23:05
*** vinod1 has quit IRC23:10
*** seventy3 has quit IRC23:17
*** seventy3 has joined #openstack-dns23:20
*** mwagner_lap has joined #openstack-dns23:25
*** tsimmons has quit IRC23:26
*** jaycaz has left #openstack-dns23:34

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!