| *** nosnos has joined #openstack-dns | 01:06 | |
| *** amrit has joined #openstack-dns | 01:11 | |
| *** amrit has quit IRC | 01:19 | |
| *** amrit has joined #openstack-dns | 01:20 | |
| *** amrit has quit IRC | 02:14 | |
| *** CaptTofu has quit IRC | 03:24 | |
| *** CaptTofu has joined #openstack-dns | 03:24 | |
| *** CaptTofu has quit IRC | 03:55 | |
| *** CaptTofu has joined #openstack-dns | 03:56 | |
| *** krow has quit IRC | 04:34 | |
| *** jmcbride has joined #openstack-dns | 05:29 | |
| *** jmcbride has quit IRC | 05:33 | |
| *** nosnos_ has joined #openstack-dns | 05:34 | |
| *** nosnos__ has joined #openstack-dns | 05:36 | |
| *** nosnos_ has quit IRC | 05:37 | |
| *** nosnos has quit IRC | 05:38 | |
| *** nosnos__ has quit IRC | 07:06 | |
| *** nosnos has joined #openstack-dns | 07:06 | |
| *** briancline has joined #openstack-dns | 07:48 | |
| *** zigo has joined #openstack-dns | 07:48 | |
| *** vinod has joined #openstack-dns | 07:55 | |
| *** pasquier-s has joined #openstack-dns | 08:12 | |
| *** vinod has quit IRC | 09:04 | |
| *** vinod has joined #openstack-dns | 09:36 | |
| *** vinod has quit IRC | 09:58 | |
| *** CaptTofu has quit IRC | 11:52 | |
| *** CaptTofu has joined #openstack-dns | 11:52 | |
| *** eankutse has joined #openstack-dns | 12:33 | |
| *** nosnos has quit IRC | 12:36 | |
| *** vinod has joined #openstack-dns | 12:44 | |
| *** vinod has quit IRC | 12:45 | |
| *** eankutse has quit IRC | 13:02 | |
| *** mugsie_ is now known as mugsie | 13:13 | |
| *** mugsie has joined #openstack-dns | 13:13 | |
| *** CaptTofu has quit IRC | 13:29 | |
| *** CaptTofu has joined #openstack-dns | 13:29 | |
| *** jmcbride has joined #openstack-dns | 13:48 | |
| *** CaptTofu has quit IRC | 13:49 | |
| *** CaptTofu has joined #openstack-dns | 13:50 | |
| *** vinod has joined #openstack-dns | 13:58 | |
| *** eankutse has joined #openstack-dns | 14:04 | |
| *** eankutse has quit IRC | 14:05 | |
| *** eankutse has joined #openstack-dns | 14:05 | |
| *** artom has joined #openstack-dns | 14:12 | |
| *** vinod has quit IRC | 14:22 | |
| jmcbride | Hi Chris, hope your son is doing better. | 14:27 |
|---|---|---|
| *** openstack has joined #openstack-dns | 14:34 | |
| *** ChanServ sets mode: +v openstack | 14:34 | |
| *** krow has joined #openstack-dns | 14:34 | |
| *** vinod has joined #openstack-dns | 14:37 | |
| *** vinod has quit IRC | 14:37 | |
| *** krow has quit IRC | 14:41 | |
| *** timfreund has quit IRC | 14:52 | |
| *** CaptTofu has quit IRC | 15:00 | |
| *** timfreund has joined #openstack-dns | 15:06 | |
| *** CaptTofu has joined #openstack-dns | 15:20 | |
| *** msisk has joined #openstack-dns | 15:30 | |
| *** krow has joined #openstack-dns | 15:38 | |
| *** krow has quit IRC | 15:43 | |
| *** vinod has joined #openstack-dns | 15:55 | |
| kiall | heya | 16:07 |
| *** msisk has quit IRC | 16:07 | |
| artom | heya | 16:07 |
| *** msisk has joined #openstack-dns | 16:08 | |
| *** jmcbride has quit IRC | 16:11 | |
| *** vinod has quit IRC | 16:17 | |
| openstackgerrit | Artom Lifshitz proposed a change to stackforge/designate: Test database migration schema https://review.openstack.org/62079 | 16:19 |
| *** eankutse1 has joined #openstack-dns | 16:31 | |
| *** eankutse has quit IRC | 16:33 | |
| *** vinod has joined #openstack-dns | 16:34 | |
| *** krow has joined #openstack-dns | 16:39 | |
| *** jmcbride has joined #openstack-dns | 16:41 | |
| *** krow has quit IRC | 16:43 | |
| kiall | artom: any luck figuring out why the DB in your patchset isn't getting reset properly? | 16:56 |
| kiall | (or if, it is.. and it's highlighting another issue? Always possible..) | 16:56 |
| artom | kiall, I was going to say I suspect name collisions... | 16:57 |
| artom | But as I was typing it out I realize it's not possible. | 16:57 |
| kiall | Sure, but it should only have 1 tsig key in the DB with that test | 16:57 |
| artom | I mean tempfile name collisions. | 16:58 |
| artom | But since setUp() copies the "master" db every time, even if the tempfile has the same name as one that was previously used, the contents should be pristine... | 16:58 |
| *** eankutse1 has quit IRC | 17:01 | |
| *** eankutse has joined #openstack-dns | 17:01 | |
| kiall | really? I thought it ensured those are properly unique? | 17:05 |
| kiall | Well .. That too, it copies it over | 17:05 |
| artom | Ensured purely based on statistics ;) | 17:05 |
| kiall | Doesn't it check the file doesn't exist, and that it can obtain a lock? | 17:05 |
| kiall | or something like that | 17:05 |
| artom | Not my code... | 17:06 |
| artom | Maybe tempfile? | 17:06 |
| kiall | I mean the stdlib tempfile module ;) | 17:06 |
| kiall | artom: ... actuallty | 17:06 |
| kiall | It's your new powerdns backend test that the error is coming from, I didn't notice that before | 17:07 |
| kiall | maybe there is a bug there? | 17:07 |
| artom | It's possible I guess... | 17:07 |
| artom | But I'd rather rule out any errors with new code before doubting the old one... | 17:08 |
| kiall | Yea, true | 17:08 |
| artom | The PowerDNS code has worked fine in production. | 17:08 |
| artom | And my tests are pretty basic - I'd be surprised if I've uncovered some obscure bug. | 17:08 |
| kiall | I feel so daft right now.. Trying to find the old DB setup code and failing ;) | 17:11 |
| kiall | Found it | 17:12 |
| kiall | ;) | 17:12 |
| kiall | artom: So, once I removed the old DB setup code.. The errors are totally different. | 17:14 |
| kiall | "table not found" etc etc | 17:14 |
| artom | Eh? What code did you remove? | 17:16 |
| kiall | artom: - storage_fixture = StorageFixture() | 17:21 |
| kiall | - self.useFixture(storage_fixture) | 17:21 |
| kiall | + # storage_fixture = StorageFixture() | 17:21 |
| kiall | + # self.useFixture(storage_fixture) | 17:21 |
| kiall | I think I see whats happening | 17:22 |
| artom | Explain then, because I don't even see where StorageFixture was being used... | 17:24 |
| artom | ;) | 17:24 |
| kiall | Okay .. So .. I think this is what we need to do :) | 17:24 |
| kiall | 1) Remove StorageFixture ;) | 17:24 |
| kiall | 2) Update DatabaseFixture to accept a repository, and return a path.. the DB at that path should be reset between each test .. | 17:25 |
| kiall | 3) supply that path as self.config('database_connection='sqlite:///path/goes/here', group='storage:sqlalchemy') | 17:25 |
| kiall | and .. all that should happen in the tests/__init__.py TestCase classes __init__ | 17:25 |
| artom | But... the powerdns backend doesn't use storage... | 17:26 |
| artom | Does it? | 17:26 |
| artom | It has its own database_connection option. | 17:27 |
| kiall | No, for PowerDNS you would have a second DatabaseFixture and set a different config var.. But, in the PowerDNS test case only this time | 17:27 |
| artom | Right, but this is where the current errors are coming from... | 17:27 |
| kiall | Right now, the DatabaseFixture generated sqlite DB isn't actually being used at all, it;s being built, but we're still using the "standard" database. | 17:28 |
| artom | Well crap, you're right. | 17:31 |
| artom | How come though? | 17:31 |
| artom | self.config(database_connection=self.db_fixture.url, group='backend:powerdns') | 17:32 |
| artom | That's called in setUp()... | 17:32 |
| kiall | I think it's too late at that point.. | 17:34 |
| kiall | I think | 17:34 |
| kiall | I'd start by removing the new PDNS test for a few mins, and getting this working first for the main DB http://paste.ubuntu.com/6704336/ | 17:35 |
| kiall | Once that works, we know the DatabaseFixture is good and it should be easy enough to get that into the right spot for powerdns | 17:36 |
| artom | Hrmm, I *have* been testing two things at the same time... | 17:36 |
| kiall | Yep :) Split the new PowerDNS tests into a new review, once we know the fixture is good :) | 17:36 |
| kiall | The addCleanup stuff is a good spot to move the "restore the golden DB" stuff: http://pastie.org/8607177 | 17:37 |
| kiall | Actually.. setUp works better there ;) | 17:38 |
| kiall | Since it works for the first run too1 | 17:38 |
| kiall | Also .. I self.useFixture() calls have to be in the test's __init__ methods.. | 17:39 |
| kiall | brb | 17:39 |
| artom | Solution #3: Ask the infra team to give Jenkins SSD drives ;) We can run all the migrations for every test :D | 17:39 |
| *** krow has joined #openstack-dns | 17:39 | |
| kiall | artom: so long as I get one for my laptop from them too, sure ;) | 17:39 |
| * artom has one. | 17:40 | |
| *** krow has quit IRC | 17:44 | |
| *** jmcbride has quit IRC | 18:11 | |
| *** rossk has joined #openstack-dns | 18:13 | |
| *** rossk_ has joined #openstack-dns | 18:26 | |
| *** rossk has quit IRC | 18:28 | |
| *** vinod has quit IRC | 18:39 | |
| *** rossk_ is now known as rossk | 18:39 | |
| *** krow has joined #openstack-dns | 18:40 | |
| *** krow has quit IRC | 18:44 | |
| *** wjohnson has quit IRC | 18:50 | |
| *** jmcbride has joined #openstack-dns | 19:02 | |
| *** eankutse has quit IRC | 19:04 | |
| *** vinod has joined #openstack-dns | 19:08 | |
| *** eankutse has joined #openstack-dns | 19:25 | |
| *** sballe has joined #openstack-dns | 19:35 | |
| *** krow has joined #openstack-dns | 19:41 | |
| *** krow1 has joined #openstack-dns | 19:44 | |
| *** krow has quit IRC | 19:44 | |
| *** jorgem has joined #openstack-dns | 19:52 | |
| *** krow1 has quit IRC | 20:00 | |
| *** amrit has joined #openstack-dns | 20:02 | |
| *** amrit has quit IRC | 20:02 | |
| *** amrit has joined #openstack-dns | 20:03 | |
| *** jmcbride has quit IRC | 20:04 | |
| *** jmcbride has joined #openstack-dns | 20:09 | |
| *** krow has joined #openstack-dns | 20:10 | |
| *** amrit has quit IRC | 20:18 | |
| *** jmcbride has quit IRC | 20:33 | |
| *** krow1 has joined #openstack-dns | 20:38 | |
| *** krow has quit IRC | 20:40 | |
| *** jmcbride has joined #openstack-dns | 20:40 | |
| *** jmcbride has quit IRC | 20:55 | |
| *** krow1 has quit IRC | 21:00 | |
| artom | Some folks have decided to fork the Nova scheduler and call it Gantt. | 21:08 |
| artom | With the intention of making a general scheduler for OpenStack. | 21:08 |
| artom | Could be useful for pools... | 21:08 |
| *** msisk has quit IRC | 21:17 | |
| *** vinod has quit IRC | 21:27 | |
| *** vipul is now known as vipul-away | 21:31 | |
| *** vipul-away is now known as vipul | 21:31 | |
| *** vinod has joined #openstack-dns | 21:34 | |
| *** pvinci_ has joined #openstack-dns | 21:36 | |
| *** CaptTofu has quit IRC | 21:48 | |
| *** CaptTofu has joined #openstack-dns | 21:49 | |
| *** CaptTofu has quit IRC | 21:51 | |
| *** CaptTofu has joined #openstack-dns | 21:51 | |
| *** vinod has quit IRC | 22:21 | |
| *** vinod has joined #openstack-dns | 22:28 | |
| *** eankutse1 has joined #openstack-dns | 22:34 | |
| *** eankutse1 has quit IRC | 22:34 | |
| *** eankutse has quit IRC | 22:38 | |
| openstackgerrit | Vinod Mangalpally proposed a change to stackforge/designate: WIP: Add APIs for managing TLDs https://review.openstack.org/65168 | 22:48 |
| *** jorgem1 has joined #openstack-dns | 22:50 | |
| *** jorgem has quit IRC | 22:53 | |
| *** CaptTofu has quit IRC | 23:13 | |
| *** CaptTofu has joined #openstack-dns | 23:13 | |
| *** vinod has quit IRC | 23:16 | |
| *** jorgem1 has quit IRC | 23:18 | |
| *** jorgem has joined #openstack-dns | 23:20 | |
| *** vipul is now known as vipul-away | 23:47 | |
| *** vipul-away is now known as vipul | 23:50 | |
| *** pvinci_ has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!