| *** eankutse has quit IRC | 00:05 | |
| *** shakayumi has quit IRC | 00:55 | |
| *** shakayumi has joined #openstack-dns | 00:57 | |
| *** shakayumi has quit IRC | 00:58 | |
| *** jeffreyio2 has joined #openstack-dns | 01:27 | |
| *** jmcbride has joined #openstack-dns | 02:07 | |
| *** jmcbride has quit IRC | 02:23 | |
| *** jmcbride has joined #openstack-dns | 02:39 | |
| *** CaptTofu has quit IRC | 02:41 | |
| *** vipul has quit IRC | 03:16 | |
| *** vipul has joined #openstack-dns | 03:17 | |
| *** vipul is now known as vipul-away | 03:35 | |
| *** vipul-away is now known as vipul | 03:39 | |
| *** jmcbride has quit IRC | 03:44 | |
| *** jeffreyio2 has quit IRC | 04:21 | |
| *** CaptTofu has joined #openstack-dns | 04:46 | |
| *** jeffreyio2 has joined #openstack-dns | 05:32 | |
| *** jeffreyio2 has quit IRC | 05:41 | |
| *** pasquier-s has quit IRC | 06:09 | |
| *** openstack has joined #openstack-dns | 06:18 | |
| *** ChanServ sets mode: +v openstack | 06:18 | |
| *** SlickNik has quit IRC | 07:14 | |
| *** vipul is now known as vipul-away | 07:14 | |
| *** SlickNik has joined #openstack-dns | 07:15 | |
| *** vipul-away is now known as vipul | 07:16 | |
| *** mugsie_ is now known as mugsie | 10:11 | |
| *** mugsie has joined #openstack-dns | 10:11 | |
| *** eankutse has joined #openstack-dns | 10:21 | |
| *** eankutse has quit IRC | 10:25 | |
| openstackgerrit | A change was merged to stackforge/designate: Give more meaningful error message when no servers are configured https://review.openstack.org/46809 | 10:49 |
|---|---|---|
| *** eankutse has joined #openstack-dns | 11:00 | |
| *** eankutse has quit IRC | 11:02 | |
| kiall | artom: heya | 11:59 |
| kiall | Yea, the notifications are intended for external systems to hook into.. e.g. ceilometer or your own custom code | 12:00 |
| *** betsy has joined #openstack-dns | 13:05 | |
| *** eankutse has joined #openstack-dns | 13:18 | |
| *** eankutse has quit IRC | 13:19 | |
| *** eankutse has joined #openstack-dns | 13:19 | |
| *** jmcbride has joined #openstack-dns | 13:24 | |
| *** CaptTofu has quit IRC | 13:48 | |
| *** tsimmons has joined #openstack-dns | 14:12 | |
| *** CaptTofu has joined #openstack-dns | 14:13 | |
| *** CaptTofu has quit IRC | 14:25 | |
| tsimmons | hey Kiall are you around? | 14:32 |
| kiall | tsimmons: heya | 14:32 |
| tsimmons | hey :) so I'm almost done with this code. I'm looking at copying the file in /var/cache/bind over to designate/bind9/zones.config | 14:33 |
| tsimmons | I figured I would keep it consistent and use utils.execute() to do a cp command. | 14:34 |
| tsimmons | The problem is when I run it I get this error: Command: sudo designate-rootwrap /etc/designate/rootwrap.conf cp var/cache/bind/*.nzf /root/designate/bind9/zones.config | 14:35 |
| tsimmons | Exit code: 97 | 14:35 |
| tsimmons | Stdout: '/usr/local/bin/designate-rootwrap: Incorrect configuration file: /etc/designate/rootwrap.conf\n' | 14:35 |
| kiall | In this case, we probably(?) don't want to shell out to cp, I guess that depends on if the /var/cache/bind version is world readable.. But to explain the error :) | 14:36 |
| kiall | https://github.com/stackforge/designate/blob/master/etc/designate/rootwrap.conf.sample | 14:36 |
| kiall | https://github.com/stackforge/designate/blob/master/etc/designate/rootwrap.d/bind9.filters | 14:36 |
| kiall | Oslo has this "root wrap" script, which is intended to restrict what services can do as `sudo` | 14:37 |
| tsimmons | ah, that makes sense. | 14:37 |
| kiall | (i.e. they reinvented /etc/sudoers.d with regexes) | 14:37 |
| tsimmons | So how should I go about getting that file over? | 14:38 |
| kiall | Assuming sudo and cp is necessary, we'll want to most restrictive command we can fit in there :) | 14:38 |
| kiall | shutil.copyfile(src, dest) is on way, assuming non-root users can read the /var/cache/bind fil | 14:38 |
| kiall | e | 14:38 |
| tsimmons | I thought about maybe using pythons shutil | 14:38 |
| tsimmons | hah, alright I'll do that. | 14:39 |
| kiall | :) | 14:39 |
| tsimmons | thanks :) | 14:39 |
| *** betsy has quit IRC | 14:50 | |
| *** betsy has joined #openstack-dns | 15:35 | |
| *** shakayumi has joined #openstack-dns | 15:43 | |
| eankutse | Kiall: Question - I commited patch set 2 for https://bugs.launchpad.net/bugs/1214869. I know from the Gerrit Workflow documentation that I have to click the "Publish" button to make it available for review. However, the "Publish" button is at the top of the patch set 1, and patch set 2 has a different set of buttons. Which way to go? | 15:44 |
| kiall | eankutse: it's already published - when you uploaded the second review, it wasn't uploaded as a draft | 15:45 |
| kiall | so .. it's "open" | 15:45 |
| kiall | OS Gerrit won't automatically test on that though .. | 15:45 |
| eankutse | hmm… ok | 15:45 |
| kiall | leaving a comment with "recheck no bug" should trigger the tests | 15:45 |
| kiall | (done BTW) | 15:46 |
| eankutse | oh, so my comment on the "git commit -a —amend" should be "recheck no bug"? | 15:46 |
| kiall | No - a comment on gerrit :) | 15:47 |
| eankutse | ah, git review -m 'recheck no bug' ? | 15:48 |
| kiall | No .. Login to review.openstack.org and hit the "review" button ;) | 15:48 |
| kiall | e.g. https://review.openstack.org/#/c/45078/ | 15:48 |
| eankutse | Thanks | 15:49 |
| kiall | eankutse: humm.. no idea why your patch is failing the flake8 test.. that error doesn't seem to make sense | 16:03 |
| kiall | Oh .. I bet it needs to be rebased :) | 16:06 |
| kiall | or maybe not.. humm | 16:07 |
| kiall | Yes. that's it | 16:08 |
| kiall | https://github.com/stackforge/designate/commit/fde4d7e01b150655434c0969ad94c16e3db2fa7d | 16:09 |
| kiall | That commit went in, and among other things, adds that excutils import | 16:09 |
| kiall | so when Jenkins tests what the final merge would look like, it's catching a change you wouldn't see locally | 16:09 |
| *** zane has joined #openstack-dns | 16:10 | |
| openstackgerrit | Kiall Mac Innes proposed a change to stackforge/designate: Monkeypatch WebTest to support HTTP PATCH. https://review.openstack.org/46983 | 16:32 |
| openstackgerrit | Kiall Mac Innes proposed a change to stackforge/designate: Monkeypatch WebTest to support HTTP PATCH https://review.openstack.org/46983 | 16:33 |
| *** CaptTofu has joined #openstack-dns | 16:33 | |
| tsimmons | kiall: I'm about to submit my bind stuff, would you like me to add the needed tweak to the bind9 configuration to the new doc you published? | 16:34 |
| openstackgerrit | Kiall Mac Innes proposed a change to stackforge/designate: Monkeypatch WebTest to support HTTP PATCH https://review.openstack.org/46983 | 16:35 |
| kiall | tsimmons: sure - I just threw up what I could remember yesterday, so any additions are welcome :) | 16:35 |
| tsimmons | Cool. I'll see if I have anything else relevant in my notes. | 16:36 |
| kiall | Nothing like silly dependency versions wasting a few hours of your time >:( | 16:39 |
| openstackgerrit | A change was merged to stackforge/designate: Monkeypatch WebTest to support HTTP PATCH https://review.openstack.org/46983 | 16:40 |
| *** eankutse has quit IRC | 16:57 | |
| *** vipul is now known as vipul-away | 17:17 | |
| *** vipul-away is now known as vipul | 17:23 | |
| *** tsimmons has quit IRC | 17:30 | |
| *** jmcbride has quit IRC | 17:31 | |
| *** tsimmons has joined #openstack-dns | 17:39 | |
| *** eankutse has joined #openstack-dns | 17:51 | |
| *** jmcbride has joined #openstack-dns | 17:56 | |
| *** eankutse1 has joined #openstack-dns | 18:03 | |
| *** eankutse has quit IRC | 18:03 | |
| *** jmcbride has quit IRC | 18:32 | |
| *** tsimmons has quit IRC | 18:36 | |
| *** dmakogon_ has joined #openstack-dns | 19:04 | |
| *** betsy has quit IRC | 19:33 | |
| *** vipul is now known as vipul-away | 19:34 | |
| *** jmcbride has joined #openstack-dns | 19:58 | |
| *** msisk has joined #openstack-dns | 20:01 | |
| *** vipul-away is now known as vipul | 20:03 | |
| *** zane has quit IRC | 20:18 | |
| *** zane has joined #openstack-dns | 20:21 | |
| eankutse1 | Kiall: when you get the chance would you take a look at the PEP8 violation that my patch is generating. I don' see how that's coming about: | 20:59 |
| eankutse1 | 2013-09-17 20:20:31.242 | pep8 runtests: commands[0] | flake8 | 20:59 |
| eankutse1 | 2013-09-17 20:20:31.258 | /home/jenkins/workspace/gate-designate-pep8$ /home/jenkins/workspace/gate-designate-pep8/.tox/pep8/bin/flake8 | 20:59 |
| eankutse1 | 2013-09-17 20:20:35.690 | ./designate/backend/impl_powerdns/__init__.py:29:1: F811 redefinition of unused 'excutils' from line 25 | 20:59 |
| eankutse1 | 2013-09-17 20:20:35.768 | ERROR: InvocationError: '/home/jenkins/workspace/gate-designate-pep8/.tox/pep8/bin/flake8' | 20:59 |
| eankutse1 | 2013-09-17 20:20:35.769 | ___________________________________ summary ____________________________________ | 20:59 |
| kiall | eankutse1: heya | 21:00 |
| eankutse1 | Hello | 21:01 |
| kiall | You must have missed my messages earlier! Took me a few mins to figure that what out too :) | 21:01 |
| kiall | There actually nothing wrong with your code, the issue is what happens when your code is combined with the current tip of master :) | 21:01 |
| kiall | There's* | 21:01 |
| kiall | 17:03 <kiall> eankutse: humm.. no idea why your patch is failing the flake8 test.. that error doesn't seem to make sense | 21:02 |
| kiall | 17:06 <kiall> Oh .. I bet it needs to be rebased :) | 21:02 |
| kiall | 17:07 <kiall> or maybe not.. humm | 21:02 |
| kiall | 17:08 <kiall> Yes. that's it | 21:02 |
| kiall | 17:09 <kiall> https://github.com/stackforge/designate/commit/fde4d7e01b150655434c0969ad94c16e3db2fa7d | 21:02 |
| kiall | 17:09 <kiall> That commit went in, and among other things, adds that excutils import | 21:02 |
| kiall | 17:09 <kiall> so when Jenkins tests what the final merge would look like, it's catching a change you wouldn't see locally | 21:02 |
| eankutse1 | ah.., I missed all that | 21:02 |
| kiall | No problem :) | 21:02 |
| kiall | Best bet is to `git fetch origin && git rebase origin/master` in your branch.. | 21:03 |
| kiall | Then run tox locally, and you'll see the same error (and the duplicate import will be visible) | 21:03 |
| *** zane has quit IRC | 21:04 | |
| eankutse1 | ok. I'll try git fetch…" I already did git rebase -i master bug/1214869 but that went smoothly and did not reveal any issues | 21:04 |
| kiall | Your local master was likely out :) | 21:05 |
| kiall | you could `git checkout master && git pull && checkout my-branch && rebase master` as a longer way than just using git fetch :) | 21:05 |
| eankutse1 | ok. I'll try that. Thx :-) | 21:06 |
| *** vipul is now known as vipul-away | 21:16 | |
| openstackgerrit | Emmanuel Ankutse proposed a change to stackforge/designate: Update domains when servers are created, modified or deleted https://review.openstack.org/45078 | 21:20 |
| eankutse1 | Kiall: do I still need to do "recheck no bug"? | 21:21 |
| kiall | eankutse1: nope, it only seems necessary when you first go from draft -> published | 21:22 |
| kiall | http://status.openstack.org/zuul/ shows the job queue | 21:22 |
| kiall | by the time you load it though... your test run's will likely already be done ;) | 21:23 |
| eankutse1 | k. I also see the posting in the IRC | 21:23 |
| eankutse1 | Kiall: k. Waiting for comments. Thanks for your time :-) | 21:24 |
| kiall | It'll probably be the morning! late here :) | 21:24 |
| kiall | On first glance, I'd love to find a way to remove the "old_server_name" arg.. def update_server(self, context, server, old_server_name): | 21:25 |
| kiall | Though - I have no suggestions as to how :) | 21:25 |
| eankutse1 | ok. without the old_server_name it's hard to know how to go about the update | 21:26 |
| kiall | Yea, It's def required to make it work.. But I wonder if we can track it via something else, like the server ID | 21:28 |
| kiall | (We don't have that info available to us in the backend DB today, but maybe we could add it..) | 21:28 |
| kiall | Anyway - Totally off the top of my head! Don't go making any changes just yet! I'll have a proper think about it tomorrow.. | 21:29 |
| kiall | Ooo | 21:29 |
| kiall | We do .. | 21:29 |
| eankutse1 | K. But I'll think through how we might go about doing the update without the old_server_name | 21:29 |
| eankutse1 | yea :-) | 21:29 |
| eankutse1 | we do :-)? | 21:30 |
| kiall | So, We have the server ID, which we can do a SELECT content FROM powerdns.records WHERE designate_id = 'server_id' AND type = 'NS'; | 21:30 |
| kiall | (I think this is only necessary for PDNS right now, as bind rewrites the whole zonefile?) | 21:31 |
| kiall | By a fluke of bad decision making about a year or so ago.. designate_id can be a bit misleading.. | 21:31 |
| kiall | for normal records, it's the designate record id .. for NS records created for a server, it's the server_id | 21:32 |
| kiall | and for SOA records it's the domain_id | 21:32 |
| eankutse1 | I think stepping through the code, I noticed that. So your point is that the server_id remains the same even though the name has changed. So we can us the server_id as a guide to know what name to replace in the SOA record | 21:34 |
| eankutse1 | But.. | 21:34 |
| kiall | Yea - But.. that raises a new Q | 21:34 |
| eankutse1 | when you use the func.replace() you still have to specify the old name of the server to be replaced | 21:34 |
| kiall | What happens when the server get's deleted | 21:35 |
| kiall | Well - We can select the NS record based on the server_id before we update it, keep the old name around, update the server, then update the NS records | 21:35 |
| *** msisk has quit IRC | 21:36 | |
| eankutse1 | I'd have to think through a bit | 21:36 |
| eankutse1 | or maybe sleep over it a bit :-) | 21:37 |
| eankutse1 | yes and then we also need to update the SOA to use an existing server | 21:38 |
| kiall | I know the feeling :) It's late, so I'm probably talking crap ;) Anyway - code looks good.. I'll leave a proper review in the morning.. Hopefully with a clean way to remove the old_server_name arg :) | 21:38 |
| eankutse1 | Cool. Have a good rest :-) | 21:38 |
| *** msisk has joined #openstack-dns | 21:39 | |
| *** jmcbride has quit IRC | 21:55 | |
| *** eankutse has joined #openstack-dns | 21:55 | |
| *** betsy has joined #openstack-dns | 21:56 | |
| *** vipul-away is now known as vipul | 21:58 | |
| *** eankutse1 has quit IRC | 21:59 | |
| *** eankutse has quit IRC | 22:00 | |
| *** eankutse has joined #openstack-dns | 22:01 | |
| *** tsimmons has joined #openstack-dns | 22:04 | |
| *** eankutse has quit IRC | 22:04 | |
| *** eankutse has joined #openstack-dns | 22:08 | |
| *** eankutse has quit IRC | 22:14 | |
| *** tsimmons has left #openstack-dns | 23:02 | |
| *** dmakogon_ has quit IRC | 23:11 | |
| *** msisk has quit IRC | 23:57 | |
| *** msisk has joined #openstack-dns | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!