| opendevreview | Karolina Kula proposed openstack/diskimage-builder master: WIP: Add support for CentOS Stream 10 https://review.opendev.org/c/openstack/diskimage-builder/+/934045 | 10:20 |
|---|---|---|
| opendevreview | Karolina Kula proposed openstack/diskimage-builder master: WIP: Add support for CentOS Stream 10 https://review.opendev.org/c/openstack/diskimage-builder/+/934045 | 10:49 |
| opendevreview | Karolina Kula proposed openstack/diskimage-builder master: WIP: Add support for CentOS Stream 10 https://review.opendev.org/c/openstack/diskimage-builder/+/934045 | 12:09 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/diskimage-builder master: Add support for building Fedora 40 https://review.opendev.org/c/openstack/diskimage-builder/+/922109 | 15:19 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/diskimage-builder master: Remove verbosity from DNF/YUM command https://review.opendev.org/c/openstack/diskimage-builder/+/934332 | 15:31 |
| opendevreview | Merged openstack/diskimage-builder master: Update Nodepool image location in docs https://review.opendev.org/c/openstack/diskimage-builder/+/933923 | 19:51 |
| JayF | https://review.opendev.org/c/openstack/diskimage-builder/+/922385 seems like a simple fix we could land if another person has a sec | 23:05 |
| JayF | In general there's a lot of very stale dib patches; I don't have context to know how many are still valid. Might be a good way for someone with more context to spend a little time. I'm happy to help review and clear the backlog for things I understand and have context on (and have reviewed quite a few just now). | 23:15 |
| opendevreview | Merged openstack/diskimage-builder master: docs: add two contextual warnings to the replace-partition element https://review.opendev.org/c/openstack/diskimage-builder/+/928819 | 23:35 |
| clarkb | JayF: do you know how the files can be owned by root if we are not running as root? (Is sudo used to gerneate them?) | 23:43 |
| JayF | oh, that's a reasonable question | 23:45 |
| JayF | I suspect this is a second run issue | 23:45 |
| clarkb | the issue is writing with sudo | 23:46 |
| JayF | but that's probably a good reason to -1 and ask, at least | 23:46 |
| clarkb | the writes happen just above the fiff | 23:46 |
| clarkb | *diff | 23:46 |
| JayF | aha | 23:46 |
| JayF | so maybe removing the sudo from 32/33 is more-correct? | 23:46 |
| JayF | (lines 32/33) | 23:46 |
| * JayF brb in a little bi | 23:46 | |
| clarkb | possibly unless weiting to that dir is a problem without privs | 23:46 |
| clarkb | another option is to simply chown the files. But I'll go ahead and approve this since it shouldn't be a regression and we're laredy using sudo all over | 23:47 |
| clarkb | fixing that can be a more comprehensive thing if anyone wants to do that | 23:47 |
| clarkb | if we weren't using sudo yet I'd be more critical in case adding sudo creates a new problem. But we already use it so should be safe any no less risky | 23:51 |
| clarkb | er no more risky | 23:51 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!