| espenfl | I have some stale stuff https://review.opendev.org/q/project:openstack/diskimage-builder+status:open+espenfl that I would like to clean up and maybe get it into the upstream codebase. Is it just cleaner at this point to abandon all these and add a fresh one on top of the current taking into account the comments and chain of changes? I would say yes as I was a bit unfamiliar | 09:53 |
|---|---|---|
| espenfl | with this way of submitting a sequence of changes. Maybe Steve is here and can give his advice on this as he was involved in the review? | 09:53 |
| *** TheJulia is now known as needs_brains_and_sleep | 13:04 | |
| *** needs_brains_and_sleep is now known as TheJulia | 13:23 | |
| clarkb | espenfl: abandoning changes is usually done when you don't want to go in that direction at all anymore. For merge conflicts and review comments you should update the change with a new patchset | 15:39 |
| clarkb | oh I see there are two different changes for the same logical change. In that case yes abandon one and contineu with the other | 15:40 |
| espenfl | clarkb: Yes, this happened since I was new to the whole gerrit stuff. I will abandon the initial one and continue from there then. | 21:20 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!