| espenfl | Hi there. Did I do the update correctly here: https://review.opendev.org/c/openstack/diskimage-builder/+/876084/1. Sorry for asking, I am just not familiar with gerrit and git-review. I think that the failing tests are mostly fixed now. The remaining one, I know little about. | 08:01 |
|---|---|---|
| clarkb | espenfl: that created a second followup change rather than updating the existing change. Typically with Gerrit you want to make each commit a logical passing entity. In this case I think both changes should be squashed into one | 15:52 |
| clarkb | espenfl: in this case you can do that by running `git review -d 876084` to download the two changes into a branch, then `git rebase -i HEAD~2` set the second commit line to squash to squash it into its parent. Edit the commit message to preserve the original commit message and its change id. Then run `git review` to push the result abck to gerrit | 15:53 |
| espenfl | clarkb: Thanks, I will try that tomorrow. | 20:45 |
| espenfl | so maybe the typical approach would be to first do git-review and then on future commits to update that "PR" I just do a regular git commit and push? | 20:47 |
| JayF | So the pattern I follow, this is not the only pattern | 20:51 |
| JayF | is a single commit, git-review, gets pushed | 20:51 |
| JayF | I need to do a revision. I revise my files, and I `git commit --amend` to amend my previous commit with these new changes. I run git-review again. | 20:51 |
| JayF | For multi-related-change workflows it gets more complex; but if you're just starting out and not chaining changes, that should work :) | 20:52 |
| JayF | also, don't sweat pushing the bonus change earlier -- I think it's borderline a rite of passage for people using gerrit for changesets for the first time :D | 20:52 |
| clarkb | jlvillal: I believe the arch is actuall aarch64 | 20:54 |
| JayF | yeah, that's what I was about to say :D | 20:54 |
| jlvillal | Trying to DIB to build a `fedora` image and it fails because it says `arm64` ARCH is not supported | 20:54 |
| clarkb | but that seems to map it to arm64 intentionally | 20:54 |
| jlvillal | maybe related to this: https://github.com/openstack/diskimage-builder/blob/174089a6a5f1ff4628a9d103e4328a1b1298e241/diskimage_builder/lib/common-defaults#L29-L30 | 20:54 |
| clarkb | jlvillal: we (opendev) build with the container element instead | 20:54 |
| jlvillal | and: https://github.com/openstack/diskimage-builder/blob/174089a6a5f1ff4628a9d103e4328a1b1298e241/diskimage_builder/elements/fedora/root.d/10-fedora-cloud-image#L27-L28 | 20:54 |
| jlvillal | It fails on line 43 of 10-fedora-cloud-image | 20:54 |
| jlvillal | Okay. Finished copying stuff over from previous post on #openstack-infra | 20:55 |
| clarkb | oh we don't build fedora for arm though | 20:55 |
| clarkb | so ya you may be blazing a new trail for fedora + arm and finding where assumptions were wrong | 20:55 |
| jlvillal | Darn. I hate blazing! ;) | 20:55 |
| jlvillal | I was afraid of that. Thanks. | 20:56 |
| clarkb | jlvillal: some logs would probably be helpful though. | 20:56 |
| jlvillal | I decided to try Fedora because Ubuntu keeps failing to build today. Was working yesterday. But I think new packages dropped but haven't hit http://ports.ubuntu.com/ :( | 20:56 |
| clarkb | I suspect the normalization there was done without consideration that some things actually use aarch64? | 20:57 |
| jlvillal | 2023-03-07 20:57:04.307 | dib-run-parts Running /tmp/dib_build.DSfkK4iq/hooks/root.d/10-fedora-cloud-image | 20:57 |
| jlvillal | 2023-03-07 20:57:04.313 | Error: unknown ARCH: arm64 | 20:57 |
| jlvillal | The most important part of the log. | 20:57 |
| clarkb | we do build https://opendev.org/openstack/project-config/src/branch/master/nodepool/nb04.opendev.org.yaml#L239-L247 though | 20:57 |
| clarkb | jlvillal: oh reading that if you set ARCH explicitly to aarch64 it should skip over things | 20:58 |
| clarkb | basically ifyou set ARCH then it doesn't try to infer it. I would try that | 20:58 |
| jlvillal | Yeah. I should at least try that :) See if it breaks other things or not. | 20:58 |
| jlvillal | Well it is moving along farther. I'll keep my fingers crossed that it will succeed. | 21:00 |
| jlvillal | clarkb, JayF Thanks. | 21:00 |
| clarkb | also you should totally not do this long term, but we mirror ubuntu-ports with reprepro which is supposed to verify that things are valid in the mirror before we publish them | 21:00 |
| clarkb | this means in theory you can get around broken mirrors using our mirror. But we definitely don't intend for them to be used publicly as we may delete/remove/move/update etc at any time | 21:00 |
| jlvillal | Oh cool. | 21:00 |
| jlvillal | I tried to use the DIB_DISTRIBUTION_MIRROR variable. But doesn't seem like it rewrites http://ports.ubuntu.com/ :( | 21:01 |
| jlvillal | Not sure if there should be a DIB_DISTRIBUTION_PORTS_MIRROR variable... | 21:02 |
| clarkb | jlvillal: https://opendev.org/openstack/project-config/src/branch/master/nodepool/nb04.opendev.org.yaml#L201 | 21:04 |
| clarkb | that is what we do | 21:04 |
| clarkb | its possible that isn't working though | 21:04 |
| clarkb | or maybe you have to use ubuntu-minimal to make it work | 21:04 |
| jlvillal | I was assuming that: https://github.com/openstack/diskimage-builder/blob/174089a6a5f1ff4628a9d103e4328a1b1298e241/diskimage_builder/elements/ubuntu/pre-install.d/01-set-ubuntu-mirror#L20 | 21:06 |
| jlvillal | did not handle ports.ubuntu.com. But maybe my regex parsing isn't correct. | 21:06 |
| clarkb | jlvillal: it may not. We don't use the ubuntu element though. We use ubuntu-minimal | 21:08 |
| jlvillal | Okay. I should give that a try. Thanks! | 21:08 |
| clarkb | with ubuntu minimal you'll need to set up our initial user and add common things like ssh | 21:09 |
| clarkb | its really there to allow you to build up what you want without the assumptions from the ubuntu image builds. | 21:10 |
| jlvillal | Thanks! | 21:10 |
| jlvillal | FYI: Fedora seemed to build. Finished without errors. | 21:10 |
| jlvillal | FYI: Ubuntu for ARM64 is building again. Looks like the packages hit ports.ubuntu.com. | 21:13 |
| JayF | We'll have to get you a hat fit for a trailblazer, John :D Thanks! | 21:19 |
| jlvillal | JayF, :) | 21:20 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!