espenfl | Hi there. Looking into https://review.opendev.org/c/openstack/diskimage-builder/+/875884. Is there a solid way to detect an Ubuntu cloud image or not? It seems the /etc/default/grub.d is only there for the cloud images and not the bare server images etc. Not sure if we should cater to all, but as it stands, the ubuntu element pull the cloud image, while ubuntu-minimal does not. | 07:36 |
---|---|---|
espenfl | Maybe we should just for Ubuntu and Debian check if /etc/default/grub.d exists, if not, use /etc/default/grub? | 07:36 |
espenfl | In the process looked into running tests locally. Seems it is just to execute tox? | 07:39 |
espenfl | I also noticed that the linter complains about a gpg file. Should we maybe exclude the lint check on those files? | 07:56 |
opendevreview | Espen Flage-Larsen proposed openstack/diskimage-builder master: Removed erroneous, comment, check for grub.d https://review.opendev.org/c/openstack/diskimage-builder/+/876084 | 13:18 |
clarkb | espenfl: as a general rule -minimal elements build images from scratch. For debuntu this uses debootstrap. The distro names without any modifiers grab the official images and modify them. And now more recently there has been work to start with docker images as a base to bootstrap things as it avoids needing tools on the host side like dnf/yum/apt/zypper/etc while still being | 15:44 |
clarkb | more minimal than the official images. | 15:44 |
espenfl | clarkb: Thanks a lot for the comment. I will keep that in mind going forward. | 15:45 |
opendevreview | Julia Kreger proposed openstack/diskimage-builder master: WIP: save the boot filesystem for fips workload cases https://review.opendev.org/c/openstack/diskimage-builder/+/876192 | 16:44 |
opendevreview | Julia Kreger proposed openstack/diskimage-builder master: WIP: save the boot filesystem for fips workload cases https://review.opendev.org/c/openstack/diskimage-builder/+/876192 | 17:51 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!