| ianw | clarkb: thanks for working through that. some meta comments on 838863; i think wait for a few other eyes on it but lgtm | 06:36 |
|---|---|---|
| rpittau | clarkb, ianw, thanks for working on that, much appreciated | 07:02 |
| rpittau | looks like also the issue we had with the upgrade job has gone, still need to retest with the correct stable branch, but it looks ok now | 07:02 |
| clarkb | fungi: if you get a chance can you look at the comments about the relaese notes in https://review.opendev.org/c/openstack/diskimage-builder/+/838863 and see if you've got suggestions on how to address that? | 15:18 |
| fungi | clarkb: to summarize, the revert is also reverting a release note which appeared in a prior release? | 15:20 |
| clarkb | fungi: yes beacuse it undoes what the previous release note documented. | 15:20 |
| clarkb | maybe we keep the previous release note and then add a new release note that mentions the change and just track it that way? | 15:21 |
| fungi | i would keep persistent-netifs-fallback-1b861e037dd8a27c.yaml and make sure dhcp-all-interfaces-debian-issue-2ec7f1a5186f0b16.yaml is clear that it's a reversal | 15:21 |
| fungi | removing release notes is akin to rewriting history and hiding problems | 15:21 |
| clarkb | cool I'll update the revert to not revert the release note | 15:22 |
| fungi | clarkb: any idea what changed with reno? https://docs.openstack.org/releasenotes/diskimage-builder/ | 15:39 |
| fungi | the current release of dib is 3.20.3 but for some reason the release notes are smashing all entries after 3.18.0 together and adding a -n suffix which seems to correspond to the number of additional tags | 15:41 |
| opendevreview | Clark Boylan proposed openstack/diskimage-builder master: Revert "Fallback to persistent netifs names with systemd" https://review.opendev.org/c/openstack/diskimage-builder/+/838863 | 15:41 |
| clarkb | fungi: no clue. I'm kinda surprised dib is in the openstack release notes though | 15:42 |
| fungi | well, it's an openstack project | 15:42 |
| clarkb | ya but it isn't managed by the release team | 15:42 |
| clarkb | intentionally so to avoid the chicken and egg the release team hit recently with other tools | 15:42 |
| clarkb | you can't have the tools the release team depends on managed by the release tooling or you can get wedged | 15:43 |
| fungi | right, but the release notes jobs aren't dependent on the openstack release management tooling as far as i'm aware, so even independent release projects run them | 15:44 |
| clarkb | I wonder if the release notes updates rely on integration with the actual release process now and since dib doesn't do that the builds are confused about what the release is? | 15:44 |
| clarkb | fungi: independent release projects don't manually tag and push they still go through the release tooling | 15:44 |
| fungi | https://releases.openstack.org/reference/release_models.html#independent "Release tags for deliverables using this tag are managed without oversight from the Release Management team." | 15:46 |
| clarkb | huh that must've changed? I thought all independent meant was that they didn't release on a set schedule | 15:47 |
| clarkb | looks like there is a release notes tox env which I assume is used to produce the documents that are weird | 15:48 |
| fungi | but yeah, you may be right, https://opendev.org/openstack/releases/src/branch/master/deliverables/_independent has things which are being tagged through automation rather than directly | 15:48 |
| fungi | maybe "oversight" doesn't mean what i think it means | 15:49 |
| clarkb | if I run `tox -e releasenotes` it seems to do the right thing | 15:50 |
| clarkb | I get those 3.18.0-5 entries listed under 3.19.0 locally and my edit from the change above as 3.20.3-5 | 15:50 |
| clarkb | maybe the job that updates stopped running before the 3.19.0 tag was made | 15:51 |
| clarkb | so we're seeing a snapshot in time that is stale | 15:51 |
| clarkb | fungi: ^ thats my best guess. The job that updates that page is just not runnign anymore for one reason or another | 16:00 |
| fungi | oh! yes, i bet you're correct. the -5 was probably the number of commits and reno isn't listing that as "in development" like it does normallyu | 16:01 |
| fungi | clarkb: confirmed, promote-openstack-releasenotes last ran for dib on the 5th commit after 3.18.0 | 16:16 |
| fungi | now to figure out why it stopped being run (it's not failing, just no longer in the pipeline) | 16:17 |
| fungi | unfortunately it stopped after 2022-02-21 so we no longer have logs indicating where it was coming from | 16:18 |
| fungi | luckily there were a bunch of changes merged that day, so i can say it stopped between 18:56:53 and 19:34:00 | 16:20 |
| fungi | oh, except that job probably doesn't get added if the files list doesn't include a release note | 16:24 |
| fungi | aha! so that was in fact the last release note merged. because release notes don't get updated in the release/tag pipeline, the published release notes end before the 3.19.0 tag was made | 16:26 |
| opendevreview | Maksim Malchuk proposed openstack/diskimage-builder master: Revert "Fallback to persistent netifs names with systemd" https://review.opendev.org/c/openstack/diskimage-builder/+/838863 | 16:29 |
| fungi | clarkb: any idea why it calculates a dev version number there instead of showing "in development" like our release notes in opendev and zuul? https://zuul-ci.org/docs/zuul/latest/releasenotes.html | 16:32 |
| fungi | i wonder if that's configurable | 16:32 |
| fungi | anyway, other openstack projects seem to include publish-openstack-releasenotes-python3 in their tag pipeline to solve this | 16:32 |
| fungi | i'll propose that addition | 16:33 |
| clarkb | I don't know | 16:35 |
| fungi | seems other openstack projects get it by adding the release-notes-jobs-python3 project-template directly in their .zuul.yaml | 16:36 |
| fungi | dib missed the transition from release-notes-jobs to release-notes-jobs-python3 and the former dropped its tag pipeline in 2018 with https://review.openstack.org/622430 | 16:39 |
| opendevreview | Jeremy Stanley proposed openstack/diskimage-builder master: Switch to release-notes-jobs-python3 https://review.opendev.org/c/openstack/diskimage-builder/+/839599 | 16:43 |
| fungi | it would be very nice to include that ^ before the next release | 16:43 |
| fungi | git show | 16:43 |
| fungi | hah, you're not my shell terminal | 16:43 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!