| cstone | Hi all. I am using diskimage-builder to build an image based off an Ubuntu 20.04 QCOW2 packager image we create. I'm finding that at some point DIB attempts to remove GRUB, which is now an "essential package" and I think may need --allow-remove-essential for that command. (example: https://pastebin.com/0dJVzfQG) | 00:25 |
|---|---|---|
| cstone | Adding the param to https://github.com/openstack/diskimage-builder/blob/master/diskimage_builder/elements/ubuntu/pre-install.d/00-remove-grub#L13-L17 does make our image build succeed | 00:27 |
| ianw | cstone: hrm, what point is it removing grub? | 00:32 |
| cstone | ianw: Looks like it's part of the ubuntu element pre-install | 00:32 |
| ianw | hrm, ok, it looks like that general idea has been there since 2013. it may well not be relevant now | 00:34 |
| ianw | # The grub post-kernel install hook will barf if the block device can't be | 00:35 |
| ianw | # found (as happens in a chroot). | 00:35 |
| ianw | i doubt the grub post-install hooks look anything like what they used to | 00:35 |
| cstone | yeah, very likely that might not be needed anymore - at the very least, it seems like it's changing and might cause problems | 00:36 |
| ianw | my first thought would probably be to remove that | 00:37 |
| ianw | we don't do a lot of testing on the ubuntu element. cgoncalves *may* know more | 00:38 |
| opendevreview | likui proposed openstack/diskimage-builder master: Replace deprecated assertEquals https://review.opendev.org/c/openstack/diskimage-builder/+/817663 | 01:46 |
| opendevreview | Chris Stone proposed openstack/diskimage-builder master: Adding allow-remove-essential for ubuntu grub install. https://review.opendev.org/c/openstack/diskimage-builder/+/817666 | 02:13 |
| opendevreview | Chris Stone proposed openstack/diskimage-builder master: Adding allow-remove-essential for ubuntu grub removal. https://review.opendev.org/c/openstack/diskimage-builder/+/817666 | 02:15 |
| cstone | I submitted a bug for it and a quickie fix (just adding the flag in) but it may be more appropriate to remove entirely. I'm a bit less familiar of the impact on that. | 02:19 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!