| openstackgerrit | Michael Johnson proposed openstack/diskimage-builder master: Set correct python version for non-chroot scripts https://review.opendev.org/697211 | 01:02 |
|---|---|---|
| *** erolg has quit IRC | 03:40 | |
| *** dasp has quit IRC | 04:41 | |
| *** dasp has joined #openstack-dib | 04:41 | |
| openstackgerrit | Michael Johnson proposed openstack/diskimage-builder master: Set correct python version for non-chroot scripts https://review.opendev.org/697211 | 05:37 |
| openstackgerrit | Merged openstack/diskimage-builder master: Allow zypper repos to be overrideable https://review.opendev.org/696990 | 06:14 |
| *** yolanda has quit IRC | 08:18 | |
| *** lennyb has quit IRC | 08:24 | |
| *** irclogbot_2 has quit IRC | 08:24 | |
| *** benj_ has quit IRC | 08:24 | |
| *** ianw has quit IRC | 08:24 | |
| *** mroh has quit IRC | 08:24 | |
| *** mjturek has quit IRC | 08:24 | |
| *** strigazi has quit IRC | 08:24 | |
| *** dasp has quit IRC | 08:24 | |
| *** andrein has quit IRC | 08:24 | |
| *** adam_g has quit IRC | 08:24 | |
| *** owalsh has quit IRC | 08:24 | |
| *** TheJulia has quit IRC | 08:24 | |
| *** mnasiadka has quit IRC | 08:24 | |
| *** openstackgerrit has quit IRC | 08:24 | |
| *** logan- has quit IRC | 08:24 | |
| *** hwoarang has quit IRC | 08:24 | |
| *** falencastro has quit IRC | 08:24 | |
| *** Anticimex has quit IRC | 08:24 | |
| *** daniel2 has quit IRC | 08:24 | |
| *** fungi has quit IRC | 08:24 | |
| *** rajinir has quit IRC | 08:24 | |
| *** jangutter has quit IRC | 08:24 | |
| *** tonyb has quit IRC | 08:24 | |
| *** tobiash has quit IRC | 08:24 | |
| *** lchabert has quit IRC | 08:24 | |
| *** cgoncalves has quit IRC | 08:24 | |
| *** johnsom has quit IRC | 08:24 | |
| *** brault has quit IRC | 08:24 | |
| *** tflink has quit IRC | 08:24 | |
| *** prometheanfire has quit IRC | 08:24 | |
| *** mgagne has quit IRC | 08:24 | |
| *** arne_wiebalck has quit IRC | 08:24 | |
| *** rm_work has quit IRC | 08:24 | |
| *** ChanServ has quit IRC | 08:24 | |
| *** dasp has joined #openstack-dib | 08:24 | |
| *** jangutter has joined #openstack-dib | 08:24 | |
| *** brault has joined #openstack-dib | 08:24 | |
| *** andrein has joined #openstack-dib | 08:24 | |
| *** mnasiadka has joined #openstack-dib | 08:24 | |
| *** TheJulia has joined #openstack-dib | 08:24 | |
| *** owalsh has joined #openstack-dib | 08:24 | |
| *** adam_g has joined #openstack-dib | 08:24 | |
| *** logan- has joined #openstack-dib | 08:24 | |
| *** lennyb has joined #openstack-dib | 08:24 | |
| *** hwoarang has joined #openstack-dib | 08:24 | |
| *** tflink has joined #openstack-dib | 08:24 | |
| *** openstackgerrit has joined #openstack-dib | 08:24 | |
| *** tonyb has joined #openstack-dib | 08:24 | |
| *** falencastro has joined #openstack-dib | 08:24 | |
| *** irclogbot_2 has joined #openstack-dib | 08:24 | |
| *** tobiash has joined #openstack-dib | 08:24 | |
| *** benj_ has joined #openstack-dib | 08:24 | |
| *** daniel2 has joined #openstack-dib | 08:24 | |
| *** prometheanfire has joined #openstack-dib | 08:24 | |
| *** mgagne has joined #openstack-dib | 08:24 | |
| *** ianw has joined #openstack-dib | 08:24 | |
| *** Anticimex has joined #openstack-dib | 08:24 | |
| *** mroh has joined #openstack-dib | 08:24 | |
| *** fungi has joined #openstack-dib | 08:24 | |
| *** rajinir has joined #openstack-dib | 08:24 | |
| *** lchabert has joined #openstack-dib | 08:24 | |
| *** cgoncalves has joined #openstack-dib | 08:24 | |
| *** mjturek has joined #openstack-dib | 08:24 | |
| *** strigazi has joined #openstack-dib | 08:24 | |
| *** ChanServ has joined #openstack-dib | 08:24 | |
| *** arne_wiebalck has joined #openstack-dib | 08:24 | |
| *** rm_work has joined #openstack-dib | 08:24 | |
| *** johnsom has joined #openstack-dib | 08:24 | |
| *** orwell.freenode.net sets mode: +o ChanServ | 08:24 | |
| *** ivve has joined #openstack-dib | 08:36 | |
| *** yolanda has joined #openstack-dib | 08:58 | |
| *** dasp has quit IRC | 15:02 | |
| *** dasp has joined #openstack-dib | 15:03 | |
| *** yolanda__ has joined #openstack-dib | 15:15 | |
| *** yolanda__ has quit IRC | 15:18 | |
| *** ivve has quit IRC | 15:33 | |
| *** jangutter has quit IRC | 16:41 | |
| *** lennyb has quit IRC | 18:05 | |
| *** lennyb has joined #openstack-dib | 18:18 | |
| *** lennyb has quit IRC | 18:25 | |
| *** lennyb has joined #openstack-dib | 18:27 | |
| *** lennyb has quit IRC | 19:10 | |
| *** lennyb has joined #openstack-dib | 19:22 | |
| *** lennyb has quit IRC | 19:38 | |
| *** lennyb has joined #openstack-dib | 19:42 | |
| rm_work | ianw: wat: https://zuul.opendev.org/t/openstack/build/1d570321293b41879e00481d6270032b/log/logs/apt-sources_test-sources.FAIL.log#1889 | 19:49 |
| rm_work | doesn't look related to the patch | 19:50 |
| rm_work | but maybe I just don't understand the link | 19:50 |
| rm_work | suppose i'll recheck | 19:50 |
| ianw | rm_work: that test is supposed to fail, and i think that the new code doesn't exit with the failure code... commenting | 20:04 |
| rm_work | ahh | 20:06 |
| rm_work | like, os.execve raises maybe if it gets a nonzero exit code? | 20:06 |
| rm_work | ahh yeah | 20:07 |
| rm_work | it's a process replace with OSError raised on errors | 20:08 |
| rm_work | so we need to capture the return code from the subprocess call and raise based on that after we clean up | 20:08 |
| ianw | yeah, see my comments, i might prefer we keep the exec | 20:08 |
| rm_work | raise? or just exit with the proper return code? | 20:08 |
| rm_work | ah | 20:08 |
| rm_work | hmm k | 20:08 |
| ianw | we have had problems with hanging subprocesses in various ways before because of pipes/fd's and it's not something anyone wants to think about too much :) | 20:09 |
| rm_work | lol | 20:09 |
| rm_work | k | 20:09 |
| ianw | adding another possible point stdio/etc gets duped might be ... fun :) | 20:09 |
| rm_work | yeah i'm ok with that I guess? though it technically separates the cleanup from the function which is not ideal | 20:10 |
| rm_work | but it's not a MAJOR leak even if cleanip fails | 20:10 |
| rm_work | do you know where the fix needs to go? | 20:10 |
| ianw | ummm, not off the top of my head, but we do have cleanup traps | 20:14 |
| johnsom | Yeah, that was a "guess" at the right answer. I didn't want to leave the temp dirs laying around | 20:14 |
| ianw | it is janky, that's for sure. we had some plans to move all of the driver into the python script (which is much easier to install with entry-points, etc) | 20:15 |
| johnsom | Good news it fixed the problem... lol | 20:15 |
| johnsom | ianw So if I read that right, you are proposing to pass the tempdir path to the bash script and have it clean up? | 20:16 |
| johnsom | Or, yeah, just set an environ var with the path, but that seems questionable. "here delete this path for me..." | 20:17 |
| ianw | i would be happy with that, using say a _ private variable, just so we minimise changing the exec() portions for this. | 20:17 |
| ianw | or do it all in the script, or put a known prefix on the tempdir | 20:18 |
| ianw | ... it just stuck me that some people might set noexec on their TMPDIR | 20:18 |
| ianw | does that count for a symlink to a non-tmp file? i don't know | 20:20 |
| ianw | does it even work *now* with noexec on TMPDIR is another question i don't know the answer too | 20:20 |
| johnsom | I know the patch as posted fixed the svc-map extra-data problem, that is about it. | 20:21 |
| openstackgerrit | Michael Johnson proposed openstack/diskimage-builder master: Set correct python version for non-chroot scripts https://review.opendev.org/697211 | 22:44 |
| johnsom | Moved it inside the bash and changed the temporary file location to be a temp dir under the home directory similar to the .cache directory | 22:45 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!