| *** yolanda_ has quit IRC | 02:41 | |
| *** lennyb has quit IRC | 02:41 | |
| *** yolanda_ has joined #openstack-dib | 02:42 | |
| *** lennyb has joined #openstack-dib | 02:42 | |
| *** mtreinish has quit IRC | 02:44 | |
| *** mtreinish has joined #openstack-dib | 02:45 | |
| *** mtreinish has left #openstack-dib | 02:45 | |
| *** mtreinish has joined #openstack-dib | 02:45 | |
| *** tonyb has quit IRC | 02:46 | |
| *** sambetts_ has quit IRC | 02:46 | |
| *** openstackgerrit has quit IRC | 02:46 | |
| *** sai_ has quit IRC | 02:46 | |
| *** pleia2 has quit IRC | 02:46 | |
| *** tonyb has joined #openstack-dib | 02:47 | |
| *** sambetts_ has joined #openstack-dib | 02:47 | |
| *** openstackgerrit has joined #openstack-dib | 02:47 | |
| *** sai_ has joined #openstack-dib | 02:47 | |
| *** pleia2 has joined #openstack-dib | 02:47 | |
| *** mgagne has quit IRC | 02:50 | |
| *** olivierbourdon38 has quit IRC | 02:50 | |
| *** jesusaur has quit IRC | 02:50 | |
| *** pmannidi has quit IRC | 02:50 | |
| *** dlbewley has quit IRC | 02:50 | |
| *** strigazi has quit IRC | 02:50 | |
| *** cloudnull has quit IRC | 02:50 | |
| *** mgagne has joined #openstack-dib | 02:50 | |
| *** olivierbourdon38 has joined #openstack-dib | 02:50 | |
| *** dlbewley has joined #openstack-dib | 02:51 | |
| *** strigazi has joined #openstack-dib | 02:51 | |
| *** cloudnull has joined #openstack-dib | 02:51 | |
| *** jesusaur has joined #openstack-dib | 02:51 | |
| *** pmannidi has joined #openstack-dib | 02:51 | |
| *** jesusaur has quit IRC | 02:55 | |
| *** jesusaur has joined #openstack-dib | 03:22 | |
| *** chhagarw has joined #openstack-dib | 05:29 | |
| *** yolanda has joined #openstack-dib | 05:33 | |
| *** yolanda_ has quit IRC | 05:35 | |
| *** hashar has joined #openstack-dib | 07:16 | |
| *** pavel_V has joined #openstack-dib | 07:21 | |
| *** pavel_V has quit IRC | 07:26 | |
| *** pavel_V has joined #openstack-dib | 07:30 | |
| *** hwoarang has joined #openstack-dib | 07:44 | |
| *** hwoarang has quit IRC | 07:47 | |
| *** hwoarang has joined #openstack-dib | 07:48 | |
| *** yolanda has quit IRC | 08:01 | |
| *** yolanda has joined #openstack-dib | 08:17 | |
| *** pavel_V has quit IRC | 08:59 | |
| *** pavel_V has joined #openstack-dib | 08:59 | |
| *** jesusaur has quit IRC | 09:14 | |
| *** jesusaur has joined #openstack-dib | 09:18 | |
| *** sambetts_ is now known as sambetts|afk | 09:22 | |
| *** sambetts|afk is now known as sambetts | 09:25 | |
| *** yolanda has quit IRC | 10:38 | |
| *** yolanda has joined #openstack-dib | 10:42 | |
| *** yolanda_ has joined #openstack-dib | 13:40 | |
| *** yolanda has quit IRC | 13:42 | |
| *** mjturek has joined #openstack-dib | 14:32 | |
| *** rajinir has joined #openstack-dib | 14:40 | |
| *** hashar is now known as hasharAway | 16:01 | |
| *** roman_g has joined #openstack-dib | 16:01 | |
| roman_g | Hello team. Please, review and merge https://review.openstack.org/#/c/568697/ | 16:03 |
|---|---|---|
| roman_g | There is +2 from Ian, so I'm seeking for input from others :) | 16:03 |
| roman_g | Patch allows to rebuild arbitrary images, which location, filename and | 16:04 |
| roman_g | sha256sum are specified in variables, not only hardcoded $DIB_RELEASE/current. | 16:04 |
| roman_g | That's for Ubuntu | 16:04 |
| clarkb | roman_g: my first impression is ++ but do we have a release notes mechanism for dib? we may want to make note that if you are using the old style url a small update is necessary to use the new ones | 16:04 |
| clarkb | seems that it does use reno | 16:05 |
| clarkb | roman_g: any chance you want to push a followup change to add a reno note for this? (I don't think we need a new patchset so I can go ahead and approve it with ianw's existing +2) | 16:06 |
| clarkb | otherwise ianw or myself can push the reno update too | 16:06 |
| roman_g | it's made to be backwards compatible | 16:06 |
| roman_g | I did it intentionally to not break other people's setup | 16:06 |
| clarkb | roman_g: it is if you don't specifiy a custom url but if you are setting a custom url you will have to update what you set | 16:06 |
| clarkb | (and I think for most users this is the case so they won't notice and it will be fine) | 16:07 |
| roman_g | > if you are setting a custom url | 16:08 |
| roman_g | that's why I submitted this patch set | 16:08 |
| clarkb | if for example I set DIB_CLOUD_IMAGES to https://my.domain.com I will have to update it to https://my.domain.com/$release/currnt | 16:08 |
| roman_g | because if you specify custom URL, this script does not work ) | 16:08 |
| clarkb | roman_g: it does as long as the paths are correct at that domain | 16:08 |
| clarkb | and this definitely makes that use case easier (I think it is a good change for that reason) | 16:08 |
| roman_g | mmm. | 16:09 |
| roman_g | got it | 16:09 |
| roman_g | where are the release notes? | 16:09 |
| clarkb | roman_g: they are in diskimage-builder/releasenotes they appear to be managed by the reno tool. There is a reno command to make a new note that you update and commit as a change. https://docs.openstack.org/reno/latest/user/usage.html has details on that process | 16:10 |
| roman_g | got it | 16:11 |
| roman_g | thank you! | 16:11 |
| *** mjturek has quit IRC | 16:53 | |
| openstackgerrit | Merged openstack/diskimage-builder master: Allow to rebuild arbitrary images https://review.openstack.org/568697 | 17:06 |
| roman_g | clarkb: I've added release notes with `reno new xxxxx` | 17:11 |
| roman_g | but can't see it when run `reno report .` | 17:11 |
| roman_g | what could be wrong? | 17:11 |
| roman_g | `reno lint .` shows no errors | 17:11 |
| clarkb | I think it may rely on git to find the notes, have you added the file to git? | 17:12 |
| *** mjturek has joined #openstack-dib | 17:12 | |
| clarkb | may even need to make a commit for it | 17:12 |
| roman_g | ahha, you are right | 17:12 |
| roman_g | it should have been added to git first | 17:13 |
| roman_g | thank you! | 17:13 |
| openstackgerrit | Roman Gorshunov proposed openstack/diskimage-builder master: Added release notes for Change 568697 https://review.openstack.org/570978 | 17:15 |
| roman_g | clarkb: here is it ^^^ | 17:16 |
| clarkb | roman_g: thank you +2 | 17:16 |
| roman_g | :) | 17:16 |
| roman_g | check first ) | 17:16 |
| *** sambetts is now known as sambetts|afk | 17:31 | |
| *** pmannidi has quit IRC | 18:52 | |
| *** pmannidi has joined #openstack-dib | 18:59 | |
| *** chhagarw has quit IRC | 19:00 | |
| *** hasharAway has quit IRC | 19:21 | |
| *** rajinir has quit IRC | 23:10 | |
| *** mjturek has quit IRC | 23:32 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!