Thursday, 2017-09-21

*** openstackgerrit has joined #openstack-dib00:26
openstackgerritIan Wienand proposed openstack/diskimage-builder master: Add initramfs-tools for ubuntu-minimal  https://review.openstack.org/50585700:26
*** openstackgerrit has quit IRC00:41
*** Sukhdev has quit IRC01:39
*** strigazi has quit IRC01:56
*** strigazi has joined #openstack-dib01:58
*** openstackgerrit has joined #openstack-dib02:01
openstackgerritIan Wienand proposed openstack/diskimage-builder master: Add initramfs-tools for ubuntu-minimal  https://review.openstack.org/50585702:01
openstackgerritIan Wienand proposed openstack/diskimage-builder master: Avoid networkx 2.0 release  https://review.openstack.org/50590802:01
*** yolanda has quit IRC02:34
*** yolanda has joined #openstack-dib02:35
*** Sukhdev has joined #openstack-dib03:24
openstackgerritIan Wienand proposed openstack/diskimage-builder master: Support networkx 2.0  https://review.openstack.org/50596304:09
*** andreas-f has joined #openstack-dib04:42
openstackgerritIan Wienand proposed openstack/diskimage-builder master: Add initramfs-tools for ubuntu-minimal  https://review.openstack.org/50585704:43
openstackgerritIan Wienand proposed openstack/diskimage-builder master: Add initramfs-tools for ubuntu-minimal/pin networkx <2.0  https://review.openstack.org/50585704:49
ianwprometheanfire: ^ hopefully once this all falls out, that gets the gate going again04:49
prometheanfireyarp04:49
prometheanfiretomorrow is my scheduled build the gentoo images day04:50
ianwi guess we need to obey upper-constraints04:53
prometheanfireit is sorta enforced :P04:55
ianwdon't we need a tox_install.sh and stuff?04:57
prometheanfireyes, let me take a look04:58
prometheanfireya, the tox file needs updating04:58
openstackgerritMatthew Thode proposed openstack/diskimage-builder master: Use upper-constraints in tox tests  https://review.openstack.org/50597505:00
prometheanfireianw: that should fix ya ^05:00
prometheanfireI think that's the only place it's needed...05:00
prometheanfireso says the grep on the nova repo :D05:01
prometheanfireianw: that will probably still need your gate fixing stuff to fix the other breakage though05:02
prometheanfireso feel free to update it05:02
prometheanfirenot sure which review that was in05:02
*** Sukhdev has quit IRC05:23
*** ChanServ sets mode: +o openstack07:18
*** hashar has joined #openstack-dib07:29
openstackgerrityolanda.robla proposed openstack/diskimage-builder master: Add initramfs-tools for ubuntu-minimal  https://review.openstack.org/50585708:08
yolandahi, resuming the job from Ian... so trying to land fixes one by one08:08
openstackgerrityolanda.robla proposed openstack/diskimage-builder master: Add initramfs-tools for ubuntu-minimal  https://review.openstack.org/50585708:29
*** hashar has quit IRC08:38
*** hashar has joined #openstack-dib08:39
openstackgerrityolanda.robla proposed openstack/diskimage-builder master: Add initramfs-tools for ubuntu-minimal  https://review.openstack.org/50585708:42
openstackgerritMerged openstack/diskimage-builder master: Add initramfs-tools for ubuntu-minimal  https://review.openstack.org/50585708:44
hwoarangyolanda: should you add a proper reference to bug report on https://review.openstack.org/#/c/505857/ ?08:54
yolandaah, the dib one... https://bugs.launchpad.net/ubuntu/+source/linux-azure/+bug/1700972 was linked08:56
openstackLaunchpad bug 1700972 in linux-azure (Ubuntu Xenial) "Please only recommend or suggest initramfs-tools | linux-initramfs-tool for kernels able to boot without initramfs" [Low,Fix committed] - Assigned to Marcelo Cerri (mhcerri)08:56
yolandaanyway i already merged that, to try unlock the network problem as well. Hoping it works08:59
openstackgerrityolanda.robla proposed openstack/diskimage-builder master: Support networkx 2.0  https://review.openstack.org/50596309:43
openstackgerritMerged openstack/diskimage-builder master: Support networkx 2.0  https://review.openstack.org/50596309:43
openstackgerrityolanda.robla proposed openstack/diskimage-builder master: debootstrap: Call update-initramfs explicitly  https://review.openstack.org/50458809:44
*** hashar has quit IRC10:16
*** jesusaur has quit IRC10:36
*** jesusaur has joined #openstack-dib10:40
*** andreas-f has quit IRC10:44
hwoarangianw:  this https://review.openstack.org/#/c/505905/ pins networkx<2.0 but your https://review.openstack.org/#/c/505963/ dropped support for networkx-1.010:53
hwoarangand diskimage-builder doesn't have updated requirements.txt so it will not try to force networkx>2.010:54
hwoarang*>=10:54
hwoarangthings will start breaking soon I believe10:54
openstackgerrityolanda.robla proposed openstack/diskimage-builder master: Revert "Support networkx 2.0"  https://review.openstack.org/50611811:10
yolandatrying to revert the network>2.0 support... but things look bad with nodepool gateas11:17
yolandagates11:17
openstackgerritOpenStack Proposal Bot proposed openstack/diskimage-builder master: Updated from global requirements  https://review.openstack.org/50616613:27
*** chhavi has joined #openstack-dib13:31
*** hashar has joined #openstack-dib14:26
johnsomhttp://logs.openstack.org/70/506170/1/check/gate-octavia-v1-dsvm-scenario-multinode/b3bbeb2/logs/devstacklog.txt.gz#_2017-09-21_14_13_09_53914:31
johnsomYep, broken with the g-r update14:32
*** openstackgerrit has quit IRC14:33
*** andreas_s has joined #openstack-dib15:17
andreas_sHi is anyone facing an issue with the ubuntu minimal build? At least I do since yesterday. For the first thing a patch was already submitted https://review.openstack.org/#/c/505857/15:18
andreas_sbut now I'm facing a different one: https://bugs.launchpad.net/diskimage-builder/+bug/171870215:19
openstackLaunchpad bug 1718702 in diskimage-builder "ubuntu minimal build fails with: KeyError: 'blockdev'" [Undecided,New]15:19
andreas_s(using version 2.8)15:19
andreas_sanyone facing the same?15:19
*** andreas_s has quit IRC15:25
clarkbandreas_s seems to have left but yes we were having kernel panics on xenial builds using ubuntu-minimal. ianw was looking at it iirc15:34
hwoarangclarkb: fyi https://bugs.launchpad.net/diskimage-builder/+bug/1718415 and perhaps this fixes it https://review.openstack.org/#/c/505857/16:08
openstackLaunchpad bug 1718415 in diskimage-builder "xenial image fails to mount rootfs" [Undecided,Confirmed]16:09
clarkbthanks16:09
*** hashar has quit IRC16:18
*** Sukhdev has joined #openstack-dib17:57
*** chhavi has quit IRC17:59
rm_workhey, any word on the strategy for fixing the networkx breakage?18:00
rm_workoctavia gates are broken pending this issue18:00
rm_workI am willing to help if there's something I can do to speed this up18:00
rm_workdo we know exactly what the plan is to fix it? moving forward with changes to use the new version, or pinning to an older one, or what?18:01
rm_workyolanda / hwoarang / ianw ^^18:02
*** Sukhdev has quit IRC18:03
yolandarm_work, i need reviews on https://review.openstack.org/50616218:03
rm_workok yeah just started looking at that18:03
rm_workdid they really just rename a thing?18:03
yolandathey did a set of breaking changes when landing v218:04
yolandai pinged ianw to review and approve it18:05
yolandaright now the dib code works for networkx 2.0 but fails for lower versions18:05
rm_workso what was dg.nodes is now dg.node, and there's a new thing that's different but named using the old name dg.nodes ?18:05
rm_workoh18:05
rm_workok so18:05
rm_workkinda the opposite18:05
rm_workthey moved what was "dg.node" to "dg.nodes"?18:06
rm_workugh ok probably i am just distracting you18:06
rm_workis ianw the only one who can move this forward?18:06
yolandathis is the list of changes https://networkx.github.io/documentation/stable/release/migration_guide_from_1.x_to_2.0.html18:07
yolandaany other dib core could make it land as well18:07
yolandaor i could approve myself, but i don't think ian will take so much to join18:07
rm_workok so i think I understand18:12
rm_workand I think your solution should work18:12
johnsomIt looks like it failed a gate.18:14
rm_worknothing voting18:15
rm_worktripleo18:15
rm_worknot sure if relevant18:15
johnsomYeah, it was odd and looked like it was voting18:16
rm_workhttp://logs.openstack.org/62/506162/1/check-tripleo/gate-tripleo-ci-centos-7-ovb-ha-oooq/11abb24/console.html#_2017-09-21_13_29_23_86726518:16
rm_worklooks unrelated18:16
rm_workhttp://logs.openstack.org/62/506162/1/check-tripleo/gate-tripleo-ci-centos-7-ovb-ha-oooq/11abb24/console.html#_2017-09-21_13_27_34_52517018:17
rm_workthat task is probably well before actually doing the DIB stuff?18:17
johnsomhttp://logs.openstack.org/62/506162/1/check-tripleo/gate-tripleo-ci-centos-7-ovb-ha-oooq/11abb24/logs/undercloud/home/jenkins/repo_setup.log.txt.gz#_2017-09-21_13_27_3718:19
johnsomYeah, undercloud stuff, so I suspect not related18:20
*** calebb has joined #openstack-dib19:38
calebbhey, i seem to be running into https://bugs.launchpad.net/diskimage-builder/+bug/1718702 , any idea if there is some sort of temporary work around, or what might be causing the issue?19:42
openstackLaunchpad bug 1718702 in diskimage-builder "ubuntu minimal build fails with: KeyError: 'blockdev'" [Undecided,New]19:42
calebbi tried using dib 2.7.2 instead of 2.8 and i had the same error19:42
prometheanfireI think I'm getting the same erorr on gentoo builds too19:46
prometheanfireI'll know in a couple min19:47
prometheanfireyep KeyError: 'blockdev'19:47
prometheanfiretry reverting a47ff0dd4abbceae786d9a5a4d1ce8042a9eb4f7 (it's what I'm trying next19:48
calebbim gonna install from source and see if i can figure out a fix19:53
bkeroWow this got a lot more complicated than last time I looked19:55
prometheanfireactually that wone worked20:04
prometheanfireso master worksforme (at least for one image20:05
bkeroprometheanfire: how about latest tag?20:06
calebbyeah im testing master and it looks like it might be working20:06
prometheanfireI run git master :|20:06
prometheanfireplus whatever patchset I'm working on20:06
bkeroTime to bisect20:07
prometheanfireI think this is mostly a side effect of not running with upper-constraints20:08
calebbyeah master just worked for me too20:08
prometheanfireI wonder if dib has a 'is_truthy' function, so passed in envars could be '1,yes,Yes,true,True' etc20:30
ianwok ... what's up :/20:34
prometheanfireI think we are ok now20:36
prometheanfirehttps://bugs.launchpad.net/diskimage-builder/+bug/171870220:36
openstackLaunchpad bug 1718702 in diskimage-builder "ubuntu minimal build fails with: KeyError: 'blockdev'" [Undecided,New]20:36
prometheanfirehaven't reproduced since the multiversion networkx patch made it in20:36
ianwhas that merged?20:40
ianwok, so networkx is pinned to <2.0 in requirements now20:42
ianwand we've also merged a 2.0 fix https://review.openstack.org/50596320:44
ianwand we have a bit of a hack out there to support both in https://review.openstack.org/#/c/50616220:45
ianwan open critical tripleo bug in https://bugs.launchpad.net/tripleo/+bug/1718753/20:45
openstackLaunchpad bug 1718753 in tripleo "DIB fails to build images, UnboundLocalError: local variable 'call_order' referenced before assignment" [Critical,Triaged] - Assigned to Ian Wienand (iwienand)20:45
*** openstackgerrit has joined #openstack-dib20:49
openstackgerritOpenStack Proposal Bot proposed openstack/diskimage-builder master: Updated from global requirements  https://review.openstack.org/50616620:49
ianwprometheanfire: 505975 ... i'd like to make sure we don't confuse ourselves even more :/20:53
ianwok, so it seems what should happen now is that we revert my 2.0 fix and take the <2.0 requirements pin from global requirements20:55
ianwthen figure out how to make sure we're testing against upper constraints20:55
ianwthen put the 2.0 change back against the requirements change to bump it, along with the other projects20:57
ianwok, have to run for a bit but will do that, then look at a release21:00
openstackgerritOpenStack Proposal Bot proposed openstack/diskimage-builder master: Updated from global requirements  https://review.openstack.org/50616621:06
openstackgerritBen Nemec proposed openstack/diskimage-builder master: Revert "Support networkx 2.0"  https://review.openstack.org/50637621:11
prometheanfireianw: sounds like a plan21:19
prometheanfireianw: ok, so how about I also fix it in project-config?21:28
*** Sukhdev has joined #openstack-dib21:28
openstackgerritOpenStack Proposal Bot proposed openstack/diskimage-builder master: Updated from global requirements  https://review.openstack.org/50616621:34
clarkbianw: was the networkx issue the thing breaking the xenial build fix?21:34
openstackgerritMatthew Thode proposed openstack/diskimage-builder master: Use upper-constraints in tox tests  https://review.openstack.org/50597521:35
prometheanfireianw: https://review.openstack.org/505975 depends on the project-config change for dib to use upper-constraints, I think that's everywhere now?21:35
clarkbactually that change merged but failed CI? I am confused21:39
prometheanfireclarkb: aren't we all21:45
ianwclarkb: networkx was unrelated to xenial21:47
*** evrardjp has quit IRC21:47
*** rm_work has quit IRC21:47
clarkbianw: ok, any idea how https://review.openstack.org/#/c/505857/7/ merged? it looks like CI was failing (due to networkx?)21:48
ianwclarkb: it says "change has been successfully pushed" ... maybe yolanda did it out of band?21:49
clarkbya wondering if that is how gerrit shows that21:49
tonybo/21:49
ianwthat said, i think what i want to do is pin everything to <2.0 networkx and then we can tackle doing the upgrade properly21:50
ianwtonyb: thanks, so my question is around how do i handle testing of new upper-constraints.txt with depends-on?21:50
ianwtonyb: like https://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/diskimage-builder.yaml#n3521:50
ianware there examples to follow?21:51
tonybianw: You need to rebase and take https://review.openstack.org/#/c/412747/21:51
tonybianw: otherwise you don't support constrarints21:52
tonybbut once you have that then Depends-On shoudl do excatly what you want21:52
*** evrardjp has joined #openstack-dib21:52
ianwheh, 8 months ago :/21:52
tonybMy fault as it hit a merge conflict and I didn't fix it21:53
tonybDo you want me to do it now?21:53
ianwtonyb: ok, i'm just wondering about the non-tox case too though21:53
ianwi want to make sure testing is in sync21:54
tonybI don't have a godd answer there, I normall just pip install -c giturl .21:55
ianwwe shouldn't use a plain "pip install"?  https://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/diskimage-builder.yaml#n35 should be a tox_install?21:55
ianwotherwise it seems like our functional tests will be different libraries to our unit tests, which seems ... confusing21:55
tonybYeah, I think the right way would be to also clone requirements (or use the macro?) which will set UPPER_CONSTRAINTS_FILE for you21:56
tonybthen the can pip install to pip install -c .....21:57
tonybMind you your suggestion of just callign tox_oinstall shoudl work albeit with the potential for network issues to stomp on you21:57
openstackgerritTony Breeds proposed openstack/diskimage-builder master: Add Constraints support  https://review.openstack.org/41274721:59
ianwthat would make sense.  tl;dr -- add requirements to the zuul-cloner, and use "-c" in the pip install pointing at that ?21:59
tonybYup22:00
ianwok22:01
tonybianw: I don't know if you can just use: https://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/macros.yaml#n4022:02
*** rm_work has joined #openstack-dib22:02
*** rm_work has quit IRC22:02
*** rm_work has joined #openstack-dib22:02
openstackgerritIan Wienand proposed openstack/diskimage-builder master: Revert "Support networkx 2.0"  https://review.openstack.org/50639822:03
tonyband then just pip install -c ./upper-constraints.txt ....22:03
tonybbasically the same thing just less grow your own22:03
ianwprometheanfire / tonyb: ^ so we're in agreement on the broad steps in 50639822:03
ianwi will do a release with the <2.0 pin.  then we can add proper constraints support22:04
ianwtonyb: oh nice, yes that would be the way to go22:04
*** owalsh_ has joined #openstack-dib22:04
tonybianw: +1 I endorse that plan22:05
prometheanfireI've been distracted, what's up?22:06
ianwtonyb: ok, thanks :)22:06
ianwprometheanfire: basically the steps in 50639822:06
*** owalsh- has joined #openstack-dib22:06
ianwwith step 1.5 being a 2.9 dib release so people can use that22:07
*** owalsh has quit IRC22:07
*** owalsh- is now known as owalsh22:07
prometheanfirelooks like https://review.openstack.org/506398 is step 122:07
prometheanfireand 1a22:07
clarkbianw: once you'd got things settled, can you make sure to let us know when you think it is safe to build xenial images again?22:07
ianwclarkb: yep, that will be when 2.9 release is made22:08
prometheanfirehttps://review.openstack.org/505975 with it's depends-on should be step 222:08
clarkbcool, thanks22:08
ianwprometheanfire: i think we want 412747?22:09
*** owalsh_ has quit IRC22:09
ianwbtw, this is mea culpa ... i should have thought ahead about what happened when an incompatible 2.0 was released when i was warned about it with that bug22:09
tonybprometheanfire: personally I think https://review.openstack.org/#/c/412747/ not 50597522:09
ianwlive and learn22:10
tonybprometheanfire: the depends-on is fine but slightly sub-optimal22:11
tonybanyway /me needs linner22:11
prometheanfiretonyb: right, forgot about the self refrence thing22:11
prometheanfiretonyb: you need to update that patch, it include a merge conflict (was auto --contined it looks like)22:12
tonybGah how did I do that?22:12
prometheanfiretonyb: guess I'll need to figure out how to fix it up in project-config then22:13
prometheanfirewe still need something like https://review.openstack.org/#/c/506388/22:13
prometheanfirethe easiest way would be to just sed out the disimagebuilder line from upper-constraints22:14
openstackgerritTony Breeds proposed openstack/diskimage-builder master: Add Constraints support  https://review.openstack.org/41274722:15
ianwprometheanfire: ohh, so "pip install -cFOO -e ." in the diskimage-builder directory is going to look at the constraints, see that the local dir is higher and take the pip version?22:17
ianwor does it figure this out?22:17
clarkbconstraints always wins.22:18
clarkbso if you have foo>3.0 in requirements but foo===2.5 in constraints then 2.5 will be installed22:18
prometheanfireyep22:18
*** yolanda has quit IRC22:18
prometheanfirethat's what it needs the sed22:18
ianwclarkb: even if you're installing from your git checkout?22:19
prometheanfireI just updated https://review.openstack.org/50638822:19
prometheanfireyep22:19
prometheanfirethat's the === power22:19
clarkbya, which is why we have the special machinery to work around that22:19
prometheanfire:D22:19
ianwhow to other projects deal with that?22:19
*** yolanda has joined #openstack-dib22:20
prometheanfirethat's what https://review.openstack.org/#/c/412747/4/tools/tox_install.sh fixes22:20
prometheanfirealso not sure if my sed method is the correct one for the project-config change though22:21
ianwahhhh, ok22:22
ianwprometheanfire: why not use edit-constraints?22:22
prometheanfirecomplexity mostly22:22
ianwi think the complexity horse has bolted :)22:23
ianwbasically i guess make the project-config script look like tox_install.sh22:23
prometheanfirewell, I'm trying to not let it get too far :P22:23
prometheanfireI could do that, but don't think it's necessarty22:24
prometheanfireI could do that, but don't think it's necessary22:24
ianwyeah, all this will need to be fiddled for zuulv3 ... but one thing at a time22:29
ianwbut it is why i'd like to use as much generic infrastructure as possible, so that we fit closer to any migration plans everyone else has22:30
prometheanfireya22:30
ianwok, i'm out for a bit ... we're just waiting for the revert/pin to land, then i'll quick approve that and go for 2.9.0 release22:48
ianwthen we can consider all the other testing stuff :)22:48
*** Sukhdev has quit IRC22:57
* prometheanfire is just sitting working on gentoo things23:41
prometheanfirebtw, I'm redoing the gentoo patch, the python update is going to be first things, because some things could be pip installed with a python version that is later removed (aka simple-init/glean)23:42
*** chhavi has joined #openstack-dib23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!