| *** chhavi has joined #openstack-dib | 00:17 | |
| *** Sukhdev_ has quit IRC | 00:46 | |
| *** chhavi has quit IRC | 02:01 | |
| *** Sukhdev has joined #openstack-dib | 03:38 | |
| *** aparnav has joined #openstack-dib | 04:00 | |
| *** chhavi has joined #openstack-dib | 04:15 | |
| *** strigazi_ has joined #openstack-dib | 04:51 | |
| *** Sukhdev has quit IRC | 04:53 | |
| *** strigazi has quit IRC | 04:54 | |
| *** strigazi has joined #openstack-dib | 04:56 | |
| *** strigazi_ has quit IRC | 04:58 | |
| *** jamielennox is now known as jamielennox|away | 05:10 | |
| *** strigazi_ has joined #openstack-dib | 05:25 | |
| *** strigazi has quit IRC | 05:27 | |
| *** jamielennox|away is now known as jamielennox | 05:30 | |
| *** strigazi has joined #openstack-dib | 05:30 | |
| *** strigazi_ has quit IRC | 05:32 | |
| ianw | yolanda: yeah, we might need to do some archaeology to decide if we need to even do that unmount there at all? | 05:35 |
|---|---|---|
| ianw | shouldn't this just be under the control of dib? | 05:36 |
| ianw | dib-block-device? | 05:36 |
| yolanda | you mean we shall drop the calls to unmount_dir ? i really don't know about the internals of it | 05:46 |
| yolanda | it's even called 2 times, one for tmp and one for mnt. I think that the one on /tmp is the one that is called where the mountpoints are not even available, so it's unmounting everything | 05:47 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Apply setfiles on all mountpoints https://review.openstack.org/447076 | 05:51 |
| ianw | yolanda: yeah, i think the problem is nobody really knows the internals of it? | 06:00 |
| ianw | that's why i mean, we might have to reverse engineer this to convince ourselves of the best approach | 06:01 |
| yolanda | my concern about dropping the umount_dir, is that we still have the use case of flat images, where block device is not involved | 06:19 |
| andreas-f | yolanda, ianw: we cannot drop the unmount_dir: there are some mount points that need cleanup: sysfs, proc, dev, ... | 06:23 |
| andreas-f | ... but the unmount_dir could exactly unmount those. | 06:25 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Only unmount directories that are mounted https://review.openstack.org/464235 | 06:29 |
| yolanda | i tried to use the DIB_MOUNTPOINTS var to don't unmount those directories, because they will be handled by block-device. But even with that i'm getting failures, i think that the problem is that unmount is called twice | 06:31 |
| *** isaacb has joined #openstack-dib | 06:40 | |
| *** isaacb has quit IRC | 06:41 | |
| *** isaacb has joined #openstack-dib | 06:41 | |
| yolanda | i found a problem with my algorithm to detect mountpoints, i'm retrying | 06:59 |
| *** isaacb_ has joined #openstack-dib | 07:00 | |
| *** isaacb has quit IRC | 07:00 | |
| yolanda | ianw, https://review.openstack.org/447076 ... addressed your comments | 07:01 |
| *** andreas-f has quit IRC | 07:02 | |
| *** jamielennox is now known as jamielennox|away | 07:07 | |
| *** andreas-f has joined #openstack-dib | 07:14 | |
| *** jamielennox|away is now known as jamielennox | 07:34 | |
| *** pmannidi has quit IRC | 08:00 | |
| openstackgerrit | Merged openstack/diskimage-builder master: Apply setfiles on all mountpoints https://review.openstack.org/447076 | 08:10 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Only unmount directories that are mounted https://review.openstack.org/464235 | 08:52 |
| *** isaacb_ has quit IRC | 08:59 | |
| *** isaacb has joined #openstack-dib | 09:06 | |
| *** isaacb has quit IRC | 09:09 | |
| *** makowals_ has joined #openstack-dib | 09:45 | |
| *** makowals has quit IRC | 09:46 | |
| yolanda | ianw, andreas-f , that one worked for me ^ | 09:51 |
| *** yolanda has quit IRC | 11:27 | |
| *** isaacb has joined #openstack-dib | 11:43 | |
| *** yolanda has joined #openstack-dib | 11:59 | |
| *** aparna has joined #openstack-dib | 13:13 | |
| *** aparnav has quit IRC | 13:16 | |
| *** aparna has quit IRC | 13:18 | |
| *** dmarlin has joined #openstack-dib | 15:12 | |
| *** isaacb has quit IRC | 15:57 | |
| *** cmurphy has quit IRC | 16:14 | |
| *** isaacb has joined #openstack-dib | 16:19 | |
| *** isaacb has quit IRC | 17:11 | |
| *** chhavi has quit IRC | 17:34 | |
| *** chhavi has joined #openstack-dib | 17:52 | |
| *** openstackgerrit has quit IRC | 18:17 | |
| *** chhavi has quit IRC | 18:29 | |
| *** Sukhdev has joined #openstack-dib | 18:29 | |
| *** Sukhdev has quit IRC | 19:22 | |
| *** Sukhdev has joined #openstack-dib | 20:36 | |
| *** Sukhdev has quit IRC | 20:37 | |
| *** Sukhdev has joined #openstack-dib | 20:38 | |
| *** makowals_ has quit IRC | 21:48 | |
| *** Sukhdev has quit IRC | 22:11 | |
| *** Sukhdev has joined #openstack-dib | 22:45 | |
| *** dmarlin has quit IRC | 23:07 | |
| *** pmannidi has joined #openstack-dib | 23:10 | |
| *** Sukhdev has quit IRC | 23:40 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!