| *** brault has joined #openstack-dib | 01:17 | |
| *** brault has quit IRC | 01:21 | |
| *** zhugaoxiao has quit IRC | 02:23 | |
| *** Administrator_ has quit IRC | 02:23 | |
| *** zhugaoxiao has joined #openstack-dib | 02:24 | |
| *** brault has joined #openstack-dib | 03:18 | |
| *** brault has quit IRC | 03:22 | |
| *** pmannidi has joined #openstack-dib | 03:27 | |
| *** pmannidi has quit IRC | 03:34 | |
| *** brault has joined #openstack-dib | 05:19 | |
| *** brault has quit IRC | 05:23 | |
| yolanda | hi andreas-f , around? i had a conversation yesterday with ianw, as it's a feature that is really needed for pike, we could land the patches, after testng our use cases and check that they work, and refactor it later | 07:10 |
|---|---|---|
| yolanda | i was just going to test again the block device config changes, before approving it, but found your -W. Do you think we can merge as it is, if that works fine, and then go with refactors? | 07:11 |
| andreas-f | yolanda: Ian's comments are really valuable - and we should go for them first. | 07:14 |
| andreas-f | I really don't want to merge things with these 'code smells'. | 07:14 |
| yolanda | my concern is that we hit the risk of really loosing pike deadline, and I depend on a feature about security for it | 07:16 |
| yolanda | so how can i help to achieve that, is that possible? | 07:16 |
| yolanda | if we continue with the slow cadence of review/refactor we are really going to loose it | 07:16 |
| yolanda | i would not say that "code smells", but i agree that is very dense :) | 07:17 |
| *** brault has joined #openstack-dib | 07:20 | |
| *** brault has quit IRC | 07:24 | |
| andreas-f | Yolanda: for me it looks that we have different goals here. My idea is, to have clean code that is maintainable and can be understood; the time line does not matter (I'm currently doing this in my spare time for fun). | 07:38 |
| andreas-f | On the other side it looks that you (RedHat?) have some goals that require my patches... | 07:38 |
| andreas-f | I have no idea how to solve this. | 07:38 |
| prometheanfire | ianw: if you still want it I can submit a review with the fix | 07:47 |
| yolanda | andreas-f, in my case the timeline is very important, we have been chasing that for several cycles and pike was an important milestone | 07:54 |
| yolanda | i know that you do it on your spare time, that's why i offer my help in anything | 07:54 |
| yolanda | if you prefer that i take the split/refactor i am happy to do it, but i dont' want to mess with your job if you are not confortable with it | 07:55 |
| yolanda | this piece of code in diskimage-builder is an important base for security job going on on RHEL | 07:56 |
| *** openstackgerrit has joined #openstack-dib | 07:56 | |
| openstackgerrit | Andreas Florath proposed openstack/diskimage-builder master: Refactor block_device: passing command line parameters https://review.openstack.org/459043 | 07:56 |
| andreas-f | Yolanda: you can review - this would help ;-) | 07:57 |
| yolanda | andreas-f, i do reviews, but it is long to get this review read/amended | 07:59 |
| yolanda | weeks pass and the deadline is soon, and i'd really like to unlock taht | 07:59 |
| yolanda | as i know you can only work on weekends, having to wait for a week to get a review amended, it's not working | 08:00 |
| andreas-f | Yolanda: I was speaking about the fresh patch - which should be half the way to I3600c6a3d663c697b59d91bd3fbb5e408af345e4 | 08:00 |
| yolanda | looking at it | 08:01 |
| yolanda | i was speaking more generally | 08:01 |
| yolanda | ok reviewed this bit | 08:09 |
| *** brault has joined #openstack-dib | 09:21 | |
| *** brault has quit IRC | 09:25 | |
| *** brault has joined #openstack-dib | 11:21 | |
| *** brault has quit IRC | 11:26 | |
| *** brault has joined #openstack-dib | 13:22 | |
| *** brault has quit IRC | 13:26 | |
| *** brault has joined #openstack-dib | 15:23 | |
| *** brault has quit IRC | 15:27 | |
| openstackgerrit | Paul Belanger proposed openstack/diskimage-builder master: Split debootstrap into debootstrap-minimal https://review.openstack.org/413103 | 16:24 |
| *** brault_ has joined #openstack-dib | 16:48 | |
| *** zhugaoxiao has quit IRC | 17:06 | |
| *** zhugaoxiao has joined #openstack-dib | 17:06 | |
| *** zhugaoxiao has quit IRC | 17:07 | |
| *** zhugaoxiao has joined #openstack-dib | 17:07 | |
| *** Sukhdev has joined #openstack-dib | 17:41 | |
| *** zhugaoxiao has quit IRC | 18:02 | |
| *** zhugaoxiao has joined #openstack-dib | 18:03 | |
| *** Administrator_ has joined #openstack-dib | 18:12 | |
| *** zhugaoxiao has quit IRC | 18:15 | |
| *** Sukhdev has quit IRC | 18:27 | |
| *** hashar has joined #openstack-dib | 20:02 | |
| *** hashar has quit IRC | 22:47 | |
| *** Administrator_ has quit IRC | 23:12 | |
| *** Administrator_ has joined #openstack-dib | 23:12 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!