| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Run dib-run-parts out of /tmp https://review.openstack.org/446769 | 01:23 |
|---|---|---|
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Don't provide dib-run-parts https://review.openstack.org/446285 | 01:23 |
| ianw | greghaynes: ^ i will respond in the thread, but i think those two combined are the solution here | 01:23 |
| ianw | i do wish i'd thought of this pre-v2, but that's life | 01:24 |
| greghaynes | ianw: the comment about why not use the normal run-parts is interesting | 01:48 |
| greghaynes | No idea if that's in the rh distros now... | 01:48 |
| *** jamielennox is now known as jamielennox|away | 01:56 | |
| *** jamielennox|away is now known as jamielennox | 02:01 | |
| ianw | greghaynes: yeah, maybe not | 03:11 |
| *** zhugaoxiao has quit IRC | 03:29 | |
| *** zhugaoxiao has joined #openstack-dib | 03:30 | |
| *** owalsh_ has joined #openstack-dib | 04:20 | |
| *** owalsh has quit IRC | 04:23 | |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Run dib-run-parts out of /tmp https://review.openstack.org/446769 | 06:19 |
| *** yolanda has joined #openstack-dib | 06:45 | |
| openstackgerrit | Andreas Florath proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 07:25 |
| *** pmannidi has quit IRC | 08:04 | |
| *** hashar has joined #openstack-dib | 08:17 | |
| *** jesusaur has quit IRC | 09:13 | |
| *** jesusaur has joined #openstack-dib | 09:15 | |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: WIP: Add lvm management to diskimage-builder https://review.openstack.org/444403 | 10:26 |
| *** zhugaoxiao has quit IRC | 12:13 | |
| *** zhugaoxiao has joined #openstack-dib | 12:14 | |
| *** mat128 has quit IRC | 13:14 | |
| *** zhugaoxiao has quit IRC | 13:36 | |
| *** zhugaoxiao has joined #openstack-dib | 13:37 | |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: WIP: Add lvm management to diskimage-builder https://review.openstack.org/444403 | 13:44 |
| yolanda | hi, ianw , greghaynes ... in order for lvm to work in dib, it needed a dracut regeneration. I have an element that does it on tripleo: http://git.openstack.org/cgit/openstack/tripleo-image-elements/tree/elements/overcloud-dracut | 13:59 |
| yolanda | however i think that this will be needed on dib. What do you think about it? shall i just include literally as it is now, or can you figure a better way to regenerate dracut? | 13:59 |
| *** brault_ is now known as brault|away | 14:09 | |
| *** brault|away is now known as brault | 14:16 | |
| greghaynes | yolanda: yea, we have a dracut-ramdisk element already, not sure how similar it is | 14:45 |
| greghaynes | it shouldnt be named with 'overcloud' though | 14:45 |
| yolanda | ah greghaynes , but it's not the same, i already looked at it | 14:47 |
| yolanda | your dracut-ramdisk is to generate initrd images | 14:47 |
| greghaynes | yea | 14:47 |
| yolanda | in my case, i need to regenerate dracut on the whole disk iamge | 14:47 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: WIP: Add lvm management to diskimage-builder https://review.openstack.org/444403 | 14:47 |
| greghaynes | if its sufficiently different probably ok to make a new one | 14:47 |
| yolanda | yes, the scope is different | 14:50 |
| yolanda | so i'll propose something around these lines, overcloud not calling it "overcloud" :) | 14:51 |
| greghaynes | ok | 14:51 |
| yolanda | in my case, i added lvm and crypt modules by default, because i needed it for handling the volumes and encryption. Do you think it makes sense to carry the same? will you add some other modules? it can be parameterized, but the defaults where "lvm crypt" | 14:53 |
| greghaynes | its probably useful to make there bee some env var or way to configure what modules | 14:53 |
| yolanda | yes, there is an env var to parameterize it. The most conflicting thing, is that , for example, to enable lvm you need to install lvm2 package. Same for crypt | 14:54 |
| yolanda | so the module enablement is tied to the packages installed | 14:54 |
| greghaynes | hrm | 14:54 |
| yolanda | see that overcloud element, it has lvm and crypt on the package-installs.yaml, because it adds lvm and crypt modules | 14:55 |
| greghaynes | I think that will just have to go in code | 14:56 |
| greghaynes | if lvm in $env_var package-install -m lvm lvm2 | 14:56 |
| yolanda | so not in the element? | 14:57 |
| greghaynes | in dracut, yes | 14:57 |
| greghaynes | but itll have to be in a install.d script, not package installs | 14:57 |
| yolanda | so you mean, adding some associations between modules and packages? what about if people want to add their own ones? | 14:57 |
| greghaynes | yolanda: yes, people will have to install the dependencies on their own | 14:58 |
| greghaynes | youll just need to support in dracut whatever it sets by default | 14:58 |
| greghaynes | alternatively | 14:59 |
| greghaynes | you could make dracut and then dracut-lvm which adds lvm to the env var and has the dependency in package-installs.yaml | 14:59 |
| yolanda | but if we need to combine several? dracut-lvm, dracut-crypt, and go appending modules in the dracut env var? | 14:59 |
| greghaynes | yep, DIB_DRACUT_MODULES="$DIB_DRACUT_MODULES lvm" in dracut-lvm/environment.d/whatever | 15:00 |
| yolanda | makes sense | 15:01 |
| yolanda | i think i prefer that approach, looks cleaner and some downstream consumer could create their own modules | 15:03 |
| greghaynes | SGTM | 15:03 |
| yolanda | cool, i'll send that | 15:05 |
| yolanda | greghaynes, more things... do you know about rpm-distro element and autorelabel? seems it didn't run autorelabel for me, falling into the other condition here http://git.openstack.org/cgit/openstack/diskimage-builder/tree/diskimage_builder/elements/rpm-distro/finalise.d/90-selinux-fixfiles-restore | 15:17 |
| yolanda | and i had to run autorelabel on my own because there were failures | 15:18 |
| greghaynes | I dont really know anything about those, no | 15:18 |
| yolanda | ok i'll check with ianw or pabelanger then | 15:19 |
| yolanda | greghaynes, i have the fear that is only applying the setfiles on the root volume/partition, and in my case, i have different mounts for var, var/log, tmp... that will cause that selinux errors | 15:28 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Fix setfiles command https://review.openstack.org/447033 | 15:30 |
| *** IRC-Source_47177 has joined #openstack-dib | 15:57 | |
| *** IRC-Source_47177 has quit IRC | 16:02 | |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: WIP: Add dracut-regenerate elements https://review.openstack.org/447047 | 16:04 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: WIP: Add lvm management to diskimage-builder https://review.openstack.org/444403 | 16:06 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Add dracut-regenerate elements https://review.openstack.org/447047 | 17:09 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: WIP: Add lvm management to diskimage-builder https://review.openstack.org/444403 | 17:20 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Always execute autorelabel https://review.openstack.org/447076 | 17:23 |
| *** hashar has quit IRC | 17:46 | |
| openstackgerrit | Andreas Florath proposed openstack/diskimage-builder master: Use stevedore for module config of block device https://review.openstack.org/447090 | 18:16 |
| openstackgerrit | Andreas Florath proposed openstack/diskimage-builder master: Use stevedore for module config of block device https://review.openstack.org/447090 | 18:59 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Always execute autorelabel https://review.openstack.org/447076 | 19:46 |
| *** andreas-f has joined #openstack-dib | 19:57 | |
| openstackgerrit | Corey O'Brien proposed openstack/diskimage-builder master: Don't unmount missing paths If the path is missing, unmount_dir fails and skips the EXTRA_DETACH and EXTRA_UNMOUNT steps https://review.openstack.org/446621 | 20:16 |
| openstackgerrit | Andreas Florath proposed openstack/diskimage-builder master: Use stevedore for module config of block device https://review.openstack.org/447090 | 20:25 |
| *** yolanda has quit IRC | 20:26 | |
| *** yolanda has joined #openstack-dib | 20:26 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!