| hgy | Hello, Who know how to get a unit test for a patch, or in which document I can learn about it? | 07:13 |
|---|---|---|
| frickler | hgy: I've found it most useful to look at existing tests, then look up some of the used functions in the python documentation if needed | 07:18 |
| frickler | hgy: do you have a specific patch you want to do a unit test for? | 07:18 |
| hgy | frickler: Yes, I added a new exception process, and got a comment which told me I need a unit test for converage | 07:21 |
| hgy | frickler: I just a newer, sorry | 07:21 |
| hgy | frickler: It's mean that I need to add a unit test for zuul? | 07:22 |
| frickler | hgy: can you share the link to your patch? makes it easier when we can see the context | 07:22 |
| hgy | frickler: of course: https://review.opendev.org/c/openstack/glance/+/819399 | 07:23 |
| frickler | hgy: so the unit tests for the file you are modifying are in https://opendev.org/openstack/glance/src/branch/master/glance/tests/unit/common/test_wsgi.py , you can try to find a similar test that you could copy and modify there | 07:27 |
| frickler | hgy: otherwise maybe ask for help in the #openstack-glance channel. or, if you think that this is all too much for you, don't be afraid to state so in the review and ask someone else to pick up the issue | 07:28 |
| hgy | frickler: Oh, Thank you very much. | 07:28 |
| hgy | frickler: Ok, I will try it first. And if I can't finish it, I will ask else to pick up it | 07:29 |
| hgy | frickler: love you | 07:29 |
| frickler | hgy: there's also a bit of documentation here https://governance.openstack.org/tc/reference/pti/python.html | 07:30 |
| hgy | frickler: oh, Ok, really appreciate you | 07:32 |
| *** jpena|off is now known as jpena | 09:27 | |
| opendevreview | Aurelien Lourot proposed openstack/governance master: Add NVidia vGPU plugin charm to OpenStack charms https://review.opendev.org/c/openstack/governance/+/819856 | 13:17 |
| *** sshnaidm|afk is now known as sshnaidm | 13:29 | |
| *** whoami-rajat__ is now known as whoami-rajat | 16:20 | |
| *** xek_ is now known as xek | 16:48 | |
| *** jpena is now known as jpena|off | 17:35 | |
| opendevreview | Merged openstack/governance master: Rework the yoga secure RBAC community goal https://review.opendev.org/c/openstack/governance/+/815158 | 18:18 |
| Alt-Shivank | Hey everone, | 18:27 |
| Alt-Shivank | I want to deploy openstack on my local machine, component by component, Is there any detailed documentation for the same. | 18:29 |
| frickler | Alt-Shivank: https://docs.openstack.org/install-guide/ | 19:08 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!