Friday, 2018-10-19

*** dr_feelgood has joined #openstack-dev00:05
*** bcafarel has quit IRC00:09
*** READ10 has joined #openstack-dev00:19
*** jamesmcarthur has quit IRC00:42
*** dr_feelgood has quit IRC00:57
*** dr_feelgood has joined #openstack-dev00:58
*** markvoelker has joined #openstack-dev00:58
*** dr_feelgood has quit IRC01:02
*** jamesmcarthur has joined #openstack-dev01:03
*** dr_feelgood has joined #openstack-dev01:08
*** dr_feelgood has quit IRC01:10
*** dr_feelgood has joined #openstack-dev01:11
*** jamesmcarthur has quit IRC01:12
*** jamesmcarthur has joined #openstack-dev01:13
*** jamesmcarthur has quit IRC01:13
*** dr_feelgood has quit IRC01:14
*** beekneemech has joined #openstack-dev01:17
*** caboucha has quit IRC01:19
*** bnemec has quit IRC01:19
*** dr_feelgood has joined #openstack-dev01:27
*** markvoelker has quit IRC01:32
*** dr_feelgood has quit IRC01:36
*** dr_feelgood has joined #openstack-dev01:37
*** Dinesh_Bhor has joined #openstack-dev01:44
*** MattMan_ has quit IRC01:46
*** MattMan_ has joined #openstack-dev01:46
*** dklyle has joined #openstack-dev01:50
*** david-lyle has joined #openstack-dev01:53
*** dklyle has quit IRC01:56
*** dklyle has joined #openstack-dev01:56
*** david-lyle has quit IRC01:59
*** jmccrory has joined #openstack-dev02:02
*** bnemec has joined #openstack-dev02:13
*** beekneemech has quit IRC02:15
*** beekneemech_ has joined #openstack-dev02:15
*** bnemec has quit IRC02:18
*** gianpietro has joined #openstack-dev02:19
*** gianpietro has quit IRC02:19
*** gianpietro has joined #openstack-dev02:19
*** dklyle has quit IRC02:20
*** gianpietro has quit IRC02:24
*** bnemec has joined #openstack-dev02:26
*** beekneemech_ has quit IRC02:29
*** kazsh has quit IRC02:30
*** Dinesh_Bhor has quit IRC02:31
*** beekneemech has joined #openstack-dev02:31
*** bnemec has quit IRC02:34
*** kazsh has joined #openstack-dev02:35
*** Dinesh_Bhor has joined #openstack-dev02:35
*** jamesmcarthur has joined #openstack-dev02:38
*** jamesmcarthur has quit IRC02:43
*** bcafarel has joined #openstack-dev02:45
*** bobh has joined #openstack-dev02:45
*** bobh has quit IRC02:46
*** bobh has joined #openstack-dev02:46
*** bnemec has joined #openstack-dev02:48
*** bobh has quit IRC02:51
*** beekneemech has quit IRC02:51
*** dr_feelgood has quit IRC02:52
*** dr_feelgood has joined #openstack-dev02:53
*** gianpietro has joined #openstack-dev02:57
*** gianpietro has quit IRC03:01
*** gianpietro has joined #openstack-dev03:01
*** jamesmcarthur has joined #openstack-dev03:02
*** gianpietro has quit IRC03:06
*** READ10 has quit IRC03:12
*** dr_feelgood has quit IRC03:21
*** dr_feelgood has joined #openstack-dev03:21
*** jamesmcarthur has quit IRC03:24
*** dr_feelgood has quit IRC03:25
*** dr_feelgood has joined #openstack-dev03:25
*** ekcs has joined #openstack-dev03:43
*** jamesmcarthur has joined #openstack-dev03:49
*** dave-mccowan has quit IRC03:53
*** jamesmcarthur has quit IRC04:07
*** Dinesh_Bhor has quit IRC04:08
*** beekneemech has joined #openstack-dev04:10
*** bnemec has quit IRC04:13
*** njohnston has quit IRC04:23
*** njohnston has joined #openstack-dev04:36
*** skazi has quit IRC04:39
*** bnemec has joined #openstack-dev04:45
*** beekneemech has quit IRC04:48
*** bnemec has quit IRC04:51
*** bnemec has joined #openstack-dev04:51
*** nijaba has quit IRC04:56
*** beekneemech has joined #openstack-dev05:03
*** bnemec has quit IRC05:06
*** nijaba has joined #openstack-dev05:09
*** andreaf has quit IRC05:10
*** zaneb has quit IRC05:15
*** andreaf has joined #openstack-dev05:15
*** Dinesh_Bhor has joined #openstack-dev05:17
*** ekcs has quit IRC05:18
*** zaneb has joined #openstack-dev05:19
*** njohnston has quit IRC05:22
*** dr_feelgood has quit IRC05:33
*** skazi has joined #openstack-dev05:38
*** njohnston has joined #openstack-dev05:39
*** njohnston has quit IRC05:44
*** Luzi has joined #openstack-dev05:45
*** njohnston has joined #openstack-dev05:52
*** dr_feelgood has joined #openstack-dev05:53
*** dr_feelgood has joined #openstack-dev05:53
*** donghm has quit IRC05:56
*** donghm has joined #openstack-dev05:56
*** jtomasek has quit IRC05:58
*** jtomasek has joined #openstack-dev06:04
*** njohnston has quit IRC06:05
*** pcaruana has joined #openstack-dev06:14
*** renxiaof has joined #openstack-dev06:21
*** njohnston has joined #openstack-dev06:22
*** tsmith_ has joined #openstack-dev06:24
*** tsmith2 has quit IRC06:27
*** tsmith_ is now known as tsmith206:27
*** tsmith_ has joined #openstack-dev06:32
*** tsmith2 has quit IRC06:34
*** tsmith_ is now known as tsmith206:34
*** Dinesh_Bhor has quit IRC06:36
*** njohnston has quit IRC06:37
*** tsmith_ has joined #openstack-dev06:37
*** e0ne has joined #openstack-dev06:37
*** tsmith__ has joined #openstack-dev06:39
*** tsmith2 has quit IRC06:40
*** tsmith__ is now known as tsmith206:40
*** tsmith_ has quit IRC06:41
*** gfidente has joined #openstack-dev06:45
*** celebdor has joined #openstack-dev07:07
*** pcaruana has quit IRC07:09
*** shardy has joined #openstack-dev07:10
*** rcernin has quit IRC07:17
*** rebtoor has quit IRC07:19
*** rebtoor has joined #openstack-dev07:19
*** dr_feelgood has quit IRC07:24
*** dr_feelgood has joined #openstack-dev07:25
*** Dinesh_Bhor has joined #openstack-dev07:26
*** dr_feelg_ has joined #openstack-dev07:27
*** dr_feelgood has quit IRC07:27
*** pcaruana has joined #openstack-dev07:28
*** dr_feelg_ has quit IRC07:28
*** dr_feelgood has joined #openstack-dev07:29
*** pcaruana is now known as pcaruana|elisa|07:30
*** renxiaof has quit IRC07:31
*** slaweq has quit IRC07:32
*** slaweq has joined #openstack-dev07:33
*** dr_feelgood has quit IRC07:34
*** tosky has joined #openstack-dev07:36
*** leni1 has joined #openstack-dev07:45
*** leni1 has quit IRC07:47
*** jbadiapa has quit IRC07:53
*** electrofelix has joined #openstack-dev07:56
*** Dinesh_Bhor has quit IRC08:02
*** e0ne has quit IRC08:03
*** jbadiapa has joined #openstack-dev08:08
*** rebtoor has quit IRC08:13
*** rebtoor has joined #openstack-dev08:13
*** jbadiapa has quit IRC08:18
*** jbadiapa has joined #openstack-dev08:36
*** nplanel_ has joined #openstack-dev08:38
*** nplanel__ has joined #openstack-dev08:40
*** vabada has quit IRC08:42
*** vabada has joined #openstack-dev08:43
*** salmankhan has joined #openstack-dev08:51
*** Dinesh_Bhor has joined #openstack-dev09:06
*** gfidente is now known as gfidente|giulivo09:07
*** eponymos has joined #openstack-dev09:09
*** e0ne has joined #openstack-dev09:09
*** eponymos has quit IRC09:12
*** ttsiouts has joined #openstack-dev09:12
*** zigo has joined #openstack-dev09:13
*** brokencycle has joined #openstack-dev09:46
openstackgerritTony Breeds proposed openstack/governance master: T Release Name  https://review.openstack.org/61151109:47
openstackgerritTony Breeds proposed openstack/governance master: T Release Name  https://review.openstack.org/61151109:59
*** Dinesh_Bhor has quit IRC10:22
*** morazi has quit IRC10:23
*** donghm has quit IRC10:28
*** cdent has joined #openstack-dev10:35
*** dtantsur|afk is now known as dtantsur10:43
*** gianpietro has joined #openstack-dev10:47
*** dave-mccowan has joined #openstack-dev10:54
*** e0ne has quit IRC11:01
*** alysonr_ has joined #openstack-dev11:27
*** nijaba has quit IRC11:34
*** njohnston has joined #openstack-dev11:34
*** nijaba has joined #openstack-dev11:38
*** nijaba has quit IRC11:40
*** nijaba has joined #openstack-dev11:43
*** brokencycle has quit IRC11:43
*** morazi has joined #openstack-dev11:48
*** e0ne has joined #openstack-dev11:52
*** tpsilva has joined #openstack-dev11:53
*** panda is now known as panda|lunch11:53
*** EmilienM is now known as EvilienM11:58
*** brokencycle has joined #openstack-dev12:00
*** sshnaidm is now known as sshnaidm|off12:06
*** gfidente|giulivo has quit IRC12:11
*** gianpietro has quit IRC12:11
*** gianpietro has joined #openstack-dev12:12
*** gianpietro has quit IRC12:17
*** mriedem has joined #openstack-dev12:19
*** cdent has quit IRC12:24
*** leni1 has joined #openstack-dev12:28
*** eharney has joined #openstack-dev12:33
*** leni1 has quit IRC12:33
*** priteau has joined #openstack-dev12:34
*** nijaba has quit IRC12:36
*** raildo has joined #openstack-dev12:39
*** nijaba has joined #openstack-dev12:40
*** nijaba has quit IRC12:42
*** dansmith is now known as SteelyDan12:45
*** jamesmcarthur has joined #openstack-dev12:48
*** kgiusti has joined #openstack-dev12:48
*** nijaba has joined #openstack-dev12:50
*** alysonr_ has quit IRC12:51
*** gkadam has joined #openstack-dev12:52
*** nijaba has quit IRC12:53
*** skazi has quit IRC12:54
*** slaweq has quit IRC12:57
*** nijaba has joined #openstack-dev12:58
*** slaweq has joined #openstack-dev13:07
*** riya_17 has joined #openstack-dev13:12
*** jamesmcarthur has quit IRC13:14
*** jamesmcarthur has joined #openstack-dev13:14
*** jamesmcarthur has quit IRC13:17
*** lbragstad is now known as elbragstad13:23
*** slaweq has quit IRC13:27
*** gianpietro has joined #openstack-dev13:28
*** jamesmcarthur has joined #openstack-dev13:39
*** jamesmcarthur has quit IRC13:40
*** jamesmcarthur has joined #openstack-dev13:40
brokencycleHi! How can I preserve the attribution on review.openstack.org when merging two review requests?13:41
*** awaugama has joined #openstack-dev13:43
cmurphybrokencycle: you can add a Co-Authored-By: footer in the commit message to add the second author13:43
*** slaweq has joined #openstack-dev13:49
*** munimeha1 has joined #openstack-dev13:53
*** rpittau has quit IRC13:56
*** sidx64 has joined #openstack-dev14:04
*** mriedem has quit IRC14:06
*** Luzi has quit IRC14:07
*** mriedem has joined #openstack-dev14:09
*** hongbin has joined #openstack-dev14:12
toskymriedem: hi, question about https://review.openstack.org/#/c/611810/ and in general about the goal14:15
toskyfor future changes, is there some plan or guideline on how to implement the functional tests for those new commands? Or "just" unit tests?14:16
mriedemtosky: because of how much the nova checks rely on the database, our tests, while called unit, are really more functional because they setup the database(s) and populate them appropriately for each test scenario14:20
mriedemi really rely on running against real data in a database (even just sqlite) because of the sqla orm involved in the checks14:20
mriedemthere are some other checks that we have to mock out calls to external services like keystone to see if placement is available14:21
mriedeme.g. https://github.com/openstack/nova/blob/master/nova/tests/unit/cmd/test_status.py#L20814:21
mriedemthis is a good example of a cells v2 test that sets up the db https://github.com/openstack/nova/blob/master/nova/tests/unit/cmd/test_status.py#L35714:22
mriedemsince i don't know how all projects do their testing, i can't really say there is a guideline14:22
toskyI see, thanks14:22
mriedembut the more functionally you can test anything related to the db the better14:22
mriedembecause if your mock is wrong, then it's a false positive14:23
toskyright14:23
toskyI suppose that, if I we manage to work on specific tests, we may end up with devstack-based tests14:24
toskydevstack-based jobs*14:24
mriedemdepends on the check14:26
*** efried is now known as efried_pto14:26
mriedemthe nova upgrade checks are run through grenade14:26
mriedemi expect all projects to eventually do the same in their upgrade jobs14:26
toskyoh, right14:28
*** mlavalle has joined #openstack-dev14:29
toskybut the question is more about testing the checks, not using the checks, but I guess that the two things may be combined in the grenade job14:29
*** jistr is now known as jistr|call14:29
mriedemsure i mean you'll need tests either way because there will be scenarios that the grenade job just won't hit14:32
mriedemespecially testing failure scenarios that will make the check fail - that would make the grenade job fail and then you could never merge it :)14:33
*** nijaba has quit IRC14:34
*** bobh has joined #openstack-dev14:38
*** nijaba has joined #openstack-dev14:38
*** nijaba has quit IRC14:38
*** slaweq has quit IRC14:40
*** nijaba has joined #openstack-dev14:44
*** sidx64 has quit IRC14:46
*** jistr|call is now known as jistr14:47
*** panda|lunch is now known as panda14:49
*** ttsiouts has quit IRC14:50
*** e0ne has quit IRC14:52
*** armstrong has joined #openstack-dev14:53
openstackgerritPete Birley proposed openstack/governance master: New Repo - OpenStack-Helm Images  https://review.openstack.org/61189514:55
openstackgerritPete Birley proposed openstack/governance master: New Repo: OpenStack-Helm Docs  https://review.openstack.org/61189614:55
*** pcaruana|elisa| has quit IRC14:56
*** pcaruana|elisa| has joined #openstack-dev14:57
*** gfidente has joined #openstack-dev15:01
*** ttsiouts has joined #openstack-dev15:01
*** pcaruana|elisa| has quit IRC15:08
*** pcaruana has joined #openstack-dev15:08
*** ttsiouts has quit IRC15:12
mtreinishcdent: that sort of approach has been discussed before. But from the devstack side we've said that there isn't any convincing reason to treat it differently15:13
mtreinishespecially because upload and all the other basic operations work under uwsgi. The only things that don't are async task apis that leverage taskflow (because of a bug in the taskflow usage for those apis outside of eventlet)15:14
mtreinishI started fixes for those, since it shouldn't be too hard. But I don't have the bandwidth or the desire to help on that anymore15:15
*** gianpietro has quit IRC15:17
*** nplanel_ has quit IRC15:17
*** gkadam has quit IRC15:18
*** mtreinish has quit IRC15:22
*** nplanel__ has quit IRC15:23
*** electrofelix has quit IRC15:25
*** mriedem is now known as mriedem_afk15:27
*** pcaruana has quit IRC15:31
*** ttsiouts has joined #openstack-dev15:37
*** mtreinish has joined #openstack-dev15:39
*** riya_17 has quit IRC15:44
*** ikhan has joined #openstack-dev15:45
*** vnogin has joined #openstack-dev15:50
*** vnogin has quit IRC15:50
*** gianpietro has joined #openstack-dev15:54
*** bobh has quit IRC16:03
*** beekneemech has quit IRC16:08
*** bnemec has joined #openstack-dev16:08
*** gfidente is now known as gfidente|afk16:19
*** openstackgerrit has quit IRC16:24
*** nflondo has joined #openstack-dev16:26
*** gianpietro has quit IRC16:28
*** ttsiouts has quit IRC16:30
*** shardy has quit IRC16:30
*** bobh has joined #openstack-dev16:35
*** e0ne has joined #openstack-dev16:35
*** nflondo has joined #openstack-dev16:36
*** e0ne has quit IRC16:37
*** mpeters has joined #openstack-dev16:39
*** bnemec is now known as beekneemech16:43
*** dtantsur is now known as dtantsur|afk16:44
*** nijaba has quit IRC16:53
*** gianpietro has joined #openstack-dev17:00
*** homegrown_ has quit IRC17:02
*** nijaba has joined #openstack-dev17:07
*** gyee has joined #openstack-dev17:12
*** tosky has quit IRC17:18
*** jamesmcarthur has quit IRC17:19
*** cdent has joined #openstack-dev17:20
*** morazi has quit IRC17:21
*** jamesmcarthur has joined #openstack-dev17:26
*** gianpietro has quit IRC17:27
*** skazi has joined #openstack-dev17:33
*** bobh has quit IRC17:34
*** nijaba has quit IRC17:35
*** morazi has joined #openstack-dev17:37
*** nijaba has joined #openstack-dev17:39
*** morazi has quit IRC17:42
*** morazi has joined #openstack-dev17:43
*** openstackgerrit has joined #openstack-dev17:49
openstackgerritMerged openstack/governance master: Add os_manila role to openstack-ansible  https://review.openstack.org/60840317:49
*** ekcs has joined #openstack-dev17:53
*** e0ne has joined #openstack-dev17:53
*** dr_feelgood has joined #openstack-dev17:55
*** e0ne has quit IRC18:00
*** dr_feelgood has quit IRC18:00
*** dr_feelgood has joined #openstack-dev18:01
*** medberry has joined #openstack-dev18:07
*** dr_feelgood has quit IRC18:08
*** e0ne has joined #openstack-dev18:08
*** dr_feelgood has joined #openstack-dev18:08
*** gianpietro has joined #openstack-dev18:09
*** AJaeger_ has joined #openstack-dev18:11
*** dr_feelgood has quit IRC18:13
*** salmankhan has quit IRC18:13
*** medberry has quit IRC18:14
*** AJaeger has quit IRC18:14
*** morazi has quit IRC18:15
*** AJaeger has joined #openstack-dev18:26
*** bobh has joined #openstack-dev18:26
*** AJaeger_ has quit IRC18:28
*** jamesmcarthur has quit IRC18:34
*** gianpietro has quit IRC18:39
*** mriedem_afk is now known as mriedem18:41
*** AJaeger_ has joined #openstack-dev18:47
*** AJaeger has quit IRC18:49
*** AJaeger_ is now known as AJaeger18:53
*** gfidente|afk has quit IRC18:55
*** gianpietro has joined #openstack-dev19:10
*** armstrong has quit IRC19:12
*** gianpietro has quit IRC19:15
*** bobh has quit IRC19:18
*** bobh has joined #openstack-dev19:19
*** bobh has quit IRC19:23
*** bobh has joined #openstack-dev19:23
*** gianpietro has joined #openstack-dev19:33
*** e0ne has quit IRC19:34
*** e0ne has joined #openstack-dev19:34
*** sshnaidm|off has quit IRC19:34
*** e0ne has quit IRC19:36
brokencyclecmurphy: thanks!19:38
*** gianpietro has quit IRC19:39
*** mpeters has quit IRC19:46
*** sshnaidm|off has joined #openstack-dev19:50
brokencyclequit19:53
*** brokencycle has quit IRC19:53
*** dave-mccowan has quit IRC19:57
*** awaugama is now known as awaugama_away20:02
*** sshnaidm|off has quit IRC20:04
*** diablo_rojo has joined #openstack-dev20:06
*** cdent has quit IRC20:12
*** gianpietro has joined #openstack-dev20:13
*** gianpietro has quit IRC20:20
*** kgiusti has left #openstack-dev20:21
*** sshnaidm|off has joined #openstack-dev20:22
*** gianpietro has joined #openstack-dev20:22
*** e0ne has joined #openstack-dev20:28
*** e0ne has quit IRC20:33
*** owalsh has quit IRC20:36
*** dklyle has joined #openstack-dev20:37
*** e0ne has joined #openstack-dev20:44
*** e0ne has quit IRC20:48
*** dklyle has quit IRC20:50
*** munimeha1 has quit IRC20:51
*** vnogin has joined #openstack-dev20:52
*** beekneemech has quit IRC20:53
*** vnogin has quit IRC20:56
*** ikhan has quit IRC20:56
*** bobh has quit IRC21:01
*** bobh has joined #openstack-dev21:01
*** dave-mccowan has joined #openstack-dev21:04
*** bobh has quit IRC21:05
*** owalsh has joined #openstack-dev21:10
*** raildo has quit IRC21:12
*** dave-mccowan has quit IRC21:13
*** celebdor has quit IRC21:20
*** salmankhan has joined #openstack-dev21:20
*** mriedem has quit IRC21:40
*** diablo_rojo has quit IRC21:58
*** gmoro has quit IRC22:02
*** dklyle has joined #openstack-dev22:03
*** priteau has quit IRC22:12
*** tpsilva has quit IRC22:13
*** diablo_rojo has joined #openstack-dev22:20
*** ssbarnea has joined #openstack-dev22:21
*** pbourke has quit IRC22:36
*** pbourke has joined #openstack-dev22:37
*** gianpietro has quit IRC22:51
*** gianpietro has joined #openstack-dev22:51
*** gianpietro has quit IRC22:52
*** gianpietro has joined #openstack-dev22:52
*** gianpietro has quit IRC22:55
*** gianpietro has joined #openstack-dev23:05
*** gianpietro has quit IRC23:09
*** jamesmcarthur has joined #openstack-dev23:10
*** hongbin has quit IRC23:10
*** jamesmcarthur has quit IRC23:15
*** diablo_rojo has quit IRC23:21
*** bnemec has joined #openstack-dev23:25
*** medberry has joined #openstack-dev23:26
*** ssbarnea has quit IRC23:35
*** bobh has joined #openstack-dev23:37
*** gyee has quit IRC23:50
*** bobh has quit IRC23:50
*** dklyle has quit IRC23:52
*** gianpietro has joined #openstack-dev23:55
*** gianpietro has quit IRC23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!