*** diablo_rojo has quit IRC | 00:08 | |
*** diablo_rojo has joined #openstack-dev | 00:19 | |
*** vnogin has quit IRC | 00:39 | |
*** spartakos has quit IRC | 00:40 | |
*** markvoelker has joined #openstack-dev | 00:42 | |
*** jamesmcarthur has joined #openstack-dev | 00:44 | |
*** markvoelker has quit IRC | 00:47 | |
*** jamesmcarthur has quit IRC | 00:54 | |
*** jamesmcarthur has joined #openstack-dev | 00:54 | |
*** jamesmcarthur has quit IRC | 01:01 | |
*** jamesmcarthur has joined #openstack-dev | 01:02 | |
*** iyamahat has quit IRC | 01:22 | |
*** jamesmcarthur has quit IRC | 01:22 | |
*** bobh has joined #openstack-dev | 01:32 | |
*** jamesmcarthur has joined #openstack-dev | 01:34 | |
*** mriedem is now known as mriedem_afk | 01:35 | |
*** markvoelker has joined #openstack-dev | 01:43 | |
*** iyamahat has joined #openstack-dev | 01:43 | |
*** ekcs has quit IRC | 01:49 | |
*** spartakos has joined #openstack-dev | 01:56 | |
*** Dinesh_Bhor has joined #openstack-dev | 01:57 | |
*** gyee has quit IRC | 02:12 | |
*** bobh has quit IRC | 02:15 | |
*** threestrands has joined #openstack-dev | 02:22 | |
*** ijw has joined #openstack-dev | 02:26 | |
*** slic has joined #openstack-dev | 02:30 | |
*** ijw has quit IRC | 02:31 | |
*** jamesmcarthur has quit IRC | 02:32 | |
*** achampion has quit IRC | 02:33 | |
*** qianmingyue has joined #openstack-dev | 02:35 | |
*** lbragstad has quit IRC | 02:39 | |
*** slic has quit IRC | 02:41 | |
*** achampion has joined #openstack-dev | 02:41 | |
*** zbitter has joined #openstack-dev | 02:42 | |
*** zaneb has quit IRC | 02:45 | |
*** rloo has quit IRC | 02:45 | |
*** dave-mccowan has quit IRC | 02:45 | |
*** bgmccollum has quit IRC | 02:45 | |
*** bgmccollum has joined #openstack-dev | 02:45 | |
*** achampion has quit IRC | 02:46 | |
*** dave-mccowan has joined #openstack-dev | 02:48 | |
*** achampion has joined #openstack-dev | 02:48 | |
*** aniketh has joined #openstack-dev | 02:53 | |
*** psachin has joined #openstack-dev | 02:57 | |
*** psachin has quit IRC | 03:04 | |
*** ekcs has joined #openstack-dev | 03:18 | |
*** rloo has joined #openstack-dev | 03:20 | |
*** gkadam has joined #openstack-dev | 03:21 | |
*** rloo has quit IRC | 03:22 | |
*** med_ has quit IRC | 03:26 | |
*** tdasilva has quit IRC | 03:27 | |
*** gnufied has quit IRC | 03:29 | |
*** Dinesh_Bhor has quit IRC | 03:48 | |
*** diablo_rojo has quit IRC | 03:49 | |
*** udesale has joined #openstack-dev | 03:54 | |
*** Dinesh_Bhor has joined #openstack-dev | 03:56 | |
*** spartakos has quit IRC | 03:57 | |
*** Dinesh_Bhor has quit IRC | 04:07 | |
*** gkadam has quit IRC | 04:10 | |
*** gkadam has joined #openstack-dev | 04:10 | |
*** bobh has joined #openstack-dev | 04:12 | |
*** bobh has quit IRC | 04:18 | |
*** mpeterson_ has joined #openstack-dev | 04:29 | |
*** NostawRm has quit IRC | 04:30 | |
*** monty has quit IRC | 04:30 | |
*** monte has joined #openstack-dev | 04:30 | |
*** mpeterson has quit IRC | 04:30 | |
*** Pharaoh_Atem has quit IRC | 04:30 | |
*** edleafe has quit IRC | 04:31 | |
*** bandini has quit IRC | 04:37 | |
*** tonyb has quit IRC | 04:40 | |
*** tonyb has joined #openstack-dev | 04:40 | |
*** Dinesh_Bhor has joined #openstack-dev | 04:41 | |
*** skazi has quit IRC | 04:45 | |
*** dave-mccowan has quit IRC | 04:48 | |
*** jamesmcarthur has joined #openstack-dev | 05:01 | |
*** aniketh has quit IRC | 05:02 | |
*** jamesmcarthur has quit IRC | 05:06 | |
*** markvoelker has quit IRC | 05:13 | |
*** shachar is now known as snapiri | 05:16 | |
*** shabeeb has joined #openstack-dev | 05:19 | |
*** shabeeb has quit IRC | 05:29 | |
*** bandini has joined #openstack-dev | 05:32 | |
*** marst has quit IRC | 05:34 | |
*** shyam89 has joined #openstack-dev | 05:35 | |
*** matthewTheMan_ has joined #openstack-dev | 05:39 | |
matthewTheMan_ | hey guys dose the ocata branch of kolla ansible support having an AD back end for user authentication via the multi domain config ? | 05:41 |
---|---|---|
*** ijw has joined #openstack-dev | 05:42 | |
matthewTheMan_ | i ask cause i have enabled multi domains in the horizon dash board added the following to nano /etc/kolla/keystone/keystone.conf ([identity]domain_specific_drivers_enabled = True domain_config_dir = /etc/keystone/domains) | 05:43 |
matthewTheMan_ | and set the config in the domains folder named keystone.domainname.conf | 05:44 |
matthewTheMan_ | and i still cant seem to get a user list back from AD | 05:44 |
matthewTheMan_ | however if you run and ldap query within the keystone container you get the expected users back | 05:45 |
*** Luzi has joined #openstack-dev | 05:47 | |
*** ijw has quit IRC | 05:47 | |
*** matthewTheMan_ has quit IRC | 05:48 | |
*** shyam89 has quit IRC | 05:51 | |
*** skazi has joined #openstack-dev | 05:56 | |
*** skazi has quit IRC | 05:56 | |
*** shyam89 has joined #openstack-dev | 06:08 | |
*** markvoelker has joined #openstack-dev | 06:10 | |
*** pcaruana has joined #openstack-dev | 06:23 | |
*** Bhujay has joined #openstack-dev | 06:25 | |
*** Bhujay has quit IRC | 06:26 | |
*** Bhujay has joined #openstack-dev | 06:26 | |
*** ijw has joined #openstack-dev | 06:37 | |
*** ijw has quit IRC | 06:42 | |
*** adrianc has joined #openstack-dev | 06:48 | |
*** brokencycle has joined #openstack-dev | 06:52 | |
*** piepmatz has joined #openstack-dev | 06:57 | |
*** ijw has joined #openstack-dev | 07:00 | |
*** rcernin has quit IRC | 07:04 | |
*** ijw has quit IRC | 07:04 | |
openstackgerrit | Thomas Morin proposed openstack/governance master: Add openstack/neutron-interconnection to neutron https://review.openstack.org/599428 | 07:06 |
*** iyamahat has quit IRC | 07:07 | |
*** MattMan_1 has joined #openstack-dev | 07:11 | |
*** MattMan has quit IRC | 07:11 | |
*** shyam89 has quit IRC | 07:13 | |
*** shyam89 has joined #openstack-dev | 07:13 | |
*** adrianc has quit IRC | 07:20 | |
*** sdinescu has quit IRC | 07:21 | |
*** sdinescu has joined #openstack-dev | 07:24 | |
*** shyam89 has quit IRC | 07:39 | |
*** shyam89 has joined #openstack-dev | 07:40 | |
*** adrianc has joined #openstack-dev | 07:40 | |
*** tosky has joined #openstack-dev | 07:40 | |
*** hseipp has joined #openstack-dev | 07:42 | |
*** e0ne has joined #openstack-dev | 07:46 | |
*** shyam89 has quit IRC | 07:53 | |
*** Emine has joined #openstack-dev | 07:58 | |
*** kei-ichi has quit IRC | 08:04 | |
*** kei-ichi has joined #openstack-dev | 08:04 | |
*** corvus has quit IRC | 08:05 | |
*** jpich has joined #openstack-dev | 08:08 | |
*** electrofelix has joined #openstack-dev | 08:13 | |
*** nplanel__ has joined #openstack-dev | 08:22 | |
*** dsneddon has quit IRC | 08:22 | |
*** gkadam_ has joined #openstack-dev | 08:23 | |
*** cdent has joined #openstack-dev | 08:25 | |
*** threestrands has quit IRC | 08:26 | |
*** gkadam has quit IRC | 08:27 | |
*** Bhujay has quit IRC | 08:30 | |
*** ttsiouts has joined #openstack-dev | 08:31 | |
*** dtantsur|afk is now known as dtantsur | 08:35 | |
*** Bhujay has joined #openstack-dev | 08:35 | |
*** sshnaidm|afk is now known as sshnaidm | 08:36 | |
*** ccamposr has joined #openstack-dev | 08:36 | |
*** ccamposr_ has joined #openstack-dev | 08:36 | |
*** ccamposr_ has quit IRC | 08:37 | |
*** priteau has quit IRC | 08:42 | |
*** priteau has joined #openstack-dev | 08:42 | |
*** shyam89 has joined #openstack-dev | 08:42 | |
*** gfidente has joined #openstack-dev | 08:42 | |
*** ttsiouts has quit IRC | 08:46 | |
*** pcaruana has quit IRC | 08:50 | |
*** ttsiouts has joined #openstack-dev | 08:54 | |
*** psachin has joined #openstack-dev | 08:56 | |
*** jamesmcarthur has joined #openstack-dev | 09:02 | |
*** tonythomas has joined #openstack-dev | 09:03 | |
*** jamesmcarthur has quit IRC | 09:06 | |
*** gmoro has quit IRC | 09:10 | |
*** gmoro has joined #openstack-dev | 09:11 | |
*** ttsiouts has quit IRC | 09:15 | |
*** aloga has quit IRC | 09:27 | |
*** aloga has joined #openstack-dev | 09:27 | |
*** Dinesh_Bhor has quit IRC | 09:31 | |
*** Dinesh_Bhor has joined #openstack-dev | 09:43 | |
*** shyam89 has quit IRC | 09:46 | |
*** shyam89 has joined #openstack-dev | 09:47 | |
*** adrianc has quit IRC | 09:55 | |
*** pcaruana has joined #openstack-dev | 09:58 | |
*** slaweq_ is now known as slaweq | 10:00 | |
*** zigo has joined #openstack-dev | 10:01 | |
*** adrianc has joined #openstack-dev | 10:04 | |
*** shyam89 has quit IRC | 10:15 | |
*** vnogin has joined #openstack-dev | 10:19 | |
*** udesale has quit IRC | 10:21 | |
*** udesale has joined #openstack-dev | 10:21 | |
*** udesale has quit IRC | 10:21 | |
*** udesale has joined #openstack-dev | 10:22 | |
*** vnogin has quit IRC | 10:29 | |
*** adrianc has quit IRC | 10:37 | |
*** vnogin has joined #openstack-dev | 10:42 | |
*** vnogin has quit IRC | 10:47 | |
*** evrardjp has joined #openstack-dev | 10:53 | |
*** pbourke has quit IRC | 10:57 | |
*** pbourke has joined #openstack-dev | 10:59 | |
*** nplanel__ has quit IRC | 11:00 | |
*** vnogin has joined #openstack-dev | 11:01 | |
*** ttsiouts has joined #openstack-dev | 11:03 | |
*** dtantsur is now known as dtantsur|brb | 11:08 | |
*** Dinesh_Bhor has quit IRC | 11:09 | |
*** udesale has quit IRC | 11:10 | |
*** kaliya has joined #openstack-dev | 11:18 | |
*** kaliya has quit IRC | 11:23 | |
*** tonythomas has quit IRC | 11:23 | |
*** kaliya has joined #openstack-dev | 11:24 | |
*** shyam89 has joined #openstack-dev | 11:27 | |
*** kaliya has quit IRC | 11:29 | |
*** eharney has quit IRC | 11:32 | |
*** nicolasbock has joined #openstack-dev | 11:32 | |
*** sshnaidm has quit IRC | 11:43 | |
*** zigo has quit IRC | 11:45 | |
*** sshnaidm has joined #openstack-dev | 11:46 | |
*** dave-mccowan has joined #openstack-dev | 11:47 | |
*** morazi has joined #openstack-dev | 11:51 | |
*** shyam89 has quit IRC | 11:53 | |
*** odyssey4me has quit IRC | 11:53 | |
*** gkadam_ has quit IRC | 11:54 | |
*** odyssey4me has joined #openstack-dev | 11:55 | |
*** lbragstad has joined #openstack-dev | 11:57 | |
*** raildo has joined #openstack-dev | 11:59 | |
*** gcb_ has joined #openstack-dev | 12:01 | |
*** med_ has joined #openstack-dev | 12:03 | |
*** e0ne has quit IRC | 12:03 | |
*** tpsilva has joined #openstack-dev | 12:05 | |
*** ttsiouts has quit IRC | 12:09 | |
*** markvoelker has quit IRC | 12:09 | |
*** ttsiouts has joined #openstack-dev | 12:10 | |
*** shyam89 has joined #openstack-dev | 12:16 | |
*** e0ne has joined #openstack-dev | 12:19 | |
*** achampion has quit IRC | 12:22 | |
*** shyam89 has quit IRC | 12:27 | |
*** ttsiouts has quit IRC | 12:31 | |
*** edleafe has joined #openstack-dev | 12:33 | |
*** ttsiouts has joined #openstack-dev | 12:34 | |
*** shyam89 has joined #openstack-dev | 12:51 | |
*** jamesmcarthur has joined #openstack-dev | 12:54 | |
*** udesale has joined #openstack-dev | 12:57 | |
*** med_ has quit IRC | 13:00 | |
*** iyamahat has joined #openstack-dev | 13:04 | |
*** adrianc has joined #openstack-dev | 13:06 | |
*** eharney has joined #openstack-dev | 13:06 | |
*** mriedem_afk is now known as mriedem | 13:15 | |
*** dtantsur|brb is now known as dtantsur | 13:17 | |
*** med_ has joined #openstack-dev | 13:20 | |
*** radeks has joined #openstack-dev | 13:20 | |
*** zbitter is now known as zaneb | 13:23 | |
*** kgiusti has joined #openstack-dev | 13:23 | |
*** beagles is now known as beagles_mtgs | 13:30 | |
*** jamesmcarthur has quit IRC | 13:31 | |
*** njohnston has quit IRC | 13:31 | |
*** tdasilva has joined #openstack-dev | 13:32 | |
*** jamesmcarthur has joined #openstack-dev | 13:32 | |
*** rloo has joined #openstack-dev | 13:33 | |
*** jamesmcarthur has quit IRC | 13:34 | |
*** jamesmcarthur has joined #openstack-dev | 13:37 | |
*** jamesmcarthur has quit IRC | 13:40 | |
*** psachin has quit IRC | 13:42 | |
*** udesale has quit IRC | 13:43 | |
*** med_ has quit IRC | 13:47 | |
*** gnufied has joined #openstack-dev | 13:56 | |
*** d0ugal has quit IRC | 13:58 | |
*** ttsiouts has quit IRC | 13:59 | |
*** iyamahat has quit IRC | 14:06 | |
*** med_ has joined #openstack-dev | 14:09 | |
*** jtomasek has quit IRC | 14:15 | |
*** jamesmcarthur has joined #openstack-dev | 14:20 | |
*** ttsiouts has joined #openstack-dev | 14:22 | |
*** dtantsur is now known as dtantsur|brb | 14:24 | |
*** shyam89 has quit IRC | 14:29 | |
*** jamesmcarthur has quit IRC | 14:32 | |
*** achampion has joined #openstack-dev | 14:37 | |
*** Luzi has quit IRC | 14:38 | |
*** gfidente has quit IRC | 14:45 | |
*** gfidente has joined #openstack-dev | 14:46 | |
*** jamesmcarthur has joined #openstack-dev | 14:48 | |
*** morazi has quit IRC | 14:49 | |
*** iyamahat has joined #openstack-dev | 14:50 | |
*** morazi has joined #openstack-dev | 14:55 | |
*** d0ugal has joined #openstack-dev | 14:57 | |
*** bobh has joined #openstack-dev | 14:58 | |
*** aniketh has joined #openstack-dev | 15:05 | |
*** takamatsu has quit IRC | 15:10 | |
*** takamatsu has joined #openstack-dev | 15:12 | |
*** jtomasek has joined #openstack-dev | 15:14 | |
*** dsneddon has joined #openstack-dev | 15:14 | |
*** awaugama has joined #openstack-dev | 15:17 | |
*** Bhujay has quit IRC | 15:18 | |
*** gyee has joined #openstack-dev | 15:22 | |
*** corvus has joined #openstack-dev | 15:23 | |
*** pcaruana has quit IRC | 15:25 | |
*** celebdor has joined #openstack-dev | 15:26 | |
*** awaugama has quit IRC | 15:26 | |
*** Gaasmann has quit IRC | 15:27 | |
*** skazi has joined #openstack-dev | 15:33 | |
*** beagles_mtgs is now known as beagles | 15:33 | |
*** Emine has quit IRC | 15:33 | |
*** kaliya has joined #openstack-dev | 15:37 | |
*** bobh has quit IRC | 15:38 | |
*** awaugama has joined #openstack-dev | 15:40 | |
*** spartakos has joined #openstack-dev | 15:42 | |
*** dave-mccowan has quit IRC | 15:44 | |
*** Leo_m has joined #openstack-dev | 15:46 | |
*** ttsiouts has quit IRC | 15:46 | |
*** Pharaoh_Atem has joined #openstack-dev | 15:52 | |
*** dave-mccowan has joined #openstack-dev | 15:55 | |
*** bobh has joined #openstack-dev | 15:56 | |
*** iyamahat has quit IRC | 15:57 | |
*** eglynn has joined #openstack-dev | 15:59 | |
*** vnogin has quit IRC | 15:59 | |
*** dtantsur|brb is now known as dtantsur | 16:01 | |
*** jamesmcarthur has quit IRC | 16:04 | |
*** spartakos has quit IRC | 16:05 | |
*** spartakos has joined #openstack-dev | 16:06 | |
*** dave-mccowan has quit IRC | 16:06 | |
*** jamesmcarthur has joined #openstack-dev | 16:09 | |
*** markvoelker has joined #openstack-dev | 16:11 | |
lbragstad | melwitt WIP patch for oslo.limit enforcement (including the verification path) https://review.openstack.org/#/c/596520/6 | 16:13 |
melwitt | ack, thanks | 16:14 |
*** morazi has quit IRC | 16:14 | |
lbragstad | i just realized this... but does the service expect oslo.limit to clean up in the event something happens between when the claim is made and the limit is over quota for cleanup? | 16:14 |
lbragstad | (the race condition case) | 16:15 |
melwitt | I didn't think so | 16:15 |
melwitt | but I didn't think about what it would involve for oslo.limit to do it | 16:15 |
lbragstad | yeah - me either... | 16:15 |
lbragstad | i was reviewing that patch and i noticed with verification path | 16:16 |
lbragstad | if a race condition happens, we can detect that by using the usage callback provided by the service, yeah? | 16:16 |
melwitt | yeah, I think it couldn't in all cases actually, because that would require fine-grained API delete access for every resource.. | 16:16 |
lbragstad | but if we're already in __exit__ (of the context manager) and we detect that case, oslo.limit doesn't know anything about dealing with those resources | 16:17 |
*** efried is now known as efried_rollin | 16:17 | |
*** zaitcev has joined #openstack-dev | 16:18 | |
melwitt | trying to think how the flow works. I call enforce, then I create a resource, then call verify, if verify fails, I delete the resource and raise 403 limit exceeded | 16:18 |
lbragstad | yeah | 16:18 |
lbragstad | that'd be the ideal case | 16:18 |
melwitt | makes sense | 16:19 |
*** bobh has quit IRC | 16:19 | |
lbragstad | 1.) call enforce 2.) create resources/fill the claim 3.) call verify 4.) if verify = False, raise 403 | 16:19 |
lbragstad | is what _would_ happen today | 16:20 |
melwitt | ok. I'm browsing the patch | 16:20 |
lbragstad | i might be getting to much into the weeds here | 16:21 |
lbragstad | but iirc a lot of the justification for the use of a context manager was to make it so that services didn't need to manually implement try/excepts and have a separate verification path | 16:22 |
*** vnogin has joined #openstack-dev | 16:22 | |
melwitt | yeah, that's what I'm looking at. if the context manager does the verify itself, then how/when do I get to create a resource before the verify fires? | 16:22 |
*** kobis1 has joined #openstack-dev | 16:23 | |
*** jamesmcarthur has quit IRC | 16:23 | |
lbragstad | yeah... | 16:24 |
lbragstad | i'm trying to write up an example quick | 16:24 |
melwitt | could pass a closure, I guess. ok | 16:24 |
*** dsneddon has quit IRC | 16:25 | |
*** vnogin has quit IRC | 16:27 | |
*** morazi has joined #openstack-dev | 16:27 | |
*** shardy has quit IRC | 16:28 | |
lbragstad | this is pretty hacky... https://gist.github.com/lbragstad/69d28dca8adfa689c00b272d6db8bde7 | 16:29 |
*** jgriffith has quit IRC | 16:29 | |
*** jpich has quit IRC | 16:30 | |
*** jgriffith has joined #openstack-dev | 16:30 | |
*** eglynn has quit IRC | 16:31 | |
lbragstad | https://gist.github.com/lbragstad/69d28dca8adfa689c00b272d6db8bde7#file-verify-failure-example-py would try and handle the clean up in oslo.limit | 16:32 |
lbragstad | https://gist.github.com/lbragstad/69d28dca8adfa689c00b272d6db8bde7#file-verify-success-example-py would try and make the service clean it up | 16:33 |
lbragstad | the later seems like it defeats the purpose the context manager | 16:33 |
*** bobh has joined #openstack-dev | 16:35 | |
lbragstad | the former still requires a little more involvement within the context manager to make sure it knows about what was created and how to clean it up | 16:35 |
*** ccamposr has quit IRC | 16:37 | |
lbragstad | melwitt what did you have in mind for a closure? | 16:44 |
melwitt | lbragstad: oh, nevermind me. I was thinking to pass the create + args to get in between the limit check and verify, but the verify happens upon exit so it's fine | 16:45 |
*** ikhan has joined #openstack-dev | 16:46 | |
lbragstad | ok | 16:46 |
lbragstad | i assume race verification support is a requirement in order for nova to adopt this? | 16:47 |
lbragstad | because it's the default today, yeah? | 16:47 |
*** iyamahat has joined #openstack-dev | 16:48 | |
melwitt | yeah, as long as there's some way to do it. I was trying to think if it's necessary for oslo.limit itself to handle it. that is, let's say oslo.limit didn't have verify, we could just do the same thing we're doing now which is, create a resource, then enforce with a claim quantity of 0 and delete and raise if exceeded | 16:49 |
melwitt | the first example of passing the resource cleanup seems like it would work well, unless I'm missing something | 16:50 |
*** iyamahat_ has joined #openstack-dev | 16:50 | |
melwitt | and remember there was talk of oslo.limit providing different policies for handling the verify, like etcd based lock instead of the create/recheck strategy, somewhere down the line in the future | 16:51 |
*** ekcs has quit IRC | 16:51 | |
melwitt | that was something I thought would be cool about it being in oslo.limit is the lib being able to provide different strategies | 16:51 |
lbragstad | ok - that makes sense... i suppose if we clean things up with that support in oslo.limit nova could simplify later | 16:53 |
*** iyamahat has quit IRC | 16:53 | |
lbragstad | also - this is probably operator specific, but what about https://gist.github.com/lbragstad/69d28dca8adfa689c00b272d6db8bde7#file-multiple-resources-py | 16:53 |
lbragstad | i guess that depends on two things 1.) what developers consider a resource and 2.) what operators consider a resource | 16:54 |
lbragstad | because they'll ultimately have to match | 16:54 |
*** kobis1 has quit IRC | 16:54 | |
lbragstad | but if we allow resources to be granular, like cores and ram_mb, then we might need to expand on oslo.limit to handle multiple claims during enforcement | 16:55 |
*** kobis1 has joined #openstack-dev | 16:55 | |
melwitt | yeah, that's how we have to do things currently, create of a server requires checking for instance, cores, and ram limits | 16:56 |
*** nplanel__ has joined #openstack-dev | 16:56 | |
lbragstad | ok | 16:56 |
melwitt | and the claim is for all at the same time | 16:56 |
lbragstad | that makes sense - i suppose you can support both with granular resources | 16:56 |
melwitt | so I think when we were talking last time in vancouver, there was a possibility of a claim being able to be on multiple resources (a list of resources) | 16:57 |
lbragstad | oh - that's an option, too | 16:58 |
lbragstad | currently, the implementation of ProjectClaim is specific to a single resource, but we can change that | 16:59 |
*** gfidente is now known as gfidente|afk | 17:00 | |
lbragstad | so maybe like this - https://gist.github.com/lbragstad/69d28dca8adfa689c00b272d6db8bde7#file-multiple-resource-single-claim-py | 17:01 |
*** e0ne has quit IRC | 17:02 | |
lbragstad | probably doesn't matter to the service as much, but i think i like that from an oslo perspective because it might keep the enforcer simpler | 17:03 |
lbragstad | by not having to deal with a massive list of claims | 17:03 |
*** zaneb has quit IRC | 17:05 | |
melwitt | yeah, I didn't know if oslo.limit, if it knew ahead of time that it needed to enforce resource X, Y, and Z, would it be able to pull the limits for all in one go? | 17:05 |
*** zbitter has joined #openstack-dev | 17:05 | |
*** brokencycle has quit IRC | 17:05 | |
*** zbitter is now known as zaneb | 17:06 | |
lbragstad | oslo.limit *could* just pull all the limits and filter by project | 17:06 |
lbragstad | then filter through the resources associated to the claim | 17:06 |
melwitt | just trying to think if being able to tell all the resources up front could help anything be more efficient | 17:06 |
lbragstad | i would think so | 17:06 |
melwitt | ProjectClaim(project, resources=[x, y, z]) | 17:07 |
lbragstad | yeah - essentially something like that | 17:07 |
lbragstad | it looks like keystone's limit API does implement filtering by project id https://github.com/openstack/keystone/blob/d2da06f262db0f47a82b8bb0193f9bae92b59a7f/keystone/api/limits.py#L39 | 17:07 |
melwitt | and my callback=self.count_x_y_z | 17:08 |
lbragstad | oh... sure | 17:08 |
lbragstad | that would make sense, but it would require the service to make new callbacks i think? | 17:09 |
*** dsneddon has joined #openstack-dev | 17:10 | |
lbragstad | and the callback would need to supply all usage in a single return value? | 17:10 |
melwitt | what do you mean by make new callbacks? (I assumed when I call enforce I have to provide the callback and in the example of creating a server, I claim cores, ram, instance at the same time and also count cores, ram, instance at the same time in the same callback) | 17:11 |
lbragstad | so - the callback for calculating core usage for a project is going to be different than calculating the memory usage for a project? | 17:11 |
melwitt | yeah, that's what we currently do, returns a dict that's like {'project': {'ram': 512, 'cores': 1, 'instances': 5}, 'user': {'ram': 0, 'cores': 0, 'instances': 0}} | 17:12 |
lbragstad | oh! | 17:12 |
melwitt | since we have to count for project and user because of user quotas | 17:12 |
melwitt | it's ugly but... | 17:12 |
lbragstad | i was thinking it was more something like | 17:12 |
lbragstad | self.calculate_core_usage_for_project() return an integer value | 17:13 |
*** adrianc has quit IRC | 17:14 | |
lbragstad | because if ^ was the case, i was going to propose we associate callbacks to the claim resources instead of the enforce | 17:14 |
melwitt | yeah. that works if each count is separate but we can do a sum(cores), sum(ram), count(id) for counting instance related resources in one query | 17:14 |
*** dsneddon has quit IRC | 17:15 | |
lbragstad | ah - sure | 17:16 |
*** kobis1 has quit IRC | 17:17 | |
*** dsneddon has joined #openstack-dev | 17:18 | |
*** jamesmcarthur has joined #openstack-dev | 17:19 | |
lbragstad | so https://gist.github.com/lbragstad/69d28dca8adfa689c00b272d6db8bde7#file-multiple-resource-single-claim-py-L27-L49 as opposed to https://gist.github.com/lbragstad/69d28dca8adfa689c00b272d6db8bde7#file-multiple-resource-single-claim-py-L1-L23 | 17:21 |
*** kobis1 has joined #openstack-dev | 17:26 | |
*** dtantsur is now known as dtantsur|afk | 17:26 | |
*** kobis1 has quit IRC | 17:26 | |
*** diablo_rojo has joined #openstack-dev | 17:30 | |
*** hseipp has quit IRC | 17:31 | |
*** sshnaidm is now known as sshnaidm|afk | 17:32 | |
*** electrofelix has quit IRC | 17:32 | |
*** achampion has quit IRC | 17:51 | |
*** pcaruana has joined #openstack-dev | 17:52 | |
*** nplanel_ has joined #openstack-dev | 17:52 | |
*** nplanel__ has quit IRC | 17:55 | |
*** openstackgerrit has quit IRC | 18:00 | |
*** dsneddon has quit IRC | 18:01 | |
*** dsneddon has joined #openstack-dev | 18:01 | |
*** eharney has quit IRC | 18:04 | |
*** morazi has quit IRC | 18:06 | |
*** spartakos has quit IRC | 18:09 | |
*** d0ugal has quit IRC | 18:10 | |
*** jamesmcarthur has quit IRC | 18:11 | |
*** jamesmcarthur has joined #openstack-dev | 18:12 | |
*** jamesmcarthur has quit IRC | 18:16 | |
*** e0ne has joined #openstack-dev | 18:18 | |
*** jamesmcarthur has joined #openstack-dev | 18:18 | |
*** achampion has joined #openstack-dev | 18:23 | |
*** mlavalle has joined #openstack-dev | 18:24 | |
*** achampion has quit IRC | 18:27 | |
*** Emine has joined #openstack-dev | 18:28 | |
*** achampion has joined #openstack-dev | 18:35 | |
*** jamesmcarthur has quit IRC | 18:35 | |
*** priteau has quit IRC | 18:35 | |
*** priteau has joined #openstack-dev | 18:36 | |
*** spartakos has joined #openstack-dev | 18:38 | |
*** spartakos has quit IRC | 18:39 | |
*** spartakos has joined #openstack-dev | 18:40 | |
*** jamesmcarthur has joined #openstack-dev | 18:52 | |
*** e0ne has quit IRC | 18:54 | |
*** kaliya has quit IRC | 18:55 | |
*** eharney has joined #openstack-dev | 19:00 | |
*** morazi has joined #openstack-dev | 19:04 | |
*** jtomasek has quit IRC | 19:04 | |
lbragstad | melwitt i think i distilled the discussion early into two bug | 19:15 |
lbragstad | https://bugs.launchpad.net/oslo.limit/+bug/1790931 and https://bugs.launchpad.net/oslo.limit/+bug/1790935 | 19:15 |
openstack | Launchpad bug 1790931 in oslo.limit "RFE: ProjectClaims should support multiple resources" [Medium,Triaged] | 19:15 |
openstack | Launchpad bug 1790935 in oslo.limit "RFE: Enforcer should optionally handle resource cleanup" [Low,Triaged] | 19:15 |
lbragstad | let me know if anything is missing there | 19:15 |
*** radeks has quit IRC | 19:16 | |
melwitt | cool, will do. thanks | 19:16 |
*** radeks has joined #openstack-dev | 19:17 | |
*** awaugama has quit IRC | 19:17 | |
*** e0ne has joined #openstack-dev | 19:18 | |
*** jamesmcarthur has quit IRC | 19:22 | |
*** jamesmcarthur has joined #openstack-dev | 19:23 | |
*** jamesmcarthur has quit IRC | 19:28 | |
*** jamesmcarthur has joined #openstack-dev | 19:30 | |
*** efried_rollin is now known as efried | 19:31 | |
*** d0ugal has joined #openstack-dev | 19:33 | |
*** ijw has joined #openstack-dev | 19:37 | |
*** d0ugal has quit IRC | 19:37 | |
*** brokencycle has joined #openstack-dev | 19:42 | |
*** raildo has quit IRC | 19:47 | |
*** jcoufal has joined #openstack-dev | 19:47 | |
*** aniketh has quit IRC | 19:47 | |
*** ijw has quit IRC | 19:49 | |
*** raildo has joined #openstack-dev | 19:59 | |
*** ijw has joined #openstack-dev | 20:05 | |
*** njohnston has joined #openstack-dev | 20:06 | |
*** jcoufal has quit IRC | 20:07 | |
*** e0ne has quit IRC | 20:08 | |
*** qianmingyue has quit IRC | 20:15 | |
*** raildo has quit IRC | 20:35 | |
*** pcaruana has quit IRC | 20:40 | |
*** jamesmcarthur has quit IRC | 20:41 | |
*** jamesmcarthur has joined #openstack-dev | 20:43 | |
*** bobh has quit IRC | 20:44 | |
*** bobh has joined #openstack-dev | 20:44 | |
*** jamesmcarthur_ has joined #openstack-dev | 20:47 | |
*** jamesmcarthur has quit IRC | 20:48 | |
*** diablo_rojo has quit IRC | 20:49 | |
*** sshnaidm|afk has quit IRC | 20:54 | |
*** rloo has quit IRC | 20:57 | |
*** rloo has joined #openstack-dev | 20:57 | |
*** kgiusti has left #openstack-dev | 20:59 | |
*** sshnaidm has joined #openstack-dev | 21:00 | |
*** sshnaidm has quit IRC | 21:01 | |
*** diablo_rojo has joined #openstack-dev | 21:03 | |
*** bobh has quit IRC | 21:03 | |
*** vnogin has joined #openstack-dev | 21:04 | |
*** radeks has quit IRC | 21:09 | |
*** vnogin has quit IRC | 21:10 | |
*** celebdor has quit IRC | 21:14 | |
*** gfidente|afk has quit IRC | 21:16 | |
*** david-lyle has joined #openstack-dev | 21:19 | |
*** nplanel has joined #openstack-dev | 21:21 | |
*** dklyle has quit IRC | 21:22 | |
*** nplanel_ has quit IRC | 21:22 | |
*** ikhan has quit IRC | 21:28 | |
*** takamatsu has quit IRC | 21:42 | |
*** bobh has joined #openstack-dev | 21:43 | |
*** jamesmcarthur_ has quit IRC | 21:46 | |
*** jamesmcarthur has joined #openstack-dev | 21:51 | |
*** jamesmcarthur has quit IRC | 21:55 | |
*** slaweq has quit IRC | 21:56 | |
*** priteau has quit IRC | 21:56 | |
*** rloo has quit IRC | 21:58 | |
*** rloo has joined #openstack-dev | 21:58 | |
*** sshnaidm has joined #openstack-dev | 22:06 | |
*** vnogin has joined #openstack-dev | 22:06 | |
*** bobh has quit IRC | 22:06 | |
*** achampion has quit IRC | 22:07 | |
*** dqx has joined #openstack-dev | 22:07 | |
*** sshnaidm is now known as sshnaidm|off | 22:08 | |
*** mlavalle has quit IRC | 22:08 | |
*** slaweq has joined #openstack-dev | 22:11 | |
*** Leo_m has quit IRC | 22:12 | |
*** ijw has quit IRC | 22:15 | |
*** slaweq has quit IRC | 22:16 | |
*** Emine has quit IRC | 22:17 | |
*** rloo has quit IRC | 22:17 | |
*** rloo has joined #openstack-dev | 22:17 | |
*** mriedem has quit IRC | 22:18 | |
*** nplanel has quit IRC | 22:19 | |
*** cdent has quit IRC | 22:19 | |
*** hongbin has quit IRC | 22:35 | |
*** rcernin has joined #openstack-dev | 22:43 | |
*** brokencycle has quit IRC | 22:52 | |
*** dqx has joined #openstack-dev | 22:55 | |
*** jamesmcarthur has joined #openstack-dev | 22:57 | |
*** jamesmcarthur has quit IRC | 23:01 | |
*** slaweq has joined #openstack-dev | 23:11 | |
*** slaweq has quit IRC | 23:15 | |
*** med_ has quit IRC | 23:27 | |
*** med_ has joined #openstack-dev | 23:38 | |
*** owalsh_ has joined #openstack-dev | 23:44 | |
*** owalsh has quit IRC | 23:48 | |
*** owalsh- has joined #openstack-dev | 23:48 | |
*** owalsh_ has quit IRC | 23:51 | |
*** ijw has joined #openstack-dev | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!