Alexei_987 | lifeless: just like we do now in openstack :) | 00:00 |
---|---|---|
lifeless | Alexei_987: exatly; we need to be better at fixing the source | 00:00 |
*** armax has joined #openstack-dev | 00:00 | |
lifeless | Alexei_987: btw if you're interested - background on subunit v2 starts here http://rbtcollins.wordpress.com/2013/02/14/time-to-revise-the-subunit-protocol/ | 00:00 |
Alexei_987 | lifeless: I vote for JSON | 00:01 |
*** jdurgin has quit IRC | 00:01 | |
*** sarob_ has joined #openstack-dev | 00:01 | |
lifeless | Alexei_987: given the amount of content there, its pretty clear you didn't read the real-world lessons learnt around that. | 00:01 |
*** sarob_ has quit IRC | 00:01 | |
*** thuc has quit IRC | 00:01 | |
Alexei_987 | lifeless: Ok ok I just like JSON ;) | 00:02 |
*** thuc has joined #openstack-dev | 00:02 | |
lifeless | Alexei_987: I'm planning on doing a trace-into-json filter at some point for human reading of streams | 00:02 |
lifeless | Alexei_987: I like JSON too | 00:02 |
lifeless | Alexei_987: its just not suitable for machine->machine transfer over possibly noisy channels | 00:02 |
StevenK | lifeless: oopstools and BSON says hi | 00:03 |
Alexei_987 | lifeless: not sure that I understand what "possibly noisy channels" means | 00:03 |
lifeless | StevenK: o/ | 00:03 |
StevenK | Haha | 00:03 |
Alexei_987 | we have TCP, no? | 00:03 |
lifeless | Alexei_987: no | 00:03 |
*** sweston has quit IRC | 00:03 | |
lifeless | Alexei_987: test backends have a nasty habit of writing crap to their pipes without warning | 00:04 |
*** sarob has quit IRC | 00:04 | |
Alexei_987 | ah.. I see what you mean | 00:04 |
*** vuil has joined #openstack-dev | 00:04 | |
lifeless | Alexei_987: so I think the CatFiles result in subunit.test_results is sufficient | 00:04 |
Alexei_987 | lifeless: however I still think that we should fix nosiness instead of protocol | 00:05 |
lifeless | Alexei_987: for gatherer above | 00:05 |
*** jdurgin has joined #openstack-dev | 00:05 | |
lifeless | Alexei_987: I spent /years/ doing that. | 00:05 |
lifeless | Alexei_987: I welcome you joining the battle. | 00:05 |
*** mtreinish has quit IRC | 00:05 | |
Alexei_987 | we could use some message queue for that (zeroMQ) | 00:05 |
Alexei_987 | it would be good for splitting stuff between workers | 00:05 |
Alexei_987 | and avoid any noise related crap | 00:05 |
*** armax has quit IRC | 00:05 | |
lifeless | Alexei_987: then the crap from the runner is lost (bad) or out of sequeunce with whatever test ran (also bad) | 00:06 |
Alexei_987 | it's not lost | 00:06 |
Alexei_987 | it's just messed up with other crap | 00:06 |
lifeless | Alexei_987: if you dont' capture stdout it is | 00:06 |
Alexei_987 | you capture it | 00:06 |
Alexei_987 | you just don't use the same pipe for internal communication | 00:06 |
*** thuc has quit IRC | 00:07 | |
Alexei_987 | so you have message queue as a command/result channel | 00:07 |
*** carl_baldwin has quit IRC | 00:07 | |
lifeless | also runs into issues with runners that internally fork/exec | 00:07 |
*** flaper87 is now known as flaper87|afk | 00:07 | |
lifeless | I can certainly see running subunit on an out of band pipe | 00:07 |
lifeless | its designed to permit that | 00:07 |
Alexei_987 | actually we don't have to fork | 00:07 |
lifeless | haven't done the glue for it yet though | 00:07 |
Alexei_987 | to use zeroMQ for example | 00:07 |
lifeless | Alexei_987: /we/ don't - there are runners out there that do | 00:07 |
lifeless | Alexei_987: e.g. zope.testrunner. | 00:07 |
Alexei_987 | so what? | 00:08 |
Alexei_987 | it just connects to proper listener and sends messages | 00:08 |
Alexei_987 | I mean that we can have 1 master process that runs a results collector | 00:08 |
*** amcrn_ has joined #openstack-dev | 00:08 | |
Alexei_987 | + X worker processes that just share an endpoint for that queue | 00:09 |
lifeless | sure, the demultiplexor | 00:09 |
lifeless | testr :) | 00:09 |
Alexei_987 | yeah | 00:09 |
*** amcrn has quit IRC | 00:09 | |
*** amcrn_ is now known as amcrn | 00:09 | |
*** mtreinish has joined #openstack-dev | 00:10 | |
*** bdpayne has joined #openstack-dev | 00:11 | |
*** vuil has quit IRC | 00:11 | |
begin | guys, can you help me to understand a little bit more python with that piece of code: self.conn_timeout = float(conf.get('conn_timeout', 0.5))? | 00:11 |
*** kgriffs has quit IRC | 00:11 | |
*** kgriffs_afk has joined #openstack-dev | 00:12 | |
*** kgriffs_afk is now known as kgriffs | 00:12 | |
Alexei_987 | lifeless: coming back to unittest issue. If you'll check unittest.loader you'll see that there is no way to get to error message without actually calling test method | 00:12 |
lifeless | Alexei_987: yes, I know. That why I opened the issue upstream | 00:12 |
lifeless | http://bugs.python.org/issue19746 | 00:13 |
*** Tross has quit IRC | 00:13 | |
Alexei_987 | do you have any ideas of how it should be fixed? | 00:13 |
*** jaybuff has joined #openstack-dev | 00:13 | |
*** hughsaunders has quit IRC | 00:13 | |
*** jhesketh__ has joined #openstack-dev | 00:13 | |
lifeless | Alexei_987: a few possibilities - a kwarg to the load methods to ask them to return errors as a separate thing to the found tests | 00:13 |
lifeless | Alexei_987: or make a defined, stable marker on the returned tests (e.g. a specific class and attributes that can be reliably introspected) | 00:14 |
*** begin has quit IRC | 00:15 | |
*** mwagner_lap has quit IRC | 00:15 | |
Alexei_987 | lifeless: how do you can actually submit a pull request there? | 00:15 |
*** mwagner_lap has joined #openstack-dev | 00:15 | |
*** mwagner_lap has quit IRC | 00:16 | |
lifeless | Alexei_987: just a patch in the bug tracker there usually, unless you have commit access | 00:17 |
Alexei_987 | lifeless: ah I found guide | 00:17 |
*** ramishra has quit IRC | 00:17 | |
*** begin has joined #openstack-dev | 00:18 | |
*** ramishra has joined #openstack-dev | 00:19 | |
*** ijw_ has quit IRC | 00:19 | |
*** armax has joined #openstack-dev | 00:19 | |
*** hughsaunders has joined #openstack-dev | 00:19 | |
*** ijw has joined #openstack-dev | 00:20 | |
*** IanGovett has quit IRC | 00:20 | |
bknudson | I'm a little worried that the keystoneclient module docs are not being updated... | 00:20 |
bknudson | http://docs.openstack.org/developer/python-keystoneclient/py-modindex.html | 00:20 |
bknudson | shows "Last updated on Mon Mar 18" | 00:20 |
jamielennox | bknudson: i've got no idea how that works | 00:23 |
jamielennox | bknudson: i don't even think most of the stuff in docs is published | 00:23 |
bknudson | jamielennox: what do you mean not published? | 00:24 |
*** hdd_ has joined #openstack-dev | 00:24 | |
jamielennox | bknudson: well i'm not sure where they go - but more i know that i went at one point to update the middleware architecture document in keystoneclient and was told not to bother because it was so far behind the one in keystone | 00:24 |
bknudson | jamielennox: the main page is up to date -- http://docs.openstack.org/developer/python-keystoneclient/index.html | 00:25 |
*** tkay has quit IRC | 00:25 | |
bknudson | says Last updated on Mon Feb 3 03:07:36 2014 | 00:26 |
*** jmontemayor has quit IRC | 00:26 | |
*** epim has quit IRC | 00:26 | |
*** dims has quit IRC | 00:26 | |
bknudson | jamielennox: that would be a strange thing to not update the documentation because it's too far out of date? | 00:26 |
jamielennox | ok, well middleware architecture is not linked there then | 00:27 |
bknudson | seems like if it's out of date is exactly the time to update it. | 00:27 |
bknudson | jamielennox: I submitted a change to add the link to the middleware arch doc. | 00:27 |
jamielennox | bknudson: more like it's worth just a wholesale sync from keystone - it belongs in client | 00:27 |
*** vuil has joined #openstack-dev | 00:27 | |
jamielennox | bknudson: yea, i've seen a few of your doc changes - i don't know how to test them though | 00:27 |
bknudson | and get it in sync with keystone | 00:27 |
*** pmathews has quit IRC | 00:27 | |
*** pmathews has joined #openstack-dev | 00:28 | |
gyee | jamielennox, I really like the way you handle multiple methods in the plugin impl | 00:28 |
bknudson | jamielennox: tox -e venv python setup.py build_sphinx | 00:28 |
jamielennox | gyee: yea, i think thats cool | 00:28 |
gyee | jamielennox, do we need one for the ADMIN token? | 00:28 |
bknudson | jamielennox: then look in doc/build/html/index.html | 00:28 |
gyee | as it is static | 00:28 |
gyee | I presume its going to be a simple one, just return the same token on get_token() | 00:29 |
jamielennox | gyee: we will need an endpoint/token plugin - but that's not an 'identity' plugin | 00:29 |
*** ramishra has quit IRC | 00:29 | |
jamielennox | bknudson: ok, i will have another look through those | 00:29 |
*** carl_baldwin has joined #openstack-dev | 00:29 | |
gyee | jamielennox, that would make it usable by middleware | 00:29 |
gyee | that 'admin_token' in auth_token middleware is really the static admin token | 00:30 |
jamielennox | gyee: true, i haven't covered the endpoint/token case in either of the factories | 00:30 |
jamielennox | yep | 00:30 |
*** stevemar has joined #openstack-dev | 00:30 | |
*** abhirc has joined #openstack-dev | 00:30 | |
gyee | jamielennox, I would love to use it for middleware, | 00:30 |
gyee | in fact, I am going to use it in the s3 and ec2 middleware prototype | 00:30 |
jamielennox | i'm not sure if i should allow 'endpoint' to be passed to the identity plugins - i dont *think* there will be a problem with that though | 00:31 |
*** abhirc has quit IRC | 00:31 | |
gyee | jamielennox, no need for endpoint | 00:31 |
jamielennox | i'm trying to keep them as pure as possible and then they get bastardized by hacks later | 00:31 |
gyee | just auth_url | 00:31 |
*** nati_ueno has joined #openstack-dev | 00:32 | |
gyee | jamielennox, I'll put up some code for you to look at and you'll see what I mean | 00:32 |
jamielennox | the only case i'm not sure about is if someone passed auth_url + endpoint + user/pass or something | 00:32 |
jamielennox | that would to me mean that you should use auth_url and user/pass for a token, but override what is returned from the catalog with endpoint | 00:32 |
gyee | jamielennox, essentially I want auth_token to use v3.client or v2.client, based on auth_version | 00:32 |
jamielennox | gyee: have you had a look at that yet? | 00:33 |
jamielennox | i've been waiting until auth plugins pass and i can do some more discovery work | 00:33 |
gyee | jamielennox, which one? you make the change already? | 00:33 |
*** nelsnelson has quit IRC | 00:33 | |
jamielennox | gyee: i mean to converting auth_tokken | 00:34 |
gyee | jamielennox, I am doing prototyping with s3 and ec3, utilizing the generic signature auth plugin | 00:35 |
jamielennox | the problem i kind of see is that there are two things to discover - which auth plugin to use and which client to use because they don't have to be the same thing | 00:35 |
*** AlexF has joined #openstack-dev | 00:35 | |
gyee | jamelennox, middleware already know what one to use | 00:35 |
gyee | jamielennox ^^ | 00:35 |
jamielennox | gyee: oh? | 00:35 |
gyee | I mean middleware already know which API to use | 00:36 |
gyee | there's a auth_version parameter | 00:36 |
jamielennox | yea, thats true you can set the client to v3 | 00:36 |
Alexei_987 | lifeless: so what do you think about using zeromq to transport internal data in subunit? | 00:36 |
jamielennox | it just only does the actual auth over v2 | 00:36 |
*** dave_tucker is now known as dave_tucker_zzz | 00:36 | |
*** cadenzajon has quit IRC | 00:36 | |
jamielennox | gyee: as in the middleware auth is only via v2 | 00:37 |
gyee | jamielennox, right, that we need to fix | 00:37 |
jamielennox | i would like to define as part of auth plugins a from_conf() method or something that would allow creating an auth plugin from a confing set | 00:37 |
jamielennox | i want to talk to dtroyer about how that would work though | 00:37 |
*** david-lyle has quit IRC | 00:37 | |
*** tkay has joined #openstack-dev | 00:38 | |
jamielennox | same with exposing command line args | 00:38 |
gyee | jamielennox, I am thinking about the same thing, have some sort of factory based on conf | 00:38 |
lifeless | Alexei_987: I've pushed the UI ugliness fix I hadn't gotten around to up to testr trunk. | 00:38 |
lifeless | Alexei_987: its not as pretty as it can be, but i don't have the time to glue it into the UI layer properly right now. | 00:38 |
lifeless | Alexei_987: we'll still need the import error stuff in testtools, of course. | 00:39 |
*** CaptTofu has joined #openstack-dev | 00:39 | |
jamielennox | gyee: yep, so i'm just not sure how we go about differentiating v2 vs v3 for that | 00:39 |
*** mikeoutland has quit IRC | 00:39 | |
jamielennox | gyee: i guess we don't need to for the first pass | 00:39 |
gyee | jamielennox, either explicitly via auth_version or discover | 00:39 |
*** pmathews has quit IRC | 00:40 | |
jamielennox | gyee: at least to start we will want a v3.Auth.from_conf and a v2.Auth.from_conf and we don't need to discover yet | 00:40 |
lifeless | Alexei_987: I'd like to see a robust standardised out of band mechanis, sure. I think it needs some design work (and just saying 'ZeroMQ' is not that) | 00:40 |
gyee | jamielennox, I was thinking get_client(conf) | 00:40 |
Alexei_987 | :) I just wanted to know maybe you have some obvious reasons against it | 00:41 |
jamielennox | gyee: we need some top level stuff soon as well | 00:41 |
jamielennox | gyee: but everything i've done has been very layered so far, so that if you know you want a v3 auth or client you can create that without doing discovery | 00:41 |
*** dims has joined #openstack-dev | 00:41 | |
Alexei_987 | lifeless: Ok I'll keep this in mind and may come back to it a bit later when I'll have time | 00:41 |
gyee | jamielennox, I love the design! | 00:41 |
*** baoli has joined #openstack-dev | 00:41 | |
*** AlexF has quit IRC | 00:41 | |
jamielennox | gyee: then a generic entry would do discovery and then hand off to the correct factory | 00:42 |
gyee | jamielennox, I'll go through the code in detail, but I like the direction at the first glance | 00:42 |
jamielennox | so we can do a v2 and a v3 from_conf and then later we are going to need a discoverable auth entry point | 00:42 |
*** baoli has quit IRC | 00:43 | |
jamielennox | gyee: yea, i'm pretty happy with how the AuthMethod stuff worked out in the v3 plugins. I thought it was going to be really ugly. | 00:43 |
*** baoli has joined #openstack-dev | 00:43 | |
jamielennox | bknudson: that AuthMethod stuff is i think what you were talking about the other day as well | 00:44 |
gyee | jamielennox, we'll probably need to figure out how to facilitate the static admin token later | 00:44 |
jamielennox | gyee: i think that one will be trivial | 00:44 |
jamielennox | we have to work it into the factories i guess but other than that | 00:44 |
Alexei_987 | lifeless: I'll update my pull request in the morning . Have a nice day | 00:44 |
gyee | jamielennox, right | 00:44 |
*** relaxdiego has quit IRC | 00:45 | |
*** dave_tucker_zzz is now known as dave_tucker | 00:46 | |
*** tdruiva has quit IRC | 00:46 | |
*** baoli has quit IRC | 00:47 | |
*** RajeshMohan has quit IRC | 00:48 | |
*** baoli has joined #openstack-dev | 00:48 | |
*** gnorth has quit IRC | 00:49 | |
*** zul has joined #openstack-dev | 00:50 | |
*** rcleere has quit IRC | 00:51 | |
*** toabctl_ has quit IRC | 00:54 | |
*** toabctl_ has joined #openstack-dev | 00:55 | |
*** matrohon has quit IRC | 00:55 | |
*** xmltok has quit IRC | 00:55 | |
*** matrohon has joined #openstack-dev | 00:55 | |
*** RajeshMohan has joined #openstack-dev | 00:56 | |
*** nati_ueno has quit IRC | 00:56 | |
*** tsekiyam_ has joined #openstack-dev | 00:56 | |
*** thuc has joined #openstack-dev | 00:56 | |
*** AlexF has joined #openstack-dev | 00:57 | |
*** thuc has quit IRC | 00:57 | |
*** dvarga is now known as dvarga|away | 00:57 | |
*** dvarga|away is now known as dvarga | 00:57 | |
*** sushils has quit IRC | 00:57 | |
*** thuc has joined #openstack-dev | 00:58 | |
*** tsekiyama has quit IRC | 00:58 | |
*** browne has quit IRC | 00:59 | |
*** zul has quit IRC | 00:59 | |
*** galstrom_zzz is now known as galstrom | 00:59 | |
*** tsekiyam_ has quit IRC | 00:59 | |
*** gokrokve has quit IRC | 01:00 | |
*** gokrokve has joined #openstack-dev | 01:00 | |
*** RajeshMohan has quit IRC | 01:01 | |
dstanek | stevemar: reviewed | 01:01 |
*** jaybuff has quit IRC | 01:01 | |
stevemar | dstanek, ahoy hoy | 01:01 |
*** jaybuff1 has joined #openstack-dev | 01:01 | |
stevemar | dstanek, fingers crossed | 01:01 |
stevemar | dstanek, d'oh | 01:02 |
dstanek | stevemar: i really just had a question about user name | 01:02 |
*** devoid has quit IRC | 01:02 | |
dstanek | the other things i could live with | 01:02 |
*** arosen has joined #openstack-dev | 01:03 | |
stevemar | dstanek, re: the name bit... i was wondering about this too | 01:04 |
stevemar | dstanek, it's hard because, from the mapping side, i can't enforce that they have a user name mapping, not easily anyway | 01:04 |
stevemar | and I can't do much about the assertion coming in | 01:04 |
*** pablosan has quit IRC | 01:05 | |
*** tresor has joined #openstack-dev | 01:05 | |
*** gokrokve has quit IRC | 01:05 | |
stevemar | dstanek, generally, it's assumed that the assertion will have some user name concept. but if the mapping rules don't have a rule about transforming SAML name to keystone name... /me shrugs | 01:06 |
*** RajeshMohan has joined #openstack-dev | 01:06 | |
*** kenperkins_ has quit IRC | 01:06 | |
dstanek | stevemar: you could add a check in there is see if name exists in the user dict | 01:06 |
*** atiwari has quit IRC | 01:07 | |
dstanek | stevemar: if it's a requirement then i could deal with it - i'd love to create a patch to add that type of validation | 01:07 |
*** vuil has quit IRC | 01:08 | |
*** ramishra has joined #openstack-dev | 01:08 | |
*** mlegault_ has joined #openstack-dev | 01:08 | |
*** andreaf has quit IRC | 01:09 | |
*** arosen has quit IRC | 01:09 | |
*** kenperkins has joined #openstack-dev | 01:09 | |
*** epim has joined #openstack-dev | 01:09 | |
*** andreaf has joined #openstack-dev | 01:09 | |
*** arosen has joined #openstack-dev | 01:10 | |
*** relaxdiego has joined #openstack-dev | 01:10 | |
stevemar | dstanek, the consequence is that user's name is None, which I think they can handle in https://review.openstack.org/#/c/71353/4/keystone/contrib/federation/controllers.py | 01:10 |
*** flamebot has joined #openstack-dev | 01:11 | |
*** toanster has quit IRC | 01:11 | |
*** terrylhowe has quit IRC | 01:11 | |
stevemar | dstanek, it will mean that the issued token has None for the user id :\ | 01:11 |
*** mlegault has quit IRC | 01:11 | |
*** toanster has joined #openstack-dev | 01:12 | |
*** tresor has quit IRC | 01:12 | |
stevemar | dstanek, initially, i wanted to double check name/id/email in that order, and break if neither was there | 01:12 |
stevemar | s/double// | 01:12 |
*** ramishra has quit IRC | 01:13 | |
*** carl_baldwin has quit IRC | 01:13 | |
*** galstrom is now known as galstrom_zzz | 01:15 | |
*** kenperkins has quit IRC | 01:15 | |
*** tkay has quit IRC | 01:15 | |
*** e0ne has quit IRC | 01:16 | |
*** CaptTofu has quit IRC | 01:16 | |
*** gokrokve has joined #openstack-dev | 01:17 | |
*** tqtran1 has quit IRC | 01:17 | |
*** CaptTofu has joined #openstack-dev | 01:19 | |
dstanek | stevemar: is that something to do in that function? | 01:21 |
*** reed has quit IRC | 01:22 | |
stevemar | dstanek, dolphm said otherwise | 01:23 |
*** RajeshMohan has quit IRC | 01:24 | |
*** gokrokve has quit IRC | 01:25 | |
*** mlegault_ has quit IRC | 01:26 | |
dstanek | stevemar: sounds good - i'm going mess with the schema a little | 01:26 |
dstanek | stevemar: what did you think about the other things? the most incorrect is the docstring ordering | 01:27 |
stevemar | dstanek, go ahead | 01:27 |
stevemar | dstanek, yeah, i can fix those up, they were legit problems | 01:27 |
dstanek | stevemar: is there tests for the mapping schema? | 01:28 |
*** lubyou has quit IRC | 01:28 | |
stevemar | dstanek, already merged | 01:28 |
stevemar | dstanek, i need a better way to make sure the error msgs are actually related to the errors i'm testing... | 01:29 |
*** dave_tucker is now known as dave_tucker_zzz | 01:29 | |
*** jamespage has quit IRC | 01:29 | |
*** godara has quit IRC | 01:29 | |
*** mmoya_ has quit IRC | 01:29 | |
*** sileht has quit IRC | 01:29 | |
*** mmoya has joined #openstack-dev | 01:29 | |
ayoung-Dad | stevemar, dstanek morganfainberg ... I think that I have a path forward for ephemeral tokens and dealing with the Redirects of Federation. What if we made GET /auth/token the call that returned a default token...unscoped. But..and here is the kicker, we make it ephemeral | 01:30 |
*** relaxdiego has quit IRC | 01:30 | |
*** otherwiseguy has quit IRC | 01:30 | |
ayoung-Dad | we only check it using PKI | 01:30 |
*** ayoung-Dad is now known as ayoung | 01:31 | |
*** dave_tucker_zzz is now known as dave_tucker | 01:31 | |
morganfainberg | ayoung, i like that. | 01:32 |
ayoung | yeah, me too | 01:32 |
ayoung | morganfainberg, and...what if we made it easy to get a scoped token by hitting other urls, like /v3/project/<projecid>/token ? | 01:32 |
ayoung | it only will give you a token for $USER | 01:33 |
stevemar | dstanek, i'll make those 2 changes now | 01:33 |
stevemar | dstanek, silly question is there a convention for ordering args? | 01:33 |
morganfainberg | ayoung, huh, | 01:34 |
*** jamespage has joined #openstack-dev | 01:34 | |
*** jamespage has joined #openstack-dev | 01:34 | |
ayoung | morganfainberg, if you want a scoped token, got to the scope you want in Keystone and say "give me a token, dammit!" | 01:34 |
morganfainberg | ayoung, i'm rolling that around in my head. | 01:35 |
morganfainberg | ayoung, so, you have a defined entry point for your unscoped token | 01:35 |
dstanek | stevemar: not really..i think it's just what makes sense for the situatio | 01:35 |
dstanek | n | 01:35 |
stevemar | dstanek, cool | 01:35 |
morganfainberg | ayoung, and then scoped tokens come from the <resource>/token ? | 01:35 |
*** novas0x2a|laptop has joined #openstack-dev | 01:35 | |
*** xarses has quit IRC | 01:35 | |
ayoung | yepo | 01:35 |
*** RajeshMohan has joined #openstack-dev | 01:35 | |
morganfainberg | ayoung, it... might just make too much sense, i'm sorry. it's too intuitive | 01:35 |
ayoung | morganfainberg, the only thing that varies on a token is the issued_at time | 01:35 |
ayoung | and...if it is based on an initial authentication/token auth...they all follow the rules of auth by token...expires_at stays constant | 01:36 |
*** sweston has joined #openstack-dev | 01:36 | |
morganfainberg | ayoung, i think you need to make it so you ask <resource>/token for the reference that you then repost the entire auth chain to to get the one-time resource that issues the scoped token | 01:36 |
*** lubyou has joined #openstack-dev | 01:36 | |
*** ctracey is now known as ctracey|away | 01:37 | |
morganfainberg | ayoung, so unscoped token would allow you to determine the resources / scopes you can use? | 01:37 |
ayoung | morganfainberg, as I understand it, the reason we didn't do something like this in the past was that creating a token was considered creating a new resources. With ephemeral, that is no longer the case | 01:37 |
morganfainberg | ayoung, or is that determined separately? | 01:37 |
morganfainberg | ayoung, and yes, that makes perfect sense (ephemeral vs non) | 01:37 |
*** sileht has joined #openstack-dev | 01:37 | |
morganfainberg | and why we do things the way we do | 01:37 |
ayoung | and a token becomes nothing more than a signed response from Keystone | 01:37 |
morganfainberg | it does make a number of things easier | 01:38 |
*** jasdeepH has quit IRC | 01:38 | |
dstanek | stevemar: dumb question...where are those tests? | 01:38 |
morganfainberg | ayoung, it would be a drastic departure from current mechanisms | 01:38 |
ayoung | morganfainberg, and it makes it easier to sign any random API, too | 01:38 |
ayoung | morganfainberg, current mechanisms can still work | 01:38 |
morganfainberg | ayoung, yes, so another extension that applies this logic | 01:38 |
morganfainberg | ayoung, with the eventual goal to make this logic the "correct" approach and deprecate the old logic long term? | 01:39 |
ayoung | morganfainberg, just the current controllers, mostly in assignmnet | 01:39 |
ayoung | I think so. | 01:39 |
*** vkmc has quit IRC | 01:39 | |
morganfainberg | ayoung, sure. i could get behind that. | 01:40 |
*** alex_xu has joined #openstack-dev | 01:40 | |
ayoung | cool | 01:40 |
morganfainberg | ayoung, i'd like to chew on it a bit still, but it seems sound | 01:40 |
*** xingchao has joined #openstack-dev | 01:40 | |
ayoung | we can discuss tomorrow | 01:40 |
morganfainberg | ayoung, aye. | 01:40 |
morganfainberg | ayoung, i assume a link for /token would appear for any resource that can sign a scope then. | 01:40 |
ayoung | morganfainberg, yeah | 01:41 |
morganfainberg | sleep + a (i'm sure) lively discussion in IRC will show us how this shakes out | 01:41 |
*** xuhanp has joined #openstack-dev | 01:41 | |
morganfainberg | but i like it conceptually | 01:41 |
ayoung | morganfainberg, really, could be done with an "accepts" header on the resource itself, but deliberate link is probably clearer | 01:41 |
morganfainberg | ayoung, deliberate link, but i wouldn't be opposed to leveraging accepts headers more than we do | 01:42 |
*** abhirc has joined #openstack-dev | 01:42 | |
ayoung | morganfainberg, I've been thinking about the token compression. Sign, then compress makes a lot of sense. We create an Content_type that indicates that | 01:43 |
ayoung | applications/cmsz64 or something | 01:43 |
*** ctracey|away has joined #openstack-dev | 01:43 | |
ayoung | applications/json+cms_z+base64 | 01:43 |
morganfainberg | ayoung, sure, though it wouldn't hurt to make each step (that needs to be reversed) detectable from the point it needs to be done | 01:44 |
ayoung | morganfainberg, and if that is the case, say we drop the base64 encoding, then the content-type would be | 01:44 |
*** arosen has quit IRC | 01:44 | |
ayoung | application/json+cms+z+base64 | 01:44 |
ayoung | I wonder if I should use that as the token prefix insted of {cmsz} | 01:44 |
morganfainberg | hm. sure. | 01:44 |
*** abhirc_ has joined #openstack-dev | 01:45 | |
ayoung | its more verbose, but with compression of the rest, it will be far more self-documenting | 01:45 |
morganfainberg | actually tbh, i'd make it so you unzip it, and it tells you this is cms, you decrypt, it is b64, you unb64, it says json | 01:45 |
*** tdruiva has joined #openstack-dev | 01:45 | |
*** dvarga has quit IRC | 01:45 | |
morganfainberg | ayoung, i only say that because it simplifies it and if any one element is dropped out you can always figure out the next step from where you are. | 01:46 |
ayoung | yeah, I like that | 01:46 |
*** dolphm has quit IRC | 01:46 | |
morganfainberg | ayoung, it also means the content-type doesn't become application/json+cms+z+b64+keystone_foo+bar+rot13 | 01:47 |
stevemar | dstanek, the malicious ones are here: https://github.com/openstack/keystone/blob/master/keystone/tests/test_v3_federation.py#L531 | 01:47 |
ayoung | morganfainberg, it doesn't it feel like when you are packing a car on a trip, and you get everything to fit? | 01:47 |
morganfainberg | ayoung, lol | 01:47 |
ayoung | why not rot13? | 01:47 |
*** jkoelker has quit IRC | 01:47 | |
stevemar | dstanek, the mappings are all in https://github.com/openstack/keystone/blob/master/keystone/tests/mapping_fixtures.py | 01:47 |
morganfainberg | ayoung, dude I rot17 everything | 01:47 |
*** kenperkins has joined #openstack-dev | 01:47 | |
*** bdpayne has quit IRC | 01:48 | |
*** jaybuff1 has quit IRC | 01:48 | |
*** abhirc has quit IRC | 01:48 | |
morganfainberg | ayoung, i am just thinking from a pipeline perspective, each step is isolated and adds the data it needs to for decoding later. | 01:48 |
ayoung | rpflex, uluv Z ifk17 vmvipkyzex | 01:48 |
morganfainberg | ayoung, rather than having to pass a dict/list/something through the whole way to track it | 01:48 |
*** kenperkins has quit IRC | 01:49 | |
*** relaxdiego has joined #openstack-dev | 01:49 | |
*** jasdeepH has joined #openstack-dev | 01:50 | |
*** dolphm has joined #openstack-dev | 01:51 | |
*** neelashah has joined #openstack-dev | 01:51 | |
*** AlexF has quit IRC | 01:51 | |
*** jkoelker has joined #openstack-dev | 01:51 | |
*** RajeshMohan has quit IRC | 01:52 | |
*** epim has quit IRC | 01:52 | |
*** melwitt has quit IRC | 01:52 | |
*** buzztroll has quit IRC | 01:52 | |
*** galstrom_zzz is now known as galstrom | 01:53 | |
*** RajeshMohan has joined #openstack-dev | 01:53 | |
*** thuc has quit IRC | 01:53 | |
*** thuc has joined #openstack-dev | 01:54 | |
*** yaguang has joined #openstack-dev | 01:54 | |
*** browne has joined #openstack-dev | 01:56 | |
*** mrodden has quit IRC | 01:57 | |
*** RajeshMohan has quit IRC | 01:58 | |
*** thuc has quit IRC | 01:58 | |
*** RajeshMohan has joined #openstack-dev | 01:58 | |
*** yongli has joined #openstack-dev | 01:59 | |
*** rmk has quit IRC | 02:00 | |
*** topol has joined #openstack-dev | 02:00 | |
topol | dolphm, you there? | 02:01 |
*** browne has quit IRC | 02:01 | |
*** sn6i23a has quit IRC | 02:02 | |
*** bswartz has joined #openstack-dev | 02:02 | |
bswartz | señor | 02:02 |
*** thuc has joined #openstack-dev | 02:03 | |
bswartz | ¬_¬ wrong window... | 02:03 |
*** pcm_ has quit IRC | 02:04 | |
*** RajeshMohan has quit IRC | 02:05 | |
*** RajeshMohan has joined #openstack-dev | 02:05 | |
*** tsekiyama has joined #openstack-dev | 02:06 | |
topol | bswartz no problema mi amigo | 02:06 |
*** godara has joined #openstack-dev | 02:06 | |
*** thedodd has joined #openstack-dev | 02:06 | |
*** gongysh has joined #openstack-dev | 02:07 | |
*** thuc has quit IRC | 02:07 | |
*** pcm_ has joined #openstack-dev | 02:07 | |
*** browne has joined #openstack-dev | 02:08 | |
*** thuc has joined #openstack-dev | 02:08 | |
*** ramishra has joined #openstack-dev | 02:09 | |
*** browne has quit IRC | 02:09 | |
*** tsekiyama has quit IRC | 02:10 | |
*** kushal has joined #openstack-dev | 02:10 | |
*** marcoemorais1 has quit IRC | 02:11 | |
*** thuc has quit IRC | 02:12 | |
morganfainberg | thedodd, see i'm over here too ;) | 02:13 |
* morganfainberg goes back to lurk mode. | 02:13 | |
*** ramishra has quit IRC | 02:14 | |
*** dstanek has quit IRC | 02:14 | |
*** gokrokve has joined #openstack-dev | 02:14 | |
*** yamahata has quit IRC | 02:16 | |
stevemar | topol, late night coding hmmm | 02:16 |
*** cagrev has joined #openstack-dev | 02:16 | |
*** READ10 has quit IRC | 02:17 | |
*** begin has quit IRC | 02:17 | |
*** xarses has joined #openstack-dev | 02:17 | |
*** Mandell has quit IRC | 02:18 | |
*** godara has quit IRC | 02:18 | |
*** godara_ has joined #openstack-dev | 02:18 | |
topol | stevemar, hey just for the record my test data was generated from real curl examples. I did mix some v2 and v3 calls to generate but it was real results that came in from the curl calls. I'll send dolph my test script | 02:19 |
*** AlexF has joined #openstack-dev | 02:19 | |
*** clouded_tux_ has quit IRC | 02:19 | |
*** baoli has quit IRC | 02:19 | |
*** clouded_tux_ has joined #openstack-dev | 02:19 | |
*** jasdeepH has quit IRC | 02:21 | |
*** jasdeepH has joined #openstack-dev | 02:21 | |
*** sarob has joined #openstack-dev | 02:22 | |
*** godara_ has quit IRC | 02:22 | |
*** buzztroll has joined #openstack-dev | 02:23 | |
topol | stevemar, still helping kids with homework. wont start coding for about an hour | 02:23 |
*** markvoelker1 has joined #openstack-dev | 02:25 | |
*** e0ne has joined #openstack-dev | 02:27 | |
*** erkules_ has joined #openstack-dev | 02:27 | |
*** xchu has joined #openstack-dev | 02:27 | |
*** buzztroll has quit IRC | 02:28 | |
*** Edward-Zhang has joined #openstack-dev | 02:29 | |
*** galstrom is now known as galstrom_zzz | 02:29 | |
*** erkules has quit IRC | 02:29 | |
*** spzala has quit IRC | 02:30 | |
*** ysk has joined #openstack-dev | 02:30 | |
*** e0ne has quit IRC | 02:31 | |
*** neelashah1 has joined #openstack-dev | 02:32 | |
*** buzztroll has joined #openstack-dev | 02:32 | |
*** pcm_ has quit IRC | 02:33 | |
*** MaxV has quit IRC | 02:33 | |
*** gordc has quit IRC | 02:33 | |
*** neelashah has quit IRC | 02:34 | |
*** ctracey|away is now known as ctracey | 02:34 | |
*** sarob has quit IRC | 02:34 | |
*** sarob has joined #openstack-dev | 02:34 | |
*** thedodd has quit IRC | 02:35 | |
*** sarob has quit IRC | 02:39 | |
*** sarob has joined #openstack-dev | 02:41 | |
*** lbragstad has joined #openstack-dev | 02:41 | |
*** johnthetubaguy has joined #openstack-dev | 02:42 | |
*** ramishra has joined #openstack-dev | 02:45 | |
*** ramishra has quit IRC | 02:46 | |
*** alop has quit IRC | 02:48 | |
*** chandan_kumar has joined #openstack-dev | 02:48 | |
*** ssurana has joined #openstack-dev | 02:49 | |
*** morganfainberg is now known as morganfainberg_Z | 02:51 | |
*** ssurana has left #openstack-dev | 02:53 | |
*** ssurana has joined #openstack-dev | 02:53 | |
*** ssurana has left #openstack-dev | 02:53 | |
*** armax has quit IRC | 02:54 | |
*** chandan_kumar has quit IRC | 02:54 | |
*** alop has joined #openstack-dev | 02:56 | |
*** chandan_kumar has joined #openstack-dev | 02:56 | |
*** galstrom_zzz is now known as galstrom | 02:58 | |
*** bdpayne has joined #openstack-dev | 02:59 | |
*** novas0x2a|laptop has quit IRC | 03:00 | |
*** russell_h has quit IRC | 03:01 | |
*** sheeprine has quit IRC | 03:02 | |
*** mikal has quit IRC | 03:02 | |
*** bdpayne has quit IRC | 03:02 | |
*** mikal has joined #openstack-dev | 03:03 | |
*** sheeprine has joined #openstack-dev | 03:04 | |
*** MaxV has joined #openstack-dev | 03:04 | |
*** tjones has joined #openstack-dev | 03:04 | |
*** yuan has joined #openstack-dev | 03:04 | |
*** troytoman has quit IRC | 03:04 | |
*** chandan_kumar has quit IRC | 03:04 | |
*** kushal has quit IRC | 03:05 | |
jamielennox | ayoung: what happened to public=False on https://review.openstack.org/#/c/68548 | 03:05 |
*** pingveno has quit IRC | 03:05 | |
*** CaptTofu has quit IRC | 03:06 | |
ayoung | jamielennox, hrm | 03:06 |
*** angdraug has quit IRC | 03:06 | |
ayoung | musta got messed up in the rebase. There are too many patches in this series | 03:06 |
*** ramishra has joined #openstack-dev | 03:07 | |
*** troytoman has joined #openstack-dev | 03:07 | |
jamielennox | ayoung: ok, i hadn't gone back through the history i was just looking at the most recent one and tought the idea might have changed | 03:08 |
ayoung | nope. | 03:08 |
*** kbrierly has quit IRC | 03:08 | |
ayoung | jamielennox, so I was thinking that, on the compression thing, it would be good if all of the operations were reflected in the headers | 03:08 |
ayoung | something like | 03:08 |
*** russell_h has joined #openstack-dev | 03:08 | |
ayoung | "{json,cms,z,base64}" | 03:09 |
*** MaxV has quit IRC | 03:09 | |
jamielennox | ayoung: what does it give us? | 03:09 |
ayoung | then any document can be signed , and you know the content type and tools to use to trnasform it | 03:09 |
ayoung | jamielennox, it means that if you want to do something different, like, say, leave off base64... | 03:09 |
ayoung | "{json,cms,z}" | 03:09 |
ayoung | or use XML | 03:09 |
ayoung | "{xml,cms,z}" | 03:10 |
ayoung | or a differnt compresssion algo... | 03:10 |
ayoung | it does mean the header is not a fixed length | 03:10 |
jamielennox | i'm not sure it buys us anything - i don't see why anoyone would want to customize that | 03:10 |
jamielennox | and it means doing a lot more work on the decode of looking up transformations | 03:11 |
jamielennox | if i can ever figure out the pecan problems i like the idea of allowing signed docs via Accept: | 03:12 |
jamielennox | but we will never issue for example an XML token | 03:12 |
ayoung | I was thinking about signing other things, like revocation event lists | 03:12 |
*** buzztroll has quit IRC | 03:12 | |
ayoung | it just would map 1 to 1 with content types really cleanly, like | 03:12 |
*** 14WAB5IF8 has quit IRC | 03:13 | |
ayoung | application/json+cms+z+base64 | 03:13 |
jamielennox | hmm, so i think maybe and sort of | 03:13 |
*** dave_tucker is now known as dave_tucker_zzz | 03:13 | |
jamielennox | i don't think all that needs to go into the content type | 03:13 |
jamielennox | you can pass an X-Encrypt: true header for z | 03:14 |
*** taps has quit IRC | 03:14 | |
jamielennox | (i made the header name up) | 03:14 |
jamielennox | hmm, although i see the problem with that | 03:14 |
*** ramishra_ has joined #openstack-dev | 03:14 | |
ayoung | yeah | 03:15 |
ayoung | we can't really do that | 03:15 |
ayoung | the token will be encrypted, but the rest of the stream won't be | 03:15 |
jamielennox | ayoung: i think regarding tokens it doesn't matter | 03:15 |
*** troytoman is now known as troytoman-away | 03:15 | |
ayoung | actually it isnt X-Encrypt | 03:15 |
*** sarob has quit IRC | 03:16 | |
jamielennox | X-Compress | 03:16 |
ayoung | Content-Encoding: gzip | 03:16 |
jamielennox | damnit i've been confusing that all day | 03:16 |
ayoung | not an X | 03:16 |
*** sarob has joined #openstack-dev | 03:16 | |
ayoung | Accept-Encoding: gzip, deflate | 03:16 |
*** yamahata has joined #openstack-dev | 03:16 | |
jamielennox | yea, i just didn't know the header to use | 03:16 |
jamielennox | anyway for token it doesn't matter | 03:16 |
ayoung | right | 03:17 |
jamielennox | because all of this is information regarding the body of a message | 03:17 |
jamielennox | and a token is not transmitted in the body | 03:17 |
ayoung | and the problem with tokens is between the wsgi App and HTTPD | 03:17 |
jamielennox | but it doesn't so much matter because a token is just a blob | 03:18 |
*** henrynash has quit IRC | 03:18 | |
*** novas0x2a|laptop has joined #openstack-dev | 03:18 | |
*** ramishra has quit IRC | 03:18 | |
*** yjiang51 has joined #openstack-dev | 03:18 | |
jamielennox | so long as we know what we produced and how to undo that process nothing else needs to really care | 03:18 |
ayoung | jamielennox, right...so why not include all that info in the header? | 03:19 |
ayoung | I mean...I am not sure that doing the equivalent of "file" on a Base64 encoded blob would tell us anything. | 03:20 |
jamielennox | ayoung: so you mean the {...}MII.. | 03:20 |
ayoung | or what you get once you undo that | 03:20 |
ayoung | yeah... | 03:20 |
ayoung | Actually ,once it is comporessed it won't be MII | 03:20 |
ayoung | much shorter | 03:20 |
*** sarob has quit IRC | 03:20 | |
jamielennox | true, we've swapped ordering | 03:20 |
stevemar | jamielennox, whats the point of https://github.com/openstack/keystone/blob/master/keystone/tests/contrib/kds/fixture/__init__.py#L21 ? | 03:21 |
stevemar | is it used? | 03:21 |
*** sweston has quit IRC | 03:21 | |
jamielennox | ayoung: umm, i just don't know if it's something that people will ever want to customize | 03:21 |
*** yamahata has quit IRC | 03:21 | |
*** rcleere has joined #openstack-dev | 03:21 | |
jamielennox | stevemar: well i see what it does, why i did that over just importing each fixture individually i can't recall | 03:22 |
*** jnoller has joined #openstack-dev | 03:22 | |
stevemar | jamielennox, it's mucking up docs building, so, i might propose to remove it... | 03:22 |
stevemar | jamielennox, if the tests pass | 03:23 |
*** paragan has joined #openstack-dev | 03:23 | |
*** dims has quit IRC | 03:23 | |
jamielennox | stevemar: that's weird - that's a pattern that is used in a number of places and there is nothing really funny about that one | 03:23 |
stevemar | jamielennox, /me shrugs | 03:24 |
*** jecarey has quit IRC | 03:24 | |
*** dims has joined #openstack-dev | 03:24 | |
*** baoli has joined #openstack-dev | 03:25 | |
*** kushal has joined #openstack-dev | 03:26 | |
*** zhikunliu has joined #openstack-dev | 03:26 | |
jamielennox | ayoung: anyway, i don't see that we get any benefit from the {x+x+x+x} format as everyone just gets a blob - it just seems to add complexity to the decode | 03:27 |
jamielennox | also the {x+x+x} is outside the signed area so i guess it would be possible for someone to screw around with it but i can't see any way they could manipulate it to do something bad | 03:27 |
ayoung | jamielennox, so...the nice thing about this format is that there is nothing Keystone specific, and certainly not token specific. It gives us a geneirc way to hand around signed and comporessed data | 03:27 |
ayoung | only the signed part is signed. | 03:28 |
*** chandan_kumar has joined #openstack-dev | 03:29 | |
jamielennox | ayoung: do we need that? | 03:31 |
ayoung | jamielennox, well, I know gyee wants to continue the practice of signing the revocation list | 03:31 |
ayoung | now evets | 03:31 |
*** Ryan_Lane has joined #openstack-dev | 03:31 | |
ayoung | I could see it being a useful abstracting | 03:32 |
ayoung | abstraction | 03:32 |
jamielennox | hmm, that' s right | 03:32 |
jamielennox | with revocation signing though i don't see why we do half of that already | 03:33 |
ayoung | and...it seems more correct to just see what the operations are on the data anyway | 03:33 |
*** pradeep has joined #openstack-dev | 03:33 | |
jamielennox | if you want to get back a signed list you should Accept: x-cms (whatever that content type is) | 03:33 |
ayoung | jamielennox, thats the thing, the content type is more than just the signature | 03:34 |
*** jnoller has quit IRC | 03:34 | |
jamielennox | i'd prefer to ditch the XML interface over have it customizable | 03:34 |
ayoung | I mean, yes, compression and encryption can be done at the http layer | 03:34 |
jamielennox | brb | 03:34 |
ayoung | and if you don't need them, you can strip them out | 03:34 |
*** dims has quit IRC | 03:35 | |
*** baoli has quit IRC | 03:35 | |
*** dims has joined #openstack-dev | 03:36 | |
*** AlexF has quit IRC | 03:37 | |
*** doug_shelley66 has quit IRC | 03:37 | |
*** rodrigods has quit IRC | 03:38 | |
*** sweston has joined #openstack-dev | 03:39 | |
stevemar | lbragstad, https://review.openstack.org/#/c/72530/ | 03:40 |
*** rodrigods has joined #openstack-dev | 03:40 | |
*** rodrigods has quit IRC | 03:40 | |
*** rodrigods has joined #openstack-dev | 03:40 | |
stevemar | ayoung ^ if not in dad-mode | 03:40 |
*** Edward-Zhang has quit IRC | 03:40 | |
ayoung | stevemar, good to go | 03:41 |
*** byeager has joined #openstack-dev | 03:41 | |
*** sarob has joined #openstack-dev | 03:43 | |
*** Edward-Zhang has joined #openstack-dev | 03:44 | |
*** bdpayne has joined #openstack-dev | 03:44 | |
*** dims has quit IRC | 03:45 | |
jamielennox | ayoung: ok so theres nothing within CMS for content-type, i didn't think there was but worth checking | 03:45 |
ayoung | jamielennox, let the idea bake....I'm not moving on it until after the meeting tomorrowq | 03:46 |
*** dims has joined #openstack-dev | 03:46 | |
jamielennox | ayoung: yea, i have no objection i don't think other that "do we need it" cause it will bring some complexity | 03:46 |
ayoung | minute amount, with potentially large potential future operations | 03:46 |
ayoung | and since we need to change the format anyway | 03:47 |
ayoung | {cmsz} was relly just kindof off the cuff anyway | 03:47 |
*** praneshp has quit IRC | 03:47 | |
jamielennox | ayoung: i would just like some more info on these large future operations and whether they are wanted | 03:47 |
jamielennox | from the client side we have no means of dealing with that sort of thing | 03:47 |
*** buzztroll has joined #openstack-dev | 03:48 | |
jamielennox | obviously we could, but just what does it buy us | 03:48 |
*** flamebot has quit IRC | 03:49 | |
ayoung | jamielennox, what else needs to be confirmed across the network without a round trip? | 03:49 |
ayoung | Quota? | 03:49 |
*** sarob_ has joined #openstack-dev | 03:49 | |
*** sarob has quit IRC | 03:50 | |
*** sweston has quit IRC | 03:50 | |
*** flamebot has joined #openstack-dev | 03:50 | |
ayoung | jamielennox, I still don't have an easy way to extract the certificate information without running it through CMS again | 03:50 |
*** russell_h has quit IRC | 03:52 | |
*** russell_h has joined #openstack-dev | 03:52 | |
ayoung | ARGH...rebase mess up/// | 03:52 |
jamielennox | ayoung: signed vs headers are somewhat different though | 03:53 |
ayoung | yeah... | 03:53 |
*** galstrom is now known as galstrom_zzz | 03:53 | |
*** arnaud has quit IRC | 03:53 | |
jamielennox | anyway can be left for the meeting | 03:54 |
jamielennox | i don't think quota should be our problem | 03:54 |
*** arnaud__ has quit IRC | 03:54 | |
*** flamebot has quit IRC | 03:54 | |
*** dims has quit IRC | 03:55 | |
*** carl_baldwin has joined #openstack-dev | 03:55 | |
*** flamebot has joined #openstack-dev | 03:55 | |
jamielennox | ayoung: this is a very quick review if you have a moment: https://review.openstack.org/#/c/70634 | 03:56 |
*** dims has joined #openstack-dev | 03:56 | |
*** Edward-Zhang has quit IRC | 03:58 | |
*** RajeshMohan has quit IRC | 03:58 | |
*** sweston has joined #openstack-dev | 03:58 | |
*** buzztroll has quit IRC | 03:58 | |
*** RajeshMohan has joined #openstack-dev | 03:59 | |
*** otherwiseguy has joined #openstack-dev | 04:01 | |
stevemar | jamielennox, ahh, they should be wrapped in quotes: __all__ = ['SqliteDb', 'KvsDb'] | 04:01 |
jamielennox | stevemar: hmm, i'm pretty sure both work - i saw that method somewhere and it seemed to be more explicit | 04:02 |
*** buzztroll has joined #openstack-dev | 04:02 | |
jamielennox | guess i'll go back to quoting hen | 04:02 |
*** gokrokve has quit IRC | 04:05 | |
*** gokrokve has joined #openstack-dev | 04:05 | |
*** bdpayne has quit IRC | 04:06 | |
*** byeager has quit IRC | 04:06 | |
*** gokrokve has quit IRC | 04:10 | |
*** bhuvan has joined #openstack-dev | 04:10 | |
*** galstrom_zzz is now known as galstrom | 04:12 | |
*** buzztroll has quit IRC | 04:12 | |
*** ramishra_ has quit IRC | 04:12 | |
*** tjones has quit IRC | 04:13 | |
*** bdpayne has joined #openstack-dev | 04:14 | |
*** cagrev has quit IRC | 04:14 | |
kashyap | harlowja, (Not sure my previous message appeared, my proxy dropped) Thank you will try in a few. /me still learning the ropes of gerrit-workflow | 04:14 |
*** rraja has joined #openstack-dev | 04:15 | |
*** MaxV has joined #openstack-dev | 04:18 | |
*** yamahata has joined #openstack-dev | 04:19 | |
*** ayoung has quit IRC | 04:20 | |
*** rohitk has joined #openstack-dev | 04:21 | |
*** harlowja is now known as harlowja_away | 04:22 | |
*** MaxV has quit IRC | 04:23 | |
*** yamahata has quit IRC | 04:23 | |
*** ijw has quit IRC | 04:23 | |
*** ijw has joined #openstack-dev | 04:24 | |
*** bhuvan has quit IRC | 04:24 | |
*** gokrokve has joined #openstack-dev | 04:25 | |
*** cagrev has joined #openstack-dev | 04:27 | |
topol | morganfainberg, are you still lurking? | 04:28 |
*** ijw has quit IRC | 04:28 | |
*** cagrev has quit IRC | 04:30 | |
*** harlowja_away is now known as harlowja | 04:30 | |
*** buzztroll has joined #openstack-dev | 04:31 | |
*** belliott has quit IRC | 04:33 | |
*** igor_ has joined #openstack-dev | 04:35 | |
*** galstrom is now known as galstrom_zzz | 04:37 | |
*** belliott has joined #openstack-dev | 04:38 | |
*** praneshp has joined #openstack-dev | 04:38 | |
*** dims has quit IRC | 04:41 | |
*** buzztroll has quit IRC | 04:42 | |
*** johnthetubaguy has quit IRC | 04:42 | |
*** dims has joined #openstack-dev | 04:43 | |
*** yamahata has joined #openstack-dev | 04:45 | |
noorul | Is there any documentation on how to write keystone plugin outside of keystone repo? | 04:45 |
*** buzztroll has joined #openstack-dev | 04:46 | |
noorul | I see this http://docs.openstack.org/developer/keystone/extension_development.html | 04:48 |
noorul | but it explains how to add code in contrib directory. I am looking keeping this plugin outside of keystone soruce repo. | 04:48 |
*** johnthetubaguy has joined #openstack-dev | 04:49 | |
*** jaybuff has joined #openstack-dev | 04:51 | |
*** kushal has quit IRC | 04:53 | |
*** jaybuff1 has joined #openstack-dev | 04:54 | |
*** jaybuff has quit IRC | 04:54 | |
*** Edward-Zhang has joined #openstack-dev | 04:55 | |
stevemar | topol, he should be around | 04:55 |
topol | stevemar. no biggie. The context thing dolphm recommended did not work. It ends up mapping to the object class instead of the context dictionary. I copied the error and will put it in as a comment | 04:57 |
*** bhuvan has joined #openstack-dev | 04:59 | |
*** bdpayne has quit IRC | 04:59 | |
*** eharney has quit IRC | 05:02 | |
*** kushal has joined #openstack-dev | 05:03 | |
*** rohitk has quit IRC | 05:04 | |
*** sarob_ has quit IRC | 05:06 | |
*** AlexF has joined #openstack-dev | 05:06 | |
*** CaptTofu has joined #openstack-dev | 05:07 | |
*** sarob has joined #openstack-dev | 05:07 | |
*** bdpayne has joined #openstack-dev | 05:07 | |
*** crank has quit IRC | 05:07 | |
*** sarob_ has joined #openstack-dev | 05:08 | |
*** thuc has joined #openstack-dev | 05:08 | |
*** sarob_ has quit IRC | 05:09 | |
*** mriedem has joined #openstack-dev | 05:09 | |
*** aspiers has joined #openstack-dev | 05:09 | |
*** sarob_ has joined #openstack-dev | 05:09 | |
*** thuc_ has joined #openstack-dev | 05:10 | |
*** arosen has joined #openstack-dev | 05:10 | |
*** sumanthns has joined #openstack-dev | 05:10 | |
*** CaptTofu has quit IRC | 05:11 | |
*** sarob has quit IRC | 05:11 | |
*** thuc has quit IRC | 05:13 | |
*** sarob_ has quit IRC | 05:13 | |
*** crank has joined #openstack-dev | 05:14 | |
*** killer_prince has quit IRC | 05:14 | |
*** killer_prince has joined #openstack-dev | 05:14 | |
*** alop has quit IRC | 05:14 | |
stevemar | topol, almost done :P I got 1 review left in me | 05:15 |
*** jhesketh__ has quit IRC | 05:15 | |
*** chandan_kumar has quit IRC | 05:15 | |
topol | stevemar, I am going big or going home... I'm trying to cover few more cases beyond get_userId. Trying to handle username plus either domain name or id as well. | 05:16 |
*** chandan_kumar has joined #openstack-dev | 05:16 | |
*** haomai___ has quit IRC | 05:16 | |
topol | stevemar, I may need to update the v2 stuff as well. Isnt it possible in v2 you could get a user_id instead of user_name? I need to go look at the v2 API | 05:17 |
*** alop has joined #openstack-dev | 05:17 | |
topol | stevemar. I'll have something ready by tomorrow even if I have to code all night | 05:18 |
*** jecarey has joined #openstack-dev | 05:18 | |
*** buzztroll has quit IRC | 05:18 | |
*** sweston has quit IRC | 05:19 | |
stevemar | topol, yowza! i like it! Yes, you can have user_id in v2 as well i believe | 05:21 |
*** flamebot has quit IRC | 05:21 | |
*** flamebot has joined #openstack-dev | 05:22 | |
*** bdpayne has quit IRC | 05:22 | |
topol | stevemar, Thanks. I look at the v2 markup. I know you were willing to bail me out but I learn 10 times as much when I have to code stuff :-) | 05:23 |
topol | stevemar the spec even makes sense now :-) | 05:23 |
*** pradeep has quit IRC | 05:24 | |
stevemar | topol, yep, userid is valid for v2: https://github.com/openstack/keystone/blob/master/keystone/tests/test_auth.py#L37 | 05:25 |
*** bashok has joined #openstack-dev | 05:26 | |
topol | stevemar, thanks | 05:26 |
stevemar | topol and ... https://github.com/openstack/keystone/blob/master/keystone/tests/test_v3.py#L1060 i really should have linked these much earlier | 05:27 |
topol | stevemar, K thanks | 05:27 |
*** tkay has joined #openstack-dev | 05:29 | |
*** kushal has quit IRC | 05:31 | |
*** tkay has quit IRC | 05:31 | |
*** pradeep has joined #openstack-dev | 05:31 | |
*** bdpayne has joined #openstack-dev | 05:32 | |
*** tkay has joined #openstack-dev | 05:32 | |
*** tkay has quit IRC | 05:32 | |
*** doug_shelley66 has joined #openstack-dev | 05:34 | |
*** sarob has joined #openstack-dev | 05:34 | |
*** thuc_ has quit IRC | 05:35 | |
*** jaybuff1 has left #openstack-dev | 05:35 | |
*** thuc has joined #openstack-dev | 05:35 | |
*** dims has quit IRC | 05:35 | |
*** amcrn has quit IRC | 05:36 | |
*** dims has joined #openstack-dev | 05:37 | |
*** thuc_ has joined #openstack-dev | 05:37 | |
*** doug_shelley66 has quit IRC | 05:38 | |
*** thuc has quit IRC | 05:40 | |
*** nshaikh has joined #openstack-dev | 05:41 | |
*** mriedem has quit IRC | 05:41 | |
*** dims has quit IRC | 05:43 | |
*** thuc_ has quit IRC | 05:44 | |
*** aeperezt has quit IRC | 05:44 | |
*** dims has joined #openstack-dev | 05:44 | |
*** thuc has joined #openstack-dev | 05:45 | |
*** rohitk has joined #openstack-dev | 05:45 | |
*** yjiang51 has quit IRC | 05:48 | |
*** thuc has quit IRC | 05:49 | |
*** kushal has joined #openstack-dev | 05:50 | |
*** unicell has quit IRC | 05:51 | |
*** rdas has joined #openstack-dev | 05:52 | |
*** gokrokve has quit IRC | 05:54 | |
*** johnthetubaguy has quit IRC | 05:54 | |
*** unicell has joined #openstack-dev | 05:55 | |
*** buzztroll has joined #openstack-dev | 05:55 | |
*** unicell has quit IRC | 05:55 | |
*** buzztroll has quit IRC | 05:55 | |
*** buzztroll has joined #openstack-dev | 05:55 | |
*** unicell has joined #openstack-dev | 05:56 | |
*** jecarey has quit IRC | 05:56 | |
*** ctracey is now known as ctracey|away | 05:56 | |
*** alop has quit IRC | 05:57 | |
*** gokrokve has joined #openstack-dev | 05:57 | |
*** marcoemorais has joined #openstack-dev | 06:01 | |
*** marcoemorais has quit IRC | 06:01 | |
*** kushal has quit IRC | 06:03 | |
*** unicell has quit IRC | 06:04 | |
*** AlexF has quit IRC | 06:04 | |
*** sarob_ has joined #openstack-dev | 06:05 | |
*** unicell has joined #openstack-dev | 06:05 | |
*** unicell has quit IRC | 06:06 | |
*** unicell has joined #openstack-dev | 06:06 | |
*** rwsu has quit IRC | 06:07 | |
*** rwsu has joined #openstack-dev | 06:07 | |
*** sarob has quit IRC | 06:08 | |
*** bhuvan has quit IRC | 06:09 | |
*** neelashah1 has quit IRC | 06:10 | |
*** sweston has joined #openstack-dev | 06:11 | |
*** carl_baldwin has quit IRC | 06:11 | |
*** tkay has joined #openstack-dev | 06:12 | |
*** buzztroll has quit IRC | 06:12 | |
*** sarob_ has quit IRC | 06:12 | |
*** zaitcev has quit IRC | 06:14 | |
*** amcrn has joined #openstack-dev | 06:15 | |
*** tkay has quit IRC | 06:15 | |
*** amcrn_ has joined #openstack-dev | 06:16 | |
*** bdpayne has quit IRC | 06:17 | |
*** buzztroll has joined #openstack-dev | 06:18 | |
*** amcrn has quit IRC | 06:20 | |
*** RajeshMohan has quit IRC | 06:21 | |
*** RajeshMohan has joined #openstack-dev | 06:23 | |
*** bhuvan has joined #openstack-dev | 06:23 | |
*** killer_prince has quit IRC | 06:24 | |
*** rwsu has quit IRC | 06:25 | |
*** pingveno has joined #openstack-dev | 06:25 | |
*** alop has joined #openstack-dev | 06:27 | |
*** amcrn_ is now known as amcrn | 06:28 | |
*** buzztroll has quit IRC | 06:30 | |
*** DinaBelova_ is now known as DinaBelova | 06:31 | |
*** cadenzajon has joined #openstack-dev | 06:33 | |
*** harlowja is now known as harlowja_away | 06:33 | |
*** rraja has quit IRC | 06:34 | |
*** denis_makogon has joined #openstack-dev | 06:36 | |
*** cadenzajon has quit IRC | 06:37 | |
*** rwsu has joined #openstack-dev | 06:38 | |
*** saju_m has joined #openstack-dev | 06:38 | |
*** coolsvap has joined #openstack-dev | 06:40 | |
*** unicell has quit IRC | 06:42 | |
*** kushal has joined #openstack-dev | 06:43 | |
*** saju_m has quit IRC | 06:43 | |
*** buzztroll has joined #openstack-dev | 06:43 | |
*** abhirc_ has quit IRC | 06:44 | |
*** alop has quit IRC | 06:45 | |
*** saju_m has joined #openstack-dev | 06:50 | |
*** rraja has joined #openstack-dev | 06:51 | |
*** saju_m has quit IRC | 06:51 | |
*** saju_m has joined #openstack-dev | 06:51 | |
*** hdd_ has quit IRC | 06:51 | |
*** saju_m has quit IRC | 06:52 | |
*** saju_m has joined #openstack-dev | 06:52 | |
*** yolanda has quit IRC | 06:57 | |
*** kdas_ has joined #openstack-dev | 07:01 | |
*** kushal has quit IRC | 07:02 | |
*** mkollaro has joined #openstack-dev | 07:03 | |
*** sumanthns has quit IRC | 07:04 | |
*** sarob has joined #openstack-dev | 07:05 | |
*** jhesketh has quit IRC | 07:06 | |
*** CaptTofu has joined #openstack-dev | 07:07 | |
*** kdas_ has quit IRC | 07:07 | |
*** sushils has joined #openstack-dev | 07:08 | |
*** Drankis has joined #openstack-dev | 07:08 | |
*** yolanda has joined #openstack-dev | 07:09 | |
*** rohitk has quit IRC | 07:11 | |
*** CaptTofu has quit IRC | 07:12 | |
*** doude_ has joined #openstack-dev | 07:13 | |
*** xqueralt has joined #openstack-dev | 07:13 | |
*** doude has quit IRC | 07:13 | |
*** mrunge has joined #openstack-dev | 07:14 | |
*** omachace has joined #openstack-dev | 07:15 | |
*** eglynn has quit IRC | 07:15 | |
*** yamahata has quit IRC | 07:15 | |
*** sweston is now known as _sweston | 07:16 | |
*** avishay has joined #openstack-dev | 07:16 | |
*** saju_m has quit IRC | 07:16 | |
*** alop has joined #openstack-dev | 07:16 | |
*** sushils has quit IRC | 07:18 | |
*** gyee has quit IRC | 07:18 | |
*** jhesketh has joined #openstack-dev | 07:19 | |
*** yamahata has joined #openstack-dev | 07:20 | |
*** buzztroll has quit IRC | 07:20 | |
*** arosen has quit IRC | 07:21 | |
marun | lifeless: ping | 07:22 |
*** yongli has quit IRC | 07:22 | |
*** reed has joined #openstack-dev | 07:22 | |
*** cfriesen has quit IRC | 07:23 | |
*** vartom1111111119 has joined #openstack-dev | 07:23 | |
*** dims has quit IRC | 07:24 | |
*** kushal has joined #openstack-dev | 07:24 | |
*** dims has joined #openstack-dev | 07:25 | |
*** rohitk has joined #openstack-dev | 07:27 | |
*** topol has quit IRC | 07:28 | |
*** kushal has quit IRC | 07:30 | |
*** DinaBelova is now known as DinaBelova_ | 07:30 | |
*** negronjl has quit IRC | 07:31 | |
*** dims has quit IRC | 07:32 | |
*** negronjl has joined #openstack-dev | 07:32 | |
*** Guest83278 has joined #openstack-dev | 07:32 | |
*** dims has joined #openstack-dev | 07:32 | |
*** avishayb has joined #openstack-dev | 07:33 | |
*** rraja has quit IRC | 07:33 | |
*** sarob has quit IRC | 07:33 | |
*** e0ne has joined #openstack-dev | 07:34 | |
*** dmsimard has joined #openstack-dev | 07:34 | |
*** viktors has joined #openstack-dev | 07:34 | |
*** e0ne has quit IRC | 07:35 | |
*** saju_m has joined #openstack-dev | 07:37 | |
*** markvoelker1 has quit IRC | 07:37 | |
*** Guest83278 has quit IRC | 07:37 | |
*** dmsimard1 has joined #openstack-dev | 07:37 | |
*** belmoreira has joined #openstack-dev | 07:38 | |
*** dmsimard has quit IRC | 07:38 | |
*** _sweston is now known as sweston | 07:39 | |
*** negronjl has quit IRC | 07:40 | |
*** d0ugal has joined #openstack-dev | 07:41 | |
*** d0ugal has quit IRC | 07:41 | |
*** d0ugal has joined #openstack-dev | 07:41 | |
*** cnesa has quit IRC | 07:42 | |
*** dims has quit IRC | 07:42 | |
*** dims has joined #openstack-dev | 07:43 | |
*** dmsimard has joined #openstack-dev | 07:44 | |
*** jhesketh has quit IRC | 07:45 | |
*** eglynn has joined #openstack-dev | 07:45 | |
*** dmsimard1 has quit IRC | 07:45 | |
*** salv-orlando has quit IRC | 07:46 | |
*** zigo has joined #openstack-dev | 07:47 | |
*** MaxV has joined #openstack-dev | 07:48 | |
*** jprovazn has joined #openstack-dev | 07:50 | |
*** amuller has joined #openstack-dev | 07:51 | |
*** saju_m has quit IRC | 07:52 | |
*** buzztroll has joined #openstack-dev | 07:53 | |
*** MaxV has quit IRC | 07:55 | |
*** jamieh has joined #openstack-dev | 07:57 | |
*** buzztroll has quit IRC | 07:58 | |
*** sushils has joined #openstack-dev | 07:58 | |
*** bauzas has joined #openstack-dev | 08:01 | |
*** rdas has quit IRC | 08:02 | |
*** denis_makogon has quit IRC | 08:04 | |
*** flaper87|afk is now known as flaper87 | 08:04 | |
*** sarob has joined #openstack-dev | 08:05 | |
*** killer_prince has joined #openstack-dev | 08:06 | |
*** avishayb has quit IRC | 08:07 | |
*** romcheg1 has joined #openstack-dev | 08:07 | |
*** sarob has quit IRC | 08:10 | |
*** evgenyf has joined #openstack-dev | 08:10 | |
*** negronjl has joined #openstack-dev | 08:12 | |
*** xga has joined #openstack-dev | 08:13 | |
*** vartom1111111111 has joined #openstack-dev | 08:14 | |
*** vartom1111111119 has quit IRC | 08:14 | |
*** buzztroll has joined #openstack-dev | 08:17 | |
*** kbrierly has joined #openstack-dev | 08:17 | |
*** zoresvit has joined #openstack-dev | 08:21 | |
*** yeylon_ has joined #openstack-dev | 08:22 | |
*** bhuvan has quit IRC | 08:22 | |
*** florentflament has joined #openstack-dev | 08:23 | |
*** mrunge has quit IRC | 08:23 | |
*** zoresvit has quit IRC | 08:23 | |
*** zoresvit has joined #openstack-dev | 08:23 | |
*** mrunge has joined #openstack-dev | 08:23 | |
*** irenab has joined #openstack-dev | 08:24 | |
*** sushils has quit IRC | 08:24 | |
*** bhuvan has joined #openstack-dev | 08:24 | |
*** marekd|away is now known as marekd | 08:24 | |
*** corXi has joined #openstack-dev | 08:24 | |
*** sushils has joined #openstack-dev | 08:25 | |
*** yeylon__ has quit IRC | 08:25 | |
*** buzztroll has quit IRC | 08:27 | |
*** e0ne has joined #openstack-dev | 08:27 | |
*** tkammer has joined #openstack-dev | 08:28 | |
*** jtomasek has joined #openstack-dev | 08:28 | |
*** I159 has joined #openstack-dev | 08:28 | |
*** zzelle has joined #openstack-dev | 08:29 | |
*** mmagr has joined #openstack-dev | 08:29 | |
*** bhuvan has quit IRC | 08:30 | |
*** sumanthns has joined #openstack-dev | 08:30 | |
*** bhuvan has joined #openstack-dev | 08:31 | |
*** DinaBelova_ is now known as DinaBelova | 08:32 | |
lifeless | marun: pong | 08:32 |
marun | lifeless: hi there | 08:33 |
marun | lifeless: this may be an exercise in 'ducky' | 08:33 |
marun | lifeless: https://review.openstack.org/#/c/72585 | 08:34 |
*** killer_prince has quit IRC | 08:34 | |
marun | lifeless: There are 2 scenarios in the test in test_plugin_api in this review | 08:34 |
marun | lifeless: I swear I was running them both at one point, but now I can't get them to run with testtools at all :( | 08:34 |
*** jhesketh has joined #openstack-dev | 08:35 | |
*** killer_prince has joined #openstack-dev | 08:35 | |
*** gcha has joined #openstack-dev | 08:35 | |
*** eglynn has quit IRC | 08:36 | |
*** thouveng has joined #openstack-dev | 08:36 | |
*** MaxV has joined #openstack-dev | 08:37 | |
*** jgallard has joined #openstack-dev | 08:38 | |
*** buzztroll has joined #openstack-dev | 08:39 | |
*** sahid has joined #openstack-dev | 08:39 | |
lifeless | marun: will check in a bit, sorry elocal | 08:40 |
marun | lifeless: no rush, i'm going to hit the hay now. | 08:40 |
*** ifarkas has joined #openstack-dev | 08:41 | |
*** giulivo has joined #openstack-dev | 08:43 | |
*** xgsa has joined #openstack-dev | 08:43 | |
*** nacim has joined #openstack-dev | 08:44 | |
*** pschaef has joined #openstack-dev | 08:46 | |
*** shardy_afk is now known as shardy | 08:48 | |
*** safchain has joined #openstack-dev | 08:49 | |
*** e0ne_ has joined #openstack-dev | 08:49 | |
*** buzztroll has quit IRC | 08:50 | |
*** mindpixel has joined #openstack-dev | 08:51 | |
*** saju_m has joined #openstack-dev | 08:51 | |
*** rraja has joined #openstack-dev | 08:51 | |
*** jordanP has joined #openstack-dev | 08:52 | |
*** e0ne has quit IRC | 08:53 | |
marekd | stevemar: you still awake? :0 | 08:54 |
*** dtantsur has joined #openstack-dev | 08:54 | |
*** ygbo has joined #openstack-dev | 08:56 | |
*** psedlak has quit IRC | 08:56 | |
*** mmagr has quit IRC | 08:56 | |
*** rdas has joined #openstack-dev | 08:57 | |
*** gokrokve has quit IRC | 08:57 | |
*** mmagr has joined #openstack-dev | 08:57 | |
*** kushal has joined #openstack-dev | 08:57 | |
*** psedlak has joined #openstack-dev | 08:58 | |
*** jistr has joined #openstack-dev | 08:58 | |
*** aditirav has joined #openstack-dev | 08:59 | |
*** markmc has joined #openstack-dev | 09:00 | |
*** sergmelikyan has joined #openstack-dev | 09:00 | |
*** jpich has joined #openstack-dev | 09:01 | |
*** bhuvan has quit IRC | 09:03 | |
*** yassine has joined #openstack-dev | 09:03 | |
*** bhuvan has joined #openstack-dev | 09:04 | |
*** sarob has joined #openstack-dev | 09:05 | |
*** yamahata has quit IRC | 09:06 | |
*** mbernacc has joined #openstack-dev | 09:06 | |
*** yamahata has joined #openstack-dev | 09:07 | |
*** CaptTofu has joined #openstack-dev | 09:08 | |
*** bhuvan has quit IRC | 09:09 | |
*** sarob has quit IRC | 09:10 | |
*** eglynn has joined #openstack-dev | 09:11 | |
*** bhuvan has joined #openstack-dev | 09:11 | |
*** jcoufal has joined #openstack-dev | 09:12 | |
*** DinaBelova is now known as DinaBelova_ | 09:13 | |
*** CaptTofu has quit IRC | 09:13 | |
*** ramishra has joined #openstack-dev | 09:19 | |
*** pixelb has joined #openstack-dev | 09:20 | |
lifeless | marun: ok, tomorrow then :) | 09:20 |
*** afazekas has joined #openstack-dev | 09:21 | |
*** athomas has joined #openstack-dev | 09:22 | |
*** buzztroll has joined #openstack-dev | 09:24 | |
*** DinaBelova_ is now known as DinaBelova | 09:24 | |
*** rossella_s has joined #openstack-dev | 09:24 | |
*** afazekas has quit IRC | 09:25 | |
*** zhikunliu has quit IRC | 09:27 | |
*** nmagnezi has joined #openstack-dev | 09:27 | |
*** danpb has joined #openstack-dev | 09:28 | |
*** buzztroll has quit IRC | 09:28 | |
*** mkollaro has quit IRC | 09:30 | |
*** gokrokve has joined #openstack-dev | 09:33 | |
*** lucasagomes has joined #openstack-dev | 09:33 | |
*** stevemar has quit IRC | 09:33 | |
*** jp_at_hp has joined #openstack-dev | 09:35 | |
*** jp_at_hp has quit IRC | 09:35 | |
*** jp_at_hp has joined #openstack-dev | 09:35 | |
*** gokrokve_ has joined #openstack-dev | 09:35 | |
*** coolsvap has quit IRC | 09:36 | |
*** boris-42_ has quit IRC | 09:36 | |
*** praneshp has quit IRC | 09:37 | |
*** abk has joined #openstack-dev | 09:37 | |
*** gokrokve has quit IRC | 09:38 | |
*** gokrokve_ has quit IRC | 09:39 | |
*** mkollaro has joined #openstack-dev | 09:41 | |
*** cdub has quit IRC | 09:44 | |
*** cdub has joined #openstack-dev | 09:45 | |
*** Edward-Zhang has quit IRC | 09:49 | |
*** bhuvan has quit IRC | 09:52 | |
*** bhuvan_ has joined #openstack-dev | 09:52 | |
*** reed has quit IRC | 09:58 | |
*** henrynash has joined #openstack-dev | 10:02 | |
*** DinaBelova is now known as DinaBelova_ | 10:03 | |
*** sarob has joined #openstack-dev | 10:05 | |
*** xga has quit IRC | 10:05 | |
*** xga has joined #openstack-dev | 10:06 | |
*** lazy_prince has joined #openstack-dev | 10:08 | |
*** sarob has quit IRC | 10:10 | |
*** xuhanp has quit IRC | 10:12 | |
*** yeylon has joined #openstack-dev | 10:13 | |
*** xchu has quit IRC | 10:13 | |
*** iartarisi has joined #openstack-dev | 10:14 | |
*** zzelle has quit IRC | 10:15 | |
*** yeylon_ has quit IRC | 10:16 | |
*** yeylon has quit IRC | 10:17 | |
*** DinaBelova_ is now known as DinaBelova | 10:19 | |
*** otherwiseguy has quit IRC | 10:19 | |
*** vartom1111111111 has quit IRC | 10:19 | |
*** bvandenh has joined #openstack-dev | 10:19 | |
*** evgenyf has quit IRC | 10:21 | |
*** buzztroll has joined #openstack-dev | 10:23 | |
*** kris_h has joined #openstack-dev | 10:24 | |
*** saju_m has quit IRC | 10:25 | |
*** rohitk has quit IRC | 10:26 | |
*** saju_m has joined #openstack-dev | 10:26 | |
*** zoresvit has quit IRC | 10:27 | |
*** gongysh has quit IRC | 10:27 | |
*** abk has quit IRC | 10:27 | |
*** buzztroll has quit IRC | 10:28 | |
*** tris has joined #openstack-dev | 10:31 | |
*** yeylon has joined #openstack-dev | 10:33 | |
*** paragan has quit IRC | 10:34 | |
*** gokrokve has joined #openstack-dev | 10:34 | |
*** evgenyf has joined #openstack-dev | 10:36 | |
*** neoXsys has joined #openstack-dev | 10:36 | |
*** gokrokve has quit IRC | 10:39 | |
*** bhuvan_ has quit IRC | 10:39 | |
*** relaxdiego has quit IRC | 10:42 | |
*** bhuvan has joined #openstack-dev | 10:44 | |
*** max_lobur_afk is now known as max_lobur | 10:46 | |
*** rfolco has joined #openstack-dev | 10:48 | |
*** sumanthns has quit IRC | 10:48 | |
*** aditirav has quit IRC | 10:48 | |
*** sumanthns has joined #openstack-dev | 10:48 | |
*** aditirav has joined #openstack-dev | 10:48 | |
*** lazy_prince has quit IRC | 10:50 | |
*** xingchao has quit IRC | 10:53 | |
*** yaguang has quit IRC | 10:54 | |
*** qba73 has joined #openstack-dev | 10:55 | |
*** kolesovdv has joined #openstack-dev | 10:55 | |
*** yassine has quit IRC | 10:56 | |
*** tdruiva has quit IRC | 10:57 | |
*** CaptTofu has joined #openstack-dev | 10:57 | |
*** ArxCruz has joined #openstack-dev | 11:00 | |
*** CaptTofu has quit IRC | 11:02 | |
*** sarob has joined #openstack-dev | 11:05 | |
*** reed has joined #openstack-dev | 11:06 | |
*** bhuvan has quit IRC | 11:08 | |
*** pcm_ has joined #openstack-dev | 11:08 | |
*** bhuvan has joined #openstack-dev | 11:08 | |
*** Alexei_987 has quit IRC | 11:10 | |
*** pcm_ has quit IRC | 11:10 | |
*** sarob has quit IRC | 11:10 | |
*** mgoddard_ has joined #openstack-dev | 11:10 | |
*** pcm_ has joined #openstack-dev | 11:10 | |
*** nmagnezi has quit IRC | 11:10 | |
*** reed has quit IRC | 11:11 | |
*** gszasz has joined #openstack-dev | 11:11 | |
*** ArxCruz has quit IRC | 11:14 | |
*** boris-42_ has joined #openstack-dev | 11:16 | |
*** xga has quit IRC | 11:17 | |
*** xga has joined #openstack-dev | 11:18 | |
*** e0ne_ has quit IRC | 11:19 | |
*** jang has quit IRC | 11:19 | |
*** huats__ has joined #openstack-dev | 11:20 | |
*** jang has joined #openstack-dev | 11:20 | |
*** huats has quit IRC | 11:21 | |
*** tristanC has quit IRC | 11:21 | |
*** tristanC has joined #openstack-dev | 11:21 | |
*** mgoddard_ is now known as mgoddard | 11:21 | |
*** tristanC has quit IRC | 11:22 | |
*** tristanC has joined #openstack-dev | 11:22 | |
*** kris_h has quit IRC | 11:23 | |
*** buzztroll has joined #openstack-dev | 11:24 | |
*** alexpilotti has joined #openstack-dev | 11:26 | |
*** tdruiva has joined #openstack-dev | 11:27 | |
*** RajeshMohan has quit IRC | 11:27 | |
*** buzztroll has quit IRC | 11:27 | |
*** RajeshMohan has joined #openstack-dev | 11:28 | |
*** pradeep1 has joined #openstack-dev | 11:28 | |
*** pradeep has quit IRC | 11:29 | |
*** yeylon has quit IRC | 11:30 | |
*** amuller_ has joined #openstack-dev | 11:30 | |
*** amuller has quit IRC | 11:33 | |
*** gokrokve has joined #openstack-dev | 11:34 | |
*** tdruiva has quit IRC | 11:36 | |
*** cnesa has joined #openstack-dev | 11:38 | |
*** DinaBelova has quit IRC | 11:39 | |
*** gokrokve has quit IRC | 11:39 | |
*** DinaBelova has joined #openstack-dev | 11:39 | |
*** bvandenh has quit IRC | 11:39 | |
*** vladan has quit IRC | 11:40 | |
*** vladikr has joined #openstack-dev | 11:40 | |
*** vladan has joined #openstack-dev | 11:42 | |
*** evgenyf has quit IRC | 11:43 | |
*** vladan has quit IRC | 11:47 | |
*** ArxCruz has joined #openstack-dev | 11:48 | |
*** romcheg1 has quit IRC | 11:48 | |
*** vkmc has joined #openstack-dev | 11:49 | |
*** vkmc has quit IRC | 11:49 | |
*** vkmc has joined #openstack-dev | 11:49 | |
*** vladan has joined #openstack-dev | 11:49 | |
*** pradeep has joined #openstack-dev | 11:50 | |
*** alex_xu has quit IRC | 11:50 | |
*** NikitaKonovalov_ has quit IRC | 11:50 | |
*** e0ne has joined #openstack-dev | 11:50 | |
*** pradeep1 has quit IRC | 11:51 | |
*** SergeyLukjanov has quit IRC | 11:51 | |
*** lazy_prince has joined #openstack-dev | 11:52 | |
*** bvandenh has joined #openstack-dev | 11:52 | |
*** mrunge has quit IRC | 11:52 | |
*** jordanP has quit IRC | 11:52 | |
*** NikitaKonovalov_ has joined #openstack-dev | 11:54 | |
*** NikitaKonovalov_ is now known as NikitaKonovalov | 11:54 | |
*** SergeyLukjanov has joined #openstack-dev | 11:55 | |
*** nmagnezi has joined #openstack-dev | 11:58 | |
*** e0ne_ has joined #openstack-dev | 11:59 | |
*** yamahata has quit IRC | 12:02 | |
*** d0ugal has quit IRC | 12:03 | |
*** e0ne has quit IRC | 12:03 | |
*** romcheg1 has joined #openstack-dev | 12:04 | |
*** d0ugal has joined #openstack-dev | 12:04 | |
*** d0ugal has quit IRC | 12:04 | |
*** d0ugal has joined #openstack-dev | 12:04 | |
*** sarob has joined #openstack-dev | 12:05 | |
*** rohitk has joined #openstack-dev | 12:06 | |
*** mrunge has joined #openstack-dev | 12:07 | |
*** gcha has quit IRC | 12:07 | |
*** doug_shelley66 has joined #openstack-dev | 12:07 | |
*** Alexei_987 has joined #openstack-dev | 12:07 | |
*** nmagnezi has quit IRC | 12:09 | |
*** paragan has joined #openstack-dev | 12:10 | |
*** sarob has quit IRC | 12:10 | |
*** irenab has quit IRC | 12:11 | |
*** yassine has joined #openstack-dev | 12:11 | |
*** raildo has quit IRC | 12:12 | |
*** pschaef has quit IRC | 12:14 | |
*** kolesovdv has quit IRC | 12:17 | |
*** yeylon has joined #openstack-dev | 12:18 | |
*** bhuvan has quit IRC | 12:19 | |
*** vladikr has quit IRC | 12:19 | |
*** reed has joined #openstack-dev | 12:19 | |
*** avishay has quit IRC | 12:22 | |
*** tserong has quit IRC | 12:22 | |
*** rraja has quit IRC | 12:22 | |
*** ala_ has joined #openstack-dev | 12:22 | |
*** tserong has joined #openstack-dev | 12:22 | |
*** buzztroll has joined #openstack-dev | 12:23 | |
*** jgallard has quit IRC | 12:23 | |
*** reed has quit IRC | 12:24 | |
*** bhuvan has joined #openstack-dev | 12:25 | |
*** nmagnezi has joined #openstack-dev | 12:25 | |
*** sahid has quit IRC | 12:25 | |
*** ala has quit IRC | 12:26 | |
*** kolesovdv has joined #openstack-dev | 12:26 | |
*** buzztroll has quit IRC | 12:28 | |
*** sahid has joined #openstack-dev | 12:28 | |
*** eglynn is now known as eglynn-lunch | 12:29 | |
*** nshaikh has quit IRC | 12:30 | |
*** lucasagomes is now known as lucas-hungry | 12:30 | |
*** aditirav has quit IRC | 12:32 | |
*** henrynash has quit IRC | 12:32 | |
*** gokrokve has joined #openstack-dev | 12:34 | |
*** FunnyLookinHat has joined #openstack-dev | 12:35 | |
*** FunnyLookinHat has joined #openstack-dev | 12:35 | |
*** ttx has quit IRC | 12:35 | |
*** neoXsys has quit IRC | 12:35 | |
*** avishay has joined #openstack-dev | 12:36 | |
*** amuller_ has quit IRC | 12:37 | |
*** reed has joined #openstack-dev | 12:38 | |
*** amuller__ has joined #openstack-dev | 12:38 | |
*** amuller__ is now known as amuller | 12:38 | |
*** gokrokve has quit IRC | 12:39 | |
*** IanGovett has joined #openstack-dev | 12:40 | |
*** gnorth has joined #openstack-dev | 12:40 | |
*** venkatesh has joined #openstack-dev | 12:41 | |
*** drewlander has joined #openstack-dev | 12:42 | |
*** bhuvan has quit IRC | 12:43 | |
*** reed_ has joined #openstack-dev | 12:44 | |
*** zul has joined #openstack-dev | 12:45 | |
*** glenng has joined #openstack-dev | 12:46 | |
*** arosen has joined #openstack-dev | 12:47 | |
*** reed has quit IRC | 12:47 | |
*** avishay has quit IRC | 12:47 | |
*** yamahata has joined #openstack-dev | 12:48 | |
*** glenng1 has joined #openstack-dev | 12:49 | |
*** sumanthns has quit IRC | 12:51 | |
*** glenng has quit IRC | 12:51 | |
*** vladan has quit IRC | 12:52 | |
*** evgenyf has joined #openstack-dev | 12:53 | |
*** yamahata has quit IRC | 12:54 | |
*** vladan has joined #openstack-dev | 12:54 | |
*** jhesketh has quit IRC | 12:54 | |
*** irenab has joined #openstack-dev | 12:54 | |
*** yeylon_ has joined #openstack-dev | 12:54 | |
*** tmclaugh[work] has joined #openstack-dev | 12:55 | |
*** baoli has joined #openstack-dev | 12:56 | |
*** reed__ has joined #openstack-dev | 12:56 | |
*** Sumeniac has quit IRC | 12:57 | |
*** jgallard has joined #openstack-dev | 12:57 | |
*** yeylon has quit IRC | 12:57 | |
*** Sumeniac has joined #openstack-dev | 12:58 | |
*** gszasz has quit IRC | 12:58 | |
*** ttx_ has joined #openstack-dev | 12:58 | |
*** reed_ has quit IRC | 13:00 | |
*** reed__ has quit IRC | 13:01 | |
*** kushal has quit IRC | 13:01 | |
*** avishay has joined #openstack-dev | 13:02 | |
*** tdruiva has joined #openstack-dev | 13:02 | |
*** markmcclain has joined #openstack-dev | 13:02 | |
*** mkollaro has quit IRC | 13:03 | |
*** neelashah has joined #openstack-dev | 13:03 | |
*** heyongli has joined #openstack-dev | 13:04 | |
*** nmagnezi has quit IRC | 13:05 | |
*** xga has quit IRC | 13:05 | |
*** xga_ has joined #openstack-dev | 13:05 | |
*** sarob has joined #openstack-dev | 13:05 | |
*** mkollaro has joined #openstack-dev | 13:06 | |
*** xga_ has quit IRC | 13:07 | |
*** xga_ has joined #openstack-dev | 13:07 | |
*** mlegault has joined #openstack-dev | 13:08 | |
*** rcrit has joined #openstack-dev | 13:08 | |
*** aeperezt has joined #openstack-dev | 13:08 | |
*** cnesa has quit IRC | 13:09 | |
*** gcha has joined #openstack-dev | 13:09 | |
*** tkammer has quit IRC | 13:10 | |
*** sgordon has joined #openstack-dev | 13:10 | |
*** sgordon has joined #openstack-dev | 13:10 | |
*** sarob has quit IRC | 13:10 | |
*** zzelle has joined #openstack-dev | 13:11 | |
*** henrynash has joined #openstack-dev | 13:11 | |
*** nmagnezi has joined #openstack-dev | 13:12 | |
*** xga_ has quit IRC | 13:12 | |
*** rraja has joined #openstack-dev | 13:13 | |
*** xga_ has joined #openstack-dev | 13:13 | |
*** yeylon_ has quit IRC | 13:14 | |
*** henrynash has quit IRC | 13:14 | |
*** yamahata has joined #openstack-dev | 13:20 | |
*** mrunge has quit IRC | 13:20 | |
*** gszasz has joined #openstack-dev | 13:21 | |
*** venkatesh has quit IRC | 13:22 | |
*** tkammer has joined #openstack-dev | 13:22 | |
*** buzztroll has joined #openstack-dev | 13:23 | |
*** ramishra has quit IRC | 13:23 | |
*** dstanek has joined #openstack-dev | 13:24 | |
*** bvandenh has quit IRC | 13:24 | |
*** rfolco has quit IRC | 13:25 | |
*** jdob has joined #openstack-dev | 13:26 | |
*** buzztroll has quit IRC | 13:28 | |
*** gordc has joined #openstack-dev | 13:28 | |
*** aveiga has joined #openstack-dev | 13:29 | |
*** yeylon_ has joined #openstack-dev | 13:30 | |
*** bvandenh has joined #openstack-dev | 13:31 | |
*** bvandenh has quit IRC | 13:33 | |
*** jordanP has joined #openstack-dev | 13:34 | |
*** gokrokve has joined #openstack-dev | 13:34 | |
*** kushal has joined #openstack-dev | 13:35 | |
*** xga has joined #openstack-dev | 13:35 | |
*** hdd_ has joined #openstack-dev | 13:36 | |
*** gokrokve_ has joined #openstack-dev | 13:36 | |
*** lbragstad has quit IRC | 13:36 | |
*** thomasem has joined #openstack-dev | 13:38 | |
*** xga_ has quit IRC | 13:38 | |
*** gokrokve has quit IRC | 13:39 | |
*** vladikr has joined #openstack-dev | 13:39 | |
*** schwicht has joined #openstack-dev | 13:40 | |
*** galstrom_zzz is now known as galstrom | 13:40 | |
*** gokrokve_ has quit IRC | 13:41 | |
*** xingchao has joined #openstack-dev | 13:42 | |
*** haomaiwa_ has joined #openstack-dev | 13:43 | |
*** lucas-hungry is now known as lucasagomes | 13:44 | |
*** CaptTofu has joined #openstack-dev | 13:44 | |
*** aditirav has joined #openstack-dev | 13:45 | |
*** aditirav has quit IRC | 13:45 | |
*** eharney has joined #openstack-dev | 13:46 | |
*** aditirav has joined #openstack-dev | 13:46 | |
*** topol has joined #openstack-dev | 13:49 | |
*** pradeep has quit IRC | 13:50 | |
*** haomai___ has joined #openstack-dev | 13:50 | |
*** henrynash has joined #openstack-dev | 13:51 | |
*** achampion has quit IRC | 13:51 | |
*** ramishra has joined #openstack-dev | 13:52 | |
*** noslzzp has joined #openstack-dev | 13:52 | |
*** tdruiva has quit IRC | 13:52 | |
*** haomaiwa_ has quit IRC | 13:53 | |
*** joesavak has joined #openstack-dev | 13:53 | |
*** zul has quit IRC | 13:53 | |
*** pradeep has joined #openstack-dev | 13:54 | |
*** mkollaro1 has joined #openstack-dev | 13:55 | |
*** mkollaro has quit IRC | 13:55 | |
*** ramishra_ has joined #openstack-dev | 13:55 | |
*** alex_xu has joined #openstack-dev | 13:57 | |
*** mriedem has joined #openstack-dev | 13:57 | |
*** ramishra has quit IRC | 13:58 | |
*** ramishra has joined #openstack-dev | 13:59 | |
*** heyongli has quit IRC | 14:00 | |
*** jmckind has joined #openstack-dev | 14:01 | |
*** gszasz has quit IRC | 14:01 | |
*** otherwiseguy has joined #openstack-dev | 14:01 | |
*** dprince has joined #openstack-dev | 14:02 | |
*** ramishra_ has quit IRC | 14:02 | |
*** rdas has quit IRC | 14:04 | |
*** dims has quit IRC | 14:05 | |
*** sarob has joined #openstack-dev | 14:05 | |
*** galstrom is now known as galstrom_zzz | 14:06 | |
*** morazi has joined #openstack-dev | 14:06 | |
*** dvarga has joined #openstack-dev | 14:06 | |
*** rfolco has joined #openstack-dev | 14:06 | |
*** thuc has joined #openstack-dev | 14:07 | |
*** tdruiva has joined #openstack-dev | 14:07 | |
*** dims has joined #openstack-dev | 14:10 | |
*** changbl has quit IRC | 14:10 | |
*** sarob has quit IRC | 14:10 | |
*** stevemar has joined #openstack-dev | 14:11 | |
*** simo_ has joined #openstack-dev | 14:12 | |
*** sahid has quit IRC | 14:12 | |
*** xga_ has joined #openstack-dev | 14:13 | |
*** andreykurilin has joined #openstack-dev | 14:13 | |
*** Tross has joined #openstack-dev | 14:13 | |
*** gszasz has joined #openstack-dev | 14:14 | |
*** ala_ has quit IRC | 14:15 | |
gilliard | Is there any guideline about when to use timeutils and when to use time from the standard python libs? | 14:15 |
gilliard | timeutils provides a way of mocking for tests, but a lot of code uses time.time directly. | 14:16 |
*** jpomero has quit IRC | 14:16 | |
*** xga has quit IRC | 14:16 | |
*** aditirav has quit IRC | 14:16 | |
chmouel | jgriffith: hello i have added a comment here https://review.openstack.org/#/c/68726/ | 14:16 |
*** Tross has quit IRC | 14:17 | |
gilliard | specifically w.r.t this patch: https://review.openstack.org/#/c/72200/ | 14:17 |
*** capri has quit IRC | 14:17 | |
*** yaguang has joined #openstack-dev | 14:17 | |
*** stevemar2 has joined #openstack-dev | 14:17 | |
*** stevemar has quit IRC | 14:18 | |
*** markmcclain has quit IRC | 14:18 | |
*** arosen has quit IRC | 14:18 | |
*** jordanP has quit IRC | 14:18 | |
*** arosen has joined #openstack-dev | 14:19 | |
*** capri has joined #openstack-dev | 14:19 | |
gilliard | I wonder if one is the preferred way or if it's just up to the developer. | 14:19 |
*** nshaikh has joined #openstack-dev | 14:19 | |
*** dstanek has quit IRC | 14:20 | |
*** topol has quit IRC | 14:21 | |
*** rodrigods has quit IRC | 14:22 | |
*** READ10 has joined #openstack-dev | 14:23 | |
*** buzztroll has joined #openstack-dev | 14:23 | |
*** ifarkas has quit IRC | 14:24 | |
*** mindpixel has quit IRC | 14:25 | |
*** ifarkas has joined #openstack-dev | 14:25 | |
*** sahid has joined #openstack-dev | 14:26 | |
*** saju_m has quit IRC | 14:27 | |
*** aditirav has joined #openstack-dev | 14:27 | |
*** buzztroll has quit IRC | 14:28 | |
*** samuelbercovici has joined #openstack-dev | 14:28 | |
*** kolesovdv has quit IRC | 14:29 | |
*** simo_ is now known as simo | 14:29 | |
*** thuc has quit IRC | 14:29 | |
*** simo has quit IRC | 14:29 | |
*** simo has joined #openstack-dev | 14:29 | |
*** dkranz has quit IRC | 14:29 | |
*** saju_m has joined #openstack-dev | 14:29 | |
*** thuc has joined #openstack-dev | 14:29 | |
gilliard | Answering my own question: set_time_override is being deprecated. https://bugs.launchpad.net/oslo/+bug/1266962 | 14:30 |
uvirtbot | Launchpad bug 1266962 in oslo "Remove set_time_override in timeutils" [Low,In progress] | 14:30 |
*** tkammer has quit IRC | 14:30 | |
*** nmagnezi has quit IRC | 14:31 | |
*** avishay has quit IRC | 14:31 | |
*** cfriesen has joined #openstack-dev | 14:32 | |
*** topol has joined #openstack-dev | 14:32 | |
*** igor___ has joined #openstack-dev | 14:33 | |
*** jordanP has joined #openstack-dev | 14:33 | |
*** thuc has quit IRC | 14:34 | |
*** igor_ has quit IRC | 14:34 | |
*** gokrokve has joined #openstack-dev | 14:34 | |
*** henrynash has quit IRC | 14:34 | |
*** lazy_prince has quit IRC | 14:35 | |
*** peristeri has joined #openstack-dev | 14:35 | |
*** rodrigods has joined #openstack-dev | 14:36 | |
*** rohitk has quit IRC | 14:36 | |
*** lbragstad has joined #openstack-dev | 14:36 | |
*** Tross has joined #openstack-dev | 14:36 | |
*** dkranz has joined #openstack-dev | 14:36 | |
*** jecarey has joined #openstack-dev | 14:36 | |
*** hartsocks has joined #openstack-dev | 14:37 | |
*** jpomero has joined #openstack-dev | 14:37 | |
*** henrynash has joined #openstack-dev | 14:37 | |
*** stevemar2 has quit IRC | 14:38 | |
*** gokrokve has quit IRC | 14:39 | |
*** mfer has joined #openstack-dev | 14:39 | |
*** thuc has joined #openstack-dev | 14:40 | |
*** dperaza has joined #openstack-dev | 14:41 | |
*** florentflament has quit IRC | 14:42 | |
*** mst89 has joined #openstack-dev | 14:42 | |
*** dstanek has joined #openstack-dev | 14:43 | |
*** tkammer has joined #openstack-dev | 14:43 | |
*** cagrev has joined #openstack-dev | 14:43 | |
*** nmagnezi has joined #openstack-dev | 14:44 | |
*** avishay has joined #openstack-dev | 14:46 | |
*** ayoung has joined #openstack-dev | 14:47 | |
*** dkranz has quit IRC | 14:47 | |
*** jgallard_ has joined #openstack-dev | 14:47 | |
*** tsekiyama has joined #openstack-dev | 14:47 | |
*** henrynash has quit IRC | 14:48 | |
*** thuc has quit IRC | 14:48 | |
*** achampion has joined #openstack-dev | 14:48 | |
*** thuc has joined #openstack-dev | 14:49 | |
*** jprovazn has quit IRC | 14:49 | |
marekd | dolphm: ping? | 14:49 |
*** jgallard has quit IRC | 14:51 | |
*** jprovazn has joined #openstack-dev | 14:51 | |
*** mflobo_ has joined #openstack-dev | 14:51 | |
*** cnesa has joined #openstack-dev | 14:51 | |
*** imcsk8 has joined #openstack-dev | 14:52 | |
*** kevinconway has joined #openstack-dev | 14:52 | |
*** romcheg1 has quit IRC | 14:52 | |
*** prad_ has joined #openstack-dev | 14:53 | |
*** thuc has quit IRC | 14:53 | |
*** wchrisj|away is now known as chris_johnson | 14:53 | |
dolphm | marun: pong | 14:53 |
*** ilyashakhat has quit IRC | 14:54 | |
dolphm | marekd: pong! (my bad, marun) | 14:54 |
*** mflobo has quit IRC | 14:54 | |
*** FunnyLookinHat has quit IRC | 14:54 | |
*** jruzicka has joined #openstack-dev | 14:54 | |
*** ygbo has quit IRC | 14:55 | |
*** ysk has quit IRC | 14:56 | |
*** mriedem has quit IRC | 14:56 | |
*** rkukura has quit IRC | 14:56 | |
*** arosen has quit IRC | 14:56 | |
*** nacim has quit IRC | 14:56 | |
*** mriedem has joined #openstack-dev | 14:57 | |
*** ygbo has joined #openstack-dev | 14:59 | |
*** devoid has joined #openstack-dev | 14:59 | |
*** xga_ has quit IRC | 15:00 | |
*** CaptTofu has quit IRC | 15:00 | |
*** abhirc has joined #openstack-dev | 15:01 | |
*** Mandell has joined #openstack-dev | 15:01 | |
*** pschaef has joined #openstack-dev | 15:01 | |
*** radez_g0n3 is now known as radez | 15:02 | |
*** mriedem has quit IRC | 15:02 | |
*** armax has joined #openstack-dev | 15:02 | |
*** sahid has quit IRC | 15:03 | |
*** rkukura has joined #openstack-dev | 15:03 | |
*** hdd_ has quit IRC | 15:04 | |
*** xga has joined #openstack-dev | 15:04 | |
*** sarob has joined #openstack-dev | 15:05 | |
*** therve_ has joined #openstack-dev | 15:05 | |
*** therve_ has quit IRC | 15:05 | |
*** terrylhowe has joined #openstack-dev | 15:05 | |
*** mgagne has joined #openstack-dev | 15:05 | |
*** danielbruno has joined #openstack-dev | 15:06 | |
*** nacim has joined #openstack-dev | 15:06 | |
*** bashok has quit IRC | 15:06 | |
*** eglynn-lunch is now known as eglynn | 15:09 | |
*** sarob has quit IRC | 15:10 | |
*** mst89_ has joined #openstack-dev | 15:10 | |
*** zul has joined #openstack-dev | 15:12 | |
*** belmoreira has quit IRC | 15:12 | |
*** belmoreira has joined #openstack-dev | 15:13 | |
*** sweston has quit IRC | 15:13 | |
*** stevemar has joined #openstack-dev | 15:14 | |
*** mst89 has quit IRC | 15:14 | |
stevemar | bknudson, apparently everyone wants to sync oslo | 15:14 |
*** alop has joined #openstack-dev | 15:16 | |
bknudson | stevemar: when the sync brings in changes for the config options they have to update the sample config. | 15:16 |
stevemar | bknudson, yes, i noticed in your change, cool. I guess it's always best to look up all changes that happened? | 15:17 |
*** BobBallAway is now known as BobBall | 15:17 | |
*** ruhe_ has joined #openstack-dev | 15:17 | |
stevemar | bknudson, what about the fact that morganfainberg also has the changes in his huge patch? | 15:17 |
*** belmoreira has quit IRC | 15:17 | |
*** Tross has quit IRC | 15:17 | |
bknudson | stevemar: I'm worried about any huge patch... I didn't look at it yet because of the size. | 15:18 |
*** jgrimm has joined #openstack-dev | 15:19 | |
*** nshaikh has left #openstack-dev | 15:19 | |
*** AlanClark has joined #openstack-dev | 15:20 | |
stevemar | bknudson, agreed. I skipped it over. | 15:20 |
stevemar | bknudson, btw - pull the trigger on: https://review.openstack.org/#/c/67645/ | 15:21 |
stevemar | ? | 15:21 |
bknudson | it would be nice to have everything in sync with oslo, so it's probably a good idea | 15:21 |
bknudson | stevemar: I've got a meeting here and then I'll take a look | 15:21 |
stevemar | bknudson, oops, just noticed your s/t status, my bad | 15:22 |
*** rodrigods has quit IRC | 15:23 | |
*** buzztroll has joined #openstack-dev | 15:23 | |
*** aljoho has joined #openstack-dev | 15:23 | |
dolphm | bknudson: is nova evolving their approach to their config checker at all? i know they don't like it when they're gate dies because of upstream config changes | 15:23 |
*** sgrasley has quit IRC | 15:25 | |
*** browne has joined #openstack-dev | 15:26 | |
flamebot | devstack questions here? my upgraded stable/havana install gives me "cannot import name base" | 15:27 |
topol | dolphm, on your comment on my patch is it possible the new signature of wrapper should be def wrapper(cls, context, *args, **kwargs): ? | 15:27 |
flamebot | instead of horizon | 15:27 |
*** buzztroll has quit IRC | 15:27 | |
topol | dolphm, because the way you had it I get AttributeError: 'CadfNotificationsWrapperTestCase' object has no attribute 'get' | 15:28 |
*** henrynash has joined #openstack-dev | 15:28 | |
bknudson | dolphm: there was some discussion on openstack-dev ml -- http://lists.openstack.org/pipermail/openstack-dev/2014-February/026246.html | 15:28 |
dolphm | topol: maybe? was it cls before? | 15:29 |
dolphm | topol: i feel like i assumed it was self | 15:29 |
dolphm | topol: but yes-- there should be an explicit argument before context, regardless (just not sure what it should be) | 15:29 |
topol | dolphm, no but I was using args[1]. | 15:30 |
*** FunnyLookinHat has joined #openstack-dev | 15:30 | |
dolphm | topol: so definitely (something, context, *args, **kwargs) then | 15:31 |
topol | dolphm, should I put self as the something? | 15:31 |
*** Gordonz has joined #openstack-dev | 15:31 | |
dolphm | topol: link me to the review | 15:31 |
*** ttx has joined #openstack-dev | 15:31 | |
*** ttx has quit IRC | 15:31 | |
*** ttx has joined #openstack-dev | 15:31 | |
*** Gordonz has quit IRC | 15:31 | |
*** ttx_ has quit IRC | 15:31 | |
topol | dolphm, https://review.openstack.org/#/c/69632/9/keystone/cadf_notifications.py | 15:31 |
*** david-lyle has joined #openstack-dev | 15:32 | |
dolphm | topol: yeah my suggested method signature is bad | 15:32 |
*** Gordonz has joined #openstack-dev | 15:32 | |
topol | dolphm, also can the notification package stuff wait until after feb 18? I made all the other changes you asked for | 15:32 |
*** nmagnezi has quit IRC | 15:32 | |
topol | dolphm, should I just put cls? or self? | 15:32 |
dolphm | topol: and these are wrapping controller methods, where the signature is always (self, context, ...) so you should do the same | 15:33 |
topol | dolphm, K I'll make it (self, context, ...) | 15:33 |
*** jcoufal_ has joined #openstack-dev | 15:33 | |
topol | dolphm, can the notification refactored as a module wait until after feb 18 or you want that done before? | 15:34 |
*** Tross has joined #openstack-dev | 15:34 | |
*** gokrokve has joined #openstack-dev | 15:34 | |
*** sahid has joined #openstack-dev | 15:34 | |
dolphm | topol: you could also debug whether it should be cls or self at runtime by dumping whatever value is passed in to args[0] (self/cls) and seeing if it's type() is a 'class' instance (and therefore self) or a class 'type' definition (and therefore cls) | 15:35 |
dolphm | topol: refactor can wait | 15:35 |
dolphm | topol: you can put it up for review whenever you'd like though | 15:36 |
*** boris-42_ has quit IRC | 15:36 | |
*** jcoufal has quit IRC | 15:36 | |
*** dtantsur has quit IRC | 15:36 | |
*** noslzzp has quit IRC | 15:36 | |
*** jprovazn has quit IRC | 15:37 | |
topol | dolphm, great! Thanks. On the refactor I would have to move notifications.py into the new package as well and then deal with all the changes that would impact, correct? | 15:37 |
*** vartom1111111111 has joined #openstack-dev | 15:37 | |
*** glenng1 is now known as glenng | 15:37 | |
*** reed__ has joined #openstack-dev | 15:38 | |
dolphm | topol: yes, i guess it would become keystone.notifications.core ? | 15:38 |
dolphm | topol: poke morganfainberg on the details-- he thought through it more thoroughly than i | 15:38 |
topol | dolphm, K, will do | 15:39 |
*** gokrokve has quit IRC | 15:39 | |
*** galstrom_zzz is now known as galstrom | 15:39 | |
*** yaguang has quit IRC | 15:40 | |
*** relaxdiego has joined #openstack-dev | 15:40 | |
*** noslzzp has joined #openstack-dev | 15:40 | |
*** dtantsur has joined #openstack-dev | 15:41 | |
*** hartsocks has quit IRC | 15:42 | |
*** coolsvap has joined #openstack-dev | 15:42 | |
*** carl_baldwin has joined #openstack-dev | 15:42 | |
*** paragan has quit IRC | 15:43 | |
*** Tross has quit IRC | 15:44 | |
*** saju_m has quit IRC | 15:45 | |
*** nkinder has joined #openstack-dev | 15:45 | |
*** sarob has joined #openstack-dev | 15:45 | |
*** jgallard_ has quit IRC | 15:46 | |
*** saju_m has joined #openstack-dev | 15:46 | |
*** vartom1111111111 has quit IRC | 15:47 | |
*** henrynash has quit IRC | 15:48 | |
*** zul has quit IRC | 15:48 | |
*** carl_baldwin has quit IRC | 15:49 | |
*** sarob has quit IRC | 15:50 | |
*** aditirav_ has joined #openstack-dev | 15:50 | |
*** kenperkins has joined #openstack-dev | 15:50 | |
*** DinaBelova is now known as DinaBelova_ | 15:51 | |
*** aditirav has quit IRC | 15:52 | |
*** aditirav_ is now known as aditirav | 15:52 | |
*** carl_baldwin has joined #openstack-dev | 15:53 | |
*** gokrokve has joined #openstack-dev | 15:55 | |
*** mrunge has joined #openstack-dev | 15:56 | |
*** jruzicka_ has joined #openstack-dev | 15:56 | |
*** gokrokve_ has joined #openstack-dev | 15:56 | |
*** reed__ is now known as reed | 15:56 | |
*** reed has quit IRC | 15:56 | |
*** reed has joined #openstack-dev | 15:56 | |
*** devoid has quit IRC | 15:57 | |
*** jruzicka has quit IRC | 15:58 | |
*** AlexF has joined #openstack-dev | 15:58 | |
*** mst89_ has quit IRC | 15:58 | |
*** gokrokve has quit IRC | 15:59 | |
*** Drankis has quit IRC | 15:59 | |
*** comay has quit IRC | 16:00 | |
*** Ruetobas has quit IRC | 16:01 | |
*** rtheis has joined #openstack-dev | 16:01 | |
*** amuller has quit IRC | 16:02 | |
*** yjiang51 has joined #openstack-dev | 16:02 | |
*** sarob has joined #openstack-dev | 16:02 | |
*** amuller_ has joined #openstack-dev | 16:02 | |
*** amuller_ is now known as amuller | 16:02 | |
*** Ruetobas has joined #openstack-dev | 16:03 | |
*** mriedem has joined #openstack-dev | 16:03 | |
*** arosen has joined #openstack-dev | 16:04 | |
*** dtantsur has quit IRC | 16:04 | |
*** samuelbercovici has quit IRC | 16:05 | |
*** corXi has quit IRC | 16:05 | |
*** sarob_ has joined #openstack-dev | 16:05 | |
*** carl_baldwin has quit IRC | 16:05 | |
*** xarses has quit IRC | 16:06 | |
*** rraja has quit IRC | 16:06 | |
*** comay has joined #openstack-dev | 16:06 | |
*** atiwari has joined #openstack-dev | 16:06 | |
*** pmathews has joined #openstack-dev | 16:07 | |
*** sarob has quit IRC | 16:07 | |
*** tjones has joined #openstack-dev | 16:07 | |
*** clayb has joined #openstack-dev | 16:07 | |
*** qba73 has quit IRC | 16:07 | |
*** Ruetobas has quit IRC | 16:08 | |
*** lcheng_ has joined #openstack-dev | 16:09 | |
*** sandywalsh has joined #openstack-dev | 16:09 | |
*** pat___ has joined #openstack-dev | 16:10 | |
*** jnoller has joined #openstack-dev | 16:10 | |
*** cnesa has quit IRC | 16:10 | |
*** hartsocks has joined #openstack-dev | 16:10 | |
*** zul has joined #openstack-dev | 16:10 | |
*** tkammer has quit IRC | 16:10 | |
dolphm | topol: just spotted where you got the args[1] approach from | 16:10 |
*** jnoller_ has joined #openstack-dev | 16:11 | |
*** pat___ has left #openstack-dev | 16:11 | |
topol | dolphm, did I do something wrong? | 16:11 |
dolphm | topol: nope! someone else did :P | 16:11 |
topol | dolphm, I am just a lemming... | 16:11 |
topol | point me to the cliff | 16:11 |
topol | dolphm, I will fix mine and pus a new patch before the 1pm irc meeting | 16:12 |
*** jgallard has joined #openstack-dev | 16:13 | |
*** mbernacc has quit IRC | 16:13 | |
*** henrynash has joined #openstack-dev | 16:13 | |
*** byeager has joined #openstack-dev | 16:13 | |
dolphm | topol: cool! | 16:13 |
*** Ruetobas has joined #openstack-dev | 16:13 | |
*** relaxdiego has quit IRC | 16:14 | |
*** jnoller has quit IRC | 16:14 | |
*** arosen has quit IRC | 16:14 | |
*** garyk has joined #openstack-dev | 16:15 | |
*** relaxdiego has joined #openstack-dev | 16:15 | |
*** ramishra has quit IRC | 16:15 | |
*** markmcclain has joined #openstack-dev | 16:15 | |
*** jcoufal_ is now known as jcoufal | 16:15 | |
*** arosen has joined #openstack-dev | 16:15 | |
*** CaptTofu has joined #openstack-dev | 16:16 | |
*** ramishra has joined #openstack-dev | 16:16 | |
*** vijendar has joined #openstack-dev | 16:16 | |
*** markmcclain1 has joined #openstack-dev | 16:16 | |
*** dtantsur has joined #openstack-dev | 16:17 | |
*** jmontemayor has joined #openstack-dev | 16:17 | |
*** mrda_away is now known as mrda | 16:18 | |
*** jmontemayor has quit IRC | 16:18 | |
timello | Is there anyone that could review keystone/keystoneclient patches, please? https://review.openstack.org/#/c/70823/ https://review.openstack.org/#/c/71337/ | 16:18 |
*** jmontemayor has joined #openstack-dev | 16:19 | |
*** markmcclain has quit IRC | 16:19 | |
*** gokrokve_ has quit IRC | 16:20 | |
*** mrunge has quit IRC | 16:21 | |
*** raildo has joined #openstack-dev | 16:22 | |
*** gokrokve has joined #openstack-dev | 16:23 | |
*** buzztroll has joined #openstack-dev | 16:23 | |
*** xgsa has quit IRC | 16:23 | |
*** ndipanov has joined #openstack-dev | 16:23 | |
*** pradeep has quit IRC | 16:24 | |
*** xga has quit IRC | 16:26 | |
*** dvarga has quit IRC | 16:26 | |
*** mdomsch has joined #openstack-dev | 16:27 | |
*** hemna has joined #openstack-dev | 16:27 | |
*** Tross has joined #openstack-dev | 16:27 | |
*** nelsnelson has joined #openstack-dev | 16:27 | |
*** Tross has quit IRC | 16:27 | |
*** buzztroll has quit IRC | 16:28 | |
*** thuc has joined #openstack-dev | 16:29 | |
*** relaxdiego has quit IRC | 16:29 | |
*** bnemec has quit IRC | 16:31 | |
*** henrynash has quit IRC | 16:31 | |
*** jruzicka_ is now known as jruzicka | 16:31 | |
*** dkranz has joined #openstack-dev | 16:32 | |
*** ramishra_ has joined #openstack-dev | 16:32 | |
*** amuller has quit IRC | 16:32 | |
*** henrynash has joined #openstack-dev | 16:33 | |
*** RajeshMohan has quit IRC | 16:33 | |
*** gyee has joined #openstack-dev | 16:33 | |
*** RajeshMohan has joined #openstack-dev | 16:33 | |
*** RajeshMohan has quit IRC | 16:33 | |
*** RajeshMohan has joined #openstack-dev | 16:33 | |
*** Tross has joined #openstack-dev | 16:34 | |
*** bnemec has joined #openstack-dev | 16:34 | |
*** ramishra has quit IRC | 16:34 | |
*** I159 has quit IRC | 16:35 | |
*** relaxdiego has joined #openstack-dev | 16:35 | |
*** markwash has joined #openstack-dev | 16:35 | |
*** rods has quit IRC | 16:38 | |
*** tzabal has joined #openstack-dev | 16:38 | |
*** cnesa has joined #openstack-dev | 16:40 | |
*** tmclaugh[work] has quit IRC | 16:41 | |
*** tmclaugh[work] has joined #openstack-dev | 16:41 | |
*** rohitk has joined #openstack-dev | 16:42 | |
*** nplanel has quit IRC | 16:42 | |
*** julienvey has left #openstack-dev | 16:42 | |
*** nplanel has joined #openstack-dev | 16:42 | |
*** garyk has quit IRC | 16:42 | |
*** ruhe_ has quit IRC | 16:43 | |
*** sarob_ has quit IRC | 16:43 | |
*** DinaBelova_ is now known as DinaBelova | 16:43 | |
*** sarob has joined #openstack-dev | 16:43 | |
*** mikeoutland has joined #openstack-dev | 16:44 | |
*** cnesa2 has joined #openstack-dev | 16:44 | |
*** xarses has joined #openstack-dev | 16:46 | |
*** cnesa has quit IRC | 16:46 | |
*** gokrokve has quit IRC | 16:47 | |
*** gokrokve has joined #openstack-dev | 16:47 | |
*** jistr has quit IRC | 16:47 | |
*** sarob has quit IRC | 16:48 | |
*** mlegault_ has joined #openstack-dev | 16:48 | |
*** tjones has quit IRC | 16:50 | |
*** cnesa2 has quit IRC | 16:50 | |
*** beagles has quit IRC | 16:51 | |
*** gokrokve has quit IRC | 16:51 | |
*** mlegault__ has joined #openstack-dev | 16:51 | |
*** ctracey|away is now known as ctracey | 16:51 | |
*** boris-42_ has joined #openstack-dev | 16:52 | |
*** mlegault has quit IRC | 16:52 | |
*** max_lobur has quit IRC | 16:52 | |
*** gokrokve has joined #openstack-dev | 16:52 | |
*** ssurana has joined #openstack-dev | 16:53 | |
*** tmclaugh[work] has quit IRC | 16:53 | |
*** alexpilotti has quit IRC | 16:54 | |
*** tjones has joined #openstack-dev | 16:54 | |
*** cnesa has joined #openstack-dev | 16:54 | |
*** Mandell has quit IRC | 16:55 | |
*** jruzicka has quit IRC | 16:55 | |
*** mlegault_ has quit IRC | 16:55 | |
*** yassine has quit IRC | 16:57 | |
*** mikeoutland has quit IRC | 16:58 | |
*** bauzas has quit IRC | 16:58 | |
*** jmontemayor_ has joined #openstack-dev | 16:58 | |
*** e0ne_ has quit IRC | 16:59 | |
*** tmclaugh[work] has joined #openstack-dev | 17:00 | |
*** tqtran has joined #openstack-dev | 17:01 | |
jog0 | dolphm: http://logs.openstack.org/20/56420/7/check/check-tempest-dsvm-neutron/24b6f66/logs/screen-key.txt.gz?level=DEBUG | 17:01 |
*** jmontema_ has joined #openstack-dev | 17:01 | |
jog0 | why are dogpile debug logs on? | 17:01 |
*** dvarga has joined #openstack-dev | 17:01 | |
*** gokrokve has quit IRC | 17:01 | |
*** jmontema_ has quit IRC | 17:01 | |
jog0 | and iso8601? | 17:01 |
jog0 | ayoung: ^ | 17:01 |
*** DavidPatterson has joined #openstack-dev | 17:01 | |
*** jmontemayor has quit IRC | 17:01 | |
*** jmontemayor_ has quit IRC | 17:02 | |
dolphm | jog0: good question... (ping: bknudson) | 17:02 |
ayoung | jog0, ask morganfainberg_Z when he's awake. it is annoying, but something about a something default internal mumble something | 17:02 |
*** jmontema_ has joined #openstack-dev | 17:02 | |
*** changbl has joined #openstack-dev | 17:02 | |
*** DavidPatterson has left #openstack-dev | 17:02 | |
*** evgenyf has quit IRC | 17:02 | |
jog0 | ayoung dolphmL ets fix the defaults | 17:02 |
bknudson | jog0: that's the default... I posted a patch to change the default... | 17:02 |
dolphm | jog0: i believe bknudson did | 17:02 |
dolphm | bknudson: did it merge? | 17:02 |
bknudson | jog0: dolphm: https://review.openstack.org/#/c/62068/ | 17:03 |
*** lcheng_ has quit IRC | 17:03 | |
*** devoid has joined #openstack-dev | 17:03 | |
dolphm | jog0: isn that check job recent? | 17:03 |
dolphm | is* | 17:03 |
bknudson | it hasn't merged. | 17:03 |
bknudson | the change needed a rebasing | 17:04 |
jog0 | bknudson: sweet thanks | 17:04 |
jog0 | looking forward to seeing this landing | 17:04 |
*** thedodd has joined #openstack-dev | 17:04 | |
*** b3nt_pin has joined #openstack-dev | 17:04 | |
*** b3nt_pin is now known as beagles | 17:04 | |
*** iartarisi has quit IRC | 17:05 | |
dolphm | bknudson: approved the underlying patch | 17:05 |
*** dsirrine has quit IRC | 17:05 | |
*** noslzzp has quit IRC | 17:05 | |
dolphm | bknudson: find another +2 on the second one :) | 17:06 |
bknudson | dolphm: that's always the hard part. | 17:06 |
*** kgriffs is now known as kgriffs_afk | 17:07 | |
*** athomas has quit IRC | 17:07 | |
*** dtantsur has quit IRC | 17:07 | |
*** jruzicka has joined #openstack-dev | 17:07 | |
*** sweston has joined #openstack-dev | 17:07 | |
*** markmc has quit IRC | 17:08 | |
*** mkollaro1 has quit IRC | 17:09 | |
*** bdpayne has joined #openstack-dev | 17:09 | |
*** dvarga is now known as dvarga|away | 17:10 | |
*** jordanP has quit IRC | 17:10 | |
*** xga has joined #openstack-dev | 17:10 | |
*** dvarga|away is now known as dvarga | 17:10 | |
*** angdraug has joined #openstack-dev | 17:11 | |
*** henrynash has quit IRC | 17:11 | |
*** jmching has joined #openstack-dev | 17:13 | |
*** nacim has quit IRC | 17:14 | |
*** sarob has joined #openstack-dev | 17:14 | |
*** zaitcev has joined #openstack-dev | 17:15 | |
*** jotan has joined #openstack-dev | 17:15 | |
*** lpaschke has joined #openstack-dev | 17:15 | |
*** alop_ has joined #openstack-dev | 17:16 | |
*** dsirrine has joined #openstack-dev | 17:16 | |
*** alop has quit IRC | 17:17 | |
*** alop_ is now known as alop | 17:17 | |
*** jaybuff has joined #openstack-dev | 17:17 | |
*** jcoufal has quit IRC | 17:17 | |
*** henrynash has joined #openstack-dev | 17:17 | |
*** CaptTofu has quit IRC | 17:19 | |
gyee | bknudson, approved it | 17:19 |
*** garyk has joined #openstack-dev | 17:19 | |
bknudson | gyee: thanks! maybe we'll get fewer complaints about the log files. | 17:19 |
*** garyk has joined #openstack-dev | 17:19 | |
*** peristeri has quit IRC | 17:19 | |
*** cnesa has quit IRC | 17:20 | |
*** pmathews has quit IRC | 17:20 | |
*** ifarkas has quit IRC | 17:20 | |
bknudson | now just need to get https://review.openstack.org/#/c/67668/ in oslo-incubator merged and ported to keystone and we might have logs sane enough to actually tweak for usability | 17:20 |
*** marcoemorais has joined #openstack-dev | 17:20 | |
*** max_lobur has joined #openstack-dev | 17:21 | |
*** ianw has quit IRC | 17:21 | |
*** peristeri has joined #openstack-dev | 17:21 | |
*** marcoemorais has quit IRC | 17:21 | |
*** mkollaro has joined #openstack-dev | 17:21 | |
*** marcoemorais has joined #openstack-dev | 17:21 | |
bknudson | and also these 2 in keystone: https://review.openstack.org/#/c/69218/ and https://review.openstack.org/#/c/69219/ | 17:22 |
gyee | bknudson, looking | 17:22 |
*** bdpayne_ has joined #openstack-dev | 17:22 | |
*** pmathews has joined #openstack-dev | 17:23 | |
*** buzztroll has joined #openstack-dev | 17:23 | |
henrynash | anyone interested in looking at the final +2 (or not) of https://review.openstack.org/#/c/44836/ ? | 17:23 |
*** kushal has quit IRC | 17:23 | |
*** marcoemorais has quit IRC | 17:24 | |
henrynash | also, the migration for the grant->assignment table is now done and up at: https://review.openstack.org/#/c/71159/5 | 17:24 |
*** fabiog has joined #openstack-dev | 17:24 | |
*** bdpayne has quit IRC | 17:24 | |
gyee | henrynash, I like rationalize the assignment grant table changes, good stuff! | 17:25 |
henrynash | gyee: it's only taken us there releases to finally get it done :-) | 17:25 |
gyee | henrynash, it makes internal db reporting a hell lot easier too | 17:25 |
*** radez is now known as radez_g0n3 | 17:26 | |
henrynash | gyee: and in fact, we can simplify some of the calls at the Manager/Controller levels as well in time | 17:26 |
*** buzztroll has quit IRC | 17:26 | |
*** Tross has quit IRC | 17:26 | |
*** buzztroll has joined #openstack-dev | 17:26 | |
dolphm | henrynash: wow two spelling mistakes slipped past bknudson... | 17:27 |
dolphm | bknudson: you're slipping! | 17:28 |
*** godara has joined #openstack-dev | 17:28 | |
bknudson | dolphm: I won't let it happen again. | 17:28 |
*** jaybuff has left #openstack-dev | 17:30 | |
dolphm | henrynash: bknudson: i'm going to submit a follow up patch or two, but so far lgtm | 17:30 |
*** _cjones_ has joined #openstack-dev | 17:30 | |
*** cnesa has joined #openstack-dev | 17:31 | |
*** aljoho has quit IRC | 17:31 | |
*** viktors has quit IRC | 17:31 | |
*** marcoemorais has joined #openstack-dev | 17:31 | |
*** bswartz has quit IRC | 17:33 | |
marun | annegentle: ping | 17:34 |
*** gszasz has quit IRC | 17:34 | |
*** ygbo has quit IRC | 17:34 | |
*** RajeshMohan has quit IRC | 17:35 | |
topol | dolphm, so I had to rebase last night which I thought went fine but now I can't run my unit tests. I get ERROR: InvocationError: '/opt/stack/keystone/.tox/py27/bin/python setup.py testr --testr-args=keystone.tests.test_notifications.CadfNotificationsWrapperTestCase.test_v2_authenticate_username' | 17:35 |
topol | dolphm, and when I run tox I get ./keystone/middleware/s3_token.py:39:1: H302 import only modules.'from keystoneclient.middleware import s3_token' does not import a module | 17:35 |
topol | from keystoneclient.middleware import s3_token | 17:35 |
*** RajeshMohan has joined #openstack-dev | 17:36 | |
topol | dolphm which is not code I even touched | 17:36 |
*** max_lobur is now known as max_lobur_afk | 17:36 | |
*** bhuvan has joined #openstack-dev | 17:36 | |
topol | dolphm, should I create a new branch by pulling down the most recent patch I uploaded last night? | 17:37 |
*** relaxdiego has quit IRC | 17:37 | |
dolphm | topol: hrm... do you have the latest client installed? | 17:38 |
*** YorikSar has joined #openstack-dev | 17:38 | |
*** AnilV4 has quit IRC | 17:38 | |
topol | dolphm probably not. | 17:38 |
*** rohitk has quit IRC | 17:39 | |
*** tqtran has quit IRC | 17:40 | |
*** sarob has quit IRC | 17:40 | |
*** MaxV has quit IRC | 17:40 | |
*** rohitk has joined #openstack-dev | 17:40 | |
*** belmoreira has joined #openstack-dev | 17:40 | |
topol | dolphm, I am still in my working branch and did a git diff and it says I have made no updates | 17:40 |
*** sarob has joined #openstack-dev | 17:40 | |
dolphm | topol: i assume you're using devstack? | 17:41 |
topol | dolphm, NO NO NO | 17:41 |
topol | dolphm, been running just stand alone keystone. my development is way faster that way | 17:42 |
dolphm | topol: lol ++ | 17:42 |
*** ppetit has quit IRC | 17:42 | |
* topol I hate waitng for devstack to start up if I can avoid it | 17:42 | |
dolphm | topol: python -c "from keystoneclient.middleware import s3_token; print(s3_token)" | 17:43 |
dolphm | topol: what's that do? | 17:43 |
*** CaptTofu has joined #openstack-dev | 17:43 | |
topol | dolphm: Traceback (most recent call last): | 17:44 |
topol | File "<string>", line 1, in <module> | 17:44 |
topol | ImportError: cannot import name s3_token | 17:44 |
dolphm | topol: do you have a keystoneclient repo checked out? | 17:44 |
*** jgallard has quit IRC | 17:44 | |
topol | dolphm, looks that way yes. SHould I go in an do a git pull origin master? | 17:45 |
*** sarob has quit IRC | 17:45 | |
*** gokrokve has joined #openstack-dev | 17:45 | |
*** abhirc has quit IRC | 17:46 | |
*** Skyrail has joined #openstack-dev | 17:46 | |
dolphm | topol: yes | 17:46 |
*** bauzas has joined #openstack-dev | 17:46 | |
*** eglynn has quit IRC | 17:47 | |
*** markmcclain1 has quit IRC | 17:47 | |
*** carl_baldwin has joined #openstack-dev | 17:47 | |
topol | dolphm, done. should stuff work now | 17:47 |
*** amcrn has quit IRC | 17:48 | |
*** jobewan has joined #openstack-dev | 17:48 | |
*** mwagner_lap has joined #openstack-dev | 17:48 | |
*** ijw has joined #openstack-dev | 17:49 | |
*** gokrokve has quit IRC | 17:49 | |
topol | dolphm, pep8 still unhappy: | 17:49 |
topol | ./keystone/middleware/s3_token.py:39:1: H302 import only modules.'from keystoneclient.middleware import s3_token' does not import a module | 17:49 |
topol | from keystoneclient.middleware import s3_token | 17:49 |
*** jmontema_ has quit IRC | 17:49 | |
*** gokrokve has joined #openstack-dev | 17:49 | |
dolphm | topol: what does that python -c thing do now? | 17:50 |
*** Tross has joined #openstack-dev | 17:50 | |
topol | dolphm, it gives me <module 'keystoneclient.middleware.s3_token' from '/opt/stack/python-keystoneclient/keystoneclient/middleware/s3_token.py'> | 17:51 |
*** devlaps has joined #openstack-dev | 17:51 | |
*** noslzzp has joined #openstack-dev | 17:52 | |
topol | dolphm, I thought tox ran in its own environment (py27). do I need to regenerate that? | 17:52 |
*** xga_ has joined #openstack-dev | 17:52 | |
dolphm | henrynash: bknudson: list limit related things https://review.openstack.org/#/c/72710/ https://review.openstack.org/#/c/72711/ https://review.openstack.org/#/c/72716/ | 17:53 |
*** xga has quit IRC | 17:53 | |
dolphm | topol: ooh, that's probably it | 17:53 |
dolphm | topol: yeah, rm -rf .tox/ or tox --recreate -e py27 | 17:53 |
*** mmagr has quit IRC | 17:54 | |
*** henrynash has quit IRC | 17:54 | |
topol | dolphm, K, cool. will try that | 17:54 |
*** marcoemorais has quit IRC | 17:54 | |
*** gokrokve has quit IRC | 17:54 | |
*** marcoemorais has joined #openstack-dev | 17:54 | |
*** alexpilotti has joined #openstack-dev | 17:54 | |
*** galstrom is now known as galstrom_zzz | 17:54 | |
*** gokrokve has joined #openstack-dev | 17:54 | |
*** prad_ has quit IRC | 17:54 | |
*** henrynash has joined #openstack-dev | 17:55 | |
*** marcoemorais has quit IRC | 17:55 | |
*** marcoemorais has joined #openstack-dev | 17:55 | |
*** carl_baldwin has quit IRC | 17:55 | |
topol | dolphm, so when I rebased last night it brought stuff down that made my tox environment inconsistent. Is that what happened? | 17:56 |
* topol I was just happy I successfully rebased at 2am all by myself... | 17:56 | |
dolphm | topol: lol, what version of keystoneclient is in your requirements.txt ? | 17:57 |
*** raildo has quit IRC | 17:58 | |
topol | dolphm python-keystoneclient>=0.5.0 | 17:58 |
*** raildo has joined #openstack-dev | 17:58 | |
*** henrique has joined #openstack-dev | 17:58 | |
*** fabiomorais has joined #openstack-dev | 17:58 | |
*** mrunge has joined #openstack-dev | 17:59 | |
*** relaxdiego has joined #openstack-dev | 17:59 | |
*** amuller has joined #openstack-dev | 18:00 | |
*** gokrokve has quit IRC | 18:01 | |
*** gokrokve has joined #openstack-dev | 18:01 | |
*** morganfainberg_Z is now known as morganfainberg | 18:02 | |
*** tqtran has joined #openstack-dev | 18:02 | |
*** morganfainberg is now known as mrgnfeignbern | 18:03 | |
*** marcoemorais has quit IRC | 18:04 | |
*** markmcclain has joined #openstack-dev | 18:04 | |
*** marcoemorais has joined #openstack-dev | 18:04 | |
*** AlexF has quit IRC | 18:04 | |
*** gokrokve has quit IRC | 18:06 | |
*** Tross has quit IRC | 18:06 | |
*** kgriffs_afk is now known as kgriffs | 18:07 | |
*** AlexF has joined #openstack-dev | 18:07 | |
*** sushils has quit IRC | 18:07 | |
*** lpaschke has quit IRC | 18:08 | |
*** READ10 has quit IRC | 18:08 | |
*** Skyrail has quit IRC | 18:08 | |
*** cnesa has quit IRC | 18:09 | |
*** rossella_s has quit IRC | 18:10 | |
*** mrgnfeignbern is now known as morganfainberg | 18:11 | |
*** safchain has quit IRC | 18:12 | |
*** Tross has joined #openstack-dev | 18:13 | |
*** sushils has joined #openstack-dev | 18:14 | |
*** amcrn has joined #openstack-dev | 18:16 | |
*** kgriffs is now known as kgriffs_afk | 18:17 | |
*** xga_ has quit IRC | 18:17 | |
*** jotan has quit IRC | 18:18 | |
*** gokrokve has joined #openstack-dev | 18:18 | |
*** galstrom_zzz is now known as galstrom | 18:19 | |
*** rohitk has quit IRC | 18:20 | |
*** sahid has quit IRC | 18:20 | |
*** Tross has quit IRC | 18:22 | |
*** jmching has quit IRC | 18:22 | |
*** danpb has quit IRC | 18:23 | |
*** gokrokve has quit IRC | 18:23 | |
*** mrodden has joined #openstack-dev | 18:23 | |
*** browne has quit IRC | 18:24 | |
*** kgriffs_afk is now known as kgriffs | 18:25 | |
*** bswartz has joined #openstack-dev | 18:25 | |
*** rcleere has quit IRC | 18:26 | |
*** jpich has quit IRC | 18:26 | |
*** AlexF has quit IRC | 18:27 | |
*** kgriffs is now known as kgriffs_afk | 18:30 | |
*** zzelle has quit IRC | 18:30 | |
*** praneshp has joined #openstack-dev | 18:30 | |
*** gokrokve has joined #openstack-dev | 18:31 | |
*** arnaud has joined #openstack-dev | 18:31 | |
*** arnaud__ has joined #openstack-dev | 18:31 | |
*** tkay has joined #openstack-dev | 18:32 | |
*** lucasagomes has quit IRC | 18:33 | |
*** chandan_kumar has quit IRC | 18:34 | |
*** epim has joined #openstack-dev | 18:37 | |
*** melodous has joined #openstack-dev | 18:37 | |
*** kgriffs_afk is now known as kgriffs | 18:38 | |
*** bauzas has quit IRC | 18:38 | |
*** abhirc has joined #openstack-dev | 18:38 | |
*** Tross has joined #openstack-dev | 18:39 | |
*** xqueralt has quit IRC | 18:39 | |
*** flamebot has quit IRC | 18:40 | |
*** browne has joined #openstack-dev | 18:41 | |
*** melwitt has joined #openstack-dev | 18:41 | |
*** gcha has quit IRC | 18:41 | |
*** sushils has quit IRC | 18:42 | |
jog0 | dtroyer: ping | 18:43 |
*** MaxV has joined #openstack-dev | 18:43 | |
*** prad has joined #openstack-dev | 18:45 | |
*** romcheg1 has joined #openstack-dev | 18:45 | |
*** jasdeepH has joined #openstack-dev | 18:45 | |
*** alexpilotti has quit IRC | 18:47 | |
*** tjones has quit IRC | 18:47 | |
*** jruzicka has quit IRC | 18:48 | |
*** rcleere has joined #openstack-dev | 18:49 | |
*** e0ne has joined #openstack-dev | 18:49 | |
*** tdruiva has quit IRC | 18:50 | |
*** jpomero has quit IRC | 18:50 | |
*** novas0x2a|laptop has quit IRC | 18:50 | |
*** tdruiva has joined #openstack-dev | 18:51 | |
jog0 | dtroyer: looking fro some grenade feedback when you hav a moment | 18:51 |
*** abhirc has quit IRC | 18:51 | |
*** mikeoutland has joined #openstack-dev | 18:52 | |
*** moted has quit IRC | 18:53 | |
*** evgenyf has joined #openstack-dev | 18:53 | |
*** markmcclain has quit IRC | 18:53 | |
*** markmcclain has joined #openstack-dev | 18:54 | |
*** dperaza has quit IRC | 18:54 | |
morganfainberg | dolphm, https://blueprints.launchpad.net/openstack/?searchtext=mongodb-dogpile-caching-backend possible i3 target | 18:55 |
gyee | jamielennox, just some minor nits about the v2 and v3 auth plugins, otherwise, they are awesome | 18:56 |
jamielennox | gyee: when you get a token you get a JSON/XML output of the token data | 18:56 |
morganfainberg | dolphm, i'm happy to review it, and the code is up | 18:56 |
gyee | jamelennox, right, middleware is a client and it interprets the token | 18:56 |
jamielennox | gyee: clients can use that but the actual token itself is only opened my auth_token | 18:56 |
morganfainberg | dolphm, but i didn't want to target it w/o checking with you first | 18:57 |
gyee | jamielennox, my point is with CMS, clients need to know how to validate it | 18:58 |
jamielennox | gyee: cool, i saw them briefly yesterday - i need to add the admin token thing now that i think about it | 18:58 |
jamielennox | gyee: auth_token i guess can be considered a client, it just doesn't fal into my standard definition of 'clients' | 18:58 |
*** jcoufal has joined #openstack-dev | 18:59 | |
*** gokrokve has quit IRC | 18:59 | |
gyee | jamielennox, I know for sure there are Java clients out there that validates the signature | 18:59 |
jamielennox | gyee: auth_token will need to know, at some point it would be nice to have that functionality on keystoneclient | 18:59 |
dolphm | morganfainberg: skimming it - i'm not opposed | 18:59 |
*** rpodolyaka1 has joined #openstack-dev | 18:59 | |
* dolphm afk | 18:59 | |
*** jistr has joined #openstack-dev | 18:59 | |
*** jgrimm has quit IRC | 19:00 | |
*** gokrokve has joined #openstack-dev | 19:00 | |
morganfainberg | dolphm, ok i'll target it, if it runs into issues we can punt it back to J1 | 19:00 |
gyee | morganfainberg, ++ | 19:00 |
*** jgrimm has joined #openstack-dev | 19:00 | |
*** Mandell has joined #openstack-dev | 19:00 | |
*** rpodolyaka1 has left #openstack-dev | 19:00 | |
*** ramishra_ has quit IRC | 19:02 | |
*** byeager has quit IRC | 19:03 | |
*** cagrev has quit IRC | 19:03 | |
*** jckasper has joined #openstack-dev | 19:04 | |
*** jpomero has joined #openstack-dev | 19:04 | |
*** cadenzajon has joined #openstack-dev | 19:04 | |
*** byeager has joined #openstack-dev | 19:04 | |
*** cagrev has joined #openstack-dev | 19:05 | |
jamielennox | gyee: AdminToken? i was going to call it TokenEndpoint but it shounds funny | 19:05 |
*** markmcclain1 has joined #openstack-dev | 19:05 | |
gyee | jamielennox, StaticToken? | 19:05 |
jamielennox | gyee: it needs to be given the endpoint as well though | 19:06 |
*** dvarga is now known as dvarga|away | 19:06 | |
gyee | admin token is really a static token | 19:06 |
*** dvarga|away is now known as dvarga | 19:06 | |
*** markmcclain has quit IRC | 19:06 | |
jamielennox | gyee: it's not a good sign that i missed that and no tests failed | 19:07 |
gyee | jamielennox, I was merely suggesting a hack, we just need a way to differentiate it from the regular tokens | 19:07 |
*** markmcclain has joined #openstack-dev | 19:07 | |
jamielennox | gyee: it has a valid place in testing and it is used by the CLIs | 19:07 |
gyee | jamielennox, yeah, that's scary :) | 19:07 |
*** galstrom is now known as galstrom_zzz | 19:07 | |
gyee | jamielennox, btw, the static admin token may go away soon when we have a bootstrap process in place | 19:09 |
jamielennox | gyee: that would be cool | 19:10 |
jamielennox | gyee: how are we expecting to bootstrap though/ | 19:10 |
*** markmcclain1 has quit IRC | 19:10 | |
gyee | jamielennox, like create a real user in the *root* domain/project or something | 19:11 |
*** sarob has joined #openstack-dev | 19:11 | |
ayoung | gyee, adding the -compress flag : | 19:11 |
ayoung | -rw-rw-r--. 1 ayoung ayoung 705 Feb 11 14:10 auth_token_scoped_expired.pem | 19:11 |
ayoung | -rw-rw-r--. 1 ayoung ayoung 2732 Feb 10 10:47 auth_token_scoped_expired.pem.orig | 19:11 |
ayoung | orig is uncompressed | 19:11 |
gyee | ayoung, w00t! | 19:11 |
ayoung | yeah...this can be a drop in replacement, except for the MII thing | 19:11 |
morganfainberg | ayoung, do you need to explicitly -uncompress ? | 19:11 |
ayoung | morganfainberg, let me see , but I suspect not | 19:12 |
*** baoli has quit IRC | 19:12 | |
*** michchap has joined #openstack-dev | 19:12 | |
*** amuller has quit IRC | 19:12 | |
gyee | morgainfainberg, no need to, openssl handles it internal I think | 19:13 |
*** praneshp has quit IRC | 19:14 | |
*** michchap_ has quit IRC | 19:14 | |
*** coasterz has quit IRC | 19:14 | |
*** radez_g0n3 is now known as radez | 19:14 | |
*** coasterz has joined #openstack-dev | 19:15 | |
*** jprovazn has joined #openstack-dev | 19:15 | |
*** evgenyf has quit IRC | 19:15 | |
*** jrist has joined #openstack-dev | 19:15 | |
*** fabiomorais has quit IRC | 19:16 | |
ayoung | morganfainberg, yeah, looks like it needs an explict uncompress | 19:16 |
morganfainberg | ayoung, ick :( | 19:16 |
ayoung | I can do that, and fall back if it is not compressed | 19:16 |
*** coolsvap has quit IRC | 19:17 | |
*** buzztroll has quit IRC | 19:17 | |
ayoung | morganfainberg, I have a couple other changes to make: I am going to stop doing the PEM format, and instead do DER and a self BASE64 encode | 19:17 |
*** carl_baldwin has joined #openstack-dev | 19:18 | |
ayoung | that will be more URL safe etc | 19:18 |
morganfainberg | ayoung, makes sense | 19:18 |
*** dstanek has quit IRC | 19:18 | |
*** buzztrol_ has joined #openstack-dev | 19:18 | |
ayoung | but this can, I think, go in as a stand alone commit. Gonna abandon the other. This one might have backport potential | 19:18 |
*** hartsocks has quit IRC | 19:18 | |
*** praneshp has joined #openstack-dev | 19:19 | |
*** moted has joined #openstack-dev | 19:19 | |
*** jrist has quit IRC | 19:20 | |
*** jp_at_hp has quit IRC | 19:21 | |
*** dstanek has joined #openstack-dev | 19:24 | |
*** ssurana has quit IRC | 19:24 | |
*** READ10 has joined #openstack-dev | 19:26 | |
*** READ10 has quit IRC | 19:26 | |
*** yeylon__ has joined #openstack-dev | 19:26 | |
*** READ10 has joined #openstack-dev | 19:26 | |
dstanek | i seem to have been disconnected... | 19:27 |
dstanek | anyone else notice that the keystone tests are taking much longer to run? | 19:27 |
*** fabiog has quit IRC | 19:28 | |
*** igor___ has quit IRC | 19:29 | |
*** yeylon_ has quit IRC | 19:29 | |
ayoung | dstanek, did you to a laptop upgrade? | 19:30 |
*** pmathews has quit IRC | 19:30 | |
ayoung | http://adam.younglogic.com/2012/06/sqlite-unit-tests/ | 19:30 |
*** tanisdl has joined #openstack-dev | 19:30 | |
*** jmontemayor has joined #openstack-dev | 19:30 | |
*** pablosan has joined #openstack-dev | 19:32 | |
*** omachace has quit IRC | 19:32 | |
*** tiamar has quit IRC | 19:32 | |
*** marcoemorais has quit IRC | 19:33 | |
*** sarob has quit IRC | 19:33 | |
*** mlavalle has joined #openstack-dev | 19:34 | |
jamielennox | ayoung: if you add -decompress to a CMS that isn't compressed does it work? | 19:36 |
jamielennox | ayoung: also it doesn't give MII anymore? | 19:37 |
*** pmathews has joined #openstack-dev | 19:37 | |
ayoung | jamielennox, fairly certain it does not work, but haven't tested yet | 19:37 |
jamielennox | ayoung: that's a pain, it would make upgrade easy | 19:38 |
ayoung | jamielennox, I'm going to grandfather in the existing token format, but subsume it under the new code | 19:38 |
ayoung | sI'll assume new code, but if it fails, fall back to the old | 19:38 |
ayoung | instead of "MII" I'll just base64 decode | 19:38 |
*** marcoemorais has joined #openstack-dev | 19:38 | |
ayoung | to see if it is an ASN1 token | 19:38 |
ayoung | I think I can make it pretty simple. Not sure if I'll have it ready today | 19:39 |
*** yeylon__ has quit IRC | 19:39 | |
*** mrunge has quit IRC | 19:39 | |
*** tjones has joined #openstack-dev | 19:40 | |
*** bauzas has joined #openstack-dev | 19:41 | |
*** enykeev has quit IRC | 19:41 | |
*** rods has joined #openstack-dev | 19:41 | |
*** ruhe_ has joined #openstack-dev | 19:41 | |
*** tjones has quit IRC | 19:42 | |
*** jamielennox is now known as jamielennox|away | 19:43 | |
*** jamielennox|away is now known as jamielennox | 19:43 | |
*** aditirav has quit IRC | 19:44 | |
jamielennox | gyee: so we don't need an admin plugin just yet, at least for compatibility | 19:44 |
*** dstanek has quit IRC | 19:44 | |
jamielennox | if you make a client that has a token and endpoint specified then it will never call out to authenticate and so our plugins are never run | 19:44 |
*** rods has quit IRC | 19:44 | |
jamielennox | i'd apparently thought of that at some point :) | 19:44 |
*** rods has joined #openstack-dev | 19:44 | |
gyee | jamielennox, good! | 19:46 |
*** otherwiseguy has quit IRC | 19:47 | |
*** doug_shelley66 has quit IRC | 19:47 | |
*** doug_shelley66 has joined #openstack-dev | 19:47 | |
jamielennox | gyee: dolphm suggested a trusts mix-in approach at some point - i've got no idea how that would work | 19:47 |
jamielennox | any ideas for how to handle trusts or just keep a trust_id param? | 19:48 |
*** jpomero has quit IRC | 19:48 | |
*** novas0x2a|laptop has joined #openstack-dev | 19:49 | |
*** saju_m has quit IRC | 19:49 | |
*** dstanek has joined #openstack-dev | 19:49 | |
gyee | jamielennox, I think he meant to trust as an interface, to support oauth and trust and whatever comes along | 19:49 |
gyee | s/to trust/trust/ | 19:49 |
jamielennox | my thoughts with oauth was that they would just be a new plugin in v3 | 19:49 |
jamielennox | is that enough? | 19:50 |
jamielennox | stevemar: ^ | 19:50 |
gyee | perhaps something like TrustAUth(**kwargs) | 19:50 |
jamielennox | stevemar: does oauth fit as another plugin like those in: https://review.openstack.org/#/c/68007/5/keystoneclient/auth/identity/v3.py | 19:50 |
*** ruhe_ has quit IRC | 19:50 | |
jamielennox | gyee: but a trust is a parameter to another method of authenticating | 19:51 |
gyee | oauth needs more than just a trust ID | 19:51 |
jamielennox | gyee: so when you use a trust you still need to provide either a user/pass or existing token to authenticate with | 19:51 |
stevemar | jamielennox, that's my plan for it | 19:51 |
*** saju_m has joined #openstack-dev | 19:51 | |
gyee | jamielennox, for trust API yes, but for oauth stevemar is the expert | 19:52 |
stevemar | jamielennox, looking | 19:52 |
*** ssurana has joined #openstack-dev | 19:52 | |
jamielennox | gyee: but to my understanding oauth is a standalone way of authenticating | 19:52 |
*** tjones has joined #openstack-dev | 19:52 | |
jamielennox | you provide your tokens in a similar way to what you would a user/pass | 19:53 |
stevemar | jamielennox, I think I can plug it in | 19:53 |
gyee | jamielennox, that's my understanding as well | 19:53 |
*** markmc has joined #openstack-dev | 19:53 | |
*** bhuvan has quit IRC | 19:53 | |
*** gokrokve has quit IRC | 19:53 | |
stevemar | i might have to change fetch_auth_ref a bit | 19:54 |
stevemar | but it should be fine | 19:54 |
gyee | jamielennox, we're good then, since stevemar says OK | 19:54 |
stevemar | jamielennox, i'll send you a paste, 1 sec | 19:54 |
gyee | otherwise, we'll let him deal with monkeypatching! :) | 19:54 |
*** gokrokve has joined #openstack-dev | 19:54 | |
stevemar | nooo | 19:54 |
jamielennox | stevemar: that should be ok - do you know how? | 19:54 |
stevemar | jamielennox, gyee http://paste.openstack.org/show/64356/ | 19:54 |
jamielennox | gyee: cool, i addressed most of your comments and i'll put up one with some the small fixes later | 19:55 |
*** gokrokve_ has joined #openstack-dev | 19:55 | |
stevemar | jamielennox, i need to change auth and methods, which it looks like I can do | 19:55 |
gyee | stevemar, jamielennox, awesome! | 19:55 |
*** ruhe- has joined #openstack-dev | 19:55 | |
*** yeylon__ has joined #openstack-dev | 19:55 | |
jamielennox | stevemar: yea that is all that a v3 plugin should need to do, add a new method identifier and the data for that method | 19:56 |
jamielennox | the plugin should give you that | 19:56 |
*** jgrimm has quit IRC | 19:56 | |
stevemar | jamielennox, just make sure I have an easy entry point for testing :) i don't want to have to bang my head on a wall for that | 19:56 |
ayoung | bknudson, dolphm do either of you know why we have this function, and if it is OK to Axe it? \https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/tests/test_auth_token_middleware.py#L1695 | 19:56 |
*** ruhe- has quit IRC | 19:56 | |
ayoung | looks like a vestige of old badness, and it is causing my test runs to fail when I run just a single package | 19:57 |
bknudson | ayoung: it's required for testresources | 19:57 |
*** ianw has joined #openstack-dev | 19:57 | |
*** ruhe has quit IRC | 19:57 | |
ayoung | bknudson, something is wrong then | 19:57 |
jamielennox | ayoung: yep what bknudson said | 19:57 |
bknudson | ayoung: yes, it shouldn't cause a single package test to fail... | 19:57 |
*** jprovazn is now known as jprovazn_afk | 19:57 | |
jamielennox | and it measn that nose won't work | 19:57 |
bknudson | ayoung: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/tests/client_fixtures.py#L44 | 19:58 |
gyee | jamielennox, I have to run, will review them later | 19:58 |
*** gyee has quit IRC | 19:58 | |
*** gokrokve has quit IRC | 19:58 | |
*** ruhe has joined #openstack-dev | 19:58 | |
ayoung | why do I get this error then? http://fpaste.org/76250/48702139/ | 19:59 |
*** wpward has joined #openstack-dev | 19:59 | |
*** gokrokve_ has quit IRC | 19:59 | |
*** gokrokve has joined #openstack-dev | 20:00 | |
*** tanisdl has quit IRC | 20:00 | |
*** ArxCruz has quit IRC | 20:00 | |
*** gokrokve_ has joined #openstack-dev | 20:01 | |
*** rfolco has quit IRC | 20:01 | |
ayoung | bknudson, ^^ | 20:01 |
*** lbragstad has quit IRC | 20:01 | |
wpward | @armax, are you available to chat? Wanted to discuss the MechanismDriverError fix I have out for review at https://review.openstack.org/#/c/69748/ | 20:01 |
jamielennox | ayoung: nose doesn't support the load_tests protocol | 20:01 |
ayoung | ah... | 20:01 |
jamielennox | ayoung: try python -m testtools.run discover | 20:01 |
bknudson | ayoung: how are you running it? | 20:01 |
jamielennox | or the test name instead of discvoer | 20:01 |
ayoung | jamielennox, running from inside ecplise with/usr/bin/nose | 20:02 |
*** jistr has quit IRC | 20:02 | |
jamielennox | ayoung: hmm, can't help you with eclipse | 20:02 |
*** thedodd has quit IRC | 20:02 | |
ayoung | jamielennox, it is just a command line exec | 20:02 |
ayoung | how would I run a specific test, then | 20:02 |
*** carl_baldwin has quit IRC | 20:03 | |
ayoung | python -m testtools.run keystoneclient.tests.test_auth_token_middleware | 20:03 |
jamielennox | python -m testtools.run keystoneclient.tests.test_auth_token_middleware.class_name.test_name | 20:03 |
armax | upward, wouldn't the review be a better place? | 20:03 |
armax | wpward | 20:03 |
*** henrynash has quit IRC | 20:03 | |
ayoung | jamielennox, how about all tests in a file? | 20:03 |
*** saju_m has quit IRC | 20:04 | |
bknudson | .tox/py27/bin/python -m testtools.run keystoneclient.tests.test_auth_token_middleware -- Ran 164 tests in 2.171s | 20:04 |
wpward | Possibly, but given the short timeframe left of getting things into this release vs the alternative you proposed, I thought maybe here would be better. But I can keep it in the review if you like. | 20:04 |
*** gokrokve has quit IRC | 20:04 | |
*** carl_baldwin has joined #openstack-dev | 20:05 | |
jamielennox | yep just drop test_name | 20:05 |
*** saju_m has joined #openstack-dev | 20:05 | |
ayoung | bknudson, heh, it ran so fast I thought it failed | 20:05 |
jamielennox | unfortunately it doesn't work if you drop file name as well, then you need to use discover | 20:05 |
ayoung | that is ok | 20:05 |
bknudson | ayoung: would be nice if keystone tests ran so fast. | 20:06 |
*** henrynash has joined #openstack-dev | 20:06 | |
dstanek | ayoung: i'm going to give that a try to see if it helps, but they are taking about 4 times as long on the same machine | 20:09 |
*** Oneiroi has quit IRC | 20:09 | |
*** ijw has quit IRC | 20:09 | |
*** ijw has joined #openstack-dev | 20:10 | |
*** dperaza has joined #openstack-dev | 20:11 | |
*** xga has joined #openstack-dev | 20:13 | |
*** ijw has quit IRC | 20:14 | |
tellesnobrega | vishy: hi, in devstack, where can i find the data that is used to create entries for keystone? | 20:14 |
*** jckasper has quit IRC | 20:14 | |
*** jckasper has joined #openstack-dev | 20:15 | |
*** jpomero has joined #openstack-dev | 20:16 | |
vishy | tellesnobrega: https://github.com/openstack-dev/devstack/blob/master/files/keystone_data.sh | 20:16 |
*** gokrokve_ has quit IRC | 20:16 | |
*** cadenzajon has quit IRC | 20:16 | |
*** gokrokve has joined #openstack-dev | 20:16 | |
*** cagrev has quit IRC | 20:16 | |
tellesnobrega | vishy: thanks | 20:17 |
*** henrynash has quit IRC | 20:17 | |
*** Oneiroi has joined #openstack-dev | 20:17 | |
*** cadenzajon has joined #openstack-dev | 20:17 | |
*** moted has quit IRC | 20:18 | |
*** xga has quit IRC | 20:18 | |
*** mdomsch has quit IRC | 20:19 | |
*** jcoufal has quit IRC | 20:19 | |
*** Alexei_987 has quit IRC | 20:20 | |
*** spzala has joined #openstack-dev | 20:20 | |
tellesnobrega | vishy: i've been there but didnt find what im looking for. I'm looking at creating tenants, but there i can only find the names, im looking for other information from the table, like domain_id and other stuff, since i added a new colunm and i need to put that data in | 20:20 |
*** jckasper_ has joined #openstack-dev | 20:20 | |
*** gokrokve has quit IRC | 20:21 | |
vishy | tellesnobrega: well it would have to be added to keystoneclient | 20:22 |
*** epim has quit IRC | 20:22 | |
*** marcoemorais has quit IRC | 20:22 | |
*** wpward has left #openstack-dev | 20:22 | |
tellesnobrega | vishy: i see, thanks | 20:22 |
jamielennox | tellesnobrega: what exactly are you missing/trying to do/ | 20:22 |
*** galstrom_zzz is now known as galstrom | 20:23 | |
*** jckasper has quit IRC | 20:24 | |
stevemar | tellesnobrega, i think you mean this stuff: https://github.com/openstack-dev/devstack/blob/master/lib/keystone#L263 | 20:24 |
*** harlowja_away is now known as harlowja | 20:24 | |
tellesnobrega | jamielennox: i added a new column to projects in keystone, and when im starting devstack i get an error because it is a fk and it breaks with the data that is passed, because there are n columns and n-1 values, so i need include the missing value | 20:25 |
*** jcoufal has joined #openstack-dev | 20:25 | |
jamielennox | tellesnobrega: so i'm not sure that having that as a FK makes sense for that reason | 20:26 |
*** eglynn has joined #openstack-dev | 20:26 | |
jamielennox | ie as a required column | 20:26 |
*** denis_makogon_ has joined #openstack-dev | 20:26 | |
jamielennox | is the column exposed from the REST API? | 20:26 |
tellesnobrega | stevemar: yes, i looked through it but i need to change the insertion | 20:26 |
tellesnobrega | jamielennox: i created a column called parent_project_id, it needs to reference a project_id and it can be null | 20:27 |
*** dvarga is now known as dvarga|away | 20:27 | |
*** dvarga|away is now known as dvarga | 20:27 | |
jamielennox | all of the managers in keystoneclient should support arbitrary kwargs such that if you need to add extra information to a POST call or something you can just specify it as kwargs and it will be sent through | 20:27 |
jamielennox | tellesnobrega: so putting a default NULL on the SQL table should fix that | 20:28 |
jamielennox | (you need to default to the current behaviour) | 20:28 |
jamielennox | tellesnobrega: or somewhere in the project or tenant creating code in keystone pass through a None value for parent_project_id - but it doesn't sound like a client problem | 20:29 |
tellesnobrega | jamielennox: i see. i'll take a look into taht | 20:29 |
tellesnobrega | jamielennox: thansk | 20:29 |
tellesnobrega | thanks | 20:29 |
jamielennox | tellesnobrega: no problem, just remember that everything you add has to be additional. You can't add new required parameters to the API because it won't be backwards compatible | 20:30 |
tellesnobrega | jamielennox: i added as nullable=true, i think the default value is wrong | 20:31 |
*** cagrev has joined #openstack-dev | 20:31 | |
*** jcoufal has quit IRC | 20:31 | |
*** lbragstad has joined #openstack-dev | 20:31 | |
*** marcoemorais has joined #openstack-dev | 20:31 | |
*** aveiga has quit IRC | 20:32 | |
*** sushils has joined #openstack-dev | 20:32 | |
jamielennox | tellesnobrega: nullable=True means that the value can be NULL it doesn't say anything about the default value | 20:32 |
*** wendar has joined #openstack-dev | 20:32 | |
*** saju_m has quit IRC | 20:32 | |
jamielennox | tellesnobrega: you will need to set default=None as well (i think the arg is called default) | 20:32 |
tellesnobrega | jamielennox: i know, just found it now. :D thanks again | 20:33 |
jamielennox | tellesnobrega: np | 20:33 |
*** chris_johnson is now known as wchrisj|away | 20:33 | |
*** zzelle has joined #openstack-dev | 20:33 | |
tellesnobrega | i will give a go again and see if it fixed | 20:33 |
*** belmoreira has quit IRC | 20:33 | |
*** ramishra has joined #openstack-dev | 20:34 | |
*** rodrigods has joined #openstack-dev | 20:34 | |
*** rodrigods has joined #openstack-dev | 20:34 | |
*** sarob has joined #openstack-dev | 20:35 | |
*** rodrigods has quit IRC | 20:35 | |
morganfainberg | bknudson, i'm slowly working on getting tests happier!!! | 20:36 |
*** wchrisj|away is now known as chris_johnson | 20:36 | |
morganfainberg | bknudson, but it's slow | 20:36 |
bknudson | morganfainberg: it's going to be a long slog. | 20:37 |
morganfainberg | bknudson, i know :( | 20:37 |
bknudson | and more tests are going to get added while you're trying to fix it. | 20:37 |
morganfainberg | bknudson, yeah i know | 20:37 |
morganfainberg | bknudson, it makes it hard | 20:37 |
morganfainberg | bknudson, but we can only do so much | 20:38 |
*** henrynash has joined #openstack-dev | 20:38 | |
morganfainberg | bknudson, i mean... the alternative is to make a massive patch bomb to fix it all at once. | 20:38 |
morganfainberg | bknudson, and i don't like it, but we could try and do that instead :P | 20:38 |
*** sushils has quit IRC | 20:38 | |
*** eglynn has quit IRC | 20:38 | |
*** moted has joined #openstack-dev | 20:39 | |
*** ramishra has quit IRC | 20:39 | |
bknudson | morganfainberg: that would never fly | 20:39 |
morganfainberg | bknudson, i know | 20:39 |
morganfainberg | bknudson, it's why i didn't even try | 20:39 |
bknudson | morganfainberg: you saw that your change to oslo-incubator fixture is merged ... and I posted a sync | 20:39 |
morganfainberg | bknudson, yeah, i tried a full oslo sync patchset... no unit test errors | 20:40 |
*** RajeshMohan has quit IRC | 20:40 | |
jamielennox | dtroyer: ping | 20:40 |
*** sarob has quit IRC | 20:40 | |
bknudson | morganfainberg: I saw that ... will have to look at it. | 20:40 |
morganfainberg | bknudson, i'll +2 yours in either case (just saw it last night) | 20:40 |
morganfainberg | bknudson, just was on no battery so couldn't review ;) | 20:41 |
*** RajeshMohan has joined #openstack-dev | 20:41 | |
bknudson | morganfainberg: no problem... I'm not sure if it's best to keep syncing each module or do the whole thing | 20:41 |
bknudson | if you were able to do the sync without any failures maybe it's best to just sync it | 20:41 |
morganfainberg | bknudson, if we can sync the whole thing, i'd rather do that | 20:41 |
morganfainberg | bknudson, yeah https://review.openstack.org/#/c/72266/ | 20:42 |
morganfainberg | bknudson, it .. all seems to work | 20:42 |
morganfainberg | bknudson, i'd advocate a complete sync unless there are incompatible changes somewhere... then we exclude that module and work on fixing/syncing separately | 20:42 |
bknudson | morganfainberg: you'll have to go through all of these and update sample.conf with any changed/new config options. | 20:42 |
morganfainberg | bknudson, oh gah. true | 20:43 |
*** pschaef has quit IRC | 20:43 | |
morganfainberg | bknudson, hehe, yeah we need to do what the other projects are doing... auto-gen the sample conf | 20:43 |
*** cnesa has joined #openstack-dev | 20:43 | |
morganfainberg | bknudson, or at least nova was doing that for a while | 20:43 |
*** kgriffs is now known as kgriffs_afk | 20:43 | |
morganfainberg | bknudson, leverage the help= arg in the options and make this less of a bear to deal with | 20:43 |
*** abhirc has joined #openstack-dev | 20:44 | |
bknudson | morganfainberg: lance looked into it for a little while but didn't get too far. | 20:44 |
morganfainberg | bknudson, it shouldn't be too hard to do. we can probably just snake some of the code used by the other project(s) | 20:44 |
morganfainberg | bknudson, we need to provide help text etc if we want the documentation we have, but otherwise, i think it shouldn't be too big a deal to do | 20:45 |
bknudson | morganfainberg: seems like it, but lance ran into a problem... maybe it was just the missing help=. | 20:45 |
*** morgabra has joined #openstack-dev | 20:45 | |
morganfainberg | bknudson, likely. | 20:45 |
*** stevemar has quit IRC | 20:45 | |
*** denis_makogon_ is now known as denis_makogon | 20:45 | |
*** erecio has joined #openstack-dev | 20:46 | |
*** erecio has quit IRC | 20:46 | |
morganfainberg | bknudson, looks like no new options added in sqlalchemy there, (at least not seeing any) i'm looking through each file now | 20:46 |
morganfainberg | bknudson, maybe some of the options were already sync'd | 20:46 |
morganfainberg | and sample not updated? | 20:46 |
bknudson | morganfainberg: https://review.openstack.org/#/c/71311/ | 20:47 |
*** DinaBelova is now known as DinaBelova_ | 20:47 | |
bknudson | morganfainberg: the help text was corrected. | 20:47 |
morganfainberg | ah i see | 20:47 |
morganfainberg | that explains it | 20:47 |
bknudson | this is why we need the auto-gen. | 20:47 |
morganfainberg | bknudson, ++ | 20:47 |
morganfainberg | let me see how hard it'll be to implement autogen | 20:48 |
morganfainberg | might be trivial | 20:48 |
*** epim has joined #openstack-dev | 20:48 | |
*** abhirc has quit IRC | 20:49 | |
*** abhirc has joined #openstack-dev | 20:50 | |
tellesnobrega | jamielennox: it worked, thanks :) | 20:53 |
jamielennox | tellesnobrega: no worries | 20:54 |
*** jprovazn_afk has quit IRC | 20:55 | |
*** byeager has quit IRC | 20:55 | |
*** galstrom is now known as galstrom_zzz | 20:56 | |
*** stevemar has joined #openstack-dev | 20:56 | |
*** drewlander has quit IRC | 20:57 | |
*** jsavak has joined #openstack-dev | 20:57 | |
*** henrynash has quit IRC | 20:58 | |
*** amcrn has quit IRC | 21:00 | |
*** raildo has quit IRC | 21:00 | |
*** joesavak has quit IRC | 21:00 | |
*** joesavak has joined #openstack-dev | 21:00 | |
*** godara has quit IRC | 21:01 | |
*** amcrn has joined #openstack-dev | 21:01 | |
*** jdob_ has joined #openstack-dev | 21:01 | |
*** marcoemorais has quit IRC | 21:02 | |
*** marcoemorais has joined #openstack-dev | 21:02 | |
*** marcoemorais has quit IRC | 21:02 | |
*** marcoemorais has joined #openstack-dev | 21:03 | |
*** jsavak has quit IRC | 21:03 | |
ayoung | dstanek, any luck? | 21:04 |
*** e0ne has quit IRC | 21:07 | |
*** byeager has joined #openstack-dev | 21:09 | |
*** galstrom_zzz is now known as galstrom | 21:09 | |
*** sarob has joined #openstack-dev | 21:10 | |
*** carl_baldwin has quit IRC | 21:10 | |
morganfainberg | bknudson, i have an almost working auto-gen | 21:10 |
morganfainberg | bknudson, just need a lot of help text | 21:10 |
morganfainberg | bknudson, i'll post a review up w/ it so we can work on that | 21:11 |
morganfainberg | bknudson, should be quiick/easy and make these oslo syncs etc much much better | 21:11 |
*** tdruiva has quit IRC | 21:11 | |
bknudson | morganfainberg: it would be great if we could make oslo-incubator test new changes against keystone so we don't get out of date again. | 21:12 |
morganfainberg | bknudson, i'll need to create an entry point we can load up though since we do config options a bit "odd" compared to other projects | 21:12 |
bknudson | test changes in their check/gate and then propose the change to keystone. | 21:12 |
*** dvarga has quit IRC | 21:12 | |
*** sgrasley has joined #openstack-dev | 21:12 | |
morganfainberg | bknudson, will have something post meeting (doing cross project atm) | 21:13 |
morganfainberg | bknudson, also.. https://review.openstack.org/#/c/71683/ please review so we can merge today if possible :) | 21:13 |
morganfainberg | bknudson, want to get the havana version into enxt stable | 21:13 |
morganfainberg | ayoung, stevemar, dstanek, ^ on the review | 21:14 |
*** jdob_ has quit IRC | 21:15 | |
*** jgrimm has joined #openstack-dev | 21:15 | |
ayoung | morganfainberg, how does that work | 21:16 |
morganfainberg | ayoung, need to merge that to master before proposal for stable/havana goes through | 21:16 |
*** kgriffs_afk is now known as kgriffs | 21:16 | |
ayoung | morganfainberg, how does it work | 21:17 |
morganfainberg | ayoung, the code? | 21:17 |
ayoung | morganfainberg, yes | 21:17 |
ayoung | my head is in CMS land | 21:17 |
morganfainberg | ayoung, i'll explain after this meeding, stay in CMS land | 21:17 |
ayoung | deal | 21:17 |
*** tdruiva has joined #openstack-dev | 21:17 | |
*** mlegault__ has quit IRC | 21:17 | |
morganfainberg | can chase down stevemar, dstanek, and jamielennox if needed too :)_ | 21:17 |
jamielennox | hmm | 21:18 |
*** carl_baldwin has joined #openstack-dev | 21:18 | |
dstanek | morganfainberg: i'll take a look again | 21:18 |
stevemar | morganfainberg, who what? i know nothing. | 21:18 |
morganfainberg | stevemar, phsaw, stop fibbing :P | 21:19 |
morganfainberg | bknudson, ok, so the only issue i see atm is that we have the odd config registration method | 21:20 |
*** baoli has joined #openstack-dev | 21:20 | |
*** baoli has quit IRC | 21:20 | |
bknudson | morganfainberg: what's odd about it? it seems to work. | 21:21 |
morganfainberg | bknudson, i think i need to create some kind of entrypoint that does .configure() and then does the generator | 21:21 |
morganfainberg | bknudson, we don't register the options, so the auto-gen doesn't see them | 21:21 |
morganfainberg | bknudson, so i just need to wrap the config generator to call our .configure() thing | 21:21 |
bknudson | morganfainberg: We used to register the options at import time. | 21:21 |
*** baoli has joined #openstack-dev | 21:21 | |
morganfainberg | bknudson, right and i don't want to go back to that | 21:21 |
morganfainberg | bknudson, but that is the assumption the auto-gen code uses | 21:21 |
bknudson | morganfainberg: please don't! | 21:21 |
bknudson | morganfainberg: bad assumption. Fix the tool | 21:22 |
*** sarob_ has joined #openstack-dev | 21:22 | |
morganfainberg | bknudson, well.. not so simple | 21:22 |
bknudson | morganfainberg: right... how would it find the options? | 21:22 |
morganfainberg | bknudson, easier solution, make a wrapper for the generator that issues our .configure() | 21:22 |
morganfainberg | bknudson, i uses the CONF object iot looks like | 21:22 |
*** erkules_ is now known as erkules | 21:22 | |
morganfainberg | looking into what nova does, make sure i'm doing it "right" | 21:23 |
bknudson | morganfainberg: we do some other weird things, too... like set the sql defaults and logging defaults. | 21:23 |
morganfainberg | bknudson, yesh | 21:23 |
bknudson | maybe that could be put into a function | 21:23 |
morganfainberg | bknudson, i think i can capture it all | 21:23 |
morganfainberg | bknudson, that was my thought | 21:23 |
morganfainberg | bknudson, this autogen will not capture the magic-automatic options for auth-plugins | 21:23 |
bknudson | I had started looking at that but then gave up. | 21:24 |
morganfainberg | bknudson, but it should catch my new options i created | 21:24 |
morganfainberg | bknudson, which, is a bit cleaner imo (as the sample) | 21:24 |
bknudson | morganfainberg: do the oslo-incubator parts auto-register their options? | 21:24 |
morganfainberg | bknudson, yes | 21:24 |
bknudson | boo | 21:24 |
*** sarob has quit IRC | 21:24 | |
*** markmc has quit IRC | 21:24 | |
morganfainberg | bknudson, like i said, i can do this with a small wrapper for the generator code | 21:25 |
*** irenab has quit IRC | 21:25 | |
morganfainberg | bknudson, import and at import time do our .configure() | 21:25 |
morganfainberg | bknudson, it'll live in keystone.common.config_generator or something | 21:25 |
morganfainberg | bknudson, let me see if i can make this work | 21:25 |
dstanek | morganfainberg: i already had it open in a tab so i just went over it again and gave it a +2 | 21:25 |
morganfainberg | dstanek, cool | 21:26 |
morganfainberg | dstanek, much appreciated | 21:26 |
*** gyee has joined #openstack-dev | 21:26 | |
*** jamielennox is now known as jamielennox|away | 21:26 | |
*** ekhugen has joined #openstack-dev | 21:28 | |
*** xmltok has joined #openstack-dev | 21:28 | |
*** jamielennox|away is now known as jamielennox | 21:29 | |
dstanek | ayoung: running the test now with a tmpfs mount | 21:29 |
*** thedodd has joined #openstack-dev | 21:30 | |
*** yolanda has quit IRC | 21:30 | |
*** huats__ is now known as huats | 21:30 | |
*** ytwu has joined #openstack-dev | 21:30 | |
dstanek | ayoung: i thought that sqlite had a way to be all in memory already | 21:30 |
ayoung | dstanek, not that we can use | 21:30 |
ayoung | dstanek, migrations kill the database afterwards | 21:30 |
*** ijw has joined #openstack-dev | 21:31 | |
ayoung | with in memory sqlite, that erases everything | 21:31 |
ayoung | so no way to run the migrations | 21:31 |
dstanek | ayoung: ah | 21:31 |
ayoung | but we shoulld not need migrations, cuzx we do the model based approach | 21:31 |
ayoung | and I never quite closed the loop on that | 21:31 |
*** ytwu1 has quit IRC | 21:31 | |
ayoung | cuz running in ramdisk was fast enough | 21:31 |
dstanek | ayoung: also the path to keystone's tmp dir is incorrect (missing a keystone/ in there) | 21:31 |
*** kgriffs is now known as kgriffs_afk | 21:31 | |
ayoung | dstanek, on my blog? | 21:32 |
ayoung | dstanek, its morphed over time, I might have typod it. We used to put it in /tmp | 21:33 |
*** marcoemorais has quit IRC | 21:33 | |
dstanek | ayoung: i didn't realize that it was posted almost 2 years ago | 21:33 |
ayoung | dstanek, I've been doing this a long time | 21:33 |
*** henrynash has joined #openstack-dev | 21:34 | |
*** amcrn has quit IRC | 21:34 | |
*** ramishra has joined #openstack-dev | 21:34 | |
*** joadavis has joined #openstack-dev | 21:35 | |
*** gokrokve has joined #openstack-dev | 21:36 | |
*** cnesa has quit IRC | 21:36 | |
*** marekd is now known as marekd|away | 21:36 | |
bknudson | shouldn't our test temp files go in /tmp? | 21:37 |
*** rtheis has quit IRC | 21:38 | |
*** anniec has joined #openstack-dev | 21:39 | |
*** ramishra has quit IRC | 21:39 | |
*** sarob_ has quit IRC | 21:39 | |
dstanek | bknudson: as long as we name them with the pid i don't have a problem with that | 21:40 |
*** anniec has quit IRC | 21:40 | |
bknudson | dstanek: I might propose that change... some systems have /tmp on ramdisk already | 21:40 |
*** amcrn has joined #openstack-dev | 21:41 | |
*** beagles has quit IRC | 21:42 | |
*** jnoller_ has quit IRC | 21:42 | |
dstanek | ayoung: it was a little faster, but not much; my disk is ssd so it's already pretty fast | 21:42 |
*** jhesketh_ has joined #openstack-dev | 21:43 | |
*** markmcclain has quit IRC | 21:44 | |
*** thomasem has quit IRC | 21:45 | |
*** marcoemorais has joined #openstack-dev | 21:47 | |
bknudson | dstanek: writing to ssd can be slower than regular disk | 21:47 |
*** abhirc has quit IRC | 21:48 | |
*** tanisdl has joined #openstack-dev | 21:49 | |
morganfainberg | dstanek, bknudson, any reason to not +A https://review.openstack.org/#/c/71683/ ? have plus 2 from both of you | 21:49 |
*** sushils has joined #openstack-dev | 21:49 | |
bknudson | morganfainberg: I can't think of a reason | 21:51 |
*** doug-fish has quit IRC | 21:52 | |
morganfainberg | bknudson, mind +A it ? i don't think i should +A my own patch ;) | 21:52 |
stevemar | jaypipes, ping | 21:52 |
*** henrynash has quit IRC | 21:52 | |
*** tmclaugh[work] has quit IRC | 21:52 | |
bknudson | morganfainberg: you can +A your own patch as long as it meets the criteria. | 21:53 |
morganfainberg | bknudson, ok | 21:53 |
morganfainberg | bknudson, i always hesistated to do so | 21:53 |
morganfainberg | bknudson, will keep in mind | 21:53 |
*** henrynash has joined #openstack-dev | 21:53 | |
jaypipes | stevemar: pong (kinda here.... I'm deep in infra doo doo right now ;) | 21:53 |
*** kgriffs_afk is now known as kgriffs | 21:54 | |
*** arunkant has quit IRC | 21:54 | |
stevemar | jaypipes, hmm okay ... answer if you can.. if i specify PUT region/regionId with a parent that doesn't exist, it should 404 right? | 21:54 |
stevemar | jaypipes, currently that's not happening, which is why your tests are failing :( | 21:54 |
jaypipes | stevemar: yes, that's correct. I will try and look into a fix later, but I think dolphm had fixed that in another patch somewhere :( | 21:55 |
stevemar | jaypipes, i'll take a deeper look | 21:56 |
*** mohits has joined #openstack-dev | 21:56 | |
jaypipes | stevemar: cheers. sorry it's taken so long to fix that dang thing! :( | 21:56 |
stevemar | jaypipes, np dude | 21:57 |
*** mikeoutland has quit IRC | 21:57 | |
*** mikeoutland has joined #openstack-dev | 21:57 | |
*** sarob has joined #openstack-dev | 21:59 | |
stevemar | jaypipes, hoping i fixed it for ya ... https://review.openstack.org/#/c/68981/5 | 22:00 |
*** sarob has quit IRC | 22:00 | |
*** sarob has joined #openstack-dev | 22:01 | |
*** ekhugen has quit IRC | 22:02 | |
*** RajeshMohan has quit IRC | 22:02 | |
*** prad has quit IRC | 22:02 | |
*** ijw_ has joined #openstack-dev | 22:03 | |
*** harlowja has quit IRC | 22:03 | |
*** RajeshMohan has joined #openstack-dev | 22:03 | |
*** peristeri has quit IRC | 22:03 | |
*** doug-fish has joined #openstack-dev | 22:04 | |
*** sarob has quit IRC | 22:06 | |
*** dstanek has quit IRC | 22:06 | |
*** ijw has quit IRC | 22:06 | |
*** sweston has quit IRC | 22:06 | |
*** prad has joined #openstack-dev | 22:07 | |
*** carl_baldwin has quit IRC | 22:08 | |
*** stevemar has quit IRC | 22:08 | |
*** jobewan has quit IRC | 22:09 | |
*** dstanek has joined #openstack-dev | 22:09 | |
*** xarses has quit IRC | 22:10 | |
dstanek | morganfainberg: i didn't see that it already had a +2 or I would have just went ahead with the +A | 22:10 |
morganfainberg | bknudson, ok i found an issue. we use a dict and the auto-gen thing is looking for lists | 22:10 |
morganfainberg | bknudson, with minor restructuring i can fix this. | 22:10 |
*** vijendar has quit IRC | 22:11 | |
morganfainberg | bknudson, but a bunch of this logic is assuming options are configured on import | 22:11 |
morganfainberg | *mutter* | 22:11 |
*** bswartz has quit IRC | 22:12 | |
bknudson | morganfainberg: it's very picky | 22:12 |
*** otherwiseguy has joined #openstack-dev | 22:12 | |
morganfainberg | bknudson, yeah | 22:12 |
*** jecarey has quit IRC | 22:12 | |
*** boris-42_ has quit IRC | 22:13 | |
*** anniec has joined #openstack-dev | 22:16 | |
*** eglynn has joined #openstack-dev | 22:16 | |
morganfainberg | bknudson, the assumption is that you don't define your options in one location like we do, but in each file that needs it | 22:16 |
morganfainberg | bknudson, i think that is what is tripping up the auto-gen tool | 22:16 |
morganfainberg | bknudson, we wrapped extra logic around it all. | 22:16 |
bknudson | morganfainberg: extra logic? to register a config option? seems like it should be pretty simple | 22:17 |
morganfainberg | bknudson, we have .configure() and a dict that we run through | 22:17 |
bknudson | oh, except for the generated options. | 22:17 |
morganfainberg | bknudson, and then add in the generated option(s) | 22:17 |
bknudson | morganfainberg: it would be good to get all that into a function anyways... or are you saying you don't need one? | 22:18 |
*** NearlyFunctional has quit IRC | 22:18 | |
morganfainberg | bknudson, the idea is that (for example) identity would define it's options in the identity files like how openstack.common.db.session does it | 22:18 |
*** e0ne has joined #openstack-dev | 22:18 | |
morganfainberg | bknudson, the generated options will never show up in the auto-gen sample config the way it is written | 22:18 |
morganfainberg | bknudson, it needs an actual config object that appears at import-time to put it in the sample conf afaict | 22:19 |
dstanek | morganfainberg, bknudson: is there an order to the sections in the sample keystone and paste config files? | 22:19 |
*** eglynn has quit IRC | 22:19 | |
morganfainberg | dstanek, [DEFAULT] at top | 22:19 |
morganfainberg | bknudson, other than that, not really | 22:19 |
morganfainberg | erm dstanek not bknudson | 22:19 |
bknudson | dstanek: I think paste-config is at the bottom of the keystone sample config file | 22:20 |
morganfainberg | bknudson, oh yeah | 22:20 |
bknudson | if we use the config file generator then it'll put them in some kind of order | 22:20 |
dstanek | ok, then i think i'm good; i just my extension stuff after the federation extension stuff | 22:20 |
*** abhirc has joined #openstack-dev | 22:21 | |
*** e0ne has quit IRC | 22:22 | |
bknudson | dstanek: quit trying to delete our .gitkeep! D keystone/tests/tmp/.gitkeep | 22:22 |
bknudson | it's like you mounted a tmpfs over it or something | 22:22 |
*** crank has quit IRC | 22:22 | |
morganfainberg | bknudson, i mean, i could make changes to the generator code i guess. but we're breaking with the general OS convention which is why it isn't as happy. | 22:23 |
*** sgordon has quit IRC | 22:23 | |
*** abhirc has quit IRC | 22:23 | |
*** abhirc has joined #openstack-dev | 22:24 | |
bknudson | morganfainberg: we could change keystone to match the general convenction | 22:24 |
*** noslzzp has quit IRC | 22:24 | |
morganfainberg | bknudson, i could make keystone.common.config register things on import again | 22:25 |
*** jecarey has joined #openstack-dev | 22:25 | |
bknudson | morganfainberg: that's too dangerous | 22:25 |
dstanek | bknudson: did i delete it? | 22:25 |
dstanek | bknudson: hmmm...so i did; i'll fix | 22:25 |
*** xarses has joined #openstack-dev | 22:25 | |
*** jtomasek has quit IRC | 22:26 | |
morganfainberg | bknudson, the typical convention would be, for example token options the manager needs would be registered by the .core file (on import) | 22:26 |
morganfainberg | bknudson, options get scattered around the code base, and registered (effectively) on-demand | 22:26 |
morganfainberg | bknudson, i don't like that | 22:26 |
morganfainberg | bknudson, i like what we have. | 22:26 |
*** jrist has joined #openstack-dev | 22:26 | |
*** galstrom is now known as galstrom_zzz | 22:27 | |
morganfainberg | bknudson, i can try and make the generator smarter, but i think we might be far enough astride from the typical use, it wont be accepted | 22:27 |
morganfainberg | dhellmann, ping | 22:27 |
dhellmann | morganfainberg: pong | 22:27 |
* morganfainberg summons dhellmann and his awesome oslo.config etc knowledge to the rescue | 22:28 | |
*** pcm_ has quit IRC | 22:28 | |
* dhellmann disavows any such knowledge | 22:28 | |
*** romcheg1 has quit IRC | 22:28 | |
*** cdub has quit IRC | 22:28 | |
morganfainberg | dhellmann, so, trying to get sample config auto generation for keystone...because manually maintaining it sucks | 22:28 |
dhellmann | ok | 22:28 |
*** mfer has quit IRC | 22:28 | |
morganfainberg | dhellmann, the issue is.. we don't do configs really the same way as the rest of OS | 22:28 |
*** romcheg1 has joined #openstack-dev | 22:28 | |
morganfainberg | we don't register opts on import | 22:28 |
*** dprince has quit IRC | 22:28 | |
*** abhirc has quit IRC | 22:28 | |
bknudson | because it's dangerous | 22:28 |
morganfainberg | ^ | 22:29 |
dhellmann | yay! | 22:29 |
dhellmann | a couple of options | 22:29 |
morganfainberg | dhellmann, so.. the config generator makes some broad assumptions | 22:29 |
dhellmann | 1. put the option definitions at module level, and register them at runtime | 22:29 |
morganfainberg | dhellmann, and wanted your input! | 22:29 |
dhellmann | 2. register one or more entry points that return the option definitions for the config generator | 22:29 |
*** cagrev has quit IRC | 22:30 | |
*** cdub has joined #openstack-dev | 22:30 | |
morganfainberg | dhellmann, so, something like stub_that_makes_opts_available_for_generator.py? | 22:30 |
dhellmann | that's the approach we're using in the oslo libraries, since we're providing options to apps that don't necessarily want to scan our source | 22:30 |
*** vladikr has quit IRC | 22:30 | |
* dhellmann looks for example in oslo.messaging | 22:30 | |
morganfainberg | bknudson, see this is why dhellmann is awesome | 22:30 |
dhellmann | http://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo/messaging/opts.py | 22:30 |
*** noslzzp has joined #openstack-dev | 22:31 | |
morganfainberg | dhellmann, oh the options don't need to be registered? | 22:31 |
dhellmann | nope | 22:31 |
morganfainberg | with the CONF object? | 22:31 |
morganfainberg | dhellmann, i totally mis-read that | 22:31 |
dhellmann | the config generator registers them with its copy I think | 22:31 |
morganfainberg | dhellmann, ok i can make this work then. | 22:31 |
*** dims has quit IRC | 22:31 | |
morganfainberg | dhellmann, hm. let me try and figure out how it determines groups. | 22:31 |
*** sweston has joined #openstack-dev | 22:32 | |
dhellmann | the entry point returns a list of (group, [options]) pairs | 22:32 |
morganfainberg | oh | 22:32 |
morganfainberg | ohhh | 22:32 |
morganfainberg | ok i think i see | 22:32 |
dhellmann | can you point me to an example of how you're registering options now? | 22:32 |
*** jobewan has joined #openstack-dev | 22:32 | |
morganfainberg | dhellmann, https://github.com/openstack/keystone/blob/master/keystone/common/config.py#L23 which is all registered at https://github.com/openstack/keystone/blob/master/keystone/common/config.py#L302 | 22:33 |
dhellmann | and the config generator isn't finding those? | 22:33 |
morganfainberg | we also have some magic opts that are created at runtime, but i can work around that. | 22:33 |
morganfainberg | dhellmann, not at all | 22:33 |
morganfainberg | i think it's the dict -> list | 22:33 |
dhellmann | oooh, yeah, that's it | 22:34 |
dhellmann | it wants one list | 22:34 |
morganfainberg | dhellmann, https://github.com/openstack/oslo-incubator/blob/master/openstack/common/config/generator.py#L172 | 22:34 |
*** Gordonz_ has joined #openstack-dev | 22:34 | |
morganfainberg | yeah | 22:34 |
*** jasdeepH has quit IRC | 22:34 | |
*** relaxdiego has quit IRC | 22:34 | |
dhellmann | you're all set to have the return value for that entry point | 22:34 |
dhellmann | return FILE_OPTIONS.items() | 22:34 |
morganfainberg | ah, yeah that is what i think i needed | 22:35 |
*** xarses has quit IRC | 22:35 | |
*** relaxdiego has joined #openstack-dev | 22:35 | |
morganfainberg | dhellmann, and that should make everything discoverable and happy (besides the massive lack of help= kwargs on our options) | 22:35 |
*** NearlyFunctional has joined #openstack-dev | 22:35 | |
*** ayoung has quit IRC | 22:35 | |
*** ramishra has joined #openstack-dev | 22:35 | |
morganfainberg | knowing how it determines the groups was the part my brain wasn't connnecting | 22:35 |
*** ctlaugh_ is now known as zz_ctlaugh | 22:35 | |
dhellmann | yep | 22:35 |
dhellmann | http://git.openstack.org/cgit/openstack/oslo.messaging/tree/setup.cfg#n53 | 22:35 |
morganfainberg | dhellmann, thanks dude, you saved me a headache... my brain hurts today already | 22:36 |
dhellmann | glad to be able to help! | 22:36 |
*** mohits_ has joined #openstack-dev | 22:36 | |
*** READ10 has quit IRC | 22:36 | |
*** Gordonz has quit IRC | 22:36 | |
*** bswartz has joined #openstack-dev | 22:38 | |
*** joesavak has quit IRC | 22:38 | |
*** achampion has quit IRC | 22:38 | |
*** apevec has joined #openstack-dev | 22:39 | |
apevec | morganfainberg, I see master is approved ! https://review.openstack.org/#/q/Ida39b4699ed6c568609a5121573fc3be5c4ab2f4,n,z | 22:39 |
bknudson | dhellmann: https://review.openstack.org/#/c/67664/ could use a review too -- you approved the dependent change. | 22:39 |
morganfainberg | apevec, i am in process of syncing the differences to havana | 22:39 |
morganfainberg | apevec, just running unit tests before posting :) | 22:40 |
*** mohits has quit IRC | 22:40 | |
dhellmann | bknudson: looking | 22:40 |
apevec | cool, that was my next question :) | 22:40 |
*** relaxdiego has quit IRC | 22:40 | |
*** ramishra has quit IRC | 22:40 | |
*** jpomero has quit IRC | 22:40 | |
apevec | morganfainberg, I'll be signing off but you should have few stable-maint around: dolphm, vishy | 22:40 |
apevec | full list here https://review.openstack.org/#/admin/groups/120,members | 22:41 |
morganfainberg | apevec, cool. | 22:41 |
morganfainberg | apevec, dhellmann also has interest in this, can have him jump on it | 22:41 |
morganfainberg | apevec, :) | 22:41 |
apevec | yep, he can +2 stable too | 22:41 |
*** marcoemorais has quit IRC | 22:41 | |
*** marcoemorais has joined #openstack-dev | 22:42 | |
*** noslzzp has quit IRC | 22:42 | |
dhellmann | morganfainberg, apevec : is that for https://review.openstack.org/#/c/66149/ ? | 22:43 |
*** Gordonz_ has quit IRC | 22:43 | |
*** jamieh has quit IRC | 22:43 | |
morganfainberg | dhellmann, yes | 22:43 |
*** dkranz has quit IRC | 22:43 | |
apevec | dhellmann, yes, new patchset is coming | 22:43 |
morganfainberg | dhellmann, master verison is approved. working on tests / sync for stable now to match | 22:43 |
morganfainberg | dhellmann, will be posted soon | 22:43 |
dhellmann | morganfainberg: ack, ping me when you're ready for a review | 22:43 |
*** topol has quit IRC | 22:44 | |
lbragstad | dolphm: think we would be able to leverage the test_notifier similar to the way nova tests their notifications? https://review.openstack.org/#/c/68548/16/keystone/tests/test_notifications.py | 22:45 |
*** noslzzp has joined #openstack-dev | 22:47 | |
dolphm | lbragstad: i haven't seen nova's approach.. looking | 22:47 |
*** sn6i23a has joined #openstack-dev | 22:47 | |
lbragstad | dolphm: linked in the comment | 22:47 |
*** dims has joined #openstack-dev | 22:47 | |
*** xarses has joined #openstack-dev | 22:48 | |
dolphm | lbragstad: hmm... i was referring to the entire method | 22:48 |
*** Chaser has quit IRC | 22:48 | |
*** sandywalsh has quit IRC | 22:48 | |
*** jhesketh__ has joined #openstack-dev | 22:48 | |
lbragstad | well I mean, isn't _assertNotifySent just checking something is sent on the queue? | 22:49 |
lbragstad | 'queue' | 22:49 |
lbragstad | and the notification is stored in the NOTIFICATIONS global in the test_notifier, so we could always read it back and verify the values | 22:49 |
*** Chaser has joined #openstack-dev | 22:49 | |
*** jckasper_ has quit IRC | 22:50 | |
morganfainberg | dhellmann, dolphm, updated patchset posted for https://review.openstack.org/#/c/66149/ | 22:50 |
*** ayoung has joined #openstack-dev | 22:50 | |
dolphm | lbragstad: that's sort of what we're doing, but wouldn't eliminate the complexity of the verification method | 22:50 |
*** jmckind has quit IRC | 22:51 | |
*** sweston has quit IRC | 22:51 | |
*** ramishra has joined #openstack-dev | 22:51 | |
dhellmann | morganfainberg: I think sdague would want that log message to not be an exception, but maybe an info or even debug | 22:52 |
*** mwagner_lap has quit IRC | 22:52 | |
dhellmann | esp. because "there is nothing the admin or operator needs to do in this case" | 22:52 |
morganfainberg | dhellmann, hm. i can reduce it to warning. | 22:52 |
morganfainberg | dhellmann, i was hoping to show what the exception that was raised when trying to convert | 22:53 |
*** ramishra has quit IRC | 22:53 | |
dhellmann | will the operator care about that? | 22:53 |
*** ramishra has joined #openstack-dev | 22:53 | |
*** CaptTofu has quit IRC | 22:53 | |
morganfainberg | dhellmann, not sure. but the operator should care it happens, it means some tokens can't be revoked on password change/user-disable/etc | 22:53 |
*** jmontemayor has quit IRC | 22:53 | |
sdague | morganfainberg: right, think about INFO and up log levels are for the operator | 22:54 |
dhellmann | ok, that's not clear from the message being loged | 22:54 |
morganfainberg | dhellmann, basically, it means something went and side-band changed the underlying data | 22:54 |
dhellmann | *logged | 22:54 |
sdague | morganfainberg: then make an operator friendly message that says that | 22:54 |
morganfainberg | sdague, sure. | 22:54 |
sdague | a stack trace should never be in a non DEBUG level | 22:54 |
*** noslzzp has quit IRC | 22:54 | |
*** jgrimm has quit IRC | 22:54 | |
sdague | because it's not meaningful to the audience reading it | 22:54 |
morganfainberg | sdague, dhellmann, add something like "any active tokens for <user> are no longer managed by keystone and will be valid until expiration" | 22:55 |
morganfainberg | ? | 22:55 |
morganfainberg | it _shouldn't_ happen | 22:55 |
morganfainberg | but this is just to make sure keystone doesn't lock out that user because something mucked with memcache outside of it's control | 22:55 |
lbragstad | dolphm: ah yeah | 22:55 |
morganfainberg | it's=keystone's | 22:55 |
dhellmann | morganfainberg: how about "Unable to convert user-token index to new format, clearing existing index record: %s" | 22:55 |
morganfainberg | dhellmann, so just drop the log exception and "error" word? | 22:56 |
dhellmann | yeah | 22:56 |
morganfainberg | down to.. uhm.. warning? | 22:56 |
dhellmann | info? | 22:56 |
*** READ10 has joined #openstack-dev | 22:56 | |
dhellmann | an operational warning still seems sorta high | 22:56 |
morganfainberg | sure *shrug* | 22:56 |
morganfainberg | not picky here on that | 22:56 |
dhellmann | but sdague is the official decider on that | 22:56 |
sdague | man, I'm the decider now? :) | 22:57 |
sdague | I think the answer is, do you expect the operator to need to address the issue actively within a couple of days | 22:57 |
morganfainberg | sdague, if you don't decide i'm going to make it register a new super log level and so something really wacky ;) | 22:57 |
sdague | if yes, warn | 22:57 |
sdague | if not, info | 22:58 |
morganfainberg | sdague, no, but the operator should know it occured | 22:58 |
sdague | then info | 22:58 |
morganfainberg | sdague, ok | 22:58 |
*** ramishra has quit IRC | 22:58 | |
*** gokrokve has quit IRC | 22:58 | |
sdague | error = page the operator in the middle of the night to fix, warn = operator action required this week, info for other things | 22:58 |
*** sweston has joined #openstack-dev | 22:58 | |
*** dstanek has quit IRC | 22:58 | |
morganfainberg | in theory, it means something is messing with the authoritative token store outside of keystone | 22:58 |
morganfainberg | which... is bad | 22:59 |
morganfainberg | but there really is nothing that keystone can do about it... nor the operator short of chasing that down | 22:59 |
sdague | debug for detailed dumps, so that will only be seen if they ask for it (assuming they'll run at info level) | 22:59 |
morganfainberg | in practice is is extremely unlikely to happen | 22:59 |
morganfainberg | sdague, went w/ info here | 22:59 |
morganfainberg | everything else is the same, new patchset up | 22:59 |
sdague | well, extremely unlikely, and they should hunt it down, would make it fine for warn | 22:59 |
morganfainberg | dhellmann, ^ | 22:59 |
sdague | but your call, I could see either way | 23:00 |
morganfainberg | sdague, eh, i don't think this is even that likely. | 23:00 |
*** neelashah has quit IRC | 23:00 | |
bknudson | not sure why you would start your server if you couldn't trust the data. | 23:00 |
morganfainberg | sdague, i think they'll have other issues along the way | 23:00 |
dhellmann | morganfainberg: typo: "tp" -> "to" | 23:00 |
morganfainberg | sdague this is just stupidly over defensive coding | 23:00 |
morganfainberg | dhellmann, darn! | 23:00 |
morganfainberg | :P | 23:00 |
morganfainberg | ;) | 23:00 |
*** gokrokve has joined #openstack-dev | 23:00 | |
morganfainberg | typos! | 23:00 |
morganfainberg | i swear i type for a living ... or something | 23:01 |
morganfainberg | bknudson, and that is why memcache is a bad place to store tokens :P | 23:01 |
*** ykhodork has joined #openstack-dev | 23:01 | |
bknudson | morganfainberg: there must be a way to set up memcache so you can trust it? | 23:01 |
*** sarob has joined #openstack-dev | 23:02 | |
morganfainberg | bknudson, bmemcache + signing/encrypt | 23:02 |
*** marcoemorais has quit IRC | 23:02 | |
bknudson | morganfainberg: at least trust it as well as a DB | 23:02 |
morganfainberg | bknudson, and even then... anyone who can auth to it can change any key | 23:02 |
dhellmann | morganfainberg: I always tell people I give directions for a living, so they shouldn't be surprised at the detailed instructions to my house | 23:02 |
*** gokrokve has quit IRC | 23:02 | |
*** marcoemorais has joined #openstack-dev | 23:02 | |
*** gokrokve has joined #openstack-dev | 23:02 | |
*** marcoemorais has quit IRC | 23:02 | |
morganfainberg | bknudson, but basic python memcache client doesn't really do all of that | 23:03 |
*** marcoemorais has joined #openstack-dev | 23:03 | |
*** marcoemorais has quit IRC | 23:03 | |
*** gokrokve has quit IRC | 23:03 | |
morganfainberg | bknudson, also a store that loses all data when you restart it... or that could choose to evict a page even if it isn't expired due to LRU needs means it's bad for tokens. | 23:03 |
morganfainberg | but people use memcache anyway. | 23:03 |
*** marcoemorais has joined #openstack-dev | 23:03 | |
morganfainberg | i am hoping i can move people away from that to redis..or some other Key value store as the "Recommended" backend for the dogpile kvs store when used for tokens | 23:04 |
bknudson | morganfainberg: is it supposed to be backed up by db or something? | 23:04 |
*** zzelle has quit IRC | 23:04 | |
morganfainberg | bknudson, it's meant to be used as a place to store data for faster access than a db, or file, or similar | 23:05 |
morganfainberg | bknudson, it's not really meant to be a "stable" storage for permanent or even semi-permanent data (tokens are the latter category until revocation events) | 23:05 |
*** dbalog has left #openstack-dev | 23:07 | |
*** vartom1111111111 has joined #openstack-dev | 23:07 | |
*** sarob has quit IRC | 23:07 | |
*** apevec has quit IRC | 23:07 | |
*** mohits_ has quit IRC | 23:08 | |
*** dstanek has joined #openstack-dev | 23:09 | |
*** noslzzp has joined #openstack-dev | 23:09 | |
*** dstanek has quit IRC | 23:09 | |
*** harlowja has joined #openstack-dev | 23:09 | |
*** carl_baldwin has joined #openstack-dev | 23:09 | |
*** buzztrol_ has quit IRC | 23:10 | |
*** kevinconway_ has joined #openstack-dev | 23:11 | |
*** carl_baldwin has quit IRC | 23:11 | |
*** sarob has joined #openstack-dev | 23:12 | |
*** kevinconway has quit IRC | 23:14 | |
*** kevinconway_ is now known as kevinconway | 23:14 | |
*** ramishra has joined #openstack-dev | 23:15 | |
*** xarg has quit IRC | 23:16 | |
*** xarg_ is now known as xarg | 23:16 | |
*** noslzzp has quit IRC | 23:16 | |
*** sarob has quit IRC | 23:16 | |
*** xarg_ has joined #openstack-dev | 23:16 | |
*** ytwu has quit IRC | 23:16 | |
*** cadenzajon has quit IRC | 23:17 | |
*** ytwu has joined #openstack-dev | 23:17 | |
*** mlavalle has quit IRC | 23:19 | |
*** galstrom_zzz is now known as galstrom | 23:20 | |
*** armax has left #openstack-dev | 23:20 | |
*** buzztroll has joined #openstack-dev | 23:21 | |
*** sweston has quit IRC | 23:21 | |
*** carl_baldwin has joined #openstack-dev | 23:21 | |
*** ssurana has quit IRC | 23:21 | |
*** yjiang51 has quit IRC | 23:22 | |
*** krtaylor has quit IRC | 23:22 | |
*** arosen has quit IRC | 23:23 | |
*** tjones has quit IRC | 23:24 | |
*** noslzzp has joined #openstack-dev | 23:25 | |
*** carl_baldwin has quit IRC | 23:26 | |
*** zul has quit IRC | 23:26 | |
*** carl_baldwin has joined #openstack-dev | 23:27 | |
morganfainberg | dhellmann, based on the thread on the ML, the generator is going to be unhappy because the options aren't on the CONF object? | 23:29 |
*** baoli has quit IRC | 23:29 | |
morganfainberg | dhellmann, back to my previous convo w/ you | 23:29 |
*** anniec has quit IRC | 23:29 | |
*** abhirc has joined #openstack-dev | 23:29 | |
dhellmann | morganfainberg: that hasn't been a problem for the oslo.messaging options, afaik | 23:30 |
dhellmann | I thought that had something to do with the way the logic for guessing groups worked, but the entry point specifies the group so no guessing | 23:30 |
morganfainberg | dhellmann, well it also looks like i can't use the generator with the entry point elegantly from within keystone to get keystone opts | 23:30 |
*** baoli has joined #openstack-dev | 23:30 | |
dhellmann | oh? | 23:30 |
morganfainberg | dhellmann, yeah, i need to specify keystone as a library for stevedore to load it | 23:31 |
*** lbragstad has quit IRC | 23:31 | |
dhellmann | yes | 23:31 |
*** baoli has quit IRC | 23:31 | |
morganfainberg | dhellmann, and it seems like it's not... loading it cleanly since it doesn't get found | 23:31 |
*** mfer has joined #openstack-dev | 23:31 | |
dhellmann | oh | 23:31 |
morganfainberg | dhellmann, it's a chicken-egg issue | 23:31 |
*** sushils has quit IRC | 23:31 | |
morganfainberg | if something not-keystone was looking for keystone's opts, it would be easier | 23:31 |
dhellmann | do you want to email me details -- I hate to duck out, but it's late here and winter is coming | 23:31 |
morganfainberg | dhellmann, i'm 2x checking. | 23:32 |
morganfainberg | dhellmann, i'll email details/hit you up tomorrow | 23:32 |
dhellmann | I need to go batten hatches or whatever one does in bad weather | 23:32 |
dhellmann | k | 23:32 |
*** dhellmann is now known as dhellmann_ | 23:32 | |
*** anniec has joined #openstack-dev | 23:32 | |
*** achampion has joined #openstack-dev | 23:33 | |
*** vartom1111111111 has quit IRC | 23:35 | |
*** FunnyLookinHat has quit IRC | 23:36 | |
*** mfer has quit IRC | 23:36 | |
*** galstrom is now known as galstrom_zzz | 23:36 | |
*** markwash has quit IRC | 23:36 | |
*** alop_ has joined #openstack-dev | 23:36 | |
*** alop has quit IRC | 23:36 | |
*** alop_ is now known as alop | 23:36 | |
*** thuc has quit IRC | 23:37 | |
*** mrda is now known as mrda_away | 23:37 | |
*** byeager has quit IRC | 23:37 | |
*** thedodd has quit IRC | 23:37 | |
*** thuc has joined #openstack-dev | 23:37 | |
*** otherwiseguy has quit IRC | 23:39 | |
*** jdob has quit IRC | 23:40 | |
*** gnorth has quit IRC | 23:40 | |
*** denis_makogon has quit IRC | 23:41 | |
*** thuc has quit IRC | 23:42 | |
*** tdruiva has quit IRC | 23:42 | |
*** pablosan has quit IRC | 23:42 | |
*** prad has quit IRC | 23:43 | |
*** ctracey is now known as ctracey|away | 23:47 | |
*** romcheg1 has quit IRC | 23:47 | |
*** noslzzp has quit IRC | 23:47 | |
*** vkmc has quit IRC | 23:47 | |
*** bauzas has quit IRC | 23:47 | |
*** ayoung has quit IRC | 23:49 | |
*** thomasem has joined #openstack-dev | 23:50 | |
*** noslzzp has joined #openstack-dev | 23:51 | |
*** henrynash has quit IRC | 23:51 | |
*** pmathews has quit IRC | 23:52 | |
*** marcoemorais has quit IRC | 23:52 | |
*** MaxV has quit IRC | 23:52 | |
*** marcoemorais has joined #openstack-dev | 23:53 | |
*** tanisdl has quit IRC | 23:53 | |
*** Tross has quit IRC | 23:54 | |
*** mriedem has quit IRC | 23:55 | |
*** tanisdl has joined #openstack-dev | 23:57 | |
*** ndipanov has quit IRC | 23:57 | |
*** noslzzp has quit IRC | 23:57 | |
*** chris_johnson is now known as wchrisj|away | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!