Tuesday, 2014-02-11

Alexei_987lifeless: just like we do now in openstack :)00:00
lifelessAlexei_987: exatly; we need to be better at fixing the source00:00
*** armax has joined #openstack-dev00:00
lifelessAlexei_987: btw if you're interested - background on subunit v2 starts here http://rbtcollins.wordpress.com/2013/02/14/time-to-revise-the-subunit-protocol/00:00
Alexei_987lifeless: I vote for JSON00:01
*** jdurgin has quit IRC00:01
*** sarob_ has joined #openstack-dev00:01
lifelessAlexei_987: given the amount of content there, its pretty clear you didn't read the real-world lessons learnt around that.00:01
*** sarob_ has quit IRC00:01
*** thuc has quit IRC00:01
Alexei_987lifeless: Ok ok I just like JSON ;)00:02
*** thuc has joined #openstack-dev00:02
lifelessAlexei_987: I'm planning on doing a trace-into-json filter at some point for human reading of streams00:02
lifelessAlexei_987: I like JSON too00:02
lifelessAlexei_987: its just not suitable for machine->machine transfer over possibly noisy channels00:02
StevenKlifeless: oopstools and BSON says hi00:03
Alexei_987lifeless: not sure that I understand what "possibly noisy channels" means00:03
lifelessStevenK: o/00:03
StevenKHaha00:03
Alexei_987we have TCP, no?00:03
lifelessAlexei_987: no00:03
*** sweston has quit IRC00:03
lifelessAlexei_987: test backends have a nasty habit of writing crap to their pipes without warning00:04
*** sarob has quit IRC00:04
Alexei_987ah.. I see what you mean00:04
*** vuil has joined #openstack-dev00:04
lifelessAlexei_987: so I think the CatFiles result in subunit.test_results is sufficient00:04
Alexei_987lifeless: however I still think that we should fix nosiness instead of protocol00:05
lifelessAlexei_987: for gatherer above00:05
*** jdurgin has joined #openstack-dev00:05
lifelessAlexei_987: I spent /years/ doing that.00:05
lifelessAlexei_987: I welcome you joining the battle.00:05
*** mtreinish has quit IRC00:05
Alexei_987we could use some message queue for that (zeroMQ)00:05
Alexei_987it would be good for splitting stuff between workers00:05
Alexei_987and avoid any noise related crap00:05
*** armax has quit IRC00:05
lifelessAlexei_987: then the crap from the runner is lost (bad) or out of sequeunce with whatever test ran (also bad)00:06
Alexei_987it's not lost00:06
Alexei_987it's just messed up with other crap00:06
lifelessAlexei_987: if you dont' capture stdout it is00:06
Alexei_987you capture it00:06
Alexei_987you just don't use the same pipe for internal communication00:06
*** thuc has quit IRC00:07
Alexei_987so you have message queue as a command/result channel00:07
*** carl_baldwin has quit IRC00:07
lifelessalso runs into issues with runners that internally fork/exec00:07
*** flaper87 is now known as flaper87|afk00:07
lifelessI can certainly see running subunit on an out of band pipe00:07
lifelessits designed to permit that00:07
Alexei_987actually we don't have to fork00:07
lifelesshaven't done the glue for it yet though00:07
Alexei_987to use zeroMQ for example00:07
lifelessAlexei_987: /we/ don't - there are runners out there that do00:07
lifelessAlexei_987: e.g. zope.testrunner.00:07
Alexei_987so what?00:08
Alexei_987it just connects to proper listener and sends messages00:08
Alexei_987I mean that we can have 1 master process that runs a results collector00:08
*** amcrn_ has joined #openstack-dev00:08
Alexei_987+ X worker processes that just share an endpoint for that queue00:09
lifelesssure, the demultiplexor00:09
lifelesstestr :)00:09
Alexei_987yeah00:09
*** amcrn has quit IRC00:09
*** amcrn_ is now known as amcrn00:09
*** mtreinish has joined #openstack-dev00:10
*** bdpayne has joined #openstack-dev00:11
*** vuil has quit IRC00:11
beginguys, can you help me to understand a little bit more python with that piece of code: self.conn_timeout = float(conf.get('conn_timeout', 0.5))?00:11
*** kgriffs has quit IRC00:11
*** kgriffs_afk has joined #openstack-dev00:12
*** kgriffs_afk is now known as kgriffs00:12
Alexei_987lifeless: coming back to unittest issue. If you'll check unittest.loader you'll see that there is no way to get to error message without actually calling test method00:12
lifelessAlexei_987: yes, I know. That why I opened the issue upstream00:12
lifelesshttp://bugs.python.org/issue1974600:13
*** Tross has quit IRC00:13
Alexei_987do you have any ideas of how it should be fixed?00:13
*** jaybuff has joined #openstack-dev00:13
*** hughsaunders has quit IRC00:13
*** jhesketh__ has joined #openstack-dev00:13
lifelessAlexei_987: a few possibilities - a kwarg to the load methods to ask them to return errors as a separate thing to the found tests00:13
lifelessAlexei_987: or make a defined, stable marker on the returned tests (e.g. a specific class and attributes that can be reliably introspected)00:14
*** begin has quit IRC00:15
*** mwagner_lap has quit IRC00:15
Alexei_987lifeless: how do you can actually submit a pull request there?00:15
*** mwagner_lap has joined #openstack-dev00:15
*** mwagner_lap has quit IRC00:16
lifelessAlexei_987: just a patch in the bug tracker there usually, unless you have commit access00:17
Alexei_987lifeless: ah I found guide00:17
*** ramishra has quit IRC00:17
*** begin has joined #openstack-dev00:18
*** ramishra has joined #openstack-dev00:19
*** ijw_ has quit IRC00:19
*** armax has joined #openstack-dev00:19
*** hughsaunders has joined #openstack-dev00:19
*** ijw has joined #openstack-dev00:20
*** IanGovett has quit IRC00:20
bknudsonI'm a little worried that the keystoneclient module docs are not being updated...00:20
bknudsonhttp://docs.openstack.org/developer/python-keystoneclient/py-modindex.html00:20
bknudsonshows "Last updated on Mon Mar 18"00:20
jamielennoxbknudson: i've got no idea how that works00:23
jamielennoxbknudson: i don't even think most of the stuff in docs is published00:23
bknudsonjamielennox: what do you mean not published?00:24
*** hdd_ has joined #openstack-dev00:24
jamielennoxbknudson: well i'm not sure where they go - but more i know that i went at one point to update the middleware architecture document in keystoneclient and was told not to bother because it was so far behind the one in keystone00:24
bknudsonjamielennox: the main page is up to date -- http://docs.openstack.org/developer/python-keystoneclient/index.html00:25
*** tkay has quit IRC00:25
bknudsonsays        Last updated on Mon Feb 3 03:07:36 201400:26
*** jmontemayor has quit IRC00:26
*** epim has quit IRC00:26
*** dims has quit IRC00:26
bknudsonjamielennox: that would be a strange thing to not update the documentation because it's too far out of date?00:26
jamielennoxok, well middleware architecture is not linked there then00:27
bknudsonseems like if it's out of date is exactly the time to update it.00:27
bknudsonjamielennox: I submitted a change to add the link to the middleware arch doc.00:27
jamielennoxbknudson: more like it's worth just a wholesale sync from keystone - it belongs in client00:27
*** vuil has joined #openstack-dev00:27
jamielennoxbknudson: yea, i've seen a few of your doc changes - i don't know how to test them though00:27
bknudsonand get it in sync with keystone00:27
*** pmathews has quit IRC00:27
*** pmathews has joined #openstack-dev00:28
gyeejamielennox, I really like the way you handle multiple methods in the plugin impl00:28
bknudsonjamielennox: tox -e venv python setup.py build_sphinx00:28
jamielennoxgyee: yea, i think thats cool00:28
gyeejamielennox, do we need one for the ADMIN token?00:28
bknudsonjamielennox: then look in doc/build/html/index.html00:28
gyeeas it is static00:28
gyeeI presume its going to be a simple one, just return the same token on get_token()00:29
jamielennoxgyee: we will need an endpoint/token plugin - but that's not an 'identity' plugin00:29
*** ramishra has quit IRC00:29
jamielennoxbknudson: ok, i will have another look through those00:29
*** carl_baldwin has joined #openstack-dev00:29
gyeejamielennox, that would make it usable by middleware00:29
gyeethat 'admin_token' in auth_token middleware is really the static admin token00:30
jamielennoxgyee: true, i haven't covered the endpoint/token case in either of the factories00:30
jamielennoxyep00:30
*** stevemar has joined #openstack-dev00:30
*** abhirc has joined #openstack-dev00:30
gyeejamielennox, I would love to use it for middleware,00:30
gyeein fact, I am going to use it in the s3 and ec2 middleware prototype00:30
jamielennoxi'm not sure if i should allow 'endpoint' to be passed to the identity plugins - i dont *think* there will be a problem with that though00:31
*** abhirc has quit IRC00:31
gyeejamielennox, no need for endpoint00:31
jamielennoxi'm trying to keep them as pure as possible and then they get bastardized by hacks later00:31
gyeejust auth_url00:31
*** nati_ueno has joined #openstack-dev00:32
gyeejamielennox, I'll put up some code for you to look at and you'll see what I mean00:32
jamielennoxthe only case i'm not sure about is if someone passed auth_url + endpoint + user/pass or something00:32
jamielennoxthat would to me mean that you should use auth_url and user/pass for a token, but override what is returned from the catalog with endpoint00:32
gyeejamielennox, essentially I want auth_token to use v3.client or v2.client, based on auth_version00:32
jamielennoxgyee: have you had a look at that yet?00:33
jamielennoxi've been waiting until auth plugins pass and i can do some more discovery work00:33
gyeejamielennox, which one? you make the change already?00:33
*** nelsnelson has quit IRC00:33
jamielennoxgyee: i mean to converting auth_tokken00:34
gyeejamielennox, I am doing prototyping with s3 and ec3, utilizing the generic signature auth plugin00:35
jamielennoxthe problem i kind of see is that there are two things to discover - which auth plugin to use and which client to use because they don't have to be the same thing00:35
*** AlexF has joined #openstack-dev00:35
gyeejamelennox, middleware already know what one to use00:35
gyeejamielennox ^^00:35
jamielennoxgyee: oh?00:35
gyeeI mean middleware already know which API to use00:36
gyeethere's a auth_version parameter00:36
jamielennoxyea, thats true you can set the client to v300:36
Alexei_987lifeless: so what do you think about using zeromq to transport internal data in subunit?00:36
jamielennoxit just only does the actual auth over v200:36
*** dave_tucker is now known as dave_tucker_zzz00:36
*** cadenzajon has quit IRC00:36
jamielennoxgyee: as in the middleware auth is only via v200:37
gyeejamielennox, right, that we need to fix00:37
jamielennoxi would like to define as part of auth plugins a from_conf() method or something that would allow creating an auth plugin from a confing set00:37
jamielennoxi want to talk to dtroyer about how that would work though00:37
*** david-lyle has quit IRC00:37
*** tkay has joined #openstack-dev00:38
jamielennoxsame with exposing command line args00:38
gyeejamielennox, I am thinking about the same thing, have some sort of factory based on conf00:38
lifelessAlexei_987: I've pushed the UI ugliness fix I hadn't gotten around to up to testr trunk.00:38
lifelessAlexei_987: its not as pretty as it can be, but i don't have the time to glue it into the UI layer properly right now.00:38
lifelessAlexei_987: we'll still need the import error stuff in testtools, of course.00:39
*** CaptTofu has joined #openstack-dev00:39
jamielennoxgyee: yep, so i'm just not sure how we go about differentiating v2 vs v3 for that00:39
*** mikeoutland has quit IRC00:39
jamielennoxgyee: i guess we don't need to for the first pass00:39
gyeejamielennox, either explicitly via auth_version or discover00:39
*** pmathews has quit IRC00:40
jamielennoxgyee: at least to start we will want a v3.Auth.from_conf and a v2.Auth.from_conf and we don't need to discover yet00:40
lifelessAlexei_987: I'd like to see a robust standardised out of band mechanis, sure. I think it needs some design work (and just saying 'ZeroMQ' is not that)00:40
gyeejamielennox, I was thinking get_client(conf)00:40
Alexei_987:) I just wanted to know maybe you have some obvious reasons against it00:41
jamielennoxgyee: we need some top level stuff soon as well00:41
jamielennoxgyee: but everything i've done has been very layered so far, so that if you know you want a v3 auth or client you can create that without doing discovery00:41
*** dims has joined #openstack-dev00:41
Alexei_987lifeless: Ok I'll keep this in mind and may come back to it a bit later when I'll have time00:41
gyeejamielennox, I love the design!00:41
*** baoli has joined #openstack-dev00:41
*** AlexF has quit IRC00:41
jamielennoxgyee: then a generic entry would do discovery and then hand off to the correct factory00:42
gyeejamielennox, I'll go through the code in detail, but I like the direction at the first glance00:42
jamielennoxso we can do a v2 and a v3 from_conf and then later we are going to need a discoverable auth entry point00:42
*** baoli has quit IRC00:43
jamielennoxgyee: yea, i'm pretty happy with how the AuthMethod stuff worked out in the v3 plugins. I thought it was going to be really ugly.00:43
*** baoli has joined #openstack-dev00:43
jamielennoxbknudson: that AuthMethod stuff is i think what you were talking about the other day as well00:44
gyeejamielennox, we'll probably need to figure out how to facilitate the static admin token later00:44
jamielennoxgyee: i think that one will be trivial00:44
jamielennoxwe have to work it into the factories i guess but other than that00:44
Alexei_987lifeless: I'll update my pull request in the morning . Have a nice day00:44
gyeejamielennox, right00:44
*** relaxdiego has quit IRC00:45
*** dave_tucker_zzz is now known as dave_tucker00:46
*** tdruiva has quit IRC00:46
*** baoli has quit IRC00:47
*** RajeshMohan has quit IRC00:48
*** baoli has joined #openstack-dev00:48
*** gnorth has quit IRC00:49
*** zul has joined #openstack-dev00:50
*** rcleere has quit IRC00:51
*** toabctl_ has quit IRC00:54
*** toabctl_ has joined #openstack-dev00:55
*** matrohon has quit IRC00:55
*** xmltok has quit IRC00:55
*** matrohon has joined #openstack-dev00:55
*** RajeshMohan has joined #openstack-dev00:56
*** nati_ueno has quit IRC00:56
*** tsekiyam_ has joined #openstack-dev00:56
*** thuc has joined #openstack-dev00:56
*** AlexF has joined #openstack-dev00:57
*** thuc has quit IRC00:57
*** dvarga is now known as dvarga|away00:57
*** dvarga|away is now known as dvarga00:57
*** sushils has quit IRC00:57
*** thuc has joined #openstack-dev00:58
*** tsekiyama has quit IRC00:58
*** browne has quit IRC00:59
*** zul has quit IRC00:59
*** galstrom_zzz is now known as galstrom00:59
*** tsekiyam_ has quit IRC00:59
*** gokrokve has quit IRC01:00
*** gokrokve has joined #openstack-dev01:00
*** RajeshMohan has quit IRC01:01
dstanekstevemar: reviewed01:01
*** jaybuff has quit IRC01:01
stevemardstanek, ahoy hoy01:01
*** jaybuff1 has joined #openstack-dev01:01
stevemardstanek, fingers crossed01:01
stevemardstanek, d'oh01:02
dstanekstevemar: i really just had a question about user name01:02
*** devoid has quit IRC01:02
dstanekthe other things i could live with01:02
*** arosen has joined #openstack-dev01:03
stevemardstanek, re: the name bit... i was wondering about this too01:04
stevemardstanek, it's hard because, from the mapping side, i can't enforce that they have a user name mapping, not easily anyway01:04
stevemarand I can't do much about the assertion coming in01:04
*** pablosan has quit IRC01:05
*** tresor has joined #openstack-dev01:05
*** gokrokve has quit IRC01:05
stevemardstanek, generally, it's assumed that the assertion will have some user name concept. but if the mapping rules don't have a rule about transforming SAML name to keystone name... /me shrugs01:06
*** RajeshMohan has joined #openstack-dev01:06
*** kenperkins_ has quit IRC01:06
dstanekstevemar: you could add a check in there is see if name exists in the user dict01:06
*** atiwari has quit IRC01:07
dstanekstevemar: if it's a requirement then i could deal with it - i'd love to create a patch to add that type of validation01:07
*** vuil has quit IRC01:08
*** ramishra has joined #openstack-dev01:08
*** mlegault_ has joined #openstack-dev01:08
*** andreaf has quit IRC01:09
*** arosen has quit IRC01:09
*** kenperkins has joined #openstack-dev01:09
*** epim has joined #openstack-dev01:09
*** andreaf has joined #openstack-dev01:09
*** arosen has joined #openstack-dev01:10
*** relaxdiego has joined #openstack-dev01:10
stevemardstanek, the consequence is that user's name is None, which I think they can handle in https://review.openstack.org/#/c/71353/4/keystone/contrib/federation/controllers.py01:10
*** flamebot has joined #openstack-dev01:11
*** toanster has quit IRC01:11
*** terrylhowe has quit IRC01:11
stevemardstanek, it will mean that the issued token has None for the user id :\01:11
*** mlegault has quit IRC01:11
*** toanster has joined #openstack-dev01:12
*** tresor has quit IRC01:12
stevemardstanek, initially, i wanted to double check name/id/email in that order, and break if neither was there01:12
stevemars/double//01:12
*** ramishra has quit IRC01:13
*** carl_baldwin has quit IRC01:13
*** galstrom is now known as galstrom_zzz01:15
*** kenperkins has quit IRC01:15
*** tkay has quit IRC01:15
*** e0ne has quit IRC01:16
*** CaptTofu has quit IRC01:16
*** gokrokve has joined #openstack-dev01:17
*** tqtran1 has quit IRC01:17
*** CaptTofu has joined #openstack-dev01:19
dstanekstevemar: is that something to do in that function?01:21
*** reed has quit IRC01:22
stevemardstanek, dolphm said otherwise01:23
*** RajeshMohan has quit IRC01:24
*** gokrokve has quit IRC01:25
*** mlegault_ has quit IRC01:26
dstanekstevemar: sounds good - i'm going mess with the schema a little01:26
dstanekstevemar: what did you think about the other things? the most incorrect is the docstring ordering01:27
stevemardstanek, go ahead01:27
stevemardstanek, yeah, i can fix those up, they were legit problems01:27
dstanekstevemar: is there tests for the mapping schema?01:28
*** lubyou has quit IRC01:28
stevemardstanek, already merged01:28
stevemardstanek, i need a better way to make sure the error msgs are actually related to the errors i'm testing...01:29
*** dave_tucker is now known as dave_tucker_zzz01:29
*** jamespage has quit IRC01:29
*** godara has quit IRC01:29
*** mmoya_ has quit IRC01:29
*** sileht has quit IRC01:29
*** mmoya has joined #openstack-dev01:29
ayoung-Dadstevemar, dstanek morganfainberg ... I think that I have a path forward for ephemeral tokens and dealing with the Redirects of Federation.  What if we made GET /auth/token  the call that returned a default token...unscoped.  But..and here is the kicker, we make it ephemeral01:30
*** relaxdiego has quit IRC01:30
*** otherwiseguy has quit IRC01:30
ayoung-Dadwe only check it using PKI01:30
*** ayoung-Dad is now known as ayoung01:31
*** dave_tucker_zzz is now known as dave_tucker01:31
morganfainbergayoung, i like that.01:32
ayoungyeah, me too01:32
ayoungmorganfainberg, and...what if we made it easy to get a scoped token by hitting other urls, like /v3/project/<projecid>/token  ?01:32
ayoungit only will give you a token for $USER01:33
stevemardstanek, i'll make those 2 changes now01:33
stevemardstanek, silly question is there a convention for ordering args?01:33
morganfainbergayoung, huh,01:34
*** jamespage has joined #openstack-dev01:34
*** jamespage has joined #openstack-dev01:34
ayoungmorganfainberg, if you want a scoped token, got to the scope you want in Keystone and say "give me a token, dammit!"01:34
morganfainbergayoung, i'm rolling that around in my head.01:35
morganfainbergayoung, so, you have a defined entry point for your unscoped token01:35
dstanekstevemar: not really..i think it's just what makes sense for the situatio01:35
dstanekn01:35
stevemardstanek, cool01:35
morganfainbergayoung, and then scoped tokens come from the <resource>/token ?01:35
*** novas0x2a|laptop has joined #openstack-dev01:35
*** xarses has quit IRC01:35
ayoungyepo01:35
*** RajeshMohan has joined #openstack-dev01:35
morganfainbergayoung, it... might just make too much sense, i'm sorry.  it's too intuitive01:35
ayoungmorganfainberg, the only thing that varies on a token is the issued_at time01:35
ayoungand...if it is based on an initial authentication/token auth...they all follow the rules of auth by token...expires_at stays constant01:36
*** sweston has joined #openstack-dev01:36
morganfainbergayoung, i think you need to make it so you ask <resource>/token for the reference that you then repost the entire auth chain to to get the one-time resource that issues the scoped token01:36
*** lubyou has joined #openstack-dev01:36
*** ctracey is now known as ctracey|away01:37
morganfainbergayoung, so unscoped token would allow you to determine the resources / scopes you can use?01:37
ayoungmorganfainberg, as I understand it, the reason we didn't do something like this in the past was that creating a token was considered creating a new resources.  With ephemeral, that is no longer the case01:37
morganfainbergayoung, or is that determined separately?01:37
morganfainbergayoung, and yes, that makes perfect sense (ephemeral vs non)01:37
*** sileht has joined #openstack-dev01:37
morganfainbergand why we do things the way we do01:37
ayoungand a token becomes nothing more than a signed response from Keystone01:37
morganfainbergit does make a number of things easier01:38
*** jasdeepH has quit IRC01:38
dstanekstevemar: dumb question...where are those tests?01:38
morganfainbergayoung, it would be a drastic departure from current mechanisms01:38
ayoungmorganfainberg, and it makes it easier to sign any random API, too01:38
ayoungmorganfainberg, current mechanisms can still work01:38
morganfainbergayoung, yes, so another extension that applies this logic01:38
morganfainbergayoung, with the eventual goal to make this logic the "correct" approach and deprecate the old logic long term?01:39
ayoungmorganfainberg, just the current controllers, mostly in assignmnet01:39
ayoungI think so.01:39
*** vkmc has quit IRC01:39
morganfainbergayoung, sure. i could get behind that.01:40
*** alex_xu has joined #openstack-dev01:40
ayoungcool01:40
morganfainbergayoung, i'd like to chew on it a bit still, but it seems sound01:40
*** xingchao has joined #openstack-dev01:40
ayoungwe can discuss tomorrow01:40
morganfainbergayoung, aye.01:40
morganfainbergayoung, i assume a link for /token would appear for any resource that can sign a scope then.01:40
ayoungmorganfainberg, yeah01:41
morganfainbergsleep + a (i'm sure) lively discussion in IRC will show us how this shakes out01:41
*** xuhanp has joined #openstack-dev01:41
morganfainbergbut i like it conceptually01:41
ayoungmorganfainberg, really, could be done with an "accepts" header on the resource itself, but deliberate link is probably clearer01:41
morganfainbergayoung, deliberate link, but i wouldn't be opposed to leveraging accepts headers more than we do01:42
*** abhirc has joined #openstack-dev01:42
ayoungmorganfainberg, I've been thinking about the token compression.  Sign, then compress makes a lot of sense.   We create an Content_type that indicates that01:43
ayoungapplications/cmsz64 or something01:43
*** ctracey|away has joined #openstack-dev01:43
ayoungapplications/json+cms_z+base6401:43
morganfainbergayoung, sure, though it wouldn't hurt to make each step (that needs to be reversed) detectable from the point it needs to be done01:44
ayoungmorganfainberg, and if that is the case, say we drop the base64 encoding, then the content-type would be01:44
*** arosen has quit IRC01:44
ayoungapplication/json+cms+z+base6401:44
ayoungI wonder if I should use that as the token prefix insted of {cmsz}01:44
morganfainberghm. sure.01:44
*** abhirc_ has joined #openstack-dev01:45
ayoungits more verbose, but with compression of the rest, it will be far more self-documenting01:45
morganfainbergactually tbh, i'd make it so you unzip it, and it tells you this is cms, you decrypt, it is b64, you unb64, it says json01:45
*** tdruiva has joined #openstack-dev01:45
*** dvarga has quit IRC01:45
morganfainbergayoung, i only say that because it simplifies it and if any one element is dropped out you can always figure out the next step from where you are.01:46
ayoungyeah, I like that01:46
*** dolphm has quit IRC01:46
morganfainbergayoung, it also means the content-type doesn't become application/json+cms+z+b64+keystone_foo+bar+rot1301:47
stevemardstanek, the malicious ones are here: https://github.com/openstack/keystone/blob/master/keystone/tests/test_v3_federation.py#L53101:47
ayoungmorganfainberg, it doesn't it feel like when you are packing a car on a trip, and you get everything to fit?01:47
morganfainbergayoung, lol01:47
ayoungwhy not rot13?01:47
*** jkoelker has quit IRC01:47
stevemardstanek, the mappings are all in https://github.com/openstack/keystone/blob/master/keystone/tests/mapping_fixtures.py01:47
morganfainbergayoung, dude I rot17 everything01:47
*** kenperkins has joined #openstack-dev01:47
*** bdpayne has quit IRC01:48
*** jaybuff1 has quit IRC01:48
*** abhirc has quit IRC01:48
morganfainbergayoung, i am just thinking from a pipeline perspective, each step is isolated and adds the data it needs to for decoding later.01:48
ayoungrpflex, uluv Z ifk17 vmvipkyzex01:48
morganfainbergayoung, rather than having to pass a dict/list/something through the whole way to track it01:48
*** kenperkins has quit IRC01:49
*** relaxdiego has joined #openstack-dev01:49
*** jasdeepH has joined #openstack-dev01:50
*** dolphm has joined #openstack-dev01:51
*** neelashah has joined #openstack-dev01:51
*** AlexF has quit IRC01:51
*** jkoelker has joined #openstack-dev01:51
*** RajeshMohan has quit IRC01:52
*** epim has quit IRC01:52
*** melwitt has quit IRC01:52
*** buzztroll has quit IRC01:52
*** galstrom_zzz is now known as galstrom01:53
*** RajeshMohan has joined #openstack-dev01:53
*** thuc has quit IRC01:53
*** thuc has joined #openstack-dev01:54
*** yaguang has joined #openstack-dev01:54
*** browne has joined #openstack-dev01:56
*** mrodden has quit IRC01:57
*** RajeshMohan has quit IRC01:58
*** thuc has quit IRC01:58
*** RajeshMohan has joined #openstack-dev01:58
*** yongli has joined #openstack-dev01:59
*** rmk has quit IRC02:00
*** topol has joined #openstack-dev02:00
topoldolphm, you there?02:01
*** browne has quit IRC02:01
*** sn6i23a has quit IRC02:02
*** bswartz has joined #openstack-dev02:02
bswartzseñor02:02
*** thuc has joined #openstack-dev02:03
bswartz¬_¬ wrong window...02:03
*** pcm_ has quit IRC02:04
*** RajeshMohan has quit IRC02:05
*** RajeshMohan has joined #openstack-dev02:05
*** tsekiyama has joined #openstack-dev02:06
topolbswartz no problema mi amigo02:06
*** godara has joined #openstack-dev02:06
*** thedodd has joined #openstack-dev02:06
*** gongysh has joined #openstack-dev02:07
*** thuc has quit IRC02:07
*** pcm_ has joined #openstack-dev02:07
*** browne has joined #openstack-dev02:08
*** thuc has joined #openstack-dev02:08
*** ramishra has joined #openstack-dev02:09
*** browne has quit IRC02:09
*** tsekiyama has quit IRC02:10
*** kushal has joined #openstack-dev02:10
*** marcoemorais1 has quit IRC02:11
*** thuc has quit IRC02:12
morganfainbergthedodd, see i'm over here too ;)02:13
* morganfainberg goes back to lurk mode.02:13
*** ramishra has quit IRC02:14
*** dstanek has quit IRC02:14
*** gokrokve has joined #openstack-dev02:14
*** yamahata has quit IRC02:16
stevemartopol, late night coding hmmm02:16
*** cagrev has joined #openstack-dev02:16
*** READ10 has quit IRC02:17
*** begin has quit IRC02:17
*** xarses has joined #openstack-dev02:17
*** Mandell has quit IRC02:18
*** godara has quit IRC02:18
*** godara_ has joined #openstack-dev02:18
topolstevemar, hey just for the record my test data was generated from real curl examples. I did mix some v2 and v3 calls to generate but it was real results that came in from the curl calls.  I'll send dolph my test script02:19
*** AlexF has joined #openstack-dev02:19
*** clouded_tux_ has quit IRC02:19
*** baoli has quit IRC02:19
*** clouded_tux_ has joined #openstack-dev02:19
*** jasdeepH has quit IRC02:21
*** jasdeepH has joined #openstack-dev02:21
*** sarob has joined #openstack-dev02:22
*** godara_ has quit IRC02:22
*** buzztroll has joined #openstack-dev02:23
topolstevemar, still helping kids with homework. wont start coding for about an hour02:23
*** markvoelker1 has joined #openstack-dev02:25
*** e0ne has joined #openstack-dev02:27
*** erkules_ has joined #openstack-dev02:27
*** xchu has joined #openstack-dev02:27
*** buzztroll has quit IRC02:28
*** Edward-Zhang has joined #openstack-dev02:29
*** galstrom is now known as galstrom_zzz02:29
*** erkules has quit IRC02:29
*** spzala has quit IRC02:30
*** ysk has joined #openstack-dev02:30
*** e0ne has quit IRC02:31
*** neelashah1 has joined #openstack-dev02:32
*** buzztroll has joined #openstack-dev02:32
*** pcm_ has quit IRC02:33
*** MaxV has quit IRC02:33
*** gordc has quit IRC02:33
*** neelashah has quit IRC02:34
*** ctracey|away is now known as ctracey02:34
*** sarob has quit IRC02:34
*** sarob has joined #openstack-dev02:34
*** thedodd has quit IRC02:35
*** sarob has quit IRC02:39
*** sarob has joined #openstack-dev02:41
*** lbragstad has joined #openstack-dev02:41
*** johnthetubaguy has joined #openstack-dev02:42
*** ramishra has joined #openstack-dev02:45
*** ramishra has quit IRC02:46
*** alop has quit IRC02:48
*** chandan_kumar has joined #openstack-dev02:48
*** ssurana has joined #openstack-dev02:49
*** morganfainberg is now known as morganfainberg_Z02:51
*** ssurana has left #openstack-dev02:53
*** ssurana has joined #openstack-dev02:53
*** ssurana has left #openstack-dev02:53
*** armax has quit IRC02:54
*** chandan_kumar has quit IRC02:54
*** alop has joined #openstack-dev02:56
*** chandan_kumar has joined #openstack-dev02:56
*** galstrom_zzz is now known as galstrom02:58
*** bdpayne has joined #openstack-dev02:59
*** novas0x2a|laptop has quit IRC03:00
*** russell_h has quit IRC03:01
*** sheeprine has quit IRC03:02
*** mikal has quit IRC03:02
*** bdpayne has quit IRC03:02
*** mikal has joined #openstack-dev03:03
*** sheeprine has joined #openstack-dev03:04
*** MaxV has joined #openstack-dev03:04
*** tjones has joined #openstack-dev03:04
*** yuan has joined #openstack-dev03:04
*** troytoman has quit IRC03:04
*** chandan_kumar has quit IRC03:04
*** kushal has quit IRC03:05
jamielennoxayoung: what happened to public=False on https://review.openstack.org/#/c/6854803:05
*** pingveno has quit IRC03:05
*** CaptTofu has quit IRC03:06
ayoungjamielennox, hrm03:06
*** angdraug has quit IRC03:06
ayoungmusta got messed up in the rebase.  There are too many patches in this series03:06
*** ramishra has joined #openstack-dev03:07
*** troytoman has joined #openstack-dev03:07
jamielennoxayoung: ok, i hadn't gone back through the history i was just looking at the most recent one and tought the idea might have changed03:08
ayoungnope.03:08
*** kbrierly has quit IRC03:08
ayoungjamielennox, so I was thinking that, on the compression thing, it would be good if all of the operations were reflected in the headers03:08
ayoungsomething like03:08
*** russell_h has joined #openstack-dev03:08
ayoung"{json,cms,z,base64}"03:09
*** MaxV has quit IRC03:09
jamielennoxayoung: what does it give us?03:09
ayoungthen any document can be signed , and you know the content type and tools to use to trnasform it03:09
ayoungjamielennox, it means that if you want to do something different, like, say, leave off base64...03:09
ayoung"{json,cms,z}"03:09
ayoungor use XML03:09
ayoung"{xml,cms,z}"03:10
ayoungor a differnt compresssion algo...03:10
ayoungit does mean the header is not a fixed length03:10
jamielennoxi'm not sure it buys us anything - i don't see why anoyone would want to customize that03:10
jamielennoxand it means doing a lot more work on the decode of looking up transformations03:11
jamielennoxif i can ever figure out the pecan problems i like the idea of allowing signed docs via Accept:03:12
jamielennoxbut we will never issue for example an XML token03:12
ayoungI was thinking about signing other things, like revocation event lists03:12
*** buzztroll has quit IRC03:12
ayoungit just would map 1 to 1 with content types really cleanly, like03:12
*** 14WAB5IF8 has quit IRC03:13
ayoungapplication/json+cms+z+base6403:13
jamielennoxhmm, so i think maybe and sort of03:13
*** dave_tucker is now known as dave_tucker_zzz03:13
jamielennoxi don't think all that needs to go into the content type03:13
jamielennoxyou can pass an X-Encrypt: true header for z03:14
*** taps has quit IRC03:14
jamielennox(i made the header name up)03:14
jamielennoxhmm, although i see the problem with that03:14
*** ramishra_ has joined #openstack-dev03:14
ayoungyeah03:15
ayoungwe can't really do that03:15
ayoungthe token will be encrypted, but the rest of the stream won't be03:15
jamielennoxayoung: i think regarding tokens it doesn't matter03:15
*** troytoman is now known as troytoman-away03:15
ayoungactually it isnt X-Encrypt03:15
*** sarob has quit IRC03:16
jamielennoxX-Compress03:16
ayoungContent-Encoding: gzip03:16
jamielennoxdamnit i've been confusing that all day03:16
ayoungnot an X03:16
*** sarob has joined #openstack-dev03:16
ayoungAccept-Encoding: gzip, deflate03:16
*** yamahata has joined #openstack-dev03:16
jamielennoxyea, i just didn't know the header to use03:16
jamielennoxanyway for token it doesn't matter03:16
ayoungright03:17
jamielennoxbecause all of this is information regarding the body of a message03:17
jamielennoxand a token is not transmitted in the body03:17
ayoungand the problem with tokens is between the wsgi App and HTTPD03:17
jamielennoxbut it doesn't so much matter because a token is just a blob03:18
*** henrynash has quit IRC03:18
*** novas0x2a|laptop has joined #openstack-dev03:18
*** ramishra has quit IRC03:18
*** yjiang51 has joined #openstack-dev03:18
jamielennoxso long as we know what we produced and how to undo that process nothing else needs to really care03:18
ayoungjamielennox, right...so why not include all that info in the header?03:19
ayoungI mean...I am not sure that doing the equivalent of "file" on a Base64 encoded blob would tell us anything.03:20
jamielennoxayoung: so you mean the {...}MII..03:20
ayoungor what you get once you undo that03:20
ayoungyeah...03:20
ayoungActually ,once it is comporessed it won't be MII03:20
ayoungmuch shorter03:20
*** sarob has quit IRC03:20
jamielennoxtrue, we've swapped ordering03:20
stevemarjamielennox, whats the point of https://github.com/openstack/keystone/blob/master/keystone/tests/contrib/kds/fixture/__init__.py#L21 ?03:21
stevemaris it used?03:21
*** sweston has quit IRC03:21
jamielennoxayoung: umm, i just don't know if it's something that people will ever want to customize03:21
*** yamahata has quit IRC03:21
*** rcleere has joined #openstack-dev03:21
jamielennoxstevemar: well i see what it does, why i did that over just importing each fixture individually i can't recall03:22
*** jnoller has joined #openstack-dev03:22
stevemarjamielennox, it's mucking up docs building, so, i might propose to remove it...03:22
stevemarjamielennox, if the tests pass03:23
*** paragan has joined #openstack-dev03:23
*** dims has quit IRC03:23
jamielennoxstevemar: that's weird - that's a pattern that is used in a number of places and there is nothing really funny about that one03:23
stevemarjamielennox, /me shrugs03:24
*** jecarey has quit IRC03:24
*** dims has joined #openstack-dev03:24
*** baoli has joined #openstack-dev03:25
*** kushal has joined #openstack-dev03:26
*** zhikunliu has joined #openstack-dev03:26
jamielennoxayoung: anyway, i don't see that we get any benefit from the {x+x+x+x} format as everyone just gets a blob - it just seems to add complexity to the decode03:27
jamielennoxalso the {x+x+x} is outside the signed area so i guess it would be possible for someone to screw around with it but i can't see any way they could manipulate it to do something bad03:27
ayoungjamielennox, so...the nice thing about this format is that there is nothing Keystone specific, and certainly not token specific.  It gives us a geneirc way to hand around signed and comporessed data03:27
ayoungonly the signed part is signed.03:28
*** chandan_kumar has joined #openstack-dev03:29
jamielennoxayoung: do we need that?03:31
ayoungjamielennox, well, I know gyee wants to continue the practice of signing the revocation list03:31
ayoungnow evets03:31
*** Ryan_Lane has joined #openstack-dev03:31
ayoungI could see it being a useful abstracting03:32
ayoungabstraction03:32
jamielennoxhmm, that' s right03:32
jamielennoxwith revocation signing though i don't see why we do half of that already03:33
ayoungand...it seems more correct to just see what the operations are on the data anyway03:33
*** pradeep has joined #openstack-dev03:33
jamielennoxif you want to get back a signed list you should Accept: x-cms (whatever that content type is)03:33
ayoungjamielennox, thats the thing, the content type is more than just the signature03:34
*** jnoller has quit IRC03:34
jamielennoxi'd prefer to ditch the XML interface over have it customizable03:34
ayoungI mean, yes, compression and encryption can be done at the http layer03:34
jamielennoxbrb03:34
ayoungand if you don't need them, you can strip them out03:34
*** dims has quit IRC03:35
*** baoli has quit IRC03:35
*** dims has joined #openstack-dev03:36
*** AlexF has quit IRC03:37
*** doug_shelley66 has quit IRC03:37
*** rodrigods has quit IRC03:38
*** sweston has joined #openstack-dev03:39
stevemarlbragstad, https://review.openstack.org/#/c/72530/03:40
*** rodrigods has joined #openstack-dev03:40
*** rodrigods has quit IRC03:40
*** rodrigods has joined #openstack-dev03:40
stevemarayoung ^ if not in dad-mode03:40
*** Edward-Zhang has quit IRC03:40
ayoungstevemar, good to go03:41
*** byeager has joined #openstack-dev03:41
*** sarob has joined #openstack-dev03:43
*** Edward-Zhang has joined #openstack-dev03:44
*** bdpayne has joined #openstack-dev03:44
*** dims has quit IRC03:45
jamielennoxayoung: ok so theres nothing within CMS for content-type, i didn't think there was but worth checking03:45
ayoungjamielennox,  let the idea bake....I'm not moving on it until after the meeting tomorrowq03:46
*** dims has joined #openstack-dev03:46
jamielennoxayoung: yea, i have no objection i don't think other that "do we need it" cause it will bring some complexity03:46
ayoungminute amount, with potentially large potential future operations03:46
ayoungand since we need to change the format anyway03:47
ayoung{cmsz} was relly just kindof off the cuff anyway03:47
*** praneshp has quit IRC03:47
jamielennoxayoung: i would just like some more info on these large future operations and whether they are wanted03:47
jamielennoxfrom the client side we have no means of dealing with that sort of thing03:47
*** buzztroll has joined #openstack-dev03:48
jamielennoxobviously we could, but just what does it buy us03:48
*** flamebot has quit IRC03:49
ayoungjamielennox, what else needs to be confirmed across the network without a round trip?03:49
ayoungQuota?03:49
*** sarob_ has joined #openstack-dev03:49
*** sarob has quit IRC03:50
*** sweston has quit IRC03:50
*** flamebot has joined #openstack-dev03:50
ayoungjamielennox, I still don't have an easy way to extract the certificate information without running it through CMS again03:50
*** russell_h has quit IRC03:52
*** russell_h has joined #openstack-dev03:52
ayoungARGH...rebase mess up///03:52
jamielennoxayoung: signed vs headers are somewhat different though03:53
ayoungyeah...03:53
*** galstrom is now known as galstrom_zzz03:53
*** arnaud has quit IRC03:53
jamielennoxanyway can be left for the meeting03:54
jamielennoxi don't think quota should be our problem03:54
*** arnaud__ has quit IRC03:54
*** flamebot has quit IRC03:54
*** dims has quit IRC03:55
*** carl_baldwin has joined #openstack-dev03:55
*** flamebot has joined #openstack-dev03:55
jamielennoxayoung: this is a very quick review if you have a moment: https://review.openstack.org/#/c/7063403:56
*** dims has joined #openstack-dev03:56
*** Edward-Zhang has quit IRC03:58
*** RajeshMohan has quit IRC03:58
*** sweston has joined #openstack-dev03:58
*** buzztroll has quit IRC03:58
*** RajeshMohan has joined #openstack-dev03:59
*** otherwiseguy has joined #openstack-dev04:01
stevemarjamielennox, ahh, they should be wrapped in quotes: __all__ = ['SqliteDb', 'KvsDb']04:01
jamielennoxstevemar: hmm, i'm pretty sure both work - i saw that method somewhere and it seemed to be more explicit04:02
*** buzztroll has joined #openstack-dev04:02
jamielennoxguess i'll go back to quoting hen04:02
*** gokrokve has quit IRC04:05
*** gokrokve has joined #openstack-dev04:05
*** bdpayne has quit IRC04:06
*** byeager has quit IRC04:06
*** gokrokve has quit IRC04:10
*** bhuvan has joined #openstack-dev04:10
*** galstrom_zzz is now known as galstrom04:12
*** buzztroll has quit IRC04:12
*** ramishra_ has quit IRC04:12
*** tjones has quit IRC04:13
*** bdpayne has joined #openstack-dev04:14
*** cagrev has quit IRC04:14
kashyapharlowja,  (Not sure my previous message appeared, my proxy dropped) Thank you will try in a few. /me still learning the ropes of gerrit-workflow04:14
*** rraja has joined #openstack-dev04:15
*** MaxV has joined #openstack-dev04:18
*** yamahata has joined #openstack-dev04:19
*** ayoung has quit IRC04:20
*** rohitk has joined #openstack-dev04:21
*** harlowja is now known as harlowja_away04:22
*** MaxV has quit IRC04:23
*** yamahata has quit IRC04:23
*** ijw has quit IRC04:23
*** ijw has joined #openstack-dev04:24
*** bhuvan has quit IRC04:24
*** gokrokve has joined #openstack-dev04:25
*** cagrev has joined #openstack-dev04:27
topolmorganfainberg, are you still lurking?04:28
*** ijw has quit IRC04:28
*** cagrev has quit IRC04:30
*** harlowja_away is now known as harlowja04:30
*** buzztroll has joined #openstack-dev04:31
*** belliott has quit IRC04:33
*** igor_ has joined #openstack-dev04:35
*** galstrom is now known as galstrom_zzz04:37
*** belliott has joined #openstack-dev04:38
*** praneshp has joined #openstack-dev04:38
*** dims has quit IRC04:41
*** buzztroll has quit IRC04:42
*** johnthetubaguy has quit IRC04:42
*** dims has joined #openstack-dev04:43
*** yamahata has joined #openstack-dev04:45
noorulIs there any documentation on how to write keystone plugin outside of keystone repo?04:45
*** buzztroll has joined #openstack-dev04:46
noorulI see this http://docs.openstack.org/developer/keystone/extension_development.html04:48
noorulbut it explains how to add code in contrib directory. I am looking keeping this plugin outside of keystone soruce repo.04:48
*** johnthetubaguy has joined #openstack-dev04:49
*** jaybuff has joined #openstack-dev04:51
*** kushal has quit IRC04:53
*** jaybuff1 has joined #openstack-dev04:54
*** jaybuff has quit IRC04:54
*** Edward-Zhang has joined #openstack-dev04:55
stevemartopol, he should be around04:55
topolstevemar. no biggie. The context thing dolphm recommended did not work. It ends up mapping to the object class instead of the context dictionary.  I copied the error and will put it in as a comment04:57
*** bhuvan has joined #openstack-dev04:59
*** bdpayne has quit IRC04:59
*** eharney has quit IRC05:02
*** kushal has joined #openstack-dev05:03
*** rohitk has quit IRC05:04
*** sarob_ has quit IRC05:06
*** AlexF has joined #openstack-dev05:06
*** CaptTofu has joined #openstack-dev05:07
*** sarob has joined #openstack-dev05:07
*** bdpayne has joined #openstack-dev05:07
*** crank has quit IRC05:07
*** sarob_ has joined #openstack-dev05:08
*** thuc has joined #openstack-dev05:08
*** sarob_ has quit IRC05:09
*** mriedem has joined #openstack-dev05:09
*** aspiers has joined #openstack-dev05:09
*** sarob_ has joined #openstack-dev05:09
*** thuc_ has joined #openstack-dev05:10
*** arosen has joined #openstack-dev05:10
*** sumanthns has joined #openstack-dev05:10
*** CaptTofu has quit IRC05:11
*** sarob has quit IRC05:11
*** thuc has quit IRC05:13
*** sarob_ has quit IRC05:13
*** crank has joined #openstack-dev05:14
*** killer_prince has quit IRC05:14
*** killer_prince has joined #openstack-dev05:14
*** alop has quit IRC05:14
stevemartopol, almost done :P I got 1 review left in me05:15
*** jhesketh__ has quit IRC05:15
*** chandan_kumar has quit IRC05:15
topolstevemar, I am going big or going home... I'm trying to cover few more cases beyond get_userId. Trying to handle username plus either domain name or id as well.05:16
*** chandan_kumar has joined #openstack-dev05:16
*** haomai___ has quit IRC05:16
topolstevemar,  I may need to update the v2 stuff as well. Isnt it possible in v2 you could get a user_id instead of user_name?  I need to go look at the v2 API05:17
*** alop has joined #openstack-dev05:17
topolstevemar. I'll have something ready by tomorrow even if I have to code all night05:18
*** jecarey has joined #openstack-dev05:18
*** buzztroll has quit IRC05:18
*** sweston has quit IRC05:19
stevemartopol, yowza! i like it! Yes, you can have user_id in v2 as well i believe05:21
*** flamebot has quit IRC05:21
*** flamebot has joined #openstack-dev05:22
*** bdpayne has quit IRC05:22
topolstevemar,  Thanks. I look at the v2 markup.  I know you were willing to bail me out but I learn 10 times as much when I have to code stuff :-)05:23
topolstevemar the spec even makes sense now :-)05:23
*** pradeep has quit IRC05:24
stevemartopol, yep, userid is valid for v2: https://github.com/openstack/keystone/blob/master/keystone/tests/test_auth.py#L3705:25
*** bashok has joined #openstack-dev05:26
topolstevemar, thanks05:26
stevemartopol and ... https://github.com/openstack/keystone/blob/master/keystone/tests/test_v3.py#L1060 i really should have linked these much earlier05:27
topolstevemar, K thanks05:27
*** tkay has joined #openstack-dev05:29
*** kushal has quit IRC05:31
*** tkay has quit IRC05:31
*** pradeep has joined #openstack-dev05:31
*** bdpayne has joined #openstack-dev05:32
*** tkay has joined #openstack-dev05:32
*** tkay has quit IRC05:32
*** doug_shelley66 has joined #openstack-dev05:34
*** sarob has joined #openstack-dev05:34
*** thuc_ has quit IRC05:35
*** jaybuff1 has left #openstack-dev05:35
*** thuc has joined #openstack-dev05:35
*** dims has quit IRC05:35
*** amcrn has quit IRC05:36
*** dims has joined #openstack-dev05:37
*** thuc_ has joined #openstack-dev05:37
*** doug_shelley66 has quit IRC05:38
*** thuc has quit IRC05:40
*** nshaikh has joined #openstack-dev05:41
*** mriedem has quit IRC05:41
*** dims has quit IRC05:43
*** thuc_ has quit IRC05:44
*** aeperezt has quit IRC05:44
*** dims has joined #openstack-dev05:44
*** thuc has joined #openstack-dev05:45
*** rohitk has joined #openstack-dev05:45
*** yjiang51 has quit IRC05:48
*** thuc has quit IRC05:49
*** kushal has joined #openstack-dev05:50
*** unicell has quit IRC05:51
*** rdas has joined #openstack-dev05:52
*** gokrokve has quit IRC05:54
*** johnthetubaguy has quit IRC05:54
*** unicell has joined #openstack-dev05:55
*** buzztroll has joined #openstack-dev05:55
*** unicell has quit IRC05:55
*** buzztroll has quit IRC05:55
*** buzztroll has joined #openstack-dev05:55
*** unicell has joined #openstack-dev05:56
*** jecarey has quit IRC05:56
*** ctracey is now known as ctracey|away05:56
*** alop has quit IRC05:57
*** gokrokve has joined #openstack-dev05:57
*** marcoemorais has joined #openstack-dev06:01
*** marcoemorais has quit IRC06:01
*** kushal has quit IRC06:03
*** unicell has quit IRC06:04
*** AlexF has quit IRC06:04
*** sarob_ has joined #openstack-dev06:05
*** unicell has joined #openstack-dev06:05
*** unicell has quit IRC06:06
*** unicell has joined #openstack-dev06:06
*** rwsu has quit IRC06:07
*** rwsu has joined #openstack-dev06:07
*** sarob has quit IRC06:08
*** bhuvan has quit IRC06:09
*** neelashah1 has quit IRC06:10
*** sweston has joined #openstack-dev06:11
*** carl_baldwin has quit IRC06:11
*** tkay has joined #openstack-dev06:12
*** buzztroll has quit IRC06:12
*** sarob_ has quit IRC06:12
*** zaitcev has quit IRC06:14
*** amcrn has joined #openstack-dev06:15
*** tkay has quit IRC06:15
*** amcrn_ has joined #openstack-dev06:16
*** bdpayne has quit IRC06:17
*** buzztroll has joined #openstack-dev06:18
*** amcrn has quit IRC06:20
*** RajeshMohan has quit IRC06:21
*** RajeshMohan has joined #openstack-dev06:23
*** bhuvan has joined #openstack-dev06:23
*** killer_prince has quit IRC06:24
*** rwsu has quit IRC06:25
*** pingveno has joined #openstack-dev06:25
*** alop has joined #openstack-dev06:27
*** amcrn_ is now known as amcrn06:28
*** buzztroll has quit IRC06:30
*** DinaBelova_ is now known as DinaBelova06:31
*** cadenzajon has joined #openstack-dev06:33
*** harlowja is now known as harlowja_away06:33
*** rraja has quit IRC06:34
*** denis_makogon has joined #openstack-dev06:36
*** cadenzajon has quit IRC06:37
*** rwsu has joined #openstack-dev06:38
*** saju_m has joined #openstack-dev06:38
*** coolsvap has joined #openstack-dev06:40
*** unicell has quit IRC06:42
*** kushal has joined #openstack-dev06:43
*** saju_m has quit IRC06:43
*** buzztroll has joined #openstack-dev06:43
*** abhirc_ has quit IRC06:44
*** alop has quit IRC06:45
*** saju_m has joined #openstack-dev06:50
*** rraja has joined #openstack-dev06:51
*** saju_m has quit IRC06:51
*** saju_m has joined #openstack-dev06:51
*** hdd_ has quit IRC06:51
*** saju_m has quit IRC06:52
*** saju_m has joined #openstack-dev06:52
*** yolanda has quit IRC06:57
*** kdas_ has joined #openstack-dev07:01
*** kushal has quit IRC07:02
*** mkollaro has joined #openstack-dev07:03
*** sumanthns has quit IRC07:04
*** sarob has joined #openstack-dev07:05
*** jhesketh has quit IRC07:06
*** CaptTofu has joined #openstack-dev07:07
*** kdas_ has quit IRC07:07
*** sushils has joined #openstack-dev07:08
*** Drankis has joined #openstack-dev07:08
*** yolanda has joined #openstack-dev07:09
*** rohitk has quit IRC07:11
*** CaptTofu has quit IRC07:12
*** doude_ has joined #openstack-dev07:13
*** xqueralt has joined #openstack-dev07:13
*** doude has quit IRC07:13
*** mrunge has joined #openstack-dev07:14
*** omachace has joined #openstack-dev07:15
*** eglynn has quit IRC07:15
*** yamahata has quit IRC07:15
*** sweston is now known as _sweston07:16
*** avishay has joined #openstack-dev07:16
*** saju_m has quit IRC07:16
*** alop has joined #openstack-dev07:16
*** sushils has quit IRC07:18
*** gyee has quit IRC07:18
*** jhesketh has joined #openstack-dev07:19
*** yamahata has joined #openstack-dev07:20
*** buzztroll has quit IRC07:20
*** arosen has quit IRC07:21
marunlifeless: ping07:22
*** yongli has quit IRC07:22
*** reed has joined #openstack-dev07:22
*** cfriesen has quit IRC07:23
*** vartom1111111119 has joined #openstack-dev07:23
*** dims has quit IRC07:24
*** kushal has joined #openstack-dev07:24
*** dims has joined #openstack-dev07:25
*** rohitk has joined #openstack-dev07:27
*** topol has quit IRC07:28
*** kushal has quit IRC07:30
*** DinaBelova is now known as DinaBelova_07:30
*** negronjl has quit IRC07:31
*** dims has quit IRC07:32
*** negronjl has joined #openstack-dev07:32
*** Guest83278 has joined #openstack-dev07:32
*** dims has joined #openstack-dev07:32
*** avishayb has joined #openstack-dev07:33
*** rraja has quit IRC07:33
*** sarob has quit IRC07:33
*** e0ne has joined #openstack-dev07:34
*** dmsimard has joined #openstack-dev07:34
*** viktors has joined #openstack-dev07:34
*** e0ne has quit IRC07:35
*** saju_m has joined #openstack-dev07:37
*** markvoelker1 has quit IRC07:37
*** Guest83278 has quit IRC07:37
*** dmsimard1 has joined #openstack-dev07:37
*** belmoreira has joined #openstack-dev07:38
*** dmsimard has quit IRC07:38
*** _sweston is now known as sweston07:39
*** negronjl has quit IRC07:40
*** d0ugal has joined #openstack-dev07:41
*** d0ugal has quit IRC07:41
*** d0ugal has joined #openstack-dev07:41
*** cnesa has quit IRC07:42
*** dims has quit IRC07:42
*** dims has joined #openstack-dev07:43
*** dmsimard has joined #openstack-dev07:44
*** jhesketh has quit IRC07:45
*** eglynn has joined #openstack-dev07:45
*** dmsimard1 has quit IRC07:45
*** salv-orlando has quit IRC07:46
*** zigo has joined #openstack-dev07:47
*** MaxV has joined #openstack-dev07:48
*** jprovazn has joined #openstack-dev07:50
*** amuller has joined #openstack-dev07:51
*** saju_m has quit IRC07:52
*** buzztroll has joined #openstack-dev07:53
*** MaxV has quit IRC07:55
*** jamieh has joined #openstack-dev07:57
*** buzztroll has quit IRC07:58
*** sushils has joined #openstack-dev07:58
*** bauzas has joined #openstack-dev08:01
*** rdas has quit IRC08:02
*** denis_makogon has quit IRC08:04
*** flaper87|afk is now known as flaper8708:04
*** sarob has joined #openstack-dev08:05
*** killer_prince has joined #openstack-dev08:06
*** avishayb has quit IRC08:07
*** romcheg1 has joined #openstack-dev08:07
*** sarob has quit IRC08:10
*** evgenyf has joined #openstack-dev08:10
*** negronjl has joined #openstack-dev08:12
*** xga has joined #openstack-dev08:13
*** vartom1111111111 has joined #openstack-dev08:14
*** vartom1111111119 has quit IRC08:14
*** buzztroll has joined #openstack-dev08:17
*** kbrierly has joined #openstack-dev08:17
*** zoresvit has joined #openstack-dev08:21
*** yeylon_ has joined #openstack-dev08:22
*** bhuvan has quit IRC08:22
*** florentflament has joined #openstack-dev08:23
*** mrunge has quit IRC08:23
*** zoresvit has quit IRC08:23
*** zoresvit has joined #openstack-dev08:23
*** mrunge has joined #openstack-dev08:23
*** irenab has joined #openstack-dev08:24
*** sushils has quit IRC08:24
*** bhuvan has joined #openstack-dev08:24
*** marekd|away is now known as marekd08:24
*** corXi has joined #openstack-dev08:24
*** sushils has joined #openstack-dev08:25
*** yeylon__ has quit IRC08:25
*** buzztroll has quit IRC08:27
*** e0ne has joined #openstack-dev08:27
*** tkammer has joined #openstack-dev08:28
*** jtomasek has joined #openstack-dev08:28
*** I159 has joined #openstack-dev08:28
*** zzelle has joined #openstack-dev08:29
*** mmagr has joined #openstack-dev08:29
*** bhuvan has quit IRC08:30
*** sumanthns has joined #openstack-dev08:30
*** bhuvan has joined #openstack-dev08:31
*** DinaBelova_ is now known as DinaBelova08:32
lifelessmarun: pong08:32
marunlifeless: hi there08:33
marunlifeless: this may be an exercise in 'ducky'08:33
marunlifeless: https://review.openstack.org/#/c/7258508:34
*** killer_prince has quit IRC08:34
marunlifeless: There are 2 scenarios in the test in test_plugin_api in this review08:34
marunlifeless: I swear I was running them both at one point, but now I can't get them to run with testtools at all :(08:34
*** jhesketh has joined #openstack-dev08:35
*** killer_prince has joined #openstack-dev08:35
*** gcha has joined #openstack-dev08:35
*** eglynn has quit IRC08:36
*** thouveng has joined #openstack-dev08:36
*** MaxV has joined #openstack-dev08:37
*** jgallard has joined #openstack-dev08:38
*** buzztroll has joined #openstack-dev08:39
*** sahid has joined #openstack-dev08:39
lifelessmarun: will check in a bit, sorry elocal08:40
marunlifeless: no rush, i'm going to hit the hay now.08:40
*** ifarkas has joined #openstack-dev08:41
*** giulivo has joined #openstack-dev08:43
*** xgsa has joined #openstack-dev08:43
*** nacim has joined #openstack-dev08:44
*** pschaef has joined #openstack-dev08:46
*** shardy_afk is now known as shardy08:48
*** safchain has joined #openstack-dev08:49
*** e0ne_ has joined #openstack-dev08:49
*** buzztroll has quit IRC08:50
*** mindpixel has joined #openstack-dev08:51
*** saju_m has joined #openstack-dev08:51
*** rraja has joined #openstack-dev08:51
*** jordanP has joined #openstack-dev08:52
*** e0ne has quit IRC08:53
marekdstevemar: you still awake? :008:54
*** dtantsur has joined #openstack-dev08:54
*** ygbo has joined #openstack-dev08:56
*** psedlak has quit IRC08:56
*** mmagr has quit IRC08:56
*** rdas has joined #openstack-dev08:57
*** gokrokve has quit IRC08:57
*** mmagr has joined #openstack-dev08:57
*** kushal has joined #openstack-dev08:57
*** psedlak has joined #openstack-dev08:58
*** jistr has joined #openstack-dev08:58
*** aditirav has joined #openstack-dev08:59
*** markmc has joined #openstack-dev09:00
*** sergmelikyan has joined #openstack-dev09:00
*** jpich has joined #openstack-dev09:01
*** bhuvan has quit IRC09:03
*** yassine has joined #openstack-dev09:03
*** bhuvan has joined #openstack-dev09:04
*** sarob has joined #openstack-dev09:05
*** yamahata has quit IRC09:06
*** mbernacc has joined #openstack-dev09:06
*** yamahata has joined #openstack-dev09:07
*** CaptTofu has joined #openstack-dev09:08
*** bhuvan has quit IRC09:09
*** sarob has quit IRC09:10
*** eglynn has joined #openstack-dev09:11
*** bhuvan has joined #openstack-dev09:11
*** jcoufal has joined #openstack-dev09:12
*** DinaBelova is now known as DinaBelova_09:13
*** CaptTofu has quit IRC09:13
*** ramishra has joined #openstack-dev09:19
*** pixelb has joined #openstack-dev09:20
lifelessmarun: ok, tomorrow then :)09:20
*** afazekas has joined #openstack-dev09:21
*** athomas has joined #openstack-dev09:22
*** buzztroll has joined #openstack-dev09:24
*** DinaBelova_ is now known as DinaBelova09:24
*** rossella_s has joined #openstack-dev09:24
*** afazekas has quit IRC09:25
*** zhikunliu has quit IRC09:27
*** nmagnezi has joined #openstack-dev09:27
*** danpb has joined #openstack-dev09:28
*** buzztroll has quit IRC09:28
*** mkollaro has quit IRC09:30
*** gokrokve has joined #openstack-dev09:33
*** lucasagomes has joined #openstack-dev09:33
*** stevemar has quit IRC09:33
*** jp_at_hp has joined #openstack-dev09:35
*** jp_at_hp has quit IRC09:35
*** jp_at_hp has joined #openstack-dev09:35
*** gokrokve_ has joined #openstack-dev09:35
*** coolsvap has quit IRC09:36
*** boris-42_ has quit IRC09:36
*** praneshp has quit IRC09:37
*** abk has joined #openstack-dev09:37
*** gokrokve has quit IRC09:38
*** gokrokve_ has quit IRC09:39
*** mkollaro has joined #openstack-dev09:41
*** cdub has quit IRC09:44
*** cdub has joined #openstack-dev09:45
*** Edward-Zhang has quit IRC09:49
*** bhuvan has quit IRC09:52
*** bhuvan_ has joined #openstack-dev09:52
*** reed has quit IRC09:58
*** henrynash has joined #openstack-dev10:02
*** DinaBelova is now known as DinaBelova_10:03
*** sarob has joined #openstack-dev10:05
*** xga has quit IRC10:05
*** xga has joined #openstack-dev10:06
*** lazy_prince has joined #openstack-dev10:08
*** sarob has quit IRC10:10
*** xuhanp has quit IRC10:12
*** yeylon has joined #openstack-dev10:13
*** xchu has quit IRC10:13
*** iartarisi has joined #openstack-dev10:14
*** zzelle has quit IRC10:15
*** yeylon_ has quit IRC10:16
*** yeylon has quit IRC10:17
*** DinaBelova_ is now known as DinaBelova10:19
*** otherwiseguy has quit IRC10:19
*** vartom1111111111 has quit IRC10:19
*** bvandenh has joined #openstack-dev10:19
*** evgenyf has quit IRC10:21
*** buzztroll has joined #openstack-dev10:23
*** kris_h has joined #openstack-dev10:24
*** saju_m has quit IRC10:25
*** rohitk has quit IRC10:26
*** saju_m has joined #openstack-dev10:26
*** zoresvit has quit IRC10:27
*** gongysh has quit IRC10:27
*** abk has quit IRC10:27
*** buzztroll has quit IRC10:28
*** tris has joined #openstack-dev10:31
*** yeylon has joined #openstack-dev10:33
*** paragan has quit IRC10:34
*** gokrokve has joined #openstack-dev10:34
*** evgenyf has joined #openstack-dev10:36
*** neoXsys has joined #openstack-dev10:36
*** gokrokve has quit IRC10:39
*** bhuvan_ has quit IRC10:39
*** relaxdiego has quit IRC10:42
*** bhuvan has joined #openstack-dev10:44
*** max_lobur_afk is now known as max_lobur10:46
*** rfolco has joined #openstack-dev10:48
*** sumanthns has quit IRC10:48
*** aditirav has quit IRC10:48
*** sumanthns has joined #openstack-dev10:48
*** aditirav has joined #openstack-dev10:48
*** lazy_prince has quit IRC10:50
*** xingchao has quit IRC10:53
*** yaguang has quit IRC10:54
*** qba73 has joined #openstack-dev10:55
*** kolesovdv has joined #openstack-dev10:55
*** yassine has quit IRC10:56
*** tdruiva has quit IRC10:57
*** CaptTofu has joined #openstack-dev10:57
*** ArxCruz has joined #openstack-dev11:00
*** CaptTofu has quit IRC11:02
*** sarob has joined #openstack-dev11:05
*** reed has joined #openstack-dev11:06
*** bhuvan has quit IRC11:08
*** pcm_ has joined #openstack-dev11:08
*** bhuvan has joined #openstack-dev11:08
*** Alexei_987 has quit IRC11:10
*** pcm_ has quit IRC11:10
*** sarob has quit IRC11:10
*** mgoddard_ has joined #openstack-dev11:10
*** pcm_ has joined #openstack-dev11:10
*** nmagnezi has quit IRC11:10
*** reed has quit IRC11:11
*** gszasz has joined #openstack-dev11:11
*** ArxCruz has quit IRC11:14
*** boris-42_ has joined #openstack-dev11:16
*** xga has quit IRC11:17
*** xga has joined #openstack-dev11:18
*** e0ne_ has quit IRC11:19
*** jang has quit IRC11:19
*** huats__ has joined #openstack-dev11:20
*** jang has joined #openstack-dev11:20
*** huats has quit IRC11:21
*** tristanC has quit IRC11:21
*** tristanC has joined #openstack-dev11:21
*** mgoddard_ is now known as mgoddard11:21
*** tristanC has quit IRC11:22
*** tristanC has joined #openstack-dev11:22
*** kris_h has quit IRC11:23
*** buzztroll has joined #openstack-dev11:24
*** alexpilotti has joined #openstack-dev11:26
*** tdruiva has joined #openstack-dev11:27
*** RajeshMohan has quit IRC11:27
*** buzztroll has quit IRC11:27
*** RajeshMohan has joined #openstack-dev11:28
*** pradeep1 has joined #openstack-dev11:28
*** pradeep has quit IRC11:29
*** yeylon has quit IRC11:30
*** amuller_ has joined #openstack-dev11:30
*** amuller has quit IRC11:33
*** gokrokve has joined #openstack-dev11:34
*** tdruiva has quit IRC11:36
*** cnesa has joined #openstack-dev11:38
*** DinaBelova has quit IRC11:39
*** gokrokve has quit IRC11:39
*** DinaBelova has joined #openstack-dev11:39
*** bvandenh has quit IRC11:39
*** vladan has quit IRC11:40
*** vladikr has joined #openstack-dev11:40
*** vladan has joined #openstack-dev11:42
*** evgenyf has quit IRC11:43
*** vladan has quit IRC11:47
*** ArxCruz has joined #openstack-dev11:48
*** romcheg1 has quit IRC11:48
*** vkmc has joined #openstack-dev11:49
*** vkmc has quit IRC11:49
*** vkmc has joined #openstack-dev11:49
*** vladan has joined #openstack-dev11:49
*** pradeep has joined #openstack-dev11:50
*** alex_xu has quit IRC11:50
*** NikitaKonovalov_ has quit IRC11:50
*** e0ne has joined #openstack-dev11:50
*** pradeep1 has quit IRC11:51
*** SergeyLukjanov has quit IRC11:51
*** lazy_prince has joined #openstack-dev11:52
*** bvandenh has joined #openstack-dev11:52
*** mrunge has quit IRC11:52
*** jordanP has quit IRC11:52
*** NikitaKonovalov_ has joined #openstack-dev11:54
*** NikitaKonovalov_ is now known as NikitaKonovalov11:54
*** SergeyLukjanov has joined #openstack-dev11:55
*** nmagnezi has joined #openstack-dev11:58
*** e0ne_ has joined #openstack-dev11:59
*** yamahata has quit IRC12:02
*** d0ugal has quit IRC12:03
*** e0ne has quit IRC12:03
*** romcheg1 has joined #openstack-dev12:04
*** d0ugal has joined #openstack-dev12:04
*** d0ugal has quit IRC12:04
*** d0ugal has joined #openstack-dev12:04
*** sarob has joined #openstack-dev12:05
*** rohitk has joined #openstack-dev12:06
*** mrunge has joined #openstack-dev12:07
*** gcha has quit IRC12:07
*** doug_shelley66 has joined #openstack-dev12:07
*** Alexei_987 has joined #openstack-dev12:07
*** nmagnezi has quit IRC12:09
*** paragan has joined #openstack-dev12:10
*** sarob has quit IRC12:10
*** irenab has quit IRC12:11
*** yassine has joined #openstack-dev12:11
*** raildo has quit IRC12:12
*** pschaef has quit IRC12:14
*** kolesovdv has quit IRC12:17
*** yeylon has joined #openstack-dev12:18
*** bhuvan has quit IRC12:19
*** vladikr has quit IRC12:19
*** reed has joined #openstack-dev12:19
*** avishay has quit IRC12:22
*** tserong has quit IRC12:22
*** rraja has quit IRC12:22
*** ala_ has joined #openstack-dev12:22
*** tserong has joined #openstack-dev12:22
*** buzztroll has joined #openstack-dev12:23
*** jgallard has quit IRC12:23
*** reed has quit IRC12:24
*** bhuvan has joined #openstack-dev12:25
*** nmagnezi has joined #openstack-dev12:25
*** sahid has quit IRC12:25
*** ala has quit IRC12:26
*** kolesovdv has joined #openstack-dev12:26
*** buzztroll has quit IRC12:28
*** sahid has joined #openstack-dev12:28
*** eglynn is now known as eglynn-lunch12:29
*** nshaikh has quit IRC12:30
*** lucasagomes is now known as lucas-hungry12:30
*** aditirav has quit IRC12:32
*** henrynash has quit IRC12:32
*** gokrokve has joined #openstack-dev12:34
*** FunnyLookinHat has joined #openstack-dev12:35
*** FunnyLookinHat has joined #openstack-dev12:35
*** ttx has quit IRC12:35
*** neoXsys has quit IRC12:35
*** avishay has joined #openstack-dev12:36
*** amuller_ has quit IRC12:37
*** reed has joined #openstack-dev12:38
*** amuller__ has joined #openstack-dev12:38
*** amuller__ is now known as amuller12:38
*** gokrokve has quit IRC12:39
*** IanGovett has joined #openstack-dev12:40
*** gnorth has joined #openstack-dev12:40
*** venkatesh has joined #openstack-dev12:41
*** drewlander has joined #openstack-dev12:42
*** bhuvan has quit IRC12:43
*** reed_ has joined #openstack-dev12:44
*** zul has joined #openstack-dev12:45
*** glenng has joined #openstack-dev12:46
*** arosen has joined #openstack-dev12:47
*** reed has quit IRC12:47
*** avishay has quit IRC12:47
*** yamahata has joined #openstack-dev12:48
*** glenng1 has joined #openstack-dev12:49
*** sumanthns has quit IRC12:51
*** glenng has quit IRC12:51
*** vladan has quit IRC12:52
*** evgenyf has joined #openstack-dev12:53
*** yamahata has quit IRC12:54
*** vladan has joined #openstack-dev12:54
*** jhesketh has quit IRC12:54
*** irenab has joined #openstack-dev12:54
*** yeylon_ has joined #openstack-dev12:54
*** tmclaugh[work] has joined #openstack-dev12:55
*** baoli has joined #openstack-dev12:56
*** reed__ has joined #openstack-dev12:56
*** Sumeniac has quit IRC12:57
*** jgallard has joined #openstack-dev12:57
*** yeylon has quit IRC12:57
*** Sumeniac has joined #openstack-dev12:58
*** gszasz has quit IRC12:58
*** ttx_ has joined #openstack-dev12:58
*** reed_ has quit IRC13:00
*** reed__ has quit IRC13:01
*** kushal has quit IRC13:01
*** avishay has joined #openstack-dev13:02
*** tdruiva has joined #openstack-dev13:02
*** markmcclain has joined #openstack-dev13:02
*** mkollaro has quit IRC13:03
*** neelashah has joined #openstack-dev13:03
*** heyongli has joined #openstack-dev13:04
*** nmagnezi has quit IRC13:05
*** xga has quit IRC13:05
*** xga_ has joined #openstack-dev13:05
*** sarob has joined #openstack-dev13:05
*** mkollaro has joined #openstack-dev13:06
*** xga_ has quit IRC13:07
*** xga_ has joined #openstack-dev13:07
*** mlegault has joined #openstack-dev13:08
*** rcrit has joined #openstack-dev13:08
*** aeperezt has joined #openstack-dev13:08
*** cnesa has quit IRC13:09
*** gcha has joined #openstack-dev13:09
*** tkammer has quit IRC13:10
*** sgordon has joined #openstack-dev13:10
*** sgordon has joined #openstack-dev13:10
*** sarob has quit IRC13:10
*** zzelle has joined #openstack-dev13:11
*** henrynash has joined #openstack-dev13:11
*** nmagnezi has joined #openstack-dev13:12
*** xga_ has quit IRC13:12
*** rraja has joined #openstack-dev13:13
*** xga_ has joined #openstack-dev13:13
*** yeylon_ has quit IRC13:14
*** henrynash has quit IRC13:14
*** yamahata has joined #openstack-dev13:20
*** mrunge has quit IRC13:20
*** gszasz has joined #openstack-dev13:21
*** venkatesh has quit IRC13:22
*** tkammer has joined #openstack-dev13:22
*** buzztroll has joined #openstack-dev13:23
*** ramishra has quit IRC13:23
*** dstanek has joined #openstack-dev13:24
*** bvandenh has quit IRC13:24
*** rfolco has quit IRC13:25
*** jdob has joined #openstack-dev13:26
*** buzztroll has quit IRC13:28
*** gordc has joined #openstack-dev13:28
*** aveiga has joined #openstack-dev13:29
*** yeylon_ has joined #openstack-dev13:30
*** bvandenh has joined #openstack-dev13:31
*** bvandenh has quit IRC13:33
*** jordanP has joined #openstack-dev13:34
*** gokrokve has joined #openstack-dev13:34
*** kushal has joined #openstack-dev13:35
*** xga has joined #openstack-dev13:35
*** hdd_ has joined #openstack-dev13:36
*** gokrokve_ has joined #openstack-dev13:36
*** lbragstad has quit IRC13:36
*** thomasem has joined #openstack-dev13:38
*** xga_ has quit IRC13:38
*** gokrokve has quit IRC13:39
*** vladikr has joined #openstack-dev13:39
*** schwicht has joined #openstack-dev13:40
*** galstrom_zzz is now known as galstrom13:40
*** gokrokve_ has quit IRC13:41
*** xingchao has joined #openstack-dev13:42
*** haomaiwa_ has joined #openstack-dev13:43
*** lucas-hungry is now known as lucasagomes13:44
*** CaptTofu has joined #openstack-dev13:44
*** aditirav has joined #openstack-dev13:45
*** aditirav has quit IRC13:45
*** eharney has joined #openstack-dev13:46
*** aditirav has joined #openstack-dev13:46
*** topol has joined #openstack-dev13:49
*** pradeep has quit IRC13:50
*** haomai___ has joined #openstack-dev13:50
*** henrynash has joined #openstack-dev13:51
*** achampion has quit IRC13:51
*** ramishra has joined #openstack-dev13:52
*** noslzzp has joined #openstack-dev13:52
*** tdruiva has quit IRC13:52
*** haomaiwa_ has quit IRC13:53
*** joesavak has joined #openstack-dev13:53
*** zul has quit IRC13:53
*** pradeep has joined #openstack-dev13:54
*** mkollaro1 has joined #openstack-dev13:55
*** mkollaro has quit IRC13:55
*** ramishra_ has joined #openstack-dev13:55
*** alex_xu has joined #openstack-dev13:57
*** mriedem has joined #openstack-dev13:57
*** ramishra has quit IRC13:58
*** ramishra has joined #openstack-dev13:59
*** heyongli has quit IRC14:00
*** jmckind has joined #openstack-dev14:01
*** gszasz has quit IRC14:01
*** otherwiseguy has joined #openstack-dev14:01
*** dprince has joined #openstack-dev14:02
*** ramishra_ has quit IRC14:02
*** rdas has quit IRC14:04
*** dims has quit IRC14:05
*** sarob has joined #openstack-dev14:05
*** galstrom is now known as galstrom_zzz14:06
*** morazi has joined #openstack-dev14:06
*** dvarga has joined #openstack-dev14:06
*** rfolco has joined #openstack-dev14:06
*** thuc has joined #openstack-dev14:07
*** tdruiva has joined #openstack-dev14:07
*** dims has joined #openstack-dev14:10
*** changbl has quit IRC14:10
*** sarob has quit IRC14:10
*** stevemar has joined #openstack-dev14:11
*** simo_ has joined #openstack-dev14:12
*** sahid has quit IRC14:12
*** xga_ has joined #openstack-dev14:13
*** andreykurilin has joined #openstack-dev14:13
*** Tross has joined #openstack-dev14:13
*** gszasz has joined #openstack-dev14:14
*** ala_ has quit IRC14:15
gilliardIs there any guideline about when to use timeutils and when to use time from the standard python libs?14:15
gilliardtimeutils provides a way of mocking for tests, but a lot of code uses time.time directly.14:16
*** jpomero has quit IRC14:16
*** xga has quit IRC14:16
*** aditirav has quit IRC14:16
chmoueljgriffith: hello i have added a comment here https://review.openstack.org/#/c/68726/14:16
*** Tross has quit IRC14:17
gilliardspecifically w.r.t this patch: https://review.openstack.org/#/c/72200/14:17
*** capri has quit IRC14:17
*** yaguang has joined #openstack-dev14:17
*** stevemar2 has joined #openstack-dev14:17
*** stevemar has quit IRC14:18
*** markmcclain has quit IRC14:18
*** arosen has quit IRC14:18
*** jordanP has quit IRC14:18
*** arosen has joined #openstack-dev14:19
*** capri has joined #openstack-dev14:19
gilliardI wonder if one is the preferred way or if it's just up to the developer.14:19
*** nshaikh has joined #openstack-dev14:19
*** dstanek has quit IRC14:20
*** topol has quit IRC14:21
*** rodrigods has quit IRC14:22
*** READ10 has joined #openstack-dev14:23
*** buzztroll has joined #openstack-dev14:23
*** ifarkas has quit IRC14:24
*** mindpixel has quit IRC14:25
*** ifarkas has joined #openstack-dev14:25
*** sahid has joined #openstack-dev14:26
*** saju_m has quit IRC14:27
*** aditirav has joined #openstack-dev14:27
*** buzztroll has quit IRC14:28
*** samuelbercovici has joined #openstack-dev14:28
*** kolesovdv has quit IRC14:29
*** simo_ is now known as simo14:29
*** thuc has quit IRC14:29
*** simo has quit IRC14:29
*** simo has joined #openstack-dev14:29
*** dkranz has quit IRC14:29
*** saju_m has joined #openstack-dev14:29
*** thuc has joined #openstack-dev14:29
gilliardAnswering my own question: set_time_override is being deprecated. https://bugs.launchpad.net/oslo/+bug/126696214:30
uvirtbotLaunchpad bug 1266962 in oslo "Remove set_time_override in timeutils" [Low,In progress]14:30
*** tkammer has quit IRC14:30
*** nmagnezi has quit IRC14:31
*** avishay has quit IRC14:31
*** cfriesen has joined #openstack-dev14:32
*** topol has joined #openstack-dev14:32
*** igor___ has joined #openstack-dev14:33
*** jordanP has joined #openstack-dev14:33
*** thuc has quit IRC14:34
*** igor_ has quit IRC14:34
*** gokrokve has joined #openstack-dev14:34
*** henrynash has quit IRC14:34
*** lazy_prince has quit IRC14:35
*** peristeri has joined #openstack-dev14:35
*** rodrigods has joined #openstack-dev14:36
*** rohitk has quit IRC14:36
*** lbragstad has joined #openstack-dev14:36
*** Tross has joined #openstack-dev14:36
*** dkranz has joined #openstack-dev14:36
*** jecarey has joined #openstack-dev14:36
*** hartsocks has joined #openstack-dev14:37
*** jpomero has joined #openstack-dev14:37
*** henrynash has joined #openstack-dev14:37
*** stevemar2 has quit IRC14:38
*** gokrokve has quit IRC14:39
*** mfer has joined #openstack-dev14:39
*** thuc has joined #openstack-dev14:40
*** dperaza has joined #openstack-dev14:41
*** florentflament has quit IRC14:42
*** mst89 has joined #openstack-dev14:42
*** dstanek has joined #openstack-dev14:43
*** tkammer has joined #openstack-dev14:43
*** cagrev has joined #openstack-dev14:43
*** nmagnezi has joined #openstack-dev14:44
*** avishay has joined #openstack-dev14:46
*** ayoung has joined #openstack-dev14:47
*** dkranz has quit IRC14:47
*** jgallard_ has joined #openstack-dev14:47
*** tsekiyama has joined #openstack-dev14:47
*** henrynash has quit IRC14:48
*** thuc has quit IRC14:48
*** achampion has joined #openstack-dev14:48
*** thuc has joined #openstack-dev14:49
*** jprovazn has quit IRC14:49
marekddolphm: ping?14:49
*** jgallard has quit IRC14:51
*** jprovazn has joined #openstack-dev14:51
*** mflobo_ has joined #openstack-dev14:51
*** cnesa has joined #openstack-dev14:51
*** imcsk8 has joined #openstack-dev14:52
*** kevinconway has joined #openstack-dev14:52
*** romcheg1 has quit IRC14:52
*** prad_ has joined #openstack-dev14:53
*** thuc has quit IRC14:53
*** wchrisj|away is now known as chris_johnson14:53
dolphmmarun: pong14:53
*** ilyashakhat has quit IRC14:54
dolphmmarekd: pong! (my bad, marun)14:54
*** mflobo has quit IRC14:54
*** FunnyLookinHat has quit IRC14:54
*** jruzicka has joined #openstack-dev14:54
*** ygbo has quit IRC14:55
*** ysk has quit IRC14:56
*** mriedem has quit IRC14:56
*** rkukura has quit IRC14:56
*** arosen has quit IRC14:56
*** nacim has quit IRC14:56
*** mriedem has joined #openstack-dev14:57
*** ygbo has joined #openstack-dev14:59
*** devoid has joined #openstack-dev14:59
*** xga_ has quit IRC15:00
*** CaptTofu has quit IRC15:00
*** abhirc has joined #openstack-dev15:01
*** Mandell has joined #openstack-dev15:01
*** pschaef has joined #openstack-dev15:01
*** radez_g0n3 is now known as radez15:02
*** mriedem has quit IRC15:02
*** armax has joined #openstack-dev15:02
*** sahid has quit IRC15:03
*** rkukura has joined #openstack-dev15:03
*** hdd_ has quit IRC15:04
*** xga has joined #openstack-dev15:04
*** sarob has joined #openstack-dev15:05
*** therve_ has joined #openstack-dev15:05
*** therve_ has quit IRC15:05
*** terrylhowe has joined #openstack-dev15:05
*** mgagne has joined #openstack-dev15:05
*** danielbruno has joined #openstack-dev15:06
*** nacim has joined #openstack-dev15:06
*** bashok has quit IRC15:06
*** eglynn-lunch is now known as eglynn15:09
*** sarob has quit IRC15:10
*** mst89_ has joined #openstack-dev15:10
*** zul has joined #openstack-dev15:12
*** belmoreira has quit IRC15:12
*** belmoreira has joined #openstack-dev15:13
*** sweston has quit IRC15:13
*** stevemar has joined #openstack-dev15:14
*** mst89 has quit IRC15:14
stevemarbknudson, apparently everyone wants to sync oslo15:14
*** alop has joined #openstack-dev15:16
bknudsonstevemar: when the sync brings in changes for the config options they have to update the sample config.15:16
stevemarbknudson, yes, i noticed in your change, cool. I guess it's always best to look up all changes that happened?15:17
*** BobBallAway is now known as BobBall15:17
*** ruhe_ has joined #openstack-dev15:17
stevemarbknudson, what about the fact that morganfainberg also has the changes in his huge patch?15:17
*** belmoreira has quit IRC15:17
*** Tross has quit IRC15:17
bknudsonstevemar: I'm worried about any huge patch... I didn't look at it yet because of the size.15:18
*** jgrimm has joined #openstack-dev15:19
*** nshaikh has left #openstack-dev15:19
*** AlanClark has joined #openstack-dev15:20
stevemarbknudson, agreed. I skipped it over.15:20
stevemarbknudson, btw - pull the trigger on: https://review.openstack.org/#/c/67645/15:21
stevemar?15:21
bknudsonit would be nice to have everything in sync with oslo, so it's probably a good idea15:21
bknudsonstevemar: I've got a meeting here and then I'll take a look15:21
stevemarbknudson, oops, just noticed your s/t status, my bad15:22
*** rodrigods has quit IRC15:23
*** buzztroll has joined #openstack-dev15:23
*** aljoho has joined #openstack-dev15:23
dolphmbknudson: is nova evolving their approach to their config checker at all? i know they don't like it when they're gate dies because of upstream config changes15:23
*** sgrasley has quit IRC15:25
*** browne has joined #openstack-dev15:26
flamebotdevstack questions here? my upgraded stable/havana install gives me "cannot import name base"15:27
topoldolphm, on your comment on my patch is it possible the new signature of wrapper should be  def wrapper(cls, context, *args, **kwargs):  ?15:27
flamebotinstead of horizon15:27
*** buzztroll has quit IRC15:27
topoldolphm, because the way you had it I get AttributeError: 'CadfNotificationsWrapperTestCase' object has no attribute 'get'15:28
*** henrynash has joined #openstack-dev15:28
bknudsondolphm: there was some discussion on openstack-dev ml -- http://lists.openstack.org/pipermail/openstack-dev/2014-February/026246.html15:28
dolphmtopol: maybe? was it cls before?15:29
dolphmtopol: i feel like i assumed it was self15:29
dolphmtopol: but yes-- there should be an explicit argument before context, regardless (just not sure what it should be)15:29
topoldolphm, no but I was using args[1].15:30
*** FunnyLookinHat has joined #openstack-dev15:30
dolphmtopol: so definitely (something, context, *args, **kwargs) then15:31
topoldolphm, should I put self as the something?15:31
*** Gordonz has joined #openstack-dev15:31
dolphmtopol: link me to the review15:31
*** ttx has joined #openstack-dev15:31
*** ttx has quit IRC15:31
*** ttx has joined #openstack-dev15:31
*** Gordonz has quit IRC15:31
*** ttx_ has quit IRC15:31
topoldolphm, https://review.openstack.org/#/c/69632/9/keystone/cadf_notifications.py15:31
*** david-lyle has joined #openstack-dev15:32
dolphmtopol: yeah my suggested method signature is bad15:32
*** Gordonz has joined #openstack-dev15:32
topoldolphm, also can the notification package stuff wait until after feb 18?  I made all the other changes you asked for15:32
*** nmagnezi has quit IRC15:32
topoldolphm, should I just put cls? or self?15:32
dolphmtopol: and these are wrapping controller methods, where the signature is always (self, context, ...) so you should do the same15:33
topoldolphm, K I'll make it (self, context, ...)15:33
*** jcoufal_ has joined #openstack-dev15:33
topoldolphm, can the notification refactored as a module wait until after feb 18 or you want that done before?15:34
*** Tross has joined #openstack-dev15:34
*** gokrokve has joined #openstack-dev15:34
*** sahid has joined #openstack-dev15:34
dolphmtopol: you could also debug whether it should be cls or self at runtime by dumping whatever value is passed in to args[0] (self/cls) and seeing if it's type() is a 'class' instance (and therefore self) or a class 'type' definition (and therefore cls)15:35
dolphmtopol: refactor can wait15:35
dolphmtopol: you can put it up for review whenever you'd like though15:36
*** boris-42_ has quit IRC15:36
*** jcoufal has quit IRC15:36
*** dtantsur has quit IRC15:36
*** noslzzp has quit IRC15:36
*** jprovazn has quit IRC15:37
topoldolphm, great! Thanks.  On the refactor I would have to move notifications.py into the new package as well and then deal with all the changes that would impact, correct?15:37
*** vartom1111111111 has joined #openstack-dev15:37
*** glenng1 is now known as glenng15:37
*** reed__ has joined #openstack-dev15:38
dolphmtopol: yes, i guess it would become keystone.notifications.core ?15:38
dolphmtopol: poke morganfainberg on the details-- he thought through it more thoroughly than i15:38
topoldolphm, K, will do15:39
*** gokrokve has quit IRC15:39
*** galstrom_zzz is now known as galstrom15:39
*** yaguang has quit IRC15:40
*** relaxdiego has joined #openstack-dev15:40
*** noslzzp has joined #openstack-dev15:40
*** dtantsur has joined #openstack-dev15:41
*** hartsocks has quit IRC15:42
*** coolsvap has joined #openstack-dev15:42
*** carl_baldwin has joined #openstack-dev15:42
*** paragan has quit IRC15:43
*** Tross has quit IRC15:44
*** saju_m has quit IRC15:45
*** nkinder has joined #openstack-dev15:45
*** sarob has joined #openstack-dev15:45
*** jgallard_ has quit IRC15:46
*** saju_m has joined #openstack-dev15:46
*** vartom1111111111 has quit IRC15:47
*** henrynash has quit IRC15:48
*** zul has quit IRC15:48
*** carl_baldwin has quit IRC15:49
*** sarob has quit IRC15:50
*** aditirav_ has joined #openstack-dev15:50
*** kenperkins has joined #openstack-dev15:50
*** DinaBelova is now known as DinaBelova_15:51
*** aditirav has quit IRC15:52
*** aditirav_ is now known as aditirav15:52
*** carl_baldwin has joined #openstack-dev15:53
*** gokrokve has joined #openstack-dev15:55
*** mrunge has joined #openstack-dev15:56
*** jruzicka_ has joined #openstack-dev15:56
*** gokrokve_ has joined #openstack-dev15:56
*** reed__ is now known as reed15:56
*** reed has quit IRC15:56
*** reed has joined #openstack-dev15:56
*** devoid has quit IRC15:57
*** jruzicka has quit IRC15:58
*** AlexF has joined #openstack-dev15:58
*** mst89_ has quit IRC15:58
*** gokrokve has quit IRC15:59
*** Drankis has quit IRC15:59
*** comay has quit IRC16:00
*** Ruetobas has quit IRC16:01
*** rtheis has joined #openstack-dev16:01
*** amuller has quit IRC16:02
*** yjiang51 has joined #openstack-dev16:02
*** sarob has joined #openstack-dev16:02
*** amuller_ has joined #openstack-dev16:02
*** amuller_ is now known as amuller16:02
*** Ruetobas has joined #openstack-dev16:03
*** mriedem has joined #openstack-dev16:03
*** arosen has joined #openstack-dev16:04
*** dtantsur has quit IRC16:04
*** samuelbercovici has quit IRC16:05
*** corXi has quit IRC16:05
*** sarob_ has joined #openstack-dev16:05
*** carl_baldwin has quit IRC16:05
*** xarses has quit IRC16:06
*** rraja has quit IRC16:06
*** comay has joined #openstack-dev16:06
*** atiwari has joined #openstack-dev16:06
*** pmathews has joined #openstack-dev16:07
*** sarob has quit IRC16:07
*** tjones has joined #openstack-dev16:07
*** clayb has joined #openstack-dev16:07
*** qba73 has quit IRC16:07
*** Ruetobas has quit IRC16:08
*** lcheng_ has joined #openstack-dev16:09
*** sandywalsh has joined #openstack-dev16:09
*** pat___ has joined #openstack-dev16:10
*** jnoller has joined #openstack-dev16:10
*** cnesa has quit IRC16:10
*** hartsocks has joined #openstack-dev16:10
*** zul has joined #openstack-dev16:10
*** tkammer has quit IRC16:10
dolphmtopol: just spotted where you got the args[1] approach from16:10
*** jnoller_ has joined #openstack-dev16:11
*** pat___ has left #openstack-dev16:11
topoldolphm, did I do something wrong?16:11
dolphmtopol: nope! someone else did :P16:11
topoldolphm, I am just a lemming...16:11
topolpoint me to the cliff16:11
topoldolphm, I will fix mine and pus a new patch before the 1pm irc meeting16:12
*** jgallard has joined #openstack-dev16:13
*** mbernacc has quit IRC16:13
*** henrynash has joined #openstack-dev16:13
*** byeager has joined #openstack-dev16:13
dolphmtopol: cool!16:13
*** Ruetobas has joined #openstack-dev16:13
*** relaxdiego has quit IRC16:14
*** jnoller has quit IRC16:14
*** arosen has quit IRC16:14
*** garyk has joined #openstack-dev16:15
*** relaxdiego has joined #openstack-dev16:15
*** ramishra has quit IRC16:15
*** markmcclain has joined #openstack-dev16:15
*** jcoufal_ is now known as jcoufal16:15
*** arosen has joined #openstack-dev16:15
*** CaptTofu has joined #openstack-dev16:16
*** ramishra has joined #openstack-dev16:16
*** vijendar has joined #openstack-dev16:16
*** markmcclain1 has joined #openstack-dev16:16
*** dtantsur has joined #openstack-dev16:17
*** jmontemayor has joined #openstack-dev16:17
*** mrda_away is now known as mrda16:18
*** jmontemayor has quit IRC16:18
timelloIs there anyone that could review keystone/keystoneclient patches, please? https://review.openstack.org/#/c/70823/ https://review.openstack.org/#/c/71337/16:18
*** jmontemayor has joined #openstack-dev16:19
*** markmcclain has quit IRC16:19
*** gokrokve_ has quit IRC16:20
*** mrunge has quit IRC16:21
*** raildo has joined #openstack-dev16:22
*** gokrokve has joined #openstack-dev16:23
*** buzztroll has joined #openstack-dev16:23
*** xgsa has quit IRC16:23
*** ndipanov has joined #openstack-dev16:23
*** pradeep has quit IRC16:24
*** xga has quit IRC16:26
*** dvarga has quit IRC16:26
*** mdomsch has joined #openstack-dev16:27
*** hemna has joined #openstack-dev16:27
*** Tross has joined #openstack-dev16:27
*** nelsnelson has joined #openstack-dev16:27
*** Tross has quit IRC16:27
*** buzztroll has quit IRC16:28
*** thuc has joined #openstack-dev16:29
*** relaxdiego has quit IRC16:29
*** bnemec has quit IRC16:31
*** henrynash has quit IRC16:31
*** jruzicka_ is now known as jruzicka16:31
*** dkranz has joined #openstack-dev16:32
*** ramishra_ has joined #openstack-dev16:32
*** amuller has quit IRC16:32
*** henrynash has joined #openstack-dev16:33
*** RajeshMohan has quit IRC16:33
*** gyee has joined #openstack-dev16:33
*** RajeshMohan has joined #openstack-dev16:33
*** RajeshMohan has quit IRC16:33
*** RajeshMohan has joined #openstack-dev16:33
*** Tross has joined #openstack-dev16:34
*** bnemec has joined #openstack-dev16:34
*** ramishra has quit IRC16:34
*** I159 has quit IRC16:35
*** relaxdiego has joined #openstack-dev16:35
*** markwash has joined #openstack-dev16:35
*** rods has quit IRC16:38
*** tzabal has joined #openstack-dev16:38
*** cnesa has joined #openstack-dev16:40
*** tmclaugh[work] has quit IRC16:41
*** tmclaugh[work] has joined #openstack-dev16:41
*** rohitk has joined #openstack-dev16:42
*** nplanel has quit IRC16:42
*** julienvey has left #openstack-dev16:42
*** nplanel has joined #openstack-dev16:42
*** garyk has quit IRC16:42
*** ruhe_ has quit IRC16:43
*** sarob_ has quit IRC16:43
*** DinaBelova_ is now known as DinaBelova16:43
*** sarob has joined #openstack-dev16:43
*** mikeoutland has joined #openstack-dev16:44
*** cnesa2 has joined #openstack-dev16:44
*** xarses has joined #openstack-dev16:46
*** cnesa has quit IRC16:46
*** gokrokve has quit IRC16:47
*** gokrokve has joined #openstack-dev16:47
*** jistr has quit IRC16:47
*** sarob has quit IRC16:48
*** mlegault_ has joined #openstack-dev16:48
*** tjones has quit IRC16:50
*** cnesa2 has quit IRC16:50
*** beagles has quit IRC16:51
*** gokrokve has quit IRC16:51
*** mlegault__ has joined #openstack-dev16:51
*** ctracey|away is now known as ctracey16:51
*** boris-42_ has joined #openstack-dev16:52
*** mlegault has quit IRC16:52
*** max_lobur has quit IRC16:52
*** gokrokve has joined #openstack-dev16:52
*** ssurana has joined #openstack-dev16:53
*** tmclaugh[work] has quit IRC16:53
*** alexpilotti has quit IRC16:54
*** tjones has joined #openstack-dev16:54
*** cnesa has joined #openstack-dev16:54
*** Mandell has quit IRC16:55
*** jruzicka has quit IRC16:55
*** mlegault_ has quit IRC16:55
*** yassine has quit IRC16:57
*** mikeoutland has quit IRC16:58
*** bauzas has quit IRC16:58
*** jmontemayor_ has joined #openstack-dev16:58
*** e0ne_ has quit IRC16:59
*** tmclaugh[work] has joined #openstack-dev17:00
*** tqtran has joined #openstack-dev17:01
jog0dolphm: http://logs.openstack.org/20/56420/7/check/check-tempest-dsvm-neutron/24b6f66/logs/screen-key.txt.gz?level=DEBUG17:01
*** jmontema_ has joined #openstack-dev17:01
jog0why are dogpile debug logs on?17:01
*** dvarga has joined #openstack-dev17:01
*** gokrokve has quit IRC17:01
*** jmontema_ has quit IRC17:01
jog0and iso8601?17:01
jog0ayoung: ^17:01
*** DavidPatterson has joined #openstack-dev17:01
*** jmontemayor has quit IRC17:01
*** jmontemayor_ has quit IRC17:02
dolphmjog0: good question... (ping: bknudson)17:02
ayoungjog0, ask morganfainberg_Z when he's awake.  it is annoying, but something about a something default internal mumble something17:02
*** jmontema_ has joined #openstack-dev17:02
*** changbl has joined #openstack-dev17:02
*** DavidPatterson has left #openstack-dev17:02
*** evgenyf has quit IRC17:02
jog0ayoung dolphmL ets fix the defaults17:02
bknudsonjog0: that's the default... I posted a patch to change the default...17:02
dolphmjog0: i believe bknudson did17:02
dolphmbknudson: did it merge?17:02
bknudsonjog0: dolphm: https://review.openstack.org/#/c/62068/17:03
*** lcheng_ has quit IRC17:03
*** devoid has joined #openstack-dev17:03
dolphmjog0: isn that check job recent?17:03
dolphmis*17:03
bknudsonit hasn't merged.17:03
bknudsonthe change needed a rebasing17:04
jog0bknudson: sweet thanks17:04
jog0looking forward to seeing this landing17:04
*** thedodd has joined #openstack-dev17:04
*** b3nt_pin has joined #openstack-dev17:04
*** b3nt_pin is now known as beagles17:04
*** iartarisi has quit IRC17:05
dolphmbknudson: approved the underlying patch17:05
*** dsirrine has quit IRC17:05
*** noslzzp has quit IRC17:05
dolphmbknudson: find another +2 on the second one :)17:06
bknudsondolphm: that's always the hard part.17:06
*** kgriffs is now known as kgriffs_afk17:07
*** athomas has quit IRC17:07
*** dtantsur has quit IRC17:07
*** jruzicka has joined #openstack-dev17:07
*** sweston has joined #openstack-dev17:07
*** markmc has quit IRC17:08
*** mkollaro1 has quit IRC17:09
*** bdpayne has joined #openstack-dev17:09
*** dvarga is now known as dvarga|away17:10
*** jordanP has quit IRC17:10
*** xga has joined #openstack-dev17:10
*** dvarga|away is now known as dvarga17:10
*** angdraug has joined #openstack-dev17:11
*** henrynash has quit IRC17:11
*** jmching has joined #openstack-dev17:13
*** nacim has quit IRC17:14
*** sarob has joined #openstack-dev17:14
*** zaitcev has joined #openstack-dev17:15
*** jotan has joined #openstack-dev17:15
*** lpaschke has joined #openstack-dev17:15
*** alop_ has joined #openstack-dev17:16
*** dsirrine has joined #openstack-dev17:16
*** alop has quit IRC17:17
*** alop_ is now known as alop17:17
*** jaybuff has joined #openstack-dev17:17
*** jcoufal has quit IRC17:17
*** henrynash has joined #openstack-dev17:17
*** CaptTofu has quit IRC17:19
gyeebknudson, approved it17:19
*** garyk has joined #openstack-dev17:19
bknudsongyee: thanks! maybe we'll get fewer complaints about the log files.17:19
*** garyk has joined #openstack-dev17:19
*** peristeri has quit IRC17:19
*** cnesa has quit IRC17:20
*** pmathews has quit IRC17:20
*** ifarkas has quit IRC17:20
bknudsonnow just need to get https://review.openstack.org/#/c/67668/ in oslo-incubator merged and ported to keystone and we might have logs sane enough to actually tweak for usability17:20
*** marcoemorais has joined #openstack-dev17:20
*** max_lobur has joined #openstack-dev17:21
*** ianw has quit IRC17:21
*** peristeri has joined #openstack-dev17:21
*** marcoemorais has quit IRC17:21
*** mkollaro has joined #openstack-dev17:21
*** marcoemorais has joined #openstack-dev17:21
bknudsonand also these 2 in keystone: https://review.openstack.org/#/c/69218/ and https://review.openstack.org/#/c/69219/17:22
gyeebknudson, looking17:22
*** bdpayne_ has joined #openstack-dev17:22
*** pmathews has joined #openstack-dev17:23
*** buzztroll has joined #openstack-dev17:23
henrynashanyone interested in looking at the final +2 (or not) of https://review.openstack.org/#/c/44836/ ?17:23
*** kushal has quit IRC17:23
*** marcoemorais has quit IRC17:24
henrynashalso, the migration for the grant->assignment table is now done and up at: https://review.openstack.org/#/c/71159/517:24
*** fabiog has joined #openstack-dev17:24
*** bdpayne has quit IRC17:24
gyeehenrynash, I like rationalize the assignment grant table changes, good stuff!17:25
henrynashgyee: it's only taken us there releases to finally get it done :-)17:25
gyeehenrynash, it makes internal db reporting a hell lot easier too17:25
*** radez is now known as radez_g0n317:26
henrynashgyee: and in fact, we can simplify some of the calls at the Manager/Controller levels as well in time17:26
*** buzztroll has quit IRC17:26
*** Tross has quit IRC17:26
*** buzztroll has joined #openstack-dev17:26
dolphmhenrynash: wow two spelling mistakes slipped past bknudson...17:27
dolphmbknudson: you're slipping!17:28
*** godara has joined #openstack-dev17:28
bknudsondolphm: I won't let it happen again.17:28
*** jaybuff has left #openstack-dev17:30
dolphmhenrynash: bknudson: i'm going to submit a follow up patch or two, but so far lgtm17:30
*** _cjones_ has joined #openstack-dev17:30
*** cnesa has joined #openstack-dev17:31
*** aljoho has quit IRC17:31
*** viktors has quit IRC17:31
*** marcoemorais has joined #openstack-dev17:31
*** bswartz has quit IRC17:33
marunannegentle: ping17:34
*** gszasz has quit IRC17:34
*** ygbo has quit IRC17:34
*** RajeshMohan has quit IRC17:35
topoldolphm, so I had to rebase last night which I thought went fine but now I can't run my unit tests. I get ERROR: InvocationError: '/opt/stack/keystone/.tox/py27/bin/python setup.py testr --testr-args=keystone.tests.test_notifications.CadfNotificationsWrapperTestCase.test_v2_authenticate_username'17:35
topoldolphm, and when I run tox I get ./keystone/middleware/s3_token.py:39:1: H302  import only modules.'from keystoneclient.middleware import s3_token' does not import a module17:35
topolfrom keystoneclient.middleware import s3_token17:35
*** RajeshMohan has joined #openstack-dev17:36
topoldolphm which is not code I even touched17:36
*** max_lobur is now known as max_lobur_afk17:36
*** bhuvan has joined #openstack-dev17:36
topoldolphm, should I create a new branch by pulling down the most recent patch I uploaded last night?17:37
*** relaxdiego has quit IRC17:37
dolphmtopol: hrm... do you have the latest client installed?17:38
*** YorikSar has joined #openstack-dev17:38
*** AnilV4 has quit IRC17:38
topoldolphm probably not.17:38
*** rohitk has quit IRC17:39
*** tqtran has quit IRC17:40
*** sarob has quit IRC17:40
*** MaxV has quit IRC17:40
*** rohitk has joined #openstack-dev17:40
*** belmoreira has joined #openstack-dev17:40
topoldolphm, I am still in my working branch and did a git diff and it says I have made no updates17:40
*** sarob has joined #openstack-dev17:40
dolphmtopol: i assume you're using devstack?17:41
topoldolphm, NO NO NO17:41
topoldolphm, been running just stand alone keystone. my development is way faster that way17:42
dolphmtopol: lol ++17:42
*** ppetit has quit IRC17:42
* topol I hate waitng for devstack to start up if I can avoid it17:42
dolphmtopol: python -c "from keystoneclient.middleware import s3_token; print(s3_token)"17:43
dolphmtopol: what's that do?17:43
*** CaptTofu has joined #openstack-dev17:43
topoldolphm: Traceback (most recent call last):17:44
topol  File "<string>", line 1, in <module>17:44
topolImportError: cannot import name s3_token17:44
dolphmtopol: do you have a keystoneclient repo checked out?17:44
*** jgallard has quit IRC17:44
topoldolphm, looks that way yes. SHould I go in an do a git pull origin master?17:45
*** sarob has quit IRC17:45
*** gokrokve has joined #openstack-dev17:45
*** abhirc has quit IRC17:46
*** Skyrail has joined #openstack-dev17:46
dolphmtopol: yes17:46
*** bauzas has joined #openstack-dev17:46
*** eglynn has quit IRC17:47
*** markmcclain1 has quit IRC17:47
*** carl_baldwin has joined #openstack-dev17:47
topoldolphm, done.  should stuff work now17:47
*** amcrn has quit IRC17:48
*** jobewan has joined #openstack-dev17:48
*** mwagner_lap has joined #openstack-dev17:48
*** ijw has joined #openstack-dev17:49
*** gokrokve has quit IRC17:49
topoldolphm, pep8 still unhappy:17:49
topol./keystone/middleware/s3_token.py:39:1: H302  import only modules.'from keystoneclient.middleware import s3_token' does not import a module17:49
topolfrom keystoneclient.middleware import s3_token17:49
*** jmontema_ has quit IRC17:49
*** gokrokve has joined #openstack-dev17:49
dolphmtopol: what does that python -c thing do now?17:50
*** Tross has joined #openstack-dev17:50
topoldolphm, it gives me <module 'keystoneclient.middleware.s3_token' from '/opt/stack/python-keystoneclient/keystoneclient/middleware/s3_token.py'>17:51
*** devlaps has joined #openstack-dev17:51
*** noslzzp has joined #openstack-dev17:52
topoldolphm, I thought tox ran in its own environment (py27). do I need to regenerate that?17:52
*** xga_ has joined #openstack-dev17:52
dolphmhenrynash: bknudson: list limit related things https://review.openstack.org/#/c/72710/ https://review.openstack.org/#/c/72711/ https://review.openstack.org/#/c/72716/17:53
*** xga has quit IRC17:53
dolphmtopol: ooh, that's probably it17:53
dolphmtopol: yeah, rm -rf .tox/ or tox --recreate -e py2717:53
*** mmagr has quit IRC17:54
*** henrynash has quit IRC17:54
topoldolphm, K, cool. will try that17:54
*** marcoemorais has quit IRC17:54
*** gokrokve has quit IRC17:54
*** marcoemorais has joined #openstack-dev17:54
*** alexpilotti has joined #openstack-dev17:54
*** galstrom is now known as galstrom_zzz17:54
*** gokrokve has joined #openstack-dev17:54
*** prad_ has quit IRC17:54
*** henrynash has joined #openstack-dev17:55
*** marcoemorais has quit IRC17:55
*** marcoemorais has joined #openstack-dev17:55
*** carl_baldwin has quit IRC17:55
topoldolphm, so when I rebased last night it brought stuff down that made my tox environment inconsistent. Is that what happened?17:56
* topol I was just happy I successfully rebased at 2am all by myself...17:56
dolphmtopol: lol, what version of keystoneclient is in your requirements.txt ?17:57
*** raildo has quit IRC17:58
topoldolphm python-keystoneclient>=0.5.017:58
*** raildo has joined #openstack-dev17:58
*** henrique has joined #openstack-dev17:58
*** fabiomorais has joined #openstack-dev17:58
*** mrunge has joined #openstack-dev17:59
*** relaxdiego has joined #openstack-dev17:59
*** amuller has joined #openstack-dev18:00
*** gokrokve has quit IRC18:01
*** gokrokve has joined #openstack-dev18:01
*** morganfainberg_Z is now known as morganfainberg18:02
*** tqtran has joined #openstack-dev18:02
*** morganfainberg is now known as mrgnfeignbern18:03
*** marcoemorais has quit IRC18:04
*** markmcclain has joined #openstack-dev18:04
*** marcoemorais has joined #openstack-dev18:04
*** AlexF has quit IRC18:04
*** gokrokve has quit IRC18:06
*** Tross has quit IRC18:06
*** kgriffs_afk is now known as kgriffs18:07
*** AlexF has joined #openstack-dev18:07
*** sushils has quit IRC18:07
*** lpaschke has quit IRC18:08
*** READ10 has quit IRC18:08
*** Skyrail has quit IRC18:08
*** cnesa has quit IRC18:09
*** rossella_s has quit IRC18:10
*** mrgnfeignbern is now known as morganfainberg18:11
*** safchain has quit IRC18:12
*** Tross has joined #openstack-dev18:13
*** sushils has joined #openstack-dev18:14
*** amcrn has joined #openstack-dev18:16
*** kgriffs is now known as kgriffs_afk18:17
*** xga_ has quit IRC18:17
*** jotan has quit IRC18:18
*** gokrokve has joined #openstack-dev18:18
*** galstrom_zzz is now known as galstrom18:19
*** rohitk has quit IRC18:20
*** sahid has quit IRC18:20
*** Tross has quit IRC18:22
*** jmching has quit IRC18:22
*** danpb has quit IRC18:23
*** gokrokve has quit IRC18:23
*** mrodden has joined #openstack-dev18:23
*** browne has quit IRC18:24
*** kgriffs_afk is now known as kgriffs18:25
*** bswartz has joined #openstack-dev18:25
*** rcleere has quit IRC18:26
*** jpich has quit IRC18:26
*** AlexF has quit IRC18:27
*** kgriffs is now known as kgriffs_afk18:30
*** zzelle has quit IRC18:30
*** praneshp has joined #openstack-dev18:30
*** gokrokve has joined #openstack-dev18:31
*** arnaud has joined #openstack-dev18:31
*** arnaud__ has joined #openstack-dev18:31
*** tkay has joined #openstack-dev18:32
*** lucasagomes has quit IRC18:33
*** chandan_kumar has quit IRC18:34
*** epim has joined #openstack-dev18:37
*** melodous has joined #openstack-dev18:37
*** kgriffs_afk is now known as kgriffs18:38
*** bauzas has quit IRC18:38
*** abhirc has joined #openstack-dev18:38
*** Tross has joined #openstack-dev18:39
*** xqueralt has quit IRC18:39
*** flamebot has quit IRC18:40
*** browne has joined #openstack-dev18:41
*** melwitt has joined #openstack-dev18:41
*** gcha has quit IRC18:41
*** sushils has quit IRC18:42
jog0dtroyer: ping18:43
*** MaxV has joined #openstack-dev18:43
*** prad has joined #openstack-dev18:45
*** romcheg1 has joined #openstack-dev18:45
*** jasdeepH has joined #openstack-dev18:45
*** alexpilotti has quit IRC18:47
*** tjones has quit IRC18:47
*** jruzicka has quit IRC18:48
*** rcleere has joined #openstack-dev18:49
*** e0ne has joined #openstack-dev18:49
*** tdruiva has quit IRC18:50
*** jpomero has quit IRC18:50
*** novas0x2a|laptop has quit IRC18:50
*** tdruiva has joined #openstack-dev18:51
jog0dtroyer: looking fro some grenade feedback when you hav a moment18:51
*** abhirc has quit IRC18:51
*** mikeoutland has joined #openstack-dev18:52
*** moted has quit IRC18:53
*** evgenyf has joined #openstack-dev18:53
*** markmcclain has quit IRC18:53
*** markmcclain has joined #openstack-dev18:54
*** dperaza has quit IRC18:54
morganfainbergdolphm, https://blueprints.launchpad.net/openstack/?searchtext=mongodb-dogpile-caching-backend possible i3 target18:55
gyeejamielennox, just some minor nits about the v2 and v3 auth plugins, otherwise, they are awesome18:56
jamielennoxgyee: when you get a token you get a JSON/XML output of the token data18:56
morganfainbergdolphm, i'm happy to review it, and the code is up18:56
gyeejamelennox, right, middleware is a client and it interprets the token18:56
jamielennoxgyee: clients can use that but the actual token itself is only opened my auth_token18:56
morganfainbergdolphm, but i didn't want to target it w/o checking with you first18:57
gyeejamielennox, my point is with CMS, clients need to know how to validate it18:58
jamielennoxgyee: cool, i saw them briefly yesterday - i need to add the admin token thing now that i think about it18:58
jamielennoxgyee: auth_token i guess can be considered a client, it just doesn't fal into my standard definition of 'clients'18:58
*** jcoufal has joined #openstack-dev18:59
*** gokrokve has quit IRC18:59
gyeejamielennox, I know for sure there are Java clients out there that validates the signature18:59
jamielennoxgyee: auth_token will need to know, at some point it would be nice to have that functionality on keystoneclient18:59
dolphmmorganfainberg: skimming it - i'm not opposed18:59
*** rpodolyaka1 has joined #openstack-dev18:59
* dolphm afk18:59
*** jistr has joined #openstack-dev18:59
*** jgrimm has quit IRC19:00
*** gokrokve has joined #openstack-dev19:00
morganfainbergdolphm, ok i'll target it, if it runs into issues we can punt it back to J119:00
gyeemorganfainberg, ++19:00
*** jgrimm has joined #openstack-dev19:00
*** Mandell has joined #openstack-dev19:00
*** rpodolyaka1 has left #openstack-dev19:00
*** ramishra_ has quit IRC19:02
*** byeager has quit IRC19:03
*** cagrev has quit IRC19:03
*** jckasper has joined #openstack-dev19:04
*** jpomero has joined #openstack-dev19:04
*** cadenzajon has joined #openstack-dev19:04
*** byeager has joined #openstack-dev19:04
*** cagrev has joined #openstack-dev19:05
jamielennoxgyee: AdminToken? i was going to call it TokenEndpoint but it shounds funny19:05
*** markmcclain1 has joined #openstack-dev19:05
gyeejamielennox, StaticToken?19:05
jamielennoxgyee: it needs to be given the endpoint as well though19:06
*** dvarga is now known as dvarga|away19:06
gyeeadmin token is really a static token19:06
*** dvarga|away is now known as dvarga19:06
*** markmcclain has quit IRC19:06
jamielennoxgyee: it's not a good sign that i missed that and no tests failed19:07
gyeejamielennox, I was merely suggesting a hack, we just need a way to differentiate it from the regular tokens19:07
*** markmcclain has joined #openstack-dev19:07
jamielennoxgyee: it has a valid place in testing and it is used by the CLIs19:07
gyeejamielennox, yeah, that's scary :)19:07
*** galstrom is now known as galstrom_zzz19:07
gyeejamielennox, btw, the static admin token may go away soon when we have a bootstrap process in place19:09
jamielennoxgyee: that would be cool19:10
jamielennoxgyee: how are we expecting to bootstrap though/19:10
*** markmcclain1 has quit IRC19:10
gyeejamielennox, like create a real user in the *root* domain/project or something19:11
*** sarob has joined #openstack-dev19:11
ayounggyee, adding the -compress flag :19:11
ayoung-rw-rw-r--. 1 ayoung ayoung  705 Feb 11 14:10 auth_token_scoped_expired.pem19:11
ayoung-rw-rw-r--. 1 ayoung ayoung 2732 Feb 10 10:47 auth_token_scoped_expired.pem.orig19:11
ayoungorig is uncompressed19:11
gyeeayoung, w00t!19:11
ayoungyeah...this can be a drop in replacement, except for the MII thing19:11
morganfainbergayoung, do you need to explicitly -uncompress ?19:11
ayoungmorganfainberg, let me see , but I suspect not19:12
*** baoli has quit IRC19:12
*** michchap has joined #openstack-dev19:12
*** amuller has quit IRC19:12
gyeemorgainfainberg, no need to, openssl handles it internal I think19:13
*** praneshp has quit IRC19:14
*** michchap_ has quit IRC19:14
*** coasterz has quit IRC19:14
*** radez_g0n3 is now known as radez19:14
*** coasterz has joined #openstack-dev19:15
*** jprovazn has joined #openstack-dev19:15
*** evgenyf has quit IRC19:15
*** jrist has joined #openstack-dev19:15
*** fabiomorais has quit IRC19:16
ayoungmorganfainberg, yeah, looks like it needs an explict uncompress19:16
morganfainbergayoung, ick :(19:16
ayoungI can do that, and fall back if it is not compressed19:16
*** coolsvap has quit IRC19:17
*** buzztroll has quit IRC19:17
ayoungmorganfainberg, I have a couple other changes to make:  I am going to stop doing the PEM format, and instead do DER and a self BASE64 encode19:17
*** carl_baldwin has joined #openstack-dev19:18
ayoungthat will be more URL safe etc19:18
morganfainbergayoung, makes sense19:18
*** dstanek has quit IRC19:18
*** buzztrol_ has joined #openstack-dev19:18
ayoungbut this can, I think, go in as a stand alone commit.  Gonna abandon the other.  This one might have backport potential19:18
*** hartsocks has quit IRC19:18
*** praneshp has joined #openstack-dev19:19
*** moted has joined #openstack-dev19:19
*** jrist has quit IRC19:20
*** jp_at_hp has quit IRC19:21
*** dstanek has joined #openstack-dev19:24
*** ssurana has quit IRC19:24
*** READ10 has joined #openstack-dev19:26
*** READ10 has quit IRC19:26
*** yeylon__ has joined #openstack-dev19:26
*** READ10 has joined #openstack-dev19:26
dstaneki seem to have been disconnected...19:27
dstanekanyone else notice that the keystone tests are taking much longer to run?19:27
*** fabiog has quit IRC19:28
*** igor___ has quit IRC19:29
*** yeylon_ has quit IRC19:29
ayoungdstanek, did you to a laptop upgrade?19:30
*** pmathews has quit IRC19:30
ayounghttp://adam.younglogic.com/2012/06/sqlite-unit-tests/19:30
*** tanisdl has joined #openstack-dev19:30
*** jmontemayor has joined #openstack-dev19:30
*** pablosan has joined #openstack-dev19:32
*** omachace has quit IRC19:32
*** tiamar has quit IRC19:32
*** marcoemorais has quit IRC19:33
*** sarob has quit IRC19:33
*** mlavalle has joined #openstack-dev19:34
jamielennoxayoung: if you add -decompress to a CMS that isn't compressed does it work?19:36
jamielennoxayoung: also it doesn't give MII anymore?19:37
*** pmathews has joined #openstack-dev19:37
ayoungjamielennox, fairly certain it does not work, but haven't tested yet19:37
jamielennoxayoung: that's a pain, it would make upgrade easy19:38
ayoungjamielennox, I'm going to grandfather in the existing token format, but subsume it under the new code19:38
ayoungsI'll assume new code, but if it fails, fall back to the old19:38
ayounginstead of "MII" I'll just base64 decode19:38
*** marcoemorais has joined #openstack-dev19:38
ayoungto see if it is an ASN1 token19:38
ayoungI think I can make it pretty simple. Not sure if I'll have it ready today19:39
*** yeylon__ has quit IRC19:39
*** mrunge has quit IRC19:39
*** tjones has joined #openstack-dev19:40
*** bauzas has joined #openstack-dev19:41
*** enykeev has quit IRC19:41
*** rods has joined #openstack-dev19:41
*** ruhe_ has joined #openstack-dev19:41
*** tjones has quit IRC19:42
*** jamielennox is now known as jamielennox|away19:43
*** jamielennox|away is now known as jamielennox19:43
*** aditirav has quit IRC19:44
jamielennoxgyee: so we don't need an admin plugin just yet, at least for compatibility19:44
*** dstanek has quit IRC19:44
jamielennoxif you make a client that has a token and endpoint specified then it will never call out to authenticate and so our plugins are never run19:44
*** rods has quit IRC19:44
jamielennoxi'd apparently thought of that at some point :)19:44
*** rods has joined #openstack-dev19:44
gyeejamielennox, good!19:46
*** otherwiseguy has quit IRC19:47
*** doug_shelley66 has quit IRC19:47
*** doug_shelley66 has joined #openstack-dev19:47
jamielennoxgyee: dolphm suggested a trusts mix-in approach at some point - i've got no idea how that would work19:47
jamielennoxany ideas for how to handle trusts or just keep a trust_id param?19:48
*** jpomero has quit IRC19:48
*** novas0x2a|laptop has joined #openstack-dev19:49
*** saju_m has quit IRC19:49
*** dstanek has joined #openstack-dev19:49
gyeejamielennox, I think he meant to trust as an interface, to support oauth and trust and whatever comes along19:49
gyees/to trust/trust/19:49
jamielennoxmy thoughts with oauth was that they would just be a new plugin in v319:49
jamielennoxis that enough?19:50
jamielennoxstevemar: ^19:50
gyeeperhaps something like TrustAUth(**kwargs)19:50
jamielennoxstevemar: does oauth fit as another plugin like those in: https://review.openstack.org/#/c/68007/5/keystoneclient/auth/identity/v3.py19:50
*** ruhe_ has quit IRC19:50
jamielennoxgyee: but a trust is a parameter to another method of authenticating19:51
gyeeoauth needs more than just a trust ID19:51
jamielennoxgyee: so when you use a trust you still need to provide either a user/pass or existing token to authenticate with19:51
stevemarjamielennox, that's my plan for it19:51
*** saju_m has joined #openstack-dev19:51
gyeejamielennox, for trust API yes, but for oauth stevemar is the expert19:52
stevemarjamielennox, looking19:52
*** ssurana has joined #openstack-dev19:52
jamielennoxgyee: but to my understanding oauth is a standalone way of authenticating19:52
*** tjones has joined #openstack-dev19:52
jamielennoxyou provide your tokens in a similar way to what you would a user/pass19:53
stevemarjamielennox, I think I can plug it in19:53
gyeejamielennox, that's my understanding as well19:53
*** markmc has joined #openstack-dev19:53
*** bhuvan has quit IRC19:53
*** gokrokve has quit IRC19:53
stevemari might have to change fetch_auth_ref a bit19:54
stevemarbut it should be fine19:54
gyeejamielennox, we're good then, since stevemar says OK19:54
stevemarjamielennox, i'll send you a paste, 1 sec19:54
gyeeotherwise, we'll let him deal with monkeypatching! :)19:54
*** gokrokve has joined #openstack-dev19:54
stevemarnooo19:54
jamielennoxstevemar: that should be ok - do you know how?19:54
stevemarjamielennox, gyee http://paste.openstack.org/show/64356/19:54
jamielennoxgyee: cool, i addressed most of your comments and i'll put up one with some the small fixes later19:55
*** gokrokve_ has joined #openstack-dev19:55
stevemarjamielennox, i need to change auth and methods, which it looks like I can do19:55
gyeestevemar, jamielennox, awesome!19:55
*** ruhe- has joined #openstack-dev19:55
*** yeylon__ has joined #openstack-dev19:55
jamielennoxstevemar: yea that is all that a v3 plugin should need to do, add a new method identifier and the data for that method19:56
jamielennoxthe plugin should give you that19:56
*** jgrimm has quit IRC19:56
stevemarjamielennox, just make sure I have an easy entry point for testing :) i don't want to have to bang my head on a wall for that19:56
ayoungbknudson, dolphm do either of you know why we have this function, and if it is OK to Axe it? \https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/tests/test_auth_token_middleware.py#L169519:56
*** ruhe- has quit IRC19:56
ayounglooks like a vestige of old badness, and it is causing my test runs to fail when I run just a single package19:57
bknudsonayoung: it's required for testresources19:57
*** ianw has joined #openstack-dev19:57
*** ruhe has quit IRC19:57
ayoungbknudson, something is wrong then19:57
jamielennoxayoung: yep what bknudson said19:57
bknudsonayoung: yes, it shouldn't cause a single package test to fail...19:57
*** jprovazn is now known as jprovazn_afk19:57
jamielennoxand it measn that nose won't work19:57
bknudsonayoung: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/tests/client_fixtures.py#L4419:58
gyeejamielennox, I have to run, will review them later19:58
*** gyee has quit IRC19:58
*** gokrokve has quit IRC19:58
*** ruhe has joined #openstack-dev19:58
ayoungwhy do I get  this error then? http://fpaste.org/76250/48702139/19:59
*** wpward has joined #openstack-dev19:59
*** gokrokve_ has quit IRC19:59
*** gokrokve has joined #openstack-dev20:00
*** tanisdl has quit IRC20:00
*** ArxCruz has quit IRC20:00
*** gokrokve_ has joined #openstack-dev20:01
*** rfolco has quit IRC20:01
ayoungbknudson, ^^20:01
*** lbragstad has quit IRC20:01
wpward@armax, are you available to chat?  Wanted to discuss the MechanismDriverError fix I have out for review at https://review.openstack.org/#/c/69748/20:01
jamielennoxayoung: nose doesn't support the load_tests protocol20:01
ayoungah...20:01
jamielennoxayoung: try python -m testtools.run discover20:01
bknudsonayoung: how are you running it?20:01
jamielennoxor the test name instead of discvoer20:01
ayoungjamielennox, running from inside ecplise with/usr/bin/nose20:02
*** jistr has quit IRC20:02
jamielennoxayoung: hmm, can't help you with eclipse20:02
*** thedodd has quit IRC20:02
ayoungjamielennox, it is just a command line exec20:02
ayounghow would I run a specific test, then20:02
*** carl_baldwin has quit IRC20:03
ayoung python -m testtools.run  keystoneclient.tests.test_auth_token_middleware20:03
jamielennoxpython -m testtools.run keystoneclient.tests.test_auth_token_middleware.class_name.test_name20:03
armaxupward, wouldn't the review be a better place?20:03
armaxwpward20:03
*** henrynash has quit IRC20:03
ayoungjamielennox, how about all tests in a file?20:03
*** saju_m has quit IRC20:04
bknudson.tox/py27/bin/python -m testtools.run  keystoneclient.tests.test_auth_token_middleware -- Ran 164 tests in 2.171s20:04
wpwardPossibly, but given the short timeframe left of getting things into this release vs the alternative you proposed, I thought maybe here would be better.  But I can keep it in the review if you like.20:04
*** gokrokve has quit IRC20:04
*** carl_baldwin has joined #openstack-dev20:05
jamielennoxyep just drop test_name20:05
*** saju_m has joined #openstack-dev20:05
ayoungbknudson, heh, it ran so fast I thought it failed20:05
jamielennoxunfortunately it doesn't work if you drop file name as well, then you need to use discover20:05
ayoungthat is ok20:05
bknudsonayoung: would be nice if keystone tests ran so fast.20:06
*** henrynash has joined #openstack-dev20:06
dstanekayoung: i'm going to give that a try to see if it helps, but they are taking about 4 times as long on the same machine20:09
*** Oneiroi has quit IRC20:09
*** ijw has quit IRC20:09
*** ijw has joined #openstack-dev20:10
*** dperaza has joined #openstack-dev20:11
*** xga has joined #openstack-dev20:13
*** ijw has quit IRC20:14
tellesnobregavishy: hi, in devstack, where can i find the data that is used to create entries for keystone?20:14
*** jckasper has quit IRC20:14
*** jckasper has joined #openstack-dev20:15
*** jpomero has joined #openstack-dev20:16
vishytellesnobrega: https://github.com/openstack-dev/devstack/blob/master/files/keystone_data.sh20:16
*** gokrokve_ has quit IRC20:16
*** cadenzajon has quit IRC20:16
*** gokrokve has joined #openstack-dev20:16
*** cagrev has quit IRC20:16
tellesnobregavishy: thanks20:17
*** henrynash has quit IRC20:17
*** Oneiroi has joined #openstack-dev20:17
*** cadenzajon has joined #openstack-dev20:17
*** moted has quit IRC20:18
*** xga has quit IRC20:18
*** mdomsch has quit IRC20:19
*** jcoufal has quit IRC20:19
*** Alexei_987 has quit IRC20:20
*** spzala has joined #openstack-dev20:20
tellesnobregavishy: i've been there but didnt find what im looking for. I'm looking at creating tenants, but there i can only find the names, im looking for other information from the table, like domain_id and other stuff, since i added a new colunm and i need to put that data in20:20
*** jckasper_ has joined #openstack-dev20:20
*** gokrokve has quit IRC20:21
vishytellesnobrega: well it would have to be added to keystoneclient20:22
*** epim has quit IRC20:22
*** marcoemorais has quit IRC20:22
*** wpward has left #openstack-dev20:22
tellesnobregavishy: i see, thanks20:22
jamielennoxtellesnobrega: what exactly are you missing/trying to do/20:22
*** galstrom_zzz is now known as galstrom20:23
*** jckasper has quit IRC20:24
stevemartellesnobrega, i think you mean this stuff: https://github.com/openstack-dev/devstack/blob/master/lib/keystone#L26320:24
*** harlowja_away is now known as harlowja20:24
tellesnobregajamielennox: i added a new column to projects in keystone, and when im starting devstack i get an error because it is a fk and it breaks with the data that is passed, because there are n columns and n-1 values, so i need include the missing value20:25
*** jcoufal has joined #openstack-dev20:25
jamielennoxtellesnobrega: so i'm not sure that having that as a FK makes sense for that reason20:26
*** eglynn has joined #openstack-dev20:26
jamielennoxie as a required column20:26
*** denis_makogon_ has joined #openstack-dev20:26
jamielennoxis the column exposed from the REST API?20:26
tellesnobregastevemar: yes, i looked through it but i need to change the insertion20:26
tellesnobregajamielennox: i created a column called parent_project_id, it needs to reference a project_id and it can be null20:27
*** dvarga is now known as dvarga|away20:27
*** dvarga|away is now known as dvarga20:27
jamielennoxall of the managers in keystoneclient should support arbitrary kwargs such that if you need to add extra information to a POST call or something you can just specify it as kwargs and it will be sent through20:27
jamielennoxtellesnobrega: so putting a default NULL on the SQL table should fix that20:28
jamielennox(you need to default to the current behaviour)20:28
jamielennoxtellesnobrega: or somewhere in the project or tenant creating code in keystone pass through a None value for parent_project_id - but it doesn't sound like a client problem20:29
tellesnobregajamielennox: i see. i'll take a look into taht20:29
tellesnobregajamielennox: thansk20:29
tellesnobregathanks20:29
jamielennoxtellesnobrega: no problem, just remember that everything you add has to be additional. You can't add new required parameters to the API because it won't be backwards compatible20:30
tellesnobregajamielennox: i added as nullable=true, i think the default value is wrong20:31
*** cagrev has joined #openstack-dev20:31
*** jcoufal has quit IRC20:31
*** lbragstad has joined #openstack-dev20:31
*** marcoemorais has joined #openstack-dev20:31
*** aveiga has quit IRC20:32
*** sushils has joined #openstack-dev20:32
jamielennoxtellesnobrega: nullable=True means that the value can be NULL it doesn't say anything about the default value20:32
*** wendar has joined #openstack-dev20:32
*** saju_m has quit IRC20:32
jamielennoxtellesnobrega: you will need to set default=None as well (i think the arg is called default)20:32
tellesnobregajamielennox: i know, just found it now. :D thanks again20:33
jamielennoxtellesnobrega: np20:33
*** chris_johnson is now known as wchrisj|away20:33
*** zzelle has joined #openstack-dev20:33
tellesnobregai will give a go again and see if it fixed20:33
*** belmoreira has quit IRC20:33
*** ramishra has joined #openstack-dev20:34
*** rodrigods has joined #openstack-dev20:34
*** rodrigods has joined #openstack-dev20:34
*** sarob has joined #openstack-dev20:35
*** rodrigods has quit IRC20:35
morganfainbergbknudson, i'm slowly working on getting tests happier!!!20:36
*** wchrisj|away is now known as chris_johnson20:36
morganfainbergbknudson, but it's slow20:36
bknudsonmorganfainberg: it's going to be a long slog.20:37
morganfainbergbknudson, i know :(20:37
bknudsonand more tests are going to get added while you're trying to fix it.20:37
morganfainbergbknudson, yeah i know20:37
morganfainbergbknudson, it makes it hard20:37
morganfainbergbknudson, but we can only do so much20:38
*** henrynash has joined #openstack-dev20:38
morganfainbergbknudson, i mean... the alternative is to make a massive patch bomb to fix it all at once.20:38
morganfainbergbknudson, and i don't like it, but we could try and do that instead :P20:38
*** sushils has quit IRC20:38
*** eglynn has quit IRC20:38
*** moted has joined #openstack-dev20:39
*** ramishra has quit IRC20:39
bknudsonmorganfainberg: that would never fly20:39
morganfainbergbknudson, i know20:39
morganfainbergbknudson, it's why i didn't even try20:39
bknudsonmorganfainberg: you saw that your change to oslo-incubator fixture is merged ... and I posted a sync20:39
morganfainbergbknudson, yeah, i tried a full oslo sync patchset... no unit test errors20:40
*** RajeshMohan has quit IRC20:40
jamielennoxdtroyer: ping20:40
*** sarob has quit IRC20:40
bknudsonmorganfainberg: I saw that ... will have to look at it.20:40
morganfainbergbknudson, i'll +2 yours in either case (just saw it last night)20:40
morganfainbergbknudson, just was on no battery so couldn't review ;)20:41
*** RajeshMohan has joined #openstack-dev20:41
bknudsonmorganfainberg: no problem... I'm not sure if it's best to keep syncing each module or do the whole thing20:41
bknudsonif you were able to do the sync without any failures maybe it's best to just sync it20:41
morganfainbergbknudson, if we can sync the whole thing, i'd rather do that20:41
morganfainbergbknudson, yeah https://review.openstack.org/#/c/72266/20:42
morganfainbergbknudson, it .. all seems to work20:42
morganfainbergbknudson, i'd advocate a complete sync unless there are incompatible changes somewhere... then we exclude that module and work on fixing/syncing separately20:42
bknudsonmorganfainberg: you'll have to go through all of these and update sample.conf with any changed/new config options.20:42
morganfainbergbknudson, oh gah. true20:43
*** pschaef has quit IRC20:43
morganfainbergbknudson, hehe, yeah we need to do what the other projects are doing... auto-gen the sample conf20:43
*** cnesa has joined #openstack-dev20:43
morganfainbergbknudson, or at least nova was doing that for a while20:43
*** kgriffs is now known as kgriffs_afk20:43
morganfainbergbknudson, leverage the help= arg in the options and make this less of a bear to deal with20:43
*** abhirc has joined #openstack-dev20:44
bknudsonmorganfainberg: lance looked into it for a little while but didn't get too far.20:44
morganfainbergbknudson, it shouldn't be too hard to do.  we can probably just snake some of the code used by the other project(s)20:44
morganfainbergbknudson, we need to provide help text etc if we want the documentation we have, but otherwise, i think it shouldn't be too big a deal to do20:45
bknudsonmorganfainberg: seems like it, but lance ran into a problem... maybe it was just the missing help=.20:45
*** morgabra has joined #openstack-dev20:45
morganfainbergbknudson, likely.20:45
*** stevemar has quit IRC20:45
*** denis_makogon_ is now known as denis_makogon20:45
*** erecio has joined #openstack-dev20:46
*** erecio has quit IRC20:46
morganfainbergbknudson, looks like no new options added in sqlalchemy there, (at least not seeing any) i'm looking through each file now20:46
morganfainbergbknudson, maybe some of the options were already sync'd20:46
morganfainbergand sample not updated?20:46
bknudsonmorganfainberg: https://review.openstack.org/#/c/71311/20:47
*** DinaBelova is now known as DinaBelova_20:47
bknudsonmorganfainberg: the help text was corrected.20:47
morganfainbergah i see20:47
morganfainbergthat explains it20:47
bknudsonthis is why we need the auto-gen.20:47
morganfainbergbknudson, ++20:47
morganfainberglet me see how hard it'll be to implement autogen20:48
morganfainbergmight be trivial20:48
*** epim has joined #openstack-dev20:48
*** abhirc has quit IRC20:49
*** abhirc has joined #openstack-dev20:50
tellesnobregajamielennox: it worked, thanks :)20:53
jamielennoxtellesnobrega: no worries20:54
*** jprovazn_afk has quit IRC20:55
*** byeager has quit IRC20:55
*** galstrom is now known as galstrom_zzz20:56
*** stevemar has joined #openstack-dev20:56
*** drewlander has quit IRC20:57
*** jsavak has joined #openstack-dev20:57
*** henrynash has quit IRC20:58
*** amcrn has quit IRC21:00
*** raildo has quit IRC21:00
*** joesavak has quit IRC21:00
*** joesavak has joined #openstack-dev21:00
*** godara has quit IRC21:01
*** amcrn has joined #openstack-dev21:01
*** jdob_ has joined #openstack-dev21:01
*** marcoemorais has quit IRC21:02
*** marcoemorais has joined #openstack-dev21:02
*** marcoemorais has quit IRC21:02
*** marcoemorais has joined #openstack-dev21:03
*** jsavak has quit IRC21:03
ayoungdstanek, any luck?21:04
*** e0ne has quit IRC21:07
*** byeager has joined #openstack-dev21:09
*** galstrom_zzz is now known as galstrom21:09
*** sarob has joined #openstack-dev21:10
*** carl_baldwin has quit IRC21:10
morganfainbergbknudson, i have an almost working auto-gen21:10
morganfainbergbknudson, just need a lot of help text21:10
morganfainbergbknudson, i'll post a review up w/ it so we can work on that21:11
morganfainbergbknudson, should be quiick/easy and make these oslo syncs etc much much better21:11
*** tdruiva has quit IRC21:11
bknudsonmorganfainberg: it would be great if we could make oslo-incubator test new changes against keystone so we don't get out of date again.21:12
morganfainbergbknudson, i'll need to create an entry point we can load up though since we do config options a bit "odd" compared to other projects21:12
bknudsontest changes in their check/gate and then propose the change to keystone.21:12
*** dvarga has quit IRC21:12
*** sgrasley has joined #openstack-dev21:12
morganfainbergbknudson, will have something post meeting (doing cross project atm)21:13
morganfainbergbknudson, also.. https://review.openstack.org/#/c/71683/ please review so we can merge today if possible :)21:13
morganfainbergbknudson, want to get the havana version into enxt stable21:13
morganfainbergayoung, stevemar, dstanek, ^ on the review21:14
*** jdob_ has quit IRC21:15
*** jgrimm has joined #openstack-dev21:15
ayoungmorganfainberg, how does that work21:16
morganfainbergayoung, need to merge that to master before proposal for stable/havana goes through21:16
*** kgriffs_afk is now known as kgriffs21:16
ayoungmorganfainberg, how does it work21:17
morganfainbergayoung, the code?21:17
ayoungmorganfainberg, yes21:17
ayoungmy head is in CMS land21:17
morganfainbergayoung, i'll explain after this meeding, stay in CMS land21:17
ayoungdeal21:17
*** tdruiva has joined #openstack-dev21:17
*** mlegault__ has quit IRC21:17
morganfainbergcan chase down stevemar, dstanek, and jamielennox if needed too :)_21:17
jamielennoxhmm21:18
*** carl_baldwin has joined #openstack-dev21:18
dstanekmorganfainberg: i'll take a look again21:18
stevemarmorganfainberg, who what? i know nothing.21:18
morganfainbergstevemar, phsaw, stop fibbing :P21:19
morganfainbergbknudson, ok, so the only issue i see atm is that we have the odd config registration method21:20
*** baoli has joined #openstack-dev21:20
*** baoli has quit IRC21:20
bknudsonmorganfainberg: what's odd about it? it seems to work.21:21
morganfainbergbknudson, i think i need to create some kind of entrypoint that does .configure() and then does the generator21:21
morganfainbergbknudson, we don't register the options, so the auto-gen doesn't see them21:21
morganfainbergbknudson, so i just need to wrap the config generator to call our .configure() thing21:21
bknudsonmorganfainberg: We used to register the options at import time.21:21
*** baoli has joined #openstack-dev21:21
morganfainbergbknudson, right and i don't want to go back to that21:21
morganfainbergbknudson, but that is the assumption the auto-gen code uses21:21
bknudsonmorganfainberg: please don't!21:21
bknudsonmorganfainberg: bad assumption. Fix the tool21:22
*** sarob_ has joined #openstack-dev21:22
morganfainbergbknudson, well.. not so simple21:22
bknudsonmorganfainberg: right... how would it find the options?21:22
morganfainbergbknudson, easier solution, make a wrapper for the generator that issues our .configure()21:22
morganfainbergbknudson, i uses the CONF object iot looks like21:22
*** erkules_ is now known as erkules21:22
morganfainberglooking into what nova does, make sure i'm doing it "right"21:23
bknudsonmorganfainberg: we do some other weird things, too... like set the sql defaults and logging defaults.21:23
morganfainbergbknudson, yesh21:23
bknudsonmaybe that could be put into a function21:23
morganfainbergbknudson, i think i can capture it all21:23
morganfainbergbknudson, that was my thought21:23
morganfainbergbknudson, this autogen will not capture the magic-automatic options for auth-plugins21:23
bknudsonI had started looking at that but then gave up.21:24
morganfainbergbknudson, but it should catch my new options i created21:24
morganfainbergbknudson, which, is a bit cleaner imo (as the sample)21:24
bknudsonmorganfainberg: do the oslo-incubator parts auto-register their options?21:24
morganfainbergbknudson, yes21:24
bknudsonboo21:24
*** sarob has quit IRC21:24
*** markmc has quit IRC21:24
morganfainbergbknudson, like i said, i can do this with a small wrapper for the generator code21:25
*** irenab has quit IRC21:25
morganfainbergbknudson, import and at import time do our .configure()21:25
morganfainbergbknudson, it'll live in keystone.common.config_generator or something21:25
morganfainbergbknudson, let me see if i can make this work21:25
dstanekmorganfainberg: i already had it open in a tab so i just went over it again and gave it a +221:25
morganfainbergdstanek, cool21:26
morganfainbergdstanek, much appreciated21:26
*** gyee has joined #openstack-dev21:26
*** jamielennox is now known as jamielennox|away21:26
*** ekhugen has joined #openstack-dev21:28
*** xmltok has joined #openstack-dev21:28
*** jamielennox|away is now known as jamielennox21:29
dstanekayoung: running the test now with a tmpfs mount21:29
*** thedodd has joined #openstack-dev21:30
*** yolanda has quit IRC21:30
*** huats__ is now known as huats21:30
*** ytwu has joined #openstack-dev21:30
dstanekayoung: i thought that sqlite had a way to be all in memory already21:30
ayoungdstanek, not that we can use21:30
ayoungdstanek, migrations kill the database afterwards21:30
*** ijw has joined #openstack-dev21:31
ayoungwith in memory sqlite, that erases everything21:31
ayoungso no way to run the migrations21:31
dstanekayoung: ah21:31
ayoungbut we shoulld not need migrations, cuzx we do the model based approach21:31
ayoungand I never quite closed the loop on that21:31
*** ytwu1 has quit IRC21:31
ayoungcuz running in ramdisk was fast enough21:31
dstanekayoung: also the path to keystone's tmp dir is incorrect (missing a keystone/ in there)21:31
*** kgriffs is now known as kgriffs_afk21:31
ayoungdstanek, on my blog?21:32
ayoungdstanek, its morphed over time, I might have typod it.  We used to put it in /tmp21:33
*** marcoemorais has quit IRC21:33
dstanekayoung: i didn't realize that it was posted almost 2 years ago21:33
ayoungdstanek, I've been doing this a long time21:33
*** henrynash has joined #openstack-dev21:34
*** amcrn has quit IRC21:34
*** ramishra has joined #openstack-dev21:34
*** joadavis has joined #openstack-dev21:35
*** gokrokve has joined #openstack-dev21:36
*** cnesa has quit IRC21:36
*** marekd is now known as marekd|away21:36
bknudsonshouldn't our test temp files go in /tmp?21:37
*** rtheis has quit IRC21:38
*** anniec has joined #openstack-dev21:39
*** ramishra has quit IRC21:39
*** sarob_ has quit IRC21:39
dstanekbknudson: as long as we name them with the pid i don't have a problem with that21:40
*** anniec has quit IRC21:40
bknudsondstanek: I might propose that change... some systems have /tmp on ramdisk already21:40
*** amcrn has joined #openstack-dev21:41
*** beagles has quit IRC21:42
*** jnoller_ has quit IRC21:42
dstanekayoung: it was a little faster, but not much; my disk is ssd so it's already pretty fast21:42
*** jhesketh_ has joined #openstack-dev21:43
*** markmcclain has quit IRC21:44
*** thomasem has quit IRC21:45
*** marcoemorais has joined #openstack-dev21:47
bknudsondstanek: writing to ssd can be slower than regular disk21:47
*** abhirc has quit IRC21:48
*** tanisdl has joined #openstack-dev21:49
morganfainbergdstanek, bknudson, any reason to not +A https://review.openstack.org/#/c/71683/ ? have plus 2 from both of you21:49
*** sushils has joined #openstack-dev21:49
bknudsonmorganfainberg: I can't think of a reason21:51
*** doug-fish has quit IRC21:52
morganfainbergbknudson, mind +A it ? i don't think i should +A my own patch ;)21:52
stevemarjaypipes, ping21:52
*** henrynash has quit IRC21:52
*** tmclaugh[work] has quit IRC21:52
bknudsonmorganfainberg: you can +A your own patch as long as it meets the criteria.21:53
morganfainbergbknudson, ok21:53
morganfainbergbknudson, i always hesistated to do so21:53
morganfainbergbknudson, will keep in mind21:53
*** henrynash has joined #openstack-dev21:53
jaypipesstevemar: pong (kinda here.... I'm deep in infra doo doo right now ;)21:53
*** kgriffs_afk is now known as kgriffs21:54
*** arunkant has quit IRC21:54
stevemarjaypipes, hmm okay ... answer if you can.. if i specify PUT region/regionId with a parent that doesn't exist, it should 404 right?21:54
stevemarjaypipes, currently that's not happening, which is why your tests are failing :(21:54
jaypipesstevemar: yes, that's correct. I will try and look into a fix later, but I think dolphm had fixed that in another patch somewhere :(21:55
stevemarjaypipes, i'll take a deeper look21:56
*** mohits has joined #openstack-dev21:56
jaypipesstevemar: cheers. sorry it's taken so long to fix that dang thing! :(21:56
stevemarjaypipes, np dude21:57
*** mikeoutland has quit IRC21:57
*** mikeoutland has joined #openstack-dev21:57
*** sarob has joined #openstack-dev21:59
stevemarjaypipes, hoping i fixed it for ya ... https://review.openstack.org/#/c/68981/522:00
*** sarob has quit IRC22:00
*** sarob has joined #openstack-dev22:01
*** ekhugen has quit IRC22:02
*** RajeshMohan has quit IRC22:02
*** prad has quit IRC22:02
*** ijw_ has joined #openstack-dev22:03
*** harlowja has quit IRC22:03
*** RajeshMohan has joined #openstack-dev22:03
*** peristeri has quit IRC22:03
*** doug-fish has joined #openstack-dev22:04
*** sarob has quit IRC22:06
*** dstanek has quit IRC22:06
*** ijw has quit IRC22:06
*** sweston has quit IRC22:06
*** prad has joined #openstack-dev22:07
*** carl_baldwin has quit IRC22:08
*** stevemar has quit IRC22:08
*** jobewan has quit IRC22:09
*** dstanek has joined #openstack-dev22:09
*** xarses has quit IRC22:10
dstanekmorganfainberg: i didn't see that it already had a +2 or I would have just went ahead with the +A22:10
morganfainbergbknudson, ok i found an issue.  we use a dict and the auto-gen thing is looking for lists22:10
morganfainbergbknudson, with minor restructuring i can fix this.22:10
*** vijendar has quit IRC22:11
morganfainbergbknudson, but a bunch of this logic is assuming options are configured on import22:11
morganfainberg*mutter*22:11
*** bswartz has quit IRC22:12
bknudsonmorganfainberg: it's very picky22:12
*** otherwiseguy has joined #openstack-dev22:12
morganfainbergbknudson, yeah22:12
*** jecarey has quit IRC22:12
*** boris-42_ has quit IRC22:13
*** anniec has joined #openstack-dev22:16
*** eglynn has joined #openstack-dev22:16
morganfainbergbknudson, the assumption is that you don't define your options in one location like we do, but in each file that needs it22:16
morganfainbergbknudson, i think that is what is tripping up the auto-gen tool22:16
morganfainbergbknudson, we wrapped extra logic around it all.22:16
bknudsonmorganfainberg: extra logic? to register a config option? seems like it should be pretty simple22:17
morganfainbergbknudson, we have .configure() and a dict that we run through22:17
bknudsonoh, except for the generated options.22:17
morganfainbergbknudson, and then add in the generated option(s)22:17
bknudsonmorganfainberg: it would be good to get all that into a function anyways... or are you saying you don't need one?22:18
*** NearlyFunctional has quit IRC22:18
morganfainbergbknudson, the idea is that (for example) identity would define it's options in the identity files like how openstack.common.db.session does it22:18
*** e0ne has joined #openstack-dev22:18
morganfainbergbknudson, the generated options will never show up in the auto-gen sample config the way it is written22:18
morganfainbergbknudson, it needs an actual config object that appears at import-time to put it in the sample conf afaict22:19
dstanekmorganfainberg, bknudson: is there an order to the sections in the sample keystone and paste config files?22:19
*** eglynn has quit IRC22:19
morganfainbergdstanek, [DEFAULT] at top22:19
morganfainbergbknudson, other than that, not really22:19
morganfainbergerm dstanek not bknudson22:19
bknudsondstanek: I think paste-config is at the bottom of the keystone sample config file22:20
morganfainbergbknudson, oh yeah22:20
bknudsonif we use the config file generator then it'll put them in some kind of order22:20
dstanekok, then i think i'm good; i just my extension stuff after the federation extension stuff22:20
*** abhirc has joined #openstack-dev22:21
*** e0ne has quit IRC22:22
bknudsondstanek: quit trying to delete our .gitkeep! D keystone/tests/tmp/.gitkeep22:22
bknudsonit's like you mounted a tmpfs over it or something22:22
*** crank has quit IRC22:22
morganfainbergbknudson, i mean, i could make changes to the generator code i guess. but we're breaking with the general OS convention which is why it isn't as happy.22:23
*** sgordon has quit IRC22:23
*** abhirc has quit IRC22:23
*** abhirc has joined #openstack-dev22:24
bknudsonmorganfainberg: we could change keystone to match the general convenction22:24
*** noslzzp has quit IRC22:24
morganfainbergbknudson, i could make keystone.common.config register things on import again22:25
*** jecarey has joined #openstack-dev22:25
bknudsonmorganfainberg: that's too dangerous22:25
dstanekbknudson: did i delete it?22:25
dstanekbknudson: hmmm...so i did; i'll fix22:25
*** xarses has joined #openstack-dev22:25
*** jtomasek has quit IRC22:26
morganfainbergbknudson, the typical convention would be, for example token options the manager needs would be registered by the .core file (on import)22:26
morganfainbergbknudson, options get scattered around the code base, and registered (effectively) on-demand22:26
morganfainbergbknudson, i don't like that22:26
morganfainbergbknudson, i like what we have.22:26
*** jrist has joined #openstack-dev22:26
*** galstrom is now known as galstrom_zzz22:27
morganfainbergbknudson, i can try and make the generator smarter, but i think we might be far enough astride from the typical use, it wont be accepted22:27
morganfainbergdhellmann, ping22:27
dhellmannmorganfainberg: pong22:27
* morganfainberg summons dhellmann and his awesome oslo.config etc knowledge to the rescue22:28
*** pcm_ has quit IRC22:28
* dhellmann disavows any such knowledge22:28
*** romcheg1 has quit IRC22:28
*** cdub has quit IRC22:28
morganfainbergdhellmann, so, trying to get sample config auto generation for keystone...because manually maintaining it sucks22:28
dhellmannok22:28
*** mfer has quit IRC22:28
morganfainbergdhellmann, the issue is.. we don't do configs really the same way as the rest of OS22:28
*** romcheg1 has joined #openstack-dev22:28
morganfainbergwe don't register opts on import22:28
*** dprince has quit IRC22:28
*** abhirc has quit IRC22:28
bknudsonbecause it's dangerous22:28
morganfainberg^22:29
dhellmannyay!22:29
dhellmanna couple of options22:29
morganfainbergdhellmann, so.. the config generator makes some broad assumptions22:29
dhellmann1. put the option definitions at module level, and register them at runtime22:29
morganfainbergdhellmann, and wanted your input!22:29
dhellmann2. register one or more entry points that return the option definitions for the config generator22:29
*** cagrev has quit IRC22:30
*** cdub has joined #openstack-dev22:30
morganfainbergdhellmann, so, something like stub_that_makes_opts_available_for_generator.py?22:30
dhellmannthat's the approach we're using in the oslo libraries, since we're providing options to apps that don't necessarily want to scan our source22:30
*** vladikr has quit IRC22:30
* dhellmann looks for example in oslo.messaging22:30
morganfainbergbknudson, see this is why dhellmann is awesome22:30
dhellmannhttp://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo/messaging/opts.py22:30
*** noslzzp has joined #openstack-dev22:31
morganfainbergdhellmann, oh the options don't need to be registered?22:31
dhellmannnope22:31
morganfainbergwith the CONF object?22:31
morganfainbergdhellmann, i totally mis-read that22:31
dhellmannthe config generator registers them with its copy I think22:31
morganfainbergdhellmann, ok i can make this work then.22:31
*** dims has quit IRC22:31
morganfainbergdhellmann, hm. let me try and figure out how it determines groups.22:31
*** sweston has joined #openstack-dev22:32
dhellmannthe entry point returns a list of (group, [options]) pairs22:32
morganfainbergoh22:32
morganfainbergohhh22:32
morganfainbergok i think i see22:32
dhellmanncan you point me to an example of how you're registering options now?22:32
*** jobewan has joined #openstack-dev22:32
morganfainbergdhellmann, https://github.com/openstack/keystone/blob/master/keystone/common/config.py#L23 which is all registered at https://github.com/openstack/keystone/blob/master/keystone/common/config.py#L30222:33
dhellmannand the config generator isn't finding those?22:33
morganfainbergwe also have some magic opts that are created at runtime, but i can work around that.22:33
morganfainbergdhellmann, not at all22:33
morganfainbergi think it's the dict -> list22:33
dhellmannoooh, yeah, that's it22:34
dhellmannit wants one list22:34
morganfainbergdhellmann, https://github.com/openstack/oslo-incubator/blob/master/openstack/common/config/generator.py#L17222:34
*** Gordonz_ has joined #openstack-dev22:34
morganfainbergyeah22:34
*** jasdeepH has quit IRC22:34
*** relaxdiego has quit IRC22:34
dhellmannyou're all set to have the return value for that entry point22:34
dhellmannreturn FILE_OPTIONS.items()22:34
morganfainbergah, yeah that is what i think i needed22:35
*** xarses has quit IRC22:35
*** relaxdiego has joined #openstack-dev22:35
morganfainbergdhellmann, and that should make everything discoverable and happy (besides the massive lack of help= kwargs on our options)22:35
*** NearlyFunctional has joined #openstack-dev22:35
*** ayoung has quit IRC22:35
*** ramishra has joined #openstack-dev22:35
morganfainbergknowing how it determines the groups was the part my brain wasn't connnecting22:35
*** ctlaugh_ is now known as zz_ctlaugh22:35
dhellmannyep22:35
dhellmannhttp://git.openstack.org/cgit/openstack/oslo.messaging/tree/setup.cfg#n5322:35
morganfainbergdhellmann, thanks dude, you saved me a headache... my brain hurts today already22:36
dhellmannglad to be able to help!22:36
*** mohits_ has joined #openstack-dev22:36
*** READ10 has quit IRC22:36
*** Gordonz has quit IRC22:36
*** bswartz has joined #openstack-dev22:38
*** joesavak has quit IRC22:38
*** achampion has quit IRC22:38
*** apevec has joined #openstack-dev22:39
apevecmorganfainberg, I see master is approved ! https://review.openstack.org/#/q/Ida39b4699ed6c568609a5121573fc3be5c4ab2f4,n,z22:39
bknudsondhellmann: https://review.openstack.org/#/c/67664/ could use a review too -- you approved the dependent change.22:39
morganfainbergapevec, i am in process of syncing the differences to havana22:39
morganfainbergapevec, just running unit tests before posting :)22:40
*** mohits has quit IRC22:40
dhellmannbknudson: looking22:40
apeveccool, that was my next question :)22:40
*** relaxdiego has quit IRC22:40
*** ramishra has quit IRC22:40
*** jpomero has quit IRC22:40
apevecmorganfainberg, I'll be signing off but you should have few stable-maint around: dolphm, vishy22:40
apevecfull list here https://review.openstack.org/#/admin/groups/120,members22:41
morganfainbergapevec, cool.22:41
morganfainbergapevec, dhellmann also has interest in this, can have him jump on it22:41
morganfainbergapevec, :)22:41
apevecyep, he can +2 stable too22:41
*** marcoemorais has quit IRC22:41
*** marcoemorais has joined #openstack-dev22:42
*** noslzzp has quit IRC22:42
dhellmannmorganfainberg, apevec : is that for https://review.openstack.org/#/c/66149/ ?22:43
*** Gordonz_ has quit IRC22:43
*** jamieh has quit IRC22:43
morganfainbergdhellmann, yes22:43
*** dkranz has quit IRC22:43
apevecdhellmann, yes, new patchset is coming22:43
morganfainbergdhellmann, master verison is approved. working on tests / sync for stable now to match22:43
morganfainbergdhellmann, will be posted soon22:43
dhellmannmorganfainberg: ack, ping me when you're ready for a review22:43
*** topol has quit IRC22:44
lbragstaddolphm: think we would be able to leverage the test_notifier similar to the way nova tests their notifications? https://review.openstack.org/#/c/68548/16/keystone/tests/test_notifications.py22:45
*** noslzzp has joined #openstack-dev22:47
dolphmlbragstad: i haven't seen nova's approach.. looking22:47
*** sn6i23a has joined #openstack-dev22:47
lbragstaddolphm: linked in the comment22:47
*** dims has joined #openstack-dev22:47
*** xarses has joined #openstack-dev22:48
dolphmlbragstad: hmm... i was referring to the entire method22:48
*** Chaser has quit IRC22:48
*** sandywalsh has quit IRC22:48
*** jhesketh__ has joined #openstack-dev22:48
lbragstadwell I mean, isn't _assertNotifySent just checking something is sent on the queue?22:49
lbragstad'queue'22:49
lbragstadand the notification is stored in the NOTIFICATIONS global in the test_notifier, so we could always read it back and verify the values22:49
*** Chaser has joined #openstack-dev22:49
*** jckasper_ has quit IRC22:50
morganfainbergdhellmann, dolphm, updated patchset posted for https://review.openstack.org/#/c/66149/22:50
*** ayoung has joined #openstack-dev22:50
dolphmlbragstad: that's sort of what we're doing, but wouldn't eliminate the complexity of the verification method22:50
*** jmckind has quit IRC22:51
*** sweston has quit IRC22:51
*** ramishra has joined #openstack-dev22:51
dhellmannmorganfainberg: I think sdague would want that log message to not be an exception, but maybe an info or even debug22:52
*** mwagner_lap has quit IRC22:52
dhellmannesp. because "there is nothing the admin or operator needs to do in this case"22:52
morganfainbergdhellmann, hm. i can reduce it to warning.22:52
morganfainbergdhellmann, i was hoping to show what the exception that was raised when trying to convert22:53
*** ramishra has quit IRC22:53
dhellmannwill the operator care about that?22:53
*** ramishra has joined #openstack-dev22:53
*** CaptTofu has quit IRC22:53
morganfainbergdhellmann, not sure.  but the operator should care it happens, it means some tokens can't be revoked on password change/user-disable/etc22:53
*** jmontemayor has quit IRC22:53
sdaguemorganfainberg: right, think about INFO and up log levels are for the operator22:54
dhellmannok, that's not clear from the message being loged22:54
morganfainbergdhellmann, basically, it means something went and side-band changed the underlying data22:54
dhellmann*logged22:54
sdaguemorganfainberg: then make an operator friendly message that says that22:54
morganfainbergsdague, sure.22:54
sdaguea stack trace should never be in a non DEBUG level22:54
*** noslzzp has quit IRC22:54
*** jgrimm has quit IRC22:54
sdaguebecause it's not meaningful to the audience reading it22:54
morganfainbergsdague, dhellmann, add something like "any active tokens for <user> are no longer managed by keystone and will be valid until expiration"22:55
morganfainberg?22:55
morganfainbergit _shouldn't_ happen22:55
morganfainbergbut this is just to make sure keystone doesn't lock out that user because something mucked with memcache outside of it's control22:55
lbragstaddolphm: ah yeah22:55
morganfainbergit's=keystone's22:55
dhellmannmorganfainberg: how about "Unable to convert user-token index to new format, clearing existing index record: %s"22:55
morganfainbergdhellmann, so just drop the log exception and "error" word?22:56
dhellmannyeah22:56
morganfainbergdown to.. uhm.. warning?22:56
dhellmanninfo?22:56
*** READ10 has joined #openstack-dev22:56
dhellmannan operational warning still seems sorta high22:56
morganfainbergsure *shrug*22:56
morganfainbergnot picky here on that22:56
dhellmannbut sdague is the official decider on that22:56
sdagueman, I'm the decider now? :)22:57
sdagueI think the answer is, do you expect the operator to need to address the issue actively within a couple of days22:57
morganfainbergsdague, if you don't decide i'm going to make it register a new super log level and so something really wacky ;)22:57
sdagueif yes, warn22:57
sdagueif not, info22:58
morganfainbergsdague, no, but the operator should know it occured22:58
sdaguethen info22:58
morganfainbergsdague, ok22:58
*** ramishra has quit IRC22:58
*** gokrokve has quit IRC22:58
sdagueerror = page the operator in the middle of the night to fix, warn = operator action required this week, info for other things22:58
*** sweston has joined #openstack-dev22:58
*** dstanek has quit IRC22:58
morganfainbergin theory, it means something is messing with the authoritative token store outside of keystone22:58
morganfainbergwhich... is bad22:59
morganfainbergbut there really is nothing that keystone can do about it... nor the operator short of chasing that down22:59
sdaguedebug for detailed dumps, so that will only be seen if they ask for it (assuming they'll run at info level)22:59
morganfainbergin practice is is extremely unlikely to happen22:59
morganfainbergsdague, went w/ info here22:59
morganfainbergeverything else is the same, new patchset up22:59
sdaguewell, extremely unlikely, and they should hunt it down, would make it fine for warn22:59
morganfainbergdhellmann, ^22:59
sdaguebut your call, I could see either way23:00
morganfainbergsdague, eh, i don't think this is even that likely.23:00
*** neelashah has quit IRC23:00
bknudsonnot sure why you would start your server if you couldn't trust the data.23:00
morganfainbergsdague, i think they'll have other issues along the way23:00
dhellmannmorganfainberg: typo: "tp" -> "to"23:00
morganfainbergsdague this is just stupidly over defensive coding23:00
morganfainbergdhellmann, darn!23:00
morganfainberg:P23:00
morganfainberg;)23:00
*** gokrokve has joined #openstack-dev23:00
morganfainbergtypos!23:00
morganfainbergi swear i type for a living ... or something23:01
morganfainbergbknudson, and that is why memcache is a bad place to store tokens :P23:01
*** ykhodork has joined #openstack-dev23:01
bknudsonmorganfainberg: there must be a way to set up memcache so you can trust it?23:01
*** sarob has joined #openstack-dev23:02
morganfainbergbknudson, bmemcache + signing/encrypt23:02
*** marcoemorais has quit IRC23:02
bknudsonmorganfainberg: at least trust it as well as a DB23:02
morganfainbergbknudson, and even then... anyone who can auth to it can change any key23:02
dhellmannmorganfainberg: I always tell people I give directions for a living, so they shouldn't be surprised at the detailed instructions to my house23:02
*** gokrokve has quit IRC23:02
*** marcoemorais has joined #openstack-dev23:02
*** gokrokve has joined #openstack-dev23:02
*** marcoemorais has quit IRC23:02
morganfainbergbknudson, but basic python memcache client doesn't really do all of that23:03
*** marcoemorais has joined #openstack-dev23:03
*** marcoemorais has quit IRC23:03
*** gokrokve has quit IRC23:03
morganfainbergbknudson, also a store that loses all data when you restart it... or that could choose to evict a page even if it isn't expired due to LRU needs means it's bad for tokens.23:03
morganfainbergbut people use memcache anyway.23:03
*** marcoemorais has joined #openstack-dev23:03
morganfainbergi am hoping i can move people away from that to redis..or some other Key value store as the "Recommended" backend for the dogpile kvs store when used for tokens23:04
bknudsonmorganfainberg: is it supposed to be backed up by db or something?23:04
*** zzelle has quit IRC23:04
morganfainbergbknudson, it's meant to be used as a place to store data for faster access than a db, or file, or similar23:05
morganfainbergbknudson, it's not really meant to be a "stable" storage for permanent or even semi-permanent data (tokens are the latter category until revocation events)23:05
*** dbalog has left #openstack-dev23:07
*** vartom1111111111 has joined #openstack-dev23:07
*** sarob has quit IRC23:07
*** apevec has quit IRC23:07
*** mohits_ has quit IRC23:08
*** dstanek has joined #openstack-dev23:09
*** noslzzp has joined #openstack-dev23:09
*** dstanek has quit IRC23:09
*** harlowja has joined #openstack-dev23:09
*** carl_baldwin has joined #openstack-dev23:09
*** buzztrol_ has quit IRC23:10
*** kevinconway_ has joined #openstack-dev23:11
*** carl_baldwin has quit IRC23:11
*** sarob has joined #openstack-dev23:12
*** kevinconway has quit IRC23:14
*** kevinconway_ is now known as kevinconway23:14
*** ramishra has joined #openstack-dev23:15
*** xarg has quit IRC23:16
*** xarg_ is now known as xarg23:16
*** noslzzp has quit IRC23:16
*** sarob has quit IRC23:16
*** xarg_ has joined #openstack-dev23:16
*** ytwu has quit IRC23:16
*** cadenzajon has quit IRC23:17
*** ytwu has joined #openstack-dev23:17
*** mlavalle has quit IRC23:19
*** galstrom_zzz is now known as galstrom23:20
*** armax has left #openstack-dev23:20
*** buzztroll has joined #openstack-dev23:21
*** sweston has quit IRC23:21
*** carl_baldwin has joined #openstack-dev23:21
*** ssurana has quit IRC23:21
*** yjiang51 has quit IRC23:22
*** krtaylor has quit IRC23:22
*** arosen has quit IRC23:23
*** tjones has quit IRC23:24
*** noslzzp has joined #openstack-dev23:25
*** carl_baldwin has quit IRC23:26
*** zul has quit IRC23:26
*** carl_baldwin has joined #openstack-dev23:27
morganfainbergdhellmann, based on the thread on the ML, the generator is going to be unhappy because the options aren't on the CONF object?23:29
*** baoli has quit IRC23:29
morganfainbergdhellmann, back to my previous convo w/ you23:29
*** anniec has quit IRC23:29
*** abhirc has joined #openstack-dev23:29
dhellmannmorganfainberg: that hasn't been a problem for the oslo.messaging options, afaik23:30
dhellmannI thought that had something to do with the way the logic for guessing groups worked, but the entry point specifies the group so no guessing23:30
morganfainbergdhellmann, well it also looks like i can't use the generator with the entry point elegantly from within keystone to get keystone opts23:30
*** baoli has joined #openstack-dev23:30
dhellmannoh?23:30
morganfainbergdhellmann, yeah, i need to specify keystone as a library for stevedore to load it23:31
*** lbragstad has quit IRC23:31
dhellmannyes23:31
*** baoli has quit IRC23:31
morganfainbergdhellmann, and it seems like it's not... loading it cleanly since it doesn't get found23:31
*** mfer has joined #openstack-dev23:31
dhellmannoh23:31
morganfainbergdhellmann, it's a chicken-egg issue23:31
*** sushils has quit IRC23:31
morganfainbergif something not-keystone was looking for keystone's opts, it would be easier23:31
dhellmanndo you want to email me details -- I hate to duck out, but it's late here and winter is coming23:31
morganfainbergdhellmann, i'm 2x checking.23:32
morganfainbergdhellmann, i'll email details/hit you up tomorrow23:32
dhellmannI need to go batten hatches or whatever one does in bad weather23:32
dhellmannk23:32
*** dhellmann is now known as dhellmann_23:32
*** anniec has joined #openstack-dev23:32
*** achampion has joined #openstack-dev23:33
*** vartom1111111111 has quit IRC23:35
*** FunnyLookinHat has quit IRC23:36
*** mfer has quit IRC23:36
*** galstrom is now known as galstrom_zzz23:36
*** markwash has quit IRC23:36
*** alop_ has joined #openstack-dev23:36
*** alop has quit IRC23:36
*** alop_ is now known as alop23:36
*** thuc has quit IRC23:37
*** mrda is now known as mrda_away23:37
*** byeager has quit IRC23:37
*** thedodd has quit IRC23:37
*** thuc has joined #openstack-dev23:37
*** otherwiseguy has quit IRC23:39
*** jdob has quit IRC23:40
*** gnorth has quit IRC23:40
*** denis_makogon has quit IRC23:41
*** thuc has quit IRC23:42
*** tdruiva has quit IRC23:42
*** pablosan has quit IRC23:42
*** prad has quit IRC23:43
*** ctracey is now known as ctracey|away23:47
*** romcheg1 has quit IRC23:47
*** noslzzp has quit IRC23:47
*** vkmc has quit IRC23:47
*** bauzas has quit IRC23:47
*** ayoung has quit IRC23:49
*** thomasem has joined #openstack-dev23:50
*** noslzzp has joined #openstack-dev23:51
*** henrynash has quit IRC23:51
*** pmathews has quit IRC23:52
*** marcoemorais has quit IRC23:52
*** MaxV has quit IRC23:52
*** marcoemorais has joined #openstack-dev23:53
*** tanisdl has quit IRC23:53
*** Tross has quit IRC23:54
*** mriedem has quit IRC23:55
*** tanisdl has joined #openstack-dev23:57
*** ndipanov has quit IRC23:57
*** noslzzp has quit IRC23:57
*** chris_johnson is now known as wchrisj|away23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!