| harlowja | kashyap czuul is nice to, especially to pick specific projects/groups of projects | 00:01 |
|---|---|---|
| harlowja | like i use it to do 'czuul --project "stackforge/*"' | 00:01 |
| *** lbragstad has quit IRC | 00:01 | |
| harlowja | to watch progress on stackforge projects | 00:01 |
| *** oanufriev has quit IRC | 00:02 | |
| stevemar | morganfainberg, replied back to one of your questions | 00:02 |
| morganfainberg | stevemar, which one? :P | 00:02 |
| stevemar | https://review.openstack.org/#/c/67645/ | 00:02 |
| *** pcm_ has quit IRC | 00:02 | |
| morganfainberg | stevemar, i've been trying to get back into the code review mind-set yanno how it goes sometimes. | 00:02 |
| stevemar | morganfainberg, also, i like your question/comment to topol | 00:02 |
| stevemar | morganfainberg, i hear ya | 00:02 |
| *** sarob has quit IRC | 00:03 | |
| stevemar | morganfainberg, i find it hard to focus on more than 2-3 big BP related ones, especially when i'm already working on stuff myself | 00:03 |
| *** sarob has joined #openstack-dev | 00:03 | |
| stevemar | morganfainberg, not sure how others do it :\ | 00:03 |
| morganfainberg | stevemar, i've been very focused on writing code and keeping track of all those changes (I think I have 4 BPs for I-3) | 00:04 |
| morganfainberg | stevemar, so reviews have been hard (esp. w/ being way out of it last week) | 00:04 |
| *** f13o has quit IRC | 00:04 | |
| *** cnesa2 has quit IRC | 00:04 | |
| *** akrivoka has quit IRC | 00:04 | |
| *** lbragstad has joined #openstack-dev | 00:05 | |
| *** armax has joined #openstack-dev | 00:05 | |
| *** mrodden has joined #openstack-dev | 00:05 | |
| morganfainberg | stevemar, i figure it'll click again and reviews will be less arduous in the near future | 00:06 |
| *** devoid has quit IRC | 00:07 | |
| *** mestery has joined #openstack-dev | 00:07 | |
| *** zzelle has quit IRC | 00:07 | |
| *** sarob has quit IRC | 00:07 | |
| *** SumitNaiksatam has joined #openstack-dev | 00:08 | |
| *** mestery has quit IRC | 00:08 | |
| *** kgriffs is now known as kgriffs_afk | 00:10 | |
| *** wchrisj__ has quit IRC | 00:11 | |
| *** krotscheck has joined #openstack-dev | 00:11 | |
| *** Steap has quit IRC | 00:11 | |
| *** wchrisj_ has joined #openstack-dev | 00:11 | |
| *** otherwiseguy has quit IRC | 00:11 | |
| *** gimps has joined #openstack-dev | 00:11 | |
| *** Steap_ has joined #openstack-dev | 00:12 | |
| *** dperaza has quit IRC | 00:12 | |
| *** ewindisch has joined #openstack-dev | 00:13 | |
| *** ruhe has joined #openstack-dev | 00:13 | |
| *** sarob has joined #openstack-dev | 00:15 | |
| *** RajeshMohan has quit IRC | 00:15 | |
| *** __nikhil__ has joined #openstack-dev | 00:16 | |
| *** wchrisj_ has quit IRC | 00:16 | |
| *** radsy has quit IRC | 00:16 | |
| *** __nikhil__ has quit IRC | 00:16 | |
| *** chris_johnson has joined #openstack-dev | 00:17 | |
| *** cnesa has joined #openstack-dev | 00:17 | |
| *** ewindisch has quit IRC | 00:19 | |
| *** kolesovdv has quit IRC | 00:20 | |
| *** mgagne has joined #openstack-dev | 00:20 | |
| *** matsuhashi has joined #openstack-dev | 00:20 | |
| *** __nikhil__ has joined #openstack-dev | 00:21 | |
| *** __nikhil__ has quit IRC | 00:21 | |
| *** jergerber has quit IRC | 00:22 | |
| *** jmontemayor has quit IRC | 00:22 | |
| *** __nikhil__ has joined #openstack-dev | 00:23 | |
| *** mgagne1 has joined #openstack-dev | 00:23 | |
| *** __nikhil__ has quit IRC | 00:23 | |
| *** david-lyle has quit IRC | 00:24 | |
| *** cnesa has quit IRC | 00:24 | |
| *** mgagne has quit IRC | 00:25 | |
| *** sarob has quit IRC | 00:25 | |
| *** sarob has joined #openstack-dev | 00:26 | |
| *** adreznec has joined #openstack-dev | 00:26 | |
| *** kin_ has joined #openstack-dev | 00:26 | |
| *** nikhil__ has quit IRC | 00:27 | |
| *** markwash has quit IRC | 00:29 | |
| *** nikhil has joined #openstack-dev | 00:30 | |
| *** sarob has quit IRC | 00:30 | |
| *** reed has quit IRC | 00:31 | |
| *** nikhil has joined #openstack-dev | 00:31 | |
| *** krotscheck has quit IRC | 00:32 | |
| *** sarob has joined #openstack-dev | 00:33 | |
| *** CaptTofu has quit IRC | 00:34 | |
| *** kolesovdv has joined #openstack-dev | 00:34 | |
| *** CaptTofu has joined #openstack-dev | 00:34 | |
| *** krotscheck has joined #openstack-dev | 00:35 | |
| *** nikhil has quit IRC | 00:35 | |
| *** anniec has quit IRC | 00:36 | |
| *** nikhil has joined #openstack-dev | 00:36 | |
| *** tjones has joined #openstack-dev | 00:36 | |
| *** yamahata has joined #openstack-dev | 00:37 | |
| *** chris_johnson has quit IRC | 00:37 | |
| *** jcoufal has joined #openstack-dev | 00:39 | |
| *** nikhil has quit IRC | 00:39 | |
| *** anniec has joined #openstack-dev | 00:39 | |
| *** clayb has quit IRC | 00:39 | |
| *** nikhil has joined #openstack-dev | 00:39 | |
| *** pmathews has quit IRC | 00:40 | |
| *** markwash has joined #openstack-dev | 00:40 | |
| *** ewindisch has joined #openstack-dev | 00:41 | |
| *** ewindisch has quit IRC | 00:43 | |
| *** vkmc has joined #openstack-dev | 00:43 | |
| *** sarob has quit IRC | 00:44 | |
| *** RajeshMohan has joined #openstack-dev | 00:44 | |
| *** tjones1 has joined #openstack-dev | 00:44 | |
| *** sarob has joined #openstack-dev | 00:44 | |
| *** tjones has quit IRC | 00:47 | |
| *** markwash has quit IRC | 00:48 | |
| *** jnoller has joined #openstack-dev | 00:48 | |
| *** sarob has quit IRC | 00:49 | |
| *** atiwari has quit IRC | 00:49 | |
| *** thuc has quit IRC | 00:50 | |
| *** sarob has joined #openstack-dev | 00:50 | |
| *** pcm_ has joined #openstack-dev | 00:51 | |
| *** thuc has joined #openstack-dev | 00:51 | |
| *** pcm_ has quit IRC | 00:53 | |
| *** pcm_ has joined #openstack-dev | 00:54 | |
| *** Sukhdev has quit IRC | 00:54 | |
| *** thuc has quit IRC | 00:55 | |
| *** mgagne has joined #openstack-dev | 00:55 | |
| *** nosnos has joined #openstack-dev | 00:56 | |
| *** mgagne1 has quit IRC | 00:57 | |
| *** tdruiva has quit IRC | 00:58 | |
| *** markmcclain has joined #openstack-dev | 01:00 | |
| *** sarob has quit IRC | 01:01 | |
| *** sarob has joined #openstack-dev | 01:01 | |
| *** thuc has joined #openstack-dev | 01:01 | |
| *** tsekiyama has quit IRC | 01:03 | |
| *** hemna is now known as hemnafk | 01:04 | |
| *** comay has quit IRC | 01:04 | |
| *** jnoller has quit IRC | 01:04 | |
| *** thuc has quit IRC | 01:04 | |
| *** anniec has quit IRC | 01:05 | |
| *** sarob has quit IRC | 01:06 | |
| *** thuc has joined #openstack-dev | 01:06 | |
| *** sarob has joined #openstack-dev | 01:07 | |
| *** mgagne has quit IRC | 01:07 | |
| *** mrodden has quit IRC | 01:10 | |
| *** vkmc has quit IRC | 01:10 | |
| mriedem | bknudson: i figured out that mysql heat utf8 issue | 01:10 |
| mriedem | http://docs.moodle.org/23/en/Converting_your_MySQL_database_to_UTF8 | 01:10 |
| mriedem | bknudson: ^ | 01:10 |
| *** relaxdiego has joined #openstack-dev | 01:11 | |
| bknudson | mriedem: ok, but how did it get to latin1 instead of utf8? | 01:11 |
| bknudson | mriedem: you going to update my.cnf? | 01:11 |
| mriedem | bknudson: yeah, i updated my.cnf | 01:12 |
| mriedem | how it got to latin i don't know | 01:12 |
| mriedem | and why the other databases didn't have that problem i'm not sure either, i used openstack-db (from openstack-utils) to set those up | 01:12 |
| *** bhuvan has joined #openstack-dev | 01:12 | |
| mriedem | maybe they do something that heat-db-setup doesn't do with utf-8 | 01:12 |
| *** adreznec has quit IRC | 01:13 | |
| bknudson | dstanek: https://review.openstack.org/#/c/69065/ | 01:13 |
| mriedem | bknudson: yup, openstack-db script sets the default character set to utf-8, heat-db-setup doesn't do that | 01:14 |
| mriedem | time for a bug | 01:14 |
| *** marcoemorais has joined #openstack-dev | 01:15 | |
| *** jdurgin has quit IRC | 01:15 | |
| dstanek | bknudson: nice, i'll give that a try and see it it makes my life better | 01:15 |
| *** igor has joined #openstack-dev | 01:15 | |
| *** igor____ has quit IRC | 01:16 | |
| ayoung | so...we really need to be able to vary the version of python-keystonclient used in the server and in the test code. | 01:17 |
| *** marcoemorais1 has quit IRC | 01:17 | |
| *** devlaps has quit IRC | 01:17 | |
| ayoung | Anyone have any ideas how to do that and not break debugability? | 01:17 |
| *** jdurgin has joined #openstack-dev | 01:17 | |
| bknudson | ayoung: don't we do that already by testing against different versions of the client? | 01:18 |
| *** ruhe has quit IRC | 01:18 | |
| *** achampion has joined #openstack-dev | 01:19 | |
| topol | morganfainberg, on your comments on my patch. is it ok if we get in and then I take a bug to refactor the notifications as a module? | 01:20 |
| *** xarses has quit IRC | 01:21 | |
| morganfainberg | sure, like i said i didn't want to block it over that | 01:21 |
| *** markmcclain has quit IRC | 01:21 | |
| *** ewindisch has joined #openstack-dev | 01:21 | |
| *** prad has joined #openstack-dev | 01:21 | |
| topol | morganfainberg, K thanks! BTW, my meetup is feb 19 so if yours is after that your get a great presentation deck for free | 01:22 |
| morganfainberg | topol, hehe | 01:22 |
| morganfainberg | topol, yeah mine is end of feb | 01:22 |
| *** esmute has quit IRC | 01:22 | |
| topol | you lucky dog | 01:22 |
| *** ewindisch has quit IRC | 01:22 | |
| morganfainberg | topol, i'm sure i'll need to massage it for the more specific topics but yeah | 01:22 |
| topol | :-) | 01:22 |
| *** achampion has quit IRC | 01:23 | |
| *** markmcclain has joined #openstack-dev | 01:23 | |
| *** anniec has joined #openstack-dev | 01:23 | |
| topol | morganfainberg, you'll be 85% done! | 01:23 |
| *** tanisdl has quit IRC | 01:23 | |
| *** ykhodork has quit IRC | 01:25 | |
| *** thuc_ has joined #openstack-dev | 01:25 | |
| *** mrda is now known as mrda_away | 01:27 | |
| *** godara has quit IRC | 01:28 | |
| *** achampion has joined #openstack-dev | 01:29 | |
| *** thuc has quit IRC | 01:29 | |
| *** thuc_ has quit IRC | 01:30 | |
| *** bhuvan has quit IRC | 01:30 | |
| *** zackf has joined #openstack-dev | 01:31 | |
| zackf | how do i comment on gerrit reviews? Not seeing a way | 01:31 |
| *** angdraug has quit IRC | 01:31 | |
| dolphm | zackf: click on the line number you want to comment on to create draft comments, then click the Review button on the changeset | 01:31 |
| jamielennox | zackf: you probably need to sign in, after that the first of the buttons is review | 01:31 |
| *** thuc has joined #openstack-dev | 01:32 | |
| jamielennox | in other news our test suite is a pain in the arse | 01:32 |
| jamielennox | so sick of this | 01:32 |
| *** mgagne has joined #openstack-dev | 01:33 | |
| zackf | dolphm: thank you | 01:33 |
| dolphm | zackf: /salute | 01:33 |
| dolphm | jamielennox: did i miss something or is that a general rant? lol | 01:33 |
| zackf | dolphm: /bow | 01:34 |
| zackf | lol | 01:34 |
| jamielennox | kinda general, i think i'm still hitting a bug somewhere in testtools or something | 01:34 |
| jamielennox | in works fine for KDS, fails misserably in general keystone tests | 01:34 |
| *** krotscheck has quit IRC | 01:34 | |
| *** zackf has quit IRC | 01:35 | |
| *** Ursinha has joined #openstack-dev | 01:36 | |
| *** armax has left #openstack-dev | 01:36 | |
| *** markmcclain has left #openstack-dev | 01:36 | |
| jamielennox | lifeless: you have a few minutes today? | 01:36 |
| *** sc68cal has quit IRC | 01:37 | |
| ayoung | bknudson, so..no we don't what we do is use the same version of the client in the test code a s the server would call in. Which means we can't share code between client and server. | 01:37 |
| ayoung | I guess it is only a problem in the python-keystoneclient tests | 01:37 |
| *** taps has quit IRC | 01:38 | |
| ayoung | bknudson, we need to do a fork before we load in the client, so that the server can use the latest version, and the test can use the old version | 01:38 |
| *** marcoemorais has quit IRC | 01:38 | |
| *** marcoemorais has joined #openstack-dev | 01:38 | |
| ayoung | jamielennox, is it the bug where it says that a database table is missing? | 01:38 |
| jamielennox | ayoung: no | 01:39 |
| ayoung | jamielennox, mine works fine. | 01:39 |
| jamielennox | ayoung: yea this is for some other stuff i'm looking at | 01:39 |
| ayoung | ./run_tests.sh ? | 01:39 |
| *** jcoufal has quit IRC | 01:39 | |
| jamielennox | the test suites exit early | 01:39 |
| bknudson | ayoung: oh, I don't know how to handle that... although once v2 is deprecated I guess there's no keystoneclient tests anymore. | 01:39 |
| dolphm | bknudson: ++ | 01:40 |
| ayoung | bknudson, I think the answer is to popen the server | 01:40 |
| jamielennox | i pinned down a/the mistake - i passed a parameter to a function that didn't require one - what i'm interested in is why did the whole test suite crap out rather than just give me an error message | 01:40 |
| dolphm | jamielennox: memory? | 01:40 |
| bknudson | jamielennox: was it at import time? | 01:40 |
| dolphm | jamielennox: what if you execute with nosetests? | 01:40 |
| *** jcoufal has joined #openstack-dev | 01:40 | |
| jamielennox | i didn't think nose worked any more - it fails with testtools.run | 01:41 |
| jamielennox | not at import | 01:41 |
| jamielennox | ah! | 01:41 |
| jamielennox | fail_gracefully | 01:41 |
| ayoung | compile error? | 01:42 |
| *** jnoller has joined #openstack-dev | 01:42 | |
| *** amcrn has quit IRC | 01:43 | |
| jamielennox | https://github.com/openstack/keystone/blob/master/keystone/service.py#L67 | 01:43 |
| jamielennox | so if there is an error in the general setup stage - not caused by a request then you hit fail_gracefully which does an exit() | 01:44 |
| *** bdpayne has quit IRC | 01:44 | |
| jamielennox | this shuts down the subunit process and the test suites craps out | 01:44 |
| jamielennox | in the case of testtools.run giving a nice big OK message | 01:44 |
| jamielennox | searched for hours for that yesterday | 01:44 |
| *** bada_ has quit IRC | 01:45 | |
| *** mst89 has quit IRC | 01:45 | |
| jamielennox | lifeless: found it ^^ | 01:46 |
| bknudson | jamielennox: can we disable that for tests? | 01:46 |
| jamielennox | bknudson: not sure - it would have to be a global or something because it's being loaded via paste | 01:46 |
| bknudson | jamielennox: a global works for me. | 01:47 |
| *** balar has quit IRC | 01:47 | |
| bknudson | jamielennox: could override __builtin__.exit or something. | 01:48 |
| jamielennox | bknudson: it would still catch your exception for you though | 01:48 |
| jamielennox | (i didn't know you could just call exit, i always thought you had to sys.exit | 01:49 |
| bknudson | "They are useful for the interactive interpreter shell and should not be used in programs." | 01:49 |
| *** aeperezt has quit IRC | 01:49 | |
| jamielennox | but i could change that to a sys.exit and then stub that to raise an error | 01:50 |
| bknudson | jamielennox: that would be great | 01:50 |
| *** marcoemorais has quit IRC | 01:50 | |
| *** balar has joined #openstack-dev | 01:51 | |
| *** _cjones_ has quit IRC | 01:51 | |
| dolphm | yeah, we should raise SystemExit() or call sys.exit() there, not use the builtin | 01:51 |
| jamielennox | dolphm: would they have the same effect on the test suite? | 01:55 |
| jamielennox | guess i can test that but just wondering if you know | 01:55 |
| *** gimps has quit IRC | 01:55 | |
| bknudson | http://docs.python.org/2/library/constants.html#exit -- when called, raise SystemExit with the specified exit code | 01:56 |
| bknudson | should we start keystone-all with -S ? | 01:56 |
| jamielennox | what is -S? | 01:56 |
| *** sc68cal has joined #openstack-dev | 01:56 | |
| bknudson | the docs say if you do -S then there's no quit/exit. | 01:57 |
| *** mestery has joined #openstack-dev | 01:57 | |
| jamielennox | so SystemExit and sys.exit() both have the same effect on subunit | 01:58 |
| *** changlp has quit IRC | 01:59 | |
| dolphm | bknudson: https://review.openstack.org/#/c/71440/ | 01:59 |
| dolphm | jamielennox: ^ | 01:59 |
| dolphm | jamielennox: with that patch i think you'll at least get some stdout about the failure, which would have helped | 01:59 |
| *** xarses has joined #openstack-dev | 02:00 | |
| jamielennox | dolphm: not really: http://paste.openstack.org/show/62714/ | 02:01 |
| *** gokrokve has quit IRC | 02:02 | |
| dolphm | jamielennox: on keystone-all http://pasteraw.com/tkn4ksc6d1ioaja7h2ec0vghpe6sjaf | 02:03 |
| dolphm | jamielennox: on testr run: http://pasteraw.com/1ldesm6hdtbhgqbr5wudxow3xqfth8l | 02:04 |
| *** jnoller has quit IRC | 02:04 | |
| jamielennox | dolphm: oh right, yea it should still work for actually running keystone-all but it used to work anyway | 02:04 |
| jamielennox | it's just in testing that it's a problem | 02:04 |
| *** tsekiyama has joined #openstack-dev | 02:04 | |
| ayoung | what does useFixture from testcase give us? | 02:06 |
| *** ianw has quit IRC | 02:06 | |
| bknudson | ayoung: the fixture encapsulates the cleanup. | 02:06 |
| *** ianw has joined #openstack-dev | 02:06 | |
| *** xmltok has quit IRC | 02:06 | |
| ayoung | bknudson, so...would it be the right abstraction to wrap an external process? | 02:06 |
| bknudson | ayoung: it would be perfect. | 02:06 |
| bknudson | ayoung: if there was some cleanup involved after the test runs. | 02:07 |
| ayoung | bknudson, probably will be. Need to kill the server | 02:07 |
| *** peoplemerge has quit IRC | 02:07 | |
| Steap_ | jamielennox: do you think you'd have time to look at https://review.openstack.org/#/c/71016/ today ? It makes sure we use HTTPretty 0.8.0, so we are one step closer to Py3 compatibility | 02:08 |
| *** melwitt has quit IRC | 02:08 | |
| *** tsekiyama has quit IRC | 02:09 | |
| *** epim has quit IRC | 02:09 | |
| dolphm | jamielennox: on tox http://pasteraw.com/evc1ztqm9i08f849d25ecue0cs44zo1 | 02:09 |
| dolphm | so, basically all test approaches show the error on stdout w/ the above patch | 02:10 |
| jamielennox | except run_test? | 02:10 |
| dolphm | Steap_: that doesn't seem like a very good reason for bumping the minimum required version for everyone :-/ | 02:11 |
| *** anniec has quit IRC | 02:11 | |
| jamielennox | dolphm: sarcasm? | 02:12 |
| dolphm | not really - i mean, we obviously support 0.8.0 as-is so there's no work to do other than to falsely advertise that we don't support 0.7.x anymore? | 02:13 |
| jamielennox | though the latest version will always be used by jenkins so we probably don't need to bump the version until we actually suport py3 | 02:13 |
| *** prad has quit IRC | 02:13 | |
| jamielennox | yea that's reasonable - we don't need it until py3 support is announced and the gates will get it anyway | 02:14 |
| *** sarob_ has joined #openstack-dev | 02:14 | |
| dolphm | i'm not opposed to it, it just seems like a useless patch | 02:14 |
| Steap_ | jamielennox: I would not want people to run "tox -ewhatever" and still use 0.7.1 because it's already in their virtual env | 02:14 |
| jamielennox | did something happen to tox, every time i've tried it recently i get tox.ConfigError: ConfigError: substitution key 'posargs' not found which is why i hadn't tested that | 02:15 |
| *** changlp has joined #openstack-dev | 02:15 | |
| *** mestery has quit IRC | 02:15 | |
| *** sarob has quit IRC | 02:16 | |
| dolphm | Steap_: you mean tox -epy33 ? | 02:16 |
| dolphm | Steap_: and only py33? | 02:16 |
| dolphm | jamielennox: downgrade to tox 1.6 | 02:16 |
| jamielennox | Steap_: until we have a release that supports py33 it doesn't matter | 02:16 |
| Steap_ | jamielennox: ok | 02:16 |
| Steap_ | jamielennox: so it's fine for me to use 0.8.0 and keep sending patches | 02:16 |
| jamielennox | Steap_: yep | 02:17 |
| Steap_ | dolphm: well, even with tox -epy27 | 02:17 |
| *** stevemar has quit IRC | 02:17 | |
| jamielennox | encouraged even | 02:17 |
| Steap_ | dolphm: would be weird if people had bugs because they have an old virtualenv | 02:17 |
| Steap_ | but well, i'm not familiar with all this :) | 02:17 |
| dolphm | Steap_: but the current version is fine in 2.7, correct? | 02:18 |
| *** jnoller has joined #openstack-dev | 02:18 | |
| Steap_ | dolphm: oh yes | 02:18 |
| Steap_ | yeah, you're right | 02:18 |
| *** jcoufal has quit IRC | 02:18 | |
| *** sarob_ has quit IRC | 02:18 | |
| Steap_ | as long as we do not have Python 3 support, it's not a good idea to upgrade - it does not bring anything | 02:18 |
| Steap_ | I'll mark the patch as WIP until we have Py3 working | 02:19 |
| dolphm | Steap_: is this our current blocker to py3 support? i haven't checked in a bit | 02:20 |
| *** tjones1 has quit IRC | 02:20 | |
| Steap_ | dolphm: one of the last, yeah | 02:22 |
| Steap_ | There is also the memcache stuff | 02:22 |
| Steap_ | that I'mabout to resend | 02:22 |
| dolphm | Steap_: and is keystoneclient the only project using httpretty still? | 02:22 |
| Steap_ | and some random issues | 02:22 |
| Steap_ | dolphm: I think so, but I haven't checked | 02:22 |
| Steap_ | jamielennox: do you know if anybody else uses HTTPretty ? ^ | 02:22 |
| *** ijw has quit IRC | 02:23 | |
| ayoung | bknudson, so...os.fork, or subprocess? | 02:23 |
| dolphm | Steap_: let's delay this one patch just a bit then; i'd like to cut a 0.5.1 asap and i also don't want a bump in minimum requirements there | 02:23 |
| *** SumitNaiksatam has quit IRC | 02:24 | |
| bknudson | ayoung: I always go with subprocess | 02:24 |
| harlowja | Steap_ i've been using httpretty in cloud-init | 02:24 |
| bknudson | ayoung: I'm a little worried about where this is going ... why subprocess during test? | 02:24 |
| *** sarob has joined #openstack-dev | 02:25 | |
| ayoung | bknudson, to run the app server | 02:25 |
| *** gimps has joined #openstack-dev | 02:25 | |
| ayoung | needs to be in a separate process to load a differnt version of the client | 02:25 |
| bknudson | ayoung: you mean run keystone? | 02:25 |
| ayoung | bknudson, yep | 02:25 |
| jamielennox | Steap_: boto from a couple of those bug reports | 02:25 |
| bknudson | ayoung: how many tests? | 02:25 |
| ayoung | bknudson, pyton-keystoneclient | 02:26 |
| bknudson | seems like it's going to be slow | 02:26 |
| ayoung | yep | 02:26 |
| ayoung | just for the keystoneclient tests | 02:26 |
| Steap_ | harlowja: ok | 02:26 |
| Steap_ | harlowja: well, you'll be happy to know it's not Py3-compatible :) | 02:26 |
| bknudson | ayoung: are there some tests that could be skipped because they don't work? | 02:26 |
| harlowja | Steap_ ya, i was gonna try to fix it someday, lol | 02:26 |
| bknudson | when the client is old | 02:26 |
| harlowja | or just fork it and fix it | 02:26 |
| Steap_ | harlowja: don't fork, send patches :p | 02:26 |
| harlowja | Steap_ isn't there already patches up? | 02:27 |
| ayoung | bknudson, its the test that loads the older version of the client..lets see | 02:27 |
| harlowja | Steap_ https://github.com/gabrielfalcao/HTTPretty/pull/124 ? | 02:27 |
| Steap_ | harlowja: there are, but if you need to fix more stuff, send patches | 02:27 |
| Steap_ | I can merge them | 02:27 |
| harlowja | Steap_ ah, cool | 02:27 |
| harlowja | sounds good | 02:27 |
| Steap_ | oh, I have to close this one | 02:27 |
| *** morganfainberg is now known as morganfainberg_Z | 02:28 | |
| ayoung | Do we only ever check out master now? | 02:28 |
| bknudson | doesn't seem like the server uses keystoneclient that much. | 02:28 |
| *** thuc has quit IRC | 02:28 | |
| ayoung | bknudson, yeah...I only see a checkout of master now | 02:28 |
| *** mrda_away is now known as mrda | 02:29 | |
| *** thuc has joined #openstack-dev | 02:29 | |
| jamielennox | dolphm: i don't see the same exit message from tox | 02:29 |
| ayoung | dolphm, I think we no longer test any versions of the keystone client except master | 02:29 |
| bknudson | ayoung: interesting... I thought dstanek had a patch to test more versions? | 02:29 |
| dolphm | jamielennox: it's after the testr output for me | 02:30 |
| dolphm | last i looked, we were only cutting ~essex and ~folsom clients | 02:30 |
| *** thuc has quit IRC | 02:33 | |
| *** rtheis_ has quit IRC | 02:34 | |
| *** erkules has quit IRC | 02:34 | |
| *** mgagne has quit IRC | 02:34 | |
| *** newell has quit IRC | 02:35 | |
| *** baoli has joined #openstack-dev | 02:37 | |
| ayoung | dolphm, I only see a git checkout for master | 02:37 |
| ayoung | I'm guessing we never added griz of havana era client tests | 02:37 |
| ayoung | I just wiped out my vendor subdir and ... lets see what I get | 02:38 |
| *** tqtran has quit IRC | 02:38 | |
| *** sc68cal has quit IRC | 02:38 | |
| ayoung | run_tests.sh test_keystoneclient errors out on a the first chunk...trying the whole suite. | 02:39 |
| ayoung | which ran fine | 02:39 |
| *** jnoller has quit IRC | 02:39 | |
| ayoung | nothing in vendoer | 02:40 |
| ayoung | nothing in vendor | 02:40 |
| dstanek | bknudson: i did somewhere | 02:40 |
| ayoung | and now all ran correctly | 02:41 |
| ayoung | keystone.tests.test_keystoneclient_sql.KcOptTestCase was all skipped | 02:41 |
| dstanek | dolphm: that upgrade of HTTPretty was to get all of the Python3 fixes | 02:41 |
| *** pixelb has quit IRC | 02:41 | |
| ayoung | keystone.tests.test_keystoneclient.KcMasterTestCase.test_admin_requires_adminness fails | 02:41 |
| ayoung | NoReferencedTableError: Foreign key associated with column 'group.domain_id' could not find table 'domain' with which to generate a foreign key to target column 'id' | 02:41 |
| *** tjones has joined #openstack-dev | 02:42 | |
| ayoung | wow that looks wrong | 02:42 |
| dolphm | dstanek: ack, i want to make sure 0.5.1 gets out before we bump minimum requirements | 02:42 |
| dstanek | bknudson: it disappeared from my radar once it was marked abandoned - going to bring it back now https://review.openstack.org/#/c/63461/ | 02:42 |
| dolphm | dstanek: i made a general bp in keystoneclient for py3 compat https://blueprints.launchpad.net/python-keystoneclient/+spec/py3-compatibility | 02:43 |
| ayoung | ah...yeah...now that they are in different files, assignment needs to be created before domain | 02:43 |
| ayoung | bet it doesnot know to add assignment | 02:43 |
| *** dims has joined #openstack-dev | 02:44 | |
| *** arnaud__ has quit IRC | 02:44 | |
| jamielennox | dolphm, bknudson: https://review.openstack.org/#/c/71443/ | 02:44 |
| *** harlowja has quit IRC | 02:44 | |
| *** arnaud has quit IRC | 02:45 | |
| *** relaxdiego has quit IRC | 02:45 | |
| *** sulrich has quit IRC | 02:45 | |
| *** erkules has joined #openstack-dev | 02:48 | |
| *** jasondotstar has joined #openstack-dev | 02:50 | |
| *** gokrokve has joined #openstack-dev | 02:50 | |
| jamielennox | ayoung: thanks but you should probably have let the jenkins run finish | 02:51 |
| ayoung | yeah...didn't realized I clicked that. Unset it, but don;t know if that makes a difference | 02:51 |
| *** alop has quit IRC | 02:52 | |
| *** asalkeld has quit IRC | 02:52 | |
| *** dkranz has quit IRC | 02:52 | |
| *** relaxdiego has joined #openstack-dev | 02:53 | |
| dolphm | ayoung: unsetting it is perfect - doing it quickly pulls it out of the gate before it's able to do any damage (if it was a bad patch) | 02:53 |
| ayoung | cool | 02:54 |
| ayoung | dolphm, so can I start using client code in the server? | 02:54 |
| dolphm | ayoung: always; why not? | 02:54 |
| ayoung | the old testing thing | 02:54 |
| dolphm | ? | 02:54 |
| ayoung | where it was pulling older clients in to the test_keystoneclient | 02:55 |
| ayoung | only looks like it pulls in master now | 02:55 |
| *** harlowja has joined #openstack-dev | 02:55 | |
| *** gokrokve has quit IRC | 02:55 | |
| *** mgagne has joined #openstack-dev | 02:55 | |
| *** gokrokve has joined #openstack-dev | 02:56 | |
| *** rraja_ has joined #openstack-dev | 02:56 | |
| dolphm | ayoung: functional tests in the server having a dependency on git + internet connection is what was bad, import keystoneclient in the service is fine | 02:56 |
| *** jasdeepH has quit IRC | 02:56 | |
| *** rraja has joined #openstack-dev | 02:56 | |
| dolphm | (not super sure what you're asking) | 02:56 |
| ayoung | dolphm, OK, so I can get rid of keystone/common/cms.py and rpelcae it with keystoneclient/common/cms.py? | 02:57 |
| ayoung | replace | 02:57 |
| dolphm | ayoung: please! | 02:57 |
| dolphm | ayoung: someone was working on that in gerrit a month or two ago; they're out of sync (or were - not sure if any changes landed) | 02:57 |
| ayoung | I'll look | 02:57 |
| dolphm | keystoneclient was behind the service it seemed | 02:57 |
| dolphm | changes were being ported to the client so that the service could depend on the client | 02:58 |
| *** spzala has quit IRC | 02:58 | |
| *** mgagne has quit IRC | 02:59 | |
| *** RajeshMohan has quit IRC | 02:59 | |
| *** gokrokve has quit IRC | 03:00 | |
| *** RajeshMohan has joined #openstack-dev | 03:00 | |
| *** gokrokve has joined #openstack-dev | 03:00 | |
| *** doug_shelley66 has quit IRC | 03:00 | |
| *** baoli has quit IRC | 03:00 | |
| *** mgagne has joined #openstack-dev | 03:02 | |
| *** peoplemerge has joined #openstack-dev | 03:04 | |
| *** buzztrol_ has quit IRC | 03:05 | |
| *** sarob has quit IRC | 03:06 | |
| *** gokrokve has quit IRC | 03:06 | |
| *** sarob has joined #openstack-dev | 03:06 | |
| ayoung | we are ok for CMS | 03:06 |
| ayoung | and the changes I am making for compression will be in the client first | 03:06 |
| *** ykhodork has joined #openstack-dev | 03:07 | |
| ayoung | dolphm, it does mean that the compression patch will need to hit master in the client before the gate will pass changes for the server. | 03:08 |
| *** otherwiseguy has joined #openstack-dev | 03:08 | |
| *** browne has quit IRC | 03:09 | |
| *** briancline has quit IRC | 03:10 | |
| dolphm | ayoung: yes - it does (and maybe even make a release of the client?) | 03:10 |
| ayoung | yep | 03:11 |
| *** tsekiyama has joined #openstack-dev | 03:11 | |
| dolphm | ayoung: i can't remember if the service is tested against the client's master or client as it appears on pypi | 03:11 |
| ayoung | dolphm, I have some changes in the server version that I am going to move to the client version. We can expedite | 03:11 |
| ayoung | looks like git | 03:11 |
| *** baoli has joined #openstack-dev | 03:12 | |
| *** sulrich has joined #openstack-dev | 03:12 | |
| *** coolsvap_away has quit IRC | 03:13 | |
| *** asalkeld has joined #openstack-dev | 03:13 | |
| *** briancline has joined #openstack-dev | 03:14 | |
| *** sc68cal_ has joined #openstack-dev | 03:14 | |
| *** jhesketh__ has quit IRC | 03:14 | |
| *** stevemar has joined #openstack-dev | 03:14 | |
| dolphm | ayoung: you're also being summoned in https://bugs.launchpad.net/bugs/1268751 | 03:14 |
| uvirtbot | Launchpad bug 1268751 in ossa "Potential token revocation abuse via group membership" [Medium,Triaged] | 03:14 |
| *** paragan has joined #openstack-dev | 03:14 | |
| ayoung | I wrote that | 03:15 |
| ayoung | heh | 03:15 |
| *** tsekiyama has quit IRC | 03:15 | |
| ayoung | No, no patch | 03:15 |
| *** sc68cal_ has quit IRC | 03:15 | |
| ayoung | bveen working on the replacement for revocations, which should not have the same problem | 03:15 |
| *** sweston has joined #openstack-dev | 03:17 | |
| *** relaxdiego has quit IRC | 03:17 | |
| *** sc68cal_ has joined #openstack-dev | 03:18 | |
| *** sc68cal_ has quit IRC | 03:18 | |
| *** Mandell has quit IRC | 03:19 | |
| *** tjones has quit IRC | 03:19 | |
| *** jhesketh__ has joined #openstack-dev | 03:19 | |
| *** tjones has joined #openstack-dev | 03:21 | |
| *** lcheng_ has joined #openstack-dev | 03:26 | |
| *** prad has joined #openstack-dev | 03:26 | |
| *** pcm_ has quit IRC | 03:27 | |
| *** prad has quit IRC | 03:28 | |
| *** sc68cal_ has joined #openstack-dev | 03:28 | |
| *** novas0x2a|laptop has quit IRC | 03:29 | |
| *** thuc has joined #openstack-dev | 03:31 | |
| *** thuc_ has joined #openstack-dev | 03:32 | |
| *** amotoki has joined #openstack-dev | 03:34 | |
| *** odyssey4me has joined #openstack-dev | 03:35 | |
| *** galstrom_zzz is now known as galstrom | 03:36 | |
| *** thuc has quit IRC | 03:36 | |
| *** ykhodork has quit IRC | 03:36 | |
| *** sc68cal_ has quit IRC | 03:39 | |
| *** relaxdiego has joined #openstack-dev | 03:39 | |
| *** odyssey4me2 has joined #openstack-dev | 03:39 | |
| *** baoli has quit IRC | 03:40 | |
| *** odyssey4me has quit IRC | 03:40 | |
| ayoung | dolphm, I need to treat all public functions in both middleware/auth_token.py and cms.py as stable, right? Can't change or remove them? | 03:42 |
| dolphm | ayoung: technically yes, but i'm not aware of anyone extending or calling into either... so i wouldn't worry too much | 03:44 |
| ayoung | dolphm, ok...I'm going to make a whole bunch of the auth_token calls private | 03:44 |
| ayoung | I think | 03:44 |
| *** sc68cal has joined #openstack-dev | 03:45 | |
| *** aveiga has quit IRC | 03:47 | |
| *** comay has joined #openstack-dev | 03:47 | |
| *** alex_klimov has joined #openstack-dev | 03:49 | |
| *** aditirav has joined #openstack-dev | 03:51 | |
| *** david-lyle has joined #openstack-dev | 03:51 | |
| *** rraja_ has quit IRC | 03:52 | |
| *** rraja has quit IRC | 03:52 | |
| *** jpomero has quit IRC | 03:52 | |
| *** galstrom is now known as galstrom_zzz | 03:53 | |
| *** jasdeepH has joined #openstack-dev | 03:53 | |
| *** achampion has quit IRC | 03:54 | |
| *** gordc has joined #openstack-dev | 03:54 | |
| *** relaxdiego has quit IRC | 03:55 | |
| *** mriedem has quit IRC | 03:56 | |
| *** emagana has quit IRC | 03:57 | |
| *** thuc_ has quit IRC | 03:58 | |
| *** thuc has joined #openstack-dev | 03:58 | |
| *** tjones has quit IRC | 03:59 | |
| ayoung | ARGH | 04:01 |
| ayoung | That whole envirnoment thing | 04:01 |
| ayoung | dumb@! | 04:01 |
| *** kushal has joined #openstack-dev | 04:01 | |
| *** pradeep has joined #openstack-dev | 04:02 | |
| *** thuc has quit IRC | 04:03 | |
| *** lcheng_ has quit IRC | 04:06 | |
| *** zackf has joined #openstack-dev | 04:06 | |
| *** HenryG has joined #openstack-dev | 04:09 | |
| *** rohitk has joined #openstack-dev | 04:11 | |
| ayoung | bknudson, the common/environment thing was you idea, right? | 04:16 |
| *** buzztroll has joined #openstack-dev | 04:16 | |
| ayoung | It puts me in a bit of a bind. I can't really do that for keystone client | 04:16 |
| *** bdpayne has joined #openstack-dev | 04:18 | |
| *** buzztroll has quit IRC | 04:20 | |
| *** tdruiva has joined #openstack-dev | 04:21 | |
| *** gokrokve has joined #openstack-dev | 04:24 | |
| *** rohitk has quit IRC | 04:26 | |
| lbragstad | ayoung: I thought jamielennox was the one who did the environment stuff? | 04:26 |
| ayoung | lbragstad, I think bknudson origianlly, but I think I am ok. I just need to back off using it for calls from the client library, and catch the original exceptions. | 04:27 |
| ayoung | testing now. | 04:27 |
| lbragstad | ayoung: side note, have you done any work with the osc? | 04:28 |
| ayoung | lbragstad, NOPE | 04:28 |
| jamielennox | ayoung: yea that was me | 04:28 |
| ayoung | jamielennox, do the orignial monkeypatch calls still take effect? | 04:28 |
| ayoung | if I do evviron use eventlet , It still monkeypatches subprocess to be the eventlet version, right? | 04:29 |
| jamielennox | should do | 04:30 |
| ayoung | we are just enforcing the use of environement.subprocess to make sure the user makes a deliberate decision, but I can't do that in the client code. | 04:30 |
| jamielennox | ayoung: yea that's correct | 04:30 |
| ayoung | https://github.com/openstack/keystone/blob/master/keystone/common/environment/eventlet_server.py | 04:30 |
| jamielennox | it was always a server side solution | 04:30 |
| ayoung | from eventlet.green import subprocess as _subprocess | 04:31 |
| jamielennox | it was also supposed to make it explicit, if you use eventlet then it should patch subprocess correnctly | 04:31 |
| ayoung | https://github.com/openstack/keystone/blob/master/keystone/common/environment/__init__.py | 04:31 |
| ayoung | https://github.com/openstack/keystone/blob/master/keystone/common/environment/__init__.py#L72 | 04:31 |
| *** kenperkins has quit IRC | 04:31 | |
| jamielennox | eventlet will patch subprocess anyway i think | 04:31 |
| ayoung | so if keystoneclient/common/cms throws a subprocess exception, we're good | 04:31 |
| jamielennox | ayoung: yea | 04:32 |
| ayoung | if I just drop environment off the catc | 04:32 |
| jamielennox | i think it'll impact some tests but it shouldn't make a difference | 04:32 |
| lifeless | jamielennox: rather than calling exit, it should raise an exception | 04:32 |
| lifeless | jamielennox: exit() raises SystemExit which nothing catches | 04:32 |
| jamielennox | ayoung: i always hated the magic of evenlet, when you use environment it is obvous | 04:32 |
| *** galstrom_zzz is now known as galstrom | 04:33 | |
| ayoung | no argument here, but the rest of the world doesn't do that | 04:33 |
| ayoung | I just want to get rid of eventlet | 04:33 |
| ayoung | Even a continuation based web server should not require monkeypatching | 04:34 |
| ayoung | shrug | 04:34 |
| lifeless | ssh heat-admin@$UNDERCLOUD_IP "cat /opt/stack/boot-stack/virtual-power-key.pub" >> ~/.ssh/authorized_keys | 04:34 |
| lifeless | bah | 04:35 |
| lifeless | sorry | 04:35 |
| SpamapS | lifeless: testing copy/paste? ;) | 04:36 |
| *** achampion has joined #openstack-dev | 04:36 | |
| StevenK | SpamapS: It never hurts to be sure it's working for when you need it. | 04:37 |
| *** sgordon has quit IRC | 04:37 | |
| ayoung | jamielennox, the funny thing is I just put in a patch to make sure that we call environemnt setup for some tests that were failing when run stand alone. | 04:38 |
| ayoung | Won't need it once this one goes it, it was failing due to the cms call | 04:38 |
| *** lcheng_ has joined #openstack-dev | 04:38 | |
| *** aditirav_ has joined #openstack-dev | 04:40 | |
| jamielennox | lifeless: oh yea, there are a bunch of things that could be done better around there i'm just glad i found it | 04:40 |
| *** aditirav_ has quit IRC | 04:41 | |
| *** aditirav has quit IRC | 04:41 | |
| *** aditirav has joined #openstack-dev | 04:41 | |
| jamielennox | lifeless: for a future version of testtools (or whereever) something that notices a dieing thread would be good - thanks for your help | 04:41 |
| *** CaptTofu has quit IRC | 04:42 | |
| lifeless | jamielennox: well, it did notice it ;) | 04:42 |
| lifeless | jamielennox: it just was super unhelpful in diagnosing why... | 04:42 |
| lifeless | jamielennox: and yes, something better would be nice | 04:42 |
| *** jcooley_ has quit IRC | 04:43 | |
| ayoung | jamielennox, https://review.openstack.org/#/c/71455/ | 04:43 |
| ayoung | and with that, we can make it a point to put common code in the client | 04:43 |
| jamielennox | ayoung: part of the purpose though was to allow for using the openssl lib if running normally | 04:43 |
| ayoung | that will happen in the client as well | 04:43 |
| *** coolsvap has joined #openstack-dev | 04:44 | |
| ayoung | the openssl shell out can be hidden behind the cms call. | 04:44 |
| ayoung | so we should be able to swap in a library in its place | 04:44 |
| *** relaxdiego has joined #openstack-dev | 04:45 | |
| *** ayoung is now known as ayoung-ZzZzzZZzz | 04:48 | |
| *** relaxdiego has quit IRC | 04:49 | |
| *** sc68cal has quit IRC | 04:50 | |
| *** sc68cal has joined #openstack-dev | 04:50 | |
| *** gokrokve has quit IRC | 04:50 | |
| *** zackf has quit IRC | 04:51 | |
| *** gokrokve has joined #openstack-dev | 04:52 | |
| *** otherwiseguy has quit IRC | 04:53 | |
| *** gokrokve has quit IRC | 04:53 | |
| *** kolesovdv has quit IRC | 04:56 | |
| *** SumitNaiksatam has joined #openstack-dev | 04:56 | |
| *** achampion has quit IRC | 04:56 | |
| *** jasondotstar has quit IRC | 04:57 | |
| *** doug_shelley66 has joined #openstack-dev | 04:57 | |
| *** galstrom is now known as galstrom_zzz | 04:58 | |
| *** doug_shelley66 has quit IRC | 05:01 | |
| *** nosnos_ has joined #openstack-dev | 05:02 | |
| *** dims has quit IRC | 05:03 | |
| *** Guest73201 is now known as mfisch | 05:03 | |
| *** Ryan_Lane has joined #openstack-dev | 05:03 | |
| *** mfisch is now known as Guest18735 | 05:03 | |
| *** dims has joined #openstack-dev | 05:04 | |
| *** sarob has quit IRC | 05:05 | |
| *** munx has quit IRC | 05:05 | |
| *** harlowja has quit IRC | 05:05 | |
| *** nosnos has quit IRC | 05:06 | |
| *** emagana has joined #openstack-dev | 05:08 | |
| *** pablosan has quit IRC | 05:09 | |
| *** sarob has joined #openstack-dev | 05:10 | |
| *** pablosan has joined #openstack-dev | 05:11 | |
| *** emagana has quit IRC | 05:13 | |
| *** harlowja has joined #openstack-dev | 05:14 | |
| *** sarob has quit IRC | 05:15 | |
| *** rraja_ has joined #openstack-dev | 05:18 | |
| *** rraja has joined #openstack-dev | 05:18 | |
| *** nshaikh has joined #openstack-dev | 05:19 | |
| stevemar | bknudson, how keen are you on calling it ruleProcessor vs mappingProcessor? | 05:20 |
| *** blamar has quit IRC | 05:21 | |
| *** buzztroll has joined #openstack-dev | 05:22 | |
| *** kgriffs_afk has quit IRC | 05:25 | |
| *** kgriffs_afk has joined #openstack-dev | 05:26 | |
| *** kgriffs_afk is now known as kgriffs | 05:26 | |
| *** rdas has joined #openstack-dev | 05:26 | |
| *** NearlyFunctional has quit IRC | 05:27 | |
| *** edmund1 has quit IRC | 05:29 | |
| *** zaitcev has quit IRC | 05:33 | |
| *** mgagne1 has joined #openstack-dev | 05:35 | |
| *** dstufft-gone has quit IRC | 05:36 | |
| *** Mandell has joined #openstack-dev | 05:36 | |
| kashyap | harlowja, Just read the scroll, /me was asleep. Thank you, will checkout zuul CLI. I recently started taking a look at its web interface - http://status.openstack.org/zuul/ | 05:37 |
| harlowja | kashyap ya, the czuul one is similar to the website | 05:38 |
| *** mgagne has quit IRC | 05:38 | |
| kashyap | Cool. I frequently work w/ poor internet connectivity w/ a USB data card, while traveling. So, trying to optimize workflows to CLI as much as possible | 05:39 |
| kashyap | harlowja, I wish there's a way to read older comments in Gerrit relatively easy. If a patch series had 50 revisions, it's just painful to comb through the older comments :-( | 05:40 |
| *** e0ne has joined #openstack-dev | 05:40 | |
| harlowja | kashyap ya, gerrit is not so good at hiding info | 05:40 |
| harlowja | especially when revisions go above 20 | 05:41 |
| harlowja | the UI falls apart around that | 05:41 |
| *** DinaBelova_ is now known as DinaBelova | 05:41 | |
| harlowja | especially when u have automated systems posting comments | 05:41 |
| harlowja | it'd be nice to have automated system comment section and human people section | 05:41 |
| kashyap | harlowja, Yeah. Is there any historical discussion you can point me to, as to why Gerrit vs traditional mailing list based patches? | 05:41 |
| harlowja | kashyap hmmm, that might even predate me, i've never seen that discussion | 05:42 |
| harlowja | i've seen a git vs launchpad one | 05:42 |
| kashyap | (I can obviously imagine some reasons, any how, no worries) | 05:42 |
| kashyap | Goodness, it's git :-) | 05:42 |
| kashyap | I presume this is the canonical repository - https://github.com/openstack-infra/zuul | 05:43 |
| *** bdpayne has quit IRC | 05:44 | |
| harlowja | i think thats the zuul repository | 05:44 |
| *** rdas has quit IRC | 05:44 | |
| *** NearlyFunctional has joined #openstack-dev | 05:45 | |
| * kashyap looks up for czuul repository | 05:46 | |
| harlowja | kashyap http://www.gossamer-threads.com/lists/openstack/dev/3981 | 05:46 |
| harlowja | sorta interesting to read | 05:46 |
| harlowja | kashyap oh czuul is @ https://github.com/harlowja/gerrit_view/#czuul | 05:46 |
| harlowja | in the same package that qgerrit is in | 05:46 |
| *** sandywalsh has quit IRC | 05:46 | |
| kashyap | Nice, thank you. | 05:47 |
| kashyap | harlowja, Also, I heard vaguely that launchpad will be replaced with something else for blueprint/bug-tracking? | 05:48 |
| harlowja | kashyap hmmm, i haven't heard that yet, that'd be nice, its not especially well integrated | 05:49 |
| *** unicell has joined #openstack-dev | 05:49 | |
| *** jcooley_ has joined #openstack-dev | 05:49 | |
| *** dstufft has joined #openstack-dev | 05:50 | |
| *** gordc has quit IRC | 05:53 | |
| *** emagana has joined #openstack-dev | 05:57 | |
| *** jamespage_ has joined #openstack-dev | 05:58 | |
| *** sergmelikyan has quit IRC | 05:58 | |
| *** denis_makogon has joined #openstack-dev | 06:00 | |
| *** jamespage_ has quit IRC | 06:05 | |
| *** jamespage__ has joined #openstack-dev | 06:05 | |
| *** neeti has joined #openstack-dev | 06:05 | |
| *** DinaBelova is now known as DinaBelova_ | 06:06 | |
| *** matsuhashi has quit IRC | 06:07 | |
| *** matsuhashi has joined #openstack-dev | 06:07 | |
| *** bdpayne has joined #openstack-dev | 06:08 | |
| *** matsuhas_ has joined #openstack-dev | 06:09 | |
| *** matsuhashi has quit IRC | 06:09 | |
| *** jcooley_ has quit IRC | 06:11 | |
| lbragstad | stevemar: trusts in ocs https://review.openstack.org/#/c/71460/ | 06:15 |
| lbragstad | the tests still need some work though | 06:15 |
| *** rohitk has joined #openstack-dev | 06:16 | |
| lbragstad | i marked it WIP for now to get some more experienced openstackclient eyes on it, especially the tests | 06:16 |
| *** sarob has joined #openstack-dev | 06:17 | |
| *** mgagne1 has quit IRC | 06:17 | |
| *** igor has quit IRC | 06:18 | |
| *** igor has joined #openstack-dev | 06:18 | |
| *** sarob has quit IRC | 06:21 | |
| *** topol has quit IRC | 06:24 | |
| *** jcooley_ has joined #openstack-dev | 06:24 | |
| *** denis_makogon_ has joined #openstack-dev | 06:24 | |
| *** rraja_ has quit IRC | 06:25 | |
| *** denis_makogon has quit IRC | 06:26 | |
| *** mrda is now known as mrda_away | 06:27 | |
| *** e0ne has quit IRC | 06:27 | |
| *** tkammer has joined #openstack-dev | 06:29 | |
| *** rdas has joined #openstack-dev | 06:31 | |
| *** rraja has quit IRC | 06:35 | |
| *** yeylon__ has joined #openstack-dev | 06:37 | |
| *** jamespage__ has quit IRC | 06:39 | |
| *** jamespage__ has joined #openstack-dev | 06:39 | |
| *** nosnos has joined #openstack-dev | 06:40 | |
| *** bdpayne has quit IRC | 06:42 | |
| *** nosnos_ has quit IRC | 06:42 | |
| *** CaptTofu has joined #openstack-dev | 06:42 | |
| stevemar | lbragstad, i'm not crazy about the way the tests are structured in general :( | 06:43 |
| lbragstad | stevemar: yeah, it took me a while to figure it out... I still don't think I have my head wrapped all the way around it though | 06:43 |
| stevemar | lbragstad, it's a bit wonky | 06:44 |
| lbragstad | I figure, wth I'll push a patch with some tests and if they give me some pointers on how to do it bettr, great | 06:44 |
| stevemar | lbragstad, setup.cg looks good :P | 06:44 |
| lbragstad | better than it did last night! thank you | 06:45 |
| *** hdd_ has quit IRC | 06:46 | |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 06:48 | |
| *** coolsvap_away has joined #openstack-dev | 06:51 | |
| *** coolsvap has quit IRC | 06:52 | |
| *** markwash has joined #openstack-dev | 06:53 | |
| *** rraja has joined #openstack-dev | 06:54 | |
| *** jpich has joined #openstack-dev | 06:54 | |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 06:54 | |
| *** dstanek has quit IRC | 06:55 | |
| *** HenryG_ has joined #openstack-dev | 06:55 | |
| *** vartom1111111116 has joined #openstack-dev | 06:57 | |
| *** yamahata__ has quit IRC | 06:57 | |
| *** yamahata__ has joined #openstack-dev | 06:57 | |
| *** bhuvan has joined #openstack-dev | 06:57 | |
| *** HenryG has quit IRC | 06:58 | |
| *** jamespage__ has quit IRC | 06:58 | |
| *** tchaypo has quit IRC | 06:58 | |
| *** mugsie has quit IRC | 07:00 | |
| *** mugsie has joined #openstack-dev | 07:01 | |
| *** coolsvap_away has quit IRC | 07:02 | |
| *** kragniz has quit IRC | 07:03 | |
| *** esmute has joined #openstack-dev | 07:04 | |
| *** lbragstad has quit IRC | 07:04 | |
| *** kragniz has joined #openstack-dev | 07:05 | |
| *** lbragstad has joined #openstack-dev | 07:06 | |
| *** nati_ueno has quit IRC | 07:06 | |
| *** tchaypo has joined #openstack-dev | 07:06 | |
| *** BLZbubba has quit IRC | 07:06 | |
| *** Drankis has joined #openstack-dev | 07:06 | |
| *** coolsvap has joined #openstack-dev | 07:07 | |
| *** ron-slc_ has quit IRC | 07:08 | |
| *** irenab has joined #openstack-dev | 07:08 | |
| *** CaptTofu has quit IRC | 07:08 | |
| *** coolsvap_away has joined #openstack-dev | 07:11 | |
| *** bvandenh has joined #openstack-dev | 07:12 | |
| *** coolsvap has quit IRC | 07:12 | |
| *** BLZbubba has joined #openstack-dev | 07:14 | |
| *** lcheng_ has quit IRC | 07:14 | |
| *** ron-slc_ has joined #openstack-dev | 07:15 | |
| *** lcheng_ has joined #openstack-dev | 07:15 | |
| *** jprovazn has joined #openstack-dev | 07:20 | |
| *** harlowja is now known as harlowja_away | 07:23 | |
| *** markwash has quit IRC | 07:24 | |
| *** yeylon_ has joined #openstack-dev | 07:26 | |
| *** stevemar has quit IRC | 07:28 | |
| *** tkammer has quit IRC | 07:28 | |
| *** bhuvan has quit IRC | 07:28 | |
| *** yeylon__ has quit IRC | 07:29 | |
| *** unicell has quit IRC | 07:29 | |
| *** MaxV has joined #openstack-dev | 07:29 | |
| *** dfarrell07 has joined #openstack-dev | 07:30 | |
| *** yolanda has joined #openstack-dev | 07:30 | |
| *** sushil_ has joined #openstack-dev | 07:31 | |
| *** pasquier-s_ has quit IRC | 07:32 | |
| *** pasquier-s_ has joined #openstack-dev | 07:32 | |
| *** markwash has joined #openstack-dev | 07:33 | |
| *** yeylon_ has quit IRC | 07:34 | |
| *** coolsvap_away is now known as coolsvap | 07:37 | |
| *** flaper87|afk is now known as flaper87 | 07:39 | |
| *** emagana has quit IRC | 07:43 | |
| *** unicell has joined #openstack-dev | 07:44 | |
| *** asalkeld has quit IRC | 07:46 | |
| *** e0ne has joined #openstack-dev | 07:47 | |
| *** kushal has quit IRC | 07:47 | |
| *** MaxV has quit IRC | 07:47 | |
| *** rohitk has quit IRC | 07:48 | |
| *** negronjl has quit IRC | 07:49 | |
| *** rraja has quit IRC | 07:49 | |
| *** negronjl has joined #openstack-dev | 07:50 | |
| *** rohitk has joined #openstack-dev | 07:50 | |
| *** tkammer has joined #openstack-dev | 07:50 | |
| *** sc68cal is now known as sc68cal_ | 07:50 | |
| *** yeylon_ has joined #openstack-dev | 07:51 | |
| *** sarob has joined #openstack-dev | 07:52 | |
| *** sc68cal_ is now known as sc68cal | 07:52 | |
| *** evgenyf has joined #openstack-dev | 07:53 | |
| *** rohitk has quit IRC | 07:55 | |
| *** denis_makogon_ has quit IRC | 07:55 | |
| *** rohitk has joined #openstack-dev | 07:56 | |
| *** markwash has quit IRC | 08:02 | |
| *** pmcg has quit IRC | 08:03 | |
| *** killer_prince has quit IRC | 08:03 | |
| *** comay has quit IRC | 08:04 | |
| *** kushal has joined #openstack-dev | 08:05 | |
| *** viktors has joined #openstack-dev | 08:05 | |
| *** rohitk has quit IRC | 08:06 | |
| *** rohitk has joined #openstack-dev | 08:06 | |
| *** jpich has quit IRC | 08:06 | |
| *** xga has joined #openstack-dev | 08:07 | |
| *** omachace has joined #openstack-dev | 08:09 | |
| *** corXi has joined #openstack-dev | 08:10 | |
| *** irenab has quit IRC | 08:11 | |
| *** pmcg has joined #openstack-dev | 08:12 | |
| *** lcheng_ has quit IRC | 08:12 | |
| *** xgsa has joined #openstack-dev | 08:13 | |
| *** jistr has joined #openstack-dev | 08:14 | |
| *** jcoufal has joined #openstack-dev | 08:17 | |
| *** evgenyf has quit IRC | 08:17 | |
| *** markwash has joined #openstack-dev | 08:18 | |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 08:20 | |
| *** Nikolay_St has quit IRC | 08:20 | |
| *** alex_xu has joined #openstack-dev | 08:20 | |
| *** MaxV has joined #openstack-dev | 08:22 | |
| *** AlexF has joined #openstack-dev | 08:22 | |
| *** florentflament has joined #openstack-dev | 08:23 | |
| *** amuller has joined #openstack-dev | 08:24 | |
| *** bogdando has joined #openstack-dev | 08:30 | |
| *** nkinder has joined #openstack-dev | 08:30 | |
| *** ndipanov_gone is now known as ndipanov | 08:32 | |
| *** athomas has joined #openstack-dev | 08:33 | |
| *** athomas has quit IRC | 08:34 | |
| *** nmagnezi has joined #openstack-dev | 08:34 | |
| *** athomas has joined #openstack-dev | 08:35 | |
| *** sahid has joined #openstack-dev | 08:39 | |
| *** nati_ueno has joined #openstack-dev | 08:40 | |
| *** afazekas has joined #openstack-dev | 08:42 | |
| *** markwash has quit IRC | 08:43 | |
| *** pll_ has joined #openstack-dev | 08:44 | |
| *** ifarkas has joined #openstack-dev | 08:45 | |
| *** eglynn has joined #openstack-dev | 08:46 | |
| *** marekd|away is now known as marekd | 08:47 | |
| *** jcoufal has quit IRC | 08:50 | |
| *** nacim has joined #openstack-dev | 08:51 | |
| *** ygbo has joined #openstack-dev | 08:51 | |
| *** xqueralt has joined #openstack-dev | 08:51 | |
| *** askb_ has joined #openstack-dev | 08:51 | |
| *** ala has joined #openstack-dev | 08:53 | |
| *** jtomasek has joined #openstack-dev | 08:55 | |
| *** mindpixel has joined #openstack-dev | 08:58 | |
| *** eglynn has quit IRC | 08:59 | |
| *** romcheg has joined #openstack-dev | 08:59 | |
| *** salv-orlando has quit IRC | 08:59 | |
| *** sarob has quit IRC | 09:00 | |
| *** pixelb has joined #openstack-dev | 09:00 | |
| *** sarob has joined #openstack-dev | 09:01 | |
| *** odyssey4me2 is now known as odyssey4me | 09:01 | |
| *** I159 has joined #openstack-dev | 09:02 | |
| *** akrivoka has joined #openstack-dev | 09:02 | |
| *** sarob has quit IRC | 09:06 | |
| *** gszasz has joined #openstack-dev | 09:06 | |
| *** jcoufal has joined #openstack-dev | 09:06 | |
| *** CaptTofu has joined #openstack-dev | 09:09 | |
| *** alex_xu has quit IRC | 09:11 | |
| *** e0ne_ has joined #openstack-dev | 09:12 | |
| *** rossella_s has joined #openstack-dev | 09:12 | |
| *** eglynn has joined #openstack-dev | 09:13 | |
| *** CaptTofu has quit IRC | 09:14 | |
| *** e0ne has quit IRC | 09:14 | |
| *** jamespage_ has joined #openstack-dev | 09:16 | |
| *** yassine has joined #openstack-dev | 09:16 | |
| *** AlexF has quit IRC | 09:16 | |
| *** jamespage_ has quit IRC | 09:17 | |
| *** alex_xu has joined #openstack-dev | 09:18 | |
| *** iartarisi has joined #openstack-dev | 09:19 | |
| *** jpich has joined #openstack-dev | 09:20 | |
| *** nati_ueno has quit IRC | 09:23 | |
| *** gcha has joined #openstack-dev | 09:24 | |
| *** safchain has joined #openstack-dev | 09:24 | |
| *** buzztroll has quit IRC | 09:25 | |
| *** Nikolay_St has joined #openstack-dev | 09:25 | |
| *** buzztroll has joined #openstack-dev | 09:25 | |
| *** kolesovdv has joined #openstack-dev | 09:28 | |
| *** nati_ueno has joined #openstack-dev | 09:29 | |
| *** dfarrell07 has quit IRC | 09:30 | |
| *** buzztroll has quit IRC | 09:30 | |
| *** igor_ has joined #openstack-dev | 09:30 | |
| *** igor has quit IRC | 09:32 | |
| *** jcooley_ has quit IRC | 09:32 | |
| *** vartom1111111117 has joined #openstack-dev | 09:33 | |
| *** markmc has joined #openstack-dev | 09:34 | |
| *** vartom1111111116 has quit IRC | 09:36 | |
| *** nati_ueno has quit IRC | 09:36 | |
| *** DinaBelova_ is now known as DinaBelova | 09:37 | |
| *** reed has joined #openstack-dev | 09:38 | |
| *** derekh has joined #openstack-dev | 09:38 | |
| *** L33 has quit IRC | 09:38 | |
| *** L33 has joined #openstack-dev | 09:38 | |
| *** johnthetubaguy has joined #openstack-dev | 09:39 | |
| *** johnthetubaguy1 has joined #openstack-dev | 09:40 | |
| *** johnthetubaguy has quit IRC | 09:40 | |
| *** jhesketh__ has quit IRC | 09:40 | |
| *** itzikb has joined #openstack-dev | 09:42 | |
| *** pmcg has quit IRC | 09:42 | |
| *** lucasagomes has joined #openstack-dev | 09:42 | |
| *** johnthetubaguy has joined #openstack-dev | 09:42 | |
| *** johnthetubaguy1 has quit IRC | 09:44 | |
| *** rraja has joined #openstack-dev | 09:45 | |
| *** rodrigods has joined #openstack-dev | 09:47 | |
| *** vartom1111111117 has quit IRC | 09:48 | |
| *** vartom1111111117 has joined #openstack-dev | 09:49 | |
| *** vartom1111111117 has quit IRC | 09:50 | |
| *** vartom1111111117 has joined #openstack-dev | 09:51 | |
| *** sweston has quit IRC | 09:51 | |
| *** pmcg has joined #openstack-dev | 09:51 | |
| *** bhuvan has joined #openstack-dev | 09:52 | |
| *** danpb has joined #openstack-dev | 09:56 | |
| *** xga has quit IRC | 09:57 | |
| *** jasondotstar has joined #openstack-dev | 10:00 | |
| *** rods` has quit IRC | 10:02 | |
| *** johnthetubaguy has quit IRC | 10:03 | |
| *** fc__ has quit IRC | 10:04 | |
| *** rods has joined #openstack-dev | 10:04 | |
| *** johnthetubaguy has joined #openstack-dev | 10:05 | |
| *** xga has joined #openstack-dev | 10:05 | |
| *** xga_ has joined #openstack-dev | 10:07 | |
| *** xga has quit IRC | 10:08 | |
| *** buzztroll has joined #openstack-dev | 10:08 | |
| *** buzztrol_ has joined #openstack-dev | 10:09 | |
| *** buzztroll has quit IRC | 10:09 | |
| *** jprovazn has quit IRC | 10:10 | |
| *** yeylon__ has joined #openstack-dev | 10:10 | |
| *** yeylon_ has quit IRC | 10:10 | |
| *** sarob has joined #openstack-dev | 10:11 | |
| *** salv-orlando has joined #openstack-dev | 10:14 | |
| *** sarob has quit IRC | 10:16 | |
| *** Alexei_987 has joined #openstack-dev | 10:17 | |
| *** evgenyf has joined #openstack-dev | 10:19 | |
| *** yeylon__ has quit IRC | 10:20 | |
| *** ruhe has joined #openstack-dev | 10:21 | |
| *** martyntaylor has joined #openstack-dev | 10:25 | |
| *** martyntaylor1 has joined #openstack-dev | 10:25 | |
| *** max_lobur_afk is now known as max_lobur | 10:26 | |
| *** e0ne_ has quit IRC | 10:26 | |
| *** amuller has quit IRC | 10:28 | |
| *** martyntaylor has quit IRC | 10:29 | |
| *** mrda_away is now known as mrda | 10:31 | |
| *** salv-orlando has quit IRC | 10:31 | |
| *** rraja has quit IRC | 10:32 | |
| *** odyssey4me2 has joined #openstack-dev | 10:33 | |
| *** odyssey4me has quit IRC | 10:34 | |
| *** yeylon__ has joined #openstack-dev | 10:36 | |
| *** paragan has quit IRC | 10:36 | |
| *** fc__ has joined #openstack-dev | 10:37 | |
| *** odyssey4me2 has quit IRC | 10:38 | |
| *** thouveng has joined #openstack-dev | 10:41 | |
| *** buzztrol_ has quit IRC | 10:43 | |
| *** evgenyf has quit IRC | 10:44 | |
| *** jistr has quit IRC | 10:44 | |
| *** itzikb has quit IRC | 10:44 | |
| *** rraja has joined #openstack-dev | 10:50 | |
| *** evgenyf has joined #openstack-dev | 10:54 | |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 10:54 | |
| *** kushal has quit IRC | 10:55 | |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 10:57 | |
| *** AnilV4 has joined #openstack-dev | 10:57 | |
| *** jamespage_ has joined #openstack-dev | 10:58 | |
| *** jasondotstar has quit IRC | 11:00 | |
| *** yassine has quit IRC | 11:01 | |
| *** mrda is now known as mrda_away | 11:02 | |
| *** vartom1111111117 has quit IRC | 11:03 | |
| *** vartom1111111117 has joined #openstack-dev | 11:03 | |
| *** jruzicka has joined #openstack-dev | 11:06 | |
| *** sahid has quit IRC | 11:06 | |
| *** sahid has joined #openstack-dev | 11:07 | |
| *** buzztroll has joined #openstack-dev | 11:08 | |
| *** jistr has joined #openstack-dev | 11:10 | |
| *** CaptTofu has joined #openstack-dev | 11:10 | |
| *** RajeshMohan has quit IRC | 11:10 | |
| *** irenab has joined #openstack-dev | 11:10 | |
| *** RajeshMohan has joined #openstack-dev | 11:11 | |
| *** jprovazn has joined #openstack-dev | 11:11 | |
| mflobo | I need to modify this file nova/hacking/checks.py to add a new function | 11:12 |
| mflobo | anyone knows how to test a new function written on that file? | 11:12 |
| *** buzztroll has quit IRC | 11:12 | |
| *** tdruiva has quit IRC | 11:12 | |
| *** salv-orlando has joined #openstack-dev | 11:14 | |
| *** CaptTofu has quit IRC | 11:15 | |
| *** IzikPenso has joined #openstack-dev | 11:15 | |
| *** david-lyle has quit IRC | 11:17 | |
| *** boris-42_ has quit IRC | 11:18 | |
| *** amuller has joined #openstack-dev | 11:18 | |
| *** askb_ has quit IRC | 11:18 | |
| *** vkmc has joined #openstack-dev | 11:19 | |
| mflobo | this is my question https://ask.openstack.org/en/question/11411/what-is-novahackingcheckspy/ | 11:20 |
| *** andreaf has joined #openstack-dev | 11:22 | |
| *** hashfail has quit IRC | 11:23 | |
| *** hashfail has joined #openstack-dev | 11:24 | |
| *** coolsvap_away has joined #openstack-dev | 11:29 | |
| *** coolsvap has quit IRC | 11:30 | |
| *** salv-orlando has quit IRC | 11:30 | |
| *** amuller_ has joined #openstack-dev | 11:32 | |
| *** IzikPenso has quit IRC | 11:32 | |
| *** amuller has quit IRC | 11:32 | |
| *** martyntaylor1 has quit IRC | 11:33 | |
| *** rraja has quit IRC | 11:34 | |
| *** pcm_ has joined #openstack-dev | 11:41 | |
| *** salv-orlando has joined #openstack-dev | 11:43 | |
| *** tdruiva has joined #openstack-dev | 11:43 | |
| *** vkmc has quit IRC | 11:43 | |
| *** pcm_ has quit IRC | 11:43 | |
| *** martyntaylor has joined #openstack-dev | 11:44 | |
| *** pcm_ has joined #openstack-dev | 11:44 | |
| *** CaptTofu has joined #openstack-dev | 11:46 | |
| *** coolsvap_away is now known as coolsvap | 11:46 | |
| *** jp_at_hp has joined #openstack-dev | 11:46 | |
| *** salv-orlando has quit IRC | 11:49 | |
| *** jamespage_ has joined #openstack-dev | 11:49 | |
| *** rraja has joined #openstack-dev | 11:49 | |
| *** athomas has quit IRC | 11:50 | |
| *** jasondotstar has joined #openstack-dev | 11:50 | |
| *** jamespage_ has quit IRC | 11:51 | |
| *** athomas has joined #openstack-dev | 11:51 | |
| *** tdruiva has quit IRC | 11:51 | |
| *** DinaBelova is now known as DinaBelova_ | 11:52 | |
| *** safchain has quit IRC | 11:56 | |
| *** CaptTofu has quit IRC | 11:57 | |
| *** CaptTofu has joined #openstack-dev | 11:58 | |
| *** jnoller has joined #openstack-dev | 11:58 | |
| *** paragan has joined #openstack-dev | 12:00 | |
| *** baoli has joined #openstack-dev | 12:00 | |
| *** rkukura has quit IRC | 12:01 | |
| *** matrohon has quit IRC | 12:02 | |
| *** Anju has joined #openstack-dev | 12:02 | |
| Anju | hii adam_g : are u around ? | 12:03 |
| *** doug_shelley66 has joined #openstack-dev | 12:04 | |
| *** DinaBelova_ is now known as DinaBelova | 12:05 | |
| *** marcin___ has joined #openstack-dev | 12:05 | |
| *** jamespage_ has joined #openstack-dev | 12:07 | |
| *** buzztroll has joined #openstack-dev | 12:08 | |
| *** jamespage_ has quit IRC | 12:09 | |
| *** tkammer has quit IRC | 12:10 | |
| *** yassine has joined #openstack-dev | 12:13 | |
| *** buzztroll has quit IRC | 12:13 | |
| *** yassine_ has joined #openstack-dev | 12:13 | |
| *** relaxdiego has joined #openstack-dev | 12:13 | |
| *** jay-lau-513 has joined #openstack-dev | 12:14 | |
| *** yamahata has quit IRC | 12:14 | |
| *** asalkeld has joined #openstack-dev | 12:17 | |
| *** asalkeld has left #openstack-dev | 12:17 | |
| *** alexpilotti has joined #openstack-dev | 12:18 | |
| Anju | join #openstack-swift | 12:19 |
| *** gcha has quit IRC | 12:22 | |
| *** IanGovett has joined #openstack-dev | 12:25 | |
| *** enykeev has quit IRC | 12:25 | |
| *** aditirav has quit IRC | 12:26 | |
| *** jnoller has quit IRC | 12:26 | |
| *** enykeev has joined #openstack-dev | 12:26 | |
| *** jcooley_ has joined #openstack-dev | 12:26 | |
| *** CaptTofu has quit IRC | 12:28 | |
| *** e0ne has joined #openstack-dev | 12:29 | |
| *** boris-42_ has joined #openstack-dev | 12:30 | |
| *** jcooley_ has quit IRC | 12:31 | |
| *** rraja has quit IRC | 12:32 | |
| *** rfolco has joined #openstack-dev | 12:33 | |
| *** coolsvap has quit IRC | 12:34 | |
| *** coolsvap has joined #openstack-dev | 12:34 | |
| *** jamespage_ has joined #openstack-dev | 12:37 | |
| *** jamespage_ has quit IRC | 12:40 | |
| *** gcha has joined #openstack-dev | 12:40 | |
| *** baoli has quit IRC | 12:42 | |
| *** eglynn is now known as eglynn-lunch | 12:42 | |
| *** baoli has joined #openstack-dev | 12:42 | |
| *** romcheg has quit IRC | 12:43 | |
| *** relaxdiego has quit IRC | 12:45 | |
| *** igor has joined #openstack-dev | 12:45 | |
| *** igor_ has quit IRC | 12:46 | |
| *** Nikolay_St has quit IRC | 12:47 | |
| *** rdas has quit IRC | 12:49 | |
| *** FunnyLookinHat has joined #openstack-dev | 12:51 | |
| *** amuller_ has quit IRC | 12:51 | |
| *** sgordon has joined #openstack-dev | 12:54 | |
| *** coolsvap has quit IRC | 12:55 | |
| *** amuller_ has joined #openstack-dev | 12:55 | |
| *** yassine has quit IRC | 12:55 | |
| *** amuller_ is now known as amuller | 12:56 | |
| jd__ | markmc: are you taking a look on #1275771 on the Nova side? just wanted to know as I was planning to | 12:57 |
| *** CaptTofu has joined #openstack-dev | 12:57 | |
| *** omachace has quit IRC | 12:57 | |
| *** neeti has quit IRC | 12:58 | |
| *** artom has joined #openstack-dev | 12:58 | |
| *** marcin___ has quit IRC | 12:59 | |
| *** jasondotstar has quit IRC | 13:00 | |
| *** sushil_ has quit IRC | 13:01 | |
| *** CaptTofu has quit IRC | 13:01 | |
| *** evgenyf has quit IRC | 13:02 | |
| markmc | jd__, I started to, then got pulled away | 13:04 |
| markmc | jd__, hoping to get back to it ASAP, but if you get there first that'd be cool | 13:04 |
| jd__ | markmc: ok, I'll jump on it this afternoon | 13:05 |
| markmc | jd__, great | 13:05 |
| markmc | jd__, could be in e.g. oslo.messaging.notifier if e.g. we forget to pass the context through the serializer | 13:05 |
| jd__ | yup | 13:06 |
| jd__ | I'm also trying to add more tests in oslo.messaging to clarify that and maybe remove the hack | 13:06 |
| *** mriedem has joined #openstack-dev | 13:07 | |
| *** evgenyf has joined #openstack-dev | 13:07 | |
| *** buzztroll has joined #openstack-dev | 13:08 | |
| *** prad_ has joined #openstack-dev | 13:08 | |
| *** safchain has joined #openstack-dev | 13:09 | |
| *** safchain has quit IRC | 13:09 | |
| *** safchain has joined #openstack-dev | 13:10 | |
| *** rkukura has joined #openstack-dev | 13:10 | |
| *** cnesa has joined #openstack-dev | 13:10 | |
| *** tdruiva has joined #openstack-dev | 13:12 | |
| *** gcha has quit IRC | 13:12 | |
| *** buzztroll has quit IRC | 13:12 | |
| *** bswartz has quit IRC | 13:14 | |
| *** romcheg has joined #openstack-dev | 13:15 | |
| *** iartarisi has quit IRC | 13:15 | |
| *** gmoro has quit IRC | 13:15 | |
| *** iartarisi has joined #openstack-dev | 13:16 | |
| *** max_lobur is now known as max_lobur_afk | 13:17 | |
| *** jasondotstar has joined #openstack-dev | 13:19 | |
| markmc | jd__, yep, the hack is removable by e.g. having pack_context() not call to_dict() | 13:20 |
| markmc | jd__, only reason I didn't do that was to limit the changes to the driver until Nova was using oslo.messaging in the gate | 13:21 |
| jd__ | markmc: fair enough | 13:21 |
| *** aveiga has joined #openstack-dev | 13:21 | |
| jd__ | I'm rewriting my patch in that sense exactly, removing to_dict() in pack_context() :) | 13:21 |
| markmc | cool | 13:22 |
| *** topol has joined #openstack-dev | 13:27 | |
| *** lpr has joined #openstack-dev | 13:27 | |
| *** max_lobur_afk is now known as max_lobur | 13:29 | |
| *** glenng has joined #openstack-dev | 13:30 | |
| *** rraja has joined #openstack-dev | 13:31 | |
| *** topol has quit IRC | 13:31 | |
| *** glenng1 has joined #openstack-dev | 13:31 | |
| *** jruzicka has quit IRC | 13:32 | |
| *** lpr is now known as parthipan | 13:33 | |
| *** glenng has quit IRC | 13:34 | |
| *** tkammer has joined #openstack-dev | 13:35 | |
| *** parthipan has quit IRC | 13:35 | |
| *** gcha has joined #openstack-dev | 13:35 | |
| *** Ursinha-afk has joined #openstack-dev | 13:36 | |
| *** gordc has joined #openstack-dev | 13:36 | |
| *** vladikr has joined #openstack-dev | 13:36 | |
| *** sahid has quit IRC | 13:38 | |
| *** rohitk has quit IRC | 13:38 | |
| *** prad_ has quit IRC | 13:38 | |
| *** vkmc has joined #openstack-dev | 13:38 | |
| *** sahid has joined #openstack-dev | 13:39 | |
| *** cnesa2 has joined #openstack-dev | 13:39 | |
| *** cnesa has quit IRC | 13:40 | |
| *** cnesa has joined #openstack-dev | 13:41 | |
| *** Tross has quit IRC | 13:42 | |
| *** galstrom_zzz is now known as galstrom | 13:43 | |
| *** cnesa2 has quit IRC | 13:44 | |
| *** tdruiva has quit IRC | 13:45 | |
| jd__ | markmc: well that was easy enough to fix, the nova's notifier instance totally lacks the request serializer, it has been forgotten in the arg list :) | 13:46 |
| jd__ | now the hard part, write a unit test | 13:46 |
| markmc | jd__, ah, schweet :) | 13:46 |
| shardy | @requirements-core, anyone able to take a look at: | 13:46 |
| shardy | https://review.openstack.org/#/c/70929/ | 13:46 |
| *** irenab has quit IRC | 13:46 | |
| shardy | we need that version bump for Heat please :) | 13:46 |
| *** browne has joined #openstack-dev | 13:47 | |
| *** milki has quit IRC | 13:48 | |
| *** milki has joined #openstack-dev | 13:48 | |
| *** lparth has joined #openstack-dev | 13:49 | |
| *** bswartz has joined #openstack-dev | 13:49 | |
| *** jdob has joined #openstack-dev | 13:49 | |
| *** thomasem has joined #openstack-dev | 13:49 | |
| *** doug_shelley66 has quit IRC | 13:50 | |
| *** otherwiseguy has joined #openstack-dev | 13:51 | |
| *** e0ne_ has joined #openstack-dev | 13:51 | |
| *** tsekiyama has joined #openstack-dev | 13:51 | |
| *** Ursinha has quit IRC | 13:52 | |
| *** Ursinha-afk is now known as Ursinha | 13:52 | |
| *** Ursinha has joined #openstack-dev | 13:52 | |
| *** galstrom is now known as galstrom_zzz | 13:52 | |
| *** rohitk has joined #openstack-dev | 13:52 | |
| *** tsekiyama has quit IRC | 13:52 | |
| *** e0ne has quit IRC | 13:54 | |
| *** bswartz has quit IRC | 13:55 | |
| *** rraja has quit IRC | 13:56 | |
| *** dprince has joined #openstack-dev | 13:56 | |
| *** jcooley_ has joined #openstack-dev | 13:57 | |
| *** cnesa has quit IRC | 13:58 | |
| *** cnesa has joined #openstack-dev | 13:59 | |
| *** vartom1111111117 has quit IRC | 13:59 | |
| *** dvarga has joined #openstack-dev | 14:00 | |
| *** belmoreira has joined #openstack-dev | 14:00 | |
| *** dkranz has joined #openstack-dev | 14:00 | |
| *** sushil_ has joined #openstack-dev | 14:01 | |
| bknudson | @requirements-core and keystone | 14:01 |
| shardy | bknudson: yup, thanks | 14:02 |
| *** tdruiva has joined #openstack-dev | 14:03 | |
| *** jcooley_ has quit IRC | 14:03 | |
| *** bknudson has quit IRC | 14:03 | |
| *** gmoro has joined #openstack-dev | 14:04 | |
| *** rbrady has joined #openstack-dev | 14:05 | |
| *** sushil_ has quit IRC | 14:05 | |
| *** cnesa has quit IRC | 14:06 | |
| *** rbrady is now known as rbrady-brb | 14:07 | |
| *** sushil_ has joined #openstack-dev | 14:07 | |
| *** jamespage_ has joined #openstack-dev | 14:07 | |
| *** buzztroll has joined #openstack-dev | 14:08 | |
| *** dstanek has joined #openstack-dev | 14:09 | |
| *** cnesa has joined #openstack-dev | 14:10 | |
| *** rohitk has quit IRC | 14:10 | |
| *** dvarga is now known as dvarga|away | 14:11 | |
| *** dvarga|away is now known as dvarga | 14:12 | |
| *** edmund has joined #openstack-dev | 14:12 | |
| *** kolesovdv has quit IRC | 14:12 | |
| *** buzztroll has quit IRC | 14:12 | |
| *** tmclaugh[work] has joined #openstack-dev | 14:13 | |
| *** jruzicka has joined #openstack-dev | 14:13 | |
| *** crank has quit IRC | 14:14 | |
| *** yamahata has joined #openstack-dev | 14:15 | |
| *** RajeshMohan has quit IRC | 14:15 | |
| *** Ursinha has quit IRC | 14:15 | |
| *** RajeshMohan has joined #openstack-dev | 14:16 | |
| *** Ursinha-afk has joined #openstack-dev | 14:16 | |
| *** Ursinha-afk is now known as Ursinha | 14:17 | |
| *** Ursinha has quit IRC | 14:17 | |
| *** Ursinha has joined #openstack-dev | 14:17 | |
| *** rbrady-brb is now known as rbrady | 14:17 | |
| *** yamahata has quit IRC | 14:22 | |
| *** bknudson has joined #openstack-dev | 14:22 | |
| *** belmoreira has quit IRC | 14:22 | |
| *** belmoreira has joined #openstack-dev | 14:23 | |
| *** yamahata has joined #openstack-dev | 14:23 | |
| *** neelashah has joined #openstack-dev | 14:24 | |
| *** eharney has joined #openstack-dev | 14:24 | |
| *** xga has joined #openstack-dev | 14:24 | |
| *** belmoreira1 has joined #openstack-dev | 14:25 | |
| *** yamahata has quit IRC | 14:25 | |
| *** yamahata has joined #openstack-dev | 14:25 | |
| *** hdd_ has joined #openstack-dev | 14:27 | |
| *** JoshuaG_AIM has joined #openstack-dev | 14:27 | |
| *** ewindisch has joined #openstack-dev | 14:27 | |
| *** belmoreira has quit IRC | 14:27 | |
| gilliard | is it possible to test oslo-incubator using tun_tests.sh | 14:30 |
| gilliard | ? | 14:30 |
| *** bauzas has joined #openstack-dev | 14:30 | |
| gilliard | I get ImportError: No module named openstack.common.db every time I try. Colleague has the same problem. | 14:31 |
| *** prad_ has joined #openstack-dev | 14:31 | |
| *** edmund has quit IRC | 14:32 | |
| *** prad_ has quit IRC | 14:32 | |
| jd__ | gilliard: just use tox | 14:34 |
| *** mkollaro has joined #openstack-dev | 14:34 | |
| gilliard | jd__: thanks - I'm just trying to remember the syntax for tox. Is run_tests broken then? | 14:34 |
| *** toanster_ is now known as toanster | 14:35 | |
| *** thomasem_ has joined #openstack-dev | 14:35 | |
| *** edmund has joined #openstack-dev | 14:35 | |
| *** IanGovett has quit IRC | 14:35 | |
| jd__ | gilliard: I don't know, just type 'tox' :) | 14:36 |
| jd__ | I don't use run_tests | 14:36 |
| *** achampion has joined #openstack-dev | 14:37 | |
| dstanek | gilliard: sounds like a pythonpath issue - i always use tox now on openstack projects | 14:37 |
| *** joesavak has joined #openstack-dev | 14:37 | |
| *** thomasem has quit IRC | 14:38 | |
| *** dims has quit IRC | 14:38 | |
| dhellmann_ | shardy, bknudson : +2 A | 14:38 |
| *** xgsa has quit IRC | 14:39 | |
| dhellmann_ | gilliard: you can run "tox -e py27" if you only want the tests for python 2.7, but "tox" by itself will also run style checks for you | 14:39 |
| *** jamieh has joined #openstack-dev | 14:39 | |
| dhellmann_ | and python 3, if you have it installed | 14:39 |
| jamieh | does glance have a dedicated irc channel? | 14:39 |
| *** jpomero has joined #openstack-dev | 14:40 | |
| jamieh | nm, found it | 14:40 |
| dhellmann_ | jamieh: yep: https://wiki.openstack.org/wiki/IRC | 14:40 |
| *** jecarey has joined #openstack-dev | 14:40 | |
| *** xgsa has joined #openstack-dev | 14:42 | |
| *** pschaef has joined #openstack-dev | 14:42 | |
| *** burt1 has joined #openstack-dev | 14:43 | |
| *** sandywalsh has joined #openstack-dev | 14:43 | |
| gilliard | dhellmann_, jd__, dstanek: FYI seems not to work with tox 1.7.0 - I had to install 1.6.1 | 14:44 |
| *** peristeri has joined #openstack-dev | 14:44 | |
| gilliard | This problem: https://bitbucket.org/hpk42/tox/issue/150/posargs-configerror | 14:44 |
| dhellmann_ | gilliard: yeah, holger made a backwards-incompatible change to the way the ini file works in 1.7 and we haven't updated openstack projects to work with it, yet | 14:44 |
| *** dhellmann_ is now known as dhellmann | 14:44 | |
| *** dims has joined #openstack-dev | 14:44 | |
| *** adreznec has joined #openstack-dev | 14:44 | |
| *** sgran has joined #openstack-dev | 14:44 | |
| *** changbl has quit IRC | 14:45 | |
| *** tongli has joined #openstack-dev | 14:46 | |
| gilliard | dhellmann: is this documented anywhere? I could add it to the wiki if required. | 14:46 |
| *** lbragstad has quit IRC | 14:46 | |
| dhellmann | gilliard: great question, I'm not sure -- sdague ^^ | 14:47 |
| jd__ | I'm not sure we want to document bug, fixing them sounds better :) | 14:49 |
| shardy | dhellmann_: thanks! | 14:51 |
| dhellmann | jd__: +1 | 14:51 |
| *** doug_shelley66 has joined #openstack-dev | 14:52 | |
| *** dperaza has joined #openstack-dev | 14:52 | |
| *** kbrierly has quit IRC | 14:53 | |
| *** jayg|g0n3 is now known as jayg | 14:54 | |
| *** jamespage_ has quit IRC | 14:54 | |
| *** blamar has joined #openstack-dev | 14:55 | |
| *** eglynn-lunch is now known as eglynn | 14:55 | |
| *** kbrierly has joined #openstack-dev | 14:55 | |
| *** zackf has joined #openstack-dev | 14:55 | |
| *** dsirrine has joined #openstack-dev | 14:55 | |
| *** angdraug has joined #openstack-dev | 14:56 | |
| *** bswartz has joined #openstack-dev | 14:58 | |
| *** tsekiyama has joined #openstack-dev | 14:59 | |
| *** belmoreira1 has quit IRC | 15:00 | |
| *** artom has quit IRC | 15:00 | |
| *** zackf has quit IRC | 15:00 | |
| *** crank has joined #openstack-dev | 15:00 | |
| *** csaba|afk is now known as csaba | 15:02 | |
| *** belmoreira has joined #openstack-dev | 15:02 | |
| *** boris-42_ has quit IRC | 15:02 | |
| *** amotoki has quit IRC | 15:02 | |
| *** stevemar has joined #openstack-dev | 15:04 | |
| *** sahid has quit IRC | 15:07 | |
| *** jswarren has joined #openstack-dev | 15:07 | |
| *** sahid has joined #openstack-dev | 15:07 | |
| *** zackf has joined #openstack-dev | 15:08 | |
| *** buzztroll has joined #openstack-dev | 15:08 | |
| *** alex_klimov has quit IRC | 15:08 | |
| *** prad_ has joined #openstack-dev | 15:08 | |
| *** mestery has joined #openstack-dev | 15:09 | |
| *** Gordonz has joined #openstack-dev | 15:10 | |
| viktors | dhellmann: hi | 15:10 |
| *** kenperkins has joined #openstack-dev | 15:11 | |
| *** dbalog has joined #openstack-dev | 15:11 | |
| *** jamieh has quit IRC | 15:11 | |
| *** jpich has quit IRC | 15:12 | |
| *** buzztroll has quit IRC | 15:13 | |
| *** Gordonz has quit IRC | 15:13 | |
| *** Gordonz has joined #openstack-dev | 15:14 | |
| *** jamieh has joined #openstack-dev | 15:14 | |
| *** IanGovett has joined #openstack-dev | 15:14 | |
| *** jpich has joined #openstack-dev | 15:15 | |
| *** gmoro has quit IRC | 15:15 | |
| *** IanGovett1 has joined #openstack-dev | 15:16 | |
| *** lbragstad has joined #openstack-dev | 15:16 | |
| *** krotscheck has joined #openstack-dev | 15:16 | |
| *** belmoreira has quit IRC | 15:16 | |
| *** FunnyLookinHat has quit IRC | 15:16 | |
| *** knuppe has joined #openstack-dev | 15:17 | |
| *** matsuhas_ has quit IRC | 15:17 | |
| *** vijendar has joined #openstack-dev | 15:17 | |
| *** pmathews has joined #openstack-dev | 15:18 | |
| *** rcleere has joined #openstack-dev | 15:18 | |
| *** glenng1 has quit IRC | 15:19 | |
| *** belmoreira has joined #openstack-dev | 15:19 | |
| *** mfer has joined #openstack-dev | 15:19 | |
| *** IanGovett has quit IRC | 15:19 | |
| *** glenng has joined #openstack-dev | 15:19 | |
| *** matrohon has joined #openstack-dev | 15:20 | |
| *** Guest18735 is now known as mfisch | 15:20 | |
| *** mfisch is now known as Guest93890 | 15:20 | |
| *** mestery has quit IRC | 15:20 | |
| *** markmc has quit IRC | 15:20 | |
| *** nosnos has quit IRC | 15:21 | |
| *** sahid has quit IRC | 15:21 | |
| *** mestery has joined #openstack-dev | 15:21 | |
| *** zzelle has joined #openstack-dev | 15:21 | |
| *** kevinconway has joined #openstack-dev | 15:22 | |
| knuppe | Is there some quota in nova to check for usage of "root_gb"? | 15:23 |
| *** mrodden has joined #openstack-dev | 15:23 | |
| *** adreznec has quit IRC | 15:24 | |
| *** tiamar has joined #openstack-dev | 15:25 | |
| *** sergmelikyan has joined #openstack-dev | 15:25 | |
| *** nshaikh has left #openstack-dev | 15:26 | |
| *** romcheg has quit IRC | 15:27 | |
| *** sahid has joined #openstack-dev | 15:27 | |
| *** jnoller has joined #openstack-dev | 15:27 | |
| *** sweston has joined #openstack-dev | 15:28 | |
| *** xga has quit IRC | 15:29 | |
| *** xga has joined #openstack-dev | 15:30 | |
| *** xga__ has joined #openstack-dev | 15:30 | |
| *** jnoller_ has joined #openstack-dev | 15:30 | |
| *** mikeoutland has joined #openstack-dev | 15:30 | |
| *** xga_ has quit IRC | 15:30 | |
| *** romcheg has joined #openstack-dev | 15:30 | |
| *** tmclaugh[work] has quit IRC | 15:32 | |
| *** xarses has quit IRC | 15:32 | |
| *** spzala has joined #openstack-dev | 15:33 | |
| *** jnoller has quit IRC | 15:33 | |
| *** aveiga has quit IRC | 15:35 | |
| *** adreznec has joined #openstack-dev | 15:35 | |
| *** david-lyle has joined #openstack-dev | 15:36 | |
| *** jgrimm has joined #openstack-dev | 15:36 | |
| *** Gordonz has quit IRC | 15:36 | |
| *** atiwari has joined #openstack-dev | 15:36 | |
| *** david_lyle_ has joined #openstack-dev | 15:39 | |
| *** aditirav has joined #openstack-dev | 15:39 | |
| *** tanisdl has joined #openstack-dev | 15:40 | |
| *** ifarkas_ has joined #openstack-dev | 15:40 | |
| *** jgrimm has quit IRC | 15:41 | |
| *** ifarkas__ has joined #openstack-dev | 15:41 | |
| *** ijw has joined #openstack-dev | 15:42 | |
| *** BLZbubba has quit IRC | 15:42 | |
| *** BLZbubba has joined #openstack-dev | 15:42 | |
| marekd | stevemar: ping | 15:42 |
| *** david-lyle has quit IRC | 15:43 | |
| *** ifarkas has quit IRC | 15:43 | |
| *** ifarkas has joined #openstack-dev | 15:43 | |
| *** galstrom_zzz is now known as galstrom | 15:43 | |
| *** romcheg has quit IRC | 15:44 | |
| *** jay-lau-513 has quit IRC | 15:45 | |
| stevemar | marekd, pong | 15:45 |
| *** pradeep has quit IRC | 15:46 | |
| *** jcooley_ has joined #openstack-dev | 15:46 | |
| *** mestery has quit IRC | 15:47 | |
| *** mrodden has quit IRC | 15:47 | |
| marekd | stevemar: speaking about generating the 'user' entity in the mapping engine... | 15:48 |
| *** jistr has quit IRC | 15:48 | |
| marekd | stevemar: I think we will need to add a attribute to the protocol, and later just use that attribute to create idp unique username | 15:48 |
| *** ijw has quit IRC | 15:48 | |
| jamieh | does anybody know whether json-schema will creep into any more openstack services apart from glance? | 15:49 |
| *** ijw has joined #openstack-dev | 15:49 | |
| marekd | because different idp send different assertions, and there is no fixed attribute that identifies the federated username | 15:49 |
| *** ifarkas has quit IRC | 15:49 | |
| marekd | stevemar: this would also make your work easy | 15:49 |
| *** ifarkas__ has quit IRC | 15:49 | |
| *** xga_ has joined #openstack-dev | 15:50 | |
| *** xga__ has quit IRC | 15:50 | |
| *** xga has quit IRC | 15:50 | |
| *** PaulMurray has joined #openstack-dev | 15:50 | |
| *** xga has joined #openstack-dev | 15:50 | |
| *** romcheg has joined #openstack-dev | 15:51 | |
| *** florentflament_ has joined #openstack-dev | 15:52 | |
| *** gmoro has joined #openstack-dev | 15:52 | |
| *** florentflament_ has quit IRC | 15:52 | |
| ayoung-ZzZzzZZzz | jamieh, we are sneaking it into Keystone. Is this a good thing or a bad thing? | 15:52 |
| *** xga_ has quit IRC | 15:52 | |
| *** sweston has quit IRC | 15:52 | |
| *** xga has quit IRC | 15:52 | |
| *** tmclaugh[work] has joined #openstack-dev | 15:52 | |
| *** ayoung-ZzZzzZZzz is now known as ayoung | 15:52 | |
| *** xga_ has joined #openstack-dev | 15:52 | |
| *** xga has joined #openstack-dev | 15:52 | |
| *** jcooley_ has quit IRC | 15:53 | |
| jamieh | good thing - i like what glance is doing | 15:53 |
| jamieh | i.e. leveraging JSON PATCH | 15:53 |
| *** artom has joined #openstack-dev | 15:53 | |
| stevemar | marekd, you mean specify the SAML attribute that will have the username in the config file? | 15:54 |
| *** jistr has joined #openstack-dev | 15:54 | |
| *** shakayumi has joined #openstack-dev | 15:54 | |
| *** akrivoka has quit IRC | 15:55 | |
| *** akrivoka has joined #openstack-dev | 15:55 | |
| marekd | stevemar: no, in the FederationProtocolModel. | 15:55 |
| marekd | because that attribute is actually idp or even idp-protocol specific. | 15:55 |
| stevemar | marekd, ah okay | 15:55 |
| marekd | CERN idp can use attribute ADFS_LOGIN, IBM can use SAML_EMAIL | 15:56 |
| stevemar | marekd, yeah, good point | 15:56 |
| marekd | so if you were thinking about some super hacks I think there is an easier way :-) | 15:57 |
| *** AlexF has joined #openstack-dev | 15:57 | |
| *** bauzas has quit IRC | 15:58 | |
| *** adreznec has quit IRC | 15:59 | |
| stevemar | marekd, did you get a chance to read brants comments on https://review.openstack.org/#/c/67645/ ? | 15:59 |
| stevemar | do you have an opinion on the class name or whether we should just initialize it with mapping['rules'] ? | 16:00 |
| *** mrodden has joined #openstack-dev | 16:01 | |
| *** Ruetobas has quit IRC | 16:01 | |
| *** zackf has quit IRC | 16:02 | |
| *** markmc has joined #openstack-dev | 16:02 | |
| *** max_lobur is now known as max_lobur_afk | 16:02 | |
| PaulMurray | russellb: ping | 16:03 |
| *** Ruetobas has joined #openstack-dev | 16:03 | |
| marekd | stevemar: i haven't read it yet. | 16:03 |
| marekd | stevemar: looking. | 16:03 |
| *** nmagnezi has quit IRC | 16:03 | |
| *** zackf has joined #openstack-dev | 16:03 | |
| *** bhuvan has quit IRC | 16:04 | |
| stevemar | marekd, thx | 16:04 |
| *** doug_shelley66 has quit IRC | 16:04 | |
| *** paragan has quit IRC | 16:05 | |
| *** doug_shelley66 has joined #openstack-dev | 16:06 | |
| *** FunnyLookinHat has joined #openstack-dev | 16:06 | |
| *** carl_baldwin has joined #openstack-dev | 16:06 | |
| *** Drankis has quit IRC | 16:06 | |
| *** jpich has quit IRC | 16:07 | |
| *** buzztroll has joined #openstack-dev | 16:08 | |
| *** Ruetobas has quit IRC | 16:08 | |
| marekd | stevemar: are you referring to any brant's specific comment? | 16:08 |
| *** hdd_ has quit IRC | 16:09 | |
| jgriffith | ttx: Did you mention that the ProphetStore folks were talking to you about their driver BP? | 16:09 |
| jgriffith | ttx: I would like to kick out everything that is "not started" at this point | 16:09 |
| jgriffith | ttx: and especially drivers from vendors I've never seend or heard from before | 16:10 |
| *** Shaan7 has joined #openstack-dev | 16:10 | |
| stevemar | marekd, his 1st and 4th | 16:10 |
| *** Shaan7 has quit IRC | 16:10 | |
| *** Shaan7 has joined #openstack-dev | 16:10 | |
| *** caleb_ has joined #openstack-dev | 16:10 | |
| bnemec | dhellmann: Could you take another look at https://review.openstack.org/#/c/67093/ ? You were +2 before the rebase, and it would be nice to get that in so we can fix the Nova unit tests on recent sqlite without adding workarounds. | 16:12 |
| *** andreaf2 has joined #openstack-dev | 16:12 | |
| *** jaypipes has quit IRC | 16:12 | |
| *** tzabal has joined #openstack-dev | 16:12 | |
| dhellmann | bnemec: looking now | 16:12 |
| *** andreaf has quit IRC | 16:12 | |
| bnemec | dhellmann: Thanks | 16:12 |
| dhellmann | bnemec: have you come up with a good name for oslo.sphinx yet? I'd like to try to slip that into the renaming we do tomorrow to avoid having to wait for another window | 16:13 |
| *** buzztroll has quit IRC | 16:13 | |
| marekd | stevemar: I am fine with name change. Do you now expect mapping_ref to be a DB entity with to_dict() applied on that? | 16:13 |
| *** jmontemayor has joined #openstack-dev | 16:13 | |
| *** Ruetobas has joined #openstack-dev | 16:14 | |
| *** jmontemayor has quit IRC | 16:14 | |
| *** shakayumi has quit IRC | 16:14 | |
| *** jmontemayor has joined #openstack-dev | 16:15 | |
| *** adreznec has joined #openstack-dev | 16:15 | |
| *** boris-42_ has joined #openstack-dev | 16:15 | |
| *** thuc has joined #openstack-dev | 16:15 | |
| *** jpich has joined #openstack-dev | 16:15 | |
| bnemec | dhellmann: Nothing great. The only other thought I had was calling it something like oslobuild.sphinx, but since dstufft suggested we stay away from namespace packages I'm leaning toward just calling it oslosphinx. | 16:15 |
| bnemec | I'd be good with openstacksphinx too, but based on the trademark discussion I've seen lately I'm wondering if we'd have to ask for permission to name it that. | 16:16 |
| dhellmann | bnemec: yeah, if it is standalone it doesn't really need a namespace package anyway | 16:16 |
| dhellmann | oh, good point | 16:16 |
| dhellmann | oslosphinx it is! | 16:16 |
| bnemec | +1 | 16:16 |
| *** thuc_ has joined #openstack-dev | 16:16 | |
| dhellmann | I'll file the change request for -infra | 16:16 |
| *** mlavalle has joined #openstack-dev | 16:16 | |
| dhellmann | we can fix up the packaging in the repo after | 16:17 |
| bnemec | dhellmann: Cool. Let me know if/when I can help out. | 16:17 |
| dhellmann | bnemec: I'll add you to the review on the infra patch | 16:17 |
| *** salv-orlando has joined #openstack-dev | 16:18 | |
| *** mestery has joined #openstack-dev | 16:18 | |
| bnemec | Sounds good. | 16:18 |
| *** vkmc has quit IRC | 16:18 | |
| *** dklyle has joined #openstack-dev | 16:19 | |
| *** jp_at_hp has quit IRC | 16:19 | |
| *** csaba is now known as csaba|afk | 16:19 | |
| stevemar | marekd, preferably yes | 16:19 |
| *** corXi has quit IRC | 16:20 | |
| marekd | stevemar: why? | 16:20 |
| *** thuc has quit IRC | 16:20 | |
| bknudson | only DB code should be dealing with DB entities. | 16:20 |
| marekd | bknudson: ++ | 16:20 |
| stevemar | marekd, easier to test tbh | 16:20 |
| bknudson | code outside of db backend shouldn't know about them | 16:20 |
| marekd | stevemar: bknudson: plus like i said in the comment - AssertionProcessor only cares about the rules, why pass anything more than required. | 16:21 |
| *** blentz has quit IRC | 16:21 | |
| *** blentz has joined #openstack-dev | 16:22 | |
| *** david_lyle_ has quit IRC | 16:22 | |
| stevemar | bknudson, marekd then i'll change it to RuleProcessor and send in only the rules | 16:23 |
| *** jprovazn is now known as jprovazn_afk | 16:23 | |
| marekd | stevemar: sounds good. | 16:23 |
| bknudson | stevemar: I'm not too picky about the name. I like passing in only the rules. | 16:24 |
| *** mikeoutland has quit IRC | 16:24 | |
| dhellmann | bnemec: I'm not finding a bug report for the oslo.sphinx issue, do you remember if there was one? | 16:24 |
| bknudson | stevemar: you could have a separate factory function that takes a mapping_ref and extracts the roles if that makes things easier. | 16:25 |
| bknudson | but why make the tests more complicated and have to wrap the rules. | 16:25 |
| *** byeager has joined #openstack-dev | 16:25 | |
| marekd | bknudson: i'd say the right place for that is somewhere in the controller.... | 16:25 |
| bknudson | marekd: right, let the controller deal with representation issues. | 16:25 |
| *** salv-orlando has quit IRC | 16:26 | |
| ttx | jgriffith: no, that was the Nimble folks | 16:26 |
| bnemec | dhellmann: I don't think I ever actually opened one, so I'm not sure there is. I didn't reference one in the devstack change I proposed so there probably isn't. | 16:27 |
| dhellmann | bnemec: ok | 16:27 |
| ttx | jgriffith: I asked them to post code and set "needs code review" | 16:27 |
| *** cagrev has joined #openstack-dev | 16:27 | |
| *** artom has left #openstack-dev | 16:28 | |
| *** xarses has joined #openstack-dev | 16:28 | |
| dhellmann | bnemec: looking at the repo, we may be able to change the package name without renaming the git repository | 16:28 |
| dstanek | ayoung, bknudson, dolphm: do we still want to test older versions of keystoneclient against keystone? | 16:28 |
| *** chris_johnson has joined #openstack-dev | 16:28 | |
| bknudson | dstanek: it has caught legitimate issues in the past. | 16:28 |
| bnemec | dhellmann: infra would probably appreciate that :-) | 16:29 |
| bknudson | dstanek: if we had complete scenario testing in tempest then I would say we don't need to do any keystoneclient testing in keystone, but that's not the case. | 16:29 |
| dstanek | bknudson: i ask because i think this will make that harder https://review.openstack.org/#/c/71455/ | 16:29 |
| *** jcooley_ has joined #openstack-dev | 16:30 | |
| dstanek | bknudson: i think that is something we should absolutely do, but then i think we need to rethink our client testing strategy | 16:30 |
| bknudson | dstanek: if something isn't supported with the older client then it shouldn't be tested with the older client. | 16:30 |
| *** galstrom is now known as galstrom_zzz | 16:30 | |
| *** L33 has quit IRC | 16:31 | |
| *** xga__ has joined #openstack-dev | 16:31 | |
| *** L33 has joined #openstack-dev | 16:31 | |
| dstanek | bknudson: it's not that simple - the server may depend on new functionality that isn't in older clients | 16:32 |
| *** xga has quit IRC | 16:32 | |
| *** gszasz has quit IRC | 16:32 | |
| bknudson | dstanek: maybe it's more work to have keystoneclient tests in keystone than it is to implement adequate testing in tempest. | 16:32 |
| *** xga_ has quit IRC | 16:32 | |
| dstanek | bknudson: i thought they didn't want client tests in there | 16:32 |
| *** buzztroll has joined #openstack-dev | 16:32 | |
| *** pradeep has joined #openstack-dev | 16:32 | |
| *** bauzas has joined #openstack-dev | 16:33 | |
| bknudson | dstanek: they do have client tests, but they're not what ours look like. | 16:33 |
| bknudson | dstanek: so I think they'd accept client tests that look the way they want... | 16:33 |
| *** salv-orlando has joined #openstack-dev | 16:34 | |
| *** ek6 has joined #openstack-dev | 16:34 | |
| bknudson | dstanek: their tests are scenarios that so tend to use several apis. | 16:35 |
| bknudson | dstanek: for example, maybe a test that gets a trust and does something with it. | 16:35 |
| bknudson | or it could be something that exercises typical operator usage of keystone... creating users and deleting them and stuff. | 16:36 |
| *** bhuvan has joined #openstack-dev | 16:36 | |
| *** xga has joined #openstack-dev | 16:36 | |
| dstanek | bknudson: but they only test using master right? | 16:36 |
| bknudson | dstanek: I believe they added support for different versions for us. | 16:37 |
| *** dklyle is now known as david-lyle | 16:37 | |
| jgriffith | ttx: ok, neither has happened so I updated comments and pushed it out to "future/next" | 16:37 |
| jgriffith | ttx: will change if they contact me with code | 16:37 |
| ttx | ok | 16:38 |
| jgriffith | ttx: the first one anyway, the second they updated to "good progress" so they've got another week | 16:38 |
| *** max_lobur_afk is now known as max_lobur | 16:38 | |
| dhellmann | bnemec: fungi recommends changing the git repo, too, but we can go ahead and publish a release of the new lib from the current repo today | 16:39 |
| bnemec | dhellmann: Sounds good. | 16:40 |
| *** dvarga is now known as dvarga|away | 16:40 | |
| *** dvarga|away is now known as dvarga | 16:40 | |
| *** galstrom_zzz is now known as galstrom | 16:40 | |
| *** pablosan has quit IRC | 16:41 | |
| dstanek | bknudson: i'm going to mark my client tests patch as work in progress and look into tempest later | 16:41 |
| ayoung | dstanek, yes we do, but not inside the keystone code repo | 16:41 |
| dstanek | ayoung: i'm stil a little worried about this https://review.openstack.org/#/c/71455/1/keystone/token/providers/pki.py | 16:41 |
| ayoung | it puts us in a difficult position during code freeze: we are allowed to make changes to the client, but then can't test them | 16:41 |
| ayoung | dstanek, the environment hting? | 16:41 |
| *** pablosan has joined #openstack-dev | 16:41 | |
| *** sdake has quit IRC | 16:41 | |
| ayoung | seee my convo with jamielennox from last night | 16:41 |
| dstanek | ayoung: yes, the client code you linked to doesn't override the imported module in sys.modules so i don't know how you'd get the correct version | 16:42 |
| ayoung | http://eavesdrop.openstack.org/irclogs/%23openstack-dev/%23openstack-dev.2014-02-06.log dstanek search for environment | 16:42 |
| jgriffith | ping flaper87 | 16:42 |
| *** gszasz has joined #openstack-dev | 16:42 | |
| flaper87 | jgriffith: pong | 16:42 |
| jgriffith | flaper87: howdy... | 16:43 |
| ayoung | dstanek, it is fairly well tested to get the evenlet version | 16:43 |
| jgriffith | flaper87: you still planning on https://blueprints.launchpad.net/cinder/+spec/oslo-messaging | 16:43 |
| jgriffith | flaper87: I have some concerns | 16:43 |
| flaper87 | jgriffith: I'm almost done | 16:43 |
| jgriffith | flaper87: Ok :) | 16:43 |
| flaper87 | jgriffith: actually, It should be ready | 16:43 |
| dstanek | ayoung: what's well tested? | 16:43 |
| flaper87 | jgriffith: but there are some tests that magically deadlock | 16:43 |
| jgriffith | flaper87: what about the issue it introduced in Nova? | 16:43 |
| jgriffith | flaper87: the logging stuff? | 16:43 |
| ayoung | dstanek, it is in every eventlet based OpenStack service out there | 16:43 |
| flaper87 | jgriffith: because of some random monkey_patches | 16:43 |
| jgriffith | flaper87: I can grab a link if you don't know what I'm talking about | 16:43 |
| flaper87 | jgriffith: oh mmh, yeah please | 16:44 |
| jgriffith | flaper87: stand by | 16:44 |
| ayoung | there was a bug where the monkeypatching wasn';t happening, which is why we have that "ensure" code | 16:44 |
| * flaper87 stands by | 16:44 | |
| *** mestery has quit IRC | 16:44 | |
| *** bvandenh has quit IRC | 16:44 | |
| jgriffith | flaper87: http://openstack.10931.n7.nabble.com/nova-massive-number-of-new-errors-in-logs-with-oslo-messaging-td31046.html | 16:44 |
| dstanek | ayoung: that method will pick the right version of subprocess and use it...but your module isn't getting subprocess from it | 16:44 |
| ayoung | dstanek, and the environement code still does the monkey patching, it is just that in our code, we have the standard of being explicit | 16:44 |
| dstanek | ayoung: don't you need to copy that function to your module too? | 16:45 |
| ayoung | dstanek, what do you mean by "my module" | 16:45 |
| jgriffith | flaper87: so until that's sorted out I don't want anything to do with it :) | 16:45 |
| dstanek | ayoung: keystone/token/providers/pki.py | 16:45 |
| ayoung | the call comes from the pki provider into the clients version of cms. cms uses the version of popen it gets from the subprocess it has access to from globals. That is going to throw a subprocess specific execption | 16:46 |
| ayoung | it will have been monkey patched on both sides of the call | 16:46 |
| *** sahid has quit IRC | 16:46 | |
| ayoung | the environemnet.use_eventlet call does that | 16:46 |
| bknudson | dstanek: ayoung: pass in the subprocess module to use. | 16:47 |
| ayoung | bknudson, can't | 16:47 |
| ayoung | this code is the keystone client code | 16:47 |
| *** sahid has joined #openstack-dev | 16:47 | |
| ayoung | its self contained and does not know which to use | 16:47 |
| ayoung | ...but this is irrelevant | 16:47 |
| jgriffith | flaper87: I've set it at "Good Progress" we'll see where dhellmann 's patch is next week and consider making it blocked and do FFE for it if needed | 16:47 |
| flaper87 | jgriffith: ok, I just noticed Doug proposed a patch, I'll dig more into this too. | 16:47 |
| bknudson | ayoung: the keystone client code must work with either eventlet or threads already then? | 16:47 |
| *** athomas has quit IRC | 16:48 | |
| dstanek | ayoung, bknudson: i'm just worried that this is an order of operations issue - if keystone/token/providers/pki.py is imported before that _ensure_subprocess runs then it may get the wrong one | 16:48 |
| stevemar | bknudson, ugh, didn't realize you made more comments, but i uploaded a new patch of rule processing, if you're interested | 16:48 |
| flaper87 | jgriffith: I'll review Doug's patch right away | 16:48 |
| jgriffith | flaper87: thanks! | 16:48 |
| flaper87 | jgriffith: my pleasure, thanks for pointing it out. I've been heads down into this and I didn't pay much attention to emails | 16:48 |
| *** athomas has joined #openstack-dev | 16:48 | |
| ayoung | the environment. code just makes things explicit so that we are forced to say at startup whentehr we we ant eventlet or not, which is, I am pretty sure, a mistake, as it makes all our code non-reusable. I admire jamie for his hatred of eventlet, but we are not really breaking our dependency on it here | 16:48 |
| *** bdpayne has joined #openstack-dev | 16:49 | |
| ayoung | dstanek, you are correct, but that is the case across the board. The monkeypatching always has to be done early in the process launch | 16:49 |
| *** jistr has quit IRC | 16:49 | |
| ayoung | this is an OpenStack norm | 16:49 |
| *** athomas has quit IRC | 16:49 | |
| ayoung | we are just being more cautious in Keystone, but the old mechanism still works. And we have the same issue with every third party library we pull in | 16:49 |
| *** sahid has quit IRC | 16:50 | |
| dstanek | ayoung: environment is not monkey patching...and ensure doesn't either | 16:50 |
| ayoung | for example, the memcached code is why we monkeypatch threading...which is far more suspect | 16:50 |
| *** krotscheck has quit IRC | 16:50 | |
| *** akrivoka has quit IRC | 16:50 | |
| *** gyee has joined #openstack-dev | 16:50 | |
| ayoung | __init__ line 86 | 16:51 |
| ayoung | eventlet.patcher.monkey_patch(os=False, select=True, socket=True, | 16:51 |
| ayoung | ... | 16:51 |
| *** vijendar has quit IRC | 16:51 | |
| ayoung | subprocess = _subprocess | 16:51 |
| lbragstad | ayoung: for some reason the link I posted isn't working: https://review.openstack.org/#/c/69084/ | 16:51 |
| lbragstad | it should be: https://bugs.launchpad.net/keystone/+bug/1276930 | 16:52 |
| uvirtbot | Launchpad bug 1276930 in keystone "assertGreater fails python 2.6 tests" [Undecided,Invalid] | 16:52 |
| lbragstad | which dolphm suggested a fix in. | 16:52 |
| ayoung | lovely | 16:52 |
| *** sahid has joined #openstack-dev | 16:52 | |
| dstanek | ayoung: but we're not patching subprocess right? that's the whole reason to do the explicit imports from environment | 16:52 |
| *** jcoufal has quit IRC | 16:52 | |
| ayoung | that code, by calling in the eventlet code, does the right thing | 16:53 |
| viktors | dhellmann: around? | 16:53 |
| dhellmann | viktors: hi | 16:53 |
| dstanek | ayoung: have you tested to make sure you can get the eventlet version? | 16:53 |
| viktors | dhellmann: hello | 16:53 |
| *** lsmola has quit IRC | 16:53 | |
| *** jtomasek has quit IRC | 16:54 | |
| viktors | dhellmann: question about global engine. What class in class in oslo.db do you want to have? | 16:54 |
| viktors | dhellmann: and is it really reasonable? | 16:54 |
| *** CrackerJackMack has quit IRC | 16:54 | |
| *** ifarkas_ has quit IRC | 16:55 | |
| *** bhuvan has quit IRC | 16:55 | |
| dhellmann | viktors: rather than copy the definitions of a bunch of functions into every project that needs the global db handle, we should provide them with a single class they can instantiate and use in a similar way | 16:55 |
| viktors | dhellmann: I'm talking about https://review.openstack.org/#/c/71274/1/nova/db/sqlalchemy/session.py | 16:55 |
| *** sudorandom has quit IRC | 16:55 | |
| ayoung | ok, discussion starts back here http://lists.openstack.org/pipermail/openstack-dev/2012-November/002207.html | 16:55 |
| *** zackf has quit IRC | 16:55 | |
| *** hemna has joined #openstack-dev | 16:55 | |
| *** CrackerJackMack has joined #openstack-dev | 16:55 | |
| *** sudorandom has joined #openstack-dev | 16:56 | |
| *** tkammer has quit IRC | 16:56 | |
| viktors | dhellmann: yes, but I not sure, that ceilometer (fir example) will use engine in a such way | 16:56 |
| *** rtheis has joined #openstack-dev | 16:56 | |
| dhellmann | viktors: so we might have a GlobalEngineManager class with a get_session() method, and nova's session.py could then instantiate one and use its methods instead of having to have copies of the functions | 16:56 |
| *** julienvey has quit IRC | 16:56 | |
| dhellmann | viktors: no, they won't, but almost every other project currently does use a global db handle | 16:56 |
| *** mestery has joined #openstack-dev | 16:56 | |
| *** jcooley_ has quit IRC | 16:56 | |
| *** asadoughi has joined #openstack-dev | 16:56 | |
| dhellmann | viktors: so even though not everyone will use it, and we don't actually *want* anyone to use it, having it will still easy the transition to oslo.db as a library | 16:57 |
| dhellmann | s/easy/ease/ | 16:57 |
| *** jcooley_ has joined #openstack-dev | 16:57 | |
| dhellmann | viktors: make sense? | 16:57 |
| * viktors thinking | 16:58 | |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 16:58 | |
| *** amuller has quit IRC | 16:58 | |
| *** amuller_ has joined #openstack-dev | 16:58 | |
| viktors | dhellmann: yes, it's will make transition to oslo.db more easy. But should we store engine and session there? | 16:59 |
| dhellmann | I don't understand | 16:59 |
| dstanek | ayoung: i get what we are trying to do; i just don't see how you can 'import subprocess' and ever get the eventlet one | 16:59 |
| *** jmontemayor has quit IRC | 17:00 | |
| viktors | dhellmann: how should we handle work with multiple engines in such case? | 17:00 |
| dstanek | ayoung: i don't see any monkeypatching or sys.modules manipulation | 17:00 |
| *** markmc has quit IRC | 17:00 | |
| dhellmann | viktors: projects that want to have multiple engines would not use this class at all, they would use the other API you've updated | 17:00 |
| *** jmontemayor has joined #openstack-dev | 17:00 | |
| ayoung | dstanek, it checks if the eventlet code has been initialized. If so, it sets subprocess to be the eventlet version | 17:01 |
| *** peoplemerge has quit IRC | 17:01 | |
| *** alop has joined #openstack-dev | 17:01 | |
| *** caleb_ has quit IRC | 17:01 | |
| ayoung | that happens in the client code | 17:01 |
| dstanek | ayoung: but only in that module - not in any other ones | 17:01 |
| ayoung | the exception that is thrown is the same class regardless of whether it was in cms or in the pki call | 17:01 |
| dhellmann | bnemec: https://bugs.launchpad.net/oslo/+bug/1277168 | 17:01 |
| uvirtbot | Launchpad bug 1277168 in oslo "having oslo.sphinx in namespace package causes issues with devstack" [High,In progress] | 17:01 |
| *** emagana has joined #openstack-dev | 17:01 | |
| ayoung | doesn't matter, the pki module is not creating a subprocess | 17:01 |
| viktors | dhellmann: let me look at oslo code one more time | 17:01 |
| ayoung | it just needs the right class to catch the exception | 17:02 |
| *** unicell has quit IRC | 17:02 | |
| *** MaxV has quit IRC | 17:02 | |
| *** sarob has joined #openstack-dev | 17:02 | |
| ayoung | we probably should be using a specific exception there, but that is just more Yak shaving | 17:02 |
| dhellmann | viktors: all I'm suggesting is that you move the code you have in that session.py into a reusable place in oslo.db so we don't have to make copies of it | 17:02 |
| *** MaxV has joined #openstack-dev | 17:02 | |
| dhellmann | viktors: I thought using a class for that would make it cleaner, but it's not required to make the code reusable | 17:03 |
| *** gszasz has quit IRC | 17:03 | |
| *** zackf has joined #openstack-dev | 17:03 | |
| ayoung | global subprocess does not look to see if another module has already linked it in. It just looks in the namespace for the current module. So the client code only gets it once it has explcitly imported it | 17:03 |
| ayoung | https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/common/cms.py#L41 | 17:03 |
| *** dtantsur has quit IRC | 17:03 | |
| ayoung | then, the next time the code is executed, it is in the globals | 17:03 |
| *** portante has left #openstack-dev | 17:04 | |
| ayoung | the only way this code would not get the eventlet code is if the check on the next line fails: | 17:04 |
| viktors | dhellmann: if I understand you correctly, in such case we should not drop storing engine instances in oslo.db, put provide a possibility to store engine(s) in library code | 17:04 |
| ayoung | from eventlet import patcher | 17:04 |
| ayoung | if patcher.already_patched.get('os'): | 17:04 |
| ayoung | it needs to have the 'os' module monkyepatched | 17:04 |
| *** DinaBelova is now known as DinaBelova_ | 17:04 | |
| *** e0ne_ has quit IRC | 17:05 | |
| *** xga has quit IRC | 17:05 | |
| viktors | dhellmann: am I got your point? | 17:05 |
| *** xga__ has quit IRC | 17:05 | |
| dhellmann | viktors: yes, in an isolated module that can be used optionally | 17:05 |
| ayoung | then it sets the local subprocess to be the global. Since we patch os, we are good | 17:05 |
| dhellmann | viktors: yes, I think so | 17:05 |
| dstanek | ayoung: globals are not shared between modules | 17:05 |
| *** xga__ has joined #openstack-dev | 17:05 | |
| *** xga has joined #openstack-dev | 17:05 | |
| *** e0ne has joined #openstack-dev | 17:05 | |
| *** portante has joined #openstack-dev | 17:05 | |
| ayoung | dstanek, exactly, that is what I just said | 17:05 |
| *** portante has left #openstack-dev | 17:05 | |
| *** devoid has joined #openstack-dev | 17:06 | |
| ayoung | the global in this case would be eventlet.subprocess | 17:06 |
| *** lcheng_ has joined #openstack-dev | 17:06 | |
| dstanek | ayoung: you can get into a situation where cms raises a CalledProcessError from eventlet, but you are excepting the one from stdlib | 17:06 |
| ayoung | the class is the same | 17:06 |
| ayoung | the exception class is kept intact | 17:06 |
| *** yassine_ has quit IRC | 17:06 | |
| viktors | dhellmann: ok, I'll look at this way | 17:06 |
| dstanek | http://paste.openstack.org/show/62834/ | 17:06 |
| *** MaxV has quit IRC | 17:07 | |
| *** gilliard has quit IRC | 17:07 | |
| ayoung | dstanek, I was well berat up by this code back when we wrote it....it is ugly, and I hate that we have to do this. | 17:07 |
| *** sarob has quit IRC | 17:07 | |
| viktors | dhellmann: but tomorrow - it's late time in my country. | 17:07 |
| dstanek | ayoung: i just think there is a case where i won't work because you are importing subprocess directly | 17:08 |
| *** e0ne has quit IRC | 17:08 | |
| *** caleb_ has joined #openstack-dev | 17:08 | |
| ayoung | dstanek, you can't just do import subprocess and get the eventlet version....it is even uglier than usual eventlet monlkeypatching | 17:08 |
| ayoung | It does work. The unit tests would fail. | 17:08 |
| *** kiall has quit IRC | 17:08 | |
| *** lparth has quit IRC | 17:08 | |
| ayoung | the code in cms does not just monkeypatch | 17:09 |
| dstanek | ayoung: that's because we're not monkey patching is this case | 17:09 |
| *** mindpixel has quit IRC | 17:09 | |
| ayoung | no, we are explicitly importing... | 17:09 |
| *** GheRivero has quit IRC | 17:09 | |
| *** jckasper_ has quit IRC | 17:09 | |
| ayoung | dstanek, here is what happens: in keystone-all we kick off the nonkeypatch before linking in other modules | 17:09 |
| *** sdake has joined #openstack-dev | 17:09 | |
| *** sdake has quit IRC | 17:09 | |
| *** sdake has joined #openstack-dev | 17:09 | |
| ayoung | that monkyepatches os | 17:10 |
| *** sweston has joined #openstack-dev | 17:10 | |
| ayoung | https://github.com/openstack/keystone/blob/master/bin/keystone-all#L129 | 17:10 |
| ayoung | everything in this block must be eventlet safe | 17:10 |
| ayoung | https://github.com/openstack/keystone/blob/master/bin/keystone-all#L45 | 17:10 |
| *** tuxninja has joined #openstack-dev | 17:11 | |
| ayoung | the monkeypatching happens prior to the pipeline, | 17:11 |
| ayoung | and prior to importing the wsgi apps | 17:11 |
| dhellmann | viktors: have a good evening :-) | 17:12 |
| dstanek | ayoung: are you saying that we are monkey patching subprocess? | 17:12 |
| ayoung | dstanek, you can't | 17:12 |
| ayoung | I'll show you the link ..one sec | 17:12 |
| viktors | dhellmann: thanks :) | 17:12 |
| ayoung | http://nullege.com/codes/search/eventlet.green.subprocess | 17:12 |
| ayoung | you need to call it explcitly, | 17:12 |
| ayoung | er... | 17:12 |
| dstanek | ayoung: we could by importing the desired version and put it in sys.modules | 17:13 |
| *** jecarey has quit IRC | 17:13 | |
| dstanek | not saying we should do that | 17:13 |
| *** taps has joined #openstack-dev | 17:13 | |
| ayoung | dstanek, yeah...but you can't cannot remember the details, looking for the ref | 17:13 |
| *** markmcclain has joined #openstack-dev | 17:15 | |
| dstanek | ayoung: gimme a few and i'll write a failing test | 17:15 |
| ayoung | dstanek, we tried that | 17:15 |
| ayoung | I'm trying to remember the reason we had to do this code...it was because eventlet does not monkeypatch subprocess, and it was because it couldn't | 17:16 |
| ayoung | it has to do with breaking the underlying library | 17:16 |
| ayoung | ah that was ii! dstanek the origianl popen is used by the eventlet libraray, so if you replace it in the sys.modules you break everything | 17:17 |
| *** tuxninja has quit IRC | 17:17 | |
| *** iartarisi has quit IRC | 17:18 | |
| dstanek | ayoung: all i'm saying is that in keystone.token.providers.pki i think you will alway get the stdlib version | 17:18 |
| ayoung | dstanek, yes, we will, but that is ok | 17:18 |
| *** evgenyf has quit IRC | 17:18 | |
| ayoung | we only need it to catch the exception | 17:18 |
| ayoung | and the exception is the stdlib version | 17:18 |
| ayoung | look at the greenlet subprocess module | 17:18 |
| *** aditirav has quit IRC | 17:19 | |
| *** tjones has joined #openstack-dev | 17:19 | |
| dstanek | ayoung: but my paste shows that they are not the same | 17:19 |
| *** mst89 has joined #openstack-dev | 17:19 | |
| ayoung | # Borrow subprocess.call() and check_call(), but patch them so they reference | 17:19 |
| ayoung | # OUR Popen class rather than subprocess.Popen. | 17:19 |
| *** dripton is now known as dripton_lunch | 17:20 | |
| ayoung | dstanek, their code does not define an exception. | 17:20 |
| *** markwash has joined #openstack-dev | 17:21 | |
| *** I159 has quit IRC | 17:21 | |
| *** nkinder has quit IRC | 17:21 | |
| ayoung | they raise the underlying exception from Popen, which they have imported into the global namespace in greenlet.subprocess | 17:21 |
| ayoung | https://github.com/rdw/Eventlet/blob/master/eventlet/green/subprocess.py#L10 dstanek | 17:22 |
| *** pradeep has quit IRC | 17:23 | |
| ayoung | that is where they inject everything from standard popen into their implenmentation | 17:23 |
| ayoung | then they override the Popen object | 17:23 |
| *** mst89 has quit IRC | 17:23 | |
| *** chris_johnson is now known as wchrisj|away | 17:24 | |
| *** wchrisj|away is now known as chris_johnson | 17:24 | |
| *** jamielennox is now known as jamielennox|away | 17:24 | |
| *** markwash has quit IRC | 17:26 | |
| *** comay has joined #openstack-dev | 17:26 | |
| *** marcoemorais has joined #openstack-dev | 17:27 | |
| *** doug_shelley66 has quit IRC | 17:27 | |
| dstanek | ayoung: then i don't understand this behavior http://paste.openstack.org/show/62835/ | 17:28 |
| dstanek | ayoung: i would expect the exception to be caught | 17:28 |
| *** tjones1 has joined #openstack-dev | 17:28 | |
| *** godara has joined #openstack-dev | 17:29 | |
| *** angdraug has quit IRC | 17:29 | |
| *** tjones has quit IRC | 17:29 | |
| *** tjones1 has quit IRC | 17:30 | |
| *** jckasper has joined #openstack-dev | 17:31 | |
| *** caleb_ has quit IRC | 17:31 | |
| ayoung | maybe there is no subprocess.CalledProcessError from the greenlet code | 17:31 |
| ayoung | and you need to impoirt the real one to catch it? | 17:32 |
| ayoung | I would not put it past them | 17:32 |
| *** tjones has joined #openstack-dev | 17:32 | |
| *** tjones has joined #openstack-dev | 17:32 | |
| ayoung | subprocess.CalledProcessError(retcode, "openssl") | 17:32 |
| *** kbrierly has quit IRC | 17:32 | |
| ayoung | yeah...this whole thing is ugly | 17:32 |
| *** cdub has joined #openstack-dev | 17:33 | |
| ayoung | dstanek, OK, if you want to check for real, do this | 17:33 |
| ayoung | run the eventlet server in Keystone, kill the certificates, and try to get a token | 17:33 |
| *** caleb_ has joined #openstack-dev | 17:33 | |
| *** dstanek_afk has joined #openstack-dev | 17:33 | |
| ayoung | using this patch ^^ | 17:33 |
| dstanek_afk | ayoung: can you resend got disconnected | 17:33 |
| *** taps has quit IRC | 17:34 | |
| *** taps has joined #openstack-dev | 17:34 | |
| *** tjones has quit IRC | 17:34 | |
| *** martyntaylor has quit IRC | 17:35 | |
| *** jobewan has joined #openstack-dev | 17:35 | |
| ayoung | dstanek, OK, if you want to check for real, do this | 17:35 |
| ayoung | run the eventlet server in Keystone, kill the certificates, and try to get a token | 17:35 |
| ayoung | using this patch ^^ | 17:35 |
| ayoung | see what error you get | 17:35 |
| *** dstanek has quit IRC | 17:36 | |
| *** tjones has joined #openstack-dev | 17:36 | |
| *** marekd is now known as marekd|away | 17:36 | |
| *** kbrierly has joined #openstack-dev | 17:36 | |
| *** DinaBelova_ is now known as DinaBelova | 17:37 | |
| *** dstanek_afk is now known as dstanek | 17:37 | |
| *** xmltok has joined #openstack-dev | 17:37 | |
| *** doug_shelley66 has joined #openstack-dev | 17:37 | |
| *** gcha has quit IRC | 17:37 | |
| *** salv-orlando has quit IRC | 17:38 | |
| dstanek | ayoung: do the tests simulate a failure to create the certs? | 17:38 |
| *** bcrochet has quit IRC | 17:38 | |
| *** bcrochet has joined #openstack-dev | 17:40 | |
| ayoung | dstanek, yes | 17:40 |
| *** kashyap has quit IRC | 17:41 | |
| ayoung | actually, they point the config at a none existent location IIRC | 17:41 |
| *** AnilV4 has quit IRC | 17:41 | |
| *** jnoller_ is now known as jnoller | 17:41 | |
| ayoung | test_cert_setup | 17:41 |
| *** jcooley_ has quit IRC | 17:41 | |
| ayoung | https://github.com/openstack/keystone/blob/master/keystone/tests/test_cert_setup.py#L69 | 17:42 |
| *** jcooley_ has joined #openstack-dev | 17:42 | |
| *** vijendar has joined #openstack-dev | 17:42 | |
| *** bcrochet has quit IRC | 17:42 | |
| *** AlexF has quit IRC | 17:42 | |
| ayoung | UnexpectedError is in between the Subprocess error and the controller somewhere...I saw it last night | 17:42 |
| *** bcrochet has joined #openstack-dev | 17:43 | |
| *** kashyap_bbiab has joined #openstack-dev | 17:44 | |
| *** pschaef has quit IRC | 17:46 | |
| *** ygbo has quit IRC | 17:46 | |
| *** dvarga is now known as dvarga|away | 17:46 | |
| *** dvarga|away is now known as dvarga | 17:46 | |
| *** pll_ has quit IRC | 17:47 | |
| *** viktors has quit IRC | 17:47 | |
| *** MaxV has joined #openstack-dev | 17:47 | |
| *** jecarey has joined #openstack-dev | 17:48 | |
| *** jamieh has quit IRC | 17:50 | |
| *** jamieh has joined #openstack-dev | 17:50 | |
| *** peoplemerge has joined #openstack-dev | 17:51 | |
| *** SumitNaiksatam has quit IRC | 17:51 | |
| *** cadenzajon has joined #openstack-dev | 17:51 | |
| *** mrodden has quit IRC | 17:52 | |
| *** AnilV4 has joined #openstack-dev | 17:53 | |
| *** nati_ueno has joined #openstack-dev | 17:54 | |
| *** angdraug has joined #openstack-dev | 17:55 | |
| *** mrodden has joined #openstack-dev | 17:55 | |
| *** dkuffner has joined #openstack-dev | 17:55 | |
| *** markwash has joined #openstack-dev | 17:56 | |
| *** AlexF has joined #openstack-dev | 17:56 | |
| *** belmoreira has quit IRC | 17:56 | |
| *** jmontemayor has quit IRC | 17:57 | |
| *** adreznec has quit IRC | 17:57 | |
| *** kashyap_bbiab has quit IRC | 17:58 | |
| *** Gordonz has joined #openstack-dev | 17:58 | |
| *** florentflament has quit IRC | 17:58 | |
| *** rossella_s has quit IRC | 17:58 | |
| *** harlowja_away is now known as harlowja | 17:59 | |
| *** AnilV4 has quit IRC | 17:59 | |
| *** galstrom is now known as galstrom_zzz | 17:59 | |
| *** pixelb has quit IRC | 18:00 | |
| *** david_lyle_ has joined #openstack-dev | 18:00 | |
| *** sweston has quit IRC | 18:01 | |
| *** Gordonz has quit IRC | 18:01 | |
| *** sc68cal_ has joined #openstack-dev | 18:01 | |
| *** davidhadas_ has joined #openstack-dev | 18:01 | |
| *** safchain has quit IRC | 18:02 | |
| *** derekh has quit IRC | 18:02 | |
| *** jmontemayor has joined #openstack-dev | 18:02 | |
| *** julienvey has joined #openstack-dev | 18:02 | |
| *** david-lyle has quit IRC | 18:02 | |
| *** jpich has quit IRC | 18:02 | |
| *** xga has quit IRC | 18:02 | |
| *** xga__ has quit IRC | 18:02 | |
| *** davidhadas has quit IRC | 18:02 | |
| *** xga has joined #openstack-dev | 18:03 | |
| *** xga__ has joined #openstack-dev | 18:03 | |
| *** sarob has joined #openstack-dev | 18:03 | |
| *** cdub has quit IRC | 18:03 | |
| *** Gordonz has joined #openstack-dev | 18:04 | |
| *** lucasagomes has quit IRC | 18:04 | |
| *** zzelle_ has joined #openstack-dev | 18:04 | |
| *** caleb_ has quit IRC | 18:05 | |
| *** caleb_ has joined #openstack-dev | 18:05 | |
| *** eglynn has quit IRC | 18:06 | |
| *** amcrn has joined #openstack-dev | 18:06 | |
| *** bauzas has quit IRC | 18:07 | |
| *** sarob has quit IRC | 18:07 | |
| *** kashyap has joined #openstack-dev | 18:08 | |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 18:08 | |
| *** sweston has joined #openstack-dev | 18:08 | |
| *** dripton_lunch is now known as dripton | 18:08 | |
| *** DinaBelova is now known as DinaBelova_ | 18:09 | |
| *** marcoemorais has quit IRC | 18:10 | |
| *** armax has joined #openstack-dev | 18:11 | |
| *** DinaBelova_ is now known as DinaBelova | 18:11 | |
| *** johnthetubaguy has quit IRC | 18:11 | |
| *** kashyap has quit IRC | 18:12 | |
| dstanek | ayoung: i think i got it now | 18:13 |
| *** pberis has quit IRC | 18:13 | |
| gyee | ayoung, how much of a diet cmsz offer? 40% | 18:13 |
| ayoung | gyee, haven;t measured yet | 18:14 |
| ayoung | I thin I might have it backewards anyway | 18:14 |
| ayoung | I am compressing after signing, I think I need to swap thjat | 18:14 |
| gyee | ayoung, I like that change though | 18:14 |
| ayoung | we'll get much better compression on the text. | 18:14 |
| dstanek | ayoung: we don't patch os so patcher.already_patched.get('os') is never true and the eventlet version doesn't get loaded | 18:14 |
| *** avishay has quit IRC | 18:14 | |
| ayoung | dstanek, ugh | 18:14 |
| *** sarob has joined #openstack-dev | 18:15 | |
| dstanek | if you go into keystone.common.environment and change the boolean for os the test will fail | 18:15 |
| ayoung | dstanek, I really really hate it when people break things that I worked hard at hacking around brokeness elsewhere... | 18:15 |
| ayoung | looovely | 18:15 |
| ayoung | wonder where else that is broken. I'm guessing throughout openstack | 18:16 |
| ayoung | hmmmm | 18:16 |
| *** pberis has joined #openstack-dev | 18:17 | |
| gyee | ayoung, for https://review.openstack.org/#/c/70847/, I am going to abandon mine and merge me changes with https://review.openstack.org/#/c/69007/. Does that sound like a plan? | 18:17 |
| ayoung | gyee, yes | 18:17 |
| *** mst89 has joined #openstack-dev | 18:17 | |
| ayoung | and feel free to take over that review | 18:17 |
| *** galstrom_zzz is now known as galstrom | 18:17 | |
| gyee | ayoung, sure | 18:17 |
| ayoung | needs tests | 18:17 |
| ayoung | can't really think how to write them | 18:17 |
| gyee | I have tests | 18:17 |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 18:17 | |
| ayoung | ++ | 18:17 |
| *** kashyap has joined #openstack-dev | 18:18 | |
| *** AnilV4 has joined #openstack-dev | 18:18 | |
| *** arnaud___ has joined #openstack-dev | 18:18 | |
| *** arnaud__ has joined #openstack-dev | 18:18 | |
| *** lcheng_ has quit IRC | 18:19 | |
| ayoung | we should run pep8 before the unit tests in run_test.sh | 18:19 |
| ayoung | heh | 18:19 |
| *** sarob has quit IRC | 18:20 | |
| *** mestery has quit IRC | 18:20 | |
| gyee | ayoung, here's an experiment, just introduce a syntax error in one of the tests, say keystone.tests.test_v3_auth | 18:21 |
| gyee | then run_tests.sh keystone.tests.test_v3_auth | 18:21 |
| *** jcooley_ has quit IRC | 18:21 | |
| gyee | and it will spit out a bunch of crap | 18:21 |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 18:21 | |
| lbragstad | ayoung: dstanek before we weren't explicitly setting os=False for monkey patching : https://github.com/openstack/keystone/commit/c0c61ed60b356d581a5618a753f5a5a8939ab844 | 18:22 |
| *** morganfainberg_Z is now known as morganfainberg | 18:22 | |
| lbragstad | and it would fail in qpid code. https://bugs.launchpad.net/keystone/+bug/1224565 http://paste.openstack.org/show/46886/ | 18:22 |
| uvirtbot | Launchpad bug 1224565 in keystone "Can't establish qpid connection with impl_qpid.py" [High,Fix released] | 18:22 |
| *** DinaBelova is now known as DinaBelova_ | 18:23 | |
| *** david_lyle_ is now known as david_lyle | 18:23 | |
| lbragstad | we had to do that so we could verify notifications could be sent using impl_qpid as the notification/rpc backend | 18:23 |
| *** AlexF has quit IRC | 18:23 | |
| *** danpb has quit IRC | 18:23 | |
| *** GheRivero has joined #openstack-dev | 18:23 | |
| *** galstrom is now known as galstrom_zzz | 18:23 | |
| *** CaptTofu has joined #openstack-dev | 18:24 | |
| ayoung | I don't think we need to monkeypatch os to get the greenlet, but it was the test we were using to see if we should be MP or not. | 18:24 |
| *** SumitNaiksatam has joined #openstack-dev | 18:24 | |
| ayoung | Does nova MP os? | 18:24 |
| lbragstad | ayoung: checking | 18:24 |
| *** alex_klimov has joined #openstack-dev | 18:25 | |
| lbragstad | https://github.com/openstack/nova/blob/master/nova/cmd/__init__.py#L35 | 18:27 |
| ayoung | that code burns my eyes | 18:27 |
| *** sushil_ has quit IRC | 18:27 | |
| *** changbl has joined #openstack-dev | 18:27 | |
| ayoung | (os=False) | 18:27 |
| *** tuxninja has joined #openstack-dev | 18:27 | |
| lbragstad | monkey_patch_modules = nova.api.ec2.cloud:nova.notifications.notify_decorator, | 18:28 |
| ayoung | not that, but the utils code that calls the monkeypatch | 18:28 |
| ayoung | yeah, that | 18:28 |
| lbragstad | looks like nova uses configuration options to manage monkey_patching | 18:28 |
| lbragstad | http://docs.openstack.org/trunk/config-reference/content//list-of-compute-config-options.html | 18:28 |
| dstanek | ayoung, lbragstad: can keystoneclient just see if anything has been patched? | 18:28 |
| lbragstad | is_monkey_patched | 18:28 |
| ayoung | dstanek, well, is that in all serers? | 18:29 |
| ayoung | services that use auth_token? | 18:29 |
| lbragstad | dstanek: http://eventlet.net/doc/patching.html#eventlet.patcher.is_monkey_patched | 18:29 |
| lbragstad | dstanek: ^ using that you mean? | 18:30 |
| lbragstad | in keystoneclient | 18:30 |
| ayoung | that is what we do, sortof | 18:30 |
| ayoung | rom eventlet import patcher | 18:31 |
| ayoung | if patcher.already_patched.get('os'): | 18:31 |
| dstanek | lbragstad: i was hoping for something is eventlet.is_anything_monkey_patched() | 18:31 |
| lbragstad | whats the difference between using that and evenlet.is_monkey_patched? | 18:31 |
| dstanek | i don't want to check for specifics because that's what got us into this jam | 18:31 |
| lbragstad | you could create loop and pass in all modules you want to check for | 18:31 |
| lbragstad | for module in modules: check for monkey patching iwth eventlet, return a list | 18:32 |
| *** dvarga is now known as dvarga|away | 18:33 | |
| *** dvarga|away is now known as dvarga | 18:33 | |
| dstanek | lbragstad: yeah, something feels wierd about that, but i have no better solution | 18:33 |
| *** ek6 has left #openstack-dev | 18:34 | |
| *** smurugesan has joined #openstack-dev | 18:34 | |
| *** sushils has joined #openstack-dev | 18:34 | |
| *** bvandenh has joined #openstack-dev | 18:34 | |
| *** newell has joined #openstack-dev | 18:34 | |
| *** kbrierly has quit IRC | 18:34 | |
| dstanek | def is_monkey_patched(): return any(patcher.already_patched.get(m) for m in ['os', 'select'...]) | 18:35 |
| dstanek | lbragstad: ^ | 18:35 |
| *** julienvey has quit IRC | 18:35 | |
| *** amuller_ has quit IRC | 18:35 | |
| *** julienvey has joined #openstack-dev | 18:35 | |
| *** kbrierly has joined #openstack-dev | 18:35 | |
| lbragstad | dstanek: yep, that would work. very nice | 18:36 |
| morganfainberg | dstanek, what is eventlet causing issues with? | 18:36 |
| *** sahid has quit IRC | 18:36 | |
| *** cnesa has quit IRC | 18:37 | |
| *** tqtran has joined #openstack-dev | 18:37 | |
| dstanek | morganfainberg: see all the comments here https://review.openstack.org/#/c/71455/1/keystone/token/providers/pki.py | 18:37 |
| *** dkuffner has quit IRC | 18:37 | |
| *** ndipanov is now known as ndipanov_gone | 18:37 | |
| *** ijw has quit IRC | 18:38 | |
| morganfainberg | dstanek, oh ick | 18:39 |
| *** igor has quit IRC | 18:40 | |
| lbragstad | dstanek: if we do go that route, we should be sure to include a comment explaining the modules we are passing it (os, select, socket, etc... ) and possible reference this https://bitbucket.org/eventlet/eventlet/src/c25b7b9044182334fd10d46c462f8a31e463961e/eventlet/patcher.py?at=default#cl-210 | 18:40 |
| *** bvandenh has quit IRC | 18:40 | |
| *** jruzicka has quit IRC | 18:40 | |
| *** smurugesan has quit IRC | 18:41 | |
| *** tjones has quit IRC | 18:41 | |
| lbragstad | I think that is what I used to make sure I patched everything explicitly in https://github.com/openstack/keystone/commit/c0c61ed60b356d581a5618a753f5a5a8939ab844 | 18:41 |
| *** mestery has joined #openstack-dev | 18:41 | |
| *** troytoman-away is now known as troytoman | 18:41 | |
| *** e0ne has joined #openstack-dev | 18:43 | |
| morganfainberg | dstanek, lbragstad, hm. | 18:43 |
| *** tjones has joined #openstack-dev | 18:43 | |
| morganfainberg | dstanek, lbragstad, you might be on the path of least resistance there. | 18:43 |
| *** chris_johnson has quit IRC | 18:44 | |
| *** igor has joined #openstack-dev | 18:44 | |
| morganfainberg | but please comment the hell out of it ;) | 18:44 |
| *** spzala has quit IRC | 18:44 | |
| lbragstad | morganfainberg: +1 | 18:44 |
| dstanek | morganfainberg, lbragstad: yeah, i think i'll submit a client change for this | 18:44 |
| dstanek | lbragstad: good idea on the comment | 18:44 |
| morganfainberg | i think if i ran across something like that (is_monkey_patched) anywhere i'd be very confused without some "omg this is why" stuff | 18:44 |
| lbragstad | dstanek: using def is_monkey_patched(): return any(patcher.already_patched.get(m) for m in ['os', 'select'...]) | 18:44 |
| *** kdbrierly has joined #openstack-dev | 18:45 | |
| dstanek | my brain hurts now | 18:45 |
| morganfainberg | lbragstad, uhm | 18:45 |
| lbragstad | exactly, whenever I have to deal with figuring out what eventlet is doing I'm always thankful for comments | 18:45 |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 18:45 | |
| morganfainberg | lbragstad, dstanek, define a dict you're passing to the patcher, reference that in is_monkeypatched | 18:45 |
| *** e0ne has quit IRC | 18:45 | |
| *** kbrierly has quit IRC | 18:45 | |
| morganfainberg | lbragstad,. don't statically set them in two places. | 18:45 |
| *** gokrokve has joined #openstack-dev | 18:46 | |
| morganfainberg | lbragstad, that will lead to heartache if it's done differently | 18:46 |
| dstanek | morganfainberg: the issue is part of the code is in server and the other part is in the client | 18:46 |
| morganfainberg | lbragstad, esp. if one gets updated w/o the other | 18:46 |
| dstanek | i would want to define that dict in the client | 18:46 |
| morganfainberg | dstanek, dict is in client, server sets values in client, pass dict | 18:46 |
| *** smurugesan has joined #openstack-dev | 18:47 | |
| morganfainberg | or, override the dict in client w. the server's version | 18:47 |
| morganfainberg | explicitly | 18:47 |
| dstanek | morganfainberg: that means that is we want to change how we patch in the server we'd have to release it in the client first | 18:47 |
| *** ArxCruz has quit IRC | 18:47 | |
| *** ArxCruz has joined #openstack-dev | 18:47 | |
| *** eglynn has joined #openstack-dev | 18:47 | |
| morganfainberg | dstanek, well.. you could do something horrible and make the server monkeypatch the client w/ new logic until the client is released >.> | 18:48 |
| morganfainberg | dstanek, ok i think i'm going to go take a shower after suggesting that | 18:48 |
| *** marcoemorais has joined #openstack-dev | 18:48 | |
| morganfainberg | though that isn't the worst idea ever | 18:48 |
| morganfainberg | dstanek, esp. if we want to support older clients on new server. | 18:49 |
| morganfainberg | dstanek, i still feel dirty from even thinking it | 18:49 |
| *** galstrom_zzz is now known as galstrom | 18:49 | |
| lbragstad | so if we need a static dictionary, we would need to use it in the is_monkey_patched() method and https://github.com/openstack/keystone/commit/c0c61ed60b356d581a5618a753f5a5a8939ab844#diff-d8bc84769b22a5fa286e30c27c55bacbR86 | 18:49 |
| lbragstad | i *think* those are the only places that would rely on that information | 18:50 |
| morganfainberg | lbragstad, probably. | 18:50 |
| jog0 | dhellmann: ping, got a logging question | 18:50 |
| * lbragstad looks to dstanek and morganfainberg to keep him honest | 18:50 | |
| *** jprovazn_afk has quit IRC | 18:50 | |
| morganfainberg | lbragstad, dstanek has looked at this more than i have | 18:50 |
| *** Gordonz has quit IRC | 18:50 | |
| morganfainberg | lbragstad, your statement seems correct at face value | 18:50 |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 18:51 | |
| dstanek | morganfainberg, lbragstad: i think we can use patcher.already_patched without the .get | 18:51 |
| *** eglynn has quit IRC | 18:51 | |
| dstanek | it's a dictionary of the things being patched | 18:51 |
| morganfainberg | dstanek, let me go look at that reallly quickly | 18:52 |
| morganfainberg | dstanek, hm... | 18:52 |
| morganfainberg | dstanek, yeah it does an "in already_patched" check | 18:53 |
| morganfainberg | dstanek, https://bitbucket.org/eventlet/eventlet/src/c25b7b9044182334fd10d46c462f8a31e463961e/eventlet/patcher.py?at=default#cl-278 | 18:53 |
| *** jpomero has quit IRC | 18:53 | |
| *** nacim has quit IRC | 18:53 | |
| morganfainberg | so if we are... smart about it, we'd be ok | 18:54 |
| dstanek | morganfainberg: i'm just saying no to explicitly look for os | 18:54 |
| *** zzelle has quit IRC | 18:54 | |
| morganfainberg | dstanek, oh if 'os' in | 18:54 |
| morganfainberg | ? | 18:54 |
| morganfainberg | or just call patcher.is_mokey_patched('os') | 18:54 |
| morganfainberg | or os | 18:54 |
| morganfainberg | w/o quotes | 18:54 |
| *** lcheng_ has joined #openstack-dev | 18:55 | |
| morganfainberg | it seems wrong to check the dict explicitly | 18:55 |
| morganfainberg | there _may_ eventually be extra logic there, and a helper function already exists | 18:55 |
| *** tanisdl has quit IRC | 18:55 | |
| dstanek | no change this http://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/common/cms.py#n45 | 18:55 |
| dstanek | to just patcher.already_patched without the .get - if anything is patched use the eventlet version | 18:56 |
| morganfainberg | og | 18:56 |
| morganfainberg | oh | 18:56 |
| dstanek | morganfainberg: i want to get away from know what modules to check for | 18:56 |
| dstanek | morganfainberg: patch on it's way to start the discussion | 18:57 |
| morganfainberg | dstanek, so if we use mysqldb, patched but nothing else (ok not normal) we'd use the eventlet version? | 18:57 |
| dhellmann | jog0: pong | 18:57 |
| *** jcooley_ has joined #openstack-dev | 18:58 | |
| lbragstad | morganfainberg: dstanek ++ to using the already_patched dict http://paste.openstack.org/show/62848/ | 18:58 |
| morganfainberg | dstanek, i ... hmmmmmmmm | 18:58 |
| *** byeager has quit IRC | 18:58 | |
| jog0 | dhellmann: soI found out nova wasn't running unit tests in debug mode | 18:58 |
| jog0 | (logging | 18:58 |
| *** emagana has quit IRC | 18:58 | |
| dhellmann | jog0: any particular reason? | 18:59 |
| *** ruhe_ has joined #openstack-dev | 18:59 | |
| jog0 | dhellmann: yes, I was thinking try to catch any missing variables in log messages | 18:59 |
| *** cagrev_ has joined #openstack-dev | 18:59 | |
| jog0 | but the logging module only dumps those to stderr http://docs.python.org/2/howto/logging.html#exceptions-raised-during-logging | 18:59 |
| dhellmann | jog0: sure, I meant is there a reason it isn't already running with debug enabled | 18:59 |
| *** troytoman is now known as troytoman-away | 19:00 | |
| jog0 | dhellmann: ohh, no reason that I know of | 19:00 |
| jog0 | just a bug | 19:00 |
| *** cagrev has quit IRC | 19:00 | |
| morganfainberg | dstanek, lbragstad, as long as we but a big (maybe) FIXME indicating we need to make sure all cases should in fact do this and identify any exceptional cases... if patcher.already_patched should be ok | 19:00 |
| *** jobewan has quit IRC | 19:00 | |
| dhellmann | jog0: ok, just checking | 19:00 |
| jog0 | so anyway to force the logging module to raise the exception during testing? | 19:00 |
| *** krtaylor has quit IRC | 19:01 | |
| lbragstad | I agree with dstanek on moving away from having to check for specifc modules, that way if eventlet does change a module in that dictionary (already_patched) it won't break us from the standpoint of what we need to check for | 19:01 |
| ayoung | morganfainberg, thanks on the greaterthan thing. Just reposted. disable is usually an idempotent operation, so safe to send multiples. | 19:01 |
| *** Gordonz_ has joined #openstack-dev | 19:01 | |
| morganfainberg | ayoung, ++ np. | 19:01 |
| *** kgriffs is now known as kgriffs_afk | 19:01 | |
| dhellmann | jog0: that raiseExceptions flag looks useful, but I don't think we have anything setting it right now | 19:02 |
| morganfainberg | ayoung, if i hadn't been swamped here i would have fixed it and proposed a change including it for you. | 19:02 |
| jog0 | dhellmann: its on by default but it only goes to stderr | 19:02 |
| dhellmann | jog0: I think maybe an env var, but not a config option, is appropriate to turn it on only for our testing | 19:02 |
| morganfainberg | ayoung, but yeah figured a quick comment would save you needing to chase the failure down | 19:02 |
| *** jpomero has joined #openstack-dev | 19:02 | |
| ayoung | morganfainberg, yep, good to ask | 19:02 |
| *** vartom1111111117 has joined #openstack-dev | 19:02 | |
| *** sweston has quit IRC | 19:02 | |
| dhellmann | jog0: oh, I read that backwards | 19:03 |
| ayoung | Keystone reviews certainly are "detail oriented" | 19:03 |
| jog0 | dhellmann: heh I did too at first | 19:03 |
| *** IanGovett has joined #openstack-dev | 19:03 | |
| morganfainberg | ayoung, i am ok with that | 19:03 |
| lbragstad | dstanek: if you want to add me to the review when it's up, you're more than welcome to | 19:03 |
| *** IanGovett1 has quit IRC | 19:03 | |
| dhellmann | jog0: well, we could install a handler that overrides the relevant method, but we're trying to get away from doing that in most cases | 19:03 |
| dhellmann | jog0: maybe that's something a test base class could do? | 19:04 |
| jog0 | dhellmann: yeah that can work | 19:04 |
| *** romcheg1 has joined #openstack-dev | 19:04 | |
| *** jckasper_ has joined #openstack-dev | 19:04 | |
| *** romcheg1 is now known as romcheg_ltp | 19:04 | |
| *** _cjones_ has joined #openstack-dev | 19:04 | |
| jog0 | I want a flag that is raiseExceptionsNoReallyDoNotJustLogToStderr | 19:05 |
| morganfainberg | lbragstad, phsaw, demand he add you to the review! | 19:05 |
| morganfainberg | ;) | 19:05 |
| dhellmann | jog0: :-) | 19:05 |
| *** dstanek has quit IRC | 19:05 | |
| *** jckasper has quit IRC | 19:05 | |
| lbragstad | morganfainberg: :) | 19:06 |
| *** gigawhat has joined #openstack-dev | 19:06 | |
| dhellmann | jog0: want to open a blueprint for that so we don't forget? | 19:06 |
| *** dstanek has joined #openstack-dev | 19:06 | |
| dstanek | lbragstad: got disconnected | 19:06 |
| jog0 | dhellmann: sure | 19:06 |
| jog0 | I am looking into it now actaully | 19:07 |
| jog0 | but let me do the BP first | 19:07 |
| lbragstad | dstanek: that'll happen | 19:07 |
| *** Gordonz_ has quit IRC | 19:07 | |
| dhellmann | jog0: yeah, this is a release-notable feature :-) | 19:07 |
| jog0 | as this should catch a lot of issues | 19:07 |
| jog0 | oslo right? | 19:07 |
| ayoung | dstanek, why not if len(patcher.already_patched): | 19:07 |
| dhellmann | jog0: yes | 19:07 |
| *** Gordonz has joined #openstack-dev | 19:07 | |
| ayoung | or | 19:08 |
| ayoung | if any(patcher.already_patched): | 19:08 |
| ayoung | lbragstad, morganfainberg will if any(patcher.already_patched): work? | 19:08 |
| *** epim has joined #openstack-dev | 19:08 | |
| morganfainberg | ayoung, you don't need the any() | 19:09 |
| dstanek | ayoung: yes it should work | 19:09 |
| morganfainberg | ayoung, you can check true/false of the dict itself | 19:09 |
| morganfainberg | ayoung, but yes, any() should work | 19:09 |
| ayoung | morganfainberg, Python is just weird | 19:09 |
| *** dfarrell07 has joined #openstack-dev | 19:09 | |
| dstanek | why not 'if patcher.already_patched'? are you worried about then changing the data structure? | 19:09 |
| ayoung | I'd expect that to check the value of the variable to see if it assigned anything | 19:09 |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 19:09 | |
| ayoung | dstanek, cuz Python is too smart for my own good | 19:10 |
| morganfainberg | ayoung, {} is implicitly boolean False when evaluated, {<stuff>} is implicitly true | 19:10 |
| dstanek | ayoung: it checks the value :) | 19:10 |
| jog0 | dhellmann: https://blueprints.launchpad.net/oslo/+spec/logging-handleerror-raise-exception | 19:10 |
| *** galstrom is now known as galstrom_zzz | 19:11 | |
| morganfainberg | dstanek, or your magic boolean evaluation __<whateveritiscalled>__ method | 19:11 |
| *** jamieh has quit IRC | 19:11 | |
| morganfainberg | dstanek, >.> | 19:11 |
| dhellmann | jog0: approved with medium priority, unless you want to raise that | 19:11 |
| jog0 | thanks | 19:11 |
| dhellmann | jog0: I'll leave the series and milestones unset for now, unless you're going to submit a change | 19:12 |
| lbragstad | ayoung: just testd it | 19:12 |
| lbragstad | http://paste.openstack.org/show/62850/ | 19:12 |
| *** galstrom_zzz is now known as galstrom | 19:12 | |
| *** Gordonz has quit IRC | 19:12 | |
| jog0 | dhellmann: I am going to take a wack at it now, but we will see | 19:12 |
| jog0 | I don't want to commit to getting it working just yet | 19:12 |
| dhellmann | jog0: wfm | 19:12 |
| ayoung | dstanek, can you open a bug, since you discovered the issue? | 19:13 |
| ayoung | I have the fix ready to go | 19:13 |
| *** pberis has quit IRC | 19:13 | |
| dstanek | ayoung: a bug for the keystoneclient behavior right? | 19:13 |
| lbragstad | ayoung: dstanek http://paste.openstack.org/show/62855/ with empty {} | 19:14 |
| ayoung | dstanek, yes | 19:14 |
| *** pberis has joined #openstack-dev | 19:14 | |
| dstanek | ayoung: will do | 19:14 |
| lbragstad | http://paste.openstack.org/show/62850/ already_patched not empty | 19:14 |
| *** spzala has joined #openstack-dev | 19:14 | |
| *** DinaBelova_ is now known as DinaBelova | 19:14 | |
| ayoung | lbragstad, what if you monkeypatch? | 19:14 |
| *** e0ne has joined #openstack-dev | 19:14 | |
| lbragstad | ayoung: http://paste.openstack.org/show/62850/ | 19:15 |
| lbragstad | the already_patched dict is updated | 19:15 |
| ayoung | ++ | 19:15 |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 19:15 | |
| *** aaronjamesford1 has joined #openstack-dev | 19:16 | |
| lbragstad | dstanek: good find on the already_patched dict, i wasn't aware of that | 19:16 |
| dolphm | lbragstad: you need to call .values() before calling any(), otherwise the function will always return true (it's looking at truthy keys) | 19:17 |
| *** FunnyLookinHat has quit IRC | 19:17 | |
| dolphm | lbragstad: i.e. http://pasteraw.com/i39tixddwt7bi3dbjjdno5c15iter7n | 19:18 |
| dstanek | dolphm: that's what we wanted - just to see if there was anything in the dictionary | 19:19 |
| *** mestery has quit IRC | 19:19 | |
| dolphm | dstanek: then don't bother with any() at all :P | 19:19 |
| dstanek | dolphm: that's what i said too :) | 19:20 |
| ayoung | dstanek, its int our code | 19:20 |
| *** FunnyLookinHat has joined #openstack-dev | 19:21 | |
| lbragstad | dolphm: you're right, thanks! http://paste.openstack.org/show/62858/ | 19:21 |
| ayoung | https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/common/cms.py#L44 lbragstad | 19:21 |
| *** pixelb has joined #openstack-dev | 19:22 | |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 19:23 | |
| *** clayb has joined #openstack-dev | 19:24 | |
| *** melwitt has joined #openstack-dev | 19:24 | |
| *** kiall has joined #openstack-dev | 19:24 | |
| *** kdbrierly has quit IRC | 19:26 | |
| zzelle_ | clarkb, hi | 19:26 |
| *** kbrierly has joined #openstack-dev | 19:26 | |
| *** dstanek has quit IRC | 19:27 | |
| *** dvarga is now known as dvarga|away | 19:27 | |
| *** dvarga|away is now known as dvarga | 19:27 | |
| *** ruhe_ has quit IRC | 19:27 | |
| *** dstanek has joined #openstack-dev | 19:27 | |
| *** caleb_ has quit IRC | 19:27 | |
| *** achampion has quit IRC | 19:27 | |
| clarkb | zzelle_: hello | 19:28 |
| *** spzala has quit IRC | 19:28 | |
| *** achampion has joined #openstack-dev | 19:28 | |
| zzelle_ | clarkb, hi | 19:28 |
| lbragstad | ayoung: yeah, wanted to test out the any() idea becuase dstanek threw out the idea | 19:28 |
| dstanek | ayoung: https://bugs.launchpad.net/python-keystoneclient/+bug/1277231 | 19:28 |
| uvirtbot | Launchpad bug 1277231 in python-keystoneclient "Check for eventlet patching in the cms module is too strict" [Undecided,New] | 19:28 |
| lbragstad | either way works | 19:28 |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 19:28 | |
| *** spzala has joined #openstack-dev | 19:29 | |
| dstanek | lbragstad: the use of already_patch was already there - i just suggested getting rid of the .get() | 19:29 |
| zzelle_ | for git-review, it's ok to use curl for http file download or is it better to use requests package ? | 19:29 |
| *** sweston has joined #openstack-dev | 19:30 | |
| *** max_lobur is now known as max_lobur_afk | 19:30 | |
| ayoung | dstanek, https://review.openstack.org/#/c/71635/1/keystoneclient/common/cms.py | 19:30 |
| *** sarob has joined #openstack-dev | 19:30 | |
| ayoung | lbragstad, dolphm ^^ | 19:31 |
| jog0 | lifeless: you were saying | 19:31 |
| lifeless | jog0: so, implementation details | 19:31 |
| zzelle_ | clarkb, for git-review, it's ok to use curl for http file download or is it better to use requests package ? | 19:31 |
| lifeless | a) logging doesn't use super consistently; it directly calls to logging.Handler.handleError | 19:31 |
| lifeless | so we need to replace that - monkey patch the class definition (ugh). | 19:31 |
| dolphm | ayoung: +2 | 19:31 |
| jog0 | dhellmann: we are talking about the BP I just filed | 19:31 |
| clarkb | zzelle_: urllib would probably be best since it is stdlib | 19:31 |
| lifeless | b) actually raising may run into the threading aspect of logging - I'll need to dig a little for that | 19:31 |
| *** tanisdl has joined #openstack-dev | 19:31 | |
| * dhellmann perks up his ears | 19:31 | |
| clarkb | zzelle_: I think git-review has tried to assume a very minimal install if you have ssh and git | 19:31 |
| lifeless | *if* it passes cross-thread, we're in trouble, otherwise redefining Handler.handleError to raise rather than write to stderr will do it | 19:32 |
| lbragstad | ayoung: looks good | 19:32 |
| *** mrodden has quit IRC | 19:32 | |
| guitarzan | ewindisch: ping | 19:32 |
| ewindisch | hi | 19:32 |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 19:32 | |
| *** caleb_ has joined #openstack-dev | 19:33 | |
| guitarzan | ewindisch: are there any docs around setting up zmq? I'm trying to check it out, but having some trouble | 19:33 |
| zzelle_ | clarkb, ok. i will look how to perform basic auth with urllib | 19:34 |
| *** mlemay has joined #openstack-dev | 19:34 | |
| *** jcooley_ has quit IRC | 19:35 | |
| *** dstanek has quit IRC | 19:36 | |
| *** bdpayne has quit IRC | 19:36 | |
| *** jcooley_ has joined #openstack-dev | 19:36 | |
| *** xga__ has quit IRC | 19:36 | |
| *** gokrokve has quit IRC | 19:36 | |
| *** xga has quit IRC | 19:36 | |
| *** jpomero has quit IRC | 19:36 | |
| ewindisch | guitarzan: I don't think there are many docs. You change the driver and set the matchmaker. Everyone in production seems to use the "files" matchmaker which requires you to create a file listing the services and their hosts (in practice for nova it just really needs you to list the schedulers. | 19:37 |
| ewindisch | guitarzan: there is also a redis matchmaker that is more 'out of the box', but I don't think anyone uses that in production | 19:37 |
| *** Gordonz has joined #openstack-dev | 19:37 | |
| guitarzan | ewindisch: yeah, I'm trying to figure out the format of the ring file | 19:37 |
| ewindisch | guitarzan: the bluehost guys use the file matchmaker, for instance (and they're also the current maintainers of the zmq driver, btw) | 19:37 |
| lifeless | jog0: but - I still think we should either do this, or not, but not do it just during test. | 19:38 |
| lifeless | jog0: its a fundamental change in behaviour | 19:38 |
| guitarzan | ewindisch: also I'm curious why calls just don't fail with the localhost matchmaker | 19:38 |
| ewindisch | guitarzan: it's simply json. It's a hash of topics to an array of hosts | 19:38 |
| lifeless | jog0: similar to e.g. turning asserts off in production code. | 19:38 |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 19:38 | |
| lifeless | jog0: the thing raising the exception might have side effects, I'm worried about false positives and untested code paths that won't be run in test. | 19:38 |
| pmathews | guitarzan: { "topic": [ "host1", "host2"] } | 19:38 |
| guitarzan | pmathews: thanks :) | 19:39 |
| ewindisch | pmathews: isn't that what I said? ;-) | 19:39 |
| *** byeager has joined #openstack-dev | 19:39 | |
| guitarzan | haha | 19:39 |
| *** cagrev__ has joined #openstack-dev | 19:39 | |
| *** dstanek has joined #openstack-dev | 19:39 | |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 19:39 | |
| *** chris_johnson has joined #openstack-dev | 19:39 | |
| ewindisch | example > description | 19:40 |
| guitarzan | and if I want to run a scheduler on the same host as another service do they need different config files? (ports to bind) | 19:40 |
| ewindisch | guitarzan: no. | 19:40 |
| ewindisch | you need to run the nova-rpc-zmq-receiver process on each host. That binds to a single port and forwards to the various services running on it | 19:40 |
| *** jcooley_ has quit IRC | 19:40 | |
| *** jcooley_ has joined #openstack-dev | 19:41 | |
| guitarzan | ewindisch: does the same apply to cinder? | 19:41 |
| *** cagrev_ has quit IRC | 19:41 | |
| *** byeager_ has joined #openstack-dev | 19:41 | |
| guitarzan | (that's actually what I'm using) | 19:41 |
| jog0 | lifeless: agreed, I do think the introspect stderr may work | 19:41 |
| jog0 | if you have an idea for that | 19:41 |
| guitarzan | ewindisch: I think that might have been a pretty big thing I was missing | 19:41 |
| ewindisch | guitarzan: this seems like a good time for me to suddenly find somewhere to go... ;-) | 19:41 |
| guitarzan | uh oh... | 19:41 |
| pmathews | guitarzan: as long as you have your topics setup properly, it should just route | 19:41 |
| guitarzan | should I give up for now? :) | 19:42 |
| *** novas0x2a|laptop has joined #openstack-dev | 19:42 | |
| jog0 | lifeless: so got a POC up | 19:42 |
| ewindisch | guitarzan: well, as of Grizzly there were some bugs with Cinder integration with the zmq driver. | 19:42 |
| ewindisch | guitarzan: and I haven't really maintained it much since then | 19:42 |
| lifeless | jog0: from fixtures import LoggingFixture... | 19:42 |
| guitarzan | ewindisch: ok, last I saw was the discussion where you said they'd be fixed in havana :D | 19:42 |
| *** bdpayne has joined #openstack-dev | 19:42 | |
| *** tjones has quit IRC | 19:42 | |
| lifeless | jog0: oh, bah | 19:42 |
| jog0 | lifeless: its just def handleError(self, record): raise | 19:42 |
| lifeless | jog0: with a custom handler? | 19:43 |
| jog0 | lifeless: that is the custom handler | 19:43 |
| jog0 | I monkey patch that in | 19:43 |
| ewindisch | guitarzan: that was my goal, but I wasn't as involved with havana as I would've liked. | 19:43 |
| lifeless | jog0: oh right | 19:43 |
| jog0 | lifeless: oh btw, the other issue | 19:43 |
| lifeless | jog0: so, I would be comfortable if rather than raise(); it captured the exception information to a fixture and then returned | 19:44 |
| jog0 | lifeless: err previous issue. nova wasn't running with debug logs on in unit tests | 19:44 |
| *** byeager has quit IRC | 19:44 | |
| lifeless | jog0: so we can introspect it, but don't change the flow | 19:44 |
| *** mrodden has joined #openstack-dev | 19:44 | |
| jog0 | lifeless: that works for me, want to hack that up? | 19:44 |
| *** sarob has quit IRC | 19:44 | |
| jog0 | lifeless: self.log_fixture = self.useFixture(fixtures.FakeLogger(level=logging.DEBUG, format=fs)) | 19:45 |
| jog0 | seems to set log level all the way down | 19:45 |
| *** jcooley_ has quit IRC | 19:45 | |
| *** markmcclain has quit IRC | 19:45 | |
| lifeless | jog0: that probably won't capture the handleError code anyhow. | 19:45 |
| zzelle_ | clarkb, urllib(2) do not verify https certificate, it allows to do man in the middle | 19:45 |
| jog0 | so I am seeing stevadore logs | 19:45 |
| *** sarob has joined #openstack-dev | 19:45 | |
| *** markmcclain has joined #openstack-dev | 19:45 | |
| lifeless | jog0: so your little monkeypatch is probably best, but s/raise/self._errors.append(sys.exc_info()) | 19:45 |
| clarkb | zzelle_: :( | 19:46 |
| zzelle_ | clarkb, perhaps it's to use curl/wget or requests | 19:46 |
| * jog0 never likes it when the words monkeypatch and best are used in the same sentance | 19:46 | |
| tellesnobrega | dolphm: in the hirarchical multitenancy you said that having a admin domain and admin tenant is a hack, i'm considering working this hack out, do you have any thoughts on possible solutions? or if this is a good thing to work on? | 19:46 |
| zzelle_ | s/it's/it's better/ | 19:46 |
| clarkb | zzelle_: fungi probably has a good opinion on it | 19:47 |
| guitarzan | ewindisch: pmathews I hope you guys don't mind if I ask questions if/when I run into issues | 19:47 |
| ewindisch | guitarzan: np | 19:47 |
| zzelle_ | fungi, hi | 19:47 |
| guitarzan | I'm very confused for example, why things don't just totally break when you don't run the receiver | 19:47 |
| pmathews | guitarzan: no problem | 19:47 |
| ewindisch | guitarzan: while I don't have time to work on it anymore, I'm glad to see people wanting to use it. | 19:47 |
| *** taps has quit IRC | 19:48 | |
| *** cfriesen has joined #openstack-dev | 19:48 | |
| *** taps has joined #openstack-dev | 19:48 | |
| ewindisch | guitarzan: things do break when you don't run the receiver. I suppose it doesn't give errors on startup, if that's what you mean? | 19:48 |
| guitarzan | yeah, calls don't just fail | 19:48 |
| guitarzan | they just disappear | 19:49 |
| guitarzan | I was very confused | 19:49 |
| ewindisch | guitarzan: calls should timeout. | 19:49 |
| *** d0ugal has quit IRC | 19:49 | |
| guitarzan | I thought so too | 19:49 |
| guitarzan | maybe I'll look into that more | 19:49 |
| ewindisch | guitarzan: oh, wow... that patch for fixing timeouts never made it in | 19:49 |
| guitarzan | my print debugging only got me so far | 19:50 |
| ewindisch | pmathews: um, did I never send you that "make timeouts actually work" patch? | 19:50 |
| pmathews | ewindisch: ouch. | 19:50 |
| pmathews | I think I have an old copy, didn't realize that never made it in | 19:50 |
| guitarzan | does Timeout never raise? | 19:50 |
| *** jcooley_ has joined #openstack-dev | 19:50 | |
| ewindisch | guitarzan: well, it turns out that Timeout is wrapping asynchronous code and that what happens is the socket just sits open forever in another thread | 19:51 |
| guitarzan | got it | 19:51 |
| guitarzan | it doesn't take 30 seconds to fire off an eventlet | 19:51 |
| ewindisch | guitarzan: the real trick is that you need to do zmq_sock.close(seconds) | 19:52 |
| pmathews | guitarzan: I think I have a patch here somewhere... | 19:52 |
| *** jckasper has joined #openstack-dev | 19:52 | |
| ewindisch | because we DO call zmq_sock.close(), but it never closes the sockets because tehre are unsent messages and it won't close the socket until it flushes the queue | 19:52 |
| ewindisch | so close(secs) will drop those messages after timeout secs | 19:53 |
| fungi | zzelle_: in the past we had been avoiding adding python dependencies for git-review to make it more portable (so you could easily run it straight out of the repository as a single monolithic script without installing it at all). we've since departed from that with pbr, so adding requests as a dependency now is probably okay | 19:53 |
| *** adreznec has joined #openstack-dev | 19:53 | |
| *** jckasper_ has quit IRC | 19:53 | |
| *** sarob has quit IRC | 19:54 | |
| *** ekhugen has joined #openstack-dev | 19:54 | |
| *** sarob has joined #openstack-dev | 19:54 | |
| *** emagana has joined #openstack-dev | 19:54 | |
| *** zackf has quit IRC | 19:54 | |
| *** jcooley_ has quit IRC | 19:56 | |
| zzelle_ | fungi, thanks for your answer, so let's go for requests ! | 19:57 |
| *** lpaschke has joined #openstack-dev | 19:57 | |
| *** jcooley_ has joined #openstack-dev | 19:57 | |
| *** sarob has quit IRC | 19:59 | |
| ayoung | gyee, http://paste.openstack.org/show/62866/ comparisons on the effects of compression | 20:00 |
| *** brianr is now known as rosmaita | 20:01 | |
| pmathews | guitarzan: https://review.openstack.org/#/c/33881/ | 20:02 |
| ayoung | dstanek, gyee dolphm, I'm thinking it makes sense to sign before compression. That way, regardless of compression level the signature is the same. Looks like the effect on size is negligible | 20:02 |
| *** kgriffs_afk is now known as kgriffs | 20:02 | |
| guitarzan | pmathews: thanks | 20:02 |
| *** roeroe has quit IRC | 20:03 | |
| *** lcheng_ has quit IRC | 20:03 | |
| *** mkollaro has quit IRC | 20:04 | |
| *** jmontemayor has quit IRC | 20:04 | |
| dstanek | ayoung: so basically base64(zip(dumps(token_data)))? | 20:04 |
| dstanek | ayoung: so basically base64(zip(sign(dumps(token_data))))? | 20:04 |
| dstanek | missed one | 20:04 |
| ayoung | dstanek, yep code is here: https://review.openstack.org/#/c/71181/3/examples/pki/gen_cmsz.py | 20:04 |
| *** HenryG_ has quit IRC | 20:04 | |
| ayoung | dstanek, the other version I can past | 20:05 |
| ayoung | e | 20:05 |
| *** HenryG_ has joined #openstack-dev | 20:05 | |
| *** HenryG_ has quit IRC | 20:05 | |
| *** jckasper_ has joined #openstack-dev | 20:05 | |
| *** rfolco has quit IRC | 20:05 | |
| *** ashwini has joined #openstack-dev | 20:05 | |
| *** ashwini has left #openstack-dev | 20:05 | |
| ayoung | http://paste.openstack.org/show/62867/ is reversing the operations to compress before signing | 20:05 |
| *** HenryG has joined #openstack-dev | 20:06 | |
| *** caleb_ has quit IRC | 20:06 | |
| *** lcheng_ has joined #openstack-dev | 20:06 | |
| *** aburaschi has joined #openstack-dev | 20:07 | |
| *** luisbg has joined #openstack-dev | 20:08 | |
| *** luisbg has joined #openstack-dev | 20:08 | |
| *** gszasz has joined #openstack-dev | 20:08 | |
| *** jckasper has quit IRC | 20:09 | |
| guitarzan | pmathews: one final question for the day, does the matchmaker file for the scheduler have to include all of the compute (volume) hosts? | 20:09 |
| bknudson | ayoung: the tokens in http://paste.openstack.org/show/62866/ weren't very big... would be more interesting to see what happens to the 8k tokens that are causing problems. | 20:09 |
| guitarzan | or is it nice enough to use the host entry and send it directly? | 20:10 |
| *** bauzas has joined #openstack-dev | 20:10 | |
| ayoung | bknudson, I can do that... | 20:10 |
| *** galstrom is now known as galstrom_zzz | 20:10 | |
| *** _cjones__ has joined #openstack-dev | 20:10 | |
| bknudson | ayoung: just from the data there, 50% compression is pretty good! | 20:10 |
| dstanek | ayoung: what's the loads() followed by a dumps() for? to check for valid JSON? | 20:11 |
| bknudson | try compressing a few more times, might get down to 1 byte. | 20:11 |
| bknudson | or even 1 bit. | 20:11 |
| bknudson | .5 bit | 20:11 |
| *** jmontemayor has joined #openstack-dev | 20:12 | |
| *** jcooley_ has quit IRC | 20:12 | |
| dstanek | ayoung: do you have an example 8k token anywhere? | 20:12 |
| *** jcooley_ has joined #openstack-dev | 20:12 | |
| *** _cjones_ has quit IRC | 20:13 | |
| *** tdruiva has quit IRC | 20:14 | |
| *** dkuffner has joined #openstack-dev | 20:15 | |
| *** dkuffner has quit IRC | 20:16 | |
| *** mkollaro has joined #openstack-dev | 20:16 | |
| *** tdruiva has joined #openstack-dev | 20:16 | |
| *** kenperkins has quit IRC | 20:17 | |
| *** kenperkins has joined #openstack-dev | 20:18 | |
| *** sarob has joined #openstack-dev | 20:18 | |
| *** kenperkins_ has joined #openstack-dev | 20:20 | |
| *** sweston has quit IRC | 20:21 | |
| *** lpaschke has quit IRC | 20:21 | |
| ayoung | dstanek, I can gen one | 20:22 |
| *** caleb_ has joined #openstack-dev | 20:22 | |
| *** RajeshMohan has quit IRC | 20:22 | |
| *** mrda_away is now known as mrda | 20:22 | |
| *** mst89 has quit IRC | 20:23 | |
| *** RajeshMohan has joined #openstack-dev | 20:23 | |
| *** kenperkins has quit IRC | 20:24 | |
| *** tdruiva has quit IRC | 20:24 | |
| *** markmcclain has quit IRC | 20:26 | |
| *** jobewan has joined #openstack-dev | 20:26 | |
| *** jcoufal has joined #openstack-dev | 20:28 | |
| *** Demego has joined #openstack-dev | 20:29 | |
| *** IanGovett has quit IRC | 20:29 | |
| *** Demego has left #openstack-dev | 20:29 | |
| *** gszasz has quit IRC | 20:29 | |
| *** sarob has quit IRC | 20:29 | |
| *** smurugesan has quit IRC | 20:30 | |
| *** krast has quit IRC | 20:30 | |
| *** sarob has joined #openstack-dev | 20:30 | |
| dstanek | ayoung: i did a real quick speed test for each compression level and there really wasn't much difference at all | 20:30 |
| ayoung | dstanek, cool | 20:30 |
| *** Guest93890 is now known as mfisch | 20:31 | |
| *** smurugesan has joined #openstack-dev | 20:31 | |
| dstanek | i was using slightly bogus data and not a real 8k token, but i'm sure the results will still be the same | 20:31 |
| *** mfisch is now known as Guest22857 | 20:31 | |
| *** smurugesan has quit IRC | 20:31 | |
| *** smurugesan has joined #openstack-dev | 20:31 | |
| jog0 | lifeless dhellmann: so after putting together a really ugly proof of concept, I got 15 nova tests to fail | 20:32 |
| jog0 | so success | 20:32 |
| *** _cjones__ has quit IRC | 20:32 | |
| *** ewindisch has quit IRC | 20:32 | |
| *** sarob has quit IRC | 20:34 | |
| *** IanGovett1 has joined #openstack-dev | 20:35 | |
| *** nikhil is now known as nikhil-brb | 20:35 | |
| dhellmann | jog0: congratulations? :-) | 20:35 |
| *** _cjones_ has joined #openstack-dev | 20:35 | |
| dhellmann | jog0: seriously, that sounds like a good debugging aid and something we should have in all the tests | 20:35 |
| *** _cjones_ has quit IRC | 20:36 | |
| *** ewindisch has joined #openstack-dev | 20:36 | |
| ayoung | dstanek, http://paste.openstack.org/show/62873/ | 20:37 |
| ayoung | so a 200k Token can work. Lets crank up the size of the Catalog! | 20:38 |
| *** sweston has joined #openstack-dev | 20:38 | |
| jog0 | dhellmann: pushing up a proof of concept now | 20:38 |
| jog0 | https://review.openstack.org/71645 | 20:38 |
| *** krtaylor has joined #openstack-dev | 20:39 | |
| jog0 | lifeless: ^ your -1 and feedback is much appreciated | 20:39 |
| ayoung | that might not be realistic compression | 20:39 |
| jog0 | dhellmann: right now its a one liner | 20:39 |
| *** nikhil-brb is now known as nikhil | 20:39 | |
| ayoung | my data was bogus...let me try making it a little more realisti | 20:39 |
| *** cadenzajon has quit IRC | 20:40 | |
| *** aburaschi has left #openstack-dev | 20:40 | |
| *** knuppe has quit IRC | 20:40 | |
| dhellmann | jog0: huh, I was expecting more than just "raise", but I guess that makes sense if handleError() is called in the context of an except block | 20:40 |
| *** jamielennox|away is now known as jamielennox | 20:40 | |
| jog0 | dhellmann: yeah its super ugly | 20:41 |
| *** tdruiva has joined #openstack-dev | 20:41 | |
| jog0 | dhellmann: lifeless had a good idea: put this in a fixture and just log the error and continue then print out the errors at the end (from the fixture) | 20:42 |
| jog0 | that way we stay closer to the normal code flow | 20:42 |
| dhellmann | I sort of like raising the exception so it's clear where the bad call is | 20:43 |
| dhellmann | but I see the value of what you're describing, too | 20:43 |
| gyee | ayoung, 50% size reduction with cmsz looks like? | 20:44 |
| ayoung | more I think...gyee | 20:44 |
| ayoung | lemme keep hacking | 20:44 |
| gyee | wow, that's awesome | 20:44 |
| *** colinmcnamara has joined #openstack-dev | 20:46 | |
| *** tzabal has left #openstack-dev | 20:46 | |
| ayoung | gyee 100%? | 20:48 |
| ayoung | gyee, dstanek http://fpaste.org/75096/71972013/ | 20:48 |
| ayoung | it gave me | 20:48 |
| ayoung | http://fpaste.org/75098/39171975/ | 20:49 |
| ayoung | soo 300k down to 3 K | 20:49 |
| *** tdruiva has quit IRC | 20:49 | |
| gyee | ayoung, awesome stuff! | 20:50 |
| gyee | ayoung, this is compression before signing right? | 20:50 |
| ayoung | gyee, actually, its sign and then compress | 20:51 |
| ayoung | that way the signature is the same regardless of compression level | 20:51 |
| ayoung | or even compression algorithm | 20:51 |
| *** morazi has joined #openstack-dev | 20:51 | |
| gyee | ayoung, yeah, that make sense | 20:51 |
| dstanek | very nice | 20:52 |
| ayoung | My guess is a text file converted to ASN has only a slight extra amount of entropy due to the formatting. The patterns of repetition should be the same. | 20:52 |
| *** yolanda has quit IRC | 20:52 | |
| gyee | in the crypto world, entropy is a good thing :D | 20:53 |
| *** dsirrine has quit IRC | 20:54 | |
| *** dramagods has joined #openstack-dev | 20:54 | |
| dstanek | ayoung: i was using this to check speeds http://paste.openstack.org/show/62880/ | 20:54 |
| ayoung | dstanek, output? | 20:55 |
| dstanek | ayoung: http://paste.openstack.org/show/62881/ | 20:55 |
| jamielennox | ayoung: wow, never expected that level of compression | 20:55 |
| *** asalkeld has joined #openstack-dev | 20:55 | |
| ayoung | dstanek, did you compare to just cms signing? | 20:55 |
| ayoung | logic is | 20:56 |
| dstanek | ayoung: that's only doing the zlib | 20:56 |
| *** jcoufal has quit IRC | 20:56 | |
| ayoung | signed = cms.cms_sign_text(text, | 20:56 |
| ayoung | signing_cert_file_name, | 20:56 |
| ayoung | signing_key_file_name) | 20:56 |
| ayoung | token = cms.cms_to_token(signed) | 20:56 |
| ayoung | dstanek, I'll in corporate a speed test | 20:56 |
| dolphm | ayoung: the "token *= 10" i hope that's not what your "compression test" was based on | 20:57 |
| *** vartom1111111117 has quit IRC | 20:57 | |
| dstanek | dolphm: i think he had a real token | 20:57 |
| jamielennox | ayoung: also i don't think that compress then sign will make any difference with the signature as you can't change the signed data | 20:58 |
| dolphm | jamielennox: openssl was refusing to sign binary data, so the order of operations had to be swapped... that's all | 20:59 |
| *** ijw has joined #openstack-dev | 20:59 | |
| *** vkmc has joined #openstack-dev | 20:59 | |
| *** rkukura has quit IRC | 20:59 | |
| ayoung | heh | 20:59 |
| ayoung | dolphm, nah, the problem wasn't that...I think dolphm | 21:00 |
| jamielennox | dolphm: weird, but that makes more sense than signatures | 21:00 |
| *** denis_makogon_ has joined #openstack-dev | 21:00 | |
| *** dvarga is now known as dvarga|away | 21:00 | |
| ayoung | I think there was something else, but it is irrelevant | 21:00 |
| *** dvarga|away is now known as dvarga | 21:00 | |
| *** asalkeld has quit IRC | 21:00 | |
| *** andreaf2 has quit IRC | 21:00 | |
| jamielennox | i don't see that it will make much practical difference | 21:01 |
| dolphm | ayoung: that was the last i heard from you? | 21:01 |
| *** denis_makogon_ is now known as denis_makogon | 21:01 | |
| ayoung | yeah..It seems to be OK with binary data now | 21:01 |
| *** gcha has joined #openstack-dev | 21:01 | |
| jamielennox | it just means if someone were to unzip it then rezip it the ID would change but the otken would still be valid | 21:01 |
| ayoung | I've done compress-> and sign-> compress and both work | 21:01 |
| jamielennox | means that we need to do *actual* cms decrypt for our tokens rather than retrieve them from a db | 21:01 |
| dolphm | ayoung: which one has a better final ration? | 21:01 |
| dolphm | final ratio* | 21:02 |
| *** IanGovett1 has quit IRC | 21:02 | |
| ayoung | jamielennox, yeah. I can work in a comparison of that with the huge token, but since the sign->compress is pretty good | 21:02 |
| *** pixelb has quit IRC | 21:02 | |
| ayoung | dolphm, they were really close...difference of 8 bytes or so | 21:02 |
| ayoung | I'll code up the rest of the comparisons, to include the timing that dstanek was doing for both | 21:02 |
| *** colinmcnamara has quit IRC | 21:02 | |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 21:02 | |
| dolphm | ayoung: dstanek: gating https://review.openstack.org/#/c/71635/ | 21:03 |
| jamielennox | ayoung: yea, if they are that close i'd prefer compress then sign as it will mean we have stable IDs and the outer layer is still CMS which is what we've been telling people to expect | 21:03 |
| *** tjones has joined #openstack-dev | 21:03 | |
| *** sgordon has quit IRC | 21:04 | |
| ayoung | dolphm, so let me get the CMS compression in before we cut a new client. | 21:04 |
| ayoung | jamielennox, ++ | 21:04 |
| *** colinmcnamara has joined #openstack-dev | 21:05 | |
| *** kgriffs is now known as kgriffs_afk | 21:05 | |
| *** nikhil has quit IRC | 21:06 | |
| dolphm | ayoung: have a bp / bug against keystoneclient for compression? | 21:06 |
| dolphm | ayoung: or choose one of the many 8K+ bugs? | 21:06 |
| ayoung | I was doing it against an 8K bug | 21:06 |
| ayoung | but I think I bped it too | 21:07 |
| *** ijw has quit IRC | 21:07 | |
| dolphm | ayoung: link me | 21:07 |
| ayoung | https://blueprints.launchpad.net/keystone/+spec/compress-tokens dolphm | 21:07 |
| dolphm | ayoung: thanks | 21:07 |
| *** vartom1111111117 has joined #openstack-dev | 21:07 | |
| jamielennox | ayoung, dolphm: do we have a standard way to indicate how we will indicate what type of token we are decoding? | 21:08 |
| jamielennox | assuming we will need more later | 21:08 |
| ayoung | jamielennox, the prefix will be different | 21:08 |
| ayoung | MII for the current | 21:08 |
| dolphm | ^ that's a coincidence, remember | 21:08 |
| ayoung | {cmsz} is what I am proposing for these | 21:08 |
| ayoung | dolphm, and a bug | 21:08 |
| jamielennox | dolphm: and it doesn't work if token size > 8k | 21:08 |
| *** ijw has joined #openstack-dev | 21:08 | |
| dolphm | jamielennox: ++ lol | 21:08 |
| ayoung | MIJ if the catalog gets too big. But I've held off on fixing that | 21:08 |
| dolphm | and then MIK | 21:09 |
| dolphm | and then MIL.. | 21:09 |
| jamielennox | MIK is huge | 21:09 |
| dolphm | yep | 21:09 |
| *** alop has quit IRC | 21:09 | |
| *** kgriffs_afk is now known as kgriffs | 21:09 | |
| *** alex_klimov has quit IRC | 21:09 | |
| ayoung | I was going to allow MII and MIJ, | 21:09 |
| dolphm | i wonder where the threshhold for MIH is | 21:09 |
| *** dsirrine has joined #openstack-dev | 21:09 | |
| ayoung | its in the bug | 21:09 |
| ayoung | er comment | 21:09 |
| *** athomas has joined #openstack-dev | 21:09 | |
| ayoung | base64.b64encode(binascii.a2b_hex('3090')) | 21:10 |
| jamielennox | ayoung: ok that's fine - i would just like to see that formalized somewhere - is it three letters, is it up to a hypen or is it dependant on the token format | 21:10 |
| ayoung | jamielennox, in cms.py | 21:10 |
| ayoung | is_asn1_token.py | 21:10 |
| jamielennox | i meant to check what format a token is | 21:10 |
| *** thuc_ has quit IRC | 21:10 | |
| jamielennox | MII vs gzipped etc | 21:11 |
| jamielennox | can we token[:3] and then look that up in a dict? | 21:11 |
| *** YorikSar has quit IRC | 21:11 | |
| *** thuc has joined #openstack-dev | 21:11 | |
| jamielennox | or are we going to have a different format prefix for everything/ | 21:11 |
| ayoung | https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/common/cms.py#L170 | 21:11 |
| ayoung | jamielennox, I think so. We'll have a set of registered token formats. | 21:12 |
| ayoung | we'll grandfather MII and MIJ in | 21:12 |
| dolphm | ayoung: i need something to track against keystoneclient as well | 21:12 |
| ayoung | the rest will be | 21:12 |
| ayoung | {cmsz} | 21:12 |
| dolphm | ayoung: (bp is against the service) | 21:12 |
| *** markwash has quit IRC | 21:12 | |
| ayoung | dolphm, wilco | 21:12 |
| jamielennox | ayoung: yea i know how the MII works - i'm wondering are you doing a 3 letter prefix for zipped tokens as well? | 21:12 |
| ayoung | {cmsz} | 21:13 |
| ayoung | with braces | 21:13 |
| *** nikhil__ has joined #openstack-dev | 21:13 | |
| ayoung | jamielennox, ^^ | 21:13 |
| jamielennox | can we have a variety of token formats that are all led with three characters | 21:13 |
| *** asalkeld has joined #openstack-dev | 21:14 | |
| jamielennox | any reason for the braces? | 21:14 |
| *** colinmcnamara has quit IRC | 21:14 | |
| *** gokrokve has joined #openstack-dev | 21:14 | |
| jamielennox | i'm guessing because they are outside of base64 | 21:14 |
| *** thuc has quit IRC | 21:15 | |
| ayoung | jamielennox, it was jdennis suggestion. Its kindof standard for compression | 21:15 |
| ayoung | norm? | 21:15 |
| *** nikhil__ has quit IRC | 21:16 | |
| *** nikhil__ has joined #openstack-dev | 21:16 | |
| jamielennox | ok, that's cool - as i said i'm just thinking that whatever we use now will be the base for future token formats | 21:16 |
| jamielennox | so we are pretty much saying if you have a new token format you should do {myformat}XXXXXXXXXXXXX | 21:17 |
| dolphm | jamielennox: i'm not sure i would expect all "tokens" to be prefixable | 21:17 |
| *** sarob has joined #openstack-dev | 21:17 | |
| ayoung | dolphm, https://blueprints.launchpad.net/python-keystoneclient/+spec/compress-tokens | 21:17 |
| *** dvarga is now known as dvarga|away | 21:17 | |
| *** dvarga|away is now known as dvarga | 21:17 | |
| dolphm | ayoung: danke | 21:17 |
| ayoung | jamielennox, yes. thats the idea | 21:17 |
| jamielennox | dolphm: i think that if they are issued from keystone we can - and if they are not issued from keystone they shouldn't be using auth_token | 21:18 |
| ayoung | we can grandfather in MII, but it would even be better to add in a new {cms} for the existing format? | 21:18 |
| *** markmcclain has joined #openstack-dev | 21:18 | |
| jamielennox | ayoung: i think we should make auth_token start accepting {cms} but it'll be a long time before we can stop issuing MII | 21:18 |
| ayoung | ++ | 21:19 |
| dolphm | ayoung: don't change the existing format :( | 21:19 |
| ayoung | jamielennox, but it will fix the long token issue for Eventlet | 21:19 |
| ayoung | dolphm, nah, it will be "in addition" | 21:19 |
| dolphm | ayoung: i.e. don't add more than one new variation, especially when one of those variations is no better than an existing one | 21:19 |
| ayoung | dolphm, I can make the client accept either and we can put in a switch to produce either from the server | 21:20 |
| dolphm | that'll just result in bugs | 21:20 |
| ayoung | ++ | 21:20 |
| ayoung | dolphm, won't be in this patch | 21:20 |
| dolphm | ayoung: what was your reasoning for making the existing format an option on the service side? | 21:21 |
| jamielennox | ayoung: okk well keen to see the time differences and the compression comparison | 21:21 |
| jamielennox | i'm not here for another couple of hours | 21:21 |
| dolphm | ayoung: why would anyone *not* want to use compressed tokens, or want to switch back? | 21:21 |
| ayoung | dolphm, I do need to make a change to one function: cms_hash_token(token_id): right now looks for MII... | 21:21 |
| ayoung | dolphm, its a trade off: compression trads off CPU cycles for network traffic | 21:21 |
| dolphm | ayoung: right, but make that configurable with the compression ratio -- but always use compression | 21:22 |
| morganfainberg | ayoung, CPU cycles are very cheap for zilib compression on the scale we're talking about. | 21:22 |
| dolphm | ayoung: even at compression level 1, you're nearly cutting the token size in half | 21:22 |
| morganfainberg | ayoung, especially if we're defaulting to 1 or 0 | 21:22 |
| dolphm | morganfainberg: 6! | 21:22 |
| ayoung | this compression goes to 11 | 21:22 |
| dolphm | morganfainberg: also, 0 makes tokens bigger | 21:22 |
| morganfainberg | dolphm, fair enough, 6 | 21:22 |
| dolphm | morganfainberg: 0 adds some sort of wrapper to the text blob you get it, and then returns that | 21:23 |
| dolphm | give* it | 21:23 |
| morganfainberg | dolphm, i think april fools patch, add a function to make tokens always 11K in size. truncates down if too big, adds zero padding if it's too small | 21:23 |
| morganfainberg | dolphm, we turn our tokens up to 11? /bad reference | 21:23 |
| morganfainberg | oh i blame ayoung ^ subconcious referended it because of that | 21:24 |
| *** krtaylor has quit IRC | 21:24 | |
| ayoung | Twas intentional | 21:24 |
| morganfainberg | ayoung, damnit :P | 21:24 |
| ayoung | You know where you stand in a Hell hole. | 21:24 |
| dolphm | morganfainberg: if you're interested http://pasteraw.com/5cwcs3xfre1r9aoffl0r5jo7ibncjge | 21:24 |
| dolphm | morganfainberg: i can work with that | 21:25 |
| morganfainberg | dolphm, cool | 21:25 |
| *** DinaBelova is now known as DinaBelova_ | 21:25 | |
| dolphm | morganfainberg: i was also thinking of inroducing v4 which does nothing but rename "domains" to "tenants" | 21:26 |
| dolphm | i think that'll go over well | 21:26 |
| jamielennox | i'm sure you know this but 'A'*100 is a really bad test of compression | 21:26 |
| dolphm | jamielennox: that was the intent | 21:26 |
| jamielennox | cool, just still lurking a bit | 21:26 |
| dolphm | jamielennox: it's illustrating the difference between 0 and 1 | 21:26 |
| *** cdub has joined #openstack-dev | 21:27 | |
| *** jcooley_ has quit IRC | 21:28 | |
| dolphm | jamielennox: illustration gets better after you throw in b64 http://pasteraw.com/q0s9jz1yvd6ldzzougazy87cbt5icwy | 21:28 |
| *** tjones has quit IRC | 21:28 | |
| dolphm | a string of length 100 becomes 148 characters long w/ compression level 0 | 21:29 |
| *** jcooley_ has joined #openstack-dev | 21:29 | |
| *** cadenzajon has joined #openstack-dev | 21:29 | |
| *** Gordonz has quit IRC | 21:29 | |
| *** aaronjamesford1 has quit IRC | 21:30 | |
| *** jcoufal-mobile has joined #openstack-dev | 21:31 | |
| *** tjones has joined #openstack-dev | 21:32 | |
| morganfainberg | dolphm, lol | 21:33 |
| *** sarob has quit IRC | 21:33 | |
| *** Guest22857 is now known as mfisch | 21:33 | |
| *** sarob has joined #openstack-dev | 21:33 | |
| *** mfisch has quit IRC | 21:33 | |
| *** mfisch has joined #openstack-dev | 21:33 | |
| *** byeager_ has quit IRC | 21:33 | |
| morganfainberg | dolphm, can we make it so each patchset increments the API version while we're at it. api version = git hash | 21:33 |
| *** d0ugal has joined #openstack-dev | 21:34 | |
| morganfainberg | dolphm or something equally awesome | 21:34 |
| morganfainberg | :) | 21:34 |
| jamielennox | dolphm: lol, how does that happen - i just assumed 0 was stick a standard length zip header in front of the otherwise uncompressed data | 21:34 |
| *** d0ugal has quit IRC | 21:34 | |
| *** d0ugal has joined #openstack-dev | 21:34 | |
| jog0 | dhellmann: I was thinking of something like this https://review.openstack.org/#/c/71645, want to get your feedback before making the oslo patch | 21:34 |
| *** cdub has quit IRC | 21:34 | |
| morganfainberg | dhellmann, for https://review.openstack.org/#/c/66149/ did you want to change the bug report at all? I'm cool with changing it if you're interested in trying to get it in sooner etc. (obv. once it can pass check) | 21:35 |
| dhellmann | morganfainberg: change the bug report? | 21:35 |
| *** dprince has quit IRC | 21:35 | |
| *** d0ugal has quit IRC | 21:35 | |
| *** dramagods has quit IRC | 21:36 | |
| *** e0ne has quit IRC | 21:36 | |
| *** sarob has quit IRC | 21:36 | |
| *** sarob has joined #openstack-dev | 21:37 | |
| *** tqtran1 has joined #openstack-dev | 21:37 | |
| jamielennox | gyee: can you have a look at: https://review.openstack.org/#/c/61247/ it's the dependant of auth plugins so you'll be interested i think (and i want to get these in) | 21:37 |
| dolphm | jamielennox: that's basically what it's doing -- it's just a bulky | 21:38 |
| *** tqtran has quit IRC | 21:38 | |
| dolphm | morganfainberg: then we force people to use discovery, i like it | 21:38 |
| jamielennox | dolphm: oh, right you are base64ing the output - i was thinking you were base64 the input | 21:38 |
| *** alop has joined #openstack-dev | 21:39 | |
| ayoung | dstanek, my brain is rejecting the format of timeit | 21:40 |
| zzelle_ | clarkb, if you want to take a look i add http support to set_hook_commit_msg | 21:41 |
| *** ijw has quit IRC | 21:41 | |
| *** sarob has quit IRC | 21:41 | |
| *** d0ugal has joined #openstack-dev | 21:41 | |
| *** d0ugal has quit IRC | 21:41 | |
| *** d0ugal has joined #openstack-dev | 21:41 | |
| zzelle_ | clarkb, https://review.openstack.org/70746 and jenkins tests didn't failed (strange) | 21:41 |
| clarkb | zzelle_: the tests don't fail 100% of the time which makes them even more annoying. I think it depends on the performance of the slave | 21:42 |
| clarkb | underperforming slaves have gerrit that timesout | 21:42 |
| *** _cjones_ has joined #openstack-dev | 21:42 | |
| *** mgagne has joined #openstack-dev | 21:42 | |
| *** _cjones_ has quit IRC | 21:42 | |
| zzelle_ | clarkb, i get also troubles with one of servers with few memory | 21:43 |
| *** _cjones_ has joined #openstack-dev | 21:43 | |
| dstanek | ayoung: yeah... from the cli it's nice to be able to use it | 21:43 |
| *** byeager has joined #openstack-dev | 21:44 | |
| dstanek | ayoung: like 'python -m timeit "import test" "test.func0()"' | 21:44 |
| *** otherwiseguy has quit IRC | 21:45 | |
| *** tdruiva has joined #openstack-dev | 21:46 | |
| *** mst89 has joined #openstack-dev | 21:49 | |
| *** thouveng has quit IRC | 21:51 | |
| *** thouveng has joined #openstack-dev | 21:51 | |
| *** tmclaugh[work] has quit IRC | 21:52 | |
| *** portante has joined #openstack-dev | 21:53 | |
| *** adnan has joined #openstack-dev | 21:53 | |
| *** adnan has joined #openstack-dev | 21:54 | |
| *** bdpayne has quit IRC | 21:56 | |
| *** gigawhat has quit IRC | 21:56 | |
| ayoung | dstanek, http://paste.openstack.org/show/62892/ gave me http://paste.openstack.org/show/62893/ | 21:57 |
| *** ayoung is now known as ayoung-afk | 21:57 | |
| *** doug_shelley66 has quit IRC | 21:57 | |
| *** bdpayne has joined #openstack-dev | 21:58 | |
| *** dsirrine has quit IRC | 21:58 | |
| *** kolesovdv has joined #openstack-dev | 21:59 | |
| *** mlemay has quit IRC | 22:00 | |
| *** epim has quit IRC | 22:01 | |
| *** epim has joined #openstack-dev | 22:03 | |
| *** shakayumi has joined #openstack-dev | 22:05 | |
| *** jcoufal-mobile has quit IRC | 22:06 | |
| *** chris_johnson has quit IRC | 22:06 | |
| *** achampion has quit IRC | 22:07 | |
| *** dbalog has left #openstack-dev | 22:08 | |
| *** pmathews has quit IRC | 22:08 | |
| *** david_lyle has quit IRC | 22:09 | |
| *** sc68cal_ has quit IRC | 22:10 | |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 22:11 | |
| *** shakayumi has quit IRC | 22:11 | |
| *** vladikr has quit IRC | 22:13 | |
| *** thomasem_ has quit IRC | 22:15 | |
| *** ijw has joined #openstack-dev | 22:20 | |
| lbragstad | stevemar: what do you think about http://paste.openstack.org/show/62897/ to be consistent with https://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3-os-trust-ext.md#trusts | 22:20 |
| *** mfer has quit IRC | 22:21 | |
| *** bswartz has quit IRC | 22:21 | |
| stevemar | lbragstad, i think it's OK, just make sure the heat folks are cool with it. I think they are using trusts? maybe? | 22:22 |
| lbragstad | stevemar: ok, sounds good. Just thinking that way we don't have swap the order like the other night when we were working onthe osc stuff | 22:23 |
| *** vartom1111111117 has quit IRC | 22:23 | |
| *** jdob has quit IRC | 22:23 | |
| *** pmathews has joined #openstack-dev | 22:23 | |
| *** jhesketh__ has joined #openstack-dev | 22:24 | |
| *** RajeshMohan has quit IRC | 22:25 | |
| *** epim has quit IRC | 22:26 | |
| *** RajeshMohan has joined #openstack-dev | 22:26 | |
| *** epim has joined #openstack-dev | 22:27 | |
| *** itzikb has joined #openstack-dev | 22:29 | |
| *** jnoller has quit IRC | 22:29 | |
| *** morazi has quit IRC | 22:29 | |
| *** dvarga has quit IRC | 22:29 | |
| *** hub_cap has joined #openstack-dev | 22:30 | |
| *** pmathews has quit IRC | 22:30 | |
| *** hub_cap has left #openstack-dev | 22:30 | |
| *** tiamar has quit IRC | 22:31 | |
| *** vijendar has quit IRC | 22:33 | |
| *** ekhugen has quit IRC | 22:33 | |
| *** doug_shelley66 has joined #openstack-dev | 22:34 | |
| *** clayb|2 has joined #openstack-dev | 22:35 | |
| *** joesavak has quit IRC | 22:35 | |
| *** clayb has quit IRC | 22:37 | |
| *** xarses has quit IRC | 22:38 | |
| dolphm | lbragstad: the trustor is the person creating the trust -- it shouldn't be part of the manager's api | 22:40 |
| dolphm | lbragstad: the only question is who YOU are delegating to, what you're delegating (roles and/or impersonation), and in what scope (project) | 22:41 |
| *** asalkeld has quit IRC | 22:41 | |
| *** Mandell has quit IRC | 22:41 | |
| *** thuc has joined #openstack-dev | 22:42 | |
| *** otherwiseguy has joined #openstack-dev | 22:42 | |
| *** krtaylor has joined #openstack-dev | 22:43 | |
| *** morazi has joined #openstack-dev | 22:43 | |
| *** thuc_ has joined #openstack-dev | 22:44 | |
| gyee | jamielennox, looking, I was afk | 22:44 |
| *** pmathews has joined #openstack-dev | 22:44 | |
| luisg | markmcclain, i posted a question here for when u get a chance pls: https://review.openstack.org/#/c/66980/ | 22:46 |
| *** thuc has quit IRC | 22:47 | |
| *** JordanRinke_ has quit IRC | 22:47 | |
| *** JordanRinke_ has joined #openstack-dev | 22:48 | |
| *** dstanek is now known as dstanek_afk | 22:49 | |
| morganfainberg | dolphm, ping | 22:50 |
| dolphm | morganfainberg: o/ | 22:50 |
| morganfainberg | https://bugs.launchpad.net/keystone/+bug/1251123 | 22:50 |
| uvirtbot | Launchpad bug 1251123 in keystone/havana "_update_user_list_with_cas causes significant overhead (when using memcached as token store backend)" [High,In progress] | 22:50 |
| morganfainberg | dolphm, that bug in havana can (and does) cause keystone to be completely unresponsive | 22:50 |
| *** tqtran has joined #openstack-dev | 22:50 | |
| morganfainberg | dolphm, is high the correct target prio? | 22:50 |
| *** buzztroll has quit IRC | 22:51 | |
| morganfainberg | dolphm, i know it's been hit by a variety of people. | 22:51 |
| *** xarses has joined #openstack-dev | 22:51 | |
| morganfainberg | dolphm, but i'm not sure what the best course of action is to solve it / get it prioritized for stable branch | 22:51 |
| dolphm | morganfainberg: that would be a critical then | 22:51 |
| morganfainberg | dolphm, ok i wanted to bounce it off you before i changed anyth | 22:51 |
| morganfainberg | g | 22:51 |
| morganfainberg | yanno :) | 22:52 |
| dolphm | morganfainberg: critical in master + havana, i assume? | 22:52 |
| morganfainberg | dolphm, master will be resolved by https://review.openstack.org/#/c/60743/ | 22:52 |
| dolphm | morganfainberg: same issue though, right? | 22:52 |
| morganfainberg | dolphm, i should add closes-bug to that review then | 22:52 |
| morganfainberg | dolphm, yes | 22:52 |
| *** dfarrell07 has quit IRC | 22:52 | |
| morganfainberg | dolphm, very very different fix though, the kvs system (dogpile) can't go in havana. | 22:53 |
| morganfainberg | there was some concern because it wasn't being fixed in master first | 22:53 |
| dolphm | morganfainberg: obligatory question-- can the patch landing in havana be merged to master first? and then the long term change to master/icehouse can land? | 22:53 |
| morganfainberg | dolphm, hm.... it depends on when we're landing the dogpile stuff | 22:53 |
| *** morazi has quit IRC | 22:53 | |
| dolphm | morganfainberg: after the fix for havana? ;) | 22:54 |
| dolphm | it's dumb, i know | 22:54 |
| morganfainberg | dolphm, lol. sure i can rebase chain it in | 22:54 |
| *** Gordonz has joined #openstack-dev | 22:54 | |
| *** tqtran1 has quit IRC | 22:54 | |
| morganfainberg | dolphm, but it will need to go into that chain since the dogpile conversion strips a ton of stuff out. | 22:54 |
| dolphm | morganfainberg: we can at least illustrate it as fixed in master using the same method | 22:54 |
| morganfainberg | dolphm, so i can restructure it all if thats what it'll take | 22:55 |
| dolphm | morganfainberg: fair enough, as long as it's not too late to be an excessive amount of work | 22:55 |
| *** galstrom_zzz is now known as galstrom | 22:55 | |
| dolphm | grammar ^ but you get my point | 22:55 |
| morganfainberg | dolphm, sec. checking on how far diverged we are for the code. | 22:56 |
| morganfainberg | dolphm, ok looks like it's just resolving test changes | 22:58 |
| *** markwash has joined #openstack-dev | 22:58 | |
| morganfainberg | dolphm, code... at least appears to merge cleanly for the driver itself. | 22:59 |
| dolphm | morganfainberg: i'll see about making an exception for this in 2013.2.2 | 22:59 |
| *** tdruiva has quit IRC | 22:59 | |
| dolphm | we're definitely late to the game to request an exception, but i'll try.. | 22:59 |
| morganfainberg | dolphm, this might just need ot be wedged in to the top of the dogpile chain which should incur only 1 change needing "fixes" | 22:59 |
| morganfainberg | dolphm, i know dhellmann requested it as a possible exception on the ML | 22:59 |
| morganfainberg | dolphm, a couple days back? | 22:59 |
| *** david-lyle has joined #openstack-dev | 22:59 | |
| dolphm | so he did! thanks for catching me before i look like an idiot | 23:00 |
| dhellmann | I don't remember seeing a response to the request on the stable maint ML | 23:00 |
| morganfainberg | dolphm, :) | 23:00 |
| morganfainberg | dolphm, ok i'm working on resolving the diff in tests should have this posted (and dogpile chain rebased) shortly | 23:01 |
| morganfainberg | i'll also bump this ot critical on LP while i'm looking at it base don this discussion | 23:01 |
| *** markmcclain has quit IRC | 23:02 | |
| dolphm | morganfainberg: comment as to why | 23:02 |
| *** caleb_ has quit IRC | 23:02 | |
| morganfainberg | dolphm, yep | 23:02 |
| *** Gordonz has quit IRC | 23:02 | |
| *** pixelb has joined #openstack-dev | 23:02 | |
| dolphm | i'll just link to your comment on stable-maint list | 23:02 |
| *** amcrn has quit IRC | 23:03 | |
| lbragstad | dolphm: so it shouldn't be used in create_trust from the keystoneclient perspective since that can be assumed from the user, correct? | 23:03 |
| dolphm | lbragstad: technically the service should just be looking at the user in context and setting that attribute dynamically, but for whatever reason that didn't happen. the client should at least implement that behavior so that users don't have to | 23:04 |
| dolphm | lbragstad: make sense? | 23:04 |
| *** peristeri has quit IRC | 23:04 | |
| *** epim has quit IRC | 23:04 | |
| lbragstad | dolphm: yeah | 23:05 |
| *** salv-orlando has joined #openstack-dev | 23:05 | |
| *** amcrn has joined #openstack-dev | 23:06 | |
| *** yeylon__ has quit IRC | 23:06 | |
| morganfainberg | dolphm, commented (sorry 2 comments) on the bug | 23:07 |
| morganfainberg | back to resolving the test changes for master. | 23:07 |
| dolphm | omg -2 comment abuse | 23:07 |
| *** dkranz has quit IRC | 23:08 | |
| *** tdruiva has joined #openstack-dev | 23:08 | |
| *** venkatesh has joined #openstack-dev | 23:09 | |
| *** jayg is now known as jayg|g0n3 | 23:09 | |
| *** epim has joined #openstack-dev | 23:09 | |
| *** enikanorov has joined #openstack-dev | 23:11 | |
| morganfainberg | dolphm, LOL. | 23:11 |
| *** eharney has quit IRC | 23:11 | |
| *** enikanorov__ has quit IRC | 23:12 | |
| lbragstad | dolphm: looks like the trust code (controllers.py for trusts) grabs the user_id from context. I'll remove 'trustor' from the clients and see what kind of gap there is. | 23:14 |
| yjiang5 | baoli: hi | 23:14 |
| *** xqueralt has quit IRC | 23:15 | |
| *** burt1 has quit IRC | 23:16 | |
| *** alex_xu has quit IRC | 23:17 | |
| dolphm | lbragstad: hmm... do you not need to provide it on POST then? | 23:17 |
| dolphm | lbragstad: what do API tests in keystone do? | 23:17 |
| dolphm | lbragstad: ... maybe this is all just deja vu for me | 23:17 |
| dolphm | morganfainberg: will this be the first patch after the destined-for-havana-patch-to-master? https://review.openstack.org/#/c/70522/ | 23:18 |
| morganfainberg | dolphm, yes | 23:18 |
| morganfainberg | i'm about to rebase it. | 23:18 |
| morganfainberg | unless you want to just hold it | 23:19 |
| dolphm | morganfainberg: i'm about to walk out the door, so i was going to pin the code review for later | 23:19 |
| *** asalkeld has joined #openstack-dev | 23:19 | |
| morganfainberg | dolphm, sure sounds good i'll rebase the change-chain | 23:19 |
| morganfainberg | dolphm, should likely be clean rebasing | 23:19 |
| *** asalkeld has quit IRC | 23:19 | |
| *** asalkeld has joined #openstack-dev | 23:20 | |
| *** buzztroll has joined #openstack-dev | 23:22 | |
| dolphm | morganfainberg: famous last words | 23:22 |
| morganfainberg | dolphm, lol | 23:22 |
| *** eglynn has joined #openstack-dev | 23:22 | |
| *** buzztroll has quit IRC | 23:23 | |
| *** buzztroll has joined #openstack-dev | 23:23 | |
| *** rcleere has quit IRC | 23:24 | |
| *** lbragstad has quit IRC | 23:24 | |
| *** jckasper_ has quit IRC | 23:25 | |
| *** romcheg_ltp has quit IRC | 23:26 | |
| *** kgriffs is now known as kgriffs_afk | 23:26 | |
| morganfainberg | vishy, ping | 23:26 |
| *** jobewan has quit IRC | 23:27 | |
| *** pixelb has quit IRC | 23:27 | |
| morganfainberg | vishy, for https://review.openstack.org/#/c/66149/ i just responded to your comment as i just remembered why i did the parse_isotime bit | 23:29 |
| *** Shaan7 has quit IRC | 23:30 | |
| *** dims has quit IRC | 23:30 | |
| *** tdruiva has quit IRC | 23:31 | |
| *** julienvey has quit IRC | 23:32 | |
| *** otherwiseguy has quit IRC | 23:32 | |
| *** byeager has quit IRC | 23:32 | |
| *** aveiga has joined #openstack-dev | 23:33 | |
| *** kevinconway has quit IRC | 23:34 | |
| *** achampion has joined #openstack-dev | 23:34 | |
| *** jmontemayor has quit IRC | 23:35 | |
| *** prad_ has quit IRC | 23:35 | |
| *** adreznec has quit IRC | 23:35 | |
| *** sweston has quit IRC | 23:35 | |
| *** jmontemayor has joined #openstack-dev | 23:35 | |
| *** SumitNaiksatam has quit IRC | 23:36 | |
| *** xarses has quit IRC | 23:36 | |
| *** cagrev__ has quit IRC | 23:37 | |
| *** cagrev__ has joined #openstack-dev | 23:37 | |
| *** asalkeld has quit IRC | 23:39 | |
| *** jmontemayor has quit IRC | 23:39 | |
| devoid | so, uhh, does heat not use the operating system DNS resolution tools? | 23:40 |
| *** sarob has joined #openstack-dev | 23:40 | |
| devoid | heat-engine to be specific | 23:40 |
| *** adnan has quit IRC | 23:41 | |
| *** denis_makogon has quit IRC | 23:41 | |
| *** lcheng_ has quit IRC | 23:42 | |
| *** eglynn has quit IRC | 23:42 | |
| *** cagrev__ has quit IRC | 23:43 | |
| *** itzikb has quit IRC | 23:44 | |
| *** sarob has quit IRC | 23:45 | |
| *** dims has joined #openstack-dev | 23:46 | |
| *** tanisdl has quit IRC | 23:47 | |
| *** changbl has quit IRC | 23:47 | |
| *** buzztroll has quit IRC | 23:48 | |
| *** buzztroll has joined #openstack-dev | 23:48 | |
| *** yamahata has quit IRC | 23:49 | |
| *** xarses has joined #openstack-dev | 23:49 | |
| *** reed has quit IRC | 23:50 | |
| *** changbl has joined #openstack-dev | 23:51 | |
| *** radsy has joined #openstack-dev | 23:51 | |
| *** galstrom is now known as galstrom_zzz | 23:51 | |
| *** asalkeld has joined #openstack-dev | 23:52 | |
| *** IanGovett has joined #openstack-dev | 23:52 | |
| *** bauzas has quit IRC | 23:53 | |
| *** cnesa has joined #openstack-dev | 23:54 | |
| *** Mandell has joined #openstack-dev | 23:55 | |
| *** thuc_ has quit IRC | 23:55 | |
| *** thuc has joined #openstack-dev | 23:56 | |
| *** SumitNaiksatam has joined #openstack-dev | 23:56 | |
| *** thuc has quit IRC | 23:56 | |
| *** kgriffs_afk is now known as kgriffs | 23:57 | |
| *** thuc has joined #openstack-dev | 23:57 | |
| *** byeager has joined #openstack-dev | 23:58 | |
| *** bknudson has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!