*** e0ne has quit IRC | 00:00 | |
*** e0ne has joined #openstack-dev | 00:00 | |
*** rraja has quit IRC | 00:00 | |
*** giulivo has quit IRC | 00:00 | |
*** sn6i23a has joined #openstack-dev | 00:01 | |
*** novas0x2a|laptop has quit IRC | 00:02 | |
*** nelsnelson is now known as nelsnelson_away | 00:03 | |
*** nelsnelson_away is now known as nelsnelson | 00:03 | |
*** erkrnt has joined #openstack-dev | 00:04 | |
*** diogogmt has quit IRC | 00:04 | |
*** david-lyle_ has quit IRC | 00:05 | |
*** e0ne has quit IRC | 00:05 | |
*** erkrnt has left #openstack-dev | 00:05 | |
*** redhat has joined #openstack-dev | 00:09 | |
*** pmathews has quit IRC | 00:11 | |
*** Longgeek has joined #openstack-dev | 00:12 | |
*** pmathews has joined #openstack-dev | 00:13 | |
*** julienvey_ has quit IRC | 00:13 | |
tqtran | Currently, you have to know in advance the contribute properties in Workflows.step in Horizon. Im trying to dynamically change the Workflows.Step contribute property base on a response of a request. Does python guru know how to achieve this? | 00:16 |
---|---|---|
*** gordc has quit IRC | 00:16 | |
*** markwash has quit IRC | 00:16 | |
*** Longgeek has quit IRC | 00:18 | |
*** markwash has joined #openstack-dev | 00:18 | |
*** morazi has quit IRC | 00:18 | |
*** moted has quit IRC | 00:19 | |
*** moted has joined #openstack-dev | 00:19 | |
*** edmund has quit IRC | 00:20 | |
*** safchain has quit IRC | 00:20 | |
*** sthaha has joined #openstack-dev | 00:26 | |
*** pmathews has quit IRC | 00:27 | |
*** nkinder has joined #openstack-dev | 00:32 | |
bknudson | henrynash: https://review.openstack.org/#/c/65725/ | 00:33 |
bknudson | this is changing the query parameter matching function, similar to change in filtering. | 00:34 |
*** novas0x2a|laptop has joined #openstack-dev | 00:36 | |
*** xchu_ has joined #openstack-dev | 00:39 | |
*** bauzas has quit IRC | 00:39 | |
*** sandywalsh has quit IRC | 00:42 | |
*** rnirmal has quit IRC | 00:45 | |
*** radez_g0n3 is now known as radez | 00:45 | |
*** markmcclain has joined #openstack-dev | 00:48 | |
*** cdub has joined #openstack-dev | 00:52 | |
*** joesavak has joined #openstack-dev | 00:55 | |
*** jsavak has joined #openstack-dev | 00:57 | |
*** yongli has quit IRC | 00:59 | |
*** joesavak has quit IRC | 01:00 | |
*** topol has joined #openstack-dev | 01:01 | |
*** yongli has joined #openstack-dev | 01:01 | |
*** benrodrigue has joined #openstack-dev | 01:04 | |
henrynash | bknudson: so I'm OK with changing it if we decide that's right…the filtering change isn't actually doing that (it was like that before I think, I just made it a utile function) | 01:07 |
*** asalkeld has joined #openstack-dev | 01:10 | |
*** mikeoutland has quit IRC | 01:12 | |
*** alex_xu has joined #openstack-dev | 01:14 | |
*** arosen1 has quit IRC | 01:14 | |
henrynash | bknudson: on the filtering patch…we trying to get this in before the I2 freeze…so I'm fine with us looking at the change in boolean interpretation as a patch on top of the filtering one | 01:15 |
bknudson | henrynash: ok, but one doesn't contradict the other one? | 01:16 |
bknudson | one of your comments was something like "this is the way we agreed to do it." | 01:16 |
*** cdub has quit IRC | 01:16 | |
*** Longgeek has joined #openstack-dev | 01:17 | |
henrynash | bknudson: well, the filtering one doesn't change the existing interoperation (remember we already filter today…it's just only done in the controller)….all I did was move that code to utils | 01:17 |
bknudson | henrynash: https://review.openstack.org/#/c/43257/50/keystone/common/utils.py | 01:17 |
henrynash | bknudsonL it used to be in the controller | 01:17 |
*** krotscheck has quit IRC | 01:17 | |
bknudson | henrynash: ok, I at least wanted you two to know about each other's patches so we didn't wipe out a change in a merge conflict | 01:18 |
bknudson | that could be avoided by rebasing one on the other. | 01:18 |
Steap | Does anyone know what the signatures are supposed to be for functions in middleware/memcache_crypt.py ? | 01:18 |
Steap | That'd help me quite a lot with https://review.openstack.org/#/c/67199/ | 01:19 |
*** arosen1 has joined #openstack-dev | 01:19 | |
henrynash | bknudson: that logic reflected what we discussed way back when…although many people would like to change that…and I'm fine with that….we should discuss that on its merits - and it is totally independent on move filtering support into drivers | 01:19 |
henrynash | bknudson: but , absolutely, good to make sure they don't collide…. | 01:19 |
bknudson | the change to move the function could be split out into its own commit | 01:20 |
henrynash | bknudson: sure…I guess…but don't we have literally less than 24 hours to get this all in…seems like a lot of work.... | 01:21 |
*** Longgeek has quit IRC | 01:22 | |
bknudson | henrynash: I thought this should have been merged back in sept. | 01:23 |
henrynash | bknudson: I agree with you :-) | 01:23 |
henrynash | bknduson: but it got put on hold till after the summit because we were meant to discuss filtering/paging etc. | 01:24 |
henrynash | bknudson: then that never happened….and I've been pulled off on other stuff for the last few months…. | 01:25 |
*** pixelb has joined #openstack-dev | 01:25 | |
*** markmcclain has quit IRC | 01:25 | |
*** jsavak has quit IRC | 01:28 | |
bknudson | henrynash: if you need help polishing something up next time, I could have made some time. | 01:30 |
henrynash | bknudson: ok, thanks….appreciate that | 01:31 |
jamielennox | bknudson: does the breakdown of patches in https://review.openstack.org/#/c/60751/ make sense to you or not worth it? | 01:33 |
*** arosen1 has quit IRC | 01:33 | |
jamielennox | (the reviewer who suggested splitting it) | 01:33 |
*** pixelb has quit IRC | 01:34 | |
*** david-lyle_ has joined #openstack-dev | 01:34 | |
jamielennox | i'm not sure if it makes any difference | 01:34 |
bknudson | jamielennox: I suggested splitting https://review.openstack.org/#/c/60751/ ? | 01:34 |
jamielennox | no | 01:34 |
bknudson | in irc or something? | 01:34 |
jamielennox | someone else | 01:34 |
jamielennox | bknudson: but that's kindof your department so i was just checking if you agreed :) | 01:34 |
bknudson | jamielennox: what's the suggestion? | 01:35 |
jamielennox | 3 reviews, interfaces, v2 plugin, v3 plugin | 01:35 |
bknudson | jamielennox: well, it is 1200 changed lines... | 01:36 |
jamielennox | there's 400 odd lines of testing added | 01:36 |
bknudson | jamielennox: https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ | 01:37 |
bknudson | 1. Review fewer than 200–400 lines of code at a time | 01:37 |
jamielennox | fair enough - what ever gets it looked at i guess is good | 01:37 |
bknudson | so for reviewers it's best to limit the changes to 200-400 lines | 01:37 |
*** jaypipes has quit IRC | 01:37 | |
jamielennox | there is a fairly large hack involved in that review that i think the significance of might be missed if i split it | 01:38 |
jamielennox | bknudson: ok, i'll split it | 01:38 |
*** galstrom_zzz is now known as galstrom | 01:38 | |
*** galstrom is now known as galstrom_zzz | 01:39 | |
ayoung | bknudson, only 60 comments? This thing is as good as merged | 01:41 |
*** xuhanp_ has joined #openstack-dev | 01:41 | |
jamielennox | ayoung: lol | 01:41 |
*** neelashah has joined #openstack-dev | 01:42 | |
bknudson | ayoung: they're all pretty easy comments to take care of... it does look good in general | 01:42 |
bknudson | the most confusing part was the config option for disabling whatever. | 01:42 |
ayoung | bknudson, I just finished up adding some more tests. I had missed domain disable as a revoke event | 01:42 |
ayoung | there is going to be a lag between a domain disable and an enable event that will allow domain scoped tokens going through | 01:43 |
ayoung | there is no way to remove a revoke event | 01:43 |
ayoung | revoke_by_id? | 01:43 |
*** neelashah has quit IRC | 01:43 | |
ayoung | yeah, I am not wedded to that name, but if we are going to change it, we need to change it now bknudson | 01:43 |
bknudson | ayoung: yes, the revoke_by_id option... not sure what the point of it is. | 01:43 |
*** neelashah has joined #openstack-dev | 01:44 | |
ayoung | bknudson, it removes the existing revoke behavior | 01:44 |
bknudson | seems like we can add a config option in m3. | 01:44 |
ayoung | that is what leads to the need for the token lists | 01:44 |
ayoung | can't test the existing code if that is there | 01:44 |
ayoung | it deletes the tokens we want to compare | 01:44 |
*** sn6i23a has quit IRC | 01:44 | |
bknudson | so it's just for testing and not for customers? | 01:45 |
bknudson | doesn't really need to be a config option then | 01:45 |
ayoung | no, it will be for customers | 01:45 |
bknudson | could be a global variable. | 01:45 |
ayoung | not all of the functionality for it is written, | 01:45 |
ayoung | just the minimal | 01:45 |
ayoung | without it, this patch is untestable, though, and I would not trust it | 01:46 |
*** bdpayne has quit IRC | 01:46 | |
ayoung | bknudson, eventually, that switch will mean "don't record the tokens lists in the backend" | 01:48 |
bknudson | ayoung: I like that name better | 01:48 |
*** arosen1 has joined #openstack-dev | 01:48 | |
ayoung | what name? | 01:49 |
bknudson | although it seems like it would be better to have a different token backend. | 01:49 |
bknudson | ayoung: dont_record_the_tokens_lists_in_the_backend" | 01:49 |
*** xingchao has joined #openstack-dev | 01:49 | |
ayoung | bknudson, well, they are there in order to support "revoke_tokens_by_id" | 01:50 |
*** krotscheck has joined #openstack-dev | 01:50 | |
*** coolsvap has quit IRC | 01:51 | |
*** _cjones_ has quit IRC | 01:52 | |
*** xarses has quit IRC | 01:52 | |
*** _cjones_ has joined #openstack-dev | 01:53 | |
ayoung | bknudson, we don't have a name for the existing token revoke mechanism. I would have called it V2 token revocations, but we have them in V3 | 01:53 |
ayoung | so revoke_by_id is the clearest I had | 01:53 |
*** zhikunliu has joined #openstack-dev | 01:56 | |
*** _cjones_ has quit IRC | 01:57 | |
*** e0ne has joined #openstack-dev | 01:57 | |
*** krotscheck has quit IRC | 01:58 | |
*** nosnos has joined #openstack-dev | 01:59 | |
*** otherwiseguy has quit IRC | 02:00 | |
*** yaguang has joined #openstack-dev | 02:01 | |
*** e0ne has quit IRC | 02:02 | |
*** arosen1 has quit IRC | 02:04 | |
*** benrodrigue has quit IRC | 02:04 | |
*** mkollaro has joined #openstack-dev | 02:05 | |
*** dave_tucker is now known as dave_tucker_zzz | 02:08 | |
henrynash | bknudson: so given that my patch isn't changing the boolean interoperation…is there a reason why you still have a -1 on it? | 02:11 |
*** angdraug has quit IRC | 02:11 | |
*** otherwiseguy has joined #openstack-dev | 02:12 | |
*** gordc has joined #openstack-dev | 02:12 | |
*** jhesketh__ has quit IRC | 02:13 | |
*** morganfainberg|z is now known as morganfainberg | 02:13 | |
morganfainberg | hm. | 02:13 |
bknudson | henrynash: nope. all my comments have been addressed. | 02:13 |
morganfainberg | oh hi! | 02:13 |
henrynash | bknudson: ok, great, thx | 02:14 |
henrynash | dolphm: ping | 02:16 |
*** arosen1 has joined #openstack-dev | 02:23 | |
*** Oneiroi has quit IRC | 02:24 | |
ayoung | bknudson, so the line environment.use_eventlet(monkeypatch_thread=False) needs to be called for all code paths. It is currently skipped in the test_auth path, and without the CMS patching is not done | 02:26 |
*** csd has quit IRC | 02:26 | |
ayoung | I'm not totally happy with that approach (forcing patching one way or the other) but someone broke it. It only shows if you run just test_auth | 02:27 |
*** mkollaro has quit IRC | 02:27 | |
*** colinmcnamara has quit IRC | 02:28 | |
*** yamahata has quit IRC | 02:29 | |
*** colinmcnamara has joined #openstack-dev | 02:29 | |
*** Oneiroi has joined #openstack-dev | 02:32 | |
*** arosen1 has quit IRC | 02:33 | |
*** vkozhukalov has joined #openstack-dev | 02:34 | |
*** neoXsys has quit IRC | 02:35 | |
*** jhesketh__ has joined #openstack-dev | 02:37 | |
*** amcrn has joined #openstack-dev | 02:40 | |
*** jasondotstar has joined #openstack-dev | 02:40 | |
*** gordc has quit IRC | 02:40 | |
*** Mandell has quit IRC | 02:41 | |
*** arosen1 has joined #openstack-dev | 02:42 | |
*** xingchao has quit IRC | 02:42 | |
*** xingchao has joined #openstack-dev | 02:43 | |
*** tqtran has quit IRC | 02:48 | |
*** xarses has joined #openstack-dev | 02:48 | |
*** sn6i23a has joined #openstack-dev | 02:48 | |
*** dkranz has joined #openstack-dev | 02:48 | |
*** david_paterson has quit IRC | 02:49 | |
*** mrda_ is now known as mrda_away | 02:49 | |
*** mrda_away is now known as mrda_ | 02:49 | |
*** sdake has quit IRC | 02:49 | |
*** arosen1 has quit IRC | 02:51 | |
*** asalkeld has quit IRC | 02:51 | |
*** erkules_ has joined #openstack-dev | 02:53 | |
bknudson | ayoung: I think I've hit the problem running a subset of tests before too. | 02:53 |
ayoung | bknudson, I think the refactoring pulled too much into the fixtures. THis is a simple fix to keep development going | 02:54 |
*** lbragstad has joined #openstack-dev | 02:55 | |
*** erkules has quit IRC | 02:55 | |
*** markmcclain has joined #openstack-dev | 02:57 | |
*** e0ne has joined #openstack-dev | 02:57 | |
*** markmcclain1 has joined #openstack-dev | 02:59 | |
*** pmathews has joined #openstack-dev | 03:01 | |
*** markmcclain has quit IRC | 03:02 | |
*** e0ne has quit IRC | 03:02 | |
*** markmcclain1 has quit IRC | 03:03 | |
*** rods has quit IRC | 03:05 | |
*** dkranz has quit IRC | 03:05 | |
*** radez is now known as radez_g0n3 | 03:06 | |
*** ramishra has joined #openstack-dev | 03:06 | |
*** ramishra_ has joined #openstack-dev | 03:08 | |
ayoung | bknudson, jamielennox what was the reolution to the whole "append Z to time" issue? Should the times always have Z or never Have Z in string form? | 03:10 |
ayoung | morganfainberg, ^^ | 03:10 |
jamielennox | ayoung, i can't remember which we decided was correct | 03:10 |
*** kushal has quit IRC | 03:11 | |
jamielennox | i think if you just use the function from OSLO then at least it is standard | 03:11 |
*** ramishra has quit IRC | 03:11 | |
morganfainberg | this was a rabbit hole... with some very odd specifics, though I am not sure there is a reason why Z can't be included. | 03:11 |
morganfainberg | let me 2x check rfc, but Wikipedia says Z is just utc designator | 03:13 |
ayoung | jamielennox, which function? | 03:13 |
morganfainberg | ayoung, http://www.w3.org/TR/NOTE-datetime - Times are expressed in UTC (Coordinated Universal Time), with a special UTC designator ("Z"). | 03:14 |
ayoung | self.revoked_at = timeutils.isotime() | 03:14 |
morganfainberg | ayoung, i think that means Z is correct for our usecases | 03:14 |
*** buzztroll has quit IRC | 03:14 | |
ayoung | We should just have a damn date object instead of all this string parsing but our code base is so functionally decomposed | 03:15 |
jamielennox | ayoung: i think i was using strtime, but i can't remember why | 03:15 |
jamielennox | oh, because jsonutils says turn datetime into string using strftime | 03:16 |
morganfainberg | jamielennox, yes | 03:16 |
ayoung | Nah, I am using str(object) | 03:17 |
*** arosen1 has joined #openstack-dev | 03:19 | |
*** paragan has joined #openstack-dev | 03:20 | |
morganfainberg | ayoung, i think timeutils has a utility to convert to the correct iso8601 format | 03:21 |
morganfainberg | ayoung, doesn't str(datetime_obj) end up with... other results? | 03:21 |
ayoung | morganfainberg, yeah...I was not using it. THat was the problem | 03:21 |
*** emagana has quit IRC | 03:21 | |
*** Longgeek has joined #openstack-dev | 03:21 | |
*** AlanClark has quit IRC | 03:22 | |
morganfainberg | ah | 03:23 |
morganfainberg | yeah, use that function :) | 03:23 |
*** ytwu has joined #openstack-dev | 03:24 | |
ayoung | Argh isotime chops the millis | 03:25 |
morganfainberg | nah, subsecond=True | 03:25 |
morganfainberg | you need to specify it | 03:25 |
*** colinmcnamara has quit IRC | 03:27 | |
*** Longgeek has quit IRC | 03:28 | |
*** reed has quit IRC | 03:30 | |
*** doug_shelley66 has quit IRC | 03:32 | |
*** yamahata has joined #openstack-dev | 03:32 | |
*** mikeoutland has joined #openstack-dev | 03:33 | |
*** carl_baldwin has joined #openstack-dev | 03:37 | |
*** carl_baldwin has quit IRC | 03:40 | |
*** salv-orlando has quit IRC | 03:42 | |
*** salv-orlando has joined #openstack-dev | 03:42 | |
*** asalkeld has joined #openstack-dev | 03:45 | |
*** arosen1 has left #openstack-dev | 03:45 | |
*** carl_baldwin has joined #openstack-dev | 03:47 | |
ayoung | bknudson, dstanek Alright python gurus...how do I do this as a single liner | 03:48 |
ayoung | found = False | 03:48 |
ayoung | for e in events: | 03:48 |
ayoung | if (e['user_id'] == user_id and e['expires_at'] == expires_at): | 03:48 |
ayoung | found = True | 03:48 |
bknudson | found = any([e['user_id'] == user_id and e['expires_at'] == expires_at for e in events]) ? | 03:49 |
bknudson | ayoung: ^ | 03:50 |
dstanek | ayoung: something like - any((e['user_id'] == user_id and e['expires_at'] == expires_at) for e in events) | 03:50 |
morganfainberg | bknudson, beat me to it | 03:50 |
dstanek | :-) | 03:50 |
*** novas0x2a|laptop has quit IRC | 03:50 | |
morganfainberg | though, I'd contest that that is not exactly super readable | 03:50 |
bknudson | dstanek: it's got to be correct | 03:50 |
*** xchu_ has quit IRC | 03:50 | |
ayoung | Nope | 03:50 |
lbragstad | morganfainberg: ++ | 03:50 |
lbragstad | ayoung: any particular reason you need it to be one line? | 03:51 |
ayoung | nope | 03:51 |
ayoung | just trying to finally learn python | 03:51 |
lbragstad | :) just for the fun of it? | 03:51 |
ayoung | think it will look good on my resume | 03:51 |
morganfainberg | ayoung, eh, i think Ruby might be a better bet... or you know PHP | 03:51 |
ayoung | Ada | 03:52 |
ayoung | can get those lush DoD jobs | 03:52 |
*** mikeoutland has quit IRC | 03:52 | |
ayoung | course, my secret clearance has lapsed | 03:52 |
*** asalkeld has quit IRC | 03:52 | |
*** buzztroll has joined #openstack-dev | 03:52 | |
*** dkranz has joined #openstack-dev | 03:52 | |
bknudson | at college Ada was first CSci class... never used it since.. | 03:52 |
morganfainberg | never learned Ada in college. | 03:52 |
bknudson | it was supposed to be the wave of the future | 03:53 |
bknudson | govt was going to require it for everything | 03:53 |
bknudson | same with POSIX | 03:53 |
morganfainberg | i am tempted every now and again to learn erlang. | 03:53 |
morganfainberg | then i go and look at examples and come back to python | 03:53 |
bknudson | with erlang we could replace the running code on the system. | 03:54 |
lbragstad | In college, we had a professor who was hell bent on getting us to write a video game using lamda moo http://en.wikipedia.org/wiki/LambdaMOO | 03:54 |
*** alex_klimov has joined #openstack-dev | 03:54 | |
morganfainberg | bknudson, but it would require us to write erlang | 03:54 |
morganfainberg | lbragstad, ugh, lambdamoo is such a ... trainwreck. | 03:54 |
lbragstad | array indexing starts at one... | 03:55 |
morganfainberg | lbragstad, (disclaimer: I got paid for a while to write C to extend that and crazy Mud code bases) | 03:55 |
lbragstad | lol really?! | 03:55 |
morganfainberg | yeah | 03:55 |
morganfainberg | ported/enhanced some of the hot-reboot codes etc | 03:55 |
*** rohitk has joined #openstack-dev | 03:55 | |
morganfainberg | did some malloc replacement in i think Dikumud based stuff to help isolate memory leaks | 03:56 |
lbragstad | morganfainberg: nice | 03:56 |
*** mriedem has quit IRC | 03:56 | |
morganfainberg | lbragstad, and by malloc replacement, i mean... why would you do that terrible macro... do something else | 03:56 |
lbragstad | morganfainberg: :) | 03:57 |
*** e0ne has joined #openstack-dev | 03:57 | |
morganfainberg | lbragstad, but.. i'll stand by the trainwreck comment | 03:57 |
ayoung | OK, so I just confirmed that revoking one token revokes all of the tokens with the same user/expiry | 03:57 |
* ayoung happy | 03:57 | |
morganfainberg | ayoung, yay! | 03:58 |
* lbragstad stands next morganfainberg 's trainwreck comment too | 03:58 | |
*** marun has joined #openstack-dev | 04:00 | |
morganfainberg | wow, i feel brain fried today | 04:01 |
morganfainberg | good thing i had the day off. | 04:01 |
lbragstad | morganfainberg: I hear yeah, I've looked at henrynash 's stuff a few times today | 04:01 |
*** e0ne has quit IRC | 04:02 | |
morganfainberg | lbragstad, i didn't even get to that today. ran errands then it was suddenly like 6pm | 04:02 |
morganfainberg | now it's like 8. | 04:02 |
lbragstad | I forget you're two hours later | 04:02 |
morganfainberg | lol yeah SoCal | 04:03 |
morganfainberg | it also means i'ts like 80 degrees here durning the day | 04:03 |
*** matiu has joined #openstack-dev | 04:03 | |
lbragstad | nice | 04:03 |
*** aditirav has joined #openstack-dev | 04:04 | |
morganfainberg | i like cold weather :P | 04:04 |
lbragstad | we have plenty of it up here if you want some | 04:04 |
morganfainberg | send some to SoCal | 04:04 |
*** aditirav has quit IRC | 04:04 | |
morganfainberg | especially if there is rain involved/... or snow | 04:04 |
lbragstad | .. lots of snow | 04:04 |
morganfainberg | heck to california in general | 04:04 |
*** aditirav has joined #openstack-dev | 04:04 | |
morganfainberg | please send us some... we need it :P | 04:05 |
*** asalkeld has joined #openstack-dev | 04:05 | |
topol | we have snow coming too. I hate snow | 04:05 |
*** reed has joined #openstack-dev | 04:08 | |
*** marun has quit IRC | 04:12 | |
*** marun has joined #openstack-dev | 04:13 | |
*** marun has quit IRC | 04:14 | |
*** alex_klimov has quit IRC | 04:15 | |
*** sn6i23a has quit IRC | 04:15 | |
*** marun has joined #openstack-dev | 04:16 | |
*** redhat has quit IRC | 04:19 | |
*** krotscheck has joined #openstack-dev | 04:19 | |
*** ArxCruz has quit IRC | 04:20 | |
*** aeperezt has quit IRC | 04:24 | |
*** krotscheck has quit IRC | 04:24 | |
*** bdpayne has joined #openstack-dev | 04:25 | |
*** Longgeek has joined #openstack-dev | 04:26 | |
*** krotscheck has joined #openstack-dev | 04:27 | |
*** emagana has joined #openstack-dev | 04:32 | |
*** Longgeek has quit IRC | 04:32 | |
*** mikeoutland has joined #openstack-dev | 04:35 | |
*** emagana has quit IRC | 04:37 | |
*** coolsvap has joined #openstack-dev | 04:38 | |
*** alex_klimov has joined #openstack-dev | 04:38 | |
*** Ryan_Lane has joined #openstack-dev | 04:39 | |
*** ramishra_ has quit IRC | 04:40 | |
*** mikeoutland has quit IRC | 04:41 | |
*** alex_klimov has quit IRC | 04:44 | |
*** alex_klimov has joined #openstack-dev | 04:44 | |
*** asalkeld has quit IRC | 04:45 | |
*** erkrnt has joined #openstack-dev | 04:45 | |
*** erkrnt has quit IRC | 04:46 | |
*** alex_klimov1 has joined #openstack-dev | 04:46 | |
*** alex_klimov has quit IRC | 04:46 | |
*** rohitk has quit IRC | 04:47 | |
*** buzztroll has quit IRC | 04:51 | |
*** aditirav_ has joined #openstack-dev | 04:52 | |
*** dstanek has quit IRC | 04:53 | |
jgriffith | ttx: I'm not going to have much to update you on tomorrow I'm afraid | 04:53 |
*** tdruiva_ has quit IRC | 04:53 | |
*** aditirav has quit IRC | 04:55 | |
*** aditirav_ is now known as aditirav | 04:55 | |
*** ramishra has joined #openstack-dev | 04:55 | |
*** gimps has quit IRC | 04:55 | |
*** buzztroll has joined #openstack-dev | 04:56 | |
*** rcleere has joined #openstack-dev | 04:57 | |
*** e0ne has joined #openstack-dev | 04:57 | |
*** Mandell has joined #openstack-dev | 04:57 | |
coolsvap | n0ano: hey | 04:58 |
ayoung | bknudson, OK...nother change posted...and I am headed to bed. Thanks for your dilligence | 04:58 |
*** ayoung is now known as ayoung-zZzZzZzZ | 04:58 | |
coolsvap | I saw you abondoned all the gantt patches | 04:59 |
*** carl_baldwin has quit IRC | 04:59 | |
n0ano | coolsvap, ack | 04:59 |
n0ano | yeah, note the email thread on dev, we decided not to continuously sync with nova, get the gantt tree working first and then rebase the tree | 04:59 |
coolsvap | n0ano: I think I missed that, sure that could also work | 05:00 |
n0ano | six of one, half dozen of the other, I'm OK with that path, it's easy enough to redo what I did. | 05:01 |
*** carl_baldwin has joined #openstack-dev | 05:01 | |
*** e0ne has quit IRC | 05:01 | |
n0ano | easy part was creating the devstack patches, I've already submitted them, getting the unit tests to work - no so easy | 05:02 |
coolsvap | whats the subject of mail? | 05:02 |
coolsvap | got it | 05:03 |
n0ano | `sync up patches' | 05:03 |
*** mohits has joined #openstack-dev | 05:03 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 05:06 | |
*** marun has quit IRC | 05:08 | |
*** itzikb has quit IRC | 05:08 | |
*** nshaikh has joined #openstack-dev | 05:09 | |
*** krotscheck has quit IRC | 05:12 | |
*** chandankumar_ has joined #openstack-dev | 05:14 | |
*** bdpayne has quit IRC | 05:16 | |
*** cmyster has joined #openstack-dev | 05:16 | |
*** dstanek has joined #openstack-dev | 05:19 | |
*** matiu has quit IRC | 05:22 | |
*** asalkeld has joined #openstack-dev | 05:22 | |
*** otherwiseguy has quit IRC | 05:23 | |
*** matiu has joined #openstack-dev | 05:23 | |
*** matiu has quit IRC | 05:24 | |
*** matiu has joined #openstack-dev | 05:24 | |
*** carl_baldwin has quit IRC | 05:25 | |
*** crank has quit IRC | 05:28 | |
*** crank has joined #openstack-dev | 05:29 | |
*** ig has quit IRC | 05:30 | |
*** ig1 has joined #openstack-dev | 05:30 | |
*** rdas has joined #openstack-dev | 05:36 | |
*** networkstatic has quit IRC | 05:39 | |
*** rohitk has joined #openstack-dev | 05:39 | |
*** networkstatic has joined #openstack-dev | 05:40 | |
*** aditirav has quit IRC | 05:43 | |
*** aditirav has joined #openstack-dev | 05:44 | |
*** rohitk has quit IRC | 05:44 | |
*** garyk has quit IRC | 05:48 | |
*** aswadrangnekar has joined #openstack-dev | 05:48 | |
*** yeylon_ has joined #openstack-dev | 05:53 | |
*** e0ne has joined #openstack-dev | 05:57 | |
*** jasondotstar has quit IRC | 05:57 | |
*** emagana has joined #openstack-dev | 05:59 | |
*** rohitk has joined #openstack-dev | 05:59 | |
*** buzztroll has quit IRC | 06:00 | |
*** buzztroll has joined #openstack-dev | 06:00 | |
*** reed has quit IRC | 06:01 | |
*** e0ne has quit IRC | 06:02 | |
*** buzztroll has quit IRC | 06:05 | |
*** nati_ueno has quit IRC | 06:06 | |
*** faramir1 has joined #openstack-dev | 06:06 | |
*** aditirav has quit IRC | 06:09 | |
*** aditirav has joined #openstack-dev | 06:09 | |
*** WhiteAnthrax has quit IRC | 06:10 | |
*** WhiteAnthrax has joined #openstack-dev | 06:11 | |
*** SergeyLukjanov is now known as SergeyLukjanov_a | 06:12 | |
*** mikeoutland has joined #openstack-dev | 06:13 | |
*** SergeyLukjanov_a is now known as SergeyLukjanov_ | 06:13 | |
*** nshaikh has left #openstack-dev | 06:14 | |
*** bdpayne has joined #openstack-dev | 06:16 | |
*** zhikunliu has quit IRC | 06:18 | |
*** Longgeek has joined #openstack-dev | 06:19 | |
*** buzztroll has joined #openstack-dev | 06:21 | |
*** kpavel has joined #openstack-dev | 06:22 | |
*** nati_ueno has joined #openstack-dev | 06:22 | |
*** nati_ueno has quit IRC | 06:23 | |
*** nati_ueno has joined #openstack-dev | 06:24 | |
*** mikeoutland has quit IRC | 06:24 | |
*** SumitNaiksatam_ has joined #openstack-dev | 06:25 | |
*** SumitNaiksatam has quit IRC | 06:25 | |
*** SumitNaiksatam_ is now known as SumitNaiksatam | 06:25 | |
*** Longgeek has quit IRC | 06:26 | |
*** irenab has joined #openstack-dev | 06:29 | |
*** zaitcev has quit IRC | 06:30 | |
*** buzztroll has quit IRC | 06:31 | |
*** bvandenh has joined #openstack-dev | 06:33 | |
*** markvoelker has quit IRC | 06:33 | |
*** xchu has quit IRC | 06:34 | |
*** avishay has joined #openstack-dev | 06:34 | |
*** neeti has joined #openstack-dev | 06:35 | |
*** buzztroll has joined #openstack-dev | 06:35 | |
*** haomaiwa_ has quit IRC | 06:36 | |
*** haomaiwang has joined #openstack-dev | 06:36 | |
*** doug_shelley66 has joined #openstack-dev | 06:36 | |
*** neoXsys has joined #openstack-dev | 06:38 | |
*** ramishra has quit IRC | 06:38 | |
*** crank has quit IRC | 06:39 | |
*** faramir1 has quit IRC | 06:39 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 06:42 | |
*** jamielennox is now known as jamielennox|away | 06:43 | |
*** mrunge has joined #openstack-dev | 06:43 | |
*** mrunge has quit IRC | 06:44 | |
*** mrunge has joined #openstack-dev | 06:44 | |
*** haomaiwa_ has joined #openstack-dev | 06:45 | |
*** vkozhukalov has quit IRC | 06:47 | |
*** haomaiwang has quit IRC | 06:48 | |
*** rcleere has quit IRC | 06:50 | |
*** crank has joined #openstack-dev | 06:51 | |
*** topol has quit IRC | 06:54 | |
*** bdpayne has quit IRC | 06:55 | |
*** garyk has joined #openstack-dev | 06:56 | |
*** haomaiwa_ has quit IRC | 06:56 | |
*** haomaiwang has joined #openstack-dev | 06:56 | |
*** e0ne has joined #openstack-dev | 06:57 | |
*** haomaiwa_ has joined #openstack-dev | 06:59 | |
*** haomaiwang has quit IRC | 07:01 | |
*** crank has quit IRC | 07:02 | |
*** e0ne has quit IRC | 07:02 | |
*** crank has joined #openstack-dev | 07:02 | |
*** ytwu has quit IRC | 07:04 | |
*** e0ne has joined #openstack-dev | 07:04 | |
*** mrunge has quit IRC | 07:07 | |
*** mrunge has joined #openstack-dev | 07:08 | |
*** ytwu has joined #openstack-dev | 07:09 | |
*** sgordon` has quit IRC | 07:09 | |
*** csaba|afk is now known as csaba | 07:09 | |
*** vartom1111111111 has joined #openstack-dev | 07:10 | |
*** sgordon` has joined #openstack-dev | 07:10 | |
*** nati_uen_ has joined #openstack-dev | 07:12 | |
*** nati_uen_ has quit IRC | 07:13 | |
*** Drankis has joined #openstack-dev | 07:13 | |
*** nati_uen_ has joined #openstack-dev | 07:14 | |
*** rraja has joined #openstack-dev | 07:15 | |
*** nati_ueno has quit IRC | 07:16 | |
*** yolanda has joined #openstack-dev | 07:18 | |
*** sthaha has quit IRC | 07:19 | |
*** pmathews has quit IRC | 07:22 | |
*** MaxV has joined #openstack-dev | 07:23 | |
*** xingchao has quit IRC | 07:26 | |
*** mrda has quit IRC | 07:27 | |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 07:29 | |
*** romcheg has joined #openstack-dev | 07:36 | |
*** MaxV has quit IRC | 07:36 | |
*** amotoki has joined #openstack-dev | 07:38 | |
*** ifarkas has joined #openstack-dev | 07:41 | |
*** neoXsys has quit IRC | 07:43 | |
*** belmoreira has joined #openstack-dev | 07:43 | |
*** aditirav has quit IRC | 07:44 | |
*** amcrn has quit IRC | 07:45 | |
*** aditirav has joined #openstack-dev | 07:45 | |
*** NikitaKonovalov_ is now known as NikitaKonovalov | 07:45 | |
*** nmagnezi has joined #openstack-dev | 07:46 | |
*** vartom1111111112 has joined #openstack-dev | 07:46 | |
*** vartom1111111111 has quit IRC | 07:48 | |
*** ala_ has joined #openstack-dev | 07:49 | |
*** oro has joined #openstack-dev | 07:49 | |
*** tkammer has joined #openstack-dev | 07:51 | |
*** jprovazn has joined #openstack-dev | 07:52 | |
*** AnilV4 has quit IRC | 07:54 | |
*** cmyster_ has joined #openstack-dev | 07:54 | |
*** aditirav has quit IRC | 07:55 | |
*** aditirav has joined #openstack-dev | 07:55 | |
*** jtomasek has joined #openstack-dev | 07:56 | |
*** dkuffner has joined #openstack-dev | 07:56 | |
*** sdake has joined #openstack-dev | 07:58 | |
*** cmyster has quit IRC | 07:58 | |
*** AnilV4 has joined #openstack-dev | 07:58 | |
*** mindpixel has joined #openstack-dev | 07:59 | |
*** neoXsys has joined #openstack-dev | 08:00 | |
*** Longgeek has joined #openstack-dev | 08:01 | |
*** rraja has quit IRC | 08:01 | |
*** nati_ueno has joined #openstack-dev | 08:02 | |
*** nati_ueno has quit IRC | 08:02 | |
*** nati_ueno has joined #openstack-dev | 08:03 | |
*** carlp has quit IRC | 08:03 | |
*** s2r2_ has joined #openstack-dev | 08:03 | |
*** erkules_ is now known as erkules | 08:04 | |
*** asalkeld has quit IRC | 08:05 | |
*** nati_uen_ has quit IRC | 08:05 | |
*** moted has quit IRC | 08:06 | |
*** xqueralt has joined #openstack-dev | 08:06 | |
*** bauzas has joined #openstack-dev | 08:08 | |
*** Longgeek has quit IRC | 08:08 | |
*** florentflament has joined #openstack-dev | 08:08 | |
*** e0ne has quit IRC | 08:09 | |
*** evgenyf has joined #openstack-dev | 08:10 | |
*** xga has joined #openstack-dev | 08:11 | |
*** _ruhe is now known as ruhe | 08:11 | |
*** jcoufal has joined #openstack-dev | 08:13 | |
*** omachace has joined #openstack-dev | 08:13 | |
*** buzztroll has quit IRC | 08:13 | |
*** jistr has joined #openstack-dev | 08:14 | |
*** flaper87|afk is now known as flaper87 | 08:14 | |
*** julienvey_ has joined #openstack-dev | 08:19 | |
*** cmyster_ has quit IRC | 08:22 | |
*** cmyster has joined #openstack-dev | 08:22 | |
*** cmyster has joined #openstack-dev | 08:22 | |
*** xgsa has joined #openstack-dev | 08:25 | |
*** sahid has joined #openstack-dev | 08:25 | |
*** julienvey_ has quit IRC | 08:28 | |
*** vkozhukalov has joined #openstack-dev | 08:29 | |
*** paragan has quit IRC | 08:33 | |
*** romcheg has quit IRC | 08:34 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 08:37 | |
*** yeylon__ has joined #openstack-dev | 08:40 | |
*** corXi has joined #openstack-dev | 08:41 | |
*** fbo_away is now known as fbo | 08:41 | |
*** mkollaro has joined #openstack-dev | 08:41 | |
*** marekd|away is now known as marekd | 08:41 | |
*** yeylon_ has quit IRC | 08:42 | |
*** DinaBelova_ is now known as DinaBelova | 08:43 | |
*** ilyashakhat has quit IRC | 08:43 | |
*** safchain has joined #openstack-dev | 08:43 | |
*** ilyashakhat has joined #openstack-dev | 08:43 | |
*** iartarisi has joined #openstack-dev | 08:45 | |
*** nacim has joined #openstack-dev | 08:45 | |
*** yamahata has quit IRC | 08:45 | |
*** paragan has joined #openstack-dev | 08:46 | |
*** comay has quit IRC | 08:46 | |
*** yassine has joined #openstack-dev | 08:47 | |
*** rraja has joined #openstack-dev | 08:48 | |
*** nacim has quit IRC | 08:49 | |
*** romcheg has joined #openstack-dev | 08:49 | |
*** nati_uen_ has joined #openstack-dev | 08:51 | |
*** ygbo has joined #openstack-dev | 08:51 | |
*** mancdaz_away is now known as mancdaz | 08:52 | |
*** Mandell has quit IRC | 08:53 | |
*** I159 has joined #openstack-dev | 08:53 | |
*** JordanP has joined #openstack-dev | 08:54 | |
*** nati_ueno has quit IRC | 08:55 | |
*** nati_uen_ has quit IRC | 08:56 | |
*** markwash has quit IRC | 08:56 | |
*** nati_ueno has joined #openstack-dev | 08:57 | |
*** krast has joined #openstack-dev | 08:57 | |
*** boris-42 has quit IRC | 09:00 | |
*** yeylon__ has quit IRC | 09:00 | |
*** derekh has joined #openstack-dev | 09:00 | |
*** boris-42 has joined #openstack-dev | 09:00 | |
*** nacim has joined #openstack-dev | 09:00 | |
*** s2r2_ has quit IRC | 09:01 | |
*** MaxV has joined #openstack-dev | 09:01 | |
*** sushils has quit IRC | 09:02 | |
*** afazekas has joined #openstack-dev | 09:03 | |
*** jhesketh__ has quit IRC | 09:04 | |
*** giulivo has joined #openstack-dev | 09:05 | |
*** evgenyf has quit IRC | 09:06 | |
*** jpich has joined #openstack-dev | 09:07 | |
*** evgenyf has joined #openstack-dev | 09:07 | |
*** xga_ has joined #openstack-dev | 09:08 | |
*** jhesketh_ has quit IRC | 09:10 | |
*** xga has quit IRC | 09:11 | |
*** yeylon__ has joined #openstack-dev | 09:15 | |
*** teran has quit IRC | 09:18 | |
*** Alexei_987 has joined #openstack-dev | 09:18 | |
*** teran has joined #openstack-dev | 09:19 | |
*** markmc has joined #openstack-dev | 09:20 | |
*** pixelb has joined #openstack-dev | 09:22 | |
*** teran has quit IRC | 09:23 | |
*** buzztroll has joined #openstack-dev | 09:24 | |
*** WintermeW has left #openstack-dev | 09:24 | |
*** viktors has joined #openstack-dev | 09:28 | |
*** danpb has joined #openstack-dev | 09:29 | |
*** buzztroll has quit IRC | 09:29 | |
BobBall | yjiang5: Sorry - had to go home very early yesterday. | 09:31 |
*** henrynash has quit IRC | 09:33 | |
*** athomas has joined #openstack-dev | 09:37 | |
*** lxsli has quit IRC | 09:38 | |
*** lxsli has joined #openstack-dev | 09:39 | |
*** jhesketh has joined #openstack-dev | 09:50 | |
*** nati_uen_ has joined #openstack-dev | 09:50 | |
*** mmagr has joined #openstack-dev | 09:51 | |
*** jhesketh__ has joined #openstack-dev | 09:52 | |
*** arozumenko has joined #openstack-dev | 09:53 | |
*** e0ne has joined #openstack-dev | 09:53 | |
*** nati_ueno has quit IRC | 09:54 | |
*** salv-orlando has quit IRC | 09:55 | |
*** salv-orlando has joined #openstack-dev | 09:56 | |
*** ig1 has quit IRC | 09:56 | |
*** kolesovdv has joined #openstack-dev | 09:56 | |
*** ig has joined #openstack-dev | 09:56 | |
*** nati_uen_ has quit IRC | 09:57 | |
*** nati_ueno has joined #openstack-dev | 09:58 | |
*** sushils has joined #openstack-dev | 09:59 | |
*** nshaikh has joined #openstack-dev | 09:59 | |
*** kpavel has quit IRC | 10:00 | |
*** MaxV has quit IRC | 10:00 | |
*** jasondotstar has joined #openstack-dev | 10:00 | |
*** teran has joined #openstack-dev | 10:04 | |
*** johnthetubaguy has joined #openstack-dev | 10:05 | |
*** mancdaz is now known as mancdaz_away | 10:06 | |
*** martyntaylor has joined #openstack-dev | 10:07 | |
*** MaxV has joined #openstack-dev | 10:08 | |
*** coolsvap has quit IRC | 10:09 | |
*** xga has joined #openstack-dev | 10:10 | |
*** sileht has quit IRC | 10:11 | |
*** Alexei_9871 has joined #openstack-dev | 10:11 | |
*** xga_ has quit IRC | 10:11 | |
*** coolsvap has joined #openstack-dev | 10:12 | |
*** jp_at_hp has joined #openstack-dev | 10:12 | |
*** Alexei_987 has quit IRC | 10:12 | |
*** mancdaz_away is now known as mancdaz | 10:14 | |
*** xga has quit IRC | 10:14 | |
*** xga_ has joined #openstack-dev | 10:14 | |
*** ihrachys has quit IRC | 10:16 | |
*** Alexei_9871 has left #openstack-dev | 10:16 | |
*** ihrachys has joined #openstack-dev | 10:16 | |
*** sileht has joined #openstack-dev | 10:21 | |
*** xingchao has joined #openstack-dev | 10:23 | |
*** coolsvap has quit IRC | 10:23 | |
*** xga__ has joined #openstack-dev | 10:25 | |
*** xga_ has quit IRC | 10:25 | |
*** jckasper has joined #openstack-dev | 10:26 | |
*** jckasper_ has quit IRC | 10:26 | |
*** gszasz has joined #openstack-dev | 10:26 | |
*** exed_ has joined #openstack-dev | 10:27 | |
*** coolsvap has joined #openstack-dev | 10:27 | |
*** paragan has quit IRC | 10:27 | |
jd__ | lifeless: is there a secret to decrypt the garbage subunit reports sometimes like \xb3)\x01@T@Itests.test_p when it fails to load the tests for whatever reason? I didn't even find a bug in LP about that, not sure what to do | 10:28 |
*** xga__ has quit IRC | 10:28 | |
*** xga__ has joined #openstack-dev | 10:28 | |
lifeless | jd__: yes | 10:28 |
*** irenab has quit IRC | 10:29 | |
lifeless | jd__: the very end of it has the modules that are not importing correctly | 10:29 |
lifeless | jd__: the bad error output is because of over enthusiastic diagnostics in testr | 10:29 |
*** xuhanp_ has quit IRC | 10:29 | |
jd__ | lifeless: thanks :) | 10:30 |
jd__ | lifeless: running subunit manually I don't seem to manage to have a "clean output" anyway, not sure why | 10:30 |
jd__ | didn't find a bug in testrepository about that, is there one I could follow? | 10:30 |
jd__ | I'd be happy to try to write a fix or something | 10:30 |
lifeless | jd__: . .tox/py27/bin/activate; python import foo.bar.baz | 10:31 |
lifeless | jd__: o, the output ? | 10:31 |
lifeless | I'm not sure if I've filed one; please do (bugs.launchpad.net/testrepository) | 10:31 |
jd__ | lifeless: yeah thanks to your hint I noticed the import error at the end :) | 10:31 |
*** xga_ has joined #openstack-dev | 10:31 | |
jd__ | I'll take a look and will open a bug | 10:31 |
lifeless | jd__: as for a fix - cool; don't worry about bzr - I take patches | 10:32 |
jd__ | :-)) | 10:32 |
lifeless | testrepository/testcommand.py line 299 is where the output is coming from | 10:32 |
lifeless | but you can see that to use the output we pass it through parse_enumeration | 10:33 |
lifeless | so the fix would be to teach parse_enumeration to give back a a pair of test ids and errors | 10:33 |
*** lxsli has quit IRC | 10:33 | |
lifeless | and if there are errors *or* the returncode is nonzero, show the errors | 10:34 |
*** irenab has joined #openstack-dev | 10:34 | |
lifeless | _v2 in testlist.py will need to change as well | 10:34 |
*** krast has quit IRC | 10:34 | |
lifeless | to include the errors | 10:34 |
*** xga__ has quit IRC | 10:35 | |
*** uaberme has joined #openstack-dev | 10:35 | |
*** martyntaylor has quit IRC | 10:35 | |
*** krast has joined #openstack-dev | 10:36 | |
*** akrivoka has joined #openstack-dev | 10:37 | |
lifeless | gnight | 10:37 |
*** boris-42 has quit IRC | 10:38 | |
*** asalkeld has joined #openstack-dev | 10:38 | |
*** yassine has quit IRC | 10:38 | |
*** ruhe is now known as _ruhe | 10:39 | |
*** yassine has joined #openstack-dev | 10:42 | |
*** nati_uen_ has joined #openstack-dev | 10:46 | |
*** oro_ has joined #openstack-dev | 10:47 | |
*** ArxCruz has joined #openstack-dev | 10:48 | |
*** ramishra has joined #openstack-dev | 10:49 | |
*** oro_ has quit IRC | 10:49 | |
*** nati_ueno has quit IRC | 10:49 | |
*** romcheg1 has joined #openstack-dev | 10:49 | |
*** vartom1111111112 has quit IRC | 10:49 | |
*** oro_ has joined #openstack-dev | 10:49 | |
*** xga__ has joined #openstack-dev | 10:49 | |
*** Longgeek has joined #openstack-dev | 10:50 | |
*** oro_ has quit IRC | 10:50 | |
*** yassine has quit IRC | 10:50 | |
*** dave_tucker_zzz is now known as dave_tucker | 10:50 | |
*** yassine has joined #openstack-dev | 10:50 | |
*** martyntaylor has joined #openstack-dev | 10:51 | |
*** xga__ has quit IRC | 10:52 | |
*** xga__ has joined #openstack-dev | 10:52 | |
*** xga_ has quit IRC | 10:53 | |
*** romcheg has quit IRC | 10:54 | |
*** _ruhe is now known as ruhe | 10:54 | |
*** xga__ has quit IRC | 10:55 | |
*** xga__ has joined #openstack-dev | 10:55 | |
*** abk has joined #openstack-dev | 10:56 | |
*** yassine has quit IRC | 10:57 | |
*** xga__ has quit IRC | 11:00 | |
*** xga__ has joined #openstack-dev | 11:00 | |
*** jasondotstar has quit IRC | 11:01 | |
*** max_lobur_afk is now known as max_lobur | 11:05 | |
*** mkollaro has quit IRC | 11:05 | |
*** jhesketh__ has quit IRC | 11:07 | |
*** jasondotstar has joined #openstack-dev | 11:07 | |
*** emagana has quit IRC | 11:07 | |
*** Alexei_987 has joined #openstack-dev | 11:09 | |
*** yassine has joined #openstack-dev | 11:10 | |
*** xga_ has joined #openstack-dev | 11:13 | |
*** akrivoka has quit IRC | 11:14 | |
*** e0ne has quit IRC | 11:15 | |
*** e0ne has joined #openstack-dev | 11:15 | |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 11:15 | |
*** xga__ has quit IRC | 11:16 | |
*** akrivoka has joined #openstack-dev | 11:17 | |
*** jcoufal has quit IRC | 11:17 | |
*** xga_ has quit IRC | 11:18 | |
*** bvandenh has quit IRC | 11:18 | |
*** xga_ has joined #openstack-dev | 11:18 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 11:19 | |
*** mkollaro has joined #openstack-dev | 11:21 | |
*** yassine has quit IRC | 11:21 | |
*** jckasper has quit IRC | 11:22 | |
*** jckasper has joined #openstack-dev | 11:22 | |
*** lucasagomes has joined #openstack-dev | 11:22 | |
*** yassine has joined #openstack-dev | 11:23 | |
*** romcheg has joined #openstack-dev | 11:23 | |
*** xga_ has quit IRC | 11:24 | |
*** xga_ has joined #openstack-dev | 11:24 | |
*** romcheg1 has quit IRC | 11:26 | |
*** eglynn has joined #openstack-dev | 11:27 | |
*** pcm_ has joined #openstack-dev | 11:31 | |
*** vartom1111111112 has joined #openstack-dev | 11:32 | |
*** rfolco has joined #openstack-dev | 11:32 | |
*** pcm_ has quit IRC | 11:33 | |
*** pcm_ has joined #openstack-dev | 11:33 | |
*** henrynash has joined #openstack-dev | 11:35 | |
*** emagana has joined #openstack-dev | 11:38 | |
*** martyntaylor has quit IRC | 11:42 | |
*** jcoufal has joined #openstack-dev | 11:42 | |
*** vartom1111111113 has joined #openstack-dev | 11:44 | |
*** vartom1111111112 has quit IRC | 11:45 | |
*** vartom1111111114 has joined #openstack-dev | 11:45 | |
*** emagana has quit IRC | 11:46 | |
*** vartom1111111115 has joined #openstack-dev | 11:46 | |
*** vartom1111111116 has joined #openstack-dev | 11:47 | |
*** vartom1111111113 has quit IRC | 11:48 | |
*** martyntaylor has joined #openstack-dev | 11:48 | |
*** vartom1111111114 has quit IRC | 11:50 | |
*** vartom1111111115 has quit IRC | 11:51 | |
*** kolesovdv has quit IRC | 11:51 | |
*** henrynash has left #openstack-dev | 11:51 | |
*** henrynash has joined #openstack-dev | 11:52 | |
*** Longgeek has quit IRC | 11:53 | |
*** yaguang has quit IRC | 11:55 | |
*** uaberme has quit IRC | 11:57 | |
*** s2r2_ has joined #openstack-dev | 11:59 | |
*** topol has joined #openstack-dev | 12:00 | |
*** xga_ has quit IRC | 12:02 | |
*** xga_ has joined #openstack-dev | 12:02 | |
*** yeylon__ has quit IRC | 12:03 | |
*** oro has quit IRC | 12:03 | |
*** mattymo has quit IRC | 12:05 | |
*** ruhe is now known as _ruhe | 12:05 | |
*** boris-42 has joined #openstack-dev | 12:05 | |
*** tdruiva has joined #openstack-dev | 12:05 | |
*** morazi has joined #openstack-dev | 12:06 | |
*** csaba is now known as csaba|afk | 12:07 | |
*** amuller has joined #openstack-dev | 12:07 | |
*** paragan has joined #openstack-dev | 12:09 | |
*** paragan has quit IRC | 12:09 | |
*** paragan has joined #openstack-dev | 12:09 | |
*** mattymo has joined #openstack-dev | 12:09 | |
*** _ruhe is now known as ruhe | 12:11 | |
*** s2r2_ has quit IRC | 12:13 | |
*** yeylon__ has joined #openstack-dev | 12:17 | |
*** xga_ has quit IRC | 12:17 | |
*** xga_ has joined #openstack-dev | 12:17 | |
*** oro has joined #openstack-dev | 12:17 | |
*** bvandenh has joined #openstack-dev | 12:18 | |
*** coolsvap has quit IRC | 12:22 | |
*** b3nt_pin has joined #openstack-dev | 12:23 | |
*** b3nt_pin is now known as beagles | 12:23 | |
*** networkstatic has quit IRC | 12:24 | |
*** yeylon__ has quit IRC | 12:25 | |
*** andreaf has quit IRC | 12:25 | |
*** tserong has quit IRC | 12:27 | |
*** madmike has quit IRC | 12:27 | |
*** gimps has joined #openstack-dev | 12:27 | |
*** rohitk has quit IRC | 12:28 | |
*** READ10 has quit IRC | 12:28 | |
*** xga__ has joined #openstack-dev | 12:28 | |
*** tserong has joined #openstack-dev | 12:31 | |
*** mancdaz is now known as mancdaz_away | 12:31 | |
*** nshaikh has quit IRC | 12:31 | |
*** xga_ has quit IRC | 12:32 | |
*** ig has quit IRC | 12:32 | |
*** mancdaz_away is now known as mancdaz | 12:33 | |
*** rtheis has joined #openstack-dev | 12:34 | |
*** FunnyLookinHat has joined #openstack-dev | 12:35 | |
*** jasondotstar has quit IRC | 12:36 | |
*** omachace has left #openstack-dev | 12:36 | |
*** xga__ has quit IRC | 12:37 | |
*** DinaBelova is now known as DinaBelova_ | 12:37 | |
*** xga__ has joined #openstack-dev | 12:37 | |
*** jhesketh has quit IRC | 12:38 | |
*** yeylon__ has joined #openstack-dev | 12:40 | |
*** xga__ has quit IRC | 12:43 | |
*** yeylon_ has joined #openstack-dev | 12:43 | |
*** xga__ has joined #openstack-dev | 12:43 | |
*** I159 has quit IRC | 12:44 | |
*** yeylon__ has quit IRC | 12:46 | |
*** ramishra has quit IRC | 12:46 | |
*** mohits has quit IRC | 12:46 | |
*** I159 has joined #openstack-dev | 12:46 | |
*** tdruiva has quit IRC | 12:48 | |
*** exed__ has joined #openstack-dev | 12:50 | |
*** rraja has quit IRC | 12:51 | |
*** asalkeld has quit IRC | 12:51 | |
*** artom has joined #openstack-dev | 12:51 | |
*** exed_ has quit IRC | 12:52 | |
*** exed__ is now known as exed_ | 12:52 | |
*** sgordon_ has joined #openstack-dev | 12:52 | |
*** gszasz has quit IRC | 12:53 | |
*** danielbruno has joined #openstack-dev | 12:53 | |
*** neeti has quit IRC | 12:56 | |
*** andreykurilin has quit IRC | 12:56 | |
*** neeti has joined #openstack-dev | 12:57 | |
*** heyongli has joined #openstack-dev | 12:57 | |
*** gszasz has joined #openstack-dev | 12:57 | |
*** david_paterson has joined #openstack-dev | 12:57 | |
*** aditirav has quit IRC | 12:57 | |
*** markmcclain has joined #openstack-dev | 12:58 | |
*** amotoki has quit IRC | 12:58 | |
*** kwss has joined #openstack-dev | 12:58 | |
*** david-lyle_ has quit IRC | 12:59 | |
*** yaguang has joined #openstack-dev | 12:59 | |
*** yeylon_ has quit IRC | 13:02 | |
*** xga_ has joined #openstack-dev | 13:02 | |
*** amuller_ has joined #openstack-dev | 13:02 | |
*** amuller has quit IRC | 13:02 | |
*** SergeyLukjanov is now known as SergeyLukjanov_a | 13:02 | |
*** markvoelker has joined #openstack-dev | 13:03 | |
*** SergeyLukjanov_a is now known as SergeyLukjanov_ | 13:03 | |
*** asalkeld has joined #openstack-dev | 13:03 | |
*** asalkeld has quit IRC | 13:04 | |
*** afazekas has quit IRC | 13:04 | |
*** oro has quit IRC | 13:04 | |
*** aspiers has quit IRC | 13:04 | |
*** mkollaro has quit IRC | 13:05 | |
*** kolesovdv has joined #openstack-dev | 13:06 | |
*** xga__ has quit IRC | 13:06 | |
*** xga has joined #openstack-dev | 13:06 | |
*** xga_ has quit IRC | 13:07 | |
*** DinaBelova_ is now known as DinaBelova | 13:07 | |
*** oro has joined #openstack-dev | 13:07 | |
*** nmagnezi has quit IRC | 13:08 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 13:09 | |
*** pschaef has joined #openstack-dev | 13:10 | |
*** giulivo has quit IRC | 13:12 | |
*** giulivo has joined #openstack-dev | 13:12 | |
*** amotoki has joined #openstack-dev | 13:14 | |
*** jckasper has quit IRC | 13:14 | |
*** mkollaro has joined #openstack-dev | 13:15 | |
*** yeylon_ has joined #openstack-dev | 13:15 | |
*** neeti has quit IRC | 13:17 | |
*** eglynn is now known as eglynn-lunch | 13:17 | |
*** rods has joined #openstack-dev | 13:17 | |
*** sthaha has joined #openstack-dev | 13:19 | |
*** sthaha has quit IRC | 13:19 | |
*** sthaha has joined #openstack-dev | 13:19 | |
*** afazekas has joined #openstack-dev | 13:19 | |
*** AMike has quit IRC | 13:19 | |
*** markmcclain has quit IRC | 13:22 | |
*** ytwu has quit IRC | 13:23 | |
*** ytwu has joined #openstack-dev | 13:24 | |
*** emagana has joined #openstack-dev | 13:26 | |
*** e0ne_ has joined #openstack-dev | 13:27 | |
*** e0ne has quit IRC | 13:28 | |
*** neeti has joined #openstack-dev | 13:28 | |
*** teran_ has joined #openstack-dev | 13:28 | |
*** vladikr has joined #openstack-dev | 13:29 | |
*** nosnos has quit IRC | 13:30 | |
*** Alexei_987 has quit IRC | 13:30 | |
*** jdob has joined #openstack-dev | 13:31 | |
*** nosnos has joined #openstack-dev | 13:31 | |
*** emagana has quit IRC | 13:31 | |
*** thouvenin has quit IRC | 13:31 | |
*** teran has quit IRC | 13:32 | |
*** safchain has quit IRC | 13:32 | |
ihrachys | a general question on how to handle oslo-incubator related bugs. So assuming there is a bug in oslo-incubator rpc module, and it's registered in Launchpad. Which projects should be affected by this? The obvious candidates are oslo and oslo.messaging. Should we also add each and every openstack module which uses this rpc module (like neutron, or ceilometer...)? Or can we just assume that the issue will | 13:34 |
ihrachys | eventually be fixed by consequent sync from incubator, and hence there's no need to add all those projects to affected list? | 13:35 |
ihrachys | I've seen oslo bugs with huge lists of affected projects before, but this approach doesn't look easy to handle | 13:35 |
*** mfink has joined #openstack-dev | 13:36 | |
*** ayoung-zZzZzZzZ has quit IRC | 13:37 | |
*** nosnos has quit IRC | 13:38 | |
*** YorikSar has quit IRC | 13:38 | |
bknudson | ihrachys: what I've done is if it's found in a project (keystone) and I plan on pulling the change into the project then I'll add that project. | 13:39 |
bknudson | I don't add every openstack project | 13:39 |
*** martyntaylor has quit IRC | 13:40 | |
*** YorikSar has joined #openstack-dev | 13:40 | |
ihrachys | bknudson: yes, I plan to do it for neutron, so I'll also add neutron project to the list, but this looks like a half-solution. | 13:40 |
bknudson | ihrachys: there was a note to the mailing list about enhancing update.py ... | 13:41 |
*** sth has joined #openstack-dev | 13:41 | |
*** gema has joined #openstack-dev | 13:42 | |
bknudson | maybe update.py could figure out what bugs are closed from the commit messages and transfer them to the new commit message. | 13:42 |
*** ruhe is now known as _ruhe | 13:42 | |
jgriffith | /window//wind/ | 13:42 |
bknudson | then launchpad would add the project to the bug for you? | 13:43 |
*** ramishra has joined #openstack-dev | 13:43 | |
*** _ruhe is now known as ruhe | 13:45 | |
*** abk has quit IRC | 13:45 | |
ttx | jgriffith: hi! | 13:45 |
*** MaxV has quit IRC | 13:45 | |
*** ramishra has quit IRC | 13:45 | |
*** sth has quit IRC | 13:46 | |
*** ramishra has joined #openstack-dev | 13:46 | |
*** gema has left #openstack-dev | 13:46 | |
jgriffith | ttx: morning | 13:46 |
*** neeti_ has joined #openstack-dev | 13:46 | |
ttx | jgriffith: #openstack-relmgr-office ? | 13:47 |
*** safchain has joined #openstack-dev | 13:47 | |
*** jasondotstar has joined #openstack-dev | 13:47 | |
*** ramishra_ has joined #openstack-dev | 13:47 | |
*** safchain has quit IRC | 13:47 | |
*** safchain has joined #openstack-dev | 13:48 | |
*** uaberme has joined #openstack-dev | 13:49 | |
*** mkollaro1 has joined #openstack-dev | 13:49 | |
*** mkollaro has quit IRC | 13:49 | |
*** neeti has quit IRC | 13:50 | |
*** tdruiva has joined #openstack-dev | 13:50 | |
*** ramishra has quit IRC | 13:51 | |
*** dstanek has quit IRC | 13:51 | |
*** mriedem has joined #openstack-dev | 13:51 | |
*** doug_shelley66 has quit IRC | 13:51 | |
*** YorikSar has quit IRC | 13:51 | |
*** YorikSar has joined #openstack-dev | 13:52 | |
*** thomasem has joined #openstack-dev | 13:52 | |
*** jckasper has joined #openstack-dev | 13:54 | |
*** cmyster has quit IRC | 13:54 | |
*** gszasz has quit IRC | 13:54 | |
*** tongli has joined #openstack-dev | 13:54 | |
*** martyntaylor has joined #openstack-dev | 13:54 | |
*** vkmc has joined #openstack-dev | 13:55 | |
*** jckasper has quit IRC | 13:55 | |
*** MaxV has joined #openstack-dev | 13:55 | |
*** noslzzp has joined #openstack-dev | 13:56 | |
*** mancdaz is now known as mancdaz_away | 13:57 | |
*** thuc has joined #openstack-dev | 13:57 | |
*** tdruiva has quit IRC | 13:58 | |
*** yaguang has quit IRC | 13:58 | |
*** rcleere has joined #openstack-dev | 13:59 | |
*** ramishra_ has quit IRC | 13:59 | |
*** dprince has joined #openstack-dev | 14:00 | |
*** aveiga has joined #openstack-dev | 14:00 | |
*** coolsvap has joined #openstack-dev | 14:00 | |
*** heyongli has quit IRC | 14:02 | |
*** jpomero has quit IRC | 14:02 | |
*** max_lobur is now known as max_lobur_afk | 14:04 | |
*** dave_tucker has left #openstack-dev | 14:04 | |
*** mancdaz_away is now known as mancdaz | 14:05 | |
*** dims has quit IRC | 14:06 | |
*** jckasper has joined #openstack-dev | 14:07 | |
*** jdob_ has joined #openstack-dev | 14:08 | |
*** YorikSar has quit IRC | 14:10 | |
*** lbragstad has quit IRC | 14:11 | |
*** xga has quit IRC | 14:11 | |
*** oro has quit IRC | 14:11 | |
*** Drankis has quit IRC | 14:12 | |
*** kolesovdv has quit IRC | 14:13 | |
*** lbragstad has joined #openstack-dev | 14:13 | |
*** oro has joined #openstack-dev | 14:15 | |
*** vkmc has quit IRC | 14:15 | |
*** ig has joined #openstack-dev | 14:16 | |
*** changbl has quit IRC | 14:17 | |
*** xga has joined #openstack-dev | 14:17 | |
*** bvandenh has quit IRC | 14:18 | |
*** rdas has quit IRC | 14:18 | |
*** dims has joined #openstack-dev | 14:19 | |
*** amuller_ has quit IRC | 14:19 | |
*** lbragstad has quit IRC | 14:20 | |
*** cagrev has joined #openstack-dev | 14:21 | |
*** READ10 has joined #openstack-dev | 14:21 | |
*** yassine has quit IRC | 14:21 | |
*** yassine has joined #openstack-dev | 14:22 | |
*** dvarga has joined #openstack-dev | 14:22 | |
*** mgagne1 has joined #openstack-dev | 14:22 | |
*** yaguang has joined #openstack-dev | 14:22 | |
*** mgagne has quit IRC | 14:23 | |
*** jayg|g0n3 is now known as jayg | 14:23 | |
*** mgagne has joined #openstack-dev | 14:24 | |
*** e0ne has joined #openstack-dev | 14:24 | |
*** CaptTofu has joined #openstack-dev | 14:25 | |
*** HT_Sergio has joined #openstack-dev | 14:25 | |
*** martyntaylor1 has joined #openstack-dev | 14:26 | |
*** cagrev has quit IRC | 14:26 | |
*** gordc has joined #openstack-dev | 14:27 | |
*** andreykurilin has joined #openstack-dev | 14:27 | |
*** max_lobur_afk is now known as max_lobur | 14:27 | |
*** mgagne1 has quit IRC | 14:27 | |
*** e0ne_ has quit IRC | 14:27 | |
*** nkinder has quit IRC | 14:27 | |
*** Mandell has joined #openstack-dev | 14:27 | |
*** vijendar has joined #openstack-dev | 14:27 | |
*** odyssey4me has joined #openstack-dev | 14:28 | |
*** martyntaylor has quit IRC | 14:29 | |
*** eharney has joined #openstack-dev | 14:29 | |
*** anniec has joined #openstack-dev | 14:29 | |
*** thuc has quit IRC | 14:30 | |
*** mancdaz is now known as mancdaz_away | 14:31 | |
*** joesavak has joined #openstack-dev | 14:31 | |
*** thuc has joined #openstack-dev | 14:31 | |
*** doug_shelley66 has joined #openstack-dev | 14:31 | |
*** Drankis has joined #openstack-dev | 14:32 | |
*** anniec_ has joined #openstack-dev | 14:32 | |
*** mancdaz_away is now known as mancdaz | 14:32 | |
*** peristeri has joined #openstack-dev | 14:33 | |
*** mfer has joined #openstack-dev | 14:33 | |
*** BobBall is now known as BobBallAWay | 14:34 | |
*** alop has joined #openstack-dev | 14:34 | |
*** jdob_ has quit IRC | 14:34 | |
*** aspiers has joined #openstack-dev | 14:34 | |
*** anniec has quit IRC | 14:34 | |
*** anniec_ is now known as anniec | 14:34 | |
*** alop has quit IRC | 14:35 | |
*** thuc has quit IRC | 14:36 | |
*** irenab has quit IRC | 14:36 | |
*** vartom1111111117 has joined #openstack-dev | 14:36 | |
*** vartom1111111118 has joined #openstack-dev | 14:38 | |
*** nermina has joined #openstack-dev | 14:38 | |
*** vartom1111111116 has quit IRC | 14:39 | |
*** vartom1111111119 has joined #openstack-dev | 14:39 | |
*** giulivo has quit IRC | 14:40 | |
*** vartom1111111117 has quit IRC | 14:41 | |
*** otherwiseguy has joined #openstack-dev | 14:41 | |
*** SergeyLukjanov is now known as SergeyLukjanov_a | 14:42 | |
*** vartom1111111118 has quit IRC | 14:42 | |
*** browne has joined #openstack-dev | 14:42 | |
*** SergeyLukjanov_a is now known as SergeyLukjanov_ | 14:43 | |
*** redhat has joined #openstack-dev | 14:43 | |
*** mdomsch has joined #openstack-dev | 14:43 | |
*** achampio1 has joined #openstack-dev | 14:44 | |
*** prad has joined #openstack-dev | 14:44 | |
*** jnoller has joined #openstack-dev | 14:44 | |
*** coolsvap_away has joined #openstack-dev | 14:45 | |
dolphm | marekd: i'm reviewing / working on a patchset for idp's | 14:45 |
*** alop has joined #openstack-dev | 14:45 | |
marekd | dolphm: cool, thanks. | 14:45 |
*** trey_h has joined #openstack-dev | 14:46 | |
*** prad has quit IRC | 14:46 | |
marekd | dolphm: i will be around for few more hours. | 14:46 |
*** vartom1111111119 has quit IRC | 14:46 | |
*** gokrokve has joined #openstack-dev | 14:46 | |
*** giulivo has joined #openstack-dev | 14:47 | |
*** achampion has quit IRC | 14:47 | |
*** bvandenh has joined #openstack-dev | 14:47 | |
*** benrodrigue has joined #openstack-dev | 14:47 | |
*** coolsvap has quit IRC | 14:47 | |
dolphm | marekd: fyi, you changed a few methods to be called put_ but did so inconsistently? i'm changing them back to create_ | 14:47 |
*** coolsvap_away is now known as coolsvap | 14:48 | |
marekd | dolphm: heh, ok. | 14:49 |
*** rcj has joined #openstack-dev | 14:49 | |
*** lbragstad has joined #openstack-dev | 14:49 | |
*** mriedem has quit IRC | 14:49 | |
*** kevinconway has joined #openstack-dev | 14:49 | |
*** sthaha has quit IRC | 14:49 | |
*** dstanek has joined #openstack-dev | 14:49 | |
*** ayoung has joined #openstack-dev | 14:50 | |
*** tshirtman has quit IRC | 14:50 | |
*** tshirtman has joined #openstack-dev | 14:50 | |
*** riskable has quit IRC | 14:50 | |
*** changbl has joined #openstack-dev | 14:50 | |
*** riskable has joined #openstack-dev | 14:50 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 14:50 | |
*** bauzas has quit IRC | 14:51 | |
*** armax has joined #openstack-dev | 14:51 | |
dolphm | marekd: it might make sense to call the controllers something other than create_ but the driver methods don't need to care about the HTTP method | 14:51 |
*** achampion has joined #openstack-dev | 14:52 | |
*** pasquier-s has quit IRC | 14:52 | |
marekd | dolphm: got it. | 14:52 |
*** mgagne has quit IRC | 14:53 | |
*** bauzas has joined #openstack-dev | 14:53 | |
*** pasquier-s has joined #openstack-dev | 14:53 | |
*** achampio1 has quit IRC | 14:53 | |
*** FunnyLookinHat has quit IRC | 14:54 | |
ayoung | dolphm, Revocations is probably ready for you. bknudson did the 60-inline-comments review yesterday, and I posted the changes at midnight. Its trhough the check queue now; all green. | 14:54 |
ayoung | I can take some reviews. What is burning?\ | 14:54 |
dolphm | ayoung: i saw lol | 14:54 |
*** boris-42 has quit IRC | 14:54 | |
ayoung | Looks like Gate is flowing again, too | 14:54 |
dolphm | ayoung: give me a few more minutes on idp's and then that'll need a review | 14:54 |
dolphm | ayoung: ++ | 14:54 |
ayoung | Sounds good. | 14:55 |
dolphm | not sure if that's just overnight, or if it's actually improved | 14:55 |
*** amotoki has quit IRC | 14:55 | |
*** dvarga is now known as dvarga|away | 14:55 | |
*** dvarga|away is now known as dvarga | 14:55 | |
*** nplanel has joined #openstack-dev | 14:56 | |
*** rcj has quit IRC | 14:57 | |
*** terriyu has joined #openstack-dev | 14:57 | |
*** rcj has joined #openstack-dev | 14:57 | |
dolphm | ayoung: alrighty- https://review.openstack.org/#/c/60244/ (cc- marekd) | 14:58 |
*** trey_h_ has joined #openstack-dev | 14:59 | |
*** xga has quit IRC | 15:00 | |
*** jcoufal has quit IRC | 15:02 | |
*** jobewan has joined #openstack-dev | 15:02 | |
*** jcoufal_ has joined #openstack-dev | 15:02 | |
*** trey_h has quit IRC | 15:03 | |
*** spzala has joined #openstack-dev | 15:03 | |
*** vkozhukalov has quit IRC | 15:04 | |
*** aeperezt has joined #openstack-dev | 15:05 | |
*** chmouel has quit IRC | 15:05 | |
*** chmouel_ has joined #openstack-dev | 15:05 | |
*** jruzicka has joined #openstack-dev | 15:05 | |
*** chmouel_ is now known as chmouel | 15:06 | |
*** prad has joined #openstack-dev | 15:07 | |
*** xga has joined #openstack-dev | 15:07 | |
*** Gordonz has joined #openstack-dev | 15:08 | |
*** Gordonz has quit IRC | 15:08 | |
*** yassine has quit IRC | 15:08 | |
*** emagana has joined #openstack-dev | 15:08 | |
*** vkmc has joined #openstack-dev | 15:08 | |
*** vkmc has quit IRC | 15:08 | |
*** vkmc has joined #openstack-dev | 15:08 | |
*** Gordonz has joined #openstack-dev | 15:08 | |
*** yassine has joined #openstack-dev | 15:09 | |
*** kgriffs_afk is now known as kgriffs | 15:10 | |
*** sahid has quit IRC | 15:11 | |
*** tkammer has quit IRC | 15:11 | |
*** amuller has joined #openstack-dev | 15:12 | |
*** emagana has quit IRC | 15:13 | |
*** alex_klimov1 has quit IRC | 15:14 | |
*** alex_xu has quit IRC | 15:14 | |
*** nkinder has joined #openstack-dev | 15:15 | |
*** mgagne has joined #openstack-dev | 15:16 | |
*** mgagne1 has joined #openstack-dev | 15:17 | |
*** trey_h_ has quit IRC | 15:17 | |
*** nmagnezi has joined #openstack-dev | 15:17 | |
*** eglynn-lunch is now known as eglynn | 15:17 | |
*** trey_h has joined #openstack-dev | 15:18 | |
*** ig has quit IRC | 15:18 | |
*** ig has joined #openstack-dev | 15:19 | |
marekd | dolphm: ayoung : just realized I missed that and that's pretty crucial: http://pasteraw.com/4ghyirco3o2j2v18q12o7b9q80xbj8u | 15:19 |
dolphm | marekd: ooh, nice test | 15:19 |
ayoung | marekd, ++ | 15:20 |
dolphm | marekd: the first part was already in there, no? | 15:20 |
*** rcleere has quit IRC | 15:20 | |
marekd | not handle_conflict | 15:20 |
*** mrunge has quit IRC | 15:20 | |
*** aswadrangnekar has quit IRC | 15:20 | |
*** exed_ has quit IRC | 15:21 | |
ttx | markmc, flaper87: is one of you filling in for dhellmann this week ? | 15:21 |
*** mgagne has quit IRC | 15:21 | |
*** dbalog has left #openstack-dev | 15:21 | |
*** nkinder has quit IRC | 15:21 | |
flaper87 | ttx: I am, as in I'm keeping an eye on the i-2 status for oslo-* | 15:22 |
lbragstad | bknudson: ayoung are either of you able to leave a comment at line 710 here: https://review.openstack.org/#/c/55908/24/keystone/tests/test_v3_auth.py | 15:22 |
ttx | flaper87: ok, please come to #openstack-relmgr-office | 15:22 |
*** paragan has quit IRC | 15:22 | |
*** FunnyLookinHat has joined #openstack-dev | 15:22 | |
*** exed_ has joined #openstack-dev | 15:22 | |
*** martyntaylor1 has quit IRC | 15:22 | |
ayoung | lbragstad, yes I can. | 15:22 |
flaper87 | ttx: can I do it in a bit? I'm in another meeting now :S | 15:23 |
ayoung | lbragstad, are you using chrome? | 15:23 |
lbragstad | ayoung: yes | 15:23 |
ayoung | morganfainberg had a problem with chrome earlier this week | 15:23 |
ayoung | some sort of update is choking on the gerrit Javascript I am guessing lbragstad | 15:23 |
lbragstad | ayoung: interesting, it keeps kicking me around to different parts of the file | 15:23 |
ayoung | Yep | 15:23 |
ttx | flaper87: sure! | 15:23 |
ayoung | try firefox | 15:23 |
bknudson | lbragstad: I don't have a problem leaving a comment. | 15:23 |
*** ytwu has quit IRC | 15:24 | |
ttx | flaper87: ping me there when available | 15:24 |
lbragstad | ayoung: ok sounds good, I'll publish the comments I have and then finish in firefox | 15:24 |
*** tkammer has joined #openstack-dev | 15:24 | |
lbragstad | bknudson: are you using chrome? | 15:24 |
*** ytwu has joined #openstack-dev | 15:24 | |
bknudson | lbragstad: no. FF | 15:24 |
lbragstad | bknudson: ok | 15:24 |
*** networkstatic has joined #openstack-dev | 15:24 | |
*** nkinder has joined #openstack-dev | 15:25 | |
*** marun has joined #openstack-dev | 15:25 | |
*** uaberme has quit IRC | 15:26 | |
marekd | bknudson: aaargh, I did apply your suggestions for sure and probably broke git somehow. | 15:26 |
*** stevemar has joined #openstack-dev | 15:28 | |
*** JonnyNomad has quit IRC | 15:29 | |
*** mgagne1 has quit IRC | 15:30 | |
*** rnirmal has joined #openstack-dev | 15:30 | |
*** dave_tucker_zzz has joined #openstack-dev | 15:31 | |
*** dave_tucker_zzz is now known as dave_tucker | 15:31 | |
*** mriedem has joined #openstack-dev | 15:31 | |
*** nelsnelson is now known as nelsnelson_away | 15:32 | |
*** nelsnelson_away is now known as nelsnelson | 15:32 | |
*** terrylhowe has joined #openstack-dev | 15:32 | |
*** xga has quit IRC | 15:33 | |
*** tmclaugh[work] has joined #openstack-dev | 15:33 | |
*** lucasagomes is now known as lucas-hungry | 15:33 | |
ayoung | marekd, you never break git. Git is resiliant | 15:34 |
ayoung | you can always restore an old state | 15:34 |
*** otherwiseguy has quit IRC | 15:34 | |
*** nelsnels_ has joined #openstack-dev | 15:34 | |
*** jecarey has joined #openstack-dev | 15:35 | |
*** yassine has quit IRC | 15:35 | |
*** nelsnels_ has quit IRC | 15:35 | |
*** yassine has joined #openstack-dev | 15:35 | |
*** dvarga is now known as dvarga|away | 15:35 | |
*** dvarga|away is now known as dvarga | 15:35 | |
*** nelsnels_ has joined #openstack-dev | 15:36 | |
*** nelsnelson has quit IRC | 15:37 | |
*** jchiles has joined #openstack-dev | 15:37 | |
marekd | ayoung: ++ | 15:37 |
ayoung | marekd, you got it sorted? | 15:37 |
*** tanisdl has joined #openstack-dev | 15:37 | |
marekd | fixed. adding the test i mentioned in pasteraw | 15:37 |
marekd | 1 minute. | 15:37 |
*** martyntaylor has joined #openstack-dev | 15:38 | |
*** xga has joined #openstack-dev | 15:38 | |
*** martyntaylor has quit IRC | 15:38 | |
*** martyntaylor has joined #openstack-dev | 15:38 | |
*** nati_uen_ has quit IRC | 15:40 | |
*** xga has quit IRC | 15:40 | |
*** xga has joined #openstack-dev | 15:40 | |
*** rcleere has joined #openstack-dev | 15:41 | |
dolphm | marekd: bknudson added some comments | 15:42 |
*** neeti_ has quit IRC | 15:42 | |
*** emagana has joined #openstack-dev | 15:42 | |
marekd | noticed that. | 15:42 |
*** galstrom_zzz is now known as galstrom | 15:43 | |
*** nelsnels_ has quit IRC | 15:43 | |
*** Underbyte has quit IRC | 15:43 | |
*** nelsnelson has joined #openstack-dev | 15:44 | |
ayoung | dstanek, check me on this: if 'id' in user and user['id'] != user_id: could be rewritten as if user.get('id') != user_id: right? the != means that they are semantically the same? | 15:44 |
marekd | dolphm: looks like you commited kina outdated patchset for idp? patchset 17 (mine) has render_response() in controllers.py, whereas Patchset 18 (yours) doesn't. | 15:45 |
*** otherwiseguy has joined #openstack-dev | 15:46 | |
*** samuelbercovici has joined #openstack-dev | 15:46 | |
*** jecarey has quit IRC | 15:46 | |
marekd | and 17 has almost all of bknudson's suggestions applied. | 15:47 |
*** emagana has quit IRC | 15:47 | |
ayoung | ah...no they are not the same...disregard | 15:47 |
dstanek | ayoung: there may be a slight difference in semantics there | 15:47 |
ayoung | dstanek, yeah, and in this case that difference is significant | 15:47 |
*** dbalog has joined #openstack-dev | 15:48 | |
ayoung | the presnet indicates the values were sent in for update. T | 15:48 |
marekd | dolphm: me fix it all, apply your changes and commit patchset again? | 15:48 |
ayoung | Their absense means "ignore" | 15:48 |
dolphm | marekd: i don't have more changes? | 15:48 |
*** rraja has joined #openstack-dev | 15:48 | |
dolphm | marekd: (reading back) hrm... i thought i checked out the latest | 15:48 |
marekd | no worries, you are probably multitasking hardcore level at the moment. | 15:49 |
*** sandywalsh has joined #openstack-dev | 15:50 | |
*** neeti has joined #openstack-dev | 15:50 | |
marekd | dolphm: pulling patchset 17, fixing, rebasing with current master will work, right? | 15:50 |
*** NikitaKonovalov is now known as NikitaKonovalov_ | 15:51 | |
*** neeti has quit IRC | 15:51 | |
*** jprovazn has quit IRC | 15:52 | |
dolphm | marekd: i don't know what happened on my end :-/ i've never checked out the last 2 patchsets (15 & 16) | 15:52 |
*** tkammer has quit IRC | 15:52 | |
*** markwash has joined #openstack-dev | 15:52 | |
dolphm | marekd: and yes - i'll re-apply my changes | 15:53 |
*** MaxV has quit IRC | 15:54 | |
marekd | hold on, cause I don't wanna end up in a race condition :-) | 15:54 |
maurosr | hey can someone take a look on this https://review.openstack.org/#/c/66360/ ? (oslo-incubator) | 15:55 |
marekd | dolphm: i will add it first, ok? | 15:55 |
dolphm | marekd: ++ | 15:55 |
dolphm | marekd: i'm waiting | 15:55 |
marekd | cool. | 15:55 |
*** kenperkins has joined #openstack-dev | 15:55 | |
*** jcoufal_ has quit IRC | 15:57 | |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 15:57 | |
*** nshaikh has joined #openstack-dev | 15:58 | |
*** mancdaz is now known as mancdaz_away | 15:58 | |
*** mancdaz_away is now known as mancdaz | 15:58 | |
*** nshaikh has quit IRC | 15:59 | |
*** Drankis has quit IRC | 16:00 | |
*** giroro_ has quit IRC | 16:01 | |
*** jmontemayor has joined #openstack-dev | 16:01 | |
*** jecarey has joined #openstack-dev | 16:01 | |
*** colinmcnamara has joined #openstack-dev | 16:01 | |
*** DinaBelova is now known as DinaBelova_ | 16:02 | |
*** boris-42 has joined #openstack-dev | 16:02 | |
*** rraja has quit IRC | 16:02 | |
*** devoid has joined #openstack-dev | 16:02 | |
*** alexpilotti has joined #openstack-dev | 16:02 | |
*** Ruetobas has joined #openstack-dev | 16:03 | |
*** carl_baldwin has joined #openstack-dev | 16:03 | |
*** thouveng has joined #openstack-dev | 16:04 | |
*** nkinder has quit IRC | 16:04 | |
*** burt1 has joined #openstack-dev | 16:04 | |
*** nmagnezi has quit IRC | 16:06 | |
*** MaxV has joined #openstack-dev | 16:07 | |
*** jlabocki has joined #openstack-dev | 16:07 | |
*** SumitNaiksatam has quit IRC | 16:07 | |
*** Ruetobas has quit IRC | 16:08 | |
*** nati_ueno has joined #openstack-dev | 16:08 | |
*** xqueralt has quit IRC | 16:08 | |
*** samuelbercovici has quit IRC | 16:09 | |
*** Nikolay_St has quit IRC | 16:09 | |
*** chandankumar_ has quit IRC | 16:10 | |
*** cdub has joined #openstack-dev | 16:11 | |
*** mrodden has joined #openstack-dev | 16:11 | |
*** prad has quit IRC | 16:11 | |
dolphm | marekd: ping me when you're ready | 16:11 |
*** prad has joined #openstack-dev | 16:12 | |
*** jpomero has joined #openstack-dev | 16:12 | |
*** gszasz has joined #openstack-dev | 16:13 | |
*** pschaef has quit IRC | 16:13 | |
*** ik__ has joined #openstack-dev | 16:13 | |
ik__ | hi | 16:13 |
*** sahid has joined #openstack-dev | 16:13 | |
ik__ | sorry to ask very basic question | 16:13 |
*** alop has quit IRC | 16:14 | |
ik__ | how filter REST requests can be fired? | 16:14 |
*** Ruetobas has joined #openstack-dev | 16:14 | |
ik__ | I mean how can I fire search request | 16:14 |
marekd | dolphm: let me run full testsuite. | 16:14 |
*** mgagne has joined #openstack-dev | 16:14 | |
*** hemna has joined #openstack-dev | 16:15 | |
*** markwash has quit IRC | 16:15 | |
*** eharney has quit IRC | 16:15 | |
*** pmathews has joined #openstack-dev | 16:16 | |
*** mgagne1 has joined #openstack-dev | 16:16 | |
*** rcj` has joined #openstack-dev | 16:16 | |
*** nkinder has joined #openstack-dev | 16:16 | |
*** sgordon_ has quit IRC | 16:18 | |
*** pschaef has joined #openstack-dev | 16:18 | |
*** topol has quit IRC | 16:19 | |
*** mgagne has quit IRC | 16:19 | |
*** gyee has joined #openstack-dev | 16:19 | |
*** trey_h has quit IRC | 16:19 | |
*** alop has joined #openstack-dev | 16:20 | |
*** belmoreira has quit IRC | 16:22 | |
*** xgsa has quit IRC | 16:23 | |
*** amuller has quit IRC | 16:24 | |
ik__ | any one? | 16:24 |
*** lucas-hungry is now known as lucasagomes | 16:25 | |
*** rcj has quit IRC | 16:25 | |
*** rcj` is now known as rcj | 16:25 | |
terrylhowe | ik__ http://docs.openstack.org/api/openstack-network/2.0/content/filtering.html | 16:26 |
ik__ | awesome thanks terrylhowe, I was trying /search/? | 16:27 |
ik__ | thanks again | 16:27 |
*** mgagne1 has quit IRC | 16:28 | |
marekd | dolphm: Patchset 19 landed. | 16:28 |
*** oro has quit IRC | 16:28 | |
*** mgagne has joined #openstack-dev | 16:28 | |
*** LinuxJedi is now known as LinuxJedi__ | 16:29 | |
*** mancdaz is now known as mancdaz_away | 16:29 | |
*** mrodden has quit IRC | 16:30 | |
*** dvarga is now known as dvarga|away | 16:30 | |
*** dvarga|away is now known as dvarga | 16:30 | |
*** mgagne1 has joined #openstack-dev | 16:30 | |
dolphm | marekd: thanks! | 16:30 |
*** galstrom is now known as galstrom_zzz | 16:31 | |
*** mancdaz_away is now known as mancdaz | 16:31 | |
*** SumitNaiksatam has joined #openstack-dev | 16:32 | |
*** glenng has joined #openstack-dev | 16:32 | |
*** mgagne has quit IRC | 16:33 | |
*** taps has joined #openstack-dev | 16:33 | |
*** DinaBelova_ is now known as DinaBelova | 16:33 | |
marekd | ayoung: dolphm : meeting today at normal time, or it's put off due to mess with merging the code and burning reviews? | 16:33 |
*** eharney has joined #openstack-dev | 16:33 | |
ayoung | lets meet | 16:34 |
dolphm | marekd: we'll have one, but it'll likely be 100% about i2 vs i3 | 16:34 |
ayoung | we can focus people on the release...don't need the full time | 16:34 |
*** oro has joined #openstack-dev | 16:34 | |
devoid | are there instructions for configuring tempest to run tests against a "real" openstack deployment? | 16:35 |
*** ala_ has quit IRC | 16:36 | |
marekd | ok, i am out of here for the moment. Should be back for the meeting. | 16:37 |
marekd | cheers. | 16:37 |
*** marekd is now known as marekd|away | 16:38 | |
*** xarses has quit IRC | 16:39 | |
*** teran_ has quit IRC | 16:40 | |
*** teran has joined #openstack-dev | 16:40 | |
*** galstrom_zzz is now known as galstrom | 16:41 | |
*** markwash has joined #openstack-dev | 16:41 | |
*** garyk has quit IRC | 16:41 | |
*** mgagne1 is now known as mgagne | 16:42 | |
*** vkmc has quit IRC | 16:44 | |
*** LinuxJedi__ has quit IRC | 16:44 | |
*** YorikSar has joined #openstack-dev | 16:44 | |
dolphm | marekd|away: https://review.openstack.org/#/c/60244/ | 16:45 |
*** thuc has joined #openstack-dev | 16:45 | |
dolphm | ayoung: ^ | 16:45 |
*** tmclaugh[work] has quit IRC | 16:45 | |
*** bauzas has quit IRC | 16:45 | |
stevemar | dolphm, put this one on your radar https://bugs.launchpad.net/keystone/+bug/1271235 | 16:45 |
*** odyssey4me has quit IRC | 16:45 | |
dolphm | stevemar: ++ i mentioned that in the code review when it landed, need to follow up with jaypipes | 16:46 |
devoid | just doing "testr list-tests" gives me crazy silly output | 16:46 |
*** markmc has quit IRC | 16:46 | |
devoid | Non-zero exit code (2) from test listing. stdout='\xb3)\x01@b@Wtempest.api.baremetal.test_api_discovery.TestApiDiscovery.test_api_versions[gate,smoke]\xf1\xb5\x19t\xb3 ... | 16:46 |
*** emagana has joined #openstack-dev | 16:47 | |
*** mdomsch has quit IRC | 16:47 | |
*** pablosan has joined #openstack-dev | 16:47 | |
*** Mandell has quit IRC | 16:48 | |
*** dkuffner has quit IRC | 16:48 | |
*** tkay has joined #openstack-dev | 16:48 | |
*** achampio1 has joined #openstack-dev | 16:48 | |
*** gokrokve has quit IRC | 16:49 | |
*** iartarisi has quit IRC | 16:49 | |
*** gokrokve has joined #openstack-dev | 16:49 | |
stevemar | dolphm, just noticed it now that marek was going right to the wsgi layer to return content for a PUT operation | 16:49 |
*** ndn9797 has joined #openstack-dev | 16:49 | |
stevemar | dolphm, was wondering if there wasn't something easier | 16:50 |
*** achampion has quit IRC | 16:50 | |
*** hartsocks has joined #openstack-dev | 16:50 | |
dolphm | stevemar: not for when you want to customize the response like that | 16:50 |
stevemar | dolphm line 159 https://review.openstack.org/#/c/60244/19/keystone/contrib/federation/controllers.py | 16:50 |
stevemar | mm | 16:50 |
*** mrodden has joined #openstack-dev | 16:50 | |
stevemar | i suppose | 16:50 |
ndn9797 | #openstack-manila | 16:50 |
*** mdomsch has joined #openstack-dev | 16:50 | |
*** jmeridth has joined #openstack-dev | 16:50 | |
stevemar | we can improve that later i guess | 16:50 |
devoid | do I need to switch my encoding off UTF-8 for testr to output properly? | 16:51 |
*** gokrokve_ has joined #openstack-dev | 16:51 | |
*** topol has joined #openstack-dev | 16:51 | |
*** arozumenko has quit IRC | 16:53 | |
topol | ayoung, who was the Barbican person you introduced me to at the hackathon and what is his email? | 16:54 |
*** gokrokve has quit IRC | 16:54 | |
ayoung | topol, um... | 16:54 |
dolphm | topol: ayoung: jarret raim? | 16:54 |
ayoung | they are all in #openstack-barbican | 16:54 |
ayoung | dolphm, he was one of them, yes | 16:54 |
* ayoung still thinks he sounds like acharacter from the Wheel of Time series | 16:55 | |
*** mkollaro1 has quit IRC | 16:55 | |
topol | ayoung, Tom something? | 16:55 |
dolphm | topol: ayoung: first.last@rackspace.com | 16:55 |
*** yaguang has quit IRC | 16:55 | |
topol | was he a racker or a red hat person? | 16:55 |
*** fbo is now known as fbo_away | 16:55 | |
ayoung | The Red Hatter was alee | 16:55 |
ayoung | Ade Lee. | 16:55 |
*** MaxV has quit IRC | 16:56 | |
topol | well this is awkward :-) | 16:56 |
*** fbo_away is now known as fbo | 16:57 | |
topol | dolphm, ayoung John Wood perhaps? | 16:57 |
*** doug_shelley66 has quit IRC | 16:57 | |
*** DinaBelova is now known as DinaBelova_ | 16:58 | |
*** neeti has joined #openstack-dev | 16:58 | |
*** tmclaugh[work] has joined #openstack-dev | 16:58 | |
ayoung | topol, https://launchpad.net/~barbican-core/+members#active | 16:58 |
*** doug_shelley66 has joined #openstack-dev | 16:58 | |
*** bdpayne has joined #openstack-dev | 16:58 | |
ayoung | The two RHers were alee (ade) and edewata (Endi Dewata) | 16:58 |
*** neelashah has quit IRC | 16:58 | |
topol | Thats where I got the name. I think it was John Wood. ayoung glad to see your memory is as bad as mine :-) | 16:59 |
*** neelashah has joined #openstack-dev | 16:59 | |
dolphm | topol: woodster in irc | 16:59 |
ayoung | topol, I can't remember who talked to whom when | 16:59 |
*** gszasz has quit IRC | 16:59 | |
topol | dolphm, ayoung, cool. I'll send an intro email. I found an IBMer to start contributing to Barbican | 17:00 |
*** tqtran has joined #openstack-dev | 17:00 | |
ayoung | ++ | 17:00 |
*** I159 has quit IRC | 17:01 | |
dolphm | woot! | 17:02 |
devoid | Am I just completely misunderstanding how tempest is supposed to be used? | 17:02 |
*** med_ has quit IRC | 17:02 | |
*** nati_uen_ has joined #openstack-dev | 17:02 | |
*** nati_uen_ has quit IRC | 17:02 | |
*** nati_uen_ has joined #openstack-dev | 17:03 | |
*** medberry has joined #openstack-dev | 17:03 | |
*** medberry has quit IRC | 17:03 | |
*** medberry has joined #openstack-dev | 17:03 | |
*** s2r2_ has joined #openstack-dev | 17:03 | |
*** eglynn is now known as eglynn-afk | 17:03 | |
*** nati_ueno has quit IRC | 17:03 | |
*** markwash has quit IRC | 17:03 | |
*** neelashah has quit IRC | 17:03 | |
*** mkollaro has joined #openstack-dev | 17:04 | |
*** tmclaugh[work] has quit IRC | 17:04 | |
*** rtheis_ has joined #openstack-dev | 17:05 | |
*** hartsocks1 has joined #openstack-dev | 17:06 | |
*** dstanek_afk has joined #openstack-dev | 17:06 | |
*** johnthetubaguy1 has joined #openstack-dev | 17:06 | |
*** devoid1 has joined #openstack-dev | 17:06 | |
*** vkozhukalov has joined #openstack-dev | 17:06 | |
*** devoid1 has quit IRC | 17:07 | |
*** dave_tucker has left #openstack-dev | 17:07 | |
*** devoid1 has joined #openstack-dev | 17:07 | |
roaet | devoid: what do you mean? | 17:07 |
*** CaptTofu_ has joined #openstack-dev | 17:07 | |
roaet | Ah, the utf-8 error thing? | 17:07 |
*** yjiang5_1 has joined #openstack-dev | 17:07 | |
*** gokrokve_ has quit IRC | 17:08 | |
devoid1 | well, first off: testr list-tests returns a non-zero exit status | 17:08 |
*** ctlaugh_ has joined #openstack-dev | 17:08 | |
devoid1 | that too | 17:08 |
roaet | I have personally never tried to use that function. | 17:08 |
roaet | I can try it. | 17:08 |
*** saschpe has joined #openstack-dev | 17:08 | |
*** alop has quit IRC | 17:08 | |
*** tkay_ has joined #openstack-dev | 17:08 | |
bknudson | "tox -e venv testr list-tests" worked for me. | 17:08 |
*** xarg__ has joined #openstack-dev | 17:09 | |
*** kgriffs has quit IRC | 17:09 | |
*** tkay has quit IRC | 17:09 | |
*** johnthetubaguy has quit IRC | 17:09 | |
*** alpha_ori has quit IRC | 17:09 | |
*** saschpe_ has quit IRC | 17:09 | |
*** ctlaugh has quit IRC | 17:09 | |
bknudson | (in keystone) | 17:09 |
*** CaptTofu has quit IRC | 17:09 | |
*** devoid has quit IRC | 17:09 | |
*** shadower has quit IRC | 17:09 | |
*** Makdaam has quit IRC | 17:09 | |
*** lifeless has quit IRC | 17:09 | |
*** mrda_ has quit IRC | 17:09 | |
*** xarg has quit IRC | 17:09 | |
*** trevorjay has quit IRC | 17:09 | |
*** csaba|afk has quit IRC | 17:09 | |
*** csaba|afk has joined #openstack-dev | 17:09 | |
*** shadower_ has joined #openstack-dev | 17:09 | |
*** tkay_ is now known as tkay | 17:09 | |
*** mrda has joined #openstack-dev | 17:09 | |
*** csaba|afk has quit IRC | 17:09 | |
*** csaba|afk has joined #openstack-dev | 17:09 | |
*** achampion has joined #openstack-dev | 17:09 | |
*** lifeless1 has joined #openstack-dev | 17:09 | |
*** xarg_ is now known as xarg | 17:09 | |
*** hartsocks has quit IRC | 17:09 | |
*** hemna has quit IRC | 17:09 | |
*** dstanek has quit IRC | 17:09 | |
*** afazekas has quit IRC | 17:09 | |
*** rtheis has quit IRC | 17:09 | |
*** matiu has quit IRC | 17:09 | |
*** skraynev has quit IRC | 17:09 | |
*** yjiang5 has quit IRC | 17:09 | |
*** jeblair has quit IRC | 17:09 | |
*** ndn9797 has quit IRC | 17:09 | |
*** skraynev has joined #openstack-dev | 17:09 | |
*** afazekas has joined #openstack-dev | 17:09 | |
roaet | devoid1: are there any other messages? | 17:09 |
*** matiu has joined #openstack-dev | 17:09 | |
dsantos_ | Hi, I was thinking about defining a cloud admin role. I saw that currently the only way for doing this is to create an admin domain, assign an admin role for a user in this domain and specify the "cloud_admin" rule in the policy.json based on the domain_id. But I think that conceptually the cloud admin should not have a default project or domain, like it's needed currently. Also I think that the cloud admin should get a unscoped token and h | 17:09 |
*** alpha_ori has joined #openstack-dev | 17:09 | |
*** hemna has joined #openstack-dev | 17:09 | |
roaet | devoid1: I'm getting /opt/stack/neutron/.venv/bin/python: No module named subunit , which I know how to fix, but are you getting that? | 17:10 |
*** matiu has quit IRC | 17:10 | |
*** matiu has joined #openstack-dev | 17:10 | |
*** kgriffs has joined #openstack-dev | 17:10 | |
*** trevorj has joined #openstack-dev | 17:10 | |
*** jeblair has joined #openstack-dev | 17:10 | |
*** HT_Sergio has quit IRC | 17:11 | |
*** morganfainberg has quit IRC | 17:11 | |
*** morganfainberg has joined #openstack-dev | 17:11 | |
ayoung | looks like I am going to be adding IdP support to revocations | 17:11 |
*** achampio1 has quit IRC | 17:11 | |
*** Makdaam has joined #openstack-dev | 17:11 | |
*** xga has quit IRC | 17:12 | |
devoid1 | bknudson I'm within a virtualenv already so I'm not sure what tox -e venv is going to do beyond that | 17:12 |
devoid1 | roaet: nope. | 17:12 |
devoid1 | $ ./run_tests.sh : testr: error: no such option: -l | 17:13 |
devoid1 | Ran 0 tests in 0.065s | 17:13 |
devoid1 | OK | 17:13 |
*** _cjones_ has joined #openstack-dev | 17:13 | |
roaet | have you run testr init? | 17:13 |
stevemar | ayoung, you can do that work as a bug in i3 :) | 17:13 |
*** jasondotstar has quit IRC | 17:13 | |
ayoung | stevemar, ++ | 17:13 |
*** alop has joined #openstack-dev | 17:14 | |
devoid1 | roaet: yea, $ testr stats runs=1 | 17:14 |
ayoung | stevemar, if we include the Keystone internal IdP in there, it will be a way to say "refuse all tokens I've issued." | 17:14 |
roaet | I'm not really sure what's happening :( | 17:14 |
roaet | it may be helpful to ask in #openstack-qa | 17:14 |
*** devoid1 is now known as devoid | 17:14 | |
*** dvarga is now known as dvarga|away | 17:14 | |
*** dvarga|away is now known as dvarga | 17:14 | |
*** jistr has quit IRC | 17:15 | |
devoid | roaet: thanks, checking over there | 17:15 |
*** bdpayne has quit IRC | 17:15 | |
*** e0ne has quit IRC | 17:16 | |
*** neelashah has joined #openstack-dev | 17:16 | |
*** martyntaylor has quit IRC | 17:16 | |
*** danpb has quit IRC | 17:16 | |
*** kwss has quit IRC | 17:16 | |
*** thuc has quit IRC | 17:17 | |
*** buzztroll has joined #openstack-dev | 17:18 | |
*** thuc has joined #openstack-dev | 17:18 | |
*** mgagne has quit IRC | 17:18 | |
*** sushils has quit IRC | 17:18 | |
ayoung | marekd|away, dolphm why is there no driver definition in federation/core.py | 17:18 |
*** MarkAtwood has joined #openstack-dev | 17:18 | |
*** buzztroll has quit IRC | 17:19 | |
*** vartom1111111119 has joined #openstack-dev | 17:19 | |
*** CaptTofu_ has quit IRC | 17:19 | |
dolphm | ayoung: there's no defined interface -- i was going to add one in a subsequent patch | 17:20 |
*** garyk has joined #openstack-dev | 17:20 | |
ayoung | so...letting it settle out before defining the Driver? How novel | 17:20 |
ayoung | OK...I can deal with that. Its odd, though | 17:20 |
dolphm | ayoung: agree, it was an oversight by me until recently | 17:20 |
ayoung | Yeah, Ididn't see it first go-round | 17:21 |
ayoung | not a stop-ship, though | 17:21 |
*** buzztroll has joined #openstack-dev | 17:21 | |
*** aswadrangnekar has joined #openstack-dev | 17:22 | |
*** tdruiva has joined #openstack-dev | 17:22 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 17:22 | |
*** sagar_nikam has joined #openstack-dev | 17:22 | |
*** thuc has quit IRC | 17:22 | |
*** pschaef has quit IRC | 17:23 | |
*** tdruiva has quit IRC | 17:23 | |
*** xga has joined #openstack-dev | 17:23 | |
*** smurugesan has joined #openstack-dev | 17:23 | |
*** kushal has joined #openstack-dev | 17:23 | |
*** ytwu has quit IRC | 17:24 | |
*** ytwu has joined #openstack-dev | 17:24 | |
*** tdruiva has joined #openstack-dev | 17:24 | |
*** nermina has quit IRC | 17:25 | |
ayoung | dolphm, I thought there was a REST V3 Controller that removed the need for lots of the boilerplate REST code? | 17:25 |
*** mkollaro has quit IRC | 17:25 | |
*** jasondotstar has joined #openstack-dev | 17:25 | |
*** angdraug has joined #openstack-dev | 17:25 | |
*** teran has quit IRC | 17:26 | |
*** thuc has joined #openstack-dev | 17:26 | |
*** aswadrangnekar has quit IRC | 17:26 | |
*** anniec has quit IRC | 17:26 | |
ayoung | stevemar, "I think we still need a test for user defined id's ..." but not enough to -1? | 17:26 |
*** corXi has quit IRC | 17:27 | |
*** thuc has quit IRC | 17:27 | |
ayoung | Isn't that covered by the recent sql handles conflict update? | 17:27 |
*** thuc has joined #openstack-dev | 17:27 | |
ayoung | https://review.openstack.org/#/c/60244/20/keystone/tests/test_v3_federation.py line 189? | 17:28 |
*** romcheg has quit IRC | 17:28 | |
stevemar | ayoung, i saw that earlier too | 17:28 |
ayoung | I'm prepping a +2 Approve. Going once. | 17:28 |
*** xarses has joined #openstack-dev | 17:28 | |
stevemar | ayoung, but there no verifying that the id is actually that id :) | 17:29 |
stevemar | theres no assertions in that test | 17:29 |
stevemar | just being picky | 17:29 |
*** vkmc has joined #openstack-dev | 17:29 | |
*** morazi has quit IRC | 17:29 | |
stevemar | go ahead and +2 it | 17:29 |
ayoung | you mean that it is not generated? Is there a test that creates and then fetches the IdP? | 17:29 |
stevemar | creates with a non-user defined id | 17:30 |
stevemar | but not with a user defined id | 17:30 |
*** mancdaz is now known as mancdaz_away | 17:30 | |
*** viktors has left #openstack-dev | 17:30 | |
stevemar | but it's very likely that marek is afk for the evening, and we can add a test later | 17:30 |
stevemar | or treat a problem as a bug | 17:30 |
*** comay_away has quit IRC | 17:30 | |
*** comay_away has joined #openstack-dev | 17:31 | |
*** Drankis has joined #openstack-dev | 17:31 | |
ayoung | ++ | 17:31 |
*** exed_ has quit IRC | 17:33 | |
ayoung | dolphm, +2 approved. Moving on to addressing commens in the revoke code | 17:33 |
*** eglynn-afk is now known as eglynn | 17:33 | |
*** mindpixel has quit IRC | 17:34 | |
*** comay_away is now known as comay | 17:34 | |
*** csd has joined #openstack-dev | 17:34 | |
morganfainberg | allo | 17:35 |
morganfainberg | morning and all that | 17:35 |
dolphm | ayoung: marekd|away: https://review.openstack.org/#/c/68184/ | 17:35 |
*** afazekas has quit IRC | 17:35 | |
ayoung | dolphm, looks about right....will add to the queue... | 17:35 |
dolphm | ayoung: i haven't even run offline tests | 17:36 |
ayoung | dolphm, yeah, NP on that. | 17:36 |
*** doug-fish has quit IRC | 17:36 | |
ayoung | bknudson, I disagree on breaking out the extension thing into its own patch | 17:36 |
ayoung | it does not need explicit testing, it just needs to be there for my patch to land | 17:37 |
ayoung | its not worth the added effort | 17:37 |
*** marun has quit IRC | 17:38 | |
*** tqtran has quit IRC | 17:38 | |
*** achampio1 has joined #openstack-dev | 17:39 | |
*** kumaranvram has joined #openstack-dev | 17:39 | |
*** kumaranvram has quit IRC | 17:39 | |
*** achampion has quit IRC | 17:39 | |
*** cmyster has joined #openstack-dev | 17:40 | |
*** READ10 has quit IRC | 17:40 | |
*** MaxV has joined #openstack-dev | 17:42 | |
*** READ10 has joined #openstack-dev | 17:42 | |
bknudson | ayoung: if the revoke code is removed for whatever reason it's not going to be tested? | 17:42 |
ayoung | true | 17:43 |
*** gokrokve has joined #openstack-dev | 17:43 | |
*** asselin has joined #openstack-dev | 17:43 | |
*** oro has quit IRC | 17:43 | |
*** gokrokve has quit IRC | 17:43 | |
ayoung | bknudson, there is so much I want to change about how we enumerate and navigate to extensions... | 17:43 |
topol | dolphm, why would someone decorate a wrapper with @property like is done in https://review.openstack.org/#/c/59604/12/keystone/contrib/kds/api/v1/models/base.py ? | 17:43 |
*** gokrokve has joined #openstack-dev | 17:43 | |
ayoung | But I'm under deadline here, and this is not priority | 17:43 |
*** marun has joined #openstack-dev | 17:44 | |
bknudson | ayoung: I don't understand why we need to change the extensions code for this one... we've already got the admin and public extensions | 17:44 |
bknudson | and that seems to work for every other extension but this one? | 17:44 |
morganfainberg | topol. line#? | 17:44 |
ayoung | bknudson, this is V3 only | 17:44 |
bknudson | all of the recent extensions have been? | 17:44 |
ayoung | other extensions should be doing that as well, but we have legacy | 17:44 |
ayoung | trying to avoid that | 17:44 |
dolphm | topol: excellent question. i'm not sure | 17:44 |
topol | morganfainberg 31 | 17:45 |
dolphm | jamielennox|away: ^ | 17:45 |
kmartin | sdague: Hi Sean, any chance you could look at https://review.openstack.org/#/c/65179/ it has four +1's (including John Griffith) and now gate appears to be working as you had a requirement patch land today? This requirement change in holding up a new cinder driver that is targetted to landed in Icehouse-2 | 17:45 |
*** sn6i23a has joined #openstack-dev | 17:45 | |
*** DinaBelova_ is now known as DinaBelova | 17:45 | |
topol | dolphm, is 59604 something that needs to land or can I -1 and comment that line with a wtf? | 17:46 |
*** jistr has joined #openstack-dev | 17:47 | |
morganfainberg | topol, dolphm, it looks like it is because @memoize is being used in lieu of @property | 17:47 |
*** drankis_ has joined #openstack-dev | 17:48 | |
morganfainberg | @memoize is encompassing the effect of @property, though I'd argue @memoize is a bad name, it should be @memoized_property if that is the intended effect | 17:48 |
*** sarob has joined #openstack-dev | 17:48 | |
morganfainberg | @memoize feels like it should be what dogpile does, not restricted to self as being the only argument | 17:48 |
*** nati_ueno has joined #openstack-dev | 17:51 | |
*** nati_ueno has quit IRC | 17:51 | |
*** neeti has quit IRC | 17:51 | |
*** eglynn has quit IRC | 17:51 | |
*** harlowja_away is now known as harlowja | 17:51 | |
*** nati_ueno has joined #openstack-dev | 17:51 | |
*** Drankis has quit IRC | 17:51 | |
dolphm | topol: already targeted at i3 | 17:52 |
*** mrunge has joined #openstack-dev | 17:53 | |
*** kgriffs is now known as kgriffs_afk | 17:53 | |
*** CaptTofu has joined #openstack-dev | 17:53 | |
*** coolsvap is now known as coolsvap_away | 17:54 | |
*** amcrn has joined #openstack-dev | 17:54 | |
*** ik__ has quit IRC | 17:55 | |
*** mestery has quit IRC | 17:55 | |
*** nati_uen_ has quit IRC | 17:55 | |
morganfainberg | dolphm, are we not doing translation stuff for kds? | 17:55 |
*** dave_tucker has joined #openstack-dev | 17:55 | |
*** drankis_ has quit IRC | 17:55 | |
*** mmagr has quit IRC | 17:55 | |
*** vkmc has quit IRC | 17:55 | |
*** Drankis has joined #openstack-dev | 17:55 | |
dolphm | morganfainberg: not so far, but we should | 17:55 |
*** xga has quit IRC | 17:55 | |
ayoung | bknudson, re: putting the revoke into the token-delete code: it doesn' | 17:56 |
*** sarob_ has joined #openstack-dev | 17:56 | |
ayoung | t match in useage | 17:56 |
morganfainberg | dolphm, ok wont -1 on that then. wasn't sure. | 17:56 |
bknudson | ayoung: ok, just wanted you to consider it. | 17:56 |
ayoung | there are a lot of places doing explcit token deletes, one per something that we need to do in bulk | 17:56 |
ayoung | yeah, I tried that first | 17:56 |
*** marekd|away is now known as marekd | 17:56 | |
ayoung | I don't love the code as is, but bascially we need to replace the existing calls with the new calls, over time.... | 17:57 |
*** sarob__ has joined #openstack-dev | 17:57 | |
*** ruhe is now known as _ruhe | 17:57 | |
*** moijes12 has joined #openstack-dev | 17:57 | |
*** arozumenko has joined #openstack-dev | 17:58 | |
*** sarob has quit IRC | 17:58 | |
*** sarob___ has joined #openstack-dev | 17:58 | |
*** derekh has quit IRC | 17:58 | |
*** tqtran has joined #openstack-dev | 17:59 | |
*** sarob has joined #openstack-dev | 17:59 | |
*** sarob has quit IRC | 18:00 | |
*** s2r2_ has quit IRC | 18:00 | |
*** sarob_ has quit IRC | 18:00 | |
*** teran has joined #openstack-dev | 18:01 | |
*** florentflament has quit IRC | 18:01 | |
*** jamielennox|away is now known as jamielennox | 18:01 | |
*** stevemar has left #openstack-dev | 18:01 | |
*** sarob__ has quit IRC | 18:02 | |
*** stevemar has joined #openstack-dev | 18:02 | |
*** avishay has quit IRC | 18:03 | |
*** sarob___ has quit IRC | 18:03 | |
*** athomas has quit IRC | 18:04 | |
*** bdpayne has joined #openstack-dev | 18:04 | |
*** doug-fish has joined #openstack-dev | 18:04 | |
*** vartom1111111119 has quit IRC | 18:05 | |
*** arnaud has joined #openstack-dev | 18:05 | |
*** arnaud__ has joined #openstack-dev | 18:05 | |
*** sagar_nikam has quit IRC | 18:06 | |
*** amuller has joined #openstack-dev | 18:06 | |
*** max_lobur is now known as max_lobur_afk | 18:07 | |
*** martyntaylor has joined #openstack-dev | 18:09 | |
*** omachace has joined #openstack-dev | 18:09 | |
*** evgenyf has quit IRC | 18:11 | |
*** mdomsch has quit IRC | 18:11 | |
*** safchain has quit IRC | 18:12 | |
*** MaxV has quit IRC | 18:12 | |
*** yamahata has joined #openstack-dev | 18:13 | |
*** sarob has joined #openstack-dev | 18:13 | |
*** moijes12 has quit IRC | 18:14 | |
*** markwash has joined #openstack-dev | 18:15 | |
*** mikeoutland has joined #openstack-dev | 18:16 | |
*** dims has quit IRC | 18:17 | |
*** nermina has joined #openstack-dev | 18:17 | |
*** martyntaylor has left #openstack-dev | 18:20 | |
*** raildo has joined #openstack-dev | 18:21 | |
*** arozumenko has quit IRC | 18:22 | |
*** morazi has joined #openstack-dev | 18:22 | |
*** radez_g0n3 is now known as radez | 18:23 | |
*** dims has joined #openstack-dev | 18:24 | |
*** dvarga is now known as dvarga|away | 18:25 | |
*** dvarga|away is now known as dvarga | 18:25 | |
*** akrivoka has quit IRC | 18:26 | |
devoid | anyone here setup tempest against non-devstack targets? | 18:26 |
*** jp_at_hp has quit IRC | 18:27 | |
*** JordanP has quit IRC | 18:30 | |
*** dripton is now known as dripton_shovelin | 18:30 | |
*** xmltok has joined #openstack-dev | 18:30 | |
*** angdraug has quit IRC | 18:31 | |
*** kgriffs_afk is now known as kgriffs | 18:31 | |
tellesnobrega | can anyone help me understand what the "owner" : "user_id:%(user_id)s or user_id:%(target.token.user_id)s" rule in policy means? | 18:33 |
*** bvandenh has quit IRC | 18:34 | |
*** browne has quit IRC | 18:36 | |
*** Mandell has joined #openstack-dev | 18:37 | |
*** liuyu has joined #openstack-dev | 18:37 | |
*** liuyu has left #openstack-dev | 18:37 | |
dolphm | stevemar: marekd: one of you working on https://review.openstack.org/#/c/60424/ ? | 18:38 |
*** markwash has quit IRC | 18:38 | |
stevemar | dolphm, yes | 18:38 |
stevemar | i am | 18:38 |
stevemar | rebasing now | 18:38 |
dolphm | stevemar: let me know when you have a patchset | 18:38 |
stevemar | and changing it to PUT | 18:38 |
stevemar | soon | 18:38 |
dolphm | stevemar: 2 hours 40 minutes until it must be gating | 18:39 |
dolphm | stevemar: let me know if you need help | 18:39 |
stevemar | dolphm, should be ok | 18:40 |
*** nati_uen_ has joined #openstack-dev | 18:40 | |
*** markwash has joined #openstack-dev | 18:41 | |
*** galstrom is now known as galstrom_zzz | 18:42 | |
devoid | tellesnobrega, "For | 18:42 |
devoid | any of the objects that have a user_id, you can use the policy rule | 18:42 |
devoid | "user_id:%(user_id)s", which will only be true if the user_id in the | 18:42 |
devoid | context is the same as the user_id on the object access is being checked | 18:42 |
devoid | against. " http://lists.openstack.org/pipermail/openstack/2013-December/003710.html | 18:42 |
*** mrunge has quit IRC | 18:43 | |
*** nati_ueno has quit IRC | 18:43 | |
*** browne has joined #openstack-dev | 18:43 | |
devoid | < still has tempest issues | 18:43 |
tellesnobrega | devoid: thanks | 18:43 |
*** Alexei_987 has joined #openstack-dev | 18:43 | |
Alexei_987 | jamielennox: Hello :) please ping me here if you would like to discuss clients topic | 18:44 |
devoid | markwash, ping | 18:45 |
jamielennox | Alexei_987: i'm around but in #openstack-meeting | 18:46 |
tellesnobrega | devoid: do you know what is the difference between using user_id:%(user_id)s and user_id:%(target.token.user_id)s by that i mean user_id and target.token.user_id? | 18:46 |
*** jprovazn has joined #openstack-dev | 18:47 | |
devoid | tellesnobrega, I do not, sorry. | 18:47 |
markwash | devoid: hello | 18:47 |
tellesnobrega | devoid: thanks anyway | 18:47 |
*** tellesnobrega has left #openstack-dev | 18:47 | |
*** dstanek_afk is now known as dstanek | 18:47 | |
*** tellesnobrega has joined #openstack-dev | 18:47 | |
*** obondarev_ has joined #openstack-dev | 18:47 | |
devoid | markwash, did you have a chance to look at https://bugs.launchpad.net/glance/+bug/1258342 | 18:47 |
*** nermina has quit IRC | 18:47 | |
*** nermina has joined #openstack-dev | 18:48 | |
*** mfer has quit IRC | 18:48 | |
*** mfer has joined #openstack-dev | 18:48 | |
*** marun has quit IRC | 18:48 | |
markwash | devoid: I was looking at it but it sounded like it was not reproducible on devstack? | 18:49 |
*** marun has joined #openstack-dev | 18:49 | |
devoid | markwash, that is correct. | 18:49 |
*** hartsocks1 has quit IRC | 18:50 | |
dstanek | henrynash: what's up with https://review.openstack.org/#/c/43257? | 18:50 |
henrynash | dstanek: somehow the approval on https://review.openstack.org/#/c/43257/54 got knocked off when I submitted a patch that was dependant on it…since it was approved it is already someway up the gate queue….not sure if Dolphm needs reapply approval or won't that matter? | 18:51 |
markwash | devoid: you said recently, "we are still seeing issues on several counts with 0.12.0" | 18:51 |
*** amuller has quit IRC | 18:51 | |
markwash | devoid: are those blocking using 0.12.0? or are you just referring to other things you want to file as bugs? | 18:51 |
devoid | markwash, still seeing the issues outlined in the bug 1258342 | 18:52 |
*** fbo is now known as fbo_away | 18:52 | |
*** jckasper has quit IRC | 18:53 | |
dstanek | henrynash: looks like it is still gating...so maybe it's OK | 18:53 |
markwash | devoid: so you have confirmed that the issue you are seeing with permissions is *not* dependent on the glanceclient version | 18:53 |
markwash | devoid: sorry I might just be having trouble reading today :-) | 18:54 |
*** dripton_shovelin is now known as dripton | 18:54 | |
*** marun has quit IRC | 18:54 | |
devoid | markwash, correct. if you look at the glance logs in http://paste.openstack.org/show/54544/ you can see that it's not even making the right select statements with respect to the owner column. | 18:54 |
*** krotscheck has joined #openstack-dev | 18:56 | |
*** alex_klimov has joined #openstack-dev | 18:56 | |
markwash | devoid: that's interesting. . that is yet another phenomenon that indicates that things are wonky in terms of the role of the user and the tenant that is given in the request | 18:56 |
*** sahid has quit IRC | 18:56 | |
*** kgriffs is now known as kgriffs_afk | 18:57 | |
devoid | markwash, my complete setup is documented in #2 https://bugs.launchpad.net/glance/+bug/1258342/comments/2 | 18:57 |
*** jcoufal-mobile has joined #openstack-dev | 18:57 | |
*** jpomero has quit IRC | 18:57 | |
markwash | devoid: regular users have *no* ability to set the owner when creating an image | 18:57 |
*** cagrev has joined #openstack-dev | 18:57 | |
markwash | there is a line that clearly says "if not admin, image.owner = context.owner (== context.tenant)" | 18:58 |
devoid | ok, well in those cases I see it set to NULL | 18:58 |
*** jchiles has quit IRC | 18:58 | |
*** lifeless1 is now known as lifeless | 18:59 | |
*** garyk has quit IRC | 18:59 | |
*** thuc has quit IRC | 18:59 | |
*** thuc has joined #openstack-dev | 19:00 | |
*** galstrom_zzz is now known as galstrom | 19:00 | |
*** thuc has quit IRC | 19:00 | |
*** thuc has joined #openstack-dev | 19:01 | |
devoid | markwash, e.g. mysql> select count(*) from images where owner is NULL; 17 | 19:01 |
*** marekd is now known as marekd|away | 19:01 | |
*** shadower_ is now known as shadower | 19:02 | |
*** mdomsch has joined #openstack-dev | 19:02 | |
*** nkinder has quit IRC | 19:03 | |
*** jckasper has joined #openstack-dev | 19:03 | |
dolphm | morganfainberg: ayoung: bknudson: fwiw, i'm okay with completely abandoning the 35357 completely (in favor of 5002 or something?), but it'll take some work across a lot of projects to do so | 19:05 |
ayoung | dolphm, 443 | 19:05 |
dolphm | ooh, now i have this dangerous list: ayoung, bknudson, dstanek, jamielennox, morganfainberg, stevemar, gyee, henrynash, topol, marekd, lbragstad, joesavak: ^ | 19:05 |
ayoung | seriously, lets not continue a bad approach | 19:05 |
dolphm | ayoung: that's a bigger conversation though | 19:06 |
dolphm | ayoung: and not just a port change to avoid a conflict | 19:06 |
*** johnthetubaguy1 has quit IRC | 19:06 | |
bknudson | I don't think anyone would stop someone from submitting changes to devstack to get keystone listening on 443. | 19:06 |
*** spzala has quit IRC | 19:07 | |
*** sushils has joined #openstack-dev | 19:07 | |
*** carlp has joined #openstack-dev | 19:07 | |
ayoung | bknudson, most of the changes are there. It implies HTTPD support, but that has been in devstack for a while | 19:08 |
dstanek | dolphm: are other projects hard coding that port? i'm assuming that devstack and tempest do | 19:08 |
*** mkollaro has joined #openstack-dev | 19:08 | |
*** clayb has joined #openstack-dev | 19:09 | |
*** mkollaro has quit IRC | 19:09 | |
dolphm | dstanek: and openstack-manuals and probably all the client projects | 19:09 |
jamielennox | dolphm: list? | 19:09 |
dolphm | jamielennox: now i can ping everyone in iRC | 19:09 |
lbragstad | so if a change is submitted to purpose changing 35357 to 5002, we'll have to do a lot of updating. So, what would be the best short term fix until that happens or lands? | 19:09 |
*** mkollaro has joined #openstack-dev | 19:09 | |
*** dstufft has quit IRC | 19:10 | |
jamielennox | ayoung, dolphm: just so you know when i manage to pass through the auth plugin stuff i fully intend to change the v3 client over to using the publicUrl rather than adminUrl | 19:10 |
ayoung | jamielennox, it is so not Keystone team managed code that I am worried about | 19:10 |
*** dstufft has joined #openstack-dev | 19:10 | |
ayoung | bknudson, dolphm OK...since the I2 pressure is off on revocation events, I am going to break up the review | 19:11 |
lifeless | jamielennox: \o/ please please please | 19:11 |
*** e0ne has joined #openstack-dev | 19:11 | |
ayoung | I think 3: | 19:11 |
bknudson | ayoung: thank you | 19:11 |
*** terriyu has quit IRC | 19:11 | |
*** julienvey_ has joined #openstack-dev | 19:11 | |
ayoung | 1: the extensions stuff 2: Base revoke extension without ties to the other projects, and 3: linking in to the existing code and replacing the existing revocations | 19:11 |
ayoung | there might be a couple other small patches, like the test fix | 19:12 |
*** doug-fish has quit IRC | 19:12 | |
*** markmcclain has joined #openstack-dev | 19:12 | |
jamielennox | lifeless: :) - as far as i know we are the only project that uses the admin port of a service catalog right? | 19:12 |
*** topol has quit IRC | 19:12 | |
ayoung | jamielennox, I am far more concerned about v2/v3 interop | 19:13 |
lifeless | jamielennox: only one we've hit | 19:13 |
*** mkollaro1 has joined #openstack-dev | 19:13 | |
*** mkollaro has quit IRC | 19:13 | |
jamielennox | lifeless: excellent, so when v2 API disappears in K we can deprecate the whole admin port concept | 19:13 |
ayoung | jamielennox, in order to make that happen, we need an interop story. | 19:13 |
*** cmyster has quit IRC | 19:13 | |
jamielennox | ayoung: not if we don't have V2 API | 19:14 |
ayoung | no | 19:14 |
ayoung | we can't break things for people using V2 in the near future | 19:14 |
ayoung | no big bangs | 19:14 |
ayoung | we need to give them a way to port their code | 19:14 |
jamielennox | ayoung: i'm not looking to for now, just changing the v3 client to the public url because it is exactly the same for v3 | 19:14 |
ayoung | and that means we need to have a way of finding both v2 and v3 endpoints out of the same service catalog, and for legacy clients | 19:15 |
jamielennox | ayoung: and we have an actual private/public split then - as opposed to now where admin is what exactly? | 19:15 |
ayoung | or have V3 be on a separate endopoint | 19:15 |
*** melwitt has joined #openstack-dev | 19:15 | |
ayoung | which is a lousy option, too | 19:15 |
jamielennox | ayoung: so i've been reconsidering the idea of putting version numbers into the service catalog as kind of a temporary fix to that | 19:16 |
*** doug-fish has joined #openstack-dev | 19:16 | |
dstanek | keystone devs: oslo's py3kcompat or six's six.moves.urllib? | 19:16 |
jamielennox | dstanek: six | 19:16 |
*** julienvey_ has quit IRC | 19:16 | |
ayoung | jamielennox, its like the port thing...there are no purely "good" options | 19:17 |
ayoung | they all suck in various ways | 19:17 |
harlowja | dolphm ayoung would u guys want to do a little chit-chat with some folks who are interested in keystone at y!, they want to learn more, and although i can offer them some of it, u guys are really the best folks to ask keystone releated questions to (perhaps a short phone call sometime this or next week?); if that is fine with u of course, i think they are not comfortable getting up on IRC and all that... (yes, i don't know why, lol) | 19:17 |
ayoung | OK...how does one go about splitting a patch? | 19:17 |
jamielennox | dolphm, ayoung: if we could do a migration that looks through the existing service_catalog and tags the endpoints in there with the current version then we could smarten the service catalog to support multiple veresions or unversioned | 19:17 |
ayoung | harlowja, can't even offer that to my company right now | 19:17 |
harlowja | :( | 19:18 |
ayoung | harlowja, I'm sorta crushed this week | 19:18 |
harlowja | durn | 19:18 |
harlowja | np | 19:18 |
harlowja | maybe not this week, but sometime? | 19:18 |
ayoung | get them on IRC | 19:18 |
harlowja | ya, i know... | 19:18 |
harlowja | i'll try | 19:18 |
dolphm | harlowja: this week isn't good for anyone lol -- what kind of audience? | 19:18 |
harlowja | some architects, and some devs, i think y! is trying to rework parts of its auth system internally, and i want to make sure they are aware of what keystone is already doing (and not rebuilt it...) | 19:19 |
ayoung | harlowja, tell them my hourly rate for Keystone consulting is $1000K/hour | 19:19 |
harlowja | lol | 19:19 |
harlowja | sweet | 19:19 |
ayoung | And can't be during normal businees hours, only between 1 and 3 AM | 19:19 |
ayoung | Friday nights | 19:20 |
harlowja | :) | 19:20 |
dstanek | ayoung: i'll do it for half! | 19:20 |
devoid | ayoung, now I understand the openstack business model. | 19:20 |
ayoung | dstanek, shhh | 19:20 |
ayoung | they will take you up on it | 19:20 |
harlowja | let me bring in an expert, i know a guy who knows about consulting rates | 19:20 |
ayoung | Mine just went up | 19:20 |
harlowja | i've got to resell your consulting rates, so let me off 10$ | 19:20 |
harlowja | lol | 19:20 |
harlowja | *let me offer | 19:21 |
dstanek | ayoung: the way i spit up patches in the past is just using interactive rebase and keep the original changeset-id on the first commit | 19:21 |
dolphm | i'll do it for 25% and send dstanek and ayoung in my place (that's how this works, right?) | 19:21 |
harlowja | lol | 19:21 |
dstanek | lol | 19:21 |
ayoung | dolphm, you still need to pay me $1000K+ per hour, so it would be a net loss for you | 19:21 |
harlowja | $1000K is alot | 19:21 |
ayoung | plus another $500/hour for dstanek | 19:21 |
dolphm | ayoung: i didn't say i was going to pay you | 19:22 |
harlowja | so ayoung u get 1000000 an hour and pay dstanek 500, lol | 19:22 |
harlowja | seems off :-P | 19:22 |
*** krtaylor has quit IRC | 19:22 | |
harlowja | lol | 19:22 |
harlowja | anyways, i'll try to get them on here, will see how that works out :-P | 19:23 |
*** syed_armani has joined #openstack-dev | 19:23 | |
ayoung | harlowja, yeah, or put together an email with their questions. | 19:24 |
harlowja | kk | 19:24 |
syed_armani | ayoung: hello | 19:24 |
harlowja | thx guys | 19:24 |
*** ayoung is now known as not-really-ayoun | 19:24 | |
*** not-really-ayoun is now known as ayoung-hiding | 19:24 | |
*** ayoung-hiding is now known as ayoung | 19:24 | |
ayoung | jamielennox, if we change the existing endpoints we break old clients | 19:25 |
jamielennox | ayoung: hmm? which part are you referring to | 19:26 |
jamielennox | ayoung: admin -> public? | 19:26 |
*** Mandell has quit IRC | 19:26 | |
*** sarob has quit IRC | 19:26 | |
*** redhat has quit IRC | 19:27 | |
ayoung | jamielennox, if we chopped the /v2.0 off the url | 19:27 |
*** vkozhukalov has quit IRC | 19:27 | |
*** nati_ueno has joined #openstack-dev | 19:27 | |
jamielennox | oh, right | 19:28 |
jamielennox | yep | 19:28 |
jamielennox | so that's kind of what i was thinking with adding a version information to it | 19:28 |
*** gokrokve has quit IRC | 19:28 | |
jamielennox | problem is the service catalog is a little unpredictable with multiple endpoints for the same service | 19:28 |
ayoung | yep | 19:28 |
ayoung | so if we made the v3 client smart enough to crawl the url if it is given a v2 url, we buy some time | 19:29 |
syed_armani | ayoung: Here https://github.com/openstack/oslo-incubator/blob/master/openstack/common/db/sqlalchemy/session.py#L695, create_engine has mysql_traditional_mode=False..I am wondering if there is a way i can set it to true via keystone config so that i can enable mysql traditional mode ??? | 19:29 |
jamielennox | ayoung: god i hate that solution | 19:29 |
ayoung | and only if given a v2 url | 19:29 |
*** cmyster has joined #openstack-dev | 19:29 | |
ayoung | jamielennox, hate the person that got us into this situation, not the hack to get us out | 19:29 |
jamielennox | ayoung: pointing fingers? | 19:30 |
ayoung | absolutely | 19:30 |
ayoung | still on the first envelope | 19:30 |
jamielennox | i don't know who it would be - before my time | 19:30 |
*** mriedem has quit IRC | 19:30 | |
jamielennox | ayoung: i just worry about us ever being able to get out of the situation where we interpret the url | 19:31 |
ayoung | jamielennox, that is why do don't do it for V3, only for V2.0 | 19:31 |
dolphm | woo 4 patches in a row just gated | 19:31 |
*** nati_uen_ has quit IRC | 19:31 | |
ayoung | then when V2.0 goes away. we drop support | 19:31 |
ayoung | http://www.notboring.com/jokes/work/3.htm | 19:31 |
*** markmcclain has quit IRC | 19:32 | |
*** yamahata has quit IRC | 19:33 | |
*** yamahata has joined #openstack-dev | 19:33 | |
*** dvarga is now known as dvarga|away | 19:34 | |
*** dvarga|away is now known as dvarga | 19:34 | |
*** irenab has joined #openstack-dev | 19:35 | |
jamielennox | ayoung: maybe we should just define new endpoints in a new region | 19:35 |
ayoung | jamielennox, nah | 19:35 |
ayoung | identity is the good name | 19:35 |
jamielennox | leave whatever the default was behind as poluted and start again | 19:35 |
jamielennox | ayoung: not service, region | 19:35 |
ayoung | ah... | 19:35 |
ayoung | so a given user choses which region based on version number? | 19:36 |
*** bvandenh has joined #openstack-dev | 19:36 | |
jamielennox | i haven't thought this all the way through so i'm not sure if it will work | 19:36 |
ayoung | nah | 19:36 |
ayoung | won't woprk in a real deployment that is already using regions | 19:36 |
ayoung | its a good thought, though | 19:36 |
jamielennox | ayoung: we have heirarchical regions now | 19:36 |
ayoung | I think hacking the URL is the way to go, and for...2 releases only | 19:37 |
ayoung | once the v2 API is dead, we drop support for it | 19:37 |
*** Mandell has joined #openstack-dev | 19:38 | |
*** drankis_ has joined #openstack-dev | 19:40 | |
*** david_paterson has quit IRC | 19:40 | |
*** HT_Sergio has joined #openstack-dev | 19:41 | |
*** Drankis has quit IRC | 19:41 | |
*** david_paterson has joined #openstack-dev | 19:41 | |
jamielennox | ayoung: does that allow for people to actually fix up their service catalog then | 19:41 |
*** mestery has joined #openstack-dev | 19:41 | |
ayoung | jamielennox, yes | 19:41 |
ayoung | they have /v2.0 in there, but can use v3 against it | 19:42 |
*** redhat has joined #openstack-dev | 19:42 | |
ayoung | once v2 is deprecated, and we have discover, they modify their service catalog to drop the v2 | 19:42 |
*** novas0x2a|laptop has joined #openstack-dev | 19:43 | |
*** cmyster has quit IRC | 19:43 | |
jamielennox | ayoung: is it something we would need to allow other services to do? | 19:44 |
jamielennox | ayoung: anyway - start by reviewing auth_plugin patches then because that is still the route to that fix | 19:44 |
morganfainberg | jamielennox, https://review.openstack.org/#/c/67785/ I have one sticking point, but i'm willing to reverse on it if we really want this in for I2. | 19:45 |
ayoung | jamielennox, I could see the other services wanting it, but it would be in their clients, not ours | 19:45 |
morganfainberg | all comments in line | 19:45 |
jamielennox | ayoung: or like soon as there are priorities here | 19:45 |
morganfainberg | the status code comment is my sticking point. | 19:45 |
*** yolanda has quit IRC | 19:45 | |
jamielennox | ayoung: not once we get session fixed up it isn't | 19:46 |
ayoung | morganfainberg, status code? | 19:47 |
morganfainberg | ayoung, HTTP status code. | 19:47 |
jamielennox | morganfainberg: so i'm not sure what else to throw there | 19:47 |
morganfainberg | ayoung, it's returning 400 | 19:47 |
jamielennox | i looked back at the API doc and i never defined out | 19:47 |
jamielennox | out? one | 19:47 |
morganfainberg | for misconfiguration or inability to get them i'd say 500 is the right one | 19:47 |
ayoung | should be 404 missing, no? | 19:47 |
morganfainberg | it would be either a misconfiguration or a legitimate can't get info. | 19:47 |
*** sarob has joined #openstack-dev | 19:47 | |
morganfainberg | ayoung, well... i could be behind that. | 19:47 |
jamielennox | ayoung: i'm really not a fan of 404 like that because the path is there | 19:47 |
ayoung | not a 400 | 19:47 |
jamielennox | it's some internal thing that's missing | 19:48 |
morganfainberg | ayoung, but def. not 400 and 403 doesn't make sense either (as per gyee) | 19:48 |
ayoung | no, the resource is missing, 404 is appropraite | 19:48 |
morganfainberg | jamielennox, that would be ISE imo (500) if it's legitimately an internal error | 19:48 |
ayoung | 404 | 19:48 |
ayoung | it will make more sense with multiple certs | 19:48 |
*** jckasper_ has joined #openstack-dev | 19:48 | |
morganfainberg | ayoung, 404 is acceptible, and makes sense. | 19:48 |
*** cagrev_ has joined #openstack-dev | 19:49 | |
gyee | morganfainberg, 500 make more sense actually | 19:49 |
*** mriedem has joined #openstack-dev | 19:49 | |
jamielennox | ayoung sure /OS-SIMPLE-CERT/certificates/:id makes sense to throw a 404 | 19:49 |
gyee | file not found is usually a misconfiguration | 19:49 |
*** syed_armani has quit IRC | 19:49 | |
morganfainberg | jamielennox, ++ | 19:49 |
jamielennox | ayoung sure /OS-SIMPLE-CERT/certificates should be able to always return something even if it's empty | 19:49 |
ayoung | an empty list is OK. | 19:49 |
ayoung | 200 | 19:50 |
ayoung | or 204 | 19:50 |
morganfainberg | jamielennox, i'd say 500 if you've configured the server in a way it can't respond. | 19:50 |
gyee | no empty list | 19:50 |
ayoung | without PKI, its 2XX | 19:50 |
gyee | 500 for empty list | 19:50 |
jamielennox | morganfainberg: well the part i'm not sure about is testing if we even need to retrieve certs | 19:50 |
jamielennox | what happens if we use UUID tokens and call the /certificates? | 19:50 |
ayoung | otherwise...put a check in at startup and refuse to start the keystone server | 19:51 |
ayoung | 204 | 19:51 |
*** marun has joined #openstack-dev | 19:51 | |
gyee | ayoung, I could pull the certs from LDAP instead of Keystone | 19:51 |
morganfainberg | if a cert is expected, and cannot be retrieved it is 500. if there are no certs it would be 2XX | 19:52 |
morganfainberg | it's a question to if a cert is expected or there are no certs | 19:52 |
*** jckasper has quit IRC | 19:52 | |
*** thuc has quit IRC | 19:53 | |
*** thuc has joined #openstack-dev | 19:53 | |
*** bfschott has joined #openstack-dev | 19:53 | |
*** cagrev has quit IRC | 19:53 | |
*** thuc has quit IRC | 19:54 | |
*** ekhugen has joined #openstack-dev | 19:54 | |
*** thuc has joined #openstack-dev | 19:54 | |
*** e0ne has quit IRC | 19:54 | |
gyee | morganfainberg, either way, the client has to know | 19:54 |
gyee | so no 2xx response | 19:55 |
gyee | Keystone has to let the client know one way or another that 1) PKI is enable and server is misconfigured, or2) PKI is disabled | 19:55 |
*** ArxCruz has quit IRC | 19:55 | |
morganfainberg | nod. | 19:56 |
*** kgriffs_afk is now known as kgriffs | 19:57 | |
*** GheRivero has quit IRC | 19:57 | |
*** GheRivero has joined #openstack-dev | 19:58 | |
jamielennox | morganfainberg: 501 Not Implemented? | 19:58 |
jamielennox | The server either does not recognize the request method, or it lacks the ability to fulfill the request.[2] Usually this implies future availability (e.g., a new feature of a web-service API). | 19:58 |
morganfainberg | jamielennox, but... it is implemented | 19:58 |
jamielennox | no | 19:58 |
jamielennox | i was going on the future availablility | 19:58 |
jamielennox | i would prefer to distinguish from a basic 500 | 19:58 |
*** gokrokve has joined #openstack-dev | 19:58 | |
*** KurtMartin has joined #openstack-dev | 19:59 | |
gyee | jamielennox, sometimes 500 is OK | 19:59 |
*** Gordonz has quit IRC | 19:59 | |
*** sarob has quit IRC | 20:00 | |
*** gokrokve_ has joined #openstack-dev | 20:00 | |
*** sarob has joined #openstack-dev | 20:00 | |
*** markmc has joined #openstack-dev | 20:01 | |
*** cagrev has joined #openstack-dev | 20:01 | |
jamielennox | ayoung, gyee, morganfainberg, dolphm: https://review.openstack.org/#/c/68225/ | 20:02 |
morganfainberg | jamielennox, ++ looks good to me | 20:03 |
*** romcheg has joined #openstack-dev | 20:03 | |
*** Tuna_ has joined #openstack-dev | 20:03 | |
*** gokrokve has quit IRC | 20:03 | |
ayoung | +2 FILGTM | 20:04 |
morganfainberg | jamielennox, 1 nit, but +2. | 20:04 |
Tuna_ | (maybe stupid) question for one who knows rpc.matchmaker_ring OR oslo-incubator.openstack.rpc.matchmaker_ring -- | 20:04 |
*** cagrev_ has quit IRC | 20:04 | |
Tuna_ | this type of matchmaker accepts a json file of your topic: [host, host] pairs | 20:04 |
jamielennox | morganfainberg: i can change it if it matters | 20:04 |
morganfainberg | jamielennox, it's a nit | 20:04 |
jamielennox | morganfainberg: yea, but i have instant review going here | 20:04 |
Tuna_ | is that file auto generated OR used anywhere by another openstack component? | 20:04 |
*** sarob has quit IRC | 20:05 | |
jamielennox | it's not like i need to wait another 24 hours | 20:05 |
morganfainberg | jamielennox, i like it being more assertive, but you've communicated it clearly | 20:05 |
morganfainberg | jamielennox, your call | 20:05 |
*** Gordonz has joined #openstack-dev | 20:05 | |
morganfainberg | i'd +2 in either case | 20:05 |
*** gokrokve_ has quit IRC | 20:05 | |
dolphm | documenting the 500 seems like overkill, but +500 | 20:05 |
dolphm | +2 lol | 20:05 |
jamielennox | morganfainberg: done | 20:05 |
jamielennox | morganfainberg: i have everything still open here already so it's not like it's a lot of work for a nit | 20:06 |
morganfainberg | jamielennox, hehe | 20:06 |
morganfainberg | jamielennox, +2 again | 20:06 |
jamielennox | dolphm: the discussion before was specific to needing a 500 documented | 20:06 |
*** mrodden1 has joined #openstack-dev | 20:07 | |
dolphm | i like the 204 *shrug* | 20:07 |
*** mrodden has quit IRC | 20:07 | |
jamielennox | now i have to remember how to distinguish between uuid and pki tokens | 20:07 |
morganfainberg | ayoung, https://review.openstack.org/#/c/55908/24/keystone/tests/test_v3_auth.py is there a reason the doSetup isn't part of the main setUp? i can see functionally based upon your changeset, i mean instead of new classes if that is required etc. | 20:07 |
ayoung | dolphm, so do I. I'd rather not start Keystone than give a 500 | 20:07 |
ayoung | morganfainberg, yes | 20:07 |
ayoung | its a base class subclass problem | 20:08 |
morganfainberg | ayoung, and if it's because of deadlines, thats is a fine answer | 20:08 |
jamielennox | ayoung: i don't think the extension should block starting keystone, if keystone in PKI mode wanted to fail because the certs weren't available that would be ok | 20:08 |
ayoung | jamielennox, ++ | 20:08 |
ayoung | what I meant | 20:08 |
*** DinaBelova is now known as DinaBelova_ | 20:08 | |
ayoung | that is what I meant. | 20:08 |
*** bauzas has joined #openstack-dev | 20:08 | |
morganfainberg | ayoung, ok, i'll mark that as something else to unwind with the test conf files fix that i'll try and land post I2 gate ickyness | 20:09 |
ayoung | morganfainberg, thanks | 20:09 |
morganfainberg | ayoung, i have ~5 changesets backloged for cleaning up tests more. | 20:09 |
jamielennox | final call anyone on the 500? | 20:09 |
morganfainberg | moving towards the parallel testing and calling load_backends exactly 1 time per test | 20:09 |
morganfainberg | food times | 20:11 |
morganfainberg | bbib | 20:11 |
*** jistr has quit IRC | 20:11 | |
_cjones_ | food time ++ | 20:11 |
*** markwash has quit IRC | 20:12 | |
jamielennox | gyee: should i call into token.providers to check for UUID vs PKI tokens or just try to read it from CONF? | 20:13 |
*** READ10 has quit IRC | 20:13 | |
gyee | jamlelennox, use token provider, token_format is deprecated | 20:13 |
*** nkinder has joined #openstack-dev | 20:14 | |
gyee | jamielennox, not sure if 204 is appropriate, we need a way to let the client know to stop calling this API | 20:15 |
gyee | if PKI is not enabled | 20:15 |
bknudson | 403 forbidden | 20:15 |
gyee | yeah | 20:15 |
*** krtaylor has joined #openstack-dev | 20:16 | |
*** prad_ has joined #openstack-dev | 20:16 | |
*** nati_uen_ has joined #openstack-dev | 20:16 | |
*** epim has joined #openstack-dev | 20:16 | |
*** mgagne has joined #openstack-dev | 20:16 | |
jamielennox | ok, that can work | 20:17 |
*** READ10 has joined #openstack-dev | 20:17 | |
*** prad has quit IRC | 20:17 | |
*** prad_ is now known as prad | 20:17 | |
ayoung | what if I upload the certs? | 20:17 |
*** dvarga is now known as dvarga|away | 20:17 | |
*** dvarga|away is now known as dvarga | 20:17 | |
*** jcoufal-mobile has quit IRC | 20:18 | |
jamielennox | ayoung: upload? | 20:18 |
*** mriedem has quit IRC | 20:18 | |
ayoung | jamielennox, I have a misconfigured Keystone, I forgot the certs...so I quickly run pki-setup | 20:19 |
ayoung | or certmonger or whatever | 20:19 |
*** nati_ueno has quit IRC | 20:19 | |
ayoung | 404 when they are missing, and 200 when they are there....lets not overcomplicate this | 20:19 |
ayoung | bknudson, I split up the review. I made them all Drafts and added Keystone core on to them for now, to keep them from hammering the gate | 20:20 |
dolphm | bknudson: so, 400 vs 403 regarding immutable attributes... | 20:20 |
bknudson | ayoung: wonderful! | 20:20 |
ayoung | I'll make them public once I've had a change to test them individually \ | 20:20 |
ayoung | here's what I did: | 20:20 |
dolphm | bknudson: the way i read the spec, we're both right and wrong -- correct me if i'm more wrong :P | 20:21 |
ayoung | git checkout -b revocation-split | 20:21 |
ayoung | git reset --soft HEAD~1 | 20:21 |
dolphm | bknudson: 400 "The request could not be understood by the server due to malformed syntax. The client SHOULD NOT repeat the request without modifications." <-- the should not repeat without mods is really important, and why i chose a 400 | 20:21 |
bknudson | dolphm: I agree it really doesn't matter | 20:21 |
ayoung | git checkout HEAD keystone etc | 20:21 |
bknudson | dolphm: since clients aren't going to have any different response to a 400 vs a 403 | 20:21 |
bknudson | clients will need more information that the problem | 20:21 |
ayoung | that got me all of the changes unstaged. For the files I wanted to then state it was simple. For the others, where I only needed some changes, it was keystone add -i --patch | 20:22 |
dolphm | bknudson: 403 "The server understood the request, but is refusing to fulfill it." true but "Authorization will not help and the request SHOULD NOT be repeated." it's not a question of authorization, which is what 403 really communicates | 20:22 |
bknudson | dolphm: but if 400 is because of "malformed syntax" -- the syntax was fine. | 20:22 |
ayoung | even then, I needed to resort to the 'e' for edit option and had to hand modify one of the patches because the changes were combined into a single chunk. | 20:22 |
dolphm | bknudson: if you squint, then "syntax" just means the contents of the request, no? | 20:22 |
ayoung | 404...resource is missing | 20:23 |
bknudson | dolphm: so "malformed contents of the request" ? the contents aren't malformed. | 20:23 |
bknudson | I guess I could keep squiting | 20:23 |
dolphm | bknudson: but they are1 | 20:23 |
ayoung | request is fine | 20:23 |
dolphm | bknudson: yes, squint harder :) | 20:23 |
dolphm | http is a very squinty spec | 20:24 |
ayoung | look, if we decided to use a different extension, and get the certs from somewhere else, then the missing certs here are OK | 20:24 |
gyee | haha | 20:24 |
ayoung | 404 | 20:24 |
bknudson | dolphm: ok, as I said the status code is used for all sorts of errors and the client isn't going to know one way or the other what to do anyways | 20:24 |
*** omachace has left #openstack-dev | 20:24 | |
gyee | dolphm, like the squinty spec part | 20:24 |
bknudson | so we could return 400 for everything and be good | 20:24 |
ayoung | or if they decide they want to distribute the certs with Puppet instead | 20:24 |
*** s2r2_ has joined #openstack-dev | 20:24 | |
dolphm | bknudson: (we can also refine error codes later, fwiw) | 20:24 |
*** NikitaKonovalov_ is now known as NikitaKonovalov | 20:24 | |
dolphm | bknudson: as an end user though, if you give me a 400 i'm going to look at rewriting my request body | 20:25 |
ayoung | bknudson, does https://review.openstack.org/#/c/68232/1 really need a test? | 20:25 |
dolphm | bknudson: and if you give me a 403, i'm going to check my authentication | 20:25 |
dolphm | bknudson: or keystone's policy | 20:25 |
dolphm | bknudson: neither of which would help me here | 20:25 |
bknudson | dolphm: why would you check authentication for 403? 403 says authentication will not help. | 20:25 |
dolphm | bknudson: because the spec is poorly written and you have to squint | 20:26 |
dolphm | bknudson: the spirit of 403 is "you're not authorized to do that right now" | 20:26 |
*** lucasagomes has quit IRC | 20:26 | |
bknudson | ayoung: is there code that's not touched by the tests? if so, how do we know it's even valid python? | 20:26 |
ayoung | nah...I broken the versions page test was updated, and I put it in the wrong commit | 20:27 |
jamielennox | off topic: pip is terrible and broken | 20:27 |
bknudson | dolphm: the spirit of 400 is that the JSON couldn't be parsed | 20:28 |
dolphm | bknudson: how much do you prefer 403 over 400? i'm leaning like 80% 400 but willing to switch | 20:28 |
bknudson | dolphm: I'm fine with 400. | 20:28 |
ayoung | 404 | 20:28 |
ayoung | 403 is better than 400 | 20:28 |
gyee | jamielennox, agreed very much! | 20:28 |
dolphm | bknudson: alright, putting a patchset up with everything else fixed | 20:28 |
ayoung | 400 is just wrong | 20:28 |
Alexei_987 | Could someone check this patch for global-requirements? https://review.openstack.org/#/c/65863/ | 20:29 |
dstanek | lbragstad: i think you were right on your original spelling here - https://review.openstack.org/#/c/66719/ | 20:30 |
lbragstad | dstanek: sounds good, I'll respin | 20:30 |
dstanek | lbragstad: you may want to slightly rephrase though... | 20:32 |
dstanek | trying to come up with something... | 20:32 |
*** gyee has quit IRC | 20:32 | |
*** nati_uen_ has quit IRC | 20:33 | |
lbragstad | dstanek: any particular past that sounds off to you? | 20:33 |
lbragstad | s/past/part/ | 20:33 |
*** mriedem has joined #openstack-dev | 20:35 | |
*** jdob has quit IRC | 20:35 | |
dstanek | lbragstad: maybe it would be sufficient just to say (immutable resource - no ``updated`` notification) | 20:35 |
dolphm | bknudson: ayoung: so we can discuss / review / land separately https://review.openstack.org/#/c/68259/ | 20:36 |
*** jdob has joined #openstack-dev | 20:36 | |
dstanek | lbragstad: i'd be OK with whatever you decide | 20:36 |
lbragstad | dstanek: ok, I'll push something up and ping ya | 20:36 |
dstanek | lbragstad: thx | 20:36 |
dolphm | bknudson: ayoung: i'm more worried about landing the rest of the patch :) | 20:36 |
*** sahid has joined #openstack-dev | 20:36 | |
*** david_paterson has quit IRC | 20:37 | |
*** david_paterson has joined #openstack-dev | 20:37 | |
*** mrunge has joined #openstack-dev | 20:38 | |
*** sarob has joined #openstack-dev | 20:39 | |
dstanek | dolphm: i like having the 403 over 400 in that case | 20:40 |
dolphm | dstanek: add you three to the review then | 20:41 |
dolphm | dstanek: i really don't want to kill the check job on identity-providers again :( | 20:41 |
*** achampio1 has quit IRC | 20:41 | |
*** achampion has joined #openstack-dev | 20:42 | |
*** spzala has joined #openstack-dev | 20:42 | |
*** gokrokve has joined #openstack-dev | 20:43 | |
*** e0ne has joined #openstack-dev | 20:43 | |
*** e0ne has quit IRC | 20:44 | |
dstanek | so...what are the rules regarding copyright? at the hackathon i remember someone mentioning that we shouldn't be assigning copyright to the OpenStack Foundation | 20:44 |
dstanek | should i start having people remove those lines in new files? | 20:44 |
jamielennox | sorry tuned out with some pip issue and implementation, was there a concensus on errors? | 20:45 |
jamielennox | dolphm, ayoung, morganfainberg: ^ | 20:45 |
dolphm | jamielennox: which error conversation? ;) | 20:45 |
jamielennox | i really don't care i just want it to be standardized | 20:45 |
jamielennox | dolphm: for OS-SIMPLE-CERT | 20:45 |
*** yeylon_ has quit IRC | 20:46 | |
lbragstad | dstanek: https://review.openstack.org/#/c/66719/9/doc/source/event_notifications.rst | 20:46 |
*** marun has quit IRC | 20:46 | |
jamielennox | what do we return if we use UUID tokens and what do we return if we use PKI tokens but the certs aren't availabel | 20:46 |
*** alex_klimov has quit IRC | 20:47 | |
*** jdob has quit IRC | 20:47 | |
*** jdob has joined #openstack-dev | 20:47 | |
dolphm | jamielennox: why would you include this extension in your pipeline if you're deploying with UUID? | 20:47 |
*** achampio1 has joined #openstack-dev | 20:47 | |
*** gokrokve has quit IRC | 20:47 | |
*** lbragstad has left #openstack-dev | 20:48 | |
jamielennox | dolphm: it's included by default | 20:48 |
jamielennox | i don't know why you would ever hit it | 20:48 |
*** achampion has quit IRC | 20:48 | |
dolphm | jamielennox: you lost me -- why is a new extension going to be included by default, for starters? | 20:49 |
*** drankis_ has quit IRC | 20:49 | |
*** csd has quit IRC | 20:49 | |
*** cagrev has quit IRC | 20:49 | |
*** mrda_ has joined #openstack-dev | 20:49 | |
jamielennox | well, it's there because we need it for the standard auth_token case and at least for devstack | 20:50 |
jamielennox | are we not allowed to have extensions on by default nay more? | 20:50 |
lifeless | many extensions are on by default in nova | 20:50 |
lifeless | they can be disabled | 20:50 |
lifeless | defaults should be what we recommend | 20:51 |
lifeless | IMNSHO | 20:51 |
jamielennox | lifeless: keystone has a number on by default as well | 20:51 |
jamielennox | dolphm: the ability to download certs is there in V2 API and relied upon by auth_token middleware | 20:51 |
*** nermina has quit IRC | 20:52 | |
jamielennox | it becomes difficult to convert auth_token to v3 if we can't do that same download | 20:52 |
jamielennox | in production you should use puppet or whatever - but i don't know if we tell many people that | 20:52 |
*** burt1 has quit IRC | 20:52 | |
jamielennox | enabled by default would make sense to me | 20:52 |
dolphm | jamielennox: ayoung was on a mission to do disabled by default -- i'm fine with on by default if it's used by core openstack by default | 20:52 |
jamielennox | dolphm: i think we need this one | 20:53 |
*** lbragstad has joined #openstack-dev | 20:54 | |
*** markmcclain has joined #openstack-dev | 20:54 | |
stevemar | bknudson, ayoung, dstanek, marekd|away, please review: https://review.openstack.org/#/c/60244/22 one more time | 20:55 |
*** cagrev has joined #openstack-dev | 20:56 | |
*** jasondotstar has quit IRC | 20:56 | |
ayoung | LGTM | 20:58 |
*** galstrom is now known as galstrom_zzz | 20:58 | |
*** obondarev_ has quit IRC | 20:59 | |
dolphm | (but don't approve yet) | 21:00 |
*** emagana has quit IRC | 21:00 | |
*** cagrev has quit IRC | 21:00 | |
*** emagana has joined #openstack-dev | 21:00 | |
*** mrodden has joined #openstack-dev | 21:01 | |
*** mrodden1 has quit IRC | 21:01 | |
*** tongli has quit IRC | 21:01 | |
*** madmike has joined #openstack-dev | 21:02 | |
*** nermina has joined #openstack-dev | 21:02 | |
*** gokrokve has joined #openstack-dev | 21:03 | |
russellb | devananda: what do you mean by asymmetric | 21:04 |
*** irenab_ has joined #openstack-dev | 21:04 | |
*** gordc has quit IRC | 21:04 | |
devananda | russellb: what mordred means by it -- taht the project check/gate pipes include the test, but that other projects it depends on *do not* | 21:04 |
devananda | russellb: that includes devstack/devstack-gate/tempest | 21:04 |
*** angdraug has joined #openstack-dev | 21:05 | |
*** mfink has quit IRC | 21:05 | |
*** prad has quit IRC | 21:05 | |
devananda | russellb: see for example https://review.openstack.org/#/c/65845/ | 21:05 |
russellb | OK, tried to incorporate that in words | 21:05 |
*** shaunm has joined #openstack-dev | 21:06 | |
devananda | russellb: which is moving ironic's tempest tests out of the experimental pipe, and into ironic's check/gate pipes with voting, but into devstack & tempest check/gate pipes as NON-voting | 21:06 |
*** e0ne has joined #openstack-dev | 21:06 | |
*** zul has quit IRC | 21:06 | |
devananda | it's in their pipes so we can see when changes in tempest break ironic's tests, but it won't affect reviews of tempest | 21:06 |
*** markwash has joined #openstack-dev | 21:07 | |
devananda | russellb: clarkb sat down with me in LCA to explain this. it's taken several discussions fo rme to feel like i understand it .... | 21:07 |
*** irenab has quit IRC | 21:07 | |
*** irenab_ is now known as irenab | 21:08 | |
*** csd has joined #openstack-dev | 21:09 | |
*** achampio1 has quit IRC | 21:10 | |
jamielennox | dolphm, morganfainberg, ayoung: https://review.openstack.org/#/c/68225/3 | 21:10 |
*** achampion has joined #openstack-dev | 21:10 | |
morganfainberg | jamielennox. hm. ok | 21:10 |
*** browne has quit IRC | 21:10 | |
morganfainberg | jamielennox, i think i missed some of the convo, but that seems sane | 21:10 |
*** markwash_ has joined #openstack-dev | 21:10 | |
dolphm | jamielennox: was there a conversation to prefer 403 over 204? | 21:11 |
*** doug_shelley66 has quit IRC | 21:11 | |
jamielennox | gyee didn't like 204 | 21:11 |
morganfainberg | dolphm, yeah, that it tells clients to go away and stop asking | 21:11 |
dolphm | fair enough | 21:12 |
jamielennox | i didn't get much of a sense of any resolution from the convo | 21:12 |
morganfainberg | dolphm, 204 implies something might be here later | 21:12 |
*** markwash has quit IRC | 21:12 | |
*** markwash_ is now known as markwash | 21:12 | |
dolphm | morganfainberg: makes sense | 21:12 |
*** doug_shelley66 has joined #openstack-dev | 21:12 | |
jamielennox | i don't want to use 404, i need that to know whether the extension is available or not | 21:12 |
jamielennox | i think 500 is appropriate for server side failure | 21:13 |
jamielennox | but at no point has this mattered all that much - we just need to standardize it | 21:13 |
marekd|away | dolphm: bknudson is warming up with his comments for https://review.openstack.org/#/c/60244/ - i can handle this now. | 21:13 |
*** marekd|away is now known as marekd | 21:14 | |
dolphm | marekd|away: if they're just nits, i'd like to fix them in a separate patch rather than restart progress towards gating | 21:14 |
bknudson | marekd: yes, take a look and if they can be made in separate patches then I'm fine with that. | 21:14 |
dolphm | bknudson: anything blocking in there? | 21:14 |
dolphm | bknudson: slash, anything api impacting? | 21:14 |
bknudson | dolphm: I looked through them and I think they can be done in a separate patch. | 21:16 |
*** s2r2_ has quit IRC | 21:16 | |
*** mrda is now known as mrda__ | 21:16 | |
*** MarkAtwood has quit IRC | 21:16 | |
*** mrda_ is now known as mrda | 21:16 | |
*** dave_tucker is now known as dave_tucker_zzz | 21:17 | |
marekd | dolphm: bknudson: so you want to merge this in the current state, and later add another patch that will clean everything bknudson didn't like? | 21:19 |
bknudson | marekd: you can add the patches or someone else can. | 21:19 |
*** dave_tucker_zzz is now known as dave_tucker | 21:19 | |
*** madmike has quit IRC | 21:19 | |
*** dvarga has quit IRC | 21:20 | |
*** dvarga has joined #openstack-dev | 21:20 | |
*** prad has joined #openstack-dev | 21:20 | |
*** mikeoutland has quit IRC | 21:20 | |
dolphm | markmc: ++ | 21:20 |
marekd | bknudson: yes, but are you fine with merging the code with current patchset or fixes are crucial? | 21:21 |
dolphm | marekd: ++ (my bad markmc) | 21:21 |
*** MaxV has joined #openstack-dev | 21:21 | |
bknudson | marekd: the comments aren't critical IMO | 21:21 |
dolphm | ayoung: publish all your draft reviews | 21:22 |
*** nati_ueno has joined #openstack-dev | 21:23 | |
*** dprince has quit IRC | 21:23 | |
*** markmcclain has quit IRC | 21:23 | |
bknudson | marekd: apparently https://review.openstack.org/#/c/60244/ is failing. | 21:23 |
*** spzala has quit IRC | 21:23 | |
bknudson | marekd: failing py26,py27 | 21:24 |
*** markmcclain has joined #openstack-dev | 21:24 | |
bknudson | marekd: oops, I'm looking at the wrong job. | 21:24 |
sdague | david-lyle: hey, taking the stable/havana thing over here | 21:25 |
bknudson | for some reason 18 is still around. | 21:25 |
sdague | can you see if yuo have any more stable changes in the gate? | 21:25 |
sdague | I thought we caught them all, but we could have missed some | 21:25 |
*** beagles has quit IRC | 21:25 | |
ayoung | dolphm, will do once I run the unit tests for them. Don't want to be posting broken reviews | 21:25 |
david-lyle | sdague, will look | 21:25 |
sdague | david-lyle: thank yuo | 21:25 |
*** gordc has joined #openstack-dev | 21:25 | |
*** b3nt_pin has joined #openstack-dev | 21:25 | |
*** b3nt_pin is now known as beagles | 21:25 | |
*** alop has quit IRC | 21:25 | |
*** alop has joined #openstack-dev | 21:26 | |
jamielennox | dstanek: i really like having ./run_tests.sh back | 21:26 |
*** dvarga is now known as dvarga|away | 21:26 | |
*** dvarga|away is now known as dvarga | 21:26 | |
dolphm | ayoung: mark as WIP instead of Draft | 21:27 |
*** e0ne has quit IRC | 21:27 | |
*** jhesketh has joined #openstack-dev | 21:29 | |
ayoung | WTH is the publish draft button now? | 21:29 |
jamielennox | simple-cert implementation patch: https://review.openstack.org/#/c/67785/ i'm not sure how long a gerrit check is expected to take at the moment | 21:30 |
*** irenab has quit IRC | 21:30 | |
*** markmc has quit IRC | 21:30 | |
*** amcrn has quit IRC | 21:31 | |
*** e0ne has joined #openstack-dev | 21:31 | |
*** SumitNaiksatam has quit IRC | 21:31 | |
morganfainberg | jamielennox, top of check queue has been in there for ~2h43min | 21:32 |
*** NikitaKonovalov is now known as NikitaKonovalov_ | 21:32 | |
stevemar | ayoung, i think it makes patches go from draft to normal? | 21:33 |
morganfainberg | stevemar, correct | 21:33 |
*** amcrn has joined #openstack-dev | 21:33 | |
*** melwitt has quit IRC | 21:34 | |
*** melwitt has joined #openstack-dev | 21:34 | |
stevemar | dstanek, you have an itchy approval trigger finger today | 21:34 |
*** melwitt has quit IRC | 21:35 | |
*** melwitt has joined #openstack-dev | 21:35 | |
*** melwitt has quit IRC | 21:35 | |
dstanek | stevemar: yes, i just told dolphm the same things | 21:35 |
dstanek | i think i'm going to make a greasemonkey script for this :-) | 21:36 |
*** MaxV has quit IRC | 21:36 | |
*** MaxV has joined #openstack-dev | 21:36 | |
stevemar | approve, no really approve | 21:36 |
*** jhesketh has quit IRC | 21:37 | |
*** gyee has joined #openstack-dev | 21:37 | |
*** jprovazn has quit IRC | 21:37 | |
*** kenperkins has quit IRC | 21:37 | |
dstanek | looks like a bunch of stuff got merged today | 21:38 |
*** melwitt1 has joined #openstack-dev | 21:38 | |
*** jhesketh has joined #openstack-dev | 21:38 | |
*** mikeoutland has joined #openstack-dev | 21:38 | |
morganfainberg | yay | 21:39 |
henrynash | dolphm: see if https://review.openstack.org/#/c/67256/ looks Ok to you now…I have answered Haneef's question, but waiting for him to remove -1 | 21:39 |
*** jhesketh_ has joined #openstack-dev | 21:39 | |
*** jhesketh_ has quit IRC | 21:40 | |
*** tjones has joined #openstack-dev | 21:40 | |
*** dave_tucker is now known as dave_tucker_zzz | 21:41 | |
*** CaptTofu has quit IRC | 21:41 | |
*** beagles has quit IRC | 21:41 | |
*** jhesketh_ has joined #openstack-dev | 21:43 | |
*** b3nt_pin has joined #openstack-dev | 21:43 | |
*** e0ne has quit IRC | 21:43 | |
*** b3nt_pin is now known as beagles | 21:43 | |
*** asalkeld has joined #openstack-dev | 21:44 | |
*** browne has joined #openstack-dev | 21:44 | |
*** alop has quit IRC | 21:45 | |
*** romcheg1 has joined #openstack-dev | 21:45 | |
*** dstufft_ has joined #openstack-dev | 21:45 | |
*** romcheg has quit IRC | 21:46 | |
*** dave_tucker_zzz is now known as dave_tucker | 21:47 | |
*** dstufft has quit IRC | 21:47 | |
*** dstufft_ is now known as dstufft | 21:48 | |
*** beagles has quit IRC | 21:48 | |
ayoung | stevemar, for some reason the publish button was missing | 21:49 |
*** shaunm has quit IRC | 21:50 | |
*** reed has joined #openstack-dev | 21:52 | |
*** jasondotstar has joined #openstack-dev | 21:52 | |
*** sarob_ has joined #openstack-dev | 21:53 | |
*** sarob_ has quit IRC | 21:54 | |
*** haneef_ has joined #openstack-dev | 21:55 | |
*** sarob_ has joined #openstack-dev | 21:55 | |
*** doug_shelley66 has quit IRC | 21:56 | |
*** sarob has quit IRC | 21:56 | |
*** doug_shelley66 has joined #openstack-dev | 21:56 | |
*** jsavak has joined #openstack-dev | 21:56 | |
haneef_ | henrynash: ping | 21:56 |
*** jcoufal has joined #openstack-dev | 21:56 | |
*** sarob_ has quit IRC | 21:57 | |
morganfainberg | bknudson, do you want me to help go through and do the rebases for the chain that includes dont configure on import? | 21:57 |
*** rcleere has quit IRC | 21:58 | |
morganfainberg | bknudson, the don't configure on import fix solves a bug w/ caching layer | 21:58 |
*** jdob has quit IRC | 21:58 | |
ayoung | dolphm, running the last of the tests now, but the main revoke extension patch is now https://review.openstack.org/#/c/68235/ | 21:59 |
henrynash | haneef_: hi | 21:59 |
morganfainberg | bknudson, oh. nvm | 21:59 |
bknudson | morganfainberg: rebase on what? | 21:59 |
morganfainberg | bknudson, not rebase | 21:59 |
morganfainberg | bknudson, just gate fail... ugh | 21:59 |
morganfainberg | i need more coffee :( | 21:59 |
*** joesavak has quit IRC | 21:59 | |
morganfainberg | dolphm, already reverfiied | 21:59 |
morganfainberg | it's just chilling in the gate queue | 21:59 |
*** rcleere has joined #openstack-dev | 21:59 | |
bknudson | morganfainberg: this is why you never split up commits | 21:59 |
haneef_ | henrynash: If we are limiting, then there is no way for the client to get the remaining result. Is that acceptable? | 21:59 |
bknudson | should just squash them. | 22:00 |
morganfainberg | bknudson, lol | 22:00 |
henrynash | haneef_: they are meant to use filtering to ask for smaller data set | 22:00 |
david-lyle | sdague: I don't see any others | 22:00 |
bknudson | one big commit -- keystone icehouse m2 | 22:00 |
*** rcleere has quit IRC | 22:00 | |
*** dvarga has quit IRC | 22:00 | |
morganfainberg | bknudson, nah, keystone Icehouse | 22:00 |
morganfainberg | nothing else needed, amirite? | 22:00 |
*** sarob has joined #openstack-dev | 22:00 | |
*** sarob has quit IRC | 22:00 | |
morganfainberg | who needs milestones | 22:00 |
ayoung | we should havea weekly milestone | 22:01 |
ayoung | call it the PTL branch | 22:01 |
morganfainberg | ayoung, i think hourly | 22:01 |
*** sarob has joined #openstack-dev | 22:01 | |
ayoung | PTL promotes weekly to be interim | 22:01 |
bknudson | we might get one patch into each milestone | 22:01 |
morganfainberg | bknudson, hehe | 22:01 |
ayoung | I'm serious | 22:01 |
haneef_ | henrynash: We are assuming that there exits a restricted filter which will satisfy the criteria. If not what will happen | 22:01 |
*** vladikr has quit IRC | 22:02 | |
ayoung | we don't test against all of the other dev branches, only their last stable milestone | 22:02 |
*** sarob_ has joined #openstack-dev | 22:02 | |
ayoung | if a team breaks something, all code stops until they fix it | 22:02 |
*** sarob_ has quit IRC | 22:02 | |
ayoung | longer discussion than we should have now, though | 22:02 |
morganfainberg | ayoung, not sure if that would make things better or worse. | 22:02 |
henrynash | haneef_: so it's up to an implementor…if they are concerned about poorly scoped queries from loading down the system then they can limit…it's optional, and there is none by default | 22:02 |
morganfainberg | ayoung, or have any real impact. | 22:02 |
morganfainberg | ayoung, yes, discussion later | 22:03 |
haneef_ | ok. I will add that in the review and remove -1 | 22:03 |
sdague | david-lyle: thanks | 22:03 |
henrynash | haneef_: there are many systems that, if you ask for too much data, it just says "too big, try again" | 22:03 |
*** ngb_ has joined #openstack-dev | 22:04 | |
morganfainberg | henrynash, or "don't try again" in some cases. | 22:04 |
henrynash | morganfainberg: excellent next step.... | 22:04 |
ayoung | dolphm, OK, revocation is all up there again in multiple patches | 22:04 |
*** simo has left #openstack-dev | 22:04 | |
ayoung | All open for public review | 22:04 |
henrynash | haneef_: thanks | 22:05 |
*** CaptTofu has joined #openstack-dev | 22:05 | |
*** Tuna__ has joined #openstack-dev | 22:05 | |
gyee | henrynash, in that case, your proposal still won't work right? | 22:06 |
*** sarob has quit IRC | 22:06 | |
gyee | LDAP still going to throw you an error if you are asking too many entries | 22:06 |
*** Tuna_ has quit IRC | 22:07 | |
ayoung | can someone do the honors on https://review.openstack.org/#/c/67785/ | 22:07 |
gyee | ayoung, looking | 22:08 |
ayoung | we can hold off on approval until its passed check | 22:08 |
morganfainberg | yes, please hold approval till post check | 22:08 |
morganfainberg | and i'm looking as well | 22:08 |
ayoung | but if we have 2 +2s now we can include it in I2 | 22:08 |
*** sarob has joined #openstack-dev | 22:09 | |
_cjones_ | ayoung: Why does keystone appear to use v2.0/tokens, when I specifically requested the v3 API? | 22:09 |
ayoung | _cjones_, you lie | 22:10 |
*** nati_ueno has quit IRC | 22:10 | |
*** mfer has quit IRC | 22:10 | |
ayoung | :_{) | 22:10 |
*** doug_shelley66 has quit IRC | 22:10 | |
_cjones_ | ayoung: I assure you kind sir, I don't on purpose. | 22:10 |
ayoung | _cjones_, using the client or via curl? | 22:11 |
*** nati_ueno has joined #openstack-dev | 22:11 | |
_cjones_ | Via horizon. | 22:11 |
_cjones_ | (access): 2014-01-21 14:08:58,533 INFO core __call__ 172.16.0.254 - - [21/Jan/2014:22:08:58 +0000] "GET http://172.16.0.201:5000/v3/users HTTP/1.0" 401 193 | 22:11 |
_cjones_ | (eventlet.wsgi.server): 2014-01-21 14:08:58,534 INFO log write 172.16.0.254 - - [21/Jan/2014 14:08:58] "GET /v3/users HTTP/1.1" 401 415 0.004771 | 22:11 |
*** ngb_ has quit IRC | 22:12 | |
ayoung | _cjones_, that is the users url | 22:12 |
ayoung | doesn't show where it requested the token | 22:12 |
*** READ10 has quit IRC | 22:12 | |
_cjones_ | ayoung, sec. | 22:12 |
_cjones_ | access): 2014-01-21 14:08:59,092 INFO core __call__ 172.16.0.201 - - [21/Jan/2014:22:08:59 +0000] "GET http://172.16.0.201:35357/v2.0/tokens/c85fd4e00b85ac8037b7e62023d1b41f HTTP/1.0" 200 3076 | 22:13 |
_cjones_ | (eventlet.wsgi.server): 2014-01-21 14:08:59,093 INFO log write 172.16.0.201 - - [21/Jan/2014 14:08:59] "GET /v2.0/tokens/c85fd4e00b85ac8037b7e62023d1b41f HTTP/1.1" 200 3206 0.103196 | 22:13 |
_cjones_ | ayoung, I'm confused as to why there seems to be a mis-match v3 for users, but v2.0 for tokens. | 22:13 |
ayoung | dolphm, why is zuul not picking up https://review.openstack.org/#/c/68232/ | 22:13 |
ayoung | _cjones_, ask the horizonators | 22:13 |
morganfainberg | ayoung, https://review.openstack.org/#/c/68235/3/keystone/contrib/revoke/core.py whitespace issues will fail pep8 | 22:14 |
*** harlowja is now known as harlowja_away | 22:14 | |
ayoung | morganfainberg, thanks | 22:14 |
morganfainberg | ayoung still doing review so i'll tag it w/ a comment | 22:14 |
_cjones_ | ayoung, k. thanks. | 22:15 |
*** termie has quit IRC | 22:16 | |
*** danielbruno has quit IRC | 22:16 | |
*** benrodrigue has quit IRC | 22:17 | |
*** david_paterson has quit IRC | 22:17 | |
*** termie has joined #openstack-dev | 22:17 | |
jpich | _cjones_: This may be related to what you're seeing: until recently Horizon would sometimes fall back to 2.0 and sometimes to 3 if the keystone version wasn't explicitly defined in the local settings (see https://bugs.launchpad.net/horizon/+bug/1231357 ) | 22:18 |
morganfainberg | ayoung, are there tests missing from your revocation patch? | 22:19 |
morganfainberg | ayoung, or slated for another patch | 22:19 |
ayoung | morganfainberg, test_revoke.py | 22:19 |
*** vipul is now known as vipul-away | 22:19 | |
morganfainberg | right, very sparse | 22:19 |
ayoung | morganfainberg, more in the follow on | 22:19 |
morganfainberg | ok | 22:19 |
ayoung | base extension doesn't do much | 22:20 |
*** asalkeld has quit IRC | 22:20 | |
_cjones_ | jpich: Thanks, I'm looking at something similar in this domain. | 22:20 |
ayoung | The logic for testing if a token is revoked it tested more in the integration patch | 22:20 |
_cjones_ | jpich: If this has been captured in a separate issue, I think I can proceed with my proposed change. | 22:20 |
morganfainberg | ayoung, sure. | 22:20 |
morganfainberg | ayoung, just was curious | 22:21 |
ayoung | And since the values are "normalized" between a v2 and a v3 token, the testing here would be trivial | 22:21 |
morganfainberg | nod | 22:21 |
ayoung | why is zuul not picking up my new patches for check? | 22:22 |
ayoung | Or Jenkins or whomever | 22:22 |
morganfainberg | ayoung, event backlog | 22:22 |
*** zzelle has joined #openstack-dev | 22:22 | |
morganfainberg | ayoung, Queue lengths: 1399 events, 61 results. | 22:22 |
ayoung | But they are not even showing in the queue | 22:22 |
*** jamielennox is now known as jamielennox|away | 22:22 | |
morganfainberg | those are unprocessed events/results | 22:22 |
ayoung | where do you see that? | 22:22 |
morganfainberg | ayoung, top left above "check" on status.openstack.org/zuul/ | 22:23 |
*** redhat has quit IRC | 22:23 | |
*** burt1 has joined #openstack-dev | 22:23 | |
morganfainberg | next to "filter projects" box | 22:23 |
*** yassine has quit IRC | 22:23 | |
jpich | _cjones_: Cool! The workaround if the patch isn't available in your system would be to set the version explicitly | 22:23 |
_cjones_ | jpich: Odd. I have that fix. | 22:23 |
jpich | :/ | 22:23 |
_cjones_ | jpich: I also set it explicitly. :) | 22:23 |
*** vijendar has quit IRC | 22:24 | |
ayoung | OK...so what needs attention? I have 5 minutes until my next meeting | 22:24 |
*** nati_ueno has quit IRC | 22:24 | |
jpich | _cjones_: Oh! Maybe you have another bug for Horizon then, please feel free to open a new report | 22:24 |
morganfainberg | ayoung, not sure. i'm about needing to go jump to internal stuff (been about 50% split today) as well. | 22:24 |
_cjones_ | jpich: Will do when I'm done this bit. | 22:24 |
jpich | _cjones_: Thank you! | 22:24 |
*** vipul-away is now known as vipul | 22:25 | |
*** vipul is now known as vipul-away | 22:25 | |
ayoung | time to drive home | 22:26 |
*** ayoung has quit IRC | 22:26 | |
*** marekd is now known as marekd|away | 22:27 | |
*** prad has quit IRC | 22:27 | |
*** bdpayne has quit IRC | 22:28 | |
*** prad has joined #openstack-dev | 22:28 | |
*** ayoung has joined #openstack-dev | 22:28 | |
*** gordc has quit IRC | 22:30 | |
*** dbalog has left #openstack-dev | 22:30 | |
*** thomasem has quit IRC | 22:31 | |
*** dims has quit IRC | 22:31 | |
*** jamielennox|away is now known as jamielennox | 22:33 | |
*** lcheng has joined #openstack-dev | 22:33 | |
*** asalkeld has joined #openstack-dev | 22:33 | |
*** ayoung has quit IRC | 22:34 | |
*** achampio1 has joined #openstack-dev | 22:34 | |
jamielennox | gyee, ayoung, morganfainberg: Fix that comment in a separate review: https://review.openstack.org/#/c/68273 so I don't yank it from the jenkins queue | 22:35 |
*** harlowja_away is now known as harlowja | 22:35 | |
gyee | jamielennox, looking | 22:35 |
*** stevemar has quit IRC | 22:35 | |
jamielennox | i might have sent that message already but i had vpn issues and i think it got lost | 22:35 |
*** achampion has quit IRC | 22:36 | |
gyee | jamielennox, change looks good, hope Jenkins agree with you today :) | 22:36 |
jamielennox | gyee: are there jenkins gods or is jenkins the god? | 22:37 |
gyee | jamielennox, heh, maybe the ppl who have root access to the Jeninks nodes? | 22:38 |
*** radez is now known as radez_g0n3 | 22:38 | |
*** devoid has quit IRC | 22:38 | |
*** doug_shelley66 has joined #openstack-dev | 22:40 | |
*** yassine has joined #openstack-dev | 22:41 | |
*** jnoller has quit IRC | 22:42 | |
*** browne has quit IRC | 22:42 | |
*** jruzicka has quit IRC | 22:42 | |
*** krtaylor has quit IRC | 22:42 | |
*** sarob has quit IRC | 22:45 | |
*** sarob has joined #openstack-dev | 22:45 | |
*** ekhugen has quit IRC | 22:45 | |
*** kenperkins has joined #openstack-dev | 22:45 | |
*** radsy has joined #openstack-dev | 22:45 | |
*** dims has joined #openstack-dev | 22:46 | |
*** achampio1 has quit IRC | 22:46 | |
*** morazi has quit IRC | 22:46 | |
dtroyer | jamielennox: got a sec? I am _finally_ trying to wrap my head around the session/auth bits in https://review.openstack.org/#/c/60751/ and friends…and trying to make OSC use it directly... | 22:46 |
*** spzala has joined #openstack-dev | 22:47 | |
*** jayg is now known as jayg|g0n3 | 22:47 | |
henrynash | gyee: I posted a comment to the list limiting api change….I think there really is a difference between limiting and pagination…and we should keep these separate | 22:47 |
*** achampion has joined #openstack-dev | 22:47 | |
*** lbragstad has quit IRC | 22:47 | |
gyee | henrynash, I am about to response, I am not sure if I understand the reasoning | 22:48 |
gyee | If client is asking server for too much data, shouldn't the server be returning a 400 and telling the client to try again with a more refined query? Again, what is the client going to do with a 'truncated' attribute. From end user experience angle, the net effect is the same, which is to refine the search query and retry. | 22:48 |
*** lbragstad has joined #openstack-dev | 22:48 | |
*** lbragstad has quit IRC | 22:48 | |
jamielennox | dtroyer: actually in a meeting but i would like to talk to you about it - will you still be here in about 40min? | 22:48 |
*** jobewan has quit IRC | 22:49 | |
dtroyer | yes | 22:49 |
*** clayb has quit IRC | 22:49 | |
henrynash | gyee: so I agree there are two options if you get too much data…and the systems out there seem to be split…some will return the amount of data it can with an indicator that this is a subset….other give you nothing (your 400 example) | 22:49 |
*** benrodrigue has joined #openstack-dev | 22:50 | |
*** yamahata has quit IRC | 22:50 | |
henrynash | gyee: the argument for returning some data is that display a page of data in a client as a clue to what to filter on is probably a nicer experience…. | 22:50 |
*** SergeyLukjanov is now known as SergeyLukjanov_a | 22:50 | |
*** yamahata has joined #openstack-dev | 22:50 | |
henrynash | gyee: but you want to tell the user in that case that this is indeed a subet | 22:50 |
*** SergeyLukjanov_a is now known as SergeyLukjanov_ | 22:51 | |
gyee | henrynash, why not use the 'next' link | 22:51 |
*** jmontemayor has quit IRC | 22:51 | |
gyee | client is asking for 100 entries, server return 50 with the next link populated | 22:52 |
henrynash | gyee: so, that was one proposal…the concern raised by others is that we have already said that this is a url to another page of data (i.e. it really is for pagination)…and we'd have to go back on that definition (not backward comaptable, in the eyes of Dolphm and others) | 22:52 |
gyee | that would be an indication of more data to come | 22:52 |
henrynash | gyee: that's pagination | 22:52 |
gyee | it is :) | 22:52 |
gyee | lets fix pagination | 22:52 |
henrynash | gyee: there are many (in Horizon) who believe we should not do pagination at all….good filtering and limiting is all you need | 22:53 |
gyee | instead of doing half-baked changes | 22:53 |
gyee | pagination is still needed | 22:53 |
henrynash | gyee: that's not a view held by all | 22:54 |
gyee | if an implementation doesn't support pagination, return a 400 | 22:54 |
*** achampion has quit IRC | 22:54 | |
gyee | fact is pagination is still useful, despite all the noise | 22:55 |
*** achampion has joined #openstack-dev | 22:55 | |
henrynash | gyee: returning no data (and a 400) is the other consistent approach, although so is the current one! Most people preferred the current one. | 22:55 |
*** prad has quit IRC | 22:56 | |
gyee | henrynash, I'd prefer 400 if the system is incapable of support pagination | 22:56 |
*** Tuna__ has quit IRC | 22:56 | |
*** doug-fish has quit IRC | 22:56 | |
morganfainberg | gyee, eh, lets return a 410 for pagination | 22:58 |
morganfainberg | sorry | 22:58 |
*** sarob has quit IRC | 22:58 | |
morganfainberg | gyee, 402 | 22:58 |
gyee | that's fine | 22:59 |
morganfainberg | gyee, payment required. pay us and we'll implement it :P | 22:59 |
*** mdomsch has quit IRC | 22:59 | |
gyee | morganfainberg, ++ | 22:59 |
gyee | or do it as an extension | 22:59 |
morganfainberg | gyee, eh. | 22:59 |
morganfainberg | gyee, i would really rather not implement pagination. | 23:00 |
morganfainberg | at all | 23:00 |
morganfainberg | personal preference | 23:00 |
*** luis_ has quit IRC | 23:00 | |
*** jpich has quit IRC | 23:00 | |
*** Gordonz has quit IRC | 23:01 | |
gyee | morganfainberg, I made my case here https://blueprints.launchpad.net/keystone/+spec/pagination | 23:01 |
*** morazi has joined #openstack-dev | 23:01 | |
*** peristeri has quit IRC | 23:02 | |
*** pcm_ has quit IRC | 23:02 | |
*** neelashah has quit IRC | 23:02 | |
*** mrunge has quit IRC | 23:02 | |
*** sarob has joined #openstack-dev | 23:03 | |
*** kevinconway has quit IRC | 23:03 | |
*** jaypipes has joined #openstack-dev | 23:03 | |
zzelle | gyee, morganfainberg returning 501 would be feet ? | 23:03 |
zzelle | *would feet | 23:03 |
*** rnirmal has quit IRC | 23:04 | |
gyee | zzelle, why not 400 | 23:04 |
*** CaptTofu has quit IRC | 23:04 | |
*** jcoufal has quit IRC | 23:04 | |
zzelle | it depends of the interface | 23:04 |
henrynash | gyee: so we had a long debate about this at the Hackathan, and agreed that we were definitely not doing pagination yet, but limiting was still good in its own right…people felt we should return data rather than none, and indicate that this was a subset (we thought 203 at the time, or something in the collection) | 23:05 |
henrynash | gyee: we all agree 203 is not right | 23:05 |
zzelle | gyee: if pagination isallowed in the interface ? it's a 501 otherwise i would say 400 | 23:06 |
zzelle | gree | 23:06 |
*** zzelle has left #openstack-dev | 23:06 | |
*** jckasper_ has quit IRC | 23:06 | |
*** zzelle has joined #openstack-dev | 23:06 | |
gyee | zzelle, 501 sounds reasonable | 23:06 |
*** HenryG has quit IRC | 23:07 | |
*** sarob has quit IRC | 23:07 | |
*** harlowja has quit IRC | 23:07 | |
gyee | henrynash, I feel like we are going extra miles to dance around pagination | 23:08 |
gyee | lets fix pagination | 23:08 |
henrynash | gyee: that;s a much long debate. meanwhile we need a way for server deployers to protect the load on their system,s | 23:09 |
zzelle | gyee, me too if pagination is considered as a standard feature provided by openstack | 23:09 |
*** willingc has joined #openstack-dev | 23:09 | |
*** luisg has joined #openstack-dev | 23:10 | |
gyee | henrynash, let do pagination as an extension and let our users vote on it | 23:10 |
henrynash | zzelle, gyee: pagination is not agreed for icehouse, limiting is | 23:10 |
gyee | we don't too much debating already | 23:10 |
gyee | s/don't/done/ | 23:10 |
henrynash | gyee: I agree with pagination as an extension, but that is not a replacement | 23:10 |
gyee | henrynash, that's not how I understood the limiting proposal | 23:11 |
gyee | it something that is internal to Keystone implementation, no API changes | 23:11 |
henrynash | gyee: well that's true apart from tell the user what's happend | 23:12 |
gyee | return 400 if Keystone can satisfy the query, simple | 23:12 |
gyee | can't | 23:12 |
*** sahid has quit IRC | 23:12 | |
*** jsavak has quit IRC | 23:13 | |
*** jecarey has quit IRC | 23:13 | |
henrynash | gyee: That's a big change form what we all agreed last week | 23:13 |
henrynash | gyee: easy to code, but the fact that there's no data returned | 23:13 |
gyee | henrynash, easy to code, but the rest of us have to maintain API-compatibility :) | 23:13 |
*** burt1 has quit IRC | 23:14 | |
henrynash | ghee: why is the proposal API incompatible? | 23:14 |
henrynash | gyee: and returning a 400 is an API change... | 23:15 |
*** dstanek has quit IRC | 23:15 | |
gyee | henrynash, means we have to account for the "truncated" attribute in our public APIs, docs, examples, the whole 9 yard | 23:16 |
*** sushils has quit IRC | 23:17 | |
gyee | if you do this as an extension, we can just publish a one line disclaimer | 23:17 |
*** dstanek has joined #openstack-dev | 23:17 | |
henrynash | gyee: no, I really don't want this as an extensions (limiting that is)…it's already optional and off by default. | 23:18 |
gyee | 400 is common for anything the server doesn't like | 23:18 |
henrynash | dolphm, bknudson, morganfainberg: what so we think about this suggestion…to not return any data in the case of a list response being too big | 23:19 |
*** sushils has joined #openstack-dev | 23:19 | |
*** jtomasek has quit IRC | 23:19 | |
*** HenryG has joined #openstack-dev | 23:19 | |
henrynash | dolphm, bknudson, morganfainberg, ghee: one issue is that it won't be obvious to the client why the server rejected it | 23:19 |
gyee | henrynash, in a lot of cases, you probably won't know until you talk to the backend anyway | 23:19 |
morganfainberg | henrynash, i thought we rejected that concept at the hackathon | 23:19 |
morganfainberg | henrynash, for that very reason | 23:20 |
henrynash | morganfainberg: we did | 23:20 |
dolphm | gyee: changing from a 2xx to a 4xx is backwards incompatible | 23:20 |
morganfainberg | and, ^ what dolphm said | 23:20 |
dolphm | gyee: 2xx to 2xx is fair game, and 4xx to 4xx is fair game, etc | 23:20 |
gyee | dolphm, if client is asking for something the server can't support, we can't just return a 2xx | 23:20 |
dolphm | gyee: is this in regard to truncated collections? | 23:21 |
gyee | yes | 23:21 |
henrynash | gyee: the issue is that it is providing some of what it asked for…but not all | 23:21 |
gyee | henrynash, isn't this classic *pagination*? | 23:21 |
henrynash | gyee: pagination is driven by the needs the clientm, list limiting is driven by the needs of the server | 23:22 |
dolphm | gyee: not really | 23:22 |
dolphm | gyee: it's a step toward pagination, but not providing pagination | 23:22 |
dolphm | i'm fine with a 2xx, new attribute in the response ("truncated"=true) or creative use of headers | 23:23 |
gyee | client asking for 1000, server can choose to return any number between 1 and 1000 with the next link if there are more than 1000 entries | 23:23 |
dolphm | gyee: the client is not asking for a specific number, nor is the client allowed to do so | 23:24 |
morganfainberg | gyee the case is client asks for all, server gives back 1000 because > 1000 would be returned | 23:24 |
dolphm | henrynash: you could return a "next" link that always returns 4xx lol | 23:24 |
gyee | use the "next" | 23:24 |
dolphm | gyee: "next" is defined to be a URL, that's the only constraint there | 23:24 |
gyee | dolphm, yes? | 23:25 |
gyee | that's what next is for | 23:25 |
dolphm | gyee: (the proposal earlier was to return an arbitrary string as the value instead of a URL) | 23:25 |
dolphm | gyee: what do you return a link to? | 23:25 |
henrynash | ghee, dolphm: I'm open to using the next link (that was the previous version)….but what do we set 'next' to? | 23:25 |
gyee | its implementation-specific at this point :) | 23:26 |
gyee | as long as it is a URl | 23:26 |
dolphm | gyee: to what? | 23:26 |
henrynash | gyee: then how does a client know they didn't get all the data? | 23:26 |
gyee | henrynash, the presence of next indicates there are more data to come | 23:26 |
dolphm | gyee: there is no more data to come -- the collection has been truncated | 23:26 |
gyee | dolphm, next=http://myserver:port/v3/users?<my pagination stuff> | 23:27 |
morganfainberg | dolphm, he's advocating to amke this into pagination | 23:27 |
morganfainberg | vs. a hard limit | 23:27 |
*** kgriffs is now known as kgriffs_afk | 23:27 | |
*** krtaylor has joined #openstack-dev | 23:27 | |
*** neelashah has joined #openstack-dev | 23:27 | |
gyee | next and prev are in the spec and they are implementation-specific | 23:27 |
henrynash | gyee: so the we'd tell clients, if there was more data (that we can't tell you about unless you give me a better query) then they 'next' link will exist….but don't follow it? | 23:28 |
dolphm | gyee: ++ but what do we do in core openstack? | 23:28 |
gyee | henrynash, the presence of next indicates more data, it is up to the user to decide what to do next | 23:28 |
gyee | no different than a google search | 23:29 |
dolphm | gyee: /facepalm | 23:29 |
dolphm | gyee: there is NO more data. you're either misunderstanding or ignoring the issue | 23:29 |
dolphm | gyee: the client must issue a NEW construct a new request to get something new | 23:29 |
gyee | no more data? | 23:29 |
dolphm | gyee: the collection has been, let's say, fatally truncated | 23:30 |
dolphm | gyee: as determined by the service/deployer | 23:30 |
*** artom has quit IRC | 23:30 | |
dolphm | gyee: the client is not in error, the response was successful, the service just needs to hint to the client that the results are incomoplete | 23:31 |
morganfainberg | flaper87, mind if we hold off on the cache discussion until I2 is a little more settled? | 23:31 |
morganfainberg | flaper87, i think it's going to be a bit crazy for the next couple days. | 23:31 |
flaper87 | morganfainberg: sounds good. I don't think any patches will be landing anytime soon besides the ones fixing the gate | 23:32 |
flaper87 | so, that's ok | 23:32 |
morganfainberg | flaper87, exactly | 23:32 |
morganfainberg | flaper87, :) | 23:32 |
gyee | dolphm, how is the response successful if you don't satisfy the entire query | 23:32 |
*** kenperkins has quit IRC | 23:33 | |
*** safchain has joined #openstack-dev | 23:34 | |
*** safchain has quit IRC | 23:34 | |
henrynash | gyee: it's as successful as the server/deployer will allow | 23:34 |
dolphm | gyee: the server satisfied the query to the best of it's ability, and returned useful data | 23:34 |
*** eharney has quit IRC | 23:34 | |
dolphm | flaper87: ++++++ | 23:35 |
flaper87 | :) | 23:35 |
*** thuc has quit IRC | 23:35 | |
*** thuc has joined #openstack-dev | 23:36 | |
gyee | dolphm, userful data is debatable | 23:37 |
haneef_ | dolphm: The question is, if the client is not happy with the truncated data what should he do? Assume the query is already restricted. | 23:37 |
dolphm | we should just start rebasing all features on top of gate-fixing patches | 23:37 |
gyee | do we have backend implementations which allows partial success? | 23:38 |
gyee | just curious | 23:38 |
dolphm | gyee: haneef_: issue a new query with filters. that's the whole point. | 23:38 |
dolphm | gyee: that's what henry's patch introduces | 23:38 |
dolphm | gyee: did you not review it? | 23:39 |
*** ayoung has joined #openstack-dev | 23:39 | |
gyee | dolphm, but you won't know till you hit the backend | 23:39 |
*** xmltok has quit IRC | 23:39 | |
gyee | dolphm, I mean backend impl | 23:39 |
henrynash | haneef_: and of course a server/deploy could overly restrict their limits to make querying hard…but that's their pergoative | 23:39 |
dolphm | gyee: again, did you review henry's patch? the backend won't sit around all day fetching a billion projects | 23:40 |
gyee | dolphm, not the code, just the spec so far | 23:40 |
*** amcrn has quit IRC | 23:40 | |
henrynash | gyee: https://review.openstack.org/#/c/44836/23 | 23:41 |
haneef_ | henrynash: If instead of truncated, if the server throws exception saying restrict the query, won't it help. What is the point in sending half of data , if we want the client to issue different query with more filters | 23:41 |
*** markmcclain has quit IRC | 23:41 | |
gyee | haneef_, apparently to help client make better decisions :) | 23:41 |
*** kenperkins has joined #openstack-dev | 23:42 | |
henrynash | haneef_: so there are different UI approaches out there in the industry…some display what data it can, saying use this to work out a better filter (and looking at the data can help)….others display nothing | 23:42 |
*** benrodrigue has quit IRC | 23:42 | |
dolphm | and i don't think anyone has a use case for the "all or nothing" approach | 23:43 |
henrynash | haneef_: we shouldn't prejudge what they;ll do….but ideally allow them to do either | 23:43 |
jamielennox | dtroyer: hey, sorry about that | 23:44 |
*** gordc has joined #openstack-dev | 23:44 | |
dtroyer | jamielennox: np | 23:44 |
jamielennox | so i think it's a bit cleaner now i split up the patch - does the layout generally make sense to you? I know Alexei_987 has some opinions here | 23:45 |
henrynash | haneef_: ..and with the current proposal they can do either…. | 23:45 |
dtroyer | jamielennox: your last comment cleared it up for me a lot…the unit of auth I carry between API clients seems to be a session, right? I've had auth_ref in my head for a long time... | 23:46 |
*** MaxV has quit IRC | 23:46 | |
gyee | henrynash, dolphm, LDAP won't even bother to return anything I think, it will return you a nice search limit exceeded error | 23:46 |
jamielennox | dtroyer: yes, the whole session object is taken from client to client and auth is therefore inherently transfered | 23:46 |
*** MaxV has joined #openstack-dev | 23:47 | |
dolphm | gyee: clients can specify limits as well | 23:47 |
jamielennox | dtroyer: this means that we take along transport level details which are most likely the same for all the services anyway | 23:47 |
dtroyer | jamielennox: right. but the service catalog is in the identity client, so I need to extract that to take along too | 23:47 |
dolphm | gyee: which is what we're talking about here | 23:47 |
jamielennox | dtroyer: ahh, no - the service catalog is part of the token so it is going to move with the auth plugin | 23:47 |
dtroyer | jamielennox: agreed on the transport… I'll need multiple sesisons to do multiple sets of creds at once, that's what took me a while to get | 23:47 |
*** blamar has quit IRC | 23:47 | |
henrynash | dolphm: you mean a client of LDAP, rather than a client of openstack I think? | 23:47 |
dolphm | henrynash: correct | 23:48 |
*** browne has joined #openstack-dev | 23:48 | |
jamielennox | dtroyer: if you look at https://review.openstack.org/#/c/60752/ it shows an example of how i want to work with the service catalog | 23:48 |
dolphm | henrynash: i think gyee's comment applies more to LDAP-server defined hard limits | 23:48 |
jamielennox | dtroyer: well it shows the implementation but without any tests and dependant on merging all the auth plugin stuff | 23:48 |
dtroyer | jamielennox: ok, HTTPClient has a property method for it... | 23:48 |
dtroyer | that threw me then | 23:49 |
jamielennox | dtroyer: yep but that will be deprecated with so much else | 23:49 |
*** tqtran has quit IRC | 23:49 | |
dtroyer | cool…I hadn't seen 60752 yet… at a glance that helps too | 23:49 |
*** willingc has quit IRC | 23:50 | |
dtroyer | jamielennox: one of the things I want to get out of this is a version that doesn't have the compatibility cruft in it | 23:50 |
jamielennox | dtroyer: essentially a client should need to know nothing except the service_type, endpoint_type and endpoint_version that it requires (which will be static for a client) and the session will do the rest | 23:50 |
*** thuc has quit IRC | 23:50 | |
jamielennox | dtroyer: ++ | 23:50 |
*** thuc has joined #openstack-dev | 23:50 | |
*** romcheg1 has quit IRC | 23:51 | |
jamielennox | dtroyer: so essentially all a client should need to be is defined in baseclient: https://review.openstack.org/#/c/60751/8/keystoneclient/baseclient.py | 23:51 |
*** MaxV has quit IRC | 23:51 | |
dtroyer | jamielennox: I'm doing a POC of that now too… in OSC the object-store commands don't have a lib API so it's all from scratch, that's where I want to work this out | 23:51 |
jamielennox | all that provides is an interface for managers to talk through | 23:52 |
dtroyer | jamielennox: and there's the other thing I'm trying, no managers, no resources. I don't think we need them at the low-level API | 23:52 |
dtroyer | OSC doesn't, but an app developer might, so they can sit on top | 23:53 |
jamielennox | dtroyer: i'm very interested in that - but i'm currently trying to see what i can get working with current clients | 23:53 |
jamielennox | dtroyer: this whole ML thread of a common client is a PITA really | 23:53 |
dtroyer | jamielennox: right… that too... | 23:53 |
dtroyer | jamielennox: that's one reason I'm doing this in OSC, no backward-compatibility issues | 23:53 |
jamielennox | dtroyer: so i'm of the opinion in all of this that we should look to layer our approach | 23:54 |
dtroyer | jamielennox: theres an etherpad you should see... | 23:54 |
jamielennox | the fact that we have keystoneclient.v3.client which directly reflects the V3 api is not a problem - it's correct - it's just lower level than most people would want to use | 23:54 |
jamielennox | anyone who is interested in developing a version independant client can (and should) which backs on to something that reflects the API | 23:55 |
*** thuc has quit IRC | 23:55 | |
dtroyer | jamielennox: exactly | 23:56 |
jamielennox | i also extract from there that if you want to do a unified client then you should that works with all those other clients | 23:56 |
*** dave_tucker is now known as dave_tucker_zzz | 23:56 | |
*** alexpilotti has quit IRC | 23:56 | |
jamielennox | that sucks currently because the clients are in disarray and you don't need to convince me that pip sucks | 23:57 |
dtroyer | don't think that consolidated object APIs isn't in our future….it's just a SMOP | 23:57 |
jamielennox | agreed, there was a post there that someone was going to start something - but someone is always starting something in openstack | 23:58 |
dtroyer | jamielennox: so I need to run in a minute…grabbing the SC out of the session's auth_ref is the Right Thing then? I'll head down that path. | 23:58 |
*** networkstatic has quit IRC | 23:59 | |
dtroyer | jamielennox: Jesse Noller is working in that direction…he wants the whole SDK though so that's why we're layering it | 23:59 |
*** nkinder has quit IRC | 23:59 | |
jamielennox | dtroyer: if you need the SC directly then yes. I made auth_ref a public attribute on purpose on those plugins (but be warned not everything is going to be a keystone plugin thus have an auth_ref) | 23:59 |
henrynash | gyee: are you any closer to seeing the other side of this debate? | 23:59 |
jamielennox | dtroyer: i had in mind though that most services would not need that | 23:59 |
*** dave_tucker_zzz is now known as dave_tucker | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!