| bknudson | morganfainberg: I rebased a long set of reviews on master and now I'm getting this | 00:00 |
|---|---|---|
| morganfainberg | huh | 00:00 |
| *** pmathews has quit IRC | 00:00 | |
| *** sushils has quit IRC | 00:00 | |
| morganfainberg | that... seems odd | 00:00 |
| *** nsp has quit IRC | 00:01 | |
| bknudson | morganfainberg: reason I ask about moving kds out of keystone is because I doubt they want to wait 10 mins for unit tests to run. | 00:02 |
| bknudson | hopefully they can start out better and smarter with parallel testr, etc. | 00:02 |
| morganfainberg | bknudson, that is a fair reasoning | 00:03 |
| morganfainberg | bknudson, i don't want to wait for that for keystone...but we're a little ways away from that | 00:03 |
| *** mrodden has quit IRC | 00:03 | |
| morganfainberg | bknudson, but i think the concern is if it's in keystone's repo it is released w/ keystone as "integrated" | 00:04 |
| *** mrodden has joined #openstack-dev | 00:04 | |
| *** mrodden has quit IRC | 00:04 | |
| morganfainberg | bknudson, rather than "that thing over there" for secure messaging | 00:04 |
| *** jivargas has joined #openstack-dev | 00:04 | |
| bknudson | morganfainberg: I think nova has some sub-projects that aren't in nova repo... | 00:04 |
| morganfainberg | don't see why the new repo couldn't be in it's own repo though | 00:04 |
| morganfainberg | we could poke infra, probably would be easy to add the repo. | 00:04 |
| *** jivargas has quit IRC | 00:04 | |
| morganfainberg | and i think it would be easy to package it still under keystone's purview | 00:05 |
| morganfainberg | dolphm, ^ any worries complaints or concerns? | 00:06 |
| jamielennox | i think we tried this already didn't we? | 00:06 |
| morganfainberg | prob. should ask the PTL first. | 00:06 |
| morganfainberg | jamielennox, no, i think we tried the "make it stackforge" and "part of barbican" | 00:06 |
| morganfainberg | not "new repo, but under keystone" | 00:06 |
| *** kevinconway has quit IRC | 00:07 | |
| jamielennox | interesting - it doesn't make any difference to me | 00:07 |
| *** rwsu has joined #openstack-dev | 00:07 | |
| morganfainberg | jamielennox, i actually think bknudson has a point about not inheriting keystone's test issues. | 00:07 |
| jamielennox | morganfainberg: i've distanced it as much as possible | 00:07 |
| jamielennox | i had a heap of problems with the one up for the next review | 00:07 |
| morganfainberg | jamielennox, fair point, but you're still beholden to keystone's long long test runtime | 00:08 |
| bknudson | that's what I'm mostly concerned about... kds tests will probably not run in parallel if they aren't doing it from the beginning. | 00:08 |
| jamielennox | because i had designed KDS to work in it's own database, the global CONF system really doesn't cope when you try to run two projects in the same process | 00:08 |
| *** antigluk_ has quit IRC | 00:08 | |
| *** mlavalle has quit IRC | 00:09 | |
| jamielennox | can work in it's own db - can work fine mingled with keystone as well | 00:09 |
| morganfainberg | jamielennox, separate table namespace, shouldn't care | 00:09 |
| *** antigluk_ has joined #openstack-dev | 00:09 | |
| *** sarob has joined #openstack-dev | 00:09 | |
| bknudson | I think you'd have to have your own kds-manage command | 00:09 |
| morganfainberg | bknudson, actually can't we just tag all the keystone tests to require the same testr worker? | 00:10 |
| morganfainberg | and the kds ones run freeeeeeeeeee | 00:10 |
| jamielennox | yea, but kds has it's own .conf so it was just having the tests scripts try to deal with both thats a problem | 00:10 |
| morganfainberg | i think testr has that logic | 00:10 |
| *** antigluk_ has quit IRC | 00:10 | |
| jamielennox | yea we discussed that before as a way to group together the sql disk commands | 00:10 |
| morganfainberg | i'm sure lifeless could clarify it for us (if he's around) ^ | 00:10 |
| *** exed_ has quit IRC | 00:10 | |
| jamielennox | i have a feeling he'd be at LCA | 00:11 |
| morganfainberg | jamielennox, bknudson, then lets (at least) do that. | 00:11 |
| morganfainberg | make sure KDS tests do run in parallel | 00:11 |
| morganfainberg | and just lock the keystone ones all to the same worker | 00:11 |
| *** antigluk_ has joined #openstack-dev | 00:11 | |
| jamielennox | morganfainberg: mmm, i had to tie the KDS db tests to the keystone db | 00:12 |
| morganfainberg | if it makes sense to split kds out into it's own repo, we can do that as well | 00:12 |
| morganfainberg | jamielennox, shouldn't really matter as long as KDS tests are smart about the DB location | 00:12 |
| *** jv___ has joined #openstack-dev | 00:12 | |
| bknudson | so if you're using keystone's "pristine" db or whatever you're going to have to all be in 1 thread. | 00:12 |
| jamielennox | https://review.openstack.org/#/c/59602/16/keystone/tests/contrib/kds/fixture/sqlitedb.py | 00:12 |
| morganfainberg | jamielennox, you could have multiple db files (sqlite) | 00:12 |
| *** gokrokve has quit IRC | 00:13 | |
| *** mdenny has quit IRC | 00:13 | |
| bknudson | if you want to make keystone's tests run in parallel that would be great, too! | 00:13 |
| *** gokrokve has joined #openstack-dev | 00:13 | |
| jamielennox | its seems to screw with CONF | 00:13 |
| *** antigluk_ has quit IRC | 00:13 | |
| morganfainberg | well, couldn't you make a connect string be used for KDS's db ? | 00:14 |
| morganfainberg | that is separate from the keystyone one? | 00:14 |
| jamielennox | bknudson: there's no reason we can't - it just means instead of copying test.db.prinstine to test.db we copy to test.db.rndnumber and run the test that way | 00:14 |
| morganfainberg | or is that not possible. | 00:14 |
| jamielennox | morganfainberg: i tried it gave really weird errors about tables not existing | 00:14 |
| morganfainberg | jamielennox, huh | 00:14 |
| jamielennox | it's probably keystone test's fault but somewhere in there the databases were getting mixed up | 00:15 |
| morganfainberg | perhaps..... perhaps | 00:15 |
| morganfainberg | hmmm. | 00:15 |
| morganfainberg | would it change things if kds was made a separate structure | 00:15 |
| *** antigluk_ has joined #openstack-dev | 00:15 | |
| morganfainberg | e.g. keystone/<stuff> | 00:15 |
| morganfainberg | and kds/<stuff> | 00:15 |
| morganfainberg | ? | 00:15 |
| jamielennox | it keystone/contrib/kds already | 00:15 |
| jamielennox | i think that's sufficient | 00:16 |
| morganfainberg | jamielennox, i mean break it out of keystone's tree, give it it's own config object, own sql lib | 00:16 |
| morganfainberg | etc | 00:16 |
| morganfainberg | i know it's duplicating code... | 00:16 |
| morganfainberg | but short of a separate repo | 00:16 |
| jamielennox | i don't know if the oslo sync code would handle that | 00:16 |
| bknudson | then might as well have their own repo | 00:16 |
| jamielennox | (not saying it can't) | 00:16 |
| jamielennox | but agree it might as well be a seperate repo then | 00:17 |
| morganfainberg | bknudson, i think separate repo is likely the best idea | 00:17 |
| morganfainberg | i think if there aren't concerns over it being separate repo, just under the "identity" project | 00:17 |
| jamielennox | that does make it a new project though really | 00:17 |
| morganfainberg | i think it would make a lot of sense | 00:17 |
| jamielennox | just administered differently | 00:17 |
| bknudson | oslo has a bunch of separate repos | 00:17 |
| morganfainberg | jamielennox, nah, it's still identity | 00:18 |
| jamielennox | but i guess i'm already making a new .conf and a new binary so it's not that much more | 00:18 |
| bknudson | python-keystoneclient is a separate repo | 00:18 |
| morganfainberg | jamielennox, yeah | 00:18 |
| *** gokrokve has quit IRC | 00:18 | |
| morganfainberg | bknudson, prob should check w/ dolphm, but i think we could get that done pretty quickly | 00:19 |
| *** sthaha has joined #openstack-dev | 00:19 | |
| *** sthaha has quit IRC | 00:19 | |
| *** sthaha has joined #openstack-dev | 00:19 | |
| morganfainberg | iirc new repos are pretty easy to add for infra | 00:19 |
| *** spzala has joined #openstack-dev | 00:19 | |
| bknudson | the infra group are a bunch of superheroes, so everything is easy for them. | 00:19 |
| morganfainberg | bknudson, damn straight | 00:19 |
| bknudson | they'd swat this one like a mosquito | 00:19 |
| *** jv___ has quit IRC | 00:19 | |
| *** yamahata has joined #openstack-dev | 00:20 | |
| morganfainberg | mordred, ^ hear that, superheroes. | 00:20 |
| jamielennox | lol, superheros is so rarely the end of that sentence | 00:20 |
| morganfainberg | mordred, not that you didn't know | 00:20 |
| *** kgriffs_afk is now known as kgriffs | 00:21 | |
| *** achampion has joined #openstack-dev | 00:21 | |
| *** FunnyLookinHat has quit IRC | 00:21 | |
| morganfainberg | bknudson, i looked at next-review | 00:21 |
| morganfainberg | should be easy to add a different json source | 00:21 |
| *** markwash has quit IRC | 00:21 | |
| morganfainberg | but it would be very different handling of the logic | 00:21 |
| morganfainberg | not hard | 00:21 |
| bknudson | morganfainberg: thank you! | 00:24 |
| bknudson | if this could help me prioritize reviews that would be great | 00:24 |
| bknudson | keep people working on high-priority items. | 00:24 |
| morganfainberg | once that json data is available that is | 00:24 |
| morganfainberg | oh yeah, i am starting to change my workflow to use that page | 00:24 |
| morganfainberg | but a nice cli, tool. oh yes | 00:25 |
| *** carl_baldwin has quit IRC | 00:26 | |
| *** antigluk_ has quit IRC | 00:27 | |
| *** kgriffs is now known as kgriffs_afk | 00:30 | |
| *** rfolco has joined #openstack-dev | 00:32 | |
| *** chandankumar has joined #openstack-dev | 00:32 | |
| *** vipuls is now known as vipuls-away | 00:33 | |
| *** vipuls-away is now known as vipuls | 00:33 | |
| *** dstanek has joined #openstack-dev | 00:33 | |
| morganfainberg | ooh i see a dstanek | 00:33 |
| morganfainberg | dstanek, gratz on core btw, haven't talked to ya since last year | 00:34 |
| dstanek | hi morganfainberg! | 00:34 |
| bknudson | dstanek: you must have had a great vacation | 00:34 |
| dstanek | thanks, now i'm at the adult table :-) | 00:34 |
| morganfainberg | dstanek, oh no | 00:35 |
| morganfainberg | dstanek, this is def. the kiddie table | 00:35 |
| *** mikeoutland has quit IRC | 00:35 | |
| dstanek | bknudson: i actually spent a lot of my vacation watching summit videos | 00:35 |
| bknudson | there were videos? | 00:35 |
| morganfainberg | bknudson, aparantly | 00:35 |
| bknudson | now I'm worried | 00:35 |
| morganfainberg | bknudson, oh, you going to be in SA next week? meant to ask | 00:36 |
| bknudson | morganfainberg: I haven't heard one way or the other. | 00:36 |
| morganfainberg | bknudson, hopefully | 00:36 |
| bknudson | I don't know when the cutoff is to register or whatever | 00:36 |
| morganfainberg | bknudson, eh, cost of flight and hotel ;) | 00:36 |
| morganfainberg | bknudson, i bet if you told dolphm you were showing up on tuesday, you'd be good | 00:36 |
| bknudson | I hope IBM can scrounge up the money. | 00:36 |
| dstanek | it'll be nice to meet people in person | 00:37 |
| morganfainberg | or .. called him on wednesday | 00:37 |
| morganfainberg | too bad jamielennox doesn't love us enough to fly like 18 hours for 3 days | 00:37 |
| * morganfainberg ducks | 00:37 | |
| morganfainberg | ;) | 00:37 |
| dstanek | bknudson: i think they have a few dollars laying around | 00:37 |
| jamielennox | morganfainberg: next one i'll host here in brisbane | 00:37 |
| bknudson | he had no problem getting to hk. | 00:37 |
| jamielennox | actually, people might come then... | 00:38 |
| morganfainberg | jamielennox, hmm. if i can get funding i'm so there | 00:38 |
| bknudson | I could go to brisbane now. | 00:38 |
| bknudson | although it has warmed up to 16 | 00:38 |
| jamielennox | heh, even the news here is talking about the weather in the US | 00:38 |
| morganfainberg | eh, i prefer cold weather | 00:38 |
| morganfainberg | can i move to the north east yet? | 00:38 |
| morganfainberg | plox. | 00:38 |
| bknudson | you prefer -30 F and -50 wind chill? | 00:38 |
| morganfainberg | bknudson, eh, i'd survive for the rest of the less-extreme winter | 00:39 |
| morganfainberg | bknudson, i really do prefer cold weather | 00:39 |
| morganfainberg | even extreme cold. | 00:39 |
| jamielennox | morganfainberg: you might not survive here then | 00:39 |
| morganfainberg | as long as i can warm up by fire etc. | 00:40 |
| morganfainberg | (even if i can't i can get the real camping gear and be comfortable enough) | 00:40 |
| dstanek | morganfainberg: i like it cold, but this week it went way too far | 00:41 |
| morganfainberg | dstanek, hehe | 00:41 |
| *** chandankumar has quit IRC | 00:41 | |
| *** sballe has quit IRC | 00:43 | |
| dstanek | jamielennox: never been to brisbane, but i'd definitely go :-) | 00:43 |
| *** sballe has joined #openstack-dev | 00:43 | |
| *** antigluk_ has joined #openstack-dev | 00:44 | |
| *** vikasd has quit IRC | 00:44 | |
| jamielennox | rain and 26C today | 00:44 |
| bknudson | oh, rain? no way then. | 00:44 |
| *** antigluk_ has quit IRC | 00:45 | |
| jamielennox | can't be sunny all the time | 00:45 |
| *** galstrom_zzz is now known as galstrom | 00:45 | |
| jamielennox | google says thats 79F - i can never do the convert | 00:46 |
| *** antigluk_ has joined #openstack-dev | 00:46 | |
| *** willingc has quit IRC | 00:46 | |
| morganfainberg | bknudson, it's ok it's sunny here in SoCal | 00:48 |
| morganfainberg | no rain for a while | 00:48 |
| bknudson | it's not raining here either. | 00:48 |
| bknudson | guess what just came up on my music player... "Here Comes the Rain" by Eurythmics. | 00:49 |
| *** yamahata has quit IRC | 00:50 | |
| morganfainberg | lol | 00:51 |
| dstanek | it was snowing here a few hours ago, but i hear it'll be warming up a bit tonight and tomorrow | 00:51 |
| *** galstrom is now known as galstrom_zzz | 00:52 | |
| lifeless | morganfainberg: hi | 00:53 |
| lifeless | morganfainberg: whatsup? | 00:54 |
| *** pablosan has quit IRC | 00:54 | |
| morganfainberg | lifeless, just was curious about testr, but i think we resolved it from previous convos | 00:54 |
| morganfainberg | lifeless, running some tests all on one worker and other split among any worker(s) | 00:54 |
| bknudson | lifeless: we had a question about running some tests in parallel and others in serial. | 00:54 |
| morganfainberg | lifeless, but i think we were sure that was possible due to the want to do that for the SQL-tests in keystone (previous convo) | 00:55 |
| *** aeperezt has quit IRC | 00:55 | |
| *** antigluk_ has quit IRC | 00:55 | |
| dstanek | morganfainberg: bknudson: was just looking at the comment on https://review.openstack.org/#/c/63460/1/keystone/tests/test_keystoneclient.py about using cleanUp instead of tearDown | 00:56 |
| lifeless | morganfainberg: bknudson: http://testrepository.readthedocs.org/en/latest/MANUAL.html#grouping-tests | 00:56 |
| dstanek | morganfainberg: bknudson: the problem is that I can't as designed | 00:56 |
| bknudson | dstanek: https://review.openstack.org/#/c/65161/ | 00:56 |
| dstanek | we steal a reference to the server in the setUp so even thought the cleanUp runs the object isn't being collected because there is a reference to it | 00:57 |
| bknudson | lifeless: thanks! I'll put that on my list of things to investigate. | 00:57 |
| dstanek | bknudson: i agree in most cases, but if we really don't want to use the tearDown I can change the code to use self.fixture.server and not create a self.server reference | 00:58 |
| bknudson | dstanek: we really don't want to use tearDown... it was causing a problem for me last week. | 00:58 |
| bknudson | so let's not use tearDown. | 00:58 |
| *** topol has joined #openstack-dev | 00:59 | |
| *** rnirmal has quit IRC | 00:59 | |
| dstanek | bknudson: i can rig that up...it'll be a little ugly, but i can | 00:59 |
| lifeless | dstanek: why will it be ugly ? | 01:00 |
| bknudson | it will be beautiful | 01:00 |
| lifeless | dstanek: tearDown -> cleanUp is a mechanical transform | 01:00 |
| dstanek | lifeless: not exactly | 01:00 |
| lifeless | dstanek: yes, exactly | 01:00 |
| dstanek | there are lots of places in the setUp where we self.blah = self.useFixture(Blah()).some_thing | 01:01 |
| lifeless | dstanek: perhaps you can put up a gist so I can see the issue you're having? | 01:01 |
| dstanek | if we do this then the reference to some_thing isn't cleaned up until the test ends | 01:01 |
| *** xarses has quit IRC | 01:01 | |
| dstanek | lifeless: by ugly i just mean that some statements will be multiple lines | 01:02 |
| *** topol_ has joined #openstack-dev | 01:02 | |
| dstanek | lifeless: maybe a test base class could just sweep through a test instances attributes and delete them in a clean up to bypass the entire problem | 01:02 |
| lifeless | dstanek: what is the problem? | 01:03 |
| bknudson | dstanek: isn't it essentially the same as https://review.openstack.org/#/c/64856/1/keystone/tests/rest.py ? | 01:03 |
| dstanek | lifeless: https://review.openstack.org/#/c/63460/1 | 01:03 |
| dstanek | bknudson: ah, that's a clever hack around | 01:04 |
| lifeless | dstanek: self.foo -> self.addCleanup(setattr, self, 'foo', None) | 01:04 |
| lifeless | bah | 01:04 |
| lifeless | dstanek: self.foo = None -> self.addCleanup(setattr, self, 'foo', None) | 01:04 |
| lifeless | or | 01:04 |
| *** topol has quit IRC | 01:04 | |
| lifeless | self.addCleanup(delattr, self, 'foo') | 01:05 |
| lifeless | might be better | 01:05 |
| dstanek | lifeless: i like that delattr approach | 01:06 |
| lifeless | in other projects we've done a cleanup of instance attributes - can be useful | 01:06 |
| *** topol has joined #openstack-dev | 01:06 | |
| *** sarob_ has joined #openstack-dev | 01:06 | |
| bknudson | morganfainberg: https://review.openstack.org/#/c/65835/ is change to remove netifaces req. | 01:06 |
| lifeless | another thing you can do is use a testsuite object where suite.run() deletes tests after they are executed | 01:06 |
| *** topol_ has quit IRC | 01:06 | |
| lifeless | this is systematic and less intrusive | 01:06 |
| bknudson | tearDown doesn't run if setUp raises. | 01:06 |
| dstanek | lifeless: right now Keystone tests in my env take about 1.2G to run :-( | 01:06 |
| bknudson | so if a test fails loading the default_fixtures in setUp then all the tests will fail | 01:07 |
| jamielennox | bknudson: with https://review.openstack.org/#/c/64555/ the gitignore really shouldn't be there right? | 01:07 |
| morganfainberg | bknudson, will +2 that once jenkins weighs in | 01:07 |
| lifeless | dstanek: I'd be very happy with a subunit.run / testtools.run patch to use a testsuite that carefully drops it's references to tests after executing | 01:08 |
| jamielennox | i know you have fixes that are in that same space | 01:08 |
| bknudson | jamielennox: I told the submitter to continue to put the .gitignore just in case the file doesn't get cleaned up for whatever reason... | 01:08 |
| bknudson | cancelled the test with CTRL-C or whatever. | 01:08 |
| dstanek | jamielennox: yuck, i think the tests should remove the files if it creates them | 01:08 |
| jamielennox | dstanek: i agree - but that's not part of the patch he's fixing | 01:08 |
| bknudson | dstanek: I submitted the change to remove the files... see my comment. | 01:08 |
| bknudson | dstanek: https://review.openstack.org/#/c/65160/ | 01:09 |
| dstanek | lifeless: in interested in that idea - i don't understand why unittest would keep all test instances around until the end of a run anyway | 01:09 |
| jamielennox | bknudson: oh right - the files are there now because he's moved the signing dir | 01:09 |
| jamielennox | bknudson: thanks - i was sure that made sense before but didn't when i looked just then | 01:09 |
| *** Edward-Zhang has joined #openstack-dev | 01:09 | |
| *** sarob has quit IRC | 01:09 | |
| lifeless | dstanek: because suite.run(); suite.run() | 01:09 |
| *** dbalog has left #openstack-dev | 01:09 | |
| dstanek | jamielennox: i would say kill the gitignore and someone should just fix the problem | 01:09 |
| jamielennox | dstanek: i think bknudson has a patch for that later on, in terms of fixing the bug that he's linked though it works | 01:10 |
| dstanek | lifeless: when i was looking at it a few week ago it just seemed odd what they were doing | 01:10 |
| lifeless | dstanek: yeah, but thats why - being able to run tests in a loop is used by some folk to e.g. track memory leaks or intermittent failures | 01:11 |
| *** sarob_ has quit IRC | 01:11 | |
| *** topol has quit IRC | 01:11 | |
| dstanek | i would imagine for big test suites it causes memory leaks | 01:11 |
| lifeless | that can be a factor too | 01:12 |
| *** SumitNaiksatam has quit IRC | 01:12 | |
| *** epopt37 has quit IRC | 01:14 | |
| *** jasondotstar has joined #openstack-dev | 01:16 | |
| *** galstrom_zzz is now known as galstrom | 01:19 | |
| *** rfolco has quit IRC | 01:20 | |
| *** kgriffs_afk is now known as kgriffs | 01:21 | |
| *** s2r2 has quit IRC | 01:21 | |
| *** jasondotstar has quit IRC | 01:22 | |
| *** xmltok has quit IRC | 01:22 | |
| *** jasondotstar has joined #openstack-dev | 01:23 | |
| *** dstanek has quit IRC | 01:23 | |
| *** fifieldt has joined #openstack-dev | 01:24 | |
| *** browne has quit IRC | 01:25 | |
| *** thuc has quit IRC | 01:26 | |
| *** thuc has joined #openstack-dev | 01:26 | |
| *** epopt37 has joined #openstack-dev | 01:26 | |
| *** markwash has joined #openstack-dev | 01:28 | |
| *** s2r2 has joined #openstack-dev | 01:29 | |
| *** thuc has quit IRC | 01:30 | |
| *** galstrom is now known as galstrom_zzz | 01:31 | |
| *** kgriffs is now known as kgriffs_afk | 01:31 | |
| *** ramishra has joined #openstack-dev | 01:31 | |
| *** mriedem has joined #openstack-dev | 01:32 | |
| *** nosnos has joined #openstack-dev | 01:33 | |
| *** yaguang has joined #openstack-dev | 01:33 | |
| *** xuhanp has joined #openstack-dev | 01:34 | |
| *** rods2 has quit IRC | 01:35 | |
| *** bdpayne has quit IRC | 01:37 | |
| nkinder | jamielennox: are you familiar with this bug? https://bugs.launchpad.net/ossn/+bug/1254619 | 01:38 |
| *** rods1 has joined #openstack-dev | 01:38 | |
| *** alexpilotti has quit IRC | 01:38 | |
| *** alexpilotti has joined #openstack-dev | 01:39 | |
| jamielennox | nkinder: i'm familiar with the conept but not a lot of detail | 01:39 |
| jamielennox | bknudson: was it you who worked on that one? i know gyee was working in the area as well | 01:40 |
| *** ayoung has joined #openstack-dev | 01:40 | |
| nkinder | jamielennox: I'm writing up the OSSN for it, and I'm not sure what we can really recommend other than avoid using external auth with usernames containing "@". | 01:40 |
| bknudson | nkinder: the work is in progress | 01:40 |
| bknudson | I've got to admit I don't really understand the problem. | 01:40 |
| nkinder | bknudson: yes, I saw the code review. | 01:40 |
| bknudson | apparently wsgi says you shouldn't muck with the username passed in or something? | 01:41 |
| nkinder | bknudson: I understand the problem, though it requires a number of variables | 01:41 |
| nkinder | bknudson: assume that external auth could return both jdoe@example1 and jdoe@example2 in REMOTE_USER. | 01:42 |
| nkinder | also assume that these are not the same jdoe | 01:42 |
| nkinder | if Keystone is using the external auth plug-in, they both map to the "jdoe" user. | 01:42 |
| bknudson | I believe it'll pick the one from the default domain. | 01:42 |
| morganfainberg | ick | 01:43 |
| morganfainberg | thats icky | 01:43 |
| morganfainberg | and bknudson is likely correct | 01:43 |
| bknudson | I think it depends on the plugin you're using. | 01:43 |
| bknudson | plus we keep changing it every release. | 01:43 |
| nkinder | bknudson: yes, I'm looking here - https://github.com/openstack/keystone/commit/88c319e6bce98082f9a90b8b27726793d5366326#diff-fdd2fb341a95d6f773e9621a38f0e6d7R21 | 01:44 |
| nkinder | bknudson: specifically, ExternalDefault | 01:44 |
| ayoung | bknudson, morganfainberg do your unit tests take this long to run: Ran 2210 tests in 268.078s | 01:44 |
| morganfainberg | ayoung, 268-300 seconds seems about avg for a full run | 01:45 |
| morganfainberg | eh, 270-300 for me | 01:45 |
| bknudson | nkinder: does the ExternalDomain plugin help? can we recommend use the other plugin? | 01:45 |
| bknudson | ayoung: Ran 2212 tests in 488.216s (+7.262s) | 01:45 |
| bknudson | I need a faster computer | 01:45 |
| ayoung | Nah, we need to move some of those tests out of there | 01:46 |
| nkinder | bknudson: that's one of my questions | 01:46 |
| bknudson | or I need to run 2 fewer tests. | 01:46 |
| morganfainberg | ayoung, fix paralell tests | 01:46 |
| morganfainberg | ayoung, should also make things better | 01:46 |
| jamielennox | right from memory the initial external auth stripped off the DOMAIN so that when using ldap or such in weird configurations we didn't care about the domain | 01:46 |
| ayoung | let me try running in parallel | 01:46 |
| morganfainberg | ayoung, i don't think you can. SQL will all fail spectacularly | 01:47 |
| nkinder | jamielennox: yes, though that assumes the user part without domain is unique (which may not be the case) | 01:47 |
| ayoung | BAH | 01:47 |
| jamielennox | nkinder: more that the @ was an indication of the domain not a part of the suername | 01:47 |
| *** stanzgy_ has quit IRC | 01:47 | |
| morganfainberg | ayoung, though i think that is actually not too hard to fix. the download the keystoneclient tests are also icky to run in paralell | 01:47 |
| ayoung | those need to get out of there, too | 01:47 |
| ayoung | but then we are left with all the v3 api tests | 01:48 |
| bknudson | nkinder: it's kind of hard to imagine a customer getting confused by this too much... they're logging in with users like jdoe@example.com but their users in keystone are jdoe. | 01:48 |
| nkinder | jamielennox: yes, that's the way ExternalDomain works | 01:48 |
| jamielennox | nkinder: so for kerberos conf there is a setting that says whether or not to leave the domain part of the REMOTE_USER | 01:48 |
| morganfainberg | ayoung, if we tell each worker to stash the "db" in a worker-specific location, most of the headaches on that front go away | 01:48 |
| morganfainberg | then we could just say all the "client" tests must occur on a single worker | 01:49 |
| nkinder | bknudson: yes, but we should call it out in case they have different users with the same username and different domains. | 01:49 |
| jamielennox | nkinder: if you have that stripping the domain and then looking for an @ it's bad | 01:49 |
| *** pdevine has quit IRC | 01:49 | |
| *** giulivo has quit IRC | 01:49 | |
| morganfainberg | might not be a big change actually. | 01:49 |
| jamielennox | so i guess you could say don't turn that setting on | 01:49 |
| nkinder | jamielennox: yes, that's what the OSSN needs to warn about. Basically, don't do that. | 01:49 |
| nkinder | I'm wondering if we should recommend ExternalDomain in that case | 01:49 |
| jamielennox | nkinder: i don't know how much that refers to external auth in general | 01:49 |
| *** epim has joined #openstack-dev | 01:50 | |
| bknudson | nkinder: do you have a description of the problem already? | 01:50 |
| nkinder | bknudson: yes | 01:50 |
| bknudson | just not a recommendation? | 01:50 |
| morganfainberg | ayoung, oh yeah, looks like it might be just a few lines of code | 01:50 |
| morganfainberg | ayoung, i'll look at that ... tonight or this weekend | 01:50 |
| nkinder | correct. That's the portion I'm working on now. | 01:50 |
| morganfainberg | see if i can get it working. | 01:50 |
| *** ljjjustin has joined #openstack-dev | 01:50 | |
| nkinder | bknudson: I'm also unclear on how you specify the plug-in. This page just states you set the word "external" in the config - http://docs.openstack.org/developer/keystone/configuration.html | 01:51 |
| nkinder | bknudson: oh, I think I misread. The method is "external". | 01:52 |
| bknudson | nkinder: so, first off, I don't think the ExternalDomain plugin has the problem. So one option is to use that plugin. | 01:52 |
| *** csd has quit IRC | 01:52 | |
| nkinder | bknudson: that was my reading of ExternalDomain too | 01:52 |
| nkinder | bknudson: though I wasn't clear about what happens if the domain doesn't exist. | 01:52 |
| bknudson | nkinder: it'll fail if the domain doesn't exist. | 01:53 |
| bknudson | it would get a DomainNotFound and then that gets turned into Unauthorized | 01:53 |
| *** willingc has joined #openstack-dev | 01:54 | |
| ayoung | morganfainberg, I wrote this up earlier today https://blueprints.launchpad.net/keystone/+spec/keystone-testing-repo | 01:54 |
| nkinder | bknudson: ok, great. | 01:54 |
| bknudson | I guess the question is then if there's some reason you have to use ExternalDefault rather than ExternalDomain... | 01:55 |
| nkinder | bknudson: so one could use ExternalDomain if that fits their usage, or they need to ensure that there aren't naming conflicts to avoid impersonation. | 01:55 |
| morganfainberg | ayoung, this makes a lot of sense... or perhaps | 01:55 |
| *** stanzgy has joined #openstack-dev | 01:55 | |
| morganfainberg | ayoung, we should make it a new gate test | 01:55 |
| *** reed has quit IRC | 01:55 | |
| ayoung | morganfainberg, yes, it would be a gate test | 01:55 |
| morganfainberg | not even in a separate repo, just change how tests are run (e.g. like neutron-large-ops) | 01:55 |
| ayoung | morganfainberg, no, it needs to be in its own repo for other reasons | 01:56 |
| *** SumitNaiksatam has joined #openstack-dev | 01:56 | |
| *** radix_ has quit IRC | 01:56 | |
| morganfainberg | in theory, we could make a testr config that ignores functional on the main-line tests. | 01:56 |
| nkinder | bknudson: ExternalDefault collapses all users in to the default domain, which could be useful I suppose (if usernames are unique) | 01:56 |
| morganfainberg | and lets you run those tests separately, specifically on-demand | 01:56 |
| nkinder | bknudson: seems like a weird case though | 01:56 |
| ayoung | its the double-entry bookeeping thing: we don't allow people to break tests in a commit. You have to plan ahead. | 01:56 |
| bknudson | nkinder: another option is that they can write their own plugin... that's why it's called a plugin. | 01:56 |
| ayoung | morganfainberg, it also allows us to add tests after the code freeze deadline | 01:56 |
| morganfainberg | ayoung, eh, sure. | 01:57 |
| *** asselin_ has joined #openstack-dev | 01:57 | |
| morganfainberg | ayoung, only potentially | 01:57 |
| nkinder | bknudson: true | 01:57 |
| morganfainberg | ayoung, but sure. wont argue | 01:57 |
| morganfainberg | can see value there | 01:57 |
| morganfainberg | (plenty of value) | 01:57 |
| ayoung | morganfainberg, splitting it via testr though is probably a good first step | 01:57 |
| morganfainberg | ayoung, i think that is likely the first step | 01:57 |
| ayoung | and may be sufficient | 01:57 |
| morganfainberg | i'll see if it's hard to do while i'm trying to fix parallel testing | 01:58 |
| morganfainberg | might be silly easy | 01:58 |
| nkinder | bknudson: thanks, I think that gives me the info I need. | 01:58 |
| morganfainberg | (infra change though) | 01:58 |
| bknudson | nkinder: ok, great. | 01:58 |
| bknudson | y, I think it's just avoid the ExternalDefault because of the problem, and use the ExternalDomain because it doesn't have the problem or provide your own plugin | 01:59 |
| nkinder | bknudson: this is planned for an update for Havana, right? | 01:59 |
| nkinder | bknudson: that's what the bug indicates... | 01:59 |
| bknudson | nkinder: icehouse you mean? | 01:59 |
| nkinder | bknudson: nope, Havana. There was discussion about fixing it there to behave the same as Grizzly. | 02:00 |
| bknudson | it might have been reported late in H and didn't get in... and now we're kind of stuck in a bind | 02:00 |
| nkinder | bknudson: I suppose I should check with dolphm when he's around | 02:01 |
| bknudson | nkinder: I don't know what we're going to do about the change made to REMOTE_AUTH handling between G & H | 02:01 |
| *** mkollaro has quit IRC | 02:01 | |
| bknudson | typically wouldn't backport a change that changes behavior | 02:01 |
| bknudson | but then we typically wouldn't make a change that breaks backwards-compat | 02:02 |
| bknudson | and wouldn't make a change so that you can't use REMOTE_USER with both v2 and v3 authentication | 02:02 |
| bknudson | let's just say REMOTE_USER is in a bad spot. | 02:03 |
| *** sandywalsh has quit IRC | 02:03 | |
| ayoung | nkinder, sure you don't want to come to the hackfest? | 02:04 |
| *** aeperezt has joined #openstack-dev | 02:06 | |
| *** aeperezt has quit IRC | 02:06 | |
| *** aeperezt has joined #openstack-dev | 02:06 | |
| nkinder | ayoung: it'd be nice, but going to have to pass this time. | 02:07 |
| ayoung | Heh...anyway, on that one, there is a patch under review | 02:07 |
| *** epim has quit IRC | 02:07 | |
| *** rockyg has quit IRC | 02:07 | |
| nkinder | ayoung: yeah, I was reading the review feedback earlier. I think dolphm was hoping for a more simple fix that could be backported for havana. | 02:08 |
| *** tqtran has quit IRC | 02:08 | |
| ayoung | so first a one line patch to revert the behavior, with a follow on patch that adds in the additional plugins | 02:09 |
| *** tqtran has joined #openstack-dev | 02:09 | |
| ayoung | https://review.openstack.org/#/c/50362/ comments Dec 11 | 02:09 |
| *** willingc has quit IRC | 02:13 | |
| nkinder | ayoung: yep, that comment seems like the right thing to do | 02:13 |
| ayoung | lemme see what that patch should look like | 02:13 |
| *** willingc has joined #openstack-dev | 02:13 | |
| *** tqtran has quit IRC | 02:14 | |
| *** coolsvap has quit IRC | 02:14 | |
| *** chandankumar has joined #openstack-dev | 02:14 | |
| *** erkules_ has joined #openstack-dev | 02:14 | |
| *** buzztroll has joined #openstack-dev | 02:14 | |
| *** sarob has joined #openstack-dev | 02:17 | |
| *** erkules has quit IRC | 02:17 | |
| *** melwitt has quit IRC | 02:18 | |
| *** ijw has quit IRC | 02:18 | |
| *** ijw has joined #openstack-dev | 02:19 | |
| *** neelashah has joined #openstack-dev | 02:19 | |
| *** sandywalsh has joined #openstack-dev | 02:19 | |
| *** sarob has quit IRC | 02:21 | |
| *** kgriffs_afk is now known as kgriffs | 02:22 | |
| ayoung | dolphm what would be the "two line delete" you refer to in https://review.openstack.org/#/c/50362/ on Dec 11? the splitting of remote user in which pluging? | 02:23 |
| ayoung | nkinder, its been long enough since I looked at this that I am getting myself back up to speed on it. | 02:23 |
| ayoung | the V2 API assumes REMOTE_USER is 1 to 1 with username | 02:24 |
| *** ijw has quit IRC | 02:24 | |
| ayoung | V3 Grizzly did | 02:25 |
| ayoung | https://github.com/openstack/keystone/blob/stable/grizzly/keystone/auth/controllers.py#L322 | 02:25 |
| ayoung | ah, but that was broken and non-functional | 02:25 |
| ayoung | it did a lookup[ in the identity backend | 02:26 |
| *** comay has quit IRC | 02:26 | |
| ayoung | to figure out the domain | 02:26 |
| ayoung | and you had to pass in passwd | 02:26 |
| *** gokrokve has joined #openstack-dev | 02:27 | |
| ayoung | external default should not have been splitting the domainid out of the remote user | 02:28 |
| *** chandankumar has quit IRC | 02:29 | |
| *** buzztroll has quit IRC | 02:30 | |
| *** amcrn has quit IRC | 02:30 | |
| ayoung | nkinder, as best as I can tell, it was a copy/paste error that got the @ split under "default" | 02:31 |
| *** dstanek has joined #openstack-dev | 02:31 | |
| ayoung | so the 2 line delete he wants would be | 02:31 |
| nkinder | ayoung: yeah, it seems like only ExternalDomain should do the split | 02:31 |
| ayoung | and then we propagate the mistake in the latest refactoring? | 02:32 |
| *** alop has quit IRC | 02:32 | |
| *** kgriffs is now known as kgriffs_afk | 02:32 | |
| *** vahidh has quit IRC | 02:35 | |
| ayoung | nkinder, I'm not sure what to do for Havana. | 02:35 |
| *** lbragstad has joined #openstack-dev | 02:35 | |
| ayoung | I think the only thing we can do without breaking anyone is create a new plugin that does no splitting. And then tell people to use that | 02:36 |
| *** dstanek has quit IRC | 02:36 | |
| *** xchu has joined #openstack-dev | 02:37 | |
| *** sballe has quit IRC | 02:37 | |
| *** sballe has joined #openstack-dev | 02:38 | |
| *** haomaiwang has quit IRC | 02:39 | |
| *** buzztroll has joined #openstack-dev | 02:39 | |
| *** angdraug has quit IRC | 02:44 | |
| *** igorodet has quit IRC | 02:47 | |
| *** jasondotstar has quit IRC | 02:49 | |
| morganfainberg | bknudson, how do you run the SQL live tests? | 02:51 |
| morganfainberg | oh. nvm i think it's safe. | 02:51 |
| ayoung | _sql_livetests | 02:51 |
| morganfainberg | yeah just saw that | 02:52 |
| ayoung | :) | 02:52 |
| ayoung | I've been on this project 2 years. That is like infinity in internet time | 02:52 |
| *** dkranz has joined #openstack-dev | 02:53 | |
| morganfainberg | hmm | 02:53 |
| morganfainberg | so. | 02:53 |
| ayoung | they are broken, aren't they? | 02:54 |
| morganfainberg | nah | 02:54 |
| ayoung | Need to run the sql migrations to get the DBs ready | 02:54 |
| morganfainberg | trying to resolve the last issue to enable paralell testing | 02:54 |
| ayoung | ah | 02:54 |
| morganfainberg | last issue is the backend_sql.conf and backend_sql_disk.conf | 02:54 |
| morganfainberg | trying to avoid breaking the ability to use those | 02:55 |
| ayoung | ah...needs to have the path injected for the worker specific db? | 02:55 |
| morganfainberg | well. backend_sql.conf | 02:55 |
| morganfainberg | yes | 02:55 |
| morganfainberg | i'm thinking of some simple "if conf.database.connection == sqlite://, replace" | 02:55 |
| morganfainberg | w/ worker specific | 02:55 |
| morganfainberg | though tests would get stupidly wonky if you even tried a MySQL backend for tests | 02:56 |
| morganfainberg | since reinit is not done in those cases. | 02:56 |
| morganfainberg | right? | 02:56 |
| *** alop has joined #openstack-dev | 02:56 | |
| *** Mandell has quit IRC | 02:57 | |
| morganfainberg | a lot of tests assume a perfect pristine and empty db each time, and my guess is mysql wouldn't be that way (or postgres) | 02:57 |
| *** alop has quit IRC | 02:57 | |
| ayoung | mysql and postgres need the migrations | 02:57 |
| ayoung | only sqlite works to create the schema from the entities (IIRC) | 02:58 |
| *** ctlaugh has quit IRC | 02:58 | |
| *** ctlaugh has joined #openstack-dev | 02:58 | |
| ayoung | so..."if conf.database.connection == sqlite:// should be the right approach | 02:58 |
| morganfainberg | ayoung, but in parallel testing mysql isn't viable | 02:58 |
| ayoung | mysql...you'd need a separate database for each worker | 02:58 |
| lifeless | Oneiroi: why not? | 02:58 |
| lifeless | bah | 02:59 |
| morganfainberg | ayoung, would it work at all, e.g. mysql is cleaned out each time? | 02:59 |
| lifeless | morganfainberg: why not? | 02:59 |
| morganfainberg | lifeless, because our unit tests assume a pristine db each time | 02:59 |
| lifeless | morganfainberg: parallel testing with real db's is fine, you just need a unique db name for each worker. | 02:59 |
| morganfainberg | oh. | 02:59 |
| morganfainberg | ohhh | 02:59 |
| morganfainberg | derpy derp derp | 02:59 |
| morganfainberg | yes | 02:59 |
| ayoung | so the test needs enough access to mysql in order to do createdb; dropdb | 02:59 |
| morganfainberg | ayoung, my point was "does that actually work" currently | 03:00 |
| morganfainberg | w/ single test worker | 03:00 |
| ayoung | the issue with postgresql, I think, was that you needed to connect to a different DB than the one you were creating and destroying | 03:00 |
| ayoung | we don't drop the db... | 03:00 |
| morganfainberg | ayoung, exactly, so do a bunch of tests fail since the db isn't in pristine state? | 03:01 |
| ayoung | Didn't want something that worked for one db and not the others, so we drop the tables instead.... | 03:01 |
| morganfainberg | ah | 03:01 |
| morganfainberg | i see | 03:01 |
| morganfainberg | hmm. | 03:01 |
| ayoung | but...if we had an admin db, then Postgres would work | 03:01 |
| ayoung | coneect to admin, do createdb worker | 03:01 |
| ayoung | and flurdy blurp | 03:01 |
| ayoung | http://www.foodrepublic.com/sites/default/files/imagecache/large/singlepage/swedish_chef_meme_2_0.jpg | 03:02 |
| ayoung | Bork Bork Bork | 03:03 |
| *** ayoung is now known as SwedishChef | 03:03 | |
| morganfainberg | hmmm. | 03:03 |
| SwedishChef | Turns out I've been speaking Norwegian the whole time. | 03:04 |
| *** SwedishChef is now known as ayoung | 03:04 | |
| *** sarob has joined #openstack-dev | 03:04 | |
| *** gokrokve has quit IRC | 03:04 | |
| *** gokrokve has joined #openstack-dev | 03:05 | |
| morganfainberg | hm. | 03:05 |
| lifeless | there's a library for creating postgresqldb's just in time | 03:06 |
| lifeless | two of them in fact | 03:06 |
| *** buzztroll has quit IRC | 03:06 | |
| morganfainberg | lifeless, looks like i'll need the same for mysql. and... db2? | 03:06 |
| morganfainberg | lifeless, but yeah, was going to go looking for that next, solving the sqlite case first, then was going to look at the others | 03:07 |
| *** _cjones_ has quit IRC | 03:07 | |
| ayoung | the live dbs can wait. We need to explicitly run them anyway, and we can do that without the parallel flag | 03:08 |
| lifeless | https://pypi.python.org/pypi/testing.postgresql https://pypi.python.org/pypi/van.pg | 03:08 |
| lifeless | morganfainberg: ^ I've used van.pg before (it was written by the author to work with my testresources library :)) | 03:08 |
| *** neoXsys has quit IRC | 03:09 | |
| *** gokrokve has quit IRC | 03:09 | |
| morganfainberg | lifeless, nice. | 03:09 |
| morganfainberg | ayoung, ok | 03:10 |
| morganfainberg | ayoung, i'll register a bug for that or well at least lump the info into the current bug | 03:10 |
| ayoung | OkeyBadokey! | 03:11 |
| morganfainberg | lifeless, is there a way to tell a testr worker to execute some code as ... an exit process? | 03:11 |
| morganfainberg | lifeless, similar to a finally block | 03:12 |
| morganfainberg | i was hoping to issue a cleanup of the pid-specific test dirs | 03:12 |
| *** buzztroll has joined #openstack-dev | 03:12 | |
| *** paragan has joined #openstack-dev | 03:12 | |
| *** buzztroll has quit IRC | 03:12 | |
| morganfainberg | it's not terrible to leave it around, but, it does balloon after test after test | 03:12 |
| lifeless | morganfainberg: os.atexit perhaps? I'd be super hesitant about it though. What problem are you solving? | 03:12 |
| *** buzztroll has joined #openstack-dev | 03:13 | |
| morganfainberg | lifeless, i create a PID specific test dir | 03:13 |
| ayoung | um...drop the db in the tearDown | 03:13 |
| jamielennox | morganfainberg: can't you jsut put them all in a larger folder then reap the big folder at the end? | 03:13 |
| lifeless | ayoung: s/tearDown/cleanUp/ | 03:13 |
| lifeless | morganfainberg: do you want to preserve state between test cases? | 03:13 |
| lifeless | morganfainberg: e.g. why is it per worker and not per case? | 03:13 |
| morganfainberg | lifeless, yes since we don't need to re-migrate the sqlite db that way | 03:13 |
| ayoung | lifeless, why not tearDown? | 03:13 |
| morganfainberg | i guess i'll use cleanups for other test data | 03:14 |
| lifeless | ayoung: because tearDown doesn't always run, and infra have asked that we stop using it. | 03:14 |
| ayoung | joy | 03:14 |
| morganfainberg | ayoung, teardown will fail to run if setup fails | 03:14 |
| lifeless | ayoung: tearDown also doesn't always run to completion, but since it's cleanup code you *want* it to run to completion. | 03:14 |
| morganfainberg | among other things | 03:14 |
| ayoung | is cleanup run per test or once per overall? | 03:15 |
| morganfainberg | lifeless, the current usecase is we have a "pristine" migrated db, and we don't want to lose that. saves time vs. migrating the sqlite every time | 03:15 |
| morganfainberg | ayoung, addCleanup is per case. | 03:15 |
| morganfainberg | lifeless, for a number of out test-cases that is. | 03:15 |
| lifeless | morganfainberg: so, testresources is /designed/ for this use case :) | 03:15 |
| morganfainberg | lifeless, ok | 03:16 |
| *** mestery has quit IRC | 03:16 | |
| lifeless | but, deleting a pid based test dir - i think it would be reasonable to use atexit for that | 03:16 |
| lifeless | morganfainberg: for now, so we don't block on this | 03:16 |
| morganfainberg | lifeless, ok | 03:16 |
| morganfainberg | lifeless, yeah trying to do this in stages | 03:17 |
| lifeless | indeed :) | 03:17 |
| morganfainberg | lifeless, so i'll use atexit to do a shutil.rmtree on that dir | 03:17 |
| morganfainberg | the pid specific one | 03:17 |
| *** nati_ueno has quit IRC | 03:17 | |
| morganfainberg | and we'll do further cleanup to use testresources as we progress towards "fixing" the keystone tests | 03:18 |
| morganfainberg | instead | 03:18 |
| ayoung | put all of the dbs in keystone/tests/db | 03:19 |
| lifeless | ayoung: surely /tmp is better | 03:19 |
| ayoung | nope | 03:19 |
| ayoung | lifeless, please no | 03:19 |
| lifeless | ayoung: why not? | 03:19 |
| morganfainberg | ayoung, keystone/tests/tmp/PID ? | 03:19 |
| morganfainberg | thats the current working tmp dir | 03:19 |
| ayoung | morganfainberg, if you are going to delete them one at a time | 03:19 |
| ayoung | make it a subdir if you want to wack them all | 03:19 |
| lifeless | writing test data to the source tree is a really bad antipattern | 03:20 |
| lifeless | ayoung: they have to be cleaned up separately | 03:20 |
| lifeless | ayoung: as each backend doesn't know if it's the last active one | 03:20 |
| morganfainberg | lifeless, ++ | 03:20 |
| ayoung | lifeless, http://adam.younglogic.com/2012/06/sqlite-unit-tests/ | 03:20 |
| ayoung | I mount them in a ramdisl | 03:20 |
| ayoung | disk for speed | 03:20 |
| *** willingc has quit IRC | 03:21 | |
| morganfainberg | ayoung, so still mount tests/tmp | 03:21 |
| morganfainberg | i create the tmpdir for the pid on demand | 03:21 |
| *** willingc has joined #openstack-dev | 03:21 | |
| ayoung | morganfainberg, I do | 03:21 |
| morganfainberg | and will clean it up at exit | 03:21 |
| ayoung | just don't put them directly in /tmp | 03:21 |
| morganfainberg | not going to change that behavior | 03:21 |
| lifeless | ayoung: that doesn't explain anything for me | 03:21 |
| morganfainberg | not no /tmp | 03:21 |
| lifeless | ayoung: isn't your /tmp a ramdisk? | 03:21 |
| morganfainberg | keystone/tests/tmp | 03:21 |
| ayoung | lifeless, no | 03:21 |
| ayoung | and it should not be | 03:21 |
| ayoung | that is a blight upon the land and must be stamped out! | 03:21 |
| ayoung | you make /tmpo a ramdisk you risk filling up your ram with random crap | 03:22 |
| morganfainberg | eh. | 03:22 |
| morganfainberg | not if you limit the size | 03:22 |
| *** galstrom_zzz is now known as galstrom | 03:22 | |
| morganfainberg | doable in linux | 03:22 |
| StevenK | Well, /tmp is swap-backed ram | 03:22 |
| lifeless | ayoung: so your point is that you want a well known path to put the tests in, so you can mount that as a tmpfs ? | 03:22 |
| ayoung | morganfainberg, and then you break things | 03:22 |
| ayoung | lifeless, we already do this... | 03:22 |
| morganfainberg | ayoung, no differnt than having your partition fill up | 03:22 |
| morganfainberg | and breaking things | 03:22 |
| ayoung | we put the testdb file in keystone/tests/tmp now | 03:22 |
| ayoung | ah...I missed the tmp above, sorry | 03:23 |
| morganfainberg | ayoung, thats where it already is going | 03:23 |
| morganfainberg | wasn't going to move that | 03:23 |
| lifeless | ayoung: yes, but I'm just making sure I have the constraint correct before I make other comments :) | 03:23 |
| *** kgriffs_afk is now known as kgriffs | 03:23 | |
| *** alex_xu has joined #openstack-dev | 03:23 | |
| ayoung | "put all of the dbs in keystone/tests/db" should have been "put all of the dbs in keystone/tests/tmp/db" | 03:23 |
| lifeless | ayoung: out of interest,have you tried eatmydata vs a tmpfs ? | 03:23 |
| morganfainberg | ayoung, is there a reason not to do it in /test/tmp/PID/ | 03:23 |
| *** CaptTofu has quit IRC | 03:23 | |
| morganfainberg | ayoung, since each worker never knows if it's the last one | 03:24 |
| morganfainberg | w/o ps inspection | 03:24 |
| morganfainberg | *ick* | 03:24 |
| *** CaptTofu has joined #openstack-dev | 03:24 | |
| morganfainberg | using os.atexit i can cleanup the pid dir explicitly | 03:24 |
| morganfainberg | for that specific worker | 03:24 |
| morganfainberg | the way you're proposing perhaps not | 03:24 |
| morganfainberg | unless there is a reason to leave the temp data around | 03:24 |
| morganfainberg | whichcase... uhm... | 03:25 |
| morganfainberg | we might leave data lingering around | 03:25 |
| ayoung | nah, wipe out hte data | 03:26 |
| ayoung | the | 03:26 |
| morganfainberg | ayoung, ok | 03:26 |
| ayoung | if you want to inspect, you can always put a break in the middle of the test, then use the sqlite command line, then kill the process or whatever | 03:27 |
| ayoung | leaving it around just makes a mess | 03:27 |
| morganfainberg | ayoung, that was my thought | 03:27 |
| *** asselin_ has quit IRC | 03:28 | |
| *** haomaiwang has joined #openstack-dev | 03:28 | |
| *** CaptTofu has quit IRC | 03:28 | |
| *** harlowja is now known as harlowja_away | 03:31 | |
| *** renlt has joined #openstack-dev | 03:32 | |
| *** pixelb has quit IRC | 03:32 | |
| *** kgriffs is now known as kgriffs_afk | 03:33 | |
| *** doug_shelley66 has quit IRC | 03:36 | |
| *** haomaiwang has quit IRC | 03:38 | |
| *** arnaud__ has quit IRC | 03:38 | |
| *** arnaud has quit IRC | 03:38 | |
| *** haomaiwang has joined #openstack-dev | 03:40 | |
| *** bswartz has joined #openstack-dev | 03:43 | |
| *** novas0x2a|laptop has quit IRC | 03:44 | |
| *** gokrokve has joined #openstack-dev | 03:45 | |
| *** chandankumar has joined #openstack-dev | 03:45 | |
| *** xarses has joined #openstack-dev | 03:46 | |
| *** aswadrangnekar has joined #openstack-dev | 03:47 | |
| *** ramishra has quit IRC | 03:49 | |
| *** ramishra has joined #openstack-dev | 03:51 | |
| *** CaptTofu has joined #openstack-dev | 03:55 | |
| *** CaptTofu has quit IRC | 03:58 | |
| *** CaptTofu has joined #openstack-dev | 03:58 | |
| *** Edward-Zhang has quit IRC | 03:59 | |
| *** carl_baldwin has joined #openstack-dev | 03:59 | |
| *** haomaiwa_ has joined #openstack-dev | 04:00 | |
| *** aditirav has joined #openstack-dev | 04:02 | |
| *** aditirav has quit IRC | 04:03 | |
| *** haomaiwang has quit IRC | 04:03 | |
| *** stevemar has joined #openstack-dev | 04:03 | |
| *** aditirav has joined #openstack-dev | 04:03 | |
| stevemar | morganfainberg ping | 04:03 |
| morganfainberg | stevemar, pong | 04:03 |
| stevemar | morganfainberg could you check out: https://review.openstack.org/#/c/64349/ | 04:04 |
| stevemar | morganfainberg, ugh actully, no rush, we still have a ton of approved patches that need rebasing | 04:04 |
| morganfainberg | hehe | 04:04 |
| morganfainberg | ok | 04:04 |
| morganfainberg | i need to wait on jenkins anyway | 04:05 |
| morganfainberg | but it has +2/+2 | 04:05 |
| morganfainberg | just needs +A | 04:05 |
| stevemar | morganfainberg - ugh right, i forgot about that, i did that hours ago :( | 04:05 |
| morganfainberg | np | 04:05 |
| stevemar | actually, yesterday apparently | 04:05 |
| stevemar | morganfainberg, so question... if i submitted the last patch for this change set, but it was started by another author, can i approve it? does it go against the guidelines? | 04:06 |
| stevemar | i would think it does | 04:06 |
| stevemar | 'never approve your own work' | 04:06 |
| morganfainberg | stevemar, depends, is it a simple rebase? | 04:07 |
| morganfainberg | typically a trivial rebase is not an issue | 04:07 |
| stevemar | its alaready been 2x +2'ed | 04:07 |
| morganfainberg | if you've contributed code (vs. rebase) | 04:07 |
| morganfainberg | you shouldn't +2 | 04:07 |
| morganfainberg | or +A imo | 04:07 |
| stevemar | hmm, i did add code, not just rebase | 04:07 |
| stevemar | i getcha | 04:08 |
| morganfainberg | yep | 04:08 |
| *** aveiga has quit IRC | 04:08 | |
| stevemar | but if it was just a rebase, then it's okay | 04:08 |
| morganfainberg | yeah | 04:08 |
| *** tkay has quit IRC | 04:08 | |
| stevemar | i hear ya | 04:08 |
| morganfainberg | sometimes you need to get code in for some reason | 04:08 |
| stevemar | cool cool | 04:08 |
| morganfainberg | but it needs a rebase | 04:08 |
| morganfainberg | with a small core team (and to prevent being overloaded) | 04:09 |
| morganfainberg | if you rebase (wait for jenkins) then you can re-submit | 04:09 |
| morganfainberg | most of the time i don't notice the need for rebase (e.g. not merge conflict) until after jenkins -2s it | 04:09 |
| morganfainberg | even then, sometimes merge conflicts i forget to test for before approving | 04:10 |
| *** ramishra_ has joined #openstack-dev | 04:11 | |
| *** ramishra has quit IRC | 04:11 | |
| *** stevemar has quit IRC | 04:13 | |
| *** jp_at_hp has quit IRC | 04:13 | |
| *** markwash has quit IRC | 04:13 | |
| *** stevemar has joined #openstack-dev | 04:14 | |
| *** spzala has quit IRC | 04:15 | |
| *** csd has joined #openstack-dev | 04:15 | |
| *** mriedem has quit IRC | 04:17 | |
| *** stevemar has quit IRC | 04:17 | |
| *** stevemar has joined #openstack-dev | 04:18 | |
| *** pdevine has joined #openstack-dev | 04:18 | |
| *** stevemar has quit IRC | 04:20 | |
| *** stevemar has joined #openstack-dev | 04:22 | |
| *** lbragstad has quit IRC | 04:23 | |
| *** stevemar has quit IRC | 04:23 | |
| *** sumanthns has joined #openstack-dev | 04:24 | |
| *** kgriffs_afk is now known as kgriffs | 04:24 | |
| *** ramishra_ has quit IRC | 04:24 | |
| *** galstrom is now known as galstrom_zzz | 04:26 | |
| *** stevemar has joined #openstack-dev | 04:26 | |
| *** willingc has quit IRC | 04:27 | |
| *** stevemar has quit IRC | 04:27 | |
| *** stevemar has joined #openstack-dev | 04:29 | |
| ayoung | jamielennox, are we considering https://bugs.launchpad.net/keystone/+bug/1253895 fixed? | 04:30 |
| *** stevemar has quit IRC | 04:30 | |
| jamielennox | ayoung: i haven't done it | 04:30 |
| jamielennox | but it is a duplicate of one that is marked commited | 04:31 |
| ayoung | jamielennox, right | 04:31 |
| *** stevemar has joined #openstack-dev | 04:32 | |
| jamielennox | ayoung: from the review it looks fixed to me | 04:33 |
| *** carlp has quit IRC | 04:33 | |
| ayoung | jamielennox, yeah, and the RDO bug with it. Thanks | 04:33 |
| *** Edward-Zhang has joined #openstack-dev | 04:33 | |
| *** rushiagr has joined #openstack-dev | 04:33 | |
| *** kgriffs is now known as kgriffs_afk | 04:34 | |
| *** willingc has joined #openstack-dev | 04:34 | |
| *** Mandell has joined #openstack-dev | 04:35 | |
| *** stevemar has quit IRC | 04:36 | |
| *** stevemar has joined #openstack-dev | 04:38 | |
| *** willingc has quit IRC | 04:39 | |
| *** yamahata has joined #openstack-dev | 04:39 | |
| *** stevemar has quit IRC | 04:40 | |
| *** aeperezt has quit IRC | 04:41 | |
| *** aeperezt has joined #openstack-dev | 04:42 | |
| *** stevemar has joined #openstack-dev | 04:42 | |
| *** erkrnt1 has joined #openstack-dev | 04:44 | |
| *** stevemar has quit IRC | 04:44 | |
| *** stevemar has joined #openstack-dev | 04:46 | |
| *** erkrnt has quit IRC | 04:47 | |
| *** CaptTofu has quit IRC | 04:47 | |
| *** CaptTofu_ has joined #openstack-dev | 04:47 | |
| *** stevemar has quit IRC | 04:48 | |
| *** stevemar has joined #openstack-dev | 04:50 | |
| *** sarob has quit IRC | 04:50 | |
| *** sarob has joined #openstack-dev | 04:51 | |
| *** stevemar has quit IRC | 04:54 | |
| *** stevemar has joined #openstack-dev | 04:55 | |
| *** sarob has quit IRC | 04:56 | |
| *** JStoker has quit IRC | 04:56 | |
| *** stevemar has quit IRC | 04:58 | |
| *** jroovers has joined #openstack-dev | 04:59 | |
| *** stevemar has joined #openstack-dev | 04:59 | |
| *** amotoki has joined #openstack-dev | 05:00 | |
| *** teran has quit IRC | 05:00 | |
| *** JStoker has joined #openstack-dev | 05:01 | |
| *** carl_baldwin has quit IRC | 05:02 | |
| *** coolsvap has joined #openstack-dev | 05:02 | |
| *** achampion has quit IRC | 05:03 | |
| *** nshaikh has joined #openstack-dev | 05:04 | |
| *** stevemar has quit IRC | 05:04 | |
| *** buzztroll has quit IRC | 05:04 | |
| *** stevemar has joined #openstack-dev | 05:06 | |
| *** renlt has quit IRC | 05:06 | |
| *** anniec has joined #openstack-dev | 05:07 | |
| *** sthaha has quit IRC | 05:08 | |
| *** buzztroll has joined #openstack-dev | 05:08 | |
| *** tkay has joined #openstack-dev | 05:10 | |
| *** stevemar has quit IRC | 05:10 | |
| *** ramishra has joined #openstack-dev | 05:12 | |
| *** csd has quit IRC | 05:12 | |
| *** stevemar has joined #openstack-dev | 05:12 | |
| *** anniec has quit IRC | 05:12 | |
| *** anniec has joined #openstack-dev | 05:12 | |
| *** csd has joined #openstack-dev | 05:12 | |
| *** pmathews has joined #openstack-dev | 05:13 | |
| *** ramishra_ has joined #openstack-dev | 05:14 | |
| *** stevemar has quit IRC | 05:14 | |
| *** stevemar has joined #openstack-dev | 05:16 | |
| *** ramishra has quit IRC | 05:17 | |
| *** afazekas has joined #openstack-dev | 05:17 | |
| *** rkofman has joined #openstack-dev | 05:17 | |
| *** amcrn has joined #openstack-dev | 05:18 | |
| *** haomaiwang has joined #openstack-dev | 05:18 | |
| *** stevemar has quit IRC | 05:20 | |
| *** erkrnt1 has quit IRC | 05:21 | |
| *** stevemar has joined #openstack-dev | 05:21 | |
| *** haomaiwa_ has quit IRC | 05:22 | |
| *** carl_baldwin has joined #openstack-dev | 05:23 | |
| *** morazi has quit IRC | 05:24 | |
| *** kgriffs_afk is now known as kgriffs | 05:24 | |
| *** stevemar has quit IRC | 05:26 | |
| *** stevemar has joined #openstack-dev | 05:28 | |
| *** nati_ueno has joined #openstack-dev | 05:28 | |
| *** stevemar has quit IRC | 05:30 | |
| *** stevemar has joined #openstack-dev | 05:31 | |
| *** SergeyLukjanov has joined #openstack-dev | 05:34 | |
| *** stevemar has quit IRC | 05:34 | |
| *** amcrn has quit IRC | 05:34 | |
| *** kgriffs is now known as kgriffs_afk | 05:34 | |
| *** stevemar has joined #openstack-dev | 05:35 | |
| *** aeperezt has quit IRC | 05:36 | |
| *** stevemar has quit IRC | 05:36 | |
| *** ramishra_ has quit IRC | 05:37 | |
| *** stevemar has joined #openstack-dev | 05:38 | |
| *** stevemar has quit IRC | 05:39 | |
| *** SergeyLukjanov has quit IRC | 05:41 | |
| *** stevemar has joined #openstack-dev | 05:41 | |
| *** dim_ has quit IRC | 05:41 | |
| *** achampion has joined #openstack-dev | 05:42 | |
| morganfainberg | ayoung, jamielennox, 2212 (+2173) tests in 172.735s | 05:42 |
| morganfainberg | woo:) | 05:42 |
| morganfainberg | that is parallel | 05:43 |
| jamielennox | morganfainberg: nice | 05:43 |
| jamielennox | morganfainberg: that will be great to have | 05:44 |
| *** galstrom_zzz is now known as galstrom | 05:44 | |
| morganfainberg | running a base-line w/o parallel now | 05:44 |
| morganfainberg | probably ~400s | 05:44 |
| jamielennox | do you have the tmpdir as tmpfs? | 05:45 |
| morganfainberg | this is 4 workers | 05:45 |
| *** buzztroll has quit IRC | 05:45 | |
| morganfainberg | nope | 05:45 |
| morganfainberg | standard VFS in my vm | 05:45 |
| jamielennox | that is impressive then | 05:45 |
| morganfainberg | so, keystone/tests/tmp as tmpfs would likely make it faster | 05:45 |
| morganfainberg | i'll mount that up and do another test as the third run | 05:45 |
| jamielennox | morganfainberg: i don't even try and run them without that anymore | 05:45 |
| jamielennox | morganfainberg: i think occasionally that we should put that hack into the gate... | 05:45 |
| *** stevemar has quit IRC | 05:45 | |
| morganfainberg | it's not too onerous of changes, though i needed to include a fix for "unsetting overrides" | 05:46 |
| morganfainberg | :P | 05:46 |
| morganfainberg | and testing w/ non-sqlite backends requires a bit more manual work now =/ | 05:46 |
| *** pmathews has quit IRC | 05:46 | |
| morganfainberg | since nonsqlite still can't be parallel | 05:46 |
| morganfainberg | but, that _should_ get fixed in a subsequent patch. | 05:47 |
| morganfainberg | and no lingering DB files or configs are left on the filesystem | 05:48 |
| morganfainberg | :) | 05:48 |
| morganfainberg | auto-cleans up when it's done | 05:49 |
| morganfainberg | *taps foot* | 05:49 |
| morganfainberg | hurry up tests! | 05:49 |
| morganfainberg | jamielennox, and the only tests i had to group were the keystoneclient ones (saves multiple checkouts) | 05:50 |
| *** achampion has quit IRC | 05:50 | |
| morganfainberg | ayoung, jamielennox, not parallel: Ran 2212 tests in 433.607s (+260.902s) | 05:51 |
| morganfainberg | and now parallel w/ tmpfs | 05:51 |
| *** buzztroll has joined #openstack-dev | 05:52 | |
| morganfainberg | whoa. | 05:52 |
| morganfainberg | ah, cert tests failed somehow | 05:52 |
| morganfainberg | huh | 05:53 |
| morganfainberg | oh, those prob. need to be grouped | 05:53 |
| *** rdas has joined #openstack-dev | 05:56 | |
| morganfainberg | and with tmpfs: | 05:56 |
| morganfainberg | ayoung, jamielennox Ran 2212 (-1) tests in 103.814s | 05:57 |
| morganfainberg | i think that is quite reasonable | 05:57 |
| *** radix_ has joined #openstack-dev | 05:57 | |
| jamielennox | i think we've been dreaming of < 2min | 05:57 |
| *** pmathews has joined #openstack-dev | 05:59 | |
| *** pmathews has quit IRC | 06:04 | |
| *** pmathews has joined #openstack-dev | 06:04 | |
| *** galstrom is now known as galstrom_zzz | 06:05 | |
| *** otherwiseguy has quit IRC | 06:05 | |
| morganfainberg | jamielennox, https://review.openstack.org/#/c/65870/ | 06:08 |
| jamielennox | morganfainberg: is it possible to do it with a tempfile.mktmpdir or whatever it's called for clenaup? | 06:09 |
| morganfainberg | jamielennox, possibly | 06:09 |
| morganfainberg | but pid seemed just as functional. | 06:09 |
| jamielennox | not sure exactly how that works but it saves the atexit call | 06:09 |
| morganfainberg | eh | 06:09 |
| morganfainberg | no | 06:09 |
| morganfainberg | still need atexit | 06:09 |
| *** pmathews has quit IRC | 06:09 | |
| morganfainberg | the directory needs to exist beyond the import of test.core | 06:10 |
| morganfainberg | and you don't ever know what the last item (from within test.core) is going to be. | 06:10 |
| morganfainberg | i think | 06:10 |
| *** pmathews has joined #openstack-dev | 06:10 | |
| morganfainberg | it's not meant to be cleaned up between runs, but at the exit of the worker | 06:10 |
| morganfainberg | i _might_ be wrong in my assertion and open to trying alternatives | 06:11 |
| jamielennox | sure if you have one big dir | 06:11 |
| jamielennox | but if your using temp dirs you could setup and teardown | 06:11 |
| morganfainberg | per worker we have some state we want to keep. | 06:11 |
| morganfainberg | the pristinedb | 06:11 |
| morganfainberg | etc | 06:11 |
| morganfainberg | we don't want to re-migrate each time. | 06:11 |
| jamielennox | that would just live outside of the folders | 06:11 |
| jamielennox | pristine isn't cleaned up between runs as it is | 06:11 |
| morganfainberg | doesn't work like that | 06:12 |
| morganfainberg | we create the pristine db on the first invocation | 06:12 |
| morganfainberg | so you're already within a worker context | 06:12 |
| morganfainberg | short of locking and waiting for the first one to win, | 06:12 |
| morganfainberg | it's not doable | 06:12 |
| *** stevemar has joined #openstack-dev | 06:12 | |
| morganfainberg | much less work to let each worker just have it's own pristine db for now | 06:12 |
| jamielennox | ok | 06:12 |
| morganfainberg | stevemar, https://review.openstack.org/#/c/65870/ parallel workers for tests, able to get < 2min tests w/ 4 workers and tmpfs | 06:13 |
| morganfainberg | jamielennox, i expect this will change when we go to using testresource | 06:13 |
| morganfainberg | and a more heavy handed cleanup might be doable | 06:13 |
| morganfainberg | but this is the first step along the way | 06:13 |
| *** tkay has quit IRC | 06:13 | |
| stevemar | hmmmmmmmmm | 06:13 |
| *** neeti has joined #openstack-dev | 06:13 | |
| morganfainberg | ugh typo in commit *grr* | 06:14 |
| *** bashok has joined #openstack-dev | 06:14 | |
| *** pmathews has quit IRC | 06:15 | |
| morganfainberg | i really hope those changes are all py26 compat | 06:15 |
| stevemar | morganfainberg - will this affect debugging (pdb) ? | 06:15 |
| morganfainberg | stevemar, likely you will want to turn off parallel workers for that | 06:16 |
| morganfainberg | is my guess | 06:16 |
| stevemar | morganfainberg - is it on by default? (still reviewing)? | 06:16 |
| morganfainberg | parallel workers, yes | 06:16 |
| *** dstanek has joined #openstack-dev | 06:16 | |
| morganfainberg | that is controlled in .testr.conf | 06:17 |
| morganfainberg | afaik | 06:17 |
| morganfainberg | i am not sure if an env var would suffice, if so, it makes it a bit easier | 06:17 |
| *** stevemar has quit IRC | 06:18 | |
| *** sushils has joined #openstack-dev | 06:19 | |
| morganfainberg | ugh. i left code in there :( | 06:20 |
| morganfainberg | grr, missed a couple things *sigh* ah well | 06:20 |
| *** stevemar has joined #openstack-dev | 06:20 | |
| *** markwash has joined #openstack-dev | 06:21 | |
| morganfainberg | anyway | 06:21 |
| morganfainberg | g'night | 06:21 |
| stevemar | morganfainberg gnight | 06:21 |
| morganfainberg | stevemar, had to upload another patchset, forgot to pull out some unneeded sutff | 06:21 |
| morganfainberg | but it should be good at this point until i get feedback/need to rebase (RACE TO REBASE!) | 06:22 |
| *** buzztroll has quit IRC | 06:22 | |
| *** HenryG has quit IRC | 06:22 | |
| *** Alexei_987 has joined #openstack-dev | 06:23 | |
| *** kgriffs_afk is now known as kgriffs | 06:25 | |
| *** stevemar has quit IRC | 06:25 | |
| *** stevemar has joined #openstack-dev | 06:26 | |
| jamielennox | damn it, i've hacked this client up with so much backwards compatability i can't produce a failing test for something - something keeps resetting variables to what i apparently mean | 06:27 |
| *** stevemar has quit IRC | 06:29 | |
| *** anniec_ has joined #openstack-dev | 06:30 | |
| *** ramishra has joined #openstack-dev | 06:30 | |
| morganfainberg | jamielennox, LOL | 06:30 |
| *** stevemar has joined #openstack-dev | 06:30 | |
| morganfainberg | jamielennox, thats actually kindof funny | 06:30 |
| jamielennox | and yet annoying | 06:31 |
| *** stevemar2 has joined #openstack-dev | 06:32 | |
| *** stevemar has quit IRC | 06:32 | |
| *** anniec has quit IRC | 06:32 | |
| *** anniec_ is now known as anniec | 06:32 | |
| *** aditirav has quit IRC | 06:32 | |
| *** pmathews has joined #openstack-dev | 06:33 | |
| *** aditirav has joined #openstack-dev | 06:33 | |
| *** rods1 has quit IRC | 06:33 | |
| *** gyee_ has quit IRC | 06:34 | |
| jamielennox | yep, found it a backwards compat hack that hard sets the right region_name into token data then the client doesn't have to do it's own region processing | 06:35 |
| *** stevemar2 has quit IRC | 06:35 | |
| jamielennox | i'm not sure if that's genius or it's time to scrap the whole bloody code base | 06:35 |
| *** kgriffs is now known as kgriffs_afk | 06:36 | |
| *** buzztroll has joined #openstack-dev | 06:36 | |
| *** amcrn has joined #openstack-dev | 06:37 | |
| *** stevemar has joined #openstack-dev | 06:37 | |
| *** neoXsys has joined #openstack-dev | 06:37 | |
| *** carl_baldwin has quit IRC | 06:38 | |
| *** carl_baldwin has joined #openstack-dev | 06:38 | |
| *** rushiagr is now known as rushiagr_away | 06:39 | |
| *** vartom111111117 has joined #openstack-dev | 06:39 | |
| *** aditirav_ has joined #openstack-dev | 06:40 | |
| *** dkuffner has joined #openstack-dev | 06:41 | |
| *** stevemar has quit IRC | 06:41 | |
| *** HenryG has joined #openstack-dev | 06:41 | |
| *** carl_baldwin has quit IRC | 06:43 | |
| *** aditirav has quit IRC | 06:43 | |
| *** aditirav_ is now known as aditirav | 06:43 | |
| *** sungju has quit IRC | 06:43 | |
| *** vartom111111117 has quit IRC | 06:44 | |
| *** vartom111111117 has joined #openstack-dev | 06:44 | |
| *** rushiagr_away is now known as rushiagr | 06:44 | |
| *** stevemar has joined #openstack-dev | 06:45 | |
| *** achampion has joined #openstack-dev | 06:46 | |
| *** stevemar has quit IRC | 06:46 | |
| *** rkofman has left #openstack-dev | 06:48 | |
| *** stevemar has joined #openstack-dev | 06:49 | |
| *** pmathews has quit IRC | 06:50 | |
| jamielennox | morganfainberg: looks good | 06:51 |
| *** achampion has quit IRC | 06:51 | |
| *** neelashah has quit IRC | 06:53 | |
| *** bdpayne has joined #openstack-dev | 06:54 | |
| *** jcoufal has joined #openstack-dev | 06:54 | |
| stevemar | jamielennox, nice job on getting the kds stuff in :) | 06:58 |
| *** alex_klimov has joined #openstack-dev | 06:59 | |
| *** willingc has joined #openstack-dev | 06:59 | |
| *** Alexei_987 has quit IRC | 06:59 | |
| jamielennox | stevemar: heh, that's the first patch - but thanks | 07:00 |
| jamielennox | good to see some progress anyway | 07:00 |
| stevemar | jamielennox, it's a start, good chunk of code | 07:00 |
| jamielennox | stevemar: yea, it's a lot of the foundational stuff that can always be improved on later but doesn't have much logic to it | 07:02 |
| *** willingc has quit IRC | 07:04 | |
| *** aditirav_ has joined #openstack-dev | 07:08 | |
| *** jprovazn has joined #openstack-dev | 07:09 | |
| *** Drankis has joined #openstack-dev | 07:10 | |
| *** dkuffner has quit IRC | 07:11 | |
| *** aditirav_ has quit IRC | 07:11 | |
| *** aditirav has quit IRC | 07:11 | |
| *** aditirav_ has joined #openstack-dev | 07:11 | |
| *** yolanda has joined #openstack-dev | 07:13 | |
| *** jamielennox is now known as jamielennox|away | 07:13 | |
| *** yamahata has quit IRC | 07:14 | |
| *** gokrokve has quit IRC | 07:16 | |
| *** gokrokve has joined #openstack-dev | 07:17 | |
| *** renlt has joined #openstack-dev | 07:18 | |
| *** sushils has quit IRC | 07:21 | |
| *** gokrokve has quit IRC | 07:21 | |
| *** csd has quit IRC | 07:21 | |
| *** ramishra has quit IRC | 07:25 | |
| *** renlt has quit IRC | 07:25 | |
| *** renlt has joined #openstack-dev | 07:26 | |
| *** kgriffs_afk is now known as kgriffs | 07:26 | |
| *** belmoreira has joined #openstack-dev | 07:27 | |
| *** belmoreira has quit IRC | 07:28 | |
| *** mrunge has joined #openstack-dev | 07:29 | |
| *** belmoreira has joined #openstack-dev | 07:29 | |
| *** renlt has quit IRC | 07:32 | |
| *** alex_xu has quit IRC | 07:32 | |
| *** renlt has joined #openstack-dev | 07:32 | |
| *** willingc has joined #openstack-dev | 07:35 | |
| *** kgriffs is now known as kgriffs_afk | 07:36 | |
| *** ifarkas has joined #openstack-dev | 07:37 | |
| *** ifarkas_ has joined #openstack-dev | 07:37 | |
| *** xgsa has joined #openstack-dev | 07:38 | |
| *** rushiagr is now known as rushiagr_away | 07:38 | |
| *** doug_shelley66 has joined #openstack-dev | 07:43 | |
| *** rhinojosa has joined #openstack-dev | 07:43 | |
| *** alex_xu has joined #openstack-dev | 07:45 | |
| *** stevemar has quit IRC | 07:45 | |
| *** rohitk has joined #openstack-dev | 07:46 | |
| *** fbo_away is now known as fbo | 07:46 | |
| *** jasondotstar has joined #openstack-dev | 07:47 | |
| *** achampion has joined #openstack-dev | 07:47 | |
| *** bdpayne has quit IRC | 07:47 | |
| *** gokrokve has joined #openstack-dev | 07:47 | |
| *** e0ne has joined #openstack-dev | 07:47 | |
| *** gokrokve_ has joined #openstack-dev | 07:49 | |
| *** flaper87|afk is now known as flaper87 | 07:51 | |
| *** gokrokve has quit IRC | 07:52 | |
| *** achampion has quit IRC | 07:52 | |
| *** gokrokve_ has quit IRC | 07:53 | |
| *** dstanek has quit IRC | 07:54 | |
| *** zaitcev has quit IRC | 07:55 | |
| *** dkuffner has joined #openstack-dev | 07:56 | |
| *** Alexei_987 has joined #openstack-dev | 07:57 | |
| *** pmathews has joined #openstack-dev | 07:57 | |
| *** rhinojosa has left #openstack-dev | 08:02 | |
| *** MaxV has joined #openstack-dev | 08:03 | |
| *** denis_makogon has joined #openstack-dev | 08:04 | |
| *** willingc has quit IRC | 08:08 | |
| *** ilyashakhat has joined #openstack-dev | 08:09 | |
| *** pdevine has quit IRC | 08:10 | |
| *** jtomasek has joined #openstack-dev | 08:12 | |
| *** xga has joined #openstack-dev | 08:12 | |
| *** sc68cal has quit IRC | 08:14 | |
| *** sc68cal has joined #openstack-dev | 08:15 | |
| *** mmagr has joined #openstack-dev | 08:15 | |
| *** alexpilotti has quit IRC | 08:17 | |
| *** faramir1 has joined #openstack-dev | 08:19 | |
| *** ljjjustin has quit IRC | 08:21 | |
| *** rushiagr_away is now known as rushiagr | 08:23 | |
| *** mancdaz_away is now known as mancdaz | 08:23 | |
| *** e0ne has quit IRC | 08:23 | |
| *** e0ne has joined #openstack-dev | 08:24 | |
| *** dstanek has joined #openstack-dev | 08:25 | |
| *** xga has quit IRC | 08:25 | |
| *** xga has joined #openstack-dev | 08:25 | |
| *** xchu has quit IRC | 08:27 | |
| *** kgriffs_afk is now known as kgriffs | 08:27 | |
| *** ifarkas_ has quit IRC | 08:28 | |
| *** yamahata has joined #openstack-dev | 08:29 | |
| *** persia__ is now known as persia | 08:30 | |
| *** persia has quit IRC | 08:31 | |
| *** persia has joined #openstack-dev | 08:31 | |
| *** alex_xu has quit IRC | 08:32 | |
| *** pmathews has quit IRC | 08:32 | |
| *** alex_xu has joined #openstack-dev | 08:36 | |
| *** e0ne_ has joined #openstack-dev | 08:37 | |
| *** e0ne has quit IRC | 08:37 | |
| *** kgriffs is now known as kgriffs_afk | 08:37 | |
| *** toabctl_ has quit IRC | 08:37 | |
| *** nati_ueno has quit IRC | 08:39 | |
| *** faramir1 has quit IRC | 08:41 | |
| *** romcheg has joined #openstack-dev | 08:41 | |
| *** toabctl has joined #openstack-dev | 08:41 | |
| *** toabctl has joined #openstack-dev | 08:41 | |
| *** corXi has joined #openstack-dev | 08:43 | |
| *** chandankumar_ has joined #openstack-dev | 08:48 | |
| *** achampion has joined #openstack-dev | 08:48 | |
| *** CaptTofu_ has quit IRC | 08:48 | |
| *** CaptTofu has joined #openstack-dev | 08:49 | |
| *** sushils has joined #openstack-dev | 08:49 | |
| *** achampion has quit IRC | 08:53 | |
| *** nmagnezi has joined #openstack-dev | 08:54 | |
| *** xjiujiu has joined #openstack-dev | 08:55 | |
| *** chandankumar_ has quit IRC | 08:59 | |
| *** matiu has quit IRC | 08:59 | |
| *** safchain has joined #openstack-dev | 09:01 | |
| *** teran has joined #openstack-dev | 09:01 | |
| *** giulivo has joined #openstack-dev | 09:01 | |
| *** pixelb has joined #openstack-dev | 09:01 | |
| *** florentflament has joined #openstack-dev | 09:02 | |
| *** iartarisi has joined #openstack-dev | 09:02 | |
| *** antigluk_ has joined #openstack-dev | 09:05 | |
| *** jpich has joined #openstack-dev | 09:05 | |
| *** derekh has joined #openstack-dev | 09:06 | |
| *** jistr has joined #openstack-dev | 09:06 | |
| *** alex_xu has quit IRC | 09:09 | |
| *** julienvey has joined #openstack-dev | 09:11 | |
| *** matrohon has quit IRC | 09:11 | |
| *** julienvey has quit IRC | 09:11 | |
| *** julienvey has joined #openstack-dev | 09:11 | |
| *** ygbo has joined #openstack-dev | 09:12 | |
| *** anniec has left #openstack-dev | 09:13 | |
| *** bogdando has joined #openstack-dev | 09:13 | |
| *** eglynn has joined #openstack-dev | 09:14 | |
| *** marekd|away is now known as marekd | 09:14 | |
| *** rushiagr is now known as rushiagr_away | 09:18 | |
| *** yeylon_ has quit IRC | 09:19 | |
| *** gilliard has quit IRC | 09:19 | |
| *** gilliard has joined #openstack-dev | 09:20 | |
| *** yassine has joined #openstack-dev | 09:22 | |
| *** xga_ has joined #openstack-dev | 09:22 | |
| *** xga has quit IRC | 09:22 | |
| *** xuhanp has quit IRC | 09:24 | |
| *** aditirav_ has quit IRC | 09:25 | |
| *** gszasz has joined #openstack-dev | 09:25 | |
| *** aditirav has joined #openstack-dev | 09:25 | |
| *** sahid has joined #openstack-dev | 09:26 | |
| *** xga_ has quit IRC | 09:27 | |
| *** xga_ has joined #openstack-dev | 09:27 | |
| *** kgriffs_afk is now known as kgriffs | 09:28 | |
| *** yassine has quit IRC | 09:29 | |
| *** matrohon has joined #openstack-dev | 09:29 | |
| *** matrohon_ has joined #openstack-dev | 09:29 | |
| *** matrohon_ has left #openstack-dev | 09:29 | |
| *** matrohon has quit IRC | 09:30 | |
| *** rushiagr_away is now known as rushiagr | 09:30 | |
| *** matrohon has joined #openstack-dev | 09:30 | |
| *** matrohon has quit IRC | 09:31 | |
| *** matrohon has joined #openstack-dev | 09:31 | |
| *** markmc has joined #openstack-dev | 09:32 | |
| *** mattymo has joined #openstack-dev | 09:32 | |
| *** _ruhe is now known as ruhe | 09:33 | |
| flaper87 | ttx: ping | 09:33 |
| *** blues-man has joined #openstack-dev | 09:34 | |
| flaper87 | ttx: I just updated https://wiki.openstack.org/wiki/StableBranch#Overview because it didn't mention havana. Could you double check when you get a chance? | 09:34 |
| *** yeylon_ has joined #openstack-dev | 09:36 | |
| ttx | flaper87: checking | 09:36 |
| *** teran has quit IRC | 09:36 | |
| flaper87 | ttx: we should probably not mention releases in that overview and find a better way to list current maintained releases | 09:36 |
| flaper87 | ttx: unless you already have one and I'm not aware of it, which is more than probable | 09:37 |
| flaper87 | :D | 09:37 |
| *** teran has joined #openstack-dev | 09:37 | |
| ttx | flaper87: fwiw the reference page lives at https://wiki.openstack.org/wiki/Releases | 09:37 |
| *** teran has quit IRC | 09:37 | |
| ttx | flaper87: you could redirect to that page to avoid duplication | 09:37 |
| flaper87 | ttx: yeah, that one I know of (phew) :D | 09:37 |
| flaper87 | ttx: yeah, I'll do that, sounds better | 09:37 |
| flaper87 | thanks | 09:37 |
| *** kgriffs is now known as kgriffs_afk | 09:38 | |
| *** teran has joined #openstack-dev | 09:38 | |
| *** nmagnezi has quit IRC | 09:38 | |
| tristanC | Hi! ttx, I also have a question... what is missing on https://bugs.launchpad.net/ossa/+bug/1174660 ? | 09:38 |
| *** Edward-Zhang has quit IRC | 09:40 | |
| *** chandankumar_ has joined #openstack-dev | 09:40 | |
| *** amcrn has quit IRC | 09:41 | |
| *** teran has quit IRC | 09:43 | |
| *** mkollaro has joined #openstack-dev | 09:45 | |
| *** jp_at_hp has joined #openstack-dev | 09:48 | |
| *** gokrokve has joined #openstack-dev | 09:48 | |
| *** denis_makogon has quit IRC | 09:48 | |
| *** achampion has joined #openstack-dev | 09:49 | |
| *** nosnos has quit IRC | 09:49 | |
| *** sahid has quit IRC | 09:49 | |
| *** sahid has joined #openstack-dev | 09:49 | |
| *** chandankumar_ has quit IRC | 09:52 | |
| *** gokrokve has quit IRC | 09:53 | |
| *** bogdando has quit IRC | 09:54 | |
| *** achampion has quit IRC | 09:54 | |
| *** yaguang has quit IRC | 09:54 | |
| ttx | tristanC: we never issued "retroactive" advisories and this one is a bit too borderline to convince us to start issuing them | 09:55 |
| *** xga has joined #openstack-dev | 09:55 | |
| ttx | tristanC: i.e. it's almost a perf issue rather than a DoS avenue | 09:55 |
| *** xga_ has quit IRC | 09:55 | |
| ttx | we kinda hoped people with stronger opinions would weigh in, but they didn't. And now it would be very retroactive | 09:56 |
| ttx | I'll discuss with VMT members and we'll make a final call | 09:56 |
| tristanC | ttx: agreed, it's just that this one is quite old and still unassign. | 09:57 |
| *** CaptTofu has quit IRC | 09:57 | |
| ttx | tristanC: yes, we just need to decide if that case should be covered by our advisory policy, since it's a bit of a corner case (old perf fix that may block a DoS vector) | 09:58 |
| ttx | tristanC: and admittedly we let that one linger while we addressed more pressing issues | 09:59 |
| ttx | will make sure we have a way forward | 10:00 |
| *** buzztroll has quit IRC | 10:00 | |
| tristanC | ttx: sure, no worry. It's more a matter of housekeeping afaik :) Thanks anyway | 10:00 |
| *** jtomasek has quit IRC | 10:02 | |
| *** JordanP has joined #openstack-dev | 10:02 | |
| *** yamahata has quit IRC | 10:05 | |
| *** ppetit has quit IRC | 10:06 | |
| *** ppetit has joined #openstack-dev | 10:06 | |
| *** mikeoutland has joined #openstack-dev | 10:09 | |
| *** SergeyLukjanov has joined #openstack-dev | 10:10 | |
| *** athomas has joined #openstack-dev | 10:10 | |
| *** jtomasek has joined #openstack-dev | 10:10 | |
| *** sahid has quit IRC | 10:12 | |
| *** sahid has joined #openstack-dev | 10:14 | |
| *** simonluo has joined #openstack-dev | 10:15 | |
| *** Longgeek has joined #openstack-dev | 10:19 | |
| *** renlt has quit IRC | 10:20 | |
| *** UKn0Me has joined #openstack-dev | 10:21 | |
| *** Longgeek has quit IRC | 10:21 | |
| *** gszasz has quit IRC | 10:21 | |
| *** mkollaro has quit IRC | 10:22 | |
| *** mkollaro has joined #openstack-dev | 10:23 | |
| *** Longgeek has joined #openstack-dev | 10:23 | |
| *** Longgeek has joined #openstack-dev | 10:23 | |
| *** ruhe is now known as _ruhe | 10:26 | |
| *** jorisroovers has joined #openstack-dev | 10:28 | |
| *** kgriffs_afk is now known as kgriffs | 10:29 | |
| *** jroovers has quit IRC | 10:30 | |
| *** michchap_ has joined #openstack-dev | 10:31 | |
| *** mikeoutland has quit IRC | 10:31 | |
| *** martyntaylor has joined #openstack-dev | 10:32 | |
| *** michchap has quit IRC | 10:32 | |
| *** jorisroovers has quit IRC | 10:32 | |
| *** matrohon_ has joined #openstack-dev | 10:34 | |
| *** teran has joined #openstack-dev | 10:35 | |
| *** chandankumar_ has joined #openstack-dev | 10:37 | |
| *** andreykurilin has joined #openstack-dev | 10:38 | |
| *** kgriffs is now known as kgriffs_afk | 10:38 | |
| *** vills_ has joined #openstack-dev | 10:40 | |
| *** vills_ has quit IRC | 10:43 | |
| *** gongysh has quit IRC | 10:44 | |
| *** bogdando has joined #openstack-dev | 10:44 | |
| *** jruzicka has joined #openstack-dev | 10:46 | |
| *** amuller has joined #openstack-dev | 10:46 | |
| *** gokrokve has joined #openstack-dev | 10:48 | |
| *** martyntaylor has quit IRC | 10:48 | |
| *** achampion has joined #openstack-dev | 10:49 | |
| *** gokrokve has quit IRC | 10:53 | |
| *** athomas has quit IRC | 10:53 | |
| *** achampion has quit IRC | 10:54 | |
| *** simonluo_ has joined #openstack-dev | 10:58 | |
| *** akrivoka has joined #openstack-dev | 10:59 | |
| *** _ruhe is now known as ruhe | 11:00 | |
| *** athomas has joined #openstack-dev | 11:00 | |
| *** rods1 has joined #openstack-dev | 11:01 | |
| *** simonluo has quit IRC | 11:02 | |
| *** paragan has quit IRC | 11:03 | |
| *** ruhe is now known as ruhe_away | 11:04 | |
| *** ruhe_away is now known as ruhe | 11:04 | |
| *** dstanek has quit IRC | 11:05 | |
| *** fbo is now known as fbo_away | 11:07 | |
| *** asalkeld has left #openstack-dev | 11:07 | |
| *** asalkeld has joined #openstack-dev | 11:08 | |
| *** blues-man has quit IRC | 11:10 | |
| *** buzztroll has joined #openstack-dev | 11:10 | |
| *** ijw has joined #openstack-dev | 11:12 | |
| *** exed_ has joined #openstack-dev | 11:14 | |
| *** johnthetubaguy has joined #openstack-dev | 11:14 | |
| *** buzztroll has quit IRC | 11:15 | |
| *** Longgeek has quit IRC | 11:16 | |
| *** chandankumar_ has quit IRC | 11:18 | |
| *** rfolco has joined #openstack-dev | 11:19 | |
| *** blues-man has joined #openstack-dev | 11:19 | |
| *** asalkeld has left #openstack-dev | 11:23 | |
| *** asalkeld has joined #openstack-dev | 11:23 | |
| *** simonluo_ has quit IRC | 11:23 | |
| flaper87 | ttx: I just noticed jd__ had already changed the thread subject. Damn, my email client failed me. T_T | 11:24 |
| jd__ | hehe | 11:25 |
| *** andreaf has quit IRC | 11:26 | |
| *** andreaf has joined #openstack-dev | 11:26 | |
| *** kgriffs_afk is now known as kgriffs | 11:29 | |
| *** ruhe is now known as _ruhe | 11:33 | |
| *** yamahata has joined #openstack-dev | 11:34 | |
| *** sushils has quit IRC | 11:37 | |
| *** pcm_ has joined #openstack-dev | 11:38 | |
| *** amuller has quit IRC | 11:39 | |
| *** pcm_ has quit IRC | 11:39 | |
| *** kgriffs is now known as kgriffs_afk | 11:40 | |
| *** pcm_ has joined #openstack-dev | 11:40 | |
| *** asalkeld has left #openstack-dev | 11:41 | |
| *** neeti has quit IRC | 11:42 | |
| *** safchain has quit IRC | 11:42 | |
| *** neeti has joined #openstack-dev | 11:42 | |
| *** amuller has joined #openstack-dev | 11:43 | |
| *** _ruhe is now known as ruhe | 11:45 | |
| *** asalkeld has joined #openstack-dev | 11:45 | |
| *** jasondotstar has quit IRC | 11:45 | |
| *** sumanthns has quit IRC | 11:46 | |
| *** rods1 has quit IRC | 11:46 | |
| *** Sumeniac has quit IRC | 11:46 | |
| *** Sumeniac has joined #openstack-dev | 11:47 | |
| *** Longgeek has joined #openstack-dev | 11:47 | |
| *** ymr1 has joined #openstack-dev | 11:47 | |
| *** ymr1 has quit IRC | 11:48 | |
| *** gokrokve has joined #openstack-dev | 11:48 | |
| *** ymr1 has joined #openstack-dev | 11:50 | |
| *** gokrokve_ has joined #openstack-dev | 11:50 | |
| *** hartsocks has joined #openstack-dev | 11:50 | |
| *** achampion has joined #openstack-dev | 11:50 | |
| *** gokrokve has quit IRC | 11:53 | |
| *** gokrokve_ has quit IRC | 11:55 | |
| *** Longgeek has quit IRC | 11:55 | |
| *** achampion has quit IRC | 11:56 | |
| *** sushils has joined #openstack-dev | 11:56 | |
| *** yamahata has quit IRC | 12:00 | |
| *** BobBallAway is now known as BobBall | 12:01 | |
| *** Sumeniac has quit IRC | 12:03 | |
| *** zasimov has joined #openstack-dev | 12:03 | |
| giulivo | ping lifeless, I noticed assertIn from testtools does not allow for any optional message while I'd like to use it in tempest for a few tests, would it make sense to you if I add that to testtools? | 12:04 |
| *** hoodow has quit IRC | 12:05 | |
| *** danpb has joined #openstack-dev | 12:06 | |
| *** chandankumar_ has joined #openstack-dev | 12:07 | |
| *** ndipanov has joined #openstack-dev | 12:08 | |
| *** dstanek has joined #openstack-dev | 12:11 | |
| *** chandankumar_ has quit IRC | 12:12 | |
| *** mjfork has quit IRC | 12:13 | |
| *** erkules_ is now known as erkules | 12:13 | |
| *** gszasz has joined #openstack-dev | 12:19 | |
| *** MaxV has quit IRC | 12:19 | |
| *** MaxV has joined #openstack-dev | 12:21 | |
| *** FunnyLookinHat has joined #openstack-dev | 12:22 | |
| *** Sumeniac has joined #openstack-dev | 12:24 | |
| *** glenng has quit IRC | 12:27 | |
| *** amuller has quit IRC | 12:28 | |
| *** tdruiva has joined #openstack-dev | 12:29 | |
| *** kgriffs_afk is now known as kgriffs | 12:30 | |
| *** tdruiva has quit IRC | 12:32 | |
| *** dstanek has quit IRC | 12:33 | |
| *** tdruiva has joined #openstack-dev | 12:33 | |
| *** rods` has joined #openstack-dev | 12:36 | |
| *** teran_ has joined #openstack-dev | 12:37 | |
| *** aditirav has quit IRC | 12:37 | |
| *** rods has quit IRC | 12:38 | |
| *** teran__ has joined #openstack-dev | 12:39 | |
| *** teran has quit IRC | 12:39 | |
| *** rushiagr is now known as rushiagr_away | 12:39 | |
| *** kgriffs is now known as kgriffs_afk | 12:40 | |
| *** bauzas has quit IRC | 12:43 | |
| *** teran_ has quit IRC | 12:43 | |
| *** neoXsys has quit IRC | 12:44 | |
| *** Sumeniac has quit IRC | 12:46 | |
| *** coolsvap has quit IRC | 12:46 | |
| *** CaptTofu has joined #openstack-dev | 12:46 | |
| *** Sumeniac has joined #openstack-dev | 12:47 | |
| *** gokrokve has joined #openstack-dev | 12:48 | |
| *** aburaschi has joined #openstack-dev | 12:48 | |
| *** jroovers has joined #openstack-dev | 12:49 | |
| *** rushiagr_away is now known as rushiagr | 12:49 | |
| *** GheRivero is now known as GheRivero_afk | 12:49 | |
| *** safchain has joined #openstack-dev | 12:50 | |
| *** safchain has quit IRC | 12:50 | |
| *** safchain has joined #openstack-dev | 12:50 | |
| *** sgordon has joined #openstack-dev | 12:51 | |
| *** achampion has joined #openstack-dev | 12:51 | |
| *** Sumeniac has quit IRC | 12:51 | |
| *** Sumeniac has joined #openstack-dev | 12:52 | |
| *** gokrokve has quit IRC | 12:53 | |
| *** Longgeek has joined #openstack-dev | 12:53 | |
| *** rushiagr has quit IRC | 12:55 | |
| *** achampion has quit IRC | 12:56 | |
| *** blues-man has quit IRC | 12:56 | |
| *** fbo_away is now known as fbo | 12:57 | |
| *** Longgeek has quit IRC | 12:59 | |
| *** feleouet has quit IRC | 13:02 | |
| *** haomaiwang has quit IRC | 13:02 | |
| *** haomaiwang has joined #openstack-dev | 13:03 | |
| *** SergeyLukjanov is now known as _SergeyLukjanov | 13:05 | |
| *** rohitk has quit IRC | 13:05 | |
| *** SergeyLukjanov has joined #openstack-dev | 13:08 | |
| *** rcj has joined #openstack-dev | 13:10 | |
| *** fbo is now known as fbo_away | 13:15 | |
| *** haomaiwa_ has joined #openstack-dev | 13:16 | |
| *** tdruiva has quit IRC | 13:17 | |
| *** tdruiva has joined #openstack-dev | 13:17 | |
| *** sandywalsh has quit IRC | 13:18 | |
| *** Steap has joined #openstack-dev | 13:18 | |
| *** haomaiwang has quit IRC | 13:19 | |
| *** paragan has joined #openstack-dev | 13:19 | |
| *** paragan has quit IRC | 13:19 | |
| *** paragan has joined #openstack-dev | 13:19 | |
| *** haomaiwang has joined #openstack-dev | 13:21 | |
| *** rohitk has joined #openstack-dev | 13:22 | |
| *** aeperezt has joined #openstack-dev | 13:22 | |
| *** ijw has quit IRC | 13:23 | |
| *** haomaiwa_ has quit IRC | 13:23 | |
| *** ijw has joined #openstack-dev | 13:24 | |
| *** haomaiwang has quit IRC | 13:26 | |
| *** achampion has joined #openstack-dev | 13:26 | |
| *** haomaiwang has joined #openstack-dev | 13:26 | |
| *** mestery has joined #openstack-dev | 13:28 | |
| *** mestery has quit IRC | 13:29 | |
| *** haomaiwa_ has joined #openstack-dev | 13:29 | |
| *** achampion has quit IRC | 13:30 | |
| *** willingc has joined #openstack-dev | 13:31 | |
| *** kgriffs_afk is now known as kgriffs | 13:31 | |
| *** sandywalsh has joined #openstack-dev | 13:32 | |
| *** haomaiwang has quit IRC | 13:32 | |
| *** mfink has joined #openstack-dev | 13:32 | |
| *** eharney has quit IRC | 13:32 | |
| *** rcrit has quit IRC | 13:36 | |
| *** rohitk has quit IRC | 13:38 | |
| *** rcrit has joined #openstack-dev | 13:39 | |
| *** fifieldt has quit IRC | 13:39 | |
| *** vladikr has joined #openstack-dev | 13:41 | |
| *** kgriffs is now known as kgriffs_afk | 13:41 | |
| *** aveiga has joined #openstack-dev | 13:41 | |
| *** bswartz has quit IRC | 13:42 | |
| *** thomasem has joined #openstack-dev | 13:42 | |
| *** haomaiwa_ has quit IRC | 13:42 | |
| *** blues-man has joined #openstack-dev | 13:43 | |
| *** haomaiwang has joined #openstack-dev | 13:43 | |
| *** haomaiwang has quit IRC | 13:44 | |
| *** CaptTofu has quit IRC | 13:44 | |
| *** haomaiwang has joined #openstack-dev | 13:45 | |
| *** danielbruno has joined #openstack-dev | 13:45 | |
| *** CaptTofu has joined #openstack-dev | 13:45 | |
| *** jdob has joined #openstack-dev | 13:47 | |
| *** mdomsch has joined #openstack-dev | 13:47 | |
| *** doug_shelley66 has quit IRC | 13:47 | |
| *** blues-man has quit IRC | 13:47 | |
| *** che-arne has joined #openstack-dev | 13:47 | |
| *** gokrokve has joined #openstack-dev | 13:48 | |
| *** dprince has joined #openstack-dev | 13:50 | |
| *** rohitk has joined #openstack-dev | 13:50 | |
| *** neelashah has joined #openstack-dev | 13:51 | |
| *** gokrokve has quit IRC | 13:53 | |
| *** blues-man has joined #openstack-dev | 13:53 | |
| *** jasondotstar has joined #openstack-dev | 13:54 | |
| *** rods has joined #openstack-dev | 13:55 | |
| *** mmagr has quit IRC | 13:55 | |
| *** Longgeek has joined #openstack-dev | 13:57 | |
| *** vartom111111117 has quit IRC | 13:57 | |
| *** tzumainn has quit IRC | 13:58 | |
| *** tzumainn has joined #openstack-dev | 13:58 | |
| *** haomaiwa_ has joined #openstack-dev | 13:59 | |
| *** willingc has quit IRC | 14:00 | |
| *** aeperezt has quit IRC | 14:00 | |
| *** rtheis has joined #openstack-dev | 14:01 | |
| *** lbragstad has joined #openstack-dev | 14:01 | |
| *** gordc has joined #openstack-dev | 14:01 | |
| *** glenng has joined #openstack-dev | 14:01 | |
| *** dsirrine has joined #openstack-dev | 14:01 | |
| *** xga has quit IRC | 14:02 | |
| *** xga has joined #openstack-dev | 14:02 | |
| *** haomaiwang has quit IRC | 14:02 | |
| *** Longgeek has quit IRC | 14:02 | |
| *** mestery has joined #openstack-dev | 14:03 | |
| *** rockyg has joined #openstack-dev | 14:04 | |
| *** mindpixel has joined #openstack-dev | 14:06 | |
| *** jayg|g0n3 is now known as jayg | 14:07 | |
| *** akrivoka has quit IRC | 14:07 | |
| *** akrivoka has joined #openstack-dev | 14:08 | |
| *** dvarga has joined #openstack-dev | 14:09 | |
| *** dvarga has quit IRC | 14:09 | |
| *** jbryce has joined #openstack-dev | 14:09 | |
| *** rockyg has quit IRC | 14:09 | |
| *** mmagr has joined #openstack-dev | 14:10 | |
| *** xga has quit IRC | 14:11 | |
| *** chandankumar has quit IRC | 14:12 | |
| *** thuc has joined #openstack-dev | 14:12 | |
| *** rdas has quit IRC | 14:12 | |
| *** thuc_ has joined #openstack-dev | 14:13 | |
| *** bauzas has joined #openstack-dev | 14:13 | |
| *** jdob has quit IRC | 14:15 | |
| *** neeti has quit IRC | 14:15 | |
| *** jdob has joined #openstack-dev | 14:16 | |
| *** l_a_m has joined #openstack-dev | 14:16 | |
| *** thuc has quit IRC | 14:17 | |
| *** xga has joined #openstack-dev | 14:18 | |
| *** noslzzp has joined #openstack-dev | 14:18 | |
| *** jdob has quit IRC | 14:19 | |
| *** jdob has joined #openstack-dev | 14:19 | |
| *** peristeri has joined #openstack-dev | 14:19 | |
| *** l_a_m has left #openstack-dev | 14:20 | |
| *** eglynn is now known as eglynn-is-hypogl | 14:22 | |
| ttx | markmc: you around ? | 14:22 |
| markmc | ttx, hey | 14:22 |
| ttx | markmc: hola, happy new year etc | 14:22 |
| markmc | ttx, ditto, etc. :) | 14:23 |
| ttx | markmc: had a question for you about oslo.rootwrap | 14:23 |
| *** chandankumar has joined #openstack-dev | 14:23 | |
| ttx | markmc: I think I pushed everything to make it part of the gate now and properly installed in devstack | 14:23 |
| ttx | (copying whazt oslo.messaging did) | 14:23 |
| ttx | markmc: trying to debug trying to debug http://logs.openstack.org/91/62691/2/check/check-grenade-dsvm/5ce0a34/logs/new/screen-c-vol.txt.gz now | 14:24 |
| *** fire has joined #openstack-dev | 14:24 | |
| ttx | I have a feeling it might come from the absence of oslo/__init__.py | 14:24 |
| ttx | which may be a problem with the python setup.py develop -style install | 14:24 |
| ttx | (pip seems to survive it alright) | 14:25 |
| markmc | ttx, hmm, suck | 14:25 |
| ttx | whe the package was simply installed as a dep I did not hit that | 14:25 |
| ttx | try is I'm not sure we should all be having oslo/__init__.py in all the oslo.* libs | 14:26 |
| ttx | s/try/problem | 14:26 |
| *** dims has quit IRC | 14:27 | |
| *** WintermeW has joined #openstack-dev | 14:27 | |
| *** bswartz has joined #openstack-dev | 14:28 | |
| markmc | ttx, struggling to remember how this is supposed to work, tbh | 14:28 |
| *** nshaikh has left #openstack-dev | 14:28 | |
| *** eglynn-is-hypogl is now known as eglynn-lunch | 14:28 | |
| ttx | dhellmann: if you're around ^ | 14:28 |
| markmc | ttx, AFAIR oslo/__init__.py shouldn't get installed for namespaced packages | 14:28 |
| ttx | markmc: I fear some kind of weirdness due to setup.py develop using eggs stuff | 14:29 |
| markmc | ttx, one odd thing is that oslo.config has: | 14:29 |
| markmc | packages = | 14:29 |
| markmc | oslo | 14:29 |
| markmc | oslo.config | 14:29 |
| markmc | namespace_packages = | 14:29 |
| markmc | oslo | 14:29 |
| markmc | ttx, and oslo.messaging has: | 14:29 |
| markmc | packages = | 14:30 |
| markmc | oslo | 14:30 |
| markmc | namespace_packages = | 14:30 |
| markmc | oslo | 14:30 |
| * ttx copies oslo.messaging | 14:30 | |
| *** mdenny has joined #openstack-dev | 14:30 | |
| markmc | ttx, there's some pbr history here and I recall mordred explaining why explicitly listing oslo.config isn't needed | 14:30 |
| markmc | ttx, so that could be a red-herring | 14:30 |
| * markmc tries some things | 14:30 | |
| *** DinaBelova has joined #openstack-dev | 14:30 | |
| *** dims has joined #openstack-dev | 14:31 | |
| *** thuc_ has quit IRC | 14:32 | |
| *** markvoelker1 has quit IRC | 14:32 | |
| *** kgriffs_afk is now known as kgriffs | 14:32 | |
| ttx | markmc: fwiw setup.py develop complains in devstacklog about "package init file 'oslo/__init__.py' not found (or not a regular file)" | 14:32 |
| ttx | which is where I got the hint from | 14:32 |
| *** thuc has joined #openstack-dev | 14:32 | |
| *** cyeoh_ has joined #openstack-dev | 14:32 | |
| *** cyeoh_ is now known as cyeoh | 14:32 | |
| *** morazi has joined #openstack-dev | 14:32 | |
| markmc | ttx, oh, oslo.rootwrap doesn't have oslo/__init__.py in git? | 14:32 |
| *** xingchao has quit IRC | 14:33 | |
| *** dbalog has joined #openstack-dev | 14:33 | |
| ttx | markmc: exactly | 14:33 |
| markmc | ttx, that's the first thing to try - add one which declares the namespace | 14:33 |
| *** jobewan has joined #openstack-dev | 14:34 | |
| ttx | i can reproduce that error running PYTHONPATH=. /tmp/oslo-rootwrap | 14:34 |
| ttx | so it's probably that | 14:34 |
| *** jnoller has joined #openstack-dev | 14:34 | |
| ttx | a requirement for running from tree that pip hides | 14:34 |
| *** mfink has quit IRC | 14:35 | |
| *** prad has joined #openstack-dev | 14:35 | |
| *** mfink has joined #openstack-dev | 14:35 | |
| markmc | ttx, adding __init__.py to git fixes 'setup.py develop' for me | 14:35 |
| ttx | yep | 14:35 |
| ttx | markmc: that's probably it. Will fix. | 14:36 |
| ttx | thx! | 14:36 |
| *** akrivoka has quit IRC | 14:36 | |
| markmc | ttx, np, ping me when you put up the review and I'll +2 - I'm a bit behind | 14:36 |
| * tshirtman just found a bug in lesscpy >_> | 14:37 | |
| *** joesavak has joined #openstack-dev | 14:37 | |
| *** thuc has quit IRC | 14:37 | |
| *** clayb has joined #openstack-dev | 14:37 | |
| *** akrivoka has joined #openstack-dev | 14:37 | |
| *** rossella_s has joined #openstack-dev | 14:38 | |
| *** doug_shelley66 has joined #openstack-dev | 14:39 | |
| lifeless | giulivo: sure | 14:39 |
| *** yamahata has joined #openstack-dev | 14:40 | |
| *** tdruiva is now known as tdruiva|away | 14:40 | |
| *** morazi has quit IRC | 14:40 | |
| *** yeylon_ has quit IRC | 14:40 | |
| ttx | markmc: will ping you when we have check test results. | 14:41 |
| *** blues-man has quit IRC | 14:41 | |
| *** kgriffs is now known as kgriffs_afk | 14:42 | |
| *** eglynn-lunch is now known as eglynn | 14:43 | |
| *** morazi has joined #openstack-dev | 14:43 | |
| *** xjiujiu has quit IRC | 14:43 | |
| *** jorisroovers has joined #openstack-dev | 14:44 | |
| *** eharney has joined #openstack-dev | 14:45 | |
| *** FunnyLookinHat has quit IRC | 14:45 | |
| *** jroovers has quit IRC | 14:46 | |
| *** colinmcnamara has joined #openstack-dev | 14:48 | |
| *** gokrokve has joined #openstack-dev | 14:48 | |
| *** AnilV4 has quit IRC | 14:48 | |
| *** jorisroovers has quit IRC | 14:50 | |
| *** rushiagr has joined #openstack-dev | 14:51 | |
| dhellmann | ttx, markmc: catching up on backlog... | 14:51 |
| ttx | dhellmann: I think we came up to the conclusion that https://review.openstack.org/#/c/65972/ was the answer | 14:52 |
| dhellmann | ttx: yep, that looks right | 14:52 |
| *** burt has joined #openstack-dev | 14:52 | |
| dhellmann | ttx: there was a ML thread about solum having issues with oslo namespace packages, but I think you hit a different issue | 14:53 |
| *** spzala has joined #openstack-dev | 14:53 | |
| ttx | dhellmann: yeah. This issue is new, appeared when we added oslo.rootwrap to the gate (so using the git master version in tests) | 14:53 |
| *** gokrokve has quit IRC | 14:53 | |
| dhellmann | ttx: yeah, I think you have the proper fix there; let's see what jenkins says | 14:54 |
| ttx | dhellmann: pip handles absence of that file more gracefully | 14:54 |
| *** chandankumar has quit IRC | 14:54 | |
| *** jsavak has joined #openstack-dev | 14:54 | |
| ttx | might just be that using common directories, it just finds one from oslo.config installed. | 14:54 |
| *** READ10 has joined #openstack-dev | 14:54 | |
| *** coasterz has quit IRC | 14:54 | |
| dhellmann | the namespace package won't actually install that file, iirc | 14:54 |
| *** teran__ has quit IRC | 14:55 | |
| dhellmann | at least under some circumstances | 14:55 |
| *** teran has joined #openstack-dev | 14:55 | |
| dhellmann | I haven't had enough caffeine to think about python packaging yet :-) | 14:55 |
| noorul | http://www.mail-archive.com/openstack-dev@lists.openstack.org/msg13109.html | 14:55 |
| noorul | dhellmann: Are you looking for ^^^ | 14:55 |
| dhellmann | noorul: I was referencing that, yes, thanks | 14:56 |
| *** coasterz has joined #openstack-dev | 14:56 | |
| noorul | And also there is another one http://www.mail-archive.com/openstack-dev@lists.openstack.org/msg13178.html | 14:57 |
| noorul | ttx ^^^ | 14:57 |
| *** joesavak has quit IRC | 14:57 | |
| *** vijendar has joined #openstack-dev | 14:58 | |
| *** CaptTofu has quit IRC | 14:59 | |
| *** carl_baldwin has joined #openstack-dev | 14:59 | |
| *** mriedem has joined #openstack-dev | 15:01 | |
| *** Longgeek has joined #openstack-dev | 15:01 | |
| dhellmann | noorul: we don't think those are related to the current problem | 15:03 |
| *** otherwiseguy has joined #openstack-dev | 15:04 | |
| *** mtreinish has quit IRC | 15:04 | |
| *** jergerber has joined #openstack-dev | 15:04 | |
| *** jergerber has quit IRC | 15:04 | |
| *** Longgeek has quit IRC | 15:06 | |
| *** mtreinish has joined #openstack-dev | 15:06 | |
| *** aditirav has joined #openstack-dev | 15:07 | |
| *** radez_g0n3 is now known as radez | 15:09 | |
| *** aditirav has quit IRC | 15:09 | |
| *** coolsvap has joined #openstack-dev | 15:09 | |
| bogdando | dhellmann, hello | 15:10 |
| dhellmann | bogdando: hi | 15:11 |
| bogdando | dhellmann, can you please elaborate your comment on https://review.openstack.org/#/c/63094/ ? | 15:11 |
| dhellmann | looking | 15:12 |
| *** carlp has joined #openstack-dev | 15:12 | |
| bogdando | I've created small demo for devstack testing both patches (#4 and last one) as well | 15:12 |
| bogdando | you can watch it here http://youtu.be/NBSFeGZEncE | 15:12 |
| dhellmann | bogdando: IIRC, that changes the output format of the log messages, which may break a deployer that is already using syslog handling in its current form | 15:12 |
| dhellmann | bogdando: a new option might be a better way to handle the format change (e.g., --rfc-syslog, though that's not a great name) | 15:13 |
| bogdando | In demo I illustrated how both changes could be used | 15:13 |
| *** kevinconway has joined #openstack-dev | 15:13 | |
| bogdando | I also like new option for log_format, but I cannot figure out how to fight this dict errors for some middlewares | 15:14 |
| dhellmann | bogdando: I'm sorry, but I really truly do not have time to watch video demos of patches. Could you produce a pastebin or something I could read? | 15:14 |
| *** UKn0Me has quit IRC | 15:14 | |
| bogdando | dhellmann, yes I will do | 15:15 |
| *** rwsu has quit IRC | 15:15 | |
| dhellmann | bogdando: thanks | 15:15 |
| *** gordc has quit IRC | 15:15 | |
| noorul | dhellmann: ok | 15:16 |
| *** alex_klimov has quit IRC | 15:16 | |
| dhellmann | bogdando: I appreciate you fixing this to make it standards compliant; we just need to come up with a way that's also backwards-compatible for existing users. We can deprecate the broken form after we make both work together. | 15:16 |
| *** aswadrangnekar has quit IRC | 15:16 | |
| *** armax has joined #openstack-dev | 15:17 | |
| *** zz_paulczar is now known as paulczar | 15:17 | |
| *** mrodden has joined #openstack-dev | 15:17 | |
| *** DynamiteXXL_ has joined #openstack-dev | 15:18 | |
| *** FunnyLookinHat has joined #openstack-dev | 15:19 | |
| *** achampion has joined #openstack-dev | 15:19 | |
| *** stevemar has joined #openstack-dev | 15:19 | |
| *** xga_ has joined #openstack-dev | 15:19 | |
| *** xga has quit IRC | 15:19 | |
| *** CaptTofu has joined #openstack-dev | 15:20 | |
| *** gszasz has quit IRC | 15:22 | |
| bogdando | dhellmann, does backwards-compatible mean "syslog = RFCSysLogHandler(address='/dev/log',..." will not work with older versions of services using syslog handler? am I understand you correct? | 15:24 |
| *** jgrimm has joined #openstack-dev | 15:24 | |
| bogdando | are where any other means? | 15:25 |
| *** DynamiteXXL_ has quit IRC | 15:25 | |
| *** kgriffs_afk is now known as kgriffs | 15:25 | |
| dhellmann | bogdando: what I mean is that any deployer using the current version of the syslog handler, with the current options that enable it, should still see the same log output format after an upgrade | 15:25 |
| *** UKn0Me has joined #openstack-dev | 15:25 | |
| dhellmann | whether that means using the same handler class, or just not having the new format enabled, is an implementation detail | 15:26 |
| dhellmann | make sense? | 15:26 |
| *** rwsu has joined #openstack-dev | 15:26 | |
| *** rcleere has joined #openstack-dev | 15:27 | |
| *** jgrimm has quit IRC | 15:28 | |
| *** noslzzp has quit IRC | 15:28 | |
| *** jasondotstar has quit IRC | 15:29 | |
| *** jgrimm has joined #openstack-dev | 15:31 | |
| *** ahmeda has joined #openstack-dev | 15:32 | |
| *** markmcclain has joined #openstack-dev | 15:36 | |
| *** armax has quit IRC | 15:36 | |
| *** armax has joined #openstack-dev | 15:37 | |
| *** galstrom_zzz is now known as galstrom | 15:37 | |
| *** russellb is now known as rustlebee | 15:39 | |
| *** gokrokve has joined #openstack-dev | 15:39 | |
| *** mfink has quit IRC | 15:39 | |
| *** mfink has joined #openstack-dev | 15:40 | |
| *** ahmeda has quit IRC | 15:41 | |
| *** armax has quit IRC | 15:41 | |
| *** jmckind has joined #openstack-dev | 15:41 | |
| *** mrodden1 has joined #openstack-dev | 15:42 | |
| *** armax has joined #openstack-dev | 15:42 | |
| *** willingc has joined #openstack-dev | 15:43 | |
| *** alaski has quit IRC | 15:43 | |
| *** mrodden has quit IRC | 15:43 | |
| *** belmoreira has quit IRC | 15:43 | |
| *** lari__ has quit IRC | 15:44 | |
| *** dansmith is now known as damnsmith | 15:44 | |
| *** Apsu has quit IRC | 15:44 | |
| *** Apsu has joined #openstack-dev | 15:44 | |
| *** blues-man has joined #openstack-dev | 15:45 | |
| *** willingc has quit IRC | 15:46 | |
| bogdando | dhellmann, here http://paste.openstack.org/show/60983/ I've tried to illustrate there are no backward-compatibility issues using original SysLogHandler | 15:46 |
| *** GheRivero_afk is now known as GheRivero | 15:46 | |
| *** ymr1 has quit IRC | 15:47 | |
| *** mmagr has quit IRC | 15:47 | |
| bogdando | you can see and compare screen vs syslog logs output both for unpatched and patched log.py, using same Nova config | 15:47 |
| dhellmann | bogdando: where's the extra piece of information, the binary name? | 15:47 |
| dhellmann | ah, I see it there | 15:47 |
| bogdando | see part 2 - it has been provided ... yes | 15:48 |
| dhellmann | so, yes, the output format has changed | 15:48 |
| *** chandankumar has joined #openstack-dev | 15:48 | |
| dhellmann | that's not backwards compatible | 15:48 |
| dhellmann | anything trying to parse that log output will now fail | 15:48 |
| dhellmann | I think what we need is a new flag that turns on this new rfc-based format, instead of the old format | 15:48 |
| *** armax has quit IRC | 15:48 | |
| *** jasondotstar has joined #openstack-dev | 15:48 | |
| *** chandankumar has quit IRC | 15:48 | |
| bogdando | I understand you now... | 15:48 |
| dhellmann | the default should be to not use the format, so deployers can turn it on if they want | 15:49 |
| dhellmann | and then during J we can talk about changing that default | 15:49 |
| bogdando | so, I should add new config option? | 15:49 |
| dhellmann | and the deprecation process to remove the old broken format | 15:49 |
| *** armax has joined #openstack-dev | 15:49 | |
| dhellmann | yes, I think so | 15:49 |
| *** mlavalle has joined #openstack-dev | 15:49 | |
| dhellmann | maybe "use_syslog_rfc_format = true" to turn it on? | 15:49 |
| bogdando | thank you for your help and your time, I will try :) | 15:49 |
| *** fire has quit IRC | 15:50 | |
| dhellmann | or maybe use_syslog_rfc_### where ### is the rfc number | 15:50 |
| dhellmann | good, thanks, and I'm sorry this wasn't clear from my original review comment :-) | 15:50 |
| *** rushiagr is now known as rushiagr_away | 15:50 | |
| dhellmann | thanks for your patience! | 15:50 |
| *** lari_ has joined #openstack-dev | 15:51 | |
| *** kbrierly has joined #openstack-dev | 15:52 | |
| *** jmckind has quit IRC | 15:56 | |
| *** zaitcev has joined #openstack-dev | 15:56 | |
| *** herndon_ has joined #openstack-dev | 15:56 | |
| *** jmw has joined #openstack-dev | 15:58 | |
| *** flaper87 is now known as flaper87|afk | 15:59 | |
| *** paragan has quit IRC | 15:59 | |
| *** thedodd has joined #openstack-dev | 15:59 | |
| *** mmagr has joined #openstack-dev | 16:00 | |
| *** rushiagr_away is now known as rushiagr | 16:00 | |
| *** Ruetobas has quit IRC | 16:01 | |
| *** paulczar is now known as zz_paulczar | 16:01 | |
| *** herndon_ has quit IRC | 16:01 | |
| *** mmagr has quit IRC | 16:01 | |
| *** Ruetobas has joined #openstack-dev | 16:03 | |
| *** gordc has joined #openstack-dev | 16:03 | |
| *** pdevine has joined #openstack-dev | 16:04 | |
| *** Longgeek has joined #openstack-dev | 16:04 | |
| *** Ruetobas has quit IRC | 16:08 | |
| *** Ruetobas has joined #openstack-dev | 16:08 | |
| *** csd has joined #openstack-dev | 16:08 | |
| *** jdurgin1 has quit IRC | 16:08 | |
| *** zz_paulczar is now known as paulczar | 16:09 | |
| *** jsavak has quit IRC | 16:09 | |
| *** joesavak has joined #openstack-dev | 16:09 | |
| *** Longgeek has quit IRC | 16:10 | |
| ttx | markmc: it's up and checked @ https://review.openstack.org/#/c/65972/ | 16:10 |
| markmc | ttx, cool | 16:11 |
| *** mlavalle has quit IRC | 16:11 | |
| *** csaba|afk is now known as csaba | 16:12 | |
| *** jistr has quit IRC | 16:12 | |
| *** noslzzp has joined #openstack-dev | 16:17 | |
| *** colinmcnamara has quit IRC | 16:17 | |
| *** gokrokve has quit IRC | 16:18 | |
| *** gokrokve has joined #openstack-dev | 16:18 | |
| *** iartarisi has quit IRC | 16:19 | |
| *** paulczar has left #openstack-dev | 16:21 | |
| *** xgsa has quit IRC | 16:22 | |
| *** gokrokve has quit IRC | 16:23 | |
| *** alaski has joined #openstack-dev | 16:26 | |
| *** e0ne_ has quit IRC | 16:26 | |
| *** browne has joined #openstack-dev | 16:26 | |
| *** reed has joined #openstack-dev | 16:26 | |
| rpodolyaka | dhellmann: ping | 16:27 |
| *** bashok has quit IRC | 16:27 | |
| *** beagles is now known as beagles_brb | 16:27 | |
| *** rushiagr is now known as rushiagr_away | 16:29 | |
| *** jmontemayor has joined #openstack-dev | 16:29 | |
| *** vijendar has quit IRC | 16:29 | |
| *** kbrierly has quit IRC | 16:29 | |
| *** rcj has quit IRC | 16:29 | |
| *** SergeyLukjanov has quit IRC | 16:30 | |
| *** tdruiva|away is now known as tdruiva | 16:30 | |
| *** vijendar has joined #openstack-dev | 16:31 | |
| *** vartom111111117 has joined #openstack-dev | 16:31 | |
| *** gyee_ has joined #openstack-dev | 16:32 | |
| *** xga has joined #openstack-dev | 16:35 | |
| *** xga_ has quit IRC | 16:35 | |
| *** derekh has quit IRC | 16:36 | |
| *** comay has joined #openstack-dev | 16:36 | |
| *** rohitk has quit IRC | 16:38 | |
| *** CaptTofu has quit IRC | 16:38 | |
| *** jcoufal has quit IRC | 16:38 | |
| *** asselin_ has joined #openstack-dev | 16:38 | |
| *** Mandell has quit IRC | 16:39 | |
| *** jruzicka has quit IRC | 16:40 | |
| *** radez is now known as radez_g0n3 | 16:40 | |
| *** exed_ has quit IRC | 16:41 | |
| *** marekd is now known as marekd|away | 16:41 | |
| *** vartom111111117 has quit IRC | 16:42 | |
| *** rcj has joined #openstack-dev | 16:44 | |
| *** jog0 is now known as flashgordon | 16:44 | |
| *** dkuffner has quit IRC | 16:45 | |
| *** changbl has quit IRC | 16:46 | |
| *** rushiagr_away is now known as rushiagr | 16:48 | |
| flashgordon | dtroyer: https://review.openstack.org/45766 | 16:48 |
| *** ahmeda has joined #openstack-dev | 16:49 | |
| *** teran_ has joined #openstack-dev | 16:49 | |
| *** markmcclain has quit IRC | 16:49 | |
| *** teran has quit IRC | 16:49 | |
| *** blues-man has quit IRC | 16:51 | |
| dhellmann | ttx: approved | 16:51 |
| dhellmann | rpodolyaka: pong | 16:51 |
| *** blues-man has joined #openstack-dev | 16:51 | |
| *** AlanClark has joined #openstack-dev | 16:52 | |
| ttx | dhellmann: awesomethx | 16:52 |
| flashgordon | dtroyer: thanks | 16:52 |
| dtroyer | flashgordon: I'm assuming the gate failures are the current sources of joy? | 16:53 |
| *** ozialien has joined #openstack-dev | 16:53 | |
| flashgordon | dtroyer: very much so | 16:53 |
| flashgordon | although we are making good progress | 16:53 |
| flashgordon | btw I have a grenade patch series https://review.openstack.org/#/q/status:open+branch:master+topic:nova-compute,n,z | 16:54 |
| *** carl_baldwin has quit IRC | 16:55 | |
| *** JordanP has quit IRC | 16:55 | |
| *** teran_ has quit IRC | 16:56 | |
| *** teran has joined #openstack-dev | 16:57 | |
| *** xmltok has joined #openstack-dev | 16:58 | |
| *** mindpixel has quit IRC | 16:58 | |
| *** ruhe is now known as _ruhe | 16:59 | |
| *** Longgeek has joined #openstack-dev | 16:59 | |
| *** rwsu has quit IRC | 17:00 | |
| *** mdomsch has quit IRC | 17:00 | |
| *** radez_g0n3 is now known as radez | 17:00 | |
| *** teran has quit IRC | 17:01 | |
| *** SumitNaiksatam has quit IRC | 17:02 | |
| *** jprovazn has quit IRC | 17:03 | |
| *** pablosan has joined #openstack-dev | 17:04 | |
| *** colinmcnamara has joined #openstack-dev | 17:04 | |
| *** pmathews has joined #openstack-dev | 17:04 | |
| *** mlavalle has joined #openstack-dev | 17:05 | |
| *** colinmcnamara has quit IRC | 17:06 | |
| *** xarses has quit IRC | 17:06 | |
| *** Longgeek has quit IRC | 17:06 | |
| *** bnemec is now known as beekneemech | 17:07 | |
| *** _ruhe is now known as ruhe | 17:07 | |
| *** buzztroll has joined #openstack-dev | 17:08 | |
| *** bdpayne has joined #openstack-dev | 17:08 | |
| *** gokrokve has joined #openstack-dev | 17:08 | |
| *** _cjones_ has joined #openstack-dev | 17:09 | |
| *** alop has joined #openstack-dev | 17:10 | |
| *** mrunge has quit IRC | 17:11 | |
| *** rnirmal has joined #openstack-dev | 17:11 | |
| *** nelsnelson has joined #openstack-dev | 17:11 | |
| *** _cjones_ has quit IRC | 17:14 | |
| rpodolyaka | dhellmann: hey! Could you please take a look at BP https://blueprints.launchpad.net/oslo/+spec/oslo-migration-toolkit when you have a minute? (patch, implementing this is already on review - https://review.openstack.org/#/c/59433/). This is schema migrations stuff we talked at the summit. This BP implements the common UI for sqlalchemy-migrate/alembic and enables smooth transitioning from migrate to alembic | 17:15 |
| *** tqtran has joined #openstack-dev | 17:17 | |
| *** Alexei_987 has quit IRC | 17:17 | |
| *** ygbo has quit IRC | 17:17 | |
| *** armax has quit IRC | 17:18 | |
| *** viktors has left #openstack-dev | 17:18 | |
| *** SumitNaiksatam has joined #openstack-dev | 17:18 | |
| *** kbrierly has joined #openstack-dev | 17:19 | |
| *** SergeyLukjanov has joined #openstack-dev | 17:19 | |
| *** akrivoka has quit IRC | 17:22 | |
| *** asselin_ has quit IRC | 17:23 | |
| *** mancdaz is now known as mancdaz_away | 17:23 | |
| *** tkay has joined #openstack-dev | 17:23 | |
| *** colinmcnamara has joined #openstack-dev | 17:23 | |
| *** beagles_brb is now known as beagles | 17:24 | |
| *** madmike has joined #openstack-dev | 17:25 | |
| *** mkollaro has quit IRC | 17:26 | |
| *** CaptTofu has joined #openstack-dev | 17:26 | |
| *** jpich has quit IRC | 17:27 | |
| *** mfink has quit IRC | 17:27 | |
| *** tkay has quit IRC | 17:28 | |
| *** hartsocks is now known as hartbot | 17:29 | |
| *** hemnafk is now known as hemna_ | 17:29 | |
| *** xga has quit IRC | 17:29 | |
| *** tkay has joined #openstack-dev | 17:29 | |
| *** dstanek has joined #openstack-dev | 17:29 | |
| *** xga has joined #openstack-dev | 17:30 | |
| *** colinmcnamara has quit IRC | 17:31 | |
| *** Sumeniac has quit IRC | 17:31 | |
| *** carl_baldwin has joined #openstack-dev | 17:31 | |
| *** comstud is now known as bearhands | 17:31 | |
| *** mriedem has quit IRC | 17:32 | |
| *** markmcclain has joined #openstack-dev | 17:32 | |
| *** armax has joined #openstack-dev | 17:35 | |
| *** e0ne has joined #openstack-dev | 17:37 | |
| *** blues-man has quit IRC | 17:37 | |
| *** dstanek has quit IRC | 17:37 | |
| *** Sumeniac has joined #openstack-dev | 17:38 | |
| *** e0ne has quit IRC | 17:38 | |
| *** e0ne has joined #openstack-dev | 17:38 | |
| *** sahid has quit IRC | 17:38 | |
| *** eglynn has quit IRC | 17:39 | |
| *** Shaan7 has joined #openstack-dev | 17:40 | |
| *** Shaan7 has quit IRC | 17:40 | |
| *** Shaan7 has joined #openstack-dev | 17:40 | |
| *** blamar has joined #openstack-dev | 17:40 | |
| *** blues-man has joined #openstack-dev | 17:42 | |
| *** markwash has quit IRC | 17:42 | |
| *** blues-man has quit IRC | 17:42 | |
| *** florentflament has quit IRC | 17:43 | |
| *** Shaan7 has quit IRC | 17:43 | |
| *** ruhe is now known as _ruhe | 17:43 | |
| *** che-arne has quit IRC | 17:45 | |
| *** che-arne has joined #openstack-dev | 17:45 | |
| *** xga has quit IRC | 17:46 | |
| *** xga has joined #openstack-dev | 17:46 | |
| *** markwash has joined #openstack-dev | 17:47 | |
| *** BobBall is now known as BobBallAway | 17:47 | |
| *** harlowja_away is now known as harlowja | 17:47 | |
| *** Shaan7 has joined #openstack-dev | 17:47 | |
| *** Shaan7 has quit IRC | 17:47 | |
| *** Shaan7 has joined #openstack-dev | 17:47 | |
| *** teran has joined #openstack-dev | 17:49 | |
| *** xarses has joined #openstack-dev | 17:54 | |
| *** zzelle has joined #openstack-dev | 17:55 | |
| *** dstanek has joined #openstack-dev | 17:56 | |
| *** csd has quit IRC | 17:57 | |
| *** fire has joined #openstack-dev | 17:58 | |
| *** bdpayne_ has joined #openstack-dev | 18:00 | |
| *** nati_ueno has joined #openstack-dev | 18:01 | |
| *** bdpayne_ has quit IRC | 18:01 | |
| *** carl_baldwin has quit IRC | 18:01 | |
| *** nati_uen_ has joined #openstack-dev | 18:02 | |
| *** bdpayne_ has joined #openstack-dev | 18:02 | |
| *** bdpayne_ has quit IRC | 18:02 | |
| *** corXi has quit IRC | 18:02 | |
| *** bdpayne has quit IRC | 18:02 | |
| *** nati_uen_ has quit IRC | 18:03 | |
| *** mriedem has joined #openstack-dev | 18:04 | |
| *** nati_uen_ has joined #openstack-dev | 18:04 | |
| *** nati_ueno has quit IRC | 18:05 | |
| *** GheRivero is now known as GheRivero_afk | 18:05 | |
| *** pmathews has quit IRC | 18:05 | |
| *** mriedem has quit IRC | 18:06 | |
| dstanek | is there any way to diff two patchsets in gerrit to see what actually changed? | 18:06 |
| *** pmathews has joined #openstack-dev | 18:06 | |
| dhellmann | dstanek: 2 versions of the same patch? | 18:06 |
| *** angdraug has joined #openstack-dev | 18:07 | |
| danpb | dstanek: gerrit has a UI option to diff 2 patches but it is essentially useless | 18:07 |
| dstanek | dhellmann: yes, like patchset 4 and patchset 5 | 18:07 |
| danpb | because if the patch was also rebased to newer git master the UI will show all those changes too | 18:07 |
| dhellmann | dstanek: the "Old Version History" selector lets you set the version to use as the source for diffs | 18:07 |
| *** carl_baldwin has joined #openstack-dev | 18:07 | |
| dhellmann | dstanek: it works better if later patches weren't rebased against a repo with a lot of other changes | 18:07 |
| dhellmann | dstanek: if that happens, sometimes you can set it to the most current version and read the diffs on the old patch backwards | 18:08 |
| *** athomas has quit IRC | 18:09 | |
| *** markmc has quit IRC | 18:09 | |
| *** armax has quit IRC | 18:09 | |
| *** ahmeda has quit IRC | 18:10 | |
| dstanek | dhellmann: not sure this is doing what i want - right now in git i would pull the changeset 4 patch and checkout FETCH_HEAD, then i fetch the patchset 5 change and diff HEAD..FETCH_HEAD | 18:11 |
| dhellmann | dstanek: and that would diff between 4 and 5? | 18:12 |
| *** ppetit has quit IRC | 18:13 | |
| dstanek | dhellmann: yeah, i do it everyone in a while when i just was to see what changed between the patches | 18:13 |
| *** ppetit has joined #openstack-dev | 18:14 | |
| CaptTofu | hi all | 18:14 |
| *** arnaud__ has joined #openstack-dev | 18:14 | |
| *** arnaud has joined #openstack-dev | 18:14 | |
| dstanek | dhellmann: doesn't always work well where there are a ton of changes - better to just look at the latest patch in isolation | 18:14 |
| dhellmann | dstanek: yeah, if you look at https://review.openstack.org/#/c/65386/ and set the "Old Version History" to patch set 1, then click the test.py link it will show you the changes between patch 1 and 2 in that file | 18:14 |
| CaptTofu | question - having issues with upstart, so I want to start a program backgrouned, but not sure how to do a docker run with the program backgrounded (this being mysqld_safe) ? | 18:14 |
| *** mlavalle has quit IRC | 18:14 | |
| CaptTofu | whoops, wrong channel | 18:14 |
| *** vipuls is now known as vipuls-away | 18:15 | |
| dhellmann | dstanek: right, it also fails if the latter patch is rebased when submitted to gerrit because git thinks it includes lots of other files that weren't in the original patch | 18:15 |
| *** vipuls-away is now known as vipuls | 18:15 | |
| dhellmann | dstanek: so I guess it's diffing not the patches themselves, but the state of the repo at each point | 18:15 |
| *** ppetit has quit IRC | 18:15 | |
| dstanek | dhellmann: i have not run into that yet, but yeah it's actually diffing the branches | 18:15 |
| *** mgagne1 has joined #openstack-dev | 18:16 | |
| *** utlemming has quit IRC | 18:16 | |
| *** noslzzp has quit IRC | 18:17 | |
| morganfainberg | mornin | 18:17 |
| *** mgagne2 has joined #openstack-dev | 18:18 | |
| *** thuc has joined #openstack-dev | 18:18 | |
| morganfainberg | lifeless, thanks for the help last night on testr stuff | 18:18 |
| *** utlemming has joined #openstack-dev | 18:19 | |
| *** mgagne has quit IRC | 18:19 | |
| *** thuc has quit IRC | 18:19 | |
| morganfainberg | lifeless, helped a lot in getting that patch posted. | 18:19 |
| *** otherwiseguy has quit IRC | 18:19 | |
| *** thuc has joined #openstack-dev | 18:19 | |
| *** thuc has quit IRC | 18:20 | |
| *** thuc has joined #openstack-dev | 18:21 | |
| *** mgagne1 has quit IRC | 18:21 | |
| *** thuc has quit IRC | 18:21 | |
| *** ahmeda has joined #openstack-dev | 18:22 | |
| *** thuc has joined #openstack-dev | 18:22 | |
| *** gyee_ has quit IRC | 18:23 | |
| *** csd has joined #openstack-dev | 18:24 | |
| *** Mandell has joined #openstack-dev | 18:24 | |
| *** sarob has joined #openstack-dev | 18:28 | |
| *** sarob has quit IRC | 18:28 | |
| morganfainberg | dolphm, huh, looks like there is something odd in the test_auth_with_id test. bad isolation | 18:28 |
| morganfainberg | yay parallel testing showing things like this | 18:28 |
| *** sarob has joined #openstack-dev | 18:28 | |
| *** rushiagr has quit IRC | 18:29 | |
| *** carl_baldwin has quit IRC | 18:29 | |
| *** neelashah has quit IRC | 18:30 | |
| *** neelashah1 has joined #openstack-dev | 18:30 | |
| *** mgagne has joined #openstack-dev | 18:30 | |
| *** browne has quit IRC | 18:30 | |
| dolphm | morganfainberg: i wasn't able to reproduce a failure there... i ran that test like 20 times this morning | 18:30 |
| *** mgagne is now known as mgagne1 | 18:30 | |
| *** mgagne2 has quit IRC | 18:30 | |
| dolphm | morganfainberg: my patchset just fixes the nits & includes lifeless's suggestion | 18:31 |
| dolphm | morganfainberg: i'm not sure what there is to doc as ayoung requested ... ideas? | 18:31 |
| *** Longgeek has joined #openstack-dev | 18:31 | |
| *** SergeyLukjanov has quit IRC | 18:35 | |
| *** Longgeek has quit IRC | 18:38 | |
| *** SergeyLukjanov has joined #openstack-dev | 18:38 | |
| *** Farooque has joined #openstack-dev | 18:39 | |
| *** devoid has joined #openstack-dev | 18:41 | |
| morganfainberg | dolphm, i am unsure about that | 18:42 |
| morganfainberg | dolphm, i mean, perhaps just "uncomment this line" if mysql? | 18:42 |
| ayoung | morganfainberg, how'd you run it? | 18:42 |
| morganfainberg | ayoung, tox -epy27 | 18:42 |
| ayoung | hmmmm | 18:43 |
| morganfainberg | ayoung, parallel testing is the default. | 18:43 |
| ayoung | is there something I need to do to clean up the tox venv? | 18:43 |
| ayoung | ohh..wait | 18:43 |
| ayoung | maybe I had the other venv ectivated and that messed things up | 18:43 |
| morganfainberg | ayoung, that could def do it | 18:43 |
| dolphm | ayoung: you can always nuke your tox environments and start fresh | 18:45 |
| ayoung | dolphm, I'll try that next | 18:45 |
| ayoung | is there some "update" | 18:45 |
| ayoung | http://paste.fedoraproject.org/67448/38937950/ | 18:45 |
| *** mdomsch has joined #openstack-dev | 18:46 | |
| dolphm | morganfainberg: i feel like i had this conversation before but i don't remember the outcome... why concurrency == 2 instead of at least 4? | 18:46 |
| morganfainberg | dolphm, hmm? we set that explicitly? | 18:46 |
| morganfainberg | my initial patch was use 1 worker per cpu | 18:46 |
| dolphm | morganfainberg: oh? i thought test_run_concurrency in .testr.conf set the number of workers | 18:47 |
| morganfainberg | dolphm, https://review.openstack.org/#/c/65870/5/.testr.conf | 18:47 |
| *** mlavalle has joined #openstack-dev | 18:47 | |
| morganfainberg | dolphm, it does, it's commented out | 18:47 |
| *** DinaBelova has quit IRC | 18:48 | |
| *** devoid has left #openstack-dev | 18:48 | |
| dolphm | morganfainberg: echo 1 == 1 worker, echo 4 == 4 workers, no? | 18:48 |
| morganfainberg | correct, | 18:48 |
| morganfainberg | but if it isn't defined (commented out by default here) | 18:49 |
| morganfainberg | it uses 1 worker per cpu | 18:49 |
| dolphm | morganfainberg: ooooh okay | 18:49 |
| *** jdurgin1 has joined #openstack-dev | 18:49 | |
| morganfainberg | i left the line in because mysql/pgsql needs to be single worker still | 18:49 |
| dolphm | morganfainberg: (worker per *core*?) | 18:49 |
| morganfainberg | so, uncomment, run "real db" test | 18:49 |
| *** pberis has quit IRC | 18:49 | |
| ayoung | per core | 18:49 |
| *** galstrom is now known as galstrom_zzz | 18:49 | |
| morganfainberg | dolphm, my VM represents true cpus to the guest | 18:49 |
| morganfainberg | but probably per core | 18:50 |
| bknudson | morganfainberg: any reason why https://review.openstack.org/#/c/65835/ isn't approved? | 18:50 |
| ayoung | there is not such thing as true cpus | 18:50 |
| morganfainberg | bknudson, i think it was waiting on jenkins | 18:50 |
| morganfainberg | ayoung, but representation to the OS | 18:50 |
| bknudson | morganfainberg: it's passed jenkins so I'll approve | 18:51 |
| morganfainberg | ayoung, i am representing 4 sockets | 18:51 |
| morganfainberg | bknudson, ++ | 18:51 |
| ayoung | bknudson, cuz stevemar didn't hit approve | 18:51 |
| morganfainberg | oh | 18:51 |
| ayoung | morganfainberg, no, not sockets | 18:51 |
| ayoung | you want core | 18:51 |
| ayoung | socket is a physical thing | 18:51 |
| morganfainberg | ayoung, it's just the way this VM is setup | 18:51 |
| morganfainberg | anyway | 18:51 |
| *** cdub_ is now known as cdub | 18:51 | |
| ayoung | you want the number of concurrent processes that can run, which is core. | 18:51 |
| ayoung | We could probably go higher | 18:52 |
| morganfainberg | ayoung, semantics for this discussion. | 18:52 |
| morganfainberg | ayoung, i was talking about how my vm was configured | 18:52 |
| morganfainberg | anyway | 18:52 |
| ayoung | I am guessing that tests are IO bound | 18:52 |
| morganfainberg | probably | 18:52 |
| *** csaba is now known as csaba|afk | 18:52 | |
| *** MaxV has quit IRC | 18:52 | |
| ayoung | morganfainberg, I run on my laptop, not in a VM | 18:52 |
| morganfainberg | bknudson, yeah stevemar didn't hit +a | 18:52 |
| ayoung | the distinction matters to me | 18:52 |
| morganfainberg | ayoung, ok. let me figure out what test_auth_with_id keeps failing | 18:53 |
| morganfainberg | why* | 18:53 |
| morganfainberg | i can't duplicate that failure locally, but it seems to keep failing in gate | 18:53 |
| morganfainberg | erm jenkins | 18:53 |
| ayoung | morganfainberg, what backend is it hitting? | 18:53 |
| *** Shaan7 is now known as Shaan7_away | 18:53 | |
| bknudson | morganfainberg: are you clearing out your vendor directory? | 18:54 |
| *** mdomsch has quit IRC | 18:54 | |
| morganfainberg | bknudson, ah, no. | 18:54 |
| *** mfer has joined #openstack-dev | 18:54 | |
| morganfainberg | bknudson, that might be it. | 18:54 |
| *** troytoman-away is now known as troytoman | 18:54 | |
| morganfainberg | oh huh | 18:54 |
| ayoung | we do evil there | 18:55 |
| morganfainberg | well, i did group those tests onto a single worker | 18:55 |
| morganfainberg | so we don't need to download things once per worker potentially | 18:55 |
| *** MaxV has joined #openstack-dev | 18:55 | |
| *** MaxV has quit IRC | 18:55 | |
| morganfainberg | i think we have some test isolation issues. | 18:55 |
| morganfainberg | seeing other tests sporadically failing | 18:56 |
| morganfainberg | https://jenkins01.openstack.org/job/gate-keystone-python27/4647/consoleFull | 18:56 |
| morganfainberg | test_delete_new_default_domain | 18:56 |
| morganfainberg | oh wait | 18:56 |
| morganfainberg | crud. wrong review | 18:57 |
| morganfainberg | *sigh* logs look an aweful lot the same sometimes | 18:57 |
| *** buzztroll has quit IRC | 18:57 | |
| morganfainberg | yeah just test_auth_with_id no other test failures | 18:57 |
| morganfainberg | https://jenkins01.openstack.org/job/gate-keystone-python27/4644/console | 18:57 |
| ayoung | notice that the https on that jenkins machine depdns on a self signed certificate | 18:58 |
| morganfainberg | ayoung, on a couple of the jenkins systems | 18:58 |
| morganfainberg | i think a couple don't | 18:58 |
| *** rwsu has joined #openstack-dev | 18:59 | |
| *** jmontemayor has quit IRC | 19:00 | |
| morganfainberg | restful testcase uses KVS backend, right? | 19:00 |
| *** herndon_ has joined #openstack-dev | 19:01 | |
| *** dbalog has quit IRC | 19:02 | |
| *** safchain has quit IRC | 19:02 | |
| *** herndon_ has quit IRC | 19:02 | |
| *** browne has joined #openstack-dev | 19:03 | |
| *** andreaf has quit IRC | 19:03 | |
| ayoung | morganfainberg, what platform are you developing on? | 19:04 |
| *** Farooque has quit IRC | 19:04 | |
| morganfainberg | ayoung, I develop on OS X, but i run tests on ubuntu (precise) and fedora... 19? | 19:04 |
| ayoung | and what version of tox? | 19:05 |
| morganfainberg | 1.6.1 | 19:05 |
| *** rossella_s has quit IRC | 19:05 | |
| morganfainberg | (fedora VM) | 19:05 |
| *** johnthetubaguy has quit IRC | 19:06 | |
| *** mrodden1 has quit IRC | 19:06 | |
| morganfainberg | ah, restful testcase uses sqlite | 19:06 |
| morganfainberg | (by default) | 19:06 |
| ayoung | yep | 19:07 |
| *** mrodden has joined #openstack-dev | 19:08 | |
| *** mriedem has joined #openstack-dev | 19:09 | |
| *** willingc has joined #openstack-dev | 19:09 | |
| morganfainberg | ok, i am not seeing how http://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/test_v3_auth.py#n1565 is failing w/o other tests failing. | 19:10 |
| *** troytoman is now known as troytoman-away | 19:10 | |
| morganfainberg | it's that one thats failed consistently in the jenkins server | 19:10 |
| *** ayoung has quit IRC | 19:11 | |
| *** herndon_ has joined #openstack-dev | 19:11 | |
| *** danielbruno has quit IRC | 19:11 | |
| *** danielbruno has joined #openstack-dev | 19:11 | |
| *** danielbruno has quit IRC | 19:11 | |
| *** danielbruno has joined #openstack-dev | 19:11 | |
| *** dstanek has quit IRC | 19:13 | |
| *** troytoman-away is now known as troytoman | 19:14 | |
| dolphm | morganfainberg: it's a fairly simple test too :( | 19:15 |
| *** pmathews has quit IRC | 19:15 | |
| morganfainberg | dolphm, yeah | 19:15 |
| bknudson | dolphm: you were +2 on this before, still https://review.openstack.org/#/c/60408/ ? | 19:15 |
| morganfainberg | it's failing on the first auth attempt, to get the unscoped token | 19:15 |
| *** troytoman is now known as troytoman-away | 19:15 | |
| *** jmontemayor has joined #openstack-dev | 19:15 | |
| *** troytoman-away is now known as troytoman | 19:15 | |
| morganfainberg | i think. | 19:15 |
| dolphm | bknudson: approving | 19:15 |
| *** romcheg has quit IRC | 19:15 | |
| bknudson | thanks | 19:16 |
| *** dbalog has joined #openstack-dev | 19:17 | |
| *** _ruhe is now known as ruhe | 19:18 | |
| morganfainberg | dolphm, i think i found it | 19:18 |
| morganfainberg | maybe. | 19:18 |
| *** jnoller has quit IRC | 19:18 | |
| morganfainberg | oh interesting | 19:19 |
| dolphm | morganfainberg: ?! | 19:19 |
| dolphm | morganfainberg: did you repro? | 19:19 |
| morganfainberg | red herring. | 19:19 |
| morganfainberg | but we have some odd errors when you look at the actual logs | 19:19 |
| morganfainberg | making notes on needing cleanup | 19:20 |
| morganfainberg | nothing critical | 19:20 |
| *** pmathews has joined #openstack-dev | 19:20 | |
| morganfainberg | but i think we can cleanup some of these longer-term | 19:20 |
| *** mdomsch has joined #openstack-dev | 19:23 | |
| *** sarob_ has joined #openstack-dev | 19:23 | |
| *** sarob has quit IRC | 19:27 | |
| *** sarob_ has quit IRC | 19:28 | |
| *** herndon_ has quit IRC | 19:28 | |
| *** reed has quit IRC | 19:28 | |
| *** tkay has quit IRC | 19:28 | |
| *** danpb has quit IRC | 19:31 | |
| *** sarob has joined #openstack-dev | 19:32 | |
| *** pdevine has quit IRC | 19:35 | |
| morganfainberg | dolphm, i'm only seeing a couple ways we could 401 out of that test. | 19:35 |
| morganfainberg | dolphm, i'm chasing down all the possibilities but i'm baffled why neither of us can repro this locally | 19:36 |
| *** tkay has joined #openstack-dev | 19:36 | |
| morganfainberg | I even did a clean venv and a git clean -fdx | 19:36 |
| morganfainberg | so it should be 100% clean environment, no joy on repro | 19:36 |
| *** Longgeek has joined #openstack-dev | 19:37 | |
| *** KeithSharp has quit IRC | 19:37 | |
| *** mrodden has quit IRC | 19:38 | |
| *** spzala has quit IRC | 19:38 | |
| *** KeithSharp has joined #openstack-dev | 19:39 | |
| *** mrodden has joined #openstack-dev | 19:39 | |
| *** tkay has quit IRC | 19:41 | |
| *** Longgeek has quit IRC | 19:42 | |
| *** novas0x2a|laptop has joined #openstack-dev | 19:43 | |
| *** denis_makogon_ has joined #openstack-dev | 19:43 | |
| *** denis_makogon_ is now known as denis_makogon | 19:45 | |
| *** dims is now known as dimsum | 19:45 | |
| sdague | harlowja: so, how's the taskflow release? | 19:46 |
| *** xarses has quit IRC | 19:47 | |
| *** xarses_ has joined #openstack-dev | 19:48 | |
| *** pmathews has quit IRC | 19:48 | |
| *** xarses_ is now known as xarses | 19:48 | |
| *** thedodd has quit IRC | 19:49 | |
| *** jnoller has joined #openstack-dev | 19:49 | |
| *** yolanda has quit IRC | 19:49 | |
| harlowja | sdague yup, one more review to go through, waiting for jeknins/zuul to unblock | 19:49 |
| *** MaxV has joined #openstack-dev | 19:50 | |
| *** xarses has joined #openstack-dev | 19:50 | |
| *** ruhe is now known as _ruhe | 19:51 | |
| *** doug_shelley66 has quit IRC | 19:53 | |
| *** thuc has quit IRC | 19:53 | |
| *** thuc has joined #openstack-dev | 19:53 | |
| *** MaxV has quit IRC | 19:53 | |
| *** doug_shelley66 has joined #openstack-dev | 19:53 | |
| *** jesusaurus has joined #openstack-dev | 19:56 | |
| harlowja | sdague tagged, should showup automatically on pypi soon | 19:56 |
| harlowja | and there it is | 19:56 |
| sdague | cool | 19:56 |
| jesusaurus | what is the climate project? https://wiki.openstack.org/wiki/Climate seems a bit bare :/ | 19:57 |
| *** edmund1 has joined #openstack-dev | 19:57 | |
| *** thuc has quit IRC | 19:58 | |
| *** rfolco has quit IRC | 19:59 | |
| *** thuc has joined #openstack-dev | 19:59 | |
| *** vipuls is now known as vipuls-away | 20:00 | |
| *** vipuls-away is now known as vipuls | 20:00 | |
| *** rockyg has joined #openstack-dev | 20:00 | |
| *** pmathews has joined #openstack-dev | 20:01 | |
| harlowja | sdague https://github.com/stackforge/taskflow/blob/0.1.2/requirements.txt should be much more future proof | 20:01 |
| harlowja | and https://review.openstack.org/#/c/65135/ will help taskflow test against sqlalchemy variations | 20:02 |
| sdague | harlowja: great | 20:03 |
| sdague | haleyb: thanks | 20:03 |
| *** jmontemayor has quit IRC | 20:04 | |
| *** jmontemayor has joined #openstack-dev | 20:05 | |
| *** dbalog has quit IRC | 20:05 | |
| *** troytoman is now known as troytoman-away | 20:05 | |
| *** Noah_ has joined #openstack-dev | 20:07 | |
| *** pmathews has quit IRC | 20:08 | |
| *** otherwiseguy has joined #openstack-dev | 20:09 | |
| *** galstrom_zzz is now known as galstrom | 20:10 | |
| *** Farooque has joined #openstack-dev | 20:11 | |
| Noah_ | hey guys | 20:11 |
| Noah_ | this may be a silly thing to say - but here goes: | 20:11 |
| Noah_ | I'm going to be working on and with Oslo, and I'm wondering if its packaged into any openstack releases / branches | 20:12 |
| Noah_ | seems a bit unclear fron the docs | 20:12 |
| Noah_ | from* | 20:12 |
| *** pdevine has joined #openstack-dev | 20:13 | |
| Noah_ | specifically: oslo.messaging | 20:13 |
| Noah_ | never-mind i see it on launchpad. ignore me. . . | 20:15 |
| *** vipuls is now known as vipuls-away | 20:15 | |
| *** herndon_ has joined #openstack-dev | 20:15 | |
| Noah_ | if anyone cares: https://launchpad.net/ubuntu/trusty/+source/oslo.messaging | 20:16 |
| *** Noah_ has left #openstack-dev | 20:16 | |
| *** jnoller has quit IRC | 20:17 | |
| *** dbalog has joined #openstack-dev | 20:18 | |
| *** hartbot is now known as bad_joke_eel | 20:21 | |
| *** sarob has quit IRC | 20:23 | |
| *** sarob has joined #openstack-dev | 20:23 | |
| *** gokrokve has quit IRC | 20:25 | |
| *** kgriffs is now known as kgriffs_afk | 20:27 | |
| *** sushils has quit IRC | 20:27 | |
| bad_joke_eel | Yeah, so I wanted to figure out how to work with Oslo myself. So far there's this process where by sometimes code comes from other projects and goes into Oslo… other times code comes out of Oslo and into other projects. | 20:27 |
| *** sarob has quit IRC | 20:28 | |
| bad_joke_eel | It's all done by copying the code as far as I can tell. | 20:28 |
| morganfainberg | oh it must be friday | 20:28 |
| *** _cjones_ has joined #openstack-dev | 20:28 | |
| bad_joke_eel | That's why I'm so... | 20:28 |
| bad_joke_eel | fried | 20:28 |
| bad_joke_eel | heh heh heh | 20:28 |
| *** utlemming has quit IRC | 20:30 | |
| *** prad has quit IRC | 20:32 | |
| morganfainberg | bad_joke_eel, ok ok... you deserve a snicker for that one | 20:32 |
| *** browne has quit IRC | 20:33 | |
| *** epim has joined #openstack-dev | 20:33 | |
| dolphm | morganfainberg: small change here since you approved it https://review.openstack.org/#/c/64856/ | 20:34 |
| morganfainberg | oh yeah, the delattr part? | 20:35 |
| *** rods has quit IRC | 20:35 | |
| morganfainberg | yeah still looks good, going to re-approve | 20:35 |
| *** henrynash has joined #openstack-dev | 20:36 | |
| *** browne has joined #openstack-dev | 20:36 | |
| henrynash | dolphm: ping | 20:36 |
| *** epim has quit IRC | 20:36 | |
| dolphm | henrynash: pong! | 20:36 |
| morganfainberg | henrynash, !! | 20:36 |
| henrynash | dolphm: so, I am coming to Texas next week... | 20:36 |
| *** arnaud has quit IRC | 20:37 | |
| dolphm | henrynash: i was just about to ask :) | 20:37 |
| *** utlemming has joined #openstack-dev | 20:37 | |
| *** changbl has joined #openstack-dev | 20:37 | |
| henrynash | dolphm: can you remind me of the location? | 20:37 |
| morganfainberg | henrynash, woot! | 20:37 |
| dolphm | henrynash: everything should be here https://gist.github.com/dolph/5cfa70c02f5b141060c5 | 20:37 |
| *** epim has joined #openstack-dev | 20:37 | |
| henrynash | morganfaiberg: thx | 20:37 |
| henrynash | dolphm: perfect | 20:37 |
| nkinder | dolphm: ping | 20:37 |
| dolphm | nkinder: o/ | 20:38 |
| henrynash | dolphm: I won't get in till very late on the Tuesday, so see you Wednesday morning | 20:38 |
| nkinder | dolphm: I'm writing up the OSSN for the external auth issue where we split REMOTE_USER by the "@" char | 20:38 |
| *** bad_joke_eel has quit IRC | 20:38 | |
| *** arnaud has joined #openstack-dev | 20:38 | |
| nkinder | dolphm: I just want to confirm the plan... | 20:38 |
| dolphm | henrynash: sounds good! | 20:38 |
| *** hartsocks has joined #openstack-dev | 20:38 | |
| morganfainberg | henrynash, such is travel across the pond eh? | 20:39 |
| dolphm | nkinder: ooh, i haven't followed up on that this week yet... do you have a link to the bug? | 20:39 |
| nkinder | dolphm: sure, one sec | 20:39 |
| nkinder | dolphm: ayoung took over it too | 20:39 |
| henrynash | morganfainberg: especially when you have to go visit one's office in North Carolina on the way over! | 20:39 |
| nkinder | dolphm: here's the review - https://review.openstack.org/#/c/50362/ | 20:39 |
| morganfainberg | henrynash, hah | 20:39 |
| dolphm | henrynash: ha | 20:40 |
| morganfainberg | henrynash, well glad you're going to make it. | 20:40 |
| nkinder | dolphm: and the bug is here - https://bugs.launchpad.net/keystone/+bug/1254619 | 20:40 |
| henrynash | morganfainberg: bald to be coming, I've been off the radar for a bit due to other work load…time to take up the slack | 20:40 |
| henrynash | even glad to be coming | 20:40 |
| henrynash | blad ? | 20:40 |
| henrynash | bald? | 20:40 |
| morganfainberg | haha | 20:40 |
| nkinder | dolphm: I have the writeup completed, but I'm trying to determine what to say about future fixes we are planning. | 20:41 |
| henrynash | that may be happening too….sigh | 20:41 |
| *** Longgeek has joined #openstack-dev | 20:41 | |
| *** thedodd has joined #openstack-dev | 20:41 | |
| nkinder | dolphm: if we plan on doing something for this in havana, it seems like I should say that | 20:41 |
| dolphm | nkinder: do you have that in a gist/paste/etherpad? | 20:41 |
| *** epim has quit IRC | 20:42 | |
| *** epim_ has joined #openstack-dev | 20:42 | |
| dolphm | nkinder: yeah, how this is address in havana is the delicate point here | 20:42 |
| *** hartsocks is now known as hartbot | 20:42 | |
| *** vartom111111117 has joined #openstack-dev | 20:42 | |
| dolphm | henrynash: bald we'll be seeing you next week | 20:42 |
| nkinder | dolphm: http://paste.openstack.org/show/61007/ | 20:43 |
| henrynash | dolphm: :-) | 20:43 |
| nkinder | dolphm: apologies for the lack of line-wrapping | 20:43 |
| dolphm | henrynash: i'll be sure to get a haircut to honor your arrival | 20:43 |
| henrynash | dolphm: appreciated | 20:43 |
| nkinder | dolphm: let me get you a more readable paste | 20:43 |
| dolphm | nkinder: raw solves that nicely http://paste.openstack.org/raw/61007/ | 20:44 |
| nkinder | ah, cool | 20:44 |
| *** tkay has joined #openstack-dev | 20:45 | |
| *** jmckind has joined #openstack-dev | 20:45 | |
| *** Longgeek has quit IRC | 20:46 | |
| *** Farooque has quit IRC | 20:46 | |
| dolphm | nkinder: summary and discussion LGTM | 20:47 |
| *** baoli_ has joined #openstack-dev | 20:47 | |
| dolphm | nkinder: let me review the latest patchset before reading the rest | 20:47 |
| nkinder | dolphm: k | 20:47 |
| *** spzala has joined #openstack-dev | 20:48 | |
| *** hartbot has left #openstack-dev | 20:49 | |
| *** sarob has joined #openstack-dev | 20:49 | |
| *** sarob_ has joined #openstack-dev | 20:51 | |
| *** Jelle1 is now known as AbyssOne | 20:51 | |
| dolphm | nkinder: so, this gets really confusing when the patch is renaming all of these plugin classes :( | 20:51 |
| *** mjfork has joined #openstack-dev | 20:52 | |
| *** dprince has quit IRC | 20:52 | |
| *** browne has quit IRC | 20:52 | |
| nkinder | dolphm: yes, there's that too. The names I used are deprecated, though the config in Havana uses ExternalDefault in the example. | 20:52 |
| nkinder | dolphm: I can use the new class names and state that it was renamed | 20:52 |
| dolphm | nkinder: maybe refer to them using both, along with the corresponding release? so something like Havana's ExternalDefault (i.e. Icehouse's DefaultDomain) | 20:54 |
| *** fire has quit IRC | 20:54 | |
| *** sarob has quit IRC | 20:54 | |
| *** sandywalsh has quit IRC | 20:55 | |
| dolphm | this may also be impacted by a backport in havana, so there will be two sets of plugins depending on which minor version of havana you're looking at? :( | 20:55 |
| *** MaxV has joined #openstack-dev | 20:58 | |
| nkinder | dolphm: yes, that gets confusing too. | 20:58 |
| dolphm | i'm trying to put together a complete mapping of what is what | 20:58 |
| *** kevinconway_ has joined #openstack-dev | 20:58 | |
| nkinder | dolphm: I don't want to be too predictive of things that aren't developed yet either. | 20:58 |
| nkinder | It might make sense to update the OSSN if we fix this for a havana update | 20:59 |
| dolphm | nkinder: agree | 20:59 |
| *** kevinconway has quit IRC | 21:00 | |
| *** Farooque has joined #openstack-dev | 21:01 | |
| *** MaxV has quit IRC | 21:02 | |
| *** Farooque has left #openstack-dev | 21:02 | |
| *** prad has joined #openstack-dev | 21:03 | |
| *** pmathews has joined #openstack-dev | 21:03 | |
| *** kevinconway_ has quit IRC | 21:03 | |
| *** kevinconway has joined #openstack-dev | 21:03 | |
| *** thurloat has quit IRC | 21:04 | |
| *** KeithSharp has quit IRC | 21:05 | |
| *** reed has joined #openstack-dev | 21:05 | |
| *** aburaschi has quit IRC | 21:05 | |
| *** tsv has joined #openstack-dev | 21:06 | |
| *** KeithSharp has joined #openstack-dev | 21:06 | |
| *** thurloat has joined #openstack-dev | 21:06 | |
| *** csd has quit IRC | 21:06 | |
| *** sandywalsh has joined #openstack-dev | 21:06 | |
| *** vipuls-away is now known as vipuls | 21:08 | |
| *** browne has joined #openstack-dev | 21:09 | |
| *** sarob_ has quit IRC | 21:15 | |
| *** sarob has joined #openstack-dev | 21:15 | |
| *** DennyZhang has joined #openstack-dev | 21:18 | |
| *** asalkeld has quit IRC | 21:19 | |
| *** sarob has quit IRC | 21:19 | |
| *** sarob_ has joined #openstack-dev | 21:19 | |
| *** tdruiva has quit IRC | 21:21 | |
| *** CaptTofu has quit IRC | 21:24 | |
| *** amcrn has joined #openstack-dev | 21:24 | |
| *** ekhugen has joined #openstack-dev | 21:24 | |
| *** CaptTofu has joined #openstack-dev | 21:24 | |
| *** mgagne1 has quit IRC | 21:27 | |
| *** terryw has joined #openstack-dev | 21:28 | |
| *** SergeyLukjanov has quit IRC | 21:29 | |
| *** otherwiseguy has quit IRC | 21:30 | |
| *** glenng has quit IRC | 21:31 | |
| *** joesavak has quit IRC | 21:32 | |
| *** vipuls is now known as vipuls-away | 21:36 | |
| *** vipuls-away is now known as vipuls | 21:36 | |
| bknudson | morganfainberg: weren't you having this problem with the parallel testing? "AppError: Bad response: 403 Forbidden (not 200 OK or 3xx redirect for ..." | 21:37 |
| bknudson | https://review.openstack.org/#/c/64575/ | 21:37 |
| morganfainberg | bknudson, 401 | 21:37 |
| *** browne has quit IRC | 21:37 | |
| morganfainberg | bknudson, the one i've been having issues with is test_auth_with_id | 21:37 |
| morganfainberg | but. very similar | 21:37 |
| morganfainberg | i am not seeing how this test is faiing where other ones work. | 21:38 |
| bknudson | ok, well these are my new tests so must be something with the rebase. | 21:38 |
| *** ahmeda has quit IRC | 21:38 | |
| bknudson | morganfainberg: ahh, the operation works now rather than failing because of a change that was merged where you fixed to use CONF.identity.default_domain_id correctly. | 21:41 |
| *** browne has joined #openstack-dev | 21:41 | |
| morganfainberg | ah | 21:41 |
| morganfainberg | bknudson, sorry :P | 21:42 |
| *** sushils has joined #openstack-dev | 21:42 | |
| *** csd has joined #openstack-dev | 21:42 | |
| *** xarses has quit IRC | 21:43 | |
| *** xarses_ has joined #openstack-dev | 21:43 | |
| *** xarses_ is now known as xarses | 21:43 | |
| morganfainberg | bknudson, ugh | 21:43 |
| morganfainberg | i need to move the vendor directory as well | 21:43 |
| bknudson | move it? | 21:44 |
| morganfainberg | looks like that is tieing things up in odd ways | 21:44 |
| morganfainberg | yeah | 21:44 |
| morganfainberg | that is my issue | 21:44 |
| *** Longgeek has joined #openstack-dev | 21:44 | |
| bknudson | what's the difference where it is? | 21:44 |
| morganfainberg | it's getting stomped on | 21:44 |
| morganfainberg | tests/tmp/PID/vendor rather than uhm wherever it goes now | 21:44 |
| morganfainberg | basically, no way for two workers to step on each other | 21:44 |
| bknudson | it's going to take forever if have to check out every time. | 21:44 |
| morganfainberg | no no | 21:45 |
| morganfainberg | those tests _should_ be grouped | 21:45 |
| morganfainberg | but, if some aren't for some reason, it should be isolated to the specific worker | 21:45 |
| morganfainberg | dolphm, w00t just duplicated the issue! | 21:45 |
| morganfainberg | i don't think i've ever felt good about a bug like this... | 21:45 |
| *** dstanek has joined #openstack-dev | 21:46 | |
| morganfainberg | bknudson, i'll see if that is needed actually, might not be an issue | 21:46 |
| *** DennyZhang has quit IRC | 21:46 | |
| morganfainberg | or might just need some regex fixes | 21:46 |
| bknudson | that's weird it's a regex to group? | 21:47 |
| morganfainberg | yeah | 21:47 |
| *** DennyZhang has joined #openstack-dev | 21:47 | |
| morganfainberg | it groups based upon group(0) | 21:47 |
| bknudson | can testresources be used to group as well? | 21:47 |
| morganfainberg | bknudson, as we move towards testresources, i think so | 21:47 |
| bknudson | even if you don't make the clients an actual testresource | 21:48 |
| morganfainberg | it was recommended we do this the simple way to start | 21:48 |
| morganfainberg | and do iterations | 21:48 |
| morganfainberg | i don't think testresources solves this specific issue | 21:48 |
| morganfainberg | unless we use the testresources to do the lifting | 21:49 |
| morganfainberg | e.g. clone etc | 21:49 |
| bknudson | morganfainberg: what's the issue? I thought testresources caused the tests to essentially be grouped. | 21:49 |
| morganfainberg | bknudson, i was talking w/ lifeless last night | 21:49 |
| *** Sumeniac has quit IRC | 21:49 | |
| bknudson | testresources doesn't cause the tests to be grouped? | 21:49 |
| morganfainberg | not sure if there is a specific effect or not | 21:50 |
| morganfainberg | i'm not that familiar with test resources | 21:50 |
| *** Longgeek has quit IRC | 21:50 | |
| bknudson | I used it on the client for a change... | 21:50 |
| bknudson | it was pretty slick. | 21:50 |
| morganfainberg | my plan was get parallel stuff working | 21:50 |
| morganfainberg | then start making other changes | 21:50 |
| morganfainberg | rather than reworking a bunch of tests and then doing it again to solve parallel issues | 21:50 |
| morganfainberg | but, right now i'm chasing a specific failure. | 21:51 |
| morganfainberg | keeps happening | 21:51 |
| morganfainberg | but i don't know why | 21:51 |
| morganfainberg | and it's not specifically related to the client | 21:51 |
| *** vipuls is now known as vipuls-away | 21:51 | |
| morganfainberg | just, saw the client was having other oddities | 21:52 |
| morganfainberg | might justify grouping, or testresources, etc as the next phase | 21:52 |
| morganfainberg | s/client/vendor checkout thing | 21:52 |
| *** teran has quit IRC | 21:52 | |
| *** danielbruno has quit IRC | 21:56 | |
| *** CaptTofu has quit IRC | 21:58 | |
| *** gokrokve has joined #openstack-dev | 21:58 | |
| *** CaptTofu has joined #openstack-dev | 21:58 | |
| *** che-arne has quit IRC | 21:59 | |
| *** retr0h has quit IRC | 21:59 | |
| *** jasondotstar has quit IRC | 21:59 | |
| *** ayoung has joined #openstack-dev | 21:59 | |
| *** jdob has quit IRC | 22:00 | |
| morganfainberg | ok.. wtf. | 22:01 |
| *** retr0h has joined #openstack-dev | 22:01 | |
| *** eharney has quit IRC | 22:03 | |
| *** peristeri has quit IRC | 22:06 | |
| *** pdevine is now known as agntdrake | 22:06 | |
| *** galstrom is now known as galstrom_zzz | 22:07 | |
| *** baoli_ has quit IRC | 22:08 | |
| *** nermina has joined #openstack-dev | 22:08 | |
| *** DennyZhang has quit IRC | 22:10 | |
| *** mdomsch has quit IRC | 22:12 | |
| *** sarob_ is now known as sarob | 22:12 | |
| *** dimsum has quit IRC | 22:15 | |
| *** jgrimm has quit IRC | 22:16 | |
| *** doug_shelley66 has quit IRC | 22:16 | |
| *** erkrnt has joined #openstack-dev | 22:16 | |
| *** radez is now known as radez_g0n3 | 22:16 | |
| *** willingc has quit IRC | 22:16 | |
| *** giulivo has quit IRC | 22:17 | |
| *** sgordon has quit IRC | 22:17 | |
| *** willingc has joined #openstack-dev | 22:18 | |
| *** vladikr has quit IRC | 22:18 | |
| *** burt has quit IRC | 22:19 | |
| *** mlavalle has quit IRC | 22:20 | |
| *** mfer has quit IRC | 22:21 | |
| *** Underbyte has quit IRC | 22:21 | |
| *** alexpilotti has joined #openstack-dev | 22:22 | |
| *** jmckind has quit IRC | 22:23 | |
| *** bswartz has quit IRC | 22:24 | |
| *** FunnyLookinHat has quit IRC | 22:28 | |
| *** Underbyte has joined #openstack-dev | 22:29 | |
| *** nurla has quit IRC | 22:30 | |
| *** mattymo has quit IRC | 22:30 | |
| *** zasimov has quit IRC | 22:30 | |
| *** nurla has joined #openstack-dev | 22:30 | |
| *** zasimov has joined #openstack-dev | 22:31 | |
| *** mattymo has joined #openstack-dev | 22:31 | |
| dolphm | ayoung: followed up your revision to https://review.openstack.org/#/c/50362/ with a few more bits and +2'd | 22:31 |
| dolphm | morganfainberg: reading back... | 22:31 |
| morganfainberg | dolphm, got it to fail. | 22:31 |
| morganfainberg | dolphm, then... last three runs... | 22:31 |
| morganfainberg | no more failure | 22:31 |
| *** rtheis has quit IRC | 22:31 | |
| morganfainberg | all i changed was some debug lines :( | 22:32 |
| dolphm | morganfainberg: testr run --until-failure | 22:32 |
| morganfainberg | AHA | 22:32 |
| morganfainberg | ok so. | 22:32 |
| morganfainberg | ... i think i found the issue | 22:32 |
| morganfainberg | or at least possibly part of it | 22:32 |
| dolphm | (i actually used that this morning using the entire class (TestAuthJSON?), and never saw it | 22:32 |
| *** dimsum has joined #openstack-dev | 22:32 | |
| *** ekhugen has quit IRC | 22:33 | |
| morganfainberg | restful test case is supposed to use sql | 22:33 |
| morganfainberg | afaict | 22:33 |
| morganfainberg | however, somehow it's referencing the KVS back | 22:33 |
| morganfainberg | for identity | 22:33 |
| *** ozialien has quit IRC | 22:34 | |
| dolphm | morganfainberg: bah. it used to use kvs only, and i think we moved it to sql as much as we could | 22:36 |
| morganfainberg | yeah so now i'm looking at testcase standup. | 22:36 |
| ayoung | aloga, can you bless my cleanups to https://review.openstack.org/#/c/50362/ and I'll approve? | 22:37 |
| morganfainberg | and it is really a heisenbug style. | 22:37 |
| morganfainberg | it's hard to repro consistently | 22:37 |
| morganfainberg | couldn't repro it on fedora 19 | 22:37 |
| morganfainberg | took a number of iterations on a new ubuntu precise vm | 22:37 |
| ayoung | gyee, BTW, not ignoring your comments on ^^, just think we should take it as is....if you feel really strongly, we can hold it up, but it is fixing a pretty important brokeness.. | 22:37 |
| ayoung | morganfainberg, that is what parallelism does: | 22:38 |
| morganfainberg | ayoung, it exposes badly designed isolation? ;) | 22:38 |
| morganfainberg | or.. badly implemented | 22:38 |
| morganfainberg | design might be fine | 22:38 |
| gyee | ayoung, no problem more of an suggestion then objection | 22:38 |
| ayoung | cool | 22:38 |
| ayoung | morganfainberg, http://adam.younglogic.com/2007/07/the-bug-at-penguin/ speaking of bugs and parallelism....read when you get a chance | 22:39 |
| morganfainberg | dolphm, i think the thing that stands out the most is that the error doesn't actually log cache layer info, meaning we're really out in the weeds somewhere. | 22:40 |
| morganfainberg | when the bug happens | 22:40 |
| morganfainberg | ayoung, tagged to read once i get more coffee methinks. | 22:40 |
| ayoung | morganfainberg, good that will give me time to go back and clean up the typos | 22:40 |
| *** vipuls-away is now known as vipuls | 22:40 | |
| *** thomasem has quit IRC | 22:43 | |
| *** noslzzp has joined #openstack-dev | 22:44 | |
| *** retr0h has quit IRC | 22:47 | |
| *** prad has quit IRC | 22:49 | |
| *** achampion has quit IRC | 22:50 | |
| *** doug_shelley66 has joined #openstack-dev | 22:51 | |
| *** utlemming has quit IRC | 22:51 | |
| *** prad has joined #openstack-dev | 22:53 | |
| *** morazi has quit IRC | 22:53 | |
| *** markmcclain has quit IRC | 22:53 | |
| *** retr0h has joined #openstack-dev | 22:54 | |
| *** retr0h has quit IRC | 22:54 | |
| *** retr0h has joined #openstack-dev | 22:54 | |
| _cjones_ | ayoung, nice article. | 22:54 |
| *** alexpilotti has quit IRC | 22:55 | |
| *** utlemming has joined #openstack-dev | 22:55 | |
| nkinder | dolphm: so do your changes described in external-auth.rst for https://review.openstack.org/#/c/50362/ only apply for icehouse? | 22:57 |
| *** madmike has quit IRC | 22:58 | |
| *** dbalog has left #openstack-dev | 22:59 | |
| nkinder | dolphm: it also looks like you're doing away with splitting REMOTE_USER at all (using REMOTE_DOMAIN instead). | 22:59 |
| nkinder | seems like a good idea | 22:59 |
| *** CaptTofu has quit IRC | 23:01 | |
| *** utlemming has quit IRC | 23:02 | |
| *** erkrnt has quit IRC | 23:04 | |
| bknudson | does apache set REMOTE_DOMAIN? | 23:04 |
| *** thuc has quit IRC | 23:04 | |
| *** thuc has joined #openstack-dev | 23:05 | |
| *** edmund1 has left #openstack-dev | 23:05 | |
| *** jayg is now known as jayg|g0n3 | 23:06 | |
| *** CaptTofu has joined #openstack-dev | 23:06 | |
| *** thuc has quit IRC | 23:09 | |
| *** vijendar has quit IRC | 23:10 | |
| _cjones_ | ayoung, or morganfainberg: Doing more digging here. Can one of you, or another keystone guru answer how the "roles" table is linked to the user or group? Am I missing something here? | 23:10 |
| nkinder | bknudson: couldn't it be set with mod_headers or mod_setenvif? | 23:10 |
| *** Drankis has quit IRC | 23:11 | |
| bknudson | I guess you could make apache do anything with mods. | 23:12 |
| *** neelashah1 has quit IRC | 23:12 | |
| *** mikemar10 has quit IRC | 23:13 | |
| *** retr0h has quit IRC | 23:15 | |
| *** retr0h has joined #openstack-dev | 23:15 | |
| *** retr0h has quit IRC | 23:15 | |
| *** retr0h has joined #openstack-dev | 23:15 | |
| *** GheRivero_afk is now known as GheRivero | 23:16 | |
| *** rcleere has quit IRC | 23:16 | |
| *** xarses has quit IRC | 23:18 | |
| *** AlanClark has quit IRC | 23:20 | |
| *** herndon_ has quit IRC | 23:22 | |
| *** rnirmal has quit IRC | 23:22 | |
| *** thedodd has quit IRC | 23:24 | |
| *** nelsnelson has quit IRC | 23:26 | |
| *** browne has quit IRC | 23:26 | |
| *** browne has joined #openstack-dev | 23:28 | |
| *** terryw has quit IRC | 23:28 | |
| *** UKn0Me has quit IRC | 23:30 | |
| *** ozialien has joined #openstack-dev | 23:31 | |
| *** Longgeek has joined #openstack-dev | 23:33 | |
| *** henrynash has quit IRC | 23:33 | |
| *** GheRivero is now known as GheRivero_afk | 23:33 | |
| *** jdurgin1 has quit IRC | 23:33 | |
| *** CaptTofu has quit IRC | 23:34 | |
| *** vartom111111117 has quit IRC | 23:35 | |
| *** jdurgin1 has joined #openstack-dev | 23:37 | |
| *** bauzas has quit IRC | 23:37 | |
| *** Longgeek has quit IRC | 23:37 | |
| *** mlavalle has joined #openstack-dev | 23:39 | |
| ayoung | _cjones_, roles come from the assignment backend. They have a userid and or a groupid associated with them on one side, and project or domainid on the other | 23:40 |
| ayoung | since they are in separate backends, there is not referential integrity constraints | 23:40 |
| ayoung | and, in fact, there should not be | 23:40 |
| *** xarses has joined #openstack-dev | 23:40 | |
| _cjones_ | ayoung, ie. In user_domain_metadata or user_project_metadat? | 23:40 |
| ayoung | you can assign a user a role before they have come in from the identity side | 23:40 |
| ayoung | _cjones_, yeah...metadata, my least favorite word | 23:41 |
| ayoung | bknudson, REMOTE_DOMAIN probably not coming through | 23:41 |
| *** rockyg has quit IRC | 23:41 | |
| _cjones_ | ayoung, U.g.l.y, you ain't got no alibi... you ugly. | 23:41 |
| ayoung | but we are going to be extending the remote_user stuff pretty significantly with federation, I am not too concerned about it | 23:41 |
| _cjones_ | ayoung, s'ok. I figured it out. | 23:41 |
| ayoung | _cjones_, MAMA we know how you got that way | 23:42 |
| *** jobewan has quit IRC | 23:42 | |
| _cjones_ | ayoung, lol. | 23:42 |
| ayoung | good, cuz I'm taking the family out to dinner | 23:42 |
| _cjones_ | ayoung, sweet. cya Monday. | 23:42 |
| *** ayoung is now known as ayoung_omnomnom | 23:42 | |
| *** mlavalle has quit IRC | 23:42 | |
| *** vipuls is now known as vipuls-away | 23:44 | |
| *** vahidh has joined #openstack-dev | 23:46 | |
| *** alop_ has joined #openstack-dev | 23:46 | |
| *** galstrom_zzz is now known as galstrom | 23:47 | |
| *** UKn0Me has joined #openstack-dev | 23:48 | |
| *** mrodden has quit IRC | 23:49 | |
| *** alop has quit IRC | 23:50 | |
| *** alop_ is now known as alop | 23:50 | |
| *** kbrierly has quit IRC | 23:51 | |
| *** e0ne has quit IRC | 23:53 | |
| *** e0ne has joined #openstack-dev | 23:53 | |
| *** sarob has quit IRC | 23:53 | |
| *** sarob has joined #openstack-dev | 23:54 | |
| *** UKn0Me has quit IRC | 23:57 | |
| *** kevinconway has quit IRC | 23:57 | |
| *** sarob has quit IRC | 23:57 | |
| *** e0ne has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
