Thursday, 2012-07-26

*** mokas has joined #openstack-dev00:01
*** mnewby has quit IRC00:02
*** spiffxp has joined #openstack-dev00:03
*** steveb_ has joined #openstack-dev00:04
*** anniec has quit IRC00:08
*** issackelly has quit IRC00:09
*** thingee has quit IRC00:10
*** johnpostlethwait has quit IRC00:11
*** anniec has joined #openstack-dev00:16
*** johnpostlethwait has joined #openstack-dev00:24
*** Mandell has quit IRC00:25
*** matwood has quit IRC00:26
*** halfss has quit IRC00:27
*** novas0x2a|lapto1 has quit IRC00:27
*** johnpostlethwait has quit IRC00:28
*** Aaton is now known as Aaton_off00:34
*** s0mik has joined #openstack-dev00:35
*** gongys has quit IRC00:36
*** utlemming has joined #openstack-dev00:39
*** adjohn has joined #openstack-dev00:40
*** anniec has quit IRC00:40
*** s0mik has quit IRC00:43
*** pixelbeat has quit IRC00:44
*** johnpostlethwait has joined #openstack-dev00:47
*** anniec has joined #openstack-dev00:48
*** johnpostlethwait has quit IRC00:49
*** rods_ has quit IRC00:51
*** mokas has quit IRC00:52
*** andrewsmedina has joined #openstack-dev00:54
*** matwood has joined #openstack-dev00:55
*** s0mik has joined #openstack-dev00:59
*** dachary has quit IRC01:02
*** dachary has joined #openstack-dev01:02
*** spiffxp has quit IRC01:03
*** andrewsmedina has quit IRC01:06
*** nunosantos has quit IRC01:10
*** jog0 has quit IRC01:17
*** andrewsmedina has joined #openstack-dev01:18
*** jdurgin has quit IRC01:19
*** anniec has quit IRC01:22
*** s0mik has quit IRC01:24
*** danwent has quit IRC01:32
*** anniec has joined #openstack-dev01:50
*** zhuadl has joined #openstack-dev01:53
*** johnpostlethwait has joined #openstack-dev01:57
*** johnpostlethwait has quit IRC02:00
*** anniec_ has joined #openstack-dev02:02
*** anniec_ has quit IRC02:03
*** mokas has joined #openstack-dev02:04
*** anniec has quit IRC02:04
*** xchu has joined #openstack-dev02:07
*** sniperd has quit IRC02:10
*** sacharya has joined #openstack-dev02:12
*** littleidea has quit IRC02:14
*** danwent has joined #openstack-dev02:18
*** littleidea has joined #openstack-dev02:24
*** mestery has joined #openstack-dev02:31
*** roge has joined #openstack-dev02:36
*** JordanRinke has quit IRC02:38
*** JordanRinke has joined #openstack-dev02:38
*** troytoman-away is now known as troytoman02:40
*** xchu has quit IRC02:42
*** roge has quit IRC02:51
*** JordanRinke has joined #openstack-dev02:52
*** JordanRinke has quit IRC02:53
*** JordanRinke has joined #openstack-dev02:53
*** bencherian has quit IRC02:57
*** dachary has quit IRC03:02
*** dachary has joined #openstack-dev03:02
*** littleidea has quit IRC03:09
*** markmcclain has quit IRC03:23
*** ayoung_ has quit IRC03:24
*** adjohn has quit IRC03:26
*** adjohn has joined #openstack-dev03:27
*** eglynn_ has joined #openstack-dev03:38
*** eglynn has quit IRC03:41
*** andrewsmedina has quit IRC03:50
*** littleidea has joined #openstack-dev03:52
*** blamar has quit IRC03:57
*** dachary has quit IRC04:00
*** dachary has joined #openstack-dev04:00
*** littleidea has quit IRC04:07
*** zhuadl has quit IRC04:09
*** adjohn has quit IRC04:10
*** Ryan_Lane has joined #openstack-dev04:14
*** spiffxp has joined #openstack-dev04:16
*** littleidea has joined #openstack-dev04:17
*** danwent has quit IRC04:18
*** xchu has joined #openstack-dev04:23
*** Mandell has joined #openstack-dev04:24
*** sacharya has quit IRC04:30
*** anderstj has joined #openstack-dev04:33
*** Mandell has quit IRC04:33
*** littleidea has quit IRC04:35
vishyjeblair, mtaylor, LinuxJedi: looks like the update to use cinder in ci broke stable-essex merge: https://jenkins.openstack.org/job/gate-tempest-devstack-vm/4888/consoleFull04:36
vishyideas?04:36
*** dtroyer is now known as dtroyer_zzz04:39
*** jcooley has joined #openstack-dev04:40
clarkbwhich is expected because cinder isn't part of openstack in essex? Maybe we can have devstack-gate determine what the enabled services should be based on GERRIT_BRANCH04:40
clarkbvishy: ^04:42
vishyclarkb: we might have to have a stable/essex branch of devstack-gate04:43
vishyin fact I'm surprised we haven't needed one before.04:43
vishyclarkb: we have one for devstack already.04:43
*** salv-orlando has joined #openstack-dev04:45
clarkbI don't think I have the permissions to add a branch to devstack-gate, but that is a good idea. Then we can simply checkout GERRIT_BRANCH of devstack-gate when cleaning up the workspace04:49
jgriffithwell that's disappointing04:49
clarkbjeblair: mtaylor ^04:49
*** bencherian has joined #openstack-dev04:59
*** steveb_ has quit IRC05:01
*** spiffxp has quit IRC05:04
*** dtroyer_zzz is now known as dtroyer05:04
*** dachary has quit IRC05:06
*** dachary has joined #openstack-dev05:06
*** mokas has quit IRC05:07
*** danwent has joined #openstack-dev05:07
mtaylorclarkb: aroo?05:08
mtaylorvishy: EXCELLENT05:08
mtaylorvishy: wait! what? you're telling me that we didnt' have cinder in stable/essex???05:08
mtaylorvishy: dammit man!05:09
*** littleidea has joined #openstack-dev05:09
*** asakhnov has joined #openstack-dev05:10
clarkbI want an easy button that says "aroo?!"05:10
mtaylorjgriffith: I don't think we can add a branch... I think we need to backport cinder to stable/essex05:10
mtaylorclarkb: weechat plugin? :)05:10
jgriffithmtaylor: say whaaaaa05:10
mtaylorjgriffith: wait, you don't think my idea is better than clarkb's ?05:10
jgriffithmtaylor: I'm working on it now05:11
jgriffithmtaylor: I'm certain it's the best solution05:11
jgriffithDone... cp -R nova-folsom nova-essex-stable05:12
clarkbthat was easy05:13
clarkb:)05:13
jgriffithpheww... lots of work averted05:13
*** zhuadl has joined #openstack-dev05:14
*** zaitcev has quit IRC05:14
mtaylorjgriffith: thanks! that's so helpful05:14
jgriffithmtaylor: no problem... any time05:15
jgriffithmtaylor: Seriously though... we can add a gate branch right?05:16
jgriffithI'm out05:18
jgriffithmtaylor: lemme know if I can help with anything (other than backporting cinder to Essex that is)05:19
clarkbmtaylor: if you need inspiration http://www.youtube.com/watch?v=Igi1LSkASyE05:21
*** garyk has joined #openstack-dev05:24
mtaylorclarkb: thank you :)05:30
*** dtroyer is now known as dtroyer_zzz05:35
*** mokas has joined #openstack-dev05:36
*** matiu has quit IRC05:36
*** asakhnov has quit IRC05:38
*** markmc has joined #openstack-dev05:40
*** troytoman is now known as troytoman-away05:56
*** hattwick has quit IRC06:01
*** johnpostlethwait has joined #openstack-dev06:07
*** GheRivero has joined #openstack-dev06:18
*** anderstj has quit IRC06:22
*** sniperd has joined #openstack-dev06:31
*** dachary has quit IRC06:32
*** dachary has joined #openstack-dev06:33
*** littleidea has quit IRC06:33
*** dachary has quit IRC06:33
*** alex88 has joined #openstack-dev06:49
*** Ryan_Lane has quit IRC06:57
*** rohitk has joined #openstack-dev07:07
alex88hi guys, someone ever tried to live-migrate a vm with floating ip attached? i've tried and live migration works, but the DNAT rules are still on the old host07:10
*** Ryan_Lane has joined #openstack-dev07:13
*** amotoki has joined #openstack-dev07:19
ttxalex88: did the CI guys solve your CLA issue ?07:26
alex88ttx: they did, thanks!07:26
alex88i've filling a bug about the above problem07:27
ttx(apparently yesterday I bet in the one that was in vacation, sorry about that)07:27
alex88ttx: np, they told me there was a bug in the cron job07:27
*** erikzaadi has joined #openstack-dev07:31
*** lianhao has quit IRC07:31
*** Ryan_Lane has quit IRC07:32
*** Mandell has joined #openstack-dev07:33
*** djinni has quit IRC07:35
*** sulochan has joined #openstack-dev07:35
*** sdake has quit IRC07:36
*** sulochan_ has joined #openstack-dev07:36
*** djinni has joined #openstack-dev07:37
*** Mandell_ has joined #openstack-dev07:38
*** Mandell has quit IRC07:38
*** sulochan has quit IRC07:40
*** sulochan_ is now known as sulochan07:40
*** jcooley has quit IRC07:41
*** jcooley has joined #openstack-dev07:42
*** sdake has joined #openstack-dev07:45
*** steveb_ has joined #openstack-dev07:52
*** bencherian has quit IRC07:53
*** toey has joined #openstack-dev07:56
*** dubsquared has joined #openstack-dev08:04
*** johnpostlethwait has quit IRC08:11
*** robert-vanleeuwe has joined #openstack-dev08:13
*** derekh has joined #openstack-dev08:13
GheRiverohi people08:14
*** almaisan-away is now known as al-maisan08:21
*** dubsquared has quit IRC08:27
*** pixelbeat has joined #openstack-dev08:28
*** sdake has quit IRC08:29
*** darraghb has joined #openstack-dev08:31
salv-orlandoGheRivero: hi!08:31
*** toey has quit IRC08:36
*** danpb has joined #openstack-dev08:41
*** danwent has quit IRC08:43
*** hattwick has joined #openstack-dev08:43
*** sdake has joined #openstack-dev08:44
*** apevec has joined #openstack-dev08:50
*** dachary has joined #openstack-dev08:56
*** anniec has joined #openstack-dev08:59
*** anniec_ has joined #openstack-dev09:00
comstud  File "tools/hacking.py", line 389, in once_git_check_commit_title09:02
comstud    title = subprocess.check_output('git log --pretty=%s -1', shell=True)09:02
comstudAttributeError: 'module' object has no attribute 'check_output'09:02
comstudsomeone committed a 2.7 only thing09:02
*** anniec has quit IRC09:03
*** anniec_ is now known as anniec09:03
*** robert-vanleeuwe has quit IRC09:05
comstudmtaylor, jeblair: https://review.openstack.org/#/c/9994/  <- may want to check on how that passed python 2.6 gate.  subprocess.check_output was added in 2.709:06
*** Mandell_ has quit IRC09:31
*** steveb_ has quit IRC09:37
*** amotoki has quit IRC09:42
*** matwood has quit IRC09:46
*** dachary has quit IRC09:48
*** thovden has quit IRC09:53
*** matwood has joined #openstack-dev09:54
*** trapni has quit IRC10:07
*** trapni has joined #openstack-dev10:07
*** xchu has quit IRC10:17
*** ttx has quit IRC10:21
*** ttx has joined #openstack-dev10:21
*** ttx has quit IRC10:21
*** ttx has joined #openstack-dev10:21
*** nunosantos has joined #openstack-dev10:22
*** nunosantos_ has joined #openstack-dev10:22
*** rods_ has joined #openstack-dev10:24
*** thovden has joined #openstack-dev10:25
*** matwood has quit IRC10:41
*** Vek has quit IRC11:02
*** toey has joined #openstack-dev11:04
*** al-maisan is now known as almaisan-away11:10
garyksalv-orlando: ping11:16
*** andrea_ has joined #openstack-dev11:19
*** toey has quit IRC11:26
*** arosen has quit IRC11:31
*** zhuadl has quit IRC11:33
*** markvoelker has joined #openstack-dev11:37
*** wiliam has joined #openstack-dev11:41
*** arosen has joined #openstack-dev11:50
*** halfss has joined #openstack-dev11:57
salv-orlandogaryk: pong11:58
garyksalv-orlando, hey, how are you? can you help me for a few minutes? i am writing tests for the rpc. it is a bit of a nightmare11:59
salv-orlandosure. what's the problem?11:59
garyksalv-orlando, from wjhat i understand i am unable to test the entire system, so i just need to check the callbacks and thier methods. is this correct?12:00
salv-orlandoyes, the actual rpc class should be either stubbed out or mocked12:00
salv-orlandoI meant calls not class12:01
garyksalv-orlando, ok, thanks, i'll try that12:01
*** thovden has quit IRC12:05
*** epic has quit IRC12:09
*** epic has joined #openstack-dev12:09
*** mdomsch has joined #openstack-dev12:20
*** salgado has joined #openstack-dev12:25
*** dhellmann_ has joined #openstack-dev12:28
*** dhellmann_ has quit IRC12:29
*** salgado has quit IRC12:30
andrea_I am working an a change that require a new script for the SQLAlchemy migration tool, is there a process to follow to get a kind of reservation for a migration number?12:32
*** dhellmann has quit IRC12:33
markmcandrea_, just pick the next number12:36
markmcandrea_, if someone else does the same and their patch gets merged first, you'll just need to rebase and use the next number12:36
andrea_markmc: ok thanks12:38
andrea_I asked because I found an old message in the ML talking about a proposal for a reservation process (https://lists.launchpad.net/openstack/msg02680.html).12:39
andrea_thanks again12:39
*** toey has joined #openstack-dev12:45
*** sacharya has joined #openstack-dev12:47
*** dachary has joined #openstack-dev12:51
*** littleidea has joined #openstack-dev12:51
markmcdansmith, hey, there?12:52
*** kbringard has joined #openstack-dev12:52
*** kbringard has joined #openstack-dev12:53
*** blamar has joined #openstack-dev12:53
*** roge has joined #openstack-dev12:53
mtaylorcomstud: we don't run hacking/pep8 on both 27 and 26 - only on 2712:53
mtaylorcomstud: normally it wouldn't make any sense to run pep8 in both - but obviously nova wraps pep812:54
mtaylorperhaps we should put in a unit test which tests hacking?12:54
*** rkukura has quit IRC12:55
comstudhrm12:55
*** rkukura has joined #openstack-dev12:55
comstudtests would not even start for me12:55
comstuduntil the hacking thing was fixed12:55
comstudfor whatever reason.. i didn't look at why12:56
*** toey has quit IRC12:56
comstudalthough12:56
comstudi must have run with only -p or something12:56
* comstud checks12:56
comstudah i lied12:56
mtayloroh, you're still running run_tests.sh probably?12:57
comstudso Yeah.. I guess maybe unit tests should test hacking ;)12:57
comstudyeah i am12:57
comstud2 pep8 failures snuck in to trunk somehow too12:57
mtaylorright pep8 version?12:57
comstudyes12:57
comstudsomeone fixed it already12:57
comstudmerged12:58
comstudlast merge for nova12:58
*** GheRivero has quit IRC12:58
mtaylorlooking12:58
*** sacharya has quit IRC12:59
*** lorin1 has joined #openstack-dev13:02
mtaylorHAHAHAH13:02
*** Vek has joined #openstack-dev13:02
mtaylorok. that's funny13:03
*** japage has quit IRC13:03
*** japage has joined #openstack-dev13:04
mtaylorcomstud: we had an exclude for pep8 for "openstack" - to avoid re-checking openstack/common13:05
*** blamar has quit IRC13:05
markmcmtaylor, did you just had an orgasm looking at code in your terminal?13:05
* markmc searching for evidence of this13:05
markmchttp://www.cloudave.com/21107/two-years-of-openstack-looking-from-the-other-side/13:05
markmc"Open source world is dominated by developers who had dedicated their life to geekdom. They get their orgasm seeing the code in a terminal window."13:06
mtaylorcomstud: turns out, that matches nova/api/openstack/compute/contrib/console_output.py13:06
*** gargya has joined #openstack-dev13:06
mtaylorwow. we do?13:06
markmcapparently13:06
* markmc feels he's missing out13:06
mtaylorwait - we've dedicated our life to geekdom itself?13:06
markmcthat too13:06
mtayloralways seemed like a by-product to me, but whatevs13:06
comstudmtaylor: aha13:08
comstudso all of nova/api/openstack is/was not being tested?13:08
*** rkukura has quit IRC13:09
*** vanchester has joined #openstack-dev13:09
mtayloryup13:11
vanchesterHi. I am using swift + keystone + s3. Is it possible to authenticate with access_key='tenant:user' like in examples, cause it seems like it isn't?13:12
vanchesterI look at the code, it splits access_key with ':'. But it's many samples with 'tenant:user' access, maybe i do something wrong?13:14
*** dtroyer_zzz is now known as dtroyer13:18
*** galvint_ has joined #openstack-dev13:19
*** ayoung has joined #openstack-dev13:19
*** thovden has joined #openstack-dev13:20
*** mnewby has joined #openstack-dev13:21
*** dprince has joined #openstack-dev13:24
*** GheRivero has joined #openstack-dev13:24
mtaylorcomstud: working on a fix - turns out pep8 does its exclude testing in the most assinine manner known to man13:25
comstudhaha13:25
comstudno worries13:25
*** matiu_ is now known as matiu13:26
*** thovden has quit IRC13:26
*** littleidea has quit IRC13:27
*** thovden has joined #openstack-dev13:28
*** Hien has quit IRC13:30
dansmithmarkmc: I am now13:32
mtaylorcomstud: https://review.openstack.org/1034013:32
markmcdansmith, some comments in your review13:32
mtaylorcomstud: that's the best I got - not crazy about monkey patching, but what can you do?13:32
markmcdansmith, I'm going to post a couple of checks_instance_lock patches now too13:32
*** Hien has joined #openstack-dev13:33
dansmithmarkmc: hmm, so checks_instance_lock() returns False if locked, that's the behavior that the stuff above expects13:34
comstudmtaylor: you have a pep8 error in your pep8 fix13:34
dansmith...or it did, I didn't realize russellb's stuff had made it in yet13:34
comstud:)13:34
comstudpep8.excluded=excluded13:34
markmcdansmith, where is the return value used?13:34
comstudspaces13:34
mtaylorcomstud: hahaha13:34
mtaylorthanks13:34
comstudhaha13:34
markmcdansmith, I don't see any usage, apart from one unit test13:34
comstudno problem!13:34
dansmithmarkmc: on the other end of the rpc layer.. it's very obscure13:35
*** sacharya has joined #openstack-dev13:35
dansmiththere was a comment too, let me see if I can find it13:35
comstudpep8.input_dir=input_dir also13:35
mtaylorcomstud: fixed13:36
comstudthnx!13:38
dansmithmarkmc: hmm, well, I'm not spotting it.. maybe I'm just thinking of my prior attempt to catch the False and do something at the api layer13:38
markmcdansmith, yeah, eglynn has a patch where he does that for set_admin_password()13:39
markmcdansmith, which is what lead me down this path13:39
dansmithmarkmc: right13:39
markmcdansmith, patches coming soon, should explain all13:39
*** andrewsmedina has joined #openstack-dev13:40
dansmithmarkmc: are you going to do the state reversal, or just do cleanup upon which I should base another iteration?13:40
comstudok, almost 7am13:41
comstudtime for a nap13:41
* comstud & bbl13:41
mtaylorcomstud: https://github.com/jcrocholl/pep8/pull/11113:41
markmcdansmith, just the cleanup - see https://github.com/markmc/nova/commits/checks_instance_lock13:41
markmcdansmith, not done thinking over the state reversal thing, but here's a thought13:42
markmcdansmith, the client side is setting the task state13:42
markmcdansmith, and on the server side you're saying which states can be reverted13:42
markmcdansmith, definitely looks like a case of repeating ourselves13:42
markmcdansmith, why not e.g.13:42
markmc  with revert_task_state(instance, task_states.REBOOTING):13:43
markmc      self.compute_rpcapi.reboot_instance(instance)13:43
markmcdansmith, that's on the client side13:44
*** utlemming has quit IRC13:44
markmcdansmith, ah, because we're talking about casts - these are async actions13:44
dansmithmarkmc: right, I already went down that path :)13:44
dansmithit seems horrifically imbalanced to me, to do the set on one side and the revert on the other,13:45
dansmithbut c'est la via (or something like that)13:45
dansmither, vie13:45
markmcdansmith, ok, now I'm thinking that specifying the state that may be reverted on the server side is overkill13:45
markmcdansmith, when the task succeeds, it clears the state irrespective of what it currently is13:46
markmcdansmith, why do different on error?13:46
dansmithdoes it? where is that?13:46
markmcdansmith, well, e.g. in reboot_instance we just do:13:46
markmc        self._instance_update(context, instance['uuid'],13:47
markmc...                              task_state=None)13:47
*** djoyner has joined #openstack-dev13:47
markmcdansmith, there's no check that task_state is currently REBOOTING13:47
*** asakhnov has joined #openstack-dev13:48
dansmithoh, I see, I misunderstood you above.. I was thinking that the error case should be more cautious because we don't know why it failed necessarily,13:48
dansmithand if it succeeded, then blowing away the task state is more appropriate13:49
dansmithhowever,13:49
dansmithit'll make it smaller and make jaypipes happier13:49
dansmithso that's fiiiiiiiiiine with me :)13:49
markmccool13:49
*** mdomsch_ has joined #openstack-dev13:51
*** mdomsch has quit IRC13:52
*** utlemming has joined #openstack-dev13:53
markmcdansmith, also, two separate decorators13:56
markmcdansmith, where it's basically not valid to use one without the other13:56
markmcdansmith, hmm, I guess you can use @revert_task_state without @checks_instance_lock, ok13:57
markmcdansmith, since it catches all exceptions13:57
*** bencherian has joined #openstack-dev13:57
dansmithyeah13:58
garykmarkmc, can you let me know if you have a minute or two to discuss --config-file14:01
markmcdansmith, on a call now, sorry14:02
*** djoyner has left #openstack-dev14:04
* dansmith forwards packets from markmc to garyk 14:06
*** utlemming has quit IRC14:06
*** rods_ has quit IRC14:08
markmcdansmith, thanks for looking at this btw, hadn't realized how much of a mess it was14:08
*** utlemming has joined #openstack-dev14:10
dansmithmarkmc: heh, well, I clearly wasn't making it any better, I just wanted it to not be broken at least :)14:12
dansmithmarkmc: I haven't quite gotten over the hump to feeling like it's okay to substantially refactor stuff like that.. :)14:12
mtaylordansmith: http://i.imgur.com/wGUTG.gif14:13
markmcdansmith, just assume everything is completely broken :)14:13
markmcmtaylor, I love that! seriously, best gif ever14:13
mtaylormarkmc: clarkb gave that to me two days ago. it's been in its own browser tab ever since :)14:14
*** dachary has quit IRC14:14
markmcmtaylor, I tweeted it months ago14:14
dansmithhehe14:14
*** dachary has joined #openstack-dev14:15
*** andrewbogott has quit IRC14:16
markmcmtaylor, you clearly don't pay close enough attention to me on twitter14:16
*** dachary1 has joined #openstack-dev14:16
*** Mandell has joined #openstack-dev14:16
dansmithheh, I say that to my wife too often14:17
dansmith"Wife: Oh, I didn't know you..."14:17
dansmith"Me: Well, if you _read_ my blog now and then..."14:17
*** dachary1 has quit IRC14:17
*** matiu has quit IRC14:18
*** matiu has joined #openstack-dev14:18
*** dachary has quit IRC14:20
*** markmcclain has joined #openstack-dev14:20
*** zhuadl has joined #openstack-dev14:22
markmcdprince, any idea what's going on with these smokestack failures? https://review.openstack.org/#/c/10247/14:23
*** Mandell has quit IRC14:24
dprincemarkmc: let me have a look.14:25
dprincemarkmc: Let me re-kick it.14:26
markmcdprince, thanks14:26
*** dtroyer is now known as dtroyer_zzz14:28
*** japage has quit IRC14:33
*** japage has joined #openstack-dev14:33
*** maoy has joined #openstack-dev14:34
*** blamar has joined #openstack-dev14:35
*** zhuadl has quit IRC14:36
*** maoy has quit IRC14:38
*** dtroyer_zzz is now known as dtroyer14:42
*** nunosantos_ has quit IRC14:52
*** nunosantos_ has joined #openstack-dev14:53
*** mnewby has quit IRC14:53
eglynn_markmc: are we on the same page at all regarding https://review.openstack.org/10130?14:54
eglynn_markmc: i.e. ... am I getting the wrong end of the stick re. the silent failure of checks_instance_lock, and the potential consequences of that?14:54
markmceglynn_, right, we have a serious issue with task_state vs locks and dansmith's revert_task_state fixes that14:55
*** dhellmann has joined #openstack-dev14:55
markmceglynn_, I don't get the background on the silent failure, but I suspect it may be intentional14:56
markmceglynn_, may be, totally unclear to me14:56
*** gargya has quit IRC14:56
markmceglynn_, it's too obviously silent for it to be unintentional14:56
markmceglynn_, idea might that users should know their VM is locked? seems weird14:56
eglynn_makrmc: hmmm, it being intentional doesn't make sense to me ... kinda like "sleath-locking"14:57
*** andrewbogott has joined #openstack-dev14:57
*** andrewbogott has joined #openstack-dev14:57
eglynn_markmc ^^^14:57
markmceglynn_, but wrt to your patch, it should just now become turning the silent not-implemented failure in set_admin_password to returning an error14:57
markmceglynn_, sure, doesn't make much sense to me either - addressing that is a much wider thing, though14:58
jeblairvishy, jgriffith: sorry about that, this should fix it: https://review.openstack.org/1034414:58
markmceglynn_, not something that should be done piecemeal for a single action14:58
eglynn_markmc: fair nuff, I'll file a bug to address the silent failure issue in a more general way14:58
markmceglynn_, cool stuff14:59
*** datsun180b has joined #openstack-dev14:59
markmccripes, looking back on pre-git history in git is painful15:00
markmceglynn_, ok, this is the origin - https://code.launchpad.net/~tr3buchet/nova/lock/+merge/4487415:01
markmceglynn_, looks silent there too, at first glance15:02
dansmithmarkmc, eglynn_: I had the same realization a week ago, thinking "how can it possibly be right to ignore all these failures and locked states?"15:02
dansmithbut with casting those actions from the api, I don't see how we can change that15:02
dansmithwhat I'd like to see,15:02
GheRivero015:02
dansmithis a "get errors for instance" method,15:03
markmceglynn_, dansmith, blueprint - https://blueprints.launchpad.net/nova/+spec/xs-lock15:03
dansmiththat would return a sanitized event log or something for an instance,15:03
dansmithso that you had a possible way to tell why something isn't working15:03
markmctr3buchet, can you shed some light on this?15:04
markmctr3buchet, if an instance is locked and a user attempts to run some actions, they fail without the user getting an error15:04
markmctr3buchet, was that intentional?15:04
eglynn_markmc, dansmith: looking at the comments trail on that original locking branch, I'm not sure the generally-understood intent was to fail silently if locked (e.g. the comment on reporting a 405 status)15:05
markmceglynn_, dansmith makes a good point - these are mostly async calls, failure happens after user has got e.g. 202 Accepted15:06
dansmithhmm, is that blueprint the same sort of lock?15:06
dansmithso if a user attempts to reboot a suspended instance, only an admin can unlock it?15:06
markmcdansmith, yeah, it's the blueprint associated with the code that added this15:07
markmcdansmith, see https://code.launchpad.net/~tr3buchet/nova/lock/+merge/4487415:07
dansmithyeah, looking, I just don't understand the business logic15:07
tr3buchetmarkmc: hmmmmm15:08
tr3buchetmarkmc: i wrote that so very long ago15:08
tr3buchetmarkmc: at the time the idea was for a service provider to be able to lock an instance so a user could not alter it15:09
*** anderstj has joined #openstack-dev15:10
dansmithright, _that_ I understand15:10
*** anderstj has quit IRC15:10
eglynn_markmc: so if its a 202 Accepted, fire-and-forget-stylee, I would expect the RPC to generally be a cast not a call15:10
eglynn_markmc: ... so there's no conduit to report a failure from checks_instance_lock anyway15:10
dansmitheglynn_: and that's true, right?15:10
eglynn_markmc: but that's not known within checks_instance_lock15:10
markmceglynn_, yeah, so e.g. reboot_instance() is a cast15:11
eglynn_dansmith: yep, but for any RPC-call-based paths into checks_instance_lock, it would make sense to report right?15:11
markmceglynn_, probably, yes15:12
dansmitheglynn_: report locked state? yes, from the user perspective, but not from the performance perspective, AIUI15:12
markmceglynn_, in fact, definitely yes15:12
dansmithI got shot down for making reboot, start, and stop synchronous calls so that I could report the result15:12
eglynn_markmc: cool15:12
markmceglynn_, which would mean revert_task_state() shouldn't swallow the except but let it be sent to the remote side15:12
*** koolhead17 has joined #openstack-dev15:12
markmceglynn_, no need to use booleans for this15:13
markmceglynn_, (note dansmith's patch adds an exception)15:13
eglynn_markmc: yeah, cool, I'm down with reporting via an exception instead of a boolean15:13
* dansmith is confused15:14
eglynn_markmc: (as long as its not just silently ignored when it needn't/shouldn't be ...)15:14
*** wiliam has quit IRC15:14
markmceglynn_, there's probably a case for making some of these casts calls too - how long running are some of them?15:14
markmcdansmith, for any of the calls we do, we should be able to report the locked error to the user15:14
*** sstent has quit IRC15:15
markmcdansmith, so we need the instance locked exception to be serialized and caught by the client side15:15
eglynn_markmc: in the unsual case, many of them are pretty quick, not sure though if there are edges where they might block ...15:15
dansmithmarkmc: I totally agree, but that seems to be contrary to the intended performance aspect15:15
*** sstent has joined #openstack-dev15:15
dansmithperhaps we should ask russellb and ewindisch to chime in15:15
dansmithbecause of: https://review.openstack.org/#/c/9922/15:15
markmcdansmith, I'm not saying we change all casts to calls15:15
markmcdansmith, initially, we just do this for the existing calls15:15
dansmithI'm not sure why we wouldn't just shoot for consistent behavior of "don't expect to hear back" for all of them,15:15
dansmithespecially if there is a "get_event_log()" method to check on why something failed15:16
eglynn_surely we just need to change selected actions, where its important to report a definite outcome ...15:16
markmcdansmith, if it's a sync call, there's no reason to discard the error which is useful to users15:16
dansmitheglynn_: are start/stop/reboot not in that set of "important" ?15:16
dansmithmarkmc: how does the user (of the API) know if it's a sync call and to expect a meaningful status?15:17
eglynn_dansmith: its debatable, since we can poll the server state15:17
markmcdansmith, 200 OK vs 202 Accepted, I guess15:17
dansmithmkay15:17
eglynn_dansmith: but that poll wouldn't tell for example if a passwd change actually happened15:17
dansmithokay, categorizing actions into things we can poll for and not makes sense, although it seems overly complicated to me15:18
dansmithbut I still wonder how the user knows that the state hasn't changed because of a lock vs. some other error15:18
eglynn_dansmith: good point, now they can only trawl the logs I guess15:19
*** rkukura has joined #openstack-dev15:19
*** rkukura has quit IRC15:19
dansmithright, so it seems like this might be an opportunity to improve things for all those scenarios15:20
*** rkukura has joined #openstack-dev15:20
eglynn_dansmith: yep, I hear ya ... so say we do change to call accross the board (from cast)15:20
*** rnirmal has joined #openstack-dev15:21
dansmithin the CIM world, I think it's rather common to generate and return a request ID, throw that back to the user,15:21
markmcdansmith, eglynn_, tried to summarise in https://review.openstack.org/#/c/10130/15:21
dansmithand then let them check on the status of that request later15:21
markmcdansmith, eglynn_, 4 separate issues15:21
* eglynn_ looking ...15:21
dansmitham I making trouble again? :)15:21
markmcno, it's all good stuff15:21
ewindischdansmith: right, an async model.15:22
markmcserious issues which really do need addressing15:22
dansmithmarkmc: since we're setting and reverting task_state in two places, would it be reasonable to check the lock in the api and avoid the attempt in the first place?15:22
dansmiththat doesn't solve everything, but it would reduce some of the problem15:22
markmcdansmith, hmm, what two places?15:22
ewindischit is also possible, at times, to use cast+callbacks in an actor model, rather than using call…15:22
eglynn_dansmith: yep, that would simplify15:22
*** cp16net is now known as cp16net|away15:22
dansmithcompute/api and compute/manager15:22
markmcdansmith, I don't think we'd revert task_state in compute/api15:23
*** cp16net|away is now known as cp16net15:23
dansmithno,15:23
markmcdansmith, at least on the road we're currently on15:23
markmcdansmith, ah, got you15:23
ewindischAre you talking now about the revert-task-state patch, or the password patch?15:23
markmcdansmith, setting in api, unsetting in manager15:23
dansmithmarkmc: right now, we set task_state = STARTING in api, and then set task_state=None in manager when it's complete15:23
dansmithright15:23
markmcdansmith, doing the lock checking on the client side is worth thinking about, yeah15:23
dansmithmarkmc: client site == compute/api.py, right?15:24
markmcdansmith, there'll be backwards compat to think about, but we consider that later15:24
markmcdansmith, right, yes15:24
dansmithokay, I can cook something up for that if you want15:24
*** alex88 has quit IRC15:24
markmcdansmith, certainly sounds like it's worth trying15:25
markmceglynn_, what do you think?15:25
eglynn_dansimth: great that would be a good rationalization, the divsion of responsibility as currently stands is needlessly confusing I think15:25
markmccool15:25
eglynn_(division between api and manager that is ...)15:25
dansmithalrighty15:25
dprincepixelbeat: I just missed this one when I approved your qemu branch: Don't import libvirt_utils in disk api. https://review.openstack.org/1034715:26
markmcdansmith, wait, wait15:27
*** andrewbogott has quit IRC15:27
markmcdansmith, that can't work for async15:27
* markmc wonders is he getting confused15:27
markmcdansmith, I think we talked this through already :)15:27
markmcdansmith, no, sorry - I did get confused15:28
markmcdansmith, carry on15:28
dansmithmarkmc: yeah, I'm talking about the preemtive check, not the reversion15:28
markmcdansmith, right15:28
markmcdansmith, I understood that and then forgot it 5 seconds later :)15:28
dansmithhow is that possible? not like this is really complicated or anything15:28
dansmithwait, what's my name again?15:28
dansmith:)15:29
markmcscrew it, let's all just become cloud analysts15:29
pixelbeatdprince, err OK. I'm wondering why I didn't get any test failures, nor were any flagged in the commit15:30
markmcdansmith, you still need the task_state reversion on the server side, right?15:30
markmcdansmith, for random other errors15:30
dprincepixelbeat: I hit this on XenServer only...15:30
*** littleidea has joined #openstack-dev15:30
dansmithmarkmc: yeah15:30
markmcdansmith, on the client side it would probably be a context manager for taking the lock15:30
markmcdansmith, and would need to pass a new "lock already acquired" flag in the RPC call for backwards compat15:31
markmcdansmith, i.e. old clients which aren't doing locking should still have locking done on the server side15:31
dansmithmarkmc: uhm, why? we don't need to acquire the lock before we do things, just check if it's locked so we can report to the user, right?15:31
dansmiththis is an admin lock, not a thread lock, unless I'm very confused15:32
markmcdansmith, ok, so only set task_state after checking the lock - so no need for reversion15:32
dansmither s/thread lock/mutex/15:32
dansmithright15:32
markmcdansmith, ok, cool15:32
dansmithin fact,15:32
eglynn_markmc, dansmith: its not much a lock aquistion, as a check-for-unlocked, no?15:32
dansmithjust don't ever run the handler in the first place if locked15:32
dansmitheglynn_: yeah15:32
eglynn_dansmith: how about just reversing the current scenario: check-for-unlocked in compute/api ... set task_state and revert in compute/manager?15:33
dansmitheglynn_: I don't think that's the point of task state,15:34
eglynn_dansmith: no ignore that, you want to set the task state as the earliest possible point, right?15:34
dansmithI think the idea is to set and check that in api.py so that 100 calls to, say, start_instance(), transltates to only a single hit to manager.py15:34
dansmithright15:34
eglynn_cool, gotcha15:34
*** mnaser has joined #openstack-dev15:35
markmcwell now, that was fun15:36
eglynn_... and enlightening15:36
annegentlettx: around? I have a root wrap question about "when" you configure nova to use it - are there pre-reqs like you must have run db sync? Or is root_helper added by packagers and deployers just need to know of its existence?15:37
ewindischmarkmc: those links in your review (revert task state) are bad15:37
*** spiffxp has joined #openstack-dev15:37
ttxannegentle: no, should be deploy before you try to run nova.15:37
annegentlettx: ok, makes sense15:37
markmcewindisch, bah15:38
annegentleI'm mostly taking your wiki page and figuring out where to insert it15:38
mnaseranyone ever ran into the strange issue of nova-compute not refreshing/running any firewall rule updates?  modifying security groups i see no nova.virt.firewall logs (firewall_driver=nova.virt.xenapi.firewall.Dom0IptablesFirewallDriver)15:38
*** apevec is now known as apevec_15:38
ttxannegentle: no prerequisites15:38
annegentlettx: well-done document, by the way15:38
*** danwent has joined #openstack-dev15:38
mnaseri do see the do_refresh_security_group_rules calls in the debug log but nothing for the nova.virt.firewall where it creates the sec group iptables rules15:39
*** apevec_ is now known as apevec__15:40
*** halfss has quit IRC15:40
*** apevec__ is now known as apevec15:40
jgriffitheglynn_: Are you able to port your fix for https://bugs.launchpad.net/nova/+bug/1027281 to Cinder as well?15:40
uvirtbotLaunchpad bug 1027281 in nova "In the nova-volume api a GET to /types returns extra db fields for json response" [Undecided,In progress]15:40
jgriffitheglynn_: Or should I grab it later this week?15:40
jgriffitherr.. next week15:40
* jgriffith can't believe it's Thursday15:40
eglynn_jgriffith: yep, I'll grab the cinder aspect too15:42
jgriffitheglynn_: thanks, I'll go ahead and assign it to you in Cinder as well then15:42
*** andrewbogott has joined #openstack-dev15:43
*** andrewbogott has joined #openstack-dev15:43
sdaguehas anyone been using stacktach for debugging? I was starting to look at it after russellb pointed it out, but my django-fu is weak enough that I'm not quite sure how I get it up on django.15:44
*** jaypipes has joined #openstack-dev15:45
* russellb hasn't used it15:45
*** littleidea has quit IRC15:47
*** thovden has quit IRC15:48
*** littleidea has joined #openstack-dev15:48
*** rohitk has quit IRC15:52
jaypipesrussellb: lol, I'm starting to get all your "send a full instance via RPC" patches confused.. :)15:53
markmcthey all rock, that's all we need to remember :)15:55
markmcsays he who hasn't gotten around to reviewing any of them yet :(15:55
*** matwood has joined #openstack-dev15:56
*** zul has quit IRC15:56
*** zul has joined #openstack-dev15:57
jaypipesmarkmc: :)15:57
*** matwood has quit IRC16:00
*** matwood has joined #openstack-dev16:00
vanchesterHi. I'm using swift + keystone + s3. Is it possible to authenticate with access_key='tenant:user' like i.e. http://docs.openstack.org/diablo/openstack-object-storage/admin/content/configuring-openstack-object-storage-with-s3_api.html, cause it seems like it isn't? I look at the code, it splits access_key with ':'. Who's wrong? :)16:00
*** zaitcev has joined #openstack-dev16:02
mtaylormarkmc, jaypipes, bcwaldon: here are the dependent lib changes that pip causes when devstack is run16:02
mtaylormarkmc, jaypipes, bcwaldon: so, basically, this is the current defactor state of the global requirements list  - the + lines are things that pip winds up installing after devstack attempts to install all of our needs via packages16:02
mtaylorso the + lines are the ones zul should care about, because they are the divergence from precise16:03
jaypipesyou mean zuul or zul?16:03
mtaylorI mean zul16:03
jaypipesk16:03
* jaypipes slaps jeblair for naming his project like chucky.16:03
*** jtran has joined #openstack-dev16:03
*** matwood has quit IRC16:04
mtaylorbecause anything wiht a + is somehting our code needs that isn't installed via apt16:04
*** SuperSonicSound has joined #openstack-dev16:04
jaypipesk16:04
markmcmtaylor, nice special casing of ubuntu there again :)16:04
mtaylorzul: or, would it be helpful if I added a depends ppa to the host I'm doing this on?16:04
mtaylormarkmc: well, I've got to start with something16:04
markmcmtaylor, sure16:04
mtaylormarkmc: I'll do rh next16:04
*** matwood has joined #openstack-dev16:05
zulmtaylor: otp16:05
markmcmtaylor, point is just that there's wider interest in new deps than the ubuntu packagers16:05
mtaylormarkmc: totally :)16:05
markmcmtaylor, but you know that, so I'm just being a dork :)16:05
*** mokas has quit IRC16:05
*** thingee has joined #openstack-dev16:05
*** e1mer has quit IRC16:06
jaypipesmarkmc: lol16:06
*** garyk has quit IRC16:06
ameadecan someone rekick jenkins verify on this: https://review.openstack.org/#/c/10170/16:06
timellohey jaypipes :)! Whenever you have a time! Please take a look into the new patch I submitted! I would appreciate to see your valuable comments! https://review.openstack.org/9666 Thanks!16:07
mtaylorameade: you can16:07
mtaylorameade: just leave a comment that says "recheck"16:07
jaypipestimello: on my long list of things today :)16:08
jaypipestimello: got a bunch of tempest/QA and Glance things ahead of you but I should be able to get there by end of day16:09
timellojaypipes: awesome!16:09
timellojaypipes: that would be great! Thank you!16:09
zaitcevchmouel: poke - not sure if you're on the list already - http://lists.openstack.org/pipermail/openstack-dev/2012-July/000216.html16:09
jaypipesnp! :)16:09
*** asakhnov has quit IRC16:10
*** galvint_ has quit IRC16:12
*** anotherjesse_zz is now known as anotherjesse16:13
mtaylormarkmc: https://review.openstack.org/10351 - I used that modification to devstack. on a clean machine, if you set TRACK_DEPENDS, you should get an /opt/stack/requires.diff file after running stack.sh16:16
*** alex88 has joined #openstack-dev16:16
*** alex88 has joined #openstack-dev16:16
markmcmtaylor, ah, cool16:17
*** mnaser has quit IRC16:17
mtaylormarkmc: I figure if we're going to start down the path of a global reqs list, we should probably have some reports to let us know what's up :)16:17
markmcmtaylor, totally16:17
markmcmtaylor, nice work16:18
mtaylormarkmc: thanks!16:18
*** s0mik has joined #openstack-dev16:18
*** thovden has joined #openstack-dev16:18
mtaylormarkmc: (devstack doesn't fully properly run yet with the virtualenv enabled ... perhaps I should just have TRACK_DEPENDS do an exit after doing the final diff instead of trying to run...)16:18
mtayloryeah, I think that's more sensible than trying to get everything to actually run from a venv :)16:19
*** erikzaadi has quit IRC16:20
russellbjaypipes: heh, not surprising, i've literally been copying/pasting the commit message and changing the method name.  they're all the same change applied to a different method of the compute rpc api.16:23
jeblairjaypipes, zul: i'm going to call my next project "James Page"16:24
jaypipesjeblair: :)16:24
*** troytoman-away is now known as troytoman16:25
mtaylorjeblair: don't you mean JaamesPaage?16:28
*** Mandell has joined #openstack-dev16:29
jeblairmtaylor: you named a package without _any_ vowels!16:29
mtaylorjeblair: that's because you took them all!16:29
jaypipesbcwaldon, ameade: around?16:31
*** andrewbogott has quit IRC16:31
jaypipeswant to chat about https://review.openstack.org/#/c/10160/416:32
*** andrewbogott has joined #openstack-dev16:32
jaypipesameade, bcwaldon: so I am uneasy about the solution in that patch16:32
jaypipesameade, bcwaldon: I think I would prefer instead to have the metadata and members still be marked deleted, but have the call to delete_image() return the metadata and member info that was marked deleted so that notifications can have that information16:33
*** anderstj has joined #openstack-dev16:34
*** anderstj_ has joined #openstack-dev16:38
*** thovden has quit IRC16:38
*** anotherjesse is now known as anotherjesse_zz16:40
*** anderstj has quit IRC16:41
*** koolhead17 has quit IRC16:42
*** ewindisch_ has joined #openstack-dev16:48
*** ewindisch has quit IRC16:50
*** ewindisch_ is now known as ewindisch16:50
mtaylorjeblair, bcwaldon: https://review.openstack.org/1035416:51
dansmithmarkmc, eglynn_: just pushed it to gerrit and added you two16:51
*** rohitk has joined #openstack-dev16:51
* eglynn_ looking ...16:51
dansmithone of the reasons I started down the path in the first place was bug 872541, which wanted positive nak when instances are locked16:52
uvirtbotLaunchpad bug 872541 in openstack-qa "nova.compute.api don't raise exception when an instance is locked" [High,In progress] https://launchpad.net/bugs/87254116:52
dansmithI never touched that after the discussion with russellb and ewindisch about async casts, but this will resolve it16:52
bcwaldonjaypipes: hey hey16:53
bcwaldonmtaylor: !16:53
mtaylorbcwaldon: !16:53
jeblairuvirtbot: !16:53
uvirtbotjeblair: Error: "!" is not a valid command.16:53
*** anotherjesse_zz is now known as anotherjesse16:53
*** anotherjesse is now known as anotherjesse_zz16:54
ewindischdansmith, what is "this" ?16:55
*** koolhead17 has joined #openstack-dev16:56
dansmithewindisch: https://review.openstack.org/#/c/10355/16:56
*** markmcclain has quit IRC16:58
ewindischdansmith: this replaces the revert- change too?16:59
dansmithewindisch: no, just cuts out about 75% of the cases where you might need state reversion17:00
dansmith(note that figure is completely fabricated)17:00
*** jdurgin has joined #openstack-dev17:02
*** dachary has joined #openstack-dev17:02
*** anniec has quit IRC17:03
bcwaldonmtaylor: can you just do a git revert of the recent commit I put in to relax the req from 0.6 to 0.6.x?17:04
mtaylorbcwaldon: sure17:04
*** cp16net is now known as cp16net|away17:05
mtaylorbcwaldon: or, should we relax the depend on novaclient too?17:05
bcwaldonmtaylor: I would prefer that17:06
mtaylorbcwaldon: let's do that - the real problem is merely that their requirements conflict17:06
*** sulochan has quit IRC17:06
bcwaldonmtaylor: kk17:06
bcwaldonmtaylor: go for it17:06
mtaylorbcwaldon: awesome17:06
*** sulochan has joined #openstack-dev17:06
kbringardI have a quick question about the nova leases file. in Diablo the leases were written out as MAC,server-name,IP17:06
*** koolhead17 has quit IRC17:06
*** jcooley has quit IRC17:07
kbringardin essex it looks like they're being set as MAC,host-$fixed_ip,IP17:07
*** mnewby has joined #openstack-dev17:07
kbringardso like, 00:00:00,host-10.0.0.1,10.0.0.117:07
kbringardis that expected, or is something else going on in my env?17:07
mtaylorbcwaldon: https://review.openstack.org/1035817:08
*** wiliam has joined #openstack-dev17:08
*** issackel_ has joined #openstack-dev17:09
*** vanchester has quit IRC17:10
*** sulochan has quit IRC17:10
*** danwent has quit IRC17:12
*** reed has joined #openstack-dev17:13
*** dhellmann has quit IRC17:13
*** danwent has joined #openstack-dev17:15
*** derekh has quit IRC17:15
*** Aaton_off is now known as Aaton17:18
*** apevec has quit IRC17:19
*** koolhead17 has joined #openstack-dev17:19
*** rkukura has quit IRC17:20
ameadejaypipes: just getting all of the deleted metadata will also return any metadata that was deleted seperate from deleting the image17:20
*** Ryan_Lane has joined #openstack-dev17:20
*** jakedahn_zz is now known as jakedahn17:21
ameadejaypipes: so if metadata was added then changed, the notification could have duplicate metadata with different values17:22
ameadejaypipes: at least this was the case in nova17:22
ameadefor instances17:22
jaypipesameade: one sec, finishing up QA meeting..17:23
*** mokas has joined #openstack-dev17:24
*** lorin1 has quit IRC17:28
*** jog0 has joined #openstack-dev17:30
*** ayoung has quit IRC17:31
*** ayoung has joined #openstack-dev17:34
dprincejkoelker: around?17:36
*** s0mik has left #openstack-dev17:37
*** garyk has joined #openstack-dev17:38
dprincejkoelker: I'm suspicous of this code in openstack-common: https://github.com/openstack/openstack-common/blob/master/openstack/common/log.py#L36017:38
dprincejkoelker: My first complaint is this seems like a Nova specific thing to do... (based on the comment)17:38
dprincejkoelker: second. This code seems to be the cause of some rather bad side effects like... nova-manage not telling you why it fails.17:39
dprincejkoelker: When most of the nova-manage commands fail they actually say they log to the log file... however they don't.17:40
dprinceSame could happen for services too.17:40
*** gyee has joined #openstack-dev17:45
*** johnpostlethwait has joined #openstack-dev17:45
jaypipesameade, bcwaldon: ok, done with qa now17:46
*** danpb has quit IRC17:46
bcwaldonjaypipes: I'm almost there17:47
jaypipesk17:47
*** nunosantos_ has quit IRC17:47
*** alex88 has quit IRC17:47
*** andrewbogott has quit IRC17:47
*** nunosantos_ has joined #openstack-dev17:47
*** rohitk has quit IRC17:57
jkoelkerdprince: yea that was all blindly copied from nova,18:01
jkoelkeri'm looking now to see how the manage commands use the logging18:01
dprincejkoelker: Would you concur that it can just go away then?18:02
dprincejkoelker: https://bugs.launchpad.net/nova/+bug/102957718:02
uvirtbotLaunchpad bug 1029577 in nova "nova-manage isn't logging errors" [High,In progress]18:02
jkoelkeri would love for it to go away18:02
dprincejkoelker: Removing that code seems to fix the issue :)18:02
dprincejkoelker: Also. In setup we already clear out the root logger anyway at the top of the function.18:02
*** jdurgin has quit IRC18:03
*** lorin1 has joined #openstack-dev18:03
dprincejkoelker: The difference seems to be that one uses 'product_name' where as the stuff at the bottom of setup seems to use the default 'unknown' logger.18:03
jkoelkerdprince: part of the issue is that nova-manage sets up it own logging18:03
jkoelkeryea18:03
jkoelkeri'm still looking at it, been a while since i looked at all the logging stuffs18:04
*** rohitk has joined #openstack-dev18:04
*** mdomsch_ is now known as mdomsch18:07
*** dhellmann has joined #openstack-dev18:09
jkoelkerdprince: ah, I remeber this now18:09
jkoelkeryea so this was for backwards compatability with the way logging used to be setup before we allowed real file config18:09
dprincejkoelker: meaning it can go away?18:10
jkoelkerwell the question is when its removed do you get multiple log statements?18:10
jkoelkerdue to the basicConfig in nova/__init__.py still sending messages?18:11
zulmtaylor: ping what were you talking about earlier?18:11
dprincejkoelker: I'll double check...18:11
*** rkukura has joined #openstack-dev18:11
*** cp16net|away is now known as cp16net18:12
*** PotHix has joined #openstack-dev18:13
mtaylorzul: deps stuff18:14
*** markmcclain has joined #openstack-dev18:14
zulmtaylor: eh?18:14
*** markmcclain has quit IRC18:14
*** markmcclain has joined #openstack-dev18:14
*** anniec has joined #openstack-dev18:14
*** alop has joined #openstack-dev18:14
mtaylorzul: http://paste.openstack.org/show/1963218:15
mtaylorzul: i've been poking at global depends - as part of that, I wanted to see what pip was installing when we ran devstack18:15
mtaylorzul: since we theoretically install all the deps from apt during our devstack gating runs18:16
jkoelkerdprice specifically to nova-manage I'm thinking what needs to happen is to grab a logger then in the excepts down at the bottom call LOG.exception so the exception gets logged18:16
*** markmcclain has quit IRC18:16
mtaylorzul: the diff I just posted is a diff of what's on the system before I let pip do anyhting, and after all of the projects get python setup.py develop'd18:16
mtaylorzul: fwiw18:16
*** markmcclain has joined #openstack-dev18:16
jkoelkerotherwise re the bug it never hits the nova module code so no log messages are generated18:16
zulmtaylor: whats cmd2?18:17
mtaylorzul: no clue18:17
mtaylorlooks like there is a deb package for it already...18:17
*** jdurgin has joined #openstack-dev18:20
*** rohitk has left #openstack-dev18:21
clarkbmtaylor: A + is something added by pip that wasn't installed by apt?18:21
Ryan_Laneayoung: so, I was able to get keystone with the ldap backend working18:22
Ryan_Lanebut there's a bug with regards to roles18:22
Ryan_Lanethe fix is actually sitting in a todo, with the code commented out18:23
*** ewindisch has quit IRC18:24
*** ewindisch has joined #openstack-dev18:24
mtaylorclarkb: yeah18:25
* adam_g really wishes for a hard freeze on new dependencies at some point in OS release cycles18:26
ayoungRyan_Lane, reference?18:29
Ryan_Lanegimme a sec18:30
Ryan_Laneayoung: https://github.com/openstack/keystone/blob/stable/essex/keystone/identity/backends/ldap/core.py line 9718:31
Ryan_Lanethough it needs to be: metadata_ref =  {'roles': self.get_metadata(user_id, tenant_id)}18:31
ayoungRyan_Lane, let me try it out18:32
* Ryan_Lane nods18:32
Ryan_Laneif I run "nova credentials" without that change, I get an empty list of roles18:32
Ryan_Lanewith the change, I get: [{u'id': u'sysadmin', u'name': u'sysadmin'}, {u'id': u'netadmin', u'name': u'netadmin'}]18:33
*** darraghb has quit IRC18:33
Ryan_Laneall this requires that I have roles defined in the roles ou that match roles set in the tenants18:33
*** nunosantos_ has quit IRC18:34
ayoungRyan_Lane, hmm...that is on essex stable?18:34
Ryan_Laneyes18:34
ayoungsignificantly different in Folsom18:34
Ryan_Laneindeed18:34
Ryan_Lanebut...18:34
Ryan_LaneI need this to work in production18:34
ayoungbut it looks like the Folsom change is wrong18:34
*** nunosantos has quit IRC18:36
*** armaan has joined #openstack-dev18:36
ayoungRyan_Lane, I think you submit that as a patch against stable18:38
Ryan_Laneok. will do18:39
Ryan_Laneayoung: https://review.openstack.org/1036518:44
Ryan_Laneotherwise it's working, with the changes to hardcoded attributes18:44
ayoungRyan_Lane, ah..lets address that too18:45
ayoungthe change to fix that is ....18:45
Ryan_Laneit's fairly hard to know if it's working based on the documentation, since most of the functions in the documentation are unimplemented18:45
ayoungBTW,  did you run that against the unit tests?18:45
ayoungI think it will fail18:45
Ryan_Laneoh18:45
Ryan_Lane:(18:45
Ryan_LaneI didn't18:45
ayoungI had to make it more like this:18:45
ayounghttp://fpaste.org/LK0W/18:46
Ryan_Laneah18:46
ayoungnot saying that is more correct, mind you,  but that is using the same fixture as the other identity tests18:46
ayoungso only set roles if you have some....18:47
ayoungfor the username change...18:47
ayounghttps://bugs.launchpad.net/keystone/+bug/997700/+attachment/3152375/+files/keystone-admiyo-0005-configuration-option-for-user-name.patch18:48
uvirtbotLaunchpad bug 997700 in keystone "LDAP should not check username on "sn" field" [Medium,Triaged]18:48
Ryan_Laneis that diff against master?18:48
ayoungprobably18:48
ayoungthe diff in the fpaste, yes18:48
* Ryan_Lane nods18:48
ayoungRyan_Lane, did you have to modify any fields besides user_name?18:49
Ryan_LaneI'll have to look.18:49
Ryan_Lanethe tenant one as well18:50
Ryan_Lanename is defined as ou18:50
ayoungOK, I'll spin up a patch for that as well.18:51
*** jakedahn is now known as jakedahn_zz18:51
*** johnpostlethwait has quit IRC18:53
Ryan_Laneawesome. thanks18:54
*** jakedahn_zz is now known as jakedahn18:54
Ryan_Lanehm. how to run tests against stable....18:55
Ryan_Laneshouldn't the tests run from the change submission?18:56
*** mnewby has quit IRC18:56
ayoungRyan_Lane, start with the unit tests18:56
ayoung./run_tests.sh18:56
ayoungin keystone git checkout dir18:56
Ryan_Laneright, but I have no way of running them18:56
Ryan_Lanecan devstack use the stable branch?18:57
ayoungRyan_Lane, yes you do.18:58
ayoungDo you havea a git checkout?18:58
Ryan_Laneon my mac18:59
Ryan_Lanewhich is missing all of the dependencies18:59
ayoungI'll take that as a "No"18:59
ayoungLuddite18:59
Ryan_Lanewell, I tend to use devstack for development18:59
ayoungOK...18:59
ayoungdevstack will work fine18:59
Ryan_LaneI have a devstack instance, but it uses master18:59
ayoungOK,  go to that machine19:00
Ryan_Laneand its dependencies are for master19:00
ayoungand the keystone checkout is in /opt/stack19:00
ayoungkill all the devstack stuff you have running19:00
ayoungand get an essex tracking branch:19:00
ayoung git branch --track essex gerrit/stable/essex19:00
ayounggit checkout essex19:00
ayoungapply your patch19:00
ayoung./run_tests.sh19:01
ayoungthe real fun is running the live ldap tests...but one step at a time19:01
*** epim has joined #openstack-dev19:01
*** anniec has quit IRC19:04
*** anniec has joined #openstack-dev19:04
Ryan_Lanemeh. my vm isn't behaving. this may take a while. I'll get the tests going and let you know how it goes19:04
*** EmilienM has joined #openstack-dev19:06
*** EmilienM has left #openstack-dev19:07
*** EmilienM has joined #openstack-dev19:08
*** andrewbogott has joined #openstack-dev19:08
*** andrewbogott has joined #openstack-dev19:08
*** fc__ has quit IRC19:10
*** novas0x2a|laptop has joined #openstack-dev19:14
sdaguejgriffith: any further thoughts on the storewise driver - https://review.openstack.org/#/c/9840/ ?19:15
Ryan_Laneayoung: in devstack in essex, the stable branch doesn't pass tests19:15
ayoungright19:16
ayoungauthor?19:16
Ryan_Lane?19:16
ayoungfor me it is the authors file check that fails19:16
ayoungRyan_Lane, nothing to do with LDAP19:16
Ryan_LaneI'm talking about without my patch19:16
ayoungyes19:16
ayoungso to run just the LDAP unit tests...19:16
Ryan_LaneI have 18 failures19:17
*** johnpostlethwait has joined #openstack-dev19:17
ayoung ./run_tests.sh test_backend_ldap19:17
ayoungRyan_Lane, right now we only care about the ldap backend tests19:18
ayoungRyan_Lane, so run ./run_tests.sh test_backend_ldap19:18
jgriffithsdague: I'm good with it, just hoping to get some other folks to at least look at it19:18
* Ryan_Lane nods19:19
Ryan_Lanethey're running19:19
jgriffithsdague: I'll see if I can get someone to look at it today, otherwise I'll push it through tomorrow for you19:19
*** mnewby has joined #openstack-dev19:21
*** dachary has quit IRC19:21
*** dachary has joined #openstack-dev19:22
Ryan_Laneugh. pip failure19:22
*** mokas has quit IRC19:23
*** andrewbogott_ has joined #openstack-dev19:26
*** andrewbogott_ has joined #openstack-dev19:26
*** andrewbogott has quit IRC19:26
*** andrewbogott_ is now known as andrewbogott19:26
ayoungRyan_Lane, anyway, let me test out your change on my VM19:27
sdaguejgriffith: cool, don't want to push anything outside of the process, but some extra reviews would be great. Just don't want to see it lost in review limbo.19:27
*** vanchester has joined #openstack-dev19:28
jgriffithsdague: Promise I won't let it get lost.  :)19:28
jgriffithsdague: F3 is my deadline for all of the drivers, then I bribe people or just approve them :)19:29
sdague:)19:29
jgriffithsdague: There ya have it...19:29
sdagueespecially if nova-volume is still going to exist in folsom, as the team wants to get it into nova if that's still the case19:29
sdaguebut I told them it should land in cinder first19:30
jgriffithsdague: Just FYI there's nothing preventing you from doing them in paralell19:30
sdaguejgriffith: ok, I'll let them know19:30
ayoungRyan_Lane, I get failures on test_authenticate and test_authenticate_no_metadata19:30
ayoungI'm going -1 the patch as is.  Please submit one with the modification we discussed19:31
*** pixelbeat has quit IRC19:31
Ryan_LaneI already have19:31
Ryan_Lanepatchset 219:31
*** thovden has joined #openstack-dev19:31
Ryan_Laneit's also failing tests, though19:31
Ryan_Laneah. pep8 failure19:32
*** koolhead17 has quit IRC19:32
Ryan_Laneand https://jenkins.openstack.org/job/gate-keystone-python26/648/testReport/test_backend_ldap/LDAPIdentity/test_authenticate_invalid_tenant/ 19:33
*** dtroyer is now known as dtroyer_zzz19:34
jeblairvishy: okay, i have the no-cinder-on-stable-branch problem straightened out; this change passes now (but needs code review): https://review.openstack.org/#/c/10321/19:35
jeblairvishy, jgriffith, adam_g: ^  and sorry about the trouble.19:35
Ryan_Laneah. that exception doesn't exist in this version. I can just remove that except19:35
*** wiliam has quit IRC19:36
Ryan_Lanethis patchset should pass19:36
*** arosen has quit IRC19:36
*** arosen has joined #openstack-dev19:37
*** armaan has left #openstack-dev19:39
ayoungRyan_Lane, can you give a first pass to https://review.openstack.org/#/c/10370/  as well19:45
Ryan_Laneayoung: this changes the default that's currently in stable19:46
Ryan_Lanefor tenant19:46
ayoungRyan_Lane, your change looks good.19:48
Ryan_Lanecool19:48
ayoungat least,  against the fake ldap back end19:48
* Ryan_Lane nods19:49
ayoungI need to do a little hack to run against live ldap...1 sec19:49
*** datsun180b_ has joined #openstack-dev19:50
*** mokas has joined #openstack-dev19:51
ayoungRyan_Lane, self.get_metadata(user_id, tenant_id) throws a different exception, I think19:52
*** cp16net is now known as cp16net|away19:52
*** datsun180b has quit IRC19:53
*** datsun180b_ is now known as datsun180b19:53
ayoungRyan_Lane, I think you need an Except: pass for that19:53
Ryan_Lanethat exception doesn't exist19:53
Ryan_Lanein this version19:53
Ryan_Lanelet me look at the function19:53
Ryan_Laneno exception thrown19:54
Ryan_Laneit just returns an empty dictionary19:54
ayounger..yeah...loking through, looks like I swallowed all the exceptions.  THat must be why I was putting on weight19:54
Ryan_Lane:D19:54
*** datsun180b has quit IRC19:55
ayoungRyan_Lane, I do think you duplicated the metadata_ref = {}  call19:56
ayoungits on line 93 and 8319:56
Ryan_Laneah. I did indeed19:56
ayoungthat is what you get for copying my sloppiness19:56
Ryan_Lanethere's a failed test too. let me check that19:56
ayoungYou also don't need to put it in the Excepiont block19:56
ayoungRyan_Lane, on test_rename_duplicate_role_name_fails  I think that is a pre-existing condition19:57
Ryan_LaneExcepiont?19:57
ayoungthe rest of the live ldap tests pass for me19:57
*** n0ano has joined #openstack-dev19:57
Ryan_Laneah. the extra metadata_ref = {}19:57
*** rnirmal has quit IRC19:57
ayoung        except exception.TenantNotFound:19:58
ayoung            tenant_ref = None19:58
ayoung            metadata_ref = {}19:58
Ryan_LaneI need the block itself, right?19:58
ayoungYou really, really want to set that to {} don't you?19:58
Ryan_Laneheh19:58
Ryan_LaneI like to set the same thing over and over :D19:58
ayoungyeah, just remove all but one of the default assignements19:58
* Ryan_Lane nods19:58
*** thovden_ has joined #openstack-dev20:01
*** thovden has quit IRC20:03
*** thovden_ is now known as thovden20:03
*** nikhil has quit IRC20:05
ayoungRyan_Lane, +1ed20:06
*** ecarlin has joined #openstack-dev20:07
ayoungRyan_Lane, added a few review requests to the other core devs20:07
Ryan_Lanesweet. thanks20:10
*** ecarlin has quit IRC20:10
andrewbogottdhellmann, markmc, russellb, could I get a +2 from one of you on https://review.openstack.org/#/c/10035/?  It's been vetted by _cerberus_ who is the expert in that area.20:10
ayoungRyan_Lane, new version of mine pushed.20:11
ayoungposted, rather20:11
Ryan_Lane+1'd20:11
*** anniec has quit IRC20:12
_cerberus_expert, eh? O_o20:13
andrewbogottDidn't you write the notification code in the first place?20:13
_cerberus_yeah ;-)20:13
_cerberus_Just refuting this supposed "expert" status20:14
andrewbogottServes you right for adding a new feature, now your the expert for life.20:14
andrewbogottyou're20:14
_cerberus_Don't I know it :-/20:14
_cerberus_:-D20:14
*** cp16net|away is now known as cp16net20:14
*** johnpostlethwait has quit IRC20:15
clarkbdevcamca-: what do you think about adding https://jenkins.openstack.org/job/gate-horizon-selenium/ as a gate test to horizon? It has been running as a check test and I think we have ironed out the kinks20:16
*** dprince has quit IRC20:20
*** andrewsmedina has quit IRC20:22
*** nikhil has joined #openstack-dev20:23
*** mnewby has quit IRC20:26
ayoungRyan_Lane, what are your LDAP objectclasses again?20:29
ayoungposix user ?20:29
Ryan_Laneinetorgperson, posixuser, person20:29
Ryan_Lanetenants are groupofnames and posixgroup20:29
ayoungOK... let me test that out with the liveldap tests and a modified schema.20:30
Ryan_Laneactually: person, inetorgperson, organizationalPerson, ldapPublicKey, shadowaccount, posixaccount20:30
Ryan_Laneheh20:30
Ryan_LaneI use uid as naming attribute, and CN for a user's full name20:31
ayoungI think I only need to name the end of the hierarchy20:32
ayoungso20:32
ayounguser_objectclass=posixaccount20:32
ayounguser_name_attribute=cn?20:33
*** anderstj_ has quit IRC20:33
Ryan_LaneI'm using inetorgperson and uid20:33
Ryan_Laneand uid for user_id_attribute20:33
ayounguser_objectclass=inetorgperson20:34
ayounguser_name_attribute=cn20:34
ayounguser_id_attribute=uid20:34
ayoungthen for tenant20:34
Ryan_Laneapparently if you use cn for the name attribute, it will do searches with the username for both uid and cn20:34
Ryan_LaneI'm using uid for both name and id20:34
Ryan_Lanefor tenant I'm using cn for both name and id20:35
*** thovden_ has joined #openstack-dev20:35
ayoungHmm.ok20:35
Ryan_Lanefor similar reasons20:35
*** anniec has joined #openstack-dev20:35
Ryan_Lanemy tenants and users are all unique, so it's not a problem20:35
ayoungRyan_Lane, http://fpaste.org/D8MG/20:35
ayoungbut with spaces, of course20:36
Ryan_LaneI'm using groupofnames for the tenant objectclass20:36
ayoungI thought you said posixgroup?20:36
Ryan_Laneboth20:36
Ryan_Laneso I keep the default in the config20:36
ayoungwhen that adds a new one,  it will only add it with the specified objectclass20:36
Ryan_LaneI'm using posixgroup as well, so that I can extend the groups to the instances20:37
Ryan_LaneI don't use keystone to manage the dit20:37
*** thovden has quit IRC20:37
*** thovden_ is now known as thovden20:37
Ryan_Lanekeystone is basically read-only20:37
ayoungright...let me try it this way and see.20:37
Ryan_Lanethat said, keystone adds tenants incorrectly. I already tested that20:37
Ryan_Laneit adds the uuid as the naming attribute, then tries to look up the tenant by dn, using the name, not the uuid20:38
ayoungobject class 'posixGroup' requires attribute 'gidNumber'20:38
Ryan_Laneyep20:38
Ryan_LaneI have to leave. back in like 30-4520:38
ayoungcuz it uses a UUID20:38
ayoungNP20:38
ayoung 'inetOrgPerson' requires attribute 'sn'", 'desc': 'Object class violation'20:39
ayounghmmmm20:39
*** mnewby has joined #openstack-dev20:42
*** littleidea_ has joined #openstack-dev20:42
*** littleidea has quit IRC20:43
*** littleidea_ is now known as littleidea20:43
sorenvishy: It's rather manual.20:45
sorenvishy: I've always made sure to adjust the ordering to account for people having swapped their turns, so that they don't have two review days really close to each other.20:48
sorenvishy: Also, a particular subset of the nova-core group has refused to show their e-mail addresses on Launchpad.20:49
sorenvishy: ...and subset of that subset has refused to give anything resembling a real name, making it even harder to figure out what the heck is going on and who's who and what's what.20:50
sorenvishy: So I'm afraid this can't be automated.20:50
sorenvishy: ..without building a separate system for it with separate tracking of these details, of course. There's certainly prior art in this project to building stuff like that.20:52
*** anniec_ has joined #openstack-dev20:54
*** anniec has quit IRC20:55
*** anniec_ is now known as anniec20:55
*** jk0 has quit IRC20:59
*** lhindman has joined #openstack-dev20:59
*** GheRivero has quit IRC21:01
*** jk0 has joined #openstack-dev21:02
*** jk0 has joined #openstack-dev21:02
*** ChanServ sets mode: +v jk021:02
*** anniec has quit IRC21:03
*** mdomsch has quit IRC21:05
*** mnewby_ has joined #openstack-dev21:09
*** aryan has quit IRC21:09
*** aryan has joined #openstack-dev21:09
*** bhuvan_ has quit IRC21:09
*** mnewby has quit IRC21:12
*** mnewby_ is now known as mnewby21:12
*** markvoelker has quit IRC21:14
*** apevec has joined #openstack-dev21:15
*** SuperSonicSound has quit IRC21:19
apevecayoung, re. https://review.openstack.org/#/c/10359/21:21
apevec"This was already merged." - on master yes21:21
Ryan_Laneayoung: I'm back21:21
apevecthis is for stable/essex21:21
ayoungapevec, ah21:21
*** heckj has joined #openstack-dev21:21
apevechttps://bugs.launchpad.net/keystone/+bug/1020569/comments/421:22
uvirtbotLaunchpad bug 1020569 in keystone "wsgi code ties all middleware consumers  to Eventlet" [Medium,Fix committed]21:22
ayoungI'm not sure that this change needs to be backported....21:22
apevecayoung, see above comment21:22
apevecin LP21:22
ayounglooking21:22
Ryan_Laneayoung: the approach I usually take for populating values is to duplicate one, if it isn't provided21:22
Ryan_Lanefor required attributes21:22
Ryan_Lanesn is an annoying one.21:23
Ryan_LaneI usually just replicate cn21:23
ayoungRyan_Lane, yeah,  that works for testing.  I have to think about what I would recommend for a live deployment.21:23
*** heckj has quit IRC21:23
ayoungRyan_Lane, What we have works for read only just fine, I suspect21:23
Ryan_Laneyep. it does21:23
Ryan_LaneI've already tested that21:23
ayoungand then the question is, would anyone really want to use LDAP except as read only21:23
Ryan_Lanesome people might21:24
Ryan_Laneespecially for tenants and roles21:24
ayoungif so...do we need a way to expand the user_add etc APIs to handle the additional values21:24
Ryan_LaneI like a template approach for this kind of thing21:24
Ryan_Lanelet me give an example21:24
ayoungapevec, I think I am going to nix applying my patch to essex.  It is not technically necessary, unless you want to avoid the eventlet dependencies in running Keystone in Apache HTTPD.  Even then,  it will work.  I'd say I'm ok with leaving the change for Folsom21:26
*** lorin1 has quit IRC21:26
ayoungunless you have some strong opinion why it needs to be in stable21:26
ayoungAnd I have to say,  I am still suspect of monkey patching Thread.   It smells like a mistake to me.21:27
Ryan_Laneayoung: http://pastebin.com/FiDUUxhk21:27
apevecayoung, my only justification is that the patch which prompted you to move monkeypatching is already in stable21:27
apevecand I do would like to try running essex in httpd21:28
ayoungapevec, yes, and it needs to be there to deal with an issue in memcached.  My fix just makes it possible to work around for debuggin purposes21:28
*** eglynn_ has quit IRC21:28
Ryan_Lanethen user creation would use the object classes and attributes in the template, and could also have the possibility of custom variables via extensions21:28
*** steveb_ has joined #openstack-dev21:29
ayoungRyan_Lane, it makes sense, the question is should we default values, or provde a way to expand the APIs to let the end user supply them.  I am more prone toward the latter21:29
Ryan_Lanewell, the template as shown in the pastebin would allow users to supply them21:30
Ryan_Lanesince the template would be user created21:30
ayoungRyan_Lane, so we drop something like that into /etc/keystone for each of the entities?21:30
Ryan_Lanelike instance templates are in nova21:30
Ryan_Laneayoung: yeah21:30
ayoungRyan_Lane, write it up as a blueprint.  We can thrash it around at the summit21:31
Ryan_LaneI'd actually consider using keystone as the ldap interface if I could customize it enough :)21:31
apevecayoung, ok, I'll abandon the change, after checking why tempest test failed21:31
ayoungapevec, do you needto test the released version of essex in HTTPD,  or is it OK to hack it, just to see it work?21:31
*** vanchester has quit IRC21:32
apevechack is fine21:32
ayoungapevec, then just remove the whole monkeypatch line21:33
jaypipes_cerberus_: lol "the increasingly large decorator storm". no shit! :)21:33
_cerberus_;-)21:33
ayoungapevec, I recently commited a change to master that gives you the rest of the files you need21:33
apevecyep, saw it, very good21:33
ayoung9b31383c7d8665cf99003974d98df147471e61e121:34
ayoungapevec,  looks like the tempest failure was unrelated21:34
apevecyeah, I did "recheck" to confirm21:35
apevecnova-volume failing21:35
*** thovden_ has joined #openstack-dev21:36
*** anniec has joined #openstack-dev21:37
Ryan_Laneayoung: https://blueprints.launchpad.net/keystone/+spec/ldap-object-templates21:37
ayoungRyan_Lane, looking21:37
*** anniec_ has joined #openstack-dev21:37
*** mnewby has quit IRC21:38
dansmithmarkmc: I'm sure you saw it, but the instance lock check thingy just needs one more little green check on it :D21:38
ayoungRyan_Lane so how would we expose that to the end user?  python-keystone client would have to be smart enough to query Keystone to know to ask for and allow those values21:39
Ryan_Laneoh. sorry. this would be on the server side config21:39
Ryan_Lanelet me adjust21:39
*** dachary has quit IRC21:39
*** thovden has quit IRC21:39
*** thovden_ is now known as thovden21:39
ayoungRyan_Lane, right,  necessary but not sufficient21:39
ayoungwe need to then let the CLI and WebUI (and other apps) know about the new mandatory fields21:40
Ryan_Laneah. true21:40
ayoungIn visual HTML,  you would add them to a form.  We don't do anything like that in JSON, thoough21:40
ayoungalthough we should.  HATEOAS and all that21:40
Ryan_Lanethe extensions would need to extend the api and cli21:41
*** anniec has quit IRC21:41
*** anniec_ is now known as anniec21:41
Ryan_Lanethe plugin framework could be used to provide variables, and extend the api21:42
ayoungRyan_Lane, I would like it to be something like this:  if you do a GET on a certain resource, you get the Metadata needed to create a new instance of that resource.21:42
Ryan_Laneandrewbogott: ^^ correct?21:42
ayounglike if you do GET http://host/v3/users/new21:42
Ryan_Laneah, that would provide back a set of required fields?21:43
* andrewbogott catches up21:43
ayoungif you set a Media type of HTML,  it would give you a form, and the default is JSON21:43
Ryan_Lanehm. the only downside to that is that each implementation of keystone could require a different set of things21:43
Ryan_Laneand clients would have no clue based on discovery21:43
ayoungNo, that is an upside21:43
andrewbogottRyan_Lane:  Yeah, a plugin can extend the commandline.  It would most likely happen via python-openstackclient rather than python-keystoneclient.21:44
ayoungyes, they would21:44
Ryan_Lanewouldn't it be better if these were formalized as extensions, so that clients could do discovery?21:44
ayoungah, you mean that the client would have no A-Priori knowledge21:44
Ryan_Laneand then they could claim compatibility with different extensions21:44
ayoungRyan_Lane, not if you buy into REST21:44
ayoungI think that I like this approach slightly better21:45
Ryan_LaneI'm just thinking consistency with how the api is extended now :)21:45
ayoungits more like Progressive enhancement...21:45
* Ryan_Lane nods21:46
Ryan_Laneit's a good topic for the summit21:46
ayoungAnyway, we have your blueprint.  I think we should discuss at summite21:46
ayoungHeh, you are ahead of me as usual21:46
ayoungRyan_Lane, http://adam.younglogic.com/2012/03/hateoas-openstack-keystone/21:47
Ryan_Laneok. I've updated the blueprint some21:47
ayoungRyan_Lane, looks good.  I have to catch a bus shortly.  I'll muse on this some more in the next few days, and try to work up a fuller spec21:49
Ryan_Laneayoung: ah. I see21:49
Ryan_Lanebased on discovery of attributes, the application would dynamically create forms21:49
Ryan_Lanegreat. thanks21:49
*** darkhorse2go has quit IRC21:50
* andrewbogott spent a while thinking this was about 'Hate as a service'21:51
Ryan_Lane:D21:51
Ryan_LaneI could use it as a proxy for every technology I hate21:52
Ryan_Lanewhich is like all of them21:52
ayoungandrewbogott, sorry it is Hate O as a service,  so it is only useful for Hating O things.21:53
Ryan_Lane:(21:53
ayounghttp://en.wikipedia.org/wiki/HATEOAS21:53
ayounghttp://roy.gbiv.com/untangled/2008/rest-apis-must-be-hypertext-driven21:53
andrewbogottI read (and, I think, mostly understood) your blog post.  Is there anything in openstack that currently does that?  Returns a form in order to define a future interface?21:54
ayoungandrewbogott, I would say that Horizon does21:54
ayoungwhat I would like is for Horizon to be far more of a passthrough from the remote services21:55
andrewbogottHm...21:55
ayoungandrewbogott, I have to leave in 2 minutes.  I will send you a write up of what I would like it to be like in an ideal world21:55
ayoungfully acking that I am dreaming21:55
*** jmeredit has joined #openstack-dev21:56
andrewbogottayoung:  ok!  I'm not very involved in horizon but would be interested in thinking about it as a lesson in HATEOAS.21:56
*** ayoung has quit IRC21:57
*** sacharya has quit IRC22:03
*** johnpostlethwait has joined #openstack-dev22:04
*** apevec has quit IRC22:04
*** dhellmann has quit IRC22:05
*** kbringard has quit IRC22:10
Ryan_Lanedamn. no ayoung. found another ldap bug22:13
Ryan_Laneauthenticating with no tenant never returns22:13
*** Gordonz_ has quit IRC22:20
*** markmcclain has quit IRC22:25
reed is this team existing? http://wiki.openstack.org/Governance/Proposed/OpenStack%20Security%20Group22:26
clarkbadam_g: fyi (also don't hate me) but horizon depends on django 1.4 now and precise has 1.3.122:28
*** heckj has joined #openstack-dev22:28
jmereditsearching for approval....https://review.openstack.org/#/c/10361/22:30
*** pixelbeat has joined #openstack-dev22:31
*** heckj has quit IRC22:33
*** anderstj has joined #openstack-dev22:35
*** nati_ueno has joined #openstack-dev22:37
*** e1mer has joined #openstack-dev22:37
*** anniec has quit IRC22:38
adam_gclarkb: thanks22:41
*** andrewsmedina has joined #openstack-dev22:44
*** salv-orlando has quit IRC22:45
*** rods_ has joined #openstack-dev22:47
*** rods has quit IRC22:50
*** rods has joined #openstack-dev22:51
*** rods_ has quit IRC22:51
*** rods_ has joined #openstack-dev22:51
*** mnewby has joined #openstack-dev22:51
*** rods has quit IRC22:52
*** rods has joined #openstack-dev22:52
*** rods has joined #openstack-dev22:53
*** rods_ has quit IRC22:54
*** rods has joined #openstack-dev22:54
*** rods_ has joined #openstack-dev22:54
*** thovden has quit IRC22:55
*** troytoman is now known as troytoman-away22:57
*** rods_ has quit IRC22:57
*** rods_ has joined #openstack-dev22:57
*** rods has quit IRC23:03
*** rods has joined #openstack-dev23:03
*** zaitcev has quit IRC23:03
*** rods_ has quit IRC23:03
*** rods_ has joined #openstack-dev23:04
*** rods_ has left #openstack-dev23:05
*** rods__ has joined #openstack-dev23:05
*** rods has quit IRC23:05
*** rods has joined #openstack-dev23:05
*** lhindman has quit IRC23:06
*** rods_ has joined #openstack-dev23:08
*** rods has quit IRC23:08
*** rods_ is now known as rods23:09
*** rods` has joined #openstack-dev23:09
*** rods has quit IRC23:09
*** rods has joined #openstack-dev23:10
*** halfss has joined #openstack-dev23:12
*** anniec_ has joined #openstack-dev23:12
*** andrewbogott has quit IRC23:20
*** rods has quit IRC23:22
*** danwent has quit IRC23:23
*** dachary has joined #openstack-dev23:25
*** anniec_ has quit IRC23:33
Ryan_Lanecrap. in keystone you need to authenticate a user for every single tenant?23:34
Ryan_Lanekeystone is really, really painful for my usecase :(23:36
arosenRyan_Lane:  you can use admin if you want.23:38
Ryan_Lanein which way?23:38
aroseni think if you connect via  port 500023:38
Ryan_Lanefor my use case, a user can be a member of multiple projects23:38
Ryan_Lanewhen they log into the web interface, they should get keystone credentials that allow them to do actions in any project they are a member of23:39
*** mnaser has joined #openstack-dev23:39
Ryan_Lanebut they should only ever need to provide their password on login23:39
Ryan_LaneI want to ensure they are accessing services as their user, though, for auditing reasons23:40
arosenSorry,  I'm not sure off hand hopefully someone else can chime in.23:40
*** pixelbeat has quit IRC23:40
*** anderstj has quit IRC23:41
*** Adri2000 has quit IRC23:45
*** nunosantos has joined #openstack-dev23:50
*** timello has quit IRC23:53
*** koolhead17 has joined #openstack-dev23:53
*** anniec has joined #openstack-dev23:55
*** anniec_ has joined #openstack-dev23:56
*** jaypipes has quit IRC23:58
*** dhellmann has joined #openstack-dev23:59
*** anniec has quit IRC23:59
*** anniec_ is now known as anniec23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!