Wednesday, 2011-12-07

openstackgerritRohit Karajgi proposed a change to openstack/tempest: Handle 404 Not found variations  https://review.openstack.org/212600:00
*** markvoelker has quit IRC00:02
openstackgerritVerification of a change to openstack/keystone failed: Split version code into its own file.  https://review.openstack.org/211700:13
openstackgerritVerification of a change to openstack/keystone failed: Split version code into its own file.  https://review.openstack.org/211700:13
*** zul has joined #openstack-dev00:15
*** rnirmal has quit IRC00:17
*** hugokuo has quit IRC00:25
*** jakedahn has quit IRC00:26
*** dragondm has quit IRC00:27
*** sleepsonthefloo has quit IRC00:29
jeblairmtaylor, zns: https://jenkins.openstack.org/view/Glance/job/glance-venv/36/console00:29
jeblairkeystone/__init__.py imports keystone.common.config which imports paste00:30
mtaylorso from keystone import version _still_ runs __init__.py?00:30
* mtaylor cries00:30
jeblairyeah, you have to be careful what you put in __init__00:31
mtaylorwhat about import keystone.version ?00:31
*** AlanClark has quit IRC00:31
jkoelkerit will still run init in keystone since __init__.py is the keystone namespace that version gets added to00:32
mtayloryeah. good point00:32
mtaylorbother00:32
mtaylorso the answer here is that we need to remove that code from keystone/__init__.py in general00:32
jeblairpersonally, i'd say we should remove _a lot_ of code from __init__.py00:33
jeblaircompare it to nova or glance, both have very short __init__.py's.  keystone has code in there.00:34
mtaylorit's the server class00:34
jeblairit's the top level namespace doing double duty as the server class00:34
*** anotherjesse has quit IRC00:38
jeblairbug 90101800:41
uvirtbotLaunchpad bug 901018 in keystone "setup.py imports keystone before dependencies are satisfied" [Undecided,New] https://launchpad.net/bugs/90101800:41
openstackgerritMonty Taylor proposed a change to openstack/keystone: Removed Server class from __init__.py.  https://review.openstack.org/212700:46
openstackgerritMonty Taylor proposed a change to openstack/keystone: Removed Server class from __init__.py.  https://review.openstack.org/212700:47
mtayloroops. pep8. fixed00:47
mtaylorjeblair: ^^00:47
*** rods has joined #openstack-dev00:48
*** rods has quit IRC00:49
*** rods has joined #openstack-dev00:49
*** rods has quit IRC00:52
*** rods has joined #openstack-dev00:52
*** gyee has quit IRC00:54
jeblairmtaylor: reviewed00:54
*** ayoung has joined #openstack-dev00:54
*** reed has joined #openstack-dev00:55
*** negronjl has quit IRC00:59
openstackgerritMonty Taylor proposed a change to openstack/keystone: Removed Server class from __init__.py.  https://review.openstack.org/212700:59
mtaylorjeblair: k. all good points. fixed00:59
*** adjohn has joined #openstack-dev01:01
openstackgerritMonty Taylor proposed a change to openstack/keystone: Removed Server class from __init__.py.  https://review.openstack.org/212701:01
*** rods has quit IRC01:05
*** ohnoimdead has quit IRC01:13
*** spiffxp has quit IRC01:13
*** jmckenty has quit IRC01:13
*** _adjohn has joined #openstack-dev01:14
*** adjohn has quit IRC01:14
*** _adjohn is now known as adjohn01:14
*** beekhof_ has quit IRC01:19
*** lloydde has quit IRC01:22
openstackgerritandrewbogott proposed a change to openstack/nova: Handle the 'instance' half of blueprint InstanceAndFloatingIPDNSForNova.  https://review.openstack.org/191001:31
*** zns has joined #openstack-dev01:31
openstackgerritandrewbogott proposed a change to openstack/nova: Handle the 'instance' half of blueprint blueprint public-and-private-dns  https://review.openstack.org/191001:32
*** spiffxp has joined #openstack-dev01:33
*** rohitk has quit IRC01:33
*** Mandell_ has joined #openstack-dev01:38
*** Mandell has quit IRC01:38
*** rohitk has joined #openstack-dev01:39
*** vladimir3p has quit IRC01:47
*** mwhooker has quit IRC01:47
openstackgerritLorin Hochstein proposed a change to openstack-ci/git-review: Fix bug 901030  https://review.openstack.org/212901:51
uvirtbotLaunchpad bug 901030 in git-review "git review -d fails if topic is blank" [Undecided,New] https://launchpad.net/bugs/90103001:51
*** novas0x2a|laptop has quit IRC01:58
*** beekhof_ has joined #openstack-dev01:58
*** rsampaio has joined #openstack-dev02:13
*** jog0 has quit IRC02:22
*** maplebed has quit IRC02:29
openstackjenkinsProject nova-docs build #1,729: SUCCESS in 3 min 23 sec: https://jenkins.openstack.org/job/nova-docs/1729/02:34
openstackjenkinsjogo: Remove bzr related code in tests/test_misc02:34
*** spiffxp has quit IRC02:40
*** negronjl has joined #openstack-dev02:44
*** winston-d has quit IRC02:46
*** andrewbogott has quit IRC02:48
openstackjenkinsProject nova-docs build #1,730: SUCCESS in 3 min 0 sec: https://jenkins.openstack.org/job/nova-docs/1730/02:48
openstackjenkinsmark.washenberger: vm_state:=error on driver exceptions during resize02:48
*** ben_duyujie has joined #openstack-dev02:54
*** rsampaio has quit IRC02:57
*** rohitk has quit IRC03:07
*** rsampaio has joined #openstack-dev03:09
openstackgerritGaurav Gupta proposed a change to openstack/nova: Added support for creating nova volume snapshots using OS API.  https://review.openstack.org/120203:10
*** bcwaldon has joined #openstack-dev03:11
*** jog0_ has joined #openstack-dev03:18
*** novas0x2a|laptop has joined #openstack-dev03:21
*** adjohn has quit IRC03:28
*** mikeyp has left #openstack-dev03:32
*** CampbellM has joined #openstack-dev03:32
*** CampbellM has quit IRC03:36
*** rsampaio has quit IRC03:38
*** adjohn has joined #openstack-dev03:40
*** spiffxp has joined #openstack-dev03:43
*** nati2 has quit IRC03:46
*** nati2 has joined #openstack-dev03:47
openstackgerritDan Prince proposed a change to openstack/keystone: Fix auth_token middleware: make _verify_claims not static. Fixes bug #901049.  https://review.openstack.org/213003:49
*** rohitk has joined #openstack-dev03:49
uvirtbotLaunchpad bug 901049 in keystone "auth_token middleware: global name 'self' is not defined" [Undecided,In progress] https://launchpad.net/bugs/90104903:49
*** dprince has joined #openstack-dev03:50
dprincekeystone devs: https://review.openstack.org/#change,213003:50
*** rnirmal has joined #openstack-dev03:50
dprincesend this ^^^03:50
*** dprince has quit IRC03:51
znsdprince: approved03:52
*** jeremy has quit IRC03:52
*** jeremy has joined #openstack-dev03:54
*** jeremy has joined #openstack-dev03:54
*** CampbellM has joined #openstack-dev03:54
*** CampbellM has quit IRC03:55
*** lts has quit IRC03:58
*** Rajaram has joined #openstack-dev03:59
*** nati2 has quit IRC04:00
*** anotherjesse has joined #openstack-dev04:02
*** nati2 has joined #openstack-dev04:02
*** lloydde has joined #openstack-dev04:03
*** adjohn has quit IRC04:04
*** bcwaldon has quit IRC04:05
*** jeremy has quit IRC04:06
*** jeremy has joined #openstack-dev04:08
*** jeremy has joined #openstack-dev04:08
*** anotherjesse has quit IRC04:11
*** troytoman-away has quit IRC04:13
*** troytoman-away has joined #openstack-dev04:17
openstackjenkinsProject nova-docs build #1,731: SUCCESS in 3 min 3 sec: https://jenkins.openstack.org/job/nova-docs/1731/04:18
openstackjenkinsalex.meade: Change cloudServersFault to computeFault04:18
*** nati2 has quit IRC04:25
*** nati2 has joined #openstack-dev04:26
*** bencherian has quit IRC04:31
*** jog0_ has quit IRC04:43
*** jog0 has joined #openstack-dev04:52
*** scottjg has joined #openstack-dev04:55
rmkAre there any docs around VSA?04:58
rmkAside from the blueprints and presentations04:58
annegentlermk: I've asked for docs and I don't think it's fully implemented... looking...04:59
rmkgreat, thanks04:59
*** adjohn has joined #openstack-dev05:00
*** chemikadze has quit IRC05:05
*** nati2_ has joined #openstack-dev05:13
*** dolphm has joined #openstack-dev05:15
*** nati2 has quit IRC05:17
*** _adjohn has joined #openstack-dev05:19
*** adjohn has quit IRC05:20
*** _adjohn is now known as adjohn05:20
*** rnirmal has quit IRC05:21
*** hugokuo has joined #openstack-dev05:23
*** novas0x2a|laptop has quit IRC05:25
*** novas0x2a|laptop has joined #openstack-dev05:28
*** bencherian has joined #openstack-dev05:41
*** nati2_ has quit IRC05:52
*** mjfork has quit IRC05:55
*** bencherian has quit IRC06:06
*** lloydde has quit IRC06:08
*** lloydde has joined #openstack-dev06:08
*** lloydde has quit IRC06:08
*** markmc has joined #openstack-dev06:12
*** spiffxp has quit IRC06:16
*** jog0_ has joined #openstack-dev06:16
*** jog0 has quit IRC06:18
*** jog0_ is now known as jog006:18
*** dolphm has quit IRC06:23
*** zaitcev has quit IRC06:23
*** jog0 has quit IRC06:28
*** jog0 has joined #openstack-dev06:29
*** scottjg has quit IRC06:42
*** reed has quit IRC06:54
*** jog0 has quit IRC06:56
openstackgerritRick Harris proposed a change to openstack/nova: Add model_query helper to handle context.read_deleted.  https://review.openstack.org/213107:00
*** Mandell_ has quit IRC07:29
*** GheRivero_ has joined #openstack-dev07:54
*** jeremy has quit IRC07:57
openstackgerritRick Harris proposed a change to openstack/nova: Refactors periodic tasks to use a decorator.  https://review.openstack.org/213207:59
openstackgerritCraig Vyvial proposed a change to openstack/nova: allowing custom notification log file to be created it desired  https://review.openstack.org/213308:00
*** jeremy has joined #openstack-dev08:01
*** jeremy has joined #openstack-dev08:01
openstackgerritCraig Vyvial proposed a change to openstack/nova: added Craig Vyvial to Authors  https://review.openstack.org/213408:03
*** GheRivero_ has quit IRC08:15
*** reidrac has joined #openstack-dev08:16
*** apevec has joined #openstack-dev08:32
openstackgerritA change to openstack/nova has been rejected: added Craig Vyvial to Authors  https://review.openstack.org/213408:33
*** jeffjapan has quit IRC08:41
openstackgerritRick Harris proposed a change to openstack/nova: Adds runing_deleted_instance reaper task.  https://review.openstack.org/213508:43
*** pixelbeat has joined #openstack-dev08:57
openstackgerritZiad Sawalha proposed a change to openstack/keystone: D5 Compatibility Support  https://review.openstack.org/213608:59
*** zns has quit IRC09:04
*** adjohn has quit IRC09:07
*** adjohn has joined #openstack-dev09:11
*** novas0x2a|laptop has quit IRC09:19
*** ben_duyujie has left #openstack-dev09:22
*** novas0x2a|laptop has joined #openstack-dev09:23
*** novas0x2a|laptop has quit IRC09:34
*** novas0x2a|laptop has joined #openstack-dev09:35
*** darraghb has joined #openstack-dev09:56
*** yamahata has joined #openstack-dev10:07
*** adjohn has quit IRC10:12
*** Diaoer has joined #openstack-dev10:27
*** Diaoer has quit IRC10:28
*** Diaoer has joined #openstack-dev10:29
*** Diaoer has quit IRC10:32
*** Diaoer has joined #openstack-dev10:33
*** aryan has joined #openstack-dev10:39
*** novas0x2a|laptop has quit IRC10:46
*** novas0x2a|laptop has joined #openstack-dev10:47
*** reidrac has quit IRC11:23
*** hugokuo has quit IRC11:24
*** reidrac has joined #openstack-dev11:24
*** novas0x2a|laptop has quit IRC11:33
*** reidrac has quit IRC11:34
*** novas0x2a|laptop has joined #openstack-dev11:34
*** rkukura has quit IRC11:45
*** lts has joined #openstack-dev11:53
*** bourke_ is now known as bourke11:54
*** reidrac has joined #openstack-dev12:02
openstackgerritGavin Brebner proposed a change to openstack/tempest: removed extra whitespace. Updated fix for bug 893845  https://review.openstack.org/213712:24
openstackgerritGavin Brebner proposed a change to openstack/tempest: Added test_create_server_metadata_key_too_long to address https://bugs.launchpad.net/tempest/+bug/893845  https://review.openstack.org/203412:24
uvirtbotLaunchpad bug 893845 in tempest "Server metadata key exceeds 255 bytes" [Medium,In progress] https://launchpad.net/bugs/89384512:24
uvirtbotLaunchpad bug 893845 in tempest "Server metadata key exceeds 255 bytes" [Medium,In progress]12:24
openstackgerritMark McLoughlin proposed a change to openstack/keystone: Fix some issues with new version module  https://review.openstack.org/213812:27
*** reidrac has quit IRC12:32
*** stuntmachine has joined #openstack-dev12:36
*** stuntmachine has quit IRC12:38
openstackgerritMark McLoughlin proposed a change to openstack/glance: Add generic PasteDeploy app and filter factories  https://review.openstack.org/213912:43
*** markvoelker has joined #openstack-dev12:47
openstackgerritMark McLoughlin proposed a change to openstack/glance: Rename 'options' variables to 'conf'  https://review.openstack.org/214012:48
*** hugokuo has joined #openstack-dev12:50
openstackgerritMark McLoughlin proposed a change to openstack/glance: Add new cfg module  https://review.openstack.org/214112:53
*** novas0x2a|laptop has quit IRC12:57
*** reidrac has joined #openstack-dev12:57
*** novas0x2a|laptop has joined #openstack-dev12:59
*** reidrac has quit IRC13:07
*** bsza has joined #openstack-dev13:09
*** Shrews has joined #openstack-dev13:12
*** rods has joined #openstack-dev13:16
*** zns has joined #openstack-dev13:18
*** reidrac has joined #openstack-dev13:20
*** zns has quit IRC13:26
*** rods has quit IRC13:36
*** mjfork has joined #openstack-dev13:37
*** dolphm has joined #openstack-dev13:39
*** reidrac has quit IRC13:43
*** dolphm has quit IRC13:44
*** smoser has quit IRC13:44
*** reidrac has joined #openstack-dev13:44
*** Rajaram has quit IRC13:45
openstackgerritMark McLoughlin proposed a change to openstack/glance: Convert glance to use the new cfg module  https://review.openstack.org/214213:53
*** zns has joined #openstack-dev13:56
*** lloydde has joined #openstack-dev14:09
openstackgerritThierry Carrez proposed a change to openstack/nova: A more secure root-wrapper alternative  https://review.openstack.org/210114:10
*** reidrac has quit IRC14:12
*** gavri has quit IRC14:12
*** ben_duyujie has joined #openstack-dev14:13
*** Adri2000 has quit IRC14:14
*** kbringard has joined #openstack-dev14:15
*** rkukura has joined #openstack-dev14:19
*** Adri2000 has joined #openstack-dev14:24
openstackgerritDan Prince proposed a change to openstack/glance: Remove keystone from pip-requires. Fixes #901018.  https://review.openstack.org/214314:24
openstackgerritDan Prince proposed a change to openstack/glance: Remove keystone from pip-requires. Fixes #901018.  https://review.openstack.org/214314:26
znsdprince: we fixed the Glance issue; this among other fixes - https://review.openstack.org/#change,211714:27
znsdprince: don't we need keystone in glance?14:27
*** troytoman-away is now known as troytoman14:27
*** reidrac has joined #openstack-dev14:29
*** rkukura has quit IRC14:36
*** gavri has joined #openstack-dev14:41
markmczns, glance's install_venv.py still doesn't work, though14:42
markmczns, I definitely saw keystone's setup.py trying to import PasteDeploy before it had been installed14:43
znsDo you have a failed build in Jenkins I can look at?14:43
markmczns, when I did get it installed into the venv, glance's tests were failing because of this: https://review.openstack.org/213814:44
markmczns, this looks like it: https://jenkins.openstack.org/view/Glance/job/glance-venv/36/console14:44
*** bcwaldon has joined #openstack-dev14:47
*** mattray has joined #openstack-dev14:49
znsmarkmc, dprince: might need to get this in and retry: https://review.openstack.org/#change,212714:51
*** mdomsch has joined #openstack-dev14:55
openstackgerritZiad Sawalha proposed a change to openstack/keystone: Removed Server class from __init__.py.  https://review.openstack.org/212714:59
*** lloydde has quit IRC15:02
openstackgerritMark McLoughlin proposed a change to openstack/keystone: Fix some issues with new version module  https://review.openstack.org/213815:08
*** dolphm has joined #openstack-dev15:08
*** zns1 has joined #openstack-dev15:08
*** hub_cap has joined #openstack-dev15:08
*** zns has quit IRC15:11
kbringarddo we know if source security groups is working in the latest essex drops?15:19
kbringardhttp://paste.openstack.org/show/3676/15:19
kbringardthat's using, what I believe is the latest diablo backport15:20
*** jmckenty has joined #openstack-dev15:24
openstackgerritMark McLoughlin proposed a change to openstack/nova: Remove extra_context support in Flags  https://review.openstack.org/214515:26
*** dolphm has quit IRC15:26
*** rsampaio has joined #openstack-dev15:26
*** novas0x2a|laptop has quit IRC15:28
*** novas0x2a|laptop has joined #openstack-dev15:29
openstackgerritA change to openstack/glance has been rejected: Remove keystone from pip-requires. Fixes bug #901018.  https://review.openstack.org/214315:30
uvirtbotLaunchpad bug 901018 in keystone "setup.py imports keystone before dependencies are satisfied" [High,In progress] https://launchpad.net/bugs/90101815:30
openstackgerritDan Prince proposed a change to openstack/glance: Remove keystone from pip-requires. Fixes bug #901018.  https://review.openstack.org/214315:32
uvirtbotLaunchpad bug 901018 in keystone "setup.py imports keystone before dependencies are satisfied" [High,In progress] https://launchpad.net/bugs/90101815:32
*** Rajaram has joined #openstack-dev15:33
openstackgerritMark McLoughlin proposed a change to openstack/nova: Add new cfg module  https://review.openstack.org/214615:33
*** lloydde has joined #openstack-dev15:36
*** bencherian has joined #openstack-dev15:39
*** dubsquared has joined #openstack-dev15:40
*** zns1 has quit IRC15:40
*** dolphm has joined #openstack-dev15:42
*** vladimir3p has joined #openstack-dev15:45
*** reed has joined #openstack-dev15:49
openstackgerritMark McLoughlin proposed a change to openstack/nova: Port nova.flags to cfg  https://review.openstack.org/214715:52
*** jaypipes has quit IRC15:53
*** code_franco has joined #openstack-dev15:55
*** rnirmal has joined #openstack-dev15:58
zulttx: so for the rootwrapper if someone adds a command that needs root they have to modify the rootwrapper?16:02
*** adjohn has joined #openstack-dev16:03
ttxzul: they have to modify the corresponsing list of filters, yes16:03
*** cp16net has joined #openstack-dev16:04
openstackgerritAndrea Rosa proposed a change to openstack/nova: Exception handler for kombu connnection  https://review.openstack.org/150316:05
*** hugokuo has left #openstack-dev16:11
*** lloydde has quit IRC16:11
*** reidrac has quit IRC16:14
openstackgerritBrian Waldon proposed a change to openstack/python-novaclient: Clean up image-list cli command  https://review.openstack.org/214816:15
*** ben_duyujie has quit IRC16:17
*** spiffxp has joined #openstack-dev16:17
*** jaypipes has joined #openstack-dev16:17
*** rkukura has joined #openstack-dev16:19
*** mdomsch has quit IRC16:19
jaypipesbcwaldon: heyo, could you ping dprince this morning when he gets in... let him know I'm available on IRC to chat about the functional integration tests stuff...16:25
bcwaldonyeah16:25
jaypipesbcwaldon: thx!16:25
bcwaldonhe's working on getting on irc16:25
jaypipesbcwaldon: coolio. :)16:25
bcwaldontoo many people on the network here on freenode16:26
jaypipesbcwaldon: seriously? wow...16:26
jaypipesbcwaldon: I'm the only one in my office ;)16:27
bcwaldonYep, I have to get on VPN to get on IRC16:27
bcwaldonlucky16:27
openstackgerritA change to openstack/glance has been rejected: Comment out keystone from pip-requires. Fixes bug #901018.  https://review.openstack.org/214316:28
uvirtbotLaunchpad bug 901018 in keystone "setup.py imports keystone before dependencies are satisfied" [High,In progress] https://launchpad.net/bugs/90101816:28
jaypipesVek: ping16:29
*** zaitcev has joined #openstack-dev16:29
jaypipesFYI, 30 minutes until QA team meeting on #openstack-meeting16:30
bcwaldonjaypipes: thanks for the reminder16:31
Shrewsjaypipes: yo man. long time no chat16:32
jaypipesShrews: holy crap! :) how are ya?16:32
Shrewsjaypipes: good. i heard the cool kids were hanging out here now. thought i'd check it out.16:33
jaypipesShrews: :)16:33
*** bencherian has quit IRC16:35
openstackgerritBrian Waldon proposed a change to openstack/python-novaclient: Clean up image-show  https://review.openstack.org/214916:41
*** cp16net has left #openstack-dev16:43
*** cp16net has joined #openstack-dev16:43
*** novas0x2a|laptop has quit IRC16:47
cp16netif you submit something to gerrit for review there is no button to say hey i really didnt mean to is there?16:48
jeblaircp16net: "Abandon change"16:48
cp16netoh :) i guess i could have used that last night... thx16:49
*** lorin1 has joined #openstack-dev16:51
*** zns has joined #openstack-dev16:57
*** maplebed has joined #openstack-dev16:59
*** jmckenty has quit IRC17:00
openstackgerritBrian Waldon proposed a change to openstack/nova: Clean up snapshot metadata  https://review.openstack.org/215017:01
*** lloydde has joined #openstack-dev17:01
*** Diaoer has quit IRC17:03
openstackjenkinsProject nova-docs build #1,732: SUCCESS in 3 min 37 sec: https://jenkins.openstack.org/job/nova-docs/1732/17:04
openstackjenkinsMark McLoughlin: Remove extra_context support in Flags17:04
*** code_franco has quit IRC17:09
*** code_franco_ has joined #openstack-dev17:09
*** code_franco_ is now known as code_franco17:09
*** sleepsonthefloo has joined #openstack-dev17:10
znsmarkmc: Glance build went through: https://jenkins.openstack.org/view/Glance/job/glance-venv/38/. Was that the fix we did in Keystone or did you guys change anything?17:10
markmczns, not 100% sure, but your moving Server out of keystone/__init__.py looked like a plausible fix for it17:11
markmczns, without this https://review.openstack.org/#change,2138 glance's functional tests will still fail, though17:12
markmczns, I hope you're ready for glance folks hunting you down everytime something breaks in keystone ? :)17:12
znsmarkmc: It will keep the momentum and pressure on us to get where nothing breaks in Keystone ;-)17:14
*** dspano has joined #openstack-dev17:14
* markmc kicks off a glance build in jenkins for giggles17:15
*** bencherian has joined #openstack-dev17:16
markmcjeblair, any idea on this? https://jenkins.openstack.org/view/Glance/job/glance/89371/console17:16
markmcjeblair, also, should venv rebuilds kick off any jobs that use the venv?17:16
*** f-yang has quit IRC17:17
znsVek: can you re-approve https://review.openstack.org/#change,1825?17:18
jeblairmarkmc: that job is only meant to run from a gerrit trigger17:18
jeblairmarkmc: you can re-trigger a previous run, or trigger by searching for a change17:19
openstackgerritBrian Waldon proposed a change to openstack/nova: Clean up snapshot metadata  https://review.openstack.org/215017:19
markmcjeblair, oh, interesting17:19
jeblairmarkmc: what's your overall intent?17:19
* markmc plays around17:19
*** rods has joined #openstack-dev17:19
markmcjeblair, to prove that glance tests are failing with latest keystone17:19
* markmc retriggers17:20
openstackgerritVerification of a change to openstack/glance failed: Rename .glance-venv to .venv.  https://review.openstack.org/207917:20
jeblairoh, we can build the venv now, that's something.17:20
jeblairmarkmc: 1 sec, there's a bunch of things going on here. :)17:21
znsmarkmc: aren't we renaming all venv's to venv?17:21
znsjeblair: yes, I built the venv after the Keystone change.17:21
markmcjeblair, my favourite quote from the week so far is "Everything is fucked. I hate computers". Appropriate here?17:22
jeblairso i had a "mv" command in the copy-venv job because we couldn't build the venv so it had the wrong name17:22
markmccool17:22
jeblairi've removed the mv command, now that we have an appropriate venv17:22
* markmc retriggers again17:22
*** adjohn has quit IRC17:24
openstackgerritVerification of a change to openstack/glance failed: Rename .glance-venv to .venv.  https://review.openstack.org/207917:25
markmcah, there we go17:25
markmczns, AttributeError: 'module' object has no attribute 'version'17:25
* markmc wanders off17:25
*** Rajaram has quit IRC17:25
*** nati2 has joined #openstack-dev17:28
openstackgerritRick Harris proposed a change to openstack/nova: Add model_query helper to handle context.read_deleted.  https://review.openstack.org/213117:29
*** Mandell has joined #openstack-dev17:30
*** nati2 has quit IRC17:30
*** nati2 has joined #openstack-dev17:31
*** dwalleck has joined #openstack-dev17:41
*** zns has quit IRC17:44
openstackgerritRick Harris proposed a change to openstack/nova: Refactors periodic tasks to use a decorator.  https://review.openstack.org/213217:45
*** spiffxp has quit IRC17:45
*** dolphm_ has joined #openstack-dev17:47
*** adjohn has joined #openstack-dev17:47
*** dolphm has quit IRC17:48
*** adjohn has quit IRC17:50
*** jog0 has joined #openstack-dev17:54
*** reed has quit IRC17:55
*** andrewbogott has joined #openstack-dev17:56
*** spiffxp has joined #openstack-dev17:57
jeblairlorin1: https://review.openstack.org/#change,187917:59
lorin1jeblair: Hey, it's working!17:59
jeblairlorin1: jenkins verified it, but it needs a +2 to merge now17:59
jeblairlorin1: sorry about that, it was due to the venv caching we do on jenkins (full details in the bug)18:00
lorin1jeblair: It turns out I may have pre-emptively +2'd it in the first place, though. I'll +1 it for now, hopefully another nova-core can +2 it.18:02
*** gyee has joined #openstack-dev18:02
jeblairok :)18:02
lorin1jeblair: Jenkins catching it wasn't a bug, it was a feature!18:02
*** dolphm has joined #openstack-dev18:02
jeblairright, it was just our bug, not duncan's.  :)18:03
*** dolphm_ has quit IRC18:05
openstackgerritRick Harris proposed a change to openstack/nova: Refactors periodic tasks to use a decorator.  https://review.openstack.org/213218:07
andrewbogottIn a review, kevin mitchell writes: "There are also a couple of assignments that use '\' as well—is there any way we can get rid of that, maybe by using a temporary variable if the lines would be longer than 79 characters?"18:13
andrewbogottI'm wondering -- is it really worth obfuscating code in order to keep the line length down?  Is there some consequence to line length that I'm missing?18:13
*** nati2 has quit IRC18:15
*** lorin1 has quit IRC18:15
vishyandrewbogott: the consequence is the code won't merge18:16
*** bencherian has quit IRC18:16
vishy:)18:16
andrewbogottUm... because git doesn't like \'s, or because reviewers don't?18:17
andrewbogottI mean, I can get rid of the continuation by doing this:18:17
andrewbogott        foo = utils.import_object(FLAGS.instance_dns_manager)18:17
andrewbogott        self.instance_dns_manager = foo18:17
andrewbogottBut that seems like madness!18:17
vishygeneral python style is to avoid \ if at all possible18:17
vishyso most python devs prefer other methods18:18
*** vladimir3p has quit IRC18:18
andrewbogotte.g. inscrutable variable names :(18:18
*** rkukura has quit IRC18:19
vishywell not usually :)18:19
vishyyou don't have to use foo!18:19
openstackjenkinsProject nova-docs build #1,733: SUCCESS in 4 min 3 sec: https://jenkins.openstack.org/job/nova-docs/1733/18:19
openstackjenkinsduncan: First steps towards consolidating testing infrastructure18:19
andrewbogottI would use 'arbitraryvariabletoavoidlinecontinuation' but that would be too long and cause a line continuation.18:20
andrewbogottBut, anyway -- I will resubmit :)18:21
vishyandrewbogott: I think there are times when a \ is fine18:22
openstackgerritJohannes Erdfelt proposed a change to openstack/nova: Fix race condition in XenAPI list_instances  https://review.openstack.org/215118:22
openstackgerritBrian Waldon proposed a change to openstack/python-novaclient: Clean up image-show  https://review.openstack.org/214918:22
*** dwalleck has quit IRC18:23
*** rkukura has joined #openstack-dev18:24
*** lorin1 has joined #openstack-dev18:25
*** lorin1 has quit IRC18:25
*** darraghb has quit IRC18:28
*** reidrac has joined #openstack-dev18:28
*** lorin1 has joined #openstack-dev18:29
*** lorin1 has quit IRC18:31
*** lorin1 has joined #openstack-dev18:31
*** jmckenty has joined #openstack-dev18:31
*** novas0x2a|laptop has joined #openstack-dev18:32
*** lorin11 has joined #openstack-dev18:33
openstackjenkinsProject nova-docs build #1,734: SUCCESS in 3 min 32 sec: https://jenkins.openstack.org/job/nova-docs/1734/18:34
openstackjenkins* alex.meade: Update associate_floating_ip to use instance objs18:34
openstackjenkins* Rick Harris: Refactors periodic tasks to use a decorator.18:34
*** lorin1 has quit IRC18:35
mtaylorandrewbogott: some times it gets odd, but the 99% case is that strict pep8 compliance makes the codebase easier to read18:38
*** dolphm has quit IRC18:38
mtaylorandrewbogott: there are, of course, cases where compliance makes you want to kill bunnies18:38
andrewbogottSure, I'm for short lines in the abstract.  Just sad about this particular case where I need to obfuscate my code.18:39
mtayloragree18:39
*** adjohn has joined #openstack-dev18:39
*** reed has joined #openstack-dev18:39
andrewbogottesp. since the long variable names are from a blueprint; not really up for debate.18:40
*** mdomsch has joined #openstack-dev18:44
*** vladimir3p has joined #openstack-dev18:45
mtaylortroytoman: ping18:46
troytomanmtaylor: yes?18:47
*** rohitk has quit IRC18:48
mtaylortroytoman: are you a good person to bug about a cloud servers ticket we've got open with no resolution?18:48
troytomanmtaylor: i'm a good place to start.18:49
mtaylortroytoman: ticket #25812718:49
mtaylortroytoman: we have a script which deletes a named image and then makes a new one18:49
mtaylortroytoman: and we'18:49
*** lorin1 has joined #openstack-dev18:49
mtaylortroytoman: and we're getting errors that the image of that name already exists18:49
mtaylortroytoman: (this is in support of openstack integration testing)18:50
troytomanmtaylor: let me look into it18:50
mtaylortroytoman: thank you!18:50
*** lorin11 has quit IRC18:52
*** dolphm has joined #openstack-dev18:53
*** dolphm has quit IRC18:56
openstackgerritandrewbogott proposed a change to openstack/nova: Handle the 'instance' half of blueprint public-and-private-dns  https://review.openstack.org/191018:57
*** lorin1 has quit IRC18:59
*** bencherian has joined #openstack-dev19:00
*** lorin1 has joined #openstack-dev19:03
*** nickon has joined #openstack-dev19:06
troytomanmtaylor: apparently the image showed deleted in one place but not another. we've fixed it and you should be OK19:10
troytomanmtaylor: still investigating how that happened in the first place19:10
*** dolphm has joined #openstack-dev19:11
*** nickon has quit IRC19:14
mtaylortroytoman: awesome. you are a wonderful human.19:16
mtaylortroytoman: and just for that, I'll make sure your client repo gets taken care of today :)19:17
troytomanmtaylor: :)19:17
openstackgerritBrian Waldon proposed a change to openstack/python-novaclient: Clean up image-list cli command  https://review.openstack.org/214819:18
openstackgerritJake Dahn proposed a change to openstack/horizon: Merging Instances and Volumes into a single panel.  https://review.openstack.org/215219:22
openstackgerritJake Dahn proposed a change to openstack/horizon: Merging Instances and Volumes into a single panel.  https://review.openstack.org/215219:25
*** dolphm has quit IRC19:28
johan_-_is jenkins wedged? i have an approved review that's been stuck for an hour19:30
*** _adjohn has joined #openstack-dev19:30
*** sleepsonthefloo_ has joined #openstack-dev19:31
mtaylorjohan_-_: link/19:31
mtaylor?19:31
*** reed_ has joined #openstack-dev19:31
johan_-_https://review.openstack.org/#change,215119:31
*** sleepsonthefloo has quit IRC19:32
*** sleepsonthefloo_ is now known as sleepsonthefloo19:32
*** adjohn has quit IRC19:32
*** _adjohn is now known as adjohn19:32
*** reed has quit IRC19:32
mtaylorjohan_-_: weird. thanks. should be running now19:33
openstackgerritVerification of a change to openstack/nova failed: Fix race condition in XenAPI list_instances  https://review.openstack.org/215119:34
sandywalsh./run_tests.sh -N doesn't work any more19:37
sandywalshjust returns19:37
openstackgerritBrian Waldon proposed a change to openstack/python-novaclient: Fixing all remaining pep8 errors  https://review.openstack.org/215319:37
*** dwalleck has joined #openstack-dev19:38
*** novas0x2a|laptop has quit IRC19:39
*** novas0x2a|laptop has joined #openstack-dev19:40
*** zns has joined #openstack-dev19:40
*** bcwaldon has quit IRC19:40
*** bcwaldon has joined #openstack-dev19:40
*** dwalleck has quit IRC19:44
sandywalshoubiwann (Duncan McGreggor) in the room?19:46
*** smoser has joined #openstack-dev19:46
sandywalsh(or whatever his nick is?)19:46
smoserhey... i'm sure i'm missing something19:46
smoserbut looking at devstack, it has: glance add -A $SERVICE_TOKEN name="$IMAGE_NAME" is_public=true container_format=ami disk_format=ami kernel_id=$KERNEL_ID19:46
mtaylorsandywalsh: run_tests.sh spits errors into a run_tests.log19:46
mtaylorsandywalsh: so when it just returns like that, look in the log file19:47
smoserthat is run (i think) as normal user.  SERVICE_TOKEN is basically a password.  how does glance know which user is doing this ?19:47
smoserjaypipes, ^19:47
sandywalshmtaylor, thanks19:47
*** GheRivero_ has joined #openstack-dev19:47
tr3buchetmarkmc: https://review.openstack.org/#change,202819:47
jaypipessmoser: the value of OS_AUTH_USER env variable.19:49
smoserah. ok. is there a way to specify that on command line ?19:49
jaypipessmoser: one sec19:49
jaypipessmoser: no, there is not apparently.19:52
jaypipessmoser: should be though...19:52
smosermaybe it also respects NOVA_USERNAME ?19:52
*** jakedahn has joined #openstack-dev19:53
smoseras devstack does not set OS_AUTH_USER afaik19:53
*** AlanClark has joined #openstack-dev19:54
openstackgerritBrian Waldon proposed a change to openstack/nova: Clean up snapshot metadata  https://review.openstack.org/215019:54
*** _adjohn has joined #openstack-dev19:56
jaypipessmoser: there is a tools/nova_to_os_env.sh script in Glance that copies the NOVA_XX env vars. anotherjesse and I were talking about simplifying things: http://wiki.openstack.org/CLIAuth19:56
smoserit appears it will just magically respond19:56
*** adjohn has quit IRC19:57
*** _adjohn is now known as adjohn19:57
openstackgerritDan Prince proposed a change to openstack/openstack-chef: Update glance::load_images to use /var/lib/glance/chef_images_loaded.  https://review.openstack.org/215419:57
smoserhttp://paste.ubuntu.com/763090/19:58
*** adjohn has quit IRC19:59
smoserjaypipes, ^ . there, 'golfing' is a valid password, but i dont knwo how glance knows which user to pair that with. maybe if there is only one user, but that would seem not right anyway.20:01
jaypipessmoser: that token must be for a specific tenant then?20:04
smoserjaypipes, i'm extremely ignorant luser here...20:04
jaypipessmoser: so when the auth plugin does a lookup into keystone for that token, it returns a tenantId?20:04
smoserjust using devstack and reading what it does20:04
jaypipessmoser: hehe, no worries, so am I. :)20:04
jaypipessmoser: devstack adds a special token for an admin user. perhaps you are using that?20:05
smoseri'm  just hoping that nothing is doing a query against all users for a password if there is no user given.20:05
smoserhow would it be using that? maybe request coming from localhost or something ?20:05
jaypipessmoser: I have to run out for a sec :( perhaps zns could help on the question of an "admin token" and how it might determine a tenant from a token.20:05
smoserbasically... run stack.sh... . openrc ... glance add20:06
jaypipessmoser: yes, devstack sets up keystone on localhost:5001 (and 35357 or something like that), which glance will default to I believe...20:06
andrewbogottHas anyone run the python-novaclient tests recently?  I'd expect them to work out of the box, but apparently I need something else in my environment...20:07
andrewbogottspecifically, it can't find a lot of python libs that are otherwise available to python.20:07
znssmoser, jaypipes: GET /v2.0/tokens/:id returns the data (on the admin service, usually 35357 - I think 5001 in older configs before IANA assigned us 35357). It depends on what you are looking for. Are you looking for the tenant that the user specified when they asked for the token or are you looking to see what tenants they have access to?20:09
openstackgerritGabriel Hurley proposed a change to openstack/horizon: Updated docs for the Dashboard.panels attribute to be clearer.  https://review.openstack.org/215520:11
smoserzns, i was just confused. i run 'env -i glance -A golfing index'20:11
smoserso glance isn't picking up anything from environment20:11
smoserand i get a list20:11
smoserwhich i guess means it is hitting the admin port. so i guess essentially the admin password in my case is 'golfing' and glance is just essentially using 'admin' as the user ?20:12
smoserfeel free to tell me bug off... keystone is new to me.20:13
zaitcevI'm still having that 404 problem with Swift.20:17
zaitcev"HEAD /vdb/18239/AUTH_1" 404 - "-" "-" "-" 0.0010 ""20:18
znssmoser: sorry, stepped away for a bit. Not sure, but you can add a debug filter to Keystone to see incoming requests (header and body) and responses (headers,body as well) and that might help figure out what Glance is sending.20:18
znsThe way to do that is add the debug middleware in your config:20:18
zns[pipeline:admin]20:18
znspipeline =20:18
zns    urlrewritefilter20:18
zns    debug20:18
zns    admin_api20:18
znsYou need (and should already have) this in the config as well:20:19
zns[filter:debug]20:19
znspaste.filter_factory = keystone.common.wsgi:debug_filter_factory20:19
znsvladimir3p: here's the D5 compatibility piece I promised yesterday: https://review.openstack.org/#change,213620:20
smoserit looks like that is it.20:20
smoser{"access": {"token": {"expires": "2015-02-05T00:00:00", "id": "golfing", "tenant": {"id": "1", "name": "admin"}}, "user": {"username": "admin", "id": "1", "roles": [{"tenantId": "1", "id": "1", "name": "Admin"}, {"id": "1", "name": "Admin"}, {"id": "3", "name": "KeystoneAdmin"}, {"id": "4", "name": "KeystoneServiceAdmin"}]}}}20:20
znsSo 'golfing' is your token id! Usually a UUID-looking string.20:22
*** adjohn has joined #openstack-dev20:23
znsAnd the token looks like it has all admin roles (Admin, KeystoneAdmin, KeystoneServiceAdmin) [these names are configurable in the conf file, so I can't guarantee the names, but looks like it...20:24
znssmoser: so, correction to your note ^^, 'golfing' is your token id (I don't think it is the password - though it could also be that if you set it up so)20:25
*** hub_cap has quit IRC20:26
smoseryou're right.20:26
smoserthanks zns20:26
znssure thing :-)20:27
*** dolphm has joined #openstack-dev20:27
*** dolphm_ has joined #openstack-dev20:29
*** nickon has joined #openstack-dev20:29
*** Abd4llA has joined #openstack-dev20:31
*** dolphm has quit IRC20:31
zaitcevDo we know anyone who knows Swift and shows up on IRC?20:33
zaitcev(and willing to spend time educating me, I should add)20:34
*** dwalleck has joined #openstack-dev20:34
openstackgerritJohannes Erdfelt proposed a change to openstack/nova: Fix race condition in XenAPI list_instances  https://review.openstack.org/215120:36
*** jmckenty has quit IRC20:41
*** jmckenty has joined #openstack-dev20:42
jaypipeszaitcev: notmyname is a good bet20:42
jaypipeszaitcev: and chmouel20:42
zaitcevjaypipes: Thank you20:43
jaypipeswelcome20:43
*** dolphm_ has quit IRC20:43
dubsquaredjaypipes:  you win.20:46
*** mdomsch_ has joined #openstack-dev20:48
*** bcwaldon has quit IRC20:48
kbringardhey soren, you about?20:55
*** Shrews has quit IRC20:55
sorenkbringard: Kinda.20:56
kbringardhttp://paste.openstack.org/show/3676/20:56
kbringardthink there may be a quick monkeypatch to fix that? or is it going to be something more involved20:56
sorenkbringard: Current trunk?20:56
kbringarddiablo backports20:56
sorenhang on20:56
kbringardit happens when you launch an instance in a security group that has a -o to another group20:57
soreniirc, https://review.openstack.org/#change,815 fixes it.20:57
kbringardmy gut reaction was that it was because there are no ports in the source-group stuff20:57
sorenYeah.20:57
openstackgerritA change to openstack/nova has been rejected: Adds network model and network info cache.  https://review.openstack.org/202820:58
sorenIIRC, https://review.openstack.org/#change,815 will at least ensure it doesn't happen again. I forget if it solves it for existing rules.20:58
kbringardyea, this is a new setup, I don't care about existing rules20:58
sorenCool.20:58
kbringardso, probably a stupid question, but what is (or is there) a way to make that into a patch that I can apply to my system :-D20:59
sorengit fetch https://review.openstack.org/p/openstack/nova refs/changes/15/815/5 && git format-patch -1 --stdout FETCH_HEAD20:59
sorenkbringard: Right above the two diff buttons, there's a table of information.21:00
kbringardah, yoda man21:00
sorenkbringard: If you click the patch option, it shows you the command you need to run. That's what I just copied.21:00
sorenI have no clue how it works, so if it doesn't work, ask someone else :)21:00
kbringardah, super easy21:00
kbringardhaha21:00
kbringardI'll give it a try and let you know :-D21:00
kbringardnow to check and see if this is marked to go into the backports21:01
sorenIf you're working from a git checkout, this will cherry-pick it instead: https://review.openstack.org/#change,81521:01
sorenerr..21:01
sorenwhoops.21:01
sorenIf you're working from a git checkout, this will cherry-pick it instead: git fetch https://review.openstack.org/p/openstack/nova refs/changes/15/815/5 && git cherry-pick FETCH_HEAD21:01
kbringardI'm not… that's where it gets compricated21:01
kbringardit's the RS CloudBuilders package21:01
kbringardso I may not be able to do it, since this particular change may rely on other changes that aren't there yet21:02
*** dolphm has joined #openstack-dev21:02
kbringardmarkmc: do you happen to know if this patch is in backports, or queued to be?21:03
kbringardlooks like the last commit to the to your nova branch was from Oct 2621:04
*** ayoung has quit IRC21:04
*** ayoung has joined #openstack-dev21:05
markmckbringard, no, looks like it's not there yet21:11
markmckbringard, I've reviewed as far as 2826e862d73d21:11
markmckbringard, Nov 821:11
* markmc hadn't realized he was a full month behind21:11
kbringardah, it's probably worth taking a look… if you you try to launch a VM in a security group that has a source group set, it'll fail to launch the VM21:12
*** zns1 has joined #openstack-dev21:14
markmckbringard, noted :) https://github.com/markmc/nova/commit/1b48384ecbbf9e86d21511767058c2eb1b32426c21:16
kbringardthank you, sir21:17
*** zns has quit IRC21:17
*** zaitcev has quit IRC21:19
*** zns has joined #openstack-dev21:19
openstackjenkinsProject nova-docs build #1,735: SUCCESS in 3 min 48 sec: https://jenkins.openstack.org/job/nova-docs/1735/21:19
openstackjenkinsbrian.waldon: Clean up snapshot metadata21:19
*** zns1 has quit IRC21:22
*** dolphm has quit IRC21:24
openstackgerritDolph Mathews proposed a change to openstack/keystone: Implemented bp portable-identifiers for tenants  https://review.openstack.org/215621:25
openstackgerritDolph Mathews proposed a change to openstack/keystone: Exposes tenant UID's (bp portable-identifiers)  https://review.openstack.org/215721:25
openstackgerritGabriel Hurley proposed a change to openstack/horizon: Cleanup of splash page error messages and keystone error handling.  https://review.openstack.org/215821:26
markmcjeblair, you know this error gerrit gives you if you try and propose someone else's patch ?21:27
markmcjeblair, and the check doesn't apply to core members21:27
openstackgerritJohannes Erdfelt proposed a change to openstack/nova: Fix race condition in XenAPI when using <object>.get_all  https://review.openstack.org/215121:27
markmcjeblair, can we remove that restriction from the stable branch?21:27
markmcjeblair,  I'd like to encourage folks to cherry pick and propose other people's patches from master21:28
*** zns has quit IRC21:30
*** zns has joined #openstack-dev21:31
*** jmckenty has quit IRC21:31
*** dwalleck has quit IRC21:32
*** zns1 has joined #openstack-dev21:33
*** reed_ is now known as reed21:34
*** zns has quit IRC21:35
jeblairmarkmc: i think so, but let me think about the ramifications for a bit.21:36
markmcjeblair, thinking is not allowed!21:37
markmcjeblair, but ok, if you insist :)21:37
openstackgerritDan Prince proposed a change to openstack/nova: Set instance['host'] to the original host value on revert resize. Fixes bug #901445  https://review.openstack.org/215921:37
uvirtbotLaunchpad bug 901445 in nova "instance['host'] is not reverted on revert-resize" [Medium,In progress] https://launchpad.net/bugs/90144521:37
*** lorin1 has quit IRC21:38
openstackgerritDolph Mathews proposed a change to openstack/keystone: Implemented bp portable-identifiers for tenants  https://review.openstack.org/215621:42
*** dwalleck has joined #openstack-dev21:51
*** dwalleck has quit IRC21:52
*** dwalleck has joined #openstack-dev21:53
openstackgerritRick Harris proposed a change to openstack/nova: Add model_query helper to handle context.read_deleted.  https://review.openstack.org/213121:54
*** lloydde has quit IRC21:56
*** mdomsch has quit IRC21:57
openstackgerritBrian Waldon proposed a change to openstack/nova: Set instance['host'] to the original host value on revert resize. Fixes bug #901445  https://review.openstack.org/215921:59
uvirtbotLaunchpad bug 901445 in nova "instance['host'] is not reverted on revert-resize" [Medium,In progress] https://launchpad.net/bugs/90144521:59
openstackgerritRick Harris proposed a change to openstack/nova: Add model_query helper to handle context.read_deleted.  https://review.openstack.org/213121:59
*** lts has quit IRC22:01
openstackgerritTrey Morris proposed a change to openstack/nova: Adds network model and network info cache.  https://review.openstack.org/202822:01
*** jmckenty has joined #openstack-dev22:03
*** rkukura has quit IRC22:06
*** markvoelker has quit IRC22:09
openstackgerritRick Harris proposed a change to openstack/nova: Add model_query helper to handle context.read_deleted.  https://review.openstack.org/213122:10
*** dragondm has joined #openstack-dev22:10
vishys1rp_ : commented on the bug22:17
*** dwalleck has quit IRC22:18
vishys1rp_: In general I'm concerned about using read_deleted too much, because I'm not sure we can depend on it working with all potential db backends22:18
openstackjenkinsProject nova-docs build #1,736: SUCCESS in 3 min 10 sec: https://jenkins.openstack.org/job/nova-docs/1736/22:19
openstackjenkinsJohannes Erdfelt: Fix race condition in XenAPI when using <object>.get_all22:19
smoserit seems something in devstack is pulling in boto-1.9b, and thats screwing up euca2ools22:19
smoseras they need 2.x22:19
smosercarrot maybe22:19
*** lloydde has joined #openstack-dev22:21
*** GheRivero_ has quit IRC22:21
s1rp_vishy: yeah, i agree, in the long-run we should completely rethink how read_deleted is being used; perhaps ax'ing it entirely. the proposal is really a short/medium term patch that gives us the functionality we need (for cleanup scripts that need to see both deleted and live records) with minimal risk to existing code22:23
vishyaren't you just saving 1 db call though?22:23
vishyis it worth changing to save that extra call?22:23
s1rp_it's not that simple, AFAICT...22:24
s1rp_most of our core logic passes around this context, and since the calls are deeply nested, we really can't "inject" new logic to add in delted records somewhere in the process22:25
s1rp_we really need to, at the top level, set read_deleted='yes' in order to accomplish that22:25
*** apevec has quit IRC22:25
s1rp_the example that bit me was getting deleted instances, and then having all of the related-object code (ips, networks) refuse to return 'live' records since my context had read_deleted=True...22:29
*** rnirmal has quit IRC22:29
*** lloydde has quit IRC22:30
vishyah interesting22:31
*** nickon has quit IRC22:32
vishythat is odd22:32
vishys1rp_: the read_deleted filter is usually just on the top query22:32
vishyso you can't just set read_deleted on the one db call where you need it?22:33
openstackjenkinsProject nova-docs build #1,737: SUCCESS in 3 min 38 sec: https://jenkins.openstack.org/job/nova-docs/1737/22:34
openstackjenkinsbrian.waldon: Set instance['host'] to the original host value on revert resize.22:34
s1rp_vishy: i tried that as a quick hack, but it was a no-go.... can't remember the exact details at the moment. just remember seeing chained calls using the context, and thinking the only way to handle this was to adjust read_deleted to handle this 3rd case22:35
*** rohitk has joined #openstack-dev22:35
vishyhmm22:35
*** dspano has quit IRC22:36
*** cp16net has quit IRC22:37
*** markmc has quit IRC22:40
vishys1rp_: i don't really get it22:42
vishyit seems like you should just be able to use read_deleted=True22:42
vishyfor this one call: self.db.instance_get_all_by_host(context, self.host)22:42
vishyand set it back to false after22:43
*** rsampaio has quit IRC22:45
*** bsza has quit IRC22:45
vishys1rp_: I really don't know that we "need" to read both ever22:46
s1rp_vishy: yup, that works for that case (wrote something called temporary_mutation to do that for me)... however...22:46
vishys1rp_: there are only two cases where we use read_deleted currently22:46
vishy1) tests22:46
vishy2) nova-manage22:46
s1rp_when you call _shutdown_instance, you pass a context, that in turn, passes the context to get_nw_info, which will then fail to return the network information, because the IPs and networks are live22:46
vishysure, but why would you call shutdown_instance with that context?22:47
s1rp_well, shutdown_instance needs to see both... "deleted" instances, and "live" ips22:47
vishycan't you just undelete the instance with the read_deleted context?22:48
vishythen call shutdown_instance?22:48
s1rp_well, in one case, we want to keep the instance deleted22:48
vishyI want to minimize the depth of calls that are accessing deleted instances22:48
s1rp_we're trying to sweep it.... in another scenario, per your suggestion, we may try to undelete the instance22:48
vishyIn most cases, deleted should be actually deleted.22:49
vishyi understand there are a few cases where we have to see deleted stuff22:49
*** danishman has joined #openstack-dev22:49
s1rp_yeah, though that's going to make cleanup scripts really tough to write, since we won't be able to use any of the current convenience code22:49
vishybut optimizing the code to allow for calls that pull everything seems odd, since I consider that to be a big edge case.22:50
s1rp_i don't really think it's going to be an edge case as we move to production systems...22:50
s1rp_we'll need plenty of cleanup scripts to keep things humming along (until we root out all of the bugs :-)22:50
vishyi guess that is true22:50
vishyI was really hoping to keep deleted semantics in the db layer22:51
vishynow we're forcing a particular implementation of how stuff is deleted.22:51
vishystill seems ugly to me, but I don't suppose it is any uglier than our current stuff22:51
s1rp_we're really only enforcing that deleted stuff isn't truly deleted until 'purged'... but those semantics seem pretty in-grained in the system, so that doesn't worry too much22:52
s1rp_yeah i'd agree it's ugly, but on the plus side, there are some nice clean ups in that patch too. focus on those! :)22:53
s1rp_i view this as a sort-of, hold-you-nose, merge this, and worry about The Right Way, down the line22:54
*** dubsquared has quit IRC23:00
*** jmckenty_ has joined #openstack-dev23:00
*** jmckenty has quit IRC23:00
*** lloydde has joined #openstack-dev23:01
*** troytoman is now known as troytoman-away23:02
*** kbringard has quit IRC23:04
openstackgerritGabriel Hurley proposed a change to openstack/horizon: Cleanup of splash page error messages and keystone error handling.  https://review.openstack.org/215823:12
*** danishman has quit IRC23:13
*** lloydde has quit IRC23:15
*** dolphm has joined #openstack-dev23:16
*** lloydde has joined #openstack-dev23:18
*** bencherian has quit IRC23:24
openstackgerritDuncan McGreggor proposed a change to openstack/nova: Updated the test runner module with a sys.path insert so that tests run in and outside a virtual environment.  https://review.openstack.org/216023:25
*** code_franco has quit IRC23:30
*** mattray has quit IRC23:33
openstackgerritBrad Hall proposed a change to openstack/nova: Fix for bug 901459  https://review.openstack.org/216123:35
uvirtbotLaunchpad bug 901459 in nova "QuantumManager#get_all_networks uninitalized variable" [Undecided,New] https://launchpad.net/bugs/90145923:35
*** nati2 has joined #openstack-dev23:35
*** AlanClark has quit IRC23:39
*** heckj has joined #openstack-dev23:41
openstackgerritBrad Hall proposed a change to openstack/nova: Fix for bug 901459  https://review.openstack.org/216123:42
uvirtbotLaunchpad bug 901459 in nova "QuantumManager#get_all_networks uninitalized variable" [Undecided,New] https://launchpad.net/bugs/90145923:42
*** rods has quit IRC23:46
*** dolphm has quit IRC23:50
*** rbasak has quit IRC23:54
*** zns1 has quit IRC23:56
*** dragondm_ has joined #openstack-dev23:58
*** jakedahn has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!