| *** nati has joined #openstack-dev | 00:14 | |
| *** nati_ has quit IRC | 00:16 | |
| *** bengrue has quit IRC | 00:32 | |
| dysinger | mtaylor: vishy: mistake was mine this morning. I didn't turn on backward compat auth. it cascaded through our automation. | 00:39 |
|---|---|---|
| *** Jaesang has joined #openstack-dev | 00:55 | |
| *** nati has quit IRC | 01:20 | |
| *** rods has quit IRC | 01:22 | |
| *** dysinger has quit IRC | 01:27 | |
| *** xtor_ has quit IRC | 01:27 | |
| *** extor has joined #openstack-dev | 01:27 | |
| *** joonwon has joined #openstack-dev | 01:30 | |
| *** blueblade has joined #openstack-dev | 01:34 | |
| *** blueblade has quit IRC | 01:36 | |
| *** stanchan has quit IRC | 01:37 | |
| *** cp16net has joined #openstack-dev | 01:41 | |
| *** nati has joined #openstack-dev | 01:42 | |
| *** hugokuo has joined #openstack-dev | 01:45 | |
| nati | When I use gerrit , i got a error ;) https://gist.github.com/8ee6025442325db64939 | 02:03 |
| nati | Then I tried to set my username on gerrit, I got application errors http://gyazo.com/a75ef95c69e7adeb730d132b9468924c | 02:04 |
| nati | How can I fix this.. | 02:05 |
| *** HugoKuo_ has joined #openstack-dev | 02:09 | |
| *** hugokuo has quit IRC | 02:13 | |
| *** HugoKuo__ has joined #openstack-dev | 02:22 | |
| *** HugoKuo_ has quit IRC | 02:25 | |
| *** medberry is now known as med_out | 02:45 | |
| rmk | I'm seeing failure conditions I thought were resolved based on the bugs I read.. | 02:53 |
| *** nati has quit IRC | 02:57 | |
| *** martine has joined #openstack-dev | 03:02 | |
| *** toluene has joined #openstack-dev | 03:03 | |
| *** RobertLaptop has joined #openstack-dev | 03:10 | |
| *** joonwon has quit IRC | 03:11 | |
| *** nati has joined #openstack-dev | 03:13 | |
| *** jdag has quit IRC | 03:15 | |
| *** martine_ has joined #openstack-dev | 03:22 | |
| *** martine has quit IRC | 03:22 | |
| openstackgerrit | A change was merged to openstack/keystone: Fix for bug 856846 - cast ints to string in users_get_by_tenant_get_page so that they can be joined https://review.openstack.org/546 | 03:25 |
| uvirtbot | Launchpad bug 856846 in keystone "TypeError: sequence item 0: expected string in users_get_by_tenant_get_page" [Undecided,New] https://launchpad.net/bugs/856846 | 03:25 |
| openstackgerrit | A change was merged to openstack/keystone: Fix for bug 856857 - add user.name to User() constructor to re-align param https://review.openstack.org/547 | 03:27 |
| uvirtbot | Launchpad bug 856857 in keystone "Incorrect invocation of types.user.User constructor" [Undecided,New] https://launchpad.net/bugs/856857 | 03:27 |
| *** dragondm has joined #openstack-dev | 03:29 | |
| *** reed has quit IRC | 04:29 | |
| *** joonwon has joined #openstack-dev | 04:35 | |
| *** zns has quit IRC | 04:37 | |
| *** wwkeyboard has joined #openstack-dev | 04:38 | |
| *** wwkeyboard has quit IRC | 04:48 | |
| *** stanchan has joined #openstack-dev | 05:07 | |
| *** martine_ has quit IRC | 05:11 | |
| *** naehring has joined #openstack-dev | 05:15 | |
| *** zaitcev has quit IRC | 05:37 | |
| *** hbetts has quit IRC | 05:43 | |
| *** joonwon has quit IRC | 05:47 | |
| *** toluene has quit IRC | 06:05 | |
| rmk | Just tested the new block_migration feature and it's corrupting the vm data | 06:09 |
| *** yeming has joined #openstack-dev | 06:21 | |
| *** dragondm has quit IRC | 06:24 | |
| vishy | jeblair, mtaylor: I think if we change rfc.sh slightly we could make it support reviewing from a branched repo. We could make it add a new remote for the openstack repo called os/$PROJECT and rebase on to os/$branch instead of origin/$branch . That way you could fork from gethub / use a team repo and still submit reviews without having to have openstack/$branch be your origin. Thoughts? | 06:42 |
| *** User has joined #openstack-dev | 06:44 | |
| *** sanjay400 has joined #openstack-dev | 06:44 | |
| sanjay400 | Hello, i have source code installation of D3 on 3 nodes (api/schd, compute, network) , to upgrade to Diablo2011.3, should i just kill the services, untar the source and start again in the same way? | 06:49 |
| openstackgerrit | sleepsonthefloor proposed a change to openstack/keystone: Reorder params in User() constructor https://review.openstack.org/549 | 06:54 |
| openstackgerrit | A change was merged to openstack/keystone: Reorder params in User() constructor https://review.openstack.org/549 | 06:56 |
| Daviey | rmk: you got further than me then.. | 06:56 |
| vishy | rmk: I got it to work, but I must say I haven't tested it extensively | 06:57 |
| vishy | there is a new patch to copy backing files as well... | 06:57 |
| rmk | Daviey: Where did you get stuck? | 06:58 |
| vishy | sanjay400: upgrading between milestones like that isn't really supported but it should work | 06:59 |
| Daviey | vishy / rmk: did you use carrot or kombu? | 06:59 |
| rmk | vishy: I was super excited to see the feature, just need to make it not destroy the VM :) | 06:59 |
| vishy | sanjay400: you will have to run a nova-manage db sync | 06:59 |
| rmk | Looks like it's using kombu (Ubuntu 11.04) | 06:59 |
| *** nati has quit IRC | 06:59 | |
| Daviey | rmk: interesting | 06:59 |
| *** nati has joined #openstack-dev | 07:00 | |
| rmk | vishy: New patch not in diablo? | 07:00 |
| vishy | rmk: keeping in mind that it is a pretty new feature in libvirt/kvm, so it may not be totally bug free there yet either | 07:00 |
| vishy | rmk: yes it didn't make it in | 07:00 |
| vishy | rmk: do you see the corruption right away? | 07:00 |
| rmk | yeah immediately | 07:00 |
| rmk | reproducable every time too | 07:00 |
| vishy | rmk: I was able to block migrate tty images just fine, but I haven't done full size ones | 07:00 |
| rmk | I've only tried it with one image so far so I can try other guest OSes | 07:00 |
| vishy | rmk: did you change any flags? | 07:01 |
| rmk | nope I was looking at them though | 07:01 |
| rmk | there's no documentation anywhere about the flags, I just see code references, so I'm not sure what they do | 07:01 |
| Daviey | rmk: Can you write up your entire steps from fresh install? | 07:01 |
| vishy | rmk: so you made libvirtd listen via tcp? | 07:01 |
| Daviey | I assume you made the libvirt config changes aswell? | 07:01 |
| rmk | Daviey: Yeap I am in the process of that actually | 07:02 |
| rmk | Yes, libvirt changes | 07:02 |
| rmk | Otherwise it doesn't work at all | 07:02 |
| rmk | Basically turning off auth and turning on the tcp listener | 07:02 |
| vishy | right | 07:02 |
| Daviey | The instance got torn down on the dest for me. :( | 07:02 |
| vishy | you can also share a root and nova key | 07:02 |
| vishy | and use qemu+ssh | 07:03 |
| rmk | vishy: Figured I'd do that in the future once it's working | 07:03 |
| Daviey | Well, unauth'd is a good first step :) | 07:03 |
| rmk | But yeah going to use unencrypted ssh keys for this once it works | 07:03 |
| Daviey | Hmm, i'm not sure you can migrate over ssh - i think you need to use psk's | 07:03 |
| ttx | mtaylor: https://bugs.launchpad.net/ubuntu/+source/glance/+bug/857021 | 07:03 |
| rmk | The functionality is awesome, it eliminates the primary reason for having NAS in our environment | 07:03 |
| uvirtbot | Launchpad bug 857021 in glance "glance (2011.3-0ubuntu1) fails to install, error in .postinst" [Undecided,New] | 07:04 |
| ttx | mtaylor: dunno if it applies to our ppa | 07:04 |
| vishy | rmk: https://code.launchpad.net/~nttdata/nova/850602/+merge/75480 | 07:04 |
| ttx | vishy: earth still standing ? | 07:04 |
| vishy | don't know | 07:05 |
| rmk | Ah so something isn't being copied now | 07:05 |
| vishy | rmk: in my usage, it didn't copy the backing file, but I didn't notice corruption | 07:05 |
| vishy | rmk: but you could try merging that branch and see if it fixes your issue | 07:06 |
| rmk | yeah I may do that | 07:06 |
| rmk | I'll just apply the patch to my active install | 07:07 |
| rmk | its just a lab environment right now anyway | 07:07 |
| *** reidrac has joined #openstack-dev | 07:07 | |
| vishy | rmk: cool, hopefully it applies cleanly against diablo | 07:07 |
| comstud | are merges on hold ? | 07:07 |
| comstud | for moving to github/gerrit ? | 07:08 |
| vishy | rmk: please share what you find. I would love to see block migration stable | 07:08 |
| vishy | comstud: yes | 07:08 |
| comstud | ok | 07:08 |
| vishy | we're moving! | 07:08 |
| comstud | there's been *no* email to the openstack list | 07:08 |
| comstud | unless i missed one? | 07:08 |
| vishy | i just sent one! | 07:08 |
| comstud | ah | 07:08 |
| comstud | well thank you | 07:08 |
| comstud | :) | 07:08 |
| comstud | not in my inbox yet | 07:08 |
| comstud | there's a merge prop approved | 07:09 |
| comstud | that if it hits trunk will conflict with one of mine | 07:09 |
| comstud | so I want it to hit trunk :-/ | 07:09 |
| comstud | ok, got your email | 07:09 |
| comstud | what does this mean for outstanding merge props? | 07:10 |
| vishy | they will have to be moved | 07:10 |
| rmk | vishy: Tests didn't apply cleanly but the part I needed did. | 07:10 |
| comstud | k, PITA | 07:10 |
| Daviey | rmk / vishy: I am seeing, http://pb.daviey.com/FwCi/ | 07:11 |
| Daviey | hmm, there is another error i see.. one moment | 07:12 |
| rmk | hmm that's odd | 07:12 |
| rmk | all rabbit chatter issues | 07:12 |
| rmk | suppose that's why you asked about carrot vs kombu | 07:12 |
| Daviey | yup :) | 07:13 |
| rmk | here goes my test with the patch | 07:13 |
| rmk | that fixed it | 07:15 |
| Daviey | rmk: Something like, $ sudo nova-manage vm block_migration --ec2_id=i-28 --dest=sapodilla ? | 07:15 |
| rmk | yeap | 07:15 |
| Daviey | BTW, that log is the dest. | 07:16 |
| rmk | yeah that's where you'd expect the action | 07:17 |
| rmk | seems like your scheduler and compute nodes are disagreeing about where queues are | 07:17 |
| Daviey | rmk: 2011-09-23 03:15:56,163 DEBUG nova.virt.libvirt.firewall [-] The nwfilter(nova-instance-instance-00000028-secgroup) for instance-00000028 is not found. from (pid=1138) unfilter_instance /usr/lib/python2.7/dist-packages/nova/virt/libvirt/firewall.py:320 | 07:18 |
| rmk | inconsistent host naming would be my guess | 07:18 |
| Daviey | but via virsh i can grab that nwfilter :? | 07:18 |
| rmk | I think that's ok -- checking my logs | 07:18 |
| rmk | nope I dont have that error | 07:20 |
| rmk | ah wait | 07:20 |
| rmk | yes that's fine I see it too, even on successes | 07:20 |
| Daviey | gah | 07:20 |
| rmk | vishy: Any way this patch can get into an official diablo package? | 07:21 |
| Daviey | rmk: nothing changed, started fresh instance and migrated - http://pb.daviey.com/HnYc/ | 07:22 |
| Daviey | rmk: Diablo is released now.. which means it is up to distros to carry it, if suitable. | 07:22 |
| rmk | interesting | 07:23 |
| Daviey | rmk: where is your patch? | 07:23 |
| rmk | Daviey: see if you can actually use the instance | 07:23 |
| Daviey | rmk: no, the migration still failed. | 07:23 |
| rmk | not my patch but here's the one vishy pointed me at ... | 07:24 |
| rmk | https://code.launchpad.net/~nttdata/nova/850602/+merge/75480/+preview-diff/+files/preview.diff | 07:24 |
| winston-d | vish: hi, i am wondering how OSAPI determine which project to use, when one user belongs to multiple projects. | 07:24 |
| winston-d | vishy : hi, i am wondering how OSAPI determine which project to use, when one user belongs to multiple projects. | 07:25 |
| Daviey | rmk: there is a good chance Ubuntu will carry that fwiw. | 07:25 |
| Daviey | rmk: did you change your flags at all? | 07:26 |
| rmk | No flag changes | 07:27 |
| rmk | Daviey: Which version of Ubuntu are you on? | 07:27 |
| Daviey | rmk: Oneiric with milestone packages | 07:27 |
| rmk | I'm using natty with release packages | 07:27 |
| rmk | I thought I read something about live migrations issues with oneiric | 07:28 |
| Daviey | rmk: wait, what packages? | 07:28 |
| rmk | 2011.3-0ubuntu2~ppa1~natty1 | 07:28 |
| Daviey | ok | 07:29 |
| rmk | I didn't do anything special for the live migration part, just followed the docs regarding libvirt config changes | 07:31 |
| rmk | what a great feature | 07:33 |
| Daviey | rmk: Yah! It just worked.. i think it was because i did add flags :) | 07:37 |
| rmk | ahh good deal | 07:37 |
| rmk | now check if your VMs have corrupted disks, mine did before that patch | 07:37 |
| comstud | *sigh* | 07:40 |
| *** AhmedSoliman has joined #openstack-dev | 07:40 | |
| Daviey | rmk: think it is ok | 07:40 |
| comstud | nova's rfc.sh seems to be broken | 07:41 |
| Daviey | rmk: ah no, there is corruption | 07:41 |
| Daviey | rmk: it's not finding the kernel | 07:42 |
| rmk | the whole disk is borked actually :) | 07:42 |
| rmk | I was on the system and couldn't even ls after migrating | 07:42 |
| Daviey | rmk: so, following reboot - grub certainly still works.. that is as far as i am atm | 07:42 |
| soren | Oh, noes! Checking stuff out with bzr is soo slow. http://paste.openstack.org/show/2538/ Oh, wait. *grumble* | 07:45 |
| Daviey | rmk: i suspect it's a qcow issue.. that the backing file resolves. | 07:47 |
| Daviey | soren: add --go-faster-stripes | 07:47 |
| soren | To git? | 07:47 |
| soren | Sorry. My joke detector isn't on yet. | 07:48 |
| Daviey | sure, why not | 07:48 |
| comstud | haha | 07:48 |
| comstud | well | 07:48 |
| comstud | this rfc.sh is broken | 07:48 |
| comstud | it doesn't detect project correctly | 07:48 |
| comstud | so it seems i hack it.. or I set the 'gerrit' remote up manually. | 07:49 |
| comstud | after reading the workflow, i'm already annoyed. | 07:49 |
| comstud | soren: your test is 46s for git and 61s for bzr for me | 07:51 |
| soren | comstud: I'm trying it from a cloud server now to compare. | 07:52 |
| comstud | not that I really care | 07:52 |
| comstud | I mean | 07:52 |
| soren | comstud: I'm sure there's some sort of locality bias. | 07:52 |
| comstud | soren: Yeah | 07:52 |
| *** yeming has quit IRC | 07:52 | |
| *** nati_ has joined #openstack-dev | 07:52 | |
| comstud | I'm not saying it to argue for git or anything, because that's certainly not my intent | 07:53 |
| comstud | I'm just giving a comparison | 07:53 |
| comstud | :) | 07:53 |
| soren | I just checked out nova for the first time, was rather surprised how long it took and then I did the same with bzr just to compare... and then I just wanted to sprinkle a bit of actual data on top of the "bzr is unusably slow. git is faster than the road runner. You don't believe me? Serious, man, try checking out *anything* with bzr. Add launchapd to mix and it's basically at a stand still" nonsense. | 07:53 |
| comstud | I tend to think LP is a bit slow in some cases, but mostly it's a non-issue | 07:54 |
| comstud | for me | 07:55 |
| *** nati has quit IRC | 07:55 | |
| Daviey | soren: not to mention that Launchpad were looking to add regional end points for the slowness in Japan. | 07:55 |
| comstud | for bzr, branching seems slower than it should be, also.. but it really doesn't bother me much | 07:55 |
| Daviey | Mainly due to concerns openstack raised. | 07:56 |
| Daviey | I hope github bend over to help when needed. | 07:56 |
| soren | comstud: Yeah. I did it *once* for Nova. Ever. How much of a issue can it really be, then? (even if it were actually slower) | 07:56 |
| vishy | comstud: where does origin point on your git repo | 07:57 |
| Daviey | soren: The main problem was that people didn't use shared-branches. | 07:57 |
| soren | Ok, git from a cloud server (i.e. same datacenter!): 18 seconds. bzr: 88 seconds. | 07:57 |
| comstud | vishy: the full URL that ends in 'nova.git' | 07:57 |
| *** AhmedSoliman has quit IRC | 07:57 | |
| comstud | so it tries to use 'nova.git' as the project | 07:57 |
| * Daviey tries branching from the same dc as bzr :) | 07:58 | |
| comstud | it's not stripping .git off | 07:58 |
| vishy | comstud: did you clone following the instructions? | 07:58 |
| comstud | yep | 07:58 |
| vishy | weird | 07:58 |
| *** rbasak has joined #openstack-dev | 07:58 | |
| comstud | this seems like an obvious problem | 07:58 |
| comstud | what is your origin? | 07:58 |
| vishy | rmk: we haven't discussed point releases on diablo | 07:59 |
| comstud | the doc says to clone openstack/nova.git | 07:59 |
| comstud | so the origin is openstack/nova.git | 07:59 |
| vishy | comstud: one sec | 07:59 |
| comstud | then it tries to match 'nova.git' against the list of projects @ review.openstack.org | 08:00 |
| comstud | which fails, of course | 08:00 |
| rmk | https://bugs.launchpad.net/nova/+bug/794627 -- I don't think this is actually working | 08:00 |
| uvirtbot | Launchpad bug 794627 in nova "Handle RabbitMQ crash and attempt to reestablish connections and queues" [High,Fix released] | 08:00 |
| comstud | i modified rfc.sh to strip off the '.git' from the 'show origin' that it does.. and then ran 'git review'... | 08:03 |
| comstud | which worked | 08:03 |
| vishy | interesting | 08:04 |
| comstud | now it thinks my master branch is 2 commits ahead of origin/master | 08:04 |
| comstud | dunno why | 08:04 |
| vishy | comstud: trying to replicate | 08:04 |
| vishy | github is slow from europe :( | 08:05 |
| comstud | vishy: i'm guessing the script used to look at $PROJECT... because otherwise there's not much reason to set it... although the docs say to do so | 08:05 |
| comstud | but i bet it was updated to try to get it from 'show origin' | 08:05 |
| comstud | and updated wrongly | 08:05 |
| comstud | just a theory. | 08:05 |
| vishy | my keystone origin is right: originhttps://github.com/openstack/keystone | 08:06 |
| comstud | hrm | 08:06 |
| vishy | maybe it was switched recently to use git remote instead of https... | 08:06 |
| comstud | well | 08:07 |
| comstud | it appears the doc needs updated | 08:07 |
| comstud | git clone git://github.com/openstack/$PROJECT.git | 08:07 |
| comstud | needs the '.git' removed maybe | 08:07 |
| vishy | yeah I think that would work | 08:08 |
| comstud | it works without it for me | 08:08 |
| comstud | i just cloned openstack/nova | 08:08 |
| vishy | good thing it is a wiki | 08:08 |
| comstud | hrm | 08:08 |
| vishy | updated | 08:08 |
| comstud | thanks | 08:09 |
| vishy | doesn't look like there is a guide for moving branches either | 08:09 |
| vishy | i guess you could just do a cp | 08:10 |
| comstud | yeah, i was looking for that also | 08:10 |
| comstud | what we do about current merge props, etc | 08:10 |
| vishy | if we don't care about history, i think a cp -r will work :) | 08:11 |
| vishy | just testing | 08:11 |
| comstud | yeah, i don't like losing history | 08:11 |
| comstud | but it may be the only choice | 08:11 |
| comstud | i was going to do this: | 08:11 |
| Daviey | err | 08:11 |
| comstud | diff -cr --exclude .bzr trunk mybranch > diff | 08:11 |
| Daviey | bzr mv ? | 08:12 |
| comstud | then cd into my git branch | 08:12 |
| vishy | comstud: no it isn't the only choice | 08:12 |
| comstud | and patch -p1 < diff | 08:12 |
| vishy | cmstud: you can use git-bzr-ng | 08:12 |
| comstud | ok | 08:12 |
| vishy | wow what happened to trunk? | 08:13 |
| comstud | ? | 08:14 |
| vishy | lp:nova is not based off of old lp:noa | 08:14 |
| comstud | are you trying to branch lp:nova by chance? | 08:14 |
| comstud | yes | 08:14 |
| vishy | well that makes it even harder | 08:14 |
| comstud | we saw this earlier | 08:14 |
| vishy | sigh | 08:14 |
| comstud | but | 08:15 |
| vishy | ok i guess we are losing history for outstanding branches | 08:15 |
| comstud | i always branch lp:nova/trunk | 08:15 |
| vishy | oh, they are different? | 08:15 |
| comstud | yeah | 08:15 |
| comstud | which I don't quite understand, but | 08:15 |
| comstud | lp:nova/trunk has everything like it should | 08:15 |
| comstud | lp:nova seems to have stopped at end of Aug | 08:15 |
| *** jeffjapan has quit IRC | 08:15 | |
| vishy | weird | 08:16 |
| comstud | actually | 08:16 |
| comstud | lp:nova synced up | 08:16 |
| comstud | it's missing at least 1 commit from trunk tho | 08:16 |
| comstud | i guess i should say.. it's synced up more than it was earlier today | 08:16 |
| comstud | earlier today it stopped at end of aug | 08:17 |
| comstud | ugh | 08:17 |
| comstud | this is fucked up | 08:17 |
| vishy | if lp:nova is a git mirror we are in trouble | 08:17 |
| comstud | trunk has a 1617 from johannes.. the last thing that made it | 08:18 |
| comstud | lp:nova has a 1617 which is the addition of rfc.sh | 08:18 |
| comstud | i think lp:nova is a git mirror. | 08:18 |
| comstud | lp:nova is missing 1 merge from trunk | 08:18 |
| comstud | yeah | 08:19 |
| comstud | a merge from johannes is missing from github | 08:19 |
| vishy | comstud: it is worse than that | 08:20 |
| vishy | the branches are heavily diverged | 08:20 |
| vishy | merging lp:nova 'splodes badly | 08:20 |
| comstud | yeah, ok | 08:20 |
| vishy | i'm trying to do a rebase with git bzr, we'll see how it goes | 08:20 |
| comstud | that matches what tr3buchet saw earlier | 08:20 |
| comstud | although it was at a time when lp:nova was many many commits behind | 08:20 |
| Daviey | Oh, lp:nova is now a git mirror... good times end. | 08:21 |
| comstud | for me, pretty much | 08:22 |
| ttx | vishy: looks like we should put out an ML post saying the branches are busted -- at least until mtaylor and jeblair have a look into it | 08:23 |
| comstud | i'll deal. i'm still really disappointed in the lack of communication on the openstack mailing list, though. | 08:23 |
| vishy | ttx: good point | 08:23 |
| comstud | not everyone is able to make the meetings every time | 08:23 |
| vishy | comstud: my bad. I should have sent out an announcement earlier | 08:23 |
| vishy | about the planned move date | 08:23 |
| comstud | and I already bitched about the lack of communication about gerrit in general a couple weeks ago | 08:23 |
| Daviey | The issue is a missing commit on lp:nova compared to git? | 08:23 |
| comstud | and now nova moves without any notice there | 08:24 |
| vishy | Daviey: no | 08:24 |
| comstud | :-/ | 08:24 |
| vishy | Daviey: the issue is that lp:nova from git is completely diverged from bzr history | 08:24 |
| Daviey | ah | 08:24 |
| vishy | * well the mirror is diverged, I haven't verified if the git repo is diverged | 08:24 |
| Daviey | vishy: did the other core projects encounter this? | 08:25 |
| vishy | ttx: should I make an announcement? or do you want to do it? | 08:25 |
| comstud | vishy: do a couple shots with me in 10 days and i'll forget about it for a short while. | 08:25 |
| vishy | comstud: deal! | 08:25 |
| comstud | :) | 08:25 |
| Daviey | vishy is buying everyone drinks? | 08:26 |
| ttx | vishy: please do | 08:28 |
| * ttx is under heavy drugs to feel happiness all around him | 08:28 | |
| ttx | and survive sleep deprivation | 08:29 |
| Daviey | vishy / ttx: Might also be worth commenting how people can still get there bzr based branches and merge proposals to the new world order? | 08:30 |
| Daviey | their* | 08:30 |
| vishy | comstud: fwiw git bzr ng works, unfortunately review doesn't because it can't rebase properly | 08:30 |
| comstud | vishy: Ok. I haven't used git-bzr | 08:32 |
| comstud | I'm a lot more comfortable with bzr... but I'm also familiar with what I'd call the normal github workflow | 08:33 |
| comstud | So either way... this is a pain for me. | 08:33 |
| comstud | But I'll figure it out and live. | 08:33 |
| Daviey | git-bzr is for using git against bzr, right? How does that help? | 08:34 |
| comstud | I don't think it helps me | 08:34 |
| comstud | :) | 08:34 |
| vishy | git-bzr-ng lets you import bzr branches into git | 08:39 |
| zykes- | is dev still going on bzr with nova vishy ? | 08:41 |
| vishy | zykes-: nope | 08:44 |
| comstud | well | 08:50 |
| comstud | i'll say that it is | 08:50 |
| comstud | because people don't know not to use it anymore. | 08:51 |
| comstud | :) | 08:51 |
| comstud | ok, ~2am ... beds time | 08:53 |
| Daviey | vishy: bzr based merge proposals are dropped, unless the requestor moves them to git? | 09:02 |
| vishy | yeah | 09:07 |
| *** darraghb has joined #openstack-dev | 09:12 | |
| zykes- | why does endpointTemplates now use id instead of name ? | 09:14 |
| vishy | sigh, looks like squashing is the only option | 09:21 |
| vishy | that sucks | 09:21 |
| markmc | vishy, this is for moving a merge prop to git ? | 09:22 |
| markmc | vishy, how about git-bzr import | 09:23 |
| markmc | vishy, then git rebase --onto origin/master ... | 09:23 |
| * markmc experimenting now | 09:23 | |
| soren | Why do you care about lp:nova anymore? | 09:23 |
| *** darraghb has quit IRC | 09:24 | |
| *** darraghb has joined #openstack-dev | 09:24 | |
| markmc | soren, anyone who has a pending merge prop needs to import it to git and rebase it onto master | 09:24 |
| soren | markmc: How does that pertain to lp:nova ? | 09:25 |
| markmc | soren, perhaps vishy tried to merge lp:nova into a merge prop before rebasing | 09:26 |
| * markmc guesses | 09:26 | |
| vishy | markmc: yeah that would be great | 09:29 |
| vishy | if the branches weren't diverged | 09:29 |
| soren | Can someone explain what the problem is? | 09:29 |
| vishy | rebasing is painful | 09:29 |
| soren | Or rather: What are we trying to achieve? | 09:29 |
| vishy | soren: I'm trying to import a branch from bzr | 09:29 |
| soren | "import"? | 09:30 |
| vishy | without losing all of the history | 09:30 |
| vishy | into git | 09:30 |
| soren | Why? | 09:30 |
| vishy | so that i can propose it | 09:30 |
| soren | With git, we don't want the history anymore. | 09:30 |
| soren | All the workflow docs tell you to rebase. | 09:30 |
| soren | I.e. discard history. | 09:30 |
| vishy | i don't mind rebasing | 09:30 |
| vishy | that doesn't squash all existing commits though | 09:30 |
| soren | Well, if you don't, why rebase? | 09:31 |
| vishy | sigh, whatever I guess all the other people that helped with this branch won't get any credit | 09:31 |
| soren | Ok, so you want to take the commits you have in bzr and get them into git. | 09:31 |
| soren | Right? | 09:31 |
| vishy | no i have no problem doing that | 09:31 |
| soren | Ok. | 09:32 |
| vishy | unfortunately it seems that the git branch is not really based off of the bzr branch | 09:32 |
| soren | What's it based off of then? | 09:32 |
| vishy | well that is the question | 09:32 |
| vishy | perhaps my rebase is just too complex for it to handle | 09:32 |
| soren | Ok, sorry, enver mind that for alittle bit. | 09:32 |
| soren | Why does it matter if it's based off of one or the other if you're rebasing anyway? | 09:32 |
| soren | The history doesn't need to lign up. | 09:33 |
| markmc | soren, it does if you're rebasing merge commits | 09:33 |
| markmc | vishy, it looks to me like 'git bzr import' of a merge prop doesn't have divergent history from the github repo | 09:33 |
| Daviey | You must be kidding me... http://pb.daviey.com/xSB6/ | 09:34 |
| markmc | vishy, e.g. if you do 'git merge-base my-merge-prop origin/master' you'll get the commit where the merge prop forked from master | 09:35 |
| Daviey | case sensitive... for EMAIL address? | 09:35 |
| markmc | vishy, so a 'git merge origin/master' works just fine | 09:35 |
| soren | As far as I can see the only problem is that a single patch managed to land on the old trunk before tarmac was shut off, but after the migration was done. | 09:36 |
| soren | Right? | 09:37 |
| vishy | soren: could be | 09:37 |
| soren | It's not like they're completely different. | 09:37 |
| *** Tribaal has joined #openstack-dev | 09:38 | |
| soren | Pardon me for sounding like a broken record... But what's so important about what lp:nova points to? | 09:38 |
| soren | Let's pretend it pointed somewhere else... What would you do? | 09:38 |
| soren | I.e. if it pointed just where you wanted it to point. | 09:39 |
| vishy | markmc: I can merge the branch, I just can't propose it | 09:39 |
| markmc | soren, ah | 09:39 |
| vishy | markmc: because it tries to rebase it | 09:39 |
| * markmc tries that | 09:39 | |
| soren | vishy: No, Gerrit refuses merge commits, afaik. | 09:39 |
| soren | Or does it just frown upon them? | 09:39 |
| vishy | soren: well i think i can use merge commits | 09:41 |
| vishy | if i ammend all of the commits to have a change id | 09:41 |
| vishy | but i'm not sure | 09:41 |
| * soren has no idea. | 09:41 | |
| soren | I'm pretty good with bzr and launchpad, though, so if you can explain what it is that you want them to do, I'd be happy to help. I just tsill haven't entirely worked that out. | 09:42 |
| soren | Maybe if you can start by explaining why it's a problem that lp:nova points to a git mirror now? | 09:42 |
| soren | a) The original trunk is still on Launchpad and b) if it weren't, *every* one of us has a copy of it. It's a dvcs, after all. | 09:43 |
| vishy | soren: my issue is more with gerrit and git | 09:47 |
| Tribaal | sorry to jump in, but: does this imply that there is an effort going on to move nova's "main" to git/github? | 09:48 |
| markmc | vishy, think you mentioned the "not a known project" issue earlier | 09:49 |
| soren | Tribaal: The *was*. It's done. | 09:49 |
| markmc | vishy, we need e.g. | 09:49 |
| vishy | soren: although i think it is odd | 09:49 |
| markmc | - if echo $project_list | grep $project >/dev/null | 09:49 |
| markmc | + if echo $project_list | grep ${project%.git} >/dev/null | 09:49 |
| Tribaal | soren: ohhhh shiny :) | 09:49 |
| vishy | that if i do (in bzr) bzr merge lp:nova with an old branch | 09:49 |
| vishy | it blows up badly | 09:49 |
| openstackgerrit | Dave Walker proposed a change to openstack/nova: contrib/nova.sh: Updated to latest 'upstream' commit:6a8433a resolves bug 857209 https://review.openstack.org/550 | 09:49 |
| uvirtbot | Launchpad bug 857209 in nova "contrib/nova.sh is broken, due to syntax changes" [Undecided,New] https://launchpad.net/bugs/857209 | 09:49 |
| soren | vishy: So don't? Merge with the old trunk. | 09:49 |
| * Daviey raises a merge of vishy's 'upstream' work :) | 09:50 | |
| soren | vishy: bzr merge lp:~openstack-hudson/nova/trunk | 09:50 |
| *** sanjay400 has quit IRC | 09:50 | |
| vishy | soren: ok so the answer is don't do that | 09:50 |
| vishy | soren: i did that, hoping that it would make my rebase function | 09:50 |
| vishy | it doesn't | 09:50 |
| soren | vishy: Well, sure. You're trying to merge something that's an entirely different repository. Probably with no common ancestry. | 09:51 |
| *** AhmedSoliman has joined #openstack-dev | 09:52 | |
| openstackgerrit | Carlos Marin proposed a change to openstack/keystone: Modified apiKeyCredentials to extend single entity and use restriction https://review.openstack.org/551 | 09:52 |
| Tribaal | soren, would you mind giving me the "main" git repository's url? Should I take the time to update the wiki while I'm at it? | 09:53 |
| soren | Tribaal: http://github.com/openstack/nova.git should be the main one, IIUC. | 09:53 |
| soren | Tribaal: Sure, if the wiki is wrong, fix it. | 09:53 |
| Tribaal | soren alright, excellent! Just FYI - the repository's title on github states it's a mirror, it would probably help if it said "this is the main repository" or something | 09:56 |
| Tribaal | (that's why I asked in the first place) | 09:56 |
| Tribaal | so are github pull requests an accepted way to send code / features? | 09:57 |
| Tribaal | sorry for all theses questions :) | 09:57 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Pull volume-cleanup-2 from bzr https://review.openstack.org/552 | 09:58 |
| soren | No, we use Gerrit. | 09:58 |
| vishy | well i got a review in | 09:58 |
| vishy | that was painful | 09:58 |
| soren | See http://wiki.openstack.org/GerritWorkflow | 09:58 |
| * soren tries, too | 09:59 | |
| Tribaal | soren: thanks, that link is golden | 10:00 |
| vishy | and that was a failure | 10:00 |
| vishy | so not trying that again | 10:00 |
| *** sanjay400 has joined #openstack-dev | 10:04 | |
| Daviey | vishy: What was it you were trying to do, i couldn't follow. | 10:10 |
| Daviey | vishy: you used git-bzr previously, and you wanted to push that to change where you were pushing, usng straight git? | 10:11 |
| *** AhmedSoliman has quit IRC | 10:12 | |
| vishy | Daviey: no it is very simple | 10:14 |
| vishy | Daviey: i'm trying to pull an old branch from bzr into git and propose it | 10:14 |
| Daviey | ah | 10:14 |
| vishy | it is surprisingly difficult for this old nasty branch | 10:14 |
| Daviey | vishy: Well git workflow seems to not care about having multiple commits, ie, folding into one patch.. that being the case, i'd bzr diff -r-1..$WHERE_YOU STARTED > patch :) | 10:16 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Pull volume-cleanup-2 from bzr https://review.openstack.org/552 | 10:18 |
| vishy | well there we go i managed to get all of the changes in | 10:18 |
| vishy | that was ugly though | 10:18 |
| vishy | Daviey: yeah that was probably the easier version | 10:18 |
| Daviey | vishy: although, Ben McGraw has lost his name in the commit history. | 10:19 |
| Daviey | oh no | 10:19 |
| Daviey | scrub that | 10:19 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Pull volume-cleanup-2 from bzr https://review.openstack.org/552 | 10:19 |
| vishy | there were commits from 3 different people in there | 10:19 |
| vishy | I don't know how to keep them | 10:20 |
| Daviey | screw it. :(.. short term pain. | 10:20 |
| markmc | vishy, okay, how does this look for instructions? http://pastebin.com/d7MVdQYw | 10:21 |
| vishy | markmc: looks ok, might want to have an alternate version | 10:22 |
| soren | ?!?!?!? | 10:22 |
| soren | Why did we remove BaseImageService? | 10:22 |
| markmc | vishy, an alternate version that just squashes into a single commit ? | 10:23 |
| vishy | i.e: bzr diff lp:nova/trunk > patchfile | 10:23 |
| vishy | cat patchfile | patch -p0 | 10:23 |
| soren | bzr diff --old lp:nova/trunk | 10:23 |
| vishy | err | 10:23 |
| vishy | yeah forgot the --old | 10:23 |
| vishy | :) | 10:23 |
| soren | Or: Go to your trunk checkout and do: bzr merge --preview ../the-other-branch | 10:23 |
| Daviey | ls | 10:25 |
| vishy | markmc: can you put that on the wiki, then we can send out an email on how to get your old branch in | 10:26 |
| markmc | vishy, will do | 10:27 |
| *** wwkeyboard has joined #openstack-dev | 10:30 | |
| markmc | vishy, http://wiki.openstack.org/MigrateMergePropFromLaunchpadToGerrit | 10:34 |
| markmc | vishy, added alternate version too | 10:41 |
| *** rods has joined #openstack-dev | 10:49 | |
| markmc | you can't submit other people's patches to gerrit? | 10:52 |
| markmc | remote: ERROR: In commit b7430a2d0fbf3cbcf2f22c61a6a30d5c1e92703e | 10:52 |
| markmc | remote: ERROR: author email address zulcss@ubuntu.com | 10:52 |
| markmc | remote: ERROR: does not match your user account. | 10:52 |
| Daviey | mtaylor: is it possible to fix, http://pb.daviey.com/xSB6/ ? | 10:57 |
| markmc | Daviey, you can add multiple accounts in your gerrit settings | 10:57 |
| markmc | Daviey, https://review.openstack.org/#settings,contact | 10:57 |
| * markmc is reluctant to add zul's address to his account though :) | 10:58 | |
| zykes- | in the initial keystone auth, is it only global endpoints that are retrieved then ? | 10:59 |
| Daviey | markmc: so i need to add a uppercase version of the email address it already knows about? :) | 11:00 |
| Daviey | or CamelCase i suppose. | 11:00 |
| markmc | Daviey, looks like it | 11:00 |
| *** bsza has joined #openstack-dev | 11:02 | |
| *** Jaesang has quit IRC | 11:05 | |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Allow the user to choose either ietadm or tgtadm https://review.openstack.org/553 | 11:05 |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Remove VolumeDriver.sync_exec method https://review.openstack.org/554 | 11:05 |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Refactor ietadm/tgtadm calls out into helper classes https://review.openstack.org/555 | 11:05 |
| markmc | well now, that was an ordeal | 11:06 |
| *** HugoKuo__ has quit IRC | 11:15 | |
| *** AhmedSoliman has joined #openstack-dev | 11:15 | |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Fix rfc.sh's check for the project https://review.openstack.org/556 | 11:21 |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Add INPUT chain rule for EC2 metadata requests https://review.openstack.org/557 | 11:24 |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Have nova-api add the INPUT rule for EC2 metadata https://review.openstack.org/558 | 11:24 |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Have nova-api add the INPUT rule for EC2 metadata https://review.openstack.org/558 | 11:32 |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Add INPUT chain rule for EC2 metadata requests https://review.openstack.org/557 | 11:32 |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Remove VolumeDriver.sync_exec method https://review.openstack.org/554 | 11:34 |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Refactor ietadm/tgtadm calls out into helper classes https://review.openstack.org/555 | 11:34 |
| *** wwkeyboard has quit IRC | 11:45 | |
| *** bsza3 has joined #openstack-dev | 12:04 | |
| *** bsza3 has quit IRC | 12:06 | |
| *** bsza has quit IRC | 12:06 | |
| *** bsza has joined #openstack-dev | 12:08 | |
| *** mfer has joined #openstack-dev | 12:09 | |
| *** mdomsch has quit IRC | 12:24 | |
| zykes- | any keystone folks here ? | 12:24 |
| zykes- | http://paste.openstack.org/show/2539/ error when using unscoped token towards a tenant that doesn't exist. | 12:26 |
| *** ameade has joined #openstack-dev | 12:27 | |
| *** neogenix has quit IRC | 12:30 | |
| *** chomping has joined #openstack-dev | 12:31 | |
| *** lts has joined #openstack-dev | 12:34 | |
| *** zns has joined #openstack-dev | 12:37 | |
| *** zns has quit IRC | 12:51 | |
| *** wwkeyboard has joined #openstack-dev | 12:56 | |
| *** naehring has quit IRC | 12:59 | |
| Daviey | ttx: Is diablo packaging that openstack cares about now static? | 13:02 |
| Daviey | as in the PPA? | 13:02 |
| ameade | I am following http://wiki.openstack.org/MigrateMergePropFromLaunchpadToGerrit | 13:08 |
| ameade | and getting a problem when i git review | 13:08 |
| ameade | The current project name, openstack/nova.git, is not a known project. | 13:08 |
| ameade | Please either reclone from github/gerrit or create a | 13:08 |
| ameade | remote named gerrit that points to the intended project. | 13:08 |
| ameade | Can't infer where gerrit is - please set a remote named | 13:08 |
| ameade | gerrit manually and then try again. | 13:08 |
| *** chomping has quit IRC | 13:10 | |
| markmc | ameade, just do: | 13:11 |
| markmc | - if echo $project_list | grep $project >/dev/null | 13:11 |
| markmc | + true | 13:11 |
| markmc | ameade, in tools/rfc.sh | 13:11 |
| markmc | ameade, then run tools/rfc.sh and revert the hack | 13:11 |
| markmc | ameade, see https://review.openstack.org/#change,556 | 13:11 |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Allow the user to choose either ietadm or tgtadm https://review.openstack.org/553 | 13:15 |
| openstackgerrit | Alex Meade proposed a change to openstack/nova: Add minDisk and minRam to OSAPI image details https://review.openstack.org/559 | 13:15 |
| ameade | ! thanks | 13:15 |
| openstack | ameade: Error: "thanks" is not a valid command. | 13:15 |
| markmc | ameade, w00t! :) | 13:15 |
| *** bcwaldon has joined #openstack-dev | 13:16 | |
| ameade | markmc: i liked the step by step docs | 13:16 |
| markmc | ameade, thanks | 13:16 |
| *** joesavak has joined #openstack-dev | 13:18 | |
| *** AhmedSoliman has quit IRC | 13:18 | |
| *** joesavak has quit IRC | 13:18 | |
| *** med_out is now known as medberry | 13:20 | |
| *** AhmedSoliman has joined #openstack-dev | 13:22 | |
| *** zns has joined #openstack-dev | 13:26 | |
| *** sanjay400 has quit IRC | 13:33 | |
| *** zns has quit IRC | 13:35 | |
| *** bcwaldon has quit IRC | 13:43 | |
| *** bcwaldon has joined #openstack-dev | 13:43 | |
| vishy | markmc: so we can't prop for other users? | 13:50 |
| vishy | markmc: that seems like it needs to be fixed. What about collaborative branches? | 13:50 |
| *** bcwaldon has quit IRC | 13:50 | |
| markmc | vishy, totally | 13:50 |
| markmc | vishy, I couldn't find any docs confirming it or anything but ... | 13:51 |
| *** bcwaldon has joined #openstack-dev | 13:51 | |
| vishy | markmc: i had the same issue | 13:51 |
| markmc | ah | 13:51 |
| vishy | markmc: we should check with the ci team | 13:51 |
| vishy | though | 13:51 |
| vishy | I managed to prop with a different author though | 13:51 |
| vishy | so maybe you just have to change yourself to committer and keep the original author | 13:52 |
| markmc | almost certain I was the committer | 13:52 |
| markmc | committer changes when you rebase | 13:52 |
| markmc | AFAIR | 13:52 |
| vishy | markmc: hmm, maybe i was mistaken | 13:53 |
| *** Binbin has joined #openstack-dev | 13:53 | |
| vishy | markmc: btw, the sync_exec was from back when the code was using twisted!!! | 13:54 |
| markmc | vishy, yeah, saw that in the logs | 13:54 |
| markmc | vishy, looks like we never really wanted to run these commands async though? | 13:54 |
| vishy | markmc: we needed a sync exec method because init_host was called before the reactor started | 13:54 |
| markmc | ah | 13:55 |
| vishy | markmc: so we had to have a version of exec that didn't do callbacks | 13:55 |
| vishy | markmc: with eventlet, the callbacks are all magic so the same method works always | 13:55 |
| markmc | cool | 13:55 |
| *** troytoman-away is now known as troytoman | 13:56 | |
| *** kbringard has joined #openstack-dev | 13:57 | |
| ttx | Daviey: You mean, shoud we refresh the packages in the Release PPA ? | 13:58 |
| Daviey | ttx: yes | 13:58 |
| ttx | Daviey: if they are badly broken, I'd say yes | 13:58 |
| *** martine_ has joined #openstack-dev | 13:58 | |
| ttx | Daviey: if tey are just "different" no | 13:58 |
| ttx | Daviey: in particular I don't see the point of updating the Oneiric one | 13:59 |
| Daviey | ttx: yeah | 13:59 |
| ttx | since you guys will ship the "Ubuntu" one | 13:59 |
| Daviey | That was my thought. | 13:59 |
| *** cmagina has joined #openstack-dev | 13:59 | |
| zul | hmm? | 14:01 |
| bcwaldon | vishy: yo, we can't get anything into nova trunk due to pep8 errors | 14:01 |
| bcwaldon | vishy: mtaylor has a branch in to fix some of them, but not all, so that can't even go in | 14:02 |
| bcwaldon | vishy: what do you propose we do | 14:02 |
| ttx | bcwaldon: apparently pep8 was disabled the last days of LP/tarmac | 14:02 |
| jk0 | s/days/weeks/ | 14:02 |
| ttx | I did push pep8 fixed in the milestone-proposed branch | 14:02 |
| vishy | yeah way was just looking at it | 14:02 |
| ttx | just so that it passes | 14:02 |
| bcwaldon | https://jenkins.openstack.org/job/nova-pep8/1378/console | 14:02 |
| ttx | but probably more crept in | 14:02 |
| bcwaldon | thats the output of mtaylor's pep8 fixes branch | 14:02 |
| vishy | bcwaldon someone take mtaylors branch and make the rest of the changes and propose? | 14:03 |
| bcwaldon | I can do it, but will I just have to do it in a second review? | 14:03 |
| bcwaldon | I can't push to his review, right? | 14:03 |
| *** reed_ has joined #openstack-dev | 14:06 | |
| jeblair | bcwaldon: i believe you _can_ push to his review | 14:13 |
| bcwaldon | ok, I'll try | 14:13 |
| *** mdomsch has joined #openstack-dev | 14:13 | |
| ttx | adam_g: you sure the glance bug applies to our Glance in PPA as well ? I looked at the debian.tar.gz and couldn't find /dev/nul references in the postinst | 14:14 |
| *** reed_ is now known as reed | 14:16 | |
| jeblair | vishy: the nova-core team can push changes to gerrit not authored by them (in gerrit ACL terminology, they can forge author and committer identity). that seemed like a good compromise between giving the -core team the flexibility to push any patch (maybe even received by email or something), but maintaining some notion of identity for everyone else (since anyone can propose a patch it's good to at least know the email on the patch is r | 14:16 |
| *** nati has joined #openstack-dev | 14:16 | |
| vishy | jeblair: ah so markmc couldn't because he is not in core, gotcha | 14:17 |
| vishy | i wonder if i should try and actually rebase my patch and keep original authors then | 14:17 |
| jeblair | vishy: sorry i didn't document that. i'll add something to the gerritworkflow wiki page. | 14:17 |
| vishy | cool thx | 14:18 |
| *** clayg_ has joined #openstack-dev | 14:18 | |
| *** troytoman is now known as troytoman-away | 14:18 | |
| *** clayg has quit IRC | 14:19 | |
| *** clayg_ is now known as clayg | 14:19 | |
| *** clayg_ has joined #openstack-dev | 14:20 | |
| *** nati_ has quit IRC | 14:20 | |
| vishy | jeblair: did you see the issue in rfc.sh where it uses .git from origin and fails? | 14:20 |
| *** zns has joined #openstack-dev | 14:24 | |
| bcwaldon | jeblair: anything special I need to do to push to a branch not owned by me? | 14:25 |
| bcwaldon | jeblair: I checked it out locally and made the changes | 14:25 |
| bcwaldon | jeblair: now can I just commit --amend and review again? | 14:25 |
| jeblair | vishy: yes. I think Mark's change looks good. Would you like to bypass code review on that to get it around the pep8 problem? | 14:26 |
| bcwaldon | jeblair: I've got a branch that fixes all pep8 errors right now | 14:27 |
| jeblair | bcwaldon: or there's that. :) | 14:27 |
| jeblair | bcwaldon: i don't think there's anything special, go for it | 14:27 |
| openstackgerrit | Brian Waldon proposed a change to openstack/nova: Fix outstanding pep8 errors for a clean trunk. https://review.openstack.org/548 | 14:27 |
| vishy | jeblair: lets try brians first | 14:27 |
| bcwaldon | kk, looks like it worked | 14:27 |
| bcwaldon | feel free to send that review in | 14:27 |
| jeblair | cool. i like this way better too. :) | 14:28 |
| *** code_franco has joined #openstack-dev | 14:28 | |
| *** rbasak has quit IRC | 14:29 | |
| *** zns has quit IRC | 14:30 | |
| *** z has joined #openstack-dev | 14:31 | |
| *** AhmedSoliman has quit IRC | 14:31 | |
| bcwaldon | vishy: some old code made it back into trunk | 14:33 |
| bcwaldon | vishy: https://github.com/openstack/nova/tree/37100f5653960b7f898e91663839feed51e14419/nova/api | 14:33 |
| bcwaldon | vishy: there's a 'rackspace' folder again | 14:33 |
| *** rbasak has joined #openstack-dev | 14:33 | |
| openstackgerrit | Brian Waldon proposed a change to openstack/nova: Removing old code that snuck back in https://review.openstack.org/560 | 14:35 |
| *** dwalleck has joined #openstack-dev | 14:40 | |
| *** dwalleck has quit IRC | 14:42 | |
| *** neogenix has joined #openstack-dev | 14:42 | |
| *** AhmedSoliman has joined #openstack-dev | 14:43 | |
| *** nati_ has joined #openstack-dev | 14:45 | |
| *** nati has quit IRC | 14:47 | |
| *** rnorwood has joined #openstack-dev | 14:57 | |
| *** heckj has joined #openstack-dev | 15:02 | |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Don't use GitPython for authors check https://review.openstack.org/561 | 15:02 |
| *** stanchan has quit IRC | 15:02 | |
| *** dolphm has joined #openstack-dev | 15:02 | |
| *** reidrac has quit IRC | 15:04 | |
| *** mdomsch has quit IRC | 15:07 | |
| *** cp16net has joined #openstack-dev | 15:07 | |
| *** heckj has quit IRC | 15:07 | |
| *** heckj has joined #openstack-dev | 15:07 | |
| vishy | jeblair: remote: ERROR: missing Change-Id in commit message | 15:09 |
| vishy | jeblair: after rebasing a whole mess of commits | 15:09 |
| vishy | jeblair: that is the first rebased commit | 15:09 |
| jeblair | vishy: does it make sense to squash the commits into one to make one gerrit change? | 15:10 |
| vishy | jeblair: i don't mind one change, but we lose the original authors for all the commits then | 15:11 |
| vishy | jeblair: it seems harsh :) | 15:11 |
| *** rnirmal has joined #openstack-dev | 15:11 | |
| jeblair | vishy: oh. so just so i understand, you have a bunch of commits all on one branch you want to push, and none of them have change-ids? | 15:11 |
| *** troytoman-away is now known as troytoman | 15:12 | |
| sandywalsh | vishy, HAHAHA | 15:12 |
| sandywalsh | sorry | 15:12 |
| sandywalsh | :D | 15:12 |
| vishy | jeblair: right | 15:12 |
| jeblair | vishy: so 'git commit --amend' will update the commit message of the most recent commit; doing so will trigger the change-id hook and add a change-id. but i don't know if there's a way to do that for older commits in the series | 15:14 |
| jeblair | (any git experts here know the answer to that?) | 15:14 |
| vishy | jeblair i guess i could --amend all the commits | 15:14 |
| bcwaldon | can somebody send this in: https://review.openstack.org/#change,548 | 15:15 |
| bcwaldon | we need it to be able to get anything done today | 15:15 |
| * sandywalsh grabs a beer to watch this | 15:15 | |
| bcwaldon | vishy: thanks, bud | 15:15 |
| * tr3buchet brings some chips | 15:15 | |
| kbringard | oh man, crisps and beer, can i join in? | 15:16 |
| sandywalsh | pull up a chair | 15:16 |
| tr3buchet | vishy: i ran intot he same problem when i first tried out the gerrit stuff | 15:16 |
| jeblair | vishy: failing that, we can turn off the change-id requirement temporarily. the downside to that is that if anyone wants to update one of these changes, they'd need to manually add the Change-Id to their commit messages when uploading a new patchset. | 15:17 |
| tr3buchet | doing an amend to get the change-id worked fine to solve for me | 15:17 |
| tr3buchet | jeblair: isn't change-id the one thing keeping this all together? | 15:17 |
| jeblair | tr3buchet: it's used when you upload a second patchset to a change (to supercede a previous one, like if you're responding to comments in a review) | 15:18 |
| tr3buchet | right, i'm just seeing how terrible it would be if we had second patchsets that were not related to the first in gerrit | 15:19 |
| tr3buchet | that would be a mess | 15:19 |
| jeblair | tr3buchet: yes, which is why i'm in favor of the requirement being there generally, but i think we could turn it off to handle the backlog of changes vishy needs to push. however, if you know how to amend commit messages other than the one on the top of the stack, i like that much better. | 15:20 |
| vishy | jeblair: it seems like the rebase would add change ids to all the branches | 15:20 |
| tr3buchet | and vishy: jeblair: you shouldn't have to worry about the change id on all of them individually if you do a rebase | 15:21 |
| bcwaldon | jaypipes: ping | 15:21 |
| jeblair | tr3buchet: i think vishy has more than one commit on his branch that he he wants to push, and does not want to squash them since they have different authors and are different changes. | 15:21 |
| tr3buchet | hmmm | 15:22 |
| tr3buchet | so what happened when he did the --amend as far as gerrit is concerned? | 15:22 |
| *** mdomsch has joined #openstack-dev | 15:22 | |
| openstackgerrit | A change was merged to openstack/nova: Fix outstanding pep8 errors for a clean trunk. https://review.openstack.org/548 | 15:25 |
| mtaylor | yay! | 15:25 |
| bcwaldon | mtaylor: I cleaned it up for you :) | 15:26 |
| mtaylor | bcwaldon: I saw - and thanks! | 15:26 |
| bcwaldon | you're very welcome | 15:26 |
| jeblair | my understanding of git is that when you amend a commit, you make a new one, so if you ammend commit #2, you make #2b, while #1 still has #2 as it's parent. | 15:27 |
| tr3buchet | you're right jeblair | 15:27 |
| ameade | if you do git commit -a --ammend this it makes a new one | 15:28 |
| jeblair | i think you could do this by amending the oldest commit N getting N', checkout N+1, rebase N+1 on N', then ammend N+1 getting (N+1)' and so on. | 15:28 |
| ameade | does it do that if you dont have the -a? | 15:28 |
| jeblair | yikes. | 15:28 |
| jaypipes | bcwaldon: pong | 15:28 |
| bcwaldon | jaypipes: gonna redo the git-authors branch in glance to remove the GitPython dep. There's a branch in for nova I am just going to copy | 15:28 |
| bcwaldon | jaypipes: you cool with that? | 15:29 |
| bcwaldon | jaypipes: https://review.openstack.org/#change,561 | 15:29 |
| jaypipes | bcwaldon: yuppers. followed Mark's comments on the nova one... | 15:29 |
| jeblair | bcwaldon, jaypipes: i think that's a gerat idea, btw. :) | 15:29 |
| tr3buchet | the -a just commits all changes instead of those that are staged | 15:29 |
| mtaylor | bcwaldon, jaypipes just to be clear - I will kill both of you, although I do think it's a great idea | 15:29 |
| notmyname | vishy: are all of these commits approved and tested? | 15:29 |
| bcwaldon | mtaylor: yeah, I thought you would say that ;) | 15:30 |
| tr3buchet | ah i see what happened with my branch. i squashed everything and only picked 1. that's why the amend was a simple fix | 15:31 |
| tr3buchet | i'm guess you picked several vishy | 15:31 |
| vishy | notmyname: no | 15:31 |
| vishy | notmyname: so I had an outstanding branch contributed by a bunch of people | 15:32 |
| vishy | notmyname: it was collaborative | 15:32 |
| jeblair | vishy: pep8 is clean now; might be a good time to approve the rfc.sh fix before too many devs have a borked version: https://review.openstack.org/#change,556 | 15:32 |
| notmyname | vishy: gotcha | 15:32 |
| dolphm | anyone know who I need to pester to register for the design summit, now that registration is officially closed at http://summit.openstack.org/ ? | 15:32 |
| vishy | notmyname: if I squash them i lose the original author etc. | 15:32 |
| *** vladimir3p has joined #openstack-dev | 15:34 | |
| *** jdag has joined #openstack-dev | 15:34 | |
| jaypipes | man, git cloning nova takes forever... | 15:35 |
| notmyname | vishy: and since the work was done before gerrit, there are not change-ids on any of the individual commits to tie them together | 15:35 |
| jaypipes | jeblair: what did you think was a great idea? the removal of the GitPython dep? | 15:36 |
| jeblair | yes | 15:36 |
| jaypipes | jeblair: ya, agreed :) | 15:36 |
| *** stuntmachine has joined #openstack-dev | 15:37 | |
| jeblair | okay, here's the best thing i've come up with on how to ammend all those commit messages: http://paste.openstack.org/show/2542/ | 15:37 |
| vishy | jeblair: magic: git rebase -i origin/master and change pick to reword | 15:38 |
| jeblair | yay magic! | 15:38 |
| mtaylor | vishy: score! | 15:38 |
| tr3buchet | vishy: then just add the change-id to the commit msg? | 15:38 |
| sandywalsh | tr3buchet, won't work unless you squash first, or it will complain of too many change-id's | 15:39 |
| jeblair | won't that edit all the messages at once? | 15:39 |
| tr3buchet | sandywalsh: even if it's the same change-id on them all? | 15:39 |
| sandywalsh | tr3buchet, the commit msg only shows from the last commit | 15:39 |
| jeblair | no! | 15:39 |
| jeblair | i'm wrong | 15:39 |
| jeblair | it edits them one by one | 15:39 |
| sandywalsh | if it's the same change-id you should be ok ... *should be* | 15:39 |
| mtaylor | yes. that's the magic | 15:39 |
| jeblair | letting the change-id hook run on each | 15:39 |
| jeblair | so it is exactly what vishy needs. | 15:40 |
| tr3buchet | well i guess we're about to find out | 15:40 |
| mtaylor | yeah - it's perfect | 15:40 |
| jeblair | sandywalsh: vishy wants a different change-id for each commit, because he wants each commit to be a change in gerrit. | 15:40 |
| vishy | then a bunch of ZZ in vim | 15:40 |
| sandywalsh | hmm | 15:40 |
| *** AhmedSoliman has quit IRC | 15:41 | |
| notmyname | how does rfc.sh determine the change-id? the branch name? | 15:41 |
| vishy | tr3buchet it adds it automatically | 15:41 |
| tr3buchet | vishy: when you reword? | 15:41 |
| sandywalsh | jeblair, so wouldn't it have to be 'branch/review/branch/review/...'? | 15:41 |
| jeblair | notmyname: the gerrit change-id hook runs on commit | 15:41 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Killed AOEVolumeDriver. https://review.openstack.org/562 | 15:41 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Adding myself to the authors. https://review.openstack.org/563 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: removed extraneous line from docs https://review.openstack.org/564 | 15:42 |
| *** AhmedSoliman has joined #openstack-dev | 15:42 | |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Renamed discover_volume to prepare_attach, undiscover_volume to prepare_detach. https://review.openstack.org/565 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Killed 'num_shelves' flag; No use for it now that AOE is removed. https://review.openstack.org/566 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: killed blades_per_shelf flag; no longer needed since AOE has been removed. https://review.openstack.org/567 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Killing more dead code from removing AOE https://review.openstack.org/568 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: more removal of aoe stuff https://review.openstack.org/569 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: rip out more aoe https://review.openstack.org/570 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: one more https://review.openstack.org/571 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Removing export_devices table. https://review.openstack.org/572 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: splitting up volume and compute coupling https://review.openstack.org/573 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fixing some pep8 errors. https://review.openstack.org/574 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fix log string and detach_volume https://review.openstack.org/575 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: change attach_volume to pass in connection_info https://review.openstack.org/576 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Adding new field to the block_device_mapping model. https://review.openstack.org/577 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Adding a migration file to add a device_path field to block_device_mapping. https://review.openstack.org/578 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: more decoupling https://review.openstack.org/579 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: WIP changes being handed off to vish. https://review.openstack.org/580 | 15:42 |
| vishy | fail | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: finish rewriting initialize and terminate https://review.openstack.org/581 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: split out code into driver classes https://review.openstack.org/582 | 15:42 |
| tr3buchet | yowza! | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: continue to cleanup volume attach code https://review.openstack.org/583 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: move login code to libvirt volume driver https://review.openstack.org/584 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: add an exception for libvirt volume driver https://review.openstack.org/585 | 15:42 |
| notmyname | openstackgerrit: use the pastebin!! ;-) | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: renumber migration scripts https://review.openstack.org/586 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: add libvirt volume drivers https://review.openstack.org/587 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fix method signature typos https://review.openstack.org/588 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: happy path finished https://review.openstack.org/589 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fix xen tests/code https://review.openstack.org/590 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fix/speedup cloud test cases https://review.openstack.org/591 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fixing block device info in terminate https://review.openstack.org/592 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: disconnect from boot volumes on terminate https://review.openstack.org/593 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fix typo https://review.openstack.org/594 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: no need to terminate volumes from hostless instance. If it has no host, they never got created https://review.openstack.org/595 | 15:42 |
| vishy | of course that apparently submits all of them as separate reviews | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: cascade deletes for block device mapping instead of iterating through and deleting https://review.openstack.org/596 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: keep error traceback. Fixed double use of mount_device https://review.openstack.org/597 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: missed one reference to connection https://review.openstack.org/598 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: write some volume driver tests and fix typos https://review.openstack.org/599 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: live migration/boot-from-volume test completed https://review.openstack.org/600 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: change migrate numbers https://review.openstack.org/601 | 15:42 |
| openstackgerrit | A change was merged to openstack/nova: Add minDisk and minRam to OSAPI image details https://review.openstack.org/559 | 15:42 |
| sandywalsh | isn't that what you wanted? or are these dups? | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fix remote error to come from nova exception and test_compute https://review.openstack.org/602 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fix the fake volume driver https://review.openstack.org/603 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fix bdm delete and add back discover https://review.openstack.org/604 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: use stubs instead of setattr https://review.openstack.org/605 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fix virt driver test https://review.openstack.org/606 | 15:42 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: pull in changes from manager https://review.openstack.org/607 | 15:43 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: changes from volume api https://review.openstack.org/608 | 15:43 |
| bcwaldon | vishy: :| and every one sends me an email, too | 15:43 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fix scheduler test https://review.openstack.org/609 | 15:43 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fix integrated attach volume test https://review.openstack.org/610 | 15:43 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: compare as string instead of converting to int https://review.openstack.org/611 | 15:43 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: fix rescan and messed up permissions https://review.openstack.org/612 | 15:43 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: renumber migrations https://review.openstack.org/613 | 15:43 |
| vishy | sandywalsh: i think what i want just doesn't work | 15:43 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: use tuples for login and logout https://review.openstack.org/614 | 15:43 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: make it work when we are on the same host https://review.openstack.org/615 | 15:43 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Fix rebasing errors https://review.openstack.org/616 | 15:43 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: remove non-existing terminate_volumes https://review.openstack.org/617 | 15:43 |
| vishy | sorry for the spam guys | 15:43 |
| heckj | yep, getting spammed in stereo! | 15:43 |
| glenc | mmmmm, spam | 15:43 |
| mtaylor | wow. that was impressive | 15:43 |
| bcwaldon | I'm not even mad... | 15:43 |
| heckj | vishy: all good - better to take the hit up front | 15:43 |
| tr3buchet | yeah i'm thinking 1 branch 1 merge | 15:43 |
| vishy | ok well I guess i know what not to do now | 15:43 |
| vishy | tr3buchet: ok can we specify multiple authors? | 15:43 |
| notmyname | vishy: mute openstackgerrit first? ;-0 | 15:43 |
| jeblair | vishy: you _didn't_ want separate changes? | 15:43 |
| kbringard | holy gerrit flood batman | 15:44 |
| vishy | jeblair: I'm just used to people getting credit for what they actually do, but I guess there is no way to do that in this setup | 15:44 |
| sandywalsh | I assumed that's what was intended ... gerrit per commit | 15:44 |
| vishy | i will stop spamming people now | 15:44 |
| ameade | man, you get a lot of work done | 15:45 |
| tr3buchet | the author shouldn't change | 15:45 |
| tr3buchet | vishy ^ | 15:45 |
| sandywalsh | vishy, you have a long way to go to beat ttx | 15:45 |
| notmyname | jeblair: I was wondering how a particular change id is generated. IOW, how does it know to keep a change id or generate a new one? | 15:45 |
| jeblair | notmyname: it generates and adds one if it there is not one in the commit message. | 15:46 |
| jeblair | notmyname: so, ideally, if it's a new commit, it adds one. if you are amending a commit to, say, implement changes suggested in a code review, it will already be there and nothing needs to happen. | 15:47 |
| sandywalsh | jeblair, in the *last* commit msg, correct? | 15:47 |
| notmyname | jeblair: ah. that's right. new patcheset have the same because they are a squash on top of the existing one (and the dev is responsible for keeping the changeid in the commit message) | 15:47 |
| jeblair | notmyname: yep | 15:47 |
| jeblair | sandywalsh: the change-id hook is a commit hook, so runs every time a commit message is saved | 15:48 |
| notmyname | jeblair: which unfortunately makes vishy right: with gerrit it's hard to have a collaborative branch merged and let everyone get appropriate creadit/blame | 15:48 |
| sandywalsh | jeblair, gotcha ... what I was suggesting in the email was if it could look back to where the branch diverged from trunk and scan from there. | 15:48 |
| sandywalsh | i guess not required if the rebase works correctly | 15:49 |
| mtaylor | notmyname: that is correct | 15:49 |
| sandywalsh | the squash merge/rebase seems the be the main culprit here | 15:50 |
| openstackgerrit | A change was merged to openstack/nova: Fix rfc.sh's check for the project https://review.openstack.org/556 | 15:51 |
| johan_-_ | how did my branch make it into lp:nova yesterday but now it's not there anymore? | 15:53 |
| *** Binbin has quit IRC | 15:54 | |
| *** zns has joined #openstack-dev | 15:55 | |
| openstackgerrit | Troy Toman proposed a change to openstack/nova: Fix bug 856664 overLimit errors now return 413 https://review.openstack.org/619 | 15:57 |
| uvirtbot | Launchpad bug 856664 in nova "When hitting the absolute limit I am getting a 403 instead of 413" [Undecided,New] https://launchpad.net/bugs/856664 | 15:57 |
| johan_-_ | lp:~johannes.erdfelt/nova/lp822982 got merged into lp:nova yesterday, but it's not on github it seems and it's not in lp:nova anymore (which i understand is a mirror of github now?) | 15:59 |
| johan_-_ | it's there in lp:nova/diablo | 15:59 |
| tr3buchet | vishy: i think your best bet is to take your branch with all the chances in it and clone it, then do a git rebase and pull out each set of changes then gerrit them one at a time | 15:59 |
| tr3buchet | clone so as not to worry | 16:00 |
| mtaylor | vishy: should we make all of the changes you just uploaded as abandoned? I'm guessing you don't want to review each of them individually | 16:02 |
| *** lorin1 has joined #openstack-dev | 16:02 | |
| *** lorin1 has left #openstack-dev | 16:02 | |
| wwkeyboard | Could I get someone to look over https://review.openstack.org/#change,545 ? | 16:02 |
| wwkeyboard | I'm want to make sure I'm following the gerrit process correctly. | 16:03 |
| *** zns has quit IRC | 16:03 | |
| wwkeyboard | s/I'm/I/ sorry, insufficient coffee this morning. | 16:04 |
| ameade | wwkeyboard: are you in the authors file? | 16:05 |
| mtaylor | wwkeyboard: yes. I agree. not enough coffee. | 16:05 |
| wwkeyboard | ameade: I doubt it as this is the first I've heard of an authors file. | 16:05 |
| kbringard | I'm glad I got in the authors file way back when we let any old schmoe in ;-) | 16:05 |
| ameade | wwkeyboard: well that's one thing you gotta do, just add yourself in the Authors file | 16:06 |
| mtaylor | good call ameade. wwkeyboard, you're going to want to amend your patch to add yourself to the Authors file | 16:06 |
| * mtaylor shuts up - ameade has got this under control :) | 16:06 | |
| ameade | lol | 16:06 |
| comstud | jeblair, mtaylor: Is someone able to move over johannes's merge that made it into nova/trunk around the time of the cutover, but didn't make it to github? | 16:06 |
| wwkeyboard | Thanks for the info! | 16:06 |
| comstud | see his comments above | 16:06 |
| mtaylor | comstud: looking | 16:06 |
| ameade | comstud: my branch was in the same posistion | 16:07 |
| ameade | comstud: i just did this http://wiki.openstack.org/MigrateMergePropFromLaunchpadToGerrit | 16:07 |
| comstud | ameade: johannes's actually merged | 16:07 |
| vishy | mtaylor: no you can delete them | 16:08 |
| comstud | it looks like there was one from titan that was approved... | 16:08 |
| ameade | comstud: ah alrighty then | 16:08 |
| comstud | but didn't merge | 16:08 |
| mtaylor | vishy: ok | 16:08 |
| bcwaldon | comstud: which | 16:08 |
| comstud | bcwaldon: sec | 16:08 |
| comstud | bcwaldon: minram | 16:08 |
| mtaylor | vishy: for what it's worth, here's the script I'm going to run to do that: http://paste.openstack.org/show/2543/ (there's an ssh/command line interface that I like to pimp out whenever I can) | 16:08 |
| bcwaldon | comstud: we got one in (minram-mindisk) in earlier today | 16:08 |
| bcwaldon | comstud: you're so behind! | 16:08 |
| comstud | bcwaldon: it's going to need to be copied over to hit and re-reviewed i guess | 16:08 |
| comstud | ahh ok | 16:08 |
| comstud | well | 16:08 |
| comstud | it's 9am | 16:08 |
| comstud | sue me | 16:08 |
| mtaylor | well - I'm going to do that script _without_ the echo | 16:08 |
| comstud | :) | 16:09 |
| comstud | i just woke up! | 16:09 |
| bcwaldon | comstud: Wrong. It is 12pm | 16:09 |
| vishy | mtaylor (or anyone) is it possible to set multiple authors in a commit? | 16:09 |
| comstud | bcwaldon WRONG! | 16:09 |
| comstud | hehe | 16:09 |
| wwkeyboard | ohh snap! the Authors file is alphabetical | 16:09 |
| bcwaldon | wwkeyboard: you jerk! | 16:09 |
| vishy | to answer my question: apparently no you cant | 16:10 |
| ameade | I am slowly moving down the Authors file :( | 16:10 |
| comstud | aaron has turned into a keyboard? | 16:10 |
| notmyname | vishy: different author and commiter but only one of each, I think, in git | 16:10 |
| mtaylor | vishy: from what I can tell, it seems no, but people will put in notes into the commit message: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=451880 | 16:10 |
| uvirtbot | Debian bug 451880 in git "git-core: Git should support multiple authors for a commit" [Wishlist,Open] | 16:10 |
| vishy | mtaylor, notmyname: well i guess shared branches are a little hamstrung | 16:10 |
| vishy | at least for people feeling good about their commits | 16:11 |
| Daviey | ls | 16:11 |
| ameade | could always just stick names in the commit message | 16:12 |
| ameade | lol | 16:12 |
| mtaylor | vishy: yes. well, the current model is to ensure that every commit that hits trunk is gold - so merging in a shared branch like that would get us with all of those subcommits in the mainline, which would make bisecting more difficult in the future | 16:12 |
| vishy | mtaylor: true ok, just hadn't wrapped my head around our new plan | 16:13 |
| mtaylor | vishy: totally. and I hadn't really contemplated group branches like that - I'm wondering if there's a way that we could leverage gerrit's branch ability to do something | 16:14 |
| comstud | ameade: but that won't update github karma!..... oh wait. | 16:14 |
| ameade | comstud: you read my mind! | 16:14 |
| comstud | ameade: yes, and your other thoughts are very disturbing. | 16:15 |
| * comstud stops reading minds. | 16:16 | |
| notmyname | mtaylor: it comes back to merge commits vs ff commits, right? | 16:16 |
| ameade | comstud: yeah you should tread softly | 16:16 |
| mtaylor | vishy: ok. those are all cleaned out | 16:16 |
| mtaylor | notmyname: well, it comes back to that blog post you shared a while back | 16:16 |
| mtaylor | notmyname: about wanting each trunk commit to describe a discreet and solid unit of work | 16:16 |
| mtaylor | notmyname: and therefore discarding the intermediary commits that got you there. | 16:17 |
| openstackgerrit | Aaron Lee proposed a change to openstack/nova: bug lp845714 https://review.openstack.org/545 | 16:18 |
| notmyname | mtaylor: we have to be careful not to fall into another holy war here ;-) | 16:18 |
| mtaylor | totally | 16:18 |
| ameade | wwkeyboard: looks like you are doing it right | 16:19 |
| mtaylor | well... that blog post helped me understand the motivation behind the design well ... at the end of the day though, gerrit winds up being designed well for implementing that approach | 16:19 |
| *** nati_ has quit IRC | 16:19 | |
| wwkeyboard | ameade: thanks | 16:19 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Remove AoE, Clean up volume code https://review.openstack.org/620 | 16:23 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Remove AoE, Clean up volume code https://review.openstack.org/620 | 16:25 |
| *** chomping has joined #openstack-dev | 16:30 | |
| *** BK_man has joined #openstack-dev | 16:31 | |
| *** neogenix has quit IRC | 16:34 | |
| openstackgerrit | Carlos Marin proposed a change to openstack/keystone: Modified apiKeyCredentials to extend single entity and use restriction https://review.openstack.org/551 | 16:42 |
| openstackgerrit | Brian Waldon proposed a change to openstack/nova: Moving admin actions to extension https://review.openstack.org/621 | 16:44 |
| vladimir3p | vishy: ping | 16:45 |
| vishy | vladimir3p: pong | 16:48 |
| vladimir3p | vishy: Hi, some time ago you mentioned on our BP that there is a team working on block-storage. Can't find any ref to it... ? | 16:48 |
| vishy | vladimir3p: a lot has been held up on our end due to my volume cleanup branch | 16:48 |
| vladimir3p | vishy: yeah, I see you resubmitted it | 16:49 |
| vishy | vladimir3p: speaking of which, I'm not sure that I merged your stuff correctly so I would appreciate if you check it | 16:49 |
| vishy | vladimir3p: part of your stuff was using discover_volume, which i moved into the compute side | 16:49 |
| vishy | vladimir3p: so i copied it into your class, but I'd prefer if it were removed from that class completely | 16:49 |
| *** nati has joined #openstack-dev | 16:49 | |
| vladimir3p | vishy: sure, I will give it a shot | 16:50 |
| *** joesavak has joined #openstack-dev | 16:50 | |
| zul | is there a reason why we are getting email for every commit in gerrit | 16:51 |
| vishy | zul: that was my bad | 16:52 |
| vishy | zul: i tried some magic and end up propping a review for every commit in my branch history | 16:52 |
| zul | oops | 16:52 |
| openstackgerrit | A change was merged to openstack/keystone: Modified apiKeyCredentials to extend single entity and use restriction https://review.openstack.org/551 | 17:00 |
| *** ameade has quit IRC | 17:01 | |
| comstud | whoever made that commit for the rfc.sh fix... | 17:02 |
| *** stuntmachine has quit IRC | 17:03 | |
| comstud | Author: Jenkins <jenkins@review.openstack.org> | 17:03 |
| comstud | which is not in the Authors file, of course | 17:03 |
| jeblair | comstud: is that breaking the authors test? | 17:04 |
| comstud | yes | 17:04 |
| pvo | yes | 17:04 |
| jeblair | Jenkins will be listed as the author for merge commits when the tree can't be fast forwarded, so we should either add jenkins to the authors file or change the test to ignore Jenkins commits | 17:05 |
| comstud | jeblair: also, vishy updated the wiki last night to clone from just $PROJECT instead of $PROJECT.git.. because of rfc.sh not matching the doc | 17:06 |
| comstud | jeblair: So now the wiki might need updated again | 17:06 |
| jeblair | (i like the second solution) | 17:06 |
| openstackgerrit | Verification of a change to openstack/nova failed: Fix bug 856664 overLimit errors now return 413 https://review.openstack.org/619 | 17:06 |
| uvirtbot | Launchpad bug 856664 in nova "When hitting the absolute limit I am getting a 403 instead of 413" [Undecided,In progress] https://launchpad.net/bugs/856664 | 17:06 |
| jeblair | comstud: thanks, i'll go look | 17:06 |
| adam_g | ttx: regarding bug #857021, you're right. looks bug was introduced to ubuntu packaging branch only.. must have peaked at the wrong PPA late last night. | 17:06 |
| *** nhm has quit IRC | 17:06 | |
| uvirtbot | Launchpad bug 857021 in glance "glance (2011.3-0ubuntu1) fails to install, error in .postinst" [High,Fix released] https://launchpad.net/bugs/857021 | 17:06 |
| comstud | jeblair: The 2nd solution makes sense | 17:06 |
| *** benrodrigue has joined #openstack-dev | 17:07 | |
| pvo | jeblair: that last jenkins failure is the authors issue | 17:08 |
| vishy | jeblair: on gerrit, doe jenkins verify after +2, or does it try to verify branches in advance? | 17:08 |
| mtaylor | vishy: after +2 | 17:09 |
| *** rbasak has quit IRC | 17:09 | |
| jeblair | vishy: after +2 (it's triggered by setting +2) | 17:09 |
| jeblair | vishy: two reasons for that: a) so that Jenkins is testing the code as it will be merged (since if it tested earlier, HEAD could change) | 17:09 |
| mtaylor | comstud, jeblair: you want me to do the authors patch? or is someone already doing it? | 17:09 |
| jeblair | b) so we're not running arbitrary un-reviewed code on the jenkins slaves | 17:10 |
| comstud | mtaylor: I'm not quiet set up yet | 17:10 |
| comstud | quite | 17:10 |
| jeblair | mtaylor: i'm not either, that would be great. :) | 17:10 |
| mtaylor | k. I'll get it | 17:10 |
| comstud | thnx | 17:10 |
| pvo | mtaylor: is that what we want though? Won't that mask who actually did the commit? | 17:11 |
| vishy | jeblair: it would be nice to have a second version that would just run through and comment red or green on a patch set | 17:11 |
| mtaylor | pvo: nope. you'll still get the real author on the real commit - the merge commit is the thing that gets jenkins as the author | 17:12 |
| vishy | jeblair, mtaylor: so that there would be a bit of advance notice if it was going to fail | 17:12 |
| jeblair | https://github.com/openstack/nova/commit/48bc6645da2f12a6c1667d2db49afe1d5417de9f | 17:12 |
| jeblair | pvo: that's the real commit | 17:12 |
| vladimir3p | vishy: ping | 17:12 |
| vladimir3p | vishy: just reviewed your volume_cleanup | 17:12 |
| *** stanchan has joined #openstack-dev | 17:12 | |
| *** nhm has joined #openstack-dev | 17:13 | |
| pvo | github says "Jenkins authored about an hour ago" | 17:13 |
| vladimir3p | vishy: the only reason we called discovery is because there was a distinction between "local_path" and remote volume | 17:13 |
| pvo | https://github.com/openstack/nova/commit/b020a057724cdf3cff59e168058ec9eb11a347ba | 17:13 |
| pvo | am I looking at it wrong? | 17:13 |
| bcwaldon | markmc: can you add something to your authors branch? | 17:13 |
| jeblair | pvo: that's the merge commit, it merged the real commit and trunk | 17:14 |
| bcwaldon | markmc: https://jenkins.openstack.org/job/nova/121527/console | 17:14 |
| openstackgerrit | William Wolf proposed a change to openstack/nova: Add next links to images requests https://review.openstack.org/622 | 17:14 |
| vladimir3p | vishy: it was in setup_compute_volume(). Now I see that you removed this code, which means that we could probably get rid of local_path() method in volume driver completely | 17:14 |
| jeblair | pvo: if you look here https://github.com/openstack/nova/commits/master | 17:14 |
| jeblair | you can see both commits | 17:14 |
| vladimir3p | it seems like nobody will be calling it anymore | 17:14 |
| pvo | ah, I see it further back... sorry. | 17:14 |
| vishy | vladimir3p: nice | 17:14 |
| jeblair | (this would make more sense if you looked at it in a tree view) | 17:14 |
| pvo | "git log --graph --oneline --all" | 17:15 |
| *** heckj has quit IRC | 17:15 | |
| jeblair | pvo: indeed! cool. :) | 17:16 |
| vladimir3p | vishy: btw, I definitely understand the rationale of previous "local_path" functionality. It definitely complicates things a bit, but was probably a nice optimization. Do you plan to implement something like that later? | 17:17 |
| openstackgerrit | Monty Taylor proposed a change to openstack/nova: Don't use GitPython for authors check https://review.openstack.org/561 | 17:19 |
| mtaylor | comstud, jeblair ^^ | 17:19 |
| *** dolphm has quit IRC | 17:20 | |
| vladimir3p | vishy & all: We periodically experience a ResourceClosedError while calling db.volume_allocate_iscsi_target(). Any idea what might be causing it? Was it because DB is locked at that time by .with_lockmode('update')? | 17:22 |
| openstackgerrit | Brian Lamar proposed a change to openstack/nova: Re-declared the reclaim_instance_interval flag to avoid test failure when not running the entire test suite. Fixed bug 857580. https://review.openstack.org/623 | 17:22 |
| uvirtbot | Launchpad bug 857580 in nova "reclaim_instance_interval must be re-declared to use in OSAPI" [Undecided,New] https://launchpad.net/bugs/857580 | 17:22 |
| *** darraghb has quit IRC | 17:23 | |
| markmc | bcwaldon, ah, okay - think changing it to 'git log --format=%ae HEAD^' will fix that | 17:25 |
| markmc | bcwaldon, bbiab and will fix then | 17:25 |
| mtaylor | markmc: I think I gotcha already | 17:26 |
| bcwaldon | markmc: yeah, thank you sir | 17:26 |
| bcwaldon | mtaylor: you have a fix for that? | 17:26 |
| mtaylor | bcwaldon: https://review.openstack.org/561 | 17:27 |
| markmc | mtaylor, looking at HEAD^ is actually more inline with what the original code did | 17:27 |
| markmc | mtaylor, hmm, maybe not | 17:28 |
| mtaylor | markmc: should we add that in as well? | 17:28 |
| markmc | mtaylor, nm - go for it :) | 17:28 |
| bcwaldon | mtaylor: looks good | 17:28 |
| markmc | mtaylor, right, the merge commits that get pushed are actually by jenkins@review.openstack.org | 17:29 |
| bcwaldon | just approve it | 17:29 |
| bcwaldon | approved* | 17:29 |
| comstud | "Once a review is voted up to +2 (two reviewers, or one core-team reviewer voting +2), Jenkins will run the proposed change and verify the merge" | 17:31 |
| comstud | if i read that correctly, it says that only 1 core team reviewer can force something to merge? | 17:32 |
| bcwaldon | That doesn't seem entirely true | 17:32 |
| bcwaldon | there *has* to be a +2 from a core dev | 17:33 |
| mtaylor | well, nobody can _force_ something to merge | 17:33 |
| comstud | well | 17:33 |
| jeblair | comstud: where is that text from? | 17:33 |
| bcwaldon | but only one core dev is required to approve it and it will go in | 17:33 |
| mtaylor | comstud: hrm - that may be worded confusingly | 17:33 |
| comstud | i mean.. that doc above implies if a single core dev votes +2, jenkins will try to merge | 17:33 |
| mtaylor | comstud: where is that? | 17:33 |
| comstud | gerrit workflow on wiki | 17:33 |
| comstud | http://wiki.openstack.org/GerritWorkflow | 17:34 |
| mtaylor | jeblair: you on it? or you want me to? | 17:34 |
| jeblair | comstud: the text is not quite right | 17:34 |
| jeblair | mtaylor: i'll fix it | 17:34 |
| comstud | I also cannot find any reference to how to use this UI | 17:35 |
| mtaylor | comstud: the general confusion here comes from two +1s not being equivilent to a +2 | 17:35 |
| comstud | other than "click review" | 17:35 |
| mtaylor | comstud: a +1 or a -1 is equivilent to a review vote in launchpad. +2 is similar to someone setting the overall status to Approved | 17:35 |
| mtaylor | and only the folks in the core team have the power to do that - waiting until there are enough votes on the review before approving something is a policy item at the moment | 17:36 |
| comstud | ok, so a core dev should vote '+1' until one sees another core dev has already voted +1? | 17:36 |
| bcwaldon | can we re-word that wiki? | 17:36 |
| bcwaldon | comstud is on it | 17:36 |
| mtaylor | yes. jeblair is working on that right now | 17:36 |
| bcwaldon | damn | 17:36 |
| comstud | bcwaldon: slow poke | 17:37 |
| bcwaldon | mtaylor: why is nova-coverage disabled? | 17:37 |
| westmaas | hey can we get that wiki page updated? its a little confusing. | 17:37 |
| mtaylor | westmaas: yes. it's in work | 17:37 |
| comstud | westmaas: LOL | 17:37 |
| bcwaldon | troll | 17:37 |
| westmaas | wat | 17:37 |
| mtaylor | westmaas: you wanna do it? | 17:37 |
| westmaas | :P | 17:37 |
| mtaylor | westmaas: no, wait, someone is working on it | 17:37 |
| westmaas | haha, no I'm good, just teasing bcwaldon | 17:38 |
| comstud | i'd do it, but I have no idea what it should be! | 17:38 |
| mtaylor | :) | 17:38 |
| openstackgerrit | A change was merged to openstack/nova: Don't use GitPython for authors check https://review.openstack.org/561 | 17:38 |
| comstud | spending 2 hours learning something new is not what I planned to do today | 17:38 |
| bcwaldon | mtaylor: did you see my q about nova-coverage? | 17:39 |
| mtaylor | bcwaldon: oh, yeah - we disabled a few of the jobs while we were doing the transition because we need to transition how the jobs are getting their stuff | 17:39 |
| bcwaldon | mtaylor: kk, and is there any way to prevent two people from kicking off jenkins jobs by +2'ing twice? | 17:40 |
| bcwaldon | mtaylor: like you and I did for this git authors branch | 17:40 |
| mtaylor | bcwaldon: oh! I would not have expected jenkins to have fired twice. I shall file a bug about that | 17:40 |
| bcwaldon | mtaylor: yeah, it's happened twice now today | 17:41 |
| mtaylor | bcwaldon: actually - hrm, it is listening for events | 17:41 |
| mtaylor | yeah - I don't know the answer to that - but I will file a bug so that we know to investigate | 17:41 |
| jeblair | http://wiki.openstack.org/GerritWorkflow#Reviewing_a_Change | 17:49 |
| mtaylor | jeblair: looks great | 17:50 |
| mtaylor | comstud: ^^ make more sense? | 17:50 |
| *** dragondm has joined #openstack-dev | 17:51 | |
| comstud | looking | 17:52 |
| *** dprince has joined #openstack-dev | 17:53 | |
| *** joesavak has quit IRC | 17:53 | |
| *** joesavak has joined #openstack-dev | 17:53 | |
| comstud | i'd almost throw "(even core reviewers)" after " reviewers should vote +1 to indicate they approve of the change" | 17:53 |
| comstud | to make it extremely clear that core reviewers should note vote +2 until at least one other core member has voted +1 | 17:54 |
| comstud | I get what it means | 17:54 |
| jeblair | comstud: good idea. you want to make that change? | 17:54 |
| comstud | I think core reviewers might still ask for clarification based on how it's written. | 17:54 |
| comstud | if I can remember my login | 17:54 |
| comstud | sec | 17:55 |
| comstud | hrm | 17:56 |
| jeblair | i can do it if you like | 17:56 |
| comstud | i can't seem to login | 17:57 |
| comstud | logins were FirstLast name right? | 17:57 |
| openstackgerrit | Verification of a change to openstack/nova failed: Fix bug 856664 overLimit errors now return 413 https://review.openstack.org/619 | 17:57 |
| uvirtbot | Launchpad bug 856664 in nova "When hitting the absolute limit I am getting a 403 instead of 413" [Undecided,In progress] https://launchpad.net/bugs/856664 | 17:57 |
| *** mdomsch has quit IRC | 17:57 | |
| jeblair | comstud: yep | 17:57 |
| comstud | ooh | 17:57 |
| comstud | i got in | 17:57 |
| comstud | you editing already or? | 17:58 |
| jeblair | go for it | 17:58 |
| comstud | k | 17:58 |
| troytoman | so jenkins failed after my patch got reviewed because jenkins is not in the authors file. do i just need to rebase? | 17:58 |
| jeblair | troytoman: as long as nothing has changed in the trunk that would conflict with your change, you shouldn't need to rebase (but it wouldn't hurt). just your patch needs to get +2 again now that the fix to the jenkins/authors problem has gone in. | 18:01 |
| mtaylor | troytoman: which change was your change? | 18:01 |
| troytoman | mtaylor: https://review.openstack.org/619 | 18:01 |
| *** mgius has joined #openstack-dev | 18:03 | |
| jeblair | troytoman: i'll retrigger jenkins for your change | 18:04 |
| * jaypipes stabs sqlalchemy-migrate | 18:04 | |
| jeblair | troytoman: it's running again now https://jenkins.openstack.org/job/nova/121531/console | 18:05 |
| *** Vek has quit IRC | 18:06 | |
| * mtaylor is SO happy that changes are directly running in jenkins now and now off in a tmp dir in a tarmac build | 18:10 | |
| openstackgerrit | Verification of a change to openstack/nova failed: Fix bug 856664 overLimit errors now return 413 https://review.openstack.org/619 | 18:13 |
| uvirtbot | Launchpad bug 856664 in nova "When hitting the absolute limit I am getting a 403 instead of 413" [Undecided,In progress] https://launchpad.net/bugs/856664 | 18:13 |
| comstud | http://wiki.openstack.org/GerritWorkflow#Reviewing_a_Change | 18:14 |
| comstud | hopefully i got it right | 18:14 |
| *** nati has quit IRC | 18:14 | |
| troytoman | jeblair, mtaylor: got the same author/jenkins failure on the build https://jenkins.openstack.org/job/nova/121531/console | 18:16 |
| mtaylor | troytoman: hrm. grr. one sec - lemme look | 18:16 |
| markmc | jenkins merges master before doing the build, right? | 18:17 |
| vladimir3p | folks, have anybody had opinion on sqlalchemy's with_lockmode() functionality? May it return ResourceClosedError exception in case of concurrent access? | 18:17 |
| mtaylor | markmc: yes | 18:18 |
| markmc | mtaylor, k, thanks | 18:18 |
| *** bsza has quit IRC | 18:19 | |
| mtaylor | troytoman: ok, so LOCALLY I get a different authors error (your email not being in the Authors file) | 18:19 |
| mtaylor | troytoman: BUT - that does not explain to me why the jenkins job is showing the jenkins author fail | 18:20 |
| mtaylor | so there may be more than one thing at play here | 18:20 |
| troytoman | mtaylor: interesting. i should be there from a previous bug fix. but, let me know what you find and i'll look again | 18:21 |
| mtaylor | troytoman: you are in the authors file as troy.toman@rackspace.com ... that commit is by ttcl@mac.com | 18:22 |
| troytoman | mtaylor: could it be that I am in there under my rackspace email but this commit was done from my non-rack email? | 18:22 |
| mtaylor | troytoman: yup | 18:22 |
| mtaylor | troytoman: you can add your non-rackspace email to the .mailmap file | 18:22 |
| troytoman | mtaylor: OK. thanks for sorting that out | 18:23 |
| mtaylor | troytoman: sure thing! | 18:23 |
| mtaylor | troytoman: also, we discovered another setup bug, so you were very helpful :) | 18:23 |
| troytoman | mtaylor: always happy to help :-) | 18:23 |
| openstackgerrit | Troy Toman proposed a change to openstack/nova: Fix bug 856664 overLimit errors now return 413 https://review.openstack.org/619 | 18:27 |
| uvirtbot | Launchpad bug 856664 in nova "When hitting the absolute limit I am getting a 403 instead of 413" [Undecided,In progress] https://launchpad.net/bugs/856664 | 18:27 |
| *** bsza has joined #openstack-dev | 18:32 | |
| openstackgerrit | Aaron Lee proposed a change to openstack/nova: bug lp845714 https://review.openstack.org/545 | 18:32 |
| mtaylor | troytoman: I don't believe you picked up that .mailmap changes ... did you git add .mailmap before doing the commit --amend? | 18:38 |
| openstackjenkins | Project nova-docs build #1,413: SUCCESS in 3 min 19 sec: https://jenkins.openstack.org/job/nova-docs/1413/ | 18:39 |
| *** wwkeyboard has quit IRC | 18:40 | |
| troytoman | mtaylor: hehe. worse actually, i made the change in my old bzr branch not in the git branch. will try again. thanks for catching it | 18:40 |
| openstackgerrit | Troy Toman proposed a change to openstack/nova: Fix bug 856664 overLimit errors now return 413 https://review.openstack.org/619 | 18:41 |
| uvirtbot | Launchpad bug 856664 in nova "When hitting the absolute limit I am getting a 403 instead of 413" [Undecided,In progress] https://launchpad.net/bugs/856664 | 18:41 |
| mtaylor | troytoman: hahahah! | 18:42 |
| mtaylor | there it is | 18:42 |
| openstackgerrit | A change was merged to openstack/nova: Fix bug 856664 overLimit errors now return 413 https://review.openstack.org/619 | 18:55 |
| uvirtbot | Launchpad bug 856664 in nova "When hitting the absolute limit I am getting a 403 instead of 413" [Undecided,In progress] https://launchpad.net/bugs/856664 | 18:55 |
| vishy | comstud, bcwaldon, dprince, soren, tr3buchet, etc.: Is something like this interesting to anyone? | 18:56 |
| vishy | https://gist.github.com/1238152 | 18:56 |
| vishy | (it runs all of the nova services in one process) | 18:56 |
| comstud | hm | 18:58 |
| comstud | that could make testing a bit easier | 18:58 |
| markmc | vishy, nice | 19:01 |
| vishy | I'm just wondering if i should prop it | 19:02 |
| vishy | I can run everything on my mac with: ./nova-all --verbose --fake_rabbit --compute_driver=nova.virt.fake.get_connection --volume_driver=nova.volume.driver.FakeISCSIDriver | 19:02 |
| vishy | and api commands work. | 19:03 |
| comstud | i always use a VM on my mac | 19:04 |
| comstud | in fact, i'm running xenserver under vmware fusion | 19:04 |
| openstackjenkins | Project nova-docs build #1,414: SUCCESS in 3 min 38 sec: https://jenkins.openstack.org/job/nova-docs/1414/ | 19:04 |
| openstackjenkins | ttcl: Fix bug 856664 overLimit errors now return 413 | 19:04 |
| comstud | which works surprisingly well if you have 8GB | 19:04 |
| uvirtbot | Launchpad bug 856664 in nova "When hitting the absolute limit I am getting a 403 instead of 413" [Undecided,Fix committed] https://launchpad.net/bugs/856664 | 19:04 |
| vishy | comstud: I do too, but it might be nice to be able to kick the tires without going to the vm | 19:04 |
| comstud | oh sure.. i know ppl who would appreciate things that make life easier on native osx | 19:05 |
| openstackgerrit | Naveed Massjouni proposed a change to openstack/nova: Adding xml schema validation for /versions resource. https://review.openstack.org/624 | 19:06 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Clean up service launching, add nova-all to run all services https://review.openstack.org/625 | 19:08 |
| vishy | well it is propped now :) | 19:09 |
| openstackgerrit | Jay Pipes proposed a change to openstack/glance: Fixes LP Bug #824794 https://review.openstack.org/626 | 19:10 |
| uvirtbot | Launchpad bug 824794 in glance "Tables are generated outside of migration process" [Low,In progress] https://launchpad.net/bugs/824794 | 19:10 |
| *** pvo has left #openstack-dev | 19:12 | |
| tr3buchet | vishy: it's interesting to me | 19:12 |
| *** pvo has joined #openstack-dev | 19:12 | |
| *** markvoelker has quit IRC | 19:13 | |
| mtaylor | vishy: would nova-all be something that we should consider writing a jenkins test around? like, run nova-all and then run one of the sets of api tests against it? early smoke testing? | 19:13 |
| vishy | mtaylor: it seems like it is way easier than starting all of the services, but it doesn't really stop you from having do do config | 19:15 |
| vishy | mtaylor: so it isn't really any more magical than starting them all in screen with something like nova.sh | 19:16 |
| mtaylor | vishy: hrm. yeah. good point | 19:16 |
| mtaylor | vishy: and given that we already have both vpc spinning up and testing things and the bare-metal boxes - probably not a huge win from jenkins side - but cool for devs! | 19:17 |
| comstud | mtaylor: is there a way to reply to someone's comments in gerrit, quoting the original comment? | 19:17 |
| mtaylor | comstud: hrm. | 19:18 |
| comstud | seems difficult to have a 'conversation', if not. | 19:18 |
| mtaylor | comstud: no - I shall put that on the todo list | 19:19 |
| comstud | and sounds like you'd need to continue -1'ing a review while you converse, ATM | 19:19 |
| openstackgerrit | Jay Pipes proposed a change to openstack/glance: Fixes LP Bug #824794 https://review.openstack.org/626 | 19:19 |
| uvirtbot | Launchpad bug 824794 in glance "Tables are generated outside of migration process" [Low,In progress] https://launchpad.net/bugs/824794 | 19:19 |
| comstud | mtaylor: thnx | 19:19 |
| vishy | comstud: if you comment on a line, you should be able to respond on the same line | 19:19 |
| comstud | i can comment on a particular line? | 19:20 |
| comstud | i looked to do this in your review | 19:20 |
| mtaylor | comstud: https://bugs.launchpad.net/openstack-ci/+bug/857675 | 19:20 |
| uvirtbot | Launchpad bug 857675 in openstack-ci "Gerrit should allow replying to comments and/or quoting their contents" [Undecided,New] | 19:20 |
| mtaylor | comstud: and yeah - just double click on the line that you want to comment on | 19:20 |
| comstud | ok, double click | 19:21 |
| comstud | is there a document on the UI portion somewhere? :) | 19:21 |
| mtaylor | comstud: this will queue up that line as a thing to go in to your review - just note that you will still need to go up to the top level review and submit the overall review | 19:21 |
| comstud | the link to the manual was not too helpful | 19:21 |
| comstud | mtaylor: Ok cool | 19:21 |
| mtaylor | yeah - the docs for the command line tools are much more complete ... not so much on the UI | 19:22 |
| *** dragondm has quit IRC | 19:25 | |
| openstackgerrit | A change was merged to openstack/nova: Adding xml schema validation for /versions resource. https://review.openstack.org/624 | 19:27 |
| openstackjenkins | Project nova-docs build #1,415: SUCCESS in 3 min 37 sec: https://jenkins.openstack.org/job/nova-docs/1415/ | 19:34 |
| openstackjenkins | naveedm9: Adding xml schema validation for /versions resource. | 19:34 |
| *** wwkeyboard has joined #openstack-dev | 19:34 | |
| *** z has quit IRC | 19:38 | |
| *** wwkeyboard has quit IRC | 19:38 | |
| *** wwkeyboard has joined #openstack-dev | 19:39 | |
| markmc | mtaylor, if you're taking gerrit feature requests ... :) | 19:43 |
| markmc | mtaylor, it'd be cool to be able to query the patch sets through the ssh interface | 19:44 |
| markmc | mtaylor, and e.g. get the refs/changes/NN/NNN/N path | 19:44 |
| markmc | mtaylor, so you can fetch and checkout without hitting the UI | 19:44 |
| smoser | is doc on how i propose merges now ? | 19:47 |
| smoser | i assume it goes through gerrit/review.openstack.org, but i'm not really sure how. | 19:47 |
| mtaylor | markmc: yup. you should be able to do that | 19:47 |
| markmc | smoser, http://wiki.openstack.org/GerritWorkflow | 19:48 |
| mtaylor | markmc: have you explored this yet: https://review.openstack.org/Documentation/cmd-index.html ? | 19:48 |
| *** code_franco has quit IRC | 19:48 | |
| markmc | mtaylor, yep; the query command only gives you info on the change, but not the patch sets it contains | 19:48 |
| markmc | mtaylor, you could take e.g. number: 555 and guess that will map to refs/changes/55/555/1 .. but that sucks | 19:49 |
| *** code_franco has joined #openstack-dev | 19:49 | |
| mtaylor | markmc: hrm. k. I agree that would be excellent (and I imagine it's possible) - I'll look in to it | 19:49 |
| markmc | mtaylor, cheers | 19:50 |
| mtaylor | markmc: if you like, file a bug against launchpad.net/openstack-ci so I don't forget? | 19:50 |
| markmc | mtaylor, will do | 19:50 |
| mtaylor | thanks! | 19:50 |
| smoser | thank you markmc | 19:51 |
| markmc | smoser, np | 19:51 |
| mtaylor | markmc: well, it's certainly supported in the json output: https://review.openstack.org/Documentation/json.html#patchset | 19:52 |
| markmc | mtaylor, huh, interesting | 19:52 |
| markmc | mtaylor, ah! gerrit query --patch-sets | 19:53 |
| markmc | doh | 19:53 |
| markmc | thanks :) | 19:53 |
| mtaylor | silly me | 19:53 |
| mtaylor | yay! there they are | 19:54 |
| markmc | very nice, me likey | 19:54 |
| * mtaylor is excited to see what crazy command line scripts folks cook up | 19:54 | |
| *** dragondm has joined #openstack-dev | 19:57 | |
| Daviey | mtaylor: did you see my ping earlier? | 19:59 |
| mtaylor | Daviey: not at all | 19:59 |
| *** dragondm has joined #openstack-dev | 19:59 | |
| mtaylor | Daviey: what's up? | 19:59 |
| Daviey | mtaylor: this makes me sad, http://pb.daviey.com/xSB6/ | 20:00 |
| Daviey | Case sensitive email address. | 20:00 |
| mtaylor | Daviey: hrm. yes. that's crappy | 20:00 |
| mtaylor | lemme look at that real quick | 20:01 |
| Daviey | mtaylor: no hurry | 20:01 |
| *** sandywalsh_ has joined #openstack-dev | 20:02 | |
| mtaylor | Daviey: yeah - fixing that shouldn't be terrible | 20:03 |
| jeblair | mtaylor: email addresses are case-sensitive | 20:03 |
| mtaylor | jeblair: they are? | 20:04 |
| * mtaylor defers absolutely to jeblair on this | 20:04 | |
| *** AhmedSoliman has quit IRC | 20:05 | |
| westmaas | not for actual delivery | 20:05 |
| bcwaldon | I don't think they are | 20:05 |
| mtaylor | ah. as one should expect - jeblair is correct | 20:05 |
| bcwaldon | waaaat | 20:05 |
| mtaylor | most email providers do not enforce it | 20:05 |
| jeblair | frequenty they are implemented by hosts in a case-insensitive manner. | 20:05 |
| mtaylor | from rfc 2821 "The local-part of a mailbox MUST BE treated as case sensitive." | 20:05 |
| jeblair | but the specs say you can't assume that | 20:05 |
| markmc | interestingly, 'git log --format=%aE' lowercases the address from .mailmap | 20:05 |
| * markmc got bitten by that earlier | 20:06 | |
| *** Vek has joined #openstack-dev | 20:06 | |
| jeblair | (the domain, of course, is not case-sensitive since DNS is not) | 20:06 |
| mtaylor | I love it when the standard is "it must be this way, but also nobody is doing that" :) | 20:07 |
| openstackgerrit | Vish Ishaya proposed a change to openstack/nova: Clean up service launching, add nova-all to run all services https://review.openstack.org/625 | 20:07 |
| jeblair | yes, but that's one of those 'generous in what you accept' situations... | 20:08 |
| mtaylor | jeblair: so, the standard notwithstanding, should we do case insensitive lookups for people's commit ids in terms of commit blocking? | 20:08 |
| *** dprince has quit IRC | 20:08 | |
| *** AhmedSoliman has joined #openstack-dev | 20:10 | |
| jeblair | mtaylor: the risk of abuse does seem very small. however, it is important to store exactly what the user input for use in outgoing mail. | 20:13 |
| jeblair | mtaylor: ie, changing a collation setting is cool, but lowercasing on database insert, not so much. | 20:14 |
| jeblair | mtaylor: one second before you do anything. | 20:14 |
| Daviey | jeblair: So you think that gerrit should be case sensitive? | 20:15 |
| jeblair | Daviey: no, sorry, i'm agreeing that case-insensitivity on the author/committer checks is okay. | 20:16 |
| mtaylor | jeblair: it's easy to do at check time | 20:17 |
| mtaylor | jeblair: rather than changing what is stored | 20:17 |
| jeblair | mtaylor: currently account_external_ids.email_address column is COLLATE latin1_general_cs have you looked at how it does the check? is it in sql or java? (ie, would changing the collation fix the problem)? | 20:20 |
| mtaylor | the check is in java. | 20:20 |
| mtaylor | jeblair: http://pastebin.com/cFMqcYBR should do the trick I believe | 20:20 |
| mtaylor | the java pulls a java Set<String> of addresses, and then does Set.contains checks ... changing the set doing the contains checks to have a case insensitive comparator should, you know, in theory, work | 20:21 |
| jeblair | i wonder if upstream would accept that, or require a config option? | 20:23 |
| *** mfer has quit IRC | 20:23 | |
| jeblair | mtaylor: i'd like to avoid supporting a patch like that locally, so lets see if we can get feedback from the gerrit devs first. | 20:24 |
| mtaylor | jeblair: good point. I'm guessing they'd probably want a config option | 20:24 |
| mtaylor | jeblair: that's a google group, right? | 20:25 |
| jeblair | http://code.google.com/p/gerrit/ | 20:25 |
| smoser | so, bugs are on launchpad still, right? | 20:25 |
| smoser | when i submit a review and mark it with a bug, will it tag the bug somehow ? | 20:25 |
| mtaylor | smoser: yes. | 20:25 |
| smoser | that rocks, mtaylor | 20:26 |
| mtaylor | smoser: http://wiki.openstack.org/GerritWorkflow#Committing_Changes | 20:26 |
| mtaylor | smoser: you can also reference blueprints | 20:26 |
| smoser | i'd seen that. | 20:26 |
| smoser | but will it mark the bug? so that if i look at the bug i'll see a link to the review ? | 20:27 |
| _cerberus_ | Anyone seen this? Patch does not have a valid e-mail address | 20:27 |
| _cerberus_ | Specifically on a rebase | 20:27 |
| mtaylor | smoser: yes | 20:27 |
| mtaylor | _cerberus_: pastebin? | 20:28 |
| smoser | cool. thank you sir. | 20:28 |
| _cerberus_ | That's it | 20:28 |
| _cerberus_ | rebase | 20:28 |
| Daviey | mtaylor: hmm, if someone pushes a branch now with the correct bug syntax, the LP bug doesn't get a comment to show there is a gerrit review 'HERE' does it? | 20:29 |
| Daviey | (i think that is what smoser was asking) | 20:30 |
| openstackgerrit | Brian Lamar proposed a change to openstack/glance: Do not allow min_ram or min_disk properties to be NULL and if they are None, make sure to default to 0. Fixes bug 857711 https://review.openstack.org/627 | 20:30 |
| uvirtbot | Launchpad bug 857711 in glance "min_ram and min_disk shouldn't ever be NULL" [Undecided,New] https://launchpad.net/bugs/857711 | 20:30 |
| jeblair | Daviey: https://bugs.launchpad.net/nova/+bug/856664 | 20:30 |
| uvirtbot | Launchpad bug 856664 in nova "When hitting the absolute limit I am getting a 403 instead of 413" [Undecided,Fix committed] | 20:30 |
| mtaylor | Daviey: yes. the launchpad bug gets updated | 20:31 |
| jeblair | Daviey: check out the message that gets added when the change gets merged | 20:31 |
| mtaylor | Daviey: as does the launchpad blueprint if you reference a blueprint | 20:31 |
| mtaylor | oh, jeblair got to it with an actual example :) | 20:32 |
| *** sandywalsh_ has quit IRC | 20:32 | |
| jeblair | Daviey: currently it doesn't update the bug when the patch is proposed, but not merged. That's possible though if people want that. | 20:32 |
| * mtaylor thinks of "fix committed" as "patch proposed" and "fix releaesd" as "merged" ... but knows that jml and others disagree with him on that | 20:33 | |
| *** dolphm has joined #openstack-dev | 20:34 | |
| jeblair | mtaylor: then what is a patch that is in a released version of openstack? | 20:34 |
| mtaylor | Daviey: see also: https://blueprints.launchpad.net/openstack-ci/+spec/ci-git-support to see blueprint integration that our gerrit does | 20:34 |
| mtaylor | jeblair: yeah - that's the argument | 20:34 |
| mtaylor | jeblair: perhaps patch submitted pops it to "in Progress" if it's not already there? | 20:35 |
| openstackgerrit | Trey Morris proposed a change to openstack/nova: moved floating ip db access and sanity checking from network api into network manager added floating ip get by fixed address added fixed_ip_get moved floating ip testing from osapi into the network tests where they belong https://review.openstack.org/628 | 20:35 |
| jeblair | mtaylor: if we did that, that would be my recommendation too. i'm not sure how much bugspam people want from gerrit. | 20:35 |
| Daviey | mtaylor: Others might not agree, but it's nice to be able to go to a bug and see that there is a branch in progress | 20:36 |
| jeblair | mtaylor: (hopefully the bug is _already_ set to in-progress by the developer, and gerrit would only effectively be leaving a comment) | 20:36 |
| Daviey | jeblair: you can be selective in the bug mail you get... :) | 20:36 |
| mtaylor | yes. /me gets almost no bug mail | 20:37 |
| * Daviey rarely sets in progress for any bugs. | 20:37 | |
| Daviey | or triaged | 20:37 |
| Daviey | New -> Confirmed -> Fix* | 20:37 |
| mtaylor | yes. this is quite commonly my process too | 20:37 |
| mtaylor | well - and I usually hope that code tools are setting the Fix* for me | 20:38 |
| openstackgerrit | Matt Dietz proposed a change to openstack/nova: Adds disk config https://review.openstack.org/629 | 20:38 |
| jeblair | Daviey: want to file a bug on openstack-ci requesting the in-progress notice? | 20:39 |
| openstackgerrit | Brian Waldon proposed a change to openstack/nova: Fixing bug 857712 https://review.openstack.org/630 | 20:40 |
| uvirtbot | Launchpad bug 857712 in nova "Compute API casting minram None to int fails" [High,In progress] https://launchpad.net/bugs/857712 | 20:40 |
| vishy | comstud, blamar, bcwaldon: bug 857714 | 20:40 |
| uvirtbot | Launchpad bug 857714 in nova "sqlalchemy replies with ResourceClosedError in case of concurrent allocations of IP addresses or volume creations" [Undecided,New] https://launchpad.net/bugs/857714 | 20:40 |
| vishy | that is annoying | 20:40 |
| bcwaldon | vishy: I bet it is :) | 20:40 |
| mtaylor | vishy: http://groups.google.com/group/repo-discuss/browse_thread/thread/e6846b6bfb4b28c0 <--- looks like folks are working on ability to have gerrit work with patchsets and not just changes in a sensible manner | 20:40 |
| *** lts has quit IRC | 20:41 | |
| blamar | vishy: Yeah :( sqlalchemy + eventlet really don't seem to like each other | 20:41 |
| comstud | hrm | 20:42 |
| vishy | mtaylor: intresting | 20:42 |
| markmc | bcwaldon, I was about to propose a fix for 857712 ... have you one in progress too? | 20:43 |
| bcwaldon | markmc: yeah, its in gerrit | 20:44 |
| bcwaldon | markmc: that's why I assigned the bug to me :) | 20:44 |
| markmc | bcwaldon, k :) | 20:44 |
| Daviey | jeblair: ok | 20:44 |
| openstackgerrit | Scott Moser proposed a change to openstack/nova: put fully qualified domain name in 'local-hostname' of metadata (bug 854614) https://review.openstack.org/631 | 20:45 |
| uvirtbot | Launchpad bug 854614 in nova "metadata service local-hostname is not fqdn" [Medium,Confirmed] https://launchpad.net/bugs/854614 | 20:45 |
| openstackgerrit | Scott Moser proposed a change to openstack/nova: put fully qualified domain name in 'local-hostname' of metadata (bug 854614) https://review.openstack.org/631 | 20:45 |
| cp16net | bcwaldon: maybe you can answer this... why does the v1.1 api require a new XMLSerializer for web service calls like flavors now? I have noticed that some of my add on calls have no XML attributes any more everything is an element. | 20:47 |
| cp16net | can you shed some light? | 20:47 |
| bcwaldon | cp16net: the default serializer will encode dict key/values into entities like that if they aren't found in the 'metadata' dict provided in serializer instantiation | 20:47 |
| bcwaldon | cp16net: you essentially need to provide a list of keys to encode to attributes | 20:48 |
| bcwaldon | cp16net: does that make sense? | 20:48 |
| cp16net | bcwaldon: yeah our api has a metadata dict that describes the object how it should look and since our last rebase it looks like things changed | 20:49 |
| bcwaldon | cp16net: what appears to have changed? | 20:49 |
| bcwaldon | cp16net: specifically the flavors serialization? | 20:49 |
| cp16net | bcwaldon: all the values that are suppose to be attributes have become elements of the parent element in XML | 20:49 |
| bcwaldon | cp16net: in *all* xml entities returned by the api? | 20:50 |
| cp16net | bcwaldon: yeah no attributes existed in the xml any more other than xmlns | 20:50 |
| bcwaldon | cp16net: can you show me the request you made and the output you are seeing? | 20:51 |
| bcwaldon | cp16net: paste.openstack.org | 20:51 |
| cp16net | maybe something in the metadata object changed that we send to the XMLDictSerializer | 20:51 |
| bcwaldon | cp16net: I'm sorry I don't understand the scope of the problem. Is this a custom controller? | 20:51 |
| cp16net | yes | 20:51 |
| bcwaldon | cp16net: ok, can you show me the code snippet that instantiates the serializer? | 20:52 |
| cp16net | http://paste.openstack.org/show/2552/ | 20:52 |
| openstackgerrit | Anne Gentle proposed a change to openstack/openstack-manuals: Fixes nova-manage network create label command and removes nova-core/release PPA reference https://review.openstack.org/632 | 20:52 |
| bcwaldon | cp16net: hmm, looks like a problem with v1.0 flavors xml serialization | 20:54 |
| bcwaldon | cp16net: I can reproduce it in my env | 20:54 |
| bcwaldon | cp16net: can you file a bug, or would you like me to? | 20:54 |
| cp16net | hmm i'd like to try to file it | 20:54 |
| cp16net | it will be my first bug :) | 20:54 |
| bcwaldon | cp16net: have at it :) | 20:54 |
| jk0 | how do you tell if the other reviewers are nova-core in gerrit? (without already knowing them obviously) | 20:55 |
| bcwaldon | jk0: unforunately, I don't think there is a way | 20:55 |
| jk0 | :( | 20:55 |
| cp16net | bcwaldon: yeah so the 1.0 is messed up but 1.1 worked | 20:55 |
| bcwaldon | cp16net: yep, the serializers are set up independently | 20:55 |
| cp16net | bcwaldon: why would there be separate serializers for each tho? | 20:56 |
| bcwaldon | cp16net: 1.0 and 1.1 are actually major versions (while the version numbers themselves are only minor diferences) | 20:56 |
| bcwaldon | cp16net: so we have different representations depending on the version | 20:57 |
| bcwaldon | cp16net: we moved away from a generic serializer when we discovered it would be too painful to make it cover *all* the cases we had | 20:57 |
| *** wwkeyboard has quit IRC | 20:57 | |
| cp16net | bcwaldon: ahh yeah booo to xml with python | 20:58 |
| bcwaldon | cp16net: yep, hopefully we will get rid of xml in v2.0 of the api | 20:58 |
| bcwaldon | cp16net: we'll see ;) | 20:58 |
| *** markmc has quit IRC | 20:58 | |
| cp16net | bcwaldon: hah doubtful... | 20:58 |
| openstackgerrit | Scott Moser proposed a change to openstack/nova: put fully qualified domain name in local-hostname https://review.openstack.org/631 | 21:00 |
| *** wwkeyboard has joined #openstack-dev | 21:00 | |
| openstackgerrit | Brian Lamar proposed a change to openstack/glance: Do not allow min_ram or min_disk properties to be NULL and if they are None, make sure to default to 0. Fixes bug 857711 https://review.openstack.org/633 | 21:00 |
| uvirtbot | Launchpad bug 857711 in glance "min_ram and min_disk shouldn't ever be NULL" [Medium,In progress] https://launchpad.net/bugs/857711 | 21:00 |
| smoser | ok. stupid question. | 21:00 |
| smoser | in git noew, i do 'git commit -a --amend' and then 'git review' | 21:01 |
| bcwaldon | smoser: yep | 21:01 |
| smoser | after hte initial reivew, it showed me a url to the review | 21:01 |
| *** bsza has quit IRC | 21:01 | |
| smoser | but after that, say i forgot... | 21:01 |
| smoser | (just pretending, of course i remember all such things) | 21:01 |
| smoser | how would i find that url again ? | 21:01 |
| smoser | i'm hoping to do so from cmdline i realize i could probably go to gerrit and look | 21:01 |
| bcwaldon | go to review.openstack.org | 21:02 |
| bcwaldon | smoser: yep, thats all I konw | 21:02 |
| openstackgerrit | Brian Lamar proposed a change to openstack/glance: Do not allow min_ram or min_disk properties to be NULL and if they are None, make sure to default to 0. Fixes bug 857711 https://review.openstack.org/627 | 21:04 |
| uvirtbot | Launchpad bug 857711 in glance "min_ram and min_disk shouldn't ever be NULL" [Medium,In progress] https://launchpad.net/bugs/857711 | 21:04 |
| jeblair | smoser: check out the command line tools: https://review.openstack.org/Documentation/cmd-index.html | 21:04 |
| jeblair | smoser: and https://review.openstack.org/Documentation/cmd-query.html | 21:04 |
| smoser | thank you. | 21:05 |
| jeblair | smoser: i've set up an ssh alias, so I can type things like "ssh review gerrit query 'owner:corvus'" | 21:05 |
| jeblair | there's json output options too, so very scriptable. | 21:05 |
| *** joesavak has quit IRC | 21:15 | |
| openstackgerrit | Verification of a change to openstack/glance failed: Do not allow min_ram or min_disk properties to be NULL and if they are None, make sure to default to 0. Fixes bug 857711 https://review.openstack.org/627 | 21:20 |
| uvirtbot | Launchpad bug 857711 in glance "min_ram and min_disk shouldn't ever be NULL" [Medium,In progress] https://launchpad.net/bugs/857711 | 21:20 |
| mtaylor | haha. "AssertionError: True is not false" | 21:21 |
| bcwaldon | mtaylor: real useful ;) | 21:21 |
| mtaylor | yup | 21:21 |
| mtaylor | although I do agre | 21:22 |
| mtaylor | True, is not, in fact, false | 21:22 |
| openstackgerrit | A change was merged to openstack/glance: Do not allow min_ram or min_disk properties to be NULL and if they are None, make sure to default to 0. Fixes bug 857711 https://review.openstack.org/627 | 21:22 |
| uvirtbot | Launchpad bug 857711 in glance "min_ram and min_disk shouldn't ever be NULL" [Medium,In progress] https://launchpad.net/bugs/857711 | 21:22 |
| *** AhmedSoliman has quit IRC | 21:24 | |
| dolphm | (regarding the openstack summit..) is there a particular airline/plane to select for guaranteed in-flight power? | 21:25 |
| openstackgerrit | Verification of a change to openstack/nova failed: * Rework osapi to use network API not FK backref * Fixes lp854585 https://review.openstack.org/618 | 21:26 |
| bcwaldon | mtaylor: I think we need a more robust fix for this authors test: https://jenkins.openstack.org/job/nova/121534/console | 21:28 |
| mtaylor | bcwaldon: HAHAHAHAHAHA | 21:29 |
| openstackgerrit | Jay Pipes proposed a change to openstack/glance: Fixes LP Bug #850685 https://review.openstack.org/634 | 21:30 |
| uvirtbot | Launchpad bug 850685 in glance "Glance client not properly catching HTTP 300 Multiple Choice" [Medium,In progress] https://launchpad.net/bugs/850685 | 21:30 |
| mtaylor | bcwaldon: yes. yes I think so. | 21:30 |
| mtaylor | also, why is that showing up at jenkins@nova-1. bother | 21:30 |
| mtaylor | oh - it's because of the local merge-before-test. gotit | 21:31 |
| rmk | I am still admiring the live block migration. | 21:31 |
| rmk | Too freaking cool. | 21:31 |
| vishy | rmk: all working great after the fix? | 21:33 |
| mtaylor | bcwaldon: I'm trying a config setting on jenkins - so I retriggered that job | 21:33 |
| rmk | vishy: Yes perfect, thanks for pointing me at it | 21:33 |
| bcwaldon | mtaylor: kk | 21:33 |
| rmk | vishy: Daviey confirmed he had issues before the patch also | 21:33 |
| bcwaldon | mtaylor: actually, looks like jkoelker pushed again | 21:34 |
| openstackgerrit | A change was merged to openstack/nova: Fixing bug 857712 https://review.openstack.org/630 | 21:34 |
| uvirtbot | Launchpad bug 857712 in nova "Compute API casting minram None to int fails" [High,In progress] https://launchpad.net/bugs/857712 | 21:34 |
| bcwaldon | mtaylor: can you kill that job? | 21:35 |
| mtaylor | bcwaldon: yup | 21:35 |
| openstackgerrit | Verification of a change to openstack/nova failed: * Rework osapi to use network API not FK backref * Fixes lp854585 https://review.openstack.org/618 | 21:35 |
| bcwaldon | mtaylor: okay, should be good | 21:36 |
| bcwaldon | mtaylor: just a trunk merge | 21:36 |
| bcwaldon | mtaylor: the diff for the new patchset just looked odd | 21:36 |
| openstackgerrit | Monty Taylor proposed a change to openstack/nova: Made jenkins email pruning more resilient. https://review.openstack.org/635 | 21:38 |
| mtaylor | bcwaldon: how's that look? | 21:38 |
| cp16net | bcwaldon: thanks for your help! | 21:38 |
| bcwaldon | bcwaldon: you're very welcome, do you want someone to address that bug, or are you going to do it | 21:38 |
| openstackjenkins | Project nova-docs build #1,416: SUCCESS in 3 min 18 sec: https://jenkins.openstack.org/job/nova-docs/1416/ | 21:39 |
| openstackjenkins | brian.waldon: Fixing bug 857712 | 21:39 |
| bcwaldon | ha, cp16net ^ | 21:39 |
| uvirtbot | Launchpad bug 857712 in nova "Compute API casting minram None to int fails" [High,In progress] https://launchpad.net/bugs/857712 | 21:39 |
| bcwaldon | mtaylor: looks good | 21:39 |
| bcwaldon | mtaylor: just have to be careful with email address allocation now | 21:39 |
| bcwaldon | mtaylor: don't give someone a *jenkins@openstack.org email | 21:39 |
| cp16net | bcwaldon: not sure if i will be able to get around to it very soon | 21:40 |
| mtaylor | bcwaldon: I will try my best not to | 21:40 |
| bcwaldon | cp16net: okay, we can take care of it for you | 21:40 |
| bcwaldon | cp16net: just didn't want to steal it | 21:40 |
| cp16net | bcwaldon: well i'd like to get on the authors some time :-) | 21:40 |
| bcwaldon | cp16net: okay, it's a v1.0 bug so it isn't top of the list | 21:40 |
| bcwaldon | cp16net: just assign it to yourself | 21:41 |
| cp16net | bcwaldon: alright sounds good have a good weekend. | 21:41 |
| bcwaldon | cp16net: yep, you too | 21:41 |
| *** cp16net has quit IRC | 21:41 | |
| bcwaldon | mtaylor: you want me to send in your branch? | 21:41 |
| mtaylor | bcwaldon: yeah | 21:42 |
| *** chomping has quit IRC | 21:43 | |
| bcwaldon | mtaylor: on its way in | 21:43 |
| mtaylor | bcwaldon: awesome | 21:43 |
| mtaylor | I'm porting the change in to glance as well... | 21:43 |
| bcwaldon | mtaylor: we can send in koelker's branch afterwards | 21:43 |
| mtaylor | ++ | 21:43 |
| bcwaldon | mtaylor: thanks, I was going to do it later but you go right ahead | 21:43 |
| bcwaldon | mtaylor: can you just replace the whole authors test? | 21:43 |
| mtaylor | yup | 21:44 |
| mtaylor | in fact, I did | 21:44 |
| bcwaldon | kk, i'll go delete my old review | 21:44 |
| openstackgerrit | Monty Taylor proposed a change to openstack/glance: Port Authors test to git. https://review.openstack.org/636 | 21:44 |
| openstackgerrit | Verification of a change to openstack/glance failed: Fixes LP Bug #824794 https://review.openstack.org/626 | 21:45 |
| uvirtbot | Launchpad bug 824794 in glance "Tables are generated outside of migration process" [Low,In progress] https://launchpad.net/bugs/824794 | 21:45 |
| mtaylor | oh bother. I missed a chunk | 21:45 |
| *** chomping has joined #openstack-dev | 21:45 | |
| bcwaldon | mtaylor: your port to git doesn't work :( | 21:46 |
| bcwaldon | mtaylor: removed everyone from Authors and it still passes | 21:46 |
| mtaylor | bcwaldon: yeah - I did something done | 21:46 |
| mtaylor | dumb | 21:46 |
| bcwaldon | mtaylor: gotta head out, I'll get on later and get caught up with this | 21:47 |
| mtaylor | k | 21:47 |
| *** bcwaldon has quit IRC | 21:48 | |
| adam_g | vishy: were there specific changes to recent dnsmasq versions that required http://bazaar.launchpad.net/~nova-core/nova/github/revision/1607 ? | 21:50 |
| vishy | adam_g: yes | 21:50 |
| vishy | adam_g: well there is a bug, and the workaround requires that | 21:51 |
| vishy | adam_g: why? | 21:51 |
| mtaylor | how do I run a specific unit test in glance? | 21:53 |
| mtaylor | like, if I want to run glance.tests.unit.test_misc.AuthorsTestCase ... what do I pass to run_test.sh -N ? | 21:53 |
| mtaylor | nm. got it | 21:53 |
| vishy | if it is like nova you do that only replace the last . with a : | 21:53 |
| openstackgerrit | Monty Taylor proposed a change to openstack/glance: Port Authors test to git. https://review.openstack.org/636 | 21:55 |
| openstackgerrit | A change was merged to openstack/nova: Made jenkins email pruning more resilient. https://review.openstack.org/635 | 21:55 |
| *** rnirmal has quit IRC | 22:02 | |
| adam_g | vishy: just curious, i had never run into any issues before | 22:03 |
| openstackjenkins | Project nova-docs build #1,417: SUCCESS in 3 min 5 sec: https://jenkins.openstack.org/job/nova-docs/1417/ | 22:03 |
| openstackjenkins | Monty Taylor: Made jenkins email pruning more resilient. | 22:03 |
| vishy | adam_g: there is apparently an issue with --bind_interfaces, libvirt and ipv6 | 22:04 |
| mtaylor | oh shit. libvirt | 22:04 |
| vishy | * --bind_interface=eth0 | 22:04 |
| vishy | or whatever | 22:04 |
| openstackgerrit | Dave Walker proposed a change to openstack/nova: contrib/nova.sh: Updated to latest 'upstream' commit:6a8433a resolves bug 857209 https://review.openstack.org/637 | 22:05 |
| uvirtbot | Launchpad bug 857209 in nova "contrib/nova.sh is broken, due to syntax changes" [Undecided,New] https://launchpad.net/bugs/857209 | 22:05 |
| rmk | Damn Cactus dashboard is coming back with no projects defined for me | 22:05 |
| rmk | No errors that I can see in the logs | 22:05 |
| adam_g | vishy: ah thanks | 22:06 |
| Daviey | bah, is it possible to rm a gerrit review which was posted by accident? | 22:06 |
| vishy | adam_g: it tries to bind the ipv6 interface and goes boom | 22:06 |
| vishy | adam_g: so we had to switch back to --listen_address | 22:06 |
| vishy | adam_g: and listen_address only works when it is the first address on the interface | 22:07 |
| mtaylor | Daviey: yes | 22:07 |
| mtaylor | Daviey: you can click Abandon on the review - or, if you're going to come back to it, you can just leave it and push an amended change later | 22:07 |
| vishy | adam_g: hence that fix (which btw in early diablo, it did something similar) | 22:07 |
| Daviey | mtaylor: it was pushed as a dupe... | 22:07 |
| vishy | before we added --bind_interface | 22:07 |
| Daviey | i've abandoned it | 22:07 |
| mtaylor | cool | 22:08 |
| mtaylor | vishy: http://nova.openstack.org/tarballs/libvirtdebs.tgz | 22:10 |
| mtaylor | hrm. I suppose I could just upload something to a specific ppa - might make it easier for people to test those | 22:10 |
| * mtaylor goes to do that right now | 22:10 | |
| vishy | awesome | 22:10 |
| Daviey | mtaylor: perhaps i'm being daft, but it's not clear to me how to switch to a pristine topic for a new feature? | 22:10 |
| Daviey | mtaylor: as in using the same git checkout with multiple branches. | 22:11 |
| mtaylor | Daviey: git checkout master ; git pull --ff-only ; git checkout -b topic/my-topic-name | 22:11 |
| mtaylor | Daviey: checkout is how you switch branches - checkout -b tells it to make a branch of that name if it doesn't exist and then change to it | 22:12 |
| mtaylor | Daviey: making a new branch is always based off of the branch you're in - thus the change to master first | 22:12 |
| Daviey | mtaylor: yeah, i did git checkout master ; git checkout -b something-new | 22:12 |
| mtaylor | cool. | 22:12 |
| Daviey | but that oddly didn't work | 22:12 |
| mtaylor | tell me what didn't work | 22:13 |
| vishy | Daviey: does your master has other commits in it? | 22:13 |
| Daviey | vishy: That might have been it.. i'm tired, probably did that. | 22:13 |
| mtaylor | Daviey: try this ... | 22:13 |
| mtaylor | Daviey: git checkout master ; git checkout -b save-master ; git checkout master ; git reset --hard origin/master | 22:14 |
| vishy | git checkout master; git reset --hard origin/master ??? | 22:14 |
| Daviey | mtaylor: I'll probably leave it for when i'm less tired now :/ | 22:14 |
| mtaylor | Daviey: that should get anything you've accidentally on master into another branch so you don't lose track of it | 22:14 |
| mtaylor | Daviey: and gets your master back to being a clean copy of origin/master | 22:14 |
| Daviey | mtaylor: thanks, i'll grep for that later | 22:14 |
| mtaylor | Daviey: cool | 22:14 |
| mtaylor | Daviey: I'm as amazed as anyone, but I seem to have gotten to the point where I grok all of the git foo now - so please feel free to bug me any time if it doesn't make sense | 22:15 |
| Daviey | wilco, thanks. | 22:16 |
| jeblair | mtaylor: _all_ of the git-fu? | 22:16 |
| mtaylor | jeblair: yes. all of it | 22:17 |
| mtaylor | jeblair: I understand and have memorized every flag | 22:17 |
| Daviey | I have fallen in love with git bisect run | 22:17 |
| mtaylor | ++ | 22:17 |
| Daviey | I want to elope with it | 22:18 |
| mtaylor | Daviey: something tells me that's illegal where you live | 22:18 |
| Daviey | :) | 22:20 |
| *** benrodrigue has quit IRC | 22:22 | |
| mtaylor | vishy: I'm uploading those libvirt packages to https://launchpad.net/~mordred/+archive/libvirt as well | 22:23 |
| *** elastic_dog has quit IRC | 22:26 | |
| vishy | sweet | 22:28 |
| *** code_franco has quit IRC | 22:29 | |
| vishy | mtaylor: I'm going to try to do lxc + nova in cloudservers | 22:31 |
| vishy | on demand nova clusters for training! | 22:32 |
| mtaylor | vishy: neat! | 22:38 |
| *** wwkeyboard has quit IRC | 22:40 | |
| openstackgerrit | Adam Gandelman proposed a change to openstack/nova: flags.py: Use '--optional_flagfile' to specify a flagfile that may not exist https://review.openstack.org/638 | 22:43 |
| rmk | Any idea what would cause the project list to be blank with the cactus dashboard against diablo's nova? | 22:43 |
| vishy | rmk: are you using deprecated auth? | 22:56 |
| * Daviey wonders how well hosts_up() scales, seems expensive for a large cloud. | 22:57 | |
| rmk | Well I figured it out | 22:59 |
| rmk | Yeah I am | 22:59 |
| rmk | dashboard username needs to match the nova username | 23:00 |
| vishy | rmk: cool | 23:01 |
| vishy | does cactus dashboard actually still work? | 23:02 |
| rmk | I'm just reluctant to use keystone until it's more documented | 23:02 |
| vishy | that is kind of impressive | 23:02 |
| rmk | vishy: It seems to :) | 23:02 |
| vishy | rmk: I'm relected to use keystone until it works... | 23:02 |
| vishy | * reluctant | 23:02 |
| dolphm | :) | 23:02 |
| rmk | there's that too | 23:02 |
| rmk | dolphm: Can you type faster? | 23:03 |
| rmk | :) | 23:03 |
| dolphm | i personally wouldn't use it until the API was stationary for at least a couple days in a row... | 23:03 |
| *** dragondm has quit IRC | 23:03 | |
| rmk | yeah dep auth is fine for now | 23:03 |
| rmk | for me at least | 23:03 |
| rmk | nova-vncproxy package never got fixed | 23:03 |
| rmk | still trying to bind to 843 as the nova user | 23:04 |
| rmk | should I just bug it? | 23:04 |
| vishy | rmk: hmm, yes please | 23:11 |
| vishy | it is a packaging bug | 23:11 |
| rmk | yep | 23:11 |
| *** jeffjapan has joined #openstack-dev | 23:17 | |
| *** rnorwood has quit IRC | 23:31 | |
| *** stanchan has quit IRC | 23:41 | |
| *** errr has quit IRC | 23:43 | |
| *** errr has joined #openstack-dev | 23:43 | |
| rmk | Do the compute nodes care about vncproxy_url | 23:52 |
| rmk | ? | 23:52 |
| *** hbetts has joined #openstack-dev | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!