*** mnour1 has joined #openstack-dev | 00:05 | |
*** mnour has quit IRC | 00:05 | |
*** mnour has joined #openstack-dev | 00:33 | |
*** mnour1 has quit IRC | 00:36 | |
*** thickskin has quit IRC | 00:47 | |
*** mnour has quit IRC | 00:50 | |
*** thickskin has joined #openstack-dev | 00:59 | |
*** rods has quit IRC | 01:03 | |
*** redbo has quit IRC | 01:23 | |
*** redbo has joined #openstack-dev | 01:23 | |
*** ChanServ sets mode: +v redbo | 01:23 | |
*** rohitju has joined #openstack-dev | 02:16 | |
*** alekibango has quit IRC | 02:16 | |
*** jkoelker_ is now known as jkoelker | 02:17 | |
*** tsuzuki_ has joined #openstack-dev | 02:17 | |
*** lts has joined #openstack-dev | 02:22 | |
*** mdomsch_ has joined #openstack-dev | 02:35 | |
*** lts has quit IRC | 03:03 | |
*** mattray has joined #openstack-dev | 03:32 | |
*** mattray has quit IRC | 03:45 | |
*** mdomsch_ has quit IRC | 03:46 | |
*** martine has quit IRC | 04:25 | |
*** tsuzuki_ has quit IRC | 05:49 | |
*** tsuzuki_ has joined #openstack-dev | 05:50 | |
*** rohitju has quit IRC | 08:21 | |
*** rohitju has joined #openstack-dev | 08:33 | |
*** AhmedSoliman has joined #openstack-dev | 08:36 | |
*** chomping has quit IRC | 08:40 | |
*** uvirtbot` is now known as uvirtbot | 08:44 | |
*** mnour has joined #openstack-dev | 08:50 | |
*** rohitju has quit IRC | 09:01 | |
openstackjenkins | Project nova build #1,306: SUCCESS in 3 min 31 sec: https://jenkins.openstack.org/job/nova/1306/ | 09:10 |
---|---|---|
openstackjenkins | Tarmac: Adds assertIn and assertNotIn support to TestCase for compatibility with python 2.6 | 09:10 |
openstackjenkins | This is a very minimal addition which doesn't require unittest2. | 09:10 |
*** zigo has joined #openstack-dev | 09:44 | |
*** zigo has quit IRC | 10:10 | |
*** zigo has joined #openstack-dev | 10:10 | |
*** rods has joined #openstack-dev | 10:28 | |
*** jaypipes has quit IRC | 11:16 | |
*** zigo has quit IRC | 11:17 | |
*** zigo has joined #openstack-dev | 11:17 | |
*** martine has joined #openstack-dev | 11:21 | |
*** BK_man has joined #openstack-dev | 11:37 | |
*** martine has quit IRC | 11:47 | |
*** martine has joined #openstack-dev | 11:52 | |
*** adiantum has joined #openstack-dev | 11:55 | |
*** mfer has joined #openstack-dev | 12:10 | |
*** lts has joined #openstack-dev | 12:26 | |
*** bsza has joined #openstack-dev | 12:27 | |
*** mdomsch has quit IRC | 12:32 | |
*** markvoelker has joined #openstack-dev | 12:37 | |
*** markmc has joined #openstack-dev | 12:41 | |
openstackjenkins | Project nova build #1,307: SUCCESS in 3 min 45 sec: https://jenkins.openstack.org/job/nova/1307/ | 12:50 |
openstackjenkins | * Tarmac: Fixes lp:813864 by removing the broken assert. The assert was a check for isinstance of 'int' that should have been 'long'. But it doesn't appear this assert really belongs, anyway. | 12:50 |
openstackjenkins | * Tarmac: Adds assertIn and assertNotIn support to TestCase for compatibility with python 2.6 | 12:50 |
openstackjenkins | This is a very minimal addition which doesn't require unittest2. | 12:50 |
openstackjenkins | * Tarmac: Bug #835952: pep8 failures do not cause the tests to fail | 12:50 |
uvirtbot | Launchpad bug 835952 in nova "pep8 failures do not cause the tests to fail" [Undecided,Fix committed] https://launchpad.net/bugs/835952 | 12:50 |
openstackjenkins | Add set -eu to run_tests.sh. This will cause it to fail whenever anything | 12:50 |
openstackjenkins | goes wrong, which is exactly what we want in a test script. | 12:50 |
openstackjenkins | To do this, I had to remove the use of the "let" keyword, which has a bizarre | 12:50 |
openstackjenkins | exit status in bash. | 12:50 |
openstackjenkins | I also removed the "|| exit" after run_tests, which means that this script | 12:50 |
openstackjenkins | will now exit with status 1, not status 0, if run_tests fails. | 12:50 |
openstackjenkins | * Tarmac: Bug #835964: pep8 violations in IPv6 code | 12:50 |
uvirtbot | Launchpad bug 835964 in nova "pep8 violations in IPv6 code" [Undecided,Fix committed] https://launchpad.net/bugs/835964 | 12:50 |
openstackjenkins | Fix pep8 violations. | 12:50 |
openstackjenkins | * Tarmac: Virtual Storage Array (VSA) feature. | 12:50 |
openstackjenkins | - new Virtual Storage Array (VSA) objects / OS API extensions / APIs / CLIs | 12:50 |
openstackjenkins | - new schedulers for selecting nodes with particular volume capabilities | 12:50 |
openstackjenkins | - new special volume driver | 12:50 |
openstackjenkins | - report volume capabilities | 12:50 |
openstackjenkins | - some fixes for volume types | 12:50 |
openstackjenkins | * Tarmac: changes a few double quotes to be single, as the rest in the vicinity are | 12:50 |
openstackjenkins | * Tarmac: Update compute API and manager so that the image_ref is set before spawning the rebuilt instance. Fixes issue where rebuild didn't actually change the image_id. | 12:50 |
*** joesavak has joined #openstack-dev | 12:52 | |
*** jsavak has joined #openstack-dev | 12:56 | |
*** joesavak has quit IRC | 12:59 | |
*** doude has joined #openstack-dev | 13:06 | |
*** kbringard has joined #openstack-dev | 13:07 | |
*** kbringard1 has joined #openstack-dev | 13:09 | |
*** kbringard has quit IRC | 13:09 | |
*** zul has quit IRC | 13:14 | |
*** zul has joined #openstack-dev | 13:15 | |
*** mattray has joined #openstack-dev | 13:16 | |
*** Guest49398 is now known as Glace | 13:24 | |
*** Glace is now known as Guest16184 | 13:25 | |
*** Guest16184 is now known as Glacee | 13:26 | |
*** bcwaldon has joined #openstack-dev | 13:44 | |
*** cp16net has joined #openstack-dev | 14:01 | |
*** nmistry has quit IRC | 14:04 | |
*** amccabe has joined #openstack-dev | 14:14 | |
*** martine has quit IRC | 14:23 | |
*** code_franco has joined #openstack-dev | 14:23 | |
*** martine_ has joined #openstack-dev | 14:23 | |
*** zigo has quit IRC | 14:25 | |
*** zigo has joined #openstack-dev | 14:25 | |
*** bcwaldon_ has joined #openstack-dev | 14:32 | |
*** rackerjoe has joined #openstack-dev | 14:35 | |
*** bcwaldon has quit IRC | 14:35 | |
*** mnour has quit IRC | 14:36 | |
*** rnirmal has joined #openstack-dev | 14:43 | |
*** mdomsch has joined #openstack-dev | 14:46 | |
openstackgerrit | Sandy Walsh proposed a change to openstack/keystone: starting on tests https://review.openstack.org/358 | 14:49 |
openstackgerrit | Sandy Walsh proposed a change to openstack/keystone: Get Service Catalog from token https://review.openstack.org/359 | 14:50 |
*** rackerjoe has quit IRC | 14:58 | |
*** bcwaldon_ has quit IRC | 15:02 | |
*** dragondm has joined #openstack-dev | 15:02 | |
*** bcwaldon has joined #openstack-dev | 15:02 | |
*** bcwaldon has quit IRC | 15:09 | |
*** heckj has joined #openstack-dev | 15:22 | |
*** kbringard1 is now known as kbringard | 15:25 | |
zykes- | what's the diff in routes.Mapper between connect & resource ? | 15:27 |
*** rnorwood has joined #openstack-dev | 15:33 | |
creiht | zykes-: https://routes.groovie.org/restful.html | 15:38 |
*** kbringard has quit IRC | 15:46 | |
*** kbringard has joined #openstack-dev | 15:46 | |
*** bsza has quit IRC | 15:51 | |
*** bsza has joined #openstack-dev | 15:52 | |
openstackgerrit | Kevin L. Mitchell proposed a change to openstack/glance: Add functional tests https://review.openstack.org/333 | 15:57 |
*** mtaylor has quit IRC | 16:02 | |
*** mtaylor has joined #openstack-dev | 16:03 | |
*** mtaylor has joined #openstack-dev | 16:03 | |
*** ChanServ sets mode: +v mtaylor | 16:03 | |
openstackgerrit | Kevin L. Mitchell proposed a change to openstack/glance: Add functional tests https://review.openstack.org/333 | 16:09 |
*** chomping has joined #openstack-dev | 16:11 | |
*** AhmedSoliman has quit IRC | 16:11 | |
*** chomping_ has joined #openstack-dev | 16:13 | |
*** chomping has quit IRC | 16:15 | |
*** chomping_ is now known as chomping | 16:15 | |
*** bengrue has joined #openstack-dev | 16:17 | |
openstackgerrit | A change was merged to openstack/keystone: Adding guide for RAX-KSKEY-service extension. Adding guide for OS-KSEC2-service extension. https://review.openstack.org/355 | 16:36 |
openstackgerrit | A change was merged to openstack/keystone: Fix host/port split code in authenticate_ec2. Resolves an AttributeError: 'Ec2Credentials' object has no attribute 'partition' exception that can occur for EC2 auth validations. https://review.openstack.org/357 | 16:37 |
*** jdurgin has joined #openstack-dev | 16:39 | |
*** martine has joined #openstack-dev | 16:43 | |
openstackgerrit | Yogeshwar Srikrishnan proposed a change to openstack/keystone: Adding guides for groups extension. https://review.openstack.org/360 | 16:44 |
openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Get Service Catalog from token https://review.openstack.org/359 | 16:45 |
zykes- | creiht: still i don't get the diff on resource & controller | 16:49 |
zykes- | ehm, connect | 16:49 |
*** vladimir3p has joined #openstack-dev | 16:51 | |
*** med_out is now known as medberry | 16:51 | |
openstackgerrit | Yogeshwar Srikrishnan proposed a change to openstack/keystone: Adding guides for groups extension. https://review.openstack.org/360 | 16:56 |
openstackgerrit | Sandy Walsh proposed a change to openstack/keystone: Get Service Catalog from token https://review.openstack.org/359 | 16:58 |
openstackgerrit | A change was merged to openstack/keystone: Adding guides for groups extension. https://review.openstack.org/360 | 16:58 |
openstackjenkins | Project burrow build #36: SUCCESS in 13 sec: https://jenkins.openstack.org/job/burrow/36/ | 17:02 |
openstackjenkins | Tarmac: Added examples, bumped version. | 17:02 |
*** ohnoimdead has joined #openstack-dev | 17:02 | |
sandywalsh | what state do I put a launchpad bug in to reopen it? | 17:11 |
sandywalsh | back to "new"? | 17:11 |
sandywalsh | soren ttx mtaylor ^^ | 17:14 |
*** bcwaldon has joined #openstack-dev | 17:15 | |
bcwaldon | vishy: can you update this MP with your thoguhts -> https://code.launchpad.net/~klmitch/nova/lp832369/+merge/72964 | 17:16 |
openstackjenkins | Project nova build #1,308: SUCCESS in 3 min 38 sec: https://jenkins.openstack.org/job/nova/1308/ | 17:20 |
openstackjenkins | * Tarmac: In the XenAPI simulator, set VM.domid, when creating the instance initially, | 17:20 |
openstackjenkins | and when starting the VM. | 17:20 |
openstackjenkins | This shows up in the logs for Bug #831599, but this fix doesn't actually | 17:20 |
openstackjenkins | fix the hang. | 17:20 |
uvirtbot | Launchpad bug 831599 in nova "Tests hang frequently in XenAPIVMTestCase.test_parallel_builds" [Medium,Confirmed] https://launchpad.net/bugs/831599 | 17:20 |
openstackjenkins | * Tarmac: Fixes lp:813864 by removing the broken assert. The assert was a check for isinstance of 'int' that should have been 'long'. But it doesn't appear this assert really belongs, anyway. | 17:20 |
bcwaldon | _cerberus_: can you update your review of this branch -> https://code.launchpad.net/~jason-koelker/nova/lp819477/+merge/71930 | 17:25 |
*** novas0x2a|laptop has joined #openstack-dev | 17:30 | |
*** negronjl has quit IRC | 17:42 | |
_cerberus_ | bcwaldon: maybe. What's it worth to you? | 17:47 |
bcwaldon | _cerberus_: a hug | 17:47 |
_cerberus_ | Sold | 17:48 |
*** negronjl has joined #openstack-dev | 17:49 | |
sandywalsh | *212 | 17:49 |
creiht | zykes-: connect is the base unit of mapping a url path to a python callable | 17:51 |
creiht | resource basically makes a lot of pre-defined connect statements | 17:51 |
sandywalsh | ant, just put a merge prop in to give a little more logging if that notification exception crops up again. | 17:51 |
*** mszilagyi has joined #openstack-dev | 18:04 | |
*** bcwaldon has quit IRC | 18:06 | |
*** bcwaldon has joined #openstack-dev | 18:09 | |
zykes- | what's the groups stuff in keystone ? | 18:13 |
zykes- | something rackspace specific ? | 18:13 |
dolphm | zykes-: more or less... it's being planned as an extension only | 18:14 |
jsavak | zykes - yes - it's an extension to support rackspace within keystone. | 18:14 |
jsavak | zykes - included in the open because other contributors are interested in it | 18:14 |
zykes- | what's it used for in diff to tenants ? | 18:15 |
vishy | bcwaldon: done | 18:17 |
bcwaldon | vishy: thanks | 18:17 |
vishy | sandywalsh: you can set it back to in progress or triaged i suppose | 18:17 |
sandywalsh | vishy, yeah, that's what I did ... thx | 18:18 |
jsavak | zykes - when a user auths, they'll get a list of groups that the user belongs to , roles that the user has, and service endpoints that the user has access to. Tenants are attributes to the endpoint showing what account/company that endpoint belongs to | 18:22 |
zykes- | what's the groups used for then ? | 18:23 |
*** zigo has quit IRC | 18:23 | |
*** martine has quit IRC | 18:26 | |
jsavak | zykes - i think it's an alternative for roles or enables a different way to manage roles. Ex: "Add Account" role may mean different things to the "Support" group than it does to the "Ops" group | 18:26 |
zykes- | hmm k | 18:27 |
zykes- | so basically just more auth stuff then | 18:27 |
jsavak | yup | 18:27 |
vishy | i find groups + roles confusing :) | 18:28 |
vishy | too many dimensions. Keep things flat imo | 18:29 |
jsavak | vishy - checking with ziad to see if i got that right. I could be, and often am, wrong. | 18:33 |
vishy | jsavak: I'm sure there are lots of existing constraints inside rs. I'm just saying in general I find it confusing to manage | 18:34 |
*** mdomsch has quit IRC | 18:39 | |
openstackjenkins | Project nova build #1,309: SUCCESS in 3 min 34 sec: https://jenkins.openstack.org/job/nova/1309/ | 18:40 |
openstackjenkins | Tarmac: Update the EC2 ToToken middleware to use eventlet.green.httplib instead of httplib2. Fixes issues where the JSON request body wasn't getting sent to Keystone. | 18:40 |
*** zaitcev has joined #openstack-dev | 18:44 | |
*** bcwaldon has quit IRC | 18:45 | |
*** bcwaldon has joined #openstack-dev | 18:47 | |
*** adiantum has quit IRC | 19:03 | |
soren | sandywalsh: Depends. Which bug? | 19:06 |
*** martine has joined #openstack-dev | 19:11 | |
*** martine_ has quit IRC | 19:15 | |
*** rackerjoe has joined #openstack-dev | 19:18 | |
*** rackerjoe has quit IRC | 19:19 | |
smoser | anyone know where/why bug 836759 ? | 19:22 |
uvirtbot | Launchpad bug 836759 in nova "nova does not grow disk images as it does partition images" [Medium,Triaged] https://launchpad.net/bugs/836759 | 19:22 |
smoser | i cant see how 'truncate -s' is not done for a disk image. | 19:23 |
*** martine_ has joined #openstack-dev | 19:23 | |
soren | smoser: I have a guess. | 19:24 |
soren | smoser: If you truncate -s a qcow image... What happens? | 19:24 |
smoser | well, not waht you want | 19:24 |
soren | Right. | 19:24 |
smoser | but i had asumed that it must be a raw image at that point | 19:24 |
smoser | i guess that would explain it though. | 19:25 |
*** dolphm has quit IRC | 19:25 | |
soren | It doesn't convert your qcow to raw, if that's what you mean. | 19:25 |
smoser | it would seem to me that it should. | 19:25 |
soren | If you upload a qcow2 image, that's what kvm ends up using. At least I'm reasonably sure it is. | 19:25 |
smoser | as a reasonable point of making things sane. | 19:25 |
smoser | i think you're right. | 19:25 |
soren | qcow2 could be fine. | 19:26 |
soren | The fact that it doesn't really notice if you're using Xen and qcow2+Xen won't work... That's a different story. | 19:26 |
smoser | it would seem that to be sane, a conversion should happen to raw at some point. | 19:30 |
smoser | so this verifies the other question i had... | 19:30 |
smoser | if i upload a compressed qcow, it will just 'qemu-img create -b <COMPRESED_QCOW>' | 19:31 |
smoser | which will mean all reads will go through uncompress | 19:31 |
smoser | soren, would you consider it reasonable if i patch _fetch_image in nova/virt/libvirt/connection.py to result in a raw image ? | 19:38 |
soren | Not really. | 19:39 |
soren | Why would you insist on a specific, hard-coded image type? | 19:39 |
*** bcwaldon has quit IRC | 19:40 | |
soren | smoser: ^ | 19:41 |
smoser | ewll, for simplicity. | 19:41 |
soren | smoser: If it's an image type the hypervisor can handle, why convert it? | 19:41 |
smoser | the other option is to make "extend" be able to extend correctly. | 19:42 |
soren | smoser: Yeah. It shouldn't use truncate to begin with. | 19:42 |
smoser | well, at some point things like 'truncate -s 1TB' are going to screw you. | 19:42 |
soren | smoser: It should use "qemu-img extend" | 19:43 |
soren | Or whatever it's called. | 19:43 |
smoser | for my case, it also needs convert | 19:43 |
soren | qemu-img resize | 19:43 |
soren | Why? | 19:43 |
smoser | because its compressed. | 19:43 |
smoser | and otherwise 3 instances will all do reads() that will to trhough decompress | 19:43 |
smoser | at some point you want to have reasonable backed images. i really think that having "raw" (possibly sparse) cached image is sane. | 19:44 |
soren | I think forcing a specific format is a poor idea. No matter which format. | 19:44 |
soren | Having it available as an option sounds great. | 19:45 |
soren | ..but forcing it for everyone.. Certainly not a change I'd approve of at this point in the cycle. | 19:45 |
*** martine has quit IRC | 19:46 | |
smoser | i cant really think of anything other than a test case that would want qcow images backed by a compressed qcow image. | 19:46 |
smoser | (personally, i think for anything other than a test, you dont want qcow backed images) | 19:46 |
*** markvoelker has quit IRC | 19:46 | |
soren | And that's a perfectly valid use case. | 19:47 |
*** bcwaldon has joined #openstack-dev | 19:47 | |
smoser | but... for you, soren, i would: | 19:47 |
soren | FWIW, Glance is supposed to grow conversion features eventually. | 19:48 |
soren | At that point, we could just ask glance for a specific format and it'd do some magic to give us that. | 19:48 |
smoser | that just pushes the ubck. | 19:48 |
smoser | buck | 19:48 |
smoser | and means you have to get a lot more data to glance to say "get me an image" | 19:48 |
*** heckj has quit IRC | 19:49 | |
smoser | never mind. you're right. | 19:49 |
smoser | but so: | 19:49 |
smoser | * add option for use-raw-backed-qcow images [default false] | 19:49 |
smoser | * add option for allow-compressed-backed-qcow-images [default false] | 19:49 |
smoser | does that sound reasonable? | 19:51 |
pvo | soren: can the libvirt network filters be used without libvirt managing instances? | 19:58 |
soren | pvo: The various spoofing protection things, no. | 19:59 |
soren | pvo: The other stuff, yes. | 19:59 |
soren | smoser: Can you elaborate on what each of those would do? Sorry, I really don't mean to be difficult, but I'm really not at my most useful right now :( | 20:00 |
pvo | soren: thanks. | 20:00 |
pvo | soren: would you see any reason why we couldn't use libvirt enable security groups on XenServer? In theory? | 20:01 |
pvo | I haven't tried yet, just wondering out loud. | 20:01 |
*** vladimir3p has quit IRC | 20:04 | |
soren | pvo: I don't know, really. | 20:04 |
smoser | i guess you dont need two flags. | 20:04 |
soren | pvo: Generally, if you can affect traffic to/from guests using iptables in your dom0, it should work. | 20:05 |
pvo | soren: ok, thats what I was thinking too. you've at least told me enough to start experimenting with it. : ) | 20:05 |
soren | pvo: I've never really used Xen enough to know about its networking model. | 20:05 |
soren | pvo: :) | 20:05 |
smoser | but basically one would modify the current behavior to always qemu-img convert -O raw <source>.img <target>.img (after checking that it wasnt raw) | 20:05 |
pvo | soren: thanks | 20:05 |
smoser | then secondly, special case the path where it is compressed qcow. | 20:06 |
*** cmagina has quit IRC | 20:10 | |
*** vladimir3p has joined #openstack-dev | 20:15 | |
*** markmc has quit IRC | 20:40 | |
openstackjenkins | Project swift build #312: SUCCESS in 35 sec: https://jenkins.openstack.org/job/swift/312/ | 20:47 |
openstackjenkins | Tarmac: deleting a database (account or container) now also clears the metadata | 20:47 |
*** mdomsch has joined #openstack-dev | 20:55 | |
*** bcwaldon has quit IRC | 21:12 | |
*** martine_ has quit IRC | 21:21 | |
*** jsavak has quit IRC | 21:21 | |
*** jsavak has joined #openstack-dev | 21:22 | |
*** jakedahn has joined #openstack-dev | 21:24 | |
*** mdomsch has quit IRC | 21:27 | |
*** Tushar has joined #openstack-dev | 21:29 | |
*** Tushar has quit IRC | 21:31 | |
chmouel | someone would have an objection if I propose a patch that s/project/tenant/ in python-novaclient? | 21:34 |
vladimir3p | vishy: ping | 21:37 |
*** jsavak has quit IRC | 21:40 | |
*** bengrue has quit IRC | 21:49 | |
*** cp16net has quit IRC | 21:51 | |
*** lts has quit IRC | 21:53 | |
*** jakedahn has quit IRC | 21:56 | |
vishy | vladimir3p: pong | 21:57 |
*** jakedahn has joined #openstack-dev | 21:57 | |
vladimir3p | vishy: Hi, looking at some very strange issue in our lab | 21:59 |
vladimir3p | vishy: trying to understand how thread-safe might be the code of execute() in nova/utils | 22:00 |
vishy | ok | 22:00 |
vladimir3p | vishy: in particular usage of PIPE in Popen | 22:00 |
vishy | thread safe? not at all | 22:00 |
vishy | although why would you be using multiple threads | 22:00 |
vladimir3p | :-) | 22:00 |
vishy | ? | 22:00 |
vladimir3p | what we are seeing is report capabilities call from periodic tasks trying to get current states | 22:01 |
vladimir3p | at the same time there is a call to create & export volume | 22:01 |
vladimir3p | and export fails even without reaching the actuall app | 22:01 |
vladimir3p | does periodic tasks & handling of new requests in manager executed in the same thread? | 22:02 |
vishy | everything is the same thread | 22:02 |
vishy | it uses greenlets | 22:02 |
vishy | so concurrency issues are generally external | 22:02 |
vishy | for example. Initiating a second call to an lvm command | 22:03 |
vishy | when one is already in process | 22:03 |
vishy | vladimir3p: if you can isolate which calls are conflicting you should be able to fix it by wrapping the offending section in a @utils.synchronized() | 22:04 |
vladimir3p | vishy: one sec, brb | 22:05 |
vladimir3p | vishy: I'm back. sorry. | 22:12 |
vladimir3p | vishy: let me understand how this single thread thing work ... | 22:12 |
*** kbringard has quit IRC | 22:12 | |
vladimir3p | vishy: for example when scheduler sends 2 requests to volume mgr to create 2 volumes | 22:12 |
vishy | ok | 22:13 |
vladimir3p | that I see in logs is... | 22:13 |
vladimir3p | some sort of intermixing of these cmds | 22:13 |
vladimir3p | I see create_volume for vol1 | 22:13 |
vladimir3p | after that create vol for vol2 | 22:13 |
vladimir3p | after that create export for vol1 | 22:13 |
vishy | right | 22:13 |
vishy | so the event loop calls execute | 22:13 |
vishy | and essentially that "thread" waits (it isn't a thread but just for understanding think about it that way) | 22:14 |
vladimir3p | yeah, it is right, but create volume and create export calls are calls to driver and executed from the same func | 22:14 |
vishy | but new requests come in and can go through the same process | 22:14 |
vishy | so you don't get two different greenlets executing the same python code concurrently | 22:15 |
vladimir3p | yes, this is how it supposed to be ... | 22:15 |
vishy | but external commands like execute can happen at the same time | 22:15 |
vladimir3p | one sec, let me 1st clarify re create volume & export | 22:15 |
vladimir3p | here what I see in logs ... let me copy/paste it ... | 22:16 |
vladimir3p | http://paste.openstack.org/show/2303/ | 22:16 |
vladimir3p | there are 2 volumes - volume-00000b9b & volume-00000b9e | 22:17 |
vladimir3p | I expect that 1st of all volume mgr will call create_volume for volume-00000b9b and it will result in 2 driver calls: self.driver.create_volume(volume_ref) & self.driver.create_export(context, volume_ref) | 22:18 |
vladimir3p | but according to logs there was something for 2nd volume executed in the middle ... or probably logs are screwed ... | 22:18 |
vishy | yes it eats the exception because of eventlet issue | 22:19 |
vishy | have to reraise the exception using the other format | 22:19 |
vishy | yes that will happen | 22:19 |
vishy | because each "thread" will pause waiting for the results of execute | 22:19 |
vishy | so if the executes can run concurrently | 22:20 |
vishy | if there is some execute that is not thread safe | 22:20 |
vishy | then you need to wrap it in a utils.synchronized so only one happens at a time | 22:20 |
vladimir3p | hmm... interesting . Actually, from our perspective executes are safe ... but I'm trying to understand if such multi-execs nature of things might be broken due to usage of PIPE | 22:21 |
vishy | shouldn't be | 22:22 |
vladimir3p | what we see is that one of create_exports is not even reaching our utility | 22:22 |
vladimir3p | (at least there shoould be a print and there is no) | 22:22 |
vishy | you should get the traceback | 22:23 |
vishy | it will probably help | 22:23 |
vladimir3p | yep. I will change this portion and will raise the correct exception | 22:23 |
vishy | i did it in volume cleanup | 22:24 |
vishy | should look like this: | 22:24 |
vishy | http://paste.openstack.org/show/2304/ | 22:25 |
vishy | all the raises there need to be fixed | 22:25 |
vladimir3p | ah, ok ... we are raising exception.ProcessExecutionError in any error... | 22:26 |
vladimir3p | like this: | 22:26 |
vladimir3p | http://paste.openstack.org/show/2305/ | 22:27 |
vladimir3p | I will change it to your style | 22:27 |
*** mfer has quit IRC | 22:38 | |
*** mgius has joined #openstack-dev | 22:38 | |
*** code_franco has quit IRC | 22:42 | |
*** rnorwood has quit IRC | 22:44 | |
*** mattray has quit IRC | 22:48 | |
*** rnirmal has quit IRC | 22:56 | |
*** dragondm has quit IRC | 23:39 | |
*** novas0x2a|laptop has quit IRC | 23:41 | |
*** medberry is now known as med_out | 23:44 | |
*** novas0x2a|laptop has joined #openstack-dev | 23:46 | |
*** novas0x2a|laptop has quit IRC | 23:53 | |
*** amccabe has quit IRC | 23:54 | |
*** martine_ has joined #openstack-dev | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!