Thursday, 2011-08-04

« Wednesday, 2011-08-03 Index Friday, 2011-08-05 »
*** rods has quit IRC00:00
*** mnaser has quit IRC00:01
*** dragondm has quit IRC00:04
*** mszilagyi has quit IRC00:12
*** jdurgin has quit IRC00:58
*** mgius has quit IRC01:08
*** mgius has joined #openstack-dev01:10
*** jakedahn has joined #openstack-dev01:44
*** nati has joined #openstack-dev01:55
*** mattray has joined #openstack-dev02:17
*** mattray has quit IRC02:39
*** mattray has joined #openstack-dev02:42
*** mattray has quit IRC02:42
*** mnaser has joined #openstack-dev03:12
*** mnaser has quit IRC03:13
openstackgerritsleepsonthefloor proposed a change to openstack/keystone: this code appears to have been accidentally deleted.  if the project does not exist, it should be created  https://review.openstack.org/14303:42
openstackgerritsleepsonthefloor proposed a change to openstack/keystone: this code appears to have been accidentally deleted.  if the project does not exist, it should be created  https://review.openstack.org/14303:52
*** mfer has quit IRC04:02
*** zaitcev has quit IRC04:03
*** TimR has quit IRC04:30
*** TimR has joined #openstack-dev04:31
*** jakedahn has quit IRC04:37
*** jakedahn has joined #openstack-dev05:01
*** cp16net has quit IRC05:52
*** cp16net has joined #openstack-dev05:52
*** nati has quit IRC06:03
*** cp16net has quit IRC06:16
ttxjaypipes, notmyname: might not be exactly what you're looking for, but you can already see diff from previous set at the per-file level06:24
ttxjaypipes, notmyname: example: https://review.openstack.org/#change,12706:26
ttxTo view diff between patchsets 1 & 2, Select patch set 1 on "Old version history"06:26
ttxAnd when you're looking at a specific file diff, you can click on "patch history" and select more complex diffs06:27
ttx...and now I realize someone else answered that already.06:42
*** HugoKuo__ has joined #openstack-dev06:45
ttxjk0, notmyname, mtaylor: About why having it on github if not using pull requests: the only repo we are not using pull requests with is trunk -- using github enables simple collaboration on other forks. Something we would have to create if doing it from scratch.06:46
ttxI agree it could be confusing though -- ideally pull requests would be proxied to gerrit, or at least disabled for trunk...06:47
*** HugoKuo_ has quit IRC06:48
*** tudamp has joined #openstack-dev07:01
*** reidrac has joined #openstack-dev07:12
*** mnour has quit IRC07:25
*** nickon has joined #openstack-dev07:50
*** AhmedSoliman has joined #openstack-dev08:07
*** darraghb has joined #openstack-dev08:17
*** sandywalsh has quit IRC08:34
*** TimR has quit IRC08:56
*** TimR has joined #openstack-dev08:57
*** mnour has joined #openstack-dev09:08
*** mnour has quit IRC09:12
*** mnour has joined #openstack-dev09:12
*** mnour has quit IRC09:27
*** mnour has joined #openstack-dev09:27
*** mnour has quit IRC09:33
*** mnour has joined #openstack-dev09:34
*** mnour has quit IRC09:36
*** cian_ has joined #openstack-dev10:13
*** TimR has quit IRC10:51
*** TimR has joined #openstack-dev10:51
*** TimR has quit IRC11:17
*** TimR has joined #openstack-dev11:18
*** markvoelker has joined #openstack-dev11:18
zykes-what projects has moved to github ?11:23
*** vcaron has joined #openstack-dev11:41
*** mfer has joined #openstack-dev11:49
ttxzykes-: no core project yet. In incubation, Keystone and Dashboard are there12:06
*** AhmedSoliman has quit IRC12:16
*** AhmedSoliman has joined #openstack-dev12:17
*** blamar has quit IRC12:27
*** blamar has joined #openstack-dev12:27
*** dprince has joined #openstack-dev12:28
dprinceI killed the tarmac job that was hung for the last 20 hours.12:36
dprinceThe new job seems to be merging our code again.12:36
dprinceYeah!12:36
openstackjenkinsProject nova build #1,187: SUCCESS in 3 min 29 sec: http://jenkins.openstack.org/job/nova/1187/12:40
openstackjenkinsTarmac: Removes extraneous bodies from certain actions in the OSAPI servers controller12:40
openstackjenkinsRequires the latest version of python-novaclient to test12:40
westmaaswoo12:40
*** alfred_mancx has joined #openstack-dev12:54
openstackjenkinsProject nova build #1,188: SUCCESS in 3 min 19 sec: http://jenkins.openstack.org/job/nova/1188/12:56
openstackjenkins* Tarmac: Update HACKING:12:56
openstackjenkins- Make imports more explicit12:56
openstackjenkins- Add some dict/list formatting guidelines12:56
openstackjenkins- Add some long method signature/call guidelines12:56
openstackjenkins- Add explanation of i18n12:56
openstackjenkins* Tarmac: Pep8 cleanup12:56
openstackjenkins* Tarmac: Defaults `dns` to '' if not present, just as we do with the other network info data.12:56
*** mnaser has joined #openstack-dev12:59
*** mnaser has quit IRC13:02
*** mnaser has joined #openstack-dev13:02
*** alfred_mancx has quit IRC13:03
*** sandywalsh has joined #openstack-dev13:05
*** mnaser has quit IRC13:10
*** BK_man has joined #openstack-dev13:12
*** vcaron has quit IRC13:15
*** adambergstein_ has joined #openstack-dev13:19
*** adambergstein has quit IRC13:19
*** adambergstein_ is now known as adambergstein13:19
jk0looks like jenkins got caught up? \o/13:25
*** dolphm has joined #openstack-dev13:26
*** TimR has quit IRC13:27
*** TimR has joined #openstack-dev13:28
*** jkoelker has joined #openstack-dev13:29
*** bcwaldon has joined #openstack-dev13:34
adambergsteinhi, is this the room for support?13:37
*** bsza has joined #openstack-dev13:37
adambergsteinI am getting the following issue in my nova-compute.log file: Found instance 'instance-0000000d' in DB but no VM. State=9, so assuming spawn is in progress.13:39
adambergsteini have an instance that is stuck in 'building'13:39
*** reidrac has quit IRC13:40
*** dolphm has quit IRC13:40
sandywalshttx/soren, we have a novaclient change coming that will bust the nova tests. We're ok on the Pypi/pip side of the fence since we explicitly choose a compatible version. But if we update rackspace/python-novaclient, will that bust the PPA builds?13:46
ttxsandywalsh: not until we update the python-novaclient package, I'd say13:47
sandywalshttx ok, so that's not an automated task then?13:48
ttxsandywalsh: currently we have 2.4.2~bzr25, so I'd say no.13:48
sandywalshheh .. ok, cool ... thanks13:48
sorenHmm.. It should be automatic.13:49
sorenWEird.13:49
* soren goes and looks.13:49
*** kbringard has joined #openstack-dev13:51
ttxsandywalsh: soren: we actually have 2.5.9~bzr65 in trunk. Was looking at milestone-proposed, sorry.13:56
ttxsandywalsh: do you have the fix for Nova that we could commit at the same time ?13:57
sandywalshttx, that's what we're just discussing, now sensitive the timing has to be. We will if need be.13:58
*** dolphm has joined #openstack-dev13:58
sandywalshs/now/how/13:58
sandywalshttx, not a big deal really13:58
sandywalshttx just other priorities too :)13:59
sorenttx: Well, we're supposed to be at r69.13:59
sorenttx: Someone broke the build.13:59
ttxsandywalsh: lets disable the tests :)13:59
sandywalshhaha13:59
sandywalshttx, don't sweat it, we'll get a patch going in parallel13:59
dprinceTarmac seems to be hung again. I'm gonna kill the existing tarmac job again (I did it earlier this morning) to get some more merge props in.14:01
*** mdomsch has joined #openstack-dev14:01
*** nmistry has joined #openstack-dev14:04
*** AhmedSoliman has quit IRC14:09
sandywalshblamar, this novaclient patch is looking really good so far ... time for some hands on testing.14:09
blamarsandywalsh: yeah lemme know how that goes :) working on the formatting still14:10
sandywalshwill do14:10
*** dolphm has quit IRC14:12
*** dolphm has joined #openstack-dev14:13
*** reidrac has joined #openstack-dev14:16
*** nmistry has quit IRC14:16
sandywalshblamar, when the help strings say "(see 'osc flavors')" ... where is it referring to?14:17
blamarhmm, must have snuck in, we were playing around with 'osc' for a command line name for a bit (osc = openstack compute)14:19
blamarI'll revert that14:19
sandywalshk14:19
*** adambergstein has left #openstack-dev14:19
blamarsandywalsh: that's updated14:24
sandywalshthanks14:25
* sandywalsh just realized what room he was in ... heh14:25
tr3buchetjeblair you around?14:32
jeblairtr3buchet: yep14:32
tr3buchethttp://pastie.org/231700914:33
tr3buchetran into issue with gerrit14:33
tr3buchetdid a rebase, i assumed to change-id hook would add the change id but it didn't14:33
tr3buchetso the push to review failed14:33
jeblaircan you tell me more about the rebase you did?14:34
tr3buchetyeah14:36
tr3buchetinteractive14:36
tr3bucheti picked the first, squashed the rest14:36
tr3buchetand then for the commit message i deleted everything and wrote my own14:36
tr3bucheti'm thinking maybe i should have kept the change id for the commit that i picked...14:37
jeblairah, okay.  probably what you deleted had a change-id then?14:37
jeblairyeah, i think so14:37
jeblairso in the error message, gerrit suggests a change-id you can use:14:37
jeblairChange-Id: I3a5e100d3b2b29ac03cbe345be0a18abef8fd73b14:37
tr3buchetyeah so it had the 16 or so commits in there with their commit messages and change ids14:37
tr3buchetok so i should just pop that in there, and i'm good?14:37
jeblairtry doing git commit --amend and adding that14:37
jeblairi think so14:37
tr3buchetok14:37
jeblairi'll update the docs to let ppl know to leave the change-id from the commit they pick when squashing/rebasing14:38
openstackgerritTrey Morris proposed a change to openstack/keystone: pep8 fixes round 1  https://review.openstack.org/14414:41
*** TimR has quit IRC14:42
tr3buchetjeblair sweet looks like i'm off to a running start14:42
tr3buchetthanks14:42
*** mattray has joined #openstack-dev14:42
blamarsandywalsh: been talking with bcwaldon and have a question; if NOVA_URL is set to http://localhost:8774/v1.0 and NOVA_VERSION=1.1 is set, should we try to use 1.0 or 1.1?14:42
jeblairthank you!  I updated http://wiki.openstack.org/GerritWorkflow#Long-lived_Topic_Branches with a note from what we learned here14:42
sandywalshblamar, heh, good point. Either we: 1. infer the version from the URL or 2. append the version from the env var?14:43
sandywalshblamar, but probably not both14:43
sandywalshblamar, I like #114:44
blamarsandywalsh: it was pointed out to me that someone could have an environment with their paste config set to serve a v1.1 endpoint at http://localhost:8774/chickens which wouldn't give us any information14:44
sandywalshphooey14:44
blamarsandywalsh: :)14:44
sandywalshblamar, ok, well I guess that answers the original question ... the URL is opaque so we do whatever the env var/cmd line flag says14:45
*** mattray has quit IRC14:46
*** rnirmal has joined #openstack-dev14:47
blamarsandywalsh: yeah, so --version or NOVA_VERSION always wins, and we don't try to mess with the NOVA_URL? sounds right to me14:47
jaypipesblamar, bcwaldon, dprince, jkoelker, johan_-_, Vek: ready to make the plunge?14:47
sandywalshblamar, yup14:48
blamarjaypipes: yay?14:48
blamar:)14:48
jaypipesblamar: heh, my feelings exactly :)14:49
*** cp16net has joined #openstack-dev14:49
*** mattray has joined #openstack-dev14:53
*** cp16net has quit IRC14:54
*** cp16net has joined #openstack-dev14:54
blamarsandywalsh: updated to pull from NOVA_VERSION as a fallback14:55
sandywalshblamar, awesome ... thanks14:55
*** tudamp has left #openstack-dev14:55
*** cp16net_ has joined #openstack-dev14:56
*** truijllo has joined #openstack-dev14:58
*** cp16net has quit IRC14:59
*** cp16net_ is now known as cp16net14:59
*** deshantm_laptop has joined #openstack-dev15:01
jkoelkerjaypipes: dive, dive, dive15:04
jaypipesjkoelker: :) mtaylor and jeblair are just warming the water...15:04
*** amccabe has joined #openstack-dev15:04
* jaypipes dips toe.15:05
mtaylormmmm15:05
jkoelkerI thought they put chemicals in the pool for that15:05
jaypipeshehe15:05
*** dragondm has joined #openstack-dev15:06
jaypipesdolphm: Keystone has some competition :) http://aws.amazon.com/iam/15:06
jaypipesdolphm: announced today.15:06
dolphmjaypipes: awesome :D15:06
jaypipesdolphm: btw, got keystone all "OpenStacked up" with test runner, etc, so it matches Nova and Glance.15:07
jaypipesdolphm: I'll propose shortly.15:07
dolphmjaypipes: cool, looking forward to it15:07
*** reidrac has quit IRC15:08
dolphmjaypipes: ziad says that's been out for a while (?)15:09
dolphmjaypipes: (iam)15:09
jaypipesdolphm: hmm, I got an announcement from AWS about it today... oh well :)15:10
jaypipesdolphm: press release fail. ;)15:10
jaypipesdolphm: ah, I guess just the identity federation is new...15:11
*** truijllo has quit IRC15:14
*** mdomsch has quit IRC15:21
tr3buchetvishy: you around?15:26
openstackgerritMonty Taylor proposed a change to openstack/openstack-ci: Fixed tarball and ppa script to work with git.  https://review.openstack.org/14515:26
*** nickon has quit IRC15:28
creihtttx: can you explain more what you mean by, "using github enables simple collaboration on  other forks15:31
creiht"15:31
creihtjaypipes: and yeah, iam has been available for a while15:33
notmynamecreiht: I think it's that we can use github's feature to collaborate on a long running topic branch before it's merged15:33
*** dolphm has quit IRC15:33
jaypipescreiht: the federated identity stuff is what's new, apparently...15:34
creihtahh15:34
jaypipescreiht: I misread the press release15:34
dprinceSo Tarmac is continually hanging on ironcamels lp:~rackspace-titan/nova/extensions-osapi1.1-serx branch.15:37
dprinceI temporarily set it to 'Needs review' to see if the rest of the branches that are approved will go.15:37
dprinceAny idea on why Tarmac always seems to hang on this specific branch? Is it a size thing?15:38
*** dolphm has joined #openstack-dev15:38
ttxcreiht: gerrit will only handle the trunk branch, iiuc -- so to get the same functionality that LP code review provides for random branches, you need something that does that for git15:39
*** CatKiller has joined #openstack-dev15:39
ttxcreiht: for example citrix uses LP code review to do peer review on their topic branches before proposing for trunk15:40
ttxcreiht: we need to keep some way of doing that in a git NWO15:40
creihtttx: I agree there, some of us were making the case earlier that if we aren't using any of the advantages of github, why not host that ourselves with something like gitorious15:41
creihtor any of the other options available15:42
notmynamethere's nothing that prevents another dev from using github regardless of where the canonical version is. (I for one will be doing this.) of course, you lose out on the "one-click-to-make-a-fork-in-your-personal-account" feature that github has15:43
notmynameheh. did I just get sucked back in to this debate again? ;-)15:45
creihtlol15:45
creihtOne of my main concerns is if we keep github as the main source of the repo, then a lot of people are going to assume that they can use the normal github workflow (i.e. making pull requests)15:46
creihtNot trying to start up any debate, just wanted clarification on what ttx was talking about earlier15:48
creiht:)15:48
dprinceI thought one of the reason for hosting code on GitHub was well... so we could make use of GitHub. Pull requests would be sweet. Too bad we can't use them.15:49
*** dolphm has quit IRC15:51
openstackgerritMonty Taylor proposed a change to openstack/glance: Changed setup.py to pull version info from git.  https://review.openstack.org/14615:51
openstackgerritKevin L. Mitchell proposed a change to openstack/keystone: Fix brain-o--we may not need project_ref, but we do need to create the project!  https://review.openstack.org/14715:51
notmynameI'd prefer to avoid a situation where someone has gone to the trouble of actually submitting a patch and pull request on github and have to tell them to instead go through an entirely different process (involving launchpad ids, extra remote repos, new UIs, etc)15:51
mtaylorcreiht, notmyname: yes. I agree with both of you15:51
openstackjenkinsProject nova build #1,189: SUCCESS in 5 min 16 sec: http://jenkins.openstack.org/job/nova/1189/15:51
openstackjenkinsTarmac: Nova uses instance_type_id and flavor_id interchangeably when they almost always different values. This can often lead to an instance changing instance_type during migration because the values passed around internally are wrong. This branch changes nova to use instance_type_id internally and flavor_id in the API. This will hopefully avoid confusion in the future.15:52
mtaylorcreiht, notmyname: we just haven't had a chance to do the not-github thing yet15:52
creihtmtaylor: well what have you been doing then? ;P15:52
creihtjk15:52
mtaylorcreiht, notmyname: jeblair and I poked at both gitweb and gitorious yesterday :)15:53
* mtaylor punches creiht 15:53
creihtI was only bringing it up because of ttx's responses15:53
notmynamemtaylor: that's completely ok (waiting eagerly for it). I think the gerrit stuff is new to a lot of people, and we're all trying to understand what it actually means for day-to-day work15:53
mtaylornotmyname: totally15:54
mtaylornotmyname: be sure to check out the command-line via ssh stuff with gerrit if you're in to command line types of things15:54
notmynameso questions aren't attacks on your work, just curiosity and potential concerns new eyes may see15:54
notmynamemtaylor: where are the docs for that?15:55
mtaylornotmyname: https://review.openstack.org/Documentation/cmd-index.html15:55
mtaylornotmyname: and I'm certainly not taking them as attacks!15:55
* creiht must try harder then15:56
creiht:)15:56
mtaylorhehe15:56
dprincemtaylor: Hey man. Tarmac is had issues merging lp:~rackspace-titan/nova/extensions-osapi1.1-serx this morning.15:56
dprincemtaylor: I temporarily marked it 'needs review' to see if the rest of the branches go.15:56
dprincemtaylor: That branch is a larger diff. Just wondering if this is a size thing?15:57
mtaylordprince: shouldn't be a size thing .. but let me look at it15:57
dprincemtaylor: Actually. The branch adds lxml to pip-requires as well. So that could be it.15:59
mtaylordprince: yup. that'll be it15:59
mtaylordprince: we'll need to add that to the nova build-deps ... I'll put that on my list15:59
dprincemtaylor: So what needs to happen to fix that?15:59
mtaylordprince: python-lxml needs to be added to the debian build-deps in lp:~openstack-ubuntu-packagers/nova/ubuntu16:00
*** negronjl has quit IRC16:00
*** negronjl has joined #openstack-dev16:00
dprincemtaylor: Its already there I think?16:00
mtaylordprince: is it?16:01
mtaylordprince: looking on the box16:01
dprincemtaylor: Sorry. Its in Build-Depends-Indep.16:01
mtaylorthat's fine16:01
dprincemtaylor: Yeah. You added it :)16:02
mtaylorahaha16:02
mtaylordprince: python-lxml is installed on the nova build slave16:03
dprincemtaylor: You just now did it? Or it was already there?16:04
mtaylordprince: already there16:04
dprincemtaylor: Sure. Okay. Any other ideas on why it hangs?16:04
openstackjenkinsProject nova build #1,190: SUCCESS in 3 min 48 sec: http://jenkins.openstack.org/job/nova/1190/16:05
openstackjenkins* Tarmac: Moves code restarting instances after compute node reboot from libvirt driver to compute manager; makes start_guests_on_host_boot flag global.16:05
openstackjenkins* Tarmac: Moved server actions tests to their own test file. Updated stubbing and how flags are set to be in line with how they're supposed to be set in tests.16:05
*** joar has quit IRC16:08
openstackjenkinsProject nova build #1,191: SUCCESS in 3 min 51 sec: http://jenkins.openstack.org/job/nova/1191/16:13
openstackjenkinsTarmac: Found a case where an UnboundLocalError would be raised in xenapi_conn.py's wait_for_task() method. This fixes the problem by moving the definition of the unbound name outside of the conditional.16:13
kbringardkpepple: congrats on the book16:14
openstackjenkinsProject glance build #89,158: SUCCESS in 1 min 2 sec: http://jenkins.openstack.org/job/glance/89158/16:19
openstackgerritA change was merged to openstack/glance: Changed setup.py to pull version info from git.  https://review.openstack.org/14616:19
openstackjenkinsMonty Taylor: Changed setup.py to pull version info from git.16:19
creihtkbringard: book?16:20
kbringardcreiht: http://oreilly.com/catalog/9781449311056/16:20
creihtnice16:20
kbringardright?16:20
*** galstrom has joined #openstack-dev16:21
kbringardthen there is this one… http://www.amazon.com/OpenStack-Lambert-M-Surhone/dp/613527242X/ref=pd_sim_sbs_b_116:22
kbringard50$ for a book that starts it's description by saying:16:22
kbringardPlease note that the content of this book primarily consists of articles available from Wikipedia or other free sources online16:22
kbringard:facepalm:16:22
westmaaswell you can get it used for $6316:23
westmaasso that's nice16:23
jaypipesblamar, bcwaldon, dprince, jkoelker, johan_-_, Vek: the switch to git is now complete.16:23
kbringardwestmaas: lol16:23
openstackgerritJustin Shepherd proposed a change to openstack/glance: Implemented @utils.skip_test, @utils.skip_unless and @utils.skip_if functionality in glance/test/utils.py. Added glance/tests/unit/test_skip_examples.py which contains example skip case usages.  https://review.openstack.org/14816:24
westmaasdprince: what jaypipes said ^^16:24
openstackgerritA change was merged to openstack/openstack-ci: Fixed tarball and ppa script to work with git.  https://review.openstack.org/14516:24
kbringardjaypipes: wait, we're switching to git? ;-)16:24
jaypipesheh16:25
kbringardhas anyone used the Zenoss zenpack for OpenStack?16:25
dprincejaypipes: Thanks for the heads up.16:25
creihtkbringard: lol16:28
creiht(about the book)16:28
kbringardyea, I looked at that and was like16:28
kbringardwow, props for catering to the lazy16:28
creihthaha16:28
openstackjenkinsProject nova build #1,192: SUCCESS in 3 min 16 sec: http://jenkins.openstack.org/job/nova/1192/16:30
openstackjenkinsTarmac: The logic for confirming and reverting resizes was flipped. As a result, reverting a resize would end up deleting the source (instead of the destination) instance, and confirming would end up deleting the destination (instead of the source) instance.16:30
openstackjenkinsThis branch fixes the logic to be correct.16:30
openstackgerritMonty Taylor proposed a change to openstack/openstack-ci: Don't double-add users to project watches.  https://review.openstack.org/14916:31
westmaasmtaylor: anything we can do to help track down why that one branch is failing?16:31
westmaaswould like to see it hit trunk!16:32
*** JStoker has quit IRC16:33
*** JStoker has joined #openstack-dev16:34
*** JStoker has joined #openstack-dev16:34
mtaylorwestmaas: not at the moment ... I need to go in and run a few commands by hand and see where it's sticking16:34
westmaask16:34
* mtaylor would like to mention that he will be happy when the merge job is actually in jenkins so that we can watch the output of the script _while_ it's running16:35
dprincewestmaas: I think its a problem with the branch.16:35
dprinceThe unit tests hang indefinately for me (on my workstation).16:35
dprinceGonna ask the ironcamel to take a look when he gets in.16:35
mtaylordprince: oh! great. (I was just about to go test that by hand ... so thanks!)16:36
dprinceFor now I'll set extensions-osapi1.1-serx back to WIP.16:36
dprincemtaylor: NP. Thank you for the help too sir.16:36
mtaylormy pleasure!16:36
*** jc_smith has quit IRC16:38
*** mwhooker has quit IRC16:38
openstackgerritJustin Shepherd proposed a change to openstack/glance: Implemented @utils.skip_test, @utils.skip_unless and @utils.skip_if functionality in glance/test/utils.py. Added glance/tests/unit/test_skip_examples.py which contains example skip case usages.  https://review.openstack.org/14816:39
*** heckj has joined #openstack-dev16:41
openstackgerritJay Pipes proposed a change to openstack/keystone: Add run_tests.sh, virtualenv scripts, and make setup.py use nose.collector as its test runner  https://review.openstack.org/15016:46
openstackgerritJay Pipes proposed a change to openstack/keystone: Gets Keystone a bit more inline with the way that other OpenStack projects run tests. Basically, adds the standard run_tests.sh script, modifies the run_tests.py script to do the following:  https://review.openstack.org/15116:46
*** jdurgin has joined #openstack-dev16:47
openstackgerritMonty Taylor proposed a change to openstack/openstack-ci: Don't double-add users to project watches.  https://review.openstack.org/14916:48
BK_manis there a reason why Nova doesn't create br100 anymore starting from Diablo-3? We're using VlanManager16:50
jaypipesvishy: see BK_man's ? ^^16:56
heckjgerrit process question - if two openstack developers (non-core) give a +1, should the Jenkins service be trying the merge, or does it always require a core developer to give a blessing? (i.e. is it a vote of +2 or specifically a core developer saying "OK")?17:01
openstackjenkinsProject swift build #303: SUCCESS in 29 sec: http://jenkins.openstack.org/job/swift/303/17:02
openstackjenkinsTarmac: More quarantine catching code. This should catch and quarantine any databases that indicate malformation or corruption with the known raised exceptions and it should catch and quarantine the case we've seen where hash directories become files.17:02
jaypipesheckj: right now, requires a +2 from a core dev...17:03
jaypipesheckj: but IIRC, that is a policy that can be edited.17:03
jaypipesheckj: the existing process is like the difference between a merge proposal Approved status (+2) versus 2 Approve comments (+1s)17:03
heckjjaypipes: got it, thanks.17:04
*** mwhooker has joined #openstack-dev17:04
heckjjaypipes: so far I've been just working through the web interface. I'm guessing most of this is actually getting done on command line w/ git/gerrit plugins?17:05
jaypipesheckj: you can use the CLI as well, yes17:06
*** jc_smith has joined #openstack-dev17:07
heckjjaypipes: which have you been using? (trying to learn without actually battering any projects)17:07
jaypipesheckj: the gerrit web interface for now... still trying to get used to a few gitisms regarding merges/rebases...17:10
mtaylorheckj: https://review.openstack.org/Documentation/cmd-index.html if you're interested17:17
heckjmtaylor: thanks17:17
openstackjenkinsProject glance build #89,159: FAILURE in 57 sec: http://jenkins.openstack.org/job/glance/89159/17:18
openstackgerritVerification of a change to openstack/glance failed: Implemented @utils.skip_test, @utils.skip_unless and @utils.skip_if functionality in glance/test/utils.py. Added glance/tests/unit/test_skip_examples.py which contains example skip case usages.  https://review.openstack.org/14817:18
openstackjenkinsgalstrom: Implemented @utils.skip_test, @utils.skip_unless and @utils.skip_if functionality in glance/test/utils.py. Added glance/tests/unit/test_skip_examples.py which contains example skip case usages.17:18
mtaylorooh. that's a bit talkies17:18
jeblairwhoops.  i turned off jenkins irc notifications for that job17:25
openstackgerritZiad Sawalha proposed a change to openstack/keystone: Small change to test Gerrit  https://review.openstack.org/15217:31
openstackgerritMonty Taylor proposed a change to openstack/openstack-ci: Don't double-add users to project watches.  https://review.openstack.org/14917:31
openstackgerritZiad Sawalha proposed a change to openstack/keystone: Small licensing change to test Gerrit  https://review.openstack.org/15317:33
*** zigo has joined #openstack-dev17:44
openstackjenkinsProject nova build #1,193: SUCCESS in 3 min 23 sec: http://jenkins.openstack.org/job/nova/1193/17:45
openstackjenkinsTarmac: Update the OS API servers metadata resource to match the current v1.1 specification17:45
openstackjenkins- move /servers/<id>/meta to /servers/<id>/metadata17:45
openstackjenkins- add PUT /servers/<id>/metadata17:45
openstackgerritJay Pipes proposed a change to openstack/keystone: Gets Keystone a bit more inline with the way that other OpenStack projects run tests. Basically, adds the standard run_tests.sh script, modifies the run_tests.py script to do the following:  https://review.openstack.org/15417:47
mtaylorjaypipes: once that is merged, should I be able to expect to have the jenins job for keystone be "python setup.py test" and have it work?17:49
*** zigo has quit IRC17:50
jaypipesmtaylor: no. but ./run_tests.sh -V/-N will work.17:50
mtaylorjaypipes: great!17:51
jaypipesjeblair, mtaylor: any way to remove the ABANDONED pull requests from the Code Review Dashboard (https://review.openstack.org/#mine)17:53
mtaylorjaypipes: not really - that's the list of your personal changes ... what you _may_ be wanting though is https://review.openstack.org/#q,is:watched+status:open,n,z17:54
mtaylorjaypipes: although I'm _just_ about to add watches for you to the glance project17:54
mtaylorjaypipes: so gimme a minute17:54
jaypipesmtaylor: I already added the glance watch17:56
mtaylorjaypipes: great! then that's actually more likely the page you're interested in as a dashboard17:56
mtaylorjaypipes: jenkins build failure17:56
jaypipesmtaylor: cool, thx!17:56
jaypipesmtaylor: build failure, saw it. I alerted Justin.17:57
mtaylorjaypipes: woot. just wanted to make sure it wasn't a failure in the testing setup17:57
jaypipesmtaylor: nope, don't think so.17:57
*** mnaser has joined #openstack-dev17:59
*** dprince has quit IRC18:00
mtaylorjaypipes: I'd like to make the glance pylint job similar to the keystone job - meaning, I'll set the current pylint count as the high water mark, so that you'll fail if you introduce _new_ warnings18:05
mtaylorjaypipes: yeah?18:05
*** adiantum has joined #openstack-dev18:12
openstackjenkinsProject nova build #1,194: SUCCESS in 3 min 17 sec: http://jenkins.openstack.org/job/nova/1194/18:14
openstackjenkinsTarmac: Add a test for empty dns list in network_info18:15
openstackgerritMonty Taylor proposed a change to openstack/openstack-ci: Don't double-add users to project watches.  https://review.openstack.org/14918:17
*** dolphm has joined #openstack-dev18:21
openstackgerritMonty Taylor proposed a change to openstack/openstack-ci: Fix project watch handling.  https://review.openstack.org/14918:26
openstackgerritMonty Taylor proposed a change to openstack/openstack-ci: Fix project watch handling.  https://review.openstack.org/14918:35
mgiusa few days ago there was a conversation about sqlalchemy errors in nova, has there been any resolution for that?18:39
mgiusError binding parameter 6: http://paste.openstack.org/raw/2053/18:39
*** darraghb has quit IRC18:40
galstrommtaylor: are we sure that failure is not a problem with jenkins.. seems like tests are leaking state. But it runs fine on my workstation.. and I can not re-run it on jenkins manually18:41
mtaylorgalstrom: which failure (sorry - juggling several balls today)18:42
galstromnp18:43
galstrommtaylor: Project glance build #89,159: FAILURE in 57 sec: http://jenkins.openstack.org/job/glance/89159/18:43
mtaylorgalstrom: gotcha - trying something (it was not set to wipe the workspace first)18:43
galstrommtaylor: kk18:44
openstackgerritA change was merged to openstack/glance: Implemented @utils.skip_test, @utils.skip_unless and @utils.skip_if functionality in glance/test/utils.py. Added glance/tests/unit/test_skip_examples.py which contains example skip case usages.  https://review.openstack.org/14818:44
mtaylorgalstrom: ^^ yay!18:44
mtaylorgalstrom: good catch18:44
galstrommtaylor: galstrom = jshepher (just fyi)18:45
galstrommtaylor: thanks18:45
zykes-what's the diff on endpoints and endpoint templates ?18:46
jaypipesmtaylor: that's cool with me, yep.18:49
zykes-dolphm: ?18:49
mtaylorjaypipes: on the other hand - glance-param is now a little wonky and I'm going to have to poke at it for a bit18:50
jaypipesmtaylor: ya, since it uses LP :)18:51
jaypipesmtaylor: there's a glance-setuppy-test-param as well..18:51
mtaylorjaypipes: well - that - and also I was tyring to make a git one and the git plugin doesn't like variable repo locations ... so I'm poking18:51
dolphmzykes-: give me a few minutes18:52
*** galstrom is now known as jshepher18:54
*** jshepher has joined #openstack-dev18:54
*** jshepher has left #openstack-dev18:55
*** jshepher has joined #openstack-dev18:55
*** bcwaldon has quit IRC18:57
mtaylorjaypipes: ok. you're now on the pep8 blocking and pylint can't get worse bandwagon18:57
jaypipesmtaylor: coolio. thx :)18:58
*** jakedahn has quit IRC19:01
*** jakedahn has joined #openstack-dev19:01
*** med_out is now known as med19:01
openstackgerritA change was merged to openstack/openstack-ci-puppet: Add keystone dependencies to keystone jenkins slave.  https://review.openstack.org/14119:02
*** alfred_mancx has joined #openstack-dev19:03
dolphmzykes-: did you ask me about this yesterday, or was that someone else?19:05
*** rnirmal has quit IRC19:05
zykes-don't remember19:06
dolphmzykes-: anyway, endpoints are basically a many to many table between a tenant and an endpoint template, therefore a tenant can have these specific Endpoints based on these generic templates19:07
*** cp16net_ has joined #openstack-dev19:07
*** jakedahn_ has joined #openstack-dev19:08
zykes-hmm k19:09
zykes-like ?19:09
dolphmzykes: check out bin/sampledata.sh19:10
*** cp16net has quit IRC19:10
dolphmzykes-: each service (nova/swift/etc) has an Endpoint Template, and the Endpoint basically plugs a Tenant ID into the Template for consumption by the User19:10
*** jakedahn has quit IRC19:11
*** jakedahn_ is now known as jakedahn19:11
zykes-so say in region 1 you have 5 services19:11
*** cp16net_ has quit IRC19:11
zykes-then you need to map 1 tenant > 5 services ?19:11
zykes-or endpoints19:12
dolphmzykes-: i don't think you would *have* to map to 5 services, you could map to 3 or 8, depending on the User's Role(s), and how those Roles map to Tenants19:13
*** cp16net has joined #openstack-dev19:14
*** bcwaldon has joined #openstack-dev19:17
zykes-not following ;p19:18
dolphmthinking about the entity relationships... one User can have many roles on many tenants, and a tenant can have one or many endpoints based on several templates -- so just because there's 5 templates doesn't mean a user will have 5 endpoints :)19:19
dolphmthere's a catch though..19:21
*** adiantum has quit IRC19:21
*** yogirackspace has joined #openstack-dev19:22
dolphm(which i just learned about) endpoint templates can be marked as global=True, which means all tenants have an **implicit** relationship to that endpoint template (**no** Endpoint record required)19:22
dolphmnon-global endpoints are totally optional, and an Endpoint must exist to map a Tenant to the EndpointTemplate19:23
comstudhas jenkins stopped doing pep8 checks for some reason?19:28
comstudi've noticed a few pep8 issues in trunk lately19:28
openstackgerritDolph Mathews proposed a change to openstack/keystone: PEP8 fixes... all of them.  https://review.openstack.org/15519:30
dolphmTHANK YOU jeblair!19:31
mtaylordolphm: w00t! is that ... pep8 clean?19:34
mtaylorcomstud: there's some wonkiness ... will be fixed soon19:34
dolphmmtaylor: that is zero pep8 violations in keystone/ and bin/19:34
mtaylordolphm: so that's an "I can turn the pep8 job on as a blocker for keystone", yeah? (once it merges)19:35
mtaylordolphm: or really, I suppose, I could turn it on NOW before it merges :)19:35
comstudmtaylor: ok, cools.  just pointing it out, in case no one else did.19:36
mtaylorcomstud: totally ... and thanks!19:36
comstudnp19:36
mtaylorcomstud: as soon as we've moved bits over to gerrit, tracking the things we want to track in jenkins becomes hella better+easier19:36
dolphmmtaylor: that is exactly what i was going to ask you for :)19:37
mtaylordolphm: doing it right now19:37
comstudmtaylor: cools :)19:37
mtaylordolphm: done19:40
mtaylordolphm: holy jesus - that's not a small patch :)19:40
dolphmhaha19:41
dolphmthank you sir19:42
*** alfred_mancx has quit IRC19:44
kpepplekbringard: thx19:48
kbringardno no, thank you :-)19:49
jeblairdolphm: you're welcome!  yay!19:50
*** bcwaldon has quit IRC19:55
*** mgius has quit IRC19:56
*** bcwaldon has joined #openstack-dev19:56
*** rnirmal has joined #openstack-dev19:58
*** cp16net_ has joined #openstack-dev20:00
*** bsza has quit IRC20:01
*** cp16net has quit IRC20:04
*** cp16net_ is now known as cp16net20:04
openstackjenkinsProject keystone build #64: SUCCESS in 57 sec: http://jenkins.openstack.org/job/keystone/64/20:11
openstackgerritVerification of a change to openstack/keystone failed: PEP8 fixes... all of them.  https://review.openstack.org/15520:11
openstackjenkinsdolph.mathews: PEP8 fixes... all of them.20:11
dolphmwoot!20:14
zykes-what ? : p20:15
dolphmmtaylor: glance-pylint ran against keystone! (and failed it!)20:22
jeblairhaha20:22
dolphmjeblair: not funny! (okay, a little)20:23
jeblairdolphm: i'll fix it.20:23
dolphmjeblair: :)20:23
*** zaitcev has joined #openstack-dev20:25
openstackjenkinsProject nova build #1,195: SUCCESS in 5 min 1 sec: http://jenkins.openstack.org/job/nova/1195/20:26
openstackjenkinsTarmac: Fixes lp81939720:26
openstackjenkinsmigrations/resize no longer go through the full create process, but instead are merely powered on.20:26
jeblairdolphm: okay, just the keystone jobs are running on it now20:27
*** mdomsch has joined #openstack-dev20:27
jeblairsorry about that20:28
openstackjenkinsProject keystone build #65: SUCCESS in 50 sec: http://jenkins.openstack.org/job/keystone/65/20:28
openstackgerritA change was merged to openstack/keystone: PEP8 fixes... all of them.  https://review.openstack.org/15520:28
openstackjenkinsdolph.mathews: PEP8 fixes... all of them.20:28
jeblairyay!20:28
dolphmnow i can say: woot!20:29
dolphmjeblair: monty said he added a pep8 blocker.. is that not in there?20:29
jeblairdolphm: there may have been a typo in the config for that job20:31
jeblairi think i've fixed it20:32
jeblairdolphm: i re-triggered your job (even though it was committed, we can still run the tests again)20:33
jeblairhttps://jenkins.openstack.org/job/keystone-pep8/5/20:34
openstackjenkinsProject keystone build #66: SUCCESS in 52 sec: http://jenkins.openstack.org/job/keystone/66/20:34
openstackjenkinsdolph.mathews: PEP8 fixes... all of them.20:34
jeblairso that looks good, and it should be gating on that for all future changes20:34
jaypipesdolphm: chance to look at that testing pull request yet?20:55
openstackjenkinsProject nova build #1,196: SUCCESS in 3 min 10 sec: http://jenkins.openstack.org/job/nova/1196/20:59
openstackjenkinsTarmac: This updates nova-ajax-console-proxy to correctly use the new syntax introduced last week by Zed Shaw <zedshaw@zedshaw.com>.20:59
openstackjenkinsrpc.Connection -> rpc.create_connection20:59
openstackjenkinsrpc.TopicAdapterConsumer -> rpc.create_consumer20:59
*** cp16net has quit IRC21:04
dolphmjeblair: just got caught up- thanks!21:06
jeblairdolphm: you're welcome, thanks for your patience!21:07
dolphmjaypipes: i've keep trying to dig in, but keep getting pulled away-- i have a small comment or two but i like it so far, i'll finish it tonight21:08
dolphmgoing home for now... think i have a migraine coming on21:08
*** dolphm has quit IRC21:08
*** rnirmal has quit IRC21:09
*** deshantm_laptop has quit IRC21:09
openstackjenkinsProject nova build #1,197: SUCCESS in 3 min 24 sec: http://jenkins.openstack.org/job/nova/1197/21:12
openstackjenkins* Tarmac: Fixed rescue/unrescue since the swap changes landed in trunk. Minor refactoring (renaming callback to _callback since it's not used here).21:12
openstackjenkins* Tarmac: Updates to the XenServer glance plugin so that it obtains the set of21:12
openstackjenkinsexisting headers and sends them along with the request to PUT a21:12
openstackjenkinssnapshotted image into glance.21:12
*** bcwaldon has quit IRC21:18
*** KnuckleSangwich has quit IRC21:24
vishyBK_man, it should21:29
vishyBK_man, do your networks have the bridge and vlan set in the db?21:29
vishyBK_man, if you're referrring to new installs, you need to set vlan_interface in your flag file or specify it when you create the networks or you will get a network with no interface set21:30
vishytr3buchet: still need me?21:34
tr3buchetvishy: i was just going to ask what you did to get patches on your keystone merge in the gerrit review system21:35
tr3bucheti coldn't tell the difference between patch 1 and patch 221:35
vishyso if you amend a patch and re-view it comes in as a patch set21:36
vishyif you choose patch set 2 from the dropdown it will show you the diff with patch set 121:36
vishyi added support for clients that don't pass in the port in the host string21:37
tr3buchetah i see, i had to choose patch set 1 from the dropdown though21:38
tr3buchetthat's awesome that you can see the diff for each amend and the overall21:38
tr3bucheti really like it so far21:38
vishyits almost as good as reitveld21:38
*** jshepher has quit IRC21:38
vishy:)21:38
openstackjenkinsProject nova build #1,198: SUCCESS in 3 min 19 sec: http://jenkins.openstack.org/job/nova/1198/21:40
openstackjenkinsTarmac: There was a recent change to how we should flip FLAGS in tests, but not all tests were fixed.  This covers the rest of them.  I also added a method to test.UnitTest so that FLAGS.verbose can be set.  This removes the need for flags to be imported from a lot of tests.21:40
openstackjenkinsAnother side effect is that it fixes a bug in host_test_filter.py where there was a tearDown method in the class that didn't call its parent.  Ie, test.TestCase.tearDown() was not being called.  host_test_filter.py's tearDown has been removed as a part of this cleanup, so the parent will be called now.21:40
openstackjenkinsThis happens to fix an unrelated pep8 issue in trunk, as well, so that my tests pass cleanly.21:40
openstackjenkinsProject nova build #1,199: SUCCESS in 3 min 18 sec: http://jenkins.openstack.org/job/nova/1199/21:50
openstackjenkinsTarmac: The OSAPI v1.0 image create POST request should store the instance_id as a Glance property.21:50
openstackgerritA change was merged to openstack/openstack-ci: Fix project watch handling.  https://review.openstack.org/14921:53
vishyif there are any keystone devs around, this branch is vital21:54
vishyhttps://review.openstack.org/#change,14321:54
jaypipess1rp: hey bro, you know we're no longer on Launchpad for merge proposals, right? :) https://code.launchpad.net/~rconradharris/glance/lp821019/+merge/7049721:56
jaypipess1rp: we're on Git/Gerrit now...21:56
mtaylorjaypipes: I wonder if there's a way I can turn off merge props...21:57
jaypipesmtaylor: hmm, not sure... I think there might be a readonly code hosting setting or something like that...21:57
mtaylorjaypipes: well, it's an imported branch - I would hope that it make sense21:57
jaypipess1rp: if you want me to walk you through converting your merge proposal into a pull request in the new reviews.openstack.org, lemme or mtaylor know.21:58
s1rpjaypipes: heh, was reading through the gerret docs right now21:58
s1rpjaypipes: remembered right after i pushed it up21:58
openstackjenkinsProject keystone build #67: SUCCESS in 2 min 28 sec: http://jenkins.openstack.org/job/keystone/67/22:03
openstackgerritVerification of a change to openstack/keystone failed: Issue #115: Added support for testing multiple keystone configurations (sql-only, memcache, ldap)  https://review.openstack.org/13222:03
openstackjenkinsdolph.mathews: Issue #115: Added support for testing multiple keystone configurations (sql-only, memcache, ldap)22:03
openstackjenkinsProject keystone build #68: SUCCESS in 55 sec: http://jenkins.openstack.org/job/keystone/68/22:04
openstackjenkinsyoga80: Changes to support services.22:04
openstackgerritVerification of a change to openstack/keystone failed: Changes to support services.  https://review.openstack.org/13722:04
openstackjenkinsProject keystone build #69: SUCCESS in 51 sec: http://jenkins.openstack.org/job/keystone/69/22:05
openstackjenkinsvishvananda: Adds support for authenticating via ec2 signatures22:05
openstackjenkinsProject keystone build #70: SUCCESS in 52 sec: http://jenkins.openstack.org/job/keystone/70/22:06
openstackjenkinskevin.mitchell: Fix brain-o--we may not need project_ref, but we do need to create the project!22:06
openstackgerritA change was merged to openstack/keystone: Fix brain-o--we may not need project_ref, but we do need to create the project!  https://review.openstack.org/14722:06
openstackjenkinsProject keystone build #71: SUCCESS in 49 sec: http://jenkins.openstack.org/job/keystone/71/22:06
openstackjenkinsme: updated README with more accurate swift info22:06
openstackgerritA change was merged to openstack/keystone: updated README with more accurate swift info  https://review.openstack.org/14222:06
*** markvoelker has quit IRC22:07
openstackjenkinsProject keystone build #72: SUCCESS in 48 sec: http://jenkins.openstack.org/job/keystone/72/22:07
openstackjenkinsgithub: Small licensing change to test Gerrit22:07
openstackjenkinsProject keystone build #73: SUCCESS in 50 sec: http://jenkins.openstack.org/job/keystone/73/22:08
openstackjenkinsgithub: Small change to test Gerrit22:08
openstackgerritA change was merged to openstack/keystone: Small licensing change to test Gerrit  https://review.openstack.org/15322:08
openstackgerritA change was merged to openstack/keystone: Small change to test Gerrit  https://review.openstack.org/15222:08
openstackjenkinsProject keystone build #74: FAILURE in 4.3 sec: http://jenkins.openstack.org/job/keystone/74/22:08
openstackjenkinsJay Pipes: Gets Keystone a bit more inline with the way that22:08
openstackgerritVerification of a change to openstack/keystone failed: Gets Keystone a bit more inline with the way that other OpenStack projects run tests. Basically, adds the standard run_tests.sh script, modifies the run_tests.py script to do the following:  https://review.openstack.org/15422:08
openstackjenkinsYippie, build fixed!22:09
openstackjenkinsProject keystone build #75: FIXED in 48 sec: http://jenkins.openstack.org/job/keystone/75/22:09
openstackgerritVerification of a change to openstack/keystone failed: pep8 fixes round 1  https://review.openstack.org/14422:09
openstackjenkinstreyemorris: pep8 fixes round 122:09
openstackjenkinsProject keystone build #76: SUCCESS in 49 sec: http://jenkins.openstack.org/job/keystone/76/22:10
openstackjenkinssleepsonthefloor: this code appears to have been accidentally deleted.  if the project does not exist, it should be created22:10
openstackgerritRick Harris proposed a change to openstack/glance: Adds swift_enable_snet config  https://review.openstack.org/15622:13
*** mdomsch has quit IRC22:14
s1rpjaypipes: just pushed up the gerrit version of that patch22:14
s1rpjaypipes: lemme know if anything looks out-of-whack22:14
notmynamejeblair: jaypipes: mtaylor: my first gerrit change just got approved/merged. but since other things had been approved since I submitted my patch, gerrit merged it with a merge commit. I saw other people talking about that yesterday (I think). is that intended behavior?22:14
jeblairnotmyname: yes, that's intended [more...]22:16
jeblairnotmyname: we have gerrit set up to do fast-forwards if possible, or merges if needed to avoid having to rebase a patch every time the repo changes22:16
jeblairnotmyname: what is awkward with respect to merge commits is if you create one yourself and submit it22:17
notmynamejeblair: ok. I could have missed it, but it didn't look like the file had changed from other commits.22:17
jeblairnotmyname: yeah, i think it has to do a merge commit as long as your patch isn't a direct descendent of the current head22:18
notmynamejeblair: just wanted to know what was expected (if it was --no-ff or something)22:18
jeblairnotmyname: even if there are no file-level merges22:18
jeblairnotmyname: so, short version is that all sounds normal22:18
notmynamejeblair: so that could lead to problems right? if it can't resolve a merge?22:19
notmyname(or if it resolves it yet introduces a code bug)22:20
*** kbringard has quit IRC22:20
jeblairnotmyname: yes, if it really can't resolve one, then it will reject it, and you'd have to rebase it and upload a new version22:20
notmynameok22:20
mtaylorand it does the merge before it runs the tests ... so it does what it can to ensure that the merge doesn't introduce bugs ... we did discuss whether or not to only support FF merges... but it seemed like with as much activity as these branches see, it would mean you'd wind up rebasing your branch like a hundred times to try to get it in :)22:21
mtaylorwhich would be ... annoying22:21
notmynameindeed :-)22:24
notmynamegood to know it merges, then tests22:24
mtaylornotmyname: now all we need to do is get our test coverage to be perfect :)22:26
openstackgerritVerification of a change to openstack/keystone failed: Changes to support services.  https://review.openstack.org/13722:26
notmynamemtaylor: and write magical tests :-)22:26
vishyif anyone is trying to use lion for dev (especially with virtualbox!) this may be helpful: http://cloudbuilders.github.com/deploy.sh/development-nova-installation-using-vagrant-and-chef.html22:26
notmynamemtaylor: is this similar to what is currently done on LP? seems that everything in bzr is essentially a merge commit22:27
mtaylornotmyname: _everything_ on lp is a merge commit. with gerrit it is entirely possible to your changes go in as a fast-forward22:30
jeblairnotmyname: (not answering your current question, but going back to the merge-test-commit sequence you mentioned) because jenkins queues jobs that are triggered by gerrit approvals, we know that each commit will be merged into a copy of the repo by jenkins, tested, and then committed to the main repo in an atomic transaction.  in other words, what we commit to the main repo really was tested as committed. :)22:31
jkoelkeranyone know how to change a ForeignKey from one table to anther with the sqlalchemy-migrate?22:32
openstackjenkinsProject keystone build #77: FAILURE in 3.8 sec: http://jenkins.openstack.org/job/keystone/77/22:33
openstackjenkinsyoga80: Changes to support services.22:33
openstackgerritVerification of a change to openstack/keystone failed: Changes to support services.  https://review.openstack.org/13722:33
openstackgerritVerification of a change to openstack/keystone failed: Changes to support services.  https://review.openstack.org/13722:35
openstackgerritVerification of a change to openstack/keystone failed: Changes to support services.  https://review.openstack.org/13722:36
*** jkoelker has quit IRC22:38
notmynamejeblair: sure, but isn't there an edge case where it can resolve the merge but in doing so introduce a logic error? then the tests will fail (we hope)22:39
*** mattray has quit IRC22:41
jeblairnotmyname: it won't resolve file conflicts on its own, so that shouldn't happen, but if something like that happens some other way (ie, logic in commit b is incompatible with logic in commit a which was committed since commit b was branched from master), yes, we hope the tests will catch it.  since the tests and commits to the trunk are atomic, we _do_ know that trunk will not change between the time the test runs and it is committed.22:44
jeblairnotmyname: which gives the tests the best opporutinity to fail and tell us something is wrong22:45
openstackgerritVerification of a change to openstack/keystone failed: Changes to support services.  https://review.openstack.org/13722:46
notmynamejeblair: I agree that it's unlikely something will go through that both passes tests and introduces a bug. but it's something to be aware of, I guess22:47
jeblairnotmyname: i agree!22:48
notmynamejeblair: does gerrit have branch dependencies (ie don't merge this until that)?22:52
jeblairnotmyname: if a change has an ancestor commit that is another change, it recognizes that as a dependency22:53
notmynamejeblair: ok. anything beyond that?22:54
notmyname(I don't have feelings one way or the other, just looking for an answer)22:54
jeblairnotmyname: i don't believe so.  it does that automatically, and other than that i don't beleieve there's a way to manually tell it something similar22:54
notmynamejeblair: also, I don't see inline comments (eg like github has) in gerrit. am I missing it or is that not supported? (LP doesn't have it either22:55
jeblairnotmyname: it does have inline comments22:55
mtaylornotmyname: it's there - just double-click on a line :)22:55
jeblairwhat he said. :)22:55
notmynameah. poor UI strikes again ;-)22:55
openstackjenkinsYippie, build fixed!22:56
openstackjenkinsProject keystone build #78: FIXED in 54 sec: http://jenkins.openstack.org/job/keystone/78/22:56
openstackjenkinsyoga80: Changes to support services.22:56
* notmyname is a big fan of inline commits. makes reviews so much easier22:56
yogirackspaceopenstackjenkins:thanks ;)22:59
openstackjenkinsyogirackspace did you mean me? Unknown command 'thanks'22:59
openstackjenkinsUse '!jenkins help' to get help!22:59
*** yogirackspace has left #openstack-dev22:59
openstackjenkinsProject keystone build #79: FAILURE in 6.3 sec: http://jenkins.openstack.org/job/keystone/79/22:59
openstackgerritVerification of a change to openstack/keystone failed: Changes to support services.  https://review.openstack.org/13722:59
openstackjenkinsyoga80: Changes to support services.22:59
*** amccabe has quit IRC23:03
openstackjenkinsProject keystone build #80: STILL FAILING in 2.2 sec: http://jenkins.openstack.org/job/keystone/80/23:06
openstackgerritVerification of a change to openstack/keystone failed: Gets Keystone a bit more inline with the way that other OpenStack projects run tests. Basically, adds the standard run_tests.sh script, modifies the run_tests.py script to do the following:  https://review.openstack.org/15423:06
openstackjenkinsJay Pipes: Gets Keystone a bit more inline with the way that23:06
openstackjenkinsProject keystone build #81: STILL FAILING in 2.2 sec: http://jenkins.openstack.org/job/keystone/81/23:06
openstackgerritVerification of a change to openstack/keystone failed: Issue #115: Added support for testing multiple keystone configurations (sql-only, memcache, ldap)  https://review.openstack.org/13223:06
openstackjenkinsdolph.mathews: Issue #115: Added support for testing multiple keystone configurations (sql-only, memcache, ldap)23:06
openstackjenkinsProject keystone build #82: STILL FAILING in 1.9 sec: http://jenkins.openstack.org/job/keystone/82/23:06
openstackgerritVerification of a change to openstack/keystone failed: pep8 fixes round 1  https://review.openstack.org/14423:06
openstackjenkinstreyemorris: pep8 fixes round 123:06
*** mfer has quit IRC23:09
*** ckmason has joined #openstack-dev23:09
*** mattray has joined #openstack-dev23:10
*** mattray has quit IRC23:10
notmynamemtaylor: jeblair: perhaps it's just me, but the openstack bots are pretty chatty. just throwing this out there, but what about putting them in a buildbot channel?23:12
jeblairnotmyname: they are.  i'd like to remove redundant notifications first (we have some jenkins jobs where we should turn off notifications)23:13
mtaylorwhat jeblair said23:13
jeblairnotmyname: and also, i was just retriggering a bunch of jobs while working on a problem :/23:13
jeblairbut, if, after that, it's still too chatty, sure, we can do that23:14
*** ckmason has quit IRC23:17
*** CatKiller has quit IRC23:26
*** CatKiller has joined #openstack-dev23:26
*** RobertLaptop has quit IRC23:35
*** RobertLaptop has joined #openstack-dev23:35
*** JordanRinke has joined #openstack-dev23:35
*** mfer has joined #openstack-dev23:52
« Wednesday, 2011-08-03 Index Friday, 2011-08-05 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!