| *** brinzhang_ has joined #openstack-cyborg | 00:41 | |
| *** brinzhang0 has quit IRC | 00:44 | |
| *** brinzhang0 has joined #openstack-cyborg | 00:48 | |
| *** brinzhang_ has quit IRC | 00:51 | |
| *** brinzhang_ has joined #openstack-cyborg | 00:53 | |
| *** brinzhang0 has quit IRC | 00:56 | |
| openstackgerrit | YumengBao proposed openstack/cyborg master: P0: Refresh cyborg basic_policies and device_profile_policies https://review.opendev.org/740542 | 01:50 |
|---|---|---|
| openstackgerrit | YumengBao proposed openstack/cyborg master: P0: Refresh cyborg basic_policies and device_profile_policies https://review.opendev.org/740542 | 01:52 |
| openstackgerrit | YumengBao proposed openstack/cyborg master: P0: Refresh cyborg basic_policies and device_profile_policies https://review.opendev.org/740542 | 02:02 |
| *** Yumeng has joined #openstack-cyborg | 02:05 | |
| *** brinzhang0 has joined #openstack-cyborg | 02:28 | |
| *** brinzhang_ has quit IRC | 02:31 | |
| *** songwenping__ has joined #openstack-cyborg | 02:55 | |
| *** brinzhang_ has joined #openstack-cyborg | 02:58 | |
| *** brinzhang0 has quit IRC | 03:01 | |
| songwenping__ | Hi Yumeng, morning. | 03:02 |
| Yumeng | hi songwenping__, brinzhang_ | 03:02 |
| brinzhang_ | hi Yuemng, songwenping__ | 03:02 |
| *** chenke has joined #openstack-cyborg | 03:03 | |
| brinzhang_ | Yumeng: sorry, spelling error | 03:03 |
| Yumeng | haha, no worries | 03:03 |
| Yumeng | hi chenke | 03:03 |
| Yumeng | seems not much people today | 03:04 |
| chenke | hi yumeng. hi all. | 03:04 |
| songwenping__ | hi chenke | 03:04 |
| chenke | hi songwenping. | 03:04 |
| Yumeng | shall we just kick off the meeting now or wait a few minutes? | 03:05 |
| *** xinranwang__ has joined #openstack-cyborg | 03:05 | |
| Yumeng | hi xinranwang__ | 03:05 |
| xinranwang__ | Hi Yumeng | 03:05 |
| Yumeng | great. let's getting start! | 03:06 |
| Yumeng | #startmeeting openstack-cyborg | 03:06 |
| openstack | Meeting started Thu Jul 23 03:06:39 2020 UTC and is due to finish in 60 minutes. The chair is Yumeng. Information about MeetBot at http://wiki.debian.org/MeetBot. | 03:06 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 03:06 |
| *** openstack changes topic to " (Meeting topic: openstack-cyborg)" | 03:06 | |
| openstack | The meeting name has been set to 'openstack_cyborg' | 03:06 |
| Yumeng | #topic Roll call | 03:06 |
| *** openstack changes topic to "Roll call (Meeting topic: openstack-cyborg)" | 03:06 | |
| Yumeng | #info Yumeng | 03:06 |
| xinranwang__ | #info xinranwang__ | 03:07 |
| brinzhang_ | #info brinzhang_ | 03:07 |
| chenke | #info chenke | 03:07 |
| Yumeng | #topic Agenda | 03:07 |
| *** openstack changes topic to "Agenda (Meeting topic: openstack-cyborg)" | 03:07 | |
| songwenping__ | #info songwenping__ | 03:07 |
| Yumeng | #topic policy default refresh | 03:07 |
| *** openstack changes topic to "policy default refresh (Meeting topic: openstack-cyborg)" | 03:07 | |
| Yumeng | I updated this morning https://review.opendev.org/#/c/740542/ | 03:08 |
| Yumeng | now this patch submmited the basic policies and device_profile policies, and basic framwork | 03:08 |
| brinzhang_ | Yumeng: I was reviewed just now, but I am sorry not looked into. in general, LGTM, but that need to add the UT, I left comment inline. | 03:10 |
| Yumeng | both the old and new policies will both work during development process | 03:11 |
| brinzhang_ | Yumeng: after I compeleted thing in my hands, I will check again about the implemention details. | 03:11 |
| brinzhang_ | sound good. | 03:11 |
| brinzhang_ | we should keep old policies and new policies are all run good, thanks | 03:12 |
| Yumeng | brinzhang_: yes we need test. but not as easy as a unit test update in current API tests. that should be another tests for only policies, we should add new policy test framwork, that would be a big work. | 03:12 |
| brinzhang_ | Yumeng: I know, but in the patch if you dont add the UT, I dont think it's good to go. | 03:13 |
| Yumeng | I will submit the policy test in another patch, I just don't want to make the first patch too big. | 03:13 |
| brinzhang_ | you can splite the UT for add new policies, another patch is to add the new policies to the interface | 03:14 |
| Yumeng | for this patch, I have tested the function by current unit test, the test_create case of device_profile, I have pasted the detailed debug info to the commit message: http://paste.openstack.org/show/796229/ | 03:15 |
| xinranwang__ | Policy test framework is a big work. We can just add test in API test first | 03:15 |
| xinranwang__ | For example, add test in device_profile API, test create dp by non admin user, and it fails | 03:16 |
| brinzhang_ | xinranwang__: yeah, we can. But the better way is add as the same time. | 03:16 |
| xinranwang__ | Do you think this make sense | 03:16 |
| brinzhang_ | It make sense to me. But I also hope that it is not a TODO. | 03:17 |
| xinranwang__ | We can add api test in this patch. Policy test framwork can be in a new patch. | 03:18 |
| xinranwang__ | What do you think Yumeng | 03:18 |
| Yumeng | xinranwang__: yes! agree, current API tests will go through the policy check in each test. I will start in the next patch very soon to submit policy test for device_profile | 03:19 |
| brinzhang_ | thanks | 03:20 |
| Yumeng | but for this patch, I think the detailed debug info has shown the policy check process, which can show that this patch basically works, so we can start review. | 03:21 |
| Yumeng | this patch can be merged after the next policy test patch is passed and submitted, but can start review now. what do you think? | 03:23 |
| brinzhang_ | Yumeng, do you test the older policies? I saw you deprecated the old policies, I am not sure it's ok for all apis | 03:24 |
| brinzhang_ | https://review.opendev.org/#/c/740542/10/cyborg/policies/base.py@95 | 03:24 |
| brinzhang_ | Yumeng: this patch I think we (xinranwang__) dont reviewed into, after checked again, we can decide whether let it to go, do you think so? | 03:25 |
| brinzhang_ | is there a milestone? | 03:25 |
| Yumeng | the old policies are "not actually" deprecated, they won't actually deprecated until we set [oslo_policy] enforce_policy=True in cyborg.conf | 03:27 |
| Yumeng | the old policies work for now, they just marked as deprecated, not actually deprecated. | 03:27 |
| Yumeng | emmm. I think we should add tests for new policies, for the old policies, we will deprecate them after all the new policies are implemented | 03:28 |
| brinzhang_ | agree, so I think this change should have UT to cover the old policies and the new policies, and checked the enforce_policy config (of course you can do in another patch, but it will be not easy to review). | 03:29 |
| brinzhang_ | no, after you completed the new policies, we also need to keep the old policies run until W or X release | 03:30 |
| brinzhang_ | To ensure backward compatibility, we should not remove it so quickly. | 03:30 |
| brinzhang_ | What do you think? Yumeng, xinranwang__, songwenping__ | 03:31 |
| songwenping__ | Yumeng: you can fix the ut and pep8 first, ths. | 03:31 |
| Yumeng | brinzhang_: yes, that's what I planed. I have NOTE them in the code. deprecate_since W | 03:32 |
| xinranwang__ | Sorry, I am back | 03:32 |
| xinranwang__ | brinzhang_: yes, agree | 03:32 |
| Yumeng | xinranwang__: oPS, will see the pep8 error. don't know why. works fine in my env. | 03:33 |
| brinzhang_ | ok. I have nothing to say of this patch now | 03:35 |
| brinzhang_ | I have two patches need to go, it was submited for a looong time. https://review.opendev.org/#/c/734406/ and https://review.opendev.org/#/c/734403/ | 03:35 |
| Yumeng | brinzhang_: anyway. this patch defines the overall framwork, I wanna you guys help to review it. | 03:35 |
| brinzhang_ | Yumeng, xinranwang__, and all: Hope you can review all, thanks | 03:36 |
| brinzhang_ | Yumeng: of course ^^, it's my pleasure | 03:36 |
| songwenping__ | bingzhang_: will look into this patch. | 03:36 |
| Yumeng | brinzhang_: about the milestone, that was set to milestone-2, but we will see if we need postpone | 03:36 |
| xinranwang__ | https://www.irccloud.com/pastebin/z94K8fNV/ | 03:36 |
| Yumeng | brinzhang_: yse, will review | 03:37 |
| brinzhang_ | thanks | 03:37 |
| songwenping__ | brinzhang_: sorry for error spell. | 03:38 |
| brinzhang_ | xinranwang__: IRC cloud need to be jump the firewall, otherwise we cannot connect to it | 03:38 |
| Yumeng | xinranwang__: aha. thanks xinran. I will fix it. | 03:39 |
| xinranwang__ | Oh, I thought is works for PRC, never mind | 03:39 |
| Yumeng | Inspur FPGA driver spec: https://review.opendev.org/#/c/730760/ | 03:40 |
| Yumeng | songwenping__: just reviewed this morning. pls see my reply. | 03:40 |
| Yumeng | we can merge this before milestone-2 | 03:40 |
| songwenping__ | Yumeng: yeah, i see it. | 03:40 |
| Yumeng | also Intel QAT driver ready for review:https://review.opendev.org/#/c/728014/ | 03:41 |
| Yumeng | I will review again today. | 03:41 |
| xinranwang__ | thanks a lot | 03:41 |
| songwenping__ | thanks for review, i will check again. | 03:41 |
| Yumeng | And shogo's is also milestone-2. Programming support ready for review: https://review.opendev.org/#/c/698190/ | 03:42 |
| Yumeng | a big work. | 03:42 |
| brinzhang_ | songwenping__, xinranwang__:will review later | 03:42 |
| xinranwang__ | thanks brinzhang_ | 03:42 |
| Yumeng | xinranwang__: can you also ask haibing to help review this, I'm not expert in programming. | 03:43 |
| songwenping__ | thanks brinzhang__ | 03:43 |
| xinranwang__ | Yes, sure | 03:43 |
| Yumeng | thanks! | 03:45 |
| Yumeng | I have nothing else to mention for today. | 03:45 |
| Yumeng | Do you guys want to bring up anything else? | 03:45 |
| brinzhang_ | nothings by me | 03:46 |
| xinranwang__ | Just noticed that cyborg-tempest-plugins has no doc | 03:46 |
| xinranwang__ | shall we add some docs for it? | 03:47 |
| brinzhang_ | if necessagr we can | 03:48 |
| Yumeng | not sure if we need. | 03:48 |
| brinzhang_ | May there will be add in the future | 03:48 |
| Yumeng | I can take a look, we can decide later.:) | 03:48 |
| brinzhang_ | yeah | 03:48 |
| Yumeng | ok. sounds good. | 03:49 |
| Yumeng | let's wrap up this meeting and have a good lunch. | 03:49 |
| xinranwang__ | Ok, it's not urgent. Just mention it here.lol | 03:49 |
| xinranwang__ | Ok, thanks. Bye | 03:50 |
| Yumeng | see you next week. Thank you for attending! bye | 03:50 |
| songwenping__ | bye | 03:50 |
| Yumeng | #endmeeting | 03:51 |
| *** openstack changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 03:51 | |
| openstack | Meeting ended Thu Jul 23 03:51:00 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 03:51 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-07-23-03.06.html | 03:51 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-07-23-03.06.txt | 03:51 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-07-23-03.06.log.html | 03:51 |
| *** brinzhang0 has joined #openstack-cyborg | 04:41 | |
| *** brinzhang_ has quit IRC | 04:44 | |
| *** brinzhang_ has joined #openstack-cyborg | 04:45 | |
| *** brinzhang0 has quit IRC | 04:48 | |
| *** links has joined #openstack-cyborg | 04:49 | |
| *** brinzhang0 has joined #openstack-cyborg | 04:52 | |
| *** brinzhang has joined #openstack-cyborg | 04:55 | |
| *** brinzhang_ has quit IRC | 04:56 | |
| *** brinzhang0 has quit IRC | 04:57 | |
| *** brinzhang_ has joined #openstack-cyborg | 05:10 | |
| *** songwenping_ has joined #openstack-cyborg | 05:10 | |
| *** brinzhang0 has joined #openstack-cyborg | 05:13 | |
| *** brinzhang has quit IRC | 05:13 | |
| *** songwenping__ has quit IRC | 05:13 | |
| *** swp20 has joined #openstack-cyborg | 05:14 | |
| *** brinzhang_ has quit IRC | 05:16 | |
| *** songwenping_ has quit IRC | 05:16 | |
| *** chenke has quit IRC | 05:29 | |
| *** songwenping_ has joined #openstack-cyborg | 05:34 | |
| *** swp20 has quit IRC | 05:37 | |
| *** brinzhang_ has joined #openstack-cyborg | 05:39 | |
| *** brinzhang0 has quit IRC | 05:42 | |
| *** xinranwang__ has quit IRC | 05:53 | |
| *** songwenping__ has joined #openstack-cyborg | 06:23 | |
| *** songwenping_ has quit IRC | 06:26 | |
| *** songwenping_ has joined #openstack-cyborg | 06:43 | |
| *** songwenping__ has quit IRC | 06:46 | |
| *** songwenping__ has joined #openstack-cyborg | 07:21 | |
| *** songwenping_ has quit IRC | 07:24 | |
| *** songwenping_ has joined #openstack-cyborg | 09:58 | |
| *** songwenping__ has quit IRC | 10:01 | |
| *** songwenping_ has quit IRC | 10:32 | |
| openstackgerrit | Xinran WANG proposed openstack/cyborg-specs master: Add Intel QAT driver specification. https://review.opendev.org/728014 | 10:35 |
| *** swp20 has joined #openstack-cyborg | 12:29 | |
| *** songwenping_ has joined #openstack-cyborg | 12:43 | |
| *** swp20 has quit IRC | 12:46 | |
| *** songwenping__ has joined #openstack-cyborg | 13:23 | |
| *** songwenping_ has quit IRC | 13:26 | |
| *** songwenping_ has joined #openstack-cyborg | 13:46 | |
| *** songwenping__ has quit IRC | 13:49 | |
| *** Yumeng has quit IRC | 14:06 | |
| *** links has quit IRC | 14:41 | |
| *** brinzhang0 has joined #openstack-cyborg | 16:07 | |
| *** songwenping__ has joined #openstack-cyborg | 16:07 | |
| *** brinzhang_ has quit IRC | 16:10 | |
| *** songwenping_ has quit IRC | 16:10 | |
| *** songwenping_ has joined #openstack-cyborg | 16:48 | |
| *** songwenping__ has quit IRC | 16:51 | |
| *** songwenping__ has joined #openstack-cyborg | 17:13 | |
| *** songwenping_ has quit IRC | 17:16 | |
| *** brinzhang_ has joined #openstack-cyborg | 18:16 | |
| *** brinzhang0 has quit IRC | 18:19 | |
| *** songwenping_ has joined #openstack-cyborg | 18:34 | |
| *** songwenping__ has quit IRC | 18:36 | |
| *** songwenping__ has joined #openstack-cyborg | 18:43 | |
| *** songwenping_ has quit IRC | 18:47 | |
| *** brinzhang0 has joined #openstack-cyborg | 19:17 | |
| *** brinzhang_ has quit IRC | 19:20 | |
| *** brinzhang_ has joined #openstack-cyborg | 19:37 | |
| *** brinzhang0 has quit IRC | 19:41 | |
| *** songwenping_ has joined #openstack-cyborg | 20:13 | |
| *** songwenping__ has quit IRC | 20:16 | |
| *** songwenping__ has joined #openstack-cyborg | 20:43 | |
| *** songwenping_ has quit IRC | 20:46 | |
| *** songwenping_ has joined #openstack-cyborg | 21:23 | |
| *** songwenping__ has quit IRC | 21:26 | |
| *** songwenping__ has joined #openstack-cyborg | 21:48 | |
| *** songwenping_ has quit IRC | 21:51 | |
| *** songwenping_ has joined #openstack-cyborg | 22:03 | |
| *** songwenping__ has quit IRC | 22:06 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!