*** brinzhang_ has quit IRC | 00:01 | |
*** brinzhang has joined #openstack-cyborg | 00:11 | |
brinzhang | gmann: I would like to add the contributing from https://review.opendev.org/#/c/712246/5/doc/source/contributor/contributing.rst to common contribution docs, but I found there already exist, but it is hard to find, | 00:41 |
---|---|---|
brinzhang | gmann: and it is not on the same page as the use of git, which makes me very uncomfortable. | 00:41 |
brinzhang | using git page https://docs.openstack.org/contributors/common/git.html#id1 | 00:42 |
brinzhang | using gerrit paage https://docs.openstack.org/contributors/common/setup-gerrit.html#what-is-gerrit | 00:42 |
openstackgerrit | Wenping Song proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584 | 00:42 |
brinzhang | IMO, they are should in one page, or need some super link | 00:43 |
*** xinranwang has joined #openstack-cyborg | 02:02 | |
openstackgerrit | YumengBao proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089 | 02:52 |
*** Yumeng has joined #openstack-cyborg | 02:55 | |
*** s_shogo has joined #openstack-cyborg | 02:59 | |
Yumeng | hi xinranwang,xinranwang and Li_Liu | 03:03 |
xinranwang | Hi | 03:03 |
Yumeng | hi hi. | 03:03 |
Yumeng | hi Li_Liu | 03:03 |
Yumeng | hi brinzhang | 03:04 |
s_shogo | Hi all | 03:04 |
brinzhang | Hi Yumeng and all, today I have some need to do right now, I am sorry cannot participate in today's meetting | 03:05 |
*** chenke has joined #openstack-cyborg | 03:05 | |
Yumeng | ok. no worries. let's get started | 03:05 |
Yumeng | #startmeeting openstack-cyborg | 03:05 |
openstack | Meeting started Thu Apr 9 03:05:59 2020 UTC and is due to finish in 60 minutes. The chair is Yumeng. Information about MeetBot at http://wiki.debian.org/MeetBot. | 03:06 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 03:06 |
chenke | Hi all. sorry for later. | 03:06 |
*** openstack changes topic to " (Meeting topic: openstack-cyborg)" | 03:06 | |
openstack | The meeting name has been set to 'openstack_cyborg' | 03:06 |
chenke | #info chenke | 03:06 |
xinranwang | #info xinranwang | 03:06 |
Yumeng | #topic Roll call | 03:06 |
*** openstack changes topic to "Roll call (Meeting topic: openstack-cyborg)" | 03:06 | |
Yumeng | #info Yumeng | 03:06 |
s_shogo | #info s_shogo | 03:06 |
Yumeng | I suppose the agenda for today is reviewing pending patches | 03:07 |
Yumeng | let's go through by priorities from high | 03:08 |
xinranwang | The microverison patch has been merged, thank you all for reviewing :) | 03:08 |
chenke | good job. | 03:08 |
Yumeng | great! Thanks Xinran for the efforts ! and v2 doc need review https://review.opendev.org/#/c/715980/ | 03:09 |
xinranwang | Yes, please review this doc patch as well. thanks Yumeng | 03:10 |
Yumeng | s_shogo and xinranwang, do you have any other patches need review? | 03:11 |
xinranwang | No other patches from m | 03:11 |
xinranwang | *me | 03:12 |
Yumeng | ok | 03:12 |
openstackgerrit | YumengBao proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089 | 03:12 |
s_shogo | This one. I'm working with Sundar's comment. https://review.opendev.org/#/c/698190/ | 03:12 |
chenke | Ok. will reivew it. | 03:13 |
s_shogo | Shaohe may have opinion about this programming patch, as the previous meeting : I can ask him in wechat. | 03:14 |
s_shogo | thank you, chenke | 03:14 |
Yumeng | I notice shaohe also has several patches realted to programming https://review.opendev.org/#/q/owner:shaohe.feng%2540intel.com+status:open | 03:14 |
Yumeng | are they related to yours? s_shogo | 03:15 |
s_shogo | At a glance, It seems to be driver layer, my patch provides api. | 03:16 |
s_shogo | I'll investigate and check them after this meeting, thanks. | 03:16 |
Yumeng | ok. seems different. I will ask him if need merged in this release. | 03:16 |
s_shogo | ok. | 03:17 |
Yumeng | so there also left Brin's patches https://review.opendev.org/#/q/owner:zhangbailin%2540inspur.com+status:open | 03:17 |
Yumeng | and mine two: arq refactor https://review.opendev.org/#/c/696089/, and add policy role https://review.opendev.org/#/c/699102/ | 03:18 |
Yumeng | please help to review! not big change. | 03:19 |
Yumeng | chenke: do you have any pending patches? | 03:20 |
chenke | oh. no patch for me. But a patch needs us wo notice. | 03:20 |
xinranwang | Ok, will review them. | 03:20 |
chenke | https://review.opendev.org/#/c/718584/1/cyborg/conductor/manager.py | 03:20 |
chenke | This patch seems help cyborg to sync data with placement. We should consider whether it's needed or not. | 03:21 |
xinranwang | Yes, I just saw this. | 03:23 |
xinranwang | IMO, it is reasonable. | 03:24 |
Yumeng | +1 agree with Brin's comment. xinranwang: do we plan to decouple placement report in next release? | 03:25 |
chenke | It looks okay, but needs further analysis. | 03:26 |
xinranwang | I think it depends on users' demand, if we want cyborg run as a standalone project, yes, we should decouple them | 03:27 |
chenke | It looks okay, but needs further analysis. To be honest, the current piece of code looks a bit redundant. About placement reporting and cyborg database update are mixed together. But I have no better idea about decoupling them. | 03:29 |
xinranwang | chenke: yes, that's what I am thinking too. If we want decouple them, it will generate more redundant code, because both of them need to do the diff. | 03:30 |
chenke | Ye. seems no better code to make report and sync cyborg db. Let's these code stay as it is. | 03:32 |
Yumeng | emmm,seems a problem to choose a less evil one. let's keep it as one topic of the PTG. | 03:32 |
Yumeng | #topic AoB | 03:33 |
*** openstack changes topic to "AoB (Meeting topic: openstack-cyborg)" | 03:33 | |
Yumeng | Anything else? | 03:33 |
brinzhang | https://review.opendev.org/#/c/718584/1/cyborg/conductor/manager.py are you talking this patch? | 03:33 |
Yumeng | yes brinzhang | 03:33 |
xinranwang | Yumeng: Sure, btw, do we have ptg etherpad where we can put the topic in, I'd like add some :) | 03:34 |
brinzhang | I dont think we should keep current logical, if so, maybe when we do next cycle to add a device, we cannot get the device occupied in obj | 03:34 |
chenke | Hi brin. "we cannot get the device occupied in obj" means what? | 03:35 |
Yumeng | xinranwang: ok, will let you know later. I will discuss with Sundar, and maybe we can create one! | 03:35 |
xinranwang | chenke: I think this patch does solve problems, it does not change the main logic, just revert the cyborg DB. I think it is useful. | 03:36 |
chenke | Agree. | 03:36 |
brinzhang | IMHO, the logic of the current code in this file makes it complicated to read. If possible, I hope to be able to refactor it. | 03:36 |
xinranwang | Yumeng: thanks! | 03:36 |
brinzhang | xinranwang, right, it just resolve the problem, not change any logical | 03:36 |
chenke | brinzhang. Agree. If we have better solution. I want to talk about it. | 03:37 |
Yumeng | brinzhang: yes. let's discuss it more detaily. | 03:37 |
brinzhang | Yumeng: We can take https://review.opendev.org/#/q/status:open+project:openstack/cyborg+branch:master+topic:unittest.mock to PTG | 03:37 |
xinranwang | brinzhang: Yes, we are trying to find a way to decouple the code. There is still some gaps. We'd better let it be like it is(the main logic) in this release, and we can discuss in PTG. | 03:38 |
brinzhang | Sundar think we cannot do this right now, but whatever we shuold do sooner or later | 03:38 |
brinzhang | yes xinranwang, https://review.opendev.org/#/c/718584 isnot change it's logical, we can looked into later | 03:39 |
Yumeng | ok. I will paste the PTG etherpad later. let's add topics. | 03:39 |
brinzhang | https://review.opendev.org/#/c/717519/. | 03:39 |
brinzhang | https://review.opendev.org/#/c/717520/ | 03:39 |
brinzhang | above two patches, I think we should merge, because of droped py27 from Cyborg | 03:40 |
brinzhang | many projects are done of this cleanup | 03:40 |
xinranwang | Another thing: There is still some operations are not supported in nova like shelve/unshelve. I'd like to investigate it and do this part in next release if possible. I will add this topic to PTG etherpad too. | 03:41 |
Yumeng | Great! Thanks Xinran! | 03:41 |
Yumeng | will review them Brin. | 03:41 |
Yumeng | if nothing else. Let's wrap up this meeting and I'll see you all again next week | 03:41 |
Yumeng | Thank you all. have a good day! | 03:42 |
xinranwang | Thanks Yumeng | 03:42 |
xinranwang | Bye bye all | 03:42 |
Yumeng | Bye | 03:42 |
Yumeng | #endmeeting | 03:42 |
*** openstack changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 03:42 | |
openstack | Meeting ended Thu Apr 9 03:42:42 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 03:42 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-04-09-03.05.html | 03:42 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-04-09-03.05.txt | 03:42 |
openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-04-09-03.05.log.html | 03:42 |
s_shogo | bye | 03:42 |
*** s_shogo has quit IRC | 03:42 | |
*** brinzhang_ has joined #openstack-cyborg | 04:14 | |
*** brinzhang has quit IRC | 04:17 | |
*** brinzhang has joined #openstack-cyborg | 04:43 | |
*** brinzhang_ has quit IRC | 04:46 | |
*** brinzhang_ has joined #openstack-cyborg | 04:49 | |
*** brinzhang has quit IRC | 04:53 | |
*** brinzhang has joined #openstack-cyborg | 04:54 | |
*** brinzhang_ has quit IRC | 04:57 | |
*** brinzhang_ has joined #openstack-cyborg | 05:13 | |
*** brinzhang_ has quit IRC | 05:15 | |
*** brinzhang_ has joined #openstack-cyborg | 05:15 | |
*** brinzhang has quit IRC | 05:16 | |
*** brinzhang has joined #openstack-cyborg | 05:20 | |
*** brinzhang_ has quit IRC | 05:23 | |
*** brinzhang_ has joined #openstack-cyborg | 05:32 | |
*** brinzhang has quit IRC | 05:36 | |
*** brinzhang has joined #openstack-cyborg | 05:49 | |
*** brinzhang has quit IRC | 05:51 | |
*** brinzhang has joined #openstack-cyborg | 05:51 | |
*** brinzhang_ has quit IRC | 05:52 | |
*** chenke has quit IRC | 05:54 | |
*** brinzhang_ has joined #openstack-cyborg | 07:13 | |
*** brinzhang has quit IRC | 07:16 | |
*** Yumeng has quit IRC | 07:20 | |
openstackgerrit | Brin Zhang proposed openstack/cyborg master: Bump openstacksdk 0.46.0 https://review.opendev.org/718606 | 07:27 |
openstackgerrit | Merged openstack/cyborg-tempest-plugin master: Update to hacking 3.0 https://review.opendev.org/717519 | 07:30 |
openstackgerrit | Brin Zhang proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584 | 07:31 |
openstackgerrit | Brin Zhang proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089 | 07:31 |
*** jraju__ has joined #openstack-cyborg | 07:35 | |
openstackgerrit | Brin Zhang proposed openstack/cyborg master: Bump openstacksdk>=0.46.0 https://review.opendev.org/718606 | 07:39 |
*** brinzhang has joined #openstack-cyborg | 07:51 | |
*** brinzhang_ has quit IRC | 07:54 | |
openstackgerrit | Brin Zhang proposed openstack/cyborg master: Bump openstacksdk>=0.46.0 https://review.opendev.org/718606 | 08:12 |
openstackgerrit | Brin Zhang proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089 | 08:13 |
openstackgerrit | Brin Zhang proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584 | 08:14 |
*** brinzhang_ has joined #openstack-cyborg | 08:49 | |
*** brinzhang has quit IRC | 08:52 | |
*** brinzhang has joined #openstack-cyborg | 08:58 | |
*** brinzhang_ has quit IRC | 09:01 | |
openstackgerrit | Wenping Song proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584 | 09:30 |
*** brinzhang_ has joined #openstack-cyborg | 09:59 | |
*** brinzhang has quit IRC | 10:02 | |
openstackgerrit | Wenping Song proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584 | 10:06 |
openstackgerrit | YumengBao proposed openstack/cyborg master: Bump openstacksdk>=0.46.0 https://review.opendev.org/718606 | 10:32 |
openstackgerrit | YumengBao proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089 | 10:32 |
openstackgerrit | YumengBao proposed openstack/cyborg master: Bump openstacksdk>=0.46.0 https://review.opendev.org/718606 | 10:41 |
openstackgerrit | YumengBao proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584 | 10:41 |
openstackgerrit | YumengBao proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089 | 10:42 |
openstackgerrit | Wenping Song proposed openstack/cyborg master: sync data for placement https://review.opendev.org/718662 | 11:07 |
*** igordc has quit IRC | 12:18 | |
*** xinranwang has quit IRC | 12:30 | |
*** brinzhang has joined #openstack-cyborg | 16:57 | |
*** brinzhang_ has quit IRC | 17:00 | |
*** jraju__ has quit IRC | 17:15 | |
openstackgerrit | Andreas Jaeger proposed openstack/cyborg-specs master: Cleanup py27 support and docs https://review.opendev.org/718783 | 19:47 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!