*** tetsuro has joined #openstack-cyborg | 00:10 | |
*** tetsuro has quit IRC | 00:12 | |
*** tetsuro has joined #openstack-cyborg | 00:13 | |
*** tetsuro has quit IRC | 00:19 | |
*** tetsuro has joined #openstack-cyborg | 00:20 | |
*** sean-k-mooney2 has joined #openstack-cyborg | 00:26 | |
*** sean-k-mooney1 has quit IRC | 00:27 | |
*** tetsuro_ has joined #openstack-cyborg | 00:30 | |
*** tetsuro has quit IRC | 00:33 | |
*** brinzhang has joined #openstack-cyborg | 00:52 | |
*** sean-k-mooney2 has quit IRC | 00:53 | |
*** TxGirlGeek has quit IRC | 00:53 | |
*** sean-k-mooney2 has joined #openstack-cyborg | 00:55 | |
*** brinzhang has quit IRC | 00:57 | |
*** brinzhang has joined #openstack-cyborg | 00:57 | |
*** sean-k-mooney2 has quit IRC | 01:08 | |
*** brinzhang_ has joined #openstack-cyborg | 01:20 | |
*** brinzhang has quit IRC | 01:23 | |
*** chenke has joined #openstack-cyborg | 01:55 | |
*** openstackgerrit has joined #openstack-cyborg | 02:49 | |
openstackgerrit | Xinran WANG proposed openstack/cyborg master: Deployable V2 API implementation https://review.opendev.org/712835 | 02:49 |
---|---|---|
*** xinranwang has joined #openstack-cyborg | 02:58 | |
*** s_shogo has joined #openstack-cyborg | 03:00 | |
*** Sundar has joined #openstack-cyborg | 03:01 | |
Sundar | Hello all o/ | 03:01 |
xinranwang | Hi all | 03:01 |
s_shogo | Hi all | 03:02 |
brinzhang_ | \o | 03:02 |
Sundar | #startmeeting openstack-cyborg | 03:02 |
openstack | Meeting started Thu Mar 19 03:02:15 2020 UTC and is due to finish in 60 minutes. The chair is Sundar. Information about MeetBot at http://wiki.debian.org/MeetBot. | 03:02 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 03:02 |
*** openstack changes topic to " (Meeting topic: openstack-cyborg)" | 03:02 | |
openstack | The meeting name has been set to 'openstack_cyborg' | 03:02 |
Sundar | Agenda: https://wiki.openstack.org/wiki/Meetings/CyborgTeamMeeting#Agenda | 03:02 |
Sundar | #topic Roll call | 03:02 |
*** openstack changes topic to "Roll call (Meeting topic: openstack-cyborg)" | 03:02 | |
Sundar | #info SUndar | 03:02 |
brinzhang_ | #info brinzhang | 03:03 |
xinranwang | #info xinranwang | 03:03 |
s_shogo | #info s_shogo | 03:03 |
Sundar | Do we have a qorum to discuss the doc subject? May be we can wait a minute for chenke and Yumeng? | 03:04 |
Sundar | *quorum | 03:04 |
brinzhang_ | agree | 03:04 |
Sundar | chenke needs a bit more time | 03:07 |
*** shaohe_feng has joined #openstack-cyborg | 03:07 | |
Sundar | brinzhang_: Do you want to get started on the docs? | 03:07 |
brinzhang_ | chenke has a disagree point with https://review.opendev.org/#/c/711869/2/doc/source/index.rst@59 | 03:09 |
Sundar | Reference to previous doc disucssion: http://eavesdrop.openstack.org/irclogs/%23openstack-cyborg/%23openstack-cyborg.2020-03-12.log.html#t2020-03-12T03:48:25 | 03:09 |
brinzhang_ | I think I should wait him, we can start other topic, and then talked this | 03:09 |
Sundar | ok | 03:10 |
brinzhang_ | Sundar, thanks send the privous ideas, I will resend it | 03:10 |
chenke | #info chenke | 03:10 |
brinzhang_ | I would like to improve the cyborg docs, such as the https://docs.openstack.org/cyborg/latest/ | 03:10 |
brinzhang_ | I would like to improve the cyborg docs, such as the https://docs.openstack.org/cyborg/latest/ | 03:10 |
brinzhang_ | I would like to improve the cyborg docs, such as the https://docs.openstack.org/cyborg/latest/ | 03:11 |
brinzhang_ | Sorry.. | 03:11 |
brinzhang_ | Sundar, start now, chenke coming | 03:11 |
chenke | Sorry, late. | 03:12 |
*** Yumeng has joined #openstack-cyborg | 03:12 | |
Sundar | NP, chenke. Sure, let's get started | 03:12 |
Yumeng | #info Yumeng | 03:12 |
chenke | ok | 03:12 |
Yumeng | Hi all, sorry for late. | 03:12 |
brinzhang_ | https://review.opendev.org/#/c/711869/3/doc/source/index.rst | 03:12 |
brinzhang_ | Hi all, let talking about this docs change, any suggestions? | 03:13 |
brinzhang_ | chenke, I donot know another perfact tittle to change "Writing to the API" | 03:14 |
brinzhang_ | if someone can give a good idea, I will be appreviate | 03:14 |
chenke | How about Docs related API | 03:15 |
Sundar | How about: "Using the API"? | 03:15 |
brinzhang_ | And is there others link should I add in the latest page? | 03:15 |
chenke | Using the API +1 | 03:15 |
brinzhang_ | If I add the api_microversion_history to the index page, it sound not good yet | 03:16 |
Sundar | Line 89,90: Who knows what genondex and modindex do? | 03:16 |
brinzhang_ | but Using the API is ok for me | 03:16 |
brinzhang_ | Sundar, I dont know what is and I dont why we need Line 89,90 | 03:17 |
chenke | I think we can remove | 03:17 |
chenke | LIne 89,90 just a link to the useless link.:https://2346739f9f4d66197c40-6f04b689d71be05d52bf14ef78b20a44.ssl.cf2.rackcdn.com/711869/2/check/openstack-tox-docs/ed5106b/docs/ | 03:18 |
Sundar | agreed | 03:18 |
brinzhang_ | agree | 03:19 |
Sundar | Anything else on this subject? | 03:20 |
Yumeng | agree both. using the API is good for understanding. remove useless doc also makes it cleaer. | 03:20 |
brinzhang_ | If anything need to add this, I think it's ok | 03:21 |
Sundar | OK Sounds good. | 03:21 |
s_shogo | Using the API seems to be natural,agree. | 03:21 |
brinzhang_ | Ok | 03:22 |
Sundar | On Nova status, I have been off for a few days for personal reasons, but hope to get back to it soon. | 03:22 |
Sundar | Any other topic to discuss? | 03:23 |
brinzhang_ | xinranwang: do we need to talked of the microversion change? | 03:23 |
brinzhang_ | https://review.opendev.org/#/c/696860/5 | 03:24 |
xinranwang | yes | 03:25 |
xinranwang | Thanks Brin | 03:25 |
brinzhang_ | np | 03:25 |
xinranwang | Now we only support 2.0 version | 03:25 |
brinzhang_ | My mainly concern is https://review.opendev.org/#/c/696860/5/cyborg/api/controllers/v2/versions.py@24, I think we should use completed version nubmer to help Cyborg control the microversion change | 03:26 |
openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add Cyborg API Reference to Cyborg index https://review.opendev.org/711869 | 03:28 |
Sundar | I suggest we follow the precedent of placement or nova. Should we get cdent or somebody to review this? | 03:29 |
xinranwang | yes, Cyborg also use completed version number | 03:29 |
xinranwang | which locate L29 L30 in version.py | 03:29 |
xinranwang | brinzhang_: | 03:29 |
xinranwang | It is not the same framework, maybe ironic and watcher is more similiar | 03:30 |
brinzhang_ | xinranwang: yeah, for my comments, do we need L24 and L26? | 03:30 |
xinranwang | brinzhang_: it is easy for recording every microversion history | 03:30 |
brinzhang_ | xinranwang: And I think we need to change the _MIN_VERSION_STRING to _MIN_API_VERSION | 03:30 |
xinranwang | brinzhang_: how | 03:31 |
brinzhang_ | xinranwang: If we will change microversion to 3.0, this way seems not easy to convert, right? | 03:32 |
brinzhang_ | xinranwag: maybe it will be have a long time | 03:32 |
xinranwang | the version 3 will be implemented in v3 repo, not here | 03:32 |
xinranwang | and in controller/v3 repo, it will has its own versions.py file | 03:33 |
brinzhang_ | xinranwang: Ok, if so, threre is just some nits inline for me, just the defined parameters ^^ | 03:33 |
xinranwang | Ok | 03:34 |
xinranwang | This is pecan specific, which is diffirent from nova ;) | 03:35 |
brinzhang_ | I know, just want to have a good way to maintain ^^ | 03:35 |
xinranwang | Yes, so do we all agree to maintain like this? | 03:36 |
brinzhang_ | aree, but I would like you can change the defined parameter name (also just a nit) | 03:37 |
brinzhang_ | xinranwang:s/aree/agree | 03:37 |
xinranwang | Ok, thanks | 03:38 |
brinzhang_ | Sundar, chenke, Yumeng, s_shogo, do you all have some idea of this ? | 03:38 |
Sundar | For me too, it is just those minor points about variable names. | 03:38 |
chenke | @xinran Overall LGTM. I will. review it again. | 03:39 |
chenke | Yes | 03:39 |
Yumeng | yes. features are good enough. | 03:40 |
brinzhang_ | thanks xinranwang and all | 03:40 |
brinzhang_ | Sundar, pls do next agenda | 03:40 |
xinranwang | There are other projects naming with release name. If you guys prefer other ways like ADD_X_PARAM, I will update it. It is flexible. | 03:40 |
xinranwang | btw, please review deployabel API patch when you got time, I think it is almost ready. | 03:41 |
chenke | +1 | 03:41 |
Sundar | I don't have any specific next agenda item. | 03:41 |
chenke | how about your nova patches? | 03:42 |
chenke | Sundar | 03:42 |
brinzhang_ | xinranwang: just need change _MIN_VERSION_STRING to _MIN_API_VERSION, and use current_api_version or thers you thinks instead of "Version.sting" | 03:42 |
Sundar | xinranwang: Could you add a pointer to those projects's code that uses release names? If there is any precedent code that I can look at, for microversions in general, that would be useful. | 03:42 |
xinranwang | sure, let me find it. | 03:43 |
Sundar | chenke: I have got some review comments on Novapatches. I was off for a few days but will resume again. | 03:43 |
chenke | Okay. | 03:44 |
Sundar | xinranwang: You can provide those references in Gerrit. | 03:45 |
Sundar | Anything else, folks? | 03:45 |
s_shogo | Mere Reporting , the client topic mentioned in the last IRC : the cyborg client from pip doesn't include sdk implementation now.(That doesn't be released yet.) | 03:45 |
brinzhang_ | https://review.opendev.org/#/q/status:open+project:openstack/cyborg+branch:master+topic:story/2007397 | 03:45 |
brinzhang_ | pls review this change, I think it's ready to go | 03:46 |
xinranwang | Sundar: ok | 03:47 |
brinzhang_ | s_shogo: so cyborgclinet can support "pip install" and the "SDK" doesnot, right? | 03:47 |
brinzhang_ | I have used pip install to install the cyborgclient, but not try to test SDK yet | 03:48 |
s_shogo | brinzhang_ sdk is ok , but client is not yet. | 03:48 |
s_shogo | (by pip) | 03:49 |
brinzhang_ | s_shogo: get it, but I can install python-cyborgclinet to my local env (devstack). I will check the client version again | 03:50 |
s_shogo | brinzhang_ thanks .The client installed pip is probably old one,without sdk version. | 03:51 |
brinzhang_ | root@ubuntu-OpenStack:~# cyborg --version | 03:51 |
brinzhang_ | 1.0.0 | 03:51 |
*** tetsuro_ has quit IRC | 03:51 | |
brinzhang_ | Ah, 1.0.0 | 03:52 |
Sundar | brinzhang_: I think https://review.opendev.org/#/q/status:open+project:openstack/cyborg+branch:master+topic:story/2007397 needs to be updated, because the top patches are based on PS 4/6 of the bottom patch, instead of the latest 6/6. | 03:52 |
brinzhang_ | Sundar, it's not any impact | 03:53 |
brinzhang_ | the base patch just update the json data | 03:53 |
Sundar | ok | 03:54 |
brinzhang_ | Sundar: Thanks | 03:55 |
Sundar | Any thoughts or reviews of https://review.opendev.org/#/c/712231/ ? | 03:56 |
Sundar | Oh, I see some comments, but no -1. WIll respond to the comments | 03:57 |
brinzhang_ | Sundar I left some comments inline^^ | 03:57 |
Sundar | ok | 03:57 |
Yumeng | I was reviewing it yesterday. but not finished. | 03:58 |
Sundar | Thanks, brinzhang_ | 03:58 |
Yumeng | I will review it today. | 03:58 |
Sundar | Yumeng, I'll wait, no rush | 03:58 |
Yumeng | ^^ ok | 03:58 |
Sundar | Anything else, folks? | 03:58 |
openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add description column to device_profiles db https://review.opendev.org/703285 | 03:58 |
Yumeng | nope from my side. | 03:59 |
openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add 'description' field to the device profile object https://review.opendev.org/703293 | 03:59 |
Yumeng | ops. https://review.opendev.org/#/c/709433/ need final review. | 03:59 |
Yumeng | thanks! | 03:59 |
brinzhang_ | Sundar: About https://review.opendev.org/#/c/703293/, I was rebased on the latest change, pls see again | 04:00 |
brinzhang_ | nothing else | 04:00 |
brinzhang_ | Yumeng: Will review at afternoon | 04:01 |
Sundar | Ok | 04:01 |
Yumeng | Thank you Brin. | 04:01 |
Sundar | Thanks everybody. Have a good week. | 04:01 |
Sundar | #endmeeting | 04:01 |
*** openstack changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 04:01 | |
openstack | Meeting ended Thu Mar 19 04:01:37 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 04:01 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-03-19-03.02.html | 04:01 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-03-19-03.02.txt | 04:01 |
openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-03-19-03.02.log.html | 04:01 |
Yumeng | bye. | 04:01 |
xinranwang | Yumeng: LGTM | 04:01 |
xinranwang | bye | 04:01 |
s_shogo | bye | 04:02 |
*** s_shogo has quit IRC | 04:02 | |
brinzhang_ | Sundar: pls see the base patch, the latest patch depend on the base patch ^ | 04:02 |
brinzhang_ | bye~ | 04:02 |
openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add Cyborg API Reference to Cyborg index https://review.opendev.org/711869 | 04:02 |
*** Sundar has quit IRC | 04:05 | |
*** tetsuro has joined #openstack-cyborg | 04:16 | |
*** tetsuro_ has joined #openstack-cyborg | 04:49 | |
*** tetsuro has quit IRC | 04:52 | |
*** tetsuro has joined #openstack-cyborg | 05:03 | |
*** tetsuro_ has quit IRC | 05:06 | |
*** tetsuro_ has joined #openstack-cyborg | 05:15 | |
*** tetsuro has quit IRC | 05:18 | |
*** links has joined #openstack-cyborg | 05:32 | |
chenke | why brin still not have +2 ? | 06:02 |
chenke | brinzhang_ | 06:02 |
brinzhang_ | chenke, maybe tomorrow? We can go to wechat ask Sundar ^^ | 06:03 |
brinzhang_ | he seems not in irc | 06:04 |
chenke | oh. I think he need to add you to core group | 06:04 |
brinzhang_ | chenke, thanks | 06:04 |
chenke | I remind him in wechat. | 06:05 |
brinzhang_ | chenke: yeah, thanks again :) | 06:05 |
chenke | np | 06:06 |
*** xinranwang has quit IRC | 06:07 | |
openstackgerrit | Merged openstack/cyborg master: Fix GPU's improper cpid_type allowed value and attach_handle_type value https://review.opendev.org/709433 | 06:42 |
*** chenke has quit IRC | 07:35 | |
openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add Cyborg API Reference to Cyborg index page https://review.opendev.org/711869 | 07:48 |
*** tetsuro_ has quit IRC | 07:49 | |
*** Yumeng has quit IRC | 07:58 | |
*** tetsuro has joined #openstack-cyborg | 08:34 | |
*** tetsuro_ has joined #openstack-cyborg | 08:40 | |
*** tetsuro has quit IRC | 08:43 | |
*** shaohe_feng has quit IRC | 09:34 | |
*** tetsuro has joined #openstack-cyborg | 09:40 | |
*** tetsuro_ has quit IRC | 09:43 | |
*** tetsuro has quit IRC | 09:56 | |
*** jraju__ has joined #openstack-cyborg | 12:43 | |
*** links has quit IRC | 12:44 | |
*** sean-k-mooney2 has joined #openstack-cyborg | 12:53 | |
*** sean-k-mooney2 is now known as sean-k-mooney | 12:53 | |
*** jraju__ has quit IRC | 14:42 | |
*** Sundar has joined #openstack-cyborg | 16:31 | |
Sundar | dansmith, sean-k-moone, gibi: I've been away for a few days. Starting today, I intend to make one final push to get the Cyborg series done. I have roughly a week to wrap things up in my current role and move on. It is good to see that every patch got some review. | 16:35 |
dansmith | Sundar: great thanks | 16:35 |
Sundar | dansmith: Thanks for your reviews. I am looking to include most of them. | 16:37 |
Sundar | Regarding your comment about not including a comment :): https://review.opendev.org/#/c/673735/45/nova/compute/api.py@2454 | 16:37 |
Sundar | first: ithe comment serves to explain what the term ARQ stands for, which will point the reader towards Cyborg. | 16:38 |
Sundar | second: I see that comments will less info have been approved :) https://review.opendev.org/gitweb?p=openstack/nova.git;f=nova/compute/api.py;hb=refs/changes/35/673735/45#l1193 | 16:39 |
Sundar | *s/will/with/ | 16:39 |
dansmith | Sundar: I figured you'd know by now, but that argument holds no weight with me | 16:39 |
Sundar | Even if you are the one that did the approving? :) | 16:40 |
dansmith | totally | 16:40 |
Sundar | Anyways, I think it is worth retaining some comments that expand the term ARQ, at least one in each major code path | 16:40 |
Sundar | Re. the IRC discussion http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-03-16.log.html#t2020-03-16T15:57:20, yes, I have tested the XML generated with real devices. Not only by looking at the xml, but also by running a sample application within the VM that interacts with the FPGA. | 16:46 |
Sundar | dansmith, sean-k-mooney: ^ | 16:47 |
dansmith | ack | 16:47 |
*** TxGirlGeek has joined #openstack-cyborg | 16:47 | |
sean-k-mooney | Sundar: do you have any write up on how to do that | 16:48 |
sean-k-mooney | or where to get the sample code | 16:48 |
sean-k-mooney | there is a host that i should be able to get acess too if needed. | 16:48 |
sean-k-mooney | if i need to take over some of the nova work from you or someone else does knowing how to test it with real hardware would be useful | 16:49 |
sean-k-mooney | we have some openvino sampel applciation but i was hoping there was a simpelr hello world | 16:49 |
sean-k-mooney | Sundar: by the way does the nivida pgpu driver work. because i also have nvida gpus at home so i can also try testign with that. i dont have ones that support ther vgpu/nvida grid feature but this is just for standard physical gpu passhtough anyway | 16:54 |
sean-k-mooney | if i can test with real hardware while also not needing to deal with fpga programming that might be a win win since from a nova point of view it will be exactly the same | 16:55 |
Sundar | sean-k-mooney: The OPAE SDK comes with some sample bitstreams (they are under the hw/ dir, IIRC, which can be a bit confusing). They are the Native Loopback (nlb) apps, so they are named like nlb-0.gbs and nlb-3.gbs. There are corresponding testing apps named nlb0 and nlb3, On the host, the nlb-N.gbs needs to be programmed into the device, either | 17:10 |
Sundar | with Cyborg or by hand. The OPAE stack also needs to be installed in the VM. Then you can the testing apps like nlbN inside the VM. | 17:10 |
sean-k-mooney | Sundar: that is good to know | 17:11 |
Sundar | sean-k-mooney: I can send more detailed notes if needed. Re. GPUs, I think some Cyborg community folks from Lenovo tested one type of Nvidia GPU. They have not been active this cycle. | 17:12 |
Sundar | I'll ask others if they have tested with GPUs this cycle. | 17:13 |
sean-k-mooney | i need to reinsally my desktop that i use for dev which has some nvida gpus in it so i might give it a try. that my project for the weekend however | 17:14 |
sean-k-mooney | for somereason after the latest bios update it nolonger supprot booting form optane... | 17:14 |
dansmith | Sundar: to be clear, are you good through the end of next week or this week? | 17:34 |
Sundar | dansmith: through next week (till March 27). A few days here or there is fine. | 17:37 |
dansmith | gotcha | 17:37 |
*** Sundar has quit IRC | 18:34 | |
*** TxGirlGeek has quit IRC | 19:14 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!