| *** brinzhang_ has joined #openstack-cyborg | 00:07 | |
| *** brinzhang has quit IRC | 00:11 | |
| *** brinzhang has joined #openstack-cyborg | 00:12 | |
| *** brinzhang_ has quit IRC | 00:15 | |
| *** igordc has quit IRC | 00:33 | |
| *** igordc has joined #openstack-cyborg | 00:53 | |
| *** chenke has joined #openstack-cyborg | 01:13 | |
| *** openstackgerrit has joined #openstack-cyborg | 01:44 | |
| openstackgerrit | chenker proposed openstack/cyborg master: Remove V1 API and related codes https://review.opendev.org/711232 | 01:44 |
|---|---|---|
| *** brinzhang_ has joined #openstack-cyborg | 01:49 | |
| *** brinzhang_ has quit IRC | 01:50 | |
| *** brinzhang_ has joined #openstack-cyborg | 01:51 | |
| *** brinzhang has quit IRC | 01:52 | |
| *** igordc has quit IRC | 02:07 | |
| *** xinranwang has joined #openstack-cyborg | 02:42 | |
| *** Sundar has joined #openstack-cyborg | 02:46 | |
| *** brinzhang has joined #openstack-cyborg | 02:50 | |
| brinzhang | Sundar: ask a question https://review.opendev.org/#/c/711225/2/cyborg/objects/extarq/ext_arq_job.py@39 | 02:52 |
| Sundar | brinzhang: Ok, looking at it | 02:53 |
| *** brinzhang_ has quit IRC | 02:53 | |
| brinzhang | Sundar: "if getattr(self.bind, "is_job", False) and need_job is not False:" if need_job=False, is it what would you want? | 02:53 |
| Sundar | What is the question? | 02:53 |
| brinzhang | Sundar: check_extra_job(context, deployable) this just only return True or False? or there is other volue? | 02:54 |
| brinzhang | Dou you accept current changes? | 02:55 |
| brinzhang | s/Dou/Do | 02:55 |
| brinzhang | "need_job is not False" has the different value when need_job init None or False | 02:56 |
| *** Yumeng has joined #openstack-cyborg | 02:57 | |
| Sundar | IMHO, need_job should be boolean (True/False). The check should be: "if need_job: ..." | 02:58 |
| Sundar | Having a possible value of None just complicates other code that has to check for None. | 02:59 |
| brinzhang | agree | 02:59 |
| Sundar | So, I agree with this change. | 03:00 |
| brinzhang | so "if getattr(self.bind, "is_job", False) and need_job is not False:" should change to "if getattr(self.bind, "is_job", False) and need_job:" | 03:00 |
| Sundar | Yes, agree | 03:01 |
| chenke | need_job or need_job is not False both ok. | 03:01 |
| brinzhang | And I think we need add some UT for this, now the change dont run some UT | 03:01 |
| Sundar | chenke: Sure. But shorter is better. | 03:01 |
| Sundar | Looks like we have quite a few people. So, let's get started. | 03:02 |
| chenke | Ok. | 03:02 |
| Sundar | #startmeeting openstack-cyborg | 03:02 |
| openstack | Meeting started Thu Mar 5 03:02:31 2020 UTC and is due to finish in 60 minutes. The chair is Sundar. Information about MeetBot at http://wiki.debian.org/MeetBot. | 03:02 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 03:02 |
| *** openstack changes topic to " (Meeting topic: openstack-cyborg)" | 03:02 | |
| openstack | The meeting name has been set to 'openstack_cyborg' | 03:02 |
| Sundar | #topic Agenda | 03:02 |
| *** openstack changes topic to "Agenda (Meeting topic: openstack-cyborg)" | 03:02 | |
| chenke | #info chenke | 03:02 |
| Sundar | #info Sundar | 03:03 |
| Li_Liu | #info Li_Liu | 03:03 |
| brinzhang | #info brinzhang | 03:03 |
| Yumeng | #info Yumeng | 03:03 |
| xinranwang | #info xinranwang | 03:04 |
| Sundar | What do people have to discuss today? | 03:04 |
| *** shaohe_feng has joined #openstack-cyborg | 03:04 | |
| brinzhang | About remove v1 API | 03:05 |
| brinzhang | https://review.opendev.org/#/c/711232/ | 03:05 |
| Sundar | BTW, the time for PTG reservation is up. I didn't hear confirmation that even 3 people plan to go to Vancouver, SO I haven't confirmed anything. | 03:05 |
| shaohe_feng | encourage developers to access the PTG | 03:07 |
| shaohe_feng | if possible. | 03:07 |
| chenke | V1's API is now worthless, and v2 can also be seen. v2's deployable api, Shogo is also doing it, I think it can be removed. Even if the v1 api is retained, the call may not necessarily be as expected. https://review.opendev.org/#/c/698190/ | 03:09 |
| chenke | brinzhang | 03:10 |
| Sundar | To have focused discussion on V release goals and plans, we could either do it in IRC and etherpads or in openstack-discuss ML. If we do a Zoom call. or WeChat discussion, they should be posted on IRC or ML. Otherwise, other projects will not have know what we do. | 03:10 |
| Sundar | brnzhang, chenke: Agree v1 API can be removed. | 03:10 |
| Sundar | brinzhang: ^ | 03:10 |
| chenke | OK | 03:10 |
| brinzhang | Sundar, but in v2 we dont have the deployable, right? | 03:11 |
| brinzhang | if we remove now, I think it's too early to do this. | 03:11 |
| chenke | https://review.opendev.org/#/c/698190/ | 03:11 |
| brinzhang | IMO, we should done all things in v2, then to deal with the v1 | 03:12 |
| Sundar | brinzhang: There is a deployable object in v2, but it means something else than the v1 deployable. | 03:13 |
| Sundar | I think we plan to have APIs for patching deployables in v2. | 03:13 |
| brinzhang | Sundar: sure | 03:14 |
| brinzhang | If all agree to remove now, I am ok too. | 03:14 |
| Sundar | brinzhang: I think it is better to remove api/controllers/v1/deployables.py and add api/controllers/v2/deployables.py | 03:15 |
| chenke | shogo is doing this | 03:15 |
| brinzhang | Sundar: I also agree, but I just think it's earlier | 03:16 |
| *** s_shogo has joined #openstack-cyborg | 03:16 | |
| Sundar | brinzhang: I see. What should we wait for, before we remove the v1 API? | 03:16 |
| brinzhang | I think so | 03:16 |
| chenke | do you use v1? | 03:17 |
| brinzhang | chenke, Sundar: Need a process here, right? | 03:19 |
| Yumeng | brinzhang: Brin, if I didn't remember it wrong, we've made an agreement Train version that we make an deprecation anounce and remove the code in U release. | 03:19 |
| brinzhang | Yumeng, Ah, if so, I think I missed this message, ignore my comments | 03:21 |
| Yumeng | But I forgot where the discussion was happen. | 03:21 |
| Sundar | Yes, we followed the process of deprecating in Stein itself and reinforced the deprecation in Train. | 03:21 |
| Yumeng | yes, it's safe to remove now. Don't worry. | 03:21 |
| Sundar | Yumeng: We have discussed this in IRC before (I need to look up when). But our API docs clearly say v1 is deprecated, both in Stein and Train. | 03:22 |
| Yumeng | ok. good that we have announcement! | 03:23 |
| brinzhang | Sundar: that should an ML or etherpad to recore this aggrement, otherwise will have different opinion | 03:24 |
| Sundar | https://docs.openstack.org/cyborg/stein/admin/api.html | 03:24 |
| brinzhang | And we should add that links to the commit message, that reviewer can get more info | 03:24 |
| chenke | Ok. I will update message | 03:25 |
| brinzhang | Sundar, chenker, Yumeng: ok, we can continue next topic | 03:26 |
| Sundar | brinzhang: The above link is published already. I have said this to Nova developers in ML too, not sure when. | 03:26 |
| chenke | ok | 03:26 |
| Sundar | For example, Sean mooney and others are testing Nova with Cyborg v2. No expectation of v1 support. | 03:27 |
| Sundar | #topic PTG | 03:27 |
| *** openstack changes topic to "PTG (Meeting topic: openstack-cyborg)" | 03:27 | |
| Sundar | To reinforce what I said: To have focused discussion on V release goals and plans, we could either do it in IRC and etherpads or in openstack-discuss ML. If we do a Zoom call. or WeChat discussion, they should be posted on IRC or ML. Otherwise, other projects will not have know what we do. | 03:28 |
| Sundar | Does anybody disagree? | 03:29 |
| xinranwang | We can create a ether pad | 03:29 |
| xinranwang | To list the goals | 03:29 |
| Sundar | Ok, so everybody agrees to this ^, right? | 03:31 |
| Yumeng | agree. etherpad, zoom are always good. | 03:31 |
| brinzhang | agree, wWe can publish content on etherpad regularly | 03:31 |
| brinzhang | send that info to ML | 03:31 |
| s_shogo | agree. | 03:32 |
| Sundar | #agree V release planning process above ^ | 03:32 |
| Sundar | Thanks, all | 03:32 |
| Sundar | Any other topic before I move to Nova and related stuff? | 03:32 |
| Yumeng | ^^ | 03:33 |
| Yumeng | Sundar, xinranwang, chenke: I will abandon this:https://review.opendev.org/#/c/709286/3 | 03:33 |
| Yumeng | but we still need to update the valid controlpath_id_type values herehttps://github.com/openstack/cyborg/blob/master/cyborg/objects/control_path.py#L26, do you agree? | 03:33 |
| Yumeng | we should remove "MDEV" in cureent valid values | 03:34 |
| Yumeng | */from | 03:34 |
| chenke | Agree | 03:34 |
| Yumeng | https://github.com/openstack/cyborg/blob/master/cyborg/objects/control_path.py#L26 | 03:34 |
| Sundar | Yumeng: agree | 03:34 |
| Sundar | to both | 03:35 |
| Yumeng | ok. great! will do. | 03:35 |
| brinzhang | agree | 03:35 |
| xinranwang | Agree | 03:36 |
| Yumeng | ok. thanks all! | 03:37 |
| Sundar | Ok, on the Nova series: it is a bit mixed news. One patch got merged, one more got +2. But we are still spinning on UT details. Sometimes seems like too much detail or nits. | 03:38 |
| Sundar | I was hoping to wrap this up by Feb. I have offers for a next role, but yet to decide. But I will be moving to a different role in March. So, I am looking to wrap it up one way or the other. | 03:40 |
| Yumeng | wow, congrats! | 03:41 |
| chenke | Sundar congratulate！ | 03:41 |
| s_shogo | congrats! >> the merged patch | 03:44 |
| Sundar | Thanks, mixed feelings for me, after putting so much effort into Cyborg. | 03:44 |
| Sundar | Can one of you volunteer to be an additional PTL after I move on? | 03:45 |
| brinzhang | Sundar, congrats! That is a new beginning and it will be brilliant. | 03:45 |
| Sundar | Thanks, brinzhang. | 03:45 |
| shaohe_feng | So what‘s your next role? | 03:45 |
| shaohe_feng | still about cloud related work? | 03:46 |
| chenke | Yes, you spend a lot of energy on cyborg, about 16 hours a day. Good luck cares for those who work hard. | 03:46 |
| Sundar | Not decided on next role, yes still about cloud, | 03:47 |
| Sundar | chenke: I was doing CYborg plus some Kubernetes work till about a month ago | 03:48 |
| Sundar | That's why it took long hours | 03:48 |
| chenke | Got it. | 03:49 |
| xinranwang | Thanks for your great efforts! | 03:49 |
| Sundar | Thanks, xinranwang | 03:50 |
| Sundar | OK, maybe you all can discuss offline on additional PTL. We still have time. | 03:50 |
| Yumeng | Sundar: I can help with the rest work after you move on. But not sure if we need more volunteers. we can discuss the tasks and seperate them. | 03:50 |
| shaohe_feng | kubernets is popular in cloud. | 03:51 |
| Sundar | Yumeng: Ok. We need to inform the OpenStack Foundation so that they can send all communication to two people, not just me alone. | 03:51 |
| Sundar | That's all, folks. Anything else before we wrap up? | 03:52 |
| shaohe_feng | can anyone who attend PTG can tell something about Cyborg and Neutron integration? | 03:53 |
| shaohe_feng | on smartnic | 03:53 |
| shaohe_feng | I have look into it. | 03:54 |
| Sundar | shaohe_feng: I have rescinded (cancelled, taken back) my proposals for Cyborg Neutron integ. It would not be easy to drive a 3-way change across Nova, neutron and Cyborg. | 03:54 |
| Sundar | The next best approach would be to assume a static programming model, and use Nova to create the resource providers for smart NICs using the provider config (YAML-based) approach. | 03:55 |
| shaohe_feng | The neutron Docs tells us, it support a new vif type smartnic | 03:55 |
| *** links has joined #openstack-cyborg | 03:56 | |
| shaohe_feng | that's means cyborg should not manage these kind of accelerators? | 03:56 |
| shaohe_feng | I have think it how to support it. | 03:57 |
| shaohe_feng | any method, nova can not do many help | 03:57 |
| shaohe_feng | some one want to know details about it. | 03:58 |
| shaohe_feng | or we can discuss offline | 03:58 |
| Sundar | shaohe_feng: First, to my knowledge, most folks do not plan to dynamically program smart NICs, i.e., change its image based on VM type, traffic type, workload, time of day, etc. | 03:58 |
| Sundar | Instead they'll do it statically, maybe even offline when no VMs are present and the host is in maintenance mode | 03:58 |
| Sundar | The strength of CYborg is dynamic programming. | 03:59 |
| shaohe_feng | I know other company will support it. and maybe they are work in progress, not sure they will upstream. | 03:59 |
| shaohe_feng | the cyborg is only for program? | 03:59 |
| Sundar | Ok, if you have concrete proposals, and plan to follow up with Nova/neutron community, along with other developers, that would be good. | 03:59 |
| Sundar | Yea, we can take this offline, or in the next IRC call. | 04:00 |
| Sundar | I need to go now. And it is lunch time for you all :) | 04:00 |
| shaohe_feng | No, it will do more not only program. | 04:00 |
| Sundar | Anything else, folks? | 04:00 |
| Yumeng | nothing from me. | 04:01 |
| Sundar | Have a good day! Bye for now. | 04:02 |
| Sundar | #endmeeting | 04:02 |
| *** openstack changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 04:02 | |
| openstack | Meeting ended Thu Mar 5 04:02:03 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 04:02 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-03-05-03.02.html | 04:02 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-03-05-03.02.txt | 04:02 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-03-05-03.02.log.html | 04:02 |
| *** s_shogo has quit IRC | 04:02 | |
| chenke | bye | 04:02 |
| *** brinzhang has quit IRC | 04:36 | |
| *** brinzhang has joined #openstack-cyborg | 04:37 | |
| *** brinzhang has quit IRC | 04:37 | |
| *** brinzhang has joined #openstack-cyborg | 04:38 | |
| *** Sundar has quit IRC | 04:57 | |
| *** brinzhang has quit IRC | 05:52 | |
| openstackgerrit | Merged openstack/cyborg master: UT for job manager https://review.opendev.org/700504 | 06:05 |
| openstackgerrit | Merged openstack/cyborg master: add testcase for check_bindings_result failed https://review.opendev.org/703543 | 06:05 |
| *** efried has quit IRC | 06:07 | |
| *** efried1 has joined #openstack-cyborg | 06:07 | |
| openstackgerrit | Merged openstack/cyborg master: change default SimpleQueue to _PySimpleQueue for queue https://review.opendev.org/708655 | 06:07 |
| openstackgerrit | Merged openstack/cyborg master: add testcases for async job bind https://review.opendev.org/708426 | 06:07 |
| openstackgerrit | Merged openstack/cyborg master: Revert "Solve py37 timeout" https://review.opendev.org/708431 | 06:07 |
| *** efried1 is now known as efried | 06:09 | |
| openstackgerrit | chenker proposed openstack/cyborg master: Fix minor error in extarq job https://review.opendev.org/711225 | 06:22 |
| openstackgerrit | chenker proposed openstack/cyborg master: Remove V1 API and related codes https://review.opendev.org/711232 | 06:33 |
| *** Yumeng has quit IRC | 06:36 | |
| openstackgerrit | YumengBao proposed openstack/cyborg master: Fix attach_handle_type of gpu device with improper value https://review.opendev.org/709433 | 07:12 |
| *** efried has quit IRC | 07:22 | |
| *** efried has joined #openstack-cyborg | 07:22 | |
| *** efried has quit IRC | 07:23 | |
| *** efried has joined #openstack-cyborg | 07:23 | |
| *** xinranwang has quit IRC | 07:35 | |
| *** tetsuro has joined #openstack-cyborg | 07:44 | |
| *** brinzhang has joined #openstack-cyborg | 08:03 | |
| openstackgerrit | YumengBao proposed openstack/cyborg master: Fix GPU's improper cpid_type allowed value and attach_handle_type value https://review.opendev.org/709433 | 09:01 |
| *** irclogbot_0 has quit IRC | 09:08 | |
| *** tetsuro has quit IRC | 09:29 | |
| *** irclogbot_0 has joined #openstack-cyborg | 09:43 | |
| *** openstackstatus has quit IRC | 09:45 | |
| openstackgerrit | YumengBao proposed openstack/cyborg master: Fix GPU's improper cpid_type allowed value and attach_handle_type value https://review.opendev.org/709433 | 10:13 |
| *** shaohe_feng has quit IRC | 10:33 | |
| *** chenke has quit IRC | 11:02 | |
| *** tetsuro has joined #openstack-cyborg | 12:03 | |
| *** tetsuro has quit IRC | 12:06 | |
| *** brinzhang has quit IRC | 12:16 | |
| *** brinzhang has joined #openstack-cyborg | 13:31 | |
| *** efried is now known as efried_gone | 15:18 | |
| *** links has quit IRC | 15:27 | |
| *** brinzhang has quit IRC | 15:45 | |
| *** TxGirlGeek has joined #openstack-cyborg | 16:39 | |
| *** igordc has joined #openstack-cyborg | 17:22 | |
| *** TxGirlGeek has quit IRC | 22:35 | |
| *** brinzhang has joined #openstack-cyborg | 23:42 | |
| *** brinzhang_ has joined #openstack-cyborg | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!