| *** links has joined #openstack-cyborg | 00:11 | |
| *** links has quit IRC | 00:12 | |
| *** TxGirlGeek has quit IRC | 00:27 | |
| *** zhurong has quit IRC | 00:43 | |
| *** zhurong has joined #openstack-cyborg | 00:56 | |
| *** Sundar has joined #openstack-cyborg | 01:48 | |
| openstackgerrit | YumengBao proposed openstack/cyborg master: conductor writes device_profile update to db https://review.opendev.org/679406 | 02:15 |
|---|---|---|
| openstackgerrit | YumengBao proposed openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957 | 02:22 |
| *** chenke has joined #openstack-cyborg | 02:42 | |
| openstackgerrit | chenker proposed openstack/cyborg master: Fix the hardcoding of user role using sdk_adapter approach https://review.opendev.org/682565 | 02:50 |
| *** s_shogo has joined #openstack-cyborg | 02:53 | |
| *** Yumeng has joined #openstack-cyborg | 02:54 | |
| *** xinranwang has joined #openstack-cyborg | 02:57 | |
| *** shaohe_feng has joined #openstack-cyborg | 03:01 | |
| Sundar | #startmeeting openstack-cyborg | 03:01 |
| openstack | Meeting started Thu Sep 26 03:01:33 2019 UTC and is due to finish in 60 minutes. The chair is Sundar. Information about MeetBot at http://wiki.debian.org/MeetBot. | 03:01 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 03:01 |
| *** openstack changes topic to " (Meeting topic: openstack-cyborg)" | 03:01 | |
| openstack | The meeting name has been set to 'openstack_cyborg' | 03:01 |
| Sundar | Hi all | 03:01 |
| Sundar | #topic Who's here | 03:01 |
| shaohe_feng | good evening | 03:01 |
| *** openstack changes topic to "Who's here (Meeting topic: openstack-cyborg)" | 03:01 | |
| Sundar | o/ | 03:01 |
| s_shogo | Hi all | 03:02 |
| shaohe_feng | o/ | 03:02 |
| chenke | o/ | 03:02 |
| chenke | Hi all. | 03:02 |
| Yumeng | #info Yumeng | 03:02 |
| Yumeng | hi all | 03:02 |
| xinranwang | Hi all | 03:03 |
| xinranwang | #info xinranwang | 03:03 |
| s_shogo | #info s_shogo | 03:03 |
| Sundar | Let's start with some good news. In Chenke's patch https://review.opendev.org/#/c/682565/, Eric asked to try 'strict_proxies=False' | 03:03 |
| Sundar | I tried and it works for me at least :) | 03:03 |
| chenke | Wow | 03:03 |
| chenke | Sound great. | 03:03 |
| Sundar | If chenke can resubmit with that change, I'll trigger the tempest check | 03:04 |
| chenke | I had done it. | 03:04 |
| chenke | And triggered the tempest check. | 03:04 |
| Sundar | https://review.opendev.org/#/c/682565/15/cyborg/common/utils.py@149 still has i, right? | 03:05 |
| Sundar | *it | 03:05 |
| Sundar | I set that to False | 03:06 |
| chenke | The eric's advice is to see it to False, pls see Line 130 the default value. | 03:06 |
| xinranwang | I discussed with colleague who has experience on CI, there is no other solution except add "depend on" in each patch. | 03:07 |
| xinranwang | it is better to merge nova patches as soon as possible. | 03:07 |
| Sundar | chenke: I see. | 03:08 |
| Sundar | Ok. Hope that does the trick. | 03:08 |
| chenke | Hope so. | 03:08 |
| Yumeng | agree with Xinran | 03:08 |
| Yumeng | we have this to test related patches :https://review.opendev.org/#/c/670999/ | 03:08 |
| Yumeng | to test nova-cyborg-integration related patches | 03:09 |
| chenke | Agree with Xinran. Now Yumengs' patch is a better solution so far. | 03:09 |
| Sundar | It is not up to us to get Nova patches merged. There are challenge sin getting reviewer attention, not only for Cyborg, but for other subjects too. | 03:09 |
| Sundar | Are we saying we should put Depends-On for a Nova patch in every Cyborg patch? | 03:10 |
| xinranwang | yes | 03:11 |
| *** shaohe_feng has quit IRC | 03:11 | |
| Sundar | All agree? | 03:12 |
| chenke | but this will have too many dependencies. | 03:12 |
| Sundar | Too many dependencies on Nova code? | 03:13 |
| chenke | Yes. | 03:14 |
| xinranwang | 1. need keep nova patch updated all the time to avoid merge conflict. | 03:15 |
| xinranwang | 2. need add "depend on" in every patch to trigger correct tempest test. | 03:15 |
| Sundar | Yea. May be we can do it judiciously based on whether the patch has Nova interaction. | 03:15 |
| chenke | But it is also a good way to fully test our cyborg code. | 03:15 |
| chenke | Agree | 03:15 |
| *** shaohe_feng has joined #openstack-cyborg | 03:16 | |
| Sundar | I am the only one maintaining those patches. Nova moves fast and breakages happen often. I cannot commit to keep doing that all the time, unless we are getting Nova reviewers' attention. | 03:16 |
| shaohe_feng | something wrong with my net | 03:16 |
| chenke | welcome back. | 03:17 |
| xinranwang | It's better to get nova folks attention. | 03:17 |
| xinranwang | Longer we wait, more efforts it takes. | 03:17 |
| Sundar | That's what we tried to do for entire Train cycle | 03:17 |
| Yumeng | yes. so better to have a successful tempest test at nova side and get merg asap, then we add more features in cyborg | 03:17 |
| Yumeng | Sundar: I can help to maintain and fix patches, if you need help. | 03:19 |
| Sundar | Let's be clear. Now we put Depends-On *from* Nova to the Cyborg patch that we want to test, i..e. chenke's patch. We can't do that for every patch. | 03:21 |
| chenke | Agree. | 03:21 |
| chenke | just some special patch should do like this. | 03:22 |
| xinranwang | +1 | 03:22 |
| s_shogo | +1 | 03:22 |
| Yumeng | +1 | 03:22 |
| Sundar | Makes sense. Any patch that touches Nova or other services or any significant patch can be tested this way. If/when we get Nova reviews early in U, we can make it a common practice. | 03:24 |
| Sundar | All good with that? | 03:24 |
| Sundar | Ok, I'll take previous +1s as yes :) | 03:25 |
| Sundar | #topic RC status | 03:26 |
| *** openstack changes topic to "RC status (Meeting topic: openstack-cyborg)" | 03:26 | |
| Sundar | https://review.opendev.org/#/c/684056/1 has been filed | 03:26 |
| Sundar | I am saying we have a few potential RC blockers. | 03:27 |
| Sundar | •Privsep: https://review.opendev.org/673957 : affects security | 03:27 |
| Sundar | •Privsep for FPGA prog: https://review.opendev.org/683733 : affects security | 03:27 |
| Sundar | •V1 API: https://review.opendev.org/684193 : affects backwards compatibility | 03:27 |
| Sundar | Others are important for us, and we should merge as much of them as we can. | 03:27 |
| shaohe_feng | https://review.opendev.org/#/c/681005/ | 03:28 |
| openstackgerrit | chenker proposed openstack/cyborg master: Fix the hardcoding of user role using sdk_adapter approach https://review.opendev.org/682565 | 03:28 |
| Sundar | shaohe_feng, an RC blocker has a high bar -- we have to explain why the entire release should be held up till we fix that | 03:29 |
| Sundar | We should continue to review your patch and try to merge it. May be this RC may not be the last one. | 03:30 |
| shaohe_feng | One questions about: sdk_adapter patch. I remember we did user sdk_adapter in V1, why we change it to connection | 03:30 |
| shaohe_feng | and change back to sdk_adapter again? | 03:30 |
| chenke | nova recommand us to use sdk now. | 03:31 |
| Sundar | We used ksa_adapter in v1. We were asked to move to sdk_adapter as a new method and then to COnnection as the latest one. There are some bugs apparently, so we have settled on what works. | 03:31 |
| Sundar | chenke: +1 | 03:32 |
| shaohe_feng | what's the pron of sdk? | 03:32 |
| shaohe_feng | O, I remember xinranwang use sdk_adapter ? | 03:34 |
| shaohe_feng | why not give up? | 03:34 |
| shaohe_feng | then sdk_adapter again? | 03:34 |
| shaohe_feng | pros and cons? | 03:35 |
| Sundar | You can ask Eric in that patch. Nova has some requirements and considerable interest in this area. | 03:36 |
| shaohe_feng | OK. | 03:36 |
| Sundar | Are there any other patches that are potential RC blockers, i.e, have security or critical implications, so we should hold up the release? | 03:37 |
| shaohe_feng | maybe we can do more investigation on it. but not now | 03:37 |
| shaohe_feng | now we have more things to do. | 03:37 |
| Sundar | Sure. If nothing else, let us please focus on reviewing the ones above first, and as much of the rest as we can. It is possible that there may be future RCs, so they may still make it | 03:39 |
| Sundar | Any other comments or thoughts? | 03:40 |
| Yumeng | https://review.opendev.org/#/c/679406/ this one please | 03:40 |
| Yumeng | conductor writes device_profile | 03:40 |
| Sundar | Yumeng: sure. IMHO, it is mostly there. I'll try it out tonight and review it | 03:40 |
| Yumeng | just updated. | 03:40 |
| Yumeng | thanks! | 03:40 |
| Sundar | Shaohe, have you tried your patch with the Nova patches? | 03:41 |
| shaohe_feng | yes. | 03:41 |
| Sundar | Great | 03:41 |
| shaohe_feng | xinranwang also help to do it. | 03:41 |
| Sundar | Thanks to both of you | 03:42 |
| Sundar | Anything else, folks? | 03:42 |
| shaohe_feng | actually, I did not change your code logical | 03:42 |
| shaohe_feng | just put them in thread pool as async job. :) | 03:42 |
| Sundar | Cool, np even if you changed it, as long as it works :) | 03:43 |
| xinranwang | This patch is almost good for me | 03:43 |
| Sundar | almost? | 03:44 |
| Sundar | Anyway, we can continue the review in Gerrit. | 03:44 |
| xinranwang | “Almost”means need other’s review as well | 03:44 |
| chenke | About this patch:https://review.opendev.org/#/c/684193/ | 03:45 |
| chenke | I agree with xinran's idea. | 03:45 |
| Sundar | Do you want to see 6 endpoints with devstack? :) | 03:45 |
| Sundar | v1 is end-of-life. | 03:46 |
| chenke | no | 03:46 |
| chenke | We don't need to enable v1. | 03:46 |
| Sundar | After Train, we can remove it early in U | 03:46 |
| Sundar | Can you explain further, chenke? v1 is deprecated but supported in this release. So, we do the bare minimum to keep it alive, but don't bother develoeprs with legacy endpoints | 03:47 |
| Sundar | We can remove v1 altogether early in U, and even these devstack comments will go away | 03:48 |
| Sundar | Anybody disagree? | 03:49 |
| chenke | Sorry, I misunderstood this meaning. | 03:49 |
| chenke | just go on. | 03:49 |
| Sundar | You are ok with that patch as is? | 03:49 |
| Sundar | Anyway, let's continue the review in Gerrit | 03:50 |
| chenke | +1 | 03:50 |
| Sundar | If nothing else, we can call it a day (or night or afternoon) | 03:50 |
| Sundar | Have a good day, everyone! Bye for now. (I'll bother you on WeChat after this -- JK) | 03:51 |
| Sundar | #endmeeting | 03:51 |
| *** openstack changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 03:51 | |
| openstack | Meeting ended Thu Sep 26 03:51:42 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 03:51 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-26-03.01.html | 03:51 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-26-03.01.txt | 03:51 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-26-03.01.log.html | 03:51 |
| chenke | Bye~ all | 03:52 |
| Sundar | chenke -- the latest tempest run failed too | 03:54 |
| chenke | could you give me the address | 03:54 |
| chenke | detail log address. | 03:54 |
| Sundar | https://openstack.fortnebula.com:13808/v1/AUTH_e8fd161dc34c421a979a9e6421f823e9/zuul_opendev_logs_c00/670999/12/check/cyborg-tempest/c00ce63/controller/logs/screen-cyborg-api.txt.gz | 03:54 |
| Sundar | Sep 25 14:33:08.765936 --- Server-side error: "Failed to create a working proxy for service compute: No valid endpoint was discoverable." | 03:55 |
| chenke | Now time is ? | 03:56 |
| chenke | I want to confirm if it is the latest log. | 03:57 |
| Sundar | It is in UTC | 03:57 |
| Sundar | I see, it could be old? | 03:57 |
| chenke | I am not sure. | 03:57 |
| Sundar | Seems like old one -- never mind, false alarm ;) | 03:58 |
| chenke | Ok~ | 03:58 |
| Sundar | I need to leave now, will be back in 30 min or so | 03:58 |
| chenke | https://zuul.opendev.org/t/openstack/stream/fa3f4faccb0744cb9e019cae42b1102d?logfile=console.log | 03:58 |
| chenke | this is new. | 03:58 |
| chenke | Ok. the same to me. | 03:58 |
| chenke | I will back after 90min. | 03:58 |
| *** Sundar has quit IRC | 04:19 | |
| *** Yumeng has quit IRC | 05:19 | |
| *** chenke has quit IRC | 05:21 | |
| *** chenke has joined #openstack-cyborg | 06:01 | |
| *** shaohe_feng has quit IRC | 06:03 | |
| openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Program FPGAs with oslo.privsep. https://review.opendev.org/683733 | 06:12 |
| *** s_shogo has quit IRC | 06:19 | |
| openstackgerrit | zhurong proposed openstack/cyborg master: Fix delete arq 403 failed https://review.opendev.org/684947 | 06:27 |
| openstackgerrit | Merged openstack/cyborg master: Enable fake_driver by default https://review.opendev.org/684712 | 07:28 |
| *** chenke has quit IRC | 07:49 | |
| *** FlorianFa has joined #openstack-cyborg | 07:52 | |
| openstackgerrit | chenker proposed openstack/cyborg master: Fix delete arq 403 failed https://review.opendev.org/684947 | 08:28 |
| openstackgerrit | Merged openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957 | 09:00 |
| *** xinranwang has quit IRC | 09:05 | |
| openstackgerrit | Merged openstack/cyborg master: conductor writes device_profile update to db https://review.opendev.org/679406 | 10:42 |
| *** Sundar has joined #openstack-cyborg | 11:04 | |
| Sundar | Hi zhurong | 11:08 |
| *** shaohe_feng has joined #openstack-cyborg | 11:09 | |
| *** chenke has joined #openstack-cyborg | 11:11 | |
| zhurong | Hi Sundar | 11:12 |
| Sundar | Hi zhurong, thanks for all your contribution and reviews. | 11:12 |
| Sundar | I'd like to talk about https://review.opendev.org/#/c/684193/3 | 11:12 |
| Sundar | OpenStack has a bacwards compat requirement. We have been releasing CYborg since Queens cycle. | 11:13 |
| Sundar | We have had v1 API for some time, developed it in Stein but also marked it as deprecated | 11:13 |
| zhurong | yeah, I think we should give people more clearly message, when will remove the V | 11:14 |
| Sundar | We cannot remove it right away in Train. We must keep it for 1 release. | 11:14 |
| zhurong | yeah, I think we should give people more clearly message, when will remove the V1 API | 11:14 |
| Sundar | So, we are keeping it in Train and will remove it in U | 11:14 |
| Sundar | Meanwhile we don't see anybody using it given its current state. So, we are doing the minimum to keep it alive. If anybody wrote scripts to play with it, they will return some meaningful value like [] or None, but not crash | 11:16 |
| Sundar | Early in U, we can remove it | 11:16 |
| zhurong | Now the message only said we deprecated v1 api, but don't give the time clearly. | 11:16 |
| Sundar | Others gave -1 and retracted after explanation. | 11:16 |
| Sundar | Ok, I believe the standard practice is 1 cycle | 11:17 |
| Sundar | We don't have to keep it longer | 11:17 |
| zhurong | sorry for the later rely, I have a meeting this afternoon, so I didn't have time to watch the review process | 11:18 |
| Sundar | Not sure we can just remove it just like that, unless you know of some exception | 11:18 |
| Sundar | NP. Do you agree with the explanation for the v1 API? | 11:19 |
| zhurong | I agree with you. In my comment, I said if we don't remove in this cycle, we should make the deprecated message more cleary, tell usr and developer when we will remove the v1 API. just edit the deprecated message add the we will remove in U cycle. | 11:21 |
| Sundar | Ah I see, sure | 11:23 |
| Sundar | We have to update all the docs | 11:24 |
| zhurong | that's my point, Sundar, I will remove the -1 | 11:31 |
| Sundar | Thanks, zhurong. | 11:33 |
| donnyd | Could we get some reviews of https://review.opendev.org/#/c/677715/2 | 11:42 |
| Sundar | donnyd: Yes, I'll ask for reviews and do it myself too. Trying to find the deadline for docs | 11:44 |
| donnyd | Sundar: you are either up really early or really late | 11:44 |
| Sundar | Both :) | 11:45 |
| Sundar | zhurong: if you agree, can you give +2 on https://review.opendev.org/#/c/684193/3 ? | 11:49 |
| zhurong | Sundar I give the +1 but can not +2 LOL | 12:06 |
| Sundar | zhurong: We should get you +2 power soon :) | 12:07 |
| openstackgerrit | Donny Davis proposed openstack/cyborg master: Cleanup index / add in driver support matrix https://review.opendev.org/677715 | 12:31 |
| donnyd | I rearranged some of the docs and moved the API related things into its own section | 13:03 |
| donnyd | https://7708f6003b3b400bcb29-64fb7d6df73b457268886899fb0ff053.ssl.cf1.rackcdn.com/677715/7/check/openstack-tox-docs/291916c/docs/ | 13:03 |
| donnyd | The API doc itself still needs some work, however content can come after everyone is happy with the structure | 13:03 |
| donnyd | Does anyone have a list of required functions for a driver to add to the matrix | 13:11 |
| openstackgerrit | chenker proposed openstack/cyborg master: Fix delete arq 403 faile and disable non-admin arq policy check https://review.opendev.org/684947 | 13:30 |
| openstackgerrit | chenker proposed openstack/cyborg master: Fix delete arq 403 failed and disable non-admin arq policy check https://review.opendev.org/684947 | 13:32 |
| openstackgerrit | chenker proposed openstack/cyborg master: Fix delete arq 403 failed and disable non-admin arq policy check https://review.opendev.org/684947 | 13:40 |
| *** chenke has quit IRC | 13:41 | |
| openstackgerrit | Merged openstack/cyborg master: Fix v1 API. https://review.opendev.org/684193 | 13:51 |
| openstackgerrit | Merged openstack/cyborg master: Program FPGAs with oslo.privsep. https://review.opendev.org/683733 | 13:51 |
| openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: async job for bind https://review.opendev.org/681005 | 14:29 |
| *** TxGirlGeek has joined #openstack-cyborg | 15:05 | |
| *** TxGirlGeek has quit IRC | 17:40 | |
| *** TxGirlGeek has joined #openstack-cyborg | 17:44 | |
| *** TxGirlGeek has quit IRC | 17:49 | |
| *** TxGirlGeek has joined #openstack-cyborg | 18:02 | |
| *** Sundar has quit IRC | 18:25 | |
| openstackgerrit | Donny Davis proposed openstack/cyborg master: Cleanup index / add in driver support matrix https://review.opendev.org/677715 | 19:03 |
| *** shaohe_feng has quit IRC | 19:38 | |
| *** TxGirlGeek has quit IRC | 19:59 | |
| openstackgerrit | Donny Davis proposed openstack/cyborg master: Cleanup index / add in driver support matrix https://review.opendev.org/677715 | 20:56 |
| *** TxGirlGeek has joined #openstack-cyborg | 20:58 | |
| *** efried has quit IRC | 22:15 | |
| openstackgerrit | Biwei Guo proposed openstack/cyborg-tempest-plugin master: [WIP] added soft reboot, pause/unpause, lock/unlock scenarios https://review.opendev.org/685183 | 22:17 |
| *** efried has joined #openstack-cyborg | 22:18 | |
| openstackgerrit | Donny Davis proposed openstack/cyborg master: Cleanup index / add in driver support matrix https://review.opendev.org/677715 | 23:07 |
| openstackgerrit | Donny Davis proposed openstack/cyborg master: Cleanup index / add in driver support matrix https://review.opendev.org/677715 | 23:34 |
| openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Cleanup index / add in driver support matrix https://review.opendev.org/677715 | 23:34 |
| *** efried has quit IRC | 23:34 | |
| *** efried has joined #openstack-cyborg | 23:35 | |
| *** TxGirlGeek has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!