openstackgerrit | Shogo Saito proposed openstack/python-cyborgclient master: v2 API Support(using openstack-sdk) https://review.opendev.org/681391 | 01:01 |
---|---|---|
openstackgerrit | YumengBao proposed openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957 | 01:25 |
*** TxGirlGeek has quit IRC | 01:45 | |
*** s_shogo has joined #openstack-cyborg | 02:28 | |
*** chenke has joined #openstack-cyborg | 02:30 | |
*** chunxiu has joined #openstack-cyborg | 02:51 | |
*** changzhi has joined #openstack-cyborg | 02:53 | |
*** xinranwang has joined #openstack-cyborg | 02:57 | |
*** Yumeng has joined #openstack-cyborg | 03:01 | |
*** Sundar has joined #openstack-cyborg | 03:02 | |
Sundar | Hi all | 03:03 |
*** wangzhh has joined #openstack-cyborg | 03:03 | |
chenke | Hi ~ | 03:03 |
wangzhh | Hi all. | 03:03 |
s_shogo | Hi all | 03:04 |
Sundar | Hi chenke, wangzhh, s_shogo | 03:04 |
xinranwang | Hi all | 03:04 |
Sundar | #startmeeting openstack-cyborg | 03:04 |
openstack | Meeting started Thu Sep 12 03:04:35 2019 UTC and is due to finish in 60 minutes. The chair is Sundar. Information about MeetBot at http://wiki.debian.org/MeetBot. | 03:04 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 03:04 |
*** openstack changes topic to " (Meeting topic: openstack-cyborg)" | 03:04 | |
openstack | The meeting name has been set to 'openstack_cyborg' | 03:04 |
wangzhh | Hi Sundar. | 03:04 |
chenke | \0 | 03:04 |
Sundar | This is the week of Train-3 milestone. | 03:05 |
Sundar | We'll look at the status, pending patches and future plans. Does anybody have any opens to be addressed? | 03:06 |
Sundar | #topic Status so far | 03:06 |
*** openstack changes topic to "Status so far (Meeting topic: openstack-cyborg)" | 03:06 | |
s_shogo | maybe, py3 patch. | 03:06 |
Yumeng | #info Yumeng | 03:07 |
Sundar | Good news: We got nearly all the nova-integ patches merged. https://review.opendev.org/#/q/project:openstack/cyborg+branch:master+topic:nova-integ Only the Nova notification patch remains. | 03:07 |
Yumeng | Thanks Sundar for your great efforts | 03:07 |
Sundar | IMHO, that is close too. We have some cleanup to do in the way we connect to other services. But we can fix that after this week too. | 03:08 |
Sundar | Yumeng: Thanks. All your contributions helped too. | 03:08 |
Sundar | The next most important things after Nova notifn would be tempest (https://review.opendev.org/#/c/667231/) and Python 3. | 03:09 |
Sundar | DO you al agree? Other patches are important too, but they cna be merged after this week too | 03:09 |
xinranwang | how about async bind patch? | 03:10 |
Sundar | That also can come in after this week, IMHO. I don;t think it is ready to merge in next 2 days. | 03:11 |
Sundar | Not so good news: It has been an uphill climb to get reviews from nova developers. The view I am hearing is that Nova patches for Cyborg need more sustained review before they can merge. | 03:12 |
Sundar | So far, the fact that most patches haven;t merged was a reason why reviewes were not getting done. Also, tempest CI was a prereq. We are very close to getting them all done , I think. | 03:13 |
Sundar | Any thoughts or comments? | 03:13 |
Sundar | It seems to me that Python 3 patch from Shogo is also close. Has nybody checked it out in their local env? | 03:14 |
s_shogo | I checked py3 patch with latest version(P9 merged), it works well. | 03:15 |
Sundar | s_shogo: Great. I'll also try it just in case. I'd invite others to check too. Do you think we can merge it by Friday? | 03:16 |
s_shogo | Sundar: I think so, there seems to be no big issue. | 03:17 |
chenke | +1 | 03:18 |
Sundar | Great. BTW, here are my Cycle highlights for Train. https://review.opendev.org/#/c/681283/ They include Python 3 too. | 03:19 |
Sundar | #topic Tempest | 03:19 |
*** openstack changes topic to "Tempest (Meeting topic: openstack-cyborg)" | 03:19 | |
Sundar | We are supposed to show the tempest CI as a prerequisite, like I said. | 03:20 |
Sundar | Yumeng: thanks a lot for all that you and your team have done. Is https://review.opendev.org/#/c/676665/ critical to merge this week? | 03:20 |
Sundar | Definitely, we need to merge https://review.opendev.org/#/c/667231/ soon. | 03:21 |
Yumeng | sundar: i will update today. I think we should merge asap | 03:22 |
Yumeng | agreed . also 667231 | 03:22 |
Sundar | Great. Glad to see your progress on privsep - but I think we can even do that in the next couple of weeks. | 03:22 |
Sundar | No need to burn yourself out :) | 03:23 |
Yumeng | about https://review.opendev.org/#/c/673957/ | 03:23 |
Yumeng | Eric and sean suggest we we don't need to have a cyborg.privsep.* sub module at all | 03:23 |
Yumeng | just a top level cyborg/privsep.py module that init the context and the privileged function should be in normal modules with privileged appended as a prefix or suffix. | 03:23 |
Yumeng | but the current fact is nova and cinder still have cyborg.privsep.* sub module | 03:24 |
Yumeng | so do we just follow the current way or change it ? what do you think? | 03:24 |
xinranwang | Yumeng: should we merge 676665 before 667231? | 03:24 |
Sundar | Yes. I have heard it be said even nova's use of rootwrap etc. is not a good template to follow. Sometimes we are expected to do better than than the legacy projects because we are new. | 03:25 |
Sundar | Yumeng: IMHO, it is better to take some time and do this right, because it will be tough to revisit this again. So, it may be better to follow the experienced input. | 03:26 |
Yumeng | yes, pleas merge 676665 before 667231 | 03:26 |
Yumeng | Sundar: ok. then I will reconsider it. do as they suggest. | 03:28 |
Sundar | Thanks a lot, Yumeng. | 03:28 |
Sundar | Yumeng: Re. 676665, There is a -1 on that. What does it take to get it resolved? | 03:28 |
Yumeng | I will do that | 03:28 |
Sundar | Excellent. Thanks :) | 03:29 |
Sundar | What should we do about https://review.opendev.org/#/c/675990/ ? | 03:29 |
Sundar | (That is Python 3. I jumped to a different topic.) | 03:30 |
Yumeng | and to all, please help to review and merge this bug fix https://review.opendev.org/#/c/675059/ | 03:31 |
s_shogo | That was included in the py3 patch. https://review.opendev.org/#/c/667524/ | 03:31 |
chenke | Ye. That was part of s_shogo's patch. | 03:31 |
Sundar | So, it should just be abandoned, I suppose. | 03:31 |
chenke | Agree | 03:32 |
s_shogo | Sundar: That's right. | 03:32 |
Sundar | Cool. | 03:32 |
Sundar | Yumeng, wangzhh: Re. https://review.opendev.org/#/c/675059/, Has GPU been tested with the nova-integ patches? | 03:32 |
Yumeng | I have tested with part of the nova-integ patches. | 03:35 |
wangzhh | Sorry, I don't have GPU env. But I think this part should be OK. Because there is little change this part. | 03:35 |
wangzhh | Yumeng, Great. | 03:35 |
Sundar | Ok. Has anybody launched a VM with real GPU attached? Oherise, how do we know it works? | 03:35 |
Sundar | *Otherwise | 03:35 |
Yumeng | wangzhh: yes a tiny fix. pls help to review \0/ | 03:36 |
*** shaohe_feng has joined #openstack-cyborg | 03:36 | |
shaohe_feng | hi all | 03:36 |
chenke | hi shaohe. | 03:37 |
Sundar | Hi shaohe_feng | 03:37 |
*** chunxiu has quit IRC | 03:37 | |
Sundar | To summarize the most important patches for this week: | 03:37 |
Sundar | Nova notification: https://review.opendev.org/674520 | 03:37 |
Sundar | Python 3: https://review.opendev.org/#/c/667524/ | 03:37 |
Sundar | Tempest: https://review.opendev.org/#/c/676665/ , https://review.opendev.org/#/c/667231/ | 03:37 |
Yumeng | Sundar: emmmm... I tested in a devstack env. not a real GPU env | 03:37 |
Sundar | Do we all agree that these are the important patches to merge this week? | 03:38 |
Yumeng | agreed' | 03:38 |
chenke | +1 | 03:39 |
chenke | Zhurong has some suggestions on Nova notification, but I suggest we merge this patch first, and then have time to modify it. | 03:40 |
Sundar | chenke: Totally agreed. Zhurong's point is important and I am working on it. | 03:40 |
Sundar | chenke: Thanks to you and zhurong for lots of active contribution! It'll be good to merge your patches by next week, IMHO, to help further development. | 03:40 |
Sundar | #topic AoB | 03:41 |
*** openstack changes topic to "AoB (Meeting topic: openstack-cyborg)" | 03:41 | |
Sundar | Anything else, folks? | 03:41 |
shaohe_feng | https://review.opendev.org/#/c/681005/ | 03:42 |
shaohe_feng | will be test on really evn today | 03:42 |
Sundar | Cool, thanks Shaohe. | 03:42 |
shaohe_feng | still some bug, I think it can works today. | 03:42 |
shaohe_feng | it is some complex. | 03:43 |
shaohe_feng | but it implemented as we discussion. | 03:43 |
shaohe_feng | welcome RFC. | 03:43 |
Sundar | Sure. All, please review and help merge the important patches above. Have a good day! | 03:44 |
wangzhh | Do we need to merge this patch before nova integrate? https://review.opendev.org/#/c/678177/ | 03:44 |
Sundar | wangzhh: Nova developers have not asked for that. They tend to take security for granted, so this may yet come up. It is important to merge that too. | 03:45 |
shaohe_feng | we need this patch, but maybe nova integrate does not need it . | 03:46 |
*** changzhi has quit IRC | 03:46 | |
wangzhh | FIne, so plz also help to review this patch. | 03:46 |
shaohe_feng | sure, | 03:46 |
Sundar | Sure, will do | 03:46 |
shaohe_feng | when is the dead line of async job? | 03:47 |
shaohe_feng | it it really not easy to test it on really env. | 03:47 |
shaohe_feng | too many steps | 03:48 |
Sundar | shaohe_feng: Given that this week is milestone 3, we have to see how things go from here. I agree with you. It is better to take time and ensure it works well. | 03:48 |
Sundar | It does not have to merge this week, if that makes you feel better :) | 03:49 |
shaohe_feng | OK, I will do my best to make it works well today. | 03:49 |
Sundar | Great. Thanks, shaohe_feng | 03:49 |
shaohe_feng | for tomorrow is our Moon festival | 03:49 |
Sundar | I see. Happy Moon festival to all of you! | 03:50 |
shaohe_feng | Thanks, | 03:50 |
Sundar | All right, see you all next week. Bye :) | 03:51 |
Sundar | #endmeeting | 03:51 |
*** openstack changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 03:51 | |
openstack | Meeting ended Thu Sep 12 03:51:09 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 03:51 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-12-03.04.html | 03:51 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-12-03.04.txt | 03:51 |
openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-12-03.04.log.html | 03:51 |
*** Sundar has quit IRC | 03:51 | |
*** chenke has quit IRC | 03:53 | |
*** s_shogo has left #openstack-cyborg | 04:10 | |
*** links has joined #openstack-cyborg | 04:34 | |
*** efried_zzz has quit IRC | 05:34 | |
*** TxGirlGeek has joined #openstack-cyborg | 06:15 | |
*** TxGirlGeek has quit IRC | 06:17 | |
openstackgerrit | YumengBao proposed openstack/cyborg master: add cyborg-tempest job and remove cyborg-devstack job https://review.opendev.org/676665 | 06:21 |
*** xinranwang has quit IRC | 07:56 | |
*** wangzhh has quit IRC | 08:03 | |
*** links has quit IRC | 08:18 | |
*** links has joined #openstack-cyborg | 08:20 | |
openstackgerrit | YumengBao proposed openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957 | 08:43 |
openstackgerrit | YumengBao proposed openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957 | 08:53 |
*** efried has joined #openstack-cyborg | 09:00 | |
*** FlorianFa has quit IRC | 09:13 | |
*** links has quit IRC | 09:40 | |
*** links has joined #openstack-cyborg | 09:46 | |
*** Yumeng has quit IRC | 09:47 | |
openstackgerrit | YumengBao proposed openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957 | 10:10 |
*** efried is now known as efried_afk | 13:36 | |
*** links has quit IRC | 14:24 | |
*** TxGirlGeek has joined #openstack-cyborg | 16:03 | |
*** efried_afk is now known as efried | 16:56 | |
openstackgerrit | Merged openstack/cyborg master: add cyborg-tempest job and remove cyborg-devstack job https://review.opendev.org/676665 | 18:45 |
*** TxGirlGeek has quit IRC | 19:17 | |
*** TxGirlGeek has joined #openstack-cyborg | 19:17 | |
*** TxGirlGeek has quit IRC | 19:27 | |
*** TxGirlGeek has joined #openstack-cyborg | 19:52 | |
*** TxGirlGeek has quit IRC | 19:54 | |
*** TxGirlGeek has joined #openstack-cyborg | 19:56 | |
*** TxGirlGeek has quit IRC | 20:45 | |
*** TxGirlGeek has joined #openstack-cyborg | 20:59 | |
*** dustinc has joined #openstack-cyborg | 21:23 | |
*** efried has quit IRC | 21:50 | |
*** efried has joined #openstack-cyborg | 21:52 | |
*** TxGirlGeek has quit IRC | 23:38 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!