| *** zhurong has quit IRC | 00:38 | |
| *** chenke has joined #openstack-cyborg | 01:14 | |
| *** zhurong has joined #openstack-cyborg | 01:21 | |
| *** s_shogo has joined #openstack-cyborg | 02:31 | |
| *** chunxiu has joined #openstack-cyborg | 02:51 | |
| *** Sundar has joined #openstack-cyborg | 02:55 | |
| *** xinranwang has joined #openstack-cyborg | 02:56 | |
| Sundar | Hi xinranwang | 03:01 |
|---|---|---|
| chenke | hello | 03:01 |
| Sundar | Hi chenke | 03:01 |
| Sundar | #startmeeting openstack-cyborg | 03:01 |
| xinranwang | Hi Sundar | 03:01 |
| openstack | Meeting started Thu Sep 5 03:01:40 2019 UTC and is due to finish in 60 minutes. The chair is Sundar. Information about MeetBot at http://wiki.debian.org/MeetBot. | 03:01 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 03:01 |
| *** openstack changes topic to " (Meeting topic: openstack-cyborg)" | 03:01 | |
| xinranwang | Hi chenke | 03:01 |
| openstack | The meeting name has been set to 'openstack_cyborg' | 03:01 |
| *** shaohe_feng has joined #openstack-cyborg | 03:01 | |
| Sundar | #topic Who's here | 03:01 |
| *** openstack changes topic to "Who's here (Meeting topic: openstack-cyborg)" | 03:01 | |
| Sundar | o/ | 03:02 |
| xinranwang | #info xinranwang | 03:02 |
| s_shogo | #info s_shogo | 03:02 |
| yikun | o/ | 03:02 |
| chenke | #info chenke | 03:02 |
| shaohe_feng | o/ | 03:02 |
| chenke | o/ | 03:02 |
| s_shogo | o/ | 03:02 |
| Sundar | Hi all | 03:02 |
| zhurong | \0/ | 03:02 |
| Sundar | zhurong: Welcome | 03:02 |
| Sundar | The main item on the agenda is, of course, the reviews | 03:03 |
| Sundar | Please focus on the P5-P9 patches. They and Nova notifn patch need to merge soon, before we get reviews of Nova patches. Also, they are needed for tempest to work, and that is a prereq too. | 03:04 |
| Sundar | yikun and all: Would you be able to review it? (Sorry for calling you out, yikun :)) | 03:05 |
| yikun | Sure, I will review it today | 03:05 |
| Sundar | Thanks :) | 03:05 |
| *** wangzhh has joined #openstack-cyborg | 03:06 | |
| yikun | and one detail question about db migrations on P5.5 | 03:06 |
| yikun | https://review.opendev.org/#/c/677115/12/cyborg/db/sqlalchemy/alembic/versions/c1b5abada09c_update_for_nova_integ.py | 03:06 |
| Sundar | We had a bit of a wrinkle on the Nova side too. The Cyborg's notification event would come too soon after we start the bind and would get lost. I think we have a way to solve it which (a) should hopefully be acceptable to Nova and (b) does not involve change to Nova objects or db | 03:06 |
| yikun | Can we append the change on existing migration script? | 03:06 |
| yikun | and most of other patches are okay to me | 03:07 |
| Sundar | yikun: There is one migration script for v2 API, so that we can show people exactly what we did. Once we releaseTrain, of course, previous migration scripts cannot be edited. | 03:08 |
| Sundar | As long as we don't change the migration script for Stein, I think we should be ok. Any concerns? | 03:08 |
| yikun | it will break upgrade from existing to now, but as you said if we still think the train relaase it's a start version, if other people have no question, I have no objection | 03:10 |
| Sundar | I understand the existing practice but (a) too many migration scripts slows down upgrade for operators and (b) it is good to show onw script for all v2 API IMHO. Thanks for your understanding. | 03:12 |
| wangzhh | Agree with yikun. It's better to append a migration script. And other patch is fine with me. | 03:12 |
| wangzhh | *patches are | 03:12 |
| Sundar | wangzhh: Given the reasons above, would you still ask for a separate migration script? | 03:13 |
| *** Coco_gao_ has joined #openstack-cyborg | 03:14 | |
| Coco_gao_ | #info Coco_gao | 03:14 |
| Sundar | Hi Coco_gao | 03:15 |
| Sundar | We are discussing the patch review | 03:15 |
| wangzhh | So, we 'll consider T as a start version? | 03:15 |
| Sundar | Stein is the starting version -- v1 API. We should not modify or change the Stein migration script. We introduced a new migration script in Train, for v2 API. Anything unrelated to it can be in a separate script. But, so far, everything we did has been for v2 and Nova integ, I think. | 03:17 |
| Sundar | From operators' point of view, the migration scripts that are part of a release should not be changed. Within a release, we usually introduce separate scripts for developers' convenience, I think. | 03:18 |
| wangzhh | Uh, Okay. I have no objection. | 03:19 |
| Sundar | Anyways, that is just my view. Thank you, wangzhh, yikun and all. | 03:19 |
| Sundar | Any other concerns or thoughts on P5-P9? | 03:19 |
| chenke | why are you put -2 on P5? | 03:21 |
| Sundar | chenke: It is only a procedure, so that the patch series does not merge piece by piece. Once we get +2 on all patches, I will remove -2, so that it will all merge together. Nova guys are following this practice for my patch series too: | 03:23 |
| Sundar | https://review.opendev.org/#/c/631242/ | 03:23 |
| Sundar | I should have done that right at the beginning. | 03:23 |
| Sundar | So, even P5 can be reviewed fully. | 03:24 |
| chenke | Okay. I understand it. | 03:24 |
| Sundar | Can we hope it to merge them by tomorrow? I don't want to rush you :) but till P5-P9 and notificaiton patch merge, we cannot even ask Nova folks for review | 03:25 |
| Sundar | And Sep 9 deadline is just few days away | 03:25 |
| wangzhh | One question: https://review.opendev.org/#/c/678177/1..2/cyborg/common/policy.py Related comment in this patch. I did't find program in update ARQ. | 03:26 |
| Sundar | update refers to bind/unbind here, and that would involve programming. | 03:28 |
| Sundar | Are you saying the term 'update' should be changed? | 03:28 |
| wangzhh | No. Just check if it is admin or not before program. As I replied. | 03:29 |
| Sundar | Hmm, it could be owner or admin, right? Whoever created the ARQ should be allowed to bind it, otherwise they should not be able to create it. | 03:30 |
| wangzhh | Yep. Owner or admin should be allowed to Bind and Unbind. But when involve programming, we should check if it is admin or not. | 03:32 |
| wangzhh | Only admin can program? Right? | 03:32 |
| Sundar | Binding involves programming for FPGAs. A tenant who has the privilege to create ARQs for an FPGA should also be able to program it, right? That's why I raised the question about 'create' privileges. | 03:33 |
| shaohe_feng | program had better have sudo privilege no node | 03:34 |
| Sundar | Yes, we do sudo fpgaconf today, and have a patch to move to oslo privsep. | 03:34 |
| shaohe_feng | s/no/on | 03:34 |
| shaohe_feng | yes. let's from simple | 03:34 |
| shaohe_feng | Firstly it can work. | 03:35 |
| shaohe_feng | and let nova can call cyborg | 03:35 |
| shaohe_feng | then improve cyborg | 03:35 |
| Sundar | wangzhh: I understand your concern. However, if only admins can create/bind ARQs for FPGAs, that will be very restrictive, right? | 03:35 |
| chenke | Yes. Firstly make it work. | 03:35 |
| wangzhh | Yep. Sundar. | 03:36 |
| wangzhh | So, Just make it work first. | 03:36 |
| Sundar | Ok, I agree with wangzhh that security is important and with others that we should first get it to work by Train-3. I'll bring RBAC on the agenda for the next IRC meeting. Hopefully, other things will be working by then. :) | 03:37 |
| wangzhh | Cool. | 03:37 |
| chenke | Agreee. | 03:37 |
| Sundar | #topic Python 3 | 03:37 |
| *** openstack changes topic to "Python 3 (Meeting topic: openstack-cyborg)" | 03:37 | |
| shaohe_feng | the admin or tenant own the bit steam image, can download the image and to do program. | 03:38 |
| Sundar | There is a Train goal to enable Py3 by Train-3 milestone, which is next week. Thanks to s_shogo (and Ikuo) for the patch. Hope we can merge that too by next week. | 03:38 |
| shaohe_feng | we should challenge the tenant | 03:39 |
| Sundar | shaohe_feng: Sure, let's take it up next week. | 03:39 |
| s_shogo | I'll check again that soon, after P5-P9 merged. (latest patch seems to be no problem) | 03:39 |
| Sundar | Thanks, s_shogo. | 03:40 |
| Sundar | #topic AoB | 03:40 |
| *** openstack changes topic to "AoB (Meeting topic: openstack-cyborg)" | 03:40 | |
| s_shogo | About cyborg client. | 03:41 |
| xinranwang | Hi all, I have to drop now. Thanks for your reviews for placement patch, it is merged finally :) And please review https://review.opendev.org/#/c/667231/ tempest code and notify patch https://review.opendev.org/#/c/674520/ too. | 03:41 |
| Sundar | Outside of patches and Py3, I don't have much for today. As i said, I think I have a way to avoid the race in Nova, and will work on getting it out. Anything else for today? | 03:41 |
| Sundar | s_shogo: Yes | 03:41 |
| Sundar | I saw your patch -- thanks. | 03:42 |
| s_shogo | I have posted a patch for OpenStack SDK, and request review to SDK team. https://review.opendev.org/#/c/679914/ | 03:42 |
| s_shogo | Subsequently ,I'll post cyborg-python client patch ,please review that > All | 03:42 |
| chenke | Cool. | 03:42 |
| Sundar | Great, sure, will do. | 03:42 |
| shaohe_feng | one thing. | 03:43 |
| shaohe_feng | we may start several asyn jobs | 03:43 |
| shaohe_feng | only all jobs are finished, the bind is successful | 03:44 |
| shaohe_feng | one of the jobs failed, then the bind should be failed | 03:44 |
| shaohe_feng | right? | 03:44 |
| Sundar | Yes. | 03:45 |
| shaohe_feng | so how to sync all the state of jobs? | 03:45 |
| Sundar | Wait for all of them to finish. I think eventlet has a wait() method, IIUC | 03:46 |
| shaohe_feng | yes. | 03:46 |
| shaohe_feng | but wait is block | 03:46 |
| shaohe_feng | so it can not in main thread. | 03:47 |
| shaohe_feng | also another, if one jobs failed, we should cancel others, right? | 03:47 |
| shaohe_feng | where should we put the wait? | 03:47 |
| Sundar | It can't be in main thread, I agree. We don't need to cancel the rest if one fails, at least in Train. As we discussed, if the job has already started flashing the card, we shouldn't cancel it then | 03:48 |
| Sundar | Just a thought: May be we have one eventlet whichis a master and it launches other eventlets, and the master does the wait. | 03:49 |
| shaohe_feng | yes, we need a such mechanism | 03:50 |
| shaohe_feng | I'm thinking it. | 03:50 |
| shaohe_feng | the master thread should not be from a thread pool, right? | 03:50 |
| shaohe_feng | for example, there a 2 pools. | 03:50 |
| Sundar | Sure. My suggestion is to do something super-simple for Train-3 milestone -- may be just one eventlet for all ARQs, because we won't have too many ARQs anyway | 03:51 |
| shaohe_feng | we create 2 jobs, so no pool for the master thread to monitor these 2 jobs. | 03:51 |
| Sundar | Simplcity and reliability are more important, IMHO. It will also reduce your work :) | 03:51 |
| shaohe_feng | yes, agree. | 03:52 |
| shaohe_feng | async is more complex than sync. | 03:52 |
| Sundar | Yes. IMHO, we can even leave unbind as sync in the worst case, for now, because we don't do anything there today | 03:53 |
| shaohe_feng | yes. agree | 03:53 |
| Sundar | We just want some patch in the works by Sep 3, so that we can kickstart the review | 03:53 |
| Sundar | I mean, Sep 9 | 03:54 |
| Sundar | Anything else, anybody? | 03:55 |
| chenke | No | 03:55 |
| Sundar | Cool. Thank you, all. Please review the patches. Have a good day! Bye. | 03:56 |
| Sundar | #endmeeting | 03:56 |
| *** openstack changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 03:56 | |
| openstack | Meeting ended Thu Sep 5 03:56:41 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 03:56 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-05-03.01.html | 03:56 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-05-03.01.txt | 03:56 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-05-03.01.log.html | 03:56 |
| wangzhh | Bye everyone. | 03:56 |
| s_shogo | Bye | 03:57 |
| *** s_shogo has quit IRC | 04:00 | |
| chenke | bye~ | 04:21 |
| *** tetsuro has joined #openstack-cyborg | 04:38 | |
| *** chunxiu has quit IRC | 04:48 | |
| *** tetsuro has quit IRC | 04:50 | |
| *** tetsuro has joined #openstack-cyborg | 04:52 | |
| *** Sundar has quit IRC | 05:13 | |
| *** shaohe_feng has quit IRC | 05:35 | |
| *** changzhi has joined #openstack-cyborg | 05:49 | |
| *** wangzhh has quit IRC | 06:05 | |
| *** links has joined #openstack-cyborg | 06:10 | |
| *** tetsuro has quit IRC | 06:22 | |
| *** zhurong has quit IRC | 06:37 | |
| *** openstackgerrit has quit IRC | 06:51 | |
| *** tetsuro has joined #openstack-cyborg | 06:55 | |
| *** tetsuro has quit IRC | 06:59 | |
| *** changzhi has quit IRC | 07:37 | |
| *** zhurong has joined #openstack-cyborg | 07:53 | |
| *** openstackgerrit has joined #openstack-cyborg | 08:20 | |
| openstackgerrit | pengyuesheng proposed openstack/cyborg master: Blacklist eventlet 0.25.0 https://review.opendev.org/680320 | 08:20 |
| openstackgerrit | zhurong proposed openstack/cyborg master: Fix placement report error in python3 https://review.opendev.org/680347 | 09:17 |
| openstackgerrit | pengyuesheng proposed openstack/cyborg master: Blacklist eventlet 0.23.0,0.25.0 https://review.opendev.org/680320 | 09:26 |
| *** Coco_gao_ has quit IRC | 09:35 | |
| *** tetsuro has joined #openstack-cyborg | 10:04 | |
| *** tetsuro has quit IRC | 10:08 | |
| *** tetsuro has joined #openstack-cyborg | 10:24 | |
| *** tetsuro has quit IRC | 11:07 | |
| *** chenke has quit IRC | 14:11 | |
| *** jraju__ has joined #openstack-cyborg | 14:30 | |
| *** links has quit IRC | 14:31 | |
| *** jraju__ has quit IRC | 14:35 | |
| *** links has joined #openstack-cyborg | 15:17 | |
| *** altlogbot_3 has quit IRC | 16:01 | |
| *** altlogbot_3 has joined #openstack-cyborg | 16:02 | |
| *** irclogbot_3 has quit IRC | 16:03 | |
| *** irclogbot_2 has joined #openstack-cyborg | 16:03 | |
| *** irclogbot_2 has quit IRC | 16:07 | |
| *** irclogbot_2 has joined #openstack-cyborg | 16:07 | |
| *** xinranwang has quit IRC | 16:15 | |
| *** links has quit IRC | 17:19 | |
| *** efried is now known as efried_afk | 18:52 | |
| *** efried_afk is now known as efried | 19:13 | |
| openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P5: Basic changes for API layer. https://review.opendev.org/670466 | 19:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P5.5: Additional changes to db layer. https://review.opendev.org/677115 | 19:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P6: Changes for device profiles. https://review.opendev.org/670467 | 19:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P7: Changes for ARQs and ExtARQs. https://review.opendev.org/670468 | 19:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P8: Changes for programming. https://review.opendev.org/670469 | 19:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P9: Enable v2 API in devstack. https://review.opendev.org/670470 | 19:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Notify Nova when binding finished https://review.opendev.org/674520 | 19:14 |
| *** efried is now known as efried_afk | 20:16 | |
| -openstackstatus- NOTICE: Gerrit is being restarted to pick up configuration changes. Should be quick. Sorry for the interruption. | 21:13 | |
| *** efried_afk is now known as efried | 21:58 | |
| openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Add driver_name to deployable reported by fake driver. https://review.opendev.org/680533 | 22:36 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!