*** zhipeng has joined #openstack-cyborg | 00:57 | |
*** s_shogo has joined #openstack-cyborg | 01:07 | |
openstackgerrit | Xinran WANG proposed openstack/cyborg master: Placement report https://review.opendev.org/659233 | 02:33 |
---|---|---|
Li_Liu | Sundar: please revert my change and I will submit a new patch. | 02:34 |
Li_Liu | sorry about the trouble I caused :P | 02:36 |
Li_Liu | Can we revert the Patch Sets? | 02:40 |
*** Sundar has joined #openstack-cyborg | 02:57 | |
*** Yumeng has joined #openstack-cyborg | 02:57 | |
*** wangzhh has joined #openstack-cyborg | 02:59 | |
Sundar | #startmeeting openstack-cyborg | 03:00 |
openstack | Meeting started Wed Aug 7 03:00:39 2019 UTC and is due to finish in 60 minutes. The chair is Sundar. Information about MeetBot at http://wiki.debian.org/MeetBot. | 03:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 03:00 |
*** openstack changes topic to " (Meeting topic: openstack-cyborg)" | 03:00 | |
openstack | The meeting name has been set to 'openstack_cyborg' | 03:00 |
yikun | o/ | 03:00 |
Sundar | #topic Roll call | 03:01 |
*** openstack changes topic to "Roll call (Meeting topic: openstack-cyborg)" | 03:01 | |
*** xinranwang has joined #openstack-cyborg | 03:01 | |
Sundar | Hi all | 03:01 |
yikun | hi Sundar | 03:01 |
xinranwang | Hi all | 03:01 |
s_shogo | Hi all | 03:01 |
Yumeng | #info Yumeng | 03:02 |
Sundar | #topic Agenda | 03:02 |
*** openstack changes topic to "Agenda (Meeting topic: openstack-cyborg)" | 03:02 | |
Sundar | https://wiki.openstack.org/wiki/Meetings/CyborgTeamMeeting#Agenda | 03:02 |
Li_Liu | #info Li_Liu | 03:02 |
xinranwang | #info xinranwang | 03:02 |
s_shogo | #info s_shogo | 03:02 |
wangzhh | Hi | 03:03 |
wangzhh | #info wangzhh | 03:03 |
Sundar | Hi all, quite a few things to discuss today. Do you have anything else to add? | 03:03 |
Sundar | Hi Li_Liu, your contribution of notification code is quite welcome. However, please check with the other contributor before overwriting their code. The patch https://review.opendev.org/#/c/631244/ has hit a merge conflict | 03:04 |
Li_Liu | sorry. I will pay attention next time | 03:06 |
Li_Liu | shall I submit a patch to revert it? | 03:07 |
Sundar | Also, as a contributor, it is good to be in communication with the team. Given the regulations in communication, that means mainly IRC meetings. | 03:07 |
Sundar | Apparently, many people are finding this time slot to be a conflict. Please bring that up and ask for a time change. We can work something out. | 03:07 |
Li_Liu | I will try to make more time for the team | 03:07 |
Sundar | Thanks, Li_Liu | 03:07 |
Li_Liu | So I will submit a patchset to revert my change | 03:08 |
Li_Liu | shall I ? | 03:08 |
Sundar | Yes, please | 03:09 |
Li_Liu | ok | 03:09 |
Sundar | Li_Liu, my suggestion is: given the very short time left, and time constraints on contributors, does it make sense for one of us to adopt the notification functionality with attribution to you? | 03:09 |
Li_Liu | sure | 03:09 |
Sundar | Though the Nova deadline is early Sep, we effectively need to finish in Aug to give time for other odds and ends | 03:09 |
Li_Liu | I guess xinran will work on it, right? | 03:10 |
xinranwang | I am working on cyborg side now. | 03:10 |
Sundar | I don't mean to step on your contribution. I am mostly concerned about the short time and making progress | 03:11 |
Li_Liu | totally understand | 03:11 |
Sundar | Li_Liu: we'll work something out. Your contributions and reviews are always welcome. | 03:11 |
Li_Liu | ok | 03:11 |
Sundar | Thanks very much, Li_Liu. | 03:12 |
Li_Liu | np | 03:13 |
Sundar | Folks, should we do a doodle pool to find another time for this IRC meeting, as it is a conflict for many people? | 03:13 |
xinranwang | agree | 03:13 |
Sundar | OK, will create one. Looks like only one day works: Thu morning China time | 03:14 |
Li_Liu | I reverted the change I did today. still have a conflict | 03:14 |
Li_Liu | might need to resolve the conflict manully | 03:15 |
Sundar | Ok | 03:16 |
Sundar | #topic bindep | 03:16 |
*** openstack changes topic to "bindep (Meeting topic: openstack-cyborg)" | 03:16 | |
yikun | https://review.opendev.org/#/c/674536/ | 03:16 |
yikun | Thanks, sundar | 03:16 |
yikun | ^ here is the bindep reltead patch | 03:17 |
Sundar | yikun has introduced the bindep patch: https://review.opendev.org/#/c/674536/ . It installs pciutils as a Cyborg dependency | 03:17 |
Sundar | Ah yes, thanks yikun | 03:17 |
Sundar | My question is: since it is really a dependency of the GPU driver, should we put that as a Cyborg dependency? | 03:18 |
yikun | My idea is that it's the special cmd which will be used by all generic pci device. | 03:18 |
yikun | so we need it | 03:18 |
xinranwang | will this depends on OS? | 03:19 |
Sundar | The operator may disable specific drivers, though. | 03:19 |
Sundar | xinranwang: Yes, the specific package may vary across distros. | 03:20 |
yikun | xinranwang: no, the general os (centos, ubuntu) has the same name | 03:20 |
yikun | https://github.com/openstack/zun/blob/master/bindep.txt#L40 | 03:20 |
yikun | acutually, the zun was also introduced it | 03:21 |
yikun | So, I think it's a better way | 03:21 |
Sundar | The package name may be common to Centos and Ubuntu. But do we know about others? | 03:21 |
xinranwang | why don't we read sysfs instead. like fpga driver did | 03:22 |
yikun | https://docs.openstack.org/infra/bindep/readme.html#examples | 03:22 |
yikun | xinranwang: not sure sysfs can be supported completely by other device. | 03:23 |
wangzhh | xinranwang, we can't find some pci device by sysfs. | 03:23 |
Sundar | wangzhh: We have /sys/bus/pci . I think you are saying that doesn't have all the info you need? | 03:24 |
xinranwang | as far as i know, the 'lspci' also read the sysfs. | 03:24 |
Yumeng | wangzhh: can we also find gpu device by sysfs ? | 03:24 |
wangzhh | Yep, Sundar, as far as i know, some info like manufacturer, read form another directory by lspci | 03:26 |
Sundar | I think the risk is low for pciutils, because it is pretty common. But this puts us on a slippery slope to other packages that may not be common. | 03:26 |
Sundar | As long as we examine each addition to bindep carefully, we should be ok, I think. | 03:27 |
wangzhh | Different os have differetnt dir. It's better to use a lib. Key point is | 03:28 |
Sundar | I have no objections to adding pciutils. Anybody thinks differently? | 03:28 |
wangzhh | Is pciutils populate? | 03:28 |
Sundar | wangzhh: are you asking if it is usually installed or populated? | 03:29 |
Sundar | Is everybody ok with adding pciutils? | 03:30 |
xinranwang | no objections | 03:31 |
wangzhh | I'm worried about there are few people maintain and use it? I'm not sure. | 03:31 |
yikun | wangzhh: lspci is contained by pcituils package | 03:32 |
Sundar | wangzhh: I think pciutils is a popular package, available in most common distros. exceptios may be some really tiny or embedded distros, but they will probably not be used in servers | 03:32 |
Sundar | *except | 03:33 |
wangzhh | Ok, fine. | 03:33 |
yikun | https://launchpad.net/ubuntu/+source/pciutils | 03:33 |
Yumeng | no objections +1 | 03:33 |
Sundar | #agreed Will adopt bindep approach with pciutils. | 03:34 |
Sundar | #topic New drivers in Train | 03:34 |
*** openstack changes topic to "New drivers in Train (Meeting topic: openstack-cyborg)" | 03:34 | |
Sundar | Glad to see many drivers getting proposed as patches | 03:34 |
Sundar | It may be a good idea to ask for a spec, stating he use cases, test plans and plans for CI, I think | 03:35 |
Sundar | Otherwise, it is not clear to the community what devices are involved and what testing needs to be done | 03:35 |
Sundar | The device hardware may not be available to other contributors. So, it is important to set up CI, I think | 03:36 |
Sundar | What do you all think? | 03:36 |
Sundar | wangzhh, yikun, Yumeng: ^ | 03:38 |
Sundar | for GPUs, Ascend, HPTS | 03:38 |
yikun | the ci support is a good idea, but I prefer we can start to make 3rd party ci support in next release. | 03:39 |
Sundar | yikun: Understand. But we should probably have some documentation on what is supported for each driver | 03:39 |
Sundar | For example, we may have some limitations or caveats for one driver but not others | 03:40 |
yikun | https://docs.openstack.org/cinder/rocky/reference/support-matrix.html | 03:41 |
yikun | I guess a page looks like it ^ | 03:41 |
Sundar | Good find :) | 03:41 |
wangzhh | Emm, agree. | 03:41 |
Sundar | I think we should require a spec before we agree to maintain the driver. The spec should describe the device, use cases, test plans and documentation plans. What do you all think? | 03:42 |
Sundar | For Train, though it is past Milestone 2, I think we can make an exception and accept specs even now. | 03:43 |
Sundar | wangzhh, Yumeng, yikun, Li_Liu, xinranwang, s_shogo: ^ | 03:45 |
Yumeng | ,Sundar, yikun,wangzhh: agree that we need to have some docs like https://docs.openstack.org/cinder/rocky/reference/support-matrix.html. | 03:45 |
Yumeng | Can we focus on the driver code/(make the function work) first and do the ci plans spec/support docs later ? | 03:45 |
wangzhh | I think this link is a good example. | 03:46 |
Yumeng | especially after we tested with some results | 03:46 |
Sundar | Apart from that doc, many projects require a spec before accepting a major feature. When somebody contributes a driver, we all agree to maintain that code. So, we need a spec to understand what we agree to. | 03:46 |
Sundar | Yumeng: CI plans can come later. But, without a spec, how do we know enough to maintain it? | 03:48 |
Sundar | Anybody disagree? or think we need exceptions for Train? | 03:50 |
Yumeng | emmm... I think driver maintainance is strongly related to the device, vendors should maintain their own and provide support for users to use.What do you think? | 03:51 |
yikun | Agree with yumen, the priority thing is make the driver work. | 03:54 |
yikun | https://docs.openstack.org/cinder/stein/drivers.html and here is also a example to show the driver support in every release | 03:55 |
Sundar | Yes, vendors would support their own drivers. When a driver is comitted to Cyborg repo, we agree to collectively maintain it. For example, for Python 3 migration, driver code can be changed by somebody other than the vendor, right? | 03:56 |
Sundar | Anyways, we can revisit this next meeting, because we are running out of time. | 03:57 |
Sundar | #topic Storyboard | 03:57 |
*** openstack changes topic to "Storyboard (Meeting topic: openstack-cyborg)" | 03:57 | |
Sundar | https://storyboard.openstack.org/#!/project/openstack/cyborg | 03:57 |
Sundar | There are lots of topics still open. Please go through it and take up what you can. | 03:58 |
Sundar | Some important things that we need to track: Python 3 migration, fake driver patch (https://review.opendev.org/665318) | 03:59 |
Sundar | testing to make sure that fake driver works with tempest CI (needed for Nova patch merging) | 03:59 |
Sundar | Anything else that we need to track in each meeting going forward? | 04:00 |
Yumeng | Sundar: I noticed lots of TODOs in dbapi such as https://github.com/openstack/cyborg/blob/master/cyborg/db/sqlalchemy/api.py#L567 | 04:01 |
xinranwang | please review the placement report part as well, it's also in critical path. | 04:02 |
xinranwang | https://review.opendev.org/#/c/659233/ | 04:02 |
Sundar | Yumeng: True, I was hoping to get to them after the patches merge. If some of you can take up some of those TODOs, that'll be great. | 04:02 |
Sundar | xinranwang: Yes. | 04:03 |
Sundar | OK, we are past the time. | 04:03 |
Yumeng | do you want to make them tested and work after V2 and nova-integ patches merged? or are there any other motivations? | 04:04 |
Yumeng | ok, we can continue in wechat | 04:04 |
Sundar | Yumeng: That's what I thought originally. But the basic db patch has already merged for Cyborg. So, we can start filing patches for db changes | 04:04 |
Yumeng | ok | 04:05 |
xinranwang | I have removed these exception in placement report patch. it can wirte the db correctly | 04:05 |
Yumeng | xinranwang:ok great! | 04:05 |
Sundar | I'll create storyboard tasks for these TODOs | 04:05 |
Sundar | Thanks, everybody. Have a good day or night, wherever you may be :) | 04:05 |
Sundar | #endmeeting | 04:06 |
*** openstack changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 04:06 | |
openstack | Meeting ended Wed Aug 7 04:06:02 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 04:06 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-08-07-03.00.html | 04:06 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-08-07-03.00.txt | 04:06 |
openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-08-07-03.00.log.html | 04:06 |
s_shogo | sorry , next week ( 8/10-19), we (NTT group) take a vacation on the whole. I'm afraid I will be absent from IRC chat and so on. | 04:06 |
s_shogo | and a small topic, but this affects all about py3 patch.Current zuul.yaml in py3 patch treats py3-test as "non-voting".Are there any problem in changing it to "voting" ? | 04:06 |
Sundar | s_shogo: NP. We should review your patch https://review.opendev.org/667524. But it says WIP. Will you update it further? | 04:07 |
Sundar | s_shogo: Py3 changes are still WIP. We should make it voting sometime later, may be in early Sep. What do you think? | 04:08 |
s_shogo | I'm waiting for finishment of merge P1-P9 patches , so I treat it as WIP.After that , I'll test them in local env again, and request review. | 04:08 |
Sundar | s_shogo: Got it, thanks. | 04:08 |
s_shogo | is ok treat as "voting" in Sep. I'll post that as patch in sep, again. | 04:09 |
s_shogo | NP. | 04:09 |
Sundar | Great | 04:09 |
s_shogo | ok, thanks. I'll prepare a wechat account in next time. | 04:12 |
*** s_shogo has quit IRC | 04:40 | |
*** links has joined #openstack-cyborg | 05:06 | |
Sundar | Li_Liu: In the IRC discussion today (http://eavesdrop.openstack.org/irclogs/%23openstack-cyborg/%23openstack-cyborg.2019-08-07.log.html#t2019-08-07T03:09:10), we had agreed that you would let somebody else take up the Nova notification functionality. | 05:49 |
Sundar | I asked Xinran. It is too late in the cycle to ask for another contributor from the community. So I'll do the part myself. Thanks for your understanding. Looking forward to further contributions from you whenever you have the time. | 05:52 |
*** wangzhh has quit IRC | 06:09 | |
*** xinranwang has quit IRC | 06:10 | |
*** Sundar has quit IRC | 06:29 | |
*** AJaeger has joined #openstack-cyborg | 06:35 | |
AJaeger | cyborg team, we moved api-ref documents, could you update a simple link, please? https://review.opendev.org/672771 | 06:36 |
Yumeng | Thanks Andreas! just +2 and W+1 | 06:49 |
AJaeger | thanks, Yumeng ! | 06:49 |
openstackgerrit | YumengBao proposed openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957 | 06:53 |
openstackgerrit | Merged openstack/python-cyborgclient master: Update api-ref location https://review.opendev.org/672771 | 06:58 |
*** AJaeger has left #openstack-cyborg | 07:00 | |
*** helenafm has joined #openstack-cyborg | 07:48 | |
*** links has quit IRC | 08:12 | |
*** links has joined #openstack-cyborg | 08:23 | |
openstackgerrit | Xinran WANG proposed openstack/cyborg master: Bug-fix in FPGA driver test case. https://review.opendev.org/675058 | 08:36 |
openstackgerrit | YumengBao proposed openstack/cyborg master: fix cannot load 'stub' error for gpu discover https://review.opendev.org/675059 | 08:44 |
*** Yumeng has quit IRC | 09:44 | |
*** helenafm has quit IRC | 10:29 | |
*** helenafm has joined #openstack-cyborg | 12:45 | |
*** links has quit IRC | 13:55 | |
*** altlogbot_3 has quit IRC | 14:46 | |
*** altlogbot_3 has joined #openstack-cyborg | 14:46 | |
*** helenafm has quit IRC | 15:45 | |
*** altlogbot_3 has quit IRC | 17:17 | |
*** altlogbot_0 has joined #openstack-cyborg | 17:22 | |
*** altlogbot_0 has quit IRC | 17:31 | |
*** altlogbot_3 has joined #openstack-cyborg | 17:34 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!