*** jaypipes has quit IRC | 00:15 | |
*** ikuo_o has joined #openstack-cyborg | 00:46 | |
*** zhurong has quit IRC | 01:04 | |
*** Sundar has joined #openstack-cyborg | 02:07 | |
Sundar | Specs to review by next Wednesday: https://review.opendev.org/658263, https://review.opendev.org/602978, https://review.opendev.org/605237 | 02:08 |
---|---|---|
*** Sundar has quit IRC | 02:44 | |
*** Sundar has joined #openstack-cyborg | 03:03 | |
Sundar | Yikun, could you join me on IRC? | 03:08 |
yikun | yep, I'm online | 03:10 |
yikun | FYI, here is why assert is not used in openstack. | 03:11 |
yikun | https://docs.openstack.org/bandit/latest/plugins/b101_assert_used.html | 03:11 |
yikun | I found this link when I review cinder code(https://review.opendev.org/#/c/663362), the team is try to clean all assert in cinder project. | 03:11 |
yikun | So, I think we should do right things in first place. | 03:11 |
yikun | Sundar: :), I'm here | 03:11 |
Sundar | Hi yikun, thanks for joining :) | 03:12 |
Sundar | We had a discussion today. For the Nova patches to merge, we need both a functional test in Nova that calls fake CYborg APIs *and* a tempest CI with a fake CYborg driver | 03:13 |
Sundar | XInran and Biwei are looking at the tempest CI in general | 03:13 |
Sundar | But the fake driver is lot like the generic driver -- I think | 03:14 |
Sundar | So, we were wondering if you could create a fake driver? | 03:14 |
Sundar | brb in 10 min | 03:18 |
yikun | Sure, but I'm not sure this fake driver looks like what? I can take this work, but I need some info from biwei or xinran | 03:23 |
Sundar | They had questions for me :) | 03:24 |
Sundar | OK, we need to figure out what this looks like | 03:24 |
Sundar | Do you know any of the tempest people? | 03:26 |
xinranwang | Actually, I don't understand why nova need fake driver test, they just wanna make sure that nova can call cyborg correctly and cyborg return the right data. It's all about API layer. | 03:28 |
yikun | No, I think maybe we can get some help from yumeng? | 03:28 |
xinranwang | Zhurong from ZTE have experience on tempest plugin. | 03:29 |
Sundar | xinranwang: Please see comments on line 409 in https://review.opendev.org/#/c/603955/13/specs/train/approved/nova-cyborg-interaction.rst,unified | 03:32 |
Sundar | yikun: Yumeng is on vacation till end June, IIRC | 03:32 |
Sundar | xinranwang: GTK. Can we contact that person or zhu.fanglei@zte.com.cn? | 03:33 |
xinranwang | According to Sean's comments, my understanding is, what nova required is still fake cyborg API, but for gate check, cyborg should have a fake driver to pass the tempest test. And there should be a test in tempest like test_boot_vm_with_accl. | 03:37 |
Sundar | Hmm, yes, so we need both, as per the comments. | 03:40 |
Sundar | xinranwang: ^ | 03:40 |
xinranwang | So no CI env need to be set up. Just code.(nova fixture, fake driver). Right? | 03:41 |
Sundar | Plus the tempest plugins for basic test cases which will call fake driver | 03:41 |
Sundar | We don't need the hardware-based CI, if that's what you mean | 03:42 |
Sundar | We do need a tempest CI env, which we are in the process of creating | 03:43 |
xinranwang | yes, sure. test_boot_vm_with_accl will be implemented in tempest plugin. I am working on this. | 03:44 |
xinranwang | But I will test it with real env. | 03:44 |
xinranwang | Hmmm, I think no need for tempest CI, we can use Zuul directly to run tempest. Just add a cyborg tempest plugin? what do you think? yikun | 03:47 |
*** links has joined #openstack-cyborg | 03:54 | |
*** ikuo_o has quit IRC | 03:55 | |
yikun | yes, I think functional test need fake cyborg api, and tempest only need a tempest plugin, but I don't know how this plugin work in a real env. | 03:58 |
*** ikuo_o has joined #openstack-cyborg | 03:58 | |
Sundar | yikun, xinwanwang: # openstack-qa is the IRC channel for tempest etc. We can ask there. | 04:01 |
Sundar | xinranwang: ^ | 04:02 |
xinranwang | OK | 04:04 |
Sundar | Please join that channel. I'll ask the question there, and you all can add/clarify | 04:05 |
xinranwang | I will go for lunch now. Will be back soon | 04:06 |
*** Sundar has quit IRC | 04:27 | |
*** jraju__ has joined #openstack-cyborg | 05:35 | |
*** links has quit IRC | 05:35 | |
*** links has joined #openstack-cyborg | 07:02 | |
*** jraju__ has quit IRC | 07:02 | |
*** links has quit IRC | 07:20 | |
*** links has joined #openstack-cyborg | 07:21 | |
*** links has quit IRC | 07:52 | |
*** links has joined #openstack-cyborg | 07:53 | |
*** helenafm has joined #openstack-cyborg | 08:19 | |
*** links has quit IRC | 08:30 | |
*** links has joined #openstack-cyborg | 08:32 | |
*** wangzhh has quit IRC | 09:30 | |
*** jaypipes has joined #openstack-cyborg | 12:01 | |
*** ikuo_o has quit IRC | 12:35 | |
*** links has quit IRC | 12:47 | |
*** Sundar has joined #openstack-cyborg | 13:34 | |
*** Sundar has quit IRC | 14:28 | |
*** helenafm has quit IRC | 16:01 | |
*** jaypipes has quit IRC | 23:33 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!