| *** tetsuro has joined #openstack-cyborg | 00:02 | |
| *** openstackgerrit has joined #openstack-cyborg | 01:20 | |
| openstackgerrit | Biwei Guo proposed openstack/cyborg master: Fix failures in v1 accelerator API, except patch. https://review.openstack.org/641184 | 01:20 |
|---|---|---|
| *** tetsuro has quit IRC | 01:32 | |
| *** Li_Liu has joined #openstack-cyborg | 02:55 | |
| *** xinranwang has joined #openstack-cyborg | 03:00 | |
| Li_Liu | Hi guys | 03:01 |
| Li_Liu | Let's wait for a few min | 03:01 |
| *** Yumeng_ has joined #openstack-cyborg | 03:03 | |
| *** Sundar has joined #openstack-cyborg | 03:04 | |
| Sundar | #info Sundar | 03:04 |
| Li_Liu | #startmeeting openstack-cyborg | 03:04 |
| openstack | Meeting started Wed Mar 6 03:04:34 2019 UTC and is due to finish in 60 minutes. The chair is Li_Liu. Information about MeetBot at http://wiki.debian.org/MeetBot. | 03:04 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 03:04 |
| *** openstack changes topic to " (Meeting topic: openstack-cyborg)" | 03:04 | |
| openstack | The meeting name has been set to 'openstack_cyborg' | 03:04 |
| Li_Liu | #topic Roll Call | 03:05 |
| *** openstack changes topic to "Roll Call (Meeting topic: openstack-cyborg)" | 03:05 | |
| Sundar | #info Sundar | 03:05 |
| Li_Liu | #info Li_Liu | 03:05 |
| xinranwang | #info xinranwang | 03:05 |
| Yumeng_ | #info Yumeng | 03:05 |
| Li_Liu | hmm | 03:05 |
| Li_Liu | let's wait for coco for a bit | 03:05 |
| Li_Liu | let me ping her on wechat | 03:05 |
| *** Coco_gao has joined #openstack-cyborg | 03:11 | |
| Coco_gao | Hi all | 03:11 |
| Sundar | Hi Coco_gao | 03:11 |
| Li_Liu | Hi Coco | 03:11 |
| Li_Liu | let's get started | 03:11 |
| Coco_gao | OK | 03:11 |
| Li_Liu | #topic Status Update | 03:11 |
| *** openstack changes topic to "Status Update (Meeting topic: openstack-cyborg)" | 03:11 | |
| Coco_gao | #info Coco_gao | 03:12 |
| Sundar | Have any of you tried to run https://review.openstack.org/#/c/640616/ ? I am getting an error | 03:12 |
| Sundar | ccess wasdenied; cyborg:deployable;create | 03:12 |
| Li_Liu | I tried .. it worked | 03:13 |
| Li_Liu | well, we will not merge it for now | 03:13 |
| Sundar | Apart from sourcing openrc as admin, did you do anything else? | 03:13 |
| Sundar | Li_Liu: the code looks good. I may be missing some step. | 03:13 |
| Li_Liu | let 's find out what I did | 03:14 |
| Coco_gao | I finished most of the functions, but not pass the test. So I still need some some to upload the diff code. | 03:14 |
| Coco_gao | some time | 03:14 |
| Li_Liu | Coco_gao, thanks for the update | 03:14 |
| Coco_gao | maybe today | 03:14 |
| Li_Liu | great | 03:14 |
| Li_Liu | xinranwang, how is the conductor part? | 03:15 |
| Coco_gao | I may not have enough time for the unittest | 03:15 |
| Li_Liu | Coco_gao, that's should be fine | 03:15 |
| Sundar | All: please review https://review.openstack.org/#/c/641184/ | 03:16 |
| xinranwang | After discussion, we found Coco and I have some duplicate work on conductor side, so I leave her some interfaces, and coco implement the diff code there | 03:16 |
| Coco_gao | xinran's code is depended on me, so I will help update her patch. The code is ready, just need some time for co-test. | 03:16 |
| Coco_gao | Hi Sundar, thanks for that patch | 03:18 |
| Sundar | Coco_gao: We'll fix the pep8 issues. But please see if this is how we want to fix and deprecate v1 API | 03:19 |
| Coco_gao | OK, after my code being merged. | 03:19 |
| Coco_gao | What's the deadline? | 03:19 |
| Sundar | We are just fixing the return value. We should also fix the documentation. Is anybody handling documentation now? | 03:19 |
| Sundar | Coco_gao: official deadline is March 8 for features. Bug fixes can go in after that too. | 03:21 |
| Yumeng_ | Sundar, I can do the doc update. | 03:21 |
| Sundar | Yumeng_: Thanks a lot | 03:21 |
| xinranwang | Li_Liu: Also, I have improve the fpga driver to match the newest DB design, I think we'd better have at least one driver works in this release. | 03:21 |
| xinranwang | here is the patch https://review.openstack.org/#/c/599960/ | 03:21 |
| Coco_gao | Sundar, after March 8, I can join for the doc. | 03:21 |
| Sundar | xinranwang: Rodrigo has a patch almost ready for OPAE-based driver | 03:22 |
| Coco_gao | xinranwang, Thank you. | 03:22 |
| xinranwang | Sundar: yes, but better to have one workable driver in this release. | 03:22 |
| Li_Liu | I am pulled into another meeting... might be delayed in response | 03:23 |
| Li_Liu | xinranwang, thanks a lot for the effort | 03:24 |
| zhipeng | Is zhenghao around ? | 03:25 |
| xinranwang | Li_Liu Coco_gao np, pls review it when you got time | 03:25 |
| zhipeng | Could we make the GPU driver as well ? | 03:25 |
| Coco_gao | I will contact zhenghao for that. | 03:25 |
| zhipeng | That'll be a dash for the weekend deadline | 03:26 |
| Coco_gao | I think that part won't change much, he had a old patch. | 03:27 |
| *** wangzhh has joined #openstack-cyborg | 03:29 | |
| Coco_gao | wangzhh | 03:29 |
| Coco_gao | we need you. | 03:30 |
| wangzhh | Hi Coco. | 03:30 |
| Coco_gao | Update the GPU driver | 03:30 |
| Coco_gao | 😁 | 03:30 |
| Coco_gao | FPGA driver is ready | 03:31 |
| wangzhh | No problem. But I don't have gpu device now. So Maybe I can just unit test. | 03:31 |
| zhipeng | wangzhh yep that should be fine | 03:33 |
| wangzhh | Anyway, I'll improve the gpu driver these days. | 03:33 |
| zhipeng | Plz do that before the S release cut | 03:33 |
| wangzhh | When? | 03:33 |
| Li_Liu | wangzhh, do you need help on that? | 03:34 |
| zhipeng | This weekend I think | 03:34 |
| zhipeng | Li should know the exact date | 03:34 |
| Li_Liu | Mar 04 - Mar 08R-5 Stein-3 milestone Feature freeze | 03:35 |
| Li_Liu | Mar 18 - Mar 22R-3 RC1 target week Hard StringFreeze | 03:35 |
| wangzhh | This work can't be split. And I think I can finish it in time. | 03:36 |
| zhipeng | Then we still have time to squeeze more stuff in lol | 03:36 |
| Coco_gao | 🤣 | 03:36 |
| Coco_gao | We still have time fix bug? | 03:37 |
| Li_Liu | My understanding is, we can at least merge the features first this week | 03:37 |
| wangzhh | And Li, what's the priority of deprecate api and new gpu driver ? | 03:37 |
| Li_Liu | and fix them for another week? | 03:37 |
| Coco_gao | That's good, cause I found some bugs and don't have time to fix right now. | 03:38 |
| zhipeng | I would caution deprecate anything before we have microversion in place | 03:39 |
| zhipeng | Bug fixes are needed ! | 03:39 |
| Coco_gao | Hi all, I have to drop off, pls help review my patches this two days for the emergency. | 03:40 |
| Coco_gao | these | 03:40 |
| Sundar | zhipeng: The accelerators table got removed, so the API for accelerators is effectively deprecated | 03:40 |
| Coco_gao | I will send my link in the wechat group. | 03:40 |
| Coco_gao | bye | 03:40 |
| zhipeng | Sundar is it possible to at least return error code for that api call now ? | 03:42 |
| zhipeng | I'm a little bit cagy about removing APIs | 03:43 |
| Sundar | zhipeng: with https://review.openstack.org/#/c/641184/, we treturn None or []. | 03:43 |
| wangzhh | In fact, we return None or [] now. | 03:43 |
| Sundar | We should also update docs, as wangzhh said | 03:43 |
| wangzhh | Yep. | 03:43 |
| Sundar | zhipeng: Totally understand your position. But, even if we put back the accelerator table, it will be useless as it doesn't get populated. | 03:44 |
| wangzhh | And I 'd like to add extra log info in these api. | 03:45 |
| wangzhh | *apis | 03:45 |
| Sundar | wangzhh: Could you elaborate? Do you want something in the returned value, or cyborg-api logs? | 03:46 |
| wangzhh | Not return value. It is cyborg-api logs. | 03:46 |
| Sundar | Sure | 03:47 |
| wangzhh | Anything else? | 03:51 |
| Sundar | We keep getting questions on docs | 03:52 |
| Li_Liu | I am still in another meeting >< | 03:52 |
| Sundar | We need to update docs for API etc. | 03:52 |
| Li_Liu | Sundar, we can do docs after the code freeze | 03:52 |
| Sundar | I haven't looked at it. But I think it can be done after March 8? | 03:52 |
| Li_Liu | yup | 03:52 |
| Sundar | Li_Liu: ok | 03:52 |
| yikun | sorry, for late, just want to sure should we deprecate cyborg v1 api in Stein release? | 03:53 |
| Sundar | yikun: No, we are not deprecating all v1 API. Only accelerator APIs | 03:54 |
| zhipeng | +1 | 03:54 |
| yikun | Sundar: OK, and accelerator will return None/[], right? | 03:54 |
| Sundar | yikun: Yes. Please review https://review.openstack.org/#/c/641184/ | 03:55 |
| wangzhh | Sundar, the deployable api does not work with new db schema. | 03:55 |
| yikun | Sundar: Cool, will do | 03:55 |
| Sundar | wangzhh: Li_Liu's patch fixes that | 03:55 |
| Sundar | ^ https://review.openstack.org/#/c/640616/ | 03:55 |
| zhipeng | Li is in internal meeting now, so he will response slowwww | 03:56 |
| zhipeng | OK any other matter we should take care for S ? | 03:57 |
| wangzhh | I saw it. But the defination of deployable is different, how to let others know? | 03:57 |
| Sundar | wangzhh: Who is using these APIs today? | 03:57 |
| Sundar | wangzhh: I see your point. Not sure how we do that without bumping versions | 03:58 |
| Sundar | zhipeng, all: is anybody using Cyborg APIs today? | 03:59 |
| wangzhh | I just know another lenovo guys use it. And even though nobody use it, but somebody know the original concept of deployable. | 04:00 |
| zhipeng | We have product development in progress now | 04:00 |
| wangzhh | We should let them know we had changed this part. | 04:00 |
| Sundar | wangzhh: Are you recommending moving to v2 in Stein? And deprecate v1? Then we will need v3 in Train | 04:01 |
| zhipeng | FWIW giving the time limit I would suggest postpone the version changes to T | 04:03 |
| wangzhh | Sure. I mean it's a long term work. We should maintain /v2/accelator, /v2/deployable, not mix v1/xxxx and /v2/xxx | 04:04 |
| wangzhh | in next version | 04:05 |
| Li_Liu | I think we still keep deployable v1 for now, but fix the part according to our new db change | 04:05 |
| Li_Liu | to make it compatible | 04:06 |
| zhipeng | +1 | 04:09 |
| wangzhh | All right. | 04:10 |
| Sundar | AT the PTG, let's talk about forming an API WG and a Documentation WG. | 04:11 |
| Sundar | I'll work on getting microversions in | 04:11 |
| wangzhh | Cool. | 04:11 |
| wangzhh | Do we have etherpad to record what to disscuss now? | 04:12 |
| zhipeng | So let's try to get the driver code in before s-3 | 04:12 |
| zhipeng | And bug fixes and doc fixes before RC1 | 04:12 |
| Sundar | wangzhh: Yes https://etherpad.openstack.org/p/cyborg-ptg-train | 04:13 |
| wangzhh | Sundar, Great. | 04:13 |
| wangzhh | zhipeng | 04:14 |
| wangzhh | Got it. | 04:14 |
| Sundar | zhipeng: +1 | 04:14 |
| wangzhh | Time for lunch, I'll drop off. | 04:16 |
| wangzhh | Bye :) | 04:16 |
| Sundar | AoB? | 04:17 |
| Li_Liu | #topic AoB | 04:17 |
| *** openstack changes topic to "AoB (Meeting topic: openstack-cyborg)" | 04:17 | |
| Li_Liu | out engineering sync is tomorrow right? | 04:17 |
| Sundar | Yes | 04:18 |
| Li_Liu | great, will further sync with you guys tomorrow then | 04:18 |
| Sundar | Bye! | 04:18 |
| Li_Liu | thanks guys, have a good day/night | 04:18 |
| *** Sundar has quit IRC | 04:18 | |
| Li_Liu | #endmeeting | 04:18 |
| *** openstack changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 04:18 | |
| openstack | Meeting ended Wed Mar 6 04:18:52 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 04:18 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-03-06-03.04.html | 04:18 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-03-06-03.04.txt | 04:18 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-03-06-03.04.log.html | 04:18 |
| *** Li_Liu has quit IRC | 04:19 | |
| *** tetsuro has joined #openstack-cyborg | 05:04 | |
| *** wangzhh has quit IRC | 06:19 | |
| *** Yumeng_ has quit IRC | 06:36 | |
| *** xinranwang has quit IRC | 08:17 | |
| *** Coco_gao has quit IRC | 08:20 | |
| *** helenafm has joined #openstack-cyborg | 08:24 | |
| *** tetsuro has quit IRC | 09:35 | |
| *** FlorianFa has quit IRC | 11:01 | |
| *** FlorianFa has joined #openstack-cyborg | 11:02 | |
| *** helenafm_ has joined #openstack-cyborg | 11:04 | |
| *** helenafm has quit IRC | 11:06 | |
| openstackgerrit | wangzhh proposed openstack/cyborg master: Add gpu driver https://review.openstack.org/574075 | 12:10 |
| openstackgerrit | wangzhh proposed openstack/cyborg master: Report data to conductor https://review.openstack.org/640615 | 12:12 |
| *** tetsuro has joined #openstack-cyborg | 12:31 | |
| *** tetsuro has quit IRC | 13:50 | |
| *** tetsuro has joined #openstack-cyborg | 13:51 | |
| openstackgerrit | wangzhh proposed openstack/cyborg master: Add gpu driver https://review.openstack.org/574075 | 13:54 |
| *** FlorianFa has quit IRC | 14:09 | |
| *** jaypipes has quit IRC | 14:14 | |
| *** jaypipes has joined #openstack-cyborg | 14:15 | |
| *** tetsuro has quit IRC | 14:34 | |
| *** helenafm_ has quit IRC | 17:34 | |
| *** edleafe_ has joined #openstack-cyborg | 18:10 | |
| *** irclogbot_0 has joined #openstack-cyborg | 18:12 | |
| *** dustinc_ has joined #openstack-cyborg | 18:26 | |
| *** irclogbot_0 has quit IRC | 18:36 | |
| openstackgerrit | Biwei Guo proposed openstack/cyborg master: Fix failures in v1 accelerator API, except patch. https://review.openstack.org/641184 | 18:39 |
| *** dustinc_ is now known as dustinc | 18:41 | |
| *** jaypipes has quit IRC | 18:44 | |
| *** irclogbot_0 has joined #openstack-cyborg | 21:09 | |
| *** irclogbot_0 has quit IRC | 21:28 | |
| *** dustinc has quit IRC | 21:46 | |
| *** dustinc has joined #openstack-cyborg | 21:47 | |
| *** dustinc has quit IRC | 21:48 | |
| *** dustinc has joined #openstack-cyborg | 21:48 | |
| *** dustinc_ has joined #openstack-cyborg | 21:50 | |
| *** dustinc has quit IRC | 21:50 | |
| *** dustinc_ has quit IRC | 21:50 | |
| *** dustinc has joined #openstack-cyborg | 21:50 | |
| *** irclogbot_0 has joined #openstack-cyborg | 21:51 | |
| *** irclogbot_0 has quit IRC | 21:56 | |
| *** irclogbot_0 has joined #openstack-cyborg | 22:20 | |
| *** irclogbot_0 has quit IRC | 22:34 | |
| *** irclogbot_0 has joined #openstack-cyborg | 22:36 | |
| *** irclogbot_0 has quit IRC | 22:44 | |
| *** dustinc has quit IRC | 23:04 | |
| *** dustinc has joined #openstack-cyborg | 23:07 | |
| *** dustinc has quit IRC | 23:12 | |
| *** dustinc has joined #openstack-cyborg | 23:23 | |
| *** dustinc has quit IRC | 23:25 | |
| *** dustinc has joined #openstack-cyborg | 23:26 | |
| *** dustinc has quit IRC | 23:26 | |
| *** dustinc has joined #openstack-cyborg | 23:26 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!