opendevreview | Michal Nasiadka proposed openstack/magnum-tempest-plugin master: WIP: k8s driver CI tests https://review.opendev.org/c/openstack/magnum-tempest-plugin/+/893131 | 03:42 |
---|---|---|
opendevreview | Michal Nasiadka proposed openstack/magnum-tempest-plugin master: WIP: k8s driver CI tests https://review.opendev.org/c/openstack/magnum-tempest-plugin/+/893131 | 04:05 |
opendevreview | Michal Nasiadka proposed openstack/magnum-tempest-plugin master: WIP: k8s driver CI tests https://review.opendev.org/c/openstack/magnum-tempest-plugin/+/893131 | 04:19 |
opendevreview | Michal Nasiadka proposed openstack/magnum master: devstack: Install sonobuoy binary https://review.opendev.org/c/openstack/magnum/+/893823 | 04:32 |
opendevreview | Michal Nasiadka proposed openstack/magnum master: devstack: Install sonobuoy binary https://review.opendev.org/c/openstack/magnum/+/893823 | 04:59 |
opendevreview | Michal Nasiadka proposed openstack/magnum-tempest-plugin master: WIP: k8s driver CI tests https://review.opendev.org/c/openstack/magnum-tempest-plugin/+/893131 | 05:19 |
opendevreview | Michal Nasiadka proposed openstack/magnum master: devstack: Install sonobuoy binary https://review.opendev.org/c/openstack/magnum/+/893823 | 05:20 |
opendevreview | Michal Nasiadka proposed openstack/magnum-tempest-plugin master: WIP: k8s driver CI tests https://review.opendev.org/c/openstack/magnum-tempest-plugin/+/893131 | 07:01 |
opendevreview | Michal Nasiadka proposed openstack/magnum-tempest-plugin master: WIP: k8s driver CI tests https://review.opendev.org/c/openstack/magnum-tempest-plugin/+/893131 | 07:59 |
opendevreview | Michal Nasiadka proposed openstack/magnum-tempest-plugin master: WIP: k8s driver CI tests https://review.opendev.org/c/openstack/magnum-tempest-plugin/+/893131 | 08:53 |
gbialas | Hi! | 09:02 |
mnasiadka | sorry, my meeting got longer than it should | 09:03 |
mnasiadka | dalees: are you around for the meeting? | 09:03 |
dalees | hi mnasiadka, I'm here | 09:03 |
mnasiadka | ok, so let's start | 09:03 |
mnasiadka | #startmeeting magnum | 09:03 |
opendevmeet | Meeting started Wed Sep 6 09:03:48 2023 UTC and is due to finish in 60 minutes. The chair is mnasiadka. Information about MeetBot at http://wiki.debian.org/MeetBot. | 09:03 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 09:03 |
opendevmeet | The meeting name has been set to 'magnum' | 09:03 |
mnasiadka | #topic rollcall | 09:03 |
mnasiadka | o/ | 09:03 |
dalees | o/ | 09:03 |
gbialas | o/ | 09:04 |
mnasiadka | #topic Secure RBAC | 09:04 |
mnasiadka | So, basically we've started to merge some of the rbac patches | 09:04 |
mnasiadka | Especially those in magnum-tempest-plugin | 09:04 |
mnasiadka | there are two that need second core | 09:05 |
mnasiadka | #link https://review.opendev.org/c/openstack/magnum-tempest-plugin/+/877086 | 09:05 |
mnasiadka | #link https://review.opendev.org/c/openstack/magnum-tempest-plugin/+/875322 | 09:05 |
mnasiadka | dalees: do you think you could have a look? | 09:05 |
dalees | I haven't looked at the RBAC change too deeply yet, but will try and spend some time | 09:06 |
mnasiadka | Actually the ones in openstack/magnum are merged | 09:06 |
mnasiadka | ricolin: if we need anything else merged for srbac - please shout | 09:06 |
dalees | yeah, i can look into these tempest ones | 09:07 |
mnasiadka | ok, let's move to next topic | 09:07 |
mnasiadka | #topic ClusterAPI | 09:07 |
mnasiadka | So, basically I think with the release calendar being as is now (so RC1 is close and then first week of Oct is the release day) | 09:07 |
mnasiadka | It might be very complicated to merge the CAPI driver changes | 09:07 |
mnasiadka | And we have some doubts on the direction of current patches + probably we'd need another round of discussions around this plus recognizing that the current patches are probably at least inspired by VexxHost driver | 09:08 |
mnasiadka | dalees: anything to add? | 09:08 |
dalees | No, not too much - but we do want to merge a CAPI driver next cycle. The functionality is too important | 09:10 |
mnasiadka | Yes, I agree - but let's do it right :) | 09:10 |
mnasiadka | ok, let's move into open discussion | 09:10 |
mnasiadka | #topic Open discussion | 09:10 |
mnasiadka | So, I have one point | 09:10 |
dalees | Yes, splitting the community on CAPI drivers isn't helpful and the path isn't clear yet. | 09:10 |
mnasiadka | the meetings on the https://meetings.opendev.org page show up as Container team meetings, and the url is to some really old logs | 09:11 |
mnasiadka | I'd like to fix that, so people have more clarity how to find the meeting date/logs | 09:11 |
mnasiadka | We have two options I guess - rename the Containers meeting to Magnum meeting and fix the link | 09:11 |
mnasiadka | or leave the meeting name as Containers and fix the link to point to Magnum | 09:12 |
mnasiadka | I think we'd need jakeyip to decide :) | 09:12 |
mnasiadka | so let's leave it for next meeting - but we should fix it | 09:12 |
dalees | Renaming to Magnum seems sensible, that's the commonly known product name | 09:12 |
mnasiadka | yeah, I'll consult with jakeyip later and do the needed changes | 09:12 |
mnasiadka | gbialas: you had something? | 09:13 |
gbialas | Yes, container team doesn't say much | 09:13 |
mnasiadka | so three votes for changing to Magnum :) | 09:13 |
gbialas | Yes. Deprecation of contianer_runtime default value | 09:13 |
mnasiadka | gbialas: can you link the current patch that jakeyip didn't like? | 09:14 |
gbialas | In short words: Change 'container_runtime' variable default to containerd, and deprecate 'host-docker'. From 1.24 dockershim is removed from k8s so host-docke dosn't make any sense | 09:14 |
gbialas | https://review.opendev.org/c/openstack/magnum/+/893378/1 | 09:14 |
mnasiadka | #link https://review.opendev.org/c/openstack/magnum/+/893378 | 09:15 |
mnasiadka | (so it renders in html properly in the logs) | 09:15 |
mnasiadka | So, we agreed to support Kubernetes 1.25+ in Bobcat in the driver | 09:15 |
mnasiadka | and drop support for older versions | 09:15 |
mnasiadka | I assume 1.25 does not support DockerShim anymore | 09:15 |
gbialas | Yes. | 09:15 |
mnasiadka | So we could change the default to containerd, and deprecate the whole variable (container_runtime) - to be dropped in C | 09:16 |
gbialas | That would be best outcome. | 09:16 |
mnasiadka | I understand the motivation that we didn't want to change defaults in the past, but with the current default - it's undeployable (you need to change to container) | 09:16 |
mnasiadka | dalees: opinions? | 09:16 |
dalees | so if old magnum templates exist that don't specify, changing a default may break them. This is the backwards compat problem, it's true with all labels sadly. | 09:16 |
dalees | we try and get around this by specifying all labels in magnum templates, it's a pain but less likely for breakages like this. | 09:17 |
dalees | having said that, i agree that having a default like docker doesn't make sense in 1.24+ if we don't install the out-of-tree dockershim | 09:17 |
mnasiadka | I'm not saying to backport the change of default, just change the default in Bobcat - that shouldn't break people that want to deploy 1.25+ when Bobcat is out | 09:18 |
mnasiadka | We just need proper release notes saying that please check your cluster template | 09:18 |
mnasiadka | (not counting the default kube_tag that we currently have, which does not help) | 09:19 |
gbialas | Also upgrading kube_tag and fedora image used to make tests to recent version would be useful. Ii docs we are still using Fedora 35 an 1.23 (in antelope) | 09:21 |
mnasiadka | I guess it would make sense to push that discussion to a time when jakeyip is around | 09:21 |
mnasiadka | And talk about how do make cluster templates without any labels work in Bobcat with some fresh kubernetes release | 09:21 |
mnasiadka | maybe we need to remove defaults at all for a cycle, and force people to set some of the labels mandatory | 09:22 |
dalees | yeah, the alternative to defaults is ignore them entirely and provide (quite large) magnum templates which specify known working labels for each k8s version. In this case it'd always be containerd. | 09:22 |
dalees | that's an interesting idea, mnasiadka. | 09:22 |
gbialas | Maybe each release we will ship just one version of key components which is proved to work, and use it as default. | 09:23 |
mnasiadka | gbialas: and warn users if they don't set these labels, it might break them after upgrading Magnum to a new OpenStack release | 09:23 |
dalees | anyway, mostly my point is that the defaults thing is a pain. Not that it shouldn't change. We just need to define a consistent policy and stick to it, letting deployers know it might break if they don't specify everything in their templates. | 09:23 |
mnasiadka | dalees: in other projects we state change of defaults in release notes, we could also add some warning in the docs | 09:24 |
mnasiadka | but I think we need some buy in from the PTL | 09:24 |
gbialas | Exactly. We can't keep backwards compatibility forever. k8s is droping something constantly | 09:24 |
dalees | i think it's worth a discussion | 09:25 |
gbialas | Yes. Happy to help with this (discussion and implementing) | 09:25 |
mnasiadka | Ok, this week is R-4, next week is RC1 week - we should decide on the meeting next week what is the approach we're taking - and implement it fast. | 09:26 |
mnasiadka | We should not be changing defaults after RC1 | 09:26 |
mnasiadka | Ok, anything else? Anybody? | 09:27 |
gbialas | Nothing from me. | 09:27 |
dalees | No other topics from me | 09:28 |
mnasiadka | mkjpryor: you're a bit late, we postponed the CAPI driver merging for C cycle - we need to sort out everything, ideally have another discussion with mnaser and jakeyip (he's not available today) | 09:28 |
mnasiadka | ok then, let's finish for today | 09:29 |
mnasiadka | thanks for coming :) | 09:29 |
mnasiadka | #endmeeting | 09:29 |
opendevmeet | Meeting ended Wed Sep 6 09:29:18 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 09:29 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/magnum/2023/magnum.2023-09-06-09.03.html | 09:29 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/magnum/2023/magnum.2023-09-06-09.03.txt | 09:29 |
opendevmeet | Log: https://meetings.opendev.org/meetings/magnum/2023/magnum.2023-09-06-09.03.log.html | 09:29 |
gbialas | Thanks! Have a nice day everyone! | 09:29 |
opendevreview | Tyler proposed openstack/magnum master: ClusterAPI: implement update_cluster_status https://review.opendev.org/c/openstack/magnum/+/851076 | 14:23 |
opendevreview | Tyler proposed openstack/magnum master: Implement cluster update for Cluster API driver https://review.opendev.org/c/openstack/magnum/+/880805 | 14:30 |
opendevreview | Tyler proposed openstack/magnum master: Cluster API: Implement upgrade to a new template https://review.opendev.org/c/openstack/magnum/+/884254 | 14:30 |
opendevreview | Tyler proposed openstack/magnum master: Cluster API: Support basic networking parameters https://review.opendev.org/c/openstack/magnum/+/884891 | 14:30 |
opendevreview | Tyler proposed openstack/magnum master: Add extra_network_name label https://review.opendev.org/c/openstack/magnum/+/893176 | 14:30 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!