| *** sapd1_x has joined #openstack-containers | 02:41 | |
| *** udesale has joined #openstack-containers | 03:33 | |
| *** ricolin has quit IRC | 03:41 | |
| *** udesale_ has joined #openstack-containers | 04:16 | |
| *** udesale has quit IRC | 04:18 | |
| *** ykarel|away is now known as ykare | 04:18 | |
| *** udesale_ has quit IRC | 05:13 | |
| *** udesale has joined #openstack-containers | 05:22 | |
| openstackgerrit | Feilong Wang proposed openstack/magnum master: [k8s] Add label 'master_lb_allowed_cidrs' https://review.opendev.org/715747 | 05:22 |
|---|---|---|
| *** ricolin has joined #openstack-containers | 05:39 | |
| *** udesale has quit IRC | 06:28 | |
| *** udesale has joined #openstack-containers | 06:30 | |
| *** belmoreira has joined #openstack-containers | 06:55 | |
| *** ttsiouts has joined #openstack-containers | 07:05 | |
| *** yolanda has joined #openstack-containers | 07:12 | |
| *** udesale_ has joined #openstack-containers | 07:25 | |
| *** udesale has quit IRC | 07:28 | |
| *** ttsiouts has quit IRC | 07:56 | |
| *** ttsiouts has joined #openstack-containers | 08:01 | |
| *** livelace has joined #openstack-containers | 08:50 | |
| *** ttsiouts has quit IRC | 09:01 | |
| *** ykare is now known as ykarel | 09:03 | |
| *** livelace has quit IRC | 09:11 | |
| *** kevinz has joined #openstack-containers | 09:11 | |
| *** belmoreira has quit IRC | 09:18 | |
| *** belmoreira has joined #openstack-containers | 09:26 | |
| *** ttsiouts has joined #openstack-containers | 09:35 | |
| *** rcernin has quit IRC | 09:39 | |
| *** ttsiouts has quit IRC | 09:40 | |
| *** threestrands has quit IRC | 09:41 | |
| *** ricolin_ has joined #openstack-containers | 09:44 | |
| *** ricolin_ has quit IRC | 10:21 | |
| *** ricolin_ has joined #openstack-containers | 10:22 | |
| *** rcernin has joined #openstack-containers | 10:22 | |
| *** ykarel is now known as ykarel|lunch | 10:23 | |
| *** ricolin_ has quit IRC | 10:31 | |
| *** ttsiouts has joined #openstack-containers | 10:34 | |
| *** ykarel|lunch is now known as ykarel | 11:08 | |
| *** ttsiouts has quit IRC | 11:13 | |
| *** ttsiouts has joined #openstack-containers | 11:16 | |
| ttsiouts | brtknr: Hey, are you around? | 11:19 |
| strigazi | ttsiouts: o/ | 11:21 |
| ttsiouts | strigazi: o/ | 11:21 |
| brtknr | its my day off so im in and out | 11:21 |
| ttsiouts | brtknr: do you have a few minutes to decide on the naming? | 11:22 |
| strigazi | brtknr: gerrit disagrees :) | 11:22 |
| ttsiouts | I wanted to fix the spec also | 11:22 |
| brtknr | haha sorry i was trying to catch up on upstream stuff | 11:24 |
| brtknr | im +2 for --merge-labels flag btw | 11:24 |
| ttsiouts | I think on the GET output we should keep on using the "labels_overridden" instead of "labels_merged" | 11:25 |
| strigazi | +1 ^^ | 11:25 |
| ttsiouts | and we need to have it as a dict in order to allow users/operators to see the overridden value without having to query the CT | 11:26 |
| strigazi | labels_overridden will be the ones changed right? | 11:26 |
| ttsiouts | strigazi: right | 11:26 |
| strigazi | +1 | 11:26 |
| ttsiouts | regarding the flag, I don't think that we should be that verbose and say --merge-labels=True | 11:27 |
| ttsiouts | this is why I added the store_true action, since this way, users can just specify --merge-labels | 11:27 |
| strigazi | +1 | 11:28 |
| strigazi | will it accept --merge-labels=False though? | 11:28 |
| ttsiouts | strigazi: no | 11:28 |
| ttsiouts | if you don't specify it defaults to False. | 11:29 |
| strigazi | i'm ok with --no-merge-labels | 11:29 |
| strigazi | if want to be able to send fale | 11:29 |
| strigazi | if want to be able to send false | 11:29 |
| ttsiouts | explicitly you mean? | 11:30 |
| strigazi | yes | 11:30 |
| strigazi | (if we want to do it) | 11:30 |
| ttsiouts | ok then it's better to go with --merge-labels=True/False | 11:30 |
| strigazi | is it? | 11:31 |
| strigazi | :) | 11:31 |
| ttsiouts | If we want to be verbose yes. | 11:31 |
| strigazi | I'm ok with having only --merge-labels and not be explict | 11:32 |
| *** livelace has joined #openstack-containers | 11:32 | |
| brtknr | > I think on the GET output we should keep on using the "labels_overridden" instead of "labels_merged" | 11:33 |
| brtknr | +1 | 11:33 |
| ttsiouts | brtknr: I wanted your opinion on the flag action | 11:33 |
| strigazi | https://git-scm.com/docs/git-format-patch the git cli use the --[no] patternt | 11:34 |
| ttsiouts | brtknr: should it just store True if specified or should the user specify --merge-labels=True/False? | 11:34 |
| ttsiouts | strigazi: I'm ok with it | 11:34 |
| strigazi | My order for preferce 1 is better than 1000: | 11:35 |
| strigazi | 1. only have --merge-labels and send don't send anything if not specified. | 11:36 |
| strigazi | 2. imlement mutual exclusive args: --merge-labels --no-merge-labels | 11:36 |
| strigazi | 1000: implement --merge-labels=True/False | 11:36 |
| brtknr | my pref is 1 | 11:37 |
| ttsiouts | cool this is what I also thought (and prefer) | 11:38 |
| ttsiouts | I mean 1 | 11:38 |
| strigazi | I'm ok to send False for the case of 1. too. | 11:38 |
| strigazi | (if not specifieed) | 11:39 |
| strigazi | (if not specified) | 11:39 |
| strigazi | which is the current logic for other booleans | 11:39 |
| *** k_mouza has joined #openstack-containers | 11:39 | |
| ttsiouts | the request will default to False either way, meaning that the field in the POST req will be false by default | 11:39 |
| ttsiouts | it's not as if we're not sending anything and we're waiting for the default behaviour to be specified by the API | 11:40 |
| strigazi | You mean it will send false, right? | 11:41 |
| ttsiouts | strigazi: yes | 11:41 |
| strigazi | +1 | 11:41 |
| ttsiouts | cool | 11:41 |
| brtknr | if we are implementing a cloud operator default, it would be good to have the option to override that from user cli but that can be done in a separate patch | 11:41 |
| ttsiouts | i'm ok with adding the --no-merge-labels flag if everyone's ok with it | 11:42 |
| strigazi | Better not do it ever. +1 To do it when (hopefully never) we implement it. | 11:42 |
| strigazi | The custom default ^^ | 11:43 |
| strigazi | So for this spec we have consensus? | 11:43 |
| ttsiouts | strigazi: +1 | 11:43 |
| brtknr | i believe so | 11:43 |
| brtknr | feilong might disagree | 11:44 |
| strigazi | For which part? | 11:44 |
| brtknr | he seemed to think we needed --merge-labels-enabled | 11:44 |
| brtknr | but merge is already a verb | 11:44 |
| brtknr | so no need to have enabled there too | 11:44 |
| strigazi | I think this is totally (the enabled part) | 11:44 |
| strigazi | "but merge is already a verb" +1 | 11:44 |
| ttsiouts | enabled does not seem right though in this case | 11:45 |
| ttsiouts | brtknr: +1 | 11:45 |
| strigazi | again: https://git-scm.com/docs/git-format-patch --ignore-if-in-upstream "Verb used in imperative" | 11:45 |
| strigazi | i have examples from git-commit too :) https://git-scm.com/docs/git-commit | 11:46 |
| ttsiouts | strigazi: +1 | 11:46 |
| ttsiouts | :) | 11:46 |
| brtknr | it should have been --enable-floating-ip --disable-floating-ip etc. | 11:47 |
| brtknr | but too late to change that now :) | 11:47 |
| strigazi | floating_ip_enabled is ok in the API and DB. merge-labels is smth that will happen in the API. It doesn't describe the state of the object. | 11:48 |
| ttsiouts | strigazi: exactly | 11:49 |
| strigazi | ttsiouts: brtknr: all good here? Shall I go for lunch? | 11:49 |
| ttsiouts | ok for me. | 11:49 |
| ttsiouts | thanks guys! | 11:50 |
| brtknr | ok enjoy your lunch | 11:50 |
| ttsiouts | brtknr: enjoy your day off :) | 11:50 |
| brtknr | thanks guys | 11:50 |
| brtknr | just eating some pastries in the sun :) you too | 11:50 |
| brtknr | ttsiouts: do you think labels_skipped should also be a dict | 11:54 |
| brtknr | otherwise the same argument stands: user would need to lookup CT to check what has been skipped | 11:54 |
| ttsiouts | brtknr: I'm ok with that | 11:56 |
| ttsiouts | brtknr: I'll update the patch to have labels_skipped as a dict and let's see what everyone thinks. | 11:57 |
| brtknr | +1 | 11:58 |
| *** k_mouza has quit IRC | 12:13 | |
| *** k_mouza has joined #openstack-containers | 12:22 | |
| *** yolanda has quit IRC | 12:44 | |
| *** yolanda has joined #openstack-containers | 12:44 | |
| *** livelace has quit IRC | 12:55 | |
| *** livelace has joined #openstack-containers | 13:06 | |
| *** ykarel is now known as ykarel|afk | 13:23 | |
| *** k_mouza has quit IRC | 14:09 | |
| *** k_mouza has joined #openstack-containers | 14:10 | |
| *** ttsiouts has quit IRC | 14:23 | |
| *** ttsiouts has joined #openstack-containers | 14:23 | |
| *** k_mouza has quit IRC | 14:24 | |
| *** ttsiouts has quit IRC | 14:28 | |
| *** ykarel|afk is now known as ykarel | 14:33 | |
| *** k_mouza has joined #openstack-containers | 15:05 | |
| *** sapd1_x has quit IRC | 15:15 | |
| *** udesale_ has quit IRC | 15:28 | |
| *** belmoreira has quit IRC | 15:45 | |
| *** k_mouza has quit IRC | 15:46 | |
| *** k_mouza has joined #openstack-containers | 15:50 | |
| *** k_mouza has quit IRC | 15:51 | |
| *** ttsiouts has joined #openstack-containers | 15:57 | |
| *** ykarel is now known as ykarel|away | 15:57 | |
| *** ttsiouts has quit IRC | 16:13 | |
| *** ttsiouts has joined #openstack-containers | 16:13 | |
| *** ttsiouts has quit IRC | 16:18 | |
| *** ttsiouts has joined #openstack-containers | 16:49 | |
| *** ttsiouts has quit IRC | 16:53 | |
| *** ttsiouts has joined #openstack-containers | 16:57 | |
| *** ttsiouts has quit IRC | 17:02 | |
| *** k_mouza has joined #openstack-containers | 17:51 | |
| *** k_mouza has quit IRC | 17:56 | |
| *** ttsiouts has joined #openstack-containers | 18:19 | |
| *** ttsiouts has quit IRC | 18:24 | |
| *** yolanda has quit IRC | 18:35 | |
| *** k_mouza has joined #openstack-containers | 18:52 | |
| *** k_mouza has quit IRC | 18:57 | |
| *** mgariepy has quit IRC | 20:12 | |
| *** KeithMnemonic has quit IRC | 21:01 | |
| *** bornie2bake has joined #openstack-containers | 22:03 | |
| *** bornie2bake has quit IRC | 22:37 | |
| *** livelace has quit IRC | 22:38 | |
| *** k_mouza has joined #openstack-containers | 22:53 | |
| *** k_mouza has quit IRC | 22:57 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!