| *** dave-mccowan has joined #openstack-containers | 00:04 | |
| *** hongbin has quit IRC | 00:06 | |
| *** sdake_ has quit IRC | 00:08 | |
| *** mrodriguez has quit IRC | 00:22 | |
| *** sdake has joined #openstack-containers | 00:25 | |
| *** dave-mccowan has quit IRC | 00:53 | |
| *** sdake has quit IRC | 01:44 | |
| *** sdake has joined #openstack-containers | 01:45 | |
| openstackgerrit | Feilong Wang proposed openstack/magnum master: [WIP] Support <cluster>/actions/resize API https://review.openstack.org/638572 | 02:01 |
|---|---|---|
| openstackgerrit | Feilong Wang proposed openstack/magnum master: [WIP] Support <cluster>/actions/resize API https://review.openstack.org/638572 | 02:08 |
| *** imdigitaljim has quit IRC | 02:09 | |
| *** _fragatina has quit IRC | 02:11 | |
| *** sdake has quit IRC | 02:32 | |
| *** sdake has joined #openstack-containers | 02:33 | |
| *** sdake has quit IRC | 02:38 | |
| *** sdake_ has joined #openstack-containers | 02:39 | |
| *** ArchiFleKs has quit IRC | 02:51 | |
| *** sdake_ has quit IRC | 03:03 | |
| *** ArchiFleKs has joined #openstack-containers | 03:08 | |
| *** sdake has joined #openstack-containers | 03:09 | |
| *** janki has joined #openstack-containers | 03:20 | |
| *** sdake has quit IRC | 03:33 | |
| openstackgerrit | Feilong Wang proposed openstack/magnum master: [WIP] Support <cluster>/actions/resize API https://review.openstack.org/638572 | 03:39 |
| *** _fragatina has joined #openstack-containers | 03:40 | |
| *** udesale has joined #openstack-containers | 03:53 | |
| *** _fragatina has quit IRC | 03:57 | |
| *** _fragatina has joined #openstack-containers | 03:57 | |
| openstackgerrit | Jake Yip proposed openstack/python-magnumclient master: python3 fixes https://review.openstack.org/638077 | 04:08 |
| *** ramishra has joined #openstack-containers | 04:48 | |
| *** lpetrut has joined #openstack-containers | 04:49 | |
| jakeyip | hey flwang I just found out that https://review.openstack.org/#/c/572897/ fails python3.7 tox due to async being a keyword. | 04:54 |
| jakeyip | not sure how to patch it if you want to retain compatibility with older clients. | 04:54 |
| *** _fragatina has quit IRC | 05:05 | |
| eandersson | jakeyip, the parameter async=None ? | 05:12 |
| jakeyip | yeap | 05:12 |
| eandersson | Yea that needs to be fixed :'( | 05:12 |
| jakeyip | upstream has fixed it https://github.com/kubernetes-client/python/commit/b10c7b6a175ab96291a6f74d68ea6027151f3b71 but I'm guessing flwang is keeping that parameter for backwards compatibility with older clients. | 05:15 |
| eandersson | jakeyip, those aren't even passed on? | 05:18 |
| eandersson | We can just add **kwargs at the end of call_api to handle backwards comp | 05:18 |
| jakeyip | yeah that could work. was wondering if he has something else in mind, or it was just a copy-pasta. the async/async_req is ignored anyway. can just let **kwargs handle them | 05:24 |
| *** lpetrut has quit IRC | 05:25 | |
| jakeyip | I think I could do this, wrote something running tox now. | 05:34 |
| jakeyip | btw @eandersson I wrote tests like you asked me to :P | 05:34 |
| openstackgerrit | Jake Yip proposed openstack/magnum master: Fix async reserved word in python3.7 https://review.openstack.org/638584 | 05:42 |
| *** lpetrut has joined #openstack-containers | 05:54 | |
| *** _fragatina has joined #openstack-containers | 06:07 | |
| *** _fragatina has quit IRC | 06:24 | |
| *** ykarel|pto has joined #openstack-containers | 06:38 | |
| *** ykarel|pto is now known as ykarel | 06:40 | |
| *** sdake has joined #openstack-containers | 06:59 | |
| *** ivve has joined #openstack-containers | 07:14 | |
| *** sdake has quit IRC | 07:33 | |
| *** ykarel is now known as ykarel|lunch | 07:46 | |
| eandersson | looks good jakeyip did you try with and without the patch to make sure the tests catch that? | 07:52 |
| *** belmoreira has quit IRC | 07:54 | |
| *** belmoreira has joined #openstack-containers | 08:05 | |
| *** ykarel|lunch is now known as ykarel | 08:10 | |
| *** sdake has joined #openstack-containers | 08:17 | |
| jakeyip | eandersson: yes test caught it. turns out the whole part of writing certs to config file wasn't being tested previously because tls_disabled = true in the test | 08:20 |
| *** alisanhaji has joined #openstack-containers | 08:25 | |
| *** ykarel is now known as ykarel|lunch | 08:59 | |
| *** sdake has quit IRC | 09:26 | |
| *** ivve has quit IRC | 09:34 | |
| *** ArchiFleKs has quit IRC | 09:37 | |
| *** ykarel|lunch is now known as ykarel | 09:41 | |
| openstackgerrit | Spyros Trigazis proposed openstack/magnum master: Add reno for flannle reboot fix https://review.openstack.org/638613 | 09:45 |
| *** ArchiFleKs has joined #openstack-containers | 09:48 | |
| *** alisanhaji has quit IRC | 10:05 | |
| openstackgerrit | Spyros Trigazis proposed openstack/magnum master: Add reno for flannel reboot fix https://review.openstack.org/638613 | 10:08 |
| *** alisanhaji has joined #openstack-containers | 10:16 | |
| openstackgerrit | Colleen Murphy proposed openstack/magnum-tempest-plugin master: Fix skipping of tests https://review.openstack.org/638619 | 10:19 |
| *** rcernin has quit IRC | 10:31 | |
| *** udesale has quit IRC | 10:59 | |
| *** sdake has joined #openstack-containers | 11:11 | |
| *** suanand has joined #openstack-containers | 11:13 | |
| openstackgerrit | Merged openstack/magnum stable/queens: Rename scripts https://review.openstack.org/631246 | 11:20 |
| *** janki has quit IRC | 12:01 | |
| *** sdake_ has joined #openstack-containers | 12:03 | |
| *** sdake has quit IRC | 12:03 | |
| *** _fragatina has joined #openstack-containers | 12:03 | |
| *** udesale has joined #openstack-containers | 12:16 | |
| *** suanand has quit IRC | 12:27 | |
| *** ivve has joined #openstack-containers | 12:35 | |
| *** dave-mccowan has joined #openstack-containers | 13:20 | |
| *** udesale has quit IRC | 13:25 | |
| *** jmlowe has quit IRC | 13:30 | |
| *** udesale has joined #openstack-containers | 13:41 | |
| *** dave-mccowan has quit IRC | 13:43 | |
| *** dioguerra has joined #openstack-containers | 13:43 | |
| *** ArchiFleKs has quit IRC | 13:46 | |
| *** ArchiFleKs has joined #openstack-containers | 13:49 | |
| *** sdake_ has quit IRC | 13:51 | |
| *** mrodriguez has joined #openstack-containers | 14:10 | |
| *** sdake has joined #openstack-containers | 14:17 | |
| *** alisanhaji has quit IRC | 14:24 | |
| *** alisanhaji has joined #openstack-containers | 14:29 | |
| *** dave-mccowan has joined #openstack-containers | 14:38 | |
| *** sdake has quit IRC | 14:43 | |
| *** sdake has joined #openstack-containers | 14:46 | |
| *** dioguerra has quit IRC | 14:49 | |
| *** hongbin has joined #openstack-containers | 14:54 | |
| *** jmlowe has joined #openstack-containers | 15:02 | |
| *** dioguerra has joined #openstack-containers | 15:03 | |
| *** ArchiFleKs has quit IRC | 15:09 | |
| *** ykarel is now known as ykarel|away | 15:10 | |
| *** ArchiFleKs has joined #openstack-containers | 15:10 | |
| *** udesale has quit IRC | 15:18 | |
| *** sdake has quit IRC | 15:21 | |
| *** sdake has joined #openstack-containers | 15:22 | |
| *** jmlowe has quit IRC | 15:49 | |
| *** ykarel|away has quit IRC | 15:55 | |
| *** flwang1 has joined #openstack-containers | 15:56 | |
| flwang1 | strigazi: around? | 15:56 |
| strigazi | flwang1: yes | 15:57 |
| flwang1 | strigazi: did you see the patch I proposed for resize? | 15:57 |
| strigazi | yes | 15:58 |
| strigazi | looks good | 15:58 |
| flwang1 | is that generally OK | 15:58 |
| flwang1 | cool | 15:58 |
| strigazi | right direction | 15:58 |
| strigazi | I left comments in the story | 15:58 |
| flwang1 | will your upgrade api be right for review this week? | 15:58 |
| strigazi | yes | 15:59 |
| strigazi | s/right/ready | 15:59 |
| flwang1 | sorry, typo, but you got my point ;) | 16:00 |
| flwang1 | i can't see your comments https://storyboard.openstack.org/#!/story/2005052 | 16:01 |
| strigazi | https://storyboard.openstack.org/#!/story/2005054 | 16:01 |
| flwang1 | ah, right | 16:01 |
| *** jmlowe has joined #openstack-containers | 16:02 | |
| flwang1 | thanks, there are several things i'd like to discuss | 16:04 |
| flwang1 | 1. PUT or PATCH | 16:04 |
| strigazi | PATCH | 16:04 |
| strigazi | put needs to creates something in the api | 16:04 |
| strigazi | put needs to create something in the api | 16:05 |
| flwang1 | but PATCH generally means you're updating an existing attribute | 16:05 |
| strigazi | node_count in our case | 16:05 |
| flwang1 | but it doesn't really matter, i don't have strong preference | 16:05 |
| flwang1 | 2. size/node_count | 16:06 |
| strigazi | we can go for node_count, size doesn't exist anywhere | 16:06 |
| flwang1 | do we need to have it? e.g. current node_count is 3, new node_count is also 3, but I'm give nodes_to_remove=['a'] | 16:07 |
| flwang1 | which for me, means i'd like to remove node 'a', but i would like to bring the node count back to 3, so it's like a replacement | 16:07 |
| strigazi | yes, it is like a replacement | 16:08 |
| *** belmoreira has quit IRC | 16:08 | |
| flwang1 | i'm not asking using 'size' or 'node_count', i'm asking how do we want to design this api | 16:08 |
| strigazi | go tit | 16:08 |
| strigazi | got it | 16:08 |
| strigazi | you described a corner case that node_count is the same | 16:09 |
| strigazi | In another case, current is 3 | 16:09 |
| strigazi | I want to drop nodeA and go to 5 | 16:09 |
| strigazi | I think it reasonable | 16:09 |
| strigazi | I think it is reasonable | 16:09 |
| flwang1 | but this is 'breaking' the api semantic a bit | 16:09 |
| strigazi | how? | 16:10 |
| flwang1 | same node_count | 16:10 |
| strigazi | that resize won't resize? | 16:10 |
| flwang1 | yep | 16:10 |
| flwang1 | 3->5, that's OK, but 3->3, hmm... | 16:10 |
| flwang1 | but personally, i like it | 16:10 |
| strigazi | that is true. What would you prefer? | 16:10 |
| strigazi | wait to go to 2 and then do another call to go to 3 again? | 16:11 |
| flwang1 | i think it could be a great feature, which make magnum api smart from some PoV | 16:11 |
| flwang1 | yep, that's another option | 16:11 |
| strigazi | on ther other hand, think this | 16:11 |
| strigazi | you say node_to_remove=nodeA and you do not pass node_count | 16:12 |
| strigazi | it will decrease to 2 | 16:12 |
| flwang1 | yes | 16:13 |
| strigazi | in the case of node_count 3 -> 3 , node_count acts as a desired node_count | 16:13 |
| strigazi | like in kubernetes | 16:13 |
| flwang1 | yes | 16:13 |
| flwang1 | that's my point | 16:13 |
| flwang1 | like declarative api | 16:14 |
| strigazi | 3->3 is less surpising | 16:14 |
| *** ykarel|away has joined #openstack-containers | 16:14 | |
| strigazi | for some maybe less, for others more, don't know | 16:14 |
| flwang1 | we just need good api document | 16:15 |
| strigazi | if something is similar to kubernetes, it might be better? :) | 16:15 |
| flwang1 | for people playing k8s, no surprise i think | 16:15 |
| flwang1 | true, that's my point | 16:15 |
| strigazi | magnum users are also kubernetes users, right? | 16:15 |
| strigazi | 95% :) | 16:16 |
| * strigazi will be right back | 16:16 | |
| flwang1 | ok | 16:17 |
| strigazi | back | 16:18 |
| strigazi | so sold, node_count=3 nodes_to_remove=a result 3 | 16:19 |
| strigazi | nodes_to_remove=a node_count not passed, result? | 16:20 |
| strigazi | flwang1: ^^ | 16:21 |
| flwang1 | deal, i will write a spec to document | 16:22 |
| flwang1 | btw, yesterday, i was testing the auto healing | 16:23 |
| flwang1 | using latest code of PR 1690 | 16:23 |
| strigazi | flwang1 node_count mandatory | 16:23 |
| flwang1 | in the CA's log, i can see CA is trying to delete minion0, but finally my minion1 is deleted, any thoughts? | 16:23 |
| strigazi | nodes_to_remove optional | 16:23 |
| flwang1 | though my heat is debug mode, i can't see the request body, so no clue now | 16:24 |
| strigazi | I know | 16:24 |
| strigazi | one sec | 16:24 |
| flwang1 | known issue? | 16:24 |
| strigazi | yes | 16:24 |
| flwang1 | oh....... | 16:24 |
| flwang1 | my toe | 16:24 |
| strigazi | https://github.com/openstack/magnum/commit/3ca2eb30369a00240a92c254c95bea6c7a60fee1 | 16:25 |
| strigazi | we need to make it {get_resource: kube-minion} | 16:25 |
| flwang1 | so that's the last comment you left on https://storyboard.openstack.org/#!/story/2005054 ? | 16:26 |
| strigazi | it is not exactly an issue | 16:26 |
| flwang1 | do you have a patch already? | 16:26 |
| strigazi | it is an issue if you use the heat-api | 16:26 |
| strigazi | no | 16:26 |
| flwang1 | yep, i'm using heat-api | 16:26 |
| flwang1 | btw, PR 1690 doesn't work for Heat Queens, which is a pain for us | 16:26 |
| strigazi | we can do this patch, {get_resource: kube-minion} | 16:27 |
| strigazi | and tell thomas to swicth to uuid | 16:27 |
| strigazi | not deletion by ip | 16:27 |
| flwang1 | strigazi: will it break the feature if we're using heat queens | 16:27 |
| strigazi | we can backport | 16:27 |
| strigazi | no? | 16:27 |
| flwang1 | my testing is based on nova UUID | 16:27 |
| flwang1 | btw, PR 1690 doesn't work for Heat Queens, which is a pain for us ---- this could be a gophercloud problem | 16:28 |
| strigazi | what doesn't work? | 16:28 |
| strigazi | the issue the deletes a different node? | 16:28 |
| strigazi | the issue that deletes a different node? | 16:28 |
| flwang1 | the request body CA sends to Heat Queens, will get 400 error | 16:28 |
| strigazi | we have heat queens as well | 16:29 |
| strigazi | and it works | 16:29 |
| flwang1 | it's weird | 16:29 |
| flwang1 | i tested on our production, it failed, then i tested it on devstack, and it 'worked', at least no 400 | 16:29 |
| strigazi | do you agree to do the change to uuid and backport? | 16:29 |
| flwang1 | strigazi: sure, any potential risk? | 16:30 |
| strigazi | two very low risks. I'll explain | 16:31 |
| flwang1 | ok | 16:32 |
| openstackgerrit | Feilong Wang proposed openstack/magnum master: [fedora_atomic] Support auto healing for k8s https://review.openstack.org/631378 | 16:33 |
| *** ricolin has joined #openstack-containers | 16:37 | |
| *** ricolin has quit IRC | 16:37 | |
| *** flwang1 has quit IRC | 16:41 | |
| *** itlinux has joined #openstack-containers | 16:47 | |
| *** flwang1 has joined #openstack-containers | 16:48 | |
| flwang1 | sorry, i lost connection | 16:49 |
| *** mgariepy has joined #openstack-containers | 16:53 | |
| strigazi | actually one risk, users that rely on the nested stack id for deleting nodes will have to start using the nodes uuid | 17:06 |
| strigazi | flwang1: only this issue ^^ | 17:06 |
| *** ykarel_ has joined #openstack-containers | 17:08 | |
| flwang1 | strigazi: but generally, our users won't talk to that api for deleting, right? | 17:09 |
| flwang1 | will it break your existing script or something? | 17:09 |
| strigazi | it won't beak something that we use | 17:10 |
| *** ykarel|away has quit IRC | 17:10 | |
| flwang1 | ok, then let's do it | 17:14 |
| strigazi | cool, anything else? I need to leave | 17:16 |
| *** flwang1 has quit IRC | 17:19 | |
| *** flwang1 has joined #openstack-containers | 17:22 | |
| *** cranges has joined #openstack-containers | 17:29 | |
| flwang1 | strigazi: no, all good | 17:37 |
| flwang1 | strigazi: i will propose the patch to speed it up | 17:37 |
| *** _fragatina has quit IRC | 17:42 | |
| *** jmlowe has quit IRC | 17:51 | |
| *** sdake has quit IRC | 17:54 | |
| *** sdake has joined #openstack-containers | 17:56 | |
| *** cranges has quit IRC | 18:00 | |
| *** dave-mccowan has quit IRC | 18:15 | |
| *** _fragatina has joined #openstack-containers | 18:32 | |
| eandersson | jakeyip, awesome | 18:38 |
| eandersson | great find | 18:38 |
| eandersson | I think strigazi was asking me about that a few weeks ago | 18:38 |
| *** ramishra has quit IRC | 18:40 | |
| *** lpetrut has quit IRC | 18:51 | |
| *** colby_ has quit IRC | 19:02 | |
| *** lpetrut has joined #openstack-containers | 19:07 | |
| *** ykarel_ is now known as ykarel | 19:28 | |
| *** sdake has quit IRC | 19:31 | |
| *** ykarel is now known as ykarel|away | 19:32 | |
| *** _fragatina has quit IRC | 19:41 | |
| *** itlinux has quit IRC | 19:41 | |
| *** dave-mccowan has joined #openstack-containers | 19:43 | |
| *** ykarel|away has quit IRC | 19:46 | |
| *** lpetrut has quit IRC | 20:08 | |
| *** itlinux has joined #openstack-containers | 20:25 | |
| *** alisanhaji has quit IRC | 20:32 | |
| *** itlinux has quit IRC | 20:51 | |
| *** itlinux has joined #openstack-containers | 21:01 | |
| *** itlinux has quit IRC | 21:02 | |
| *** itlinux has joined #openstack-containers | 21:13 | |
| *** henriqueof has quit IRC | 21:20 | |
| *** itlinux has quit IRC | 21:20 | |
| *** itlinux has joined #openstack-containers | 21:40 | |
| *** ivve has quit IRC | 21:47 | |
| *** dave-mccowan has quit IRC | 21:55 | |
| *** _fragatina has joined #openstack-containers | 22:21 | |
| *** spiette has quit IRC | 22:27 | |
| *** spiette has joined #openstack-containers | 22:31 | |
| *** sdake has joined #openstack-containers | 22:37 | |
| *** itlinux has quit IRC | 23:35 | |
| openstackgerrit | Feilong Wang proposed openstack/magnum master: [WIP] Support <cluster>/actions/resize API https://review.openstack.org/638572 | 23:52 |
| *** itlinux has joined #openstack-containers | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!